sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
b4c14261bb7d62b5a5a9da0128e67391a9017c41 | Robert Jackson | Robert Jackson | Merge pull request #12330 from nathanhammond/update-dag-map
Update dag-map. | merge pull request from nathanhammond/update-dag-map | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 10,900 |
57a8f43e3bb2907a8455e9751ecfd6f28833734f | Robert Jackson | Robert Jackson | Merge pull request #12213 from Kuzirashi/patch-1
[DOC release] Update ComputedProperty API docs | merge pull request from kuzirashi/patch-1 | 42 | true | false | 5 | true | false | false | emberjs | ember.js | 10,901 |
fe2c2aa35c6420ae6c9d09dec68e31ff4b266b87 | Nathan Hammond | Nathan Hammond | Update dag-map. | update dag-map | 14 | false | false | 2 | true | false | false | emberjs | ember.js | 10,902 |
ae297e6d8cea4913cabb1e561b2d2cba069f3d17 | Robert Jackson | Robert Jackson | Merge pull request #12311 from slindberg/ember-dev-update
Update ember-dev to enable warning helpers | merge pull request from slindberg/ember-dev-update | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 10,903 |
5ea23bb98fd12066e9d3a6019d4b2672f5f512d8 | Steven Lindberg | Steven Lindberg | Updated ember-dev bower SHA to latest
Adds `Ember.warn` helpers | updated ember-dev bower sha to latest | 37 | false | false | 6 | false | false | false | emberjs | ember.js | 10,904 |
c5774e3179db64a3cc1889e8a3f067eb8c31226d | Robert Jackson | Robert Jackson | Merge pull request #12323 from rwjblue/make-nested-paths-work-with-get-helper
[BUGFIX beta] Make `{{get something 'path.goes.here'}}` work. | merge pull request from rwjblue/make-nested-paths-work-with-get-helper | 71 | true | false | 5 | true | false | false | emberjs | ember.js | 10,905 |
4c124c3ca2a7a10c5d5ffcd83979ee4d9b659aaa | Robert Jackson | Robert Jackson | [BUGFIX beta] Make `{{get something 'path.goes.here'}}` work.
The `get` keyword should be roughly the same as `Ember.get`, but
previously we were asserting when the path included a `.`. This was most
likely because in the non-dynamic key case we were always using a
`KeyStream` instead of calling `source.get(newPath)` (a `KeyStream` will
assert when its path includes a `.` but `BasicStream#get` will
automatically create the correct stream for that path).
This removes the asserts, hard coded `KeyStream` usage, and adds a
number of tests for nested keys. | [bugfix beta] make `{{get something 'path.goes.here'}}` work | 60 | false | false | 7 | false | false | false | emberjs | ember.js | 10,906 |
c665584b90983ed5d3a079f372d3b7567ab98735 | Robert Jackson | Robert Jackson | Merge pull request #12318 from rwjblue/fix-attribute-bindings
Ensure attributeBindings work when legacy view addon is disabled. | merge pull request from rwjblue/fix-attribute-bindings | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 10,907 |
0f920a618ffb7d558cc773cb494e8375fc35a699 | Kuzirashi | Kuzirashi | [DOC release] Update ComputedProperty API docs | [doc release] update computedproperty api docs | 46 | false | false | 6 | false | false | false | emberjs | ember.js | 10,908 |
b60e201209cb0e60939457ad0062376dfaacaa32 | Robert Jackson | Robert Jackson | Remove unsupported global check for class bindings. | remove unsupported global check for class bindings | 50 | false | false | 7 | true | false | true | emberjs | ember.js | 10,909 |
d3e20d82ff1331f2a34edc622771a4f91e0f5b19 | Robert Jackson | Robert Jackson | Ensure attributeBindings work when legacy view addon is disabled.
When the `_Ember.ENV._LEGACY_VIEW_SUPPORT` flag is falsey, the `view`
stream is not setup as of 6963750. This resulted in anything added in
`attributeBindings` being `undefined` (because the attribute binding
system was essentially using `href=view.href` instead of
`href=this.href` or just `href=href`).
You might thing (as I did initially): "HOW CAN WE NOT HAVE A SINGLE TEST
THAT CHECKS FOR AN ATTRIBUTE VALUE?!?!?!?", and the answer is somewhat
more disconcerting. We currently run all tests with the legacy view and
controller flags set to `true`. :(
Future test refactoring efforts will be needed to fix that mistake. | ensure attributebindings work when legacy view addon is disabled | 64 | false | false | 9 | false | true | false | emberjs | ember.js | 10,910 |
a0acb068986b11a4da108127a64034dca16c1b4d | Robert Jackson | Robert Jackson | Merge pull request #12315 from vikram7/vr-add-array-copy-test
Adds test for Ember.copy on an array | merge pull request from vikram7/vr-add-array-copy-test | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 10,911 |
29f69a174af43a288d8b9c3a73d1e1af0df4ca5b | Robert Jackson | Robert Jackson | Merge pull request #12313 from thoov/docsUpdate
[DOC release] Making guidFor public | merge pull request from thoov/docsupdate | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 10,912 |
60597b38463cc35d3720c2eb0c43b1a3caf1e93f | Vikram Ramakrishnan | Vikram Ramakrishnan | adds test for Ember.copy on an array | adds test for ember.copy on an array | 36 | false | false | 7 | false | false | false | emberjs | ember.js | 10,913 |
deb1cb593bed208389fe2c63f3b719587369bb85 | Travis Hoover | Travis Hoover | [DOC release] Making guidFor public | [doc release] making guidfor public | 35 | false | false | 5 | false | false | false | emberjs | ember.js | 10,914 |
60ab02263bd33cbd53106933c4de0fabf9acdd03 | Stefan Penner | Stefan Penner | Merge pull request #12075 from runspired/event-runloop-fix
Don't spin up extra run-loops when bubbling events. Fixes #11540 | merge pull request from runspired/event-runloop-fix | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 10,915 |
eeca01ae4f2a2769950e2454bb4bf86ec2c250a9 | Stefan Penner | Stefan Penner | Merge pull request #12312 from emberjs/minor-doc-fix
Update API docs for `computed` | merge pull request from emberjs/minor-doc-fix | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 10,916 |
da7f6d5b2f5767e682b289997be3c2f4005ea3f3 | Edward Faulkner | Edward Faulkner | update API docs for `computed`
This example was showing the old-style computed property arguments,
which were deprecated before 2.0. | update api docs for `computed` | 30 | false | false | 5 | true | true | true | emberjs | ember.js | 10,917 |
2bca168034054eda8be220468740e38dda9b3d18 | Robert Jackson | Robert Jackson | Merge pull request #12309 from rwjblue/use-cache-for-tagname-operations
Use `Cache` for tagname operations. | merge pull request from rwjblue/use-cache-for-tagname-operations | 65 | true | false | 5 | true | false | false | emberjs | ember.js | 10,918 |
c1dd47a063d892327a352e7a763f9c8dd1375a11 | Robert Jackson | Robert Jackson | Use `Cache` for tagname operations.
* Avoid running a regexp match against the same string many times.
* Avoid searching the same string for a dash many times.
* Change `Cache` to use `new EmptyObject()` since we do not need
`delete` support, we don't need to force into "slow mode" | use `cache` for tagname operations | 34 | false | false | 5 | false | true | false | emberjs | ember.js | 10,919 |
0ff1f46ebda74da54d48f6e094a96bdcb8728a79 | Matthew Beale | Matthew Beale | Merge pull request #12260 from rwjblue/init-before-didReceiveAttrs
[BUGFIX release] Ensure `init` is completed before `didReceiveAttrs` fires. | merge pull request from rwjblue/init-before-didreceiveattrs | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 10,920 |
40e2b67b4264cb870bdd9c8764e8db79dba0d84c | Robert Jackson | Robert Jackson | Merge pull request #12301 from rwjblue/update-emberjs-build
Update emberjs-build to allow es6.classes transform. | merge pull request from rwjblue/update-emberjs-build | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 10,921 |
6606c33a6edfb9b239cb798e7fcd7fc217173142 | Robert Jackson | Robert Jackson | Update emberjs-build to allow es6.classes transform. | update emberjs-build to allow es6.classes transform | 51 | false | false | 6 | true | true | false | emberjs | ember.js | 10,922 |
57f84a958f56667fe23187a4bc4dc1e09326b1f9 | Robert Jackson | Robert Jackson | Merge pull request #12299 from rwjblue/make-layout-simple-prop
[BUGFIX beta] Avoid extra work for `Ember.Component#layout`. | merge pull request from rwjblue/make-layout-simple-prop | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 10,923 |
bceed2f103b2b79513ecf6a3b0f5d294bf16c35b | Robert Jackson | Robert Jackson | [BUGFIX beta] Avoid extra work for `Ember.Component#layout`.
---
Prior to this change, `layout` was a CP that did a few things:
* `get(this, 'layoutName')` (and if set `this.container.lookup`)
* `get(this, 'defaultLayout')`
After this change, `layout` is a simple property that avoids that extra
work.
---
Prior to this change, `defaultLayout` would actually override a layout
that came from the container, this was incorrect (literally the opposite
of what we wanted).
This corrects that logic, and ensures that we only attempt to use the
`layout` property if the layout was not found during the container
lookup (which properly mimics the behavior in 1.0 - 1.12 where `layout`
was injected into the component if a layout was found in the container). | [bugfix beta] avoid extra work for `ember.component#layout` | 59 | false | false | 7 | false | false | false | emberjs | ember.js | 10,924 |
57415d741a7753388e079c695747825e056d926e | Stefan Penner | Stefan Penner | Merge pull request #12235 from kwight/master
Correct the URL for running all unit tests in the browser. | merge pull request from kwight/master | 38 | true | false | 5 | true | false | false | emberjs | ember.js | 10,925 |
5f156d0a0ddc86a2152b900ecbf28e768e5e3ccf | Kirk Wight | Kirk Wight | Clarify that the unit tests being referred to are for the Ember package itself, and not for an Ember app (whose tests are usually found at http://localhost:4200/tests/). | 4200/tests/) | 12 | false | false | 1 | false | false | false | emberjs | ember.js | 10,926 |
1bed4a5a3c81a353fc38324c29770e5604ed6ad2 | Robert Jackson | Robert Jackson | Merge pull request #12278 from HipsterBrown/master
[DOC Release] Show args in Ember.observer example | merge pull request from hipsterbrown/master | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 10,927 |
c0708b761defb752bfc97dbea496edd046102969 | Robert Jackson | Robert Jackson | Merge pull request #12198 from nathanhammond/link-to-cleanup
[BUGFIX beta] Further cleanup of the link-to component. | merge pull request from nathanhammond/link-to-cleanup | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 10,928 |
db23f4397555bc40bb7ac7d18250805f2f42589e | Robert Jackson | Robert Jackson | Merge pull request #12297 from rwjblue/one-loop-during-create
[BUGFIX beta] Remove double loop over attrs to create a component. | merge pull request from rwjblue/one-loop-during-create | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 10,929 |
f4a3059e56de5207f9c6812ca948f0fc407b7c61 | Robert Jackson | Robert Jackson | [BUGFIX beta] Remove double loop over attrs to create a component.
Previously, we would loop over `attrs` and create additional objects for
each entry then subsequently merge that "snapshot" back into a target
object TWICE for initial render.
This updates to loop once over the attrs and do all the work needed in
that one pass. It also avoids allocating two temporary objects and the
extra `Object.assign` to merge them back into the target. | [bugfix beta] remove double loop over attrs to create a component | 65 | false | false | 11 | false | false | false | emberjs | ember.js | 10,930 |
f0bd8edcb96116646dacc94d5a095ec19aec6c09 | Robert Jackson | Robert Jackson | Merge pull request #12292 from rwjblue/seal-morphs
Add debugSeal to Morphs to ensure consistent shaping. | merge pull request from rwjblue/seal-morphs | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 10,931 |
a01c357cdeba3aa407bbbcc30a72fd1a4434ffe3 | Robert Jackson | Robert Jackson | Merge pull request #12294 from rwjblue/add-names-to-anon-functions-in-node-manager
Add names to anon functions in node managers. | merge pull request from rwjblue/add-names-to-anon-functions-in-node-manager | 76 | true | false | 5 | true | false | false | emberjs | ember.js | 10,932 |
cdc496a0fcc9a7cafc01eca7943b59ab59a42081 | Robert Jackson | Robert Jackson | Add names to anon functions in node managers.
This makes debugging and profiling a little bit easier (removing some
"anonymous functions" and replacing with useful names). | add names to anon functions in node managers | 44 | false | false | 8 | true | true | true | emberjs | ember.js | 10,933 |
f06f4aeb697edd11f4d3e446792ff7758ec843e2 | Robert Jackson | Robert Jackson | Add debugSeal to Morphs to ensure consistent shaping.
The `debugSeal` debug function is stripped in production builds so it
does not affect their performance, but using it in debug builds allows
us to ensure that the Morph's and AttrMorph's created by Ember are not
changing shape over time. | add debugseal to morphs to ensure consistent shaping | 52 | false | false | 8 | true | true | false | emberjs | ember.js | 10,934 |
eeb8ee905171483e47ace7786ffcf7e62d8ea985 | Robert Jackson | Robert Jackson | Merge pull request #12289 from rwjblue/update-state-getState
Component Performance Tweaks | merge pull request from rwjblue/update-state-getstate | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 10,935 |
f1bfa774b289ec32fb3613f9cbcb6398cf6919cb | Robert Jackson | Robert Jackson | Use `debugSeal` in debug builds to ensure `Stream` shape up. | use `debugseal` in debug builds to ensure `stream` shape up | 59 | false | false | 10 | false | true | false | emberjs | ember.js | 10,936 |
742cbaa9094361c7e9938bba969cbaf8be778853 | Robert Jackson | Robert Jackson | Use `undefined` for Scope initial values.
Also, ensure `EMPTY` has the same object shape as `Scope`. | use `undefined` for scope initial values | 40 | false | false | 6 | false | true | false | emberjs | ember.js | 10,937 |
6c5f87d61d1893654a1f28f0b25902c1c782311b | Robert Jackson | Robert Jackson | Underscore propagateAttrsToThis to make it clear its private. | underscore propagateattrstothis to make it clear its private | 60 | false | false | 8 | true | true | false | emberjs | ember.js | 10,938 |
d15e699c6da8db3fdbd78a7c1fcf7c1cfbdc029a | Robert Jackson | Robert Jackson | Update HTMLBars version.
https://github.com/tildeio/htmlbars/compare/v0.14.4...v0.14.5 | update htmlbars version | 23 | false | false | 3 | true | true | true | emberjs | ember.js | 10,939 |
6e6f1ad29727f8a57498dd06032be541b09e271d | Robert Jackson | Robert Jackson | Use `Morph#getState` instead of `Morph.state`.
This allows us to lazily create the state bucket for each morph, and
avoids creating a ton of extra objects that are unused. | use `morph#getstate` instead of `morph.state` | 45 | false | false | 5 | false | true | false | emberjs | ember.js | 10,940 |
43b39f8644c92a5346de9d4b294bb116ecf3ca4f | Yehuda Katz | Yehuda Katz | Tests pass! | tests pass! | 11 | false | false | 2 | false | false | false | emberjs | ember.js | 10,941 |
fb00bbcfbae52a20339e02522cd5bf7f8f2f95d1 | Yehuda Katz | Yehuda Katz | Guard view.* and controller.* | guard view.* and controller.* | 29 | false | false | 4 | false | false | false | emberjs | ember.js | 10,942 |
69637502435589fcfe063eaf0f21faf069f4a70d | Yehuda Katz | Yehuda Katz | Restructure streams to be more static | restructure streams to be more static | 37 | false | false | 6 | false | true | false | emberjs | ember.js | 10,943 |
87190229e133deab859fbc935e8241f8c667936d | Godfrey Chan | Yehuda Katz | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for using `Object.create` by often assuming we are
creating something more class-like and eventually blowing up methods
that use scopes.
Eventually, this scope refactoring will probably replace some of the
hooks in HTMLBars. | implement template scopes as classes | 36 | false | false | 5 | true | true | true | emberjs | ember.js | 10,944 |
87694af87d7decf2fcbc52d646138a2f7cfe4cdb | Godfrey Chan | Yehuda Katz | Remove most of AttrsProxy
Previously, we tried to restrict which attributes we set eagerly, and
clean up the rest using unknownProperty. However, over time, making that
work correctly has gotten more and more complicated, and the cost of the
laziness is more than the benefits.
This commit goes back to an eager setting strategy, eliminates
unknownProperty and the reliance on _internalDidReceiveAttrs. It leaves
a setter interceptor for propagating sets to mutable cells. | remove most of attrsproxy | 25 | false | false | 4 | true | true | true | emberjs | ember.js | 10,945 |
a3fb7a1dd8a449bd8a157821789a8641ca079434 | Robert Jackson | Robert Jackson | Merge pull request #12283 from emberjs/meta-refactor-3
Meta refactor part 3 | merge pull request from emberjs/meta-refactor-3 | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 10,946 |
41d0162fdca4d71212977b0337f47ac8afab5464 | Edward Faulkner | Edward Faulkner | fix hasDeps inheritance | fix hasdeps inheritance | 23 | false | false | 3 | true | true | true | emberjs | ember.js | 10,947 |
313f4dee168949d0ae2d630a87f893c61c85bb1a | Edward Faulkner | Edward Faulkner | Defend against mutation during iteration | defend against mutation during iteration | 40 | false | false | 5 | false | false | false | emberjs | ember.js | 10,948 |
b51a3b5f411132bee95c1fe4738c50c1c7d533cd | Edward Faulkner | Edward Faulkner | iterators to for-in loops
per @stefanpenner | iterators to for-in loops | 25 | false | false | 4 | false | false | false | emberjs | ember.js | 10,949 |
0b5081f783ce55fbf9c5202d72568555d4c79cb5 | Edward Faulkner | Edward Faulkner | Refactoring meta, part 2
This improves encapsulation of the inheritedMap and inheritedMapOfMaps
meta properties, and changes their internal implementations to avoid
Object.create and some potential shape de-opts.
I'm seeing single digit percentage improvement in initial render speed. | refactoring meta, part 2 | 24 | false | false | 4 | false | false | false | emberjs | ember.js | 10,950 |
fc00ef3d98aa13ddcfbbd9d3cde1eb82ec301826 | Robert Jackson | Robert Jackson | Merge pull request #12275 from rwjblue/revert-12177
Revert "Refactoring meta, part 2" from #12177 | merge pull request from rwjblue/revert-12177 | 45 | true | false | 5 | true | true | false | emberjs | ember.js | 10,951 |
642d8d1dd03cc66239c4fb81d51c1d5a8a02261e | Andrew Smith | Andrew Smith | [DOC release] Fix `action` helper event type example
The event types only work if they are camel cased | [doc release] fix `action` helper event type example | 52 | false | false | 8 | false | false | false | emberjs | ember.js | 10,952 |
18463f5771f2c2f1574b04077486dbd5ffa6e034 | Nick Hehr | Nick Hehr | [DOC Release] Show args in Ember.observer example | [doc release] show args in ember.observer example | 49 | false | false | 7 | false | false | false | emberjs | ember.js | 10,953 |
6640ab13d6671fe44ed82b02cc22f62bc7a2976a | Robert Jackson | Robert Jackson | Merge pull request #12276 from rwjblue/add-edge-testing
Add Microsoft Edge testing to SauceLabs config. | merge pull request from rwjblue/add-edge-testing | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 10,954 |
22178e3d16b4d91d55734c5813c0f0de2d0d4052 | Robert Jackson | Robert Jackson | Add Microsoft Edge testing to SauceLabs config. | add microsoft edge testing to saucelabs config | 46 | false | false | 7 | false | true | false | emberjs | ember.js | 10,955 |
ea1f42cd913a55d555f17803c1b5d5110f7c473f | Stefan Penner | Stefan Penner | Merge pull request #12274 from emberjs/rwjblue-patch-2
Remove work around for babel bug. | merge pull request from emberjs/rwjblue-patch-2 | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 10,956 |
4abb3077242322b27fadf25c154a5ec88550f165 | bmac | Robert Jackson | Failing tests for ArrayProxy#length cacheing issue
(cherry picked from commit 941f245efb5fe3e03e65636ba96a985fb169b86b) | failing tests for arrayproxy#length cacheing issue | 50 | false | false | 6 | false | false | false | emberjs | ember.js | 10,957 |
4a9b8b6fef7fefb7e7aefbfbeb6f6042a6dde981 | Robert Jackson | Robert Jackson | Revert "Refactoring meta, part 2"
This reverts commit b799c3b1f3138803f42662e66851142382603277. | revert "refactoring meta, part 2" | 33 | false | false | 5 | false | true | false | emberjs | ember.js | 10,958 |
e837d52744d18f6c629aea0e99da0154ff6609a0 | Robert Jackson | Robert Jackson | Revert "iterators to for-in loops"
This reverts commit 33d389aec617471fec62762de386c1fac87843d4. | revert "iterators to for-in loops" | 34 | false | false | 5 | false | true | false | emberjs | ember.js | 10,959 |
c3dd592c27ab4769be6b7a1f06d75b81b72296eb | Robert Jackson | Robert Jackson | Remove work around for babel bug. | remove work around for babel bug | 32 | false | false | 6 | true | true | true | emberjs | ember.js | 10,960 |
9302e0b7f39d0518e3c22fd8345d74f1c8967ff7 | Robert Jackson | Robert Jackson | Merge pull request #12269 from rwjblue/remove-unused-conditional-stream
Remove unused conditional stream. | merge pull request from rwjblue/remove-unused-conditional-stream | 65 | true | false | 5 | true | false | false | emberjs | ember.js | 10,961 |
e7620254a0320d97de393c26f71f2c5d418b696c | Robert Jackson | Robert Jackson | Merge pull request #12262 from xcambar/rsvp_circular_reference
Breaks circular references in rejected jqXhr promises | merge pull request from xcambar/rsvp_circular_reference | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 10,962 |
4f6bad238ed55252d44351c1e60196b981d86ad0 | Xavier Cambar | Xavier Cambar | Avoids circular reference with a non-enumerable property
Tests that errors can be serialized | avoids circular reference with a non-enumerable property | 56 | false | false | 7 | false | false | false | emberjs | ember.js | 10,963 |
6d66c6bc4a202f6f3469f6cee3e998504058a8c8 | Robert Jackson | Robert Jackson | Merge pull request #12272 from rwjblue/update-htmlbrs
Update HTMLBars to fix memory leak with {{each}} inside {{if}}. | merge pull request from rwjblue/update-htmlbrs | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 10,964 |
92646d4b784b233a65e09284c633ccf8fbda1046 | Robert Jackson | Robert Jackson | Add test to confirm {{each}} inside {{if}} is cleaned up. | add test to confirm {{each}} inside {{if}} is cleaned up | 56 | false | false | 10 | true | true | false | emberjs | ember.js | 10,965 |
37c70647bf5d293bc48c16e11ed7ce70a3457127 | Godfrey Chan | Robert Jackson | Move to new HTMLBars internal block API
(cherry picked from commit a4f017e78224f8f4ac62cea0bb40b15814398263) | move to new htmlbars internal block api | 39 | false | false | 7 | false | false | false | emberjs | ember.js | 10,966 |
2a44c09675932f2fc12152db3973e5b6ab1f29d3 | Robert Jackson | Robert Jackson | Update HTMLBars to v0.14.4. | update htmlbars to v0.14.4 | 26 | false | false | 4 | true | true | true | emberjs | ember.js | 10,967 |
62830c14ed3dfb9720fe1d903a4420c82599960b | Robert Jackson | Robert Jackson | Merge pull request #12270 from rwjblue/cleanup-legacy-makeViewHelper-remnants
[CLEANUP canary] Remove unused `isLegacyViewHelper` flag. | merge pull request from rwjblue/cleanup-legacy-makeviewhelper-remnants | 71 | true | false | 5 | true | false | false | emberjs | ember.js | 10,968 |
1087affc7dfd41d7834cd4b94a1efec3776bfb5b | Robert Jackson | Robert Jackson | [CLEANUP canary] Remove unused `isLegacyViewHelper` flag.
This was added to support `Ember.Handlebars.makeViewHelper` which was
removed leading up to Ember 2.0.0 so it is no longer needed. | [cleanup canary] remove unused `islegacyviewhelper` flag | 56 | false | false | 6 | false | false | false | emberjs | ember.js | 10,969 |
3439ccd2bfbe76cbddfd1416afbbec791f920a52 | Robert Jackson | Robert Jackson | Remove unused conditional stream. | remove unused conditional stream | 32 | false | false | 4 | true | true | true | emberjs | ember.js | 10,970 |
7315671950d245ebbc65129537d487e456121a7c | Robert Jackson | Robert Jackson | [BUGFIX release] Ensure `init` is completed before `didReceiveAttrs` fires.
Given the following example:
```javascript
export default Ember.Component.extend({
init() {
this._super(...arguments);
this.wasInitWithSomeThing = !!this.attrs.someThing;
},
didReceiveAttrs() {
this._super(...arguments);
if (this.wasInitWithSomeThing) {
// do custom logic based on being `init` with `someThing`
}
}
});
```
Currently, the `didReceiveAttrs` (and also `didInitAttrs`) is firing
from within the `this._super()` call in `init` (because we trigger these
hooks in `Ember.View`'s `init`). Which means that `didReceiveAttrs` can
not have access to things set in `init`.
This change allows us to avoid that circumstance, and ensure that `init`
is fully completed before `didReceiveAttrs` is fired and also ensures
taht `didReceiveAttrs`/`didInitAttrs` is still fired from within the
`constructor` before observation is started. | [bugfix release] ensure `init` is completed before `didreceiveattrs` fires | 74 | false | false | 9 | false | false | false | emberjs | ember.js | 10,971 |
4fbc27d83139a38d633d9a9481de94c3006d220e | Robert Jackson | Robert Jackson | Merge pull request #12247 from ef4/split-the-worlds
[BUGFIX canary] Trust Ember.set | merge pull request from ef4/split-the-worlds | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 10,972 |
46153b47b9416bd4a6305b53d58e6b303f793e3b | Martin Muñoz | Martin Muñoz | Merge pull request #12259 from quaertym/new-stream-util
Add new-stream util | merge pull request from quaertym/new-stream-util | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 10,973 |
c8c0fc88e9b04065addfcd45919867b7fcf99725 | Emre Unal | Emre Unal | Add new-stream util
Use new-stream util to remove duplication | add new-stream util | 19 | false | false | 3 | true | false | true | emberjs | ember.js | 10,974 |
0f6e7d8116118f66d51312772276623f38c2386f | Robert Jackson | Robert Jackson | Merge pull request #12256 from rwjblue/cleanup-concat-subscription
[BUGFIX release-1-13] Ensure concat streams unsubscribe properly. | merge pull request from rwjblue/cleanup-concat-subscription | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 10,975 |
dc4fbd9e5c7e1b84f2e9fb3d112bfd83f710ff1a | Robert Jackson | Robert Jackson | [BUGFIX release-1-13] Ensure concat streams unsubscribe properly.
The stream returned by `concat` should subscribe to any input
streams so that the "concat stream" is marked as dirty if any of
the input streams are dirtied. This is/was working properly.
Unfortunately, when `subscribe`ing directly as done in 1.13.0, the
subscriptions are never cleared if the "concat stream" is deactivated.
This means, that listeners build up over time and leak the "concat
streams" and the `KeyStream`'s / `ProxyStream`'s that are in use.
Using `stream.addDependency` instead of manually `subscribe`ing allows
the returned "concat stream" to properly remove subscribers when it is
deactivated. | [bugfix release-1-13] ensure concat streams unsubscribe properly | 64 | false | false | 7 | false | false | false | emberjs | ember.js | 10,976 |
bc84326936de4d7d3305a33017c84900e7905331 | Robert Jackson | Robert Jackson | Merge pull request #12253 from rwjblue/remove-superfluous-initializer
[BUGFIX beta] Remove superfluous initializer. | merge pull request from rwjblue/remove-superfluous-initializer | 63 | true | false | 5 | true | false | false | emberjs | ember.js | 10,977 |
a8cd4cbb02e1271850d427ea6d976b6244465fb0 | Robert Jackson | Robert Jackson | [BUGFIX beta] Remove superfluous initializer.
All of the work done by this initializer is already done in
`Ember.Application#buildRegistry`, and having the initializer AND the
`buildRegistry` do the same thing causes issues with `App.reset`. | [bugfix beta] remove superfluous initializer | 44 | false | false | 5 | false | false | false | emberjs | ember.js | 10,978 |
d2c7ab25d5665ae1a8e23dacc5dc76f187ca54fc | Christian Wesselhoeft | Christian Wesselhoeft | [DOC release] Mark enumerable methods as public | [doc release] mark enumerable methods as public | 47 | false | false | 7 | false | false | false | emberjs | ember.js | 10,979 |
c0c72266e22734e683e95f35d6b5dc7b19791c8f | Robert Jackson | Robert Jackson | Merge pull request #12248 from denisovlev/fix_typo
Fix typo in ember-metal/tests/main_test.js | merge pull request from denisovlev/fix_typo | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 10,980 |
5db9f43e9745e9324fcc71eadd1cc4a49329cbc4 | Denisov Lev | Denisov Lev | Fix typo | fix typo | 8 | false | false | 2 | false | true | false | emberjs | ember.js | 10,981 |
a2fc1eeec122b8eaa3fdc985877bb057b7017d05 | Edward Faulkner | Edward Faulkner | [BUGFIX canary] Trust Ember.set
This change eliminates unnecessary dirtying of proxy streams when the
source object is an Ember.Object. It results in significant re-render
performance improvement in certain scenarios, especially when people are
iterating over lists of Ember.Objects to render components with
expensive lifecycle hooks.
We already have a longstanding convention that people need to use `set`
to mutate Ember.Objects if they expect any observability, and as long as
people are using `set`, interior mutability will be captured by other
observers further downstream.
The same is not necessarily true for POJOs. We would like to allow
something conceptually like:
myComponent.set('thing', aPojo);
aPojo.deep.inside.here = 'newValue';
myComponent.notifyPropertyChange('thing');
to work correctly, such that the deep mutation gets noticed. Which is
why this change treats POJOs and Ember.Object's differently. | [bugfix canary] trust ember.set | 31 | false | false | 4 | false | false | false | emberjs | ember.js | 10,982 |
3e3427e556388f50b1d1f6a20307ce7986ecdfc8 | Robert Jackson | Robert Jackson | Merge pull request #12239 from jasonmit/patch-2
Removing @private from aliasMethod | merge pull request from jasonmit/patch-2 | 41 | true | false | 5 | true | false | false | emberjs | ember.js | 10,983 |
f60b3a6e368d3967219702e62f261ba3f579d7dc | Robert Jackson | Robert Jackson | Merge pull request #12241 from rwjblue/better-error-for-unknown-closure-actions
[BUGFIX beta] Provide a helpful error for undefined closure actions. | merge pull request from rwjblue/better-error-for-unknown-closure-actions | 73 | true | false | 5 | true | false | false | emberjs | ember.js | 10,984 |
eb019715ca4f5e250d45729ece98e62b3ba75c97 | Robert Jackson | Robert Jackson | [BUGFIX beta] Provide a helpful error for undefined closure actions.
In the following scenario:
```handlebars
{{#foo-bar blah=(action somethingThatIsUndefined)}}
Click Me!
{{/foo-bar}}
```
Previously, an error was only thrown when attempting to invoke
`this.attrs.blah()`. After this change a helpful error like the following
will be thrown:
```
An action could not be made for `somethingThatIsUndefined` in
< component object id>. Please confirm that you are using either
a quoted action name (i.e. `(action 'somethingThatIsUndefined')`)
or a function available in < component object id>.
``` | [bugfix beta] provide a helpful error for undefined closure actions | 67 | false | false | 10 | false | false | false | emberjs | ember.js | 10,985 |
37289016b88b9738b0b510f0165f7f55ad895317 | Jason Mitchell | Jason Mitchell | Marking aliasMethod as public | marking aliasmethod as public | 29 | false | false | 4 | false | false | false | emberjs | ember.js | 10,986 |
7d76ff78ffd6ae10d1849c5a23c33b1f63b0a247 | Robert Jackson | Robert Jackson | Merge pull request #12233 from rwjblue/remove-knownForType-usage
Remove knownForType usage for dashless helpers. | merge pull request from rwjblue/remove-knownfortype-usage | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 10,987 |
deb95805f14bae3e8feafe43693b17713f3d9cac | Kirk Wight | Kirk Wight | Correct the URL for running all unit tests in the browser. | correct the url for running all unit tests in the browser | 57 | false | false | 11 | true | true | false | emberjs | ember.js | 10,988 |
23888dac5efdb7fb043d9a1ee6560495d74ecef4 | Robert Jackson | Robert Jackson | Remove knownForType usage for dashless helpers.
`container.registry.has` is a fast check, and allows us to make this
PAYGO much better than iterating all modules up front. | remove knownfortype usage for dashless helpers | 46 | false | false | 6 | true | true | true | emberjs | ember.js | 10,989 |
dadb1dbc51d496f742b2ec8bc8a6f76145add3b2 | Robert Jackson | Robert Jackson | Merge pull request #12230 from rwjblue/remove-derequire
Update emberjs-build to remove need for derequire. | merge pull request from rwjblue/remove-derequire | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 10,990 |
5351b9458f306398f6168acaa6f5eafe7a0bce2b | Stefan Penner | Stefan Penner | Merge pull request #12232 from duggiefresh/cleanup-remove-ember-imports
[CLEANUP beta] Don't import entire `ember` module | merge pull request from duggiefresh/cleanup-remove-ember-imports | 65 | true | false | 5 | true | false | false | emberjs | ember.js | 10,991 |
61813a468caf6a1a000e371b7c56db7194c83a38 | Doug Yun | Doug Yun | [CLEANUP beta] Don't import entire `ember` module
* Removes `import 'ember'` from tests. :ice_cream: | [cleanup beta] don't import entire `ember` module | 49 | false | false | 7 | false | false | false | emberjs | ember.js | 10,992 |
0192fdb93500ef6b80ea8b8a11c818e9a6136525 | Robert Jackson | Robert Jackson | Update emberjs-build to remove need for derequire.
emberjs-build now uses a babel plugin to transform top level `define`
calls into `enifed` calls. This allows us to:
* keep dev builds closer to prod builds (by removing this specific
difference)
* shave another 3-5 seconds off of production builds.
```
% ember s -prod
Before:
initial build, cold boot: Build successful - 86282ms.
initial build, warm boot: Build successful - 19390ms.
After:
initial build, cold boot: Build successful - 61330ms.
initial build, warm boot: Build successful - 13912ms.
``` | update emberjs-build to remove need for derequire | 49 | false | false | 7 | true | true | true | emberjs | ember.js | 10,993 |
066d32c6e8607f6d9aac23673198c19fbfbc1858 | Martin Muñoz | Martin Muñoz | Merge pull request #12228 from rwjblue/remove-loader-resolve
Update emberjs-build to v0.3.5. | merge pull request from rwjblue/remove-loader-resolve | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 10,994 |
9869cc29c1e01b01a22f115fd1939e6ef18e7d67 | Robert Jackson | Robert Jackson | Update emberjs-build to remove use-strict-remover.
This has been implemented upstream as a custom babel plugin. | update emberjs-build to remove use-strict-remover | 49 | false | false | 5 | true | false | true | emberjs | ember.js | 10,995 |
ab3159a8359b2b703395436000424e269d5bded4 | Robert Jackson | Robert Jackson | Update emberjs-build to remove loader recursion.
Should help initial boot a tiny bit, but is less bytes either way
:smiley:. | update emberjs-build to remove loader recursion | 47 | false | false | 6 | true | true | true | emberjs | ember.js | 10,996 |
647c4e9e60b0f825a96033e6dc46cbedfc720ace | Alan | Alan | [DOC Release] Document `Ember.getWithDefault` | [doc release] document `ember.getwithdefault` | 45 | false | false | 4 | false | false | false | emberjs | ember.js | 10,997 |
ebd892c97d7afa802316facc8f6c4daff9f13d7b | Robert Jackson | Robert Jackson | Merge pull request #12226 from rwjblue/update-emberjs-build
Update emberjs-build to use persistent filter versions. | merge pull request from rwjblue/update-emberjs-build | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 10,998 |
26a6f0aebc5e04bd59f39f163a2b863466d382d6 | Robert Jackson | Robert Jackson | Refactor to ember-cli-build.js (avoids warning) | refactor to ember-cli-build.js (avoids warning) | 47 | false | false | 5 | false | false | false | emberjs | ember.js | 10,999 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.