sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
56ea37d4eea5bcc07ebd2b0aadfa144308f86406 | Robert Jackson | Robert Jackson | Add missing feature flag import statement.
This line was removed in a prior commit, but after the glimmer component
PR had already been rebased. | add missing feature flag import statement | 41 | false | false | 6 | false | false | false | emberjs | ember.js | 11,100 |
ae6c9e82b91fd5b695907e7b76c998a128a157d0 | Robert Jackson | Robert Jackson | Merge pull request #12011 from emberjs/glimmer-component
Glimmer component | merge pull request from emberjs/glimmer-component | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 11,101 |
295fa60d3dd704074b3f6214944dd848f97999b8 | Robert Jackson | Robert Jackson | Merge pull request #12128 from emberjs/fix-failing-node-tests
[BUGFIX beta] Run SSR tests only if feature flag enabled | merge pull request from emberjs/fix-failing-node-tests | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 11,102 |
ed54f6717353b9c22c0aa67a79a9cb3055fd2b77 | Robert Jackson | Robert Jackson | Add missing `id`'s to `Ember.warn` calls.
(cherry picked from commit 92ad367f552ff01193a8796fd116d862847ac381) | add missing `id`'s to `ember.warn` calls | 40 | false | false | 6 | false | true | false | emberjs | ember.js | 11,103 |
3ef05630791d4987dc6378af8b72e9adccbb3c44 | Robert Jackson | Robert Jackson | Ensure debug statements are available from ember-metal/core.
(cherry picked from commit ce43e1826d2f088073aad8c9554495cff4bb2afd) | ensure debug statements are available from ember-metal/core | 59 | false | false | 7 | false | false | false | emberjs | ember.js | 11,104 |
0db7ab3bc42f59eb369322c0206ee5e694e49fff | Tom Dale | Tom Dale | [BUGFIX beta] Run SSR tests only if feature flag enabled
This fixes a regression where the server-side rendering tests were
failing because the application-visit feature flag was stripped.
Now, rather than forcing it to be enabled, we only run the tests when
the feature is available. | [bugfix beta] run ssr tests only if feature flag enabled | 56 | false | false | 10 | false | false | false | emberjs | ember.js | 11,105 |
2232c8849684851cc9304b95e432300c9d5a2a1f | Robert Jackson | Robert Jackson | Post release version bump. | post release version bump | 25 | false | false | 4 | false | false | false | emberjs | ember.js | 11,106 |
762b3468730cfdf4c8d60fd21b3298bacbe78935 | Robert Jackson | Robert Jackson | Merge pull request #12120 from rwjblue/do-not-add-select-to-container
[BUGFIX release] Only add `view:select` for ember-legacy-views. | merge pull request from rwjblue/do-not-add-select-to-container | 63 | true | false | 5 | true | false | false | emberjs | ember.js | 11,107 |
1f098d5454313a4d3141bd98388aa6c7587c9134 | Robert Jackson | Robert Jackson | Merge pull request #12121 from rwjblue/fix-jshint-errors
Fix a few JSHint errors from main files. | merge pull request from rwjblue/fix-jshint-errors | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 11,108 |
f65de715e5cf7630316d5947c67a5217d4bbb487 | Robert Jackson | Robert Jackson | Merge pull request #12123 from morganick/fix-input-helper-docs
[DOC release] Making code example use event from example description | merge pull request from morganick/fix-input-helper-docs | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 11,109 |
621e0d5548dd3b21182bc274a9dbf9283482feae | Nick Morgan | Nick Morgan | Making code example use event from example description
Fixes #12122 | making code example use event from example description | 54 | false | false | 8 | false | false | false | emberjs | ember.js | 11,110 |
fc3618b43e47cb03697748b2c240807d0d96e069 | Robert Jackson | Robert Jackson | Merge pull request #12103 from codefox421/is-array
[BUGFIX release] Fix Ember.isArray export | merge pull request from codefox421/is-array | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 11,111 |
fa2724f0b593c10a26c89de600a41f0b7ae7af75 | Robert Jackson | Robert Jackson | Fix a few JSHint errors from main files. | fix a few jshint errors from main files | 39 | false | false | 8 | false | true | false | emberjs | ember.js | 11,112 |
047cfb1f6a997505e40abc4a7d1cf65d527fe00f | Robert Jackson | Robert Jackson | [BUGFIX release] Only add `view:select` for ember-legacy-views.
This causes some issues if you want to add a route named `select`
(because we clober `view:select`). | select` for ember-legacy-views | 30 | false | false | 3 | false | false | false | emberjs | ember.js | 11,113 |
647b84dc3819f4b1e48f1fa8b668a529992f9c4a | Robert Jackson | Robert Jackson | Add 2.1.0-beta.1 to CHANGELOG.
[ci skip] | add 2.1.0-beta.1 to changelog | 29 | false | false | 4 | true | true | true | emberjs | ember.js | 11,114 |
af32b76f38c6591290bc3f2eed0424b2588b0318 | Nick Iaconis | Nick Iaconis | [BUGFIX release] Fix isArray export | [bugfix release] fix isarray export | 35 | false | false | 5 | false | false | false | emberjs | ember.js | 11,115 |
d34aaed42c7471744254eafdedeb5c8e3e077d2b | Robert Jackson | Robert Jackson | Add 1.13.0 - 1.13.8 + 2.0.0 to CHANGELOG.md.
[ci skip] | add 1.13.0 - 1.13.8 + 2.0.0 to changelog.md | 43 | false | false | 8 | true | true | true | emberjs | ember.js | 11,116 |
16eb4f803ca751c1f869f2c1e7e2c9b7ae79a7e6 | Sean W. Richardson | Robert Jackson | Seperate instanceInitializer into its own section.
(cherry picked from commit f38acb3b339d3009acc7e9518e52f3b56d8f6724)
(cherry picked from commit 7fc8118eb89277411f72148b6735ea254b3fcd47) | seperate instanceinitializer into its own section | 49 | false | false | 6 | true | true | true | emberjs | ember.js | 11,117 |
a36b677cfa9c646144c2ecf319cf4d9fcbeeed84 | Robert Jackson | Robert Jackson | Merge pull request #12118 from rwjblue/remove-core-outlet-feature
[FEATURE ember-routing-core-outlet] Remove feature. | merge pull request from rwjblue/remove-core-outlet-feature | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 11,118 |
2a65aa87dd5d0e4303c05450873713ed8b1dc8c2 | Robert Jackson | Robert Jackson | Merge pull request #12117 from rwjblue/enable-container-reform
[FEATURE ember-registry-container-reform] Enable by default. | merge pull request from rwjblue/enable-container-reform | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 11,119 |
0172338ca9b0fccfe4f216d3f69caeb9b76936c6 | Robert Jackson | Robert Jackson | [FEATURE ember-routing-core-outlet] Remove feature.
This is no longer in use by liquid-fire, removing... | [feature ember-routing-core-outlet] remove feature | 50 | false | false | 4 | false | false | false | emberjs | ember.js | 11,120 |
6bcfd6c5fa02f642c98bd4a49c704d1f9be324af | Robert Jackson | Robert Jackson | [FEATURE ember-registry-contianer-reform] Enable by default. | [feature ember-registry-contianer-reform] enable by default | 59 | false | false | 5 | false | false | false | emberjs | ember.js | 11,121 |
5117b62a1150a30bc6e8f58d683a55cf1935df7d | Robert Jackson | Robert Jackson | [FEATURE ember-registry-container-reform] Underscore private methods. | [feature ember-registry-container-reform] underscore private methods | 68 | false | false | 5 | false | false | false | emberjs | ember.js | 11,122 |
7cee520eab4762f59a5ff338c4f507f25b861cda | Robert Jackson | Robert Jackson | Merge pull request #12116 from rwjblue/enable-debug-handlers-feature
[FEATURE ember-debug-handlers] Enable by default. | merge pull request from rwjblue/enable-debug-handlers-feature | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 11,123 |
2be3ed88e004a06664d8156414ed406701353822 | Robert Jackson | Robert Jackson | [FEATURE ember-debug-handlers] Enable by default. | [feature ember-debug-handlers] enable by default | 48 | false | false | 5 | false | false | false | emberjs | ember.js | 11,124 |
68dec3d589a6634a03e3acc764628b5507ac49e6 | Robert Jackson | Robert Jackson | Merge pull request #12115 from rwjblue/remove-metal-stream-feature
Remove ember-metal-stream feature. | merge pull request from rwjblue/remove-metal-stream-feature | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 11,125 |
8804a08b144ebdc7b919c3ed19877fe06dc6162a | Robert Jackson | Robert Jackson | Remove ember-metal-stream feature.
We have generally decided that if streams require being exposed as
public API that we have somewhat failed in regards to the other API's.
The Glimmer refactors make that much closer to reality (streams should
not be leaking into public API's in 2.0.0).
Removing this extra feature flag... | remove ember-metal-stream feature | 33 | false | false | 3 | false | false | false | emberjs | ember.js | 11,126 |
c4e43a2da05b43877f24993f7cf327e00b979313 | Robert Jackson | Robert Jackson | Do not export Ember.GlimmerComponent unless feature is enabled. | do not export ember.glimmercomponent unless feature is enabled | 62 | false | false | 8 | false | false | false | emberjs | ember.js | 11,127 |
d57b32d851a950d83434e8241bdeba22aed20692 | Robert Jackson | Robert Jackson | Merge branch 'master' into glimmer-component | merge branch 'master' into glimmer-component | 44 | true | false | 5 | false | true | false | emberjs | ember.js | 11,128 |
ce89367c5dc0b9a0216bfbaaa9f915697c3a3c29 | Robert Jackson | Robert Jackson | Merge pull request #12106 from stefanpenner/meta-shape-fun
[BUGFIX release] ensure meta shape is correctly pre-allocated | merge pull request from stefanpenner/meta-shape-fun | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 11,129 |
ea91d63b44e223b46f5eb96852a072aa91d1b31e | Robert Jackson | Robert Jackson | Merge pull request #12113 from rwjblue/consolidate-travis-build
Collapse two Travis builds into one. | merge pull request from rwjblue/consolidate-travis-build | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 11,130 |
9af8d2193804baf3c280687c77ffc35de1e2e994 | Robert Jackson | Robert Jackson | Merge pull request #12112 from rwjblue/remove-feature-flags
Remove feature flags for features enabled in release. | merge pull request from rwjblue/remove-feature-flags | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 11,131 |
0c1e11dc9229d3760803641e1c171e75a6122342 | Robert Jackson | Robert Jackson | Collapse two Travis builds into one.
The build setup takes longer than actually running these. This updates
Travis config to run one less build, but the same actual tests. | collapse two travis builds into one | 35 | false | false | 6 | true | false | true | emberjs | ember.js | 11,132 |
c021a5ae2a6a60245ce45d680c5b1e0d79efc097 | Robert Jackson | Robert Jackson | Remove feature flagging import. | remove feature flagging import | 30 | false | false | 4 | true | true | true | emberjs | ember.js | 11,133 |
668a08e7052786df1de1c66ecf07dc29e71078b8 | Robert Jackson | Robert Jackson | Remove ember-htmlbars-helper and ember-htmlbars-dashless-helpers flags. | remove ember-htmlbars-helper and ember-htmlbars-dashless-helpers flags | 70 | false | false | 5 | false | false | false | emberjs | ember.js | 11,134 |
08741c56e113be520fc814913b87d6ca7873009b | Robert Jackson | Robert Jackson | Remove ember-htmlbars-get-helper feature flags. | remove ember-htmlbars-get-helper feature flags | 46 | false | false | 4 | false | false | false | emberjs | ember.js | 11,135 |
4307db7e50417d76ece19f7585615074e4592a4f | Robert Jackson | Robert Jackson | Remove ember-routing-htmlbars-improved-actions feature flags. | remove ember-routing-htmlbars-improved-actions feature flags | 60 | false | false | 4 | false | false | false | emberjs | ember.js | 11,136 |
68f915a3a8824809ac1de8023bb796d4ae33e361 | Robert Jackson | Robert Jackson | Remove ember-router-willtransition feature flags. | remove ember-router-willtransition feature flags | 48 | false | false | 4 | false | false | false | emberjs | ember.js | 11,137 |
66a17fb7b0e4c809831ee4fda18cbbc5abf42b1c | Robert Jackson | Robert Jackson | Remove ember-application-initializer-context feature flags. | remove ember-application-initializer-context feature flags | 58 | false | false | 4 | false | false | false | emberjs | ember.js | 11,138 |
3c05b4767b1e17732cb68d45389f25e98cb14d80 | Robert Jackson | Robert Jackson | Remove ember-application-instance-initializers feature flags. | remove ember-application-instance-initializers feature flags | 60 | false | false | 4 | false | false | false | emberjs | ember.js | 11,139 |
79ec14b264d0a8543b433e64cf77759a828e121c | Robert Jackson | Robert Jackson | Remove ember-routing-transitioning-classes feature flags. | remove ember-routing-transitioning-classes feature flags | 56 | false | false | 4 | false | false | false | emberjs | ember.js | 11,140 |
8190bfdb3f66d1349e0863095b8d523957c75fcc | Stefan Penner | Stefan Penner | Merge pull request #12111 from raycohen/nearest-of-type-public
[DOC release] Marks `nearestOfType` as public instead of private. | merge pull request from raycohen/nearest-of-type-public | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 11,141 |
0fbdf32544bb29db2a718ccee9245eb60604ebb1 | Robert Jackson | Robert Jackson | Remove feature flags for ember-htmlbars-each-in. | remove feature flags for ember-htmlbars-each-in | 47 | false | false | 5 | true | true | true | emberjs | ember.js | 11,142 |
6ed97d18637779906fd7a47be0b20de3b5db46b5 | Robert Jackson | Robert Jackson | Remove feature flags for ember-htmlbars-attribute-syntax. | remove feature flags for ember-htmlbars-attribute-syntax | 56 | false | false | 5 | true | true | false | emberjs | ember.js | 11,143 |
3c8cb582e883a5322cab00f3bb314997ab623f28 | Ray Cohen | Ray Cohen | [DOC release] Marks `nearestOfType` as public instead of private. | [doc release] marks `nearestoftype` as public instead of private | 64 | false | false | 9 | false | false | false | emberjs | ember.js | 11,144 |
5ca3d5f9de4d6561fedf6cda7382072d011ae7b1 | Robert Jackson | Robert Jackson | Remove feature flags for ember-htmlbars-inline-if-helper. | remove feature flags for ember-htmlbars-inline-if-helper | 56 | false | false | 5 | true | true | false | emberjs | ember.js | 11,145 |
0e47f283031749a946b5682732a1529708533919 | Robert Jackson | Robert Jackson | Remove ember-htmlbars-component-helper feature flags. | remove ember-htmlbars-component-helper feature flags | 52 | false | false | 4 | false | false | false | emberjs | ember.js | 11,146 |
5308d86a92f84aaf6057e4e10800ad52d69e6a87 | Robert Jackson | Robert Jackson | Remove ember-routing-named-substates feature flags. | remove ember-routing-named-substates feature flags | 50 | false | false | 4 | false | false | false | emberjs | ember.js | 11,147 |
b53366aac202da1b64764ac707f6facd033aa609 | Robert Jackson | Robert Jackson | Merge pull request #12104 from rwjblue/fix-concatenated-properties
[BUGFIX release-1-13] Ensure concatenatedProperties are not stomped. | merge pull request from rwjblue/fix-concatenated-properties | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 11,148 |
2633dee6871bc00d06b6715f371dba48ce90425b | Robert Jackson | Robert Jackson | Merge pull request #12070 from emberjs/fix-did-insert-element-in-ssr
[BUGFIX] Disable DOM-related component hooks in FastBoot | merge pull request from emberjs/fix-did-insert-element-in-ssr | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 11,149 |
c82e5c97147e0a87bdc397e2c2058c5f11c808bf | Stefan Penner | Stefan Penner | [BUGFIX release] ensure meta shape is correctly pre-allocated
I accidentally broke that [here](https://github.com/emberjs/ember.js/commit/580a40a75f8553bd4581f3b15ba1958c09eb3543) | [bugfix release] ensure meta shape is correctly pre-allocated | 61 | false | false | 8 | false | false | false | emberjs | ember.js | 11,150 |
98d7cf327f0c2ce97eadd9b7dfefbbb51734e1eb | Robert Jackson | Robert Jackson | [BUGFIX release-1-13] Ensure concatenatedProperties are not stomped.
When `_propagateAttrsToThis` is invoked it iterates all properties that
are present in `this.attrs` and calls `this.set(attrName, attrValue)`.
This is normally exactly what you expect. However, in the case of
`concatenatedProperties` and `mergedProperties` this `set`ing causes the
concatenated / merged property to be completely clobbered.
The fix introduced in #12073 adds a very simple work around for the
internally known items (just hard coding things like `classNames`,
`classNameBindings`, `attributeBindings`, and `actions`). This was
obviously a very naive check, and leaves any external usages of
`concatenatedProperties` in components/views completely hosed.
---
The changes here introduces a __avoidPropagating property that we can
use to prevent `concatenatedProperties` and `mergedProperties` from
being set inside `_propagateAttrsToThis`. To avoid introducing this cost
for every component created (when only classes can define new
concatenated / merged properties) we are storing the
`__avoidPropagating` on the constructor itself. | [bugfix release-1-13] ensure concatenatedproperties are not stomped | 67 | false | false | 7 | false | false | false | emberjs | ember.js | 11,151 |
b43e0e641f52c9acbcaba5cc3e90f60cccf9f599 | Robert Jackson | Robert Jackson | Merge pull request #12100 from rwjblue/fix-alias-volatility
Fix issue with `Ember.computed.alias` volatility. | merge pull request from rwjblue/fix-alias-volatility | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 11,152 |
9a7dbd5b306366347c6a1592ad790dc3b90321c3 | Stefan Penner | Robert Jackson | update test description to be more descriptive then "asdfasdf"
(cherry picked from commit 535f74ccfae965acb822a6fa0e82084df89f9b54) | update test description to be more descriptive then "asdfasdf" | 62 | false | false | 9 | false | true | false | emberjs | ember.js | 11,153 |
f48ffeae102009210cd97e16b96d0cf122e4fb6f | Kris Selden | Robert Jackson | [BUGFIX release] Fix #12083
(cherry picked from commit b610b2fd7e4a92e1b578b7db1192d665160d9cb8) | [bugfix release] fix | 20 | false | false | 3 | false | false | false | emberjs | ember.js | 11,154 |
d5564c263df8ebf45c04d51ae8d72515afb5d318 | Stefan Penner | Robert Jackson | Failing tests for #12083
(cherry picked from commit 1e0b50dfcbc8cc14721c755a5c5c32519a028a29) | failing tests for | 17 | false | false | 3 | false | false | false | emberjs | ember.js | 11,155 |
6336d21f8d7421685f8ab7e9e045475a9a8f6f48 | Robert Jackson | Robert Jackson | Merge pull request #12062 from emberjs/remove-next-super
Remove this.__nextSuper | merge pull request from emberjs/remove-next-super | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 11,156 |
ec9127894aa08f08b0e394c991ae03f3d486e60a | Stefan Penner | Stefan Penner | Merge pull request #12092 from locks/patch-2
typo | merge pull request from locks/patch-2 | 38 | true | false | 5 | true | false | false | emberjs | ember.js | 11,157 |
bba7a97dd73142d475b139cc381833c79282011a | Ricardo Mendes | Ricardo Mendes | typo | typo | 4 | false | false | 1 | false | false | false | emberjs | ember.js | 11,158 |
27a85e097bc0f205c1e286eaec9b6d54ba3297ba | Stefan Penner | Stefan Penner | Merge pull request #12090 from EricSchank/patch-2
[DOC release] fix formatting of 'if' helper | merge pull request from ericschank/patch-2 | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 11,159 |
6c04423ab2bc00a30782ec7e7265ea6c1a120f3c | Eric Schank | Eric Schank | [DOC release] fix formatting of 'if' helper
fix doc typo | [doc release] fix formatting of 'if' helper | 43 | false | false | 7 | false | false | false | emberjs | ember.js | 11,160 |
d218230221b0b7fd3f0b282ba5faac3e9a36b7d9 | Robert Jackson | Robert Jackson | Merge pull request #12089 from emberjs/fix-stream-leak
[BUGFIX release] fix two bugs in closure actions | merge pull request from emberjs/fix-stream-leak | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 11,161 |
c547dfdd0eb74a8b80ea8183f16b470d53c86356 | Godhuda | Godhuda | [BUGFIX release] fix two bugs in closure actions
Closure actions accidentally invoked `addDependency` for all params and
hash every time the value was recomputed.
Effectively, this means that when the params and hash value change, the
stream representing the closure action gets totally superfluous repeated
dependencies. This probably doesn’t cause incorrect behavior, because
the subscriptions are simply responsible for dirtying nodes, but it does
cause a memory leak.
Additionally, this commit adds a label to the closure action stream,
which was previously missing. | [bugfix release] fix two bugs in closure actions | 48 | false | false | 8 | false | false | false | emberjs | ember.js | 11,162 |
7a4e44eb81fb1d7b095654310b132f6d8a4fed64 | Stefan Penner | Stefan Penner | Merge pull request #12086 from emberjs/unlock-simple-dom-version
[CLEANUP] Unlock simple-dom version | merge pull request from emberjs/unlock-simple-dom-version | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 11,163 |
5455020d93066bd7d949467b55935723d4c69686 | Tom Dale | Tom Dale | [CLEANUP] Unlock simple-dom version
Fixes #11943, which reported a test failure after updating to newer
versions of simple-dom. I believe the regression was fixed with the
recent Node test refactorings. | [cleanup] unlock simple-dom version | 35 | false | false | 4 | false | false | false | emberjs | ember.js | 11,164 |
29847ef9fc841fddad56053426ae9a64edd11b8d | Tom Dale | Tom Dale | [BUGFIX] Disable component lifecycle hooks in FastBoot
This commit fixes #11325, which reported a regression where components
and views lifecycle hooks were inappropriately invoked in FastBoot.
FastBoot needs a mechanism to signal to the rendering layer that it is
operating in an environment without a full DOM, and thus userland hooks
that may expect a fully-functioning DOM (didInsertElement, didRender,
etc) should not be invoked.
Previously, the Renderer’s constructor accepted a second argument that
disabled this, but support for that appears to have been lost somewhere
along the way.
This commit introduces a test that verifies these hooks are disabled.
It also causes the RenderEnv to copy the Renderer’s `destinedForDOM`
flag, making it available inside HTMLBars helpers and keywords.
Now, the ViewNodeManager and ComponentNodeManager check the env for the
`destinedForDOM` flag, and if it’s false, do not invoke these lifecycle
hooks. | [bugfix] disable component lifecycle hooks in fastboot | 54 | false | false | 7 | false | false | false | emberjs | ember.js | 11,165 |
dc6f6b927e8750287bdbfe188a82ef5ae0299d82 | Godhuda | Godhuda | Merge remote-tracking branch 'origin/master' into glimmer-component | merge remote-tracking branch 'origin/master' into glimmer-component | 67 | true | false | 6 | false | false | false | emberjs | ember.js | 11,166 |
0604db16ea85496b294d31f4289fbf1687924e89 | Godhuda | Godhuda | Add failing test for top-level {{partial}}
Currently a top-level partial that happens to have a single top-level
element confuses the heuristics in the component hook. | add failing test for top-level {{partial}} | 42 | false | false | 6 | true | true | true | emberjs | ember.js | 11,167 |
197289a60b4e18c776be95fadeff5756dea5e6b8 | Robert Jackson | Robert Jackson | Merge pull request #12066 from emberjs/clean-up-ssr-tests
Clean up server-side rendering tests | merge pull request from emberjs/clean-up-ssr-tests | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 11,168 |
c53e68f70df6869831135e982df381a09d76d535 | Robert Jackson | Robert Jackson | Merge pull request #12074 from mixonic/assert-no-dep
[CLEANUP beta] Assert on view and controller keywords | merge pull request from mixonic/assert-no-dep | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 11,169 |
ba0b6360e2cfec8632b0d963c8696caf69814d25 | Matthew Beale | Matthew Beale | [CLEANUP beta] Remove collection helper without flag | [cleanup beta] remove collection helper without flag | 52 | false | false | 7 | false | false | false | emberjs | ember.js | 11,170 |
8f72bf23c26260ff2233d64588c3be82edcd9f12 | Matthew Beale | Matthew Beale | [CLEANUP beta] Assert on view and controller keywords | [cleanup beta] assert on view and controller keywords | 53 | false | false | 8 | false | false | false | emberjs | ember.js | 11,171 |
89ba4e05dc2d777b6f5796de2eda5b0e36d1f9c7 | Robert Jackson | Robert Jackson | Merge pull request #11999 from adamesque/patch-2
[DOC release] Make controller property on Route public | merge pull request from adamesque/patch-2 | 42 | true | false | 5 | true | false | false | emberjs | ember.js | 11,172 |
1d84753c7e021b00a5a9ed15751ea1a7cd1c3c24 | Robert Jackson | Robert Jackson | Merge pull request #12065 from juggy/rename-qp-only
Rename _handleOnlyQueryParamsSupplied to _computeRouteNameWithQueryParams | merge pull request from juggy/rename-qp-only | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 11,173 |
257b2719cc3a2d7300535b2f079dcf1782235ae1 | Chris Thoburn | Chris Thoburn | dont spin up extra run-loops when bubbling events. Fixes #11540 | dont spin up extra run-loops when bubbling events. fixes | 57 | false | false | 9 | false | false | false | emberjs | ember.js | 11,174 |
c55f22043177412f5ba2f07aa9a0163556f217cc | Robert Jackson | Robert Jackson | Merge pull request #12060 from emberjs/unused-templates
[BUGFIX canary] Delete unused templates | merge pull request from emberjs/unused-templates | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 11,175 |
ac9405e1ecf398a560982fabe312d00469ebb412 | Robert Jackson | Robert Jackson | Merge pull request #12059 from rwjblue/opt-out-events
[BUGFIX canary] Honor `customEvents` opting out of event listeners. | merge pull request from rwjblue/opt-out-events | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 11,176 |
e7b807cd950033bf156364487d64dccd5d45cc04 | Robert Jackson | Robert Jackson | Merge pull request #12073 from rwjblue/fix-classNames
[BUGFIX release] Fix classNames clobbering issue with AttrProxy. | merge pull request from rwjblue/fix-classnames | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 11,177 |
f52711ec94f9c9418854884377e078a042ebb5e3 | Robert Jackson | Robert Jackson | [BUGFIX release] Fix classNames clobbering issue with AttrProxy.
Specifying `classNames` as a hash argument was previously stomping the
concatenated property on the already created view when processing
`attrs` in the `AttrsProxy`.
This PR prevents us from stomping on any `concatenatedProperties` or
`mergedProperties` while propagating `attrs` to `this`. | [bugfix release] fix classnames clobbering issue with attrproxy | 63 | false | false | 8 | false | false | false | emberjs | ember.js | 11,178 |
6c78b25bead6d4e24e653147c970f9a238473abc | Robert Jackson | Robert Jackson | Merge pull request #12071 from EricSchank/unspecified-comp-attrs
[BUGFIX release] use bracket notation to access unknown attr #12035 | merge pull request from ericschank/unspecified-comp-attrs | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 11,179 |
288f40db8b1e24ae226e560e49281667e7070a34 | Eric Schank | Eric Schank | [BUGFIX release] use bracket notation to access unknown attr #12035 | [bugfix release] use bracket notation to access unknown attr | 60 | false | false | 9 | false | false | false | emberjs | ember.js | 11,180 |
4a8d9a37015e454161851c3975f4159fbcdff03c | Robert Jackson | Robert Jackson | Merge pull request #10173 from dgeb/fix-3310
[BUGFIX] Ensure that dynamic injections are not cacheable in a Container. | merge pull request from dgeb/fix-3310 | 38 | true | false | 5 | true | true | false | emberjs | ember.js | 11,181 |
d8a95b11d5776ca840b4c123d3b40d48db4eaf2f | Tom Dale | Tom Dale | Clean up server-side rendering tests
The tests for running Ember applications inside a Node.js environment
evolved organically and were in need of a cleanup. In particular, there
was so much boilerplate code that was repeated for each test that it
was hard for the layperson to follow along, and even experienced users
had trouble understanding what the intent of the test was without
careful parsing.
This commit splits the test into two files:
1. Simple component rendering tests that just verify that a single
component can be rendered to a string of HTML
2. Integration tests that boot and test an entire application.
The integration tests have been cleaned up significantly. I implemented
a small DSL for building up an application in the tests, as well as some
helper methods that abstract the steps necessary to put Ember into
server-side rendering mode, as well as the asynchrony that comes with
it.
That abstraction happens in a helper that wraps QUnit.module, giving any
tests in that module a pre-built environment for registering classes
in the application, then routing to a URL and testing the resulting
HTML. | clean up server-side rendering tests | 36 | false | false | 5 | false | false | false | emberjs | ember.js | 11,182 |
84b46b9e1e8e894a0b76349a1c0a2e7ebb7f0f5b | Dan Gebhardt | Dan Gebhardt | Ensure that dynamic injections are not cacheable in a Container.
A non-singleton injection should prevent caching of an object or factory
instance in a container.
[Fixes #3310] | ensure that dynamic injections are not cacheable in a container | 63 | false | false | 10 | false | false | false | emberjs | ember.js | 11,183 |
1d55f55e579e551af10bf1f9f2439e650d6b3b7c | Dan Gebhardt | Dan Gebhardt | Reword tests to better reflect container / registry relationship. | reword tests to better reflect container / registry relationship | 64 | false | false | 9 | true | true | false | emberjs | ember.js | 11,184 |
69192d55b89c5c2c3e022acb2a179c06945fce20 | Julien Guimont | Julien Guimont | Rename _handleOnlyQueryParamsSupplied to _computeRouteNameWithQueryParams | rename _handleonlyqueryparamssupplied to _computeroutenamewithqueryparams | 73 | false | false | 4 | false | true | false | emberjs | ember.js | 11,185 |
40822807224795e0ce2fb34dd83a0d738f7280d7 | Robert Jackson | Robert Jackson | Merge pull request #12058 from cibernox/fix_qps_only_links
[BUGFIX release] Fix link-to with only qps linking to outdated route | merge pull request from cibernox/fix_qps_only_links | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 11,186 |
9bffc1ac0aae14bf4681fef6c1218bc8e6597f07 | Robert Jackson | Robert Jackson | Merge pull request #12061 from stefanpenner/faster-guid-for-yo
[BUGFIX release] improve performance of guidFor when reading an exist… | merge pull request from stefanpenner/faster-guid-for-yo | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 11,187 |
5cecffa5211007105b024d02df65496bb0e277cf | Kris Selden | Kris Selden | Remove this.__nextSuper
This just ensures that the superFunction is wrapped with a terminal _super instead of relying on this.__nextSuper = null while invoked to prevent recursion. Allows wrapped functions not to have to go through 2 argument applies, makes debugging a lot easier and performs better. | remove this.__nextsuper | 23 | false | false | 2 | true | true | false | emberjs | ember.js | 11,188 |
a19e1f986ff4bc78de5bbb853ba84e632590107e | Stefan Penner | Stefan Penner | [BUGFIX release] improve performance of guidFor when reading an existing guid
* This made OrderedSet#add 2x -> 3x faster (helps our ember-data friends)
* This appears to have made OrderedSet#add faster then V8 native Set#add (for now) | [bugfix release] improve performance of guidfor when reading an existing guid | 77 | false | false | 11 | false | false | false | emberjs | ember.js | 11,189 |
1b636042cb657a20d59ed293e3ba8687164a71ff | Miguel Camba | Miguel Camba | [BUGFIX release] Fix link-to with only qps linking to outdated route | [bugfix release] fix link-to with only qps linking to outdated route | 68 | false | false | 11 | false | false | false | emberjs | ember.js | 11,190 |
8fe89b11bcd2bd4be5956eeabdff3b6648d24e5a | Edward Faulkner | Edward Faulkner | [BUGFIX canary] Delete unused templates | [bugfix canary] delete unused templates | 39 | false | false | 5 | false | false | false | emberjs | ember.js | 11,191 |
5a023f33afa2cedb5a652cd2efd354352aa3d7c7 | Robert Jackson | Robert Jackson | Merge pull request #12051 from EricSchank/patch-1
[DOC release] document current-when argument for link-to #12038 | merge pull request from ericschank/patch-1 | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 11,192 |
acbb0b2d2551e2032490ce56becccc08e8bf5e4d | Robert Jackson | Robert Jackson | [BUGFIX canary] Honor `customEvents` opting out of event listeners.
Setting `customEvents` to a hash in an application is a way to add new
listeners that the `EventDispatcher` knows about.
Often, users see this and decide that they want to disable a given event
(for example `mouseenter` and `mouseleave` events) and think they can do
something like:
```javascript
var App = Ember.Application.create({
customEvents: {
mouseenter: null,
mouseleave: null
}
});
```
Unfortunately, that just makes the `EventDispatcher` call a method named
`null` on the view/component instances (LOL).
This fixes that bug by allowing a `null` value to disable the event
listener. | [bugfix canary] honor `customevents` opting out of event listeners | 66 | false | false | 9 | false | false | false | emberjs | ember.js | 11,193 |
088973af347572b7c6c046f34dfddae5c2faa441 | Eric Schank | Eric Schank | [DOC release] document current-when argument for link-to #12038
Add docs for `current-when` on `link-to`
See issue #12038 | [doc release] document current-when argument for link-to | 56 | false | false | 7 | false | false | false | emberjs | ember.js | 11,194 |
92d4854ca35b010541730053eae5810c8fe0a0eb | Godhuda | Godhuda | Test all styles of top-level element in <GC>
Previously, we had hardcoded tests for two styles of top-level element
in a GlimmerComponent. For the layout of `<foo-bar>`, we had tests for
the top-level element being `<foo-bar>` itself and being a `<div>`.
A recent commit allowed the top-level element to also be any dasherized
element that was not registered as an Ember component (aka “web
components”). This commit modifies the tests to enumerate all three
styles and runs the same set of tests for each. | test all styles of top-level element in <gc> | 44 | false | false | 8 | true | true | true | emberjs | ember.js | 11,195 |
974493f0ddef29f607498d385d3ff3258ba00894 | Godhuda | Godhuda | Make non-Ember-component <foo-bar> work
As of the previous commit, any use of `<foo-bar>` was assumed to be an
Ember Glimmer Component. This breaks code that was using dasherized
names either to refer to web components or just to produce regular HTML
elements. We believe that both of these are done in practice.
This commit allows `<foo-bar>` to be treated the same as `<div>` in all
currently implemented contexts. | make non-ember-component <foo-bar> work | 39 | false | false | 4 | false | true | false | emberjs | ember.js | 11,196 |
c4905667e3c5337727b72295e0745d87ace5bd6d | Robert Jackson | Robert Jackson | Merge pull request #12057 from rwjblue/instance-initializers-custom-events
Allow instanceInitializers to set `customEvents`. | merge pull request from rwjblue/instance-initializers-custom-events | 68 | true | false | 5 | true | false | false | emberjs | ember.js | 11,197 |
715aa2b2fa5801d4b17cce6915a6863acd798251 | Godhuda | Godhuda | Reorganize for transformation bug
The current ember-debug transformations do not support nested asserts
inside runInDebug. | reorganize for transformation bug | 33 | false | false | 4 | false | false | false | emberjs | ember.js | 11,198 |
f12a9f412b9b2123604ea7ba9bb6d9360d2118ac | Robert Jackson | Robert Jackson | Allow instanceInitializers to set `customEvents`.
Instance initializers were previously not able to affect the
`customEvents` that will be provided to the `EventDispatcher`. This is
most helpful when you are receiving configuration that is registered as
in an initiailzer.
The fix here is to run instance initializers before the event dispatcher
is setup, so that they can augment the `customEvents` hash. | allow instanceinitializers to set `customevents` | 48 | false | false | 5 | false | true | false | emberjs | ember.js | 11,199 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.