sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
f36d8d10b8a445b4b47f31761914ed23450fa68c | Robert Jackson | Robert Jackson | Merge pull request #11392 from HeroicEric/update-each-syntax
[DOC] Replace deprecated {{#each}} syntax | merge pull request from heroiceric/update-each-syntax | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 12,000 |
8d50a42c1d25733406622ce54749888df8ce4144 | Eric Kelly | Eric Kelly | [DOC] Replace deprecated {{#each}} syntax | [doc] replace deprecated {{#each}} syntax | 41 | false | false | 5 | false | false | false | emberjs | ember.js | 12,001 |
c471c0f15fe6df94034919dbde419d4e8df7caf5 | Robert Jackson | Robert Jackson | Merge pull request #11389 from bantic/deprecate-view-helper
[BUGFIX beta] Add deprecation for view helper | merge pull request from bantic/deprecate-view-helper | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 12,002 |
7cf353523f0a10947494d4cf25e675fb685964fb | Matthew Beale | Matthew Beale | Merge pull request #11387 from bantic/deprecate-ember-view-global
[BUGFIX beta] Change the Ember.View global to have a deprecation warning on init | merge pull request from bantic/deprecate-ember-view-global | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 12,003 |
c5be1b029c7dccc9391cd7d6a0e2c5e0896504c1 | Cory Forsyth | Cory Forsyth | [BUGFIX beta] Add deprecation for view helper
* change env value RAISE_ON_DEPRECATION to false
* change tests for Ember.deprecate that relied on RAISE_ON_DEPRECATION being true
refs #11377 | [bugfix beta] add deprecation for view helper | 45 | false | false | 7 | false | false | false | emberjs | ember.js | 12,004 |
1cfb36d19236b9441f8c742b8630127fc3e26808 | Cory Forsyth | Cory Forsyth | [BUGFIX beta] Change the Ember.View global to have a deprecation warning on init
* Use underscored env variable _ENABLE_LEGACY_VIEW_SUPPORT to remove deprecation.
* Change tests that used the Ember.View global directly to import View from "ember-views/views/view" instead
Refs #11377 | [bugfix beta] change the ember.view global to have a deprecation warning on init | 80 | false | false | 13 | false | false | false | emberjs | ember.js | 12,005 |
205e6df5b4e8fffc38135f9ece3650fe96a22b5e | Robert Jackson | Robert Jackson | Merge pull request #11383 from cibernox/update-each-in
Update {{each-in}} to use ember-metal/should-display | merge pull request from cibernox/update-each-in | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 12,006 |
6127adbfcb342f87f09710a8bb7bf29d123a1e5d | Robert Jackson | Robert Jackson | Merge pull request #11386 from rwjblue/stupid-rwjblue
[BUGFIX beta] Ensure errors are not thrown if actions are not found. | merge pull request from rwjblue/stupid-rwjblue | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 12,007 |
da0ebf20b7849ab1fe2cef04b165fd4702d959b4 | Robert Jackson | Robert Jackson | [BUGFIX beta] Ensure errors are not thrown if actions are not found.
Events are triggered async, and the ActionManager.registeredActions
listing may have already been cleared by the time it is fired. | [bugfix beta] ensure errors are not thrown if actions are not found | 67 | false | false | 12 | false | false | false | emberjs | ember.js | 12,008 |
e17fdb994dac0141d3855d4e13397c8e859f77ba | Miguel Camba | Miguel Camba | Update {{each-in}} to use ember-metal/should-display | update {{each-in}} to use ember-metal/should-display | 52 | false | false | 5 | false | false | false | emberjs | ember.js | 12,009 |
dfc31dfb23e8695a29e5bca11c480b4cccc8edd8 | Miguel Camba | Miguel Camba | Apply commit 48aad1d with a patch | apply commit 48aad1d with a patch | 33 | false | false | 6 | false | true | false | emberjs | ember.js | 12,010 |
796aff2146d0573f4240bec294201b33ab9a9ad9 | Miguel Camba | Miguel Camba | Return the setter values instead of this | return the setter values instead of this | 40 | false | false | 7 | true | true | true | emberjs | ember.js | 12,011 |
e633c52a899ceece3029de585607ee92bd10ce72 | Miguel Camba | Miguel Camba | Remove chaining in set and see what happens | remove chaining in set and see what happens | 43 | false | false | 8 | false | false | false | emberjs | ember.js | 12,012 |
117d0dd5d1d0a412e8886d8168624a44ec70c2d6 | Robert Jackson | Robert Jackson | Merge pull request #11375 from mmun/babel-feature-flags
Transition feature flag infrastructure to modules | merge pull request from mmun/babel-feature-flags | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 12,013 |
6a4edb4b97d66a697eed1a1881d1627312a5878c | Martin Muñoz | Martin Muñoz | Transition feature flag infrastructure to modules | transition feature flag infrastructure to modules | 49 | false | false | 6 | false | false | false | emberjs | ember.js | 12,014 |
aa7666fe3bb90df38b725cc48adc9134580c754b | Robert Jackson | Robert Jackson | Merge pull request #11376 from rwjblue/gst
[BUGFIX beta] Prevent AST plugins from being shared across compiles. | merge pull request from rwjblue/gst | 36 | true | false | 5 | true | false | false | emberjs | ember.js | 12,015 |
6e4cbeb35cf86e4f5329353fabbfb2aff07da58c | Robert Jackson | Robert Jackson | [BUGFIX beta] Prevent AST plugins from being shared across compiles. | [bugfix beta] prevent ast plugins from being shared across compiles | 67 | false | false | 10 | false | false | false | emberjs | ember.js | 12,016 |
cb00d3787c083fa2046caa3b30544ac19f6fa92a | Robert Jackson | Robert Jackson | Merge pull request #11373 from rwjblue/multiple-actions
[BUGFIX beta] Fix issue with multiple actions in a single element. | merge pull request from rwjblue/multiple-actions | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 12,017 |
4e7d3bebce85414d08ae22ab4d5f5a05e3b5bbb8 | Robert Jackson | Robert Jackson | [BUGFIX beta] Fix issue with multiple actions in a single element.
In prior versions of Ember multiple `{{action}}` helpers were
not able to be attached to a single element. This was primarily due
to the way that the actions were wired (via `data-ember-action`
attribute).
That original limitation seems like a bug, and this commit enables usage
of multiple actions in a single DOM element by having the
private `ActionManager` keep its internal representation of "actions for
a given action ID" as an array and iterating that array when an event
occurs. | [bugfix beta] fix issue with multiple actions in a single element | 65 | false | false | 11 | false | false | false | emberjs | ember.js | 12,018 |
17fcf1c16fc1f704b1c124fbb0f6a1a7729f09ff | Robert Jackson | Robert Jackson | Merge pull request #11372 from bcardarella/bc-docfix-nextObject
[DOCFIX] Enumerable.nextObject | merge pull request from bcardarella/bc-docfix-nextobject | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 12,019 |
c28f9c77bcadbd7c24737bc06b1efcf804514dad | Brian Cardarella | Brian Cardarella | [DOCFIX] Enumerable.nextObject
Corrected the documentation grammar | [docfix] enumerable.nextobject | 30 | false | false | 2 | false | false | false | emberjs | ember.js | 12,020 |
50cf18fa9e542d255a899386370da14060d62525 | Stanley Stuart | Stanley Stuart | Merge pull request #11371 from rwjblue/update-dep-checker
Update ember-cli-dependency-checker. | merge pull request from rwjblue/update-dep-checker | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 12,021 |
a5e5ad6917ee2f091f826aa5996be1c4d0c10db7 | Matthew Beale | Matthew Beale | Fix helper export, add test | fix helper export, add test | 27 | false | false | 5 | true | true | true | emberjs | ember.js | 12,022 |
071630b84b07e9dc85ad59acaaba22ab99c2b7e8 | Matthew Beale | Matthew Beale | Merge pull request #11278 from mixonic/helpers
Implement Ember.Helper: RFC#53. | merge pull request from mixonic/helpers | 40 | true | false | 5 | true | false | false | emberjs | ember.js | 12,023 |
c350340e710c829ef4cbc62aff2fbcb8bddfec29 | Matthew Beale | Matthew Beale | Revert changes to handlebars lookup | revert changes to handlebars lookup | 35 | false | false | 5 | false | true | false | emberjs | ember.js | 12,024 |
35ad35bbdffee4095989ea38337ccfb89826eb7d | Robert Jackson | Robert Jackson | Update ember-cli-dependency-checker. | update ember-cli-dependency-checker | 35 | false | false | 2 | false | false | false | emberjs | ember.js | 12,025 |
415959d49c2b09a2e9160f63fc847a6c7d39f636 | Matthew Beale | Matthew Beale | Wrap ember-htmlbars-helper in a feature flag | wrap ember-htmlbars-helper in a feature flag | 44 | false | false | 6 | false | false | false | emberjs | ember.js | 12,026 |
334b3df0aff2038ceda0293fecebc1ee16cc8d54 | Matthew Beale | Matthew Beale | Implement Ember.Helper API | implement ember.helper api | 26 | false | false | 3 | true | true | true | emberjs | ember.js | 12,027 |
9e3c1655b8138e45716923e513ac18d23e6862c9 | Robert Jackson | Robert Jackson | Merge pull request #11369 from tomdale/wordsmith-each
Wordsmith `key=` prose | merge pull request from tomdale/wordsmith-each | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 12,028 |
5e63afecbead32b6073143010b67c1ae671048b0 | Tom Dale | Tom Dale | Wordsmith key prose | wordsmith key prose | 19 | false | false | 3 | false | false | false | emberjs | ember.js | 12,029 |
0050fe7fdf0755c6170b2f4c29af33307235251f | Robert Jackson | Robert Jackson | Merge pull request #11367 from emberjs/improve-build-tooling
Improve build tooling | merge pull request from emberjs/improve-build-tooling | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 12,030 |
f9126e09abaf023c308d2761a56d6ae60f13734e | Robert Jackson | Robert Jackson | Merge pull request #11368 from rwjblue/document-backburner-private
Revert "[DOC beta] Remove invalid backburner comment block." | merge pull request from rwjblue/document-backburner-private | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 12,031 |
062465af97bfc8d913e58cd1e0cc84df7f8a6a67 | Matthew Beale | Matthew Beale | Only call deactivate when being deactivated | only call deactivate when being deactivated | 43 | false | false | 6 | false | false | false | emberjs | ember.js | 12,032 |
67e433f6ae6778abfbfe69c54318d81ddbbb5351 | Stefan Penner | Stefan Penner | bump emberjs-build | bump emberjs-build | 18 | true | false | 2 | false | true | false | emberjs | ember.js | 12,033 |
f34eefdea249bb50ed8f5360bfad3d33bb4eaa44 | Robert Jackson | Robert Jackson | Revert "[DOC beta] Remove invalid backburner comment block."
This reverts commit 212c584ac73d7bd8b79e1a46cf27ed3b3b8e5fcd. | revert "[doc beta] remove invalid backburner comment block." | 60 | false | false | 8 | false | true | false | emberjs | ember.js | 12,034 |
6e25ec664200a9972d11b4ce9ad14be71cba4a4f | Stefan Penner | Stefan Penner | remove whitespace | remove whitespace | 17 | false | false | 2 | true | true | false | emberjs | ember.js | 12,035 |
28b464437628f73c82367ffbf61ea8e1ed1216ba | Robert Jackson | Robert Jackson | Merge pull request #11366 from rwjblue/remove-private-backburner-doc-block
[DOC beta] Remove invalid backburner comment block. | merge pull request from rwjblue/remove-private-backburner-doc-block | 68 | true | false | 5 | true | false | false | emberjs | ember.js | 12,036 |
212c584ac73d7bd8b79e1a46cf27ed3b3b8e5fcd | Robert Jackson | Robert Jackson | [DOC beta] Remove invalid backburner comment block. | [doc beta] remove invalid backburner comment block | 50 | false | false | 7 | false | false | false | emberjs | ember.js | 12,037 |
b2247adc6af4ce034e567caa2b0816613af02a01 | Robert Jackson | Robert Jackson | Merge pull request #11207 from trek/configure-query-params-in-route
[FEATURE] [REFACTOR] Configure query params in route | merge pull request from trek/configure-query-params-in-route | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 12,038 |
1301e680deaa52dcd253690efba74466fbb119d5 | Robert Jackson | Robert Jackson | Merge pull request #11365 from rwjblue/fix-more-comment-blocks
[DOC beta] Cleanup more doc block access notation in ember-debug. | merge pull request from rwjblue/fix-more-comment-blocks | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 12,039 |
bb50b04d5f1479f4b11b8aa0873b28be56add676 | Trek Glowacki | Trek Glowacki | Ignore specific query params keys when feature flag is off | ignore specific query params keys when feature flag is off | 58 | false | false | 10 | false | true | false | emberjs | ember.js | 12,040 |
ed18882a38a8806e666b2bc5599982b1d51170c1 | Robert Jackson | Robert Jackson | [DOC beta] Cleanup more doc block access notation in ember-debug. | [doc beta] cleanup more doc block access notation in ember-debug | 64 | false | false | 10 | false | false | false | emberjs | ember.js | 12,041 |
da76ea85c3f9c3d3310e3ad262ddd958373dbe3b | Trek Glowacki | Trek Glowacki | Split query param related tests into smaller modules | split query param related tests into smaller modules | 52 | false | false | 8 | false | false | false | emberjs | ember.js | 12,042 |
f1d1da91d11a6699ef3c7f96ad63355f705fb566 | Robert Jackson | Robert Jackson | Merge pull request #11362 from rwjblue/enforce-documentation-access-specifics
[DOC beta] Enforce public/private declaration for API docs. | merge pull request from rwjblue/enforce-documentation-access-specifics | 71 | true | false | 5 | true | false | false | emberjs | ember.js | 12,043 |
6e1ad90712db713fd9b32fab38020dddf65e6114 | Robert Jackson | Robert Jackson | [DOC beta] Enforce public/private declaration for API docs. | [doc beta] enforce public/private declaration for api docs | 58 | false | false | 8 | false | false | false | emberjs | ember.js | 12,044 |
b30ad1ef2e5e029111b775ee4174684e1ad68a4e | Robert Jackson | Robert Jackson | Merge pull request #11363 from rwjblue/fix-concat-tests
[BUGFIX beta] Use layout properly for `{{concat}}` tests. | merge pull request from rwjblue/fix-concat-tests | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 12,045 |
63054061dee190378513d9f33a8abfc70341e9f1 | Robert Jackson | Robert Jackson | [BUGFIX beta] Use layout properly for `{{concat}}` tests. | [bugfix beta] use layout properly for `{{concat}}` tests | 56 | false | false | 8 | false | false | false | emberjs | ember.js | 12,046 |
55f02b1b07a3a2b6a546bfec2e78f9d1005834c3 | Robert Jackson | Robert Jackson | Merge pull request #11264 from rwjblue/add-concat-helper
Expose `{{concat}}` helper publicly. | merge pull request from rwjblue/add-concat-helper | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 12,047 |
73acd45cdbed6ad0981263dace24741fb31045d9 | Robert Jackson | Robert Jackson | Merge pull request #11360 from rwjblue/add-warning-for-keyless-each
[BUGFIX beta] Add a warning message when using keyless {{each}}. | merge pull request from rwjblue/add-warning-for-keyless-each | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 12,048 |
d1d610541608bb82c9a490d66f85d1b09f6668f0 | Trek Glowacki | Trek Glowacki | Feature flag query params refactor | feature flag query params refactor | 34 | false | false | 5 | false | false | false | emberjs | ember.js | 12,049 |
9f0c8176d456e311f365bf935ec4dbd683db806c | Robert Jackson | Robert Jackson | [BUGFIX beta] Add a warning message when using keyless {{each}}. | [bugfix beta] add a warning message when using keyless {{each}} | 63 | false | false | 10 | false | false | false | emberjs | ember.js | 12,050 |
4d4f9e621ec850d550da5313b0cc01e09c689afe | Robert Jackson | Robert Jackson | Merge pull request #11219 from danmcclain/arbitrary-positional-params
[BUGFIX beta] Allows for an arbitrary # of positional parameters | merge pull request from danmcclain/arbitrary-positional-params | 63 | true | false | 5 | true | false | false | emberjs | ember.js | 12,051 |
78b63d1e36e0d25b5c8f1f202d27b3d36fce3fc5 | Robert Jackson | Robert Jackson | Merge pull request #11352 from rwjblue/fix-template-lookup-from-views-as-components
[BUGFIX beta] Fix Views with templates inline as component. | merge pull request from rwjblue/fix-template-lookup-from-views-as-components | 77 | true | false | 5 | true | false | false | emberjs | ember.js | 12,052 |
060b5f75b2a6ef5e3356ac52b5a62a188206fc6d | Robert Jackson | Robert Jackson | Merge pull request #11353 from ilkkao/ilkkao/special-keys-to-legacy-each
Add special values to legacy {{each}}s' keyPath | merge pull request from ilkkao/ilkkao/special-keys-to-legacy-each | 66 | true | false | 5 | true | false | false | emberjs | ember.js | 12,053 |
930513b5c86007baa3e81c4d94f6ea8715a17880 | Ilkka Oksanen | Ilkka Oksanen | Add special values to legacy `{{each}}`s' keyPath | add special values to legacy `{{each}}`s' keypath | 49 | false | false | 7 | true | true | true | emberjs | ember.js | 12,054 |
d425967940d58bf66a5104a630449d0ce07c5169 | Robert Jackson | Robert Jackson | [BUGFIX beta] Fix Views with templates inline as component.
When using a `Ember.View` based factory from a component's location the
new `_template` lookup will not work (because `Ember.View` does not have
that specific fallback). | [bugfix beta] fix views with templates inline as component | 58 | false | false | 9 | false | false | false | emberjs | ember.js | 12,055 |
544da2a523f29b4bcc686df47deb027819a2ad0e | Stefan Penner | Stefan Penner | Merge pull request #11349 from Turbo87/jsdoc-issues
Fix JSDoc issues | merge pull request from turbo87/jsdoc-issues | 45 | true | false | 5 | true | true | false | emberjs | ember.js | 12,056 |
502ae9543e102c50ec642584bd2329946dd7160b | Robert Jackson | Robert Jackson | Merge pull request #11346 from teddyzeenny/data-adapter
Use model name instead of factory in data adapter | merge pull request from teddyzeenny/data-adapter | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 12,057 |
c963eed9ebebbc2075029348075e36f3cc6ba04a | Teddy Zeenny | Teddy Zeenny | Use model name instead of factory in data adapter | use model name instead of factory in data adapter | 49 | false | false | 9 | true | true | true | emberjs | ember.js | 12,058 |
f1df1d43d449b9aecb6c0585520cb10602ca9dd8 | Tobias Bieniek | Tobias Bieniek | JSDoc: Replace "Integer" type with "Number"
"Integer" is not a valid type | replace "integer" type with "number" | 36 | false | false | 5 | true | true | true | emberjs | ember.js | 12,059 |
da3003c547a09132f5744c3325804e6dae7407ef | Tobias Bieniek | Tobias Bieniek | JSDoc: Replace "Hash" type with "Object"
"Hash" is not a valid type | replace "hash" type with "object" | 33 | false | false | 5 | true | true | true | emberjs | ember.js | 12,060 |
6f769aab58d9cad6195859d8ec1b6f66ab134fb3 | Tobias Bieniek | Tobias Bieniek | Fix broken JSDoc references | fix broken jsdoc references | 27 | false | false | 4 | true | true | true | emberjs | ember.js | 12,061 |
5e7a7d175f74ca319fb1a1dc6857af603de747f6 | Robert Jackson | Robert Jackson | Merge pull request #11348 from rwjblue/better-errors-for-better-actions
[BUGFIX beta] Provide useful errors when a closure action is not found. | merge pull request from rwjblue/better-errors-for-better-actions | 65 | true | false | 5 | true | false | false | emberjs | ember.js | 12,062 |
3711d8eefe6e25a3ba61d3978ecd33c4c3a54bee | Robert Jackson | Robert Jackson | [BUGFIX beta] Provide useful errors when a closure action is not found. | [bugfix beta] provide useful errors when a closure action is not found | 70 | false | false | 12 | false | false | false | emberjs | ember.js | 12,063 |
b1551676764b5f355f65fbfdc571fcea40b1c962 | Stefan Penner | Stefan Penner | Merge pull request #11347 from rwjblue/add-watchmanconfig
Add .watchmanconfig to ignore `tmp`. | merge pull request from rwjblue/add-watchmanconfig | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 12,064 |
9b70eed5f9a97cb3ba80b9343b263955b6641703 | Robert Jackson | Robert Jackson | Add .watchmanconfig to ignore `tmp`. | add .watchmanconfig to ignore `tmp` | 35 | false | false | 5 | true | true | true | emberjs | ember.js | 12,065 |
0cdfa9d334c502162d30450ec1353671c59c863d | Robert Jackson | Robert Jackson | Merge pull request #11339 from rwjblue/each-special-values
[BUGFIX beta] Add special values to `{{each}}`'s keyPath. | merge pull request from rwjblue/each-special-values | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 12,066 |
bdfd3699fb5730c0315e347bdc281703791ae081 | Robert Jackson | Robert Jackson | Merge pull request #11341 from jmurphyau/rerender-child-with-view
Make ComponentNodeManager.rerender use RenderEnv | merge pull request from jmurphyau/rerender-child-with-view | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 12,067 |
dfe32bca50a73f779227c8cb6586b9d36213c973 | James Murphy | James Murphy | ComponentNodeManager.rerender use RenderEnv
Fixes #11340.
Test 'non-block with each rendering child components' in 'component_invocation_test.js' demonstrates a 'real world' test that is failing. | componentnodemanager.rerender use renderenv | 43 | false | false | 3 | false | false | false | emberjs | ember.js | 12,068 |
c7fafb9c7517f917ce2c045e09099776548a81ef | Robert Jackson | Robert Jackson | [BUGFIX beta] Add special values to `{{each}}`'s keyPath. | [bugfix beta] add special values to `{{each}}`'s keypath | 56 | false | false | 8 | false | false | false | emberjs | ember.js | 12,069 |
87fdde9b8135a776ac4147575862165d4399edf0 | Robert Jackson | Robert Jackson | Merge pull request #11313 from rwjblue/deprecate-template
[BUGFIX beta] Allow deprecated access to `template` in component. | merge pull request from rwjblue/deprecate-template | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 12,070 |
308ca404a99e1495eb00e4a929c677b1fd737e4f | Robert Jackson | Robert Jackson | Merge pull request #11338 from emberjs/glimmer-optimizations
Glimmer optimizations | merge pull request from emberjs/glimmer-optimizations | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 12,071 |
d1d993d1becc0802169790c7858e7074592adbcc | Tom Dale | Tom Dale | Make the `env` more generally consistent (JIT)
Previously, the `env` was a bag of properties, and got frequently
extended or modified (in largely predictable ways).
The consequence is that even though the environment is conceptually a
single concept, it got treated internally as a megamorphic shapeless
entity. For what it’s worth, this JIT confusion was somewhat mirrored
by a confusion when reading the code: it was never precisely clear what
the `env` would look like from the perspective of a human reader.
This commit changes the environment to be a single class. There are only
two kinds of child environments (a change in the `view` and a change to
`outletState`), and there are now methods on `env` to make that simple
and predictable.
The consequence is that all methods that take an `env` now go down a
fast path when accessing it, and human readers of the code can feel
confident about what the environment looks like. | make the `env` more generally consistent (jit) | 46 | false | false | 7 | false | true | false | emberjs | ember.js | 12,072 |
b9020834ad51cd414678c8b3101c92907b539f2e | Tom Dale | Tom Dale | Fix a case where AttrMorph was being extended | fix a case where attrmorph was being extended | 45 | false | false | 8 | true | true | true | emberjs | ember.js | 12,073 |
25507d3b223e19b6ff0163c8d8ba4ea12465499f | Tom Dale | Tom Dale | Fix bug where parent/ownerView was incorrect
Previously, `parentView` and `ownerView` were set based on `scope`,
which is the “owner tree”. However, it should be based on the
component tree instead.
This commit properly wires up `parentView` and `ownerView`, while
maintaining the correct semantics for the `{{view.foo}}` keyword in
both legacy views and components. | fix bug where parent/ownerview was incorrect | 44 | false | false | 6 | true | true | true | emberjs | ember.js | 12,074 |
53b9f19a8fd737ed9dfede59316ec83825de44d2 | Tom Dale | Tom Dale | Change `assign` to not use a for-in loop
Apparently, v8’s JIT engineers require that we, as JavaScript developers
perform this very simple transformation, since they do not seem capable
of performing it themselves. | change `assign` to not use a for-in loop | 40 | false | false | 8 | false | true | false | emberjs | ember.js | 12,075 |
78f4df640955915e0b30c6ad174d60771d5ca624 | Robert Jackson | Robert Jackson | Failing test for {{component}} keyword teardown.
Currently, the `{{component}}` keyword does not teardown previously created components
when swapping. This test demonstrates that. | failing test for {{component}} keyword teardown | 47 | false | false | 6 | false | false | false | emberjs | ember.js | 12,076 |
34f80676d052a373330a826543950e6c52f9379a | Robert Jackson | Robert Jackson | [BUGFIX beta] Allow deprecated access to `template` in component.
This adds deprecated support for checking `this.get('template')` in a
component for determining if the component was invoked with a block or not.
This is deprecated in favor of using `{{#if hasBlock}}{{/if}}` in the components
layout. | [bugfix beta] allow deprecated access to `template` in component | 64 | false | false | 9 | false | false | false | emberjs | ember.js | 12,077 |
e89dc6da1d0bf5be2b569fb5e52ae9d8d8da9d33 | Robert Jackson | Robert Jackson | Merge pull request #11323 from rwjblue/fix-builds-publishing
Fix canary build publishing. | merge pull request from rwjblue/fix-builds-publishing | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 12,078 |
8ba5e69dfd61ecab92cc6868f91f3dc445aa0fd4 | Robert Jackson | Robert Jackson | Fix canary build publishing.
ember-cli-yuidoc was updated, but the docs script was not updated to the
new command name. This caused the publishing of builds to fail. | fix canary build publishing | 27 | false | false | 4 | true | false | true | emberjs | ember.js | 12,079 |
04f9b148b8d026329e0fe21be286536196c291c4 | Trek Glowacki | Trek Glowacki | Update QP tests to avoid deprecarted {{#each}} style | update qp tests to avoid deprecarted {{#each}} style | 52 | false | false | 8 | true | true | false | emberjs | ember.js | 12,080 |
5b47245619b477c5748ec23d292fad3be35b877a | Trek Glowacki | Trek Glowacki | Merge branch 'master' into configure-query-params-in-route | merge branch 'master' into configure-query-params-in-route | 58 | true | false | 5 | false | true | false | emberjs | ember.js | 12,081 |
023438cae4ecf4f8dff079ea89df4b309e53f18e | Trek Glowacki | Trek Glowacki | Merge branch 'master' into configure-query-params-in-route
Conflicts:
packages/ember-routing/lib/system/route.js | merge branch 'master' into configure-query-params-in-route | 58 | true | false | 5 | false | true | false | emberjs | ember.js | 12,082 |
7ac9950e16d75bb00f12c9a15554cfe1c4c6fd7b | Robert Jackson | Robert Jackson | Merge pull request #11322 from rwjblue/properly-allow-view-to-not-have-_transitionTo
[BUGFIX beta] Do not require a view being rendered to have `_transitionTo`. | merge pull request from rwjblue/properly-allow-view-to-not-have-_transitionto | 78 | true | false | 5 | true | false | false | emberjs | ember.js | 12,083 |
4bd690ec968fb92d3c60bd9193c6cf38760fc6b8 | Robert Jackson | Robert Jackson | Merge pull request #11317 from jaswilli/visit-regression
[BUGFIX release] Ensure handleURL called after setURL in visit helper | merge pull request from jaswilli/visit-regression | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 12,084 |
b4ce0e5734d5e4b6e26bc56afdcf59e02dcb2e4a | Robert Jackson | Robert Jackson | [BUGFIX beta] Do not require a view being rendered to have `_transitionTo`.
In the majority of places in the renderer we were already guarding for `_transitionTo`
being undefined, but these didn't guard.
Added the guard for consistency. | [bugfix beta] do not require a view being rendered to have `_transitionto` | 74 | false | false | 12 | false | false | false | emberjs | ember.js | 12,085 |
1ce579637257f39fb5b6ce5db87df9da379a3253 | Robert Jackson | Robert Jackson | Merge pull request #11320 from rwjblue/use-stamp-for-factory-check
[BUGFIX beta] Use stamp to detect View/Component factory or instance. | merge pull request from rwjblue/use-stamp-for-factory-check | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 12,086 |
4200641b9142e1f85ed782302c17a94236dab715 | Robert Jackson | Robert Jackson | [BUGFIX beta] Use brand to detect View/Component factory or instance. | [bugfix beta] use brand to detect view/component factory or instance | 68 | false | false | 10 | false | false | false | emberjs | ember.js | 12,087 |
f869e4ba68c54444b2a800a724b4869a94884a5f | Jason Williams | Jason Williams | [BUGFIX release] Ensure handleURL called after setURL in visit helper
Refs #11201 | [bugfix release] ensure handleurl called after seturl in visit helper | 69 | false | false | 10 | false | false | false | emberjs | ember.js | 12,088 |
f9328616fd6cee5c80f2895b1c08efda2f636442 | Robert Jackson | Robert Jackson | Merge pull request #11314 from rwjblue/prevent-protocol-warnings
[BUGFIX beta] Prevent `unsafe:` protocol popups in test suite. | merge pull request from rwjblue/prevent-protocol-warnings | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 12,089 |
4eab5d865f2ab9a5836243a34cf94ad8bfcbc30b | Robert Jackson | Robert Jackson | [BUGFIX beta] Prevent `unsafe:` protocol popups in test suite.
When running the test suite under Safari (before these changes) you would have
a number of popups regarding the `unsafe:` protocol not having an application
associated.
The warning was triggered on Safari when the element is inserted into the DOM, this
change swaps from `view.appendTo` to `view.createElement()`. `createElement()` adds
the element but does not insert into the DOM (allowing us to do the assertions we need
but preventing this annoying popup). | ` protocol popups in test suite | 31 | false | false | 6 | false | false | false | emberjs | ember.js | 12,090 |
7e9cec43a75747e0745ac7e60611eb611b33bfbc | Robert Jackson | Robert Jackson | Merge pull request #11309 from splattne/patch-1
Change {{each ...}} to {{#each ...}} in deprecation messages | merge pull request from splattne/patch-1 | 41 | true | false | 5 | true | false | false | emberjs | ember.js | 12,091 |
23c36f5181ed00611692003f1fd57cfc1475f0bc | Stefan Plattner | Stefan Plattner | Fix deprecation test messages to {{#each ...}} | fix deprecation test messages to {{#each ...}} | 46 | false | false | 7 | true | true | true | emberjs | ember.js | 12,092 |
e88ed22076c8ec6838a40fee7383454589045b2a | Robert Jackson | Robert Jackson | Merge pull request #11310 from rwjblue/remove-workaround-for-htmlbars-issue
[FEATURE ember-htmlbars-get-helper] Remove work-around for HTMLBars bug in inline/subexpr. | merge pull request from rwjblue/remove-workaround-for-htmlbars-issue | 69 | true | false | 5 | true | false | false | emberjs | ember.js | 12,093 |
eacbc49de011be8d9545395a6d53610bf5f40e07 | Robert Jackson | Robert Jackson | [FEATURE ember-htmlbars-get-helper] Remove work-around for HTMLBars bug in inline/subexpr. | [feature ember-htmlbars-get-helper] remove work-around for htmlbars bug in inline/subexpr | 89 | false | false | 9 | false | false | false | emberjs | ember.js | 12,094 |
990820eed3b423f55a90c8435ea82b3d2a314975 | Robert Jackson | Robert Jackson | Merge pull request #11307 from mitchlloyd/inline-if
Failing test for inline if | merge pull request from mitchlloyd/inline-if | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 12,095 |
9dcefbec19ee2a232b5b8bc4c2c25ce7319f0464 | Mitch Lloyd | Mitch Lloyd | [BUGFIX beta] Bump HTMLBars to fix inline if
Fixes #11306 | [bugfix beta] bump htmlbars to fix inline if | 44 | false | false | 8 | false | false | false | emberjs | ember.js | 12,096 |
6a1fbb4f516b68c88f35e1b73d297b4c14fd7bd4 | Stefan Plattner | Stefan Plattner | Change {{each ...}} to {{#each ...}} in deprecation messages
Deprecation message for `{{#each foo in bar}}` should show the right syntax; `{{#each ...}}` instead of `{{each ...}}` | change {{each ...}} to {{#each ...}} in deprecation messages | 60 | false | false | 9 | false | true | false | emberjs | ember.js | 12,097 |
9e8fd04161da9a398c67c42261c6aee60f10683a | Robert Jackson | Robert Jackson | Expose `{{concat}}` helper publicly. | expose `{{concat}}` helper publicly | 35 | false | false | 4 | false | true | false | emberjs | ember.js | 12,098 |
1b5adaa65d20af4f4e57702ea34aa0dcc42e1489 | Robert Jackson | Robert Jackson | Merge pull request #11285 from jbrown/patch-6
[DOC] Favor not using prototype extensions. | merge pull request from jbrown/patch-6 | 39 | true | false | 5 | true | false | false | emberjs | ember.js | 12,099 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.