sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
2910fceb5429469a61829c263f20b1bd261cbf48 | Godfrey Chan | GitHub | Merge pull request #14154 from emberjs/glimmer-mount
[GLIMMER] Introduce mount syntax. | merge pull request from emberjs/glimmer-mount | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 8,800 |
adab3f9089af09c217124348c792007abbb8522c | Dan Gebhardt | Godfrey Chan | [GLIMMER] Introduce mount syntax. | [glimmer] introduce mount syntax | 32 | false | false | 4 | false | false | false | emberjs | ember.js | 8,801 |
6378dc148185c71142a8613e6e166811075ae80c | Godfrey Chan | GitHub | Merge pull request #14144 from emberjs/render-to-element-tests
[WIP] Migrate renderToElement tests | merge pull request from emberjs/render-to-element-tests | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 8,802 |
b287dd13b775d2a884102b9a381b63bbaf2a84af | Godfrey Chan | Godfrey Chan | Remove unused test helpers | remove unused test helpers | 26 | false | false | 4 | true | true | true | emberjs | ember.js | 8,803 |
518669ed061f2809737e359f86458447a1c55b13 | Robert Jackson | Robert Jackson | Add 2.8.0-beta.4 to CHANGELOG.md.
[ci skip]
(cherry picked from commit c50cf7569fda3ac9f1135c10e9686747b47b52cf) | add 2.8.0-beta.4 to changelog.md | 32 | false | false | 4 | true | true | true | emberjs | ember.js | 8,804 |
c5722a16ed21402cbf17a1918bfec8db684db0a8 | Godfrey Chan | Godfrey Chan | Migrate renderToElement tests | migrate rendertoelement tests | 29 | false | false | 3 | false | true | false | emberjs | ember.js | 8,805 |
80e0acee3b58a1b50719e19b87b631c8a17d6ea9 | Ricardo Mendes | Ricardo Mendes | [DOC release] Update `didInsertElement` documentation.
It was still mentioned that `didInsertElement` was called both on
first render but also in re-renders.
I also tried to simplify the last sentence of the documentation
to remove the idea of bubbling and thus, of re-triggering the
parent `didInsertElement` on child re-render. | [doc release] update `didinsertelement` documentation | 53 | false | false | 5 | false | false | false | emberjs | ember.js | 8,806 |
aadb2e092aed9d4efbce9ee348f2b248d855f6f9 | Doug Yun | Doug Yun | [BUGFIX beta] Removes `this._environment` guard
Fixes #14029
Related to #14085 | [bugfix beta] removes `this._environment` guard | 47 | false | false | 5 | false | false | false | emberjs | ember.js | 8,807 |
69cedc133b1df24c46f96cccbb775e138e67cd7f | Robert Jackson | GitHub | Merge pull request #14147 from dgeb/engine-should-render
Expand visit tests for routable engines and shouldRender flag. | merge pull request from dgeb/engine-should-render | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 8,808 |
70bb5550d7534af331176b036d20f811af6b7b90 | Dan Gebhardt | Dan Gebhardt | Expand visit tests for routable engines and shouldRender flag.
Include identical tests that vary only whether `shouldRender` is `true`
or `false`, confirming that model hooks are invoked in both cases. | expand visit tests for routable engines and shouldrender flag | 61 | false | false | 9 | true | true | false | emberjs | ember.js | 8,809 |
01110cb48f224790e717a15a0e5525e793ec5e23 | Robert Jackson | GitHub | Merge pull request #14146 from rwjblue/use-reexports-instead-of-cross-package-deep-imports
Use index reexports from container instead of cross package deep imports. | merge pull request from rwjblue/use-reexports-instead-of-cross-package-deep-imports | 84 | true | false | 5 | true | false | false | emberjs | ember.js | 8,810 |
62cce5dfee44137fd590149705b534e6973e5886 | Robert Jackson | Robert Jackson | Use index reexports instead of cross package deep imports.
As we implement this, we will be able to do much more intelligent build things. | use index reexports instead of cross package deep imports | 57 | false | false | 9 | true | true | false | emberjs | ember.js | 8,811 |
5fa57d8e650ca8542cb63ebcff772be6ffdbe3c8 | Robert Jackson | GitHub | Merge pull request #14145 from rwjblue/use-relative-requires
Use relative imports throughout packages/*/lib/**/*.js. | merge pull request from rwjblue/use-relative-requires | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 8,812 |
cbd680c42fba2fff7fed581ed33511a11b6eb8ab | Robert Jackson | Robert Jackson | Use relative imports in ember-testing. | use relative imports in ember-testing | 37 | false | false | 5 | true | true | true | emberjs | ember.js | 8,813 |
94d379d95f992c395ffae407d7df92589c7cc0a5 | Robert Jackson | Robert Jackson | Use relative imports in ember-htmlbars. | use relative imports in ember-htmlbars | 38 | false | false | 5 | true | true | true | emberjs | ember.js | 8,814 |
e7d3881aeb56c443609aead95c48083721107d13 | Robert Jackson | Robert Jackson | Use relative imports in ember-extension-support. | use relative imports in ember-extension-support | 47 | false | false | 5 | true | true | true | emberjs | ember.js | 8,815 |
890db01442b8a1f7753947399d13e3a7fe0933d0 | Robert Jackson | Robert Jackson | Use relative imports in ember-debug. | use relative imports in ember-debug | 35 | false | false | 5 | true | true | true | emberjs | ember.js | 8,816 |
7dab3b1fbb19d27f088cbe347a5202c2ab281112 | Robert Jackson | Robert Jackson | Use relative imports in ember-views. | use relative imports in ember-views | 35 | false | false | 5 | true | true | true | emberjs | ember.js | 8,817 |
c56e2152b4d01b38a4c4e227e8e4ca295fb46da0 | Robert Jackson | Robert Jackson | Use relative imports in ember-template-compiler. | use relative imports in ember-template-compiler | 47 | false | false | 5 | true | true | true | emberjs | ember.js | 8,818 |
7f6cf8cfa3752d41956bd9ff086f8ee1469cef42 | Robert Jackson | Robert Jackson | Use relative imports for ember-application. | use relative imports for ember-application | 42 | false | false | 5 | true | true | true | emberjs | ember.js | 8,819 |
6aa70081f55feefc106b2c2cfaae369ab8d74d60 | Robert Jackson | Robert Jackson | Use relative imports for container. | use relative imports for container | 34 | false | false | 5 | true | true | true | emberjs | ember.js | 8,820 |
9a28659e5c0b029d3d0dbdc3fddb5cd116c484d5 | Robert Jackson | Robert Jackson | Use relative imports for ember-routing. | use relative imports for ember-routing | 38 | false | false | 5 | true | true | true | emberjs | ember.js | 8,821 |
ba0803de837b2bb29ea387f5bc1122e3fc032ee6 | Robert Jackson | GitHub | Merge pull request #14143 from teddyzeenny/view-utils
Expose `getRootViews and `getClientViews` on `ViewUtils` | merge pull request from teddyzeenny/view-utils | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 8,822 |
dfbb59fa85cce50cba299b5fdbb85b89a28e07fa | Teddy Zeenny | Teddy Zeenny | Expose `getViewBounds` on `ViewUtils` | expose `getviewbounds` on `viewutils` | 37 | false | false | 4 | true | true | true | emberjs | ember.js | 8,823 |
7b7b9bb2c50111ba780328285d95ab19734e1b7b | Teddy Zeenny | Teddy Zeenny | Expose `getRootViews and `getClientViews` on `ViewUtils` | expose `getrootviews and `getclientviews` on `viewutils` | 56 | false | false | 6 | false | true | false | emberjs | ember.js | 8,824 |
8a49ddd78f8f20bc66c145817b2be51099c248ce | Godfrey Chan | GitHub | Merge pull request #14139 from emberjs/lazy-child-views
😪 Make `view.childViews` lazy | merge pull request from emberjs/lazy-child-views | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 8,825 |
8f3c5b55938e94feb4ecc743ffaa976a9d93ea78 | Godfrey Chan | Godfrey Chan | IE9 doesn’t seem to be fully spec-compliant here | ie9 doesn’t seem to be fully spec-compliant here | 48 | false | false | 8 | false | false | false | emberjs | ember.js | 8,826 |
4e5ddaec612997aba719b6c7e62627eb87bc96e9 | Godfrey Chan | Godfrey Chan | 😪 Make `view.childViews` lazy
🆕 `getRootViews` return an array of “top-level” components
🆕 `getChildViews` to replace `view.childViews` (to be deprecated 🔜)
🆕 “tagless” components are registered in the view-registry with a GUID
🆒 `view.childViews` is now a getter that delegates to `getChildViews`
🆓 `view.childViews` no longer leak destroyed components (bug in beta)
🔙 `view.childViews` now tracks updates (components added or removed
during updates) correctly, which was unreliable since 1.13
Instead of tracking `childView` instances, we now track a list of IDs
that can be used to look them up in the view registry. This has the
benefit of not holding a reference to the view instance – thus do not
require cleanup when the child views are destroyed.
When requested, we lazily query the view registry to reify the (still)
live children and cleanup and stale IDs while we are at it.
This approach does leak the string IDs of destroyed components, however
the effect is believed to be minimal. If this ended up causing problems,
we can be smarter about this, such as tracking the number of removals
and schedule a collection (outside of the render loop) when a view has
accumulated enough removals. | 😪 make `view.childviews` lazy | 29 | false | false | 4 | false | false | false | emberjs | ember.js | 8,827 |
48e52b3d267d62e1c28d192a4679f25d669eb7d7 | Godfrey Chan | Godfrey Chan | Introduce a way to make ES5 getters from `Mixin`s | introduce a way to make es5 getters from `mixin`s | 49 | false | false | 9 | true | true | true | emberjs | ember.js | 8,828 |
5840266f5f5011df007224dfb4a9ef24bfc532d7 | Godfrey Chan | Godfrey Chan | [CLEANUP] Make `ApplicationTest` have `runTask` | [cleanup] make `applicationtest` have `runtask` | 47 | false | false | 5 | false | false | false | emberjs | ember.js | 8,829 |
cb429a0261378de5b19a6215f8f07e8fc21e18d8 | Godfrey Chan | Godfrey Chan | [CLEANUP] Glimmer 2 does not need `ownerView`
We also don’t need to propagate `parentView` in `linkChild` anymore:
since 9228bb8, `parentView` is supplied via the “create props” for both
engines to ensure that it is available during `init`. | [cleanup] glimmer 2 does not need `ownerview` | 45 | false | false | 7 | false | false | false | emberjs | ember.js | 8,830 |
6fc0790bb4092d71da88cda570c86d770ae46bac | Godfrey Chan | Godfrey Chan | [CLEANUP] Remove childViews cleanup logic
This is dead code, we don’t actually call these methods anywhere in the
codebase anymore. | [cleanup] remove childviews cleanup logic | 41 | false | false | 5 | false | false | false | emberjs | ember.js | 8,831 |
d78c0dd1415ed6b49ab97b966ef650e8d5be3b35 | Godfrey Chan | Godfrey Chan | Use a dictionary for the view registry | use a dictionary for the view registry | 38 | false | false | 7 | true | true | true | emberjs | ember.js | 8,832 |
c5b10f156ae3216b63e6946ee7d311625c71db88 | Robert Jackson | GitHub | Merge pull request #14140 from rwjblue/cleanup-engine-registry-setup
[BUGFIX beta] Ensure injections happen in engine instances. | merge pull request from rwjblue/cleanup-engine-registry-setup | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 8,833 |
831c8cbbc82fa5b5b01b3eaf050b45778bf803e6 | Robert Jackson | Robert Jackson | [GLIMMER] Ensure all components have injections.
Prior to this change we were defaulting to `Ember.Component` which does
not receive injections (which meant it was missing the `renderer`).
This worked "ok" in HTMLBars since we created a default global renderer
to handle components/views without a container/owner.
This change ensures that in the template only component case we fall
back to using the default component looked up from the owner. This
ensures that injections are present. | [glimmer] ensure all components have injections | 47 | false | false | 6 | false | false | false | emberjs | ember.js | 8,834 |
3de2360772f1f542c06f46e62d096b269e77361b | Robert Jackson | Robert Jackson | [BUGFIX beta] Ensure injections happen in engine instances.
Prior to this `_environment` could not be relied upon in routes or
views (which is used when `shouldRender: false` is used with `visit`).
The refactor uses the environment to determine what injections to setup
in the engine-instance, and has the `application-instance` defer to the
`engine-instance` to avoid duplication. | [bugfix beta] ensure injections happen in engine instances | 58 | false | false | 8 | false | false | false | emberjs | ember.js | 8,835 |
e19a71d490c2bf3dc82de80eb553f450358e52f6 | Robert Jackson | GitHub | Merge pull request #14135 from emberjs/glimmer-owner
[BUGFIX beta] Fix basic component and helper resolution in engines. | merge pull request from emberjs/glimmer-owner | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 8,836 |
02814c2da26a1558fb06eb527ef83e829dae7016 | Robert Jackson | Robert Jackson | Use the correct owner for each template lookup.
Ensure that the owner being used is not the environments default
`Owner`, but it is the owner that the template is being looked up by.
For late bound templates this means the components owner, and for normal
templates (looked up from registry) it is passed to the factories
`.create` method by the container itself. | use the correct owner for each template lookup | 46 | false | false | 8 | true | true | true | emberjs | ember.js | 8,837 |
447df33c4db30c475a08415196dbb7012f08cc07 | asakusuma | Robert Jackson | [BUGFIX beta] Fix basic component and helper resolution in engines.
Ensure that Cache lookups are performed using the correct owner.
Ensure that engines are destroyed _before_ top-level views so that top-level
views are not re-instantiated during engine teardown. | [bugfix beta] fix basic component and helper resolution in engines | 66 | false | false | 10 | false | false | false | emberjs | ember.js | 8,838 |
79026a7a645021ace0cdf1cd3971ac4df3877430 | Dan Gebhardt | Robert Jackson | [BUGFIX beta] Clone additional parent dependencies into engine instances.
An engine instance needs to share the following with its parent:
* `service:-glimmer-environment` (only for glimmer)
* `renderer:-dom` or `renderer:-inert`, depending on whether the environment
is interactive | [bugfix beta] clone additional parent dependencies into engine instances | 72 | false | false | 9 | false | false | false | emberjs | ember.js | 8,839 |
b769492642b9c2170c0f997b979055b6d3da0d7e | Robert Jackson | GitHub | Merge pull request #14134 from emberjs/update-glimmer-threading-symbol-table
Update Glimmer to 0.11.0. | merge pull request from emberjs/update-glimmer-threading-symbol-table | 70 | true | false | 5 | true | false | false | emberjs | ember.js | 8,840 |
ca443d01d22409da0c1001557e0852017654045e | Robert Jackson | Robert Jackson | Update Glimmer to 0.11.0.
* Threads `SymbolTable` throughout the system instead of `blockMeta`.
* Change a few argument signatures for Glimmer syntax's (moving from
options hash to positional, etc). | update glimmer to 0.11.0 | 24 | false | false | 4 | true | true | true | emberjs | ember.js | 8,841 |
fa82fe78cd549c35ce363bce26253125f41160c4 | Ricardo Mendes | GitHub | Merge pull request #14034 from Serabe/fix/13771
[DOC release] Extend `Route.paramsFor` documentation | merge pull request from serabe/fix/13771 | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 8,842 |
ac93fc759d762728935a875c030f73d124814c8a | Robert Jackson | GitHub | Merge pull request #14130 from emberjs/components-instrumentation
[GLIMMER2] Component instrumentation support | merge pull request from emberjs/components-instrumentation | 59 | true | false | 5 | true | true | false | emberjs | ember.js | 8,843 |
238b57ec39c3befebd47d68ed4eedc891b1a3059 | Godfrey Chan | Godfrey Chan | [GLIMMER2] Component instrumentation support
Added support for the following instrumentation events:
- render.component
- render.outlet (new)
Previously, all outlets are backed by an “OutletView” instance. Since we
don’t do that anymore, I have to replace that with a new event to make
the test pass.
The `render.component` event also gets a new `initialRender` field in
the payload that indicates whether this is an initial render or a
re-render. | [glimmer2] component instrumentation support | 44 | false | false | 4 | false | false | false | emberjs | ember.js | 8,844 |
f97598ea6916dfa9094569715933a5e9c060a34d | Robert Jackson | GitHub | Merge pull request #14132 from rwjblue/use-relative-imports-for-same-package
Use relative imports (part 1). | merge pull request from rwjblue/use-relative-imports-for-same-package | 70 | true | false | 5 | true | false | false | emberjs | ember.js | 8,845 |
b70c72d7a5817b06dad58d5dd00d6d59051106f1 | Robert Jackson | GitHub | Merge pull request #14117 from mmun/call-array-proxy-content-change-hooks
[BUGFIX beta] Call ArrayProxy's content change hooks | merge pull request from mmun/call-array-proxy-content-change-hooks | 67 | true | false | 5 | true | false | false | emberjs | ember.js | 8,846 |
aa76fcff3346304f4612868c15490d5872f43e43 | Robert Jackson | Robert Jackson | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | use relative imports | 20 | false | false | 3 | true | true | true | emberjs | ember.js | 8,847 |
ac07da7b52838830466fcb9a8753dad6cc09a9a7 | Godfrey Chan | GitHub | Merge pull request #14129 from emberjs/bounds-snapshot
Make `getViewBounds` return a snapshot | merge pull request from emberjs/bounds-snapshot | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 8,848 |
996dee2d8097a8d83aaac828d5ef0525b13cac87 | Godfrey Chan | Godfrey Chan | Make `getViewBounds` return a snapshot
This avoids leaking the internals on the RenderNode (htmlbars) and
Tracker (glimmer) objects, and works for all the known use cases (Ember
Inspector and Liquid Fire). | make `getviewbounds` return a snapshot | 38 | false | false | 5 | false | true | false | emberjs | ember.js | 8,849 |
59ea782713f2ac1f1481ecc8df5a053a48f25df4 | Robert Jackson | GitHub | Merge pull request #14119 from emberjs/fix-toplevel
Fix toplevel | merge pull request from emberjs/fix-toplevel | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 8,850 |
31b9f39d93d3147478d0c6cbc689dead23fccf10 | Robert Jackson | Robert Jackson | Migrate appendTo tests to new infrastructure. | migrate appendto tests to new infrastructure | 44 | false | false | 6 | false | true | false | emberjs | ember.js | 8,851 |
3b9c02b58626e6ab015b4916b808069494db8f15 | Robert Jackson | Robert Jackson | [GLIMMER] Share assertions between ROOT_MANAGER and MANAGER. | [glimmer] share assertions between root_manager and manager | 59 | false | false | 7 | false | false | false | emberjs | ember.js | 8,852 |
86a95076ecc3e2afdfb8614d0cd9ae14167104ef | Kris Selden | Robert Jackson | [GLIMMER] Enable Component#appendTo usage. | [glimmer] enable component#appendto usage | 41 | false | false | 4 | false | false | false | emberjs | ember.js | 8,853 |
daf2a91682331508b99d4c083e9ecef88c6dc9f9 | Robert Jackson | GitHub | Merge pull request #14126 from rwjblue/wat
Prevent JIT related issue with Safari + method named apply. | merge pull request from rwjblue/wat | 36 | true | false | 5 | true | false | false | emberjs | ember.js | 8,854 |
e8e12b302923457c0bd3d876454753fcbb935419 | Robert Jackson | Robert Jackson | Prevent JIT related issue with Safari + method named apply.
When this test URL is ran in Safari with the devtools closed:
```
/tests/index.html?hideskipped&hidepassed&enableoptionalfeatures&seed=5rbluti5zsr¬rycatch
```
Against ffde3384b65647790de00aaf712e23e92ac38258
The following error is thrown:
```
TypeError: undefined is not an object (evaluating 'parsed[0]')
apply@http://localhost:7200/ember.debug.js:12504:24
applyAttributeBindings@http://localhost:7200/ember.debug.js:11478:58
didCreateElement@http://localhost:7200/ember.debug.js:11680:31
evaluate@http://localhost:7200/ember.debug.js:57533:37
execute@http://localhost:7200/ember.debug.js:63697:36
render@http://localhost:7200/ember.debug.js:63246:30
render@http://localhost:7200/ember.debug.js:11258:52
runInTransaction@http://localhost:7200/ember.debug.js:30852:17
transaction@http://localhost:7200/ember.debug.js:11280:43
_transaction@http://localhost:7200/ember.debug.js:11287:22
_renderRoot@http://localhost:7200/ember.debug.js:11295:24
appendOutletView@http://localhost:7200/ember.debug.js:11176:23
appendTo@http://localhost:7200/ember.debug.js:13986:58
didCreateRootView@http://localhost:7200/ember.debug.js:4003:20
_setOutlets@http://localhost:7200/ember.debug.js:36065:35
invoke@http://localhost:7200/ember.debug.js:1068:20
flush@http://localhost:7200/ember.debug.js:1132:17
flush@http://localhost:7200/ember.debug.js:938:22
end@http://localhost:7200/ember.debug.js:250:30
run@http://localhost:7200/ember.debug.js:372:21
run@http://localhost:7200/ember.debug.js:30055:32
bootApplication@http://localhost:7200/ember-tests.js:97711:32
http://localhost:7200/ember-tests.js:98835:20
runTest@http://localhost:7200/qunit/qunit.js:843:32
run@http://localhost:7200/qunit/qunit.js:823:11
http://localhost:7200/qunit/qunit.js:970:14
process@http://localhost:7200/qunit/qunit.js:629:24
begin@http://localhost:7200/qunit/qunit.js:611:9
http://localhost:7200/qunit/qunit.js:671:9
```
It seems that all arguments to `AttributeBindings.apply` after the
second (`parsed` and `operations` in this case) are `undefined`.
Renaming the method from `apply` to `install` resolves the error.
:sob: :sob: :sob: :sob: :sob: :sob: :sob: :sob: | prevent jit related issue with safari + method named apply | 58 | false | false | 10 | false | false | false | emberjs | ember.js | 8,855 |
ffde3384b65647790de00aaf712e23e92ac38258 | Robert Jackson | GitHub | Merge pull request #14123 from rwjblue/fix-router-teardown
[BUGFIX beta] Avoid rerendering outlet state during router destruction. | merge pull request from rwjblue/fix-router-teardown | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 8,856 |
c94d277b82e57962953ccf601b8862016cb46f29 | Robert Jackson | GitHub | Merge pull request #14122 from rwjblue/fix-test-cleanup
Fix test failures when randomized. | merge pull request from rwjblue/fix-test-cleanup | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 8,857 |
890fb044a20047119277497b35e255c52c6d1cb7 | Robert Jackson | Robert Jackson | [BUGFIX beta] Avoid rerendering outlet state during router destruction.
During each `Ember.Route`'s `willDestroy` we trigger a
`run.once(this.router, '_setOutlets');`. This is so that the routes
views are destroyed properly (by removing them from the outlet state).
During `Ember.Router`'s `willDestroy` we clear
`this._toplevelView` (along with a bunch of other cleanup).
These two things combined can mean that `this._toplevelView` is `null`
when `_setOutlets` is called again (during the `Router`'s destruction).
In that scenario we are actually creating another
`this._toplevelView` and setting up another rendered root (since one
doesn't exist). When this happens the newly created root is never
cleaned up, since the Router's `willDestroy` has already ran and can no
longer clean up after itself. | [bugfix beta] avoid rerendering outlet state during router destruction | 70 | false | false | 9 | false | false | false | emberjs | ember.js | 8,858 |
029968601abcd0f2d15e3d0ad420969c0e4653c3 | Robert Jackson | GitHub | Merge pull request #14121 from HeroicEric/better-quoteless-error-assertion
Provide better error for non-resolving quoteless action | merge pull request from heroiceric/better-quoteless-error-assertion | 68 | true | false | 5 | true | false | false | emberjs | ember.js | 8,859 |
588a698c732f78b2ed7392d6240d79b9476e9a6f | Robert Jackson | Robert Jackson | Prevent reordering when using `seed` URL config. | prevent reordering when using `seed` url config | 47 | false | false | 7 | true | false | true | emberjs | ember.js | 8,860 |
632ecdb07826f16cb1e7cf7a5afecc9d6ae71414 | Robert Jackson | Robert Jackson | Fix issues with test cleanup. | fix issues with test cleanup | 28 | false | false | 5 | true | true | true | emberjs | ember.js | 8,861 |
5f1bcec8a13fa768cffe10f7abe76a21e503f245 | Eric Kelly | Eric Kelly | Provide better error for non-resolving quoteless action
This makes a slight improvement to the assertion that is raised when a
quoteless path is used to specify an action by including additional
information to help track down which `{{action}}` invocation is
triggering the assertion. | provide better error for non-resolving quoteless action | 55 | false | false | 7 | true | true | false | emberjs | ember.js | 8,862 |
fa7d1522a019954c37412880a87e3f4ed1dab20c | Robert Jackson | GitHub | Merge pull request #14110 from rwjblue/fix-toplevel-tree-destruction
[BUGFIX beta] Fix issues with revalidation during teardown. | merge pull request from rwjblue/fix-toplevel-tree-destruction | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 8,863 |
ec80bbfa76b9e46d83ca6502cb6fdd525764ba12 | Godfrey Chan | GitHub | Merge pull request #14118 from emberjs/fix-is-object-deopt
Fix isObject deopt | merge pull request from emberjs/fix-is-object-deopt | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 8,864 |
f1971a8ff50b0c454f7a6da92316f70ea2bcbe10 | Godhuda | Godhuda | Fix isObject deopt
This deopts the ChainNode constructor because inlining
Fixes #14113 | fix isobject deopt | 18 | false | false | 3 | false | true | false | emberjs | ember.js | 8,865 |
664172b7aed92461032673d12c482abfad0a1fb3 | Godfrey Chan | GitHub | Merge pull request #14116 from emberjs/rm-controller
[CLEANUP GLIMMER2] Remove unused `controller` | merge pull request from emberjs/rm-controller | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 8,866 |
0c2a3f0e2a42ac151236221dce3b673d7caa7120 | Martin Muñoz | Martin Muñoz | [BUGFIX beta] Call ArrayProxy's content change hooks
Provides some temporary relief for #14114. | [bugfix beta] call arrayproxy's content change hooks | 52 | false | false | 7 | false | false | false | emberjs | ember.js | 8,867 |
5f5b9ae5f8c117c3dc45409b7f0d2272f042cb68 | Godfrey Chan | GitHub | Merge pull request #14115 from emberjs/component-bounds
[GLIMMER2] Implement `getViewBounds` for components | merge pull request from emberjs/component-bounds | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 8,868 |
6b7bcde1f26deefe0604fed309cc9f89b4f71dda | Godhuda | Godhuda | [CLEANUP GLIMMER2] Remove unused `controller`
This was added for the purpose of threading through the `targetObject`,
but we now track it explicitly so this is just a pointless duplication. | [cleanup glimmer2] remove unused `controller` | 45 | false | false | 5 | false | false | false | emberjs | ember.js | 8,869 |
5a143323cd40ef1a1c50420873be140498773473 | Godfrey Chan | Godfrey Chan | Bump Glimmer | bump glimmer | 12 | true | false | 2 | true | true | false | emberjs | ember.js | 8,870 |
d79462362c6cd966723061d497fd55e290427bec | Godfrey Chan | Godfrey Chan | [GLIMMER2] args refactor | [glimmer2] args refactor | 24 | false | false | 3 | false | false | false | emberjs | ember.js | 8,871 |
fcdb9b9bce12e0a71613683aaeb3df041a786703 | Godfrey Chan | Godfrey Chan | [GLIMMER2] Implement `getViewBounds` | [glimmer2] implement `getviewbounds` | 36 | false | false | 3 | false | false | false | emberjs | ember.js | 8,872 |
2fa40155c62315c5c5db9c18bcd409cfad288962 | Robert Jackson | Robert Jackson | [BUGFIX beta] Prevent issues with revalidation during teardown.
When the toplevelView (aka `ownerView`) is being destroyed (during test
teardown generally) an error was ocurring under certain "special"
circumstances. Specifically, if removal of a sibling node triggered a
revalidation of one still attached.
Consider the following example:
```hbs
{{#x-select as |select|}}
{{#select.option value="1"}}{/select.option}}
{{#select.option value="2"}}{/select.option}}
{{/x-select}}
```
The components in question are using the registration pattern so that
the children notify/register with the parent upon `didInsertElement`
(and `willDestroyElement`).
When a new option is added or removed from the parent, it updates its
`value` property which is bound to each options `selected`
attribute (to toggle the selection state in the DOM).
The specific mechanism that causes the DOM to get updated when the
various computed properties change is that a Stream object calls
`ownerNode.emberView.scheduleRevalidate`. This tells the rest of the
system to start walking the tree to flush out any updates to the DOM.
When a view is being removed, we set the `emberView`
property of its `renderNode` to `null` before traversing the subtree of
children. This means, that as the children are removed (and therefore
cause the `value` of the parent to change) the `selected` attribute
binding attempts to call `ownerNode.emberView.scheduleRevalidation()`.
Unfortunately, when we are actually tearing down the
`ownerNode.emberView` itself that invocation results in an error (
cannot call `scheduleRevalidation` on `null`).
---
This change adds a simple guard to avoid calling `scheduleRevalidation`
when the `ownerNode.emberView` is being torn down. | [bugfix beta] prevent issues with revalidation during teardown | 62 | false | false | 8 | false | false | false | emberjs | ember.js | 8,873 |
588805907fb425b79f0cd644a45f8a1cb121902e | Godhuda | Godfrey Chan | Updated to use new element operations APIs | updated to use new element operations apis | 42 | false | false | 7 | false | false | false | emberjs | ember.js | 8,874 |
f7d64dc3895c43b1a23164c599d3dee6371cd6a4 | Robert Jackson | GitHub | Merge pull request #14109 from mixonic/finish-13744
[DOC canary] Document how a waiter works | merge pull request from mixonic/finish-13744 | 45 | true | false | 5 | true | true | false | emberjs | ember.js | 8,875 |
d21e016c51e0d1b6ce23ee36a67eac2a14e2bede | Robert Jackson | Robert Jackson | Add failing test for GH#13846. | add failing test for gh | 23 | false | false | 5 | true | true | true | emberjs | ember.js | 8,876 |
3ce933612d1b4ddff3d849cee7cc4a079fcc62bd | Matthew Beale | GitHub | Merge pull request #14106 from rwjblue/do-not-assert-on-id
[BUGFIX beta] Avoid assertion when `id=` is provided to tagless components. | merge pull request from rwjblue/do-not-assert-on-id | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 8,877 |
12e9a92c71941397b588c5c5143985f005c9f036 | Ilya Radchenko | Matthew Beale | [DOC canary] Document how a waiter works
A simple explanation of how a waiter works would help anyone looking to write one. | [doc canary] document how a waiter works | 40 | false | false | 7 | false | false | false | emberjs | ember.js | 8,878 |
ac66e5393ff0b11c2f6c0393d4234010b52d4fe5 | Matthew Beale | GitHub | Merge pull request #14107 from mixonic/docs-cleanup
[DOC canary] Several cleanups in test helpers | merge pull request from mixonic/docs-cleanup | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 8,879 |
3b9806e2ed2b0c50067150879ea46e088311f64b | Matthew Beale | Matthew Beale | [DOC canary] Move helper docs around
Per https://github.com/emberjs/ember.js/issues/13862, move the helper
documentation into each file closer to the implementation.
Also replaces:
* https://github.com/emberjs/ember.js/pull/13878
* https://github.com/emberjs/ember.js/pull/13876
* https://github.com/emberjs/ember.js/pull/13874
* https://github.com/emberjs/ember.js/pull/13873
Fixes https://github.com/emberjs/ember.js/issues/13862 | [doc canary] move helper docs around | 36 | false | false | 6 | false | false | false | emberjs | ember.js | 8,880 |
ed63f4710dd760b961ee25a74e1505a08eec77fa | EGlenfield22 | Matthew Beale | [DOC canary] Adding second arg to findWithAssert and find methods, with examples | [doc canary] adding second arg to findwithassert and find methods, with examples | 80 | false | false | 12 | false | false | false | emberjs | ember.js | 8,881 |
71ea36e9e4c96d3833f1598a51191eacaefee702 | Matthew Beale | GitHub | Merge pull request #13853 from Serabe/fix/link-to-docs
[DOC beta] Mark `LinkComponent#activeClass` as public. | merge pull request from serabe/fix/link-to-docs | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 8,882 |
23ecbcc6bfe84b86f240b4de6b45fffceac5ac26 | Matthew Beale | GitHub | Merge pull request #13877 from purvitiwari/master
[DOC Canary] Comments added for ember testing helper scripts | merge pull request from purvitiwari/master | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 8,883 |
b216f384e1b0e1caa3e1103818272f76777679fa | Matthew Beale | GitHub | Merge pull request #14047 from Serabe/fix/14046
[DOC beta] Improve `Route#render` documentation | merge pull request from serabe/fix/14046 | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 8,884 |
64a685359d5680095e88e487fcd29b86c434c6f8 | Robert Jackson | Robert Jackson | [BUGFIX beta] Avoid assertion when `id=` is provided to tagless components. | [bugfix beta] avoid assertion when `id=` is provided to tagless components | 74 | false | false | 11 | false | false | false | emberjs | ember.js | 8,885 |
3ba7ae2b30bee93bf98023618ebe3d37b0206873 | Robert Jackson | GitHub | Merge pull request #14104 from les2/glimmer-2--isvisiblebinding-fix
Call IsVisibleBinding only if no style binding | merge pull request from les2/glimmer-2--isvisiblebinding-fix | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 8,886 |
05353cbc30bad04cc6f638ccde56a056fd59b713 | Lloyd Smith II | Lloyd Smith II | Call IsVisibleBinding only if no style binding
Previously, the `seen` variable was used as both an `Array` and a
hashmap (plain JavaScript object) when it was really an `Array`. The
`Array` would never return `true` for `seen['style']` in this code block
meaning that the `IsVisibleBinding` call would always be invoked,
regardless of whether there was an attribute binding for `style`. This
behavior is most likely a bug. The author intends to investigate unit /
integration tests for this case and add them in a separate commit. | call isvisiblebinding only if no style binding | 46 | false | false | 7 | false | true | false | emberjs | ember.js | 8,887 |
82ce6a4854bd02474a6817b27e5401f20ce384c7 | Lloyd Smith II | Lloyd Smith II | test: IsVisibleBinding without style binding | isvisiblebinding without style binding | 38 | false | false | 4 | false | false | false | emberjs | ember.js | 8,888 |
3f4ba8d405234a21ee4f8b7f9d872ef10003e0ec | Robert Jackson | GitHub | Merge pull request #14102 from rwjblue/update-glimmer
Update to latest glimmer-engine (0.9.2). | merge pull request from rwjblue/update-glimmer | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 8,889 |
4c0877e6a6b61f88e3ca18efaa3a6141e2be9c2a | Robert Jackson | Robert Jackson | Update to latest glimmer-engine (0.9.2).
* Update injections for Glimmer's environment to handle DOM helper
changes.
* Manage both DOM helper (`DOMChanges` and `DOMTreeConstruction`)
* Move `protocolForURL` to `Environment` (from `DOMHelper`)
* Update various usages of
`GroupedElementOperations.prototype.addAttribute` to use
`.addDynamicAttribute`.
* Update `glimmer-engine`'s usage of `babel` transpilation to use
externalized helpers and strip runtime `class-call-check` helper
usage.
* Update `emberjs-build` to prevent inclusion of `babelHelpers` twice.
* Update `emberjs-build` to ensure runtime checks are stripped for prod
builds and not for debug builds. | update to latest glimmer-engine (0.9.2) | 39 | false | false | 5 | false | false | false | emberjs | ember.js | 8,890 |
899056950b68ed5e0130ef7a27ba65c6763067a9 | Robert Jackson | GitHub | Merge pull request #14100 from rwjblue/properly-unregister-views
Ensure view registry entries can be unregistered properly. | merge pull request from rwjblue/properly-unregister-views | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 8,891 |
66c8a9e5fd792b69e25bef18d25c300646724d86 | Robert Jackson | GitHub | Merge pull request #14098 from rwjblue/make-module-names-correct
Remove `testModule` from `skip-if-glimmer`. | merge pull request from rwjblue/make-module-names-correct | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 8,892 |
f212287d58a561699e5b8b58d65b4b77ea90b10b | Chad Hietala | Robert Jackson | DOMHelper -> DOMChanges | domhelper -> domchanges | 23 | false | false | 3 | false | false | false | emberjs | ember.js | 8,893 |
5713721f7a08321cb95e9f39316d7704d7bb3138 | Robert Jackson | Robert Jackson | Ensure view registry entries can be unregistered properly.
When the `register` / `unregister` functions were moved from the
`ViewSupportMixin` to the renderer, I didn't properly update them to use
the provided `view`'s `elementId` and was instead using `this.elementId`
(on the renderer) which was obviously undefined.
This meant that we were holding on to a reference of all
views/components ever created (since they were never being released from
the `viewRegistry`). :sob: | ensure view registry entries can be unregistered properly | 57 | false | false | 8 | true | false | false | emberjs | ember.js | 8,894 |
c386d922bdee6a8fc495c034c78f07f98072b065 | Robert Jackson | Robert Jackson | Remove `testModule` from `skip-if-glimmer`.
Conditionally calling `QUnit.module` leads to bizarre test names. Since
`testModule` was only calling `QUnit.module` when not using `ember-glimmer`,
but `test` was just swapping between `QUnit.test` and `QUnit.skip` we
ended up "sharing" the previously ran `QUnit.module'`s name as a prefix
to skipped tests.
 | remove `testmodule` from `skip-if-glimmer` | 42 | false | false | 4 | false | true | false | emberjs | ember.js | 8,895 |
f56d13728f380444f98f172c3e85172648631bf2 | Robert Jackson | GitHub | Merge pull request #14095 from rwjblue/add-assertion-for-missing-template
Add helpful assertion when template is missing. | merge pull request from rwjblue/add-assertion-for-missing-template | 67 | true | false | 5 | true | false | false | emberjs | ember.js | 8,896 |
205e5acfaf421c600769dfc428e40cb857ecacd5 | Robert Jackson | GitHub | Merge pull request #14087 from trentmwillis/lazy-handler
[BUGFIX beta] Check that handler exists before triggering event | merge pull request from trentmwillis/lazy-handler | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 8,897 |
4d6b7d09b52304cf94fdb4bcb63aba40e9f0b723 | Robert Jackson | GitHub | Merge pull request #14078 from chadhietala/add-external-helpers
Adds external helpers for babel | merge pull request from chadhietala/add-external-helpers | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 8,898 |
39875a4869d73ad34c165bbeecce0b4d4d15ab39 | Robert Jackson | Robert Jackson | Add helpful assertion when template is missing.
Prior to this change, calling `component.appendTo()` when there was no
`template` would trigger an unhelpful error:
```
Cannot read property 'asEntryPoint' of undefined
```
After this change, it will at least point you in the direction of the
offending component:
```
You cannot render `<dummy@component:foo-bar::ember168>` without a template.
``` | add helpful assertion when template is missing | 46 | false | false | 7 | true | true | true | emberjs | ember.js | 8,899 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.