sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
8ba68d27ab12fac4b3e33059cdbc96bd2552ab09 | Godfrey Chan | Godfrey Chan | [GLIMMER2] Only dirty `UpdatableReference` when value has changed
This path is used for Iterable’s `retain` operation. A lot of times, it
is called when nothing have actually changed. Dirtying the tag here in
those cases is causing a lot of unnecessary re-render churns. | [glimmer2] only dirty `updatablereference` when value has changed | 65 | false | false | 8 | false | false | false | emberjs | ember.js | 9,000 |
96f113512e0adaa4289156f037c18a5a29d5733d | Robert Jackson | Robert Jackson | [GLIMMER] Fix OutletView#appendTo when jQuery is not present. | [glimmer] fix outletview#appendto when jquery is not present | 60 | false | false | 8 | false | false | false | emberjs | ember.js | 9,001 |
ddd7f581b3551948ca4e360190d14d882cade724 | Peter Wagenet | Peter Wagenet | [DOC release] Improve Ember.deprecate documentation | [doc release] improve ember.deprecate documentation | 51 | false | false | 5 | false | false | false | emberjs | ember.js | 9,002 |
d2d6e2790e4146215baa5cdc5175d238574c1b86 | Trent Willis | Trent Willis | [BUGFIX beta] Pass environment options forward to Engines
This fixes a failing test introduced in the previous test where Engines
rendered even though shouldRender was set to false. | [bugfix beta] pass environment options forward to engines | 57 | false | false | 8 | false | false | false | emberjs | ember.js | 9,003 |
47c6a6f80b7a4d3b858fdb2f9a26ba30155528fd | Trent Willis | Trent Willis | [BUGFIX beta] Add tests for visit() with shouldRender set to false | [bugfix beta] add tests for visit() with shouldrender set to false | 66 | false | false | 11 | false | false | false | emberjs | ember.js | 9,004 |
98269f82f9a4aa58cbc91b508b4967688fda77ee | Peter Wagenet | Peter Wagenet | [DOC release] Use dash for partial naming | [doc release] use dash for partial naming | 41 | false | false | 7 | false | false | false | emberjs | ember.js | 9,005 |
73515134645225ac1887eec94f2d5fd9a096ce5b | Gavin Joyce | Gavin Joyce | failing test for #14001 | failing test for | 16 | false | false | 3 | false | false | false | emberjs | ember.js | 9,006 |
767a12ff38682edccbc08e7475addb74360396d2 | Gavin Joyce | Gavin Joyce | added curly component classNameBindings tests | added curly component classnamebindings tests | 45 | false | false | 5 | false | false | false | emberjs | ember.js | 9,007 |
037c9837408a2ffbe554d1be348f39f1ef313a37 | Godfrey Chan | Godfrey Chan | [GLIMMER2] Bump Glimmer for non-volatile iterables | [glimmer2] bump glimmer for non-volatile iterables | 50 | false | false | 6 | false | false | false | emberjs | ember.js | 9,008 |
63d9e76714570b70eaaf3ebd420859f7797c54de | Godfrey Chan | Godfrey Chan | [GLIMMER2] Remove last `CURRENT_TAG` from `{{#each-in}}`
Basically copies the strategy from `PropertyReference` | [glimmer2] remove last `current_tag` from `{{#each-in}}` | 56 | false | false | 6 | false | false | false | emberjs | ember.js | 9,009 |
97ac58ba7bf52ce5d8cd163fc7aba1a99926a2e1 | Godfrey Chan | Godfrey Chan | [GLIMMER2] Refactor `{{#each-in}}`
* Make a specialized `Iterable` class for `{{#each-in}}`
* Handle/test duplicated keys in `{{#each-in}}`
* Default `{{#each-in}}` to use `key=“@index”` since it’s guaranteed to
be unique (and is effectively free to compute)
* `ArrayIterable` doesn’t actually need to care about proxies: `ArrayProxy`
is not actually a proxy – it does not inherit from `ProxyMixin`, thus
does not contain the `[IS_PROXY]` brand. For tagging, since it listens
for array change events on its `content` and update its `length`, the
array proxy object already gets dirtied automatically whenever the
content changes. For iterating, it falls into the `EmberArray` branch,
which iterates through `arrangedContent`. | [glimmer2] refactor `{{#each-in}}` | 34 | false | false | 3 | false | false | false | emberjs | ember.js | 9,010 |
1a4a05226a692f40a7d8bd6074d42923f5f8ab85 | Godfrey Chan | Godfrey Chan | [GLIMMER2] Eliminate `ConditionalReference`’s reliance on `CURRENT_TAG`
This is simply not needed – `isTruthy` is a CP on the proxy that is only
updated when `content` changes. | [glimmer2] eliminate `conditionalreference`’s reliance on `current_tag` | 71 | false | false | 6 | false | false | false | emberjs | ember.js | 9,011 |
299e0efd32f0ea886c75bd1ef5e3638ec840af22 | Godfrey Chan | Godfrey Chan | [GLIMMER2] Eliminate `PropertyReference`’s reliance on `CURRENT_TAG` | [glimmer2] eliminate `propertyreference`’s reliance on `current_tag` | 68 | false | false | 6 | false | false | false | emberjs | ember.js | 9,012 |
3d25f9805cf1eb37a3f5ae6e05e3e2646b4f6175 | Robert Jackson | GitHub | Merge pull request #14009 from cibernox/fix-attribute-binding-for-role
[BUGFIX beta] attributeBindings not working with `role` | merge pull request from cibernox/fix-attribute-binding-for-role | 64 | true | false | 5 | true | false | false | emberjs | ember.js | 9,013 |
a1831d2381b2ff673fbef87f4109936b98429218 | Godfrey Chan | Godfrey Chan | Remove unneeded mandatory-setter watcher
`REFERENCE_FOR_KEY` is only used for pooling property references, which
already handles the `mandatory-setter` check. | remove unneeded mandatory-setter watcher | 40 | false | false | 4 | false | false | false | emberjs | ember.js | 9,014 |
a931cb057700d851c036b9f3b18c476c5a7c3a13 | cibernox | cibernox | [BUGFIX beta] attributeBindings not working with `role` | [bugfix beta] attributebindings not working with `role` | 55 | false | false | 7 | false | false | false | emberjs | ember.js | 9,015 |
ad5d20bb923cc04b227d1ed848ffd54a4602c626 | Robert Jackson | GitHub | Merge pull request #13988 from emberjs/refactor-each-tests
Refactor `{{#each}}` tests | merge pull request from emberjs/refactor-each-tests | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 9,016 |
ef157d017e75a27eb38107c819532b3f4b5c0d94 | Robert Jackson | GitHub | Merge pull request #14005 from zackthehuman/more-gh-13982
[GLIMMER2] Cache component def until name changes | merge pull request from zackthehuman/more-gh-13982 | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 9,017 |
10ad94efed38f53e08403d08a503a2d951bf163b | Zachary Mulgrew | Zachary Mulgrew | Cache component def until name changes | cache component def until name changes | 38 | false | false | 6 | false | false | false | emberjs | ember.js | 9,018 |
91d2b83f67ebef1ee5a45ca2a92323be16cdc237 | Godfrey Chan | Godfrey Chan | Make various edge-cases @glimmer only | make various edge-cases @glimmer only | 37 | false | false | 5 | false | true | false | emberjs | ember.js | 9,019 |
20de5413dc00cb21e32e28304b91d79b990bfc40 | Robert Jackson | GitHub | Merge pull request #13997 from zackthehuman/gh-13962
Make component helper reference stable + tests | merge pull request from zackthehuman/gh-13962 | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 9,020 |
a2f66a9df1925de751448db16a27fec5f66dbe24 | Godfrey Chan | Godfrey Chan | Flesh out {{#each/each-in}} test cases
Also fixed various bugs:
* When iterating over a proxy, iterate over the content instead of the
proxy object.
* `{{#each-in}}`-ing over primitives (e.g. false) and strings counts as
falsy. In ES5 (IE <= 11) `Object.keys()` throws when passed anything
other than typeof ‘object’ or ‘function’.
* Don’t error when `{{#each}}`-ing over primitives (e.g. false) and
non-arrays. | flesh out {{#each/each-in}} test cases | 38 | false | false | 5 | false | false | false | emberjs | ember.js | 9,021 |
639763a81183e17cbc9ee218899c0fefab1de8b4 | Godfrey Chan | Godfrey Chan | Improve coverage for `ArrayProxy` + `{{#each}}` | improve coverage for `arrayproxy` + `{{#each}}` | 47 | false | false | 6 | true | true | true | emberjs | ember.js | 9,022 |
5b0e95759eb0ea5c282255c79406fffd42e17e64 | Godfrey Chan | Godfrey Chan | Index the generated tests to avoid collision
Some objects `JSON.stringify` into the same string, causing these tests
to share the same name, which causes QUnit to only run one of them. | index the generated tests to avoid collision | 44 | false | false | 7 | false | true | false | emberjs | ember.js | 9,023 |
0587ce06fa4dfd31f24771621995e5f052addd51 | Zack Mulgrew | Zack Mulgrew | Make component helper reference stable + tests | make component helper reference stable + tests | 46 | false | false | 7 | false | true | false | emberjs | ember.js | 9,024 |
ac4f53a9dc60c5e511392add119a9d0d83a3dfed | Godhuda | Godhuda | Bump Glimmer for {{#each-in}} fix | bump glimmer for {{#each-in}} fix | 33 | true | false | 5 | false | true | false | emberjs | ember.js | 9,025 |
b4ad39460d3de25a334a76400c01730f4269e395 | Jason Ly | GitHub | [DOC] Syntax highlighting
Added syntax highlighting for the example code. | [doc] syntax highlighting | 25 | false | false | 3 | false | false | false | emberjs | ember.js | 9,026 |
dccb3d93fec186678b50a65ec3637f2306a0fced | Jason Ly | GitHub | Syntax highlighting
Added syntax highlighting! | syntax highlighting | 19 | false | false | 2 | false | false | false | emberjs | ember.js | 9,027 |
a6f3fc4fbbe4371820f66a7c952822aa2e784e60 | Godhuda | Godhuda | Unify Glimmer and HTMLBars `{{#each}}` tests | unify glimmer and htmlbars `{{#each}}` tests | 44 | false | false | 6 | true | false | true | emberjs | ember.js | 9,028 |
fdafaf5f246534e4a4d4b9a78176f93d5f2674e7 | Jason Ly | GitHub | Update README.md
Consistency fix, numbered bullets had inconsistent punctuation with the other sections. | update readme.md | 16 | false | false | 2 | false | false | false | emberjs | ember.js | 9,029 |
1fcf09ea74b8102785a47444d48270c801fe6f2a | Godfrey Chan | Godfrey Chan | Refactor `{{#each}}` tests
* Refactor `TogglingConditionalsSyntaxTest`, so that `{{#each}}` and
`{{#each-in}}` can share the same test cases with `{{#if}}`,
`{{#unless}}` and `{{#with}}`
* Refactor most of the `{{#each}}` tests so that we can run them against
`emberA`, array-like objects (objects with a `forEach` method) and
array proxies | refactor `{{#each}}` tests | 26 | false | false | 3 | false | false | false | emberjs | ember.js | 9,030 |
6449018ee1321082e946e7a4e8f198c8e11fd3a4 | Robert Jackson | GitHub | Merge pull request #13987 from rwjblue/fix-readdomattr
[GLIMMER] Fix `Component#readDOMAttr`. | merge pull request from rwjblue/fix-readdomattr | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 9,031 |
10cf96474e3f1d86a1f71a530c7a11202abb969b | Robert Jackson | GitHub | Merge pull request #13985 from rwjblue/strip-leading-v-from-tags
Strip leading `v` from the version on tags. | merge pull request from rwjblue/strip-leading-v-from-tags | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 9,032 |
7a3e9b680071f5abffc998bd794e3e3aeef1ac09 | Robert Jackson | Robert Jackson | [GLIMMER] Fix `Component#readDOMAttr`.
There are a number of specific attributes that must be converted to
properties after initial values. Using `this.readDOMAttr` was designed
to assist with the `<input value="adf">` case (to prevent cursor
position loss). This migrates from the temporary
`this.element.getAttribute` to the more fully featured `readDOMAttr`
that is exported by `glimmer-runtime`. | [glimmer] fix `component#readdomattr` | 37 | false | false | 3 | false | false | false | emberjs | ember.js | 9,033 |
61354f0e3c5f1bb0fcd5b3af7147fb599750cf6a | Tracy Lee | Tracy Lee | [DOC release] Add documentation for click 2nd argument | [doc release] add documentation for click 2nd argument | 54 | false | false | 8 | false | false | false | emberjs | ember.js | 9,034 |
cfa5cc529951d93fb683a8ab0ea3d8f737d3b13f | Robert Jackson | Robert Jackson | Strip leading `v` from the version on tags. | strip leading `v` from the version on tags | 42 | false | false | 8 | false | false | false | emberjs | ember.js | 9,035 |
868e29c9840592a81f8a67e32262fe28976d762e | Robert Jackson | Robert Jackson | Add v2.8.0-beta.2 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 7b5186c1c952e480a2712c2f91611f5db9fc0647) | add v2.8.0-beta.2 to changelog.md | 33 | false | false | 4 | true | true | true | emberjs | ember.js | 9,036 |
bd29c1eeeea969ff35a74dffac14ee8a2aff42a8 | Kris Selden | GitHub | Merge pull request #13978 from chadhietala/add-tests
[Glimmer2] More coverage around falsy input values | merge pull request from chadhietala/add-tests | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 9,037 |
7e626ef14337c9c97163b276e995fed2ab0790e9 | Chad Hietala | Chad Hietala | [Glimmer2] More coverage around falsy input values | [glimmer2] more coverage around falsy input values | 50 | false | false | 7 | false | false | false | emberjs | ember.js | 9,038 |
3a7b78a96760a37b4a9c8e10ea54821e283a2011 | Robert Jackson | GitHub | Merge pull request #13979 from rwjblue/fix-debug-build-output
Strip debug statements properly in prod builds. | merge pull request from rwjblue/fix-debug-build-output | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 9,039 |
291e28b6c2139c9becad617f66ae5f295ed74b89 | Robert Jackson | Robert Jackson | Strip debug statements properly in prod builds. | strip debug statements properly in prod builds | 46 | false | false | 7 | false | true | false | emberjs | ember.js | 9,040 |
06ecec27bf0fa7f97f679c283c425719cdb08dfd | Kris Selden | GitHub | Merge pull request #13967 from emberjs/fix-layout
[glimmer2] fix cache of directly imported templates | merge pull request from emberjs/fix-layout | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 9,041 |
f5f08d90f2b379c80d322f06af5b6b67fe5772e5 | Kris Selden | Kris Selden | [glimmer2] fix cache of imported templates
* Simplify template factory.
* Add tests for template factory.
* Fix caching of template factory instances that
are directly imported. | [glimmer2] fix cache of imported templates | 42 | false | false | 6 | false | false | false | emberjs | ember.js | 9,042 |
b2e5d62b4350075cc86284ff8772daa57c8fafd9 | Kris Selden | GitHub | Merge pull request #13977 from emberjs/fix-outlet-test
Fix ported outlet test | merge pull request from emberjs/fix-outlet-test | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 9,043 |
b03c1bf306f6226eff4f23d880205afb346163f6 | Kris Selden | GitHub | Merge pull request #13976 from chadhietala/fix-input-value
[Glimmer2] Bump glimmer to fix #13974 | merge pull request from chadhietala/fix-input-value | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 9,044 |
64362723b506cc36771a9da3d89ca19f2ec4c729 | Kris Selden | Kris Selden | Fix ported outlet test
Symlink integration tests to htmlbars.
LOG_VIEW_LOOKUPS is done in the router
Ensure outlet state matches router.
TODO: extract building outlet states, also, I
think ViewClass is no longer used by anything. | fix ported outlet test | 22 | false | false | 4 | false | true | false | emberjs | ember.js | 9,045 |
341f32f3bba6c588bd79d2a01a553b33df97a062 | Chad Hietala | Chad Hietala | [Glimmer2] Bump glimmer to fix #13974 | [glimmer2] bump glimmer to fix | 30 | false | false | 5 | false | false | false | emberjs | ember.js | 9,046 |
8fa4d1ded164d5a933d4eb9aa86992194ab0f7a5 | Kris Selden | GitHub | Merge pull request #13973 from emberjs/failing-outlet-tests
[WIP] [GLIMMER] Port {{outlet}} tests. | merge pull request from emberjs/failing-outlet-tests | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 9,047 |
f9683a43af2662a3bf33ef7e1abf4bb9174163b1 | Godfrey Chan | GitHub | Merge pull request #13964 from emberjs/reduce-current-tag
[Glimmer 2] Step 1 of reducing `CURRENT_TAG`s | merge pull request from emberjs/reduce-current-tag | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 9,048 |
6feae8915dfd3881afc8dcd463993039ce00bdbc | Robert Jackson | Robert Jackson | [GLIMMER] Port {{outlet}} tests. | [glimmer] port {{outlet}} tests | 31 | false | false | 4 | false | false | false | emberjs | ember.js | 9,049 |
3b20721864374a7c8721d73a89901c39af8b2747 | Godfrey Chan | Godfrey Chan | Pull in CachedReference fix from glimmer | pull in cachedreference fix from glimmer | 40 | false | false | 6 | false | false | false | emberjs | ember.js | 9,050 |
82d9f36f273f7475056a81eefffc493119f16288 | Godhuda | Godfrey Chan | Step 1 of reducing `CURRENT_TAG`s
Pulling the value of a reference could be a side-effectful operation
from the perspective of the revision timeline (e.g. updating an
`UpdatableTag` is a change on the timeline). Therefore we should always
compute the value first, then pull from the validation tag.
If we always follow that protocol, there is no actual reason to
initialize an `UpdatableTag` with a `CURRENT_TAG`. While this is always
"correct", it causes values that doesn't otherwise matter to "poison" an
tag combinator all the way up. (And also causes caches to miss – because
the tag value might have changed after computing the value, as it is
usually the case when an `UpdatableTag` is involved.) | step 1 of reducing `current_tag`s | 33 | false | false | 5 | false | false | false | emberjs | ember.js | 9,051 |
cf2fdd22e9b24b264aaf5fc66ed46103cac98293 | Godfrey Chan | GitHub | Merge pull request #13971 from rwjblue/fix-glimmer-mut-actions
[GLIMMER] Fix issues with actions with the `(mut` helper. | merge pull request from rwjblue/fix-glimmer-mut-actions | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 9,052 |
ec8f3255bb70684e200e049c438fc3c7990301ef | Robert Jackson | Robert Jackson | [GLIMMER] Fix issues when using actiosn with mut.
We were previously triggering the "You specified a bound action name but
it resolved to undefined or null" message, because the mut reference's
`.value()` actually returned the properties value (which was
`undefined`).
The fix here is to check for `[INVOKE]` and handle it specially. | [glimmer] fix issues when using actiosn with mut | 48 | false | false | 8 | false | false | false | emberjs | ember.js | 9,053 |
8ba7f68f3ce53b083ab4a95264bf77a02acc366b | Stefan Penner | GitHub | Merge pull request #13939 from emberjs/no-longer-copy-forward
Cleanup Ember.Error | merge pull request from emberjs/no-longer-copy-forward | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 9,054 |
1fdfb44bdbc6fbe7084350e706bcfd86210546b8 | Robert Jackson | GitHub | Merge pull request #13970 from rwjblue/registry-setup-fixes
Registry setup fixes | merge pull request from rwjblue/registry-setup-fixes | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 9,055 |
13ea22bd54a5e967fd4638704bb55b348fb07d32 | Robert Jackson | GitHub | Merge pull request #13969 from andrewmp1/bug-fix/12967
[BUGFIX beta] Fix issue 12967. Using render without a name losing templateName property. | merge pull request from andrewmp1/bug-fix/12967 | 48 | true | false | 5 | true | true | false | emberjs | ember.js | 9,056 |
ffc29cd237613507e915c7cf9972ef8dd3b16453 | Robert Jackson | Robert Jackson | Expose `Ember.ApplicationInstance.setupRegistry` for tooling.
Glimmer requires that a number of factories and injections added by
`ApplicationInstance#setupRegistry` are present, but the testing harness
only has access to calling `Ember.Application.buildRegistry` which
leaves the registry in a partially populated state.
This exposes `Ember.ApplicationInstance.setupRegistry` so that
`ember-test-helpers` can ensure that its registry is properly populated. | expose `ember.applicationinstance.setupregistry` for tooling | 60 | false | false | 4 | true | true | false | emberjs | ember.js | 9,057 |
031915af9bf8011f4b68f59b632aacb16450b158 | Robert Jackson | Robert Jackson | Ensure Ember.Application.buildRegistry uses glimmer registry in alpha
ember-test-helpers calls `Ember.Application.buildRegistry` to create a
registry for its testing harness. Prior to these changes,
`options[GLIMMER]` would be `undefined` and therefore throw an error
when building a registry in the alpha series. | ensure ember.application.buildregistry uses glimmer registry in alpha | 69 | false | false | 7 | false | false | false | emberjs | ember.js | 9,058 |
ce9f233da2f98c96e97ad6c66a6f7d84de46bab8 | Andrew Purdy | Andrew Purdy | [BUGFIX beta] Fix issue 12967. Using render without a name loses templateName property. | [bugfix beta] fix issue 12967. using render without a name loses templatename property | 86 | false | false | 13 | false | false | false | emberjs | ember.js | 9,059 |
c076329e429381925d2416a2fa29ee1e580c7ea7 | Robert Jackson | GitHub | Merge pull request #13952 from rwjblue/use-native-dom
Use native DOM methods instead of jQuery. | merge pull request from rwjblue/use-native-dom | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 9,060 |
26c8ec6c9ad92835b0c1f97e8ae179ba19461804 | Nick Muerdter | Nick Muerdter | [DOC release] Fix documentation of Route queryParamsDidChange.
The second parameter is an object of the query parameters currently set
on the URL, not an integer. | [doc release] fix documentation of route queryparamsdidchange | 61 | false | false | 7 | false | false | false | emberjs | ember.js | 9,061 |
2c206582103ca0132aa2f4eb95f2bd6b529f54dc | Robert Jackson | GitHub | Merge pull request #13961 from rwjblue/update-glimmer
Update glimmer-engine to avoid tslint files in prod builds. | merge pull request from rwjblue/update-glimmer | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 9,062 |
775e05ef8975d4809215131ef875f6109573b085 | Robert Jackson | Robert Jackson | Refactor HistoryLocation / HashLocation to use native API's. | refactor historylocation / hashlocation to use native api's | 59 | false | false | 8 | false | false | false | emberjs | ember.js | 9,063 |
019cd38c53ed8a1911bfdfebf859226b7e020473 | Robert Jackson | Robert Jackson | Refactor View#appendTo to use native DOM API's. | refactor view#appendto to use native dom api's | 46 | false | false | 7 | false | false | false | emberjs | ember.js | 9,064 |
7633228cabae0cf3f0d2baa71fdabed9cf0e00c1 | Robert Jackson | Robert Jackson | Avoid invoking jQuery when it is not present during eval. | avoid invoking jquery when it is not present during eval | 56 | false | false | 10 | false | false | false | emberjs | ember.js | 9,065 |
c7124b54a31d58c1afafb53b8e6490ed886580f2 | Robert Jackson | Robert Jackson | Update glimmer-engine to avoid tslint files in prod builds. | update glimmer-engine to avoid tslint files in prod builds | 58 | false | false | 9 | true | true | false | emberjs | ember.js | 9,066 |
002bb826593789927cd3089e2c25f8c628a369de | Stefan Penner | Stefan Penner | Cleanup EmberError
* if constructor was called and not new'd, new it
* capture stack to the subclass
* ensure the Error constructor `this` is preserved
* unroll the loop | cleanup embererror | 18 | false | false | 2 | false | false | false | emberjs | ember.js | 9,067 |
b236ff1ea5004f249ae3fd57c2053d3b40a4c964 | Robert Jackson | GitHub | Merge pull request #13951 from emberjs/backtracking-message
Improve “backtracking re-render” message | merge pull request from emberjs/backtracking-message | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 9,068 |
f247628d13a779ea2e697395e646623eccccccc0 | Robert Jackson | GitHub | Merge pull request #13958 from rwjblue/alpha-version
Fix version number for alpha. | merge pull request from rwjblue/alpha-version | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 9,069 |
5d2a0ffe1a01ded944c64915d0b499fb2408999e | Robert Jackson | Robert Jackson | Fix version number for alpha. | fix version number for alpha | 28 | false | false | 5 | true | true | true | emberjs | ember.js | 9,070 |
c503705728b7309e214bb4cba10a965725e97ee0 | Godfrey Chan | Godfrey Chan | Improve “backtracking re-render” message | improve “backtracking re-render” message | 40 | false | false | 4 | false | false | false | emberjs | ember.js | 9,071 |
6ebf1b6f4f83bb8de09dd6ec31f50063293687a8 | Godfrey Chan | GitHub | Merge pull request #13953 from rwjblue/fix-canary-builds
Fix canary builds to prevent alpha builds from overriding. | merge pull request from rwjblue/fix-canary-builds | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 9,072 |
f71273bca1c4d82403916da1942ee4f5466f5472 | Robert Jackson | Robert Jackson | Fix canary builds to prevent alpha builds from overriding. | fix canary builds to prevent alpha builds from overriding | 57 | false | false | 9 | true | false | false | emberjs | ember.js | 9,073 |
ade07e355a30e9fcfeb9f953b8016f0800edb607 | Godfrey Chan | GitHub | Merge pull request #13950 from emberjs/fix-glimmer-builds
Fix Glimmer builds | merge pull request from emberjs/fix-glimmer-builds | 51 | true | false | 5 | true | true | false | emberjs | ember.js | 9,074 |
3ce73bb00126f20edb7f5cb9ceb6f1a69ae758bb | Godfrey Chan | Godfrey Chan | Fix Glimmer builds
Both template compilers seem to need backburner, hoisting it up. | fix glimmer builds | 18 | false | false | 3 | true | true | true | emberjs | ember.js | 9,075 |
4b58330183350e4d4e7d3259de3289a4002abd99 | Godfrey Chan | GitHub | Merge pull request #13944 from emberjs/prevent-publishing
Disable publishing backtracking build (#13941 take two) | merge pull request from emberjs/prevent-publishing | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 9,076 |
ed8b3edc5e62bb6f375b301df96558312f1ad15a | Godfrey Chan | GitHub | Merge pull request #13943 from emberjs/fix-bash-syntax-error
Fix bash syntax error | merge pull request from emberjs/fix-bash-syntax-error | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 9,077 |
b6b84bbdee2f486a58debc098657189fb602c333 | Godfrey Chan | GitHub | Merge pull request #13942 from emberjs/bump-glimmer
Bump glimmer to remove assert warning | merge pull request from emberjs/bump-glimmer | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 9,078 |
86f65045fddd5fdd09685f39884230474dd2e111 | Robert Jackson | Godfrey Chan | Disable publishing backtracking build. | disable publishing backtracking build | 37 | false | false | 4 | false | true | false | emberjs | ember.js | 9,079 |
fb36149541b98029ce1dcc88583aee870f193412 | Godfrey Chan | Godfrey Chan | Fix bash syntax error | fix bash syntax error | 21 | false | false | 4 | false | true | false | emberjs | ember.js | 9,080 |
f8526029b6bc4632e04ae0b6b28deb455c259461 | Godfrey Chan | Godfrey Chan | Bump glimmer to remove assert warning | bump glimmer to remove assert warning | 37 | true | false | 6 | true | true | false | emberjs | ember.js | 9,081 |
8c3eaca82bc40f2af634570ee0f118e341657f82 | Robert Jackson | GitHub | Merge pull request #13934 from rwjblue/add-glimmer-ci
Add Glimmer build output to CI/CD. | merge pull request from rwjblue/add-glimmer-ci | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 9,082 |
591bb7265fc848279f792be66cf1c042235cbb44 | Robert Jackson | Robert Jackson | Refactor feature and package gathering processes.
Also adds a cache key for invalidating when `features.json`
changes (still requires a restart). | refactor feature and package gathering processes | 48 | false | false | 6 | false | false | false | emberjs | ember.js | 9,083 |
3a5efdef54c379f45175c372bf035a6fa2df1ea8 | Robert Jackson | Robert Jackson | Add Glimmer build output to CI/CD. | add glimmer build output to ci/cd | 33 | false | false | 6 | false | true | false | emberjs | ember.js | 9,084 |
eac9d7438ce614dd49d377caa2cf13eb59acd958 | Kris Selden | GitHub | Merge pull request #13938 from emberjs/fix-cache
[BUGFIX beta] Fix ember-metal/cache | merge pull request from emberjs/fix-cache | 42 | true | false | 5 | true | false | false | emberjs | ember.js | 9,085 |
80f0462b9b2c749ec52cf096022330de3fb536f3 | Godhuda | Godhuda | [BUGFIX beta] Fix ember-metal/cache
In #13829, we introduced the ability to pass a custom key function for
the cache. However, we are incorrectly passing `(key, value)` to `set`
when the function expects `(obj, value)`.
This is causing problems for caches that uses a custom cache keying
function (such as Glimmer's compilation cache), because the get side
would handle the keying correctly, but the set side would compute the
key based on the already-computed key (i.e. `this.key(this.key(obj))`).
In Glimmer's compilation cache, this is causing the cache to always miss
because the `set` side would cache everything under the `"undefined"`
key. | [bugfix beta] fix ember-metal/cache | 35 | false | false | 4 | false | false | false | emberjs | ember.js | 9,086 |
99874064d8b70e858509e9263439491faf7aa176 | Godhuda | Godhuda | [GLIMMER2] Add failing tests for compilation cache | [glimmer2] add failing tests for compilation cache | 50 | false | false | 7 | false | false | false | emberjs | ember.js | 9,087 |
af78380b7438b075e98059274c8f34379414d702 | Robert Jackson | GitHub | Merge pull request #13937 from chadhietala/pr/13935
[Glimmer2] afterRender fix | merge pull request from chadhietala/pr/13935 | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 9,088 |
113ef3aed34c5b35cade739e69550b32374d0e13 | Chad Hietala | Chad Hietala | [Glimmer2] afterRender fix | [glimmer2] afterrender fix | 26 | false | false | 3 | false | false | false | emberjs | ember.js | 9,089 |
1a5e9c4e4710da71ab6f283c04fc2b3dfb7b2b1b | Kris Selden | Kris Selden | [glimmer2] ensure that changes after render are reflected to DOM
Recheck tag on loop end for changes since render, then start another
loop immediately after if check fails, with some hard limit for now
of how many times it will do this before giving up. | [glimmer2] ensure that changes after render are reflected to dom | 64 | false | false | 10 | false | false | false | emberjs | ember.js | 9,090 |
0628013c10d07060d18aa18b7bc31ce01a400ab0 | Robert Jackson | GitHub | Merge pull request #13920 from rwjblue/add-info-to-binding-deprecation
[BUGFIX release] Add more info to the `Ember.Binding` deprecation. | merge pull request from rwjblue/add-info-to-binding-deprecation | 64 | true | false | 5 | true | false | false | emberjs | ember.js | 9,091 |
7d486b91918271a18425676d82b6de67e492de8c | Robert Jackson | GitHub | Merge pull request #13933 from rwjblue/skip-failing-tests-in-glimmer
[GLIMMER] Skip remaining failing tests when flag is enabled. | merge pull request from rwjblue/skip-failing-tests-in-glimmer | 62 | true | false | 5 | true | false | false | emberjs | ember.js | 9,092 |
c828a68c3d11cbd83892c1385d827dd4675d84fe | Robert Jackson | Robert Jackson | [GLIMMER] Skip remaining failing tests when flag is enabled. | [glimmer] skip remaining failing tests when flag is enabled | 59 | false | false | 9 | false | false | false | emberjs | ember.js | 9,093 |
64979def9ab95212895dea8593e9a8b563d585aa | Godfrey Chan | GitHub | Merge pull request #13927 from emberjs/non-volatile-proxies
[GLIMMER2] Make proxies not VOLATILE | merge pull request from emberjs/non-volatile-proxies | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 9,094 |
72aaec19be7000ca79e4959515261cf143642a00 | Godfrey Chan | GitHub | Merge pull request #13928 from emberjs/unskip-mut
[GLIMMER2] Unskip a {{mut}} test | merge pull request from emberjs/unskip-mut | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 9,095 |
73be39530d8a7a568222dbbbdb1e215ac887a1f3 | Godfrey Chan | GitHub | Merge pull request #13926 from chadhietala/unskip-html-safe-test
[Glimmer2] Unskip html-safe test | merge pull request from chadhietala/unskip-html-safe-test | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 9,096 |
cc0b1b253b9dd1d35652375bdd1a9448f50bd475 | Godfrey Chan | Godfrey Chan | [GLIMMER2] Make proxies not VOLATILE
This was done previously to be more conservative, but I suspect it is
not actually needed. As long as things you are proxying are dirtied with
a `set`, this should be fine.
`CURRENT_TAG` means if anything within the boundaries of the object
model has changed, then this object _might_ have changed. `VOLATILE_TAG`
means the object you are talking about falls outside of the boundaries
of the object model, therefore you literally cannot tell.
I don’t _think_ that’s needed for proxy. If this is causing problems in
real apps during alpha, we can revert it. | [glimmer2] make proxies not volatile | 36 | false | false | 5 | false | false | false | emberjs | ember.js | 9,097 |
2a70be3fef6e09c998e2a3e0da58c2c81c8545fa | Godfrey Chan | Godfrey Chan | [GLIMMER2] Unskip a {{mut}} test
The backtracking rerender work re-aligned the semantics here | [glimmer2] unskip a {{mut}} test | 32 | false | false | 5 | false | false | false | emberjs | ember.js | 9,098 |
c79b7626aaee6ba4765844f21b423c35b3084331 | Godfrey Chan | GitHub | Merge pull request #13925 from chadhietala/closure-components-follow-up
[Glimmer2] Cleanup positional argument merging | merge pull request from chadhietala/closure-components-follow-up | 65 | true | false | 5 | true | false | false | emberjs | ember.js | 9,099 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.