sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
336974825be2aa061c293561e32a2d1f1a9fd531 | Robert Jackson | Robert Jackson | Add v2.8.0-beta.3 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 30ad5145ba199e35314a8ce4afc1253ddd749c11) | add v2.8.0-beta.3 to changelog.md | 33 | false | false | 4 | true | true | true | emberjs | ember.js | 8,900 |
1568459714bbe54d03b6711ea7d3501e08758300 | Robert Jackson | Robert Jackson | Add 2.7.1 to the CHANGELOG.md.
[ci skip]
(cherry picked from commit e6a4a3b00ad1c3e978d9a3692510c90958d28add) | add 2.7.1 to the changelog.md | 29 | false | false | 5 | true | true | true | emberjs | ember.js | 8,901 |
938ad1af87c3eda3da2549924a3965186a6125ef | Robert Jackson | GitHub | Merge pull request #14093 from emberjs/prevent-auto-run-assertions-for-objects-not-in-templates
[GLIMMER] Prevent auto-run assertion for objects not rendered. | merge pull request from emberjs/prevent-auto-run-assertions-for-objects-not-in-templates | 89 | true | false | 5 | true | false | false | emberjs | ember.js | 8,902 |
533e8aa16deeb421dd594962e138bbf0c2102a16 | Robert Jackson | Godfrey Chan | [GLIMMER] Prevent auto-run assertion for objects not rendered.
Prior to this change any `Ember.set` done after **any** rendering has
been done during tests will trigger the auto-run assertion.
This change prevents the auto-run assertion when a given object has not
been used in rendering process. | [glimmer] prevent auto-run assertion for objects not rendered | 61 | false | false | 8 | false | false | false | emberjs | ember.js | 8,903 |
e150088e65f86bc0464e74120b84ac4bbc1d9101 | Robert Jackson | GitHub | Merge pull request #14090 from rwjblue/will-clear-render
[GLIMMER] Ensure willClearRender is called. | merge pull request from rwjblue/will-clear-render | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 8,904 |
ce72c7e482d8217234ab3b73f3049441c71b39b7 | Trent Willis | Trent Willis | [BUGFIX beta] Check that handler exists before triggering event
This is necessary for lazily-loaded routes where the handler is not
available synchronously. This includes events like loading and
queryParamsDidChange which trigger synchronously after starting a
transition, in those cases we should by-pass handlers that are not
yet loaded. | [bugfix beta] check that handler exists before triggering event | 63 | false | false | 9 | false | false | false | emberjs | ember.js | 8,905 |
b0bc1111b043d5116217efd7d085ef137bd71769 | Chad Hietala | Chad Hietala | Adds external helpers for babel | adds external helpers for babel | 31 | false | false | 5 | false | false | false | emberjs | ember.js | 8,906 |
e3aa15c0e2d584a2da4a51bfc5eb2725bbca9560 | Robert Jackson | Robert Jackson | [GLIMMER] Ensure willClearRender is called.
This hook is somewhat silly at this point, since the entire purpose
makes very little sense today, but it is still invoked in HTMLBars
(right after `willDestroyElement`) so we should keep it around for
Glimmer2 as well.
I am absolutely in favor of deprecating and removing in future
iterations. | [glimmer] ensure willclearrender is called | 42 | false | false | 5 | false | false | false | emberjs | ember.js | 8,907 |
c49ff666c2f9315455df5cc2e951283104603c51 | Robert Jackson | GitHub | Merge pull request #14082 from emberjs/each-update-test
Add a (failing on Glimmer) test for #13983 | merge pull request from emberjs/each-update-test | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 8,908 |
e46790b8cab75ef1c461cdaf483824a840e0ed99 | Godhuda | Godhuda | Bump glimmer-engine
Fixes #13994, #13995, #13983, #14076 | bump glimmer-engine | 19 | true | false | 2 | false | true | false | emberjs | ember.js | 8,909 |
40fe91a21e39cca4e042278628abf8813b8365f8 | Godhuda | Godhuda | Add a (failing on Glimmer) test for #13983 | add a (failing on glimmer) test for | 35 | false | false | 7 | true | false | true | emberjs | ember.js | 8,910 |
7a963b0003eb0651fc9a6cfb35f16601a5ee6128 | Robert Jackson | GitHub | Merge pull request #14084 from rwjblue/fix-each-package-tests
Fix `eachPackageTests` to actually run for each package. | merge pull request from rwjblue/fix-each-package-tests | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 8,911 |
d9c9d47e77eeb40ad19cf01d5fd9bb3920cacdf2 | Robert Jackson | Robert Jackson | Fix `eachPackageTests` to actually run for each package.
When `lib/packages.js` was refactored to be a function, this iteration
in the each package tests was missed. | fix `eachpackagetests` to actually run for each package | 55 | false | false | 8 | false | true | false | emberjs | ember.js | 8,912 |
14a18e7109eb6e678932a971769e73c9259fc043 | Godfrey Chan | GitHub | Merge pull request #14059 from emberjs/burndown-skipped-tests
Unify most remaining @htmlbars tests | merge pull request from emberjs/burndown-skipped-tests | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 8,913 |
e8318e85ab230fe1e842509c741703e1d0080557 | Robert Jackson | GitHub | Merge pull request #14077 from nathanhammond/update-r-r
[BUGFIX beta] Update route-recognizer. | merge pull request from nathanhammond/update-r-r | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 8,914 |
d981dadc2a58aa63dc8b74c66e06279465b76974 | Godfrey Chan | Godfrey Chan | Unify another element action modify test
Unsure if we need to be testing the implementation details here, but the
difference is trivial. | unify another element action modify test | 40 | false | false | 6 | true | true | true | emberjs | ember.js | 8,915 |
d26e7ab9909dadfa22408cb8ab289b5fb7cbe212 | Godfrey Chan | Godfrey Chan | Unify backtracking-rerender tests | unify backtracking-rerender tests | 33 | false | false | 3 | false | false | false | emberjs | ember.js | 8,916 |
2f5f485d15ea180e4f1733f8f7e06d8d29314f9e | Godfrey Chan | Godfrey Chan | Unify another test
The difference is in Glimmer, the hooks are not called when nothing has
changed. This also refactored the tests to be more readable. | unify another test | 18 | false | false | 3 | true | true | true | emberjs | ember.js | 8,917 |
93ae5ab1c7055edc455562cbab15cd7e8418612e | Godfrey Chan | Godfrey Chan | Unify another duplicated test | unify another duplicated test | 29 | false | false | 4 | true | true | true | emberjs | ember.js | 8,918 |
8d4adf1776eeeaa70504dfcc6c7e0ef919a6dce0 | Godfrey Chan | Godfrey Chan | Unify the “multiple actions modifier” tests
The only difference is the assertion that tests two action attributes
were added, which is an implementation detail that we don’t need to be
testing. | unify the “multiple actions modifier” tests | 43 | false | false | 6 | false | false | false | emberjs | ember.js | 8,919 |
b289ec5e792d941ebae0ca97b8ad8869be5d40be | Godfrey Chan | Godfrey Chan | [GLIMMER2] Implement `UPDATE` for `(get)` helper
Also improves the test coverage (the tests didn’t test changing the key
before). | [glimmer2] implement `update` for `(get)` helper | 48 | false | false | 6 | false | false | false | emberjs | ember.js | 8,920 |
a1b430aa9d957fd8eddb43d6dc8fc8477a9fd0c2 | Godfrey Chan | Godfrey Chan | [GLIMMER2] Unskip working test | [glimmer2] unskip working test | 30 | false | false | 4 | false | false | false | emberjs | ember.js | 8,921 |
8d57efc8d7f9b1df023b56d55b6878758c96aff6 | Godfrey Chan | Godfrey Chan | Fix incorrectly named tests, merge duplicated tests and do INUR | fix incorrectly named tests, merge duplicated tests and do inur | 63 | false | false | 10 | false | false | false | emberjs | ember.js | 8,922 |
0552496206bf939850410b44b9b06f15a8531b5a | Godfrey Chan | Godfrey Chan | Fixed wrong test, it now passes on both engines | fixed wrong test, it now passes on both engines | 47 | false | false | 9 | false | false | false | emberjs | ember.js | 8,923 |
3c30b36f9d56833241dcbfde723fafc7c6cbaedc | Godfrey Chan | Godfrey Chan | [GLIMMER2] `attributeBindings` for `id` are not updatable | [glimmer2] `attributebindings` for `id` are not updatable | 57 | false | false | 7 | false | false | false | emberjs | ember.js | 8,924 |
58121ffd35729e7917785408139d908ce8a6ad88 | Godfrey Chan | GitHub | Merge pull request #14072 from emberjs/glimmer-cleanup
Glimmer cleanup | merge pull request from emberjs/glimmer-cleanup | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 8,925 |
b37377577d439b76d6706e60b2f291a41b7b15d2 | Godfrey Chan | Godfrey Chan | [GLIMMER2] Bump Glimmer to get new `isConst`
This allows more references that don’t inherit from `ConstRefernce` to
be considered “constant” for the purpose of optimization. Specifically,
`isConst` now consider everything with a `CONSTANT_TAG` to be constant. | [glimmer2] bump glimmer to get new `isconst` | 44 | false | false | 7 | false | false | false | emberjs | ember.js | 8,926 |
0f25156bf031cc0f40ae462494d096e12cac571a | Nathan Hammond | Nathan Hammond | [BUGFIX beta] Update route-recognizer. | [bugfix beta] update route-recognizer | 37 | false | false | 4 | false | false | false | emberjs | ember.js | 8,927 |
a7718e4997fafc0352c9d51cdbb7b7fd277c9b2d | Godfrey Chan | Godfrey Chan | [GLIMMER2] Remove unused `invalidate` code | [glimmer2] remove unused `invalidate` code | 42 | false | false | 5 | false | false | false | emberjs | ember.js | 8,928 |
284be5f1c285661f3e26d9c90b53380125cb4547 | Godfrey Chan | Godfrey Chan | [GLIMMER2] Simplify `hash` helper
The hash helper simply means “give me the named args”, so we can simply
pass along `args.named` which is already a `PathReference`. | [glimmer2] simplify `hash` helper | 33 | false | false | 4 | false | false | false | emberjs | ember.js | 8,929 |
70a24648c29112447ed8450535d133e8d1713221 | Robert Jackson | GitHub | Merge pull request #14065 from Serabe/fix/14057
[DOC relase] Improve `mut` documentation | merge pull request from serabe/fix/14057 | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 8,930 |
b3d0f081b01df9443f6c1377223809f7020ec7b5 | Robert Jackson | GitHub | Merge pull request #14070 from bantic/remove-unused-with-key-code
Remove unused `withKeyCode` option for ActionHelper | merge pull request from bantic/remove-unused-with-key-code | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 8,931 |
ccfef8b865f69c125c6c75017587e24adec143ba | Robert Jackson | GitHub | Merge pull request #14069 from rwjblue/update-testem-config
Update testem config to use `latest` when possible. | merge pull request from rwjblue/update-testem-config | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 8,932 |
d47736c07622300cef813a5619383590f0af3fe7 | Robert Jackson | GitHub | Merge pull request #13980 from emberjs/migrate-remainder-of-outlet-tests
Migrate remainder of outlet tests to new testing setup. | merge pull request from emberjs/migrate-remainder-of-outlet-tests | 66 | true | false | 5 | true | false | false | emberjs | ember.js | 8,933 |
ed0e92c526aba032a62a9a32b6a49cb8dfbfa39f | Cory | Cory | Remove unused `withKeyCode` option for ActionHelper
The ability to pass `withKeyCode` to `{{action}}` was removed in
4f5aa0632ffeccdaa17430748d16d3146b55bc36 when the use of a feature flag named
`"ember-routing-handlebars-action-with-key-code"` was reverted. The removal commit left
this unused `withKeyCode` option to `ActionHelpers.registerAction`. | remove unused `withkeycode` option for actionhelper | 51 | false | false | 6 | true | true | false | emberjs | ember.js | 8,934 |
cb318bc7fb2d98c8d0434502b9e917f61f50602a | Robert Jackson | Robert Jackson | Update testem config to use `latest` when possible.
* Use `latest` for Chrome
* Use `latest` for FireFox (was using 45) | update testem config to use `latest` when possible | 50 | false | false | 8 | true | true | true | emberjs | ember.js | 8,935 |
ee464a72010041aed04a578f8c076aed5e2daec6 | Robert Jackson | Robert Jackson | [GLIMMER] Fix `{{outlet}}` tests to use DI for templates. | [glimmer] fix `{{outlet}}` tests to use di for templates | 56 | false | false | 9 | false | false | false | emberjs | ember.js | 8,936 |
d8936f88d204c8d50372eddf807ef55c940dc203 | Robert Jackson | Robert Jackson | Migrate remainder of outlet tests to new testing setup. | migrate remainder of outlet tests to new testing setup | 54 | false | false | 9 | false | true | false | emberjs | ember.js | 8,937 |
07cc7893ff821e3109243a9845a38c9aa5f75e3d | Robert Jackson | GitHub | Merge pull request #14068 from alisdair/fix-link-to-query-params-undefined
Default queryParams for link-to must have values | merge pull request from alisdair/fix-link-to-query-params-undefined | 68 | true | false | 5 | true | false | false | emberjs | ember.js | 8,938 |
574b64b31a852e7c4aa07aabe2ececdc6ae32945 | Robert Jackson | GitHub | Merge pull request #14066 from simonihmig/patch-1
[BUGFIX beta] Update router.js to fix Phantom 1.9 issues. | merge pull request from simonihmig/patch-1 | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 8,939 |
266474d44af6e08cb695f72f0fd0c6e7f8ea861b | Alisdair McDiarmid | Alisdair McDiarmid | Default queryParams in link-to must have values
Fixes #14010 | default queryparams in link-to must have values | 47 | false | false | 7 | false | false | false | emberjs | ember.js | 8,940 |
b229ca93338a2e9f4871f46dd5d40cb3f2b765b2 | Alisdair McDiarmid | Alisdair McDiarmid | Failing test for #14010 | failing test for | 16 | false | false | 3 | false | false | false | emberjs | ember.js | 8,941 |
c0d9752582cb20bb811a88475aa3f03fd079a66b | Simon Ihmig | GitHub | [BUGFIX beta] Update router.js to fix Phantom 1.9 issues. | [bugfix beta] update router.js to fix phantom 1.9 issues | 56 | false | false | 9 | false | false | false | emberjs | ember.js | 8,942 |
4eeff936d268cc455e0a45c472a0a62fca9d9639 | Robert Jackson | GitHub | Merge pull request #14062 from emberjs/rwjblue-patch-1
[BUGFIX beta] Update router.js to fix Phantom 1.9 issues. | merge pull request from emberjs/rwjblue-patch-1 | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 8,943 |
436c330fa13a191b668d2608a9b2df92f48c8f71 | Sergio Arbeo | Sergio Arbeo | [DOC relase] Improve `mut` documentation
`mut` documentation contains code that does not work. It also references a blog
post with outdated information.
This PR fixes the code with the right behaviour and remove the link to avoid
confussion.
Fixes #14057 | [doc relase] improve `mut` documentation | 40 | false | false | 5 | false | false | false | emberjs | ember.js | 8,944 |
fe04569456bd22f5d1e9be65a048ff82f8474ded | Robert Jackson | GitHub | Merge pull request #14061 from rwjblue/provide-correct-glimmer-template-compiler
Update emberjs-build to v0.14.0. | merge pull request from rwjblue/provide-correct-glimmer-template-compiler | 74 | true | false | 5 | true | false | false | emberjs | ember.js | 8,945 |
18678b75db328f66a67931f8bd8bfde55549a45e | Robert Jackson | Robert Jackson | Update emberjs-build to v0.14.0.
Updates to a version of emberjs-build that does not use
glimmer-template-precompiler (an obsolete package). Instead it passes
through the current glimmer version to the underlying template
compliation so that the templates shipped with Ember are for the same
version of glimmer that will be used at runtime.
Also, updates to using tagged builds. | update emberjs-build to v0.14.0 | 31 | false | false | 4 | true | true | true | emberjs | ember.js | 8,946 |
22369507e948428a2cc0ca0a2f5d5a33b45a8762 | Sergio Arbeo | Sergio Arbeo | [DOC beta] Improve `Route#render` documentation
This PR makes explicit that render only accepts a live template
as its `into` option.
Fix #14046 | [doc beta] improve `route#render` documentation | 47 | false | false | 5 | false | false | false | emberjs | ember.js | 8,947 |
2a938b9a016e69a6c1a723b145d560d6bc167d12 | Robert Jackson | GitHub | [BUGFIX beta] Update router.js to fix Phantom 1.9 issues.
:rage: | [bugfix beta] update router.js to fix phantom 1.9 issues | 56 | false | false | 9 | false | false | false | emberjs | ember.js | 8,948 |
31d3ba764e6b2e6e0336090caf4ecea674a58bed | Robert Jackson | GitHub | Merge pull request #14060 from rwjblue/use-upstreamed-cache-invalidation
Update emberjs-build to 0.13.5. | merge pull request from rwjblue/use-upstreamed-cache-invalidation | 66 | true | false | 5 | true | false | false | emberjs | ember.js | 8,949 |
3bdd7b5e68052541fda3c734d9d4c70c2cfa492b | Robert Jackson | Robert Jackson | Update emberjs-build to 0.13.5.
The cache invalidation issues that were being monkey patched around,
have been fixed upstream in broccoli-babel-transpiler.
These manual hacks are no longer needed. | update emberjs-build to 0.13.5 | 30 | false | false | 4 | true | true | true | emberjs | ember.js | 8,950 |
98cbb482c7e98e74d72a297ee9df8740b5718883 | Robert Jackson | GitHub | Merge pull request #14058 from emberjs/update-r-r
[BUGFIX release] Update route-recognizer to v0.2.1. | merge pull request from emberjs/update-r-r | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 8,951 |
ffa25a90b2833ec2e4ead0dcb1689118c6125bbb | Robert Jackson | GitHub | Merge pull request #14056 from maletor/patch-1
features: remove ember-routable-components | merge pull request from maletor/patch-1 | 40 | true | false | 5 | true | false | false | emberjs | ember.js | 8,952 |
3ccf02871f769cf4c2998c3591d8a658e6809b36 | Robert Jackson | Robert Jackson | [BUGFIX release] Update route-recognizer to v0.2.1. | [bugfix release] update route-recognizer to v0.2.1 | 50 | false | false | 6 | false | false | false | emberjs | ember.js | 8,953 |
23eac6478a8c6516da3b756d1dacf98a0d341a71 | Ellis Berner | GitHub | features: remove ember-routable-components
It looks like someone forgot to remove this feature since it does not exist in `features.json`. | remove ember-routable-components | 32 | false | false | 2 | false | true | false | emberjs | ember.js | 8,954 |
caa9d3f8c36ec58d5ca3291e1897d4e684516a74 | Robert Jackson | GitHub | Merge pull request #14054 from trentmwillis/reset-substates
[BUGFIX beta] Ensure substates properly work with resetNamespace | merge pull request from trentmwillis/reset-substates | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 8,955 |
9a69d632b27faf0592c58698e3eb83ccced2d972 | Trent Willis | Trent Willis | [BUGFIX beta] Ensure substates properly work with resetNamespace | [bugfix beta] ensure substates properly work with resetnamespace | 64 | false | false | 8 | false | false | false | emberjs | ember.js | 8,956 |
6558db677105a15efda5f35dcc7d9a70beff1984 | Robert Jackson | GitHub | Merge pull request #14053 from TheAlphaNerd/de-submodule
chore: remove submodules | merge pull request from thealphanerd/de-submodule | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 8,957 |
028efd02d36e29397a931d353d99aeeb385917ad | Myles Borins | Myles Borins | chore: remove submodules
According to [rwjblue][1] the submodules are not used anymore
[1]: https://github.com/nodejs/citgm/pull/159#issuecomment-239156530 | remove submodules | 17 | false | false | 2 | true | true | false | emberjs | ember.js | 8,958 |
f9981ef7619965e0089f969fa81b043c48dddcee | Ricardo Mendes | GitHub | Merge pull request #14051 from bmeurant/includes-doc
[DOC] Fix code blocks for includes | merge pull request from bmeurant/includes-doc | 46 | true | false | 5 | true | true | false | emberjs | ember.js | 8,959 |
729adcae57338cca2c074ff5ecb695b347b45ef4 | Godfrey Chan | GitHub | Merge pull request #14041 from emberjs/optimize-property-reference
[GLIMMER2] Optimize {{property}} PropertyReference | merge pull request from emberjs/optimize-property-reference | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 8,960 |
47511c35261822ec215802fddd2fd1871e0cb2ff | Godfrey Chan | Godfrey Chan | [GLIMMER2] Move child ref caching into `RootReference` | [glimmer2] move child ref caching into `rootreference` | 54 | false | false | 7 | false | false | false | emberjs | ember.js | 8,961 |
7458fd2b083a6aba4209f4da146a8150da324955 | Godfrey Chan | Godfrey Chan | [GLIMMER2] (╯°□°)╯︵ ƃuᴉdǝǝʞ-ʞooq ʎxoɹd dᴉlℲ
This commit flips the responsibilities around – instead of making each
reference do the work to track whether they are dealing with proxies, we
can just make proxies themselves provide the right tag and do the book-
keeping internally.
With this change, `tagFor(proxy)` will return a tag that accounts for
changes on the proxy itself as well as its content. This frees the rest
of the system from worrying about that difference and removes a lot of
runtime `isProxy` checks. | [glimmer2] (╯°□°)╯︵ ƃuᴉdǝǝʞ-ʞooq ʎxoɹd dᴉlⅎ | 43 | false | false | 5 | false | false | false | emberjs | ember.js | 8,962 |
f3e3b9c55249a9eb827719fca5a4cc7945c6d8a4 | Baptiste Meurant | Baptiste Meurant | [DOC] Fix code blocks for includes | [doc] fix code blocks for includes | 34 | false | false | 6 | false | false | false | emberjs | ember.js | 8,963 |
caf4ab80a68e25892a8dfb2564aca3d3ad1c1a03 | Chad Hietala | GitHub | Merge pull request #14048 from mitchlloyd/mitchlloyd/cleanup-dead-code
Remove dead code | merge pull request from mitchlloyd/mitchlloyd/cleanup-dead-code | 64 | true | false | 5 | true | false | false | emberjs | ember.js | 8,964 |
ee050f46f6e5c94266db56292ad7a67d64af6333 | Mitch Lloyd | Mitch Lloyd | Remove dead code | remove dead code | 16 | false | false | 3 | true | true | true | emberjs | ember.js | 8,965 |
6f5402693ebff985113fa54a095b34bed38fd7c0 | Robert Jackson | GitHub | Merge pull request #14044 from trentmwillis/router-bump
[BUGFIX Beta] Bump router.js so that getHandlers is invoked lazily | merge pull request from trentmwillis/router-bump | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 8,966 |
0f6a800f11c1343fc05f73c59a9aeedb023ebeb9 | Godfrey Chan | GitHub | Merge pull request #14028 from chadhietala/pr/14019
Correct -normalize-class and AST plugin | merge pull request from chadhietala/pr/14019 | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 8,967 |
bbd88954e48a203e393a2df2130a7f456bda5fc7 | Trent Willis | Trent Willis | [BUGFIX beta] Bump router.js so that getHandlers is invoked lazily | [bugfix beta] bump router.js so that gethandlers is invoked lazily | 66 | false | false | 10 | false | false | false | emberjs | ember.js | 8,968 |
19ea8a947d35436060924458f3922f6443c3784b | Chad Hietala | Chad Hietala | [Glimmer2] Correct and split AST plugin for old class bindings | [glimmer2] correct and split ast plugin for old class bindings | 62 | false | false | 10 | false | false | false | emberjs | ember.js | 8,969 |
8219e0d26ed71ceea0da3d21f4e53d9a4f780bb2 | Kris Selden | GitHub | Merge pull request #14043 from emberjs/remove-duplicate-import
Update index.js | merge pull request from emberjs/remove-duplicate-import | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 8,970 |
57b217bdff2b568e73fd3161864d0db224cb7a6a | Godfrey Chan | Godfrey Chan | [CLEANUP] Remove `init` arguments checking
We don’t need this anymore, see a447c48ece6d7ae00139f0e95f739b14c640d0a6 | [cleanup] remove `init` arguments checking | 42 | false | false | 5 | false | false | false | emberjs | ember.js | 8,971 |
e0680caa7f2a583deadeec9682ece57debdd8e5b | Godfrey Chan | Godfrey Chan | `POST_INIT` do not take arguments | `post_init` do not take arguments | 33 | false | false | 5 | false | false | false | emberjs | ember.js | 8,972 |
b6e2712bf0b10ce4ec739cbceb3a66cff1efc8db | Godfrey Chan | Godfrey Chan | [GLIMMER2] Move `[IS_DISPATCHING_ATTRS]` to `init`
This avoids an extra shape transition when the component is updated. | [glimmer2] move `[is_dispatching_attrs]` to `init` | 50 | false | false | 5 | false | false | false | emberjs | ember.js | 8,973 |
588509213e63d535ae54f4bb268734a4d8c82777 | Godfrey Chan | Godfrey Chan | [GLIMMER2] Optimize {{property}} PropertyReference
A quick survey in our app indicates ~77% of `PropertyReference` have a
const parent. This is unsurprising, because most path lookup curlies are
single-level (no dots in the path) lookup on the component directly.
This means we can do less work and book-keeping in those cases (checking
if the parent is a proxy on every `compute`, etc). | [glimmer2] optimize {{property}} propertyreference | 50 | false | false | 4 | false | false | false | emberjs | ember.js | 8,974 |
1843fa449beb86f3aa184d306ac1fa541b422626 | Stefan Penner | GitHub | Update index.js | update index.js | 15 | false | false | 2 | true | false | false | emberjs | ember.js | 8,975 |
8438d2b68a8a83e76262c21d56fbc6efeb0d147c | Robert Jackson | GitHub | Merge pull request #14042 from emberjs/fix-call-apply
Restructure code to avoid awkward compilation | merge pull request from emberjs/fix-call-apply | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 8,976 |
188cf49440c043b00e5ae24b03bf85b7f8120b03 | Sergio Arbeo | Sergio Arbeo | [DOC beta] Mark `LinkComponent#activeClass` as public.
`activeClass` is mark as private in `Ember.LinkComponent` though in the
documentation suggests to use it for modifying the class added when link is
active. | [doc beta] mark `linkcomponent#activeclass` as public | 53 | false | false | 6 | false | false | false | emberjs | ember.js | 8,977 |
40c37b6b62a2411adecb7901921c8a6b208d5d19 | Godfrey Chan | Godfrey Chan | Restructure code to avoid awkward compilation
Before:
```
Route.reopen({
replaceWith: function () {
for (var _len3 = arguments.length, args = Array(_len3), _key3 = 0; _key3 < _len3; _key3++) {
args[_key3] = arguments[_key3];
}
return this._super.apply(this, prefixRouteNameArg.call.apply(prefixRouteNameArg, [this].concat(args)));
},
transitionTo: function () {
for (var _len4 = arguments.length, args = Array(_len4), _key4 = 0; _key4 < _len4; _key4++) {
args[_key4] = arguments[_key4];
}
return this._super.apply(this, prefixRouteNameArg.call.apply(prefixRouteNameArg, [this].concat(args)));
},
...
});
```
After:
```
Route.reopen({
replaceWith: function () {
for (var _len3 = arguments.length, args = Array(_len3), _key3 = 0; _key3 < _len3; _key3++) {
args[_key3] = arguments[_key3];
}
return this._super.apply(this, prefixRouteNameArg(this,args));
},
transitionTo: function () {
for (var _len4 = arguments.length, args = Array(_len4), _key4 = 0; _key4 < _len4; _key4++) {
args[_key4] = arguments[_key4];
}
return this._super.apply(this, prefixRouteNameArg(this,args));
},
...
});
```
Which is more readable and avoid a needless allocation from the `concat`
(and presumably `.call.apply` is rather inefficient).
As a bonus, it also removes the splatting in `prefixRouteNameArg`. | restructure code to avoid awkward compilation | 45 | false | false | 6 | false | true | false | emberjs | ember.js | 8,978 |
e540e5d21e0d2a6a8af0461a1a9ec9eab724848e | Matthew Beale | GitHub | Merge pull request #13965 from GUI/queryParamsDidChange-doc-fix
[DOC release] Fix documentation of Route queryParamsDidChange | merge pull request from gui/queryparamsdidchange-doc-fix | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 8,979 |
71a5f610b5e65c8a0eb78f0562d0514feac43010 | Matthew Beale | GitHub | Merge pull request #13989 from jasonly/patch-2
[DOC] Update README.md | merge pull request from jasonly/patch-2 | 40 | true | false | 5 | true | false | false | emberjs | ember.js | 8,980 |
fff8129c3d1595100a8f85fc7965e86fc35b6201 | Matthew Beale | GitHub | Merge pull request #13990 from jasonly/patch-3
[DOC] Syntax highlighting FEATURES.md | merge pull request from jasonly/patch-3 | 40 | true | false | 5 | true | false | false | emberjs | ember.js | 8,981 |
1631de0e229efe8b7153c9535ce3fb4874778300 | Matthew Beale | GitHub | Merge pull request #13991 from jasonly/patch-4
[DOC] Syntax highlighting CONTRIBUTING.md | merge pull request from jasonly/patch-4 | 40 | true | false | 5 | true | false | false | emberjs | ember.js | 8,982 |
0ef7ce369f2645852a4250d4964e09b6253d0a6d | Matthew Beale | GitHub | Merge pull request #14039 from Serabe/fix/14020
[CLEANUP] Move components to glimmer | merge pull request from serabe/fix/14020 | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 8,983 |
156b1f7b472c37f36b480328cf3694e941ea02ae | Matthew Beale | GitHub | Merge pull request #14030 from rwjblue/fixes-glimmer-outlet-without-jquery
[GLIMMER] Fix OutletView#appendTo when jQuery is not present. | merge pull request from rwjblue/fixes-glimmer-outlet-without-jquery | 68 | true | false | 5 | true | false | false | emberjs | ember.js | 8,984 |
fe48cd5e4d804279bc99d6a58a7ae627531bc112 | Robert Jackson | GitHub | Merge pull request #14037 from Serabe/fix/14024
[DOC release] Boolean `attributeBindings` documentation updated | merge pull request from serabe/fix/14024 | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 8,985 |
fb1870f0f16a0521499c116d60d3afffbce36699 | Robert Jackson | GitHub | Merge pull request #14038 from Serabe/fix/14022
[DOC release] Fix `setEach` documentation | merge pull request from serabe/fix/14022 | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 8,986 |
a91f4ecbb1cc0cddbe930d11d6ead2d15f257185 | Sergio Arbeo | Sergio Arbeo | [CLEANUP] Move components to glimmer
The original code is moved from `ember-htmlbars` to `ember-glimmer` and
symlinked from `ember-htmlbars`
Fixes #14020 | [cleanup] move components to glimmer | 36 | false | false | 5 | false | false | false | emberjs | ember.js | 8,987 |
851461235377c4d90f8a2a73129b1979328d1836 | Sergio Arbeo | Sergio Arbeo | [DOC release] Fix `setEach` documentation
As suggested in #14022, `setEach` is a more ergonomic, not more efficient
method.
Fixes #14022 | [doc release] fix `seteach` documentation | 41 | false | false | 5 | false | false | false | emberjs | ember.js | 8,988 |
5d2175a5ae8ea33c18352ed2f53b339715b23901 | Sergio Arbeo | Sergio Arbeo | [DOC release] Boolean `attributeBindings` documentation updated
From [HTML5, A vocabulary and associated APIs for HTML and
XHTML](https://www.w3.org/TR/html5/infrastructure.html#boolean-attributes):
A number of attributes are boolean attributes. The presence of a boolean
attribute on an element represents the true value, and the absence of the
attribute represents the false value.
**Note:** The values "true" and "false" are not allowed on boolean
attributes. To represent a false value, the attribute has to be omitted
altogether.
Fixes #14024 | [doc release] boolean `attributebindings` documentation updated | 63 | false | false | 6 | false | false | false | emberjs | ember.js | 8,989 |
7f5b5b4f745f328ffd7456052fba6c14aab1c89b | Ricardo Mendes | GitHub | Merge pull request #13986 from ladyleet/issue-13397-bug-fix
[DOC release] Add documentation for click 2nd argument | merge pull request from ladyleet/issue-13397-bug-fix | 53 | true | false | 5 | true | true | false | emberjs | ember.js | 8,990 |
ab0577655ee4ff7e1aed2b50936625e74c46d7fd | Yehuda Katz | GitHub | Merge pull request #14012 from emberjs/reduce-current-tag-2
[GLIMMER2] Remove remaining `CURRENT_TAG`s | merge pull request from emberjs/reduce-current-tag-2 | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 8,991 |
85a8acd5f75f40a17032fb9ca200e9b5797ba19a | Robert Jackson | GitHub | Merge pull request #14035 from emberjs/rm-link-to-will-render
Use `didReceiveAttrs` (instead of `willRender`) in `{{link-to}}` | merge pull request from emberjs/rm-link-to-will-render | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 8,992 |
5e27c4ac0902df129f291083d9d6f8e78d6ea195 | Godfrey Chan | Godfrey Chan | Use `didReceiveAttrs` in `{{link-to}}`
This code only need to run when the arguments/attrs change, not before
every re-render. At least on the Glimmer side, the latter run more often
than the first, so this is unnecessarily doing a bunch of extra work,
invalidating expensive CPs, etc. | use `didreceiveattrs` in `{{link-to}}` | 38 | false | false | 4 | false | true | false | emberjs | ember.js | 8,993 |
3631f01111b43f3b88eb9cec1f2630e8e418bcd8 | Sergio Arbeo | Sergio Arbeo | [DOC release] Extend `Route.paramsFor` documentation
Improve documentation on `Route.paramsFor`.
Fixes #13771 | [doc release] extend `route.paramsfor` documentation | 52 | false | false | 5 | false | false | false | emberjs | ember.js | 8,994 |
3532546912c0e70261b5d1dea9bfce94ddbd817b | Robert Jackson | GitHub | Merge pull request #14033 from Serabe/fix/14018
[BUGFIX beta] `fillIn` only sets value to first match. | merge pull request from serabe/fix/14018 | 41 | true | false | 5 | true | true | false | emberjs | ember.js | 8,995 |
7e9176da06a05ded3381d1ba090b3faa85290d99 | Sergio Arbeo | Sergio Arbeo | [BUGFIX beta] `fillIn` only sets value to first match.
Currently, `fillIn` sets the new value to all matches, though the events are
only fired for the first one, making Ember only aware of that one.
This can cause a problem while trying to _debug_ a test.
Fixes #14018 | [bugfix beta] `fillin` only sets value to first match | 53 | false | false | 9 | false | false | false | emberjs | ember.js | 8,996 |
eecc9f99b58c02c2dc076a9abd816e53671933a0 | Robert Jackson | GitHub | Merge pull request #14025 from trentmwillis/should-render
[BUGFIX] Pass environment options forward to Engines | merge pull request from trentmwillis/should-render | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 8,997 |
7d0c6649e70a2820358001443c48e520b6c78bb1 | Robert Jackson | GitHub | Merge pull request #14027 from emberjs/improve-deprecation-docs
[DOC release] Improve Ember.deprecate documentation | merge pull request from emberjs/improve-deprecation-docs | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 8,998 |
138de8f64fe494158a8cfe992dd7fb0751a3601d | Ricardo Mendes | GitHub | Merge pull request #14026 from wagenet/fix-partial-docs
[DOC release] Use dash for partial naming | merge pull request from wagenet/fix-partial-docs | 49 | true | false | 5 | true | true | false | emberjs | ember.js | 8,999 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.