language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | spring-projects | spring-framework | 26bb3a0893564ab2f17cf7ac9d6fa86593995dea.json | Improve docs on enabling Servlet 3 multipart | spring-web/src/main/java/org/springframework/web/multipart/support/StandardServletMultipartResolver.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -41,6 +41,18 @@
* storage locations need t... | true |
Other | spring-projects | spring-framework | 26bb3a0893564ab2f17cf7ac9d6fa86593995dea.json | Improve docs on enabling Servlet 3 multipart | src/docs/asciidoc/web/webmvc.adoc | @@ -999,11 +999,27 @@ have `commons-fileupload` as a dependency on your classpath.
[[mvc-multipart-resolver-standard]]
==== Servlet 3.0
-To use Servlet 3.0 multipart support, you need to register the `DispatcherServlet`
-accordingly. In programmatic Servlet registration, set a `MultipartConfigElement` on the
-Servl... | true |
Other | spring-projects | spring-framework | 8651b8d4c1b09d3bb75bb0cf56791970a72751d8.json | Show use of RequestEntity rather than HttpEntity
Issue: SPR-16608 | spring-web/src/main/java/org/springframework/web/client/RestTemplate.java | @@ -89,9 +89,7 @@
* HTTP PATCH, HTTP PUT with response body, etc.). Note however that the underlying HTTP
* library used must also support the desired combination.
*
- * <p>For each HTTP method there are three variants: two accept a URI template string
- * and URI variables (array or map) while a third accepts a ... | true |
Other | spring-projects | spring-framework | 8651b8d4c1b09d3bb75bb0cf56791970a72751d8.json | Show use of RequestEntity rather than HttpEntity
Issue: SPR-16608 | src/docs/asciidoc/integration.adoc | @@ -1159,7 +1159,7 @@ on preparing URIs or customizing how the `RestTemplate` expands URI templates, s
===== Dealing with request and response headers
Besides the methods described above, the `RestTemplate` also has the `exchange()`
-method, which can be used for arbitrary HTTP method execution based on the `HttpEn... | true |
Other | spring-projects | spring-framework | 9d63f805b3b3ad07f102f6df779b852b2d1f306c.json | Fix AsciiDoc typos in AOP documentation (#1743)
* Fix AsciiDoc typos in AOP documentation
* Polish formatting | src/docs/asciidoc/core/core-aop.adoc | @@ -1630,7 +1630,7 @@ using the `ref` attribute:
</bean>
----
-The bean backing the aspect (" `aBean`" in this case) can of course be configured and
+The bean backing the aspect (`"aBean"` in this case) can of course be configured and
dependency injected just like any other Spring bean.
@@ -1727,12 +1727,12 @... | false |
Other | spring-projects | spring-framework | 04c2a2990dda185cca75ded2b218dff3054dafa8.json | Provide simple way to create ClientResponse
This commit introduces ClientResponse.Builder, an easier way to create a
ClientResponse from an existing response, or from scratch.
Issue: SPR-16553 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/ClientResponse.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -16,20 +16,26 @@
package org.springframew... | true |
Other | spring-projects | spring-framework | 04c2a2990dda185cca75ded2b218dff3054dafa8.json | Provide simple way to create ClientResponse
This commit introduces ClientResponse.Builder, an easier way to create a
ClientResponse from an existing response, or from scratch.
Issue: SPR-16553 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultClientResponse.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -61,6 +61,10 @@ public DefaultClientResponse... | true |
Other | spring-projects | spring-framework | 04c2a2990dda185cca75ded2b218dff3054dafa8.json | Provide simple way to create ClientResponse
This commit introduces ClientResponse.Builder, an easier way to create a
ClientResponse from an existing response, or from scratch.
Issue: SPR-16553 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultClientResponseBuilder.java | @@ -0,0 +1,189 @@
+/*
+ * Copyright 2002-2018 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 04c2a2990dda185cca75ded2b218dff3054dafa8.json | Provide simple way to create ClientResponse
This commit introduces ClientResponse.Builder, an easier way to create a
ClientResponse from an existing response, or from scratch.
Issue: SPR-16553 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/support/ClientResponseWrapper.java | @@ -0,0 +1,176 @@
+/*
+ * Copyright 2002-2018 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 04c2a2990dda185cca75ded2b218dff3054dafa8.json | Provide simple way to create ClientResponse
This commit introduces ClientResponse.Builder, an easier way to create a
ClientResponse from an existing response, or from scratch.
Issue: SPR-16553 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/support/package-info.java | @@ -0,0 +1,26 @@
+/*
+ * Copyright 2002-2018 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | 04c2a2990dda185cca75ded2b218dff3054dafa8.json | Provide simple way to create ClientResponse
This commit introduces ClientResponse.Builder, an easier way to create a
ClientResponse from an existing response, or from scratch.
Issue: SPR-16553 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/support/ServerRequestWrapper.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -40,14 +40,14 @@
import org.springframework... | true |
Other | spring-projects | spring-framework | 04c2a2990dda185cca75ded2b218dff3054dafa8.json | Provide simple way to create ClientResponse
This commit introduces ClientResponse.Builder, an easier way to create a
ClientResponse from an existing response, or from scratch.
Issue: SPR-16553 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/support/package-info.java | @@ -1,5 +1,5 @@
/**
- * Classes supporting the {@code org.springframework.web.reactive.function} package.
+ * Classes supporting the {@code org.springframework.web.reactive.function.server} package.
* Contains a {@code HandlerAdapter} that supports {@code HandlerFunction}s,
* a {@code HandlerResultHandler} that su... | true |
Other | spring-projects | spring-framework | 04c2a2990dda185cca75ded2b218dff3054dafa8.json | Provide simple way to create ClientResponse
This commit introduces ClientResponse.Builder, an easier way to create a
ClientResponse from an existing response, or from scratch.
Issue: SPR-16553 | spring-webflux/src/test/java/org/springframework/web/reactive/function/client/DefaultClientResponseBuilderTests.java | @@ -0,0 +1,104 @@
+/*
+ * Copyright 2002-2018 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 04c2a2990dda185cca75ded2b218dff3054dafa8.json | Provide simple way to create ClientResponse
This commit introduces ClientResponse.Builder, an easier way to create a
ClientResponse from an existing response, or from scratch.
Issue: SPR-16553 | spring-webflux/src/test/java/org/springframework/web/reactive/function/client/support/ClientResponseWrapperTests.java | @@ -0,0 +1,163 @@
+/*
+ * Copyright 2002-2018 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 04c2a2990dda185cca75ded2b218dff3054dafa8.json | Provide simple way to create ClientResponse
This commit introduces ClientResponse.Builder, an easier way to create a
ClientResponse from an existing response, or from scratch.
Issue: SPR-16553 | spring-webflux/src/test/java/org/springframework/web/reactive/function/server/support/ServerRequestWrapperTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -23,10 +23,17 @@
import org.junit.Before;... | true |
Other | spring-projects | spring-framework | 7de2650a7070af4db25ef9b5d87528a679302120.json | Drop @WebServlet annotation
Issue: SPR-16591 | spring-web/src/main/java/org/springframework/http/server/reactive/JettyHttpHandlerAdapter.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -20,7 +20,6 @@
import java.nio.ByteBuffer;
... | true |
Other | spring-projects | spring-framework | 7de2650a7070af4db25ef9b5d87528a679302120.json | Drop @WebServlet annotation
Issue: SPR-16591 | spring-web/src/main/java/org/springframework/http/server/reactive/ServletHttpHandlerAdapter.java | @@ -29,7 +29,6 @@
import javax.servlet.ServletRegistration;
import javax.servlet.ServletRequest;
import javax.servlet.ServletResponse;
-import javax.servlet.annotation.WebServlet;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
@@... | true |
Other | spring-projects | spring-framework | 7de2650a7070af4db25ef9b5d87528a679302120.json | Drop @WebServlet annotation
Issue: SPR-16591 | spring-web/src/main/java/org/springframework/http/server/reactive/TomcatHttpHandlerAdapter.java | @@ -21,7 +21,6 @@
import javax.servlet.AsyncContext;
import javax.servlet.ServletRequest;
import javax.servlet.ServletResponse;
-import javax.servlet.annotation.WebServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
@@ -39,8 +38,8 @@
*
* @author Violeta Georg... | true |
Other | spring-projects | spring-framework | 7de2650a7070af4db25ef9b5d87528a679302120.json | Drop @WebServlet annotation
Issue: SPR-16591 | spring-web/src/test/java/org/springframework/http/server/reactive/bootstrap/JettyHttpServer.java | @@ -41,6 +41,7 @@ protected void initServer() throws Exception {
ServletHttpHandlerAdapter servlet = createServletAdapter();
ServletHolder servletHolder = new ServletHolder(servlet);
+ servletHolder.setAsyncSupported(true);
this.contextHandler = new ServletContextHandler(this.jettyServer, "", false, false... | true |
Other | spring-projects | spring-framework | 7de2650a7070af4db25ef9b5d87528a679302120.json | Drop @WebServlet annotation
Issue: SPR-16591 | spring-web/src/test/java/org/springframework/http/server/reactive/bootstrap/TomcatHttpServer.java | @@ -73,7 +73,7 @@ protected void initServer() throws Exception {
File base = new File(System.getProperty("java.io.tmpdir"));
Context rootContext = tomcatServer.addContext(this.contextPath, base.getAbsolutePath());
- Tomcat.addServlet(rootContext, "httpHandlerServlet", servlet);
+ Tomcat.addServlet(rootContext... | true |
Other | spring-projects | spring-framework | 541ee13934cf8c1dfcbcfadce2bb6299bd25900c.json | Add bufferContent option to MockRestServiceServer
Issue: SPR-14694 | spring-test/src/main/java/org/springframework/test/web/client/MockRestServiceServer.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -20,6 +20,7 @@
import java.net.URI;
impo... | true |
Other | spring-projects | spring-framework | 541ee13934cf8c1dfcbcfadce2bb6299bd25900c.json | Add bufferContent option to MockRestServiceServer
Issue: SPR-14694 | spring-test/src/test/java/org/springframework/test/web/client/samples/SampleTests.java | @@ -15,18 +15,26 @@
*/
package org.springframework.test.web.client.samples;
+import java.io.IOException;
+import java.util.Collections;
+
import org.junit.Before;
import org.junit.Test;
import org.springframework.core.io.ClassPathResource;
import org.springframework.core.io.Resource;
import org.springframew... | true |
Other | spring-projects | spring-framework | a712c1966133385de1c4a1208aa32c392ec21049.json | Add multipart support to WebFlux functional API
Issue: SPR-14546 | build.gradle | @@ -89,6 +89,7 @@ configure(allprojects) { project ->
ext.servletVersion = "3.1.0"
ext.slf4jVersion = "1.7.25"
ext.snakeyamlVersion = "1.18"
+ ext.nioMultipartVersion = "1.0.2"
ext.testngVersion = "6.11"
ext.tiles3Version = "3.0.7"
ext.tomcatVersion = "8... | true |
Other | spring-projects | spring-framework | a712c1966133385de1c4a1208aa32c392ec21049.json | Add multipart support to WebFlux functional API
Issue: SPR-14546 | spring-web/src/main/java/org/springframework/http/codec/DefaultClientCodecConfigurer.java | @@ -21,6 +21,7 @@
import org.springframework.core.codec.Decoder;
import org.springframework.core.codec.StringDecoder;
import org.springframework.http.codec.json.Jackson2JsonDecoder;
+import org.springframework.http.codec.multipart.MultipartHttpMessageWriter;
/**
* Default implementation of {@link ClientCodecCon... | true |
Other | spring-projects | spring-framework | a712c1966133385de1c4a1208aa32c392ec21049.json | Add multipart support to WebFlux functional API
Issue: SPR-14546 | spring-web/src/main/java/org/springframework/http/codec/DefaultServerCodecConfigurer.java | @@ -21,6 +21,8 @@
import org.springframework.core.codec.Encoder;
import org.springframework.core.codec.StringDecoder;
import org.springframework.http.codec.json.Jackson2JsonEncoder;
+import org.springframework.http.codec.multipart.SynchronossMultipartHttpMessageReader;
+import org.springframework.util.ClassUtils;
... | true |
Other | spring-projects | spring-framework | a712c1966133385de1c4a1208aa32c392ec21049.json | Add multipart support to WebFlux functional API
Issue: SPR-14546 | spring-web/src/test/java/org/springframework/http/codec/ClientCodecConfigurerTests.java | @@ -40,6 +40,7 @@
import org.springframework.http.MediaType;
import org.springframework.http.codec.json.Jackson2JsonDecoder;
import org.springframework.http.codec.json.Jackson2JsonEncoder;
+import org.springframework.http.codec.multipart.MultipartHttpMessageWriter;
import org.springframework.http.codec.xml.Jaxb2Xml... | true |
Other | spring-projects | spring-framework | a712c1966133385de1c4a1208aa32c392ec21049.json | Add multipart support to WebFlux functional API
Issue: SPR-14546 | spring-web/src/test/java/org/springframework/http/codec/ServerCodecConfigurerTests.java | @@ -41,6 +41,7 @@
import org.springframework.http.MediaType;
import org.springframework.http.codec.json.Jackson2JsonDecoder;
import org.springframework.http.codec.json.Jackson2JsonEncoder;
+import org.springframework.http.codec.multipart.SynchronossMultipartHttpMessageReader;
import org.springframework.http.codec.x... | true |
Other | spring-projects | spring-framework | a712c1966133385de1c4a1208aa32c392ec21049.json | Add multipart support to WebFlux functional API
Issue: SPR-14546 | spring-webflux/src/main/java/org/springframework/web/reactive/function/BodyExtractors.java | @@ -33,15 +33,19 @@
import org.springframework.http.MediaType;
import org.springframework.http.ReactiveHttpInputMessage;
import org.springframework.http.codec.HttpMessageReader;
+import org.springframework.http.codec.multipart.Part;
import org.springframework.http.server.reactive.ServerHttpRequest;
import org.spri... | true |
Other | spring-projects | spring-framework | a712c1966133385de1c4a1208aa32c392ec21049.json | Add multipart support to WebFlux functional API
Issue: SPR-14546 | spring-webflux/src/main/java/org/springframework/web/reactive/function/BodyInserters.java | @@ -33,11 +33,15 @@
import org.springframework.http.client.reactive.ClientHttpRequest;
import org.springframework.http.codec.HttpMessageWriter;
import org.springframework.http.codec.ServerSentEvent;
+import org.springframework.http.codec.multipart.MultipartHttpMessageReader;
+import org.springframework.http.codec.mu... | true |
Other | spring-projects | spring-framework | a712c1966133385de1c4a1208aa32c392ec21049.json | Add multipart support to WebFlux functional API
Issue: SPR-14546 | spring-webflux/src/test/java/org/springframework/web/reactive/config/DelegatingWebFluxConfigurationTests.java | @@ -103,7 +103,7 @@ public void requestMappingHandlerAdapter() throws Exception {
verify(webFluxConfigurer).configureArgumentResolvers(any());
assertSame(formatterRegistry.getValue(), initializerConversionService);
- assertEquals(9, codecsConfigurer.getValue().getReaders().size());
+ assertEquals(10, codecsCo... | true |
Other | spring-projects | spring-framework | a712c1966133385de1c4a1208aa32c392ec21049.json | Add multipart support to WebFlux functional API
Issue: SPR-14546 | spring-webflux/src/test/java/org/springframework/web/reactive/config/WebFluxConfigurationSupportTests.java | @@ -127,7 +127,7 @@ public void requestMappingHandlerAdapter() throws Exception {
assertNotNull(adapter);
List<HttpMessageReader<?>> readers = adapter.getMessageCodecConfigurer().getReaders();
- assertEquals(9, readers.size());
+ assertEquals(10, readers.size());
assertHasMessageReader(readers, forClass(... | true |
Other | spring-projects | spring-framework | a712c1966133385de1c4a1208aa32c392ec21049.json | Add multipart support to WebFlux functional API
Issue: SPR-14546 | spring-webflux/src/test/java/org/springframework/web/reactive/function/MultipartIntegrationTests.java | @@ -0,0 +1,104 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 2579dab209f955a6190104ba0e963b1da6734721.json | Get XNIO as an undertow transitive dependency | build.gradle | @@ -97,7 +97,6 @@ configure(allprojects) { project ->
ext.websocketVersion = "1.1"
ext.woodstoxVersion = "5.0.3"
ext.xmlunitVersion = "2.3.0"
- ext.xnioVersion = "3.4.5.Final"
ext.xstreamVersion = "1.4.9"
ext.gradleScriptDir = "${rootProject.projectDir}/gradle"
@@ -71... | false |
Other | spring-projects | spring-framework | 6e71828a351ae31dec6bb0621266e4cef6e4a42f.json | Add space before cookie attributes
According to RFC-6265 that there should be a space between the ; and
the attribute name, i.e. the header should be something like
name=value; Domain=localhost; HttpOnly rather than
name=value;Domain=localhost;HttpOnly
Issue: SPR-15225 | spring-test/src/main/java/org/springframework/mock/web/MockHttpServletResponse.java | @@ -328,25 +328,25 @@ private String getCookieHeader(Cookie cookie) {
StringBuilder buf = new StringBuilder();
buf.append(cookie.getName()).append('=').append(cookie.getValue() == null ? "" : cookie.getValue());
if (StringUtils.hasText(cookie.getPath())) {
- buf.append(";Path=").append(cookie.getPath());
+ ... | true |
Other | spring-projects | spring-framework | 6e71828a351ae31dec6bb0621266e4cef6e4a42f.json | Add space before cookie attributes
According to RFC-6265 that there should be a space between the ; and
the attribute name, i.e. the header should be something like
name=value; Domain=localhost; HttpOnly rather than
name=value;Domain=localhost;HttpOnly
Issue: SPR-15225 | spring-test/src/test/java/org/springframework/mock/web/MockHttpServletResponseTests.java | @@ -168,9 +168,9 @@ public void cookies() {
response.addCookie(cookie);
- assertEquals("foo=bar;Path=/path;Domain=example.com;" +
- "Max-Age=0;Expires=Thu, 01 Jan 1970 00:00:00 GMT;" +
- "Secure;HttpOnly", response.getHeader(HttpHeaders.SET_COOKIE));
+ assertEquals("foo=bar; Path=/path; Domain=example.co... | true |
Other | spring-projects | spring-framework | 6e71828a351ae31dec6bb0621266e4cef6e4a42f.json | Add space before cookie attributes
According to RFC-6265 that there should be a space between the ; and
the attribute name, i.e. the header should be something like
name=value; Domain=localhost; HttpOnly rather than
name=value;Domain=localhost;HttpOnly
Issue: SPR-15225 | spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/MockWebResponseBuilderTests.java | @@ -116,8 +116,8 @@ public void buildResponseHeaders() throws Exception {
assertThat(header.getValue(), equalTo("value"));
header = responseHeaders.get(2);
assertThat(header.getName(), equalTo("Set-Cookie"));
- assertThat(header.getValue(), startsWith("cookieA=valueA;Path=/path;Domain=domain;Max-Age=1800;Expi... | true |
Other | spring-projects | spring-framework | 6e71828a351ae31dec6bb0621266e4cef6e4a42f.json | Add space before cookie attributes
According to RFC-6265 that there should be a space between the ; and
the attribute name, i.e. the header should be something like
name=value; Domain=localhost; HttpOnly rather than
name=value;Domain=localhost;HttpOnly
Issue: SPR-15225 | spring-test/src/test/java/org/springframework/test/web/servlet/result/PrintingResultHandlerTests.java | @@ -120,7 +120,7 @@ public void printResponse() throws Exception {
assertEquals(2, cookieValues.size());
assertEquals("cookie=cookieValue", cookieValues.get(0));
assertTrue("Actual: " + cookieValues.get(1), cookieValues.get(1).startsWith(
- "enigma=42;Path=/crumbs;Domain=.example.com;Max-Age=1234;Expires=")... | true |
Other | spring-projects | spring-framework | 6e71828a351ae31dec6bb0621266e4cef6e4a42f.json | Add space before cookie attributes
According to RFC-6265 that there should be a space between the ; and
the attribute name, i.e. the header should be something like
name=value; Domain=localhost; HttpOnly rather than
name=value;Domain=localhost;HttpOnly
Issue: SPR-15225 | spring-web/src/test/java/org/springframework/mock/web/test/MockHttpServletResponse.java | @@ -328,25 +328,25 @@ private String getCookieHeader(Cookie cookie) {
StringBuilder buf = new StringBuilder();
buf.append(cookie.getName()).append('=').append(cookie.getValue() == null ? "" : cookie.getValue());
if (StringUtils.hasText(cookie.getPath())) {
- buf.append(";Path=").append(cookie.getPath());
+ ... | true |
Other | spring-projects | spring-framework | 6a1ce13ae2bc3946ffcf43c6bc6905ed137d8073.json | Upgrade Kotlin to 1.1.2-eap-77 | build.gradle | @@ -1,5 +1,5 @@
buildscript {
- ext.kotlinVersion = '1.1.2-eap-73'
+ ext.kotlinVersion = '1.1.2-eap-77'
repositories {
maven { url "https://repo.spring.io/plugins-release" }
maven { url "https://dl.bintray.com/kotlin/kotlin-eap-1.1" } | false |
Other | spring-projects | spring-framework | 55833dc3d1f7bd05881484e488066d07390b2df8.json | Discontinue use of Rouge in the Reference Manual
Due to a bug in Rouge thats prevents it from working on MS Windows, we
are currently reverting back to CodeRay for source code highlighting
within the Reference Manual.
Issues: SPR-15471 | src/docs/asciidoc/appendix.adoc | @@ -5,7 +5,6 @@
:wiki-spring-framework: https://github.com/spring-projects/spring-framework/wiki
:toc: left
:toclevels: 2
-ifdef::backend-pdf[:source-highlighter: rouge]
[[spring-whats-new]]
== What's New in the Spring Framework | true |
Other | spring-projects | spring-framework | 55833dc3d1f7bd05881484e488066d07390b2df8.json | Discontinue use of Rouge in the Reference Manual
Due to a bug in Rouge thats prevents it from working on MS Windows, we
are currently reverting back to CodeRay for source code highlighting
within the Reference Manual.
Issues: SPR-15471 | src/docs/asciidoc/core.adoc | @@ -4,7 +4,6 @@
:api-spring-framework: {doc-root}/spring-framework/docs/{spring-version}/javadoc-api/org/springframework
:toc: left
:toclevels: 2
-ifdef::backend-pdf[:source-highlighter: rouge]
This part of the reference documentation covers all of those technologies that are
absolutely integral to the Spring Fr... | true |
Other | spring-projects | spring-framework | 55833dc3d1f7bd05881484e488066d07390b2df8.json | Discontinue use of Rouge in the Reference Manual
Due to a bug in Rouge thats prevents it from working on MS Windows, we
are currently reverting back to CodeRay for source code highlighting
within the Reference Manual.
Issues: SPR-15471 | src/docs/asciidoc/data-access.adoc | @@ -4,7 +4,6 @@
:api-spring-framework: {doc-root}/spring-framework/docs/{spring-version}/javadoc-api/org/springframework
:toc: left
:toclevels: 2
-ifdef::backend-pdf[:source-highlighter: rouge]
This part of the reference documentation is concerned with data access and the
interaction between the data access laye... | true |
Other | spring-projects | spring-framework | 55833dc3d1f7bd05881484e488066d07390b2df8.json | Discontinue use of Rouge in the Reference Manual
Due to a bug in Rouge thats prevents it from working on MS Windows, we
are currently reverting back to CodeRay for source code highlighting
within the Reference Manual.
Issues: SPR-15471 | src/docs/asciidoc/integration.adoc | @@ -6,7 +6,6 @@
:doc-spring-gemfire: {doc-root}/spring-gemfire/docs/current/reference
:toc: left
:toclevels: 2
-ifdef::backend-pdf[:source-highlighter: rouge]
This part of the reference documentation covers the Spring Framework's integration with
a number of Java EE (and related) technologies. | true |
Other | spring-projects | spring-framework | 55833dc3d1f7bd05881484e488066d07390b2df8.json | Discontinue use of Rouge in the Reference Manual
Due to a bug in Rouge thats prevents it from working on MS Windows, we
are currently reverting back to CodeRay for source code highlighting
within the Reference Manual.
Issues: SPR-15471 | src/docs/asciidoc/overview.adoc | @@ -4,7 +4,6 @@
:api-spring-framework: {doc-root}/spring-framework/docs/{spring-version}/javadoc-api/org/springframework
:toc: left
:toclevels: 2
-ifdef::backend-pdf[:source-highlighter: rouge]
| true |
Other | spring-projects | spring-framework | 55833dc3d1f7bd05881484e488066d07390b2df8.json | Discontinue use of Rouge in the Reference Manual
Due to a bug in Rouge thats prevents it from working on MS Windows, we
are currently reverting back to CodeRay for source code highlighting
within the Reference Manual.
Issues: SPR-15471 | src/docs/asciidoc/testing.adoc | @@ -5,7 +5,6 @@
:doc-spring-boot: {doc-root}/spring-boot/docs/current/reference
:toc: left
:toclevels: 2
-ifdef::backend-pdf[:source-highlighter: rouge]
The adoption of the test-driven-development (TDD) approach to software
development is certainly advocated by the Spring team, and so coverage of Spring's | true |
Other | spring-projects | spring-framework | 55833dc3d1f7bd05881484e488066d07390b2df8.json | Discontinue use of Rouge in the Reference Manual
Due to a bug in Rouge thats prevents it from working on MS Windows, we
are currently reverting back to CodeRay for source code highlighting
within the Reference Manual.
Issues: SPR-15471 | src/docs/asciidoc/web.adoc | @@ -4,7 +4,6 @@
:api-spring-framework: {doc-root}/spring-framework/docs/{spring-version}/javadoc-api/org/springframework
:toc: left
:toclevels: 2
-ifdef::backend-pdf[:source-highlighter: rouge]
This part of the reference documentation covers Spring Framework's support for the
presentation tier (and specifically ... | true |
Other | spring-projects | spring-framework | 33d7816de38aa7b3040667b1717722206609fd1f.json | Remove extraneous asterisk
Closes gh-1397 | spring-aop/src/main/java/org/springframework/aop/support/NameMatchMethodPointcut.java | @@ -27,7 +27,7 @@
/**
* Pointcut bean for simple method name matches, as alternative to regexp patterns.
- * Does not handle overloaded methods: all methods *with a given name will be eligible.
+ * Does not handle overloaded methods: all methods with a given name will be eligible.
*
* @author Juergen Hoeller
... | false |
Other | spring-projects | spring-framework | e677342628847104265420a2cb5d3e35b7891caa.json | Add originalMessage to ErrorMessage
Issue: SPR-15459 | spring-messaging/src/main/java/org/springframework/messaging/support/ErrorMessage.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -18,27 +18,39 @@
import java.util.Map;
... | true |
Other | spring-projects | spring-framework | e677342628847104265420a2cb5d3e35b7891caa.json | Add originalMessage to ErrorMessage
Issue: SPR-15459 | spring-messaging/src/test/java/org/springframework/messaging/support/ErrorMessageTests.java | @@ -0,0 +1,41 @@
+/*
+ * Copyright 2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *... | true |
Other | spring-projects | spring-framework | b897f96e0ff61ec8965ebd51bbad0d5b798e5e7f.json | Use PathRemainingMatchInfo in RequestPredicates
This commit uses the newly introduced PathRemainingMatchInfo
(316a680577a392464c6da60d989b00acd2a5e472) in path-based
RequestPredicates.
Issue: SPR-15419 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/RequestPredicates.java | @@ -42,7 +42,6 @@
import org.springframework.web.util.UriUtils;
import org.springframework.web.util.patterns.PathPattern;
import org.springframework.web.util.patterns.PathPatternParser;
-import org.springframework.web.util.patterns.PathRemainingMatchInfo;
/**
* Implementations of {@link RequestPredicate} that i... | true |
Other | spring-projects | spring-framework | b897f96e0ff61ec8965ebd51bbad0d5b798e5e7f.json | Use PathRemainingMatchInfo in RequestPredicates
This commit uses the newly introduced PathRemainingMatchInfo
(316a680577a392464c6da60d989b00acd2a5e472) in path-based
RequestPredicates.
Issue: SPR-15419 | spring-webflux/src/test/java/org/springframework/web/reactive/function/server/NestedRouteIntegrationTests.java | @@ -16,7 +16,6 @@
package org.springframework.web.reactive.function.server;
-import org.junit.Ignore;
import org.junit.Test;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
@@ -71,7 +70,6 @@ public void baz() throws Exception {
}
@Test
- @Ignore("SPR-15419")
public void variables... | true |
Other | spring-projects | spring-framework | cf50a9a1edd24af61abadaab9b04b6cde0f42e91.json | Fix Selenium links in testing.adoc
Selenium wiki & javadoc moved from google code to github.
Also a fix to a link for Geb.
Closes gh-1392 | src/docs/asciidoc/testing.adoc | @@ -4656,7 +4656,7 @@ public class CreateMessagePage {
----
Formerly, this pattern is known as the
-https://code.google.com/p/selenium/wiki/PageObjects[Page Object Pattern]. While we can
+https://github.com/SeleniumHQ/selenium/wiki/PageObjects[Page Object Pattern]. While we can
certainly do this with HtmlUnit, Web... | false |
Other | spring-projects | spring-framework | d78d82c516e08c9c74f9ad6260e7a54c8798a342.json | Use Conventions for reactive model attribute names
Issue: SPR-14915 | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/ErrorsMethodArgumentResolver.java | @@ -18,18 +18,17 @@
import reactor.core.publisher.Mono;
+import org.springframework.core.Conventions;
import org.springframework.core.MethodParameter;
import org.springframework.core.ReactiveAdapter;
import org.springframework.core.ReactiveAdapterRegistry;
import org.springframework.core.ResolvableType;
impor... | true |
Other | spring-projects | spring-framework | d78d82c516e08c9c74f9ad6260e7a54c8798a342.json | Use Conventions for reactive model attribute names
Issue: SPR-14915 | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/ModelAttributeMethodArgumentResolver.java | @@ -26,13 +26,15 @@
import reactor.core.publisher.MonoProcessor;
import org.springframework.beans.BeanUtils;
+import org.springframework.core.Conventions;
import org.springframework.core.DefaultParameterNameDiscoverer;
import org.springframework.core.MethodParameter;
import org.springframework.core.ParameterName... | true |
Other | spring-projects | spring-framework | d78d82c516e08c9c74f9ad6260e7a54c8798a342.json | Use Conventions for reactive model attribute names
Issue: SPR-14915 | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/ModelInitializer.java | @@ -23,12 +23,12 @@
import reactor.core.publisher.Mono;
+import org.springframework.core.Conventions;
import org.springframework.core.MethodParameter;
import org.springframework.core.ReactiveAdapter;
import org.springframework.core.ReactiveAdapterRegistry;
import org.springframework.core.ResolvableType;
impor... | true |
Other | spring-projects | spring-framework | d78d82c516e08c9c74f9ad6260e7a54c8798a342.json | Use Conventions for reactive model attribute names
Issue: SPR-14915 | spring-webflux/src/main/java/org/springframework/web/reactive/result/view/ViewResolutionResultHandler.java | @@ -28,6 +28,7 @@
import reactor.core.publisher.Mono;
import org.springframework.beans.BeanUtils;
+import org.springframework.core.Conventions;
import org.springframework.core.MethodParameter;
import org.springframework.core.Ordered;
import org.springframework.core.ReactiveAdapter;
@@ -37,7 +38,6 @@
import org.... | true |
Other | spring-projects | spring-framework | d78d82c516e08c9c74f9ad6260e7a54c8798a342.json | Use Conventions for reactive model attribute names
Issue: SPR-14915 | spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/ModelAttributeMethodArgumentResolverTests.java | @@ -42,7 +42,11 @@
import org.springframework.web.reactive.BindingContext;
import org.springframework.web.server.ServerWebExchange;
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotNull;
+import sta... | true |
Other | spring-projects | spring-framework | acd6b9df06ac24045576cb9ae5736f5fe24a29d2.json | Fix failing test
Explicitly pass the client-side JSR-356 WebSocketContainer to the
TomcatWebSocketClient to prevent the ContainerProvider from finding
the one from undertow-websockets-jsr through the ServiceLoader API. | spring-webflux/src/main/java/org/springframework/web/reactive/socket/client/TomcatWebSocketClient.java | @@ -17,6 +17,7 @@
package org.springframework.web.reactive.socket.client;
import javax.websocket.Session;
+import javax.websocket.WebSocketContainer;
import org.springframework.web.reactive.socket.HandshakeInfo;
import org.springframework.web.reactive.socket.adapter.StandardWebSocketSession;
@@ -33,6 +34,14 @@
... | true |
Other | spring-projects | spring-framework | acd6b9df06ac24045576cb9ae5736f5fe24a29d2.json | Fix failing test
Explicitly pass the client-side JSR-356 WebSocketContainer to the
TomcatWebSocketClient to prevent the ContainerProvider from finding
the one from undertow-websockets-jsr through the ServiceLoader API. | spring-webflux/src/test/java/org/springframework/web/reactive/socket/AbstractWebSocketIntegrationTests.java | @@ -21,6 +21,8 @@
import java.net.URI;
import java.net.URISyntaxException;
+import org.apache.tomcat.websocket.WsContainerProvider;
+import org.apache.tomcat.websocket.WsWebSocketContainer;
import org.apache.tomcat.websocket.server.WsContextListener;
import org.junit.After;
import org.junit.Before;
@@ -93,7 +95,... | true |
Other | spring-projects | spring-framework | 74b4c028819c67b90d4d06d352d3083d91d8a3f8.json | Add ClientRequest attributes
This commit introduces client-side request attributes, similar to those
found on the server-side. The attributes can be used, for instance, for
passing on request-specific information to a globally registered
ExchangeFilterFunction.
The client request builder, as well as WebClient.Request... | spring-test/src/main/java/org/springframework/test/web/reactive/server/DefaultWebTestClient.java | @@ -51,9 +51,11 @@
import org.springframework.web.reactive.function.client.WebClient;
import org.springframework.web.util.UriBuilder;
-import static java.nio.charset.StandardCharsets.*;
-import static org.springframework.test.util.AssertionErrors.*;
-import static org.springframework.web.reactive.function.BodyExtra... | true |
Other | spring-projects | spring-framework | 74b4c028819c67b90d4d06d352d3083d91d8a3f8.json | Add ClientRequest attributes
This commit introduces client-side request attributes, similar to those
found on the server-side. The attributes can be used, for instance, for
passing on request-specific information to a globally registered
ExchangeFilterFunction.
The client request builder, as well as WebClient.Request... | spring-test/src/main/java/org/springframework/test/web/reactive/server/WebTestClient.java | @@ -508,6 +508,23 @@ interface Builder {
*/
S headers(Consumer<HttpHeaders> headersConsumer);
+ /**
+ * Set the attribute with the given name to the given value.
+ * @param name the name of the attribute to add
+ * @param value the value of the attribute to add
+ * @return this builder
+ */
+ S att... | true |
Other | spring-projects | spring-framework | 74b4c028819c67b90d4d06d352d3083d91d8a3f8.json | Add ClientRequest attributes
This commit introduces client-side request attributes, similar to those
found on the server-side. The attributes can be used, for instance, for
passing on request-specific information to a globally registered
ExchangeFilterFunction.
The client request builder, as well as WebClient.Request... | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/ClientRequest.java | @@ -17,6 +17,7 @@
package org.springframework.web.reactive.function.client;
import java.net.URI;
+import java.util.Map;
import java.util.function.Consumer;
import org.reactivestreams.Publisher;
@@ -68,6 +69,11 @@ public interface ClientRequest {
*/
BodyInserter<?, ? super ClientHttpRequest> body();
+ /**... | true |
Other | spring-projects | spring-framework | 74b4c028819c67b90d4d06d352d3083d91d8a3f8.json | Add ClientRequest attributes
This commit introduces client-side request attributes, similar to those
found on the server-side. The attributes can be used, for instance, for
passing on request-specific information to a globally registered
ExchangeFilterFunction.
The client request builder, as well as WebClient.Request... | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultClientRequestBuilder.java | @@ -18,6 +18,7 @@
import java.net.URI;
import java.util.Collections;
+import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.Optional;
@@ -55,6 +56,8 @@ class DefaultClientRequestBuilder implements ClientRequest.Builder {
private final MultiValueMap<String, String> cook... | true |
Other | spring-projects | spring-framework | 74b4c028819c67b90d4d06d352d3083d91d8a3f8.json | Add ClientRequest attributes
This commit introduces client-side request attributes, similar to those
found on the server-side. The attributes can be used, for instance, for
passing on request-specific information to a globally registered
ExchangeFilterFunction.
The client request builder, as well as WebClient.Request... | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultWebClient.java | @@ -22,6 +22,7 @@
import java.time.ZonedDateTime;
import java.time.format.DateTimeFormatter;
import java.util.Arrays;
+import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.function.Consumer;
@@ -181,6 +182,9 @@ private class DefaultRequestBodySpec implements RequestBodySpe... | true |
Other | spring-projects | spring-framework | 74b4c028819c67b90d4d06d352d3083d91d8a3f8.json | Add ClientRequest attributes
This commit introduces client-side request attributes, similar to those
found on the server-side. The attributes can be used, for instance, for
passing on request-specific information to a globally registered
ExchangeFilterFunction.
The client request builder, as well as WebClient.Request... | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/ExchangeFilterFunctions.java | @@ -18,6 +18,8 @@
import java.nio.charset.StandardCharsets;
import java.util.Base64;
+import java.util.Map;
+import java.util.function.Function;
import reactor.core.publisher.Mono;
@@ -35,7 +37,21 @@
public abstract class ExchangeFilterFunctions {
/**
- * Return a filter that adds an Authorization header... | true |
Other | spring-projects | spring-framework | 74b4c028819c67b90d4d06d352d3083d91d8a3f8.json | Add ClientRequest attributes
This commit introduces client-side request attributes, similar to those
found on the server-side. The attributes can be used, for instance, for
passing on request-specific information to a globally registered
ExchangeFilterFunction.
The client request builder, as well as WebClient.Request... | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/WebClient.java | @@ -420,6 +420,23 @@ interface Builder {
*/
S headers(Consumer<HttpHeaders> headersConsumer);
+ /**
+ * Set the attribute with the given name to the given value.
+ * @param name the name of the attribute to add
+ * @param value the value of the attribute to add
+ * @return this builder
+ */
+ S att... | true |
Other | spring-projects | spring-framework | 74b4c028819c67b90d4d06d352d3083d91d8a3f8.json | Add ClientRequest attributes
This commit introduces client-side request attributes, similar to those
found on the server-side. The attributes can be used, for instance, for
passing on request-specific information to a globally registered
ExchangeFilterFunction.
The client request builder, as well as WebClient.Request... | spring-webflux/src/test/java/org/springframework/web/reactive/function/client/DefaultWebClientTests.java | @@ -145,6 +145,18 @@ public void mutateDoesCopy() throws Exception {
client2.mutate().defaultCookies(cookies -> assertEquals(2, cookies.size()));
}
+ @Test
+ public void attributes() {
+ ExchangeFilterFunction filter = (request, next) -> {
+ assertEquals("bar", request.attributes().get("foo"));
+ return nex... | true |
Other | spring-projects | spring-framework | 74b4c028819c67b90d4d06d352d3083d91d8a3f8.json | Add ClientRequest attributes
This commit introduces client-side request attributes, similar to those
found on the server-side. The attributes can be used, for instance, for
passing on request-specific information to a globally registered
ExchangeFilterFunction.
The client request builder, as well as WebClient.Request... | spring-webflux/src/test/java/org/springframework/web/reactive/function/client/ExchangeFilterFunctionsTests.java | @@ -25,7 +25,7 @@
import static org.junit.Assert.*;
import static org.mockito.Mockito.*;
-import static org.springframework.http.HttpMethod.*;
+import static org.springframework.http.HttpMethod.GET;
/**
* @author Arjen Poutsma
@@ -98,4 +98,23 @@ public void basicAuthentication() throws Exception {
assertEqu... | true |
Other | spring-projects | spring-framework | 2ccbc55ffdffc08d8f64f0b195b38e602cca7ce1.json | Use PathContainer in web.reactive.function.server
This commit uses the newly introduced `PathContainer` and `RequestPath`
support in the functional web framework. It exposes the path container
as property in `ServerRequest`, and uses that in the path-based
`RequestPredicates`. | spring-test/src/main/java/org/springframework/mock/web/reactive/function/server/MockServerRequest.java | @@ -19,6 +19,7 @@
import java.net.InetSocketAddress;
import java.net.URI;
import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
import java.security.Principal;
import java.util.Arrays;
import java.util.Collections;
@@ -38,6 +39,8 @@
import org.springframework.http.HttpMethod;
import org.sp... | true |
Other | spring-projects | spring-framework | 2ccbc55ffdffc08d8f64f0b195b38e602cca7ce1.json | Use PathContainer in web.reactive.function.server
This commit uses the newly introduced `PathContainer` and `RequestPath`
support in the functional web framework. It exposes the path container
as property in `ServerRequest`, and uses that in the path-based
`RequestPredicates`. | spring-web/src/main/java/org/springframework/http/server/reactive/RequestPath.java | @@ -15,6 +15,9 @@
*/
package org.springframework.http.server.reactive;
+import java.net.URI;
+import java.nio.charset.Charset;
+
/**
* Represents the complete path for a request.
*
@@ -38,4 +41,11 @@ public interface RequestPath extends PathContainer {
*/
PathContainer pathWithinApplication();
+ /**
+ ... | true |
Other | spring-projects | spring-framework | 2ccbc55ffdffc08d8f64f0b195b38e602cca7ce1.json | Use PathContainer in web.reactive.function.server
This commit uses the newly introduced `PathContainer` and `RequestPath`
support in the functional web framework. It exposes the path container
as property in `ServerRequest`, and uses that in the path-based
`RequestPredicates`. | spring-web/src/main/java/org/springframework/web/util/pattern/PathPattern.java | @@ -539,8 +539,8 @@ public static class PathRemainingMatchInfo {
/**
* Return the part of a path that was not matched by a pattern.
*/
- public String getPathRemaining() {
- return this.pathRemaining.value();
+ public PathContainer getPathRemaining() {
+ return this.pathRemaining;
}
/** | true |
Other | spring-projects | spring-framework | 2ccbc55ffdffc08d8f64f0b195b38e602cca7ce1.json | Use PathContainer in web.reactive.function.server
This commit uses the newly introduced `PathContainer` and `RequestPath`
support in the functional web framework. It exposes the path container
as property in `ServerRequest`, and uses that in the path-based
`RequestPredicates`. | spring-web/src/test/java/org/springframework/web/util/pattern/PathPatternMatcherTests.java | @@ -37,13 +37,7 @@
import org.springframework.web.util.pattern.PathPattern.PathRemainingMatchInfo;
import static org.hamcrest.CoreMatchers.containsString;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertNotNull;
-import static org.juni... | true |
Other | spring-projects | spring-framework | 2ccbc55ffdffc08d8f64f0b195b38e602cca7ce1.json | Use PathContainer in web.reactive.function.server
This commit uses the newly introduced `PathContainer` and `RequestPath`
support in the functional web framework. It exposes the path container
as property in `ServerRequest`, and uses that in the path-based
`RequestPredicates`. | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultServerRequest.java | @@ -38,6 +38,7 @@
import org.springframework.http.HttpRange;
import org.springframework.http.MediaType;
import org.springframework.http.codec.HttpMessageReader;
+import org.springframework.http.server.reactive.PathContainer;
import org.springframework.http.server.reactive.ServerHttpRequest;
import org.springframew... | true |
Other | spring-projects | spring-framework | 2ccbc55ffdffc08d8f64f0b195b38e602cca7ce1.json | Use PathContainer in web.reactive.function.server
This commit uses the newly introduced `PathContainer` and `RequestPath`
support in the functional web framework. It exposes the path container
as property in `ServerRequest`, and uses that in the path-based
`RequestPredicates`. | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/RequestPredicates.java | @@ -18,6 +18,7 @@
import java.net.URI;
import java.security.Principal;
+import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.HashSet;
@@ -37,6 +38,7 @@
import org.springframework.http.HttpCookie;
import org.springframework.http.HttpMethod;
import org.springframew... | true |
Other | spring-projects | spring-framework | 2ccbc55ffdffc08d8f64f0b195b38e602cca7ce1.json | Use PathContainer in web.reactive.function.server
This commit uses the newly introduced `PathContainer` and `RequestPath`
support in the functional web framework. It exposes the path container
as property in `ServerRequest`, and uses that in the path-based
`RequestPredicates`. | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/ServerRequest.java | @@ -19,6 +19,7 @@
import java.net.InetSocketAddress;
import java.net.URI;
import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
import java.security.Principal;
import java.util.List;
import java.util.Locale;
@@ -36,6 +37,7 @@
import org.springframework.http.MediaType;
import org.springfram... | true |
Other | spring-projects | spring-framework | 2ccbc55ffdffc08d8f64f0b195b38e602cca7ce1.json | Use PathContainer in web.reactive.function.server
This commit uses the newly introduced `PathContainer` and `RequestPath`
support in the functional web framework. It exposes the path container
as property in `ServerRequest`, and uses that in the path-based
`RequestPredicates`. | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/support/ServerRequestWrapper.java | @@ -34,6 +34,7 @@
import org.springframework.http.HttpMethod;
import org.springframework.http.HttpRange;
import org.springframework.http.MediaType;
+import org.springframework.http.server.reactive.PathContainer;
import org.springframework.http.server.reactive.ServerHttpRequest;
import org.springframework.util.Asse... | true |
Other | spring-projects | spring-framework | 2ccbc55ffdffc08d8f64f0b195b38e602cca7ce1.json | Use PathContainer in web.reactive.function.server
This commit uses the newly introduced `PathContainer` and `RequestPath`
support in the functional web framework. It exposes the path container
as property in `ServerRequest`, and uses that in the path-based
`RequestPredicates`. | spring-webflux/src/test/java/org/springframework/web/reactive/function/server/MockServerRequest.java | @@ -19,6 +19,7 @@
import java.net.InetSocketAddress;
import java.net.URI;
import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
import java.security.Principal;
import java.util.Arrays;
import java.util.Collections;
@@ -38,6 +39,8 @@
import org.springframework.http.HttpMethod;
import org.sp... | true |
Other | spring-projects | spring-framework | 727ca4514a1886c0e8739417536382d534844f59.json | Stream custom types in Jackson2JsonEncoder
Issue: SPR-15727 | spring-web/src/main/java/org/springframework/http/codec/json/Jackson2JsonEncoder.java | @@ -124,7 +124,7 @@ public Flux<DataBuffer> encode(Publisher<?> inputStream, DataBufferFactory buffe
return Flux.from(inputStream).map(value ->
encodeValue(value, mimeType, bufferFactory, elementType, hints));
}
- else if (MediaType.APPLICATION_STREAM_JSON.isCompatibleWith(mimeType)) {
+ else if (this.st... | true |
Other | spring-projects | spring-framework | 727ca4514a1886c0e8739417536382d534844f59.json | Stream custom types in Jackson2JsonEncoder
Issue: SPR-15727 | spring-web/src/test/java/org/springframework/http/codec/json/Jackson2JsonEncoderTests.java | @@ -16,6 +16,7 @@
package org.springframework.http.codec.json;
+import java.util.Arrays;
import java.util.Map;
import com.fasterxml.jackson.annotation.JsonTypeInfo;
@@ -32,6 +33,7 @@
import org.springframework.core.ResolvableType;
import org.springframework.core.io.buffer.AbstractDataBufferAllocatingTestCase... | true |
Other | spring-projects | spring-framework | 67330dfc23564ac830e6b33143cf48bd824dfa67.json | Expose mapped handler as an exchange attribute
Issue: SPR-15564 | spring-webflux/src/main/java/org/springframework/web/reactive/HandlerMapping.java | @@ -31,29 +31,31 @@
public interface HandlerMapping {
/**
- * Name of the {@link ServerWebExchange} attribute that contains the
- * best matching pattern within the handler mapping.
- * <p>Note: This attribute is not required to be supported by all
- * HandlerMapping implementations. URL-based HandlerMappings ... | true |
Other | spring-projects | spring-framework | 67330dfc23564ac830e6b33143cf48bd824dfa67.json | Expose mapped handler as an exchange attribute
Issue: SPR-15564 | spring-webflux/src/main/java/org/springframework/web/reactive/handler/AbstractUrlHandlerMapping.java | @@ -145,8 +145,9 @@ private Object handleMatch(Object handler, PathPattern bestMatch, String pathWit
validateHandler(handler, exchange);
- exchange.getAttributes().put(PATH_WITHIN_HANDLER_MAPPING_ATTRIBUTE, pathWithinMapping);
+ exchange.getAttributes().put(BEST_MATCHING_HANDLER_ATTRIBUTE, handler);
exchang... | true |
Other | spring-projects | spring-framework | 67330dfc23564ac830e6b33143cf48bd824dfa67.json | Expose mapped handler as an exchange attribute
Issue: SPR-15564 | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/AbstractHandlerMethodMapping.java | @@ -322,7 +322,7 @@ protected HandlerMethod lookupHandlerMethod(String lookupPath, ServerWebExchange
lookupPath + "': {" + m1 + ", " + m2 + "}");
}
}
- handleMatch(bestMatch.mapping, lookupPath, exchange);
+ handleMatch(bestMatch.mapping, bestMatch.handlerMethod, lookupPath, exchange);
return b... | true |
Other | spring-projects | spring-framework | 67330dfc23564ac830e6b33143cf48bd824dfa67.json | Expose mapped handler as an exchange attribute
Issue: SPR-15564 | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/RequestMappingInfoHandlerMapping.java | @@ -106,8 +106,10 @@ protected Comparator<RequestMappingInfo> getMappingComparator(final ServerWebExc
* @see HandlerMapping#PRODUCIBLE_MEDIA_TYPES_ATTRIBUTE
*/
@Override
- protected void handleMatch(RequestMappingInfo info, String lookupPath, ServerWebExchange exchange) {
- super.handleMatch(info, lookupPath, ... | true |
Other | spring-projects | spring-framework | 67330dfc23564ac830e6b33143cf48bd824dfa67.json | Expose mapped handler as an exchange attribute
Issue: SPR-15564 | spring-webflux/src/test/java/org/springframework/web/reactive/result/method/RequestMappingInfoHandlerMappingTests.java | @@ -39,6 +39,7 @@
import org.springframework.http.MediaType;
import org.springframework.mock.http.server.reactive.test.MockServerHttpRequest;
import org.springframework.stereotype.Controller;
+import org.springframework.util.ClassUtils;
import org.springframework.util.MultiValueMap;
import org.springframework.web.... | true |
Other | spring-projects | spring-framework | 67330dfc23564ac830e6b33143cf48bd824dfa67.json | Expose mapped handler as an exchange attribute
Issue: SPR-15564 | spring-webmvc/src/main/java/org/springframework/web/servlet/HandlerMapping.java | @@ -96,11 +96,11 @@ public interface HandlerMapping {
/**
* Name of the {@link HttpServletRequest} attribute that contains a map with
- * URI matrix variables.
+ * URI variable names and a corresponding MultiValueMap of URI matrix
+ * variables for each.
* <p>Note: This attribute is not required to be supp... | true |
Other | spring-projects | spring-framework | 9d7b8503d0ee420cfa1ba1a2ffda0500b61042bb.json | Delay DataBuffer release until stream is closed
This commit changes the release of data buffers from a finally block
into a `doFinally()` lambda on the returned `Flux<XMLEvent>` stream.
Issue: SPR-15707 | spring-web/src/main/java/org/springframework/http/codec/xml/XmlEventDecoder.java | @@ -106,14 +106,14 @@ public Flux<XMLEvent> decode(Publisher<DataBuffer> inputStream, ResolvableType e
try {
InputStream is = dataBuffer.asInputStream();
Iterator eventReader = inputFactory.createXMLEventReader(is);
- return Flux.fromIterable((Iterable<XMLEvent>) () -> eventReader);
+ ... | false |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-beans/src/main/kotlin/org/springframework/beans/factory/BeanFactoryExtensions.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-beans/src/main/kotlin/org/springframework/beans/factory/ListableBeanFactoryExtensions.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-beans/src/test/kotlin/org/springframework/beans/factory/BeanFactoryExtensionsTests.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-beans/src/test/kotlin/org/springframework/beans/factory/ListableBeanFactoryExtensionsTests.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-context/src/main/kotlin/org/springframework/context/annotation/AnnotationConfigApplicationContextExtensions.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-context/src/main/kotlin/org/springframework/context/support/GenericApplicationContextExtensions.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-context/src/test/kotlin/org/springframework/context/annotation/AnnotationConfigApplicationContextExtensionsTests.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-context/src/test/kotlin/org/springframework/context/support/GenericApplicationContextExtensionsTests.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-test/src/test/kotlin/org/springframework/test/web/reactive/server/WebTestClientExtensionsTests.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-web/src/main/kotlin/org/springframework/web/client/RestOperationsExtensions.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-web/src/test/kotlin/org/springframework/web/client/RestOperationsExtensionsTests.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-web/src/test/kotlin/org/springframework/web/method/annotation/RequestParamMethodArgumentResolverKotlinTests.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/BodyInsertersExtensions.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/client/ClientResponseExtensions.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.