language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
spring-projects
spring-framework
c43040287253bda3e9710759eb722fb54c1e9cc0.json
Improve support for Mono<ResponseEntity<?>> If the body class is not resolvable from the return type and there is a body instance we now fall back on the class of the body instance. Issue: SPR-14877
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/HandlerResultHandlerTests.java
@@ -71,7 +71,7 @@ public void setUp() throws Exception { public void usesContentTypeResolver() throws Exception { TestResultHandler resultHandler = new TestResultHandler(new FixedContentTypeResolver(IMAGE_GIF)); List<MediaType> mediaTypes = Arrays.asList(IMAGE_JPEG, IMAGE_GIF, IMAGE_PNG); - MediaType actual = ...
true
Other
spring-projects
spring-framework
c43040287253bda3e9710759eb722fb54c1e9cc0.json
Improve support for Mono<ResponseEntity<?>> If the body class is not resolvable from the return type and there is a body instance we now fall back on the class of the body instance. Issue: SPR-14877
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/MessageWriterResultHandlerTests.java
@@ -43,17 +43,16 @@ import org.springframework.core.codec.CharSequenceEncoder; import org.springframework.core.io.ClassPathResource; import org.springframework.core.io.Resource; -import org.springframework.core.io.buffer.DataBuffer; import org.springframework.core.io.buffer.support.DataBufferTestUtils; import org....
true
Other
spring-projects
spring-framework
c43040287253bda3e9710759eb722fb54c1e9cc0.json
Improve support for Mono<ResponseEntity<?>> If the body class is not resolvable from the return type and there is a body instance we now fall back on the class of the body instance. Issue: SPR-14877
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/ResponseEntityResultHandlerTests.java
@@ -23,6 +23,7 @@ import java.time.temporal.ChronoUnit; import java.util.ArrayList; import java.util.Arrays; +import java.util.Collections; import java.util.List; import java.util.concurrent.CompletableFuture; @@ -37,11 +38,11 @@ import org.springframework.core.ResolvableType; import org.springframework.core.c...
true
Other
spring-projects
spring-framework
95abd18fea067b271bf50252b0a741c5850cab93.json
Fix Exception Handling result handler resolution Prior to this commit, the wrong `HandlerResultHandler` could be resolved when handling exceptions; this could happen only if the original handler and exception handler had different signatures: ``` Publisher<String> originalHandler() { ... } @ExceptionHandler(MyCustom...
spring-web-reactive/src/main/java/org/springframework/web/reactive/DispatcherHandler.java
@@ -142,7 +142,7 @@ private Mono<HandlerResult> invokeHandler(ServerWebExchange exchange, Object han private Mono<Void> handleResult(ServerWebExchange exchange, HandlerResult result) { return getResultHandler(result).handleResult(exchange, result) .otherwise(ex -> result.applyExceptionHandler(ex).then(excepti...
true
Other
spring-projects
spring-framework
95abd18fea067b271bf50252b0a741c5850cab93.json
Fix Exception Handling result handler resolution Prior to this commit, the wrong `HandlerResultHandler` could be resolved when handling exceptions; this could happen only if the original handler and exception handler had different signatures: ``` Publisher<String> originalHandler() { ... } @ExceptionHandler(MyCustom...
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/RequestMappingExceptionHandlingIntegrationTests.java
@@ -25,6 +25,7 @@ import org.springframework.context.annotation.ComponentScan; import org.springframework.context.annotation.Configuration; import org.springframework.http.HttpHeaders; +import org.springframework.http.ResponseEntity; import org.springframework.web.bind.annotation.ExceptionHandler; import org.sprin...
true
Other
spring-projects
spring-framework
1e4a3a2370b9ded44a62155aea59c0d81c36149f.json
Return SslInfo only if X509Certificate[] present Issue: SPR-16842
spring-web/src/main/java/org/springframework/http/server/reactive/DefaultSslInfo.java
@@ -40,7 +40,7 @@ final class DefaultSslInfo implements SslInfo { private final X509Certificate[] peerCertificates; - DefaultSslInfo(String sessionId, X509Certificate[] peerCertificates) { + DefaultSslInfo(@Nullable String sessionId, X509Certificate[] peerCertificates) { Assert.notNull(peerCertificates, "No SS...
true
Other
spring-projects
spring-framework
1e4a3a2370b9ded44a62155aea59c0d81c36149f.json
Return SslInfo only if X509Certificate[] present Issue: SPR-16842
spring-web/src/main/java/org/springframework/http/server/reactive/ServletServerHttpRequest.java
@@ -57,10 +57,6 @@ */ class ServletServerHttpRequest extends AbstractServerHttpRequest { - private static final String X509_CERTIFICATE_ATTRIBUTE = "javax.servlet.request.X509Certificate"; - - private static final String SSL_SESSION_ID_ATTRIBUTE = "javax.servlet.request.ssl_session_id"; - static final DataBuffer...
true
Other
spring-projects
spring-framework
b472d192f43c5d827cfc49115c22c83acaebf2f0.json
Improve support for caching encoded resources The key in CachingResourceResolver now includes the "Accept-Encoding" request header cleaned to exclude "*", "identity", and parameters, and also sorted alphabetically. For encoded resources the response now includes a response header with "Vary: Accept-Encoding". Issue:...
spring-webflux/src/main/java/org/springframework/web/reactive/resource/CachingResourceResolver.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -16,7 +16,9 @@ package org.springframewor...
true
Other
spring-projects
spring-framework
b472d192f43c5d827cfc49115c22c83acaebf2f0.json
Improve support for caching encoded resources The key in CachingResourceResolver now includes the "Accept-Encoding" request header cleaned to exclude "*", "identity", and parameters, and also sorted alphabetically. For encoded resources the response now includes a response header with "Vary: Accept-Encoding". Issue:...
spring-webflux/src/main/java/org/springframework/web/reactive/resource/EncodedResourceResolver.java
@@ -268,6 +268,7 @@ public HttpHeaders getResponseHeaders() { headers = new HttpHeaders(); } headers.add(HttpHeaders.CONTENT_ENCODING, this.coding); + headers.add(HttpHeaders.VARY, HttpHeaders.ACCEPT_ENCODING); return headers; } }
true
Other
spring-projects
spring-framework
b472d192f43c5d827cfc49115c22c83acaebf2f0.json
Improve support for caching encoded resources The key in CachingResourceResolver now includes the "Accept-Encoding" request header cleaned to exclude "*", "identity", and parameters, and also sorted alphabetically. For encoded resources the response now includes a response header with "Vary: Accept-Encoding". Issue:...
spring-webflux/src/main/java/org/springframework/web/reactive/resource/GzipResourceResolver.java
@@ -166,6 +166,7 @@ public HttpHeaders getResponseHeaders() { headers = new HttpHeaders(); } headers.add(HttpHeaders.CONTENT_ENCODING, "gzip"); + headers.add(HttpHeaders.VARY, HttpHeaders.ACCEPT_ENCODING); return headers; } }
true
Other
spring-projects
spring-framework
b472d192f43c5d827cfc49115c22c83acaebf2f0.json
Improve support for caching encoded resources The key in CachingResourceResolver now includes the "Accept-Encoding" request header cleaned to exclude "*", "identity", and parameters, and also sorted alphabetically. For encoded resources the response now includes a response header with "Vary: Accept-Encoding". Issue:...
spring-webflux/src/test/java/org/springframework/web/reactive/resource/CachingResourceResolverTests.java
@@ -28,10 +28,10 @@ import org.springframework.cache.concurrent.ConcurrentMapCache; import org.springframework.core.io.ClassPathResource; import org.springframework.core.io.Resource; -import org.springframework.mock.http.server.reactive.test.MockServerHttpRequest; import org.springframework.mock.web.test.server.Moc...
true
Other
spring-projects
spring-framework
b472d192f43c5d827cfc49115c22c83acaebf2f0.json
Improve support for caching encoded resources The key in CachingResourceResolver now includes the "Accept-Encoding" request header cleaned to exclude "*", "identity", and parameters, and also sorted alphabetically. For encoded resources the response now includes a response header with "Vary: Accept-Encoding". Issue:...
spring-webflux/src/test/java/org/springframework/web/reactive/resource/EncodedResourceResolverTests.java
@@ -37,6 +37,7 @@ import org.springframework.core.io.ClassPathResource; import org.springframework.core.io.FileSystemResource; import org.springframework.core.io.Resource; +import org.springframework.http.HttpHeaders; import org.springframework.mock.http.server.reactive.test.MockServerHttpRequest; import org.sprin...
true
Other
spring-projects
spring-framework
b472d192f43c5d827cfc49115c22c83acaebf2f0.json
Improve support for caching encoded resources The key in CachingResourceResolver now includes the "Accept-Encoding" request header cleaned to exclude "*", "identity", and parameters, and also sorted alphabetically. For encoded resources the response now includes a response header with "Vary: Accept-Encoding". Issue:...
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/CachingResourceResolver.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -16,14 +16,18 @@ package org.springframew...
true
Other
spring-projects
spring-framework
b472d192f43c5d827cfc49115c22c83acaebf2f0.json
Improve support for caching encoded resources The key in CachingResourceResolver now includes the "Accept-Encoding" request header cleaned to exclude "*", "identity", and parameters, and also sorted alphabetically. For encoded resources the response now includes a response header with "Vary: Accept-Encoding". Issue:...
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/EncodedResourceResolver.java
@@ -263,6 +263,7 @@ public HttpHeaders getResponseHeaders() { headers = new HttpHeaders(); } headers.add(HttpHeaders.CONTENT_ENCODING, this.coding); + headers.add(HttpHeaders.VARY, HttpHeaders.ACCEPT_ENCODING); return headers; } }
true
Other
spring-projects
spring-framework
b472d192f43c5d827cfc49115c22c83acaebf2f0.json
Improve support for caching encoded resources The key in CachingResourceResolver now includes the "Accept-Encoding" request header cleaned to exclude "*", "identity", and parameters, and also sorted alphabetically. For encoded resources the response now includes a response header with "Vary: Accept-Encoding". Issue:...
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/GzipResourceResolver.java
@@ -167,6 +167,7 @@ public HttpHeaders getResponseHeaders() { headers = new HttpHeaders(); } headers.add(HttpHeaders.CONTENT_ENCODING, "gzip"); + headers.add(HttpHeaders.VARY, HttpHeaders.ACCEPT_ENCODING); return headers; } }
true
Other
spring-projects
spring-framework
b472d192f43c5d827cfc49115c22c83acaebf2f0.json
Improve support for caching encoded resources The key in CachingResourceResolver now includes the "Accept-Encoding" request header cleaned to exclude "*", "identity", and parameters, and also sorted alphabetically. For encoded resources the response now includes a response header with "Vary: Accept-Encoding". Issue:...
spring-webmvc/src/test/java/org/springframework/web/servlet/resource/CachingResourceResolverTests.java
@@ -73,7 +73,7 @@ public void resolveResourceInternal() { @Test public void resolveResourceInternalFromCache() { Resource expected = Mockito.mock(Resource.class); - this.cache.put(CachingResourceResolver.RESOLVED_RESOURCE_CACHE_KEY_PREFIX + "bar.css", expected); + this.cache.put(getCacheKey("bar.css"), expecte...
true
Other
spring-projects
spring-framework
b472d192f43c5d827cfc49115c22c83acaebf2f0.json
Improve support for caching encoded resources The key in CachingResourceResolver now includes the "Accept-Encoding" request header cleaned to exclude "*", "identity", and parameters, and also sorted alphabetically. For encoded resources the response now includes a response header with "Vary: Accept-Encoding". Issue:...
spring-webmvc/src/test/java/org/springframework/web/servlet/resource/EncodedResourceResolverTests.java
@@ -36,6 +36,7 @@ import org.springframework.core.io.ClassPathResource; import org.springframework.core.io.FileSystemResource; import org.springframework.core.io.Resource; +import org.springframework.http.HttpHeaders; import org.springframework.mock.web.test.MockHttpServletRequest; import org.springframework.util....
true
Other
spring-projects
spring-framework
9074828478cd964e3e1e6a8f0e02739cc88fe055.json
Add attributes to WebFlux WebSocketSession Issue: SPR-16212
spring-webflux/src/main/java/org/springframework/web/reactive/socket/WebSocketSession.java
@@ -15,6 +15,8 @@ */ package org.springframework.web.reactive.socket; +import java.util.Collections; +import java.util.Map; import java.util.function.Function; import org.reactivestreams.Publisher; @@ -52,6 +54,13 @@ public interface WebSocketSession { */ DataBufferFactory bufferFactory(); + /** + * Re...
true
Other
spring-projects
spring-framework
9074828478cd964e3e1e6a8f0e02739cc88fe055.json
Add attributes to WebFlux WebSocketSession Issue: SPR-16212
spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/AbstractWebSocketSession.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -17,6 +17,8 @@ package org.springframework....
true
Other
spring-projects
spring-framework
592dc628d5523ef955bd2dfa4cbe3a45a254bfb5.json
Use specific XSD types in spring-websocket.xsd Issue: SPR-16531
spring-websocket/src/main/resources/org/springframework/web/socket/config/spring-websocket.xsd
@@ -148,7 +148,7 @@ ]]></xsd:documentation> </xsd:annotation> </xsd:attribute> - <xsd:attribute name="stream-bytes-limit" type="xsd:string"> + <xsd:attribute name="stream-bytes-limit" type="xsd:int"> <xsd:annotation> <xsd:documentation source="java:org.springframework.web.socket.sockj...
false
Other
spring-projects
spring-framework
543f1902397db77e3277130abea377b8a1d4a63f.json
Expand WebFlux docs with WebSocketHandler examples Issue: SPR-16820
spring-webflux/src/main/java/org/springframework/web/reactive/socket/WebSocketHandler.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -19,11 +19,69 @@ import java.util.Collectio...
true
Other
spring-projects
spring-framework
543f1902397db77e3277130abea377b8a1d4a63f.json
Expand WebFlux docs with WebSocketHandler examples Issue: SPR-16820
src/docs/asciidoc/web/webflux-websocket.adoc
@@ -20,10 +20,10 @@ server side applications that handle WebSocket messages. [[webflux-websocket-server-handler]] -=== WebSocketHandler +=== Server [.small]#<<web.adoc#websocket-server-handler,Same in Servlet stack>># -Creating a WebSocket server is as simple as implementing `WebSocketHandler`: +To create a Web...
true
Other
spring-projects
spring-framework
37b0ed9fcb74c42dd6a8de24834d5ac7e75392f6.json
Improve TCP connection info logging. After the recent changes to expose configuring TcpOperations, it no longer makes sense to automatically log the relayHost/Port since that's mutually exclusive with a custom TcpOperations. Instead we delegate to TcpOperations.toString(). Issue: SPR-16801
spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/ReactorNettyTcpStompClient.java
@@ -89,4 +89,8 @@ public void shutdown() { this.tcpClient.shutdown(); } + @Override + public String toString() { + return "ReactorNettyTcpStompClient[" + this.tcpClient + "]"; + } }
true
Other
spring-projects
spring-framework
37b0ed9fcb74c42dd6a8de24834d5ac7e75392f6.json
Improve TCP connection info logging. After the recent changes to expose configuring TcpOperations, it no longer makes sense to automatically log the relayHost/Port since that's mutually exclusive with a custom TcpOperations. Instead we delegate to TcpOperations.toString(). Issue: SPR-16801
spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompBrokerRelayMessageHandler.java
@@ -82,12 +82,12 @@ public class StompBrokerRelayMessageHandler extends AbstractBrokerMessageHandler public static final String SYSTEM_SESSION_ID = "_system_"; - // STOMP recommends error of margin for receiving heartbeats + /** STOMP recommended error of margin for receiving heartbeats */ private static final ...
true
Other
spring-projects
spring-framework
37b0ed9fcb74c42dd6a8de24834d5ac7e75392f6.json
Improve TCP connection info logging. After the recent changes to expose configuring TcpOperations, it no longer makes sense to automatically log the relayHost/Port since that's mutually exclusive with a custom TcpOperations. Instead we delegate to TcpOperations.toString(). Issue: SPR-16801
spring-messaging/src/main/java/org/springframework/messaging/tcp/reactor/ReactorNettyTcpClient.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -30,6 +30,8 @@ import io.netty.channel.grou...
true
Other
spring-projects
spring-framework
37b0ed9fcb74c42dd6a8de24834d5ac7e75392f6.json
Improve TCP connection info logging. After the recent changes to expose configuring TcpOperations, it no longer makes sense to automatically log the relayHost/Port since that's mutually exclusive with a custom TcpOperations. Instead we delegate to TcpOperations.toString(). Issue: SPR-16801
spring-websocket/src/test/java/org/springframework/web/socket/config/MessageBrokerBeanDefinitionParserTests.java
@@ -279,18 +279,17 @@ public void stompBrokerRelay() { assertEquals(5000, messageBroker.getSystemHeartbeatSendInterval()); assertThat(messageBroker.getDestinationPrefixes(), Matchers.containsInAnyOrder("/topic","/queue")); - List<Class<? extends MessageHandler>> subscriberTypes = - Arrays.<Class<? extends M...
true
Other
spring-projects
spring-framework
020c6c0102c33b362acb34db441359cc35641e15.json
Polish: remove Javadoc tags from spring-websocket.xsd
spring-websocket/src/main/resources/org/springframework/web/socket/config/spring-websocket.xsd
@@ -526,14 +526,14 @@ <xsd:attribute name="allowed-origins" type="xsd:string"> <xsd:annotation> <xsd:documentation><![CDATA[ - Configure allowed {@code Origin} header values. Multiple origins may be specified + Configure allowed Origin header values. Multiple origins may be specified as a comma-sepa...
false
Other
spring-projects
spring-framework
29158aa79acb43d5c3d95689914e54c28426f8d7.json
Expose timeToFirstMessage in Java/XML config Issue: SPR-16531
spring-websocket/src/main/java/org/springframework/web/socket/config/MessageBrokerBeanDefinitionParser.java
@@ -308,6 +308,9 @@ private RuntimeBeanReference registerStompHandler(Element element, RuntimeBeanRe if (transportElem.hasAttribute("send-buffer-size")) { handlerDef.getPropertyValues().add("sendBufferSizeLimit", transportElem.getAttribute("send-buffer-size")); } + if (transportElem.hasAttribute("time-to...
true
Other
spring-projects
spring-framework
29158aa79acb43d5c3d95689914e54c28426f8d7.json
Expose timeToFirstMessage in Java/XML config Issue: SPR-16531
spring-websocket/src/main/java/org/springframework/web/socket/config/annotation/WebMvcStompEndpointRegistry.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -77,6 +77,9 @@ public WebMvcStompEndpointReg...
true
Other
spring-projects
spring-framework
29158aa79acb43d5c3d95689914e54c28426f8d7.json
Expose timeToFirstMessage in Java/XML config Issue: SPR-16531
spring-websocket/src/main/java/org/springframework/web/socket/config/annotation/WebSocketTransportRegistration.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -40,6 +40,9 @@ public class WebSocketTranspo...
true
Other
spring-projects
spring-framework
29158aa79acb43d5c3d95689914e54c28426f8d7.json
Expose timeToFirstMessage in Java/XML config Issue: SPR-16531
spring-websocket/src/main/java/org/springframework/web/socket/messaging/SubProtocolWebSocketHandler.java
@@ -68,13 +68,8 @@ public class SubProtocolWebSocketHandler implements WebSocketHandler, SubProtocolCapable, MessageHandler, SmartLifecycle { - /** - * Sessions connected to this handler use a sub-protocol. Hence we expect to - * receive some client messages. If we don't receive any within a minute, the - * co...
true
Other
spring-projects
spring-framework
29158aa79acb43d5c3d95689914e54c28426f8d7.json
Expose timeToFirstMessage in Java/XML config Issue: SPR-16531
spring-websocket/src/main/resources/org/springframework/web/socket/config/spring-websocket.xsd
@@ -683,6 +683,22 @@ @param sendBufferSizeLimit the maximum number of bytes to buffer when sending messages; if the value is less than or equal to 0 then buffering is effectively disabled. + ]]></xsd:documentation> + </xsd:annotation> + </xsd:attribute> + <xsd:attrib...
true
Other
spring-projects
spring-framework
29158aa79acb43d5c3d95689914e54c28426f8d7.json
Expose timeToFirstMessage in Java/XML config Issue: SPR-16531
spring-websocket/src/test/java/org/springframework/web/socket/config/MessageBrokerBeanDefinitionParserTests.java
@@ -94,8 +94,8 @@ import static org.junit.Assert.*; /** - * Test fixture for MessageBrokerBeanDefinitionParser. - * See test configuration files websocket-config-broker-*.xml. + * Test fixture for {@link MessageBrokerBeanDefinitionParser}. + * Also see test configuration files websocket-config-broker-*.xml. * *...
true
Other
spring-projects
spring-framework
29158aa79acb43d5c3d95689914e54c28426f8d7.json
Expose timeToFirstMessage in Java/XML config Issue: SPR-16531
spring-websocket/src/test/java/org/springframework/web/socket/config/annotation/WebSocketMessageBrokerConfigurationSupportTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2015 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -48,7 +48,6 @@ import org.springframework.s...
true
Other
spring-projects
spring-framework
29158aa79acb43d5c3d95689914e54c28426f8d7.json
Expose timeToFirstMessage in Java/XML config Issue: SPR-16531
spring-websocket/src/test/resources/org/springframework/web/socket/config/websocket-config-broker-simple.xml
@@ -10,7 +10,7 @@ path-helper="urlPathHelper"> <!-- message-size=128*1024, send-buffer-size=1024*1024 --> - <websocket:transport message-size="131072" send-timeout="25000" send-buffer-size="1048576"> + <websocket:transport message-size="131072" send-timeout="25000" send-buffer-size="1048576" time-to-fi...
true
Other
spring-projects
spring-framework
18854ee5445b2e1301dbfddfdb759a647230b7fa.json
Polish: simplify ControllerMethodResolver initialization
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/ControllerMethodResolver.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -24,8 +24,6 @@ import java.util.Map; impor...
true
Other
spring-projects
spring-framework
18854ee5445b2e1301dbfddfdb759a647230b7fa.json
Polish: simplify ControllerMethodResolver initialization
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/RequestMappingHandlerAdapter.java
@@ -170,7 +170,7 @@ public void afterPropertiesSet() throws Exception { } this.methodResolver = new ControllerMethodResolver(this.argumentResolverConfigurer, - this.messageReaders, this.reactiveAdapterRegistry, this.applicationContext); + this.reactiveAdapterRegistry, this.applicationContext, this.message...
true
Other
spring-projects
spring-framework
18854ee5445b2e1301dbfddfdb759a647230b7fa.json
Polish: simplify ControllerMethodResolver initialization
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/ControllerMethodResolverTests.java
@@ -76,7 +76,7 @@ public void setUp() throws Exception { applicationContext.refresh(); this.methodResolver = new ControllerMethodResolver( - resolvers, codecs.getReaders(), ReactiveAdapterRegistry.getSharedInstance(), applicationContext); + resolvers, ReactiveAdapterRegistry.getSharedInstance(), applicati...
true
Other
spring-projects
spring-framework
18854ee5445b2e1301dbfddfdb759a647230b7fa.json
Polish: simplify ControllerMethodResolver initialization
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/ModelInitializerTests.java
@@ -79,7 +79,7 @@ public void setUp() throws Exception { resolverConfigurer.addCustomResolver(new ModelArgumentResolver(adapterRegistry)); ControllerMethodResolver methodResolver = new ControllerMethodResolver( - resolverConfigurer, Collections.emptyList(), adapterRegistry, new StaticApplicationContext()); +...
true
Other
spring-projects
spring-framework
f7d60b7f58f26e313ef41995dfa44c5461adcc5c.json
Add getResource to MultipartFile Issue: SPR-16808
spring-web/src/main/java/org/springframework/web/multipart/MultipartFile.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -21,6 +21,7 @@ import java.io.InputStream; ...
true
Other
spring-projects
spring-framework
f7d60b7f58f26e313ef41995dfa44c5461adcc5c.json
Add getResource to MultipartFile Issue: SPR-16808
spring-web/src/main/java/org/springframework/web/multipart/MultipartFileResource.java
@@ -0,0 +1,99 @@ +/* + * Copyright 2002-2018 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
f7d60b7f58f26e313ef41995dfa44c5461adcc5c.json
Add getResource to MultipartFile Issue: SPR-16808
spring-web/src/test/java/org/springframework/web/multipart/support/StandardMultipartHttpServletRequestTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -16,12 +16,20 @@ package org.springframew...
true
Other
spring-projects
spring-framework
ed97e14c7ad8b5402e67f4da3c3b5a0a2949270a.json
Update Kotlin refdoc with the new tutorial
src/docs/asciidoc/languages/kotlin.adoc
@@ -9,8 +9,10 @@ existing libraries written in Java. The Spring Framework provides first-class support for Kotlin that allows developers to write Kotlin applications almost as if the Spring Framework was a native Kotlin framework. -Feel free to join the #spring channel of http://slack.kotlinlang.org/[Kotlin Slack] ...
false
Other
spring-projects
spring-framework
4da43de7e1df1fb4f73c0a496b81d7c863c4a50c.json
Remove individual detection of forwarded headers This commit removes all places where forwarded headers are checked implicitly, on an ad-hoc basis. ForwardedHeaderFilter is expected to be used instead providing centralized control over using or discarding such headers. Issue: SPR-16668
spring-test/src/main/java/org/springframework/mock/web/reactive/function/server/MockServerRequest.java
@@ -38,7 +38,6 @@ import org.springframework.http.HttpHeaders; import org.springframework.http.HttpMethod; import org.springframework.http.HttpRange; -import org.springframework.http.HttpRequest; import org.springframework.http.MediaType; import org.springframework.http.codec.HttpMessageReader; import org.springf...
true
Other
spring-projects
spring-framework
4da43de7e1df1fb4f73c0a496b81d7c863c4a50c.json
Remove individual detection of forwarded headers This commit removes all places where forwarded headers are checked implicitly, on an ad-hoc basis. ForwardedHeaderFilter is expected to be used instead providing centralized control over using or discarding such headers. Issue: SPR-16668
spring-web/src/main/java/org/springframework/web/cors/reactive/CorsUtils.java
@@ -16,6 +16,8 @@ package org.springframework.web.cors.reactive; +import java.net.URI; + import org.springframework.http.HttpHeaders; import org.springframework.http.HttpMethod; import org.springframework.http.server.reactive.ServerHttpRequest; @@ -49,28 +51,26 @@ public static boolean isPreFlightRequest(Server...
true
Other
spring-projects
spring-framework
4da43de7e1df1fb4f73c0a496b81d7c863c4a50c.json
Remove individual detection of forwarded headers This commit removes all places where forwarded headers are checked implicitly, on an ad-hoc basis. ForwardedHeaderFilter is expected to be used instead providing centralized control over using or discarding such headers. Issue: SPR-16668
spring-web/src/main/java/org/springframework/web/util/WebUtils.java
@@ -18,11 +18,10 @@ import java.io.File; import java.io.FileNotFoundException; +import java.net.URI; import java.util.Collection; import java.util.Enumeration; -import java.util.LinkedHashSet; import java.util.Map; -import java.util.Set; import java.util.StringTokenizer; import java.util.TreeMap; import javax...
true
Other
spring-projects
spring-framework
4da43de7e1df1fb4f73c0a496b81d7c863c4a50c.json
Remove individual detection of forwarded headers This commit removes all places where forwarded headers are checked implicitly, on an ad-hoc basis. ForwardedHeaderFilter is expected to be used instead providing centralized control over using or discarding such headers. Issue: SPR-16668
spring-web/src/test/java/org/springframework/web/cors/reactive/CorsUtilsTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2015 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -16,15 +16,19 @@ package org.springframew...
true
Other
spring-projects
spring-framework
4da43de7e1df1fb4f73c0a496b81d7c863c4a50c.json
Remove individual detection of forwarded headers This commit removes all places where forwarded headers are checked implicitly, on an ad-hoc basis. ForwardedHeaderFilter is expected to be used instead providing centralized control over using or discarding such headers. Issue: SPR-16668
spring-web/src/test/java/org/springframework/web/util/WebUtilsTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -21,19 +21,20 @@ import java.util.HashMap; ...
true
Other
spring-projects
spring-framework
4da43de7e1df1fb4f73c0a496b81d7c863c4a50c.json
Remove individual detection of forwarded headers This commit removes all places where forwarded headers are checked implicitly, on an ad-hoc basis. ForwardedHeaderFilter is expected to be used instead providing centralized control over using or discarding such headers. Issue: SPR-16668
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultServerRequest.java
@@ -36,7 +36,6 @@ import org.springframework.http.HttpCookie; import org.springframework.http.HttpHeaders; import org.springframework.http.HttpRange; -import org.springframework.http.HttpRequest; import org.springframework.http.MediaType; import org.springframework.http.codec.HttpMessageReader; import org.springf...
true
Other
spring-projects
spring-framework
4da43de7e1df1fb4f73c0a496b81d7c863c4a50c.json
Remove individual detection of forwarded headers This commit removes all places where forwarded headers are checked implicitly, on an ad-hoc basis. ForwardedHeaderFilter is expected to be used instead providing centralized control over using or discarding such headers. Issue: SPR-16668
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/ServerRequest.java
@@ -84,10 +84,13 @@ default HttpMethod method() { /** * Return a {@code UriBuilderComponents} from the URI associated with this - * {@code ServerRequest}, while also overlaying with values from the headers - * "Forwarded" (<a href="http://tools.ietf.org/html/rfc7239">RFC 7239</a>), - * or "X-Forwarded-Host",...
true
Other
spring-projects
spring-framework
4da43de7e1df1fb4f73c0a496b81d7c863c4a50c.json
Remove individual detection of forwarded headers This commit removes all places where forwarded headers are checked implicitly, on an ad-hoc basis. ForwardedHeaderFilter is expected to be used instead providing centralized control over using or discarding such headers. Issue: SPR-16668
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/ServerWebExchangeArgumentResolver.java
@@ -109,7 +109,7 @@ else if (ZoneId.class == paramType) { return timeZone != null ? timeZone.toZoneId() : ZoneId.systemDefault(); } else if (UriBuilder.class == paramType || UriComponentsBuilder.class == paramType) { - return UriComponentsBuilder.fromHttpRequest(exchange.getRequest()); + return UriCompone...
true
Other
spring-projects
spring-framework
4da43de7e1df1fb4f73c0a496b81d7c863c4a50c.json
Remove individual detection of forwarded headers This commit removes all places where forwarded headers are checked implicitly, on an ad-hoc basis. ForwardedHeaderFilter is expected to be used instead providing centralized control over using or discarding such headers. Issue: SPR-16668
spring-webflux/src/test/java/org/springframework/web/reactive/function/server/MockServerRequest.java
@@ -38,7 +38,6 @@ import org.springframework.http.HttpHeaders; import org.springframework.http.HttpMethod; import org.springframework.http.HttpRange; -import org.springframework.http.HttpRequest; import org.springframework.http.MediaType; import org.springframework.http.codec.HttpMessageReader; import org.springf...
true
Other
spring-projects
spring-framework
4da43de7e1df1fb4f73c0a496b81d7c863c4a50c.json
Remove individual detection of forwarded headers This commit removes all places where forwarded headers are checked implicitly, on an ad-hoc basis. ForwardedHeaderFilter is expected to be used instead providing centralized control over using or discarding such headers. Issue: SPR-16668
spring-webmvc/src/main/java/org/springframework/web/servlet/support/ServletUriComponentsBuilder.java
@@ -16,18 +16,14 @@ package org.springframework.web.servlet.support; -import java.util.Enumeration; import javax.servlet.http.HttpServletRequest; -import org.springframework.http.HttpRequest; -import org.springframework.http.server.ServletServerHttpRequest; import org.springframework.lang.Nullable; import org...
true
Other
spring-projects
spring-framework
4da43de7e1df1fb4f73c0a496b81d7c863c4a50c.json
Remove individual detection of forwarded headers This commit removes all places where forwarded headers are checked implicitly, on an ad-hoc basis. ForwardedHeaderFilter is expected to be used instead providing centralized control over using or discarding such headers. Issue: SPR-16668
spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/MvcUriComponentsBuilderTests.java
@@ -23,6 +23,7 @@ import java.lang.annotation.Target; import java.util.Arrays; import java.util.List; +import javax.servlet.http.HttpServletRequest; import org.hamcrest.Matchers; import org.joda.time.DateTime; @@ -36,7 +37,9 @@ import org.springframework.format.annotation.DateTimeFormat.ISO; import org.springf...
true
Other
spring-projects
spring-framework
4da43de7e1df1fb4f73c0a496b81d7c863c4a50c.json
Remove individual detection of forwarded headers This commit removes all places where forwarded headers are checked implicitly, on an ad-hoc basis. ForwardedHeaderFilter is expected to be used instead providing centralized control over using or discarding such headers. Issue: SPR-16668
spring-webmvc/src/test/java/org/springframework/web/servlet/support/ServletUriComponentsBuilderTests.java
@@ -16,12 +16,17 @@ package org.springframework.web.servlet.support; +import javax.servlet.http.HttpServletRequest; + import org.junit.Before; import org.junit.Test; +import org.springframework.mock.web.test.MockFilterChain; import org.springframework.mock.web.test.MockHttpServletRequest; +import org.springfr...
true
Other
spring-projects
spring-framework
4da43de7e1df1fb4f73c0a496b81d7c863c4a50c.json
Remove individual detection of forwarded headers This commit removes all places where forwarded headers are checked implicitly, on an ad-hoc basis. ForwardedHeaderFilter is expected to be used instead providing centralized control over using or discarding such headers. Issue: SPR-16668
src/docs/asciidoc/web/webflux.adoc
@@ -1417,10 +1417,8 @@ etc, and is equivalent to `required=false`. See <<webflux-ann-sessionattributes>> for more details. | `UriComponentsBuilder` -| For preparing a URL relative to the current request's host, port, scheme, context path, and - the literal part of the servlet mapping also taking into account `F...
true
Other
spring-projects
spring-framework
4da43de7e1df1fb4f73c0a496b81d7c863c4a50c.json
Remove individual detection of forwarded headers This commit removes all places where forwarded headers are checked implicitly, on an ad-hoc basis. ForwardedHeaderFilter is expected to be used instead providing centralized control over using or discarding such headers. Issue: SPR-16668
src/docs/asciidoc/web/webmvc.adoc
@@ -1689,8 +1689,7 @@ etc, and is equivalent to `required=false`. | `UriComponentsBuilder` | For preparing a URL relative to the current request's host, port, scheme, context path, and - the literal part of the servlet mapping also taking into account `Forwarded` and - `X-Forwarded-*` headers. See <<mvc-uri-build...
true
Other
spring-projects
spring-framework
eef592d901df1a3f477253c864b7ade9673d8da8.json
Add builder to MockServerWebExchange Issue: SPR-16772
spring-test/src/main/java/org/springframework/mock/web/server/MockServerWebExchange.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -15,15 +15,20 @@ */ package org.springfra...
true
Other
spring-projects
spring-framework
eef592d901df1a3f477253c864b7ade9673d8da8.json
Add builder to MockServerWebExchange Issue: SPR-16772
spring-web/src/test/java/org/springframework/mock/web/test/server/MockServerWebExchange.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -15,15 +15,20 @@ */ package org.springfra...
true
Other
spring-projects
spring-framework
eef592d901df1a3f477253c864b7ade9673d8da8.json
Add builder to MockServerWebExchange Issue: SPR-16772
spring-web/src/test/java/org/springframework/web/server/session/DefaultWebSessionManagerTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -17,6 +17,7 @@ import java.util.Arrays; ...
true
Other
spring-projects
spring-framework
eef592d901df1a3f477253c864b7ade9673d8da8.json
Add builder to MockServerWebExchange Issue: SPR-16772
spring-web/src/test/java/org/springframework/web/server/session/InMemoryWebSessionStoreTests.java
@@ -55,7 +55,7 @@ public void startsSessionImplicitly() { } @Test - public void retrieveExpiredSession() throws Exception { + public void retrieveExpiredSession() { WebSession session = this.store.createWebSession().block(); assertNotNull(session); session.getAttributes().put("foo", "bar"); @@ -73,7 +73,...
true
Other
spring-projects
spring-framework
eef592d901df1a3f477253c864b7ade9673d8da8.json
Add builder to MockServerWebExchange Issue: SPR-16772
spring-web/src/test/java/org/springframework/web/server/session/MockWebSessionManager.java
@@ -1,47 +0,0 @@ -/* - * Copyright 2002-2016 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - ...
true
Other
spring-projects
spring-framework
eef592d901df1a3f477253c864b7ade9673d8da8.json
Add builder to MockServerWebExchange Issue: SPR-16772
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/ServerWebExchangeArgumentResolverTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -58,7 +58,7 @@ public class ServerWebExchang...
true
Other
spring-projects
spring-framework
eef592d901df1a3f477253c864b7ade9673d8da8.json
Add builder to MockServerWebExchange Issue: SPR-16772
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/SessionAttributeMethodArgumentResolverTests.java
@@ -31,33 +31,21 @@ import org.springframework.core.ReactiveAdapterRegistry; import org.springframework.core.annotation.SynthesizingMethodParameter; import org.springframework.format.support.DefaultFormattingConversionService; -import org.springframework.http.codec.ServerCodecConfigurer; -import org.springframework....
true
Other
spring-projects
spring-framework
eef592d901df1a3f477253c864b7ade9673d8da8.json
Add builder to MockServerWebExchange Issue: SPR-16772
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/SessionAttributesHandlerTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -17,7 +17,6 @@ package org.springframework....
true
Other
spring-projects
spring-framework
eef592d901df1a3f477253c864b7ade9673d8da8.json
Add builder to MockServerWebExchange Issue: SPR-16772
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/WebSessionArgumentResolverTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -21,21 +21,15 @@ import org.springframewo...
true
Other
spring-projects
spring-framework
a1fa0daad5ea42b46eacf0f330dec69acf1de320.json
Fix a typo in javadoc Closes gh-1824
spring-jdbc/src/main/java/org/springframework/jdbc/object/RdbmsOperation.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -42,7 +42,7 @@ * arguments. Subclasses sho...
false
Other
spring-projects
spring-framework
504e2768de904cd9c653e9f22b6d99a0ec26697a.json
Add SAP HANA to common JPA database platforms Issue: SPR-16460
spring-orm/src/main/java/org/springframework/orm/jpa/vendor/AbstractJpaVendorAdapter.java
@@ -48,7 +48,7 @@ public abstract class AbstractJpaVendorAdapter implements JpaVendorAdapter { /** * Specify the target database to operate on, as a value of the {@code Database} enum: - * DB2, DERBY, H2, HSQL, INFORMIX, MYSQL, ORACLE, POSTGRESQL, SQL_SERVER, SYBASE + * DB2, DERBY, H2, HANA, HSQL, INFORMIX, MY...
true
Other
spring-projects
spring-framework
504e2768de904cd9c653e9f22b6d99a0ec26697a.json
Add SAP HANA to common JPA database platforms Issue: SPR-16460
spring-orm/src/main/java/org/springframework/orm/jpa/vendor/Database.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2012 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -39,8 +39,12 @@ public enum Database { D...
true
Other
spring-projects
spring-framework
504e2768de904cd9c653e9f22b6d99a0ec26697a.json
Add SAP HANA to common JPA database platforms Issue: SPR-16460
spring-orm/src/main/java/org/springframework/orm/jpa/vendor/EclipseLinkJpaVendorAdapter.java
@@ -97,9 +97,10 @@ protected String determineTargetDatabaseName(Database database) { switch (database) { case DB2: return TargetDatabase.DB2; case DERBY: return TargetDatabase.Derby; + case HANA: return TargetDatabase.HANA; case HSQL: return TargetDatabase.HSQL; case INFORMIX: return TargetDatabase...
true
Other
spring-projects
spring-framework
504e2768de904cd9c653e9f22b6d99a0ec26697a.json
Add SAP HANA to common JPA database platforms Issue: SPR-16460
spring-orm/src/main/java/org/springframework/orm/jpa/vendor/HibernateJpaVendorAdapter.java
@@ -28,6 +28,7 @@ import org.hibernate.dialect.DB2Dialect; import org.hibernate.dialect.DerbyTenSevenDialect; import org.hibernate.dialect.H2Dialect; +import org.hibernate.dialect.HANAColumnStoreDialect; import org.hibernate.dialect.HSQLDialect; import org.hibernate.dialect.InformixDialect; import org.hibernate.d...
true
Other
spring-projects
spring-framework
ad2c0f8410e3b8642e65545afe77e38614069b08.json
Improve @Nullable annotation This commit makes Spring @Nullable annotation leveraging JSR 305 @TypeQualifierNickname + @Nonnull(when= When.MAYBE) instead of directly using @javax.annotation.Nullable which seems not designed to be used as a meta-annotation. It also removes @TypeQualifierDefault since the purpose of th...
spring-core/src/main/java/org/springframework/lang/Nullable.java
@@ -6,7 +6,9 @@ import java.lang.annotation.RetentionPolicy; import java.lang.annotation.Target; -import javax.annotation.meta.TypeQualifierDefault; +import javax.annotation.Nonnull; +import javax.annotation.meta.TypeQualifierNickname; +import javax.annotation.meta.When; /** * Leverage JSR 305 meta-annotations...
false
Other
spring-projects
spring-framework
76b28a0cece1049fe5317cd76dfc774437f0d6b6.json
Fix grammatical errors in Testing chapter
src/docs/asciidoc/testing.adoc
@@ -2411,8 +2411,8 @@ how caching works, it is important to understand what is meant by __unique__ and suite__. An `ApplicationContext` can be __uniquely__ identified by the combination of -configuration parameters that are used to load it. Consequently, the unique combination -of configuration parameters are used ...
false
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
build.gradle
@@ -177,6 +177,7 @@ configure(allprojects) { project -> } dependencies { + provided("com.google.code.findbugs:jsr305:3.0.2") testCompile("junit:junit:${junitVersion}") { exclude group:'org.hamcrest', module:'hamcrest-core' }
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/aopalliance/aop/AspectException.java
@@ -16,6 +16,8 @@ package org.aopalliance.aop; +import org.springframework.lang.Nullable; + /** * Superclass for all AOP infrastructure exceptions. * Unchecked, as such exceptions are fatal and end user @@ -41,7 +43,7 @@ public AspectException(String message) { * @param message the exception message * @...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/aopalliance/intercept/MethodInterceptor.java
@@ -16,6 +16,8 @@ package org.aopalliance.intercept; +import org.springframework.lang.Nullable; + /** * Intercepts calls on an interface on its way to the target. These * are nested "on top" of the target. @@ -52,6 +54,7 @@ public interface MethodInterceptor extends Interceptor { * @throws Throwable if the...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/AfterReturningAdvice.java
@@ -18,6 +18,8 @@ import java.lang.reflect.Method; +import org.springframework.lang.Nullable; + /** * After returning advice is invoked only on normal method return, not if an * exception is thrown. Such advice can see the return value, but cannot change it. @@ -39,6 +41,6 @@ public interface AfterReturningAd...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/IntroductionAwareMethodMatcher.java
@@ -18,6 +18,8 @@ import java.lang.reflect.Method; +import org.springframework.lang.Nullable; + /** * A specialized type of {@link MethodMatcher} that takes into account introductions * when matching methods. If there are no introductions on the target class, @@ -39,6 +41,6 @@ public interface IntroductionAwa...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/MethodBeforeAdvice.java
@@ -18,6 +18,8 @@ import java.lang.reflect.Method; +import org.springframework.lang.Nullable; + /** * Advice invoked before a method is invoked. Such advices cannot * prevent the method call proceeding, unless they throw a Throwable. @@ -39,6 +41,6 @@ public interface MethodBeforeAdvice extends BeforeAdvice {...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/MethodMatcher.java
@@ -18,6 +18,8 @@ import java.lang.reflect.Method; +import org.springframework.lang.Nullable; + /** * Part of a {@link Pointcut}: Checks whether the target method is eligible for advice. * @@ -57,7 +59,7 @@ public interface MethodMatcher { * the candidate class must be taken to be the method's declaring cl...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/ProxyMethodInvocation.java
@@ -18,6 +18,8 @@ import org.aopalliance.intercept.MethodInvocation; +import org.springframework.lang.Nullable; + /** * Extension of the AOP Alliance {@link org.aopalliance.intercept.MethodInvocation} * interface, allowing access to the proxy that the method invocation was made through. @@ -73,14 +75,15 @@ pu...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/TargetClassAware.java
@@ -16,6 +16,8 @@ package org.springframework.aop; +import org.springframework.lang.Nullable; + /** * Minimal interface for exposing the target class behind a proxy. * @@ -34,6 +36,7 @@ public interface TargetClassAware { * (typically a proxy configuration or an actual proxy). * @return the target Class...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/TargetSource.java
@@ -16,6 +16,8 @@ package org.springframework.aop; +import org.springframework.lang.Nullable; + /** * A {@code TargetSource} is used to obtain the current "target" of * an AOP invocation, which will be invoked via reflection if no around @@ -58,6 +60,7 @@ public interface TargetSource extends TargetClassAware...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/aspectj/AbstractAspectJAdvice.java
@@ -42,6 +42,7 @@ import org.springframework.aop.support.StaticMethodMatcher; import org.springframework.core.DefaultParameterNameDiscoverer; import org.springframework.core.ParameterNameDiscoverer; +import org.springframework.lang.Nullable; import org.springframework.util.Assert; import org.springframework.util.C...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/aspectj/AspectJAdviceParameterNameDiscoverer.java
@@ -30,6 +30,7 @@ import org.aspectj.weaver.tools.PointcutPrimitive; import org.springframework.core.ParameterNameDiscoverer; +import org.springframework.lang.Nullable; import org.springframework.util.StringUtils; /** @@ -473,6 +474,7 @@ else if (numAnnotationSlots == 1) { /* * If the token starts meets Ja...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/aspectj/AspectJAfterReturningAdvice.java
@@ -22,6 +22,7 @@ import org.springframework.aop.AfterAdvice; import org.springframework.aop.AfterReturningAdvice; +import org.springframework.lang.Nullable; import org.springframework.util.ClassUtils; import org.springframework.util.TypeUtils; @@ -75,7 +76,7 @@ public void afterReturning(Object returnValue, Me...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/aspectj/AspectJAopUtils.java
@@ -21,6 +21,7 @@ import org.springframework.aop.Advisor; import org.springframework.aop.AfterAdvice; import org.springframework.aop.BeforeAdvice; +import org.springframework.lang.Nullable; /** * Utility methods for dealing with AspectJ advisors. @@ -58,6 +59,7 @@ public static boolean isAfterAdvice(Advisor anA...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/aspectj/AspectJExpressionPointcut.java
@@ -56,6 +56,7 @@ import org.springframework.beans.factory.FactoryBean; import org.springframework.beans.factory.annotation.BeanFactoryAnnotationUtils; import org.springframework.beans.factory.config.ConfigurableBeanFactory; +import org.springframework.lang.Nullable; import org.springframework.util.ClassUtils; imp...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/aspectj/MethodInvocationProceedingJoinPoint.java
@@ -29,6 +29,7 @@ import org.springframework.aop.ProxyMethodInvocation; import org.springframework.core.DefaultParameterNameDiscoverer; import org.springframework.core.ParameterNameDiscoverer; +import org.springframework.lang.Nullable; import org.springframework.util.Assert; /** @@ -109,6 +110,7 @@ public Object...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/AbstractAspectJAdvisorFactory.java
@@ -41,6 +41,7 @@ import org.springframework.aop.framework.AopConfigException; import org.springframework.core.ParameterNameDiscoverer; import org.springframework.core.annotation.AnnotationUtils; +import org.springframework.lang.Nullable; import org.springframework.util.StringUtils; /** @@ -125,6 +126,7 @@ publi...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/AspectJAdvisorFactory.java
@@ -24,6 +24,7 @@ import org.springframework.aop.Advisor; import org.springframework.aop.aspectj.AspectJExpressionPointcut; import org.springframework.aop.framework.AopConfigException; +import org.springframework.lang.Nullable; /** * Interface for factories that can create Spring AOP Advisors from classes @@ -7...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/MetadataAwareAspectInstanceFactory.java
@@ -17,6 +17,7 @@ package org.springframework.aop.aspectj.annotation; import org.springframework.aop.aspectj.AspectInstanceFactory; +import org.springframework.lang.Nullable; /** * Subinterface of {@link org.springframework.aop.aspectj.AspectInstanceFactory} @@ -44,6 +45,7 @@ public interface MetadataAwareAspe...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/ReflectiveAspectJAdvisorFactory.java
@@ -50,6 +50,7 @@ import org.springframework.core.annotation.AnnotationUtils; import org.springframework.core.convert.converter.Converter; import org.springframework.core.convert.converter.ConvertingComparator; +import org.springframework.lang.Nullable; import org.springframework.util.ReflectionUtils; import org.s...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/package-info.java
@@ -3,4 +3,7 @@ * * <p>Normally to be used through an AspectJAutoProxyCreator rather than directly. */ +@NonNullApi package org.springframework.aop.aspectj.annotation; + +import org.springframework.lang.NonNullApi; \ No newline at end of file
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/aspectj/autoproxy/package-info.java
@@ -2,4 +2,7 @@ * Base classes enabling auto-proxying based on AspectJ. * Support for AspectJ annotation aspects resides in the "aspectj.annotation" package. */ +@NonNullApi package org.springframework.aop.aspectj.autoproxy; + +import org.springframework.lang.NonNullApi; \ No newline at end of file
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/aspectj/package-info.java
@@ -8,4 +8,7 @@ * or AspectJ load-time weaver. It is intended to enable the use of a valuable subset of AspectJ * functionality, with consistent semantics, with the proxy-based Spring AOP framework. */ +@NonNullApi package org.springframework.aop.aspectj; + +import org.springframework.lang.NonNullApi; \ No newli...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/config/AopConfigUtils.java
@@ -26,6 +26,7 @@ import org.springframework.beans.factory.support.BeanDefinitionRegistry; import org.springframework.beans.factory.support.RootBeanDefinition; import org.springframework.core.Ordered; +import org.springframework.lang.Nullable; import org.springframework.util.Assert; /** @@ -104,7 +105,7 @@ publi...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/config/ConfigBeanDefinitionParser.java
@@ -45,6 +45,7 @@ import org.springframework.beans.factory.support.RootBeanDefinition; import org.springframework.beans.factory.xml.BeanDefinitionParser; import org.springframework.beans.factory.xml.ParserContext; +import org.springframework.lang.Nullable; import org.springframework.util.StringUtils; import org.sp...
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/config/package-info.java
@@ -2,4 +2,7 @@ * Support package for declarative AOP configuration, * with XML schema being the primary configuration format. */ +@NonNullApi package org.springframework.aop.config; + +import org.springframework.lang.NonNullApi; \ No newline at end of file
true
Other
spring-projects
spring-framework
87598f48e41d483745aba56cbf4e998c6f6d680c.json
Introduce null-safety of Spring Framework API This commit introduces 2 new @Nullable and @NonNullApi annotations that leverage JSR 305 (dormant but available via Findbugs jsr305 dependency and already used by libraries like OkHttp) meta-annotations to specify explicitly null-safety of Spring Framework parameters and r...
spring-aop/src/main/java/org/springframework/aop/framework/AdvisorChainFactory.java
@@ -19,6 +19,8 @@ import java.lang.reflect.Method; import java.util.List; +import org.springframework.lang.Nullable; + /** * Factory interface for advisor chains. * @@ -36,6 +38,6 @@ public interface AdvisorChainFactory { * target object, in which case the method's declaring class is the next best option) ...
true