language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/server/ServerRequestExtensions.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/server/ServerResponseExtensions.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-webflux/src/test/kotlin/org/springframework/web/reactive/function/BodyExtractorsExtensionsTests.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-webflux/src/test/kotlin/org/springframework/web/reactive/function/BodyInsertersExtensionsTests.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-webflux/src/test/kotlin/org/springframework/web/reactive/function/client/ClientResponseExtensionsTests.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-webflux/src/test/kotlin/org/springframework/web/reactive/function/client/WebClientExtensionsTests.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-webflux/src/test/kotlin/org/springframework/web/reactive/function/server/ServerRequestExtensionsTests.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-webflux/src/test/kotlin/org/springframework/web/reactive/function/server/ServerResponseExtensionsTests.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d728d597f25f6ea2fcf1c7db66766812b01b6861.json | Add missing license headers in Kotlin files | spring-webflux/src/test/kotlin/org/springframework/web/reactive/result/method/annotation/RequestParamMethodArgumentResolverKotlinTests.kt | @@ -1,3 +1,19 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-orm/src/main/java/org/springframework/orm/hibernate5/support/AsyncRequestInterceptor.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2015 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -36,7 +36,7 @@
*
* Ensures the following... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-orm/src/main/java/org/springframework/orm/jpa/support/AsyncRequestInterceptor.java | @@ -36,7 +36,7 @@
*
* Ensures the following:
* 1) The session is bound/unbound when "callable processing" is started
- * 2) The session is closed if an async request times out
+ * 2) The session is closed if an async request times out or an error occurred
*
* @author Rossen Stoyanchev
* @since 3.2.5
@@ -51,... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-orm/src/test/java/org/springframework/orm/jpa/support/OpenEntityManagerInViewTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2013 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -228,6 +228,48 @@ public String call() throw... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-web/src/main/java/org/springframework/web/context/request/async/AsyncWebRequest.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2012 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -16,6 +16,8 @@
package org.springframewor... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-web/src/main/java/org/springframework/web/context/request/async/CallableInterceptorChain.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2015 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -94,6 +94,24 @@ else if (result != CallableP... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-web/src/main/java/org/springframework/web/context/request/async/CallableProcessingInterceptor.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2015 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -28,15 +28,15 @@
*
* <p>A {@code Callabl... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-web/src/main/java/org/springframework/web/context/request/async/CallableProcessingInterceptorAdapter.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2015 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -60,6 +60,15 @@ public <T> Object handleTime... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-web/src/main/java/org/springframework/web/context/request/async/DeferredResult.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -18,6 +18,7 @@
import java.util.PriorityQ... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-web/src/main/java/org/springframework/web/context/request/async/DeferredResultInterceptorChain.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2015 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -78,6 +78,17 @@ public void triggerAfterTime... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-web/src/main/java/org/springframework/web/context/request/async/DeferredResultProcessingInterceptor.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2015 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -25,15 +25,15 @@
*
* <p>A {@code Deferre... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-web/src/main/java/org/springframework/web/context/request/async/DeferredResultProcessingInterceptorAdapter.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2015 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -60,6 +60,16 @@ public <T> boolean handleTim... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-web/src/main/java/org/springframework/web/context/request/async/ErrorCallableProcessingInterceptor.java | @@ -0,0 +1,37 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-web/src/main/java/org/springframework/web/context/request/async/ErrorDeferredResultProcessingInterceptor.java | @@ -0,0 +1,37 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-web/src/main/java/org/springframework/web/context/request/async/StandardServletAsyncWebRequest.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -20,6 +20,8 @@
import java.util.ArrayList;
... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-web/src/main/java/org/springframework/web/context/request/async/WebAsyncManager.java | @@ -67,9 +67,15 @@ public final class WebAsyncManager {
private static final CallableProcessingInterceptor timeoutCallableInterceptor =
new TimeoutCallableProcessingInterceptor();
+ private static final CallableProcessingInterceptor errorCallableInterceptor =
+ new ErrorCallableProcessingInterceptor();
+
pr... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-web/src/main/java/org/springframework/web/context/request/async/WebAsyncTask.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -46,6 +46,8 @@
private Callable<V> timeo... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-web/src/test/java/org/springframework/web/context/request/async/DeferredResultTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -16,6 +16,8 @@
package org.springframewor... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-web/src/test/java/org/springframework/web/context/request/async/StandardServletAsyncWebRequestTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2015 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -17,6 +17,8 @@
package org.springframework.... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-web/src/test/java/org/springframework/web/context/request/async/WebAsyncManagerErrorTests.java | @@ -0,0 +1,280 @@
+/*
+ * Copyright 2002-2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-web/src/test/java/org/springframework/web/context/request/async/WebAsyncManagerTests.java | @@ -17,6 +17,8 @@
package org.springframework.web.context.request.async;
import java.util.concurrent.Callable;
+import java.util.function.Consumer;
+
import javax.servlet.http.HttpServletRequest;
import org.junit.Before;
@@ -138,6 +140,7 @@ public void startCallableProcessingCallableException() throws Exception... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/ReactiveTypeHandler.java | @@ -219,6 +219,7 @@ public final void onSubscribe(Subscription subscription) {
terminate();
this.emitter.complete();
});
+ this.emitter.onError(t -> this.emitter.completeWithError(t));
subscription.request(1);
}
| true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/ResponseBodyEmitter.java | @@ -19,6 +19,7 @@
import java.io.IOException;
import java.util.LinkedHashSet;
import java.util.Set;
+import java.util.function.Consumer;
import org.springframework.http.MediaType;
import org.springframework.http.server.ServerHttpResponse;
@@ -74,6 +75,8 @@ public class ResponseBodyEmitter {
private final Def... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/ResponseBodyEmitterReturnValueHandler.java | @@ -19,6 +19,8 @@
import java.io.IOException;
import java.io.OutputStream;
import java.util.List;
+import java.util.function.Consumer;
+
import javax.servlet.ServletRequest;
import javax.servlet.http.HttpServletResponse;
@@ -217,6 +219,11 @@ public void onTimeout(Runnable callback) {
this.deferredResult.onTi... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/ReactiveTypeHandlerTests.java | @@ -22,6 +22,7 @@
import java.util.List;
import java.util.Set;
import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.Consumer;
import java.util.stream.Collectors;
import org.junit.Before;
@@ -380,6 +381,10 @@ public void completeWithError(Throwable failure) {
public void onTimeout(Run... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/ResponseBodyEmitterReturnValueHandlerTests.java | @@ -19,6 +19,7 @@
import java.util.Collections;
import java.util.List;
import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.Consumer;
import org.junit.Before;
import org.junit.Test;
@@ -175,6 +176,25 @@ public void responseBodyEmitterWithTimeoutValue() throws Exception {
verify(async... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/ResponseBodyEmitterTests.java | @@ -102,6 +102,7 @@ public void sendFailsAfterComplete() throws Exception {
public void sendAfterHandlerInitialized() throws Exception {
this.emitter.initialize(this.handler);
verify(this.handler).onTimeout(any());
+ verify(this.handler).onError(any());
verify(this.handler).onCompletion(any());
verifyNoM... | true |
Other | spring-projects | spring-framework | e0678ba5835eb6f0a8d8b3ac344c8728102c4a4d.json | Add onError callback to DeferredResult
Issue: SPR-15614 | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/SseEmitterTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2015 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -18,6 +18,7 @@
import java.io.IOException;
... | true |
Other | spring-projects | spring-framework | 83beb9d57d558d1386c194b7792c88134105dfa4.json | Set MockSessionCookieConfig#maxAge default to -1
Issue: SPR-15142 | spring-test/src/main/java/org/springframework/mock/web/MockSessionCookieConfig.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2013 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -39,7 +39,7 @@ public class MockSessionCooki... | true |
Other | spring-projects | spring-framework | 83beb9d57d558d1386c194b7792c88134105dfa4.json | Set MockSessionCookieConfig#maxAge default to -1
Issue: SPR-15142 | spring-web/src/test/java/org/springframework/mock/web/test/MockSessionCookieConfig.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2013 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -39,7 +39,7 @@ public class MockSessionCooki... | true |
Other | spring-projects | spring-framework | d724644588b77e807ce16b13ae3cd36208807055.json | Expose WebSession on ServerRequest
This commit exposes the WebSession on ServerRequest. | spring-web-reactive/src/main/java/org/springframework/web/reactive/function/server/DefaultServerRequest.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -40,6 +40,7 @@
import org.springframework.w... | true |
Other | spring-projects | spring-framework | d724644588b77e807ce16b13ae3cd36208807055.json | Expose WebSession on ServerRequest
This commit exposes the WebSession on ServerRequest. | spring-web-reactive/src/main/java/org/springframework/web/reactive/function/server/RequestPredicates.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -35,6 +35,7 @@
import org.springframework.u... | true |
Other | spring-projects | spring-framework | d724644588b77e807ce16b13ae3cd36208807055.json | Expose WebSession on ServerRequest
This commit exposes the WebSession on ServerRequest. | spring-web-reactive/src/main/java/org/springframework/web/reactive/function/server/ServerRequest.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -34,6 +34,7 @@
import org.springframework.h... | true |
Other | spring-projects | spring-framework | d724644588b77e807ce16b13ae3cd36208807055.json | Expose WebSession on ServerRequest
This commit exposes the WebSession on ServerRequest. | spring-web-reactive/src/main/java/org/springframework/web/reactive/function/server/support/ServerRequestWrapper.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -36,6 +36,7 @@
import org.springframework.w... | true |
Other | spring-projects | spring-framework | d724644588b77e807ce16b13ae3cd36208807055.json | Expose WebSession on ServerRequest
This commit exposes the WebSession on ServerRequest. | spring-web-reactive/src/test/java/org/springframework/web/reactive/function/server/DefaultServerRequestTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -48,6 +48,7 @@
import org.springframework.u... | true |
Other | spring-projects | spring-framework | d724644588b77e807ce16b13ae3cd36208807055.json | Expose WebSession on ServerRequest
This commit exposes the WebSession on ServerRequest. | spring-web-reactive/src/test/java/org/springframework/web/reactive/function/server/MockServerRequest.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -41,6 +41,7 @@
import org.springframework.u... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-beans/src/main/kotlin/org/springframework/beans/factory/BeanFactoryExtension.kt | @@ -1,47 +0,0 @@
-package org.springframework.beans.factory
-
-import kotlin.reflect.KClass
-
-/**
- * Extension for [BeanFactory] providing [KClass] based API.
- *
- * @author Sebastien Deleuze
- * @since 5.0
- */
-object BeanFactoryExtension {
-
- /**
- * @see BeanFactory.getBean(Class<T>)
- */
- fun <T : Any> Bean... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-beans/src/main/kotlin/org/springframework/beans/factory/BeanFactoryExtensions.kt | @@ -0,0 +1,60 @@
+package org.springframework.beans.factory
+
+import kotlin.reflect.KClass
+
+
+/**
+ * Extension for [BeanFactory.getBean] providing a [KClass] based variant.
+ *
+ * @author Sebastien Deleuze
+ * @since 5.0
+ */
+fun <T : Any> BeanFactory.getBean(requiredType: KClass<T>) = getBean(requiredType.java)
... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-beans/src/main/kotlin/org/springframework/beans/factory/ListableBeanFactoryExtension.kt | @@ -1,75 +0,0 @@
-package org.springframework.beans.factory
-
-import kotlin.reflect.KClass
-
-/**
- * Extension for [ListableBeanFactory] providing [KClass] based API.
- *
- * @author Sebastien Deleuze
- * @since 5.0
- */
-object ListableBeanFactoryExtension {
-
- /**
- * @see ListableBeanFactory.getBeanNamesForType(... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-beans/src/main/kotlin/org/springframework/beans/factory/ListableBeanFactoryExtensions.kt | @@ -0,0 +1,97 @@
+package org.springframework.beans.factory
+
+import kotlin.reflect.KClass
+
+
+/**
+ * Extension for [ListableBeanFactory.getBeanNamesForType] providing a [KClass] based variant.
+ *
+ * @author Sebastien Deleuze
+ * @since 5.0
+ */
+fun <T : Any> ListableBeanFactory.getBeanNamesForType(type: KClass<T... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-context/src/main/kotlin/org/springframework/context/annotation/AnnotationConfigApplicationContextExtension.kt | @@ -1,14 +0,0 @@
-package org.springframework.context.annotation
-
-/**
- * Extension for [AnnotationConfigApplicationContext] providing
- * `AnnotationConfigApplicationContext { }` style initialization.
- *
- * @author Sebastien Deleuze
- * @since 5.0
- */
-object AnnotationConfigApplicationContextExtension {
-
- f... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-context/src/main/kotlin/org/springframework/context/annotation/AnnotationConfigApplicationContextExtensions.kt | @@ -0,0 +1,11 @@
+package org.springframework.context.annotation
+
+/**
+ * Extension for [AnnotationConfigApplicationContext] allowing
+ * `AnnotationConfigApplicationContext { ... }` style initialization.
+ *
+ * @author Sebastien Deleuze
+ * @since 5.0
+ */
+fun AnnotationConfigApplicationContext(configure: Annotati... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-context/src/main/kotlin/org/springframework/context/support/GenericApplicationContextExtension.kt | @@ -1,65 +0,0 @@
-package org.springframework.context.support
-
-import org.springframework.beans.factory.config.BeanDefinitionCustomizer
-import org.springframework.context.ApplicationContext
-import java.util.function.Supplier
-import kotlin.reflect.KClass
-
-/**
- * Extension for [GenericApplicationContext] providin... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-context/src/main/kotlin/org/springframework/context/support/GenericApplicationContextExtensions.kt | @@ -0,0 +1,80 @@
+package org.springframework.context.support
+
+import org.springframework.beans.factory.config.BeanDefinitionCustomizer
+import org.springframework.context.ApplicationContext
+import java.util.function.Supplier
+import kotlin.reflect.KClass
+
+
+/**
+ * Extension for [GenericApplicationContext.registe... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-context/src/main/kotlin/org/springframework/ui/ModelExtensions.kt | @@ -17,22 +17,15 @@
package org.springframework.ui
/**
- * Extension for [Model] providing idiomatic Kotlin API
+ * Extension for [Model.addAttribute] providing Array like setter.
+ *
+ * ```kotlin
+ * model["firstName"] = "Mario"
+ * ```
*
* @author Mario Arias
* @since 5.0
*/
-object ModelExtension {
-
- ... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-context/src/main/kotlin/org/springframework/ui/ModelMapExtensions.kt | @@ -17,22 +17,16 @@
package org.springframework.ui
/**
- * Extension for [ModelMap] providing idiomatic Kotlin API
+ *
+ * Extension for [ModelMap] providing Array like setter.
+ *
+ * ```kotlin
+ * model["firstName"] = "Mario"
+ * ```
*
* @author Mario Arias
* @since 5.0
*/
-object ModelMapExtension {
-
- ... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-context/src/test/kotlin/org/springframework/context/support/GenericApplicationContextExtensionsTests.kt | @@ -2,11 +2,9 @@ package org.springframework.context.support
import org.junit.Assert.assertNotNull
import org.junit.Test
-import org.springframework.context.support.GenericApplicationContextExtension.registerBean
-import org.springframework.beans.factory.BeanFactoryExtension.getBean
-import org.springframework.cont... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-context/src/test/kotlin/org/springframework/ui/ModelExtensionsTests.kt | @@ -19,10 +19,9 @@ package org.springframework.ui
import org.junit.Assert.assertEquals
import org.junit.Assert.assertTrue
import org.junit.Test
-import org.springframework.ui.ModelExtension.set
-class ModelExtensionTests {
+class ModelExtensionsTests {
@Test
fun setAttribute() { | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-context/src/test/kotlin/org/springframework/ui/ModelMapExtensionsTests.kt | @@ -19,10 +19,9 @@ package org.springframework.ui
import org.junit.Assert.assertEquals
import org.junit.Assert.assertTrue
import org.junit.Test
-import org.springframework.ui.ModelMapExtension.set
-class ModelMapExtensionTests {
+class ModelMapExtensionsTests {
@Test
fun setAttribute() { | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-web-reactive/src/main/kotlin/org/springframework/web/reactive/function/BodyExtractorsExtension.kt | @@ -1,40 +0,0 @@
-package org.springframework.web.reactive.function
-
-import org.springframework.http.ReactiveHttpInputMessage
-import reactor.core.publisher.Flux
-import reactor.core.publisher.Mono
-import kotlin.reflect.KClass
-
-/**
- * Extension for [BodyExtactors] providing [KClass] based API and avoiding specify... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-web-reactive/src/main/kotlin/org/springframework/web/reactive/function/BodyExtractorsExtensions.kt | @@ -0,0 +1,42 @@
+package org.springframework.web.reactive.function
+
+import org.springframework.http.ReactiveHttpInputMessage
+import reactor.core.publisher.Flux
+import reactor.core.publisher.Mono
+import kotlin.reflect.KClass
+
+/**
+ * Function for providing a `toMono()` alternative to `BodyExtractors.toMono(Foo::... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-web-reactive/src/main/kotlin/org/springframework/web/reactive/function/BodyInsertersExtension.kt | @@ -1,27 +0,0 @@
-package org.springframework.web.reactive.function
-
-import org.reactivestreams.Publisher
-import org.springframework.http.ReactiveHttpOutputMessage
-import org.springframework.http.server.reactive.ServerHttpResponse
-
-/**
- * Extension for [BodyInserters] providing [KClass] based API and avoiding sp... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-web-reactive/src/main/kotlin/org/springframework/web/reactive/function/BodyInsertersExtensions.kt | @@ -0,0 +1,23 @@
+package org.springframework.web.reactive.function
+
+import org.reactivestreams.Publisher
+import org.springframework.http.ReactiveHttpOutputMessage
+import org.springframework.http.server.reactive.ServerHttpResponse
+
+/**
+ * Function for providing a `fromPublisher(publisher)` alternative to `BodyIn... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-web-reactive/src/main/kotlin/org/springframework/web/reactive/function/client/ClientResponseExtension.kt | @@ -1,24 +0,0 @@
-package org.springframework.web.reactive.function.client
-
-import reactor.core.publisher.Flux
-import reactor.core.publisher.Mono
-import kotlin.reflect.KClass
-
-/**
- * Extension for [ClientResponse] providing [KClass] based API.
- *
- * @author Sebastien Deleuze
- * @since 5.0
- */
-object ClientR... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-web-reactive/src/main/kotlin/org/springframework/web/reactive/function/client/ClientResponseExtensions.kt | @@ -0,0 +1,24 @@
+package org.springframework.web.reactive.function.client
+
+import reactor.core.publisher.Flux
+import reactor.core.publisher.Mono
+import kotlin.reflect.KClass
+
+
+/**
+ * Extension for [ClientResponse.bodyToMono] providing a [KClass] based variant.
+ *
+ * @author Sebastien Deleuze
+ * @since 5.0
+... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-web-reactive/src/main/kotlin/org/springframework/web/reactive/function/server/ServerRequestExtension.kt | @@ -1,22 +0,0 @@
-package org.springframework.web.reactive.function.server
-
-import kotlin.reflect.KClass
-
-/**
- * Extension for [ServerRequest] providing [KClass] based API.
- *
- * @author Sebastien Deleuze
- * @since 5.0
- */
-object ServerRequestExtension {
-
- /**
- * @see ServerRequest.bodyToMono
- */
- fun ... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-web-reactive/src/main/kotlin/org/springframework/web/reactive/function/server/ServerRequestExtensions.kt | @@ -0,0 +1,20 @@
+package org.springframework.web.reactive.function.server
+
+import kotlin.reflect.KClass
+
+
+/**
+ * Extension for [ServerRequest.bodyToMono] providing a [KClass] based variant.
+ *
+ * @author Sebastien Deleuze
+ * @since 5.0
+ */
+fun <T : Any> ServerRequest.bodyToMono(type: KClass<T>) = bodyToMono... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-web/src/main/kotlin/org/springframework/web/client/RestOperationsExtension.kt | @@ -1,116 +0,0 @@
-package org.springframework.web.client
-
-import org.springframework.http.HttpEntity
-import org.springframework.http.HttpMethod
-import org.springframework.http.RequestEntity
-import java.net.URI
-
-/**
- * Extension for [RestOperations] providing [KClass] based API and avoiding specifying
- * a cla... | true |
Other | spring-projects | spring-framework | 0a988fd2b1c7e2d98e87df3842c4fc053acac9a5.json | Remove object wrappers in Kotlin extensions
This commit also improve significantly Kotlin extensions
documentation.
Issue: SPR-15127 | spring-web/src/main/kotlin/org/springframework/web/client/RestOperationsExtensions.kt | @@ -0,0 +1,159 @@
+package org.springframework.web.client
+
+import org.springframework.http.HttpEntity
+import org.springframework.http.HttpMethod
+import org.springframework.http.RequestEntity
+import java.net.URI
+
+
+/**
+ * Extension for [RestOperations.getForObject] avoiding specifying thanks to Kotlin reified ty... | true |
Other | spring-projects | spring-framework | 1af905ca0a97c1e19a60e63a1d62469888fbb12a.json | Add Model and ModelMap Kotlin extensions
Issue: SPR-15119 | spring-context/src/main/kotlin/org/springframework/ui/ModelExtension.kt | @@ -0,0 +1,38 @@
+/*
+ * Copyright 2002-2017 the original author or authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *... | true |
Other | spring-projects | spring-framework | 1af905ca0a97c1e19a60e63a1d62469888fbb12a.json | Add Model and ModelMap Kotlin extensions
Issue: SPR-15119 | spring-context/src/main/kotlin/org/springframework/ui/ModelMapExtension.kt | @@ -0,0 +1,38 @@
+/*
+ * Copyright 2002-2017 the original author or authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *... | true |
Other | spring-projects | spring-framework | 1af905ca0a97c1e19a60e63a1d62469888fbb12a.json | Add Model and ModelMap Kotlin extensions
Issue: SPR-15119 | spring-context/src/test/kotlin/org/springframework/ui/ModelExtensionTests.kt | @@ -0,0 +1,34 @@
+/*
+ * Copyright 2002-2017 the original author or authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *... | true |
Other | spring-projects | spring-framework | 1af905ca0a97c1e19a60e63a1d62469888fbb12a.json | Add Model and ModelMap Kotlin extensions
Issue: SPR-15119 | spring-context/src/test/kotlin/org/springframework/ui/ModelMapExtensionTests.kt | @@ -0,0 +1,34 @@
+/*
+ * Copyright 2002-2017 the original author or authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *... | true |
Other | spring-projects | spring-framework | aa43472f2ea1f8aaffa65be917bc24603dc4d56c.json | Fix error handling in Jackson2JsonDecoder
Issue: SPR-15112 | spring-web/src/main/java/org/springframework/http/codec/json/Jackson2JsonDecoder.java | @@ -118,7 +118,7 @@ private Flux<Object> decodeInternal(JsonObjectDecoder objectDecoder, Publisher<D
return value;
}
catch (IOException ex) {
- return Flux.error(new CodecException("Error while reading the data", ex));
+ throw new CodecException("Error while reading the data", ex);
}
... | true |
Other | spring-projects | spring-framework | aa43472f2ea1f8aaffa65be917bc24603dc4d56c.json | Fix error handling in Jackson2JsonDecoder
Issue: SPR-15112 | spring-web/src/test/java/org/springframework/http/codec/json/Jackson2JsonDecoderTests.java | @@ -28,6 +28,7 @@
import reactor.test.StepVerifier;
import org.springframework.core.ResolvableType;
+import org.springframework.core.codec.CodecException;
import org.springframework.core.io.buffer.AbstractDataBufferAllocatingTestCase;
import org.springframework.core.io.buffer.DataBuffer;
import org.springframewo... | true |
Other | spring-projects | spring-framework | 87f498195c8d3a2685c04e9f204131e8b2be699b.json | Fix RequestUpgradeStrategy impl. class loading
Issue: SPR-15106 | spring-web-reactive/src/main/java/org/springframework/web/reactive/socket/server/support/HandshakeWebSocketService.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -123,7 +123,7 @@ else if (undertowPresent) {... | false |
Other | spring-projects | spring-framework | 83929b2b98e7a1f3d4ed5d6e3f5bcd499989110b.json | Improve performance of StringUtils.capitalize()
Issue: SPR-15094 | spring-core/src/main/java/org/springframework/util/StringUtils.java | @@ -516,15 +516,22 @@ private static String changeFirstCharacterCase(String str, boolean capitalize) {
if (str == null || str.length() == 0) {
return str;
}
- StringBuilder sb = new StringBuilder(str.length());
- if (capitalize) {
- sb.append(Character.toUpperCase(str.charAt(0)));
- }
else {
- sb.ap... | false |
Other | spring-projects | spring-framework | 19e77cd140d6efd2736a43b8688a8a3ffb6f2a7b.json | Remove use of Boolean constructors
Codacy warns us that there are several references to Boolean
constructors in the tests. Direct usage of the Boolean constructor is
discouraged and even deprecated in Java 9 [1]. Boolean constructor use
can easily be replaced with the constant instances.
This commit contains the foll... | spring-webmvc/src/test/java/org/springframework/web/servlet/tags/form/CheckboxTagTests.java | @@ -164,7 +164,7 @@ public void withSingleValueBooleanChecked() throws Exception {
@Test
public void withSingleValueBooleanObjectUnchecked() throws Exception {
- this.bean.setSomeBoolean(new Boolean(false));
+ this.bean.setSomeBoolean(Boolean.FALSE);
this.tag.setPath("someBoolean");
int result = this.tag.... | true |
Other | spring-projects | spring-framework | 19e77cd140d6efd2736a43b8688a8a3ffb6f2a7b.json | Remove use of Boolean constructors
Codacy warns us that there are several references to Boolean
constructors in the tests. Direct usage of the Boolean constructor is
discouraged and even deprecated in Java 9 [1]. Boolean constructor use
can easily be replaced with the constant instances.
This commit contains the foll... | spring-webmvc/src/test/java/org/springframework/web/servlet/tags/form/CheckboxesTagTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2015 the original author or authors.
+ * Copyright 2002-2016 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -773,7 +773,7 @@ protected TestBean createTe... | true |
Other | spring-projects | spring-framework | 19e77cd140d6efd2736a43b8688a8a3ffb6f2a7b.json | Remove use of Boolean constructors
Codacy warns us that there are several references to Boolean
constructors in the tests. Direct usage of the Boolean constructor is
discouraged and even deprecated in Java 9 [1]. Boolean constructor use
can easily be replaced with the constant instances.
This commit contains the foll... | spring-webmvc/src/test/java/org/springframework/web/servlet/tags/form/RadioButtonsTagTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2015 the original author or authors.
+ * Copyright 2002-2016 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -620,7 +620,7 @@ protected TestBean createTe... | true |
Other | spring-projects | spring-framework | 3f97ab183e08ee0001ee98b9614770dad8d29155.json | Avoid use of double constructor of BigDecimal
Codacy warns about an Error Prone [1] use of the double constructor of
BigDecimal in tests. The reason given is that it is a source of
precision loss if the number does not have an exact double
representation. The recommendation is to use the String constructor of
BigDecim... | spring-jdbc/src/test/java/org/springframework/jdbc/core/JdbcTemplateQueryTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2015 the original author or authors.
+ * Copyright 2002-2016 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -197,8 +197,8 @@ public void testQueryForObj... | false |
Other | spring-projects | spring-framework | 276cfd8993dc7d97995d324a14806ea16547f832.json | Fix Jdiff generation with Java8 | gradle/jdiff.gradle | @@ -43,6 +43,7 @@ task jdiff {
ant.mkdir(dir: outputDir)
ant.jdiff(
destdir: outputDir,
+ source: "1.8",
verbose: "off",
stats: "on",
docchanges: "off") { | false |
Other | spring-projects | spring-framework | 85a4e5065d821b088343a3b6a05f210fffd0aa94.json | Add log4j2 config to spring-web-reactiv | spring-web-reactive/src/test/resources/log4j.properties | @@ -1,9 +0,0 @@
-log4j.rootCategory=WARN, stdout
-
-log4j.logger.org.springframework.http=DEBUG
-log4j.logger.org.springframework.web=DEBUG
-log4j.logger.reactor=INFO
-
-log4j.appender.stdout=org.apache.log4j.ConsoleAppender
-log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
-log4j.appender.stdout.layout.Conv... | true |
Other | spring-projects | spring-framework | 85a4e5065d821b088343a3b6a05f210fffd0aa94.json | Add log4j2 config to spring-web-reactiv | spring-web-reactive/src/test/resources/log4j2-test.xml | @@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<Configuration status="WARN">
+ <Appenders>
+ <Console name="Console" target="SYSTEM_OUT">
+ <PatternLayout pattern="%d{HH:mm:ss.SSS} [%t] %-5level %logger{36} - %msg%n" />
+ </Console>
+ </Appenders>
+ <Loggers>
+ <Logger name="org.springframework.http" le... | true |
Other | spring-projects | spring-framework | 85b0ce1ef78ea0aa795e80821e206cc851c9894b.json | Avoid defensive checks against java.time API
Issue: SPR-13188 | spring-beans/src/main/java/org/springframework/beans/PropertyEditorRegistrySupport.java | @@ -26,6 +26,7 @@
import java.net.URL;
import java.nio.charset.Charset;
import java.nio.file.Path;
+import java.time.ZoneId;
import java.util.Collection;
import java.util.Currency;
import java.util.HashMap;
@@ -89,19 +90,6 @@
*/
public class PropertyEditorRegistrySupport implements PropertyEditorRegistry {
-... | true |
Other | spring-projects | spring-framework | 85b0ce1ef78ea0aa795e80821e206cc851c9894b.json | Avoid defensive checks against java.time API
Issue: SPR-13188 | spring-context/src/main/java/org/springframework/format/support/DefaultFormattingConversionService.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2015 the original author or authors.
+ * Copyright 2002-2016 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -21,10 +21,10 @@
import org.springframework... | true |
Other | spring-projects | spring-framework | 85b0ce1ef78ea0aa795e80821e206cc851c9894b.json | Avoid defensive checks against java.time API
Issue: SPR-13188 | spring-core/src/main/java/org/springframework/core/convert/support/DefaultConversionService.java | @@ -23,7 +23,6 @@
import org.springframework.core.convert.ConversionService;
import org.springframework.core.convert.converter.ConverterRegistry;
-import org.springframework.util.ClassUtils;
/**
* A specialization of {@link GenericConversionService} configured by default with
@@ -40,11 +39,6 @@
*/
public cl... | true |
Other | spring-projects | spring-framework | 85b0ce1ef78ea0aa795e80821e206cc851c9894b.json | Avoid defensive checks against java.time API
Issue: SPR-13188 | spring-web/src/main/java/org/springframework/http/converter/json/Jackson2ObjectMapperBuilder.java | @@ -753,16 +753,13 @@ private void registerWellKnownModulesIfAvailable(ObjectMapper objectMapper) {
// jackson-datatype-jdk8 not available
}
- // Java 8 java.time package present?
- if (ClassUtils.isPresent("java.time.LocalDate", this.moduleClassLoader)) {
- try {
- Class<? extends Module> javaTimeModul... | true |
Other | spring-projects | spring-framework | 85b0ce1ef78ea0aa795e80821e206cc851c9894b.json | Avoid defensive checks against java.time API
Issue: SPR-13188 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/ServletRequestMethodArgumentResolver.java | @@ -70,7 +70,7 @@ public boolean supportsParameter(MethodParameter parameter) {
Principal.class.isAssignableFrom(paramType) ||
Locale.class == paramType ||
TimeZone.class == paramType ||
- "java.time.ZoneId".equals(paramType.getName()) ||
+ ZoneId.class == paramType ||
InputStream.class.isAssi... | true |
Other | spring-projects | spring-framework | 7f4904ed22208028e9c47e3ee4802ab94186fbaa.json | Avoid deprecated Mockito methods
Issue: SPR-14880 | spring-beans/src/test/java/org/springframework/beans/factory/DefaultListableBeanFactoryTests.java | @@ -2706,13 +2706,13 @@ public void resolveEmbeddedValue() {
bf.addEmbeddedValueResolver(r3);
given(r1.resolveStringValue("A")).willReturn("B");
given(r2.resolveStringValue("B")).willReturn(null);
- given(r3.resolveStringValue(isNull(String.class))).willThrow(new IllegalArgumentException());
+ given(r3.resol... | true |
Other | spring-projects | spring-framework | 7f4904ed22208028e9c47e3ee4802ab94186fbaa.json | Avoid deprecated Mockito methods
Issue: SPR-14880 | spring-context/src/test/java/org/springframework/context/event/ApplicationListenerMethodAdapterTests.java | @@ -50,52 +50,48 @@ public class ApplicationListenerMethodAdapterTests extends AbstractApplicationEv
private final ApplicationContext context = mock(ApplicationContext.class);
+
@Test
public void rawListener() {
- Method method = ReflectionUtils.findMethod(SampleEvents.class,
- "handleRaw", ApplicationEve... | true |
Other | spring-projects | spring-framework | ac774cdcef7b25878f075d7e3514c373880eacac.json | Avoid deprecated Mockito methods
Issue: SPR-14880 | spring-context/src/test/java/org/springframework/context/annotation/ImportSelectorTests.java | @@ -71,10 +71,10 @@ public void importSelectors() {
context.refresh();
context.getBean(Config.class);
InOrder ordered = inOrder(beanFactory);
- ordered.verify(beanFactory).registerBeanDefinition(eq("a"), (BeanDefinition) anyObject());
- ordered.verify(beanFactory).registerBeanDefinition(eq("b"), (BeanDefinit... | true |
Other | spring-projects | spring-framework | ac774cdcef7b25878f075d7e3514c373880eacac.json | Avoid deprecated Mockito methods
Issue: SPR-14880 | spring-core/src/test/java/org/springframework/core/ResolvableTypeTests.java | @@ -855,7 +855,7 @@ public void resolveTypeWithCustomVariableResolver() throws Exception {
VariableResolver variableResolver = mock(VariableResolver.class);
given(variableResolver.getSource()).willReturn(this);
ResolvableType longType = ResolvableType.forClass(Long.class);
- given(variableResolver.resolveVari... | true |
Other | spring-projects | spring-framework | ac774cdcef7b25878f075d7e3514c373880eacac.json | Avoid deprecated Mockito methods
Issue: SPR-14880 | spring-jms/src/test/java/org/springframework/jms/core/JmsMessagingTemplateTests.java | @@ -353,21 +353,21 @@ public void sendAndReceive() {
Destination destination = new Destination() {};
Message<String> request = createTextMessage();
javax.jms.Message replyJmsMessage = createJmsTextMessage();
- given(jmsTemplate.sendAndReceive(eq(destination), anyObject())).willReturn(replyJmsMessage);
+ give... | true |
Other | spring-projects | spring-framework | ac774cdcef7b25878f075d7e3514c373880eacac.json | Avoid deprecated Mockito methods
Issue: SPR-14880 | spring-messaging/src/test/java/org/springframework/messaging/simp/stomp/DefaultStompSessionTests.java | @@ -572,7 +572,7 @@ public void receiptNotReceived() throws Exception {
receiptable.addReceiptLostTask(() -> notReceived.set(true));
ArgumentCaptor<Runnable> taskCaptor = ArgumentCaptor.forClass(Runnable.class);
- verify(taskScheduler).schedule(taskCaptor.capture(), notNull(Date.class));
+ verify(taskSchedule... | true |
Other | spring-projects | spring-framework | ac774cdcef7b25878f075d7e3514c373880eacac.json | Avoid deprecated Mockito methods
Issue: SPR-14880 | spring-web/src/test/java/org/springframework/http/converter/protobuf/ProtobufHttpMessageConverterTests.java | @@ -55,7 +55,7 @@ public void setUp() {
@Test
public void extensionRegistryInitialized() {
- verify(this.registryInitializer, times(1)).initializeExtensionRegistry(anyObject());
+ verify(this.registryInitializer, times(1)).initializeExtensionRegistry(any());
}
@Test | true |
Other | spring-projects | spring-framework | ac774cdcef7b25878f075d7e3514c373880eacac.json | Avoid deprecated Mockito methods
Issue: SPR-14880 | spring-web/src/test/java/org/springframework/web/method/annotation/ModelAttributeMethodProcessorTests.java | @@ -148,10 +148,10 @@ public void resolveArgumentFromModel() throws Exception {
public void resovleArgumentViaDefaultConstructor() throws Exception {
WebDataBinder dataBinder = new WebRequestDataBinder(null);
WebDataBinderFactory factory = mock(WebDataBinderFactory.class);
- given(factory.createBinder(anyObjec... | true |
Other | spring-projects | spring-framework | ac774cdcef7b25878f075d7e3514c373880eacac.json | Avoid deprecated Mockito methods
Issue: SPR-14880 | spring-websocket/src/test/java/org/springframework/web/socket/messaging/WebSocketStompClientTests.java | @@ -56,21 +56,22 @@
*/
public class WebSocketStompClientTests {
- private TestWebSocketStompClient stompClient;
-
@Mock
private TaskScheduler taskScheduler;
@Mock
private ConnectionHandlingStompSession stompSession;
+ @Mock
+ private WebSocketSession webSocketSession;
+
+
+ private TestWebSocketStompCl... | true |
Other | spring-projects | spring-framework | 475b876f08349b70e066719e5ae7437db96ad255.json | Add ResponseEntity test | spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/ResponseEntityResultHandlerTests.java | @@ -289,6 +289,23 @@ public void handleMonoWithWildcardBodyType() throws Exception {
assertResponseBody("\"body\"");
}
+ @Test // SPR-14877
+ public void handleMonoWithWildcardBodyTypeAndNullBody() throws Exception {
+
+ this.exchange.getAttributes().put(HandlerMapping.PRODUCIBLE_MEDIA_TYPES_ATTRIBUTE,
+ Col... | false |
Other | spring-projects | spring-framework | c43040287253bda3e9710759eb722fb54c1e9cc0.json | Improve support for Mono<ResponseEntity<?>>
If the body class is not resolvable from the return type and there is
a body instance we now fall back on the class of the body instance.
Issue: SPR-14877 | spring-web-reactive/src/main/java/org/springframework/web/reactive/result/AbstractHandlerResultHandler.java | @@ -22,6 +22,7 @@
import java.util.List;
import java.util.Optional;
import java.util.Set;
+import java.util.function.Supplier;
import org.springframework.core.MethodParameter;
import org.springframework.core.Ordered;
@@ -101,13 +102,14 @@ public int getOrder() {
* Select the best media type for the current re... | true |
Other | spring-projects | spring-framework | c43040287253bda3e9710759eb722fb54c1e9cc0.json | Improve support for Mono<ResponseEntity<?>>
If the body class is not resolvable from the return type and there is
a body instance we now fall back on the class of the body instance.
Issue: SPR-14877 | spring-web-reactive/src/main/java/org/springframework/web/reactive/result/method/annotation/AbstractMessageWriterResultHandler.java | @@ -93,50 +93,51 @@ public List<HttpMessageWriter<?>> getMessageWriters() {
@SuppressWarnings("unchecked")
protected Mono<Void> writeBody(Object body, MethodParameter bodyParameter, ServerWebExchange exchange) {
- ResolvableType bodyType = ResolvableType.forMethodParameter(bodyParameter);
- ReactiveAdapter adap... | true |
Other | spring-projects | spring-framework | c43040287253bda3e9710759eb722fb54c1e9cc0.json | Improve support for Mono<ResponseEntity<?>>
If the body class is not resolvable from the return type and there is
a body instance we now fall back on the class of the body instance.
Issue: SPR-14877 | spring-web-reactive/src/main/java/org/springframework/web/reactive/result/view/ViewResolutionResultHandler.java | @@ -319,7 +319,7 @@ private Mono<? extends Void> resolveAndRender(String viewName, Locale locale,
views.addAll(getDefaultViews());
List<MediaType> producibleTypes = getProducibleMediaTypes(views);
- MediaType bestMediaType = selectMediaType(exchange, producibleTypes);
+ MediaType bestMediaType = s... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.