language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
laravel
framework
28b6f2e6c9490d4d55ccdeeb6dbd8352c15bfb28.json
Add implicit extensions to validator
tests/Validation/ValidationFactoryTest.php
@@ -22,9 +22,10 @@ public function testMakeMethodCreatesValidValidator() $presence = m::mock('Illuminate\Validation\PresenceVerifierInterface'); $factory->extend('foo', function() {}); + $factory->extendImplicit('implicit', function() {}); $factory->setPresenceVerifier($presence); $validator = $factory->...
true
Other
laravel
framework
28b6f2e6c9490d4d55ccdeeb6dbd8352c15bfb28.json
Add implicit extensions to validator
tests/Validation/ValidationValidatorTest.php
@@ -623,6 +623,15 @@ public function testCustomValidators() } + public function testCustomImplicitValidators() + { + $trans = $this->getRealTranslator(); + $v = new Validator($trans, array(), array('implicit_rule' => 'foo')); + $v->addImplicitExtension('implicit_rule', function() { return true; }); + $this->a...
true
Other
laravel
framework
a98ad9d4610e27bd7bf243a026a696f60647a394.json
fix bug in sqlite truncate.
src/Illuminate/Database/Query/Grammars/SQLiteGrammar.php
@@ -74,11 +74,9 @@ public function compileInsert(Builder $query, array $values) */ public function compileTruncate(Builder $query) { - $table = $this->wrapTable($query->from); - - $sql = array('delete from sqlite_sequence where name = ?' => array($table)); + $sql = array('delete from sqlite_sequence where nam...
true
Other
laravel
framework
a98ad9d4610e27bd7bf243a026a696f60647a394.json
fix bug in sqlite truncate.
tests/Database/DatabaseQueryBuilderTest.php
@@ -522,7 +522,7 @@ public function testTruncateMethod() $builder = $this->getBuilder(); $builder->from('users'); $this->assertEquals(array( - 'delete from sqlite_sequence where name = ?' => array('"users"'), + 'delete from sqlite_sequence where name = ?' => array('users'), 'delete from "users"' => arr...
true
Other
laravel
framework
6c3e34b7e64b4757c827d10323f55c1a4f4b0ced.json
fix argument order passing to url generator.
src/Illuminate/Routing/Redirector.php
@@ -55,7 +55,7 @@ public function back($status = 302, $headers = array()) */ public function to($path, $status = 302, $headers = array(), $secure = false) { - $path = $this->generator->to($path, $secure); + $path = $this->generator->to($path, array(), $secure); return $this->createRedirect($path, $status,...
false
Other
laravel
framework
69a1f9616f55de439dca3800ed544861dbaf40e4.json
Fix foreach order.
src/Illuminate/Routing/Router.php
@@ -202,7 +202,7 @@ public function any($pattern, $action) */ public function controllers(array $controllers) { - foreach ($controllers as $name => $uri) + foreach ($controllers as $uri => $name) { $this->controller($uri, $name); }
false
Other
laravel
framework
2c1ccba4864f017f3a473f52a3957eefe5f50982.json
Fix parameter order on Route::controllers.
src/Illuminate/Routing/Router.php
@@ -204,7 +204,7 @@ public function controllers(array $controllers) { foreach ($controllers as $name => $uri) { - $this->controller($name, $uri); + $this->controller($uri, $name); } }
false
Other
laravel
framework
fc7943b495fdce550a85e1c24ef1b4efab26045f.json
use setFrom instead of addFrom.
src/Illuminate/Mail/Message.php
@@ -33,7 +33,7 @@ public function __construct($swift) */ public function from($address, $name = null) { - $this->swift->addFrom($address, $name); + $this->swift->setFrom($address, $name); return $this; }
false
Other
laravel
framework
24a3fc8ccf7d6839e42f5f509e413bbcde8ac06b.json
fix bug in wincache driver.
src/Illuminate/Cache/WinCacheStore.php
@@ -46,7 +46,7 @@ protected function retrieveItem($key) */ protected function storeItem($key, $value, $minutes) { - wincache_ucache_add($this->prefix.$key, value, $minutes * 60); + wincache_ucache_add($this->prefix.$key, $value, $minutes * 60); } /**
false
Other
laravel
framework
04308b7c4435d96f05822f76b1d652ca565c9783.json
throw notfoundhttpexception on app::abort(404)
src/Illuminate/Foundation/Application.php
@@ -485,7 +485,14 @@ public function setLocale($locale) */ public function abort($code, $message = '', array $headers = array()) { - throw new HttpException($code, $message, null, $headers); + if ($code == 404) + { + throw new NotFoundHttpException($message); + } + else + { + throw new HttpException($c...
false
Other
laravel
framework
b59741374d692934cfe86ca095296447bea96033.json
fix fallback locale.
src/Illuminate/Translation/Translator.php
@@ -3,6 +3,7 @@ use Illuminate\Support\NamespacedItemResolver; use Symfony\Component\Translation\Loader\ArrayLoader; use Symfony\Component\Translation\TranslatorInterface; +use Symfony\Component\Translation\Translator as SymfonyTranslator; class Translator extends NamespacedItemResolver implements TranslatorInter...
true
Other
laravel
framework
b59741374d692934cfe86ca095296447bea96033.json
fix fallback locale.
tests/Translation/TranslationTranslatorTest.php
@@ -56,9 +56,10 @@ public function testLoadMethodProperlyCallsLoaderToRetrieveItems() { $t = new Translator($loader = $this->getLoader(), 'en', 'sp'); $loader->shouldReceive('load')->once()->with('en', 'foo', 'bar')->andReturn(array('messages' => array('foo' => 'bar'))); + $loader->shouldReceive('load')->once(...
true
Other
laravel
framework
b6869eb887d8c4bc6f71b57f2dc7b91cef2cca49.json
allow generic custom rules on validator.
src/Illuminate/Validation/Validator.php
@@ -853,14 +853,14 @@ protected function getMessage($attribute, $rule) { $lowerRule = strtolower(snake_case($rule)); - $inlineKey = "{$attribute}.{$lowerRule}"; + $inlineMessage = $this->getInlineMessage($attribute, $lowerRule); // First we will retrieve the custom message for the validation rule if one ...
true
Other
laravel
framework
b6869eb887d8c4bc6f71b57f2dc7b91cef2cca49.json
allow generic custom rules on validator.
tests/Validation/ValidationValidatorTest.php
@@ -69,6 +69,12 @@ public function testInlineValidationMessagesAreRespected() $this->assertFalse($v->passes()); $v->messages()->setFormat(':message'); $this->assertEquals('require it please!', $v->messages()->first('name')); + + $trans = $this->getRealTranslator(); + $v = new Validator($trans, array('name' =...
true
Other
laravel
framework
37fc266596f17d0e1e55f93f6f4ec404018b0f8a.json
make translator parameters like L3.
src/Illuminate/Translation/Translator.php
@@ -88,6 +88,8 @@ public function get($key, $parameters = array(), $locale = null) { list($namespace, $group, $item) = $this->parseKey($key); + $parameters = $this->formatParameters($parameters); + // Once we call the "load" method, we will receive back the "domain" for the // namespace and group. The "do...
true
Other
laravel
framework
37fc266596f17d0e1e55f93f6f4ec404018b0f8a.json
make translator parameters like L3.
tests/Translation/TranslationTranslatorTest.php
@@ -35,9 +35,9 @@ public function testGetMethodProperlyLoadsAndRetrievesItem() $t = $this->getMock('Illuminate\Translation\Translator', array('load', 'trans'), array($this->getLoader(), 'en', 'sp')); $t->expects($this->once())->method('load')->with($this->equalTo('bar'), $this->equalTo('foo'), $this->equalTo('en'...
true
Other
laravel
framework
60f26afc13d943b5a2ae546307224c8178c41005.json
allow multi-line echos.
src/Illuminate/View/Compilers/BladeCompiler.php
@@ -146,7 +146,7 @@ protected function compileComments($value) */ protected function compileEchos($value) { - return preg_replace('/\{\{\s*(.+?)\s*\}\}/', '<?php echo $1; ?>', $value); + return preg_replace('/\{\{\s*(.+?)\s*\}\}/s', '<?php echo $1; ?>', $value); } /**
false
Other
laravel
framework
7670d5c9462d5a34295cc5967b0d420cb7a5e6a0.json
allow trailing slashes.
src/Illuminate/Routing/Router.php
@@ -667,7 +667,7 @@ protected function findRoute(Request $request) // that's used by the Illuminate foundation framework for responses. try { - $path = '/'.ltrim($request->getPathInfo(), '/'); + $path = $this->formatRequestPath($request); $parameters = $this->getUrlMatcher($request)->match($path); ...
true
Other
laravel
framework
7670d5c9462d5a34295cc5967b0d420cb7a5e6a0.json
allow trailing slashes.
tests/Routing/RoutingTest.php
@@ -17,19 +17,15 @@ public function testBasic() $router = new Router; $router->get('/', function() { return 'root'; }); $router->get('/foo', function() { return 'bar'; }); - $router->get('/foo//', function() { return 'foo'; }); $request = Request::create('/foo', 'GET'); $this->assertEquals('bar', $route...
true
Other
mrdoob
three.js
f618a57397feca711b6749635fc99b0f7c65e8d0.json
add dark mode support to index.css
threejs/lessons/resources/index.css
@@ -42,3 +42,9 @@ iframe.background { padding: 15px 20px; } } + +@media (prefers-color-scheme: dark) { + .container { + background-color: rgba(0, 0, 0, 0.9); + } +}
false
Other
mrdoob
three.js
a8c5a8ffce852b94a145b94ed041edd57a7bc131.json
remove unneeded css
threejs/lessons/resources/lesson.css
@@ -20,16 +20,10 @@ table { pre { background: rgb(143, 140, 140); padding: 1em; - line-height: 1; - background: #444; - overflow: auto; } pre>code { white-space: inherit; background: none; - font-size: 10pt; - padding: none; - color: #99e4fd; } pre.prettyprint { margin-top: 2em !important;
false
Other
mrdoob
three.js
519e74d868c5bb8b05e862ee811d67fb520f721f.json
fix build to add class to code blocks
build/js/build.js
@@ -400,6 +400,9 @@ const Builder = function(outBaseDir, options) { const info = extractHandlebars(content); let html = marked(info.content); // HACK! :-( + // There's probably a way to do this in marked + html = html.replace(/<pre><code/g, '<pre class="prettyprint"><code'); + // HACK! :-( ...
false
Other
mrdoob
three.js
2c9e8dd148c3d6fa1b7fe63fa7ac436ade632f15.json
use one canvas
threejs/lessons/threejs-canvas-textures.md
@@ -365,6 +365,40 @@ and we get labels where the text is centered and scaled to fit {{{example url="../threejs-canvas-textured-labels-scale-to-fit.html" }}} +Above we used a new canvas for each texture. Whether or not to use a +canvas per texture is up to you. If you need to up them often then +having one canvas...
true
Other
mrdoob
three.js
2c9e8dd148c3d6fa1b7fe63fa7ac436ade632f15.json
use one canvas
threejs/threejs-canvas-textured-labels-one-canvas.html
@@ -0,0 +1,186 @@ +<!-- Licensed under a BSD license. See license.html for license --> +<!DOCTYPE html> +<html> + <head> + <meta charset="utf-8"> + <meta name="viewport" content="width=device-width, initial-scale=1.0, user-scalable=yes"> + <title>Three.js - Canvas Textured Labels One Canvas</title> + <styl...
true
Other
mrdoob
three.js
6b1afd44966074033493bc65e3a036f718d045f8.json
change main page
build/templates/index.template
@@ -80,7 +80,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. </div> {{{content}}} <div> - 3d scene by: <a href="https://sketchfab.com/elsergio217">elsergio217</a> + flamingo by: <a href="http://mirada.com/">mirada</a> </div> </div> </div>
true
Other
mrdoob
three.js
6b1afd44966074033493bc65e3a036f718d045f8.json
change main page
threejs/background-v01.html
@@ -0,0 +1,193 @@ +<!-- Licensed under a BSD license. See license.html for license --> +<!DOCTYPE html> +<html> + <head> + <meta charset="utf-8"> + <meta name="viewport" content="width=device-width, initial-scale=1.0, user-scalable=yes"> + <title>Three.js - Fundamentals</title> + <link type="text/css" href...
true
Other
mrdoob
three.js
6b1afd44966074033493bc65e3a036f718d045f8.json
change main page
threejs/background.html
@@ -46,18 +46,19 @@ const near = 0.1; const far = 5000; const camera = new THREE.PerspectiveCamera(fov, aspect, near, far); - camera.position.x = -0.; - camera.position.y = 350; - camera.position.z = 40.; + camera.position.set(-580, 55, 390); + const maxFovX = 40; + const numBirds = 40; + const minMax...
true
Other
mrdoob
three.js
9d2c2e250371697fc0f8e1e14e71d5f0215571a0.json
add data license
threejs/lessons/threejs-indexed-textures.md
@@ -53,6 +53,9 @@ to generate such a texture. Here it is. <div class="threejs_center"><img src="../resources/data/world/country-index-texture.png" style="width: 700px;"></div> +Note: The data used to generate this texture comes from [this website](http://thematicmapping.org/downloads/world_borders.php) +and is th...
true
Other
mrdoob
three.js
9d2c2e250371697fc0f8e1e14e71d5f0215571a0.json
add data license
threejs/resources/data/world/license.md
@@ -0,0 +1,11 @@ +# CC-BY-SA + +All the data in this folder was generate from data from this website + +http://thematicmapping.org/downloads/world_borders.php + +The licence of that data is [CC-BY-SA](http://creativecommons.org/licenses/by-sa/3.0/). + +Which means this data is also [CC-BY-SA](http://creativecommons.org...
true
Other
mrdoob
three.js
bfda3c200408c6ea1165e5d93f83cdb9b8f6e045.json
remove unsued line
threejs/threejs-picking-gpu.html
@@ -165,7 +165,6 @@ 1, // height pixelBuffer); - //const id = this.idBuffer[0]; const id = (pixelBuffer[0] << 16) | (pixelBuffer[1] << 8) |
false
Other
mrdoob
three.js
e36b7bbd289ce1de56fd972be55d4f508b515b2c.json
fix image scaling
threejs/lessons/threejs-align-html-elements-to-3d.md
@@ -189,7 +189,7 @@ There are a couple of issues we probably want to deal with. One is that if we rotate the objects so they overlap all the labels overlap as well. -<img src="resources/images/overlapping-labels.png" class="threejs_center" style="width: 307px;"> +<div class="threejs_center"><img src="resources/imag...
false
Other
mrdoob
three.js
59726bae96775d035fb14bb05e902567741341dc.json
add lots of objects animated article
threejs/lessons/threejs-optimize-lots-of-objects-animated.md
@@ -0,0 +1,704 @@ +Title: Three.js Optimize Lots of Objects Animated +Description: Animated merged objects with Morphtargets + +This article is a continuation of [an article about optimizing lots of objects +](threejs-optimize-lots-of-objects.html). If you haven't read that +yet please read it before proceeding. + +In...
true
Other
mrdoob
three.js
59726bae96775d035fb14bb05e902567741341dc.json
add lots of objects animated article
threejs/lessons/threejs-optimize-lots-of-objects.md
@@ -527,7 +527,8 @@ faces that are never visible. The problem with making everything one mesh though is it's no longer easy to move any part that was previously separate. Depending on our use case -though there are creative solutions. We'll explore one in another article. +though there are creative solutions. We'll...
true
Other
mrdoob
three.js
59726bae96775d035fb14bb05e902567741341dc.json
add lots of objects animated article
threejs/lessons/toc.html
@@ -20,6 +20,7 @@ <li>Optimization</li> <ul> <li><a href="/threejs/lessons/threejs-optimize-lots-of-objects.html">Optimizing Lots of Objects</a></li> + <li><a href="/threejs/lessons/threejs-optimize-lots-of-objects-animated.html">Optimizing Lots of Objects Animated</a></li> </ul> <li>Tips</li> <u...
true
Other
mrdoob
three.js
59726bae96775d035fb14bb05e902567741341dc.json
add lots of objects animated article
threejs/threejs-lots-of-objects-animated.html
@@ -0,0 +1,410 @@ +<!-- Licensed under a BSD license. See license.html for license --> +<!DOCTYPE html> +<html> + <head> + <meta charset="utf-8"> + <meta name="viewport" content="width=device-width, initial-scale=1.0, user-scalable=yes"> + <title>Three.js - Lots of Objects - Animated</title> + <style> + ...
true
Other
mrdoob
three.js
59726bae96775d035fb14bb05e902567741341dc.json
add lots of objects animated article
threejs/threejs-lots-of-objects-morphtargets-w-colors.html
@@ -0,0 +1,485 @@ +<!-- Licensed under a BSD license. See license.html for license --> +<!DOCTYPE html> +<html> + <head> + <meta charset="utf-8"> + <meta name="viewport" content="width=device-width, initial-scale=1.0, user-scalable=yes"> + <title>Three.js - Lots of Objects - MorphTargets w/colors</title> + ...
true
Other
mrdoob
three.js
59726bae96775d035fb14bb05e902567741341dc.json
add lots of objects animated article
threejs/threejs-lots-of-objects-morphtargets.html
@@ -0,0 +1,417 @@ +<!-- Licensed under a BSD license. See license.html for license --> +<!DOCTYPE html> +<html> + <head> + <meta charset="utf-8"> + <meta name="viewport" content="width=device-width, initial-scale=1.0, user-scalable=yes"> + <title>Three.js - Lots of Objects - Morphtargets</title> + <style> ...
true
Other
mrdoob
three.js
59726bae96775d035fb14bb05e902567741341dc.json
add lots of objects animated article
threejs/threejs-lots-of-objects-multiple-data-sets.html
@@ -0,0 +1,351 @@ +<!-- Licensed under a BSD license. See license.html for license --> +<!DOCTYPE html> +<html> + <head> + <meta charset="utf-8"> + <meta name="viewport" content="width=device-width, initial-scale=1.0, user-scalable=yes"> + <title>Three.js - Lots of Objects - Multiple Datasets</title> + <st...
true
Other
mrdoob
three.js
374dfeedf294143ec128cd59236fdfaf6ecbace7.json
fix long words being too long on mobile
threejs/lessons/resources/lesson.css
@@ -24,6 +24,11 @@ pre.prettyprint li { white-space: pre; } +/* to handle long words in paragraph */ +p code { + word-break: break-word; + white-space: normal; +} div[data-diagram] { height: 100%;
false
Other
mrdoob
three.js
525b441f039af23429e06196b96e6097affb49d2.json
add missing example
threejs/lessons/threejs-backgrounds.md
@@ -274,4 +274,6 @@ let bgMesh; } ``` +{{{example url="../threejs-background-equirectangularmap.html" }}} + Using equirectagular images requires more complicated shaders and so is slower than using cubemaps. Fortunately it's easy to convert from an equirectangular image to a cubemap. [Here's a site that will do it...
false
Other
mrdoob
three.js
12024a76a25f6424b56063165841c7d6153ed265.json
handle extra whitespace
threejs/resources/editor.js
@@ -58,7 +58,7 @@ function fixSourceLinks(url, source) { const srcRE = /(src=)"(.*?)"/g; const linkRE = /(href=)"(.*?")/g; const imageSrcRE = /((?:image|img)\.src = )"(.*?)"/g; - const loaderLoadRE = /(loader\.load[a-z]*\()('|")(.*?)('|")/ig; + const loaderLoadRE = /(loader\.load[a-z]*\s*\(\s*)('|")(.*?)('|"...
false
Other
mrdoob
three.js
ae614345b0c391c627827aed8c5aafcc0b5aa966.json
remove unused lines
threejs/threejs-background-cubemap.html
@@ -86,8 +86,6 @@ 'resources/images/cubemaps/computer-history-museum/pos-z.jpg', 'resources/images/cubemaps/computer-history-museum/neg-z.jpg', ]); -// texture.format = THREE.RGBFormat; -// texture.mapping = THREE.CubeReflectionMapping; const shader = THREE.ShaderLib.cube; const mater...
false
Other
mrdoob
three.js
65ae4afc8fce25dae226d9a367902339dbd94403.json
handle arrays of images
threejs/resources/editor.js
@@ -58,7 +58,9 @@ function fixSourceLinks(url, source) { const srcRE = /(src=)"(.*?)"/g; const linkRE = /(href=)"(.*?")/g; const imageSrcRE = /((?:image|img)\.src = )"(.*?)"/g; - const loaderLoadRE = /(loader.load[a-z]*\()('|")(.*?)('|")/ig; + const loaderLoadRE = /(loader\.load[a-z]*\()('|")(.*?)('|")/ig; +...
false
Other
mrdoob
three.js
325d29bad377f2c9d871160abc67578132278f88.json
fix image size
threejs/lessons/threejs-post-processing-3dlut.md
@@ -46,7 +46,7 @@ We'll also add a background image like we covered in [backgrounds and skyboxs](t Now that we have a scene we need a 3DLUT. The simplest 3DLUT is a 2x2x2 identity LUT where *identity* means nothing happens. It's like multiplying by 1 or doing nothign, even though we're looking up colors in the LUT e...
false
Other
mrdoob
three.js
5e204c261f4dd697c0509ab903c6ef320c450618.json
fix PBR material order
threejs/lessons/resources/threejs-materials.js
@@ -76,7 +76,7 @@ import {threejsLessonUtils} from './threejs-lesson-utils.js'; const material = new MatCtor({ color, roughness: r / (numRough - 1), - metalness: m / (numMetal - 1), + metalness: 1 - m / (numMetal - 1), }); const mesh = new THREE.Mesh(hi...
true
Other
mrdoob
three.js
5e204c261f4dd697c0509ab903c6ef320c450618.json
fix PBR material order
threejs/lessons/threejs-materials.md
@@ -169,9 +169,8 @@ have hard reflections whereas something that's not rough, like a billiard ball, is very shiny. Roughness goes from 0 to 1. The other setting, [`metalness`](MeshStandardMaterial.metalness), says -how metal the material is. Metals behave differently than non-metals. For -some reason this setting i...
true
Other
mrdoob
three.js
e1450376e24f043dd0c6035363bac5b0f05b4a10.json
fix metalness description
threejs/lessons/threejs-materials.md
@@ -169,8 +169,9 @@ have hard reflections whereas something that's not rough, like a billiard ball, is very shiny. Roughness goes from 0 to 1. The other setting, [`metalness`](MeshStandardMaterial.metalness), says -how metal the material is. Metals behave differently than non-metals -and so this setting goes from 0...
false
Other
mrdoob
three.js
4aecaeb33e8d70297d73e7bb12eea948dce99e8c.json
add id for es6 module breakout
threejs/lessons/threejs-fundamentals.md
@@ -406,7 +406,7 @@ a different color. I hope this short intro helps to get things started. [Next up we'll cover making our code responsive so it is adaptable to multiple situations](threejs-responsive.html). -<div class="threejs_bottombar"> +<div id="es6" class="threejs_bottombar"> <h3>es6 modules, three.js, and ...
false
Other
mrdoob
three.js
ffcaab3189e0c50957956a15bf268c8d5215ce85.json
add another extrude example
threejs/lessons/resources/threejs-primitives.js
@@ -110,7 +110,7 @@ import {threejsLessonUtils} from './threejs-lesson-utils.js'; }, ExtrudeBufferGeometry: { ui: { - steps: { type: 'range', min: 1, max: 10, }, + steps: { type: 'range', min: 1, max: 100, }, depth: { type: 'range', min: 1, max: 20, precision: 1, }, beve...
false
Other
mrdoob
three.js
fcc4337ba47069c5fef5bfa0931721aaf66c14b3.json
add deep links to primitives
threejs/lessons/resources/lesson.css
@@ -27,6 +27,10 @@ table { .footnotes { font-size: smaller; } +.deep-link { + position: absolute; + transform: translateX(-1em); +} pre { background: rgb(143, 140, 140);
true
Other
mrdoob
three.js
fcc4337ba47069c5fef5bfa0931721aaf66c14b3.json
add deep links to primitives
threejs/lessons/resources/threejs-lesson-utils.js
@@ -1,5 +1,5 @@ import * as THREE from '../../resources/threejs/r115/build/three.module.js'; -import {TrackballControls} from '../../resources/threejs/r115/examples/jsm/controls/TrackballControls.js'; +import {OrbitControls} from '../../resources/threejs/r115/examples/jsm/controls/OrbitControls.js'; export const th...
true
Other
mrdoob
three.js
fcc4337ba47069c5fef5bfa0931721aaf66c14b3.json
add deep links to primitives
threejs/lessons/resources/threejs-primitives.js
@@ -642,16 +642,25 @@ const geometry = new THREE.WireframeGeometry( }, }; - function addLink(parent, name) { + function addLink(parent, name, href) { const a = document.createElement('a'); - a.href = `https://threejs.org/docs/#api/geometries/${name}`; + a.href = href || `https://threejs.org/docs/...
true
Other
mrdoob
three.js
fcc4337ba47069c5fef5bfa0931721aaf66c14b3.json
add deep links to primitives
threejs/lessons/ru/threejs-primitives.md
@@ -18,30 +18,30 @@ Three.js имеет большое количество примитивов. П создание и загрузку данных из нескольких программ 3D-моделирования. А сейчас давайте рассмотрим некоторые из доступных примитивов. -<div data-primitive="BoxBufferGeometry">Прямоугольный параллелепипед</div> -<div data-primitive="CircleBufferGeomet...
true
Other
mrdoob
three.js
fcc4337ba47069c5fef5bfa0931721aaf66c14b3.json
add deep links to primitives
threejs/lessons/threejs-primitives.md
@@ -24,30 +24,30 @@ primitives. Many of the primitives below have defaults for some or all of their parameters so you can use more or less depending on your needs. -<div data-primitive="BoxBufferGeometry">A Box</div> -<div data-primitive="CircleBufferGeometry">A flat circle</div> -<div data-primitive="ConeBufferGeo...
true
Other
mrdoob
three.js
92767a1adaf103a83c9164633be0b604ca642480.json
Fix french sentences
threejs/lessons/fr/threejs-fundamentals.md
@@ -51,9 +51,9 @@ Voici ce qui est à remarquer dans le diagramme ci-dessus : la couleur d'arrière plan et le brouillard. L'ensemble de ces objets définissent une structure hiérarchique de type parent/enfant, arborescente, et indique où les objets apparaissent et comment ils sont orientés. Les enfants sont posi...
false
Other
mrdoob
three.js
0ea4e6c3f2655407b1670e48c9f32941330f3eb0.json
Fix french sentences for #51
threejs/lessons/fr/langinfo.hanson
@@ -6,16 +6,14 @@ description: 'Apprendre à utiliser Three.js.', link: 'http://threejsfundamentals.org/', commentSectionHeader: '<div>Questions ? <a href="http://stackoverflow.com/questions/tagged/three.js">Les poser sur stackoverflow</a>.</div>\n <div>Problèmes / bug ? <a href="http://github.com/gfxfun...
true
Other
mrdoob
three.js
0ea4e6c3f2655407b1670e48c9f32941330f3eb0.json
Fix french sentences for #51
threejs/lessons/fr/threejs-fundamentals.md
@@ -10,7 +10,7 @@ Three.js est souvent confondu avec WebGL puisque la plupart du temps, mais pas toujours, elle exploite WebGL pour dessiner en 3D. [WebGL est un système très bas niveau qui ne dessine que des points, des lignes et des triangles](https://webglfundamentals.org). Faire quelque chose d'exploitable avec ...
true
Other
mrdoob
three.js
0ea4e6c3f2655407b1670e48c9f32941330f3eb0.json
Fix french sentences for #51
threejs/lessons/fr/threejs-prerequisites.md
@@ -7,21 +7,21 @@ Ils supposent que : * vous savez programmer en Javascript ; * vous savez ce que c'est qu'un *DOM*, comment écrire du HTML, ainsi que créer des éléments *DOM* en Javascript ; - * vous savez exploiter les -[modules es6](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statement...
true
Other
mrdoob
three.js
0ea4e6c3f2655407b1670e48c9f32941330f3eb0.json
Fix french sentences for #51
threejs/lessons/fr/threejs-responsive.md
@@ -1,23 +1,23 @@ -Title: Design réactif et Three.js +Title: Design réactif et Three.js Description: Comment rendre three.js adaptable à des affichages de taille différente. TOC: Design réactif -Ceci est le second article dans une série à propos de three.js. -Le premier était [à propos des principes de base](three...
true
Other
mrdoob
three.js
e22c820d6f1af6c34e628f499642a54a7ace1c60.json
fix horizontal scrollbar on certain pages
threejs/lessons/resources/lesson.css
@@ -80,7 +80,7 @@ div[data-diagram] { position: absolute; top: 0; left: 0; - width: 100vw; + width: 100%; height: 100vh; z-index: -100; }
true
Other
mrdoob
three.js
e22c820d6f1af6c34e628f499642a54a7ace1c60.json
fix horizontal scrollbar on certain pages
threejs/lessons/resources/threejs-lesson-utils.js
@@ -7,7 +7,10 @@ export const threejsLessonUtils = { if (this.renderer) { return; } - const canvas = document.querySelector('#c'); + + const canvas = document.createElement('canvas'); + canvas.id = 'c'; + document.body.appendChild(canvas); const renderer = new THREE.WebGLRenderer({ ...
true
Other
mrdoob
three.js
e22c820d6f1af6c34e628f499642a54a7ace1c60.json
fix horizontal scrollbar on certain pages
threejs/lessons/ru/threejs-primitives.md
@@ -329,6 +329,5 @@ function addLineGeometry(x, y, geometry) { Далее давайте рассмотрим [как работает граф сцены и как его использовать](threejs-scenegraph.html). -<canvas id="c"></canvas> <script type="module" src="../resources/threejs-primitives.js"></script> <link rel="stylesheet" href="../resources/threejs-p...
true
Other
mrdoob
three.js
e22c820d6f1af6c34e628f499642a54a7ace1c60.json
fix horizontal scrollbar on certain pages
threejs/lessons/ru/threejs-textures.md
@@ -615,6 +615,5 @@ metalness roughness --> -<canvas id="c"></canvas> <script type="module" src="../resources/threejs-textures.js"></script> <link rel="stylesheet" href="../resources/threejs-textures.css">
true
Other
mrdoob
three.js
e22c820d6f1af6c34e628f499642a54a7ace1c60.json
fix horizontal scrollbar on certain pages
threejs/lessons/threejs-primitives.md
@@ -398,7 +398,6 @@ or [custom BufferGeometry](threejs-custom-buffergeometry.html). Next up let's go over [how three's scene graph works and how to use it](threejs-scenegraph.html). -<canvas id="c"></canvas> <link rel="stylesheet" href="resources/threejs-primitives.css"> <script type="module" src="resources/three...
true
Other
mrdoob
three.js
e22c820d6f1af6c34e628f499642a54a7ace1c60.json
fix horizontal scrollbar on certain pages
threejs/lessons/threejs-textures.md
@@ -624,6 +624,5 @@ metalness roughness --> -<canvas id="c"></canvas> <link rel="stylesheet" href="resources/threejs-textures.css"> <script type="module" src="resources/threejs-textures.js"></script>
true
Other
mrdoob
three.js
2efb3385eff61e8cf18694d7689c764c61bca3a7.json
fix input textarea color
threejs/lessons/resources/threejs-primitives.css
@@ -39,6 +39,12 @@ div[data-primitive] .input>div { div[data-primitive] .input input { position: absolute; } +div[data-primitive] .input input[type=text] { + background: #444; + color: white; + border: none; + padding: 3px; +} @media (max-width: 600px) { div[data-primitive] .input>div {
false
Other
mrdoob
three.js
3714df0b234c3b509a0e169b0621045eda4af5cf.json
add sliders to primitives
threejs/lessons/resources/lesson.css
@@ -39,6 +39,7 @@ pre>code { pre.prettyprint { margin-top: 2em !important; margin-bottom: 2em !important; + position: relative; } pre.prettyprint li { white-space: pre; @@ -565,5 +566,10 @@ pre.prettyprint.lighttheme .fun { color: #900; } /* function name */ .lesson-comment-notes { backgro...
true
Other
mrdoob
three.js
3714df0b234c3b509a0e169b0621045eda4af5cf.json
add sliders to primitives
threejs/lessons/resources/threejs-lesson-utils.js
@@ -217,4 +217,4 @@ export const threejsLessonUtils = { }, }; - +window.threejsLessonUtils = threejsLessonUtils; \ No newline at end of file
true
Other
mrdoob
three.js
3714df0b234c3b509a0e169b0621045eda4af5cf.json
add sliders to primitives
threejs/lessons/resources/threejs-primitives.css
@@ -21,12 +21,50 @@ div[data-primitive] .desc { div[data-primitive] .desc code { white-space: normal; } + +div[data-primitive] .input { + display: inline-block; + user-select: none; +} +div[data-primitive] .input::before { + content:" "; +} +div[data-primitive] .input input[type=range] { + width: 200px; +} +di...
true
Other
mrdoob
three.js
3714df0b234c3b509a0e169b0621045eda4af5cf.json
add sliders to primitives
threejs/lessons/resources/threejs-primitives.js
@@ -189,15 +189,15 @@ const geometry = THREE.ExtrudeBufferGeometry(shape, extrudeSettings); for (let i = 0; i < 10; ++i) { points.push(new THREE.Vector2(Math.sin(i * 0.2) * 3 + 3, (i - 5) * .8)); } - const geometry = new THREE.LatheBufferGeometry(points); - return geometry; + ...
true
Other
mrdoob
three.js
3714df0b234c3b509a0e169b0621045eda4af5cf.json
add sliders to primitives
threejs/lessons/threejs-primitives.md
@@ -42,7 +42,7 @@ for <code>TextBufferGeometry</code> and <code>TextGeometry</code> respectively.< <div data-primitive="TorusBufferGeometry">A torus (donut)</div> <div data-primitive="TorusKnotBufferGeometry">A torus knot</div> <div data-primitive="TubeBufferGeometry">A circle traced down a path</div> -<div data-pri...
true
Other
mrdoob
three.js
816ec01e260847437dca4c8c4fb9a6d36ab147fd.json
fix position calculation
threejs/lessons/threejs-indexed-textures.md
@@ -162,8 +162,8 @@ const pickHelper = new GPUPickHelper(); function getCanvasRelativePosition(event) { const rect = canvas.getBoundingClientRect(); return { - x: event.clientX - rect.left, - y: event.clientY - rect.top, + x: (event.clientX - rect.left) * canvas.width / rect.width, + y: (event.clien...
true
Other
mrdoob
three.js
816ec01e260847437dca4c8c4fb9a6d36ab147fd.json
fix position calculation
threejs/lessons/threejs-offscreencanvas.md
@@ -463,15 +463,15 @@ We updated `pickPosition` from the mouse like this function getCanvasRelativePosition(event) { const rect = canvas.getBoundingClientRect(); return { - x: event.clientX - rect.left, - y: event.clientY - rect.top, + x: (event.clientX - rect.left) * canvas.width / rect.width, + y:...
true
Other
mrdoob
three.js
816ec01e260847437dca4c8c4fb9a6d36ab147fd.json
fix position calculation
threejs/lessons/threejs-picking.md
@@ -134,15 +134,15 @@ clearPickPosition(); function getCanvasRelativePosition(event) { const rect = canvas.getBoundingClientRect(); return { - x: event.clientX - rect.left, - y: event.clientY - rect.top, + x: (event.clientX - rect.left) * canvas.width / rect.width, + y: (event.clientY - rect.top ) *...
true
Other
mrdoob
three.js
816ec01e260847437dca4c8c4fb9a6d36ab147fd.json
fix position calculation
threejs/lessons/threejs-voxel-geometry.md
@@ -972,15 +972,15 @@ hit. function getCanvasRelativePosition(event) { const rect = canvas.getBoundingClientRect(); return { - x: event.clientX - rect.left, - y: event.clientY - rect.top, + x: (event.clientX - rect.left) * canvas.width / rect.width, + y: (event.clientY - rect.top ) * canvas.height /...
true
Other
mrdoob
three.js
816ec01e260847437dca4c8c4fb9a6d36ab147fd.json
fix position calculation
threejs/threejs-indexed-textures-picking-and-highlighting.html
@@ -345,8 +345,8 @@ function getCanvasRelativePosition(event) { const rect = canvas.getBoundingClientRect(); return { - x: event.clientX - rect.left, - y: event.clientY - rect.top, + x: (event.clientX - rect.left) * canvas.width / rect.width, + y: (event.clientY - rect.top ) * canvas.h...
true
Other
mrdoob
three.js
816ec01e260847437dca4c8c4fb9a6d36ab147fd.json
fix position calculation
threejs/threejs-indexed-textures-picking-debounced.html
@@ -350,8 +350,8 @@ function getCanvasRelativePosition(event) { const rect = canvas.getBoundingClientRect(); return { - x: event.clientX - rect.left, - y: event.clientY - rect.top, + x: (event.clientX - rect.left) * canvas.width / rect.width, + y: (event.clientY - rect.top ) * canvas.h...
true
Other
mrdoob
three.js
816ec01e260847437dca4c8c4fb9a6d36ab147fd.json
fix position calculation
threejs/threejs-indexed-textures-picking.html
@@ -276,8 +276,8 @@ function getCanvasRelativePosition(event) { const rect = canvas.getBoundingClientRect(); return { - x: event.clientX - rect.left, - y: event.clientY - rect.top, + x: (event.clientX - rect.left) * canvas.width / rect.width, + y: (event.clientY - rect.top ) * canvas.h...
true
Other
mrdoob
three.js
816ec01e260847437dca4c8c4fb9a6d36ab147fd.json
fix position calculation
threejs/threejs-indexed-textures-random-colors.html
@@ -325,8 +325,8 @@ function getCanvasRelativePosition(event) { const rect = canvas.getBoundingClientRect(); return { - x: event.clientX - rect.left, - y: event.clientY - rect.top, + x: (event.clientX - rect.left) * canvas.width / rect.width, + y: (event.clientY - rect.top ) * canvas.h...
true
Other
mrdoob
three.js
816ec01e260847437dca4c8c4fb9a6d36ab147fd.json
fix position calculation
threejs/threejs-offscreencanvas-w-picking.html
@@ -85,16 +85,16 @@ function getCanvasRelativePosition(event) { const rect = canvas.getBoundingClientRect(); return { - x: event.clientX - rect.left, - y: event.clientY - rect.top, - }; + x: (event.clientX - rect.left) * canvas.width / rect.width, + y: (event.clientY - rect.top ) * ...
true
Other
mrdoob
three.js
816ec01e260847437dca4c8c4fb9a6d36ab147fd.json
fix position calculation
threejs/threejs-picking-gpu.html
@@ -205,8 +205,8 @@ function getCanvasRelativePosition(event) { const rect = canvas.getBoundingClientRect(); return { - x: event.clientX - rect.left, - y: event.clientY - rect.top, + x: (event.clientX - rect.left) * canvas.width / rect.width, + y: (event.clientY - rect.top ) * canvas.h...
true
Other
mrdoob
three.js
816ec01e260847437dca4c8c4fb9a6d36ab147fd.json
fix position calculation
threejs/threejs-picking-raycaster-complex-geo.html
@@ -136,8 +136,8 @@ function getCanvasRelativePosition(event) { const rect = canvas.getBoundingClientRect(); return { - x: event.clientX - rect.left, - y: event.clientY - rect.top, + x: (event.clientX - rect.left) * canvas.width / rect.width, + y: (event.clientY - rect.top ) * canvas.h...
true
Other
mrdoob
three.js
816ec01e260847437dca4c8c4fb9a6d36ab147fd.json
fix position calculation
threejs/threejs-picking-raycaster-transparency.html
@@ -153,15 +153,15 @@ function getCanvasRelativePosition(event) { const rect = canvas.getBoundingClientRect(); return { - x: event.clientX - rect.left, - y: event.clientY - rect.top, + x: (event.clientX - rect.left) * canvas.width / rect.width, + y: (event.clientY - rect.top ) * canvas...
true
Other
mrdoob
three.js
816ec01e260847437dca4c8c4fb9a6d36ab147fd.json
fix position calculation
threejs/threejs-picking-raycaster.html
@@ -146,15 +146,15 @@ function getCanvasRelativePosition(event) { const rect = canvas.getBoundingClientRect(); return { - x: event.clientX - rect.left, - y: event.clientY - rect.top, + x: (event.clientX - rect.left) * canvas.width / rect.width, + y: (event.clientY - rect.top ) * canvas...
true
Other
mrdoob
three.js
816ec01e260847437dca4c8c4fb9a6d36ab147fd.json
fix position calculation
threejs/threejs-tips-preservedrawingbuffer.html
@@ -106,16 +106,16 @@ function getCanvasRelativePosition(event) { const rect = canvas.getBoundingClientRect(); return { - x: event.clientX - rect.left, - y: event.clientY - rect.top, + x: (event.clientX - rect.left) * canvas.width / rect.width, + y: (event.clientY - rect.top ) * canvas...
true
Other
mrdoob
three.js
816ec01e260847437dca4c8c4fb9a6d36ab147fd.json
fix position calculation
threejs/threejs-voxel-geometry-culled-faces-ui.html
@@ -512,15 +512,15 @@ function getCanvasRelativePosition(event) { const rect = canvas.getBoundingClientRect(); return { - x: event.clientX - rect.left, - y: event.clientY - rect.top, + x: (event.clientX - rect.left) * canvas.width / rect.width, + y: (event.clientY - rect.top ) * canvas...
true
Other
mrdoob
three.js
571aabfdd35f6379b885722ece8e121388ffd932.json
fix slight grammatical error "Examples would lamps, bowling pins..." I assume this is meant to read "Examples would be: ...")
threejs/lessons/threejs-primitives.md
@@ -29,7 +29,7 @@ primitives. Here we are extruding a heart shape. Note this is the basis for <code>TextBufferGeometry</code> and <code>TextGeometry</code> respectively.</div> <div data-primitive="IcosahedronBufferGeometry">An icosahedron (20 sides)</div> -<div data-primitive="LatheBufferGeometry">A shape generated ...
false
Other
mrdoob
three.js
7b797bb4ead8c9d9d11038365f401835c793af49.json
load external files only on live site
build/templates/analytics.template
@@ -1,10 +1,29 @@ -<script src="//cdn.webglstats.com/stat.js" defer="defer" async="async"></script> -<script async src="https://www.googletagmanager.com/gtag/js?id=UA-120733518-1"></script> <script> - window.dataLayer = window.dataLayer || []; - function gtag(){dataLayer.push(arguments);} - gtag('js', new Date()); ...
false
Other
mrdoob
three.js
a43ab685966c758c6bb4284e9d9dddcd373b1abf.json
fix fixes from testing with check-all-the-errors
threejs/lessons/ru/threejs-lights.md
@@ -395,7 +395,7 @@ scene.add(light.target); scene.add(helper); ``` -Угол конуса прожектора задается с помощью свойства [`angle`](Spotlight.angle) +Угол конуса прожектора задается с помощью свойства [`angle`](SpotLight.angle) в радианах. Мы будем использовать наш `DegRadHelper` из [статьи про текстуры](threejs...
true
Other
mrdoob
three.js
a43ab685966c758c6bb4284e9d9dddcd373b1abf.json
fix fixes from testing with check-all-the-errors
threejs/lessons/ru/threejs-materials.md
@@ -52,7 +52,7 @@ const m5 = new THREE.MeshBasicMaterial({color: 'hsl(0,100%,50%)'); // red прим. переводчика: Блик - световое пятно на ярко освещённой выпуклой или плоской глянцевой поверхности. -[Зеркальное отражение](http://compgraph.tpu.ru/mir_reflection.htm) я часто буду называть бликом, +[Зеркальное отражени...
true
Other
mrdoob
three.js
a43ab685966c758c6bb4284e9d9dddcd373b1abf.json
fix fixes from testing with check-all-the-errors
threejs/lessons/ru/threejs-textures.md
@@ -448,7 +448,7 @@ Mips - это копии текстуры, каждая из которых в которые используют 4 или 5 текстур одновременно. 4 текстуры * 8 пикселей на текстуру - это поиск 32 пикселей для каждого пикселя. Это может быть особенно важно учитывать на мобильных устройствах. -## <a href="uvmanipulation"></a> Повторение, смеще...
true
Other
mrdoob
three.js
a43ab685966c758c6bb4284e9d9dddcd373b1abf.json
fix fixes from testing with check-all-the-errors
threejs/lessons/threejs-align-html-elements-to-3d.md
@@ -409,7 +409,7 @@ where min, max, lat, lon, are all in latitude and longitude degrees. Let's load it up. The code is based on the examples from [optimizing lots of objects](threejs-optimize-lots-of-objects.html) though we are not drawing lots of objects we'll be using the same solutions for [rendering on -demand](...
true
Other
mrdoob
three.js
a43ab685966c758c6bb4284e9d9dddcd373b1abf.json
fix fixes from testing with check-all-the-errors
threejs/lessons/threejs-debugging-javascript.md
@@ -18,7 +18,7 @@ enormously in your learning. All browsers have developer tools. [Chrome](https://developers.google.com/web/tools/chrome-devtools/), -[Firefox](https://developer.mozilla.org/son/docs/Tools), +[Firefox](https://developer.mozilla.org/en-US/docs/Tools), [Safari](https://developer.apple.com/safari/...
true
Other
mrdoob
three.js
a43ab685966c758c6bb4284e9d9dddcd373b1abf.json
fix fixes from testing with check-all-the-errors
threejs/lessons/threejs-game.md
@@ -1563,7 +1563,7 @@ things. To do that I made a `StatusDisplayHelper` component. I uses a `PolarGridHelper` to draw a circle around each character and it uses html elements to let each character show some status using -the techniques covered in [the article on aligning html elements to 3D](threejs-align-html-elem...
true
Other
mrdoob
three.js
a43ab685966c758c6bb4284e9d9dddcd373b1abf.json
fix fixes from testing with check-all-the-errors
threejs/lessons/threejs-indexed-textures.md
@@ -262,7 +262,7 @@ but what about highlighting the selected countries? For that we can take inspiration from *paletted graphics*. -[Paletted graphics](https://en.wikipedia.org/wiki/Palette_(computing)) +[Paletted graphics](https://en.wikipedia.org/wiki/Palette_%28computing%29) or [Indexed Color](https://en.wikip...
true
Other
mrdoob
three.js
a43ab685966c758c6bb4284e9d9dddcd373b1abf.json
fix fixes from testing with check-all-the-errors
threejs/lessons/threejs-lights.md
@@ -400,7 +400,7 @@ scene.add(light.target); scene.add(helper); ``` -The spotlight's cone's angle is set with the [`angle`](Spotlight.angle) +The spotlight's cone's angle is set with the [`angle`](SpotLight.angle) property in radians. We'll use our `DegRadHelper` from the [texture article](threejs-textures.html) ...
true
Other
mrdoob
three.js
a43ab685966c758c6bb4284e9d9dddcd373b1abf.json
fix fixes from testing with check-all-the-errors
threejs/lessons/threejs-offscreencanvas.md
@@ -614,7 +614,7 @@ of the DOM events they use. Maybe we could pass in our own object that has the same API surface as a DOM element. We only need to support the features the OrbitControls need. -Digging through the [OrbitControls source code](https://github.com/gfxfundamentals/threejsfundamentals/blob/master/thre...
true
Other
mrdoob
three.js
a43ab685966c758c6bb4284e9d9dddcd373b1abf.json
fix fixes from testing with check-all-the-errors
threejs/lessons/threejs-optimize-lots-of-objects.md
@@ -18,7 +18,7 @@ re-create the [WebGL Globe](https://globe.chromeexperiments.com/). The first thing we need to do is get some data. The WebGL Globe said the data they use comes from [SEDAC](http://sedac.ciesin.columbia.edu/gpw/). Checking out the site I saw there was [demographic data in a grid -format](http://seda...
true
Other
mrdoob
three.js
a43ab685966c758c6bb4284e9d9dddcd373b1abf.json
fix fixes from testing with check-all-the-errors
threejs/lessons/threejs-prerequisites.md
@@ -138,7 +138,7 @@ for (const [key, value] of Object.entries(someObject)) { ### Use `forEach`, `map`, and `filter` where useful -Arrays added the functions [`forEach`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/forEach, +Arrays added the functions [`forEach`](https://...
true
Other
mrdoob
three.js
a43ab685966c758c6bb4284e9d9dddcd373b1abf.json
fix fixes from testing with check-all-the-errors
threejs/lessons/threejs-textures.md
@@ -456,7 +456,7 @@ we'll eventually have materials that use 4 or 5 textures all at once. 4 textures pixels per texture is looking up 32 pixels for ever pixel rendered. This can be especially important to consider on mobile devices. -## <a href="uvmanipulation"></a> Repeating, offseting, rotating, wrapping a textur...
true