owner stringclasses 15
values | repo stringclasses 15
values | id int64 116k 4.21B | issue_number int32 1 180k | author stringlengths 0 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-04-09 03:22:08 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-04-09 03:28:07 | reactions unknown | author_association stringclasses 7
values |
|---|---|---|---|---|---|---|---|---|---|
rust-lang | rust | 1,125,284,599 | 95,896 | ehuss | Note that when adding new pages to the book, they need to be linked from `SUMMARY.md`. I have posted #96988 to fix this. | 2022-05-12T18:09:56 | 2022-05-12T18:09:56 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,167,381 | 95,474 | nikomatsakis | @rfcbot fcp merge
We discussed this in the https://github.com/orgs/rust-lang/teams/lang meeting today and agreed this was a clear bug fix. | 2022-05-12T15:59:02 | 2022-05-12T15:59:02 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,177,849 | 95,356 | bors | :v: @coolreader18 can now approve this pull request
<!-- homu: {"type":"Delegated","delegator":"yaahc","delegate":"coolreader18"} --> | 2022-05-12T16:09:08 | 2022-05-12T16:09:08 | {} | COLLABORATOR |
rust-lang | rust | 1,125,276,519 | 90,488 | oli-obk | > That'll make a const fn and a non-const fn behave differently even if the const fn is not called in const context.
This is what will happen for all other traits, too, not just Debug/Display.
On the PR itself:
I would like to move this PR along. But neither Ralf nor I will approve the current version. I know ... | 2022-05-12T17:59:52 | 2022-05-12T17:59:52 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,284,083 | 96,988 | rust-highfive | r? @steveklabnik
(rust-highfive has picked a reviewer for you, use r? to override) | 2022-05-12T18:09:15 | 2022-05-12T18:09:15 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,295,452 | 95,845 | CAD97 | While I agree in general (I can already imagine someone asking why `strip` is missing some symbols), there's a really recent counterexample of someone wanting `TypeId -> TypeName`: https://users.rust-lang.org/t/how-to-get-the-type-name-from-typeid/75507?u=cad97
(That said, I also do think the in-thread solution of a `... | 2022-05-12T18:23:16 | 2022-05-12T18:23:16 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,352,106 | 96,732 | bors | :broken_heart: Test failed - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6412473071?check_suite_focus=true)
<!-- homu: {"type":"TryBuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/6412473071?check_suite_focus=true","builder_name":"checks-actions"} --> | 2022-05-12T19:33:51 | 2022-05-12T19:33:51 | {} | COLLABORATOR |
rust-lang | rust | 1,125,172,849 | 96,978 | bors | :broken_heart: Test failed - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6409543390?check_suite_focus=true)
<!-- homu: {"type":"TryBuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/6409543390?check_suite_focus=true","builder_name":"checks-actions"} --> | 2022-05-12T16:04:14 | 2022-05-12T16:04:14 | {} | COLLABORATOR |
rust-lang | rust | 1,125,176,307 | 95,474 | rfcbot | :bell: **This is now entering its final comment period**, as per the [review above](https://github.com/rust-lang/rust/pull/95474#issuecomment-1125167397). :bell: | 2022-05-12T16:07:35 | 2022-05-12T16:07:35 | {} | NONE |
rust-lang | rust | 1,125,177,235 | 96,948 | joshtriplett | @bors r+ rollup | 2022-05-12T16:08:31 | 2022-05-12T16:08:31 | {} | MEMBER |
rust-lang | rust | 1,125,206,964 | 96,757 | jyn514 | Looks like https://github.com/rust-lang/triagebot/pull/1610 is not working :( @Mark-Simulacrum do you mind checking the logs to see if triagebot threw an exception? | 2022-05-12T16:40:22 | 2022-05-12T16:40:22 | {} | MEMBER |
rust-lang | rust | 1,125,226,146 | 96,892 | rust-timer | Finished benchmarking commit (d8a4e1603dd700949c5b4853c312802049749630): [comparison url](https://perf.rust-lang.org/compare.html?start=4f8e2e3ad9fce35dc356ee1e87170814e4112d76&end=d8a4e1603dd700949c5b4853c312802049749630).
**Summary**:
- Primary benchmarks: 😿 relevant regressions found
- Secondary benchmarks: no re... | 2022-05-12T17:02:36 | 2022-05-12T17:02:36 | {} | COLLABORATOR |
rust-lang | rust | 1,125,271,289 | 96,978 | bors | :broken_heart: Test failed - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6411097149?check_suite_focus=true)
<!-- homu: {"type":"TryBuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/6411097149?check_suite_focus=true","builder_name":"checks-actions"} --> | 2022-05-12T17:53:11 | 2022-05-12T17:53:11 | {} | COLLABORATOR |
rust-lang | rust | 1,125,167,918 | 96,973 | bors | :sunny: Try build successful - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6409462066?check_suite_focus=true)
Build commit: 5e729d04bfc306976e08f76cc40ac1422855c075 (`5e729d04bfc306976e08f76cc40ac1422855c075`)
<!-- homu: {"type":"TryBuildCompleted","builders":{"checks-actions":"https://github.com/rust-la... | 2022-05-12T15:59:34 | 2022-05-12T15:59:34 | {} | COLLABORATOR |
rust-lang | rust | 1,125,177,805 | 95,356 | yaahc | this LGTM once the todo is fixed. After you've fixed that up and it's passing the github checks go ahead and r=me
@bors delegate+ | 2022-05-12T16:09:06 | 2022-05-12T16:09:06 | {} | MEMBER |
rust-lang | rust | 1,125,286,918 | 96,892 | estebank | Interesting how this affects a single crate. It seems like `evaluate_obligations` and `check_mod_item_types` might be driving it?
https://perf.rust-lang.org/detailed-query.html?sort_idx=-11&commit=d8a4e1603dd700949c5b4853c312802049749630&base_commit=4f8e2e3ad9fce35dc356ee1e87170814e4112d76&benchmark=bitmaps-3.1.0-ch... | 2022-05-12T18:12:52 | 2022-05-12T18:15:14 | {} | CONTRIBUTOR |
rust-lang | rust | 1,118,485,565 | 96,732 | rust-log-analyzer |
The job **`dist-x86_64-apple`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6305950280?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/8e1d6168d65dde432c242f62f035959e38311100/checks/6305950280/logs)
<details><summary><i>Click to see the possible cause of... | 2022-05-05T12:24:10 | 2022-05-12T19:31:49 | {} | COLLABORATOR |
rust-lang | rust | 1,125,350,455 | 96,732 | Kobzol | @bors try | 2022-05-12T19:31:58 | 2022-05-12T19:31:58 | {} | MEMBER |
rust-lang | rust | 1,125,354,662 | 96,991 | rust-log-analyzer |
The job **`mingw-check`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6412387982?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/75575e7bb7ebbaee87f495b8836e1f250e0dfd3d/checks/6412387982/logs)
<details><summary><i>Click to see the possible cause of the f... | 2022-05-12T19:37:12 | 2022-05-12T19:39:47 | {} | COLLABORATOR |
rust-lang | rust | 1,125,357,909 | 96,732 | Kobzol | @bors try | 2022-05-12T19:41:37 | 2022-05-12T19:41:37 | {} | MEMBER |
rust-lang | rust | 1,125,363,279 | 96,984 | ehuss | @bors retry
dist-aarch64-apple
The hosted runner: GitHub Actions 6 lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.
| 2022-05-12T19:49:08 | 2022-05-12T19:49:08 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,178,638 | 96,932 | joshtriplett | @bors r+ rollup | 2022-05-12T16:09:57 | 2022-05-12T16:09:57 | {} | MEMBER |
rust-lang | rust | 1,125,190,873 | 95,051 | wesleywiser | @bors try @rust-timer queue | 2022-05-12T16:23:11 | 2022-05-12T16:23:11 | {} | MEMBER |
rust-lang | rust | 1,125,229,993 | 96,910 | jsha | Thanks for the repro attempt! And sorry I forgot to include a link to the example page. Good sleuthing. :-)
Your comment made me recall I still have an old version of fira-sans.ttf locally installed from debugging https://github.com/rust-lang/docs.rs/issues/1669#issuecomment-1068396583. So this should be quite low p... | 2022-05-12T17:06:51 | 2022-05-12T17:06:51 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,290,496 | 96,978 | bors | :hourglass: Trying commit 588de49ce861165222eb39ce14942ea158bef945 with merge 031d87645f5dacc484cc4590a1aa9abc7409a80e...
<!-- homu: {"type":"TryBuildStarted","head_sha":"588de49ce861165222eb39ce14942ea158bef945","merge_sha":"031d87645f5dacc484cc4590a1aa9abc7409a80e"} --> | 2022-05-12T18:17:13 | 2022-05-12T18:17:13 | {} | COLLABORATOR |
rust-lang | rust | 1,125,322,191 | 96,989 | rust-log-analyzer |
The job **`x86_64-gnu-llvm-12`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6411605905?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/2b2dc5c035d2ae59628b1a215f5cbed1dbfdce15/checks/6411605905/logs)
<details><summary><i>Click to see the possible cause o... | 2022-05-12T18:56:20 | 2022-05-12T19:38:08 | {} | COLLABORATOR |
rust-lang | rust | 1,125,207,428 | 96,980 | strega-nil-ms | @nagisa true, the question was whether `fs::metadata(Path)` could use `FindFirstFileW()` instead of `CreateFileW()` followed by `GetFileInformationByHandle()`; that's how we're solving this in the C++ standard library.
> This function currently corresponds to the stat function on Unix and the GetFileAttributesEx fun... | 2022-05-12T16:40:58 | 2022-05-12T16:50:35 | {} | NONE |
rust-lang | rust | 1,125,233,230 | 96,984 | ehuss | @bors r+ p=1 | 2022-05-12T17:10:37 | 2022-05-12T17:10:37 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,286,809 | 96,969 | Kobzol | @bors try | 2022-05-12T18:12:44 | 2022-05-12T18:12:44 | {} | MEMBER |
rust-lang | rust | 1,125,345,874 | 96,984 | rust-log-analyzer |
A job failed! Check out the build log: [(web)](https://github.com/rust-lang-ci/rust/runs/6410848264?check_suite_focus=true) [(plain)](https://github.com/rust-lang-ci/rust/commit/757c12d56581a8f94e1b2a02e57224f6c109a17a/checks/6410848264/logs)
<details><summary><i>Click to see the possible cause of the failure (guesse... | 2022-05-12T19:26:05 | 2022-05-12T19:26:05 | {} | COLLABORATOR |
rust-lang | rust | 1,125,356,502 | 95,051 | rust-timer | Finished benchmarking commit (71cf7a7c42d5ea1f7979d30a273e0b7913cf188b): [comparison url](https://perf.rust-lang.org/compare.html?start=481db40311cdd241ae4d33f34f2f75732e44d8e8&end=71cf7a7c42d5ea1f7979d30a273e0b7913cf188b).
**Summary**:
- Primary benchmarks: mixed results
- Secondary benchmarks: mixed results
| ... | 2022-05-12T19:39:39 | 2022-05-12T19:39:39 | {} | COLLABORATOR |
rust-lang | rust | 1,125,366,505 | 96,732 | bors | :broken_heart: Test failed - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6412713089?check_suite_focus=true)
<!-- homu: {"type":"TryBuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/6412713089?check_suite_focus=true","builder_name":"checks-actions"} --> | 2022-05-12T19:52:36 | 2022-05-12T19:52:36 | {} | COLLABORATOR |
rust-lang | rust | 1,125,373,949 | 96,732 | rust-log-analyzer |
The job **`dist-x86_64-apple`** failed! Check out the build log: [(web)](https://github.com/rust-lang-ci/rust/runs/6412578231?check_suite_focus=true) [(plain)](https://github.com/rust-lang-ci/rust/commit/771ef42acff5fb9e0bc90317b84c8c28917b696f/checks/6412578231/logs)
<details><summary><i>Click to see the possible ca... | 2022-05-12T20:01:55 | 2022-05-12T20:02:06 | {} | COLLABORATOR |
rust-lang | rust | 1,125,380,057 | 94,954 | RalfJung | Cc @rust-lang/wg-const-eval
since this uses `rustc_allow_const_fn_unstable` | 2022-05-12T20:09:42 | 2022-05-12T20:09:42 | {
"+1": 1
} | MEMBER |
rust-lang | rust | 1,125,178,655 | 96,932 | bors | :pushpin: Commit 275812ad2cb0a5a9a8de88151438d1319a6f0704 has been approved by `joshtriplett`
<!-- @bors r=joshtriplett 275812ad2cb0a5a9a8de88151438d1319a6f0704 -->
<!-- homu: {"type":"Approved","sha":"275812ad2cb0a5a9a8de88151438d1319a6f0704","approver":"joshtriplett"} --> | 2022-05-12T16:09:58 | 2022-05-12T16:09:58 | {} | COLLABORATOR |
rust-lang | rust | 1,125,187,671 | 96,975 | RalfJung | I'll look into it; Monday is a bit late -- more incompat changes might pile up, making this all a lot harder to diagnose. | 2022-05-12T16:19:43 | 2022-05-12T16:19:43 | {} | MEMBER |
rust-lang | rust | 1,125,261,803 | 96,978 | lqd | @bors try | 2022-05-12T17:43:19 | 2022-05-12T17:43:19 | {} | MEMBER |
rust-lang | rust | 1,125,272,604 | 96,986 | rust-highfive | Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.
Please see [the contribution instructions](https://rustc-dev-guide.rust-lang.org/contributing.html) for more information.
| 2022-05-12T17:54:52 | 2022-05-12T17:54:52 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,296,355 | 81,759 | magnusuMET | I just encountered this issue in a crate of mine, where build artifacts from the asan build is reused for the doc tests, causing the linker errors | 2022-05-12T18:24:27 | 2022-05-12T18:24:27 | {} | NONE |
rust-lang | rust | 1,125,365,739 | 96,966 | bors | :pushpin: Commit ea33873c493ba99f0a9b3750e33d7317eab0af6c has been approved by `cuviper`
<!-- @bors r=cuviper ea33873c493ba99f0a9b3750e33d7317eab0af6c -->
<!-- homu: {"type":"Approved","sha":"ea33873c493ba99f0a9b3750e33d7317eab0af6c","approver":"cuviper"} --> | 2022-05-12T19:51:36 | 2022-05-12T19:51:36 | {} | COLLABORATOR |
rust-lang | rust | 1,125,368,275 | 96,732 | Kobzol | @bors try | 2022-05-12T19:55:02 | 2022-05-12T19:55:02 | {} | MEMBER |
rust-lang | rust | 1,125,201,366 | 96,982 | rust-highfive | r? @estebank
(rust-highfive has picked a reviewer for you, use r? to override) | 2022-05-12T16:34:06 | 2022-05-12T16:34:06 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,212,008 | 95,562 | rust-timer | Finished benchmarking commit (481db40311cdd241ae4d33f34f2f75732e44d8e8): [comparison url](https://perf.rust-lang.org/compare.html?start=18bd2dd5cda08b09ace6e37c1a0312e9b2bb4beb&end=481db40311cdd241ae4d33f34f2f75732e44d8e8).
**Summary**:
- Primary benchmarks: 🎉 relevant improvements found
- Secondary benchmarks: 🎉 r... | 2022-05-12T16:46:04 | 2022-05-12T16:46:04 | {
"hooray": 2
} | COLLABORATOR |
rust-lang | rust | 1,125,216,684 | 96,980 | ChrisDenton | Hm, changing `fs::metadata` is not something I'd be minded to do lightly. At least not without further investigation. Some questions that spring to mind:
* What happens if the user does not have permission to read the directory but does have permission to read the file?
* Can we get all the metadata that's needed? ... | 2022-05-12T16:51:31 | 2022-05-12T16:53:19 | {} | MEMBER |
rust-lang | rust | 1,125,253,937 | 96,974 | bors | :sunny: Test successful - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6410837747?check_suite_focus=true)
Approved by: matthiaskrgr
Pushing c6499fd9987a2b338892f56cea26c39a6fe64d18 to master...
<!-- homu: {"type":"BuildCompleted","approved_by":"matthiaskrgr","base_ref":"master","builders":{"checks-actions... | 2022-05-12T17:34:04 | 2022-05-12T17:34:04 | {} | COLLABORATOR |
rust-lang | rust | 1,125,271,166 | 96,978 | rust-log-analyzer |
The job **`dist-x86_64-msvc`** failed! Check out the build log: [(web)](https://github.com/rust-lang-ci/rust/runs/6410964875?check_suite_focus=true) [(plain)](https://github.com/rust-lang-ci/rust/commit/57b5bac113c6e1100592c1bf7d5a7fc61d74e332/checks/6410964875/logs)
<details><summary><i>Click to see the possible cau... | 2022-05-12T17:53:01 | 2022-05-12T18:28:59 | {} | COLLABORATOR |
rust-lang | rust | 1,125,169,004 | 95,826 | rust-log-analyzer |
The job **`x86_64-gnu-llvm-12`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6409000955?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/170e2ef1f038f6a070dc8cbb71ed705c4d8aea5e/checks/6409000955/logs)
<details><summary><i>Click to see the possible cause o... | 2022-05-12T16:00:40 | 2022-05-12T18:38:36 | {} | COLLABORATOR |
rust-lang | rust | 1,125,352,687 | 96,969 | bors | :sunny: Try build successful - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6412482994?check_suite_focus=true)
Build commit: 572ba4359edc03a746e930674acaf1b3752844d8 (`572ba4359edc03a746e930674acaf1b3752844d8`)
<!-- homu: {"type":"TryBuildCompleted","builders":{"checks-actions":"https://github.com/rust-la... | 2022-05-12T19:34:36 | 2022-05-12T19:34:36 | {} | COLLABORATOR |
rust-lang | rust | 1,125,368,369 | 96,732 | bors | :hourglass: Trying commit ab19f43ad135f1351a2e96ea38edcfde840ac340 with merge ea39a518964de0ac1b93a3d637ed012e889ad53d...
<!-- homu: {"type":"TryBuildStarted","head_sha":"ab19f43ad135f1351a2e96ea38edcfde840ac340","merge_sha":"ea39a518964de0ac1b93a3d637ed012e889ad53d"} --> | 2022-05-12T19:55:10 | 2022-05-12T19:55:10 | {} | COLLABORATOR |
rust-lang | rust | 1,125,380,383 | 95,850 | cjgillot | I'm not really sure that losing the capability is worth it, but at the same time I don't remember ever seeing an ICE triggered by this.
r? rust-lang/compiler | 2022-05-12T20:10:11 | 2022-05-12T20:10:11 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,178,069 | 96,970 | bors | :sunny: Try build successful - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6409627792?check_suite_focus=true)
Build commit: 3f7b27fe41ccd116a4c0829bd9a14b65bada4578 (`3f7b27fe41ccd116a4c0829bd9a14b65bada4578`)
<!-- homu: {"type":"TryBuildCompleted","builders":{"checks-actions":"https://github.com/rust-la... | 2022-05-12T16:09:23 | 2022-05-12T16:09:23 | {} | COLLABORATOR |
rust-lang | rust | 1,125,190,905 | 95,051 | rust-timer | Awaiting bors try build completion.
@rustbot label: +S-waiting-on-perf | 2022-05-12T16:23:13 | 2022-05-12T16:23:13 | {} | COLLABORATOR |
rust-lang | rust | 1,125,199,968 | 96,970 | cjgillot | @oli-obk I don't understand your comment about anonymous lifetimes.
> I think it's fine to only do this for named lifetimes, as all others are forbidden anyway (`'_` and just leaving them out is already triggering other errors).
To be on the safe side, I'd rather have named and anonymous lifetimes treated the sam... | 2022-05-12T16:32:32 | 2022-05-12T16:32:32 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,221,735 | 96,980 | strega-nil-ms | @ChrisDenton given that it's reading the directory, it should make performance better (assuming one doesn't do the double call thing).
I'm personally not that invested, I just thought I'd share with y'all since I have to fix this bug for the STL 😛 | 2022-05-12T16:57:34 | 2022-05-12T16:57:34 | {} | NONE |
rust-lang | rust | 1,125,233,077 | 96,984 | rust-highfive | :warning: **Warning** :warning:
* These commits modify **submodules**. | 2022-05-12T17:10:29 | 2022-05-12T17:10:29 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,245,372 | 95,845 | scottmcm | A thought on the hash conversation: What if we used a full cryptographic hash (SHA3-256, for the sake of argument), but rather than embedding the full thing in `TypeId`, we treat the parts that don't fit in a `usize` the way this PR treats `TypeManglingStr`?
Thus on 32-bit we have `struct TypeId(usize, &'static [usi... | 2022-05-12T17:24:26 | 2022-05-12T17:24:26 | {
"+1": 1
} | MEMBER |
rust-lang | rust | 1,125,266,512 | 95,051 | rust-timer | Queued 71cf7a7c42d5ea1f7979d30a273e0b7913cf188b with parent 481db40311cdd241ae4d33f34f2f75732e44d8e8, future [comparison URL](https://perf.rust-lang.org/compare.html?start=481db40311cdd241ae4d33f34f2f75732e44d8e8&end=71cf7a7c42d5ea1f7979d30a273e0b7913cf188b). | 2022-05-12T17:48:58 | 2022-05-12T17:48:58 | {} | COLLABORATOR |
rust-lang | rust | 1,125,275,420 | 96,980 | ChrisDenton | > What happens if the user does not have permission to read the directory but does have permission to read the file?
Ok I tested with two users. For the sake of this example, I'll call them "Admin" and "User".
As Admin I created a directory and denied User all access. Within the directory I then created a "test.t... | 2022-05-12T17:58:33 | 2022-05-12T17:59:00 | {} | MEMBER |
rust-lang | rust | 1,125,300,822 | 96,989 | rust-highfive | r? @davidtwco
(rust-highfive has picked a reviewer for you, use r? to override) | 2022-05-12T18:29:58 | 2022-05-12T18:29:58 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,346,675 | 96,991 | rust-highfive | r? @nagisa
(rust-highfive has picked a reviewer for you, use r? to override) | 2022-05-12T19:27:08 | 2022-05-12T19:27:08 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,351,002 | 96,973 | oli-obk | There's a small perf hit. Without running cachegrind it's hard to tell, i'll check tomorrow. I agree with Ralf tho, the last commit should be reverted and benchmarked on its own. | 2022-05-12T19:32:39 | 2022-05-12T19:32:39 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,225,261 | 96,980 | ChrisDenton | It's great that we have this report! I just want to make sure we investigate fully before making changes that may affect users of the standard library.
I'll also note we do have the unstable [std::fs::try_exists](https://doc.rust-lang.org/std/fs/fn.try_exists.html) whose behaviour can change. | 2022-05-12T17:01:32 | 2022-05-12T17:01:32 | {} | MEMBER |
rust-lang | rust | 1,125,254,077 | 96,984 | bors | :hourglass: Testing commit e353579b8b97c428e8b2850ac2bccdf26269d6b2 with merge 757c12d56581a8f94e1b2a02e57224f6c109a17a...
<!-- homu: {"type":"BuildStarted","head_sha":"e353579b8b97c428e8b2850ac2bccdf26269d6b2","merge_sha":"757c12d56581a8f94e1b2a02e57224f6c109a17a"} --> | 2022-05-12T17:34:14 | 2022-05-12T17:34:14 | {} | COLLABORATOR |
rust-lang | rust | 1,125,266,492 | 95,051 | bors | :sunny: Try build successful - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6411036062?check_suite_focus=true)
Build commit: 71cf7a7c42d5ea1f7979d30a273e0b7913cf188b (`71cf7a7c42d5ea1f7979d30a273e0b7913cf188b`)
<!-- homu: {"type":"TryBuildCompleted","builders":{"checks-actions":"https://github.com/rust-la... | 2022-05-12T17:48:56 | 2022-05-12T17:48:56 | {} | COLLABORATOR |
rust-lang | rust | 1,125,290,067 | 96,978 | lqd | @bors try | 2022-05-12T18:16:44 | 2022-05-12T18:16:44 | {} | MEMBER |
rust-lang | rust | 1,125,350,883 | 96,732 | bors | :hourglass: Trying commit 968beaf291e14ef8c95397b3e5c279a339c5ac2d with merge d007f66a589d5f8534d710af7fdf5c480fded63b...
<!-- homu: {"type":"TryBuildStarted","head_sha":"968beaf291e14ef8c95397b3e5c279a339c5ac2d","merge_sha":"d007f66a589d5f8534d710af7fdf5c480fded63b"} --> | 2022-05-12T19:32:30 | 2022-05-12T19:32:30 | {} | COLLABORATOR |
rust-lang | rust | 1,125,365,561 | 96,966 | cuviper | @bors r+ rollup=never | 2022-05-12T19:51:33 | 2022-05-12T19:51:33 | {} | MEMBER |
rust-lang | rust | 1,122,697,874 | 95,474 | rfcbot | Team member @nikomatsakis has proposed to merge this. The next step is review by the rest of the tagged team members:
* [x] @Aaron1011
* [ ] @cjgillot
* [x] @davidtwco
* [x] @eddyb
* [x] @estebank
* [ ] @lcnr
* [ ] @matthewjasper
* [ ] @michaelwoerister
* [ ] @nagisa
* [x] @nikomatsakis
* [ ] @oli-obk
* [ ] @petrochen... | 2022-05-10T17:53:11 | 2022-05-12T16:01:55 | {} | NONE |
rust-lang | rust | 1,125,174,505 | 96,979 | rust-highfive | Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any `rust-lang/rust` public library APIs then please comment with `r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs` to request review from a libs-api team reviewer. If you're unsure where your change falls no wo... | 2022-05-12T16:05:51 | 2022-05-12T16:05:51 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,167,397 | 95,474 | rfcbot | Team member @nikomatsakis has proposed to merge this. The next step is review by the rest of the tagged team members:
* [ ] @cramertj
* [x] @joshtriplett
* [x] @nikomatsakis
* [x] @pnkfelix
* [ ] @scottmcm
No concerns currently listed.
Once a majority of reviewers approve (and at most 2 approvals are outstanding), t... | 2022-05-12T15:59:03 | 2022-05-12T16:07:17 | {} | NONE |
rust-lang | rust | 1,125,189,871 | 95,826 | RalfJung | > What's the miri_unleashed mean in src/test/ui/consts/miri_unleashed/ptr_arith.rs? It looks like the changes in [a0a7c03](https://github.com/rust-lang/rust/pull/95826/commits/a0a7c03f7bdc768524a7eb9e5a9b580e9a3fd29d) made it fail, but I'm not exactly sure why (or how it's even running a Miri test).
miri_unleashed m... | 2022-05-12T16:22:02 | 2022-05-12T16:22:02 | {} | MEMBER |
rust-lang | rust | 1,125,304,513 | 96,892 | oli-obk | Yea. Idk what's happening there, need to rerun cachegrind to see what effect my changes had.
| 2022-05-12T18:34:28 | 2022-05-12T18:34:28 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,190,829 | 96,973 | RalfJung | > Commit 3 replaces BLOCK_SIZE with BLOCK_SIZE_POW, so that we can use shiftings instead of multiply and divide operations, which can save a little time.
Did you benchmark this? I keep hearing compilers know how to compile multiply/divide by constants much better than humans do.
This makes the code a lot less rea... | 2022-05-12T16:23:08 | 2022-05-12T16:24:13 | {
"+1": 1
} | MEMBER |
rust-lang | rust | 1,125,194,528 | 96,972 | nagisa | Looks like its probably that, yeah, although in my case I've seen the same problem present itself when calling methods directly too.
Duplicate of #77304 | 2022-05-12T16:26:53 | 2022-05-12T16:26:53 | {} | MEMBER |
rust-lang | rust | 1,125,197,783 | 96,970 | oli-obk | @craterbot check | 2022-05-12T16:30:15 | 2022-05-12T16:30:15 | {} | CONTRIBUTOR |
rust-lang | rust | 1,125,198,130 | 96,970 | craterbot | :construction: Experiment **`pr-96970`** is now **running**
:information_source: **Crater** is a tool to run experiments across parts of the Rust ecosystem. [Learn more](https://github.com/rust-lang/crater) | 2022-05-12T16:30:36 | 2022-05-12T16:30:36 | {} | COLLABORATOR |
rust-lang | rust | 1,124,359,309 | 96,957 | rust-log-analyzer |
The job **`x86_64-gnu-llvm-12`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6396065699?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/bb9814d483eca95a587d85f831b75aa1408dc2f8/checks/6396065699/logs)
<details><summary><i>Click to see the possible cause o... | 2022-05-11T22:43:16 | 2022-05-12T17:12:30 | {} | COLLABORATOR |
rust-lang | rust | 1,125,250,133 | 96,928 | kingdido999 | @rustbot claim | 2022-05-12T17:29:56 | 2022-05-12T17:29:56 | {} | NONE |
rust-lang | rust | 1,125,286,950 | 96,969 | bors | :hourglass: Trying commit 139f3bc0ecad20eadb1e61ebb4ad1d517ff37bcb with merge 572ba4359edc03a746e930674acaf1b3752844d8...
<!-- homu: {"type":"TryBuildStarted","head_sha":"139f3bc0ecad20eadb1e61ebb4ad1d517ff37bcb","merge_sha":"572ba4359edc03a746e930674acaf1b3752844d8"} --> | 2022-05-12T18:12:54 | 2022-05-12T18:12:54 | {} | COLLABORATOR |
rust-lang | rust | 1,125,298,928 | 96,978 | bors | :broken_heart: Test failed - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6411570759?check_suite_focus=true)
<!-- homu: {"type":"TryBuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/6411570759?check_suite_focus=true","builder_name":"checks-actions"} --> | 2022-05-12T18:27:37 | 2022-05-12T18:27:37 | {} | COLLABORATOR |
rust-lang | rust | 1,119,498,143 | 96,591 | rust-log-analyzer |
The job **`x86_64-gnu-llvm-12`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6321405657?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/44f633cd3aa7b2bd2e31244309381098824191e3/checks/6321405657/logs)
<details><summary><i>Click to see the possible cause o... | 2022-05-06T11:02:35 | 2022-05-12T18:43:01 | {} | COLLABORATOR |
rust-lang | rust | 1,125,358,022 | 96,732 | bors | :hourglass: Trying commit 5b632ff3b6692440b2250eabdc90ba294df2efab with merge 771ef42acff5fb9e0bc90317b84c8c28917b696f...
<!-- homu: {"type":"TryBuildStarted","head_sha":"5b632ff3b6692440b2250eabdc90ba294df2efab","merge_sha":"771ef42acff5fb9e0bc90317b84c8c28917b696f"} --> | 2022-05-12T19:41:46 | 2022-05-12T19:41:46 | {} | COLLABORATOR |
rust-lang | rust | 1,125,363,373 | 96,984 | bors | :hourglass: Testing commit e353579b8b97c428e8b2850ac2bccdf26269d6b2 with merge a5ad0d29a401007b51715852cc702e441ac2248c...
<!-- homu: {"type":"BuildStarted","head_sha":"e353579b8b97c428e8b2850ac2bccdf26269d6b2","merge_sha":"a5ad0d29a401007b51715852cc702e441ac2248c"} --> | 2022-05-12T19:49:15 | 2022-05-12T19:49:15 | {} | COLLABORATOR |
rust-lang | rust | 1,125,177,331 | 96,948 | bors | :pushpin: Commit cdbfd3e01136948e2ca7947c6eb37914b296cb2d has been approved by `joshtriplett`
<!-- @bors r=joshtriplett cdbfd3e01136948e2ca7947c6eb37914b296cb2d -->
<!-- homu: {"type":"Approved","sha":"cdbfd3e01136948e2ca7947c6eb37914b296cb2d","approver":"joshtriplett"} --> | 2022-05-12T16:08:36 | 2022-05-12T16:08:36 | {} | COLLABORATOR |
rust-lang | rust | 1,125,233,254 | 96,984 | bors | :pushpin: Commit e353579b8b97c428e8b2850ac2bccdf26269d6b2 has been approved by `ehuss`
<!-- @bors r=ehuss e353579b8b97c428e8b2850ac2bccdf26269d6b2 -->
<!-- homu: {"type":"Approved","sha":"e353579b8b97c428e8b2850ac2bccdf26269d6b2","approver":"ehuss"} --> | 2022-05-12T17:10:39 | 2022-05-12T17:10:39 | {} | COLLABORATOR |
rust-lang | rust | 1,125,355,240 | 96,969 | Kobzol | I was a bit pessimistic towards `ninja` before, as I didn't realize that the `sccache` wasn't primed, so the build was slower. But anyways the build is not faster with `ninja`, it's on par with `make`. So this is not worth it. | 2022-05-12T19:37:55 | 2022-05-12T19:37:55 | {} | MEMBER |
rust-lang | rust | 1,126,777,549 | 97,045 | bors | :sunny: Try build successful - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6435863670?check_suite_focus=true)
Build commit: 27e0a1ccff81e0c702800c4e46627bd584cded41 (`27e0a1ccff81e0c702800c4e46627bd584cded41`)
<!-- homu: {"type":"TryBuildCompleted","builders":{"checks-actions":"https://github.com/rust-la... | 2022-05-14T17:10:06 | 2022-05-14T17:10:06 | {} | COLLABORATOR |
rust-lang | rust | 1,126,791,410 | 97,047 | rodrimati1992 | A reduced version:
```rust
#![feature(adt_const_params, generic_const_exprs)]
pub struct Changes<const CHANGES: &'static [&'static str]>
where
[(); CHANGES.len()]:,
{
changes: [usize; CHANGES.len()],
}
impl<const CHANGES: &'static [&'static str]> Changes<CHANGES>
where
[(); CHANGES.len()]:,
... | 2022-05-14T18:34:44 | 2022-05-14T18:37:59 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,811,150 | 96,713 | petrochenkov | r? @notriddle | 2022-05-14T21:04:56 | 2022-05-14T21:04:56 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,828,424 | 96,455 | bors | :broken_heart: Test failed - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6437632356?check_suite_focus=true)
<!-- homu: {"type":"BuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/6437632356?check_suite_focus=true","builder_name":"checks-actions"} --> | 2022-05-14T23:53:06 | 2022-05-14T23:53:06 | {} | COLLABORATOR |
rust-lang | rust | 1,126,837,374 | 95,953 | JakobDegen | Thanks for the suggestion @scottmcm , added that test. Also rebased | 2022-05-15T01:21:43 | 2022-05-15T01:21:43 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,754,245 | 96,883 | bors | :pushpin: Commit 06a1e8854c95d5be5db0bebe4630c691b604e792 has been approved by `oli-obk`
<!-- @bors r=oli-obk 06a1e8854c95d5be5db0bebe4630c691b604e792 -->
<!-- homu: {"type":"Approved","sha":"06a1e8854c95d5be5db0bebe4630c691b604e792","approver":"oli-obk"} --> | 2022-05-14T16:11:33 | 2022-05-14T16:11:33 | {} | COLLABORATOR |
rust-lang | rust | 1,126,777,559 | 97,045 | rust-timer | Queued 27e0a1ccff81e0c702800c4e46627bd584cded41 with parent 8019fa0dc08bb0e26d28ce29c3983408ffb2feac, future [comparison URL](https://perf.rust-lang.org/compare.html?start=8019fa0dc08bb0e26d28ce29c3983408ffb2feac&end=27e0a1ccff81e0c702800c4e46627bd584cded41). | 2022-05-14T17:10:07 | 2022-05-14T17:10:07 | {} | COLLABORATOR |
rust-lang | rust | 1,126,743,941 | 96,324 | rust-log-analyzer |
The job **`mingw-check`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6435518250?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/c2fc17574318c46197e0ae690263663edfed88f4/checks/6435518250/logs)
<details><summary><i>Click to see the possible cause of the f... | 2022-05-14T16:04:05 | 2022-05-14T17:23:11 | {} | COLLABORATOR |
rust-lang | rust | 1,126,791,024 | 96,150 | est31 | Another data point: [syn's changes after the PR was merged](https://github.com/dtolnay/syn/compare/1.0.93...1.0.94). | 2022-05-14T18:32:20 | 2022-05-14T18:32:20 | {} | MEMBER |
rust-lang | rust | 1,126,792,577 | 86,822 | mystor | This patch stack came up again lately, so I figured I'd rebase it | 2022-05-14T18:42:00 | 2022-05-14T18:42:00 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,801,005 | 95,576 | rust-timer | Awaiting bors try build completion.
@rustbot label: +S-waiting-on-perf | 2022-05-14T19:42:24 | 2022-05-14T19:42:24 | {} | COLLABORATOR |
rust-lang | rust | 1,126,810,839 | 97,002 | ehuss | That's strange. For some reason, the `edition` field is not being picked up. Are those error messages coming directly from running cargo in a terminal? Or are you using something else? I noticed you say you have rust-analyzer and vscode, perhaps you are somehow checking the code in there? If so, what exact steps are y... | 2022-05-14T21:02:22 | 2022-05-14T21:02:22 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,812,500 | 96,496 | bors | :broken_heart: Test failed - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6437006041?check_suite_focus=true)
<!-- homu: {"type":"TryBuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/6437006041?check_suite_focus=true","builder_name":"checks-actions"} --> | 2022-05-14T21:16:36 | 2022-05-14T21:16:36 | {} | COLLABORATOR |
rust-lang | rust | 1,126,829,826 | 97,001 | vincenzopalazzo | @rustbot claim | 2022-05-15T00:06:56 | 2022-05-15T00:06:56 | {} | MEMBER |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.