owner stringclasses 15
values | repo stringclasses 15
values | id int64 116k 4.21B | issue_number int32 1 180k | author stringlengths 0 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-04-09 03:22:08 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-04-09 03:28:07 | reactions unknown | author_association stringclasses 7
values |
|---|---|---|---|---|---|---|---|---|---|
rust-lang | rust | 1,126,745,139 | 78,260 | Patryk27 | fwiw, I think this was solved after https://github.com/rust-lang/rust/pull/96845, too 🙂 | 2022-05-14T16:07:48 | 2022-05-14T16:07:48 | {
"+1": 1
} | CONTRIBUTOR |
rust-lang | rust | 1,126,826,054 | 71,684 | soc | >> So config_dir(<APP_INFO>), not home_dir()?
> it is perfectly reasonable to need to store user preferences in locations other than the 'config' dir
My comment – before your creative citation approach – reflects that.
> No???? What in the world does the downloads directory have to do with documents????
Cal... | 2022-05-14T23:22:55 | 2022-05-14T23:22:55 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,830,522 | 97,044 | rust-timer | Finished benchmarking commit (70b3681bf621bc0de91ffab711b2350068b4c466): [comparison url](https://perf.rust-lang.org/compare.html?start=b36be12d979de84a063f617295674a40d6ddf16d&end=70b3681bf621bc0de91ffab711b2350068b4c466).
**Summary**: This benchmark run did not return any relevant results.
If you disagree with this... | 2022-05-15T00:12:29 | 2022-05-15T00:12:29 | {} | COLLABORATOR |
rust-lang | rust | 1,126,841,691 | 96,602 | Mark-Simulacrum | @bors r+ | 2022-05-15T01:59:04 | 2022-05-15T01:59:04 | {
"hooray": 1
} | MEMBER |
rust-lang | rust | 1,126,816,015 | 96,958 | jsha | @bors r+ rollup | 2022-05-14T21:46:21 | 2022-05-14T21:46:21 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,822,854 | 96,991 | compiler-errors | @bors try @rust-timer queue | 2022-05-14T22:48:41 | 2022-05-14T22:48:41 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,366,640 | 71,684 | soc | >> What is the use case for getting the "home" directory?
> Myriad, off the top of my head:
>
> 1. Storing user preferences
So `config_dir(<APP_INFO>)`, not `home_dir()`?
> 2. Running a program installation in environments that don't provide administrator access
So `config_dir(<APP_INFO>)`/`data_... | 2022-05-13T19:14:02 | 2022-05-14T23:13:12 | {
"-1": 3,
"confused": 2
} | CONTRIBUTOR |
rust-lang | rust | 1,126,792,096 | 97,047 | Kixiron | The other ICE block is also standalone
```rust
#![feature(adt_const_params, generic_const_exprs)]
pub struct Changes<const CHANGES: &'static [&'static str]>
where
[(); CHANGES.len()]:,
{
changes: [usize; CHANGES.len()],
}
impl<const CHANGES: &'static [&'static str]> Changes<CHANGES>
where
[()... | 2022-05-14T18:39:11 | 2022-05-14T18:42:34 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,808,359 | 97,044 | bors | :hourglass: Testing commit 9a4285c2c647c017a528cbb3ec5cc18558034954 with merge 70b3681bf621bc0de91ffab711b2350068b4c466...
<!-- homu: {"type":"BuildStarted","head_sha":"9a4285c2c647c017a528cbb3ec5cc18558034954","merge_sha":"70b3681bf621bc0de91ffab711b2350068b4c466"} --> | 2022-05-14T20:43:47 | 2022-05-14T20:43:47 | {} | COLLABORATOR |
rust-lang | rust | 1,107,529,307 | 94,857 | petrochenkov | Blocked on https://github.com/rust-lang/rust/pull/96713. | 2022-04-23T16:21:16 | 2022-05-14T21:06:07 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,814,558 | 86,822 | rust-timer | Queued 6a774941b6e5cc24047cc184c5a3d371f7664ed1 with parent b36be12d979de84a063f617295674a40d6ddf16d, future [comparison URL](https://perf.rust-lang.org/compare.html?start=b36be12d979de84a063f617295674a40d6ddf16d&end=6a774941b6e5cc24047cc184c5a3d371f7664ed1). | 2022-05-14T21:34:18 | 2022-05-14T21:34:18 | {} | COLLABORATOR |
rust-lang | rust | 1,126,835,499 | 97,051 | rust-highfive | Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.
Please see [the contribution instructions](https://rustc-dev-guide.rust-lang.org/contributing.html) for more information.
| 2022-05-15T01:00:52 | 2022-05-15T01:00:52 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,790,234 | 97,039 | bors | :sunny: Test successful - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6436244572?check_suite_focus=true)
Approved by: jackh726
Pushing b36be12d979de84a063f617295674a40d6ddf16d to master...
<!-- homu: {"type":"BuildCompleted","approved_by":"jackh726","base_ref":"master","builders":{"checks-actions":"https... | 2022-05-14T18:28:08 | 2022-05-14T18:28:08 | {} | COLLABORATOR |
rust-lang | rust | 1,126,790,265 | 97,040 | bors | :hourglass: Testing commit 7d0f04a21845bf81575393c49f7e05a9bc596cfa with merge 30a51465e202ee8e69090adfbb328de8a7c96843...
<!-- homu: {"type":"BuildStarted","head_sha":"7d0f04a21845bf81575393c49f7e05a9bc596cfa","merge_sha":"30a51465e202ee8e69090adfbb328de8a7c96843"} --> | 2022-05-14T18:28:19 | 2022-05-14T18:28:19 | {} | COLLABORATOR |
rust-lang | rust | 1,126,803,394 | 96,496 | rust-timer | Awaiting bors try build completion.
@rustbot label: +S-waiting-on-perf | 2022-05-14T20:02:25 | 2022-05-14T20:02:25 | {} | COLLABORATOR |
rust-lang | rust | 1,126,803,414 | 96,496 | bors | :hourglass: Trying commit ab781757fe65ccafa2f569a21d520216ef113857 with merge 4f76fc078a48495558dcb392e9d2d01f09d0e073...
<!-- homu: {"type":"TryBuildStarted","head_sha":"ab781757fe65ccafa2f569a21d520216ef113857","merge_sha":"4f76fc078a48495558dcb392e9d2d01f09d0e073"} --> | 2022-05-14T20:02:31 | 2022-05-14T20:02:31 | {} | COLLABORATOR |
rust-lang | rust | 1,126,804,364 | 86,822 | eddyb | @bors try @rust-timer queue | 2022-05-14T20:10:07 | 2022-05-14T20:10:07 | {} | MEMBER |
rust-lang | rust | 1,126,808,331 | 97,040 | bors | :sunny: Test successful - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6436858987?check_suite_focus=true)
Approved by: jackh726
Pushing 30a51465e202ee8e69090adfbb328de8a7c96843 to beta...
<!-- homu: {"type":"BuildCompleted","approved_by":"jackh726","base_ref":"beta","builders":{"checks-actions":"https://g... | 2022-05-14T20:43:39 | 2022-05-14T20:43:39 | {} | COLLABORATOR |
rust-lang | rust | 1,126,826,089 | 96,455 | bors | :hourglass: Testing commit a03f15a276b407197b78c4cf304801405f6d5e33 with merge 504e77c0f63fbc1a9a87e9fd62d5cf2468e446b6...
<!-- homu: {"type":"BuildStarted","head_sha":"a03f15a276b407197b78c4cf304801405f6d5e33","merge_sha":"504e77c0f63fbc1a9a87e9fd62d5cf2468e446b6"} --> | 2022-05-14T23:23:14 | 2022-05-14T23:23:14 | {} | COLLABORATOR |
rust-lang | rust | 1,126,743,876 | 96,324 | berendjan | 2 questions:
I hardcoded the port number but this is probably a bad idea since other tests might accidentally use the same port number and this might lead to flaky tests (port being used at same time). `library/std/src/net/test.rs` uses `next_test_ip4()`, but this is not pub and not available in the os mod. What is a... | 2022-05-14T16:03:48 | 2022-05-14T16:03:48 | {} | NONE |
rust-lang | rust | 1,126,771,950 | 97,044 | bors | :pushpin: Commit 9a4285c2c647c017a528cbb3ec5cc18558034954 has been approved by `Mark-Simulacrum`
<!-- @bors r=Mark-Simulacrum 9a4285c2c647c017a528cbb3ec5cc18558034954 -->
<!-- homu: {"type":"Approved","sha":"9a4285c2c647c017a528cbb3ec5cc18558034954","approver":"Mark-Simulacrum"} --> | 2022-05-14T16:34:05 | 2022-05-14T16:34:05 | {} | COLLABORATOR |
rust-lang | rust | 1,126,787,696 | 97,045 | lqd | > Perf bot is currently broken
note: only the bootstrap rustc benchmark is currently broken.
| 2022-05-14T18:11:44 | 2022-05-14T18:11:44 | {} | MEMBER |
rust-lang | rust | 1,126,791,220 | 87,074 | sunfishcode | Looking into this, I noticed that the io-lifetimes crate's view mechanism is actually unsound. There's no guarantee that the `Into<OwnedFd>` for a type return the *same* fd as the `From<OwnedFd>`, so if the fd can be reassigned to a different fd, it can cause double closes of the original fd. Follow [this PR for detail... | 2022-05-14T18:33:23 | 2022-05-14T18:33:23 | {
"+1": 1
} | MEMBER |
rust-lang | rust | 1,126,798,060 | 93,960 | jhpratt | I asked on Zulip if there was anyone interested in taking this PR over (no responses yet). I have other priorities in the compiler, and I know there are still some design decisions to be made for `impl const Trait`, so this isn't a blocker of anything.
If anyone would like to take this over, please say so! If not, I... | 2022-05-14T19:20:33 | 2022-05-14T19:20:33 | {} | MEMBER |
rust-lang | rust | 1,126,798,512 | 90,409 | oli-obk | The example in your linked comment didn't ICE before and doesn't now. It links to a different issue which ICEs, did you mean that? | 2022-05-14T19:24:18 | 2022-05-14T19:24:18 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,798,898 | 96,324 | rust-log-analyzer |
The job **`x86_64-gnu-llvm-12`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6436387513?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/bc5b947d77b5cec31e561bab4cda240119c921d3/checks/6436387513/logs)
<details><summary><i>Click to see the possible cause o... | 2022-05-14T19:27:01 | 2022-05-14T19:58:17 | {} | COLLABORATOR |
rust-lang | rust | 1,126,804,389 | 86,822 | bors | :hourglass: Trying commit 92b5d2baf2324faf392a67e8805e0b4bf7aeb20c with merge 6a774941b6e5cc24047cc184c5a3d371f7664ed1...
<!-- homu: {"type":"TryBuildStarted","head_sha":"92b5d2baf2324faf392a67e8805e0b4bf7aeb20c","merge_sha":"6a774941b6e5cc24047cc184c5a3d371f7664ed1"} --> | 2022-05-14T20:10:15 | 2022-05-14T20:10:15 | {} | COLLABORATOR |
rust-lang | rust | 1,126,811,212 | 97,050 | GuillaumeGomez | @bors r+ rollup=never p=4 | 2022-05-14T21:05:24 | 2022-05-14T21:05:24 | {} | MEMBER |
rust-lang | rust | 1,126,822,038 | 86,822 | rust-timer | Finished benchmarking commit (6a774941b6e5cc24047cc184c5a3d371f7664ed1): [comparison url](https://perf.rust-lang.org/compare.html?start=b36be12d979de84a063f617295674a40d6ddf16d&end=6a774941b6e5cc24047cc184c5a3d371f7664ed1).
**Summary**:
- Primary benchmarks: mixed results
- Secondary benchmarks: mixed results
| ... | 2022-05-14T22:39:42 | 2022-05-14T22:39:42 | {} | COLLABORATOR |
rust-lang | rust | 1,126,754,179 | 96,883 | jackh726 | @bors r=oli-obk | 2022-05-14T16:11:31 | 2022-05-14T16:11:31 | {} | MEMBER |
rust-lang | rust | 1,126,771,945 | 97,044 | Mark-Simulacrum | @bors r+ p=1 | 2022-05-14T16:34:04 | 2022-05-14T16:34:04 | {} | MEMBER |
rust-lang | rust | 1,126,781,718 | 96,324 | the8472 | > Also not sure how to properly re-export something, is
>
> ```rust
> pub use super::linux::net::TcpStreamExt;
> ```
>
> correct?
That won't work because the linux module is only conditionally available behind `cfg` flags. Instead you'll need to have this in an internal common module behind a flag for both l... | 2022-05-14T17:34:31 | 2022-05-14T17:34:31 | {} | MEMBER |
rust-lang | rust | 1,126,799,925 | 97,039 | rust-timer | Finished benchmarking commit (b36be12d979de84a063f617295674a40d6ddf16d): [comparison url](https://perf.rust-lang.org/compare.html?start=2d691170885b32502b391b8b1a0d54d2419a5653&end=b36be12d979de84a063f617295674a40d6ddf16d).
**Summary**: This benchmark run did not return any relevant results.
If you disagree with this... | 2022-05-14T19:34:36 | 2022-05-14T19:34:36 | {} | COLLABORATOR |
rust-lang | rust | 1,126,815,150 | 97,050 | rust-log-analyzer |
The job **`x86_64-gnu-tools`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6436952713?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/439ddd419a036c6aa21b8138884c777edbf9ef4a/checks/6436952713/logs)
<details><summary><i>Click to see the possible cause of ... | 2022-05-14T21:38:01 | 2022-05-14T21:38:01 | {} | COLLABORATOR |
rust-lang | rust | 1,126,820,263 | 97,050 | klensy | #96455 isn't r+ | 2022-05-14T22:20:34 | 2022-05-14T22:20:34 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,828,443 | 96,883 | bors | :hourglass: Testing commit 06a1e8854c95d5be5db0bebe4630c691b604e792 with merge 2a8a0fc4237da544aca0d6631ee467891caad9ad...
<!-- homu: {"type":"BuildStarted","head_sha":"06a1e8854c95d5be5db0bebe4630c691b604e792","merge_sha":"2a8a0fc4237da544aca0d6631ee467891caad9ad"} --> | 2022-05-14T23:53:14 | 2022-05-14T23:53:14 | {} | COLLABORATOR |
rust-lang | rust | 1,126,731,609 | 97,040 | rust-log-analyzer |
The job **`x86_64-gnu-llvm-12`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6435046987?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/65911211a118437e177530e0b2148b3fed555d06/checks/6435046987/logs)
<details><summary><i>Click to see the possible cause o... | 2022-05-14T14:58:35 | 2022-05-14T15:25:44 | {} | COLLABORATOR |
rust-lang | rust | 1,126,773,395 | 87,074 | the8472 | reading and writing aren't always the most interesting things though. e.g. if you have a directory fd you want to pass it temporarily to cap-std's `Dir`. If you have an unknown fd you might want to temporarily turn it into a `File` to call `metadata()` to figure out what kind of fd it is and things like that.
Anyway... | 2022-05-14T16:44:14 | 2022-05-14T16:44:14 | {} | MEMBER |
rust-lang | rust | 1,126,781,095 | 80,967 | Xiretza | Looks like this got stabilized in #96628, can that be added to the OP under "Stabilization PR"? | 2022-05-14T17:30:49 | 2022-05-14T17:30:49 | {
"+1": 2
} | CONTRIBUTOR |
rust-lang | rust | 453,789,956 | 56,056 | mirh | SetDefaultDllDirectories is **not** a security feature.
https://web.archive.org/web/20190113103607/https://blogs.msdn.microsoft.com/oldnewthing/20170126-00/?p=95265#comments | 2019-01-12T23:48:21 | 2022-05-14T18:44:34 | {
"+1": 2
} | NONE |
rust-lang | rust | 1,126,811,215 | 97,050 | bors | :pushpin: Commit 439ddd419a036c6aa21b8138884c777edbf9ef4a has been approved by `GuillaumeGomez`
<!-- @bors r=GuillaumeGomez 439ddd419a036c6aa21b8138884c777edbf9ef4a -->
<!-- homu: {"type":"Approved","sha":"439ddd419a036c6aa21b8138884c777edbf9ef4a","approver":"GuillaumeGomez"} --> | 2022-05-14T21:05:25 | 2022-05-14T21:05:25 | {} | COLLABORATOR |
rust-lang | rust | 1,126,770,390 | 78,260 | oli-obk | Nice! Thank you | 2022-05-14T16:23:33 | 2022-05-14T16:23:33 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,774,823 | 96,345 | rust-timer | Finished benchmarking commit (2d691170885b32502b391b8b1a0d54d2419a5653): [comparison url](https://perf.rust-lang.org/compare.html?start=8019fa0dc08bb0e26d28ce29c3983408ffb2feac&end=2d691170885b32502b391b8b1a0d54d2419a5653).
**Summary**:
- Primary benchmarks: no relevant changes found
- Secondary benchmarks: 😿 releva... | 2022-05-14T16:54:01 | 2022-05-14T16:54:01 | {} | COLLABORATOR |
rust-lang | rust | 1,126,650,281 | 95,576 | rust-log-analyzer |
The job **`x86_64-gnu-llvm-12`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6432660959?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/499b429204c0fd3a9614ba6c89fa190519d12cd6/checks/6432660959/logs)
<details><summary><i>Click to see the possible cause o... | 2022-05-14T06:05:24 | 2022-05-14T17:40:12 | {} | COLLABORATOR |
rust-lang | rust | 1,126,815,652 | 96,496 | c410-f3r | > The job **`dist-x86_64-linux`** failed! Check out the build log: [(web)](https://github.com/rust-lang-ci/rust/runs/6436678509?check_suite_focus=true) [(plain)](https://github.com/rust-lang-ci/rust/commit/4f76fc078a48495558dcb392e9d2d01f09d0e073/checks/6436678509/logs)
> Click to see the possible cause of the failure... | 2022-05-14T21:43:05 | 2022-05-14T22:38:21 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,822,864 | 96,991 | bors | :hourglass: Trying commit 2b7d989fee1298f640debd5eb1dbb7d683867390 with merge 72cca280044a72eb76a39cef9abc6f294209e98c...
<!-- homu: {"type":"TryBuildStarted","head_sha":"2b7d989fee1298f640debd5eb1dbb7d683867390","merge_sha":"72cca280044a72eb76a39cef9abc6f294209e98c"} --> | 2022-05-14T22:48:49 | 2022-05-14T22:48:49 | {} | COLLABORATOR |
rust-lang | rust | 1,126,736,192 | 96,958 | GuillaumeGomez | Updated! Also updated the demo. | 2022-05-14T15:24:26 | 2022-05-14T15:24:26 | {} | MEMBER |
rust-lang | rust | 1,126,740,396 | 97,039 | bors | :hourglass: Testing commit 872f09c9756aa1be54b027a556a84132e98552a0 with merge b36be12d979de84a063f617295674a40d6ddf16d...
<!-- homu: {"type":"BuildStarted","head_sha":"872f09c9756aa1be54b027a556a84132e98552a0","merge_sha":"b36be12d979de84a063f617295674a40d6ddf16d"} --> | 2022-05-14T15:47:24 | 2022-05-14T15:47:24 | {} | COLLABORATOR |
rust-lang | rust | 1,126,742,477 | 97,045 | Urgau | Perf bot is currently broken until https://github.com/rust-lang/rust/pull/97044 is merged. See https://rust-lang.zulipchat.com/#narrow/stream/247081-t-compiler.2Fperformance/topic/perfrlo.20broken for additional information. | 2022-05-14T16:00:41 | 2022-05-14T16:00:41 | {
"+1": 1
} | MEMBER |
rust-lang | rust | 1,126,772,194 | 87,074 | joshtriplett | > My questions are more towards the libs team. Do we want a `FdView` in std?
I don't think we want one that operates on any possible object that holds a file descriptor, pretending a borrowed descriptor is an owned one. Not without some kind of unsafe operation involved.
I can imagine having ways to read and writ... | 2022-05-14T16:35:54 | 2022-05-14T16:35:54 | {} | MEMBER |
rust-lang | rust | 1,126,774,210 | 87,074 | joshtriplett | I don't think we should allow it by default.
I think we should allow calling metadata on things other than a File.
We should talk about possible designs for directory file descriptors, but I don't think those should be a blocker for this work. | 2022-05-14T16:49:44 | 2022-05-14T16:50:02 | {} | MEMBER |
rust-lang | rust | 1,126,798,265 | 95,950 | Jules-Bertholet | @rustbot author | 2022-05-14T19:22:11 | 2022-05-14T19:22:11 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,801,817 | 96,324 | berendjan | apparently linux does not like port 0, switching to `next_test_ipv4` | 2022-05-14T19:49:40 | 2022-05-14T19:49:40 | {} | NONE |
rust-lang | rust | 1,126,803,939 | 97,032 | bors | :pushpin: Commit 015e2ae76984144a7ece6d8169ff42b6dc7d6870 has been approved by `petrochenkov`
<!-- @bors r=petrochenkov 015e2ae76984144a7ece6d8169ff42b6dc7d6870 -->
<!-- homu: {"type":"Approved","sha":"015e2ae76984144a7ece6d8169ff42b6dc7d6870","approver":"petrochenkov"} --> | 2022-05-14T20:06:32 | 2022-05-14T20:06:32 | {} | COLLABORATOR |
rust-lang | rust | 1,126,823,353 | 97,050 | bors | :hourglass: Testing commit 439ddd419a036c6aa21b8138884c777edbf9ef4a with merge e9cb39e63dad082c433b3a22107fb38e681ed967...
<!-- homu: {"type":"BuildStarted","head_sha":"439ddd419a036c6aa21b8138884c777edbf9ef4a","merge_sha":"e9cb39e63dad082c433b3a22107fb38e681ed967"} --> | 2022-05-14T22:54:36 | 2022-05-14T22:54:36 | {} | COLLABORATOR |
rust-lang | rust | 1,126,828,596 | 96,885 | bors | :pushpin: Commit 4fa24bcb54cd11ec9c5e95d6d0ef366e512d27d6 has been approved by `cjgillot,luqmana`
<!-- @bors r=cjgillot,luqmana 4fa24bcb54cd11ec9c5e95d6d0ef366e512d27d6 -->
<!-- homu: {"type":"Approved","sha":"4fa24bcb54cd11ec9c5e95d6d0ef366e512d27d6","approver":"cjgillot,luqmana"} --> | 2022-05-14T23:55:11 | 2022-05-14T23:55:11 | {} | COLLABORATOR |
rust-lang | rust | 1,126,751,886 | 97,040 | jackh726 | @bors r+ | 2022-05-14T16:10:27 | 2022-05-14T16:10:27 | {} | MEMBER |
rust-lang | rust | 1,126,751,963 | 97,040 | bors | :pushpin: Commit 7d0f04a21845bf81575393c49f7e05a9bc596cfa has been approved by `jackh726`
<!-- @bors r=jackh726 7d0f04a21845bf81575393c49f7e05a9bc596cfa -->
<!-- homu: {"type":"Approved","sha":"7d0f04a21845bf81575393c49f7e05a9bc596cfa","approver":"jackh726"} --> | 2022-05-14T16:10:29 | 2022-05-14T16:10:29 | {} | COLLABORATOR |
rust-lang | rust | 1,126,784,577 | 97,046 | rust-highfive | r? @Mark-Simulacrum
(rust-highfive has picked a reviewer for you, use r? to override) | 2022-05-14T17:52:17 | 2022-05-14T17:52:17 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,800,416 | 96,935 | thomcc | > Maybe we should have `fetch_byte_add` and `fetch_ptr_add` or something like that.
I've gone ahead and renamed things along these lines. | 2022-05-14T19:37:58 | 2022-05-14T19:37:58 | {} | MEMBER |
rust-lang | rust | 1,126,805,391 | 96,827 | petrochenkov | I suddenly got busy and will get to this PR (and then to https://github.com/rust-lang/rust/pull/96884) next weekend most likely. | 2022-05-14T20:18:31 | 2022-05-14T20:18:31 | {
"+1": 1
} | CONTRIBUTOR |
rust-lang | rust | 1,126,806,026 | 97,045 | eddyb | So maybe the extra TLS isn't feasible after all :/
I might still want to keep some of the refactors (that streamline `ExecutionStrategy` to being only about `Buffer`-oriented request dispatch), but using `Closure` (like before this PR) instead of TLS. | 2022-05-14T20:25:06 | 2022-05-14T20:25:06 | {} | MEMBER |
rust-lang | rust | 1,126,816,025 | 96,958 | bors | :pushpin: Commit dee294759ba141889f40689eda7345e89fe2bae5 has been approved by `jsha`
<!-- @bors r=jsha dee294759ba141889f40689eda7345e89fe2bae5 -->
<!-- homu: {"type":"Approved","sha":"dee294759ba141889f40689eda7345e89fe2bae5","approver":"jsha"} --> | 2022-05-14T21:46:23 | 2022-05-14T21:46:23 | {} | COLLABORATOR |
rust-lang | rust | 1,126,826,071 | 97,050 | bors | :broken_heart: Test failed - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6437521229?check_suite_focus=true)
<!-- homu: {"type":"BuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/6437521229?check_suite_focus=true","builder_name":"checks-actions"} --> | 2022-05-14T23:23:06 | 2022-05-14T23:23:06 | {} | COLLABORATOR |
rust-lang | rust | 1,126,828,593 | 96,885 | petrochenkov | @bors r=cjgillot,luqmana | 2022-05-14T23:55:10 | 2022-05-14T23:55:10 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,837,416 | 97,051 | djmcgill | Huh, I _did_ run `./x.py test tidy --bless`, one sec.
e: oh, my IDE changed it after I ran that. Cute. | 2022-05-15T01:22:10 | 2022-05-15T01:57:16 | {} | NONE |
rust-lang | rust | 1,126,801,000 | 95,576 | oli-obk | @bors try @rust-timer queue | 2022-05-14T19:42:23 | 2022-05-14T19:42:23 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,801,018 | 95,576 | bors | :hourglass: Trying commit 5a86bd7e8ab58a99aa670a03df861834946ff14f with merge 153fb1b0ee3220b80bbfd9385be4e451700aeb1c...
<!-- homu: {"type":"TryBuildStarted","head_sha":"5a86bd7e8ab58a99aa670a03df861834946ff14f","merge_sha":"153fb1b0ee3220b80bbfd9385be4e451700aeb1c"} --> | 2022-05-14T19:42:32 | 2022-05-14T19:42:32 | {} | COLLABORATOR |
rust-lang | rust | 1,126,826,004 | 97,050 | rust-log-analyzer |
The job **`x86_64-gnu-tools`** failed! Check out the build log: [(web)](https://github.com/rust-lang-ci/rust/runs/6437410541?check_suite_focus=true) [(plain)](https://github.com/rust-lang-ci/rust/commit/e9cb39e63dad082c433b3a22107fb38e681ed967/checks/6437410541/logs)
<details><summary><i>Click to see the possible cau... | 2022-05-14T23:22:35 | 2022-05-14T23:22:35 | {} | COLLABORATOR |
rust-lang | rust | 1,126,740,370 | 96,345 | bors | :sunny: Test successful - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6435482147?check_suite_focus=true)
Approved by: notriddle
Pushing 2d691170885b32502b391b8b1a0d54d2419a5653 to master...
<!-- homu: {"type":"BuildCompleted","approved_by":"notriddle","base_ref":"master","builders":{"checks-actions":"htt... | 2022-05-14T15:47:16 | 2022-05-14T15:47:16 | {} | COLLABORATOR |
rust-lang | rust | 1,126,744,571 | 77,541 | Patryk27 | fwiw, I think this was solved after https://github.com/rust-lang/rust/pull/96845, too 🙂 | 2022-05-14T16:07:27 | 2022-05-14T16:07:27 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,770,802 | 96,970 | oli-obk | Closing as @cjgillot wrote an actual fix instead of overzealous patch that this PR was | 2022-05-14T16:26:27 | 2022-05-14T16:26:27 | {
"laugh": 1
} | CONTRIBUTOR |
rust-lang | rust | 1,126,787,299 | 56,056 | rben01 | > All normal DLL dependencies are loaded and their symbols resolved before `main` is ever called. All C++ static initializers are also run before `main` is ever called, so Rust never has a chance to call `SetDefaultDllDirectories` before that stuff happens. Rust _does_ actually `LoadLibrary` a few DLLsitself though but... | 2022-05-14T18:08:55 | 2022-05-14T18:08:55 | {} | NONE |
rust-lang | rust | 1,126,812,548 | 96,496 | rust-log-analyzer |
The job **`dist-x86_64-linux`** failed! Check out the build log: [(web)](https://github.com/rust-lang-ci/rust/runs/6436678509?check_suite_focus=true) [(plain)](https://github.com/rust-lang-ci/rust/commit/4f76fc078a48495558dcb392e9d2d01f09d0e073/checks/6436678509/logs)
<details><summary><i>Click to see the possible ca... | 2022-05-14T21:16:58 | 2022-05-14T21:52:21 | {} | COLLABORATOR |
rust-lang | rust | 1,126,822,855 | 96,991 | rust-timer | Awaiting bors try build completion.
@rustbot label: +S-waiting-on-perf | 2022-05-14T22:48:42 | 2022-05-14T22:48:42 | {} | COLLABORATOR |
rust-lang | rust | 1,126,823,340 | 97,044 | bors | :sunny: Test successful - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6437408430?check_suite_focus=true)
Approved by: Mark-Simulacrum
Pushing 70b3681bf621bc0de91ffab711b2350068b4c466 to master...
<!-- homu: {"type":"BuildCompleted","approved_by":"Mark-Simulacrum","base_ref":"master","builders":{"checks-a... | 2022-05-14T22:54:27 | 2022-05-14T22:54:27 | {} | COLLABORATOR |
rust-lang | rust | 1,126,824,977 | 96,991 | bors | :broken_heart: Test failed - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6437474182?check_suite_focus=true)
<!-- homu: {"type":"TryBuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/6437474182?check_suite_focus=true","builder_name":"checks-actions"} --> | 2022-05-14T23:10:45 | 2022-05-14T23:10:45 | {} | COLLABORATOR |
rust-lang | rust | 1,126,734,872 | 97,045 | bors | :hourglass: Trying commit 9242c1263f813f7d030b4c786f328ab276d0cbdb with merge 27e0a1ccff81e0c702800c4e46627bd584cded41...
<!-- homu: {"type":"TryBuildStarted","head_sha":"9242c1263f813f7d030b4c786f328ab276d0cbdb","merge_sha":"27e0a1ccff81e0c702800c4e46627bd584cded41"} --> | 2022-05-14T15:16:03 | 2022-05-14T15:16:03 | {} | COLLABORATOR |
rust-lang | rust | 1,126,803,386 | 96,496 | joshtriplett | @bors try @rust-timer queue | 2022-05-14T20:02:23 | 2022-05-14T20:02:23 | {} | MEMBER |
rust-lang | rust | 1,126,803,935 | 97,032 | petrochenkov | @bors r+ rollup | 2022-05-14T20:06:31 | 2022-05-14T20:06:31 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,804,367 | 86,822 | rust-timer | Awaiting bors try build completion.
@rustbot label: +S-waiting-on-perf | 2022-05-14T20:10:09 | 2022-05-14T20:10:09 | {} | COLLABORATOR |
rust-lang | rust | 1,126,821,441 | 96,991 | rust-log-analyzer |
The job **`mingw-check`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6437311167?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/e5805b5d6f7f5b1670eda3f23c41cf7187420651/checks/6437311167/logs)
<details><summary><i>Click to see the possible cause of the f... | 2022-05-14T22:33:26 | 2022-05-14T22:37:48 | {} | COLLABORATOR |
rust-lang | rust | 1,126,784,572 | 97,046 | rust-highfive | Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any `rust-lang/rust` public library APIs then please comment with `r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs` to request review from a libs-api team reviewer. If you're unsure where your change falls no wo... | 2022-05-14T17:52:16 | 2022-05-14T17:52:16 | {} | CONTRIBUTOR |
rust-lang | rust | 1,126,788,239 | 97,045 | rust-timer | Finished benchmarking commit (27e0a1ccff81e0c702800c4e46627bd584cded41): [comparison url](https://perf.rust-lang.org/compare.html?start=8019fa0dc08bb0e26d28ce29c3983408ffb2feac&end=27e0a1ccff81e0c702800c4e46627bd584cded41).
**Summary**:
- Primary benchmarks: mixed results
- Secondary benchmarks: mixed results
| ... | 2022-05-14T18:15:29 | 2022-05-14T18:15:29 | {} | COLLABORATOR |
rust-lang | rust | 1,126,814,556 | 86,822 | bors | :sunny: Try build successful - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6437079495?check_suite_focus=true)
Build commit: 6a774941b6e5cc24047cc184c5a3d371f7664ed1 (`6a774941b6e5cc24047cc184c5a3d371f7664ed1`)
<!-- homu: {"type":"TryBuildCompleted","builders":{"checks-actions":"https://github.com/rust-la... | 2022-05-14T21:34:17 | 2022-05-14T21:34:17 | {} | COLLABORATOR |
rust-lang | rust | 1,126,820,320 | 56,056 | DemiMarie | I believe it cannot be done. Windows assumes that one does not run a program from a directory that also has untrusted files. | 2022-05-14T22:21:11 | 2022-05-14T22:21:11 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,007,395 | 96,743 | eds-collabora | Thanks for pointing this out. I read, and re-read RFC 2541, but I hadn't understood it properly. So the key part of the current behaviour that I had missed is that only _uncovered_ type parameters are prohibited before the first local type, in order for the trait to be considered local. The original RFC 1023 wording pr... | 2022-05-09T12:00:24 | 2022-05-09T12:00:24 | {} | NONE |
rust-lang | rust | 1,121,150,272 | 96,725 | ChrisDenton | > Might be good to do that right away. Then we get some usage of BorrowedHandle before stabilizing it, to see if it works well. :)
Good point. @nico-abram could you update the implementation to return `BorrowedHandle` | 2022-05-09T14:07:31 | 2022-05-09T14:07:31 | {} | MEMBER |
rust-lang | rust | 1,121,171,358 | 96,868 | rust-highfive | r? @petrochenkov
(rust-highfive has picked a reviewer for you, use r? to override) | 2022-05-09T14:23:36 | 2022-05-09T14:23:36 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,190,015 | 96,515 | nikomatsakis | I don't really understand the PR description, @lcnr :( maybe we can find some time to sync up on this. I'd like to understand better what is going on! | 2022-05-09T14:38:04 | 2022-05-09T14:38:04 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,216,220 | 96,867 | rust-timer | Awaiting bors try build completion.
@rustbot label: +S-waiting-on-perf | 2022-05-09T15:00:02 | 2022-05-09T15:00:02 | {} | COLLABORATOR |
rust-lang | rust | 1,121,216,343 | 96,867 | bors | :hourglass: Trying commit 0e4a86f545d8550091c07a262e64967fa3de70af with merge ba1281089ae9e873f5ff73dd7d8eac4a8f460404...
<!-- homu: {"type":"TryBuildStarted","head_sha":"0e4a86f545d8550091c07a262e64967fa3de70af","merge_sha":"ba1281089ae9e873f5ff73dd7d8eac4a8f460404"} --> | 2022-05-09T15:00:09 | 2022-05-09T15:00:09 | {} | COLLABORATOR |
rust-lang | rust | 1,121,395,612 | 96,077 | rust-log-analyzer |
The job **`mingw-check`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6356812866?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/fccb4e88dece858be47c4c0ae980141fbc9fbeaa/checks/6356812866/logs)
<details><summary><i>Click to see the possible cause of the f... | 2022-05-09T17:46:18 | 2022-05-09T17:55:37 | {} | COLLABORATOR |
rust-lang | rust | 1,121,448,821 | 96,817 | Wandalen | Sure. I will write a MRE. | 2022-05-09T18:43:06 | 2022-05-09T18:43:06 | {} | NONE |
rust-lang | rust | 1,121,012,448 | 96,584 | jyn514 | Hi @bentongxyz - https://github.com/rust-lang/rust/issues/86890 is a good issue to try out (it's a little harder to test than this one, but not too bad), or you could go with the first approach I mentioned in https://github.com/rust-lang/rust/pull/96584#discussion_r863470457 so you don't have to wait for my PR to land.... | 2022-05-09T12:05:24 | 2022-05-09T12:05:24 | {} | MEMBER |
rust-lang | rust | 1,121,369,413 | 96,674 | thomcc | @bors retry | 2022-05-09T17:20:16 | 2022-05-09T17:20:16 | {} | MEMBER |
rust-lang | rust | 1,121,378,449 | 96,709 | juntyr | @nrc I mostly use GATs in my codebase to allow a trait method to return an opaque iterator type whose lifetime must be bounded by the lifetime used for `&self`.
> It seems like the iterator type should be hidden and you're writing a manual desugaring of returning an `impl Trait`? I.e., for your example, why not use:... | 2022-05-09T17:28:56 | 2022-05-09T17:28:56 | {
"+1": 2,
"heart": 3
} | CONTRIBUTOR |
rust-lang | rust | 1,121,393,642 | 96,867 | rust-timer | Finished benchmarking commit (ba1281089ae9e873f5ff73dd7d8eac4a8f460404): [comparison url](https://perf.rust-lang.org/compare.html?start=e013f9e0ca4055930f931a30171c355de42f9f92&end=ba1281089ae9e873f5ff73dd7d8eac4a8f460404).
**Summary**:
- Primary benchmarks: 🎉 relevant improvement found
- Secondary benchmarks: no re... | 2022-05-09T17:44:27 | 2022-05-09T17:44:27 | {} | COLLABORATOR |
rust-lang | rust | 1,121,417,235 | 96,709 | Stargateur | @nrc The problem is why do you allow all others complex thing in Rust but stop at GaTs ? It's seem totally arbitrary. Rust IS one of the hardest language, In my opinion it is harder than haskell by far specially Rust Async World. I think we should be carefully about introduce GaTs in std cause this indeed affect all us... | 2022-05-09T18:09:26 | 2022-05-09T18:21:04 | {
"+1": 4,
"-1": 3
} | CONTRIBUTOR |
rust-lang | rust | 1,121,416,949 | 96,077 | rust-log-analyzer |
The job **`x86_64-gnu-llvm-12`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6356991001?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/0baca9aeeb7e493a97c18eaa09703500184020ce/checks/6356991001/logs)
<details><summary><i>Click to see the possible cause o... | 2022-05-09T18:09:09 | 2022-05-09T18:31:19 | {} | COLLABORATOR |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.