owner stringclasses 15
values | repo stringclasses 15
values | id int64 116k 4.21B | issue_number int32 1 180k | author stringlengths 0 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-04-09 03:22:08 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-04-09 03:28:07 | reactions unknown | author_association stringclasses 7
values |
|---|---|---|---|---|---|---|---|---|---|
rust-lang | rust | 1,121,077,645 | 96,864 | rust-highfive | Some changes occurred in `clean/types.rs`.
cc @camelid | 2022-05-09T13:06:43 | 2022-05-09T13:06:43 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,171,496 | 94,012 | pnkfelix | @cormacrelf I am currently planning to look into approaches for fixing this more generally with @dingxiangfei2009 . Would you like to try to collaborate with us as well on that? Do you think we should close this PR, or try to adapt it? | 2022-05-09T14:23:42 | 2022-05-09T14:23:50 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,258,579 | 96,872 | rust-highfive | r? @nagisa
(rust-highfive has picked a reviewer for you, use r? to override) | 2022-05-09T15:34:25 | 2022-05-09T15:34:25 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,295,468 | 96,872 | RalfJung | That codegen test failure is odd. For some reason `"Enum4::A"` is not in the LLVM IR at all any more? | 2022-05-09T16:07:55 | 2022-05-09T16:07:55 | {} | MEMBER |
rust-lang | rust | 1,121,318,076 | 96,867 | rust-timer | Queued ba1281089ae9e873f5ff73dd7d8eac4a8f460404 with parent e013f9e0ca4055930f931a30171c355de42f9f92, future [comparison URL](https://perf.rust-lang.org/compare.html?start=e013f9e0ca4055930f931a30171c355de42f9f92&end=ba1281089ae9e873f5ff73dd7d8eac4a8f460404). | 2022-05-09T16:27:20 | 2022-05-09T16:27:20 | {} | COLLABORATOR |
rust-lang | rust | 1,121,336,357 | 96,877 | matthiaskrgr | @bors r+ rollup=never p=6 | 2022-05-09T16:46:06 | 2022-05-09T16:46:06 | {} | MEMBER |
rust-lang | rust | 1,120,891,433 | 96,709 | Pzixel | > thanks for expanding! I must admit I don't quite follow the ownership properties of the trait now. I thought that either the trait transforms self into something else (in which case it shouldn't need a lifetime at all) or it borrows the contents of self, in which case it just needs the self lifetime, but this seems t... | 2022-05-09T09:54:26 | 2022-05-09T17:45:02 | {
"+1": 1
} | NONE |
rust-lang | rust | 1,121,057,675 | 96,862 | RalfJung | > follow-up to https://github.com/rust-lang/rust/pull/96814
To be clear, your PR needs to land first before #96814 can make progress. | 2022-05-09T12:49:36 | 2022-05-09T12:49:36 | {} | MEMBER |
rust-lang | rust | 1,121,063,389 | 95,632 | m-ou-se | I suppose the main question is how often an incomplete `write` is not immediately followed by a `write` for the remaining part. Are there many reasonable scenarios where something tries to write 1000 bytes, only succeeds at writing 200, and then is satisfied with that and stops writing? If not, it might be best to just... | 2022-05-09T12:55:06 | 2022-05-09T12:55:06 | {
"+1": 1
} | MEMBER |
rust-lang | rust | 1,121,214,382 | 96,838 | bors | :broken_heart: Test failed - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6354243900?check_suite_focus=true)
<!-- homu: {"type":"BuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/6354243900?check_suite_focus=true","builder_name":"checks-actions"} --> | 2022-05-09T14:58:17 | 2022-05-09T14:58:17 | {} | COLLABORATOR |
rust-lang | rust | 1,121,274,528 | 96,815 | rust-timer | Finished benchmarking commit (e013f9e0ca4055930f931a30171c355de42f9f92): [comparison url](https://perf.rust-lang.org/compare.html?start=8a2fe75d0e6e024aa434e5b9c40adb2567f362b8&end=e013f9e0ca4055930f931a30171c355de42f9f92).
**Summary**:
- Primary benchmarks: no relevant changes found
- Secondary benchmarks: 🎉 releva... | 2022-05-09T15:49:05 | 2022-05-09T15:49:05 | {} | COLLABORATOR |
rust-lang | rust | 1,121,311,660 | 96,875 | rust-highfive | Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any `rust-lang/rust` public library APIs then please comment with `r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs` to request review from a libs-api team reviewer. If you're unsure where your change falls no wo... | 2022-05-09T16:21:55 | 2022-05-09T16:21:55 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,421,550 | 96,872 | RalfJung | @eddyb I think I took care of all your comments, but it might be good for you to have another look. :) | 2022-05-09T18:13:50 | 2022-05-09T18:13:50 | {} | MEMBER |
rust-lang | rust | 1,121,445,278 | 96,823 | estebank | @bors r+ | 2022-05-09T18:38:51 | 2022-05-09T18:38:51 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,445,293 | 96,823 | bors | :pushpin: Commit 1d68e6d67452c0de61e133553a28c8871e96837a has been approved by `estebank`
<!-- @bors r=estebank 1d68e6d67452c0de61e133553a28c8871e96837a -->
<!-- homu: {"type":"Approved","sha":"1d68e6d67452c0de61e133553a28c8871e96837a","approver":"estebank"} --> | 2022-05-09T18:38:52 | 2022-05-09T18:38:52 | {} | COLLABORATOR |
rust-lang | rust | 1,121,045,889 | 96,862 | bors | :hourglass: Trying commit aba79aecc904cc5cd0174804c375a2bdac4baa82 with merge 9070d93994dedb99925dcdbee841e40c34eee7d4...
<!-- homu: {"type":"TryBuildStarted","head_sha":"aba79aecc904cc5cd0174804c375a2bdac4baa82","merge_sha":"9070d93994dedb99925dcdbee841e40c34eee7d4"} --> | 2022-05-09T12:38:56 | 2022-05-09T12:38:56 | {} | COLLABORATOR |
rust-lang | rust | 1,121,004,959 | 96,715 | rust-log-analyzer |
A job failed! Check out the build log: [(web)](https://github.com/rust-lang-ci/rust/runs/6351170497?check_suite_focus=true) [(plain)](https://github.com/rust-lang-ci/rust/commit/19d72cf1e1ec94a4173edab7a315796d56d0c4c3/checks/6351170497/logs)
<details><summary><i>Click to see the possible cause of the failure (guesse... | 2022-05-09T11:57:38 | 2022-05-09T17:44:25 | {} | COLLABORATOR |
rust-lang | rust | 1,121,442,515 | 96,324 | joshtriplett | (Comments still need to get word-wrapped.) | 2022-05-09T18:35:46 | 2022-05-09T18:35:46 | {
"+1": 1
} | MEMBER |
rust-lang | rust | 1,120,997,318 | 96,862 | oli-obk | @bors try @rust-timer queue | 2022-05-09T11:49:04 | 2022-05-09T11:49:04 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,279,953 | 96,473 | lcnr | @rustbot ready | 2022-05-09T15:54:04 | 2022-05-09T15:54:22 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,433,049 | 93,661 | ehuss | OK, I'm going to go ahead and approve. I'll follow up with pulling in the RFC when this merges.
@bors r=estebank,Mark-Simulacrum rollup
| 2022-05-09T18:25:45 | 2022-05-09T18:25:45 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,069,690 | 96,863 | rust-log-analyzer |
The job **`mingw-check`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6352037826?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/5251a80c0adf44467de58b9384b247815e540bec/checks/6352037826/logs)
<details><summary><i>Click to see the possible cause of the f... | 2022-05-09T13:00:35 | 2022-05-09T13:49:25 | {} | COLLABORATOR |
rust-lang | rust | 1,121,213,515 | 96,838 | rust-log-analyzer |
The job **`x86_64-gnu-tools`** failed! Check out the build log: [(web)](https://github.com/rust-lang-ci/rust/runs/6353757958?check_suite_focus=true) [(plain)](https://github.com/rust-lang-ci/rust/commit/1eaacc30576db615c0add464c71199f4230008e9/checks/6353757958/logs)
<details><summary><i>Click to see the possible cau... | 2022-05-09T14:57:32 | 2022-05-09T14:57:32 | {} | COLLABORATOR |
rust-lang | rust | 1,121,216,089 | 95,290 | sunfishcode | @BurntSushi One possible approach for your use case is to have `OsString` remember whether its `from_wide` conversion encountered any surrogates, because if it didn't, then `.into_string()` can do a trivial conversion. #96869 is a rough sketch of this idea. That's likely not as convenient for you as having it hand out ... | 2022-05-09T14:59:54 | 2022-05-09T14:59:54 | {} | MEMBER |
rust-lang | rust | 1,121,363,956 | 94,075 | mikebenfield | I can change the code to force cpp-like debuginfo to be generated, but I think the only way to test it out with the natvis stuff is on Windows.
I'll look at the possibility of disabling these layouts when cpp-like debuginfo is enabled. | 2022-05-09T17:14:56 | 2022-05-09T17:14:56 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,376,028 | 96,715 | compiler-errors | @bors r+ | 2022-05-09T17:26:43 | 2022-05-09T17:26:43 | {} | CONTRIBUTOR |
rust-lang | rust | 1,120,979,716 | 96,715 | bors | :boom: Test timed out
<!-- homu: {"type":"TimedOut"} --> | 2022-05-09T11:29:49 | 2022-05-09T11:29:49 | {} | COLLABORATOR |
rust-lang | rust | 1,121,045,769 | 96,008 | bors | :pushpin: Commit 9d157ada35c0e363e30344526755649c3399f7de has been approved by `lcnr`
<!-- @bors r=lcnr 9d157ada35c0e363e30344526755649c3399f7de -->
<!-- homu: {"type":"Approved","sha":"9d157ada35c0e363e30344526755649c3399f7de","approver":"lcnr"} --> | 2022-05-09T12:38:48 | 2022-05-09T12:38:48 | {} | COLLABORATOR |
rust-lang | rust | 1,121,086,281 | 96,806 | oli-obk | This should affect the ICEs in https://github.com/rust-lang/rust/issues?q=is%3Aissue+is%3Aopen+Encountered+errors+resolving+bounds+outside+of+type+inference
Please add tests for them.
This also likely affects all tests in https://github.com/rust-lang/rust/issues?q=is%3Aissue+is%3Aopen+Encountered+error+%60Unimple... | 2022-05-09T13:14:05 | 2022-05-09T13:14:05 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,172,928 | 96,868 | petrochenkov | r? rust-lang/compiler | 2022-05-09T14:24:48 | 2022-05-09T14:24:48 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,295,992 | 93,975 | nmeum | > > [rust-lang/libc#2664](https://github.com/rust-lang/libc/pull/2664) Should fix by #94052
>
> @12101111, does that pave the way for full std availability on riscv musl?
Just #94052 is actually not sufficient. https://github.com/rust-lang/libc/pull/2784 is also needed. Furthermore, to have the latest Rust releas... | 2022-05-09T16:08:26 | 2022-05-09T16:08:26 | {} | NONE |
rust-lang | rust | 1,121,339,571 | 96,870 | ehuss | It looks like string-based matching was incidentally removed in #46335. I probably missed that when writing the docs, instead relying on your comment [here](https://github.com/rust-lang/rust/pull/41508#pullrequestreview-34906301). Do you recall at the time if the preference was for simplicity of implementation, or simp... | 2022-05-09T16:49:45 | 2022-05-09T16:49:45 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,148,532 | 96,725 | ChrisDenton | > Can this even happen? As far as I can tell, when the main thread exits Windows will exit the process anyway.
It's possible! In Win32, [a process only exits when all threads have exited](https://devblogs.microsoft.com/oldnewthing/20100827-00/?p=13023) or ExitProcess is called (which terminates all other threads),
... | 2022-05-09T14:06:16 | 2022-05-09T14:06:16 | {} | MEMBER |
rust-lang | rust | 1,121,235,480 | 93,740 | kprotty | > So, has there been benchmarks over parking_lot word lock vs futexes vs SRW locks?
`usync` includes [throughput benchmarks](https://github.com/kprotty/usync/blob/master/benchmark/src/mutex.rs) from parking_lot's repo with the listed locks for comparison (usync vs stdlib vs parking_lot vs SRWLOCK-or-pthread).
> ... | 2022-05-09T15:15:22 | 2022-05-09T15:15:22 | {
"+1": 1
} | NONE |
rust-lang | rust | 1,121,274,150 | 96,341 | kckeiks | yes, it is being worked on. | 2022-05-09T15:48:46 | 2022-05-09T15:49:20 | {
"+1": 1
} | CONTRIBUTOR |
rust-lang | rust | 1,121,331,723 | 96,473 | lcnr | @bors r=cjgillot | 2022-05-09T16:41:04 | 2022-05-09T16:41:04 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,337,227 | 94,799 | lcnr | keeping the reasoning from https://github.com/rust-lang/rust/pull/94799#issuecomment-1064309755
> alright, wasn't the reason for the perf impact, but I still believe that this is a small improvement. If this is merged nobody else will try the same change in the future and it doesn't make anything worse :shrug:
@p... | 2022-05-09T16:47:05 | 2022-05-09T16:47:21 | {} | CONTRIBUTOR |
rust-lang | rust | 1,120,997,339 | 96,862 | rust-timer | Awaiting bors try build completion.
@rustbot label: +S-waiting-on-perf | 2022-05-09T11:49:05 | 2022-05-09T11:49:05 | {} | COLLABORATOR |
rust-lang | rust | 1,121,292,857 | 96,473 | klensy | > Finished benchmarking commit ([1ceb86c](https://github.com/rust-lang/rust/commit/1ceb86c8e7375b780e598d1a3fe3534a2553e868)): [comparison url](https://perf.rust-lang.org/compare.html?start=fed2c43bbf4e3955f83cea77c0b1709c0dbcebf3&end=1ceb86c8e7375b780e598d1a3fe3534a2553e868).
Improved all, except doc builds (if unc... | 2022-05-09T16:05:47 | 2022-05-09T16:05:47 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,318,034 | 96,867 | bors | :sunny: Try build successful - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6355765037?check_suite_focus=true)
Build commit: ba1281089ae9e873f5ff73dd7d8eac4a8f460404 (`ba1281089ae9e873f5ff73dd7d8eac4a8f460404`)
<!-- homu: {"type":"TryBuildCompleted","builders":{"checks-actions":"https://github.com/rust-la... | 2022-05-09T16:27:18 | 2022-05-09T16:27:18 | {} | COLLABORATOR |
rust-lang | rust | 1,121,323,359 | 96,874 | SNCPlay42 | Duplicate of #96583 (which isn't actually fixed until #96844 lands) | 2022-05-09T16:32:29 | 2022-05-09T16:32:29 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,387,224 | 94,075 | RalfJung | Having layout depend on debuginfo flags seems a bit odd, have we ever done that? If the same type has its layout computed in different crates, we have to ensure it comes out the same... OTOH we have `-Z randomize-layout` so having CLI flags affect layout has some precedence.
Is there not a way to emit some kind of "... | 2022-05-09T17:37:51 | 2022-05-09T17:37:51 | {} | MEMBER |
rust-lang | rust | 1,121,199,226 | 96,077 | rust-log-analyzer |
The job **`mingw-check`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6353856081?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/11f57dbac69eaaab69d46fb2ca1e85b5bab66aad/checks/6353856081/logs)
<details><summary><i>Click to see the possible cause of the f... | 2022-05-09T14:45:26 | 2022-05-09T17:46:13 | {} | COLLABORATOR |
rust-lang | rust | 1,121,422,898 | 96,584 | bentongxyz | > https://github.com/rust-lang/rust/issues/86890 is a good issue to try out (it's a little harder to test than this one, but not too bad), or you could go with the first approach I mentioned in https://github.com/rust-lang/rust/pull/96584#discussion_r863470457 so you don't have to wait for my PR to land.
@jyn514 Tha... | 2022-05-09T18:15:15 | 2022-05-09T18:15:15 | {
"heart": 1
} | CONTRIBUTOR |
rust-lang | rust | 1,121,045,742 | 96,008 | lcnr | cnsidering that this is
1) a pretty straightforward bug fix
2) only adds a new lint, so it isn't a breaking change
3) i've already notified t-lang and got an unofficial signoff by @scottmcm
@bors r+ rollup | 2022-05-09T12:38:46 | 2022-05-09T12:38:46 | {
"heart": 1
} | CONTRIBUTOR |
rust-lang | rust | 1,121,346,395 | 96,493 | chbaker0 | @rustbot label -S-waiting-on-author +S-waiting-on-review
@Mark-Simulacrum I didn't do enough digging; "--skip" in libtest does what I want. The PR now just adds the arguments to bootstrap and compiletest and forwards them down to libtest. | 2022-05-09T16:57:27 | 2022-05-09T16:57:27 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,064,923 | 96,862 | bjorn3 | This branch can be removed with this PR, right?
https://github.com/bjorn3/rustc_codegen_cranelift/blob/25f7711fea4f83a82d54c17dff5cc5b9a2b2937b/src/base.rs#L630-L652 | 2022-05-09T12:56:36 | 2022-05-09T12:56:36 | {} | MEMBER |
rust-lang | rust | 1,121,173,190 | 96,852 | lqd | Strange indeed, I wasn't expecting PGO would affect this particular case this much. I wanted to check the PGO'ed cg profiles locally but I'm hitting https://bugs.kde.org/show_bug.cgi?id=452758 with these `try` builds, unfortunately. | 2022-05-09T14:25:01 | 2022-05-09T14:25:01 | {} | MEMBER |
rust-lang | rust | 1,121,187,943 | 65,844 | pnkfelix | > This continues to occur with Rust 1.60 and 1.62.0-nightly ([e1b71fe](https://github.com/rust-lang/rust/commit/e1b71feb592ba64805689e2b15b9fa570182c442) 2022-05-03). I've seen it in the wild with both the `ryu` and `serde` crates.
My working assumption is that the continued occurrences are due to https://bugs.llvm.... | 2022-05-09T14:36:16 | 2022-05-09T14:36:42 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,209,766 | 96,868 | rust-log-analyzer |
The job **`x86_64-gnu-llvm-12`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6353954519?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/29ed414fb13be673f153e868ac5b83e1b35e0dbe/checks/6353954519/logs)
<details><summary><i>Click to see the possible cause o... | 2022-05-09T14:54:18 | 2022-05-09T16:03:34 | {} | COLLABORATOR |
rust-lang | rust | 1,121,291,521 | 96,855 | aadog | 1.importing frida init symbols via C static library
2. Set the project type to cdylib and export it to the symbol of frida_init
3 Use ida to view, it will be called recursively.
All symbols will point to the frida_init function exported by dylib, which cannot be called correctly
from static library frida_init | 2022-05-09T16:04:51 | 2022-05-09T16:04:51 | {} | NONE |
rust-lang | rust | 1,121,297,019 | 96,872 | eddyb | > That codegen test failure is odd. For some reason `"Enum4::A"` is not in the LLVM IR at all any more?
That would make sense, I think, IIRC only `Abi::Aggregate` results in LLVM types with specific names. | 2022-05-09T16:09:15 | 2022-05-09T16:09:15 | {} | MEMBER |
rust-lang | rust | 1,121,372,647 | 96,845 | bors | :sunny: Test successful - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6356566647?check_suite_focus=true)
Approved by: nikic
Pushing 0e345b76a5550d82caff5540649ee0ba6e3b4f3f to master...
<!-- homu: {"type":"BuildCompleted","approved_by":"nikic","base_ref":"master","builders":{"checks-actions":"https://git... | 2022-05-09T17:23:25 | 2022-05-09T17:23:25 | {
"heart": 2
} | COLLABORATOR |
rust-lang | rust | 1,121,372,866 | 96,877 | bors | :hourglass: Testing commit 59722228b981f86d5540a43d9eb2cd2c66da92e9 with merge 0dd7e10282aaa7a3e1f5660f8bb043ee4ea07355...
<!-- homu: {"type":"BuildStarted","head_sha":"59722228b981f86d5540a43d9eb2cd2c66da92e9","merge_sha":"0dd7e10282aaa7a3e1f5660f8bb043ee4ea07355"} --> | 2022-05-09T17:23:37 | 2022-05-09T17:23:37 | {} | COLLABORATOR |
rust-lang | rust | 1,121,045,914 | 96,862 | oli-obk | 🤣 enum -> int cast acting as mem::forget strikes again. We used to drop these enums right after casting. [Then we got MIR and we ended up `mem::forget`ting them instead.](https://github.com/rust-lang/rust/issues/35941) We do have a lint against them now: https://github.com/rust-lang/rust/issues/73333 | 2022-05-09T12:38:58 | 2022-05-09T12:38:58 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,054,422 | 96,728 | lcnr | I added `let _tables = tcx.typeck(..)` to detect cycles while implementing `WithOptConstParam` and before the stabilization of `min_const_generics`. The first match arm was added later and didn't include that check. I don't think there's any intention behind that difference.
I don't actually get why `type X = Baz::<... | 2022-05-09T12:46:41 | 2022-05-09T12:46:41 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,166,802 | 96,867 | rust-highfive | r? @nagisa
(rust-highfive has picked a reviewer for you, use r? to override) | 2022-05-09T14:20:15 | 2022-05-09T14:20:15 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,180,079 | 96,838 | bors | :hourglass: Testing commit 2be012a0c664bf1ee90af0e5cac9a3e3e24f4666 with merge 1eaacc30576db615c0add464c71199f4230008e9...
<!-- homu: {"type":"BuildStarted","head_sha":"2be012a0c664bf1ee90af0e5cac9a3e3e24f4666","merge_sha":"1eaacc30576db615c0add464c71199f4230008e9"} --> | 2022-05-09T14:30:08 | 2022-05-09T14:30:08 | {} | COLLABORATOR |
rust-lang | rust | 1,121,306,613 | 96,473 | cjgillot | r=me with the warning removed. | 2022-05-09T16:17:49 | 2022-05-09T16:17:49 | {} | CONTRIBUTOR |
rust-lang | rust | 1,120,986,505 | 96,755 | jyn514 | @gimbles Say someone adds a new `Build` field in config.rs. That immediately lets you start using it under `[build]` in config.toml. But nothing actually enforces that you also add the field to config.toml.example, so it's possible to get a PR merged with a completely undocumented option. I'd like to make that statical... | 2022-05-09T11:37:32 | 2022-05-09T11:37:32 | {} | MEMBER |
rust-lang | rust | 1,120,993,332 | 96,862 | rust-highfive | r? @compiler-errors
(rust-highfive has picked a reviewer for you, use r? to override) | 2022-05-09T11:44:37 | 2022-05-09T11:44:37 | {} | CONTRIBUTOR |
rust-lang | rust | 1,120,997,429 | 96,815 | bors | :hourglass: Testing commit b890037af3eb71fcdacec9ad6d92646715d18836 with merge e013f9e0ca4055930f931a30171c355de42f9f92...
<!-- homu: {"type":"BuildStarted","head_sha":"b890037af3eb71fcdacec9ad6d92646715d18836","merge_sha":"e013f9e0ca4055930f931a30171c355de42f9f92"} --> | 2022-05-09T11:49:11 | 2022-05-09T11:49:11 | {} | COLLABORATOR |
rust-lang | rust | 1,121,114,088 | 96,709 | zesterer | > Also, many projects out there are probably waiting for the stabilization of GAT. For example, SQLx publicly stated that a new release is blocked by it in https://github.com/launchbadge/sqlx/issues/1413 (Although I am not sure nowadays).
I think this is quite an important point. Even though GATs are still an unstab... | 2022-05-09T13:37:07 | 2022-05-09T13:37:07 | {
"+1": 25,
"heart": 7
} | CONTRIBUTOR |
rust-lang | rust | 1,120,221,023 | 96,077 | rust-log-analyzer |
The job **`mingw-check`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6334720632?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/85e6704c60100d25a9ed4d9896293df911fbc56d/checks/6334720632/logs)
<details><summary><i>Click to see the possible cause of the f... | 2022-05-07T14:39:11 | 2022-05-09T14:43:01 | {} | COLLABORATOR |
rust-lang | rust | 1,121,216,186 | 96,867 | michaelwoerister | @bors try @rust-timer queue | 2022-05-09T15:00:00 | 2022-05-09T15:00:00 | {} | MEMBER |
rust-lang | rust | 1,121,224,445 | 95,290 | BurntSushi | @sunfishcode Yeah I think that would likely resolve the perf aspect of it. That's clever. Nice. As you mention though, it doesn't address the correctness problem. e.g., If someone used the glob `*.rs` then `*` should ideally match through even an encoding of surrogates. (It is important to note though that such cases a... | 2022-05-09T15:06:48 | 2022-05-09T15:06:48 | {} | MEMBER |
rust-lang | rust | 1,121,331,742 | 96,473 | bors | :pushpin: Commit 32b13ac9280d15273ef17ee474c0f0a738bb5f5a has been approved by `cjgillot`
<!-- @bors r=cjgillot 32b13ac9280d15273ef17ee474c0f0a738bb5f5a -->
<!-- homu: {"type":"Approved","sha":"32b13ac9280d15273ef17ee474c0f0a738bb5f5a","approver":"cjgillot"} --> | 2022-05-09T16:41:06 | 2022-05-09T16:41:06 | {} | COLLABORATOR |
rust-lang | rust | 1,121,376,053 | 96,715 | bors | :pushpin: Commit e947fad68cc7dce9285364984931dc1f286b9fa3 has been approved by `compiler-errors`
<!-- @bors r=compiler-errors e947fad68cc7dce9285364984931dc1f286b9fa3 -->
<!-- homu: {"type":"Approved","sha":"e947fad68cc7dce9285364984931dc1f286b9fa3","approver":"compiler-errors"} --> | 2022-05-09T17:26:45 | 2022-05-09T17:26:45 | {} | COLLABORATOR |
rust-lang | rust | 1,121,395,533 | 96,864 | notriddle | > I originally wanted to make Item::name field private and implement full_name as name replacement directly.
This sounds like a good idea to me. | 2022-05-09T17:46:13 | 2022-05-09T17:46:13 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,433,085 | 93,661 | bors | :pushpin: Commit 800e0e2cfa845be5a01c611c8f370172b3a7cea5 has been approved by `estebank,Mark-Simulacrum`
<!-- @bors r=estebank,Mark-Simulacrum 800e0e2cfa845be5a01c611c8f370172b3a7cea5 -->
<!-- homu: {"type":"Approved","sha":"800e0e2cfa845be5a01c611c8f370172b3a7cea5","approver":"estebank,Mark-Simulacrum"} --> | 2022-05-09T18:25:46 | 2022-05-09T18:25:46 | {} | COLLABORATOR |
rust-lang | rust | 1,121,445,107 | 96,860 | cuviper | I think `#[allow(dead_code)]` is fine -- we already do that in a number of places in `sys` to avoid cumbersome `cfg` blocks, and this one is a small bit of code anyway. | 2022-05-09T18:38:39 | 2022-05-09T18:38:39 | {} | MEMBER |
rust-lang | rust | 1,120,997,122 | 96,814 | oli-obk | > I'll create a PR
done: https://github.com/rust-lang/rust/pull/96862
> I'm perfectly content with the idea of us losing `assume`s that have been added before if it helps some agenda that's grander than micro-optimizing a handcrafted test case.
We lost some of them. I tried to get them back by telling LLVM mor... | 2022-05-09T11:48:50 | 2022-05-09T11:48:50 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,006,811 | 96,671 | mgeisler | > > The security vulnerability linked to seems to be different: there an attacker would start a SUID binary from a directory under the control of the attacker. The binary would respawn itself by executing the program found at /proc/self/exe (which the attacker can control). This is a real problem. In my opinion, the ex... | 2022-05-09T11:59:48 | 2022-05-09T11:59:48 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,042,036 | 94,488 | JKAnderson409 | @rustbot ready
Sorry I've been out for a long time but I'm back in the office today.
FYI, the Book gives the impression that `Display` can be lossy and that it cannot be derived. If this change means that it may become derivable, then that suggested change by @joshtriplett should go in.
> An example of a trait... | 2022-05-09T12:34:41 | 2022-05-09T12:34:41 | {} | NONE |
rust-lang | rust | 1,121,057,347 | 96,863 | rust-highfive | r? @michaelwoerister
(rust-highfive has picked a reviewer for you, use r? to override) | 2022-05-09T12:49:18 | 2022-05-09T12:49:18 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,111,132 | 96,694 | amab8901 |
> This seems to work correctly when using the "Run" link ([playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=310c27f576d349dd216ccdda2438700a)). This diagnostic will only appear when compiling with Rust 2018 or earlier; Rust 2021 added `FromIterator` to the prelude, which allows th... | 2022-05-09T13:34:26 | 2022-05-09T13:34:26 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,214,483 | 96,838 | oli-obk | @bors retry | 2022-05-09T14:58:22 | 2022-05-09T14:58:22 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,214,523 | 96,845 | bors | :hourglass: Testing commit 694962718f188bbe0905da270733b2bb18fe24f6 with merge 0e345b76a5550d82caff5540649ee0ba6e3b4f3f...
<!-- homu: {"type":"BuildStarted","head_sha":"694962718f188bbe0905da270733b2bb18fe24f6","merge_sha":"0e345b76a5550d82caff5540649ee0ba6e3b4f3f"} --> | 2022-05-09T14:58:25 | 2022-05-09T14:58:25 | {} | COLLABORATOR |
rust-lang | rust | 1,121,046,126 | 80,552 | sdroege | One thing that I needed in my use-case in addition to what `GroupBy` (and the `slice-group-by` crate) provide is access to the remainder of the iterator at any point in time, i.e. an accessor for the `GroupBy::slice` field. | 2022-05-09T12:39:13 | 2022-05-09T12:39:13 | {
"+1": 2
} | CONTRIBUTOR |
rust-lang | rust | 1,121,057,097 | 96,725 | m-ou-se | > My only other concern is that perhaps new APIs should be making use of the (currently unstable) [`BorrowedHandle<'_>`](https://doc.rust-lang.org/std/os/windows/io/struct.BorrowedHandle.html), assuming it will be stabilized sometime soon-ish. But that could be added as a possibility on the tracking issue.
Might be ... | 2022-05-09T12:49:03 | 2022-05-09T12:49:03 | {} | MEMBER |
rust-lang | rust | 1,121,071,319 | 96,862 | rust-log-analyzer |
The job **`mingw-check`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6351997383?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/0eacd4308fb57cb069e7e38cc4a700073a5cc19c/checks/6351997383/logs)
<details><summary><i>Click to see the possible cause of the f... | 2022-05-09T13:01:54 | 2022-05-09T13:09:49 | {} | COLLABORATOR |
rust-lang | rust | 1,121,143,043 | 96,487 | piegamesde | I tried bisecting with the following one-liner: `nix-shell -p 'with (import <nixpkgs> { overlays = [(import (builtins.fetchTarball https://github.com/mozilla/nixpkgs-mozilla/archive/master.tar.gz))]; }); ((rustChannelOf { date = "2022-02-01"; channel = "nightly"; }).rust.override { targets = [ "riscv32i-unknown-none-el... | 2022-05-09T14:02:18 | 2022-05-09T14:02:18 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,179,826 | 96,815 | bors | :sunny: Test successful - [checks-actions](https://github.com/rust-lang-ci/rust/runs/6353740510?check_suite_focus=true)
Approved by: oli-obk
Pushing e013f9e0ca4055930f931a30171c355de42f9f92 to master...
<!-- homu: {"type":"BuildCompleted","approved_by":"oli-obk","base_ref":"master","builders":{"checks-actions":"https:/... | 2022-05-09T14:29:55 | 2022-05-09T14:29:55 | {} | COLLABORATOR |
rust-lang | rust | 1,121,264,381 | 96,602 | TApplencourt | @jyn514, @Mark-Simulacrum If you have time, I think this is ready to review!
Sorry, if I'm too pushy 🙏🏽 | 2022-05-09T15:39:26 | 2022-05-09T15:39:26 | {} | CONTRIBUTOR |
rust-lang | rust | 1,121,293,032 | 96,855 | aadog | @hellow554 If you still don't understand, welcome to consult my project, I can provide a case at any time | 2022-05-09T16:05:58 | 2022-05-09T16:05:58 | {} | NONE |
rust-lang | rust | 1,121,336,379 | 96,877 | bors | :pushpin: Commit 59722228b981f86d5540a43d9eb2cd2c66da92e9 has been approved by `matthiaskrgr`
<!-- @bors r=matthiaskrgr 59722228b981f86d5540a43d9eb2cd2c66da92e9 -->
<!-- homu: {"type":"Approved","sha":"59722228b981f86d5540a43d9eb2cd2c66da92e9","approver":"matthiaskrgr"} --> | 2022-05-09T16:46:08 | 2022-05-09T16:46:08 | {} | COLLABORATOR |
rust-lang | rust | 1,127,640,416 | 97,038 | rust-timer | Awaiting bors try build completion.
@rustbot label: +S-waiting-on-perf | 2022-05-16T12:58:13 | 2022-05-16T12:58:13 | {} | COLLABORATOR |
rust-lang | rust | 1,127,643,187 | 50,035 | nikic | FWIW https://github.com/llvm/llvm-project/commit/aae5f8115a7c9ab2e323cae8a1528d38fc3652f4 should make this happen more reliably. We were previously only dropping such atomic loads inside specific passes, as a side-effect of other optimizations. | 2022-05-16T13:01:08 | 2022-05-16T13:01:08 | {} | CONTRIBUTOR |
rust-lang | rust | 1,127,679,988 | 96,971 | zhaixiaojuan |
>
>Does the LLVM version used by rustc already support it?
Regarding the loongarch architecture, the llvm code is currently being submitted officially, and there are 28 patches that have been merged into the llvm main branch. For details, see https://github.com/llvm/llvm-project
I will answer the policies of... | 2022-05-16T13:31:41 | 2022-05-16T13:31:41 | {
"+1": 1
} | CONTRIBUTOR |
rust-lang | rust | 1,127,745,266 | 97,081 | bors | :hourglass: Trying commit b85ebefcc4ffe44f4ce6f1e8a690256369492d95 with merge 478f542b5fc15d694bbe951c050e0f980667c115...
<!-- homu: {"type":"TryBuildStarted","head_sha":"b85ebefcc4ffe44f4ce6f1e8a690256369492d95","merge_sha":"478f542b5fc15d694bbe951c050e0f980667c115"} --> | 2022-05-16T14:26:05 | 2022-05-16T14:26:05 | {} | COLLABORATOR |
rust-lang | rust | 1,127,813,891 | 96,892 | rust-timer | Queued e07108b10a51c3252d80b9ec8a6a6a1ae6fb54af with parent 56d540e0571ac1b0633ce10644224c495aaf42a0, future [comparison URL](https://perf.rust-lang.org/compare.html?start=56d540e0571ac1b0633ce10644224c495aaf42a0&end=e07108b10a51c3252d80b9ec8a6a6a1ae6fb54af). | 2022-05-16T15:25:38 | 2022-05-16T15:25:38 | {} | COLLABORATOR |
rust-lang | rust | 1,127,890,674 | 96,713 | petrochenkov | @bors r=notriddle | 2022-05-16T16:35:43 | 2022-05-16T16:35:43 | {} | CONTRIBUTOR |
rust-lang | rust | 1,127,905,299 | 96,565 | notriddle | r? @camelid | 2022-05-16T16:51:17 | 2022-05-16T16:51:17 | {} | CONTRIBUTOR |
rust-lang | rust | 1,127,907,734 | 96,539 | bors | :pushpin: Commit 38b1fb4390a140cb81c9c665d0185a48beddd8aa has been approved by `Mark-Simulacrum`
<!-- @bors r=Mark-Simulacrum 38b1fb4390a140cb81c9c665d0185a48beddd8aa -->
<!-- homu: {"type":"Approved","sha":"38b1fb4390a140cb81c9c665d0185a48beddd8aa","approver":"Mark-Simulacrum"} --> | 2022-05-16T16:53:48 | 2022-05-16T16:53:48 | {} | COLLABORATOR |
rust-lang | rust | 1,127,911,699 | 97,084 | Mark-Simulacrum | @bors r+ rollup=never p=1000 | 2022-05-16T16:58:04 | 2022-05-16T16:58:04 | {} | MEMBER |
rust-lang | rust | 1,127,926,564 | 82,499 | ghost | Created #97086 for `link_section` | 2022-05-16T17:13:33 | 2022-05-16T17:13:33 | {
"heart": 1,
"hooray": 1,
"rocket": 1
} | NONE |
rust-lang | rust | 1,123,381,181 | 96,724 | bors | :umbrella: The latest upstream changes (presumably #96931) made this pull request unmergeable. Please [resolve the merge conflicts](https://rustc-dev-guide.rust-lang.org/git.html#rebasing-and-conflicts). | 2022-05-11T08:49:47 | 2022-05-16T17:15:24 | {} | COLLABORATOR |
rust-lang | rust | 1,127,939,157 | 97,025 | oli-obk | @bors try
We should crater this as it adds a new rule to our final MIR output that needs to be upheld or we ICE | 2022-05-16T17:25:23 | 2022-05-16T17:25:23 | {} | CONTRIBUTOR |
rust-lang | rust | 1,127,638,435 | 50,035 | bjorn3 | The linked playground compiles to
```
playground::foo: # @playground::foo
# %bb.0:
retq
# -- End function
```
with optimizations enabled since rustc 1.60.0. | 2022-05-16T12:56:04 | 2022-05-16T12:56:04 | {} | MEMBER |
rust-lang | rust | 1,127,649,351 | 97,079 | rust-log-analyzer |
The job **`mingw-check`** failed! Check out the build log: [(web)](https://github.com/rust-lang/rust/runs/6452527752?check_suite_focus=true) [(plain)](https://github.com/rust-lang/rust/commit/2129d527fddcab1fa7d02ebae980db0c1cc09e56/checks/6452527752/logs)
<details><summary><i>Click to see the possible cause of the f... | 2022-05-16T13:06:41 | 2022-05-16T13:11:07 | {} | COLLABORATOR |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.