owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
swiftlang | swift | 4,581,418,136 | 89,531 | hnrklssn | @swift-ci please test linux platform | 2026-05-30T02:58:09 | 2026-05-30T02:58:09 | {} | MEMBER |
swiftlang | swift | 4,581,418,120 | 89,531 | hnrklssn | **CI Failure:** [Swift Test Linux Platform](https://ci.swift.org/job/swift-PR-Linux/28033/)
**Reason:** Infrastructure error detected
**Type:** Jenkins error
```
[2026-05-30T02:57:12.005Z] [Pipeline] sh
```
Automatically retriggering CI to verify if this is a transient infrastructure issue. | 2026-05-30T02:58:08 | 2026-05-30T02:58:08 | {} | MEMBER |
swiftlang | swift | 4,581,496,165 | 89,442 | AnthonyLatsis | https://github.com/swiftlang/llvm-project/pull/13063
@swift-ci please smoke test | 2026-05-30T03:29:12 | 2026-05-30T03:29:12 | {} | COLLABORATOR |
swiftlang | swift | 4,581,568,371 | 89,531 | hnrklssn | **CI Failure:** [Swift Test Linux Platform](https://ci.swift.org/job/swift-PR-Linux/28035/)
**Reason:** Infrastructure error detected
**Type:** Jenkins error
```
[2026-05-30T03:51:37.000Z] [Pipeline] sh
```
Automatically retriggering CI to verify if this is a transient infrastructure issue. | 2026-05-30T03:52:10 | 2026-05-30T03:52:10 | {} | MEMBER |
swiftlang | swift | 4,581,568,397 | 89,531 | hnrklssn | @swift-ci please test linux platform | 2026-05-30T03:52:10 | 2026-05-30T03:52:10 | {} | MEMBER |
swiftlang | swift | 4,581,644,535 | 89,552 | gottesmm | @swift-ci smoke test | 2026-05-30T04:26:29 | 2026-05-30T04:26:29 | {} | CONTRIBUTOR |
swiftlang | swift | 4,581,643,697 | 89,567 | DougGregor | @swift-ci please test | 2026-05-30T04:26:11 | 2026-05-30T04:26:11 | {} | MEMBER |
swiftlang | swift | 4,581,716,797 | 89,432 | compnerd | @swift-ci please smoke test | 2026-05-30T04:55:31 | 2026-05-30T04:55:31 | {} | MEMBER |
swiftlang | swift | 4,581,654,557 | 89,567 | DougGregor | @swift-ci please test | 2026-05-30T04:30:35 | 2026-05-30T04:30:35 | {} | MEMBER |
swiftlang | swift | 4,581,802,615 | 75,354 | jrflat | For some reason CI used a base swift commit from >10 hours ago that didn't include the fix for `Assertion isa<To>(Val) && "cast<Ty>() argument of incompatible type!"`. I'll try again | 2026-05-30T05:25:29 | 2026-05-30T05:25:29 | {} | CONTRIBUTOR |
swiftlang | swift | 4,581,669,414 | 89,431 | KneupnerTrackunit | Very nice! When/how can I get my hands on that? I will patiently until the next release.
| 2026-05-30T04:37:13 | 2026-05-30T04:37:13 | {} | NONE |
swiftlang | swift | 4,581,795,497 | 89,431 | KneupnerTrackunit | even better! I could fix my real issue based on this diagnostic. THANK YOU | 2026-05-30T05:23:01 | 2026-05-30T05:23:01 | {} | NONE |
swiftlang | swift | 4,581,643,902 | 89,442 | AnthonyLatsis | https://github.com/swiftlang/llvm-project/pull/13063
@swift-ci please smoke test | 2026-05-30T04:26:15 | 2026-05-30T04:26:15 | {} | COLLABORATOR |
swiftlang | swift | 4,581,803,605 | 75,354 | jrflat | https://github.com/apple/swift-system/pull/303
@swift-ci build toolchain Windows | 2026-05-30T05:25:51 | 2026-05-30T05:25:51 | {} | CONTRIBUTOR |
swiftlang | swift | 4,581,939,302 | 89,571 | compnerd | @swift-ci please smoke test | 2026-05-30T06:19:29 | 2026-05-30T06:19:29 | {} | MEMBER |
swiftlang | swift | 4,581,897,421 | 75,354 | jrflat | https://github.com/apple/swift-system/pull/303
@swift-ci build toolchain Windows | 2026-05-30T05:59:12 | 2026-05-30T05:59:12 | {} | CONTRIBUTOR |
swiftlang | swift | 4,581,942,393 | 89,575 | compnerd | @swift-ci please test Windows platform | 2026-05-30T06:21:04 | 2026-05-30T06:21:04 | {} | MEMBER |
swiftlang | swift | 4,581,897,080 | 75,354 | jrflat | It appears to lock onto the last swift commit made _before_ the system PR's last commit. Rebased this test commit on main so we'll see if it helps. | 2026-05-30T05:59:00 | 2026-05-30T05:59:00 | {} | CONTRIBUTOR |
swiftlang | swift | 4,581,942,743 | 89,575 | compnerd | CC: @al45tair @carlpeto | 2026-05-30T06:21:15 | 2026-05-30T06:21:15 | {} | MEMBER |
swiftlang | swift | 4,582,063,476 | 87,060 | j-hui | @swift-ci please smoke test | 2026-05-30T07:19:23 | 2026-05-30T07:19:23 | {} | CONTRIBUTOR |
swiftlang | swift | 4,582,065,198 | 89,566 | j-hui | @swift-ci please test windows platform | 2026-05-30T07:20:12 | 2026-05-30T07:20:12 | {} | CONTRIBUTOR |
swiftlang | swift | 4,582,214,648 | 87,060 | j-hui | @swift-ci please smoke test macos platform | 2026-05-30T08:08:21 | 2026-05-30T08:08:21 | {} | CONTRIBUTOR |
swiftlang | swift | 4,582,852,925 | 89,529 | NotTheNHK | All three failed for different reasons:
- macOS: Failed due to a timeout during its build phase.
- macOS(arm64): Failed due to the Mem2Reg issue.
- Windows: Failed because the following test failed: `functionalities/breakpoint/breakpoint_set_restart/TestBreakpointSetRestart.py`. | 2026-05-30T12:41:57 | 2026-05-30T12:41:57 | {} | CONTRIBUTOR |
swiftlang | swift | 4,582,422,824 | 88,465 | ktoso | @swift-ci please smoke test macOS | 2026-05-30T09:31:34 | 2026-05-30T09:31:34 | {} | CONTRIBUTOR |
swiftlang | swift | 4,582,807,331 | 88,465 | ktoso | @swift-ci please smoke test macOS | 2026-05-30T12:24:44 | 2026-05-30T12:24:44 | {} | CONTRIBUTOR |
swiftlang | swift | 4,582,784,825 | 89,198 | jamieQ | @rintaro @hamishknight is this something you'll be able to provide feedback on at some point? Please let me know if you'd prefer it be taken out of "draft" status for review if that matters for your process. Thanks in advance! | 2026-05-30T12:13:37 | 2026-05-30T12:13:37 | {} | CONTRIBUTOR |
swiftlang | swift | 4,582,783,646 | 89,494 | finagolfin | [All linux trunk toolchain CI broke around the time this pull was merged](https://ci.swift.org/job/oss-swift-package-trigger/5292/console), any idea [what's going on here](https://ci.swift.org/job/oss-swift-package-fedora-41/917/console)?
```00:52:20 /home/build-user/build/buildbot_linux/llvm-linux-x86_64/./bin/clang... | 2026-05-30T12:13:01 | 2026-05-30T12:54:29 | {} | MEMBER |
swiftlang | swift | 4,582,774,288 | 89,496 | xwu | Precisely.
I'm surprised that `print()` has been using `debugDescription` for this long, actually. For instance, it doesn't seem like printing the payload is the right level of detail for the _default_ output:
```swift
let x = Double(nan: 42, signaling: false)
print(x) // "nan(0x2a)"
```
---
Brief investigation sho... | 2026-05-30T12:08:28 | 2026-05-30T20:29:27 | {} | COLLABORATOR |
swiftlang | swift | 4,583,064,808 | 89,573 | tshortli | @swift-ci please smoke test | 2026-05-30T14:14:14 | 2026-05-30T14:14:14 | {} | CONTRIBUTOR |
swiftlang | swift | 4,583,654,058 | 89,574 | xedin | @swift-ci please test | 2026-05-30T18:11:41 | 2026-05-30T18:11:41 | {} | CONTRIBUTOR |
swiftlang | swift | 4,584,443,762 | 89,570 | elsakeirouz | @swift-ci please test macOS | 2026-05-30T20:11:07 | 2026-05-30T20:11:07 | {} | CONTRIBUTOR |
swiftlang | swift | 4,583,554,067 | 83,446 | compnerd | The bootstrapping is now live, the experimental SDK has been promoted to the canonical SDK. | 2026-05-30T17:27:23 | 2026-05-30T17:27:23 | {} | MEMBER |
swiftlang | swift | 4,584,027,679 | 89,442 | AnthonyLatsis | https://github.com/swiftlang/llvm-project/pull/13063
@swift-ci please smoke test macOS | 2026-05-30T19:12:10 | 2026-05-30T19:12:10 | {} | COLLABORATOR |
swiftlang | swift | 4,583,013,034 | 89,431 | tshortli | > Very nice! When/how can I get my hands on that? I will patiently until the next release.
You can use `swiftly` to install development toolchains: https://www.swift.org/install/macos/#development-snapshots | 2026-05-30T13:51:44 | 2026-05-30T13:51:44 | {} | CONTRIBUTOR |
swiftlang | swift | 4,583,555,218 | 88,762 | compnerd | The bootstrapping is completed, which allowed me to also now enable the WMO on the toolchain build. | 2026-05-30T17:27:57 | 2026-05-30T17:27:57 | {} | MEMBER |
swiftlang | swift | 4,583,050,473 | 89,576 | tshortli | @swift-ci please smoke test | 2026-05-30T14:07:46 | 2026-05-30T14:07:46 | {} | CONTRIBUTOR |
swiftlang | swift | 4,583,445,345 | 89,549 | MaxDesiatov | @swift-ci smoke test | 2026-05-30T16:37:58 | 2026-05-30T16:37:58 | {} | CONTRIBUTOR |
swiftlang | swift | 4,583,552,971 | 85,321 | compnerd | With the next snapshot of the toolchain, this should be complete. We now SxS bind the toolchain to the runtime that we ship and bundle it. Because the binaries are bound to the runtime in their app manifest, we know that the collision would not occur. | 2026-05-30T17:26:55 | 2026-05-30T17:26:55 | {} | MEMBER |
swiftlang | swift | 4,583,514,975 | 89,571 | compnerd | @swift-ci please smoke test | 2026-05-30T17:09:31 | 2026-05-30T17:09:31 | {} | MEMBER |
vuejs | core | 423,707,300 | 2 | yyx990803 | /cc @vuejs/collaborators @octref @Atinux @DanielRosenwasser @alexchopin @clarkdo @pi0 @chenjiahan @johnleider @Leopoldthecoder @KaelWD @icarusion @rstoenescu @rigor789 @Hanks10100
You have been added to this repo either because you are a core team member or as maintainer of notable projects that builds on top of Vue... | 2018-09-22T01:28:30 | 2018-09-22T01:28:30 | {
"+1": 13,
"heart": 1
} | MEMBER |
vuejs | core | 423,725,360 | 2 | znck | > VNodes are now context-free
I guess this would affect devtools. /cc @Akryum | 2018-09-22T07:53:41 | 2018-09-22T07:53:41 | {
"+1": 1
} | MEMBER |
vuejs | core | 423,717,774 | 2 | KaelWD | > might gonna change slot names
You could probably use [`slot.length`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/length) to differentiate between scoped and not.
> seem that we cannot access components inside directives anymore
I think we use this in a few places... | 2018-09-22T05:18:39 | 2018-09-22T08:16:03 | {} | CONTRIBUTOR |
vuejs | core | 423,729,071 | 2 | znck | What would be the prop merging behavior for `class` and event props (`onClick`)? | 2018-09-22T09:03:35 | 2018-09-22T09:03:35 | {} | MEMBER |
vuejs | core | 423,729,248 | 2 | HerringtonDarkholme | I share the same concern with @Justineo . Other than ariia/itemprop like attributes, `class` is a common usage of prop falling. Migration tool might help but code modification seems to be unavoidable and tedious.
> why we need the pure props?
@Kingwl ~~I guess it might be used to differentiate between class comp... | 2018-09-22T09:06:34 | 2018-09-22T09:17:42 | {
"+1": 3
} | MEMBER |
vuejs | core | 423,732,467 | 2 | Kingwl | @phanan oh, i forget the pipeline operator syntax :rofl:
you are right, drop it
~~Although pipeline is still stage 1~~ | 2018-09-22T10:09:42 | 2018-09-22T10:09:42 | {} | MEMBER |
vuejs | core | 423,735,378 | 2 | Leopoldthecoder | I also share some of the concerns @Justineo has.
> component authors usually cannot know in advance what attributes are necessary in certain use cases
Without `$attrs`, we may have to manually filter out all explicit component APIs from `props` and attach what's left of it to the desired element.
> we cannot a... | 2018-09-22T10:47:31 | 2018-09-22T10:47:31 | {} | CONTRIBUTOR |
vuejs | core | 423,823,679 | 2 | LinusBorg | This looks a amazing, I finally feel like this is something I can navigate and undestand :-P
Points I want to comment on:
### Props
Like others I'm not too sure about the whole droppinf of $attrs and $listeners, and especially automatic interance of attributes.
While $attrs and $listeners can probably be re... | 2018-09-23T15:14:46 | 2018-09-23T15:16:28 | {
"laugh": 3
} | MEMBER |
vuejs | core | 423,824,909 | 2 | KaelWD | > How do we make them works with types?
[I wrote a little helper for that](https://github.com/vuetifyjs/vuetify/blob/c3c61a9f/src/util/mixins.ts), could probably be included with vue depending on what the API ends up looking like.
```ts
export default mixins(A, B, C).extend({...})
// OR
export default class M... | 2018-09-23T15:33:39 | 2018-09-23T15:35:58 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 423,830,995 | 2 | yyx990803 | Btw @octref - I'd like the 3.0 compiler to provide infrastructure for even better IDE support - e.g. template type checking / type-aware completions. Maybe even keep the language service in the repo. | 2018-09-23T17:00:31 | 2018-09-23T17:00:31 | {
"+1": 2
} | MEMBER |
vuejs | core | 423,834,416 | 2 | znck | Adding `.attr` make me feel Vue templates are not HTML anymore. | 2018-09-23T17:51:10 | 2018-09-23T17:51:10 | {
"+1": 3
} | MEMBER |
vuejs | core | 423,879,073 | 2 | octref | > Btw @octref - I'd like the 3.0 compiler to provide infrastructure for even better IDE support - e.g. template type checking / type-aware completions. Maybe even keep the language service in the repo.
That's great. I'll take a look of the parser / compiler and let you know what change would it take. If we have [Err... | 2018-09-24T05:21:25 | 2018-09-24T05:21:25 | {} | MEMBER |
vuejs | core | 424,556,325 | 2 | rigor789 | Thanks for inviting me to this early (and exciting) preview of Vue 3.0!
**VNodes**
Does the change in VNodes affect the template compiler modules? In NativeScript-Vue we have some syntactic sugar that is handled by the template compiler through modules, I'm guessing these will need to be updated (not a deal break... | 2018-09-26T01:41:45 | 2018-09-26T01:41:45 | {} | CONTRIBUTOR |
vuejs | core | 425,341,909 | 2 | Jinjiang | > Maybe we can differentiate the two (component props vs. native attributes) similar to how we differentiate component events vs. native events with the .attr modifier:
>
> ```
> <!-- this is always a prop, although the component *may* explicitly render it as an attribute, there's no guarantee -->
> <Foo label="12... | 2018-09-28T07:02:26 | 2018-09-28T07:02:48 | {} | MEMBER |
vuejs | core | 426,302,327 | 2 | KaelWD | > `@prop bar: number = 'baz'`
`TS2322: Type '"baz"' is not assignable to type 'number'.` | 2018-10-02T14:47:48 | 2018-10-02T14:47:48 | {
"laugh": 1
} | CONTRIBUTOR |
vuejs | core | 426,296,178 | 2 | yyx990803 | @DanielRosenwasser it's definitely not complete yet.
1. In a functional component there's no `this`, so the only way to access its props is via the argument.
2. Yes.
3. No, props on `this` are readonly (both type-wise and implementation-wise).
Here's how a user would specify props types:
``` ts
interfac... | 2018-10-02T14:31:11 | 2018-10-02T15:20:20 | {
"+1": 1
} | MEMBER |
vuejs | core | 426,328,837 | 2 | HerringtonDarkholme | I've come up an alternative component definition. Make `Component` take two arguments which define `data` and `prop`. It would look like:
```ts
const propDef = {
bar: { type: Number, default: 123 }
}
const dataDef = (prop) => ({
myData: 'bar',
baz: prop.bar + 1
})
class Foo extends Component(propDef, d... | 2018-10-02T15:56:18 | 2018-10-02T15:56:59 | {} | MEMBER |
vuejs | core | 426,357,487 | 2 | KaelWD | > makes it possible to specify compound types as props
Compound types can already be inferred in 2.x, it's non-primitive types that have to be annotated manually.
`type: [String, Number]` works correctly. | 2018-10-02T17:18:27 | 2018-10-02T17:18:27 | {} | CONTRIBUTOR |
vuejs | core | 426,364,457 | 2 | octref | @KaelWD You are right, but afaik it doesn't support some of the more advanced union types, such as string literal unions. Also as you mentioned, it doesn't work for non-primitives, especially object literal / classes.
I guess I meant "complex types" 😛 | 2018-10-02T17:38:40 | 2018-10-02T17:39:04 | {} | MEMBER |
vuejs | core | 426,459,934 | 2 | chrisvfritz | ### Events interpretation
@yyx990803 With the flat structure, does this mean any prop/attr that starts with `on` will be interpreted as an event? So in a template, does this mean `@click="foo"` would do the same thing as `on-click="foo"`/`onClick="foo"`? | 2018-10-02T23:07:56 | 2018-10-02T23:09:26 | {} | CONTRIBUTOR |
vuejs | core | 426,461,508 | 2 | chrisvfritz | ### Functional component function syntax
@yyx990803 Regarding:
```js
const Func = (h, props, slots, ctx) => h('div')
```
I'm wondering if we should keep everything in an object in the 2nd argument, as we do now, so that users don't have to worry about argument order and can just pull out what they need with ... | 2018-10-02T23:16:09 | 2018-10-02T23:16:09 | {
"+1": 6,
"heart": 2
} | CONTRIBUTOR |
vuejs | core | 426,464,413 | 2 | chrisvfritz | ### `resolveComponent` questions
@yyx990803 So this means globally registered components have no effect on render functions? I'm curious what's the reason for this change, as it seems much less convenient.
If we do need `resolveComponent` though, should it actually be asynchronous in case the component being res... | 2018-10-02T23:31:46 | 2018-10-02T23:31:46 | {} | CONTRIBUTOR |
vuejs | core | 426,467,189 | 2 | chrisvfritz | ### Concerns about `class` components being the default
Would `class` components be the recommended default for build-step apps? Would there be any cases where users would have to use a class component, instead of the object syntax? If the answer to any of these is yes, I have strong reservations.
Since many feat... | 2018-10-02T23:47:28 | 2018-10-03T02:48:13 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 426,672,793 | 2 | znck | > If we do need resolveComponent though, should it actually be asynchronous in case the component being resolved is async?
AFAIK async component triggers rerender when component is resolved. | 2018-10-03T15:07:50 | 2018-10-03T15:07:50 | {} | MEMBER |
vuejs | core | 426,689,683 | 2 | yyx990803 | @chrisvfritz
High level notes: anything not specifically mentioned is in principle unchanged.
### Handling multiple listeners to the same event
``` js
h('button', {
onClick: [handlerA, handlerB]
})
```
Also when you `cloneVNode(vnode, { onClick: foo })`, the listeners is merged with existing ones in... | 2018-10-03T15:51:36 | 2018-10-03T15:58:48 | {
"+1": 1
} | MEMBER |
vuejs | core | 426,697,065 | 2 | chrisvfritz | ### Deprecating `nativeOn` (and maybe `inheritAttrs` altogether?)
@yyx990803 I worry that `nativeOn` is actually an anti-pattern though. I personally teach people to never use it, since you can accidentally break any component by changing its root node. And unlike attributes passed to a component, it actually requir... | 2018-10-03T16:10:38 | 2018-10-03T16:10:38 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 426,732,246 | 2 | octref | > However, some library authors in the community will inevitably want to take advantage of stage-x features, thus encouraging their users to, and sometimes they'll be so useful that they eventually become widespread enough that most apps just break sometimes, when part of the spec changes.
I think the worry is unwar... | 2018-10-03T17:49:11 | 2018-10-03T17:49:11 | {} | MEMBER |
vuejs | core | 426,852,745 | 2 | DanielRosenwasser | @chrisvfritz I work on TypeScript, but I hope you can trust this is in good faith. 🙂
I really don't want to push the Vue community into anything that would negatively affect it for the sake of TypeScript support, so I have some of the same concerns you have on the Vue community's behalf; however, the truth of it is... | 2018-10-04T01:09:43 | 2018-10-04T04:48:32 | {
"+1": 2,
"heart": 1
} | CONTRIBUTOR |
vuejs | core | 427,086,603 | 2 | yyx990803 | I was thinking a bit more about the render function signature and would like some feedback.
### Should we remove `h` as the first argument?
> Please vote with thumbs up for removing it, and thumbs down for keeping it.
Since in 3.0 VNodes are context free, it's no longer necessary to use the instance-bound `h` ... | 2018-10-04T16:36:57 | 2018-10-04T16:36:57 | {
"+1": 9
} | MEMBER |
vuejs | core | 427,093,246 | 2 | yyx990803 | Additional considerations for `h` removal and render functions signatures:
First of all we are making render functions signatures for stateful vs. functional components exactly the same.
With `h` always taking up the first argument position, render functions would look clunky with flat arguments:
``` js
rende... | 2018-10-04T16:56:56 | 2018-10-04T16:56:56 | {
"+1": 3
} | MEMBER |
vuejs | core | 427,095,506 | 2 | Akryum | I need to check! :smile_cat: | 2018-10-04T17:03:58 | 2018-10-04T17:03:58 | {} | MEMBER |
vuejs | core | 427,096,629 | 2 | Akryum | Great! Also will it be possible to store the functional components in dev mode with their props at each render? I think the current implementation in the devtools is quite fragile (and props inspect doesn't even work yet). | 2018-10-04T17:07:34 | 2018-10-04T17:08:00 | {} | MEMBER |
vuejs | core | 427,173,904 | 3 | yyx990803 | > Generic type parameter for props (P) comes before data (D)
I'm a bit confused because currently D comes before P. Are you suggesting that Props **should** come before Data, or the other way around?
> Generic type parameter P has defaults
I guess it should default to `{}` instead. I gave it the `Record<string... | 2018-10-04T21:22:00 | 2018-10-04T21:43:39 | {} | MEMBER |
vuejs | core | 427,225,817 | 2 | chrisvfritz | ### Using arrays instead of fragments in the public API
@yyx990803 Currently in our functional components, we can return an array of vnodes. To me, that's much more ideal than introducing fragments as public API, which would be a new concept that also comes with new syntax. In Vue 3, what would you think about just ... | 2018-10-05T02:16:21 | 2018-10-05T02:16:21 | {} | CONTRIBUTOR |
vuejs | core | 427,221,888 | 2 | chrisvfritz | ### Classes in the public API
@yyx990803 @octref @DanielRosenwasser Thanks for all of your feedback. 🙂 I do see some of the advantages of classes, but I guess it's the "likely more stable" part that has me nervous. Building the framework around classes has proven to be painful for React, so it makes me nervous to e... | 2018-10-05T01:48:33 | 2018-10-05T02:22:30 | {} | CONTRIBUTOR |
vuejs | core | 427,310,746 | 2 | chrisvfritz | @yyx990803 OK, this should hopefully help with `class` and the general unpredictability of the ES spec. Talking about this kind of issue with folks at the Framework Maintainer's summit, Tom Dale managed to set up a direct, monthly line of communication with TC39 for the frontend frameworks. See the invite below:
> H... | 2018-10-05T09:59:50 | 2018-10-05T09:59:50 | {} | CONTRIBUTOR |
vuejs | core | 427,353,921 | 2 | chrisvfritz | @nickmessing Regarding JSX, should we have some custom merge syntax to replace use of the spread operator? Otherwise, even with a flat data structure, won't merging for class, style, and events not work correctly? | 2018-10-05T12:45:22 | 2018-10-05T12:45:22 | {} | CONTRIBUTOR |
vuejs | core | 427,355,085 | 2 | LinusBorg | If I understand correctly, the flat data structure should make those behave just the same as normal props and attributes insofar as merging is concerned. | 2018-10-05T12:49:54 | 2018-10-05T12:49:54 | {} | MEMBER |
vuejs | core | 427,386,150 | 2 | yyx990803 | @chrisvfritz
I somehow missed the comment about removing `nativeOn`. Sounds like a good idea, I'll look into it.
Re: "Using arrays instead of fragments in the public API": that's already the case. You can just return arrays in a render function and they get converted to fragments implicitly.
RE: TC39: I actua... | 2018-10-05T14:31:55 | 2018-10-05T14:35:19 | {} | MEMBER |
vuejs | core | 427,520,532 | 3 | DanielRosenwasser | > > Generic type parameter for props (P) comes before data (D)
>
> I'm a bit confused because currently D comes before P. Are you suggesting that Props **should** come before Data, or the other way around?
Whoops! Fixed. Yes, I meant `P` **should** come before `D`.
>
> > Generic type parameter P has defaults... | 2018-10-05T23:01:00 | 2018-10-05T23:01:10 | {} | CONTRIBUTOR |
vuejs | core | 427,634,092 | 2 | michalsnik | Personally I would much rather prefer inconsistence here, than inconvenience by having to explicitly pass class to the child component as a prop. Being them merged automagically is very convenient and feels kinda natural. I use it all the time to have my components independent of the place they’re being used in. This i... | 2018-10-07T08:01:52 | 2018-10-07T08:01:52 | {
"+1": 3
} | MEMBER |
vuejs | core | 427,681,792 | 2 | chrisvfritz | @michalsnik Note that with this proposal, you wouldn't have to explicitly define class as a prop - you could just add `v-bind="$attrs"` to the root element for any components where you wanted this behavior for class and all other attributes. When this is desired for a 3rd party component, it's also an extremely simple ... | 2018-10-07T19:54:33 | 2018-10-07T19:54:33 | {} | CONTRIBUTOR |
vuejs | core | 427,933,530 | 3 | yyx990803 | > I'm a little curious over what the rationale is to only proxy specified props. What are the current design limitations that prevent this.
When a component doesn't declare props, the consumer of the component can pass arbitrary props to it that may conflict with the component's own data or methods. With declared pr... | 2018-10-08T18:24:31 | 2018-10-08T18:24:31 | {} | MEMBER |
vuejs | core | 428,021,651 | 2 | chrisvfritz | @yyx990803 Just to confirm and summarize, does that mean the following will be true for Vue 3?
- `inheritAttrs` will be removed
- `nativeOn`/`.native` will be removed
- All implicit attribute passthrough will be removed, including for `class` and `style`
- The only way to pass arbitrary attributes/events onto a c... | 2018-10-09T00:35:26 | 2018-10-09T00:36:08 | {} | CONTRIBUTOR |
vuejs | core | 428,035,137 | 2 | Justineo | IMO component consumers will expect the fall-through behavior. The real difference is whether component author have to spread `$attrs` manually by default, or they only need to do so when they choose to implement a component as a fragment or other special occasions.
If we prevent the fall-through behavior by default... | 2018-10-09T02:04:35 | 2018-10-09T02:04:35 | {} | MEMBER |
vuejs | core | 428,056,817 | 2 | Justineo | I think it's an education issue in either way. We can also educate users that if you don't explicitly take over `$attrs` they'll be spread into the root element by default...maybe it's only not so intuitive for users coming from React world...
And the current behavior only fails when *component authors didn't do any... | 2018-10-09T04:36:42 | 2018-10-09T04:36:42 | {} | MEMBER |
vuejs | core | 428,046,381 | 2 | chrisvfritz | > If we prevent the fall-through behavior by default, I will expect there will be less 3rd party libs which allow passing arbitrary attributes to DOM
@Justineo I agree with your concerns, but I feel like this is an education issue we can solve with documentation, encouraging people to always define a pass-through wi... | 2018-10-09T03:20:36 | 2018-10-09T14:35:24 | {} | CONTRIBUTOR |
vuejs | core | 428,226,562 | 2 | chrisvfritz | @yyx990803 As an aside, would it be possible to see a kitchen sink example of the proposed class-based component API? | 2018-10-09T14:58:54 | 2018-10-09T14:58:54 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 428,287,817 | 2 | znck | > I'd rather have something work or not work consistently.
I'd prefer a consistent behavior as I don't want to jump into component definition to check if a custom prop can be added or not. It's better to never put extra prop/attrs unless component API/docs explicitly specifies so. | 2018-10-09T17:53:19 | 2018-10-09T17:53:29 | {} | MEMBER |
vuejs | core | 428,289,341 | 4 | phanan | > open question: should we rename them to `onXxx` to differentiate from methods?
I'm all for it. Even for v2.0 and below (where methods are contained within their own object obviously), I always find myself itching for the convention. Another approach might be to use the denoting `$` (though I'm not leaning toward t... | 2018-10-09T17:57:43 | 2018-10-09T17:59:17 | {} | MEMBER |
vuejs | core | 428,310,445 | 4 | phanan | > because of we should be avoided migration fatigue to v3 from v2 as possible, however, as official blog mentioned, we will plan to support about the compatible features for 2.x
While I hear this, we might as well keep in mind that these kinds of backward API changes can only be introduced with major versions, which... | 2018-10-09T18:58:58 | 2018-10-09T18:59:14 | {
"+1": 2
} | MEMBER |
vuejs | core | 423,713,003 | 2 | Justineo | Hi Evan,
Nice work! Here are some of my early thoughts:
### Props
> However, the behavior of **undeclared props falling through as attrs** will be removed; it's as if `inheritAttr` now defaults to `false`. The component will be responsible for merging the props as attrs onto the desired element.
Does this m... | 2018-09-22T03:24:14 | 2018-09-22T03:24:14 | {
"+1": 4
} | MEMBER |
vuejs | core | 423,725,180 | 2 | znck | > However, the behavior of undeclared props falling through as `attrs` will be removed; it's as if `inheritAttr` now defaults to `false`.
What I get here is: `this.$props` would have all the props and there is no `this.$attrs` which means if I have to forward unhandled attributes to an element I have to calculate `t... | 2018-09-22T07:51:00 | 2018-09-22T07:51:00 | {} | MEMBER |
vuejs | core | 423,725,851 | 2 | znck | ```
// after (consistent with JSX usage)
{
type: [Function MyComponent], // type of vnode, some sort of reference to component.
id: 'foo',
domPropsInnerHTML: '',
onClick: foo,
key: 'foo',
ref: ref => {
this.$refs.bar = ref
}
}
```
Maybe we can add type to vnode so that it's easy do the... | 2018-09-22T08:02:44 | 2018-09-22T08:05:37 | {} | MEMBER |
vuejs | core | 423,727,667 | 2 | Kingwl | > Flat Data Format
seems friendly to tsx, should we add event(emit) declaration into component?
similar to props declaration, you can access the declaration of the event in component instance, or $emit the dynamic event
> // Now can also be:
> const Func = (h, props, slots, ctx) => h('div')
> **Func.pure... | 2018-09-22T08:35:54 | 2018-09-22T08:35:54 | {} | MEMBER |
vuejs | core | 423,728,148 | 2 | eddyerburgh | > why we need the pure props?
I think it's to identify functional components from components created with `Vue.extend`/ async components. But I think we could add a flag to extended components, and omit `pure` from functional components. | 2018-09-22T08:45:44 | 2018-09-22T08:45:44 | {
"+1": 6
} | MEMBER |
vuejs | core | 423,728,241 | 2 | phanan | > Filters are gone for good (or can it?)
> a nice sugar for template
Oh man, I can still recall [the chaos it created](https://github.com/vuejs/vue/issues/2756) when the same proposal was raised for v2. Too bad it's been a while and pipe operator is still not a thing yet. FWIW, all the arguments (for both sides) ... | 2018-09-22T08:47:29 | 2018-09-22T08:51:38 | {
"+1": 3
} | MEMBER |
vuejs | core | 423,754,545 | 2 | Hanks10100 | Really be excited with Vue 3, and looking forward to it.
*Weex is built on **bottom** of Vue.js*, so the breaking changes of syntax will not affect Weex actually. But some compatibility work still can't be omitted, mostly for the new package structure and VNode, not syntax.
> #### VNodes are now context-free
B... | 2018-09-22T16:07:55 | 2018-09-23T01:02:31 | {
"+1": 3
} | NONE |
vuejs | core | 423,825,321 | 2 | octref | The only thing affecting Vetur is removal of filter. This is great because I can treat interpolations as JS statements without any custom syntax handling. But also +1 to what @LinusBorg said:
> I'm not too attached to them, but if we drop them, we need a good guide about how to replace them in a maintainable way.
... | 2018-09-23T15:39:18 | 2018-09-23T15:39:18 | {} | MEMBER |
vuejs | core | 423,830,077 | 2 | yyx990803 | Answering a few concerns:
### $attrs
First, `class` and `style` merging behavior remains the same (and now applies to single-root functional components as well).
Second, I think the ability to **render arbitrary attributes on the root of a child component** is a useful one, but currently it's a very implicit b... | 2018-09-23T16:47:23 | 2018-09-23T17:02:14 | {} | MEMBER |
vuejs | core | 423,831,305 | 2 | yyx990803 | @KaelWD that mixins helper is great, I was actually still thinking about how to deal with it 😂 | 2018-09-23T17:04:59 | 2018-09-23T17:04:59 | {
"hooray": 1
} | MEMBER |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.