owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 423,898,841 | 2 | Justineo | > ```html
> <!-- is label a prop or an attribute? -->
> <Foo label="123" />
> ```
I think it's implemention detail and should be encapsulated by component authors. As I understand, the separation of content attributes (attrs) and IDL attributes (props) only makes sense for native elements, as we can only specify ... | 2018-09-24T07:53:49 | 2018-09-24T07:53:49 | {} | MEMBER |
vuejs | core | 423,923,428 | 2 | Akryum | Will there be an easier way for devtools to access to functional components if we cannot access context of vnodes anymore? | 2018-09-24T09:46:42 | 2018-09-24T09:46:42 | {} | MEMBER |
vuejs | core | 424,380,089 | 2 | yyx990803 | Update: attribute fallthrough will be preserved when the component has declared props (the behavior will be the same as before). In addition, all parent `class`, `style` and `nativeOn` bindings will be in `$attrs`, so when the child component returns a Fragment, or has `inheritAttrs: false`, simply doing `v-bind="$attr... | 2018-09-25T15:01:29 | 2018-09-25T15:01:29 | {
"+1": 9
} | MEMBER |
vuejs | core | 426,112,038 | 2 | DanielRosenwasser | > Component no longer need to delcare props in order to receive props. Everything passed from parent vnode's `data` (with the exception of internal properties, i,e. `key`, `ref`, `slots` and `nativeOn*`) will be available in `this.$props` and also as the first argument of the render function. This eliminates the need f... | 2018-10-02T01:00:15 | 2018-10-02T01:00:15 | {} | CONTRIBUTOR |
vuejs | core | 426,315,042 | 2 | yyx990803 | @KaelWD fixed ;) | 2018-10-02T15:20:34 | 2018-10-02T15:20:34 | {} | MEMBER |
vuejs | core | 426,354,792 | 2 | octref | I like interface and implementation for props separated. This makes it possible to specify compound types as props, and it makes clear that anything you put to `options` are runtime behaviors. The typings could be simplified a lot as well. | 2018-10-02T17:10:48 | 2018-10-02T17:10:48 | {} | MEMBER |
vuejs | core | 426,457,931 | 2 | chrisvfritz | ### Handling multiple listeners to the same event
@yyx990803 Will we be able to assign multiple simultaneous listeners without patterns like prop getters, which are necessary in React? Currently, child components don't have to worry about whether the parent might be listening to the same events, like in [this exampl... | 2018-10-02T22:58:19 | 2018-10-02T23:01:17 | {} | CONTRIBUTOR |
vuejs | core | 426,460,806 | 2 | chrisvfritz | ### Emitting events
@yyx990803 With listeners being props, does this mean a listener would have to be declared as a prop to be used? (I'm OK with this.) And if so, would we still need `$emit` or would we just call the function passed to the prop? | 2018-10-02T23:12:30 | 2018-10-02T23:12:30 | {} | CONTRIBUTOR |
vuejs | core | 426,462,897 | 2 | chrisvfritz | ### `createAsyncComponent` with advanced async components
@yyx990803 Does that mean we'd have this kind of API for advanced async components?
```js
createAsyncComponent(() => import('./MyComponent.vue', {
loading: require('./Loading.vue').default
})
``` | 2018-10-02T23:23:39 | 2018-10-02T23:23:48 | {} | CONTRIBUTOR |
vuejs | core | 426,717,146 | 2 | chrisvfritz | @yyx990803
### Events Interpretation
> So in a template, does this mean `@click="foo"` would do the same thing as `on-click="foo"`/`onClick="foo"`?
> No. Template syntax is irrelevant and does not change.
How would `on-click="foo"` be interpreted in a template then? Would it simply be ignored? Translated t... | 2018-10-03T17:05:25 | 2018-10-03T17:05:25 | {} | CONTRIBUTOR |
vuejs | core | 426,727,899 | 2 | yyx990803 | > However, some library authors in the community will inevitably want to take advantage of stage-x features, thus encouraging their users to, and sometimes they'll be so useful that they eventually become widespread enough that most apps just break sometimes, when part of the spec changes.
Honestly, it's like throwi... | 2018-10-03T17:36:13 | 2018-10-03T17:37:44 | {
"+1": 1
} | MEMBER |
vuejs | core | 427,091,867 | 2 | Akryum | How will the devtools be able to go from a DOM element to the corresponding component instance if the vnodes don't have any access to it anymore? Also if I remember correctly there is a PR to add the context for functional components to be able to inspect their props.
On another topic, I think it would be nice to ha... | 2018-10-04T16:53:03 | 2018-10-04T16:53:03 | {} | MEMBER |
vuejs | core | 427,095,193 | 2 | yyx990803 | @Akryum we will still expose `element.__vue__` in dev mode. I don't recall devtools relying on `vnode.context`, or do we? | 2018-10-04T17:02:57 | 2018-10-04T17:02:57 | {} | MEMBER |
vuejs | core | 427,096,002 | 2 | yyx990803 | @Akryum I just did a grep on `dev` branch and looks like we don't ;) | 2018-10-04T17:05:28 | 2018-10-04T17:05:28 | {} | MEMBER |
vuejs | core | 427,098,346 | 2 | Akryum | About SSR I forgot to write that the vue-apollo implementation also recognizes a special attribute like `no-prefetch` which skips a components sub-tree to optimize the tree walking if it is known that no queries will be found there. | 2018-10-04T17:12:55 | 2018-10-04T17:12:55 | {} | MEMBER |
vuejs | core | 427,101,672 | 2 | rigor789 | I believe having `h` as the first argument is convenient, but there are more pros to removing it. Advanced users who are more likely to touch render functions in the first place are not going to mind an extra import for the global `h`. As for the other arguments, if it's just the 3 `props, slots, attrs` then I don't th... | 2018-10-04T17:23:17 | 2018-10-04T17:23:17 | {} | CONTRIBUTOR |
vuejs | core | 427,224,451 | 2 | chrisvfritz | ### Maybe a terrible idea to avoid importing `h` 😅
Similar to how Babel handles polyfills, could we detect JSX or when `h` is called as a function in a Babel plugin, then automatically add `import { h } from Vue` to the module (unless `h` is already defined in the module scope)? Then in the vast majority of cases, ... | 2018-10-05T02:06:25 | 2018-10-05T02:21:05 | {} | CONTRIBUTOR |
vuejs | core | 427,232,001 | 2 | nickmessing | Looks like I'm the only one super excited about flat data format for VNodes. There's always a lot of people having trouble with JSX spreading and this is a great quality-of-life improvement for JSX users. | 2018-10-05T03:00:23 | 2018-10-05T03:00:23 | {
"laugh": 1
} | MEMBER |
vuejs | core | 427,357,278 | 2 | nickmessing | @chrisvfritz, we already have a runtime merge helper, but the object that needs to be passed to spread has to be structured like this:
```js
{
attrs: { id: 'foo' },
domProps: { innerHTML: '' },
on: { click: foo },
key: 'foo',
ref: 'bar'
}
```
With flat data, users can spread object structured just... | 2018-10-05T12:58:10 | 2018-10-05T12:58:10 | {
"heart": 1
} | MEMBER |
vuejs | core | 427,399,182 | 2 | yyx990803 | @chrisvfritz just to clarify, by deprecating `nativeOn` are you proposing that we:
- Removing the `inheritAttrs` option
- If a component wants to allow user to modify its root node, it would explicitly do so by adding `v-bind="$attrs"` to desired root node
- If a component did not do that, then the user would have... | 2018-10-05T15:11:00 | 2018-10-05T15:11:00 | {} | MEMBER |
vuejs | core | 427,412,104 | 2 | chrisvfritz | @nickmessing Great to hear that the runtime merge helper already correctly handles class, style, and events instead of overwriting! 🙂 Thanks for clarifying.
@yyx990803 That is exactly what I'm proposing. And just like with attributes, the user could prevent a listener from being added to $attrs by declaring it as a... | 2018-10-05T15:50:12 | 2018-10-05T15:50:12 | {} | CONTRIBUTOR |
vuejs | core | 427,525,323 | 3 | DanielRosenwasser | # `props` duplication & validation
From https://github.com/vuejs/vue-next/issues/2#issuecomment-426296178
> A few obvious things to improve here:
>
> 1. If the user provided a Props interface but didn't specify the static props options, the props will still be merged onto `this` in types but not in impleme... | 2018-10-05T23:33:49 | 2018-10-05T23:34:17 | {} | CONTRIBUTOR |
vuejs | core | 427,619,813 | 2 | yyx990803 | I'd like to get people's opinion on the idea of removing `inheritAttrs` as outlined [here](https://github.com/vuejs/vue-next/issues/2#issuecomment-427399182). I do occasionally find it convenient to be able to add a class or styling on a child component for layout or ad-hoc tweaks, but I also see how the 2.x behavior c... | 2018-10-07T02:09:10 | 2018-10-07T02:09:10 | {} | MEMBER |
vuejs | core | 427,682,322 | 2 | chrisvfritz | And as Evan mentioned, people would never be able to rely on the behavior, since any component could return multiple root nodes. This means for 3rd party components, changing the template or render function in a way that does not affect the public interface or behavior would still result in breaking changes for users, ... | 2018-10-07T20:01:38 | 2018-10-07T20:01:38 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 427,930,259 | 3 | DanielRosenwasser | > Even so, if we can do some more inference here that will probably strike a better balance of writing less while still getting better types. I've opened up Microsoft/TypeScript#27584 so we can track that
Actually, I realized that props are specified statically (as they should be), not via a `super()` call. So never... | 2018-10-08T18:13:46 | 2018-10-08T18:13:46 | {} | CONTRIBUTOR |
vuejs | core | 427,948,182 | 2 | yyx990803 | Now that I think about it, it is indeed going to be problematic if we keep the implicit class/style fallthrough behavior. Most of the time, we can class/style to style the child component assuming it has a single root node **AND** that the class/style is going to be merged onto the root node. However, it's possible tha... | 2018-10-08T19:13:33 | 2018-10-08T19:15:22 | {
"+1": 1
} | MEMBER |
vuejs | core | 428,023,147 | 2 | Akryum | Could we define events like we do for props? They would be omitted from `$attrs`. Also it might help with HOC and typing, for example `this.$emit.myEvent('foo')` and docs. | 2018-10-09T00:45:13 | 2018-10-09T00:45:13 | {} | MEMBER |
vuejs | core | 428,222,882 | 2 | chrisvfritz | @Justineo
> maybe it's only not so intuitive for users coming from React world...
It's not just React users, unfortunately. Probably most new Vue developers I work with are also surprised by this behavior.
> And the current behavior only fails when component authors didn't do anything to redirect $attrs to th... | 2018-10-09T14:49:52 | 2018-10-09T14:50:39 | {} | CONTRIBUTOR |
vuejs | core | 428,272,105 | 2 | yyx990803 | @chrisvfritz created an issue for that: https://github.com/vuejs/vue-next/issues/4 | 2018-10-09T17:05:07 | 2018-10-09T17:05:07 | {
"+1": 1
} | MEMBER |
vuejs | core | 428,286,301 | 4 | znck | > import { h, Component } from '@vue/renderer-dom'
Doesn't using `h` and `Component` from `'@vue/renderer-dom'` couples component to one renderer? | 2018-10-09T17:48:36 | 2018-10-09T17:48:36 | {} | MEMBER |
vuejs | core | 428,291,024 | 4 | yyx990803 | @znck `h` is just re-exported from `@vue/core` for convenience. It works regardless of render target. You can also import it from `@vue/core`. | 2018-10-09T18:02:23 | 2018-10-09T18:02:23 | {} | MEMBER |
vuejs | core | 428,291,342 | 4 | phanan | > // getters are converted to computed properties
While it's convenient (and I like the syntax), is it always the expected behavior? | 2018-10-09T18:03:19 | 2018-10-09T18:03:19 | {} | MEMBER |
vuejs | core | 428,291,752 | 4 | yyx990803 | @phanan as long as we document this. | 2018-10-09T18:04:33 | 2018-10-09T18:04:33 | {} | MEMBER |
vuejs | core | 428,304,986 | 4 | kazupon | > open question: should we rename them to onXxx to differentiate from methods?
IMO, we should not change the lifecycle method names in v3, because of we should be avoided migration fatigue to v3 from v2 as possible, however, as [official blog](https://medium.com/the-vue-point/plans-for-the-next-iteration-of-vue-js... | 2018-10-09T18:42:51 | 2018-10-09T18:42:51 | {
"+1": 2,
"-1": 1
} | MEMBER |
vuejs | core | 428,332,841 | 4 | chrisvfritz | > `static options: ComponentOptions<App> = {`
To me, it looks very hacky to keep some options top-level and some under an `options` field. Is there a way we can keep everything top-level? E.g.:
```js
static props: ComponentProps<App> = {
// ...
}
```
> App.options = options
This pains me. 😅 Since we... | 2018-10-09T20:07:56 | 2018-10-09T20:07:56 | {} | CONTRIBUTOR |
vuejs | core | 428,337,563 | 4 | Jinjiang | > we might as well keep in mind that these kinds of backward API changes can only be introduced with major versions
The naming difference could be adapted through `createComponentClassFromOptions(options)` in https://github.com/vuejs/vue-next/blob/ba62deb5d938c43c41ec5e7686dc006a91d809b8/packages/core/src/componentU... | 2018-10-09T20:22:25 | 2018-10-09T20:22:25 | {} | MEMBER |
vuejs | core | 428,338,931 | 2 | chrisvfritz | > It's better to never put extra prop/attrs unless component API/docs explicitly specifies so.
@znck For the reasons @Justineo mentioned, I _do_ think there should be an expectation that unless a component renders `null` or only renders children, it should _always_ pass arbitrary attrs/events to some element. Otherw... | 2018-10-09T20:26:52 | 2018-10-09T20:27:06 | {} | CONTRIBUTOR |
vuejs | core | 428,353,252 | 2 | Jinjiang | I have some different thoughts. 😅
First it's great to support fragment and portal. But at the same time, we break up, at least, weaken the "future ready" feature that Vue components could be built into native web components. Because in 3.0, we are not sure a Vue component has a root DOM element. If we couldn't get ... | 2018-10-09T21:09:42 | 2018-10-09T21:09:42 | {} | MEMBER |
vuejs | core | 428,375,152 | 2 | yyx990803 | @Jinjiang
> Because in 3.0, we are not sure a Vue component has a root DOM element.
Native web components always have its own custom element / shadow root that can serve as the root element, so I don't really think that's a problem.
> I suggest to make global html attributes like style, class, aria-* and nati... | 2018-10-09T22:29:21 | 2018-10-09T22:32:20 | {} | MEMBER |
vuejs | core | 543,857,219 | 331 | yyx990803 | The only type change is on the last line where
``` ts
T extends object ? 'object' : 'stop']
```
is changed to
``` ts
T extends object ? 'object' : 'ref']
```
It seems to be missing in latest diff now. | 2019-10-18T17:44:52 | 2019-10-18T17:44:52 | {} | MEMBER |
vuejs | core | 543,890,533 | 334 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-18T19:03:17 | 2019-10-18T19:03:17 | {
"heart": 1
} | CONTRIBUTOR |
vuejs | core | 544,054,654 | 328 | HcySunYang | Since every patched vnode checks for refs and vnode* hooks. we added the `NEED_PATCH` flag even if the refs is static. If the static refs will not have this flag, is there an inconsistency? | 2019-10-19T02:17:46 | 2019-10-19T02:17:46 | {} | MEMBER |
vuejs | core | 545,246,404 | 358 | a631807682 | @yyx990803 I have no idea optimizing for `NaN` actually is meaningful or not, but it check in Vue 2 by this commit.
https://github.com/vuejs/vue/commit/c1bf20acb675aff7ba3e13381b1d45c395a3da7f | 2019-10-23T03:16:11 | 2019-10-23T03:16:11 | {} | CONTRIBUTOR |
vuejs | core | 545,247,453 | 358 | yyx990803 | @a631807682 yeah you are right, I forgot... | 2019-10-23T03:20:21 | 2019-10-23T03:20:21 | {} | MEMBER |
vuejs | core | 545,446,248 | 366 | vue-bot | Hey @underfin, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-23T13:34:11 | 2019-10-23T13:34:11 | {} | CONTRIBUTOR |
vuejs | core | 546,297,638 | 373 | a631807682 | I using this regex to search whether the same problem exists in vscode, they show me alot (not all but most of them are useless), any suggestions?
```
:\s([a-zA-Z]{1,})\s=(\s[a-zA-Z0-9']{1,})
``` | 2019-10-25T10:24:32 | 2019-10-25T10:25:40 | {} | CONTRIBUTOR |
vuejs | core | 543,821,758 | 326 | yyx990803 | Can we also add a test for the in-component directives? | 2019-10-18T16:26:50 | 2019-10-18T16:26:50 | {} | MEMBER |
vuejs | core | 543,834,208 | 331 | himself65 | this is the only way to test a type I known :( | 2019-10-18T16:54:07 | 2019-10-18T16:54:07 | {} | CONTRIBUTOR |
vuejs | core | 543,860,736 | 331 | yyx990803 | Yeah I was wrong. BailTypes should return `ref` as well 🤦♂
The test could be something like
``` js
const a = ref([1, ref(1)]).value
a[0]++
a[1]++
const b = ref([new Map()]).value
b[0].has(1)
``` | 2019-10-18T17:53:57 | 2019-10-18T17:55:44 | {} | MEMBER |
vuejs | core | 543,877,736 | 331 | himself65 | `as const` ??? wow, that's my first time see that
thanks a lot | 2019-10-18T18:32:40 | 2019-10-18T18:32:40 | {} | CONTRIBUTOR |
vuejs | core | 544,530,369 | 335 | vue-bot | Hey @HcySunYang, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-21T14:05:25 | 2019-10-21T14:05:25 | {} | CONTRIBUTOR |
vuejs | core | 545,488,971 | 364 | vue-bot | Hey @a631807682, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-23T15:05:57 | 2019-10-23T15:05:57 | {} | CONTRIBUTOR |
vuejs | core | 545,978,825 | 367 | vue-bot | Hey @wuomzfx, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-24T15:42:59 | 2019-10-24T15:42:59 | {} | CONTRIBUTOR |
vuejs | core | 546,268,172 | 374 | pikax | I can't even find your changes...
your PR:
it should look like:
| 2019-10-25T08:59:20 | 2019-10-25T08:59:20 | {} | MEMBER |
vuejs | core | 546,405,840 | 379 | ayush987goyal | Hey! @yyx990803 Should this function (and some other functions) in `vModel.ts` be exported so that it can be unit tested? | 2019-10-25T15:43:16 | 2019-10-25T15:43:16 | {} | CONTRIBUTOR |
vuejs | core | 544,207,633 | 338 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-20T00:08:18 | 2019-10-20T00:08:18 | {} | CONTRIBUTOR |
vuejs | core | 544,344,201 | 329 | a631807682 | The current verification method is confusing, i think i should use `optionCache` to validate which property is already defined, not only `data` `computed` and `methods`, but also the options which defined in `renderContext`, just like `computed` ~~`watch` `provide`~~ and `inject`. | 2019-10-21T04:30:16 | 2019-10-21T07:54:01 | {} | CONTRIBUTOR |
vuejs | core | 546,374,723 | 371 | vue-bot | Hey @yeyan1996, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-25T14:22:33 | 2019-10-25T14:22:33 | {} | CONTRIBUTOR |
vuejs | core | 546,375,973 | 376 | yyx990803 | 👍 | 2019-10-25T14:25:59 | 2019-10-25T14:25:59 | {
"heart": 1
} | MEMBER |
vuejs | core | 546,381,721 | 354 | vue-bot | Hey @ayush987goyal, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-25T14:40:45 | 2019-10-25T14:40:45 | {} | CONTRIBUTOR |
vuejs | core | 546,610,211 | 383 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-26T14:57:30 | 2019-10-26T14:57:30 | {} | CONTRIBUTOR |
vuejs | core | 546,753,523 | 395 | vue-bot | Hey @djy0, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-28T00:49:27 | 2019-10-28T00:49:27 | {} | CONTRIBUTOR |
vuejs | core | 544,288,113 | 341 | dsseng | @yyx990803 isn't `prefixIdentifiers` 'locked' in `true` state when in module? | 2019-10-20T20:14:05 | 2019-10-20T20:14:05 | {} | CONTRIBUTOR |
vuejs | core | 544,635,798 | 332 | vue-bot | Hey @jo0ger, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-21T18:04:12 | 2019-10-21T18:04:12 | {} | CONTRIBUTOR |
vuejs | core | 545,302,878 | 360 | pikax | you can use `firsttris.vscode-jest-runner` to debug. Or `orta.vscode-jest` to debug failing tests | 2019-10-23T07:09:47 | 2019-10-23T07:09:47 | {} | MEMBER |
vuejs | core | 543,863,939 | 333 | vue-bot | Hey @CyberAP, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-18T18:02:15 | 2019-10-18T18:02:15 | {} | CONTRIBUTOR |
vuejs | core | 544,544,958 | 337 | yyx990803 | refs should be removed after we proposed ref unification in `setup()`. | 2019-10-21T14:37:45 | 2019-10-21T14:37:45 | {
"+1": 1
} | MEMBER |
vuejs | core | 544,546,481 | 337 | dsseng | @yyx990803 may I ask another q about refs? Should we implement function template refs? if so, I want to do those.
| 2019-10-21T14:41:04 | 2019-10-21T14:41:04 | {} | CONTRIBUTOR |
vuejs | core | 545,500,732 | 359 | yyx990803 | It's not very clear from the code but it's done [here](https://github.com/vuejs/vue-next/blob/master/packages/runtime-core/src/createRenderer.ts#L1859). For functions it's just calling the same function with `null` so there's no dedicated unset branch. | 2019-10-23T15:29:32 | 2019-10-23T15:29:32 | {} | MEMBER |
vuejs | core | 545,514,495 | 361 | vue-bot | Hey @Mayness, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-23T15:58:45 | 2019-10-23T15:58:45 | {} | CONTRIBUTOR |
vuejs | core | 545,514,970 | 359 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-23T15:59:52 | 2019-10-23T15:59:52 | {} | CONTRIBUTOR |
vuejs | core | 546,608,593 | 380 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-26T14:37:18 | 2019-10-26T14:37:18 | {} | CONTRIBUTOR |
vuejs | core | 543,875,799 | 331 | yyx990803 | ``` js
const arrRef = ref([1, ref(1)]).value
let [a, b] = arrRef
a + 1
b + 1
```
^ this works because both `1` and `ref(1)` unwraps to `number` and the final value unwraps to `number[]` with no unions. If you have other types of refs in there it will break for sure.
Or you can do
``` js
const arrRef = ref(... | 2019-10-18T18:29:04 | 2019-10-18T18:30:54 | {} | MEMBER |
vuejs | core | 543,888,469 | 334 | yyx990803 | Good catch. This would be valid when we allow exporting a function directly in SFCs. | 2019-10-18T18:57:54 | 2019-10-18T18:57:54 | {
"+1": 1
} | MEMBER |
vuejs | core | 544,291,433 | 341 | yyx990803 | Yes, but mode has nothing to do with `cacheHandlers`. It only has contingency on `prefixIdentifiers`. | 2019-10-20T20:52:22 | 2019-10-20T20:52:22 | {} | MEMBER |
vuejs | core | 544,629,645 | 342 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-21T17:49:03 | 2019-10-21T17:49:03 | {
"heart": 1
} | CONTRIBUTOR |
vuejs | core | 545,244,770 | 358 | yyx990803 | I actually think `NaN` **should** always trigger effects. In actual applications, setting a value to `NaN` is almost always the result of a mistake - i.e. the user expects the value to change, but it ended up being `NaN`.
If `NaN` is used in render - it will show up in the rendered component, so the user will always... | 2019-10-23T03:08:42 | 2019-10-23T03:08:42 | {} | MEMBER |
vuejs | core | 545,247,590 | 358 | Mayness | yes, thanks | 2019-10-23T03:20:56 | 2019-10-23T03:20:56 | {} | CONTRIBUTOR |
vuejs | core | 546,353,689 | 378 | ayush987goyal | Duplicate of #369 | 2019-10-25T13:27:57 | 2019-10-25T13:27:57 | {} | CONTRIBUTOR |
vuejs | core | 546,610,166 | 387 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-26T14:56:56 | 2019-10-26T14:56:56 | {} | CONTRIBUTOR |
vuejs | core | 546,705,985 | 390 | thecrypticace | I believe this is written intentionally to remove the runtime overhead that `...someObject` introduces. | 2019-10-27T15:38:17 | 2019-10-27T15:38:37 | {} | CONTRIBUTOR |
vuejs | core | 546,743,557 | 389 | ZhangJian-3ti | For performance concern., maybe better just in DEV mode. | 2019-10-27T22:54:52 | 2019-10-27T22:54:52 | {} | CONTRIBUTOR |
vuejs | core | 544,637,938 | 345 | vue-bot | Hey @underfin, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-21T18:09:44 | 2019-10-21T18:09:44 | {} | CONTRIBUTOR |
vuejs | core | 544,666,351 | 344 | yyx990803 | FYI I had to revert this after checking the unmount logic. All types of refs need to be tracked so that they can be properly unmounted. | 2019-10-21T19:20:08 | 2019-10-21T19:20:16 | {} | MEMBER |
vuejs | core | 545,499,522 | 359 | dsseng | @yyx990803 maybe I'm wrong but here I can see it unsets only string and ref refs:
| 2019-10-23T15:27:06 | 2019-10-23T15:27:06 | {} | CONTRIBUTOR |
vuejs | core | 546,371,941 | 370 | yyx990803 | Thanks for the PR, but the original test case already tests values nested in arrays. Technically the new case doesn't provide additional reassurance. | 2019-10-25T14:15:12 | 2019-10-25T14:15:12 | {} | MEMBER |
vuejs | core | 543,879,648 | 331 | himself65 | all done (maybe | 2019-10-18T18:36:43 | 2019-10-18T18:36:43 | {} | CONTRIBUTOR |
vuejs | core | 544,530,606 | 336 | yyx990803 | This is something I'm considering removing from the RFC. Direct access to the internal instance creates direct decoupling, while most similar needs can be dealt with using provide/inject. | 2019-10-21T14:06:00 | 2019-10-21T14:06:00 | {} | MEMBER |
vuejs | core | 544,635,107 | 343 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-21T18:02:22 | 2019-10-21T18:02:22 | {} | CONTRIBUTOR |
vuejs | core | 545,504,417 | 359 | dsseng | @yyx990803 done. I'm sorry, I was wrong. I thought you're speaking about ref update. | 2019-10-23T15:37:21 | 2019-10-23T15:37:21 | {} | CONTRIBUTOR |
vuejs | core | 546,753,606 | 391 | yyx990803 | Both Map and Set are iterables and already handled by `Array.from`.
For maps the usage should be `v-for="[key, value] of map"`. We should add tests for them though. | 2019-10-28T00:50:13 | 2019-10-28T00:51:05 | {} | MEMBER |
vuejs | core | 543,860,338 | 331 | himself65 | emmmm, but now
```
ref([1, new Map<any, any>(), ref('1')]).value
// (string | number | Map<any, any> | Ref<string>)
``` | 2019-10-18T17:52:51 | 2019-10-18T17:52:51 | {} | CONTRIBUTOR |
vuejs | core | 543,873,860 | 331 | himself65 | like this example
```ts
const arrRef = ref([1, new Map<any, any>(), ref('1')])
```
BUT the real type of `arrRef.value` is `(number | Map<any, any>, string)[]`
NOT `[number, Map<any, any>, string]` ( for each param has its exact type)
so, the example
```ts
const arrRef = ref([1, ref(1)])
let [a, b] = ar... | 2019-10-18T18:25:04 | 2019-10-18T18:25:04 | {} | CONTRIBUTOR |
vuejs | core | 544,061,666 | 328 | HcySunYang | Oh, I misunderstood, I will adjust this PR. | 2019-10-19T02:41:15 | 2019-10-19T02:41:15 | {} | MEMBER |
vuejs | core | 545,476,521 | 350 | vue-bot | Hey @edison1105, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-23T14:40:00 | 2019-10-23T14:40:00 | {} | CONTRIBUTOR |
vuejs | core | 546,266,597 | 374 | Gloomysunday28 | > Can you do a rebase?
When I pass in the third argument in the mount function, but it is not an object form, but a string, the mount function will report Cannot use 'in' operator to search for 'Symbol()' in test and interrupt the rendering. And quit directly | 2019-10-25T08:55:08 | 2019-10-25T08:55:08 | {} | NONE |
vuejs | core | 546,375,179 | 372 | vue-bot | Hey @dlxqlig, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-25T14:23:48 | 2019-10-25T14:23:48 | {} | CONTRIBUTOR |
vuejs | core | 546,379,975 | 378 | yyx990803 | Thanks, already merged #369. | 2019-10-25T14:36:23 | 2019-10-25T14:36:23 | {} | MEMBER |
vuejs | core | 543,886,647 | 331 | yyx990803 | Turns out `as const` narrows the type too much and doesn't cover actual use cases of mixed types inside an array. I've changed the test case to assert proper type via branch narrowing. | 2019-10-18T18:53:34 | 2019-10-18T18:53:34 | {} | MEMBER |
vuejs | core | 544,542,743 | 340 | dsseng | Sorry for re-implementing. I also thought that this creates duplication, but TODO was there :) | 2019-10-21T14:32:57 | 2019-10-21T14:32:57 | {} | CONTRIBUTOR |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.