owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 470,224,321 | 21 | chrisvfritz | @LinusBorg That's essentially by problem with `observable`. 😄 It doesn't return an "observable" the way most of the rest of the ecosystem thinks of them, but rather a reactive state object. | 2019-03-06T18:38:55 | 2019-03-06T18:38:55 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 471,922,454 | 23 | yyx990803 | @LinusBorg I totally agree. This is in fact my biggest concern as well.
But I think that really depends on how we present it. Here this internal proposal is presenting it directly as a hooks equivalent because that's what it is aiming to be - however, we don't really have to introduce it to the users that way.
No... | 2019-03-12T09:29:55 | 2019-03-12T09:30:29 | {} | MEMBER |
vuejs | core | 472,312,451 | 23 | yyx990803 | @LinusBorg it is trivial to support in the migration build, and in most cases can be automatically converted. The only reason `this.$watch` is exposed on `this` is so that the watcher can be stopped when the component is destroyed. A generic `watch` API can and should be usable in any context. However if we introduce t... | 2019-03-13T07:38:05 | 2019-03-13T07:38:05 | {} | MEMBER |
vuejs | core | 472,372,408 | 23 | posva | is it possible to hit a middleground with a compat plugin that adds those features (watch for example) with warnings an cli hints to do the automatic conversion? | 2019-03-13T10:48:32 | 2019-03-13T10:58:00 | {} | MEMBER |
vuejs | core | 474,770,539 | 23 | yyx990803 | This has been split into two separate RFCs: #24 & #25 | 2019-03-20T10:22:14 | 2019-03-20T10:22:14 | {} | MEMBER |
vuejs | core | 475,082,354 | 24 | yyx990803 | @LinusBorg
- Reactive vs template refs: yeah this is a potential source of confusion. I can't think of a better term than "ref" though because it is literally a reference to a value. Any other naming suggestions?
It is interesting because in React they have unified DOM refs vs. value refs (by making DOM refs... | 2019-03-21T00:56:25 | 2019-03-21T00:57:18 | {} | MEMBER |
vuejs | core | 471,901,081 | 23 | LinusBorg | Hey Evan!
I like this. I don't have any real opinion on the details like `created()` vs. `data()` vs. `state()`, but the general syntax/workflow seems great.
I would like to see the risk of overwhelming users with too many new things, or rather - too many choices with 3.0 - being adressed, though.
I really thi... | 2019-03-12T08:22:10 | 2019-03-12T08:58:40 | {
"+1": 5
} | MEMBER |
vuejs | core | 475,171,817 | 28 | Akryum | - Will functional component function be able to return a Promise?
- `attach props to the function itself` => Will this play nice with TypeScript? | 2019-03-21T10:06:52 | 2019-03-21T10:06:52 | {} | MEMBER |
vuejs | core | 475,598,437 | 24 | HcySunYang | The implementation of `value` api is similar to: `value => state({ value })`? if so, is it really necessary? | 2019-03-22T12:14:06 | 2019-03-22T12:14:06 | {} | MEMBER |
vuejs | core | 475,889,864 | 26 | yyx990803 | @posva they can, with the `<Props>` generic argument.
For the runtime check, yes it is still dev only. | 2019-03-23T17:41:29 | 2019-03-23T17:41:29 | {
"+1": 1
} | MEMBER |
vuejs | core | 475,891,691 | 24 | yyx990803 | @posva it doesn't matter. Implicit nextTick has to fire a internal sync callback anyway. | 2019-03-23T18:05:35 | 2019-03-23T18:05:35 | {} | MEMBER |
vuejs | core | 443,082,826 | 8 | Jinjiang | > I don't see why we couldn't make it valid if it isn't already. 🙂 I don't think we currently allow for multiples arguments on a directive, do we?
_Update: Found that syntax like `@update:value="xxx"` already supported well in v2. No more asked._ 🙂
~In v2 [doc link](https://vuejs.org/v2/guide/components.html#Us... | 2018-11-30T03:55:57 | 2018-11-30T05:54:20 | {} | MEMBER |
vuejs | core | 469,137,049 | 20 | chrisvfritz | @yyx990803 What do you think about that addition to the TypeScript toolchain though? Should we try to push harder on that before trying to balance the compromises of making Vue more complex? | 2019-03-04T06:43:34 | 2019-03-04T06:43:34 | {} | CONTRIBUTOR |
vuejs | core | 469,813,917 | 20 | yyx990803 | @littledan nice! I just did a quick experiment and it seems it would indeed work and solve quite a few issues in our current implementation. I'll try to rework the current prototype to use this strategy to confirm that it fully resolves the issues. | 2019-03-05T18:56:58 | 2019-03-05T18:56:58 | {
"hooray": 1
} | MEMBER |
vuejs | core | 469,829,455 | 20 | yyx990803 | @littledan great news - confirmed that this can indeed work. This also solves all the problems related to `this` identity in `constructor`, fantastic! | 2019-03-05T19:40:58 | 2019-03-05T19:40:58 | {
"hooray": 1
} | MEMBER |
vuejs | core | 474,156,983 | 23 | yyx990803 | Another important aspect is the ability to compose multiple "logic modules" together by passing state between them (while not polluting the namespace of the host component):
``` js
export default {
props: ['id'],
created() {
const position = useMousePosition()
const orientation = useDeviceOrientati... | 2019-03-19T00:57:06 | 2019-03-19T00:59:20 | {
"+1": 2
} | MEMBER |
vuejs | core | 475,543,347 | 27 | LinusBorg | > I believe we've had similar feature requests in the past, but we did not implement it because we felt it didn't provide enough value.
[There's even a current RFC proposal for such an option](https://github.com/vuejs/rfcs/pull/16) | 2019-03-22T09:04:12 | 2019-03-22T09:04:12 | {} | MEMBER |
vuejs | core | 475,633,408 | 27 | LinusBorg | If so I missed the memo ... :-P | 2019-03-22T14:05:07 | 2019-03-22T14:05:07 | {} | MEMBER |
vuejs | core | 475,634,054 | 27 | KaelWD | #2
> Now are internally on-vnode hooks with the exact same lifecycle as components
Maybe I misinterpreted that | 2019-03-22T14:07:00 | 2019-03-22T14:07:00 | {} | CONTRIBUTOR |
vuejs | core | 467,220,851 | 4 | yyx990803 | Closing in favor of https://github.com/vuejs/vue-next/issues/20 | 2019-02-25T23:05:07 | 2019-02-25T23:05:07 | {} | MEMBER |
vuejs | core | 467,229,775 | 20 | yyx990803 | @nickmessing yes, you should consider improving this file: https://github.com/vuejs/vue-next/blob/master/packages/runtime-dom/jsx.d.ts | 2019-02-25T23:39:59 | 2019-02-25T23:39:59 | {} | MEMBER |
vuejs | core | 469,767,693 | 20 | littledan | @nicolo-ribaudo , who has been working on the implementation of private and decorators in Babel, has volunteered to help out with looking into whether Vue could use the pattern in https://github.com/vuejs/vue-next/issues/20#issuecomment-469584878 . Is there any way he could get access to this repository? | 2019-03-05T17:12:20 | 2019-03-05T17:12:20 | {} | NONE |
vuejs | core | 475,457,985 | 29 | yyx990803 | @Akryum
> Will we still be able to access a component from DOM elements?
We can expose anything the devtool needs, since it doesn't have to be part of the public API.
> Will `instance.$vnode` and `vnode.componentInstance` sill work?
Yes. `vnode.componentInstance` will probably have a different name but sti... | 2019-03-22T01:04:53 | 2019-03-22T01:04:53 | {
"+1": 1
} | MEMBER |
vuejs | core | 475,618,448 | 24 | LinusBorg | but would you allow this?
```javascript
const countRef = value(0)
countRef.value // clear
countRef.value = [1,2]
```
* If yes, then why forbid the other way around?
* If no, then my previous comment's explanation is valid. | 2019-03-22T13:21:59 | 2019-03-22T13:21:59 | {} | MEMBER |
vuejs | core | 465,889,991 | 4 | octref | > * When not declared: everything passed in is in `this.$props`.
@yyx990803 I reread some discussion in #2 and #3. [This Comment](https://github.com/vuejs/vue-next/issues/2#issuecomment-426296178) was helpful.
> 1. If the user provided a Props interface but didn't specify the static props options, the props will ... | 2019-02-21T07:21:50 | 2019-02-21T07:21:50 | {} | MEMBER |
vuejs | core | 469,861,768 | 21 | LinusBorg | Me likey.
> The obvious downside is the adjustment pain for current users, but I think that could be mostly alleviated by a period of allowing the old names to work as aliases, while emitting a warning if they're actually used.
This is the most important part for me.
We still have to remember that we are promi... | 2019-03-05T21:20:38 | 2019-03-05T21:22:20 | {
"+1": 2
} | MEMBER |
vuejs | core | 469,875,358 | 20 | littledan | I'm very happy to hear this! Maybe we can work together on documenting this strategy well enough so that other framework authors can learn from this design. | 2019-03-05T22:00:57 | 2019-03-05T22:00:57 | {} | NONE |
vuejs | core | 472,524,148 | 23 | LinusBorg | > Unlike React Hooks, created is called only once, so these calls are not subject to call order and can be conditional.
Good point. Another positive effect of this, combined with the reactivity system v. React's immutable state, it that we don't have to worry about closures breaking stuff if the wrong references are... | 2019-03-13T17:25:40 | 2019-03-13T17:25:40 | {} | MEMBER |
vuejs | core | 474,783,523 | 25 | LinusBorg | Love it as well as the other part of this.
A nice side effect of this approach would be that it solves the problem of naming conflicts when we would introduce new lifecycle hooks in later versions, right?
Right now, in the public discussion about the class API, we are in a back and forth how to namespace lifecycl... | 2019-03-20T11:02:37 | 2019-03-20T11:02:37 | {
"+1": 1
} | MEMBER |
vuejs | core | 475,285,242 | 28 | posva | I think with TS, you should be able to use an interface to type both:
```ts
interface FunctionalProps {
name: string
}
const FunctionalComp: FunctionalComponent<FunctionalProps> = props => {
return h('div', `Hello! ${props.name}`)
}
FunctionalComp.props = {
name: String
}
``` | 2019-03-21T15:46:38 | 2019-03-21T15:46:38 | {} | MEMBER |
vuejs | core | 475,414,863 | 28 | octref | > some users are using functional components solely for performance reasons, e.g. in SFCs with `<template functional>`
For me, the appeal had always been being able to write components with only `template` block, though.
```vue
<template functional>
<div>
{{ props.msg }}
</div>
</template>
```
~~... | 2019-03-21T21:44:26 | 2019-03-21T21:44:47 | {} | MEMBER |
vuejs | core | 475,616,560 | 30 | LinusBorg | > This is similar to using the provide option in a 2.x root instance.
Will we do a separate RFC for provide/inject as a whole or are we planning to keep the `provide` API in components intact? | 2019-03-22T13:15:46 | 2019-03-22T13:15:46 | {
"+1": 1,
"eyes": 1
} | MEMBER |
vuejs | core | 475,869,177 | 25 | posva | I don't get why using `value` instead of `state` here.
Do the same rule for automatic watcher removal apply to hook listeners?
Everything else looks good!
Regarding replacing lifecycle hooks in class declarations, I don't think we should replace them because it's a less intuitive api | 2019-03-23T13:19:46 | 2019-03-23T13:19:46 | {} | MEMBER |
vuejs | core | 444,989,983 | 18 | posva | I don't feel that good about it precisely because it's not about needing it to be reused but about having that reusing mechanism out of the box.
At the same time I feel like new comers get into reuse problems but when they get the explanation that vue reuses components for perf reasons they seem to be happy about it | 2018-12-06T19:04:52 | 2018-12-06T19:04:52 | {} | MEMBER |
vuejs | core | 465,612,327 | 4 | yyx990803 | @octref yes, that one still needs some more work.
First, runtime props option works the same way as in v2:
``` ts
class App extends Component {
static props = {
msg: {
type: String,
default: 'foo',
validator: str => ['foo', 'bar'].includes(str)
}
}
}
```
Second, in the c... | 2019-02-20T14:58:35 | 2019-02-20T14:59:59 | {} | MEMBER |
vuejs | core | 467,233,377 | 20 | nickmessing | @yyx990803, I will release an alpha of TSX support for Vue 2 and then will try to port that to Vue 3. | 2019-02-25T23:55:06 | 2019-02-25T23:55:06 | {} | MEMBER |
vuejs | core | 469,155,249 | 20 | octref | > giving Vue no chance to overwrite the default value properly
```js
class MyComponent extends Vue {
@prop foo: number = 1
bar = this.foo + 1
}
```
I believe you can hijack the setter of `foo` so `1` is merged into `PropOptions.default` instead of written to `this.foo`.
I do have other concerns and I'... | 2019-03-04T08:04:51 | 2019-03-04T08:04:51 | {} | MEMBER |
vuejs | core | 471,223,926 | 20 | yyx990803 | @DanielRosenwasser thanks for the feedback! I agree that ideally, a single interface would offer a decent dev experience and covers both internal and external type checking, however, our current constraints are:
- A runtime schema is required to be able to expose props on `this`, due to potential conflicts;
-... | 2019-03-09T21:33:29 | 2019-03-09T21:55:39 | {} | MEMBER |
vuejs | core | 475,457,423 | 27 | yyx990803 | @Akryum
> It's unclear to me what `cloneVNode` does exactly :(
It clones the VNode :) The 2nd argument to `cloneVNode` is optional. It means "clone and add these additional props". It serves a few purposes:
- Avoid mutating the original VNode
- Handles special merging logic for `class`, `style` and event lis... | 2019-03-22T01:01:29 | 2019-03-22T01:01:29 | {
"+1": 4
} | MEMBER |
vuejs | core | 539,829,962 | 161 | dsseng | @znck probably no, but we could move it to shared. | 2019-10-09T04:57:02 | 2019-10-09T04:57:02 | {} | CONTRIBUTOR |
vuejs | core | 540,460,662 | 179 | tangdaohai | updated! @Himself65 | 2019-10-10T08:30:15 | 2019-10-10T08:30:15 | {} | CONTRIBUTOR |
vuejs | core | 540,702,338 | 190 | vue-bot | Hey @CodeDaraW, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-10T18:00:28 | 2019-10-10T18:00:28 | {} | CONTRIBUTOR |
vuejs | core | 539,653,004 | 164 | znck | You merged before, I opened the webpage. 😆 | 2019-10-08T18:55:01 | 2019-10-08T18:55:01 | {} | MEMBER |
vuejs | core | 540,068,277 | 168 | yyx990803 | Note: this cannot be easily tested because jest tests all run in strict mode and deletion returning false results in TypeError. | 2019-10-09T16:00:57 | 2019-10-09T16:00:57 | {} | MEMBER |
vuejs | core | 540,120,506 | 177 | vue-bot | Hey @Himself65, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-09T18:06:55 | 2019-10-09T18:06:55 | {} | CONTRIBUTOR |
vuejs | core | 540,866,067 | 197 | yyx990803 | Thanks but there is already a test case for the `lazy` option: https://github.com/vuejs/vue-next/blob/master/packages/reactivity/__tests__/effect.spec.ts#L508 | 2019-10-11T01:52:22 | 2019-10-11T01:52:22 | {} | MEMBER |
vuejs | core | 539,489,721 | 159 | yyx990803 | Thanks but code is auto formatted. There is no need to submit style related PRs. | 2019-10-08T12:30:41 | 2019-10-08T12:30:41 | {} | MEMBER |
vuejs | core | 539,496,881 | 153 | himself65 | I see, thanks
| 2019-10-08T12:49:07 | 2019-10-08T12:49:07 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 539,665,651 | 161 | znck | Evan, Is there a way to use the `warn` method from `runtime-core` here? | 2019-10-08T19:28:01 | 2019-10-08T19:28:16 | {} | MEMBER |
vuejs | core | 540,034,951 | 141 | vue-bot | Hey @laquasicinque, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-09T14:46:33 | 2019-10-09T14:46:33 | {} | CONTRIBUTOR |
vuejs | core | 540,505,262 | 184 | vue-bot | Hey @dependabot-preview[bot], thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-10T10:24:56 | 2019-10-10T10:24:56 | {} | CONTRIBUTOR |
vuejs | core | 540,608,954 | 181 | yyx990803 | 👍 | 2019-10-10T14:17:22 | 2019-10-10T14:17:22 | {} | MEMBER |
vuejs | core | 540,611,194 | 181 | vue-bot | Hey @TerenceZ, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-10T14:22:17 | 2019-10-10T14:22:17 | {} | CONTRIBUTOR |
vuejs | core | 539,524,451 | 150 | rigor789 | I feel like `.idea` would be better off in your own global `.gitignore`. | 2019-10-08T13:53:17 | 2019-10-08T13:53:17 | {} | CONTRIBUTOR |
vuejs | core | 539,651,392 | 89 | thecrypticace | 🙌 | 2019-10-08T18:50:49 | 2019-10-08T18:50:49 | {} | CONTRIBUTOR |
vuejs | core | 540,075,868 | 150 | vue-bot | Hey @yinxin630, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-09T16:18:56 | 2019-10-09T16:18:56 | {} | CONTRIBUTOR |
vuejs | core | 540,424,657 | 133 | pikax | closed by https://github.com/vuejs/vue-next/commit/f91d335e6595029b713b55cb0cea77e7085c382d | 2019-10-10T07:11:13 | 2019-10-10T07:11:13 | {} | MEMBER |
vuejs | core | 540,608,998 | 179 | vue-bot | Hey @tangdaohai, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-10T14:17:29 | 2019-10-10T14:17:29 | {} | CONTRIBUTOR |
vuejs | core | 540,615,339 | 188 | vue-bot | Hey @dream2023, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-10T14:31:05 | 2019-10-10T14:31:05 | {} | CONTRIBUTOR |
vuejs | core | 541,059,170 | 208 | xanf | After making this PR I've discovered another set #202 + #204 by @TerenceZ
Sorry for making "duplicate" PR, to simplify maintainers job, I will highlight major differences:
@TerenceZ work:
* is split into two separate PRs which is, of course, better in terms of maintainability
* introduce back `Empty` VNodeType
... | 2019-10-11T13:13:23 | 2019-10-11T13:43:00 | {} | CONTRIBUTOR |
vuejs | core | 541,076,349 | 209 | yyx990803 | Usage of `switch` here is intentional. | 2019-10-11T13:59:19 | 2019-10-11T13:59:19 | {} | MEMBER |
vuejs | core | 539,912,958 | 173 | laquasicinque | At this point, wouldn't it just be faster just to start off with a single array that's got all the values as opposed to having 3 arrays spread into one? | 2019-10-09T09:11:38 | 2019-10-09T09:11:38 | {} | CONTRIBUTOR |
vuejs | core | 540,056,196 | 173 | vue-bot | Hey @hua1995116, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-09T15:33:54 | 2019-10-09T15:33:54 | {} | CONTRIBUTOR |
vuejs | core | 541,055,055 | 207 | pikax | prettier runs when you commit. | 2019-10-11T13:01:33 | 2019-10-11T13:01:33 | {
"+1": 1
} | MEMBER |
vuejs | core | 539,438,681 | 157 | vue-bot | Hey @dependabot-preview[bot], thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-08T09:48:26 | 2019-10-08T09:48:26 | {} | CONTRIBUTOR |
vuejs | core | 539,525,300 | 150 | himself65 | ok | 2019-10-08T13:55:04 | 2019-10-08T13:55:04 | {} | CONTRIBUTOR |
vuejs | core | 539,557,741 | 152 | vue-bot | Hey @yeyan1996, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-08T15:05:22 | 2019-10-08T15:05:22 | {} | CONTRIBUTOR |
vuejs | core | 539,596,592 | 139 | yyx990803 | While I appreciate this PR, I'm actually considering making native element checks entirely compile-time (as a parser option), which produces more efficient runtime code and avoids including the whole list in the runtime itself. | 2019-10-08T16:32:41 | 2019-10-08T16:32:41 | {} | MEMBER |
vuejs | core | 540,077,407 | 170 | vue-bot | Hey @TerenceZ, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-09T16:22:44 | 2019-10-09T16:22:44 | {} | CONTRIBUTOR |
vuejs | core | 540,165,915 | 148 | yyx990803 | Closed via 5dfb271 - still, thanks for the contribution! | 2019-10-09T20:00:30 | 2019-10-09T20:00:30 | {} | MEMBER |
vuejs | core | 540,610,642 | 183 | yyx990803 | These errors will get caught as long as the code is executed in any framework handlers (`setup()`, lifecycle hooks, methods, event handlers...) | 2019-10-10T14:21:06 | 2019-10-10T14:21:06 | {} | MEMBER |
vuejs | core | 540,639,364 | 187 | vue-bot | Hey @xanf, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-10T15:24:19 | 2019-10-10T15:24:19 | {} | CONTRIBUTOR |
vuejs | core | 540,725,448 | 139 | yyx990803 | Compiler side looks good for now. Let's work on the runtime validation in a separate PR. | 2019-10-10T18:53:24 | 2019-10-10T18:53:24 | {} | MEMBER |
vuejs | core | 541,081,253 | 199 | yyx990803 | IMO this PR doesn't really "improve" typing in the sense of providing safer/better inference. Feels like typing for typing's sake. | 2019-10-11T14:11:52 | 2019-10-11T14:11:52 | {
"+1": 2
} | MEMBER |
vuejs | core | 539,652,660 | 130 | yyx990803 | `v-show` is something we will leave for a bit later due to its interaction with the `<transition>` module, which isn't implemented yet. Thanks for the PR though! | 2019-10-08T18:54:08 | 2019-10-08T18:54:08 | {} | MEMBER |
vuejs | core | 540,090,050 | 177 | himself65 | Ok, tomorrow. I’m going to sleep now | 2019-10-09T16:54:22 | 2019-10-09T16:54:22 | {} | CONTRIBUTOR |
vuejs | core | 540,103,290 | 82 | TimvdEijnden | @yyx990803 both changes applied! | 2019-10-09T17:25:38 | 2019-10-09T17:25:38 | {} | CONTRIBUTOR |
vuejs | core | 540,112,770 | 139 | CodeDaraW | Yeah, that's a good idea. After moving the list to `compiler-dom`, we can keep the runtime as efficient as before. | 2019-10-09T17:48:14 | 2019-10-09T17:48:14 | {} | CONTRIBUTOR |
vuejs | core | 540,506,886 | 183 | a631807682 | > Throwing makes sense as the operation will not work and therefore the following code is also unlikely to work as it could rely on it working. Not throwing would also completely hide the problem in production
I think we just need to warning in dev mode, it means it will make mistake if developer don't solve it. jus... | 2019-10-10T10:29:30 | 2019-10-10T10:29:49 | {} | CONTRIBUTOR |
vuejs | core | 539,558,097 | 154 | vue-bot | Hey @meteorlxy, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-08T15:06:06 | 2019-10-08T15:06:06 | {} | CONTRIBUTOR |
vuejs | core | 539,568,900 | 142 | yyx990803 | Thanks for the PR and the catch - after looking at it, I don't think modifying `isSimpleIdentifier` itself is the right place to fix the problem. The root cause is the fast path in `transformExpression` which should take both whitelisted globals and these literals into account. See b4d375b for details. | 2019-10-08T15:29:19 | 2019-10-08T15:29:19 | {} | MEMBER |
vuejs | core | 539,594,739 | 153 | yyx990803 | Not just this, it also avoids the spread (`...args`) which is even more expensive. | 2019-10-08T16:28:13 | 2019-10-08T16:28:13 | {} | MEMBER |
vuejs | core | 539,972,950 | 176 | posva | Thank you but we do test development warnings so these are likely to get covered in the future. Regarding coverage, I think it's too early to try to get close to 100% so I don't think it's a good idea to send PR to ignore code branches | 2019-10-09T12:11:30 | 2019-10-09T12:11:30 | {} | MEMBER |
vuejs | core | 540,082,326 | 175 | yyx990803 | Thanks but I don't think these changes bring meaningful improvements.
1. The `patchClass` function never receives arrays of strings because classes are always normalized.
2. Breaking one liners into tiny modules is unnecessary.
Finally, avoid mixing multiple changes in a single PR. | 2019-10-09T16:34:31 | 2019-10-09T16:34:45 | {} | MEMBER |
vuejs | core | 540,411,329 | 179 | tangdaohai | > I think It would be nice if like this
>
> ```ts
> it('lazy', () => {
> const obj = reactive({ foo: 1 })
> let dummy
> const runner = effect(() => (dummy = obj.foo), { lazy: true })
> expect(dummy).toBe(undefined)
>
> expect(runner()).toBe(1)
> expect(dummy).toBe(1)
> obj.foo... | 2019-10-10T06:45:23 | 2019-10-10T06:45:23 | {
"laugh": 1
} | CONTRIBUTOR |
vuejs | core | 540,505,469 | 186 | vue-bot | Hey @dependabot-preview[bot], thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-10T10:25:26 | 2019-10-10T10:25:26 | {} | CONTRIBUTOR |
vuejs | core | 540,646,369 | 180 | vue-bot | Hey @wuomzfx, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-10T15:39:44 | 2019-10-10T15:39:44 | {} | CONTRIBUTOR |
vuejs | core | 540,701,927 | 191 | vue-bot | Hey @cexbrayat, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-10T17:59:24 | 2019-10-10T17:59:24 | {} | CONTRIBUTOR |
vuejs | core | 540,867,148 | 194 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-11T01:58:17 | 2019-10-11T01:58:17 | {} | CONTRIBUTOR |
vuejs | core | 539,924,241 | 173 | hua1995116 | This is for sure, but I'm not sure if the author has classified. Improvements were made while maintaining the author's original intent. | 2019-10-09T09:41:00 | 2019-10-09T09:41:00 | {} | CONTRIBUTOR |
vuejs | core | 540,114,390 | 139 | CodeDaraW | Should we validate the component name using RegExp in `runtime-core` like this?
https://github.com/vuejs/vue-next/blob/8f1475b8dd840962c8c170cfc5304836792c6431/packages/compiler-core/src/parse.ts#L389 | 2019-10-09T17:52:16 | 2019-10-09T17:52:16 | {} | CONTRIBUTOR |
vuejs | core | 540,144,380 | 149 | yyx990803 | 👍 great work! | 2019-10-09T19:05:30 | 2019-10-09T19:05:30 | {
"+1": 1
} | MEMBER |
vuejs | core | 540,604,133 | 174 | vue-bot | Hey @a631807682, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-10T14:07:57 | 2019-10-10T14:07:57 | {} | CONTRIBUTOR |
vuejs | core | 540,723,900 | 98 | yyx990803 | Thanks for the report. We will add integration tests under `packages/vue/__tests___` for all directives once the work in compiler is done. | 2019-10-10T18:50:36 | 2019-10-10T18:50:36 | {} | MEMBER |
vuejs | core | 540,866,316 | 195 | vue-bot | Hey @dream2023, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-11T01:53:54 | 2019-10-11T01:53:54 | {} | CONTRIBUTOR |
vuejs | core | 539,544,147 | 139 | CodeDaraW | It makes sense.
BTW, after moving `element.ts` to runtime-dom, using a mock validator to test the validation logic in runtime-core may be a better choice. | 2019-10-08T14:36:50 | 2019-10-08T14:36:50 | {} | CONTRIBUTOR |
vuejs | core | 539,831,891 | 171 | znck | Thanks for the PR, however if/else is easier to comprehend compared to early return. | 2019-10-09T05:04:54 | 2019-10-09T05:04:54 | {} | MEMBER |
vuejs | core | 540,592,126 | 125 | dsseng | okay, thank you for explaining! | 2019-10-10T13:47:52 | 2019-10-10T13:47:52 | {} | CONTRIBUTOR |
vuejs | core | 541,083,760 | 201 | vue-bot | Hey @a631807682, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-11T14:18:06 | 2019-10-11T14:18:06 | {} | CONTRIBUTOR |
vuejs | core | 541,096,982 | 202 | yyx990803 | Thanks, the error is actually because I renamed `Empty` to `Comment` (to handle more cases) and forgot to change it in some places it was used. Fixed in 9ad7ae4 | 2019-10-11T14:51:24 | 2019-10-11T14:51:24 | {} | MEMBER |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.