owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 641,490,900 | 1,155 | blocka | How would type checking work in the templates if it's using attrs instead
of props
On Tue, Jun 9, 2020, 8:28 PM PrettyWood <notifications@github.com> wrote:
> Hi! Any feedback on this issue? I have some components that are basically
> just registries with some logic and I would love to be able to just use
> props in ... | 2020-06-09T18:23:23 | 2020-06-09T18:23:23 | {} | NONE |
vuejs | core | 642,085,474 | 1,336 | underfin | See https://vuejs.org/v2/api/#errorCaptured. The `errorCaptured` is only handle error for child components.
```
const Child = {
setup() {
return {
error() {
console.log("In error");
throw "Should be ignored";
},
async asyncError() {
await 1;
... | 2020-06-10T15:29:23 | 2020-06-10T15:29:23 | {} | MEMBER |
vuejs | core | 638,747,752 | 1,261 | CaiPeng1989 | You can temporarily use this configuration to resolve the error
```
"skipLibCheck": true
``` | 2020-06-04T09:55:13 | 2020-06-04T09:55:13 | {
"hooray": 1
} | NONE |
vuejs | core | 639,328,064 | 1,277 | dependabot-preview[bot] | Superseded by #1301. | 2020-06-05T08:10:26 | 2020-06-05T08:10:26 | {} | CONTRIBUTOR |
vuejs | core | 640,679,265 | 1,304 | shortpoet | You're absolutely right, no more error! Both of the use cases work (v-if and dynamic load). I wish I knew why the difference lol. Thank you so much for looking into this. 😊 I apologize if it was a bit of a wild goose chase. I hope you didn't spend too much time on it. 😅 | 2020-06-08T14:51:53 | 2020-06-08T14:51:53 | {} | NONE |
vuejs | core | 641,596,338 | 1,268 | shengxinjing | thanks for reply | 2020-06-09T21:39:01 | 2020-06-09T21:39:01 | {} | CONTRIBUTOR |
vuejs | core | 641,343,512 | 1,324 | pikax | @dodas check https://github.com/vuejs/vue-next/pull/1129 and https://github.com/microsoft/TypeScript/issues/33942 | 2020-06-09T14:43:21 | 2020-06-09T14:43:21 | {
"+1": 1
} | MEMBER |
vuejs | core | 641,594,607 | 1,226 | yyx990803 | Not sure if this is necessary - the newline is for easier inspection/debugging when working on the compiler and its cost is negligible. | 2020-06-09T21:34:47 | 2020-06-09T21:34:47 | {} | MEMBER |
vuejs | core | 637,442,078 | 1,281 | sneppy | How? I need to access the top elements of the vnodes to register some DOM events; I also need to wrap each node in a custom component. In Vue 2.x I would do it like this:
```javascript
let elements = this.$slots.default.map((slot) => slot.elm)
```
and:
```javascript
let cards = this.$slots.default.map((slot... | 2020-06-02T10:18:38 | 2020-06-02T10:18:38 | {} | NONE |
vuejs | core | 638,024,639 | 1,230 | underfin | https://github.com/vuejs/vue-next/pull/1286
Todo: This pr is used the value of `context.parent` is error.This above pr implement it correctly.
| 2020-06-03T07:48:38 | 2020-06-03T07:48:38 | {} | MEMBER |
vuejs | core | 638,916,580 | 1,295 | doter1995 | fix the bug at [pull #1296](https://github.com/vuejs/vue-next/pull/1296) | 2020-06-04T15:14:55 | 2020-06-04T15:14:55 | {} | NONE |
vuejs | core | 638,951,974 | 1,290 | yyx990803 | I think we can add a warning/tip when trying to re-mount an unmounted app and tell the user to move app creation into a function. | 2020-06-04T16:04:34 | 2020-06-04T16:04:34 | {} | MEMBER |
vuejs | core | 640,193,964 | 1,263 | underfin | Yeah.https://github.com/vuejs/vue-next/blob/master/packages/vue/src/index.ts#L72 `registerRuntimeCompiler(compileToFunction)` is an sideEffect for webpack build this.
See https://github.com/webpack/webpack/issues/10978#event-3397796191. Maybe we should change `sideEffect: true` for has internal evalution exports. | 2020-06-07T10:31:59 | 2020-06-07T10:32:11 | {} | MEMBER |
vuejs | core | 641,591,221 | 1,258 | yyx990803 | This is out of scope for now. The Deno ecosystem still lacks some of the most commonly used tools needed for frontend development. It doesn't seem to be worth the effort at this stage. | 2020-06-09T21:27:14 | 2020-06-09T21:27:14 | {} | MEMBER |
vuejs | core | 641,592,933 | 1,261 | yyx990803 | Closed via #1106 | 2020-06-09T21:30:55 | 2020-06-09T21:30:55 | {} | MEMBER |
vuejs | core | 637,210,641 | 1,278 | underfin | https://github.com/less/less.js/issues/3508. The less imports need next version publish.Them already fix it. | 2020-06-02T01:16:41 | 2020-06-02T01:16:41 | {} | MEMBER |
vuejs | core | 641,462,562 | 1,155 | PrettyWood | Hi! Any feedback on this issue? I have some components that are basically just registries with some logic and I would love to be able to just use `props` in setup instead of duplicating the `props` option everywhere or using `attrs`, which becomes confusing in this case | 2020-06-09T17:28:03 | 2020-06-09T17:29:05 | {
"+1": 1
} | NONE |
vuejs | core | 641,589,841 | 1,219 | yyx990803 | Thanks for the PR! Merging https://github.com/vuejs/vue-next/pull/1234 instead since it is a bit more explicit and provides better test coverage, hope you don't mind. | 2020-06-09T21:24:30 | 2020-06-09T21:24:30 | {
"+1": 1
} | MEMBER |
vuejs | core | 642,061,189 | 1,335 | yyx990803 | https://github.com/vuejs/vue-class-component/tree/next | 2020-06-10T14:51:28 | 2020-06-10T14:51:28 | {} | MEMBER |
vuejs | core | 636,948,078 | 1,282 | 34r7h | > Thank you but as said in #1280 and #1279, this is less readable. There is also no need to open 3 pull requests for the same thing
yea didn't see these and was using github directly to see if y'all liked the contribution idea. i made an issue to discuss here https://github.com/vuejs/vue-next/issues/1283 | 2020-06-01T16:05:36 | 2020-06-01T16:05:36 | {} | NONE |
vuejs | core | 637,446,746 | 1,267 | posva | Third party libraries need an upgrade yes. Most of them have already started | 2020-06-02T10:28:49 | 2020-06-02T10:28:49 | {
"+1": 1
} | MEMBER |
vuejs | core | 638,951,366 | 1,296 | yyx990803 | https://github.com/vuejs/vue-next/issues/1287#issuecomment-638252620 | 2020-06-04T16:03:24 | 2020-06-04T16:03:24 | {} | MEMBER |
vuejs | core | 639,329,395 | 1,301 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [ci/circleci: test](https://circleci.com/gh/vuejs/vue-next/5581?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
Dependabot will still automatically merge this pull request if you amend it and your test... | 2020-06-05T08:13:27 | 2020-06-05T08:13:27 | {} | CONTRIBUTOR |
vuejs | core | 639,333,994 | 1,284 | posva | Then it will probably be supported (https://github.com/vuejs/vue-next/issues/1285#issuecomment-637721233) | 2020-06-05T08:21:54 | 2020-06-05T08:21:54 | {} | MEMBER |
vuejs | core | 639,749,623 | 1,114 | Rolanddoda | Not seeing the solution here. Should props must be declared in two places when using TS ? 🤔 | 2020-06-05T19:38:05 | 2020-06-05T19:38:05 | {} | NONE |
vuejs | core | 640,167,359 | 1,311 | underfin | This can work in my local dev.I don't what happened with https://jsfiddle.net/8ctosfgu/31/.I get some error with blew image.It's unrelated and un-reproduction in my dev.
| 2020-06-07T06:53:36 | 2020-06-07T06:54:18 | {} | MEMBER |
vuejs | core | 641,150,163 | 1,324 | pikax | when using generics is recommended to cast:
```ts
export function useMappedRefOriginal<T, MT>(
original: Ref<T>,
fn: (newVal: T) => MT
) {
const mapped = ref(fn(original.value)) as Ref<MT>;
return mapped;
}
``` | 2020-06-09T09:16:53 | 2020-06-09T09:16:53 | {
"+1": 5,
"eyes": 4
} | MEMBER |
vuejs | core | 641,588,276 | 1,259 | yyx990803 | We avoid >ES2015 syntax in the codebase. | 2020-06-09T21:21:26 | 2020-06-09T21:21:26 | {} | MEMBER |
vuejs | core | 641,592,256 | 1,327 | yyx990803 | Vue 3 is not going to provide the bundle renderer since what the bundle renderer does can be handled in userland. | 2020-06-09T21:29:22 | 2020-06-09T21:29:22 | {} | MEMBER |
vuejs | core | 636,943,651 | 1,283 | 34r7h | Let's discuss. If agreeable, I'll comb through the codebase to find and fix appropriate lines. | 2020-06-01T16:01:54 | 2020-06-01T16:01:54 | {} | NONE |
vuejs | core | 638,043,899 | 1,273 | dependabot-preview[bot] | Superseded by #1289. | 2020-06-03T08:25:47 | 2020-06-03T08:25:47 | {} | CONTRIBUTOR |
vuejs | core | 639,315,951 | 1,284 | posva | See https://github.com/vuejs/vue-next/issues/1276#issuecomment-637026034 | 2020-06-05T07:44:54 | 2020-06-05T07:44:54 | {} | MEMBER |
vuejs | core | 639,000,324 | 1,294 | AlexandreBonaventure | If anything, my gut feeling is that the transpilation transforming Object spreads -> Object.assign causes the issue where the subtle difference of implementation like here https://thecodebarbarian.com/object-assign-vs-object-spread.html
Are messing up with the component props/proxy/reactivity like here maybe: https://... | 2020-06-04T17:35:29 | 2020-06-05T13:29:59 | {} | CONTRIBUTOR |
vuejs | core | 639,546,298 | 1,294 | yyx990803 | Hmm, I used the index destructuring because it's slightly faster than array destructuring... but it probably won't be too significant. | 2020-06-05T14:55:07 | 2020-06-05T14:55:07 | {} | MEMBER |
vuejs | core | 640,169,134 | 1,311 | liulinboyi | I think maybe this is the reason.
In VSCode, this SFC code, will prompt error.
 | 2020-06-07T07:12:57 | 2020-06-07T07:12:57 | {} | MEMBER |
vuejs | core | 640,262,894 | 1,315 | yyx990803 | Not really a bug, because syntactically that’s three separate v-ifs that may or may not be true at the same time. So it’s considered a fragment root. Use v-else-if to avoid the ambiguity. | 2020-06-07T18:51:42 | 2020-06-07T18:51:42 | {
"+1": 1
} | MEMBER |
vuejs | core | 641,317,619 | 1,301 | dependabot-preview[bot] | OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`.
If you change your mind, just re-... | 2020-06-09T14:01:15 | 2020-06-09T14:01:15 | {} | CONTRIBUTOR |
vuejs | core | 641,514,618 | 1,331 | yyx990803 | This is actually because a lot of implementations in this benchmark are fine-tuned to perform better (e.g. Inferno, React, Preact) - where they make each row a component and then have a manual `shouldComponentUpdate` to skip the updates. This makes their implementations perform better especially in the "select row" ben... | 2020-06-09T19:10:15 | 2020-06-09T19:11:36 | {
"eyes": 1
} | MEMBER |
vuejs | core | 642,102,945 | 1,336 | jods4 | @underfin Right, the repro is not a good one sorry about that. Didn't pay enough attention when I created it.
The bug is legit, though: in my app the hook is at the App (root) and it doesn't work since `instance` is null in child. (I see you made PR to fix it, thanks!). | 2020-06-10T15:58:25 | 2020-06-10T15:58:25 | {} | CONTRIBUTOR |
vuejs | core | 586,369,371 | 724 | posva | Have you tried using the current master version? It seems to work using the [template explorer](https://vue-next-template-explorer.netlify.com/#%7B%22src%22%3A%22%3Cnav%3E%5Cn%20%20%20%20%3Cdiv%20class%3D'nav-top'%3E%5Cn%20%20%20%20%20%20%3Cdiv%20v-for%3D'n%20of%20stack'%20%3Akey%3D'n.label'%20%40click%3D'go(n.group)'%... | 2020-02-14T16:43:27 | 2020-02-14T16:43:27 | {} | MEMBER |
vuejs | core | 588,985,453 | 745 | rigor789 | @lmiller1990 Thanks for sharing, luckily I have the `nodeOps` implemented already (from the 2.x version) so that part should be straight-forward to refactor for 3.0. 👍
I'm still a little unsure if I should be copying the shared utils as needed -if the core gets updated and the shared util gets an update too, I hav... | 2020-02-20T11:59:45 | 2020-02-20T11:59:45 | {} | CONTRIBUTOR |
vuejs | core | 589,591,692 | 751 | yyx990803 | This is intentional for performance. | 2020-02-21T10:20:43 | 2020-02-21T10:20:43 | {} | MEMBER |
vuejs | core | 590,670,460 | 772 | yyx990803 | Do note in alpha.4 it leads to an infinite loop warning. This is because the ref was referenced as a dependency for the render and mutated (from `null` to the element) in the same render cycle.
The fact that a template ref is `null` during the first render is the expected and correct behavior. To ensure access to th... | 2020-02-25T03:54:57 | 2020-02-25T03:54:57 | {} | MEMBER |
vuejs | core | 591,084,065 | 768 | nmezzopera | @yyx990803 thanks for the clarification! One question, the issue happens even just with render functions. Aren't those separate from the template compilation? | 2020-02-25T21:41:29 | 2020-02-25T21:41:29 | {} | NONE |
vuejs | core | 586,472,473 | 725 | exodusanto | Ok... so no need of the repo link 😄 | 2020-02-14T21:06:06 | 2020-02-14T21:06:06 | {} | NONE |
vuejs | core | 586,582,797 | 716 | ShenQingchuan | [From here... https://github.com/vuejs/vue-next/blob/master/packages/reactivity/src/effect.ts#L197](https://github.com/vuejs/vue-next/blob/master/packages/reactivity/src/effect.ts#L197)
Although in `addRunners` we have a `if` brach to judge whether `effectsToAdd` is `void 0`, but for a huge array or collection, tryi... | 2020-02-15T11:53:00 | 2020-02-15T11:53:00 | {} | CONTRIBUTOR |
vuejs | core | 588,996,775 | 745 | lmiller1990 | Which util were you thinking of using specifically? nativescript-vue seems fairly popular and a big part of the ecosystem - I'm sure if you have a good use case, there might be some way to expose some of the functions in `shared` to the outside world. | 2020-02-20T12:27:44 | 2020-02-20T12:27:44 | {} | MEMBER |
vuejs | core | 589,342,301 | 750 | posva | vue devtools are not adapted yet for Vue 3 but it will come. The repository is at https://github.com/vuejs/vue-devtools btw but it's already planned to add support for Vue 3 | 2020-02-20T21:53:42 | 2020-02-20T21:53:42 | {
"+1": 7
} | MEMBER |
vuejs | core | 589,658,799 | 753 | yyx990803 | @dependabot rebase | 2020-02-21T13:45:18 | 2020-02-21T13:45:18 | {
"+1": 1
} | MEMBER |
vuejs | core | 589,700,361 | 758 | yyx990803 | Thanks, I did the same in 33622d6 | 2020-02-21T15:24:59 | 2020-02-21T15:24:59 | {
"-1": 1,
"eyes": 1
} | MEMBER |
vuejs | core | 589,916,663 | 732 | yyx990803 | This is not a valid feature request. | 2020-02-22T04:22:07 | 2020-02-22T04:22:07 | {} | MEMBER |
vuejs | core | 590,901,175 | 776 | yyx990803 | I think this is a good patch - just curious what specific error did you run into that led you to look into this? It'd be nice to have a reproduction to ensure we are not overlooking the original issue. | 2020-02-25T14:44:15 | 2020-02-25T14:44:15 | {} | MEMBER |
vuejs | core | 591,438,310 | 777 | aztalbot | Looks like the behavior is set to change based on this [rfc](https://github.com/vuejs/rfcs/blob/functional-async-api-change/active-rfcs/0007-functional-async-api-change.md#async-component-creation). `createAsyncComponent` doesn't seem to be implemented yet. Without it, the only way to do async components right now is t... | 2020-02-26T13:56:41 | 2020-02-26T13:59:25 | {
"+1": 4
} | CONTRIBUTOR |
vuejs | core | 591,679,816 | 379 | jacobmllr95 | @yyx990803 Maybe you can revisit this when you find some time.
For more details see: https://github.com/vuejs/vue/pull/9527 | 2020-02-26T22:35:17 | 2020-02-26T22:35:17 | {} | CONTRIBUTOR |
vuejs | core | 592,015,848 | 575 | yyx990803 | @ysj16 I'm not yet fully convinced that this is the best syntax to go with. I think a proper RFC with more discussion around the use case would be needed. | 2020-02-27T15:18:01 | 2020-02-27T15:18:01 | {
"+1": 8
} | MEMBER |
vuejs | core | 592,061,478 | 786 | yyx990803 | I don't think this is correct. v2 doesn't support watching an array of sources, when when the source is an array the `oldValue` should indeed be an empty array. | 2020-02-27T16:49:15 | 2020-02-27T16:49:15 | {} | MEMBER |
vuejs | core | 585,569,496 | 714 | dsseng | @yyx990803 should they be then received by server rendering code and moved where required, right? I can do that. | 2020-02-13T06:15:20 | 2020-02-13T06:15:34 | {} | CONTRIBUTOR |
vuejs | core | 586,495,425 | 724 | jods4 | If template explorer is based on master, that would explain why I couldn't reproduce it then.
I just made a quick test and just having a plain `<svg v-if='x'></svg>` is a repro with `alpha.4`. | 2020-02-14T22:19:08 | 2020-02-14T22:19:08 | {} | CONTRIBUTOR |
vuejs | core | 586,468,567 | 725 | yyx990803 | You can easily provide repro using the global build: https://unpkg.com/browse/vue@3.0.0-alpha.4/dist/ | 2020-02-14T20:54:02 | 2020-02-14T20:54:02 | {
"+1": 1
} | MEMBER |
vuejs | core | 587,522,648 | 736 | posva | Maybe `unknown`, but that's a completely different change | 2020-02-18T15:37:15 | 2020-02-18T15:37:15 | {} | MEMBER |
vuejs | core | 587,619,770 | 737 | yyx990803 | Curious what is the use case that led you to this? Why would you want to know if the underlying value is a ref or not? | 2020-02-18T18:30:54 | 2020-02-18T18:30:54 | {} | MEMBER |
vuejs | core | 587,923,763 | 738 | pikax | @yyx990803 Just read the commit message from the commit I mentioned... Making this PR invalid, but also making the typescript typings (unwrapped ) invalid also.
On the example above the correct access to the properties is:
```ts
`${this.ref} ${this.object.msg} ${this.value} ${this.nested.ref.value} ${this.refNest... | 2020-02-18T21:59:08 | 2020-02-18T21:59:08 | {} | MEMBER |
vuejs | core | 589,705,917 | 737 | yyx990803 | I'm starting to think that Arrays should not automatically unwrap refs it contains. With ref unwrapping it becomes very complicated to ensure expected behavior for all the built-in Array methods. For example, the following could be ambiguous:
``` js
const n = ref(2)
const arr = [1, n, 3]
const mapped = arr.map(v ... | 2020-02-21T15:37:16 | 2020-02-21T15:49:54 | {} | MEMBER |
vuejs | core | 589,715,342 | 759 | yyx990803 | Seems to be a problem in `ref`'s typing instead of watch, since the type of `coerced` should be `Ref<number>` instead of `Ref<number | Ref<number>>`. | 2020-02-21T15:58:25 | 2020-02-21T15:58:25 | {} | MEMBER |
vuejs | core | 590,901,549 | 772 | yyx990803 | @jods4 `setup()` + all lifecycle hooks. | 2020-02-25T14:45:04 | 2020-02-25T14:45:04 | {
"+1": 1
} | MEMBER |
vuejs | core | 585,836,574 | 721 | yyx990803 | Where would this service be injected by the application then?
Have you looked at the `provide`/`inject` usage in composition API? They can be typed too. https://composition-api.vuejs.org/api.html#provide-inject | 2020-02-13T16:10:02 | 2020-02-13T16:10:02 | {} | MEMBER |
vuejs | core | 589,537,996 | 753 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [ci/circleci: test](https://circleci.com/gh/vuejs/vue-next/2756?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
Dependabot will still automatically merge this pull request if you amend it and your test... | 2020-02-21T07:46:17 | 2020-02-21T07:46:17 | {} | CONTRIBUTOR |
vuejs | core | 589,595,896 | 752 | yyx990803 | This seems arbitrary. IMO it's the correct place to use reduce. | 2020-02-21T10:32:05 | 2020-02-21T10:32:05 | {} | MEMBER |
vuejs | core | 591,615,182 | 775 | yyx990803 | Great job! | 2020-02-26T19:59:59 | 2020-02-26T19:59:59 | {} | MEMBER |
vuejs | core | 591,670,767 | 785 | yyx990803 | I don't think this is necessary - all these flags default to false and it is common to do `FLAG=1 [some command]`. | 2020-02-26T22:11:46 | 2020-02-26T22:11:46 | {} | MEMBER |
vuejs | core | 586,469,987 | 724 | yyx990803 | Closing since I can confirm this is fixed in current master. Will be releasing alpha.5 soon. | 2020-02-14T20:58:26 | 2020-02-14T20:58:26 | {
"+1": 1
} | MEMBER |
vuejs | core | 586,648,135 | 729 | yyx990803 | Due to the need for passing down the ssr context via app context (see e495fa4) this is no longer applicable. | 2020-02-15T22:42:12 | 2020-02-15T22:42:12 | {} | MEMBER |
vuejs | core | 587,614,330 | 731 | yyx990803 | We'll keep it in for now, will be supported in alpha.5 and onward. When support becomes universal we'll likely start adding warnings for it. | 2020-02-18T18:27:13 | 2020-02-18T18:27:28 | {} | MEMBER |
vuejs | core | 588,463,740 | 745 | msaelices | I guess that a good starting point would be reading how the `compiler-dom` and `runtime-dom` do their stuff and mimic the approach, using `compiler-core` and `runtime-core`. BTW, I don't know if there are any caveats here. | 2020-02-19T21:00:22 | 2020-02-19T21:00:22 | {} | NONE |
vuejs | core | 590,437,364 | 763 | yyx990803 | Thanks, this is covered by #764 which includes more fixes. | 2020-02-24T17:02:03 | 2020-02-24T17:02:10 | {} | MEMBER |
vuejs | core | 590,968,454 | 766 | jods4 | @yyx990803 Would love an alpha.7 soon if you can, this bug has high impact and breaks many bindings for me. | 2020-02-25T17:10:03 | 2020-02-25T17:10:03 | {} | CONTRIBUTOR |
vuejs | core | 586,648,036 | 714 | yyx990803 | I was testing this locally and realized it's better to pass the ssr context via the app context instead. Handles concurrency and doesn't require nested passing.
The previous passing implementation would also require the compiler to generate different code (in order for `renderComponent` calls used in ssr render func... | 2020-02-15T22:40:58 | 2020-02-15T22:40:58 | {} | MEMBER |
vuejs | core | 589,478,034 | 749 | loiacon | It appears to be something on attributes merge.
https://github.com/vuejs/vue-next/blob/a840e7ddf0b470b5da27b7b2b8b5fcf39a7197a2/packages/runtime-core/src/componentRenderUtils.ts#L79-L92 | 2020-02-21T03:14:26 | 2020-02-21T03:14:26 | {} | CONTRIBUTOR |
vuejs | core | 589,660,800 | 756 | hareku | @yyx990803
Thank you refactor and merge it. | 2020-02-21T13:50:43 | 2020-02-21T13:50:43 | {} | CONTRIBUTOR |
vuejs | core | 589,916,476 | 757 | yyx990803 | See 775a7c2 | 2020-02-22T04:18:48 | 2020-02-22T04:18:48 | {} | MEMBER |
vuejs | core | 589,916,702 | 760 | yyx990803 | Duplicate of #761 | 2020-02-22T04:22:42 | 2020-02-22T04:22:42 | {} | MEMBER |
vuejs | core | 590,892,092 | 772 | yyx990803 | `watch` behavior has also changed! (See the last item [here](https://github.com/vuejs/vue-next/blob/master/CHANGELOG.md#breaking-changes-1))
Eager watchers now fire synchronously (this is necessary to make them work inside Suspense trees and for server rendering). To make the initial run be able to access template r... | 2020-02-25T14:25:40 | 2020-02-25T14:25:40 | {} | MEMBER |
vuejs | core | 590,899,353 | 773 | yyx990803 | Oh I linked the wrong issue in that commit (it was meant to fix this one) | 2020-02-25T14:40:38 | 2020-02-25T14:40:38 | {
"+1": 1
} | MEMBER |
vuejs | core | 591,349,740 | 782 | vankop | Will be great if there is a simple workaround.. | 2020-02-26T10:18:26 | 2020-02-26T10:18:33 | {} | NONE |
vuejs | core | 592,285,976 | 784 | yyx990803 | Thanks a lot for the PR - although it wasn't fully fixing the issue, it did help me identify the underlying problem faster.
See https://github.com/vuejs/vue-next/commit/6810d1402e214a12fa274ff5fb7475bad002d1b1 - we need to account for more possible merged attrs than just `class` or `style`. In addition, we should on... | 2020-02-28T02:54:32 | 2020-02-28T02:54:32 | {
"laugh": 1
} | MEMBER |
vuejs | core | 586,393,100 | 725 | exodusanto | Maybe related to #724 but I have this error at runtime and the example is more simple | 2020-02-14T17:41:16 | 2020-02-14T17:41:16 | {} | NONE |
vuejs | core | 586,466,800 | 725 | yyx990803 | The actual warning should be `Invalid HostVNode type: undefined`, right? (If I am right, this is exactly why you should provide an actual repro) | 2020-02-14T20:48:25 | 2020-02-14T20:48:25 | {} | MEMBER |
vuejs | core | 586,468,288 | 725 | exodusanto | Right. Is there any codesandbox template with Vue 3? | 2020-02-14T20:53:12 | 2020-02-14T20:53:22 | {} | NONE |
vuejs | core | 587,283,172 | 716 | yyx990803 | Thanks for your effort, but I don't think the fix is on the right track... see e1c9153
We should only add a case for `Map.set`. There are cases where the iterate effect should not be triggered - e.g. when the target can be an Array or a WeakMap.
Also, `addRunners` dedupes the effects using Sets so there's no need f... | 2020-02-18T05:17:34 | 2020-02-18T05:17:34 | {} | MEMBER |
vuejs | core | 587,448,361 | 736 | hareku | @posva
Thank you. I agree your opinion, but I think the error type of `ErrorCapturedHook` should be changed to `any`, because anything other than Error may be thrown.
What do you think? | 2020-02-18T13:00:16 | 2020-02-18T13:00:48 | {} | CONTRIBUTOR |
vuejs | core | 590,177,197 | 759 | clemyan | I see this specific instance of the issue is fixed in `alpha.6`. However, I still think this is a problem with `watch`. As long as the `value` property of `Ref<T>` is typed as `UnwrapRef<T>`, it is not type-safe to treat `ref.value` as `T` and pass it to `WatchCallback<T, T>`.
[Type-unsafe example](http://www.typesc... | 2020-02-24T05:58:39 | 2020-02-24T05:58:39 | {} | NONE |
vuejs | core | 590,436,579 | 770 | yyx990803 | Thanks, I tested this vs. current CircleCI setup and the CircleCI version is still a bit faster. | 2020-02-24T17:00:43 | 2020-02-24T17:00:43 | {
"heart": 1
} | MEMBER |
vuejs | core | 591,479,970 | 782 | yyx990803 | This has been fixed by 8cb0b83 | 2020-02-26T15:19:26 | 2020-02-26T15:19:26 | {} | MEMBER |
vuejs | core | 587,273,732 | 731 | yyx990803 | I believe we intentionally removed it at one point, since according to MDN `xlink:href` has been deprecated in SVG 2: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:href
Based on [caniuse data](https://caniuse.com/#feat=mdn-svg_elements_use_href) it seems most browsers down to IE11 supports directl... | 2020-02-18T04:33:51 | 2020-02-18T04:35:01 | {} | MEMBER |
vuejs | core | 587,511,554 | 716 | ShenQingchuan | Ah... seems like I was over thinking about this case ... 🤣 my first commit was just right ... | 2020-02-18T15:15:22 | 2020-02-18T15:15:22 | {} | CONTRIBUTOR |
vuejs | core | 590,767,994 | 772 | jods4 | @yyx990803 The problem is... it just doesn't work.
This was a simple repro, but my intent is to access the DOM element in a `watch` to do stuff with the elements. As `watch` is run after mounting, it's supposed to work, doesn't it?
This examples paints a canvas:
https://codesandbox.io/s/pedantic-ives-3iyqk
It w... | 2020-02-25T09:25:38 | 2020-02-25T09:25:38 | {} | CONTRIBUTOR |
vuejs | core | 591,172,423 | 772 | jods4 | Shall I open an issue for that?
I'm learning new things (functions ref!) but it's ridiculous that I can achieve it with this obscure syntax yet the intuitive way doesn't work. | 2020-02-26T00:46:45 | 2020-02-26T00:46:45 | {} | CONTRIBUTOR |
vuejs | core | 591,999,602 | 575 | ysj16 | Is this feature in progress? If not, I can try. @yyx990803 | 2020-02-27T14:26:42 | 2020-02-27T14:26:42 | {} | CONTRIBUTOR |
vuejs | core | 587,274,072 | 731 | yyx990803 | Edit: I actually removed it in a7eefaf and then landed it back in e6e2c58 thinking I missed it 🤦♂ | 2020-02-18T04:35:29 | 2020-02-18T04:35:48 | {} | MEMBER |
vuejs | core | 587,438,921 | 736 | posva | I don't think it's a good idea to transform the error thrown by the user. They are responsible to throw valid errors but they could also be throwing anything and expect to get back that same thin in the error handler | 2020-02-18T12:35:10 | 2020-02-18T12:35:10 | {} | MEMBER |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.