owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 540,027,760 | 148 | yyx990803 | 1. Yes, `v-pre` should be handled at parser level
- Skip interpolation parsing
- Parse all elements as plain elements (with `tagType: ElementTypes.ELEMENT`)
- Parse all attributes as plain attributes (with `type: NodeTypes.ATTRIBUTE`)
2. This should be in compiler-core, directly in `src/parse.ts`. | 2019-10-09T14:30:43 | 2019-10-09T14:30:43 | {} | MEMBER |
vuejs | core | 540,076,924 | 169 | vue-bot | Hey @TerenceZ, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-09T16:21:31 | 2019-10-09T16:21:31 | {} | CONTRIBUTOR |
vuejs | core | 540,437,538 | 81 | TimvdEijnden | @hugoazevedosoares You can get some inspiration from my PR about other warnings: https://github.com/vuejs/vue-next/pull/82 😉 | 2019-10-10T07:37:40 | 2019-10-10T07:37:40 | {} | CONTRIBUTOR |
vuejs | core | 540,505,674 | 185 | vue-bot | Hey @dependabot-preview[bot], thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-10T10:25:57 | 2019-10-10T10:25:57 | {} | CONTRIBUTOR |
vuejs | core | 540,637,228 | 187 | yyx990803 | 👍 nice catch! | 2019-10-10T15:19:26 | 2019-10-10T15:19:26 | {} | MEMBER |
vuejs | core | 541,017,595 | 89 | thecrypticace | Rebased. | 2019-10-11T10:57:22 | 2019-10-11T10:57:22 | {} | CONTRIBUTOR |
vuejs | core | 539,438,897 | 158 | vue-bot | Hey @dependabot-preview[bot], thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-08T09:49:01 | 2019-10-08T09:49:01 | {
"laugh": 1
} | CONTRIBUTOR |
vuejs | core | 539,489,876 | 156 | yyx990803 | Code is auto-formatted. There is no need for style-related PRs. | 2019-10-08T12:31:09 | 2019-10-08T12:31:09 | {} | MEMBER |
vuejs | core | 539,523,528 | 139 | rigor789 | I have to agree with @znck - the element names are specific to the DOM, and are not required in other platforms (NativeScript in my case). :) | 2019-10-08T13:51:16 | 2019-10-08T13:51:16 | {} | CONTRIBUTOR |
vuejs | core | 539,628,794 | 99 | vue-bot | Hey @Himself65, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-08T17:53:18 | 2019-10-08T17:53:18 | {} | CONTRIBUTOR |
vuejs | core | 540,065,409 | 155 | vue-bot | Hey @a631807682, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-09T15:54:25 | 2019-10-09T15:54:25 | {} | CONTRIBUTOR |
vuejs | core | 540,078,691 | 161 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-09T16:25:55 | 2019-10-09T16:25:55 | {
"heart": 1
} | CONTRIBUTOR |
vuejs | core | 540,146,239 | 149 | vue-bot | Hey @CyberAP, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-09T19:10:23 | 2019-10-09T19:10:23 | {} | CONTRIBUTOR |
vuejs | core | 540,247,927 | 98 | jesusantguerrero | @yyx990803 Hello Evan, could you please take a look at this one? | 2019-10-09T23:25:52 | 2019-10-09T23:25:52 | {} | NONE |
vuejs | core | 539,868,089 | 172 | posva | Thanks but the old version is way more performant with `has` | 2019-10-09T07:04:40 | 2019-10-09T07:04:40 | {} | MEMBER |
vuejs | core | 539,876,930 | 165 | haoqunjiang | Duplicate of https://github.com/vuejs/vue-next/pull/161 | 2019-10-09T07:31:30 | 2019-10-09T07:32:21 | {} | MEMBER |
vuejs | core | 540,121,095 | 82 | vue-bot | Hey @TimvdEijnden, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-09T18:08:22 | 2019-10-09T18:08:22 | {} | CONTRIBUTOR |
vuejs | core | 540,611,686 | 182 | vue-bot | Hey @pikax, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-10T14:23:20 | 2019-10-10T14:23:20 | {} | CONTRIBUTOR |
vuejs | core | 541,062,805 | 207 | Domino9697 | @pikax yes this is already great ! However, if like me you use different formatters on different projects, I have to switch between them. And IMO, a dev should see its code formatted when he codes within his editor :) | 2019-10-11T13:23:45 | 2019-10-11T13:23:45 | {} | CONTRIBUTOR |
vuejs | core | 539,806,514 | 89 | thecrypticace | I just took a couple of minutes to track down the `[object Object]`. It falls out from comments assuming the children property will be always be a string.
https://github.com/vuejs/vue-next/blob/723dc8791b39f96ec0ba9acdc40f4f33426ad733/packages/runtime-core/src/createRenderer.ts#L679-L680
https://github.com/vuejs/vu... | 2019-10-09T03:23:22 | 2019-10-09T03:26:01 | {} | CONTRIBUTOR |
vuejs | core | 540,089,268 | 177 | yyx990803 | Need a rebase against master for the tests to pass. | 2019-10-09T16:52:18 | 2019-10-09T16:52:18 | {} | MEMBER |
vuejs | core | 540,103,483 | 125 | dsseng | @yyx990803 could you please take another look on this? We can move that symbol to `@vue/shared` package to avoid cross-imports. Sorry for taking your time. | 2019-10-09T17:26:06 | 2019-10-09T17:26:06 | {} | CONTRIBUTOR |
vuejs | core | 540,120,316 | 178 | yyx990803 | Thanks but I don't think code simple as that really need unit tests. These code paths will be covered in higher level tests anyway. | 2019-10-09T18:06:27 | 2019-10-09T18:06:27 | {
"+1": 2
} | MEMBER |
vuejs | core | 540,707,335 | 192 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-10T18:13:14 | 2019-10-10T18:13:14 | {
"heart": 1
} | CONTRIBUTOR |
vuejs | core | 540,717,345 | 81 | ant1m4tt3r | > @hugoazevedosoares You can get some inspiration from my PR about other warnings: #82
Thanks @TimvdEijnden , but I could not find the context of the property change in this function. Do you have any idea how can I get this data? | 2019-10-10T18:37:40 | 2019-10-10T18:37:40 | {} | NONE |
vuejs | core | 540,728,895 | 193 | vue-bot | Hey @laquasicinque, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-10T18:59:52 | 2019-10-10T18:59:52 | {} | CONTRIBUTOR |
vuejs | core | 541,084,100 | 189 | vue-bot | Hey @pikax, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-11T14:18:57 | 2019-10-11T14:18:57 | {} | CONTRIBUTOR |
vuejs | core | 539,478,933 | 153 | znck | What @Justineo said. | 2019-10-08T11:57:03 | 2019-10-08T11:57:03 | {} | MEMBER |
vuejs | core | 539,651,124 | 89 | yyx990803 | Looks good! I'll look into the incorrect render output. | 2019-10-08T18:50:05 | 2019-10-08T18:50:05 | {} | MEMBER |
vuejs | core | 539,669,225 | 132 | yyx990803 | Really appreciate the PR but by directiveTransform I actually meant something like this: https://github.com/vuejs/vue-next/commit/eadcaead37116a9506302f9a55917c32552eded9#diff-939380a39655d7195a8a1c71675c6f8a
I noticed that previously directiveTransforms do not have access to the elementNode so I had to update its s... | 2019-10-08T19:37:49 | 2019-10-08T19:37:49 | {} | MEMBER |
vuejs | core | 540,029,179 | 116 | vue-bot | Hey @TimvdEijnden, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-09T14:33:45 | 2019-10-09T14:33:45 | {} | CONTRIBUTOR |
vuejs | core | 540,143,394 | 125 | yyx990803 | @sh7dm code in `@vue/shared` are inlined into final builds and thus the symbol is not guaranteed to be unique anymore. | 2019-10-09T19:03:00 | 2019-10-09T19:03:00 | {
"+1": 2
} | MEMBER |
vuejs | core | 540,502,290 | 183 | posva | Throwing makes sense as the operation will not work and therefore the following code is also unlikely to work as it could rely on it working. Not throwing would also completely hide the problem in production | 2019-10-10T10:16:50 | 2019-10-10T10:16:50 | {} | MEMBER |
vuejs | core | 540,876,338 | 139 | CodeDaraW | Okay, thank Evan for guidance! | 2019-10-11T02:44:06 | 2019-10-11T02:44:06 | {} | CONTRIBUTOR |
vuejs | core | 541,078,521 | 198 | vue-bot | Hey @hreochen, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-11T14:04:56 | 2019-10-11T14:04:56 | {} | CONTRIBUTOR |
vuejs | core | 539,551,959 | 160 | vue-bot | Hey @Himself65, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-08T14:53:26 | 2019-10-08T14:53:26 | {} | CONTRIBUTOR |
vuejs | core | 540,068,283 | 168 | vue-bot | Hey @TerenceZ, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-09T16:00:58 | 2019-10-09T16:00:58 | {} | CONTRIBUTOR |
vuejs | core | 540,728,477 | 139 | vue-bot | Hey @CodeDaraW, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-10T18:59:08 | 2019-10-10T18:59:08 | {} | CONTRIBUTOR |
vuejs | core | 541,064,069 | 209 | pikax | Similar to: https://github.com/vuejs/vue-next/pull/107/ | 2019-10-11T13:26:57 | 2019-10-11T13:26:57 | {} | MEMBER |
vuejs | core | 541,857,191 | 278 | vue-bot | Hey @fisker, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-14T18:55:53 | 2019-10-14T18:55:53 | {} | CONTRIBUTOR |
vuejs | core | 541,924,792 | 255 | vue-bot | Hey @CyberAP, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-14T21:12:36 | 2019-10-14T21:12:36 | {} | CONTRIBUTOR |
vuejs | core | 542,018,421 | 284 | vue-bot | Hey @fisker, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-15T03:20:11 | 2019-10-15T03:20:11 | {} | CONTRIBUTOR |
vuejs | core | 542,189,485 | 294 | fnlctrl | The O(n) complexity of `indexOf`, and total (worst case) complexity O(n^2) of calling `indexOf` inside `filter` is hidden by a small input of 6*3.
Try with 100*3 and you'll see the power of O(n^2): https://jsperf.com/dedupe-large-input
![image](https://user-images.githubusercontent.com/5557143/66831918-5b22a300-e... | 2019-10-15T12:35:58 | 2019-10-15T12:35:58 | {
"+1": 1
} | MEMBER |
vuejs | core | 542,284,105 | 287 | yyx990803 | Cannot reproduce. | 2019-10-15T15:57:54 | 2019-10-15T15:57:54 | {} | MEMBER |
vuejs | core | 542,287,739 | 291 | yyx990803 | Duplicate of #282 | 2019-10-15T16:05:51 | 2019-10-15T16:05:51 | {} | MEMBER |
vuejs | core | 542,560,173 | 311 | HowGraceU | I find it, thanks | 2019-10-16T07:19:41 | 2019-10-16T07:19:41 | {} | NONE |
vuejs | core | 542,745,967 | 319 | pikax | I'm concern on how our benchmarks are yielding different results 🤔 | 2019-10-16T15:03:14 | 2019-10-16T15:03:14 | {} | MEMBER |
vuejs | core | 542,943,783 | 315 | dlxqlig | Fix it on compiler-core test. | 2019-10-17T00:22:31 | 2019-10-17T00:22:31 | {} | CONTRIBUTOR |
vuejs | core | 543,649,471 | 330 | jacekkarczmarczyk | @laquasicinque why not just `'[object Object]': true` etc? | 2019-10-18T10:07:10 | 2019-10-18T10:07:10 | {} | CONTRIBUTOR |
vuejs | core | 541,924,741 | 238 | yyx990803 | Seems to force-pushed the wrong change to keep. The signature change is landed in 004223a. | 2019-10-14T21:12:31 | 2019-10-14T21:12:31 | {} | MEMBER |
vuejs | core | 542,384,228 | 281 | adamlewkowicz | Let me know if the spec suits you. | 2019-10-15T20:11:54 | 2019-10-15T20:11:54 | {} | CONTRIBUTOR |
vuejs | core | 542,720,589 | 317 | yyx990803 | This is intentional. No need to spawn yarn process just to spawn another node process. | 2019-10-16T14:10:48 | 2019-10-16T14:10:48 | {} | MEMBER |
vuejs | core | 542,723,952 | 319 | CyberAP | > using Array.fill seems a bit faster than looping.
It's faster because Array length is settled. | 2019-10-16T14:17:47 | 2019-10-16T14:17:47 | {} | CONTRIBUTOR |
vuejs | core | 543,333,539 | 327 | yyx990803 | That RFC is outdated - we removed that signature in the latest spec: https://vue-composition-api-rfc.netlify.com/api.html#computed | 2019-10-17T19:48:26 | 2019-10-17T19:48:26 | {} | MEMBER |
vuejs | core | 541,859,128 | 280 | yyx990803 | I don't really think this is necessary... let's not spend too much time on yak shaving. | 2019-10-14T18:59:36 | 2019-10-14T18:59:36 | {} | MEMBER |
vuejs | core | 542,297,784 | 296 | vue-bot | Hey @MichealXie, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-15T16:29:17 | 2019-10-15T16:29:17 | {} | CONTRIBUTOR |
vuejs | core | 542,537,323 | 311 | yyx990803 | Raw effect will be called many times synchronously by default unless you provide a scheduler. Public APIs like watchers & component re-renders are buffered with a scheduler just like Vue 2. | 2019-10-16T06:15:06 | 2019-10-16T06:15:18 | {} | MEMBER |
vuejs | core | 543,472,103 | 324 | underfin | I get this.I think the filter is important for develop experience compare with the size of the runtime code.
It is better to jsx user If remove filter,but it is not good to template user.Like fllowing code,the filter function is need to import view component and then use it,It is normal for method of use, it is sim... | 2019-10-18T03:19:47 | 2019-10-18T03:19:47 | {
"+1": 3,
"heart": 3,
"rocket": 1
} | MEMBER |
vuejs | core | 541,856,362 | 275 | CyberAP | Made the test comparing four methods for that check and yes, objects are faster.
https://jsperf.com/in-operator-vs-indexof-vs-set-has/1 | 2019-10-14T18:54:14 | 2019-10-14T18:54:14 | {} | CONTRIBUTOR |
vuejs | core | 541,867,388 | 203 | vue-bot | Hey @TerenceZ, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-14T19:16:06 | 2019-10-14T19:16:06 | {} | CONTRIBUTOR |
vuejs | core | 541,879,890 | 217 | vue-bot | Hey @CodeDaraW, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-14T19:41:31 | 2019-10-14T19:41:31 | {} | CONTRIBUTOR |
vuejs | core | 542,018,506 | 283 | vue-bot | Hey @fisker, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-15T03:20:38 | 2019-10-15T03:20:38 | {} | CONTRIBUTOR |
vuejs | core | 542,530,516 | 289 | vue-bot | Hey @underfin, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-16T05:52:59 | 2019-10-16T05:52:59 | {} | CONTRIBUTOR |
vuejs | core | 542,742,397 | 319 | CyberAP | > This is even faster (and won't require a polyfill when we do IE11 support):
>
> ```js
> const newIndextoOldIndexMap = new Array(toBePatched)
> for (i = 0; i < toBePatched; i++) newIndexToOldIndexMap[i] = 0
> ```
Kinda equal https://jsperf.com/array-fill-vs-loop | 2019-10-16T14:55:59 | 2019-10-16T14:55:59 | {} | CONTRIBUTOR |
vuejs | core | 543,816,970 | 330 | vue-bot | Hey @edison1105, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-18T16:17:00 | 2019-10-18T16:17:00 | {} | CONTRIBUTOR |
vuejs | core | 542,013,395 | 285 | haoqunjiang | It's not redundant. In semicolon-less style, you should never start a line with `(`, `[`, or `` ` ``. That's why it's prefixed with a `;`. For further reading on this topic, see https://standardjs.com/rules-en.html#semicolons | 2019-10-15T02:54:37 | 2019-10-15T02:54:37 | {} | MEMBER |
vuejs | core | 542,190,644 | 294 | pikax | That's true. 👍
I'm wondering how many objects are we gonna usually use this array for 🤔
probably change strategy if the array is > 100 items? | 2019-10-15T12:39:07 | 2019-10-15T12:39:07 | {} | MEMBER |
vuejs | core | 542,401,370 | 290 | yyx990803 | I'd say the current 2.x behavior is a bug. | 2019-10-15T20:57:10 | 2019-10-15T20:57:10 | {} | MEMBER |
vuejs | core | 542,481,583 | 307 | vue-bot | Hey @ZhangJian-3ti, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-16T02:23:57 | 2019-10-16T02:23:57 | {} | CONTRIBUTOR |
vuejs | core | 542,332,259 | 301 | ZhangJian-3ti | IMO, in this case ,this style reduced the readability. | 2019-10-15T17:56:48 | 2019-10-16T05:28:15 | {
"-1": 1
} | CONTRIBUTOR |
vuejs | core | 541,940,837 | 277 | yyx990803 | Thanks for the PR, but most of these shared functions are either self-explanatory or will be tested as part of the features that use them. The exception is `looseEqual`, which I moved to `vModel.ts` because that's the only place where it is used. Please submit a separate PR to add the `looseEqual` tests to https://gith... | 2019-10-14T21:46:52 | 2019-10-14T21:46:52 | {} | MEMBER |
vuejs | core | 542,011,604 | 285 | Justineo | Code will be automatically formatted and there's no need to submit code style PRs. Thanks. | 2019-10-15T02:46:03 | 2019-10-15T02:46:03 | {} | MEMBER |
vuejs | core | 542,089,592 | 290 | HcySunYang | In the 2.x version, the template below:
```html
<div>{{}}</div>
```
The delimiters will be considered plain text.
If the template is as follows:
```html
<div>{{ }}</div>
```
Will generate empty text(''), but neither case throws an error or warn. | 2019-10-15T08:00:03 | 2019-10-15T08:00:03 | {} | MEMBER |
vuejs | core | 542,415,121 | 299 | vue-bot | Hey @CodeDaraW, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-15T21:35:49 | 2019-10-15T21:35:49 | {} | CONTRIBUTOR |
vuejs | core | 542,637,496 | 316 | haoqunjiang | Please DO NOT abuse pull requests. It's not for bug reports.
And, make sure to have a look at https://github.com/vuejs/vue-next/blob/master/.github/contributing.md first. | 2019-10-16T10:31:34 | 2019-10-16T10:31:34 | {} | MEMBER |
vuejs | core | 542,278,771 | 276 | vue-bot | Hey @HcySunYang, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-15T15:46:26 | 2019-10-15T15:46:26 | {} | CONTRIBUTOR |
vuejs | core | 543,813,840 | 320 | yyx990803 | Great job 👍 | 2019-10-18T16:09:25 | 2019-10-18T16:09:25 | {} | MEMBER |
vuejs | core | 542,176,312 | 292 | fnlctrl | I originally wrote these types but then found them to be misleading - It's not going to be just "KeyboardEvent" and there're many other possibilities.
For example you can do `<div @click.ctrl="foo"/>` . So to properly type it we'll need to use something like:
```
type Events = KeyboardEvent | MouseEvent | TouchEve... | 2019-10-15T11:58:25 | 2019-10-15T11:58:25 | {} | MEMBER |
vuejs | core | 542,281,253 | 276 | yyx990803 | Great work! | 2019-10-15T15:52:02 | 2019-10-15T15:52:02 | {} | MEMBER |
vuejs | core | 543,702,033 | 330 | laquasicinque | @jacekkarczmarczyk Only really because its fewer characters and the result is more or less the same. I'm casting to Boolean anyway which would get `true` | `false` or else the response would be `true` | `undefined` even with me using `true` instead of 1. If you want short and `true` then `!0` also works.
My example... | 2019-10-18T12:01:18 | 2019-10-18T12:01:18 | {} | CONTRIBUTOR |
vuejs | core | 543,777,523 | 331 | himself65 | @jo0ger thanks, I fixed | 2019-10-18T14:39:37 | 2019-10-18T14:39:37 | {} | CONTRIBUTOR |
vuejs | core | 541,922,308 | 255 | yyx990803 | Great work! | 2019-10-14T21:07:40 | 2019-10-14T21:07:40 | {
"+1": 1
} | MEMBER |
vuejs | core | 542,182,386 | 292 | fnlctrl | > replacing as any to the expected event, in my opinion makes more sense.
But we're indeed expecting `KeyboardEvent | MouseEvent ` - both are valid usage.
```
<div @click.ctrl="foo"/> Ctrl click
<div @keydown.a.ctrl="foo"/> Ctrl+A
```
`TouchEvent` also has `ctrlKey`, so it's technically valid (though people... | 2019-10-15T12:15:55 | 2019-10-15T12:16:03 | {} | MEMBER |
vuejs | core | 542,733,117 | 309 | vue-bot | Hey @xiaoboost, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-16T14:36:42 | 2019-10-16T14:36:42 | {} | CONTRIBUTOR |
vuejs | core | 542,738,257 | 319 | pikax | on chrome seems not to be as fast 🤔
https://jsperf.com/array-generate-and-populate
EDIT:
chrome:
safary:
![image](https://user-images.githubusercontent.com/4620458/66930676-dd16d880-f02c-11e... | 2019-10-16T14:47:29 | 2019-10-16T14:51:55 | {} | MEMBER |
vuejs | core | 542,761,465 | 319 | yyx990803 | @pikax your tests are using a global `i`, which incurs a global variable check on every `i` access.
There's no other places that need this so no need for extraction. | 2019-10-16T15:35:36 | 2019-10-16T15:35:51 | {
"+1": 1
} | MEMBER |
vuejs | core | 543,334,981 | 325 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-17T19:52:28 | 2019-10-17T19:52:28 | {} | CONTRIBUTOR |
vuejs | core | 543,648,356 | 330 | edison1105 | > Surely Object would provide the biggest performance increase? https://jsperf.com/regandset/3
>
> Edit: different perf test so that it always returns a boolean
@laquasicinque thanks for your suggestion. | 2019-10-18T10:04:57 | 2019-10-18T11:47:34 | {} | MEMBER |
vuejs | core | 541,877,654 | 254 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-14T19:36:45 | 2019-10-14T19:36:45 | {} | CONTRIBUTOR |
vuejs | core | 541,934,160 | 89 | thecrypticace | cc @yyx990803
Is there anything else you need me to change here or are you waiting on other things first? | 2019-10-14T21:32:07 | 2019-10-14T21:32:07 | {} | CONTRIBUTOR |
vuejs | core | 542,119,913 | 290 | jacekkarczmarczyk | I see. Do i understand correctly it's a breaking change (`{{}}` => `''` instead of `{{}}` => `'{{}}'`)? | 2019-10-15T09:18:03 | 2019-10-15T09:18:03 | {} | CONTRIBUTOR |
vuejs | core | 542,178,233 | 292 | pikax | The typings here are for the someone reading it to know this is suppose to be that type of event,
> type Events = KeyboardEvent | MouseEvent | TouchEvent
> { ctrl: e => !(e as Events).ctrlKey }
doing this will also cause a bit annoyance because you will need to cast at every prop. replacing `as any` to the ex... | 2019-10-15T12:04:08 | 2019-10-15T12:04:08 | {} | MEMBER |
vuejs | core | 542,287,238 | 288 | vue-bot | Hey @edison1105, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-15T16:04:42 | 2019-10-15T16:04:42 | {} | CONTRIBUTOR |
vuejs | core | 542,413,460 | 299 | yyx990803 | 👍 | 2019-10-15T21:30:53 | 2019-10-15T21:30:53 | {} | MEMBER |
vuejs | core | 542,497,388 | 301 | RobertWHurst | @ZhangJian-3ti Returning early is pretty common and makes code more readable. It's not at all like goto statements. | 2019-10-16T03:38:41 | 2019-10-16T03:38:41 | {} | NONE |
vuejs | core | 542,538,092 | 252 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-16T06:17:27 | 2019-10-16T06:17:27 | {} | CONTRIBUTOR |
vuejs | core | 541,768,201 | 280 | fisker | I forgot that
1. parser in `.prettierc` is not required until `v1.16.0`
2. `--check` also not supported in `v1.14.0`
Should we update the prettier version (may format ts differently https://github.com/fisker/vue-next/commit/2d0999c12fb1028f173b81d782ef0f06f408b72a) or restore `.prettierrc` & remove `--check` | 2019-10-14T16:05:28 | 2019-10-14T17:10:37 | {} | CONTRIBUTOR |
vuejs | core | 541,857,592 | 279 | vue-bot | Hey @fisker, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-14T18:56:41 | 2019-10-14T18:56:41 | {} | CONTRIBUTOR |
vuejs | core | 542,084,274 | 290 | jacekkarczmarczyk | Shouldn't it throw or at least warn? Not sure how it works in 2.x tho | 2019-10-15T07:45:29 | 2019-10-15T07:45:29 | {} | CONTRIBUTOR |
vuejs | core | 542,297,509 | 295 | vue-bot | Hey @a631807682, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-15T16:28:39 | 2019-10-15T16:28:39 | {} | CONTRIBUTOR |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.