owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 428,782,868 | 2 | chrisvfritz | @Justineo
> suggest authors to always spread the $attrs object in the warning message
That would be my preference, as I'm still not convinced there's a valid use case for whitelisting. I feel like there can always be exceptions where an attribute beyond `data-*`/`aria-*`/`role` is necessary due to a strange requ... | 2018-10-11T01:05:45 | 2018-10-11T01:05:58 | {} | CONTRIBUTOR |
vuejs | core | 433,927,338 | 12 | chrisvfritz | ### Hook call order
@yyx990803 I agree with pretty much everything you said on Twitter. Another education concern I have with hooks is that they _must_ be called in the same order every time the render function is run, which isn't intuitive unless you understand their magic. To me, this makes them almost unusable ou... | 2018-10-29T14:19:15 | 2018-10-29T14:19:15 | {} | CONTRIBUTOR |
vuejs | core | 434,126,159 | 12 | chrisvfritz | I'd also like to propose that we always call these "render hooks" to avoid confusion with lifecycle hooks, then start using some other term for lifecycle hooks starting Vue 3 (e.g. "lifecycle functions"). If a Vue user ever has to say the words "lifecycle hook hook" or even "lifecycle hook render hook", I'll cry a litt... | 2018-10-30T00:11:13 | 2018-10-30T00:11:13 | {
"+1": 2,
"laugh": 1
} | CONTRIBUTOR |
vuejs | core | 441,552,397 | 17 | Jinjiang | @chrisvfritz I think most cases a component need a render function. Sometimes developers may get mistakes to miss a _valid_ `<template>` or `render()` function. That would cause nothing rendered which may make the developers lost I think. So if there is no render function written or generated, we can catch the mistake ... | 2018-11-26T08:14:55 | 2018-11-26T08:14:55 | {
"+1": 4
} | MEMBER |
vuejs | core | 443,070,834 | 9 | chrisvfritz | > Why not use value directly but choose modelValue by default?
@Jinjiang I don't think I understand the question. Could you elaborate? | 2018-11-30T02:40:37 | 2018-11-30T02:40:51 | {} | CONTRIBUTOR |
vuejs | core | 428,418,924 | 4 | HerringtonDarkholme | > > open question: should we rename them to onXxx to differentiate from methods?
>
> IMO, we should not change the lifecycle method names in v3, because of we should be avoided migration fatigue to v3 from v2 as possible.
From the perspective of vue-class-component, builtin lifecycle names haven't caused many pro... | 2018-10-10T02:42:56 | 2018-10-10T02:42:56 | {} | MEMBER |
vuejs | core | 428,901,845 | 4 | phanan | > It also promotes a good practice that constructor should have only data initialization in it.
While I personally like the idea, I'm not sure about this practice. Constructors can, and often, do more than just initializing the data. Also, not every piece of data initialized in the constructor needs to be reactive, ... | 2018-10-11T10:18:28 | 2018-10-11T10:40:12 | {} | MEMBER |
vuejs | core | 428,924,655 | 4 | Jinjiang | And as a step forward, we can simplify the lifecycle design by deprecating `beforeCreated` right? Because it’s more like a constructor in v2 I think. 🤔
EDIT:
> EDIT: While we're at it, constructors are more like `created()` hooks to me.
@phanan sorry for missing your comment. It seems we think the same. 😅 | 2018-10-11T11:44:55 | 2018-10-11T11:49:47 | {} | MEMBER |
vuejs | core | 429,009,776 | 2 | yyx990803 | As this thread has become super long and hard to navigate, let's open separate issues to discuss specific topics. | 2018-10-11T15:52:56 | 2018-10-11T15:52:56 | {
"+1": 1
} | MEMBER |
vuejs | core | 429,411,632 | 8 | posva | Should we consider renaming the `input` event to `update:value` when no argument is provided? It would be another breaking change | 2018-10-12T18:06:36 | 2018-10-12T18:06:36 | {} | MEMBER |
vuejs | core | 431,796,233 | 5 | blake-newman | No that is fine, the problem is when you have functional components and no defined props. This is common when using this definition: https://github.com/nickmessing/babel-plugin-jsx-vue-functional
Attributes will all flood to the dom, and with more complex functional component this is an issue.
```
export const ... | 2018-10-22T10:24:37 | 2018-10-22T10:24:37 | {} | MEMBER |
vuejs | core | 434,180,071 | 12 | yyx990803 | Updated `vue-hooks` to support Vue-style hooks + `hooks()` in 2.x: https://github.com/yyx990803/vue-hooks#usage-in-normal-vue-components | 2018-10-30T05:49:33 | 2018-10-30T05:49:33 | {
"hooray": 3
} | MEMBER |
vuejs | core | 434,867,303 | 13 | yyx990803 | Absolutely, I wanted to expose a Vue-2 similar API eventually. This was just an experiment to see how it would look like as components. | 2018-10-31T22:18:31 | 2018-10-31T22:18:31 | {
"+1": 4
} | MEMBER |
vuejs | core | 435,557,607 | 8 | chrisvfritz | Good point. Though the use case is relatively rare, I agree we should handle it. Maybe a modifier like `v-model.spread="object"` could address that use case. Thoughts? | 2018-11-03T03:47:55 | 2018-11-03T03:47:55 | {} | CONTRIBUTOR |
vuejs | core | 440,385,546 | 17 | yyx990803 | Isn't renderless components ones that returns content from scoped slots? They still do need the render function to do their jobs.
I can't think of a case where a component without render/template would make sense. | 2018-11-20T18:40:42 | 2018-11-20T18:41:01 | {} | MEMBER |
vuejs | core | 428,417,184 | 2 | Justineo | > This we can actually detect and throw a warning for (if $attrs is not empty, but never accessed during render).
What if this is intentional and all allowed attributes are declared in props instead? | 2018-10-10T02:32:03 | 2018-10-10T02:32:03 | {} | MEMBER |
vuejs | core | 429,939,428 | 9 | chrisvfritz | @yyx990803 Brilliant! I love it. 😻 A few follow-up questions:
- Should `v-model="foo"` actually translate to an `onModelUpdate:value` event (instead of `onModelUpdate:foo`)?
- For consistency, should `v-model:my-prop="foo"` translate to `modelMyProp` and `onModelUpdate:myProp`, which could also be transformed at... | 2018-10-15T17:19:46 | 2018-10-15T18:07:59 | {} | CONTRIBUTOR |
vuejs | core | 428,648,952 | 2 | Justineo | > wouldn't hand-picking attributes always be an anti-pattern?
Yes. I'm just saying it's valid in the current mechanism, despite being an anti-pattern. On a second thought it may be good enough to suggest them spread `$attrs` instead.
Another issue might be whether we suggest authors to always spread the `$attrs` ... | 2018-10-10T16:55:00 | 2018-10-10T16:55:00 | {} | MEMBER |
vuejs | core | 428,897,920 | 4 | HerringtonDarkholme | I really love @Jinjiang 's proposal and actually I have also considered it.
Pros are evident: it removes `data` method from API so it does simplify API concept. It also removes one generic type `Data` from TS's definition. It also promotes a good practice that constructor should have only data initialization in it... | 2018-10-11T10:05:10 | 2018-10-11T10:05:10 | {} | MEMBER |
vuejs | core | 429,124,856 | 7 | yyx990803 | I'm not sure if fake rendering is really a good idea. Mocking sounds super fragile and I doubt it can be really that lightweight if we want to make sure things don't just break.
Maybe we can tackle this from a different perspective - is it possible to statically analyze and extract queries at build time (kinda like ... | 2018-10-11T21:27:36 | 2018-10-11T21:27:36 | {} | MEMBER |
vuejs | core | 432,289,861 | 5 | yyx990803 | @blake-newman the problem with implicit class and style merging is that it does not always work - e.g. when the component returns a fragment. A simple refactoring can accidentally cause things to break. | 2018-10-23T15:15:39 | 2018-10-23T15:15:39 | {} | MEMBER |
vuejs | core | 435,629,689 | 12 | phanan | > To me, the word "injection" makes more sense for this feature than "hook".
@anthonygore @chrisvfritz Actually, "injection," or "inject," has already been used for a very different feature :)
> `useData` seems only accept an object or array which is a little constraint for that I think.
@Jinjiang I'm a bit l... | 2018-11-03T23:44:31 | 2018-11-03T23:44:31 | {} | MEMBER |
vuejs | core | 442,512,823 | 4 | yyx990803 | @Jinjiang it can still be useful when you somehow have to use `data()` or need to access the properties on `this.$data.xxx`, rare cases, but may still be needed. | 2018-11-28T16:33:20 | 2018-11-28T16:33:20 | {} | MEMBER |
vuejs | core | 428,626,377 | 2 | chrisvfritz | @Justineo Also, I _think_ null and children renders are the only cases where intentionally not spreading `$attrs` would be valid, but maybe I've missed a use case. Can you think of a situation where a component has its own markup, but the author might not want to spread `$attrs`? | 2018-10-10T15:50:40 | 2018-10-10T15:50:40 | {} | CONTRIBUTOR |
vuejs | core | 428,630,461 | 2 | chrisvfritz | @yyx990803 And actually, is there potentially a way we could detect if a component has generated its own markup, rather than rendering `null` or just its children? That way, we could have more precise warnings. If a component _does_ generate its own markup, then:
**Component \<Foo\> was passed attribute "bar", but "... | 2018-10-10T16:01:42 | 2018-10-10T16:02:20 | {} | CONTRIBUTOR |
vuejs | core | 429,059,365 | 4 | chrisvfritz | ### Class education/transition
> Does that make sense?
@yyx990803 That makes perfect sense, clarifies quite a few things for me, and generally resolves my education/transition concerns. 🙂 And if we don't end up making classes the recommended default for JS users, _all_ my concerns actually disappear. I'll keep t... | 2018-10-11T18:03:26 | 2018-10-11T18:04:44 | {} | CONTRIBUTOR |
vuejs | core | 429,007,120 | 4 | yyx990803 | @Jinjiang @HerringtonDarkholme @phanan I've also considered this. Some reasons I am hesitant about it:
- It requires us to do an `Object.getOwnPropertyDescriptors` on every instance initialization to dynamically construct the reactive data object. This has some performance cost that I will need to measure.
- You ... | 2018-10-11T15:46:43 | 2018-10-11T18:31:03 | {} | MEMBER |
vuejs | core | 429,070,645 | 4 | yyx990803 | @chrisvfritz
> do we actually need a special API for non-reactive properties? When you don't want a property to be reactive, couldn't you just avoid initializing it in data and do so in created/mounted instead?
You don't really need them (especially in plain ES), but:
- The decorator allows TS users to place ... | 2018-10-11T18:33:59 | 2018-10-11T18:35:10 | {
"+1": 1
} | MEMBER |
vuejs | core | 431,319,102 | 5 | blake-newman | I have some queries for this:
1) The `$attrs` does include class / style for merging? If not this may void my further questions.
2)
> `$attrs` will just point to `$props` which includes everything passed to the component.
Here is an example component in React:
```
import * as classNames from 'classnames... | 2018-10-19T10:29:28 | 2018-10-19T10:29:28 | {} | MEMBER |
vuejs | core | 431,855,754 | 4 | yyx990803 | Update: don't know since when but latest Chrome Canary now enables class fields by default, so we can already play with the following API without a transpiler:
``` js
class Foo extends Component {
static props = {
msg: String
}
count = 0
render() {
return h('div', [this.msg, this.count])
... | 2018-10-22T14:42:31 | 2018-10-22T14:42:31 | {
"hooray": 3
} | MEMBER |
vuejs | core | 435,344,580 | 12 | anthonygore | > I'd also like to propose that we always call these "render hooks" to avoid confusion with lifecycle hooks, then start using some other term for lifecycle hooks starting Vue 3 (e.g. "lifecycle functions"). If a Vue user ever has to say the words "lifecycle hook hook" or even "lifecycle hook render hook", I'll cry a li... | 2018-11-02T11:05:04 | 2018-11-02T11:05:04 | {} | NONE |
vuejs | core | 443,067,439 | 17 | chrisvfritz | That works for me. 🙂 I don't have any further arguments, so I'll close. | 2018-11-30T02:22:43 | 2018-11-30T02:22:43 | {} | CONTRIBUTOR |
vuejs | core | 428,999,890 | 4 | yyx990803 | @chrisvfritz ok, I may have misunderstood your intention. From what you have explained, it seems your concern has less to do with the actual implementation, but more about how we present / document / transition the users to the new syntax. So let's clarify a few points:
- Given that static class fields will likely l... | 2018-10-11T15:28:56 | 2018-10-11T15:28:56 | {
"+1": 1
} | MEMBER |
vuejs | core | 429,574,896 | 8 | chrisvfritz | @posva I like that idea a lot! 🙂 It'd make component events more consistent and would actually solve a problem we currently have with transparent wrapper components. I just created [a new issue](https://github.com/vuejs/vue-next/issues/9) to explore this further. | 2018-10-13T21:00:20 | 2018-10-13T21:00:29 | {} | CONTRIBUTOR |
vuejs | core | 434,330,189 | 5 | blake-newman | Okay, this makes a lot more sense, sorry for the confusion. My understanding was based on a 2.x issue where their vNode data was not flat, which would mean all information even if extracted would be transferred as attributes if you did not empty `data.attrs` object as this information exists on both `props` and `attrs`... | 2018-10-30T14:46:36 | 2018-10-30T14:46:36 | {} | MEMBER |
vuejs | core | 442,398,789 | 9 | Jinjiang | Sorry. Why not use `value` directly but choose `modelValue` by default? Did I miss something? | 2018-11-28T10:31:44 | 2018-11-28T10:31:44 | {} | MEMBER |
vuejs | core | 429,175,543 | 5 | chrisvfritz | > `cloneVNode(h('div'), this.$attrs)`
@yyx990803 Quick question: why do we need `cloneVNode` here instead of just doing `h('div', this.$attrs)`?
| 2018-10-12T01:39:47 | 2018-10-12T01:39:47 | {} | CONTRIBUTOR |
vuejs | core | 435,023,005 | 13 | rstoenescu | Quasar relies on 2.x API for provide/inject in a lot of places too. I really like the `useInject` hook idea and I think that would fit great. | 2018-11-01T12:16:53 | 2018-11-01T12:16:53 | {} | NONE |
vuejs | core | 443,067,040 | 4 | chrisvfritz | > or need to access the properties on `this.$data.xxx`
Oh, so `this.$data` won't be available unless using a `data` function? | 2018-11-30T02:20:40 | 2018-11-30T02:20:40 | {} | CONTRIBUTOR |
vuejs | core | 546,760,260 | 390 | KaelWD | https://jsperf.com/clone-vnode
| 2019-10-28T01:41:52 | 2019-10-28T01:41:52 | {} | CONTRIBUTOR |
vuejs | core | 547,976,613 | 415 | dependabot-preview[bot] | OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`.
If you change your mind, just re-... | 2019-10-30T15:52:54 | 2019-10-30T15:52:54 | {} | CONTRIBUTOR |
vuejs | core | 551,928,554 | 436 | vue-bot | Hey @pikax, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-08T17:57:26 | 2019-11-08T17:57:26 | {} | CONTRIBUTOR |
vuejs | core | 552,060,429 | 422 | vue-bot | Hey @a631807682, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-09T03:11:54 | 2019-11-09T03:11:54 | {} | CONTRIBUTOR |
vuejs | core | 552,062,801 | 439 | vue-bot | Hey @Polaris-z, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-09T03:46:56 | 2019-11-09T03:46:56 | {} | CONTRIBUTOR |
vuejs | core | 553,966,416 | 447 | vue-bot | Hey @ztplz, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-14T16:28:06 | 2019-11-14T16:28:06 | {} | CONTRIBUTOR |
vuejs | core | 556,887,803 | 476 | yyx990803 | Please don't use others' repos for experiments. If you keep doing this you will be blocked from all vuejs repos. | 2019-11-21T03:01:44 | 2019-11-21T03:01:44 | {} | MEMBER |
vuejs | core | 557,435,533 | 479 | Justineo | Code is automatically formatted so there's no need to submit manual code style fixes. Thanks. | 2019-11-22T08:14:47 | 2019-11-22T08:14:47 | {} | MEMBER |
vuejs | core | 547,020,597 | 404 | vue-bot | Hey @cexbrayat, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-28T16:09:06 | 2019-10-28T16:09:06 | {} | CONTRIBUTOR |
vuejs | core | 547,320,636 | 408 | jacekkarczmarczyk | see https://github.com/vuejs/vue-next/pull/319 | 2019-10-29T08:59:32 | 2019-10-29T08:59:32 | {} | CONTRIBUTOR |
vuejs | core | 553,694,296 | 457 | zzzz-Z | @Justineo @yyx990803 对就是想说这个。 2.0的时候只有在.native的时候才会添加到根元素上 | 2019-11-14T02:24:37 | 2019-11-14T02:24:37 | {} | CONTRIBUTOR |
vuejs | core | 553,703,702 | 457 | haoqunjiang | > 而且测试用例和实际使用情况展现的完全两种情况 这也是不应该的啊
这是因为 runtime-test 没有实现冒泡。放到 runtime-dom 里的测试应该就一致了。 | 2019-11-14T03:08:39 | 2019-11-14T03:08:39 | {} | MEMBER |
vuejs | core | 555,518,789 | 464 | underfin | I see.
| 2019-11-19T13:57:20 | 2019-11-19T13:57:20 | {} | MEMBER |
vuejs | core | 555,522,923 | 468 | vue-bot | Hey @Zhang-Yida, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-19T14:07:50 | 2019-11-19T14:07:50 | {} | CONTRIBUTOR |
vuejs | core | 546,754,597 | 392 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-28T00:59:56 | 2019-10-28T00:59:56 | {} | CONTRIBUTOR |
vuejs | core | 549,513,491 | 416 | dsseng | okay, suspenses are pretty rare and update rarely too | 2019-11-04T19:37:36 | 2019-11-04T19:37:36 | {} | CONTRIBUTOR |
vuejs | core | 551,899,297 | 442 | mawi1512 | You're right, thanks for the explanation! | 2019-11-08T16:38:02 | 2019-11-08T16:38:02 | {} | NONE |
vuejs | core | 553,968,353 | 452 | vue-bot | Hey @cexbrayat, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-14T16:32:25 | 2019-11-14T16:32:25 | {} | CONTRIBUTOR |
vuejs | core | 554,676,727 | 462 | vue-bot | Hey @theniceangel, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-16T21:37:08 | 2019-11-16T21:37:08 | {} | CONTRIBUTOR |
vuejs | core | 546,815,466 | 400 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [Mixed content](https://app.netlify.com/sites/vue-next-coverage/deploys/5db6904930447e00084166e3)
- [Redirect rules](https://app.netlify.com/sites/vue-next-coverage/deploys/5db6904930447e00084166e3)
- [Header rules](https://app.netlify.co... | 2019-10-28T06:54:22 | 2019-10-28T06:54:22 | {} | CONTRIBUTOR |
vuejs | core | 547,951,286 | 411 | yyx990803 | We can't enforce anything here because `h` is platform agnostic, so unless the user explicitly creates a portal with `h<Node, HTMLElement>(...)` it won't do anything, but if the user has to do that then the type inference doesn't do much anyway. | 2019-10-30T15:03:48 | 2019-10-30T15:03:48 | {} | MEMBER |
vuejs | core | 547,976,973 | 413 | vue-bot | Hey @limichange, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-30T15:53:41 | 2019-10-30T15:53:41 | {} | CONTRIBUTOR |
vuejs | core | 549,511,645 | 416 | yyx990803 | This is not going to be perf-critical due to its low usage frequency, so I think it's to just keep the logic simple. | 2019-11-04T19:33:00 | 2019-11-04T19:33:00 | {} | MEMBER |
vuejs | core | 550,985,857 | 432 | vue-bot | Hey @ztplz, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-07T08:58:34 | 2019-11-07T08:58:34 | {} | CONTRIBUTOR |
vuejs | core | 552,661,848 | 449 | yyx990803 | Good catch! As @posva noted, we also need to handle e.g. `:true-value="someObject"` so we need to force set `true-value` and `false-value` as DOM properties on `<input>` elements - which means we will need a special case for that [here](https://github.com/vuejs/vue-next/blob/master/packages/runtime-dom/src/patchProp.ts... | 2019-11-11T23:19:53 | 2019-11-11T23:20:18 | {} | MEMBER |
vuejs | core | 556,855,810 | 475 | AmberAAA | 111 | 2019-11-21T02:26:55 | 2019-11-21T02:26:55 | {} | NONE |
vuejs | core | 547,018,116 | 403 | yyx990803 | good catch. | 2019-10-28T16:03:44 | 2019-10-28T16:03:44 | {} | MEMBER |
vuejs | core | 547,422,912 | 408 | yyx990803 | `fill` is slower. | 2019-10-29T13:36:56 | 2019-10-29T13:36:56 | {} | MEMBER |
vuejs | core | 551,121,325 | 435 | underfin | I want to add some test for compiler-sfc package.But meet some problem.
```
Pattern: ./packages/compiler-sfc/_tests_/parse.spec.ts - 0 matches
```
It is caused by not scan the test files.
So, I want to get some help. | 2019-11-07T15:13:03 | 2019-11-07T15:13:38 | {} | MEMBER |
vuejs | core | 552,062,646 | 435 | vue-bot | Hey @underfin, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-09T03:44:24 | 2019-11-09T03:44:24 | {} | CONTRIBUTOR |
vuejs | core | 553,690,709 | 457 | yyx990803 | DOM 里面事件是会冒泡的... 你点击子元素当然会出发父元素的 click 事件了 | 2019-11-14T02:08:29 | 2019-11-14T02:08:29 | {} | MEMBER |
vuejs | core | 553,984,398 | 456 | yyx990803 | Good catch. I just realized we are missing tests for the scheduler due to a big refactor. Would you be interested in adding some? (can be based on these [old tests](https://github.com/vuejs/vue-next/blob/sync/packages/scheduler/__tests__/scheduler.spec.ts)) | 2019-11-14T17:07:52 | 2019-11-14T17:07:52 | {} | MEMBER |
vuejs | core | 547,131,008 | 394 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-28T20:27:05 | 2019-10-28T20:27:05 | {} | CONTRIBUTOR |
vuejs | core | 547,422,720 | 407 | yyx990803 | This isn't technically needed. You can just call `effect` on a stopped effect to get a new effect. | 2019-10-29T13:36:30 | 2019-10-29T13:36:30 | {} | MEMBER |
vuejs | core | 548,178,271 | 418 | limichange | emmmmm, ok, I get it. | 2019-10-31T01:24:36 | 2019-10-31T01:24:36 | {} | CONTRIBUTOR |
vuejs | core | 549,516,996 | 423 | yyx990803 | The typing is correct, since the type of `reactive({ ... })` already contains unwrapping. | 2019-11-04T19:46:24 | 2019-11-04T19:46:24 | {} | MEMBER |
vuejs | core | 552,108,308 | 444 | yyx990803 | Props are already readonly: a5f962a | 2019-11-09T15:04:51 | 2019-11-09T15:04:51 | {} | MEMBER |
vuejs | core | 552,904,393 | 435 | underfin | Thanks a lot! | 2019-11-12T13:58:24 | 2019-11-12T13:58:24 | {} | MEMBER |
vuejs | core | 553,123,709 | 449 | vue-bot | Hey @cexbrayat, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-12T21:29:41 | 2019-11-12T21:29:41 | {} | CONTRIBUTOR |
vuejs | core | 553,940,425 | 457 | yyx990803 | 简单来说，以后默认所有没有被声明为 props 的属性（包括 class, style, 事件和普通的 attribute）都会被子组件的根元素继承。如果想要订制这个行为，就用 `inhertiAttrs: false` 然后自己在子元素里绑定 `$attrs`。 | 2019-11-14T15:32:57 | 2019-11-14T15:33:10 | {} | MEMBER |
vuejs | core | 553,986,028 | 456 | vue-bot | Hey @theniceangel, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-14T17:11:25 | 2019-11-14T17:11:25 | {} | CONTRIBUTOR |
vuejs | core | 555,442,398 | 324 | iNerV | RFC here vuejs/rfcs#97 | 2019-11-19T10:31:53 | 2019-11-19T10:31:53 | {} | CONTRIBUTOR |
vuejs | core | 556,954,716 | 478 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [ci/circleci: build](https://circleci.com/gh/vuejs/vue-next/1330?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
Dependabot will still automatically merge this pull request if you amend it and your tes... | 2019-11-21T07:21:32 | 2019-11-21T07:21:32 | {} | CONTRIBUTOR |
vuejs | core | 549,882,324 | 426 | yyx990803 | Thanks, yes we should warn duplicate plugins like in v2. Fixed in c61e546 | 2019-11-05T15:50:11 | 2019-11-05T15:50:11 | {} | MEMBER |
vuejs | core | 553,697,261 | 457 | fnlctrl | 新的attr fallthrough rfc里移除了.native https://github.com/vuejs/rfcs/pull/92 | 2019-11-14T02:38:05 | 2019-11-14T02:38:05 | {} | MEMBER |
vuejs | core | 546,854,712 | 389 | dsseng | @ZhangJian-3ti afaik error handling and reporting should work in prod too. i don't know for sure, let's wait @yyx990803 opinion about this. | 2019-10-28T09:06:15 | 2019-10-28T09:06:15 | {} | CONTRIBUTOR |
vuejs | core | 547,122,676 | 406 | yyx990803 | Slots are called as part of render functions. No need for special treatment. | 2019-10-28T20:06:10 | 2019-10-28T20:06:10 | {} | MEMBER |
vuejs | core | 547,971,341 | 412 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-30T15:42:08 | 2019-10-30T15:42:08 | {} | CONTRIBUTOR |
vuejs | core | 548,068,895 | 418 | yyx990803 | Thanks for the PR - however... I don't know if this is actually "simplifying" the structure. This app is already pretty simple as it is, and its scope is not going to grow. Unfortunately this feels a bit over-engineering to me. | 2019-10-30T19:10:18 | 2019-10-30T19:10:18 | {} | MEMBER |
vuejs | core | 549,884,666 | 430 | vue-bot | Hey @Junyan, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-05T15:55:51 | 2019-11-05T15:55:51 | {} | CONTRIBUTOR |
vuejs | core | 551,381,826 | 437 | vue-bot | Hey @ztplz, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-08T04:40:25 | 2019-11-08T04:40:25 | {} | CONTRIBUTOR |
vuejs | core | 547,970,962 | 417 | vue-bot | Hey @theniceangel, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-30T15:41:21 | 2019-10-30T15:41:21 | {} | CONTRIBUTOR |
vuejs | core | 554,461,903 | 458 | loiacon | > Thanks for the PR - however, my original comment actually was more about the fact that we are doing multiple `indexOf` calls to find the end for current text. I think the `Math.min` refactor, while beneficial, is likely not the bottleneck.
I've tried some ways to remove the multiple `indexOf` from the parser, and ... | 2019-11-15T17:52:28 | 2019-11-15T17:52:28 | {} | CONTRIBUTOR |
vuejs | core | 555,268,463 | 468 | Zhang-Yida | Okey, I will submit the new pull request which contains these three new plugins. | 2019-11-19T00:06:03 | 2019-11-19T00:06:03 | {} | CONTRIBUTOR |
vuejs | core | 547,960,683 | 407 | yyx990803 | Technically, you cannot "restart" an effect - you can only create a new effect with the same options (this is exactly what your implementation does). The original effect is still inactive. Some options like `lazy` and `onStop` would be ambiguous when performing a restart. I think conceptually, it's better to explicitly... | 2019-10-30T15:21:22 | 2019-10-30T15:21:22 | {} | MEMBER |
vuejs | core | 549,884,961 | 425 | vue-bot | Hey @ChesterBu, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-05T15:56:33 | 2019-11-05T15:56:33 | {} | CONTRIBUTOR |
vuejs | core | 553,986,357 | 458 | yyx990803 | Thanks for the PR - however, my original comment actually was more about the fact that we are doing multiple `indexOf` calls to find the end for current text. I think the `Math.min` refactor, while beneficial, is likely not the bottleneck. | 2019-11-14T17:12:16 | 2019-11-14T17:12:44 | {} | MEMBER |
vuejs | core | 554,560,369 | 458 | vue-bot | Hey @loiacon, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-15T22:53:04 | 2019-11-15T22:53:04 | {} | CONTRIBUTOR |
vuejs | core | 548,193,499 | 407 | chenquincy | @yyx990803 Yes, I think you are right. Ths for reply. | 2019-10-31T02:43:12 | 2019-10-31T02:43:12 | {} | CONTRIBUTOR |
vuejs | core | 551,896,375 | 442 | yyx990803 | I was a bit skeptical about the benchmark because it doesn't make sense. Turns out V8 optimizes the call using `indexOf` because it is probably flagged as a special side-effect-free method but `startsWith` somehow is not. So simply calling the function without assigning the return value to anything (i.e. the call produ... | 2019-11-08T16:30:22 | 2019-11-08T16:30:45 | {} | MEMBER |
vuejs | core | 552,147,624 | 445 | yyx990803 | Thanks! This is a good catch, but the fix isn't quite right. I added more tests in 08bf997. | 2019-11-09T23:41:33 | 2019-11-09T23:41:33 | {} | MEMBER |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.