owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 553,084,480 | 449 | cexbrayat | @posva @yyx990803 Thanks for the feedback!
I added a unit test and implemented a special case in `patchProp`, let me know if this how you intended it. | 2019-11-12T19:48:24 | 2019-11-12T19:48:24 | {} | MEMBER |
vuejs | core | 553,691,366 | 457 | zzzz-Z | 而且测试用例和实际使用情况展现的完全两种情况 这也是不应该的啊 | 2019-11-14T02:11:31 | 2019-11-14T02:11:31 | {} | CONTRIBUTOR |
vuejs | core | 557,438,269 | 479 | 0xPoe | > Code is automatically formatted so there's no need to submit manual code style fixes. Thanks.
I don't think format code can remove this semicolon. Could you please explain why we have this semicolon now? | 2019-11-22T08:23:22 | 2019-11-22T08:23:22 | {} | CONTRIBUTOR |
vuejs | core | 546,790,935 | 382 | dsseng | @yyx990803 your request was completed | 2019-10-28T04:57:04 | 2019-10-28T04:57:04 | {} | CONTRIBUTOR |
vuejs | core | 547,020,326 | 403 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-28T16:08:32 | 2019-10-28T16:08:32 | {} | CONTRIBUTOR |
vuejs | core | 549,511,736 | 424 | vue-bot | Hey @412799755, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-04T19:33:13 | 2019-11-04T19:33:13 | {} | CONTRIBUTOR |
vuejs | core | 549,514,503 | 419 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-04T19:40:02 | 2019-11-04T19:40:02 | {} | CONTRIBUTOR |
vuejs | core | 549,515,942 | 405 | yyx990803 | landed in 1a361e2 | 2019-11-04T19:43:38 | 2019-11-04T19:43:38 | {} | MEMBER |
vuejs | core | 553,693,800 | 457 | Justineo | @yyx990803 这好像说的是没有 `.native` 的时候 `<child @click="...">` 绑到了它的根元素上？ | 2019-11-14T02:22:17 | 2019-11-14T02:22:17 | {} | MEMBER |
vuejs | core | 554,520,629 | 459 | vue-bot | Hey @loiacon, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-15T20:42:04 | 2019-11-15T20:42:04 | {} | CONTRIBUTOR |
vuejs | core | 555,039,901 | 466 | panstromek | This will (just by JS semantics) be slower, because it performs unnecessary allocation of new Object and dynamic property lookup, which are both much more expensive than simple branching. You basically need to rely on the engine to optimize it, but the engine doesn't do it until the function is run at least once, more ... | 2019-11-18T14:32:07 | 2019-11-18T14:32:07 | {} | NONE |
vuejs | core | 555,526,464 | 464 | vue-bot | Hey @underfin, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-19T14:16:04 | 2019-11-19T14:16:04 | {} | CONTRIBUTOR |
vuejs | core | 547,807,557 | 407 | chenquincy | @yyx990803 Use `effect` on a stopped effect can get a new effect, but it seems that I should pass all the options again. It's not convenient when I have many options in the original `effect`. | 2019-10-30T09:16:47 | 2019-10-30T09:41:09 | {} | CONTRIBUTOR |
vuejs | core | 547,905,800 | 400 | dependabot-preview[bot] | Superseded by #415. | 2019-10-30T13:35:33 | 2019-10-30T13:35:33 | {} | CONTRIBUTOR |
vuejs | core | 549,513,810 | 420 | vue-bot | Hey @imgss, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-04T19:38:26 | 2019-11-04T19:38:26 | {} | CONTRIBUTOR |
vuejs | core | 553,978,829 | 451 | vue-bot | Hey @underfin, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-14T16:55:15 | 2019-11-14T16:55:15 | {} | CONTRIBUTOR |
vuejs | core | 554,676,348 | 462 | yyx990803 | Great job! | 2019-11-16T21:32:11 | 2019-11-16T21:32:11 | {} | MEMBER |
vuejs | core | 555,076,774 | 468 | yyx990803 | We should update the json and alias plugin too. | 2019-11-18T15:51:20 | 2019-11-18T15:51:20 | {} | MEMBER |
vuejs | core | 556,854,493 | 475 | AmberAAA | 1 | 2019-11-21T02:25:31 | 2019-11-21T02:25:31 | {} | NONE |
vuejs | core | 551,104,704 | 434 | vue-bot | Hey @pikax, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-07T14:33:51 | 2019-11-07T14:33:51 | {} | CONTRIBUTOR |
vuejs | core | 554,518,995 | 459 | yyx990803 | 👍 | 2019-11-15T20:37:09 | 2019-11-15T20:37:09 | {} | MEMBER |
vuejs | core | 555,148,980 | 453 | vue-bot | Hey @chenquincy, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-18T18:34:06 | 2019-11-18T18:34:06 | {} | CONTRIBUTOR |
vuejs | core | 546,754,710 | 396 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-28T01:00:51 | 2019-10-28T01:00:51 | {} | CONTRIBUTOR |
vuejs | core | 546,871,785 | 389 | a631807682 | It should work in prod too, `errorHandler` is not dev api, usually we need to upload track error to the server. | 2019-10-28T09:52:08 | 2019-10-28T09:52:08 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 546,967,248 | 401 | vue-bot | Hey @underfin, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-28T14:18:29 | 2019-10-28T14:18:29 | {} | CONTRIBUTOR |
vuejs | core | 547,552,359 | 409 | vue-bot | Hey @underfin, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-29T17:56:50 | 2019-10-29T17:56:50 | {} | CONTRIBUTOR |
vuejs | core | 547,819,389 | 407 | chenquincy | > @yyx990803 Use `effect` on a stopped effect can get a new effect, but it seems that I should pass all the options again. It's not convenient when I have many options in the original `effect`.
@yyx990803 Maybe `restart` is the better name for this function. It's the feature I want to add actually. | 2019-10-30T09:48:05 | 2019-10-30T09:48:05 | {} | CONTRIBUTOR |
vuejs | core | 547,906,357 | 415 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [deploy/netlify](https://app.netlify.com/sites/vue-next-coverage/deploys/5db9919b2e93e20008f30f0d)
- [Mixed content](https://app.netlify.com/sites/vue-next-coverage/deploys/5db9919b2e93e20008f30f0d)
- [Redirect rules](https://app.netlify.... | 2019-10-30T13:36:44 | 2019-10-30T13:36:44 | {} | CONTRIBUTOR |
vuejs | core | 552,062,370 | 435 | yyx990803 | The test directory name should be `__tests__` with two underscores. Some tests can be ported from here: https://github.com/vuejs/component-compiler-utils/tree/master/test | 2019-11-09T03:40:05 | 2019-11-09T03:40:39 | {} | MEMBER |
vuejs | core | 553,691,176 | 457 | zzzz-Z | 可是我并没有在父元素上绑定事件啊，组件外部传递的事件不应该主动绑定到根元素上吧
2.0也不是这样子的啊 | 2019-11-14T02:10:38 | 2019-11-14T02:10:38 | {} | CONTRIBUTOR |
vuejs | core | 553,698,516 | 457 | zzzz-Z | @fnlctrl 谢谢 这么说以后都得加上 inheritAttrs: false,
除非你想让所有事件都继承到根元素上 是这个样子吗？ | 2019-11-14T02:44:09 | 2019-11-14T02:44:09 | {} | CONTRIBUTOR |
vuejs | core | 553,699,774 | 457 | fnlctrl | 要等这个rfc最终敲定了才能确定，也有可能有变动。目前的实现是这个行为。 | 2019-11-14T02:50:03 | 2019-11-14T02:50:03 | {} | MEMBER |
vuejs | core | 555,074,213 | 466 | yyx990803 | What @panstromek said. | 2019-11-18T15:46:11 | 2019-11-18T15:46:11 | {} | MEMBER |
vuejs | core | 557,439,044 | 479 | 0xPoe | I tried to use yarn lint to format code but it still in there. | 2019-11-22T08:25:49 | 2019-11-22T08:25:49 | {} | CONTRIBUTOR |
vuejs | core | 546,965,558 | 398 | yyx990803 | The original is correct. It should report the method name not being found. | 2019-10-28T14:14:41 | 2019-10-28T14:14:41 | {} | MEMBER |
vuejs | core | 551,859,668 | 441 | vue-bot | Hey @chenquincy, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-08T14:57:26 | 2019-11-08T14:57:26 | {} | CONTRIBUTOR |
vuejs | core | 552,057,737 | 438 | vue-bot | Hey @ztplz, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-11-09T02:37:25 | 2019-11-09T02:37:25 | {} | CONTRIBUTOR |
vuejs | core | 554,190,560 | 456 | theniceangel | @yyx990803 no problem. | 2019-11-15T03:06:22 | 2019-11-15T03:06:22 | {} | CONTRIBUTOR |
vuejs | core | 556,954,495 | 477 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [ci/circleci: build](https://circleci.com/gh/vuejs/vue-next/1329?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
Dependabot will still automatically merge this pull request if you amend it and your tes... | 2019-11-21T07:20:46 | 2019-11-21T07:20:46 | {} | CONTRIBUTOR |
vuejs | core | 541,330,380 | 218 | vue-bot | Hey @a631807682, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-12T14:35:22 | 2019-10-12T14:35:22 | {} | CONTRIBUTOR |
vuejs | core | 541,331,205 | 229 | yyx990803 | This is already inferred. | 2019-10-12T14:45:11 | 2019-10-12T14:45:11 | {} | MEMBER |
vuejs | core | 541,351,585 | 248 | Justineo | Usually if you see a plain for loop in our source code, it **is intentional** for performance reasons. We are not accepting changes that introduce performance loss but doesn't change any behavior. | 2019-10-12T18:46:06 | 2019-10-12T18:46:06 | {} | MEMBER |
vuejs | core | 541,369,318 | 241 | yyx990803 | I was checking xlink support range and noticed it's actually no longer needed the evergreen browsers, so I removed the code for it. We will need to add it back for the IE11 compat build but that will be done when it's due. | 2019-10-12T23:26:23 | 2019-10-12T23:26:23 | {} | MEMBER |
vuejs | core | 541,447,344 | 125 | dsseng | @yyx990803 I discovered that there's a [`Symbol.for`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/for) function, which could help us with global symbols. What do you think about it? | 2019-10-13T19:00:57 | 2019-10-13T19:01:58 | {} | CONTRIBUTOR |
vuejs | core | 541,499,061 | 267 | yyx990803 | This should be kept, because the `_createVNode` inside the `with` block is faster (no `with` check to access it). | 2019-10-14T04:24:54 | 2019-10-14T04:24:54 | {} | MEMBER |
vuejs | core | 541,109,280 | 196 | yyx990803 | We do use commitizen in Vue 2's repo but honestly I haven't found it to be much useful. Thanks for the PR though. | 2019-10-11T15:22:54 | 2019-10-11T15:22:54 | {} | MEMBER |
vuejs | core | 541,124,828 | 213 | yyx990803 | I was actually not going to do inline code generation for the logic. Instead we will export tree-shakable handler wrappers like `withKeyModifer(fn, 'foo')` from the runtime so the DOM v-on transform just need to wrap the base handler expressions. | 2019-10-11T16:04:51 | 2019-10-11T16:04:51 | {} | MEMBER |
vuejs | core | 541,370,827 | 220 | vue-bot | Hey @underfin, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-12T23:54:25 | 2019-10-12T23:54:25 | {} | CONTRIBUTOR |
vuejs | core | 541,407,854 | 256 | PoojaKhandhadia | Thanks @yyx990803 for such detailed explanation. I understand your concern and will try to create some useful PRs :) | 2019-10-13T10:51:40 | 2019-10-13T10:51:40 | {} | NONE |
vuejs | core | 541,642,220 | 125 | dsseng | Prefixing serces that purpose: `Symbol.for('Vue.isVNode')` will resolve that problem | 2019-10-14T12:15:08 | 2019-10-14T12:15:08 | {} | CONTRIBUTOR |
vuejs | core | 541,790,653 | 275 | CyberAP | > Turns out a benchmark shows that `in` check or plain object access is about 5x faster than using Sets, mostly because the objects are static so their property access is well-optimized by the engine. We probably want to refactor all existing usage of Set checks to just plain objects.
>
> To save the redundant `{ ke... | 2019-10-14T16:49:12 | 2019-10-14T16:49:12 | {} | CONTRIBUTOR |
vuejs | core | 541,117,371 | 210 | dsseng | okay, thanks for fixing this! | 2019-10-11T15:44:53 | 2019-10-11T15:44:53 | {} | CONTRIBUTOR |
vuejs | core | 541,279,927 | 219 | vue-bot | Hey @z-ao, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-12T03:33:23 | 2019-10-12T03:33:23 | {} | CONTRIBUTOR |
vuejs | core | 541,298,033 | 214 | pikax | Similar to: #107 https://github.com/vuejs/vue-next/pull/209 | 2019-10-12T07:52:28 | 2019-10-12T07:52:28 | {} | MEMBER |
vuejs | core | 541,317,225 | 236 | pikax | Aren't you suppose to build with yarn? | 2019-10-12T11:46:08 | 2019-10-12T11:46:08 | {} | MEMBER |
vuejs | core | 541,484,552 | 263 | yyx990803 | In case you missed it... these modifiers are already handled in the runtime: https://github.com/vuejs/vue-next/blob/master/packages/runtime-dom/src/directives/vModel.ts#L40 (And they are better placed in the runtime because there are additional special behavior needed, and they can be tree-shaken if never used). | 2019-10-14T02:18:51 | 2019-10-14T02:19:40 | {} | MEMBER |
vuejs | core | 541,487,601 | 240 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-14T02:46:25 | 2019-10-14T02:46:25 | {} | CONTRIBUTOR |
vuejs | core | 541,782,795 | 267 | yyx990803 | It won't, it's just shadowing with the same function. | 2019-10-14T16:33:26 | 2019-10-14T16:33:26 | {
"+1": 1
} | MEMBER |
vuejs | core | 541,278,911 | 211 | yyx990803 | This function may need to handle manually written slots so anything be there and `unknown` is the correct type. | 2019-10-12T03:19:49 | 2019-10-12T03:19:49 | {} | MEMBER |
vuejs | core | 541,330,102 | 223 | yyx990803 | `runtime-test` is platform agnostic. It doesn't have void tags. | 2019-10-12T14:31:39 | 2019-10-12T14:31:51 | {} | MEMBER |
vuejs | core | 541,330,410 | 222 | vue-bot | Hey @HcySunYang, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-12T14:35:41 | 2019-10-12T14:35:41 | {} | CONTRIBUTOR |
vuejs | core | 541,331,441 | 226 | yyx990803 | After thinking about it I think it's probably ok to have a simple object map for it, since public property access is not as common as data/prop access. Trying to land https://github.com/vuejs/vue-next/pull/214. | 2019-10-12T14:47:44 | 2019-10-12T14:47:44 | {} | MEMBER |
vuejs | core | 541,332,523 | 228 | vue-bot | Hey @mcc108, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-12T15:00:36 | 2019-10-12T15:00:36 | {} | CONTRIBUTOR |
vuejs | core | 541,369,895 | 234 | vue-bot | Hey @sangeeth96, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-12T23:38:49 | 2019-10-12T23:38:49 | {} | CONTRIBUTOR |
vuejs | core | 541,380,369 | 256 | yyx990803 | I know this is related to #245, but I decided to revert it. See https://github.com/vuejs/vue-next/pull/257
Please note that in general, I do not encourage style-related PRs. I understand the desire to contribute, but please also realize that style related changes are often subjective in terms of whether it improves ... | 2019-10-13T02:54:15 | 2019-10-13T02:54:15 | {} | MEMBER |
vuejs | core | 541,407,866 | 261 | dsseng | We should probably rename this function to e.g. `toVNode` since it doesn't produce only strings now. | 2019-10-13T10:51:47 | 2019-10-13T10:51:59 | {} | CONTRIBUTOR |
vuejs | core | 541,504,784 | 267 | yyx990803 | It is, but the outer variable is only used for hoisted calls, and the inner is used by other non-hoisted calls. The inner variable still provides performance benefits for non-hoisted calls. | 2019-10-14T05:11:27 | 2019-10-14T05:11:27 | {} | MEMBER |
vuejs | core | 541,765,735 | 273 | vue-bot | Hey @a631807682, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-14T16:01:04 | 2019-10-14T16:01:04 | {} | CONTRIBUTOR |
vuejs | core | 541,334,312 | 220 | underfin | Thanks for your review. I already change my code and commit it. | 2019-10-12T15:20:23 | 2019-10-12T15:20:23 | {} | MEMBER |
vuejs | core | 541,484,587 | 265 | yyx990803 | Seehttps://github.com/vuejs/vue-next/pull/263#issuecomment-541484552 | 2019-10-14T02:19:08 | 2019-10-14T02:19:08 | {} | MEMBER |
vuejs | core | 541,505,365 | 125 | yyx990803 | `Symbol.for` doesn't provide the same level of encapsulation as normal Symbols. Suppose we use `Symbol.for('isVNode')`, then the user can do this:
``` js
const myVNode = {
[Symbol.for('isVNode')]: true
}
```
So it's not fundamentally different from `_isVNode: true`. | 2019-10-14T05:16:13 | 2019-10-14T05:16:13 | {} | MEMBER |
vuejs | core | 541,097,020 | 204 | yyx990803 | See https://github.com/vuejs/vue-next/pull/202#issuecomment-541096982 | 2019-10-11T14:51:32 | 2019-10-11T14:51:32 | {} | MEMBER |
vuejs | core | 541,104,194 | 208 | vue-bot | Hey @xanf, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-11T15:09:57 | 2019-10-11T15:09:57 | {} | CONTRIBUTOR |
vuejs | core | 541,107,319 | 210 | yyx990803 | This is actually a TODO where the template compilation error should be logged for on-the-fly compilation. See https://github.com/vuejs/vue-next/commit/95d7e1f471ed098f1f3bb3fa9cb4bd27bc2e76c8 | 2019-10-11T15:17:42 | 2019-10-11T15:17:42 | {} | MEMBER |
vuejs | core | 541,273,203 | 205 | vue-bot | Hey @ChesterBu, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-12T02:09:35 | 2019-10-12T02:09:35 | {} | CONTRIBUTOR |
vuejs | core | 541,492,178 | 261 | yyx990803 | I don't think this feature is needed. | 2019-10-14T03:26:29 | 2019-10-14T03:26:29 | {} | MEMBER |
vuejs | core | 541,190,068 | 215 | vue-bot | Hey @xanf, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-11T19:14:39 | 2019-10-11T19:14:39 | {} | CONTRIBUTOR |
vuejs | core | 541,315,162 | 235 | PoojaKhandhadia | incorrect files changed | 2019-10-12T11:16:47 | 2019-10-12T11:16:47 | {} | NONE |
vuejs | core | 541,333,418 | 239 | vue-bot | Hey @jo0ger, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-12T15:10:35 | 2019-10-12T15:10:35 | {} | CONTRIBUTOR |
vuejs | core | 541,427,114 | 265 | dsseng | Duplicate of #263, but maybe this will be better as simpler solution? | 2019-10-13T15:14:40 | 2019-10-13T15:14:40 | {} | CONTRIBUTOR |
vuejs | core | 541,489,383 | 260 | vue-bot | Hey @fisker, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-14T03:02:14 | 2019-10-14T03:02:14 | {} | CONTRIBUTOR |
vuejs | core | 541,126,234 | 212 | dsseng | @yyx990803 it helps in editing, e.g. VSCode will create files with correct indents and EOL. | 2019-10-11T16:08:24 | 2019-10-11T16:08:24 | {} | CONTRIBUTOR |
vuejs | core | 541,181,678 | 81 | TimvdEijnden | @hugoazevedosoares If you know the name of the property that might be enough. If I would find out how to get the name I would just create a test and debug the code. | 2019-10-11T18:49:25 | 2019-10-11T18:49:25 | {} | CONTRIBUTOR |
vuejs | core | 541,406,509 | 262 | dsseng | Also, I think `getValueByPath` function might be helpful so we can extract it into `shared` package | 2019-10-13T10:31:54 | 2019-10-13T10:32:14 | {} | CONTRIBUTOR |
vuejs | core | 541,773,963 | 268 | yyx990803 | Interesting - I'm not able to reproduce this, but it does fail for computed refs. Fixed in 6b3ad95 and I also added type assertions to the tests. Thanks! | 2019-10-14T16:16:12 | 2019-10-14T16:16:12 | {} | MEMBER |
vuejs | core | 541,118,839 | 136 | yyx990803 | Closed by 5f28708 | 2019-10-11T15:48:40 | 2019-10-11T15:48:40 | {} | MEMBER |
vuejs | core | 541,120,735 | 196 | ant1m4tt3r | Thanks.
| 2019-10-11T15:53:42 | 2019-10-11T15:54:53 | {} | NONE |
vuejs | core | 541,190,155 | 216 | vue-bot | Hey @leopiccionia, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-11T19:14:59 | 2019-10-11T19:14:59 | {} | CONTRIBUTOR |
vuejs | core | 541,329,772 | 236 | DNLHC | Lock files are meant to be committed into repository | 2019-10-12T14:27:25 | 2019-10-12T14:27:25 | {} | NONE |
vuejs | core | 541,331,728 | 230 | vue-bot | Hey @a631807682, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-12T14:51:11 | 2019-10-12T14:51:11 | {} | CONTRIBUTOR |
vuejs | core | 541,358,046 | 243 | yyx990803 | This is largely subjective - but I only use early return if the branches are big and have extra nesting. In this case it just doesn't seem necessary. | 2019-10-12T20:16:13 | 2019-10-12T20:16:13 | {} | MEMBER |
vuejs | core | 541,487,489 | 253 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-14T02:45:31 | 2019-10-14T02:45:31 | {} | CONTRIBUTOR |
vuejs | core | 541,491,709 | 259 | vue-bot | Hey @fisker, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-14T03:22:38 | 2019-10-14T03:22:38 | {} | CONTRIBUTOR |
vuejs | core | 541,527,171 | 266 | jo0ger | Indeed, there are the following question：
``` ts
const a = ref(0)
const b1 = computed(() => a.value) // the type of b1 is ComputedRef<number>
const b2 = computed({ // the type of b2 is WritableComputedRef<number>
get: () => a.value,
set: val => {}
})
const c1 = reactive({ b1 }) // the type of c1.b1 is numbe... | 2019-10-14T07:12:19 | 2019-10-14T07:13:10 | {} | CONTRIBUTOR |
vuejs | core | 541,641,202 | 267 | dsseng | @yyx990803 won't it create an error? | 2019-10-14T12:12:58 | 2019-10-14T12:12:58 | {} | CONTRIBUTOR |
vuejs | core | 541,784,142 | 217 | CodeDaraW | Great, what you say just has cleared up my confusion!
Since add `isCustomElement` config option will change the logic of compiler, is it better to open a separate PR doing this? | 2019-10-14T16:36:05 | 2019-10-14T16:36:05 | {} | CONTRIBUTOR |
vuejs | core | 541,298,596 | 209 | a631807682 | > Usage of `switch` here is intentional.
Is it necessary to remove the comment or change it to a more detailed comment?
```
// TODO simplify this?
switch (key) {
...
``` | 2019-10-12T07:59:32 | 2019-10-12T07:59:32 | {} | CONTRIBUTOR |
vuejs | core | 541,332,918 | 232 | vue-bot | Hey @sharvilak11, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-12T15:04:46 | 2019-10-12T15:04:46 | {} | CONTRIBUTOR |
vuejs | core | 541,490,047 | 258 | yyx990803 | `Array.from` is significantly slower than plain for loop. | 2019-10-14T03:08:32 | 2019-10-14T03:08:32 | {} | MEMBER |
vuejs | core | 541,500,499 | 264 | vue-bot | Hey @jo0ger, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-14T04:37:03 | 2019-10-14T04:37:03 | {} | CONTRIBUTOR |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.