owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 541,782,367 | 275 | yyx990803 | Turns out a benchmark shows that `in` check or plain object access is about 5x faster than using Sets, mostly because the objects are static so their property access is well-optimized by the engine. We probably want to refactor all existing usage of Set checks to just plain objects.
To save the redundant `{ key: tru... | 2019-10-14T16:32:36 | 2019-10-14T16:32:36 | {} | MEMBER |
vuejs | core | 541,332,986 | 237 | vue-bot | Hey @sharvilak11, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-12T15:05:30 | 2019-10-12T15:05:30 | {} | CONTRIBUTOR |
vuejs | core | 541,369,929 | 250 | vue-bot | Hey @fisker, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-12T23:39:24 | 2019-10-12T23:39:24 | {} | CONTRIBUTOR |
vuejs | core | 541,371,481 | 254 | yyx990803 | Should be in `runtime-core` (and re-exported in `vue`). It's possible for 3rd party custom runtimes to have different versions from core. | 2019-10-13T00:01:51 | 2019-10-13T00:01:51 | {
"+1": 1
} | MEMBER |
vuejs | core | 541,416,371 | 217 | CodeDaraW | User component name validation has been implemented, but how should we set the default `isNativeTag` in `runtime-dom` ? | 2019-10-13T12:58:23 | 2019-10-13T12:58:23 | {} | CONTRIBUTOR |
vuejs | core | 541,492,061 | 262 | yyx990803 | This is going to be dropped in v3 (will only be supported in 2.x compat build). It's one of those inconsistent designs (only support dot but not bracket paths / complex exps) | 2019-10-14T03:25:26 | 2019-10-14T03:25:26 | {} | MEMBER |
vuejs | core | 541,642,712 | 261 | dsseng | Okay, i thought that's a dirty & hacky workaround | 2019-10-14T12:16:14 | 2019-10-14T12:16:14 | {} | CONTRIBUTOR |
vuejs | core | 541,331,578 | 227 | vue-bot | Hey @wubaiqing, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-12T14:49:19 | 2019-10-12T14:49:19 | {} | CONTRIBUTOR |
vuejs | core | 541,332,135 | 231 | yyx990803 | This project does not use npm. Yarn is required for development. | 2019-10-12T14:56:20 | 2019-10-12T14:56:20 | {} | MEMBER |
vuejs | core | 541,348,899 | 254 | posva | If we add this it should probably be a variable replacement done with rollup and jest (like __DEV__). | 2019-10-12T18:12:38 | 2019-10-12T18:12:38 | {
"+1": 1
} | MEMBER |
vuejs | core | 541,504,531 | 261 | yyx990803 | This can be done with a functional component that returns any vnode passed as prop. It shouldn't be an interpolation feature. | 2019-10-14T05:09:55 | 2019-10-14T05:09:55 | {} | MEMBER |
vuejs | core | 541,515,013 | 268 | yyx990803 | Sorry but this doesn't seem to be an improvement. | 2019-10-14T06:13:30 | 2019-10-14T06:13:30 | {} | MEMBER |
vuejs | core | 541,660,024 | 125 | pikax | in production we don't name the symbols.
In my opinion there's not much benefit of using symbols in `_isVNode` since the reason of using `Symbol` is to prevent access to the property, something the `Symbol.for('isVNode')` won't do it. | 2019-10-14T12:54:00 | 2019-10-14T12:54:00 | {
"+1": 1
} | MEMBER |
vuejs | core | 541,125,257 | 212 | yyx990803 | Since the code is auto-formatted I don't think this is really needed. | 2019-10-11T16:05:59 | 2019-10-11T16:05:59 | {} | MEMBER |
vuejs | core | 541,128,940 | 213 | fnlctrl | Got it, I'll update to use runtime wrappers instead | 2019-10-11T16:16:15 | 2019-10-11T16:16:15 | {} | MEMBER |
vuejs | core | 541,188,468 | 215 | yyx990803 | Yeah, that's correct. I dropped the class optimization part because it relies on full AST analysis and won't be consistent between browser/non-browser builds. | 2019-10-11T19:09:25 | 2019-10-11T19:09:25 | {} | MEMBER |
vuejs | core | 541,351,139 | 254 | dsseng | @posva thanks, will do! where should it be, `runtime-core` or `vue`? Now I think `vue` will be better for that | 2019-10-12T18:40:59 | 2019-10-12T18:40:59 | {} | CONTRIBUTOR |
vuejs | core | 541,351,784 | 251 | Justineo | As mentioned in other PRs, this will be a no-go. Thanks for the contribution anyway. | 2019-10-12T18:48:50 | 2019-10-12T18:48:50 | {} | MEMBER |
vuejs | core | 541,370,411 | 214 | vue-bot | Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-12T23:49:32 | 2019-10-12T23:49:32 | {} | CONTRIBUTOR |
vuejs | core | 541,491,839 | 246 | vue-bot | Hey @fisker, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-14T03:23:35 | 2019-10-14T03:23:35 | {} | CONTRIBUTOR |
vuejs | core | 541,597,308 | 268 | adamlewkowicz | @yyx990803
This PR wasn't finished and it was a fix for watcher types, since it doesn't inherit types correctly.
 | 2019-10-14T10:19:51 | 2019-10-14T10:21:41 | {} | CONTRIBUTOR |
vuejs | core | 541,607,791 | 172 | zzzzzhowie | you are right，but when l change `collectionTypes` type，there will be an typescript error in this line because Function（target.constructor） is not assignable to paramter of type 'CollectionConstructor'
```typescript
const handlers = collectionTypes.has(target.constructor)
? collectionHandlers
: baseHandle... | 2019-10-14T10:49:37 | 2019-10-14T14:36:17 | {} | CONTRIBUTOR |
vuejs | core | 541,724,486 | 266 | yyx990803 | @jo0ger indeed! Adding the generic T to the underlying ReactiveEffect allows TS to infer T from it. | 2019-10-14T14:49:53 | 2019-10-14T14:49:53 | {} | MEMBER |
vuejs | core | 541,735,498 | 266 | vue-bot | Hey @jo0ger, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-14T15:07:50 | 2019-10-14T15:07:50 | {} | CONTRIBUTOR |
vuejs | core | 541,760,603 | 274 | yyx990803 | This does reduce a few `.has` checks for already reactive values, but adds two `.has` checks for non-reactive values. Benchmark shows similar performance after this change, so I don't think this is necessary. | 2019-10-14T15:51:52 | 2019-10-14T15:51:52 | {} | MEMBER |
vuejs | core | 541,269,433 | 204 | TerenceZ | > See [#202 (comment)](https://github.com/vuejs/vue-next/pull/202#issuecomment-541096982)
The refered PR aims to resolve Empty node, but this PR is related to hoist with Comment.
The following code will refer to _Comment without declaration.
```html
<div><span><!-- comment --> content</span></div>
```
```... | 2019-10-12T01:30:38 | 2019-10-12T01:30:38 | {} | CONTRIBUTOR |
vuejs | core | 541,273,188 | 204 | yyx990803 | It has been addressed by #208: https://github.com/vuejs/vue-next/blob/master/packages/compiler-core/src/codegen.ts#L214-L216 | 2019-10-12T02:09:23 | 2019-10-12T02:09:23 | {} | MEMBER |
vuejs | core | 541,332,287 | 233 | yyx990803 | This PR seems to be based off an outdated commit and is no longer valid. | 2019-10-12T14:57:46 | 2019-10-12T14:57:46 | {} | MEMBER |
vuejs | core | 541,372,663 | 245 | vue-bot | Hey @fisker, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-13T00:17:10 | 2019-10-13T00:17:10 | {} | CONTRIBUTOR |
vuejs | core | 541,513,909 | 272 | yyx990803 | 不要发垃圾 PR。再犯直接 block。 | 2019-10-14T06:07:59 | 2019-10-14T06:07:59 | {} | MEMBER |
vuejs | core | 541,516,504 | 225 | vue-bot | Hey @a631807682, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-14T06:20:32 | 2019-10-14T06:20:32 | {} | CONTRIBUTOR |
vuejs | core | 541,647,132 | 276 | HcySunYang | The test needs to update the snapshot, but I don't know how to fix it. | 2019-10-14T12:25:33 | 2019-10-14T12:44:04 | {} | MEMBER |
vuejs | core | 541,104,787 | 207 | vue-bot | Hey @Domino9697, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-11T15:11:22 | 2019-10-11T15:11:22 | {} | CONTRIBUTOR |
vuejs | core | 541,499,298 | 267 | dsseng | @yyx990803 isn't it a redefinition of variable? | 2019-10-14T04:26:48 | 2019-10-14T04:26:48 | {} | CONTRIBUTOR |
vuejs | core | 541,514,782 | 266 | yyx990803 | We also need to do the same for `WritableComputedRef`. But the inference would fail for at least one of them because TS thinks `ComputedRef` and `WritableComputedRef` extends each other: https://github.com/microsoft/TypeScript/issues/34274
Might need to come up with some alternative here. | 2019-10-14T06:12:24 | 2019-10-14T06:12:24 | {} | MEMBER |
vuejs | core | 541,330,572 | 203 | yyx990803 | Looks good - let's add a test case for this in `transformElement.spec.ts`. | 2019-10-12T14:37:35 | 2019-10-12T14:37:35 | {} | MEMBER |
vuejs | core | 541,369,831 | 244 | vue-bot | Hey @fisker, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-12T23:37:48 | 2019-10-12T23:37:48 | {} | CONTRIBUTOR |
vuejs | core | 541,370,041 | 236 | yyx990803 | I've already said this in another PR you submitted. **This project does not use npm. You should not be using npm to install dependencies. Yarn is required.** So `package-lock.json` doesn't make sense. | 2019-10-12T23:42:21 | 2019-10-12T23:42:53 | {} | MEMBER |
vuejs | core | 541,498,839 | 261 | dsseng | @yyx990803 it was required and wanted by users in v2. There was even an issue for that. | 2019-10-14T04:23:20 | 2019-10-14T04:23:20 | {} | CONTRIBUTOR |
vuejs | core | 620,763,349 | 1,073 | shadowc | That worked! Thanks a lot! | 2020-04-28T17:57:59 | 2020-04-28T17:57:59 | {} | NONE |
vuejs | core | 622,036,720 | 1,047 | yyx990803 | Oops, didn't see this, already did in 8ab44e1f | 2020-04-30T18:50:55 | 2020-04-30T18:50:55 | {} | MEMBER |
vuejs | core | 622,210,894 | 1,082 | lzhoucs | Update, I had some luck with SFC finally. It turns out I can totally get rid of `<slot></slot>` in my template. Check it out: https://codepen.io/lzhoucs/pen/RwWZYGp | 2020-05-01T01:54:53 | 2020-05-01T01:54:53 | {} | NONE |
vuejs | core | 618,451,735 | 1,033 | elevatebart | @shilman, @Aaron-Pool Did you experience the same kind of issue implementing vue-next in storybook? | 2020-04-23T15:08:47 | 2020-04-23T15:12:16 | {} | CONTRIBUTOR |
vuejs | core | 618,723,212 | 1,033 | elevatebart | The main conflict seems to be about `NativeElements`/ `IntrinsicElements`.
Another solution might be to share the definition of the `NativeElements` in a separate package, then have React and Vue typings depend on the same package.
This way, TSX conflicts will be avoided until one chooses to switch from react TS... | 2020-04-23T23:32:14 | 2020-04-23T23:32:14 | {} | CONTRIBUTOR |
vuejs | core | 618,727,470 | 1,033 | shilman | @elevatebart we haven't yet implemented vue-next in storybook. you're in uncharted territory! 😄 | 2020-04-23T23:48:18 | 2020-04-23T23:48:18 | {
"+1": 1
} | NONE |
vuejs | core | 618,776,361 | 1,040 | leopiccionia | Yes, `$on`, `$off` and `$once` were removed by a [merged RFC](https://github.com/vuejs/rfcs/blob/master/active-rfcs/0020-events-api-change.md).
That RFC suggested replacing a event bus by a library implementing the EventEmitter/PubSub pattern, like [mitt](https://www.npmjs.com/package/mitt). | 2020-04-24T03:06:25 | 2020-04-24T03:06:25 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 619,062,525 | 1,043 | ayangliayangli | > 额外感谢翻译，现在 Composition API 官方页面有一个中文翻译的 PR - 建议可以参与审阅，两边可以比较一下，完善和统一一些术语、概念的译法：[vuejs/composition-api-rfc#23](https://github.com/vuejs/composition-api-rfc/pull/23)
原来在这里，感谢指引！ | 2020-04-24T14:57:34 | 2020-04-24T14:57:34 | {} | NONE |
vuejs | core | 619,155,354 | 1,032 | pikax | Not necessarily, because `ClassComponent` is not part of `Component`, only `h` needs special typing to provide `props` validations, `PublicAPIComponent` can't be used in `h` because is quite generic and everything would fall under that overload.
That said, for the exposed APIs I think is much better using PublicAPI... | 2020-04-24T17:44:22 | 2020-04-24T17:44:22 | {} | MEMBER |
vuejs | core | 619,413,021 | 1,048 | jonaskuske | *Attributes* are always text, that's how HTML works. But if you want to pass something other than text, setting it as a DOM property instead of an attribute using [`:srcObject.prop="userMediaStream"`](https://vuejs.org/v2/api/#v-bind) should do the trick I believe. :) | 2020-04-25T17:23:05 | 2020-04-25T17:23:05 | {} | CONTRIBUTOR |
vuejs | core | 619,420,775 | 1,048 | jonaskuske | Yup that's it, good catch! Instead of setting `srcObject` to `null`, which is permitted, it tries setting it to an empty string – and that throws.
For now you could add a `v-if="userMediaStream"` to the `<video>` :) | 2020-04-25T18:20:44 | 2020-04-25T18:22:36 | {
"heart": 1
} | CONTRIBUTOR |
vuejs | core | 619,465,536 | 1,049 | jonaskuske | Why is Vue 3 even doing this to begin with? It seems to be a convenience feature that was introduced intentionally ([there's a test for it](https://github.com/vuejs/vue-next/blob/master/packages/runtime-dom/__tests__/patchProps.spec.ts#L9-L10)), but it's a breaking change:
In Vue 2, `<div :id.prop="null" />` would r... | 2020-04-26T01:43:22 | 2020-04-26T04:05:03 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 619,934,627 | 1,063 | posva | What @mathe42 said and please do not skip the reproduction link when reporting bugs | 2020-04-27T11:53:08 | 2020-04-27T11:53:08 | {} | MEMBER |
vuejs | core | 621,916,319 | 1,082 | underfin | sorry.I dont have another solution for this. | 2020-04-30T15:11:04 | 2020-04-30T15:11:04 | {} | MEMBER |
vuejs | core | 622,309,643 | 1,093 | blake-newman | To me this makes the most sense, the null casting to an empty string seems to be a convenience layer only.
However, this casting can be done in userland when desired, which firstly fixes #1049 and as the alternatives are computational heavy we can remove from the framework. | 2020-05-01T09:01:31 | 2020-05-01T09:01:31 | {} | MEMBER |
vuejs | core | 619,037,151 | 1,043 | yyx990803 | 谢谢分享，但这里不是分享的地方。issue 只用来报 bug 和 feature request. | 2020-04-24T14:15:58 | 2020-04-24T14:15:58 | {} | MEMBER |
vuejs | core | 619,419,526 | 1,048 | jonaskuske | Sneaky edit: you're right, in Vue 3 there's an error because you can't set `srcObject` to anything other than a `MediaStream` | 2020-04-25T18:10:48 | 2020-04-25T18:14:39 | {} | CONTRIBUTOR |
vuejs | core | 619,475,801 | 1,052 | LemonAppleMo | 好像是自闭和标签的问题。 | 2020-04-26T03:37:09 | 2020-04-26T03:37:09 | {} | NONE |
vuejs | core | 619,961,239 | 1,064 | bekalshenoy | @posva I tried Both Option Given By @mathe42 in #1063 But Both Fails With A New Error. I Also Given A GitHub Repo Link. | 2020-04-27T12:42:06 | 2020-04-27T12:42:06 | {} | CONTRIBUTOR |
vuejs | core | 621,427,943 | 1,074 | yyx990803 | `config.globalProperties` are meant as an escape hatch for replicating the behavior of `Vue.prototype`. In setup functions, simply import what you need or explicitly use `provide/inject` to expose properties to app. | 2020-04-29T19:53:46 | 2020-04-29T19:53:46 | {
"+1": 2
} | MEMBER |
vuejs | core | 621,484,333 | 802 | filonik | @Himself65 Thank you for taking a stab at it nonetheless. It seems like supporting this feature is more of a philosophical/design decision, rather than a technical issue.
I do wonder if there might be a mechanism to implement this functionality while avoiding some of the costs/penalties that were mentioned. Also, I ... | 2020-04-29T21:51:35 | 2020-04-29T21:56:50 | {} | NONE |
vuejs | core | 622,069,719 | 1,047 | pikax | I can upgrade to 3.9 and do the tests, I'm used to fix type errors 😄
No worries about it 🙂 | 2020-04-30T19:49:11 | 2020-04-30T19:49:11 | {} | MEMBER |
vuejs | core | 620,052,725 | 1,062 | yyx990803 | Booleans are valid vnode children and should be rendered. This is also consistent with v2 behavior.
Only `null` is considered empty placeholder. Conditional rendering should use `condition ? h(...) : null`. | 2020-04-27T15:19:40 | 2020-04-27T15:19:57 | {} | MEMBER |
vuejs | core | 621,614,451 | 1,082 | lzhoucs | Sorry, I don't quite get it. I don't expect/rely on anything being fallthrough though. All I know is`props.modelValue` is available inside the render function(`Tabs`), and the render function runs everytime the tab is clicked (because of updated `props.modelValue` I guess). So maybe there's something I missed that I st... | 2020-04-30T05:04:21 | 2020-04-30T05:25:21 | {} | NONE |
vuejs | core | 622,425,170 | 1,049 | yyx990803 | FYI: there is no `.prop` modifier in Vue 3 anymore. Vue 3 intelligently determines if the key should be set as a prop or an attribute.
A result of this is that `<div id="foo"/>` also sets `id` as a prop - so it needs to coerce nullish values to strings in this case. | 2020-05-01T15:06:39 | 2020-05-01T15:06:39 | {
"+1": 1
} | MEMBER |
vuejs | core | 618,884,919 | 993 | pikax | Even with the rename it makes really hard to enforce the correct types validation, because when you have the interface `Component` that is generic, the enforcing of the props becomes really hard.
The tests I was getting trouble with were the `h-dts`
if we are too loose, this will not pass
```ts
describe('h inf... | 2020-04-24T08:42:23 | 2020-04-24T08:42:23 | {} | MEMBER |
vuejs | core | 619,207,153 | 1,033 | Aaron-Pool | @elevatebart Same here, the furthest I've gone is using jsx with the Vue 2.x composition-api plugin. Haven't started to explore the vue-next waters just yet. | 2020-04-24T19:44:44 | 2020-04-24T19:44:44 | {} | NONE |
vuejs | core | 619,414,112 | 1,048 | ycmjason | Opps, looks like it is not working yet. I will leave this open. 😄 | 2020-04-25T17:31:40 | 2020-04-25T17:31:40 | {} | CONTRIBUTOR |
vuejs | core | 620,709,334 | 1,072 | posva | As said in the other issue, change your shim: https://github.com/vuejs/vue-router-next/blob/master/playground/shim.d.ts | 2020-04-28T16:18:56 | 2020-04-28T16:18:56 | {
"+1": 1
} | MEMBER |
vuejs | core | 621,432,794 | 1,076 | yyx990803 | The callback fires because a new object is being returned every time, and it does a simple identity compare by default.
You can just perform your own deep comparison in the callback and return if nothing has changed. | 2020-04-29T20:03:10 | 2020-04-29T20:03:10 | {} | MEMBER |
vuejs | core | 621,688,408 | 1,085 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [ci/circleci: test](https://circleci.com/gh/vuejs/vue-next/4567?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
Dependabot will still automatically merge this pull request if you amend it and your test... | 2020-04-30T08:20:51 | 2020-04-30T08:20:51 | {} | CONTRIBUTOR |
vuejs | core | 622,064,894 | 1,047 | yyx990803 | Oh! I didn't even notice those tests.
So I noticed that TS 3.9 has built-in `@ts-expect-error`, and I think we would be better off dropping `tsd` and using your approach (by building a dummy project with `tsc --noEmit`). So that would mean migrating existing `test-dts` tests. The thing is there are a number of type ... | 2020-04-30T19:41:11 | 2020-04-30T19:41:34 | {} | MEMBER |
vuejs | core | 618,065,376 | 1,033 | yyx990803 | But are you going to use JSX/TSX in Vue, or are you going entirely with templates?
While this does make it compile, you still wouldn't be able to use Vue TSX until you completely remove React typings? | 2020-04-22T22:06:26 | 2020-04-22T22:06:26 | {
"+1": 3
} | MEMBER |
vuejs | core | 618,238,927 | 1,035 | posva | You no longer use `extend`, use `defineComponent` or the `extends` option. See https://github.com/vuejs/rfcs/blob/9f18645a700f54e7d9a4e3b53046d48791e31459/active-rfcs/0009-global-api-change.md#global-api-mapping | 2020-04-23T07:45:59 | 2020-04-23T07:46:08 | {} | MEMBER |
vuejs | core | 619,420,434 | 1,048 | ycmjason | Got the same error.
I believe the error came from https://github.com/vuejs/vue-next/blob/0bb1f67d12b4a7d7ae2fe1d94883333bf736aa13/packages/runtime-dom/src/modules/props.ts#L35
I think it is trying to set the `srcObject` to `''` when the value is nullish.
Can't seem to find any logic around the `.prop` flag so ... | 2020-04-25T18:18:12 | 2020-04-25T18:20:27 | {} | CONTRIBUTOR |
vuejs | core | 619,422,759 | 1,048 | jonaskuske | Here's a repro btw, might want to add it to the issue description:
https://codepen.io/21stCenturyJonas/pen/JjYNjZX | 2020-04-25T18:36:40 | 2020-04-25T18:36:47 | {} | CONTRIBUTOR |
vuejs | core | 620,337,063 | 1,066 | Tan90Qian | I find the reason! Vue has automatic dependency collection for template.I change the state in outer hook but it was not used in template or render. So the component will not update...
It was depressing that I can't know what will be returned from a public hook, so that I can't give the returned value to template.
Ho... | 2020-04-28T02:19:50 | 2020-04-28T02:26:46 | {} | NONE |
vuejs | core | 621,816,827 | 1,080 | thecrypticace | The primary intent for async setup and async components is to allow components time to initialize because they don't have everything they need ready to be set up. An example would be if you are using code splitting in your application amd your component has to go fetch CSS, JS, or other assets over the network. There a... | 2020-04-30T12:56:15 | 2020-04-30T12:56:15 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 622,387,839 | 1,067 | yyx990803 | This should a good first PR opportunity: https://github.com/vuejs/vue-next/blob/master/packages/shared/src/index.ts#L116 | 2020-05-01T13:27:49 | 2020-05-01T13:27:49 | {
"+1": 4
} | MEMBER |
vuejs | core | 618,228,655 | 993 | jods4 | @pikax that's fine, I figured there had to be a reason why `defineComponent` isn't returning the real type.
From a public API perspective, can I suggest that you do a bit of renaming type? Can `Component` be the public, usable type (i.e. the current `PublicAPIComponent`); and the current `Component` becomes some `Co... | 2020-04-23T07:23:43 | 2020-04-23T07:23:43 | {} | CONTRIBUTOR |
vuejs | core | 619,139,755 | 1,032 | yyx990803 | This should make [PublicAPIComponent](https://github.com/vuejs/vue-next/blob/master/packages/runtime-core/src/component.ts#L78) unnecessary, right? | 2020-04-24T17:14:04 | 2020-04-24T17:14:04 | {} | MEMBER |
vuejs | core | 619,931,781 | 1,063 | bekalshenoy | Using Computed Like This Solve The Problem But It Will Be More Code When Using This Way Many Times
| 2020-04-27T11:47:38 | 2020-04-27T11:47:38 | {} | CONTRIBUTOR |
vuejs | core | 619,987,815 | 1,064 | bekalshenoy | Thanks, Closing This Issue | 2020-04-27T13:31:44 | 2020-04-27T13:31:44 | {} | CONTRIBUTOR |
vuejs | core | 620,075,837 | 1,066 | Tan90Qian | I change it and the test case was working!
But I found when I use `createApp` and `h` to test a custom hook, the `onUpdated` lifecycle will not work after I change reactive state.
[here](https://github.com/vuejs/vue-next/blob/master/packages/runtime-core/__tests__/apiLifecycle.spec.ts#L93) uses `nodeOps` to create... | 2020-04-27T15:57:23 | 2020-04-27T16:11:45 | {} | NONE |
vuejs | core | 622,343,721 | 1,091 | ysj16 | The state will be covered by ref in [setRef-L1930](https://github.com/vuejs/vue-next/blob/master/packages/runtime-core/src/renderer.ts#L1930)(I wonder the reason for that), and then will call [warn](https://github.com/vuejs/vue-next/blob/master/packages/runtime-core/src/componentProxy.ts#L198) in componentProxy recursi... | 2020-05-01T10:55:53 | 2020-05-01T10:55:53 | {} | CONTRIBUTOR |
vuejs | core | 618,389,554 | 1,039 | jakedohm | Also, I looked through the Vue RFCs repo to see if <component> had changed and couldn't find anything, but if it has this could be related to that 👍 | 2020-04-23T13:01:21 | 2020-04-23T13:01:21 | {} | NONE |
vuejs | core | 620,524,654 | 1,070 | bekalshenoy | Delete `shims-tsx.d.ts` In Your `src` Folder | 2020-04-28T10:35:25 | 2020-04-28T10:37:37 | {
"+1": 4
} | CONTRIBUTOR |
vuejs | core | 620,668,513 | 802 | himself65 | And I think this issue won't fix. See https://github.com/vuejs/vue-next/pull/991#issuecomment-616800766 | 2020-04-28T15:12:23 | 2020-04-28T15:12:23 | {} | CONTRIBUTOR |
vuejs | core | 621,719,418 | 1,083 | pikax | I would say this is an intended behaviour, since we are bailing the types `Node | Window` on https://github.com/vuejs/vue-next/blob/master/packages/reactivity/src/ref.ts#L142
There's the original issue: https://github.com/vuejs/vue-next/issues/951
EDIT: If adding `dom` is not an option, you can declare `Window` a... | 2020-04-30T09:24:44 | 2020-04-30T09:32:58 | {
"+1": 1
} | MEMBER |
vuejs | core | 619,585,573 | 1,033 | elevatebart | Hello @DanielRosenwasser,
Does TypeScript have a solution to deal with JSX ambient types conflicting?
I tried using the `"types":[]` trick without luck.
I tried using the `paths: {}` trick to redirect retrieval of types to another object but since types are ambient there is still a conflict.
What solutions do y... | 2020-04-26T17:00:41 | 2020-04-26T17:00:41 | {} | CONTRIBUTOR |
vuejs | core | 619,987,490 | 1,064 | bekalshenoy | @mathe42 Then How To Give A Interface As A Type In Props. So I Can Give Type Also To Its Children | 2020-04-27T13:31:11 | 2020-04-27T13:43:26 | {} | CONTRIBUTOR |
vuejs | core | 622,099,351 | 1,082 | lzhoucs | Thanks for the help so far. I feel like somehow the modified vnodes(`Tab`) are not getting picked up or dropped when they are not the direct children of `Tabs`, in my case `_Tabs` being the layer in between. Modifying them as direct children works which is what I did in my 2nd example above: https://codepen.io/lzhoucs/... | 2020-04-30T20:41:58 | 2020-04-30T20:41:58 | {} | NONE |
vuejs | core | 619,363,955 | 1,036 | jods4 | @yyx990803 About `this`: I have not opened a suggestion yet because I can't make this work _fully_, but there's stuff that already works today and stuff that _could_ be made to work if we wanted to, that makes simple components nicer.
Consider the classical "counter" example:
```js
setup() {
const state = react... | 2020-04-25T11:21:19 | 2020-04-25T11:21:19 | {
"+1": 3
} | CONTRIBUTOR |
vuejs | core | 619,499,863 | 1,053 | yyx990803 | This is caused by `v-model`'s event handler (inline handlers): [template compile result](https://vue-next-template-explorer.netlify.app/#%7B%22src%22%3A%22%3CInput%20v-model%3Aval%3D%5C%22val1%5C%22%20key%3D%5C%221%5C%22%2F%3E%22%2C%22ssr%22%3Afalse%2C%22options%22%3A%7B%22mode%22%3A%22module%22%2C%22prefixIdentifiers%... | 2020-04-26T07:17:35 | 2020-04-26T07:17:35 | {
"+1": 1
} | MEMBER |
vuejs | core | 620,051,619 | 1,065 | yyx990803 | This is intentional. | 2020-04-27T15:17:46 | 2020-04-27T15:17:46 | {} | MEMBER |
vuejs | core | 620,755,689 | 1,073 | ddslavov | It is implemented like so
`@input="$emit('update:modelValue', $event.target.value)"`
This works for a v-model directive without an argument.
Something that tricked me from the rfc was the `onUpdate:modelValue` syntax, but you'd have to remember that in the new vnode structure, events are not nested on the `on: { .... | 2020-04-28T17:43:25 | 2020-04-28T17:48:58 | {
"+1": 1
} | NONE |
vuejs | core | 621,596,229 | 1,082 | underfin | ```
const Tabs = (props, {emit, slots}) => {
// ...
return children
}
```
Solution: You can should directly return children.
In https://github.com/vuejs/rfcs/pull/154.
```
Functional components without props declaration will have everything passed in as props. It will only have implicit fallthrough for cl... | 2020-04-30T03:49:30 | 2020-04-30T03:49:30 | {} | MEMBER |
vuejs | core | 621,834,081 | 1,080 | xland | @thecrypticace
It's so kind of you.
Your comments help me a lot.
Thank you very much.
| 2020-04-30T13:25:44 | 2020-04-30T13:25:44 | {} | NONE |
vuejs | core | 622,033,150 | 1,060 | yyx990803 | `markRaw` simply adds the item to a `WeakMap`, there really isn't too much of a perf cost - if any, it's not that different from a property existence check.
Native DOM nodes or any browser native objects are not observed because they wouldn't pass the `isObservableType` check - they'd return something like `[object ... | 2020-04-30T18:44:45 | 2020-04-30T18:44:45 | {} | MEMBER |
vuejs | core | 622,162,472 | 1,051 | ycmjason | https://github.com/vuejs/vue-next/pull/1092
Here is my attempt to fix. | 2020-04-30T22:58:18 | 2020-04-30T22:58:18 | {} | CONTRIBUTOR |
vuejs | core | 618,026,929 | 1,029 | yyx990803 | Thanks a lot for the PR, however, it did not address the root cause of the issue (in your branch the watcher doesn't register the correct values).
We can still use some of the tests to ensure behavior correctness - which can be made into a separate PR. | 2020-04-22T20:38:25 | 2020-04-22T20:38:25 | {
"+1": 1
} | MEMBER |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.