owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 648,020,842 | 1,431 | underfin | Yeah.It should inculde into this.I will update code. | 2020-06-23T09:22:06 | 2020-06-23T09:22:06 | {} | MEMBER |
vuejs | core | 649,349,969 | 1,366 | jods4 | @jacekkarczmarczyk
> since I use this values only for reading
Computed has is not about reading, it can be read/write, too.
It's a ref that uses computations rather than being a plain value itself: think get/set property instead of field.
What you're saying is that a readonly ref might make more sense: `T | r... | 2020-06-25T08:11:09 | 2020-06-25T08:11:09 | {} | CONTRIBUTOR |
vuejs | core | 649,387,295 | 1,366 | jods4 | What I meant is that -- as far as concepts go -- you can create writable computeds:
`let x = computed({ get: ..., set: ... })`
It looks like the type `ComputedRef<T>` is meant for the getter-only version.
Makes sense since a writable computed is exactly like `Ref` from the type-system perspective.
Then again t... | 2020-06-25T08:47:41 | 2020-06-25T08:47:41 | {} | CONTRIBUTOR |
vuejs | core | 649,663,844 | 1,430 | yyx990803 | Should be fixed by 2961e149 (unreleased) | 2020-06-25T16:10:36 | 2020-06-25T16:10:36 | {} | MEMBER |
vuejs | core | 649,704,890 | 1,428 | edison1105 | > If we were to follow the name conventions, the enums should be in `ALL_UPPERCASE`.
OK. | 2020-06-25T17:03:18 | 2020-06-25T17:03:18 | {} | MEMBER |
vuejs | core | 646,869,142 | 1,407 | posva | Transitions still need to be fully supported by Vue Router (check the readme).
BTW, regarding the issue, you are not even providing a code sample, it's quite hard to do anything | 2020-06-19T21:36:27 | 2020-06-19T21:36:27 | {} | MEMBER |
vuejs | core | 647,464,342 | 1,425 | seanfreemannutrien | regardless, in the codebox links i sent, i used data as a function not an object. . | 2020-06-22T11:43:14 | 2020-06-22T11:43:14 | {} | NONE |
vuejs | core | 647,672,597 | 1,429 | posva | Have you read https://github.com/vuejs/rfcs/blob/amend-optional-props/active-rfcs/0031-attr-fallthrough.md#v-on-listener-fallthrough?
The form wrapper will actually work in Vue 3 without the need of `inheritListeners` or `intheritAttrs` | 2020-06-22T17:33:57 | 2020-06-22T17:33:57 | {} | MEMBER |
vuejs | core | 647,117,796 | 1,414 | LinusBorg | Not 100% yet, but I think we have to extend `idNativeTag` to check against `app.context.isCustomElement`.
https://github.com/vuejs/vue-next/blob/e4dc03a8b17d5e9f167de6a62a645878ac7ef3e2/packages/runtime-dom/src/index.ts#L99-L106
It seems to me that we only use it in the compiler so far, so any custom element decl... | 2020-06-21T11:52:44 | 2020-06-21T11:52:44 | {} | MEMBER |
vuejs | core | 647,163,625 | 1,416 | yyx990803 | Thanks for the PR, but `hasOwnProperty` is semantically different from the `in` operator. The latter checks for properties on the prototype chain and this change can potentially lead to different behavior.
I also don't see the refactoring of the renderer code bringing real improvements - it alters the original flow ... | 2020-06-21T18:24:28 | 2020-06-21T18:24:28 | {} | MEMBER |
vuejs | core | 648,009,750 | 1,431 | sibbng | Is this PR covers this code too?
```html
<img src='data:image/svg+xml;utf8,<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" height="100" width="100"><circle cx="50" cy="50" r="40" stroke="black" stroke-width="3" fill="red" /></svg>'>
```
I'm getting same error on this too and it ... | 2020-06-23T09:00:46 | 2020-06-23T09:00:46 | {} | NONE |
vuejs | core | 648,712,232 | 1,439 | posva | It's worth noting string literals are not supported in IE | 2020-06-24T09:37:04 | 2020-06-24T09:37:04 | {} | MEMBER |
vuejs | core | 648,721,463 | 1,439 | Awen-hub | > It's worth noting string literals are not supported in IE
Does Vue3 compatible with IE? What about the Proxy Object used in createReactiveObject? And I also find others occasions using `${}` in the project.
| 2020-06-24T09:55:00 | 2020-06-24T09:55:00 | {} | NONE |
vuejs | core | 648,953,517 | 1,209 | LinusBorg | > I think it should pass...
No, it should fail.
`watch()` callbacks are run async, on the next Tick. Otherwise, each synchronous change of a watched reactive dependency would trigger the watcher, which in 99% of scenarios you don't want.
**this** test will pass:
```javascript
import { nextTick } from 'vue'... | 2020-06-24T17:19:25 | 2020-06-24T17:23:31 | {} | MEMBER |
vuejs | core | 648,967,943 | 1,209 | RobbinBaauw | If I run this test it fails (based on `34128939c5abc6b85ab82a270692509283066eda`):
`yarn test packages/runtime-core/__tests__/apiWatch.spec.ts -t "triggerRef with watch"`
```
● api: watch › triggerRef with watch
expect(received).toBe(expected) // Object.is equality
Expected: true
Received: fal... | 2020-06-24T17:45:19 | 2020-06-24T17:47:04 | {} | CONTRIBUTOR |
vuejs | core | 649,735,283 | 1,447 | LinusBorg | Docs will include that on release. I think it can be closed then. | 2020-06-25T18:05:02 | 2020-06-25T18:05:02 | {} | MEMBER |
vuejs | core | 646,900,217 | 1,408 | AlexandreBonaventure | This seems to be the same bug https://github.com/vuejs/vue-next/issues/1407
posva is saying the transition are not quite ready in vue-router | 2020-06-19T23:48:38 | 2020-06-19T23:48:38 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 647,348,098 | 1,414 | underfin | > Oh so we really only check during compile time? My mistake then.
Look it is for now and this will not generate code for customer component import and don't check it with runtime.
| 2020-06-22T07:48:52 | 2020-06-22T07:49:01 | {} | MEMBER |
vuejs | core | 649,169,064 | 1,442 | underfin | This is fixed by be69beed5ed05067006c297589598b33e7108b1b | 2020-06-25T02:02:29 | 2020-06-25T02:02:29 | {} | MEMBER |
vuejs | core | 649,336,891 | 1,366 | jacekkarczmarczyk | > They will typically read those input by doing unref(x)
All my usages of MaybeRef (so far 1 xd) are actually getting `T | ComputedRef<T>` since I use this values only for reading - it makes me think that `T | ComputedRef<T>` is actually a better idea.
Is there even a usecase when I would want to pass `T | Ref<T>... | 2020-06-25T07:57:58 | 2020-06-25T07:57:58 | {} | CONTRIBUTOR |
vuejs | core | 649,718,848 | 1,447 | bshepherdson | I hadn't tried `defineAsyncComponent` because I didn't know about it until right now. That almost certainly is the real answer here, since it handles the SFC case as well as this one.
The TS problem with having to cast the component is because the `FunctionComponent` variant doesn't have options like `components:` a... | 2020-06-25T17:30:47 | 2020-06-25T17:30:47 | {} | NONE |
vuejs | core | 649,746,428 | 1,430 | kightlingerh | Thanks @yyx990803, your work is very much appreciated!! | 2020-06-25T18:29:10 | 2020-06-25T18:29:10 | {} | NONE |
vuejs | core | 650,211,402 | 1,443 | yyx990803 | `instance.props` is not the source of truth since if an absent prop won't be set on it. We still need to use the normalized props options - the reason of the bug was we are only checking it when `type.props` is present - but when a component has props from mixins but no props declaration on itself it would be skipped.
... | 2020-06-26T14:33:37 | 2020-06-26T14:33:37 | {} | MEMBER |
vuejs | core | 645,705,318 | 1,359 | CyberAP | Vue supports runtime template compilation. Bringing support for TypeScript in templates would mean that you'll get different levels of template support for pre-compiled and post-compiled applications, which in result would complicate things for developers and maintainers. In the example above you could provide better t... | 2020-06-18T00:58:51 | 2020-06-18T00:58:51 | {} | CONTRIBUTOR |
vuejs | core | 647,462,391 | 1,425 | seanfreemannutrien | you are mistaken, data has to be a function if it's a component. and data is an object if you are creating a new instance. that should not change anything.
https://vuejs.org/v2/guide/components.html#data-Must-Be-a-Function
| 2020-06-22T11:38:55 | 2020-06-22T11:38:55 | {} | NONE |
vuejs | core | 648,832,785 | 1,439 | yyx990803 | From my tests, it seems the fastest would be simply replacing all `String(x)` with `x + ''`. | 2020-06-24T13:50:16 | 2020-06-24T13:50:16 | {} | MEMBER |
vuejs | core | 649,632,024 | 1,392 | yyx990803 | Multiple `hasOwn` checks are expensive, in addition, it's not entirely safe to skip these keys - for example, the user may add a new property named `map` to an object and this would cause it to not be tracked on the initial run when `map` is not on the object yet. | 2020-06-25T15:40:31 | 2020-06-25T15:40:31 | {} | MEMBER |
vuejs | core | 649,637,247 | 1,428 | yyx990803 | If we were to follow the name conventions, the enums should be in `ALL_UPPERCASE`. | 2020-06-25T15:48:30 | 2020-06-25T15:48:30 | {} | MEMBER |
vuejs | core | 647,460,727 | 1,425 | posva | For minimal state management, it's even easier with Vue 3 since you can use `ref` and `reactive` to create reactive objects and modify them anywhere while still consuming them in component templates by returning them in the `setup` function.
Note the documentation for Vue 2 is well, for Vue 2. So it's normal for some ... | 2020-06-22T11:35:04 | 2020-06-22T11:35:04 | {} | MEMBER |
vuejs | core | 647,466,323 | 1,408 | posva | I tried out the code locally and it works just fine. That being said transitions still need a few things to support `this` (same as KeepAlive). See https://github.com/vuejs/rfcs/pull/160 | 2020-06-22T11:47:42 | 2020-06-22T11:47:42 | {} | MEMBER |
vuejs | core | 647,958,632 | 1,209 | RobbinBaauw | I think `triggerRef` might not work with `watch` at all (outside of components). Added the following test case which fails:
```ts
test('triggerRef with watch', () => {
const a = ref(1)
let aTriggered = false
watch(a, () => {
aTriggered = true
})
triggerRef(a)
expect(aTriggered).... | 2020-06-23T07:19:42 | 2020-06-23T07:21:02 | {} | CONTRIBUTOR |
vuejs | core | 649,364,542 | 1,366 | jacekkarczmarczyk | > Computed has is not about reading, it can be read/write, too.
Well, not in this case:
Anyway you're right, I had readonly in mind, if you think that `readonly Ref<T>` is better than `ComputedRef<T>` t... | 2020-06-25T08:25:40 | 2020-06-25T08:26:17 | {} | CONTRIBUTOR |
vuejs | core | 649,739,713 | 1,175 | yyx990803 | #1151 has been merged - can you rebase on top of `master` and add appropriate tests? (Note I moved `Transition.spec.ts` into `vue/__tests__` | 2020-06-25T18:14:28 | 2020-06-25T18:14:28 | {} | MEMBER |
vuejs | core | 647,119,510 | 1,387 | LinusBorg | The issue is that you create a plain, non-reactive object here:
```javascript
const obj = {
name: 'test (2 child list items should show)',
items: [],
}
```
and then continue to mutate this plain, nonreactive object:
```javasacript
obj.items.push({ label:'item-1', score:1 })
```
In Vue 3, this cha... | 2020-06-21T12:08:22 | 2020-06-21T12:09:37 | {
"+1": 6,
"laugh": 1,
"rocket": 1
} | MEMBER |
vuejs | core | 647,467,333 | 1,425 | seanfreemannutrien | the only thing vuejs could do until now that none other frameworks could do is that feature, where you can share state amazing across multiple component where that state object is just es6 module, now that's gone from vue3. it's sad. nice job guys. | 2020-06-22T11:50:04 | 2020-06-22T11:50:04 | {} | NONE |
vuejs | core | 647,715,300 | 1,414 | sonicoder86 | I've tried this
```javascript
config.module
.rule('vue')
.use('vue-loader')
.loader('vue-loader')
.tap(options => {
options.compilerOptions = {
...(options.compilerOptions || {}), // merge existing compilerOptions, if any
isCustomElement: tag => /^e-/.test(... | 2020-06-22T19:01:27 | 2020-06-22T19:01:39 | {} | NONE |
vuejs | core | 648,048,007 | 1,426 | underfin | @jods4 Sorry for I'm not completely get your first said =.=
> When comparing vnodes, instead of using the patchFlags from the new node only, combine it with the patchFlags from previous node.
This is necessary with use patchFlags from the new node. Example, the previous node is a element but the new node is a c... | 2020-06-23T10:15:21 | 2020-06-23T10:23:04 | {} | MEMBER |
vuejs | core | 648,979,327 | 1,209 | RobbinBaauw | Some excerpts from the codebase I'm working on:
```ts
function onClickNow() {
manualScrollStartX.value = 0;
triggerRef(manualScrollStartX);
}
```
```ts
watch(manualScrollStartX, (x) => {
// Something with this scroll
});
```
The value of `manualScrollStartX` may or may not be 0 already, but in... | 2020-06-24T18:06:20 | 2020-06-24T18:06:20 | {} | CONTRIBUTOR |
vuejs | core | 649,189,293 | 1,442 | kagurakana | Wow, awsome! thank you. | 2020-06-25T03:15:48 | 2020-06-25T03:15:48 | {} | NONE |
vuejs | core | 656,212,486 | 1,556 | yyx990803 | Please read the RFC: https://github.com/vuejs/rfcs/blob/master/active-rfcs/0011-v-model-api-change.md | 2020-07-09T16:01:16 | 2020-07-09T16:01:16 | {
"+1": 8
} | MEMBER |
vuejs | core | 657,665,289 | 1,571 | yyx990803 | see 65beba98
This check must be done using the flags on the slots object because the slots may get passed down the nested child components. | 2020-07-13T16:38:08 | 2020-07-13T16:38:08 | {
"eyes": 1
} | MEMBER |
vuejs | core | 658,070,334 | 1,580 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [ci/circleci: test](https://circleci.com/gh/vuejs/vue-next/6927?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
Dependabot will still automatically merge this pull request if you amend it and your test... | 2020-07-14T09:15:08 | 2020-07-14T09:15:08 | {} | CONTRIBUTOR |
vuejs | core | 658,082,056 | 1,577 | Akimotorakiyu | @thecrypticace OK | 2020-07-14T09:40:09 | 2020-07-14T09:40:09 | {} | NONE |
vuejs | core | 658,260,701 | 1,578 | yyx990803 | Ah, thanks, didn't see this when I was working on 380c6792 | 2020-07-14T15:53:55 | 2020-07-14T15:53:55 | {} | MEMBER |
vuejs | core | 658,608,833 | 1,498 | pikax | @sodatea Thank you :)
There's the fix: https://github.com/vuejs/vue-next/pull/1584 | 2020-07-15T07:54:32 | 2020-07-15T07:54:32 | {} | MEMBER |
vuejs | core | 658,867,789 | 1,592 | yyx990803 | GitHub seems to be stuck checking the merge conflict - I cherry picked this in 9146cc48 - Thanks! | 2020-07-15T16:32:46 | 2020-07-15T16:32:46 | {} | MEMBER |
vuejs | core | 659,145,298 | 1,458 | Picknight | Has been cleaned up in [[chore: remove outdated options]](https://github.com/vuejs/vue-next/commit/4535b1bde88d760ba9aa00656f98a5aa57ea949b). | 2020-07-16T04:06:18 | 2020-07-16T04:06:18 | {} | CONTRIBUTOR |
vuejs | core | 655,192,083 | 1,532 | CyberAP | Converting this into a higher-order function with `effect` (as proposed above) could potentially solve the problem:
```js
export const createEffectComposable = (ref = ref(null)) => {
const _effect = effect(() => {
// ...
})
const _stop = () => stop(effect)
return () => { ref, stop: _stop }
}
```
... | 2020-07-07T23:29:21 | 2020-07-07T23:35:20 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 655,626,305 | 1,542 | yyx990803 | This should actually be disallowed - Vue 2 already warns against such cases. See 5e52f4e4 | 2020-07-08T16:32:44 | 2020-07-08T16:32:44 | {} | MEMBER |
vuejs | core | 657,129,277 | 1,227 | RobbinBaauw | Hm okay, I disagree with that sentiment as said above but that sounds like a similar proposal. I think 1 layer of auto unref would be perfect (and doable without proxies), and I can envision a multitude of "layer 8" issues related to the current behavior popping up once the masses start to use Vue 3 :smile: (just as mi... | 2020-07-11T21:01:46 | 2020-07-12T08:23:58 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 657,391,890 | 1,569 | Picknight | You seem to reduce two function expressions, but added two arrow functions. The actual difference is very small. | 2020-07-13T06:55:21 | 2020-07-13T06:55:21 | {} | CONTRIBUTOR |
vuejs | core | 657,530,697 | 1,574 | posva | Can you give more specific details like code samples pleas?. don't follow the feature request template when reporting a bug | 2020-07-13T12:26:10 | 2020-07-13T12:26:10 | {} | MEMBER |
vuejs | core | 658,689,167 | 1,569 | zhangenming | 都是自己人而且已经关闭了, 那我就说中文了哈....
一个箭头函数的成本真的和一个完整函数体的成本是一样的或者相近的吗 这点我挺吃惊的 谢谢
另外一点 把函数提出来而不是作为变量嵌在里面是不是可读更高呢
如果我这样改会不会好点呢 谢谢 https://github.com/zhangenming/vue-next/commit/ad80018109ca138be3c304a556c61c7cb4a8ccfd
可能是我强迫症了吧 | 2020-07-15T10:30:20 | 2020-07-15T10:30:20 | {} | CONTRIBUTOR |
vuejs | core | 658,788,177 | 1,587 | tangjinzhou | @yyx990803 @HcySunYang
This is not just a key issue, even if the same key, the child node should be updated.
Like:
```html
<span v-if="value%2 === 0" key="1">world</span>
<span v-if="value%2 !== 0" key="1">hello</span>
``` | 2020-07-15T14:05:00 | 2020-07-15T14:06:29 | {} | CONTRIBUTOR |
vuejs | core | 658,879,900 | 1,458 | jods4 | There might be some clean up left to do.
`computed` is still exposed in `ReactiveEffectOptions`, although it's not used anymore:
https://github.com/vuejs/vue-next/blob/master/packages/reactivity/src/effect.ts#L24
And it's set by `apiWatch`, to no effect:
https://github.com/vuejs/vue-next/blob/58b07069ad33c8a8e... | 2020-07-15T16:54:15 | 2020-07-15T16:54:15 | {} | CONTRIBUTOR |
vuejs | core | 656,175,979 | 1,556 | fawmi | I don't know whether it is expected behavior or not, but it works, when specifying a model
`v-model:value="state.someText"
`
| 2020-07-09T14:53:39 | 2020-07-09T14:53:54 | {
"+1": 3
} | NONE |
vuejs | core | 658,240,590 | 1,227 | basvanmeurs | First of all, I am completely with @RobbinBaauw on this one. I'd like to see the reactive setupState being changed to shallowReactive.
The recursive feature of the setup state's reactive proxy just feels like it's doing more than it should. Really, why are my instances turning into proxies by just returning them in ... | 2020-07-14T15:17:04 | 2020-07-14T15:17:30 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 658,260,383 | 1,581 | yyx990803 | @dependabot rebase | 2020-07-14T15:53:20 | 2020-07-14T15:53:20 | {
"+1": 1
} | MEMBER |
vuejs | core | 655,370,140 | 1,462 | Picknight | Done. @yyx990803 | 2020-07-08T08:24:47 | 2020-07-08T08:24:47 | {} | CONTRIBUTOR |
vuejs | core | 655,514,100 | 1,539 | yyx990803 | Vue 3 SFC currently doesn't support scoped styles for manually render functions, for now you have to either use templates or CSS modules. | 2020-07-08T13:18:40 | 2020-07-08T13:18:40 | {} | MEMBER |
vuejs | core | 656,049,344 | 1,555 | underfin | See https://github.com/vuejs/rfcs/blob/global-api-change/active-rfcs/0009-global-api-change.md :) | 2020-07-09T10:33:14 | 2020-07-09T10:33:14 | {} | MEMBER |
vuejs | core | 658,070,754 | 1,581 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [ci/circleci: test](https://circleci.com/gh/vuejs/vue-next/6928?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
Dependabot will still automatically merge this pull request if you amend it and your test... | 2020-07-14T09:16:00 | 2020-07-14T09:16:00 | {} | CONTRIBUTOR |
vuejs | core | 655,367,902 | 1,545 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [ci/circleci: test](https://circleci.com/gh/vuejs/vue-next/6769?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
Dependabot will still automatically merge this pull request if you amend it and your test... | 2020-07-08T08:20:33 | 2020-07-08T08:20:33 | {} | CONTRIBUTOR |
vuejs | core | 655,385,351 | 1,462 | jacekkarczmarczyk | As far as i understand before this PR you could do
```ts
r.obj.k = 'x'
```
and now you can't
How can I now create shallow readonly variable so that
```ts
r.obj = {}; // should fail
r.obj.k = 'x'; // should work
```
?
> This is not a new feature
Maybe it should a new feature? Or is shallow readonly con... | 2020-07-08T08:53:29 | 2020-07-08T08:53:29 | {} | CONTRIBUTOR |
vuejs | core | 655,612,181 | 1,502 | yyx990803 | This adds quite a bit of extra logic - it'd be nice to see a benchmark of how this affects the cases it's optimizing for, and whether it affects other common cases. | 2020-07-08T16:06:15 | 2020-07-08T16:06:15 | {} | MEMBER |
vuejs | core | 655,664,438 | 1,539 | aztalbot | I ran into the same issue. I wasn't so much surprised that it wasn't supported, more so that it seems the `data-v-<scopeId>` attribute on the nodes were suffixed with `-s` and removing the suffix was enough to apply the styles. The [comment](https://github.com/vuejs/vue-next/blob/58b07069ad33c8a8e44cb47b81084a452dda284... | 2020-07-08T17:48:17 | 2020-07-08T17:50:19 | {
"+1": 10
} | CONTRIBUTOR |
vuejs | core | 657,190,089 | 1,567 | janispritzkau | That's roughly how it could be fixed by iterating over both the previous and next values in the `patchEvent` function:
https://github.com/vuejs/vue-next/compare/master...janispritzkau:multiple-event-listener-options | 2020-07-12T08:17:29 | 2020-07-12T08:30:05 | {} | NONE |
vuejs | core | 657,744,084 | 1,359 | phroggyy | I think there is an alternate use case here which is usage of syntax that is in TS but not necessarily in the ES standard yet. Null coalescing and the elvis operator are both things I feel are missing.
*However*, I don't think a blanket "support TS in templates" might be the best solution. The ideal solution would b... | 2020-07-13T19:20:07 | 2020-07-13T19:20:07 | {} | NONE |
vuejs | core | 658,400,426 | 1,569 | yyx990803 | ^ what @Picknight said. | 2020-07-14T20:37:19 | 2020-07-14T20:37:32 | {} | MEMBER |
vuejs | core | 658,736,894 | 1,569 | Picknight | 1. About arrow funtion's performance, see [stackoverflow](https://stackoverflow.com/questions/44030645/are-arrow-functions-faster-more-performant-lighter-than-ordinary-standalone-f).
2. Regarding code readability, frankly speaking, I think the difference is not much. | 2020-07-15T12:25:40 | 2020-07-15T12:25:40 | {} | CONTRIBUTOR |
vuejs | core | 658,797,290 | 1,587 | HcySunYang | To be honest, this is a wrong usage.
if the users specify the key manually, it is possible to break the block-tree assumption, should we prevent users from doing that? Or give a warning? 🤔
| 2020-07-15T14:20:28 | 2020-07-15T14:24:38 | {} | MEMBER |
vuejs | core | 659,318,903 | 1,056 | johnsoncodehk | ```javascript
import { getCurrentInstance } from "vue";
setup() {
const instance = getCurrentInstance();
instance.proxy. // == context.root
}
``` | 2020-07-16T10:19:25 | 2020-07-16T10:19:25 | {
"+1": 11
} | MEMBER |
vuejs | core | 659,422,598 | 1,600 | Justineo | Actually I’ve been thinking maybe we should have a `jsx` mode which completely align with JSX, so that white spaces handling can be consistent across projects where template and JSX are mixed. In v2 the `condense` mode still have trivial differences with JSX. WDYT? @yyx990803 | 2020-07-16T13:45:28 | 2020-07-16T13:45:28 | {} | MEMBER |
vuejs | core | 656,445,403 | 1,558 | underfin | The `TransitionWrapper` need pass `slots` into `Transition`.Use below code inside TransitionWrapper steup
```js
return () => h(Transition, { css: false, onEnter }, slots)
```
| 2020-07-10T02:28:18 | 2020-07-10T02:29:00 | {} | MEMBER |
vuejs | core | 658,765,207 | 1,590 | zhangenming | YES you are right, i know it , THANKS
but i want to know Why do you have to keep it in the wrong order,
It's because doesn't actually matter? | 2020-07-15T13:24:02 | 2020-07-15T13:25:07 | {} | CONTRIBUTOR |
vuejs | core | 658,773,480 | 1,563 | yyx990803 | Thanks for the PR. This function has more comprehensive coverage from #379. | 2020-07-15T13:38:48 | 2020-07-15T13:38:48 | {} | MEMBER |
vuejs | core | 659,011,880 | 1,583 | michaeltintiuc | Thank you @underfin just tested it with several scenarios with latest release, works like a charm! :heart: | 2020-07-15T21:09:48 | 2020-07-15T21:09:48 | {} | NONE |
vuejs | core | 659,131,255 | 1,587 | yyx990803 | In Vue 3 you should never do this. There's no convincing reason to force the same key on two branches. We should throw warnings if the user tries to do this. | 2020-07-16T03:12:07 | 2020-07-16T03:12:44 | {} | MEMBER |
vuejs | core | 655,607,563 | 1,541 | pearofducks | Friggin awesome - thanks @yyx990803 !! | 2020-07-08T15:57:54 | 2020-07-08T15:57:54 | {} | NONE |
vuejs | core | 655,608,405 | 1,484 | yyx990803 | Hmm, I'm not sure about this. It should only warn for rendering since using undefined properties in rendering is probably unintended, but accessing a non-existent property `this.x` in a lifecycle hook should behave the same like in v2 (no warning) | 2020-07-08T15:59:30 | 2020-07-08T15:59:30 | {} | MEMBER |
vuejs | core | 656,017,518 | 1,554 | vue-bot | Hello, thank you for taking time filling this issue!
However, we kindly ask you to use our [Issue Helper](https://new-issue.vuejs.org/?repo=vuejs/vue-next) when creating new issues, in order to ensure every issue provides the necessary information for us to investigate. This explains why your issue has been automatic... | 2020-07-09T09:24:47 | 2020-07-09T09:24:47 | {} | CONTRIBUTOR |
vuejs | core | 656,120,681 | 1,552 | yyx990803 | This is expected behavior. The tracking mechanism for Array mutation changed in Vue 3, the behavior is different **but it is correct and is now more efficient.** It doesn't need to run the getter because its return value does not rely on anything that would be mutated by `push`. | 2020-07-09T13:15:59 | 2020-07-09T13:15:59 | {} | MEMBER |
vuejs | core | 656,475,960 | 1,558 | pearofducks | @underfin - using that code in my reproduction still doesn't call the `onEnter` hook
Here's a fork with your suggested edit - https://jsfiddle.net/4cv2s0re/ | 2020-07-10T04:29:49 | 2020-07-10T04:30:36 | {} | NONE |
vuejs | core | 657,157,984 | 1,553 | wonderful-panda | Thank you. I've overlooked it. | 2020-07-12T01:12:27 | 2020-07-12T01:12:27 | {} | CONTRIBUTOR |
vuejs | core | 657,667,023 | 1,568 | yyx990803 | If a target object's `depsMap` exists, it must be non-empty (since the map is only created when a key is tracked) so the check is unnecessary. | 2020-07-13T16:41:36 | 2020-07-13T16:41:59 | {} | MEMBER |
vuejs | core | 658,069,212 | 1,579 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [ci/circleci: test](https://circleci.com/gh/vuejs/vue-next/6924?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
Dependabot will still automatically merge this pull request if you amend it and your test... | 2020-07-14T09:12:46 | 2020-07-14T09:12:46 | {} | CONTRIBUTOR |
vuejs | core | 658,260,195 | 1,579 | yyx990803 | @dependabot rebase | 2020-07-14T15:53:00 | 2020-07-14T15:53:00 | {
"+1": 1
} | MEMBER |
vuejs | core | 658,550,984 | 1,498 | haoqunjiang | This change seems to have broken `vue-class-component`.
Cc: @ktsn | 2020-07-15T05:17:00 | 2020-07-15T05:17:00 | {} | MEMBER |
vuejs | core | 658,712,667 | 1,589 | HcySunYang | For elements(nodes) with `v-if/v-if-else/v-else` at the same level(siblings), generate incremental keys for them so that they are always different. | 2020-07-15T11:25:00 | 2020-07-15T11:25:00 | {} | MEMBER |
vuejs | core | 655,372,007 | 1,462 | jacekkarczmarczyk | this looks like a breaking change? | 2020-07-08T08:27:49 | 2020-07-08T08:27:49 | {} | CONTRIBUTOR |
vuejs | core | 655,846,203 | 1,547 | baihuibo | So I want an entry to get the current binding instance, and now I need to
```vue
<template>
<comp v-foo/>
<div v-foo/>
</template>
```
```js
const fooDirective = {
mounted(el, {instance}, vNode) {
const childNode = instance.$.subTree.dynamicChildren.find(child => child.el === el);
... | 2020-07-09T01:44:12 | 2020-07-09T01:44:12 | {} | NONE |
vuejs | core | 657,199,241 | 1,568 | posva | Worth noting the yarn size script failed (https://app.circleci.com/pipelines/github/vuejs/vue-next/3361/workflows/0fca983f-5bd8-4045-83a2-e10be5399209/jobs/6862/steps) but reported a passing test on CircleCI | 2020-07-12T09:49:38 | 2020-07-12T09:49:38 | {} | MEMBER |
vuejs | core | 658,148,302 | 1,518 | Hisioni | why not use vue-router hooks | 2020-07-14T12:22:03 | 2020-07-14T12:22:03 | {} | NONE |
vuejs | core | 657,664,892 | 1,559 | yyx990803 | see 65beba98 | 2020-07-13T16:37:19 | 2020-07-13T16:37:19 | {} | MEMBER |
vuejs | core | 659,413,503 | 1,595 | basvanmeurs | @yyx990803 @jods4 @RobbinBaauw
Even though the commit https://github.com/vuejs/vue-next/commit/165068dbc295bb70fdec9ae56dfcaac17d2f977c by @yyx990803 mitigates the problem it doesn't fix it for multi-iteration effect queue drains.
My proposition is to add a new flush mode in the WatcherOptions named 'final', whi... | 2020-07-16T13:31:07 | 2020-07-16T13:31:07 | {} | CONTRIBUTOR |
vuejs | core | 655,436,514 | 1,541 | pearofducks | Not completely clear on what you're describing. :)
If this is supposed to be mitigated by the user, IMO this should be explicitly documented - and it'd be great to know what changes I can make in the meantime.
IMO this should not be under use control, since it's both a regression vs. Vue 2, and the different beha... | 2020-07-08T10:35:00 | 2020-07-08T11:07:09 | {} | NONE |
vuejs | core | 655,419,222 | 1,541 | underfin | This caused by the `length` is untrunst value for `Transition` call `leave` hook. The hook is wrapped and cacheabled (compiled code is ` (_cache[1] = ($event, ...args) => (_ctx.onLeave($event, ...args))`).The same as happend in `js`.
So, I think it should be a break change and it should under user control.We don'... | 2020-07-08T09:57:32 | 2020-07-08T11:35:32 | {} | MEMBER |
vuejs | core | 655,843,201 | 1,541 | underfin | @yyx990803 .This also happened with blew code.
``` js
onLeave: (...arg) => {
const [el, done] =arg
el.style.backgroundColor = 'red'
setTimeout(done, 10000)
}
``` | 2020-07-09T01:33:45 | 2020-07-09T01:34:03 | {} | MEMBER |
vuejs | core | 657,228,478 | 1,570 | posva | `FunctionalComponent` is a generic that takes the props interface as the first type. Take a look at the existing test: https://github.com/vuejs/vue-next/blob/a5b4332c69146de569ad328cac9224c3cded15c9/test-dts/functionalComponent.test-d.tsx#L18-L21 | 2020-07-12T14:21:28 | 2020-07-12T14:22:10 | {
"+1": 1
} | MEMBER |
vuejs | core | 657,913,012 | 1,568 | Akimotorakiyu | @yyx990803 ,have a look with this example:
```ts
const reactiveValue = reactive({ value: 1 });
const reactiveEffect = effect(() => {
console.log("reactiveValue", reactiveValue.value);
});
// depsMap is not none, the size is 1
stop(reactiveEffect);
// depsMap is not none, but the size is 0
```
**and in c... | 2020-07-14T01:27:26 | 2020-07-14T01:27:51 | {} | NONE |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.