owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 603,557,867 | 876 | rigor789 | I'll give it a try and report back! | 2020-03-24T23:30:54 | 2020-03-24T23:30:54 | {} | CONTRIBUTOR |
vuejs | core | 608,394,335 | 904 | a631807682 |
> This is not a bug, just a warn in **DEV**
> because when you use multiple children template, the vue will wrap a Fragment around it.
There are two nodes in the example, one is the comment and the other is the element, and I think in this case the user wants to pass attributes to the element node, rather t... | 2020-04-03T11:59:56 | 2020-04-03T11:59:56 | {} | CONTRIBUTOR |
vuejs | core | 609,049,172 | 919 | yyx990803 | Why would you even add both the original and the observed version of the same object as keys in the same map?
The basic rule of thumb when using v3's reactivity system is if you intend to make something reactive, create the reactive version directly and work only with the reactive version. Forget about the original.... | 2020-04-04T15:56:34 | 2020-04-04T16:03:04 | {
"+1": 1
} | MEMBER |
vuejs | core | 609,067,801 | 910 | jods4 | I'll try to see if I can come up with another repro... really not sure which bits are responsible for the problem after alpha.11 | 2020-04-04T18:09:07 | 2020-04-04T18:09:07 | {} | CONTRIBUTOR |
vuejs | core | 603,510,170 | 876 | yyx990803 | Yes, that's correct | 2020-03-24T21:18:38 | 2020-03-24T21:18:38 | {} | MEMBER |
vuejs | core | 603,537,698 | 876 | yyx990803 | Actually, since element vnodes can now accept slots as children, your approach of exporting a custom `resolveComponent` from your runtime should already work, maybe we don't need the option at all. | 2020-03-24T22:28:19 | 2020-03-24T22:28:19 | {} | MEMBER |
vuejs | core | 606,541,310 | 901 | posva | I think this is expected: you need to explicitly pass a `ref` object:
```js
reactive({
ref: ref(null)
})
``` | 2020-03-31T10:34:14 | 2020-03-31T10:34:14 | {} | MEMBER |
vuejs | core | 606,657,986 | 902 | posva | You must use lowercase and non self-closing when using in-browser templates:
```html
<div id="app">
<div ref="div">div</div>
<foo ref="foo"></foo>
</div>
```
That plus the mentioned typo and things work 🙂 | 2020-03-31T14:19:59 | 2020-03-31T14:19:59 | {} | MEMBER |
vuejs | core | 608,429,153 | 912 | yyx990803 | @cexbrayat yeah that should be removed too, thanks for spotting it. | 2020-04-03T13:20:14 | 2020-04-03T13:20:14 | {} | MEMBER |
vuejs | core | 609,079,961 | 923 | yyx990803 | I don't really understand why you'd write code that is shown in the repro, but that's not how `v-model` is designed to be used. The `vModelText` directive is strictly internal and assumes compiler usage only. Note not everything exported on Vue is part of the public API. | 2020-04-04T19:46:39 | 2020-04-04T19:46:39 | {} | MEMBER |
vuejs | core | 601,824,319 | 858 | yyx990803 | Yes, you will have to store the previous value yourself if you are using `@vue/reactivity`. | 2020-03-20T17:31:38 | 2020-03-20T17:31:38 | {} | MEMBER |
vuejs | core | 602,977,399 | 827 | himself65 | add the script on `pretest`? | 2020-03-24T02:42:56 | 2020-03-24T02:42:56 | {} | CONTRIBUTOR |
vuejs | core | 603,853,842 | 873 | shshaw | Confirming that the latest release (3.0.0-alpha.10) solved this. Thank you for the quick response! | 2020-03-25T13:57:07 | 2020-03-25T13:57:07 | {} | NONE |
vuejs | core | 605,869,126 | 896 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [ci/circleci: test](https://circleci.com/gh/vuejs/vue-next/3619?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
Dependabot will still automatically merge this pull request if you amend it and your test... | 2020-03-30T08:52:00 | 2020-03-30T08:52:00 | {} | CONTRIBUTOR |
vuejs | core | 607,339,678 | 906 | posva | Great! I don't know if that's the right fix but it would be nice if it had some unit tests | 2020-04-01T16:04:26 | 2020-04-01T16:04:26 | {} | MEMBER |
vuejs | core | 611,972,116 | 945 | mika76 | Ah I see - brilliant - thanks! | 2020-04-10T10:15:46 | 2020-04-10T10:15:46 | {} | NONE |
vuejs | core | 612,067,197 | 635 | yyx990803 | FYI this has been removed in 55566e8f (see commit message for details) | 2020-04-10T15:00:12 | 2020-04-10T15:00:12 | {
"confused": 1
} | MEMBER |
vuejs | core | 601,987,424 | 861 | rigor789 | `optionMergeStrategies` is used for mixins in 2.x. As far as I'm aware, mixins are completely replaced by the composition API in 3.x and the option is no longer needed. | 2020-03-21T03:33:00 | 2020-03-21T03:33:00 | {} | CONTRIBUTOR |
vuejs | core | 602,143,330 | 835 | jiangying000 | close since potential performance issue. | 2020-03-22T03:42:58 | 2020-03-22T03:42:58 | {} | CONTRIBUTOR |
vuejs | core | 603,712,211 | 878 | posva | `version` is already exported by `vue`:
```js
import { version } from 'vue'
``` | 2020-03-25T08:38:14 | 2020-03-25T08:38:14 | {} | MEMBER |
vuejs | core | 607,337,276 | 906 | ysj16 | The three elements will perform the same way with #794 (with key) | 2020-04-01T16:00:22 | 2020-04-01T16:01:32 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 608,367,407 | 904 | jaskang | This is not a bug, just a warn in __DEV__
because when you use multiple children template, the vue will wrap a Fragment around it. | 2020-04-03T10:49:01 | 2020-04-03T10:49:01 | {} | NONE |
vuejs | core | 609,058,014 | 919 | yyx990803 | The expected behavior is fixed, but you should still avoid having both the raw and observed versions of the same object as keys in the same map. It can lead to rather ambiguous behavior and should definitely be avoided. (a warning is added for such cases) | 2020-04-04T16:58:34 | 2020-04-04T16:59:01 | {} | MEMBER |
vuejs | core | 610,181,664 | 937 | vue-bot | Hello, thank you for taking time filling this issue!
However, we kindly ask you to use our [Issue Helper](https://new-issue.vuejs.org/?repo=vuejs/vue-next) when creating new issues, in order to ensure every issue provides the necessary information for us to investigate. This explains why your issue has been automatic... | 2020-04-07T05:27:06 | 2020-04-07T05:27:06 | {} | CONTRIBUTOR |
vuejs | core | 611,802,505 | 677 | jonaskuske | @yyx990803 There's a regression in the latest alpha, the repro from above (https://codepen.io/21stCenturyJonas/pen/ZEYdOBg, updated it to use `alpha.12`) is failing again.
It works when going back to `alpha.11`. | 2020-04-09T23:34:26 | 2020-04-09T23:34:26 | {} | CONTRIBUTOR |
vuejs | core | 602,396,223 | 867 | thecrypticace | I did some poking around and will add that rendering only breaks when the frozen array contains objects. If it contains primitives it (from what I can tell) works as expected. It seems it's related to the proxy's that wrap objects.
The error is:
```
TypeError: 'get' on proxy: property '0' is a read-only and non-co... | 2020-03-23T05:38:12 | 2020-03-23T06:04:02 | {} | CONTRIBUTOR |
vuejs | core | 603,563,665 | 876 | rigor789 | That seems to be working with `alpha.10`, thanks! | 2020-03-24T23:51:33 | 2020-03-24T23:51:33 | {} | CONTRIBUTOR |
vuejs | core | 604,432,618 | 882 | yyx990803 | This doesn't seem to make sense. Please make sure to explain the reasoning behind a PR. | 2020-03-26T13:31:30 | 2020-03-26T13:31:30 | {} | MEMBER |
vuejs | core | 604,453,512 | 887 | yyx990803 | This is different, because `defineComponent` is only used for type inference and doesn't do anything in itself, while `createAsyncComponent` actually creates an async component wrapper. | 2020-03-26T14:12:06 | 2020-03-26T14:12:06 | {} | MEMBER |
vuejs | core | 606,674,483 | 902 | danyadev | But if you look at foo.value, you can see that there is a vnode key
| 2020-03-31T14:48:13 | 2020-03-31T14:48:13 | {} | CONTRIBUTOR |
vuejs | core | 609,015,132 | 920 | ysj16 | A reactive object will toRaw in Map.set, so there will be both origin object and reactive object in map in #919, so I just delete the reactive one. If it's not a good way, you can close this PR at any time.:smile: | 2020-04-04T11:36:33 | 2020-04-04T11:42:15 | {} | CONTRIBUTOR |
vuejs | core | 609,032,037 | 921 | yyx990803 | Please do not submit pointless PRs. If you do this again you will be blocked from all vuejs repos. | 2020-04-04T13:53:47 | 2020-04-04T13:53:47 | {} | MEMBER |
vuejs | core | 610,181,020 | 935 | vue-bot | Hello, thank you for taking time filling this issue!
However, we kindly ask you to use our [Issue Helper](https://new-issue.vuejs.org/?repo=vuejs/vue-next) when creating new issues, in order to ensure every issue provides the necessary information for us to investigate. This explains why your issue has been automatic... | 2020-04-07T05:24:48 | 2020-04-07T05:24:48 | {} | CONTRIBUTOR |
vuejs | core | 610,963,127 | 938 | yyx990803 | Closed via d531686f9154c2ef7f1d877c275df62a8d8da2a5 (commit message referenced wrong issue) | 2020-04-08T13:34:41 | 2020-04-08T13:34:41 | {} | MEMBER |
vuejs | core | 604,450,602 | 886 | posva | You need to use a function because you are passing a raw value when reading `state.hasUsers`.
```js
watch(() => state.hasUsers, () => {
console.log('key \'hasUsers\' has been changed!');
});
```
The only cases when you don't need to pass a function is when you pass a Ref (result of a `computed... | 2020-03-26T14:06:29 | 2020-03-26T14:06:29 | {} | MEMBER |
vuejs | core | 604,942,131 | 891 | posva | In a few words: this will break reactivity and is not possible
Longer explanations have been provided in the RFC related to the composition api, in particular here: https://vue-composition-api-rfc.netlify.com/#overhead-of-introducing-refs | 2020-03-27T11:08:13 | 2020-03-27T11:08:13 | {} | MEMBER |
vuejs | core | 606,723,977 | 902 | yyx990803 | Use `$el` | 2020-03-31T16:08:31 | 2020-03-31T16:08:31 | {} | MEMBER |
vuejs | core | 609,849,858 | 930 | basvanmeurs | Thanks for your feedback! Requested changes have been done. | 2020-04-06T15:02:54 | 2020-04-06T15:02:54 | {} | CONTRIBUTOR |
vuejs | core | 611,080,663 | 906 | yyx990803 | There are two parts in this repro:
1. Dynamic transition names not updating on nested HOCs. This is fixed by b8da8b2d.
2. Transition mode not working on nested HOCs' own updates:
``` html
<transition mode="out-in">
<router-view/>
</transition>
```
Note `<router-view/>` updates itself, not as a result ... | 2020-04-08T17:11:37 | 2020-04-08T17:11:37 | {
"+1": 4,
"heart": 1
} | MEMBER |
vuejs | core | 646,897,455 | 1,408 | wucdbm | I suspect it may be related to https://github.com/vuejs/vue-next/issues/1400 in a way.
Using mode `out-in` though. | 2020-06-19T23:33:48 | 2020-06-19T23:33:48 | {} | NONE |
vuejs | core | 648,976,326 | 1,209 | yyx990803 | `watch` does not trigger because the value of `active` (or of `count` in the latter case) **did not change**. In other words - `triggerRef` did trigger the watch's source to be re-evaluated (accessing `count.value`), but it re-evaluated to the same value.
`watchEffect`, on the other hand, always re-run its function ... | 2020-06-24T18:00:40 | 2020-06-24T18:00:40 | {} | MEMBER |
vuejs | core | 645,664,725 | 1,359 | Eldar-X | I am also dreaming about ts support in templates. For example it's my favorite part of angular especially when you have large and complex project and need to change something, you mostly don't look into templates, you just change script part and never know if your template part is broken :( | 2020-06-17T22:45:04 | 2020-06-17T22:45:04 | {} | NONE |
vuejs | core | 646,905,846 | 1,408 | underfin | @AlexandreBonaventure Have you an git repo for this? The codesandbox is un-convenient for debug this. | 2020-06-20T00:26:26 | 2020-06-20T00:26:26 | {} | MEMBER |
vuejs | core | 647,062,745 | 1,411 | liulinboyi | @posva Thank you! | 2020-06-21T00:47:17 | 2020-06-21T00:47:17 | {} | MEMBER |
vuejs | core | 647,284,774 | 1,414 | underfin | You can add the blew config into `vite.config.js`.Because your template will compiled by sfc compiler.
```
vueCompilerOptions: {
isCustomElement: tag => {
return /^x-/.test(tag)
}
}
```
Other the `app.config.isCustomElement = tag => /^x-/.test(tag);` only work with runtime-dom compiler. | 2020-06-22T05:20:45 | 2020-06-22T05:20:45 | {
"+1": 6,
"hooray": 1
} | MEMBER |
vuejs | core | 648,952,250 | 1,439 | CyberAP | Here is a test of all methods in isolation, template literal seems to be the fastest in Chrome 83 on Windows if you leave the constructor check, without the check concat is the fastest on average. But it probably should be `'' + x` to avoid getting unexpected results.
https://jsperf.com/tostring-multiple-methods/1 | 2020-06-24T17:16:54 | 2020-06-24T17:25:29 | {} | CONTRIBUTOR |
vuejs | core | 648,977,616 | 1,439 | yyx990803 | I'd just change all occurrences to `'' + x` (inline, may need type casting) without a util function. | 2020-06-24T18:03:04 | 2020-06-24T18:03:04 | {
"+1": 1
} | MEMBER |
vuejs | core | 649,351,618 | 1,366 | jods4 | > I'd say there surely are usecases even though they might not be that many.
There's always corner cases, but then one can use something else than `MaybeRef<T>` for typing.
I see this type as a convenience and "standard" for the common case. | 2020-06-25T08:12:48 | 2020-06-25T08:12:48 | {} | CONTRIBUTOR |
vuejs | core | 649,402,826 | 1,366 | jacekkarczmarczyk | > A MaybeRef should accept [...]: ref(1), computed(() => 1), readonly(ref(1)).
> Plus plain T of course and you should be able to call unref on it.
If we agree on MaybeRef being readonly then it should be added to the above requirements. I'm not sure if it's a bug in vue typings or limitations of TS, but you can ... | 2020-06-25T09:02:20 | 2020-06-25T09:02:20 | {} | CONTRIBUTOR |
vuejs | core | 649,686,988 | 1,447 | LinusBorg | Hey, thanks for providing a repro.
> It feels like a hacky workaround, instead of something nicely supported.
The workaround that you propose only works for 2 components in one file (not happening with SFCs, really), and then it's only required if you use templates instead of (T/J)SX. It won't help you when usin... | 2020-06-25T16:44:55 | 2020-06-25T16:50:12 | {} | MEMBER |
vuejs | core | 650,051,126 | 1,448 | unbyte | It was fixed by 7e281733120fe003552b915f97713a3d26f4dc8a. | 2020-06-26T08:20:05 | 2020-06-26T08:20:05 | {} | CONTRIBUTOR |
vuejs | core | 646,850,129 | 1,407 | AlexandreBonaventure | Hum, actually don't think it is a regression. But I can't manage to make a simple repro for this issue yet. I'll update soon | 2020-06-19T20:32:26 | 2020-06-19T20:32:26 | {} | CONTRIBUTOR |
vuejs | core | 646,873,788 | 1,407 | AlexandreBonaventure | Well @posva, I don't actually see any mention of that.... Could you point to me where I can find this info ? | 2020-06-19T21:54:54 | 2020-06-19T21:54:54 | {} | CONTRIBUTOR |
vuejs | core | 646,978,012 | 1,387 | shawnwildermuth | I'm seeing something similar. But it's an update behind. When the nested object changes, the UI doesn't change until a second render cycle is called. | 2020-06-20T10:56:18 | 2020-06-20T10:56:18 | {} | NONE |
vuejs | core | 647,155,844 | 1,415 | yyx990803 | The core rendering algorithm relies on being able to get the next sibling node. There's no way around this. Even if your target platform doesn't have it by default, it should at least provide other APIs that allows you to implement that yourself (e.g. checking the index of the node in its parent's children), otherwise ... | 2020-06-21T17:13:48 | 2020-06-21T17:13:48 | {} | MEMBER |
vuejs | core | 647,181,106 | 1,387 | shawnwildermuth | The issue I found was in my code. Once I tried to reproduce it in Beta.15, I couldn't. So I am happy to have it closed. | 2020-06-21T21:01:20 | 2020-06-21T21:01:20 | {} | NONE |
vuejs | core | 647,185,498 | 1,387 | ConradSollitt | Thanks for the detailed feedback @LinusBorg | 2020-06-21T21:42:45 | 2020-06-21T21:42:45 | {} | NONE |
vuejs | core | 647,307,007 | 1,414 | sonicoder86 | @underfin how can I add the same to Vue CLI? | 2020-06-22T06:15:09 | 2020-06-22T06:15:09 | {} | NONE |
vuejs | core | 647,344,936 | 1,414 | LinusBorg | @blacksonic for vue-cli you would have to do something like this:
```javascript
// vue.config.js
module.exports = {
chainWebpack: config => {
// get the existing vue-loader rule and tap into its options
config.module.rule('vue-loader').tap(options => {
option.compilerOptions = {
...(opti... | 2020-06-22T07:42:02 | 2020-06-22T07:42:44 | {
"+1": 5,
"rocket": 2
} | MEMBER |
vuejs | core | 647,759,502 | 1,414 | yyx990803 | As pointed out, Vue 3 requires configuring custom elements via compiler options if pre-compiling templates.
This seems to be now a Vue CLI specific configuration problem so I'm closing it. But feel free to continue the discussion.
/cc @sodatea | 2020-06-22T20:42:41 | 2020-06-22T20:42:41 | {} | MEMBER |
vuejs | core | 648,706,413 | 1,438 | posva | Prior art: https://github.com/vuejs/vue/issues/6913
This should go through an RFC process. It would probably be useful to have in-template computed properties as well. I created this for vue 2 https://github.com/posva/vue-local-scope | 2020-06-24T09:25:55 | 2020-06-24T09:25:55 | {
"+1": 2
} | MEMBER |
vuejs | core | 648,866,253 | 1,439 | Awen-hub | > From my tests, it seems the fastest would be simply replacing all `String(x)` with `x + ''`.
Really? I have compared `${x}` and x + '' before, and x + '' is about 22% slower in Chrome. You can see it in this link(https://jsperf.com/1234qwe). Could you show me your tests? | 2020-06-24T14:46:00 | 2020-06-24T14:46:00 | {} | NONE |
vuejs | core | 647,450,970 | 1,425 | CyberAP | Export a ref.
Object becoming reactive is a side-effect of Vue 2 reactivity, but this behaviour is not documented as expected. | 2020-06-22T11:13:15 | 2020-06-22T11:13:15 | {} | CONTRIBUTOR |
vuejs | core | 647,463,766 | 1,425 | CyberAP | Data is only a function in Vue 3
https://github.com/vuejs/rfcs/blob/master/active-rfcs/0019-remove-data-object-declaration.md | 2020-06-22T11:41:55 | 2020-06-22T11:41:55 | {} | CONTRIBUTOR |
vuejs | core | 647,576,444 | 1,236 | jungeonkim | @pikax
It fixed in 3.0.0-beta.15 development build. But it doesn't work in 3.0.0-beta.15 production build.
https://jsfiddle.net/dxybujrm/ | 2020-06-22T15:05:15 | 2020-06-22T15:05:15 | {} | NONE |
vuejs | core | 647,714,619 | 1,429 | lee-chase | Fantastic @posva I hadn't spotted that. | 2020-06-22T19:00:24 | 2020-06-22T19:00:24 | {} | NONE |
vuejs | core | 648,006,442 | 1,426 | jods4 | @underfin I'm not suggesting that you use the `patchFlags` of the previous node, which would obviously create the same problem in reverse.
Rather, I suggest you combine the `patchFlags` from both nodes. If _either one_ is deoptimized then all props should be compared.
> If you want remove { class: 'added-stuff' }... | 2020-06-23T08:54:17 | 2020-06-23T08:54:17 | {} | CONTRIBUTOR |
vuejs | core | 649,635,142 | 1,247 | yyx990803 | First of all, thanks a lot of coming up with the idea and experimenting with this. Unfortunately, the gain here doesn't seem to justify the increased complexity of the implementation.
I still think this is an area worth exploring - but I think a more compiler-informed approach would be more plausible. | 2020-06-25T15:44:40 | 2020-06-25T15:44:40 | {} | MEMBER |
vuejs | core | 649,661,686 | 1,130 | yyx990803 | In general I am against use cases like this since the whole point of reactivity is having a consistent state graph and this API is like intentionally giving the user a tool to make the graph inconsistent. I can't help but feel that it's a sign that you need to rethink how you are approaching the problem. There are prob... | 2020-06-25T16:08:52 | 2020-06-25T16:08:52 | {} | MEMBER |
vuejs | core | 649,840,453 | 1,308 | yyx990803 | Should be fixed by 7ae70ea4 | 2020-06-25T22:03:25 | 2020-06-25T22:03:25 | {} | MEMBER |
vuejs | core | 645,599,685 | 1,394 | yyx990803 | Good job 👍 | 2020-06-17T20:13:23 | 2020-06-17T20:13:23 | {} | MEMBER |
vuejs | core | 647,120,365 | 1,366 | LinusBorg | I personally call them `MaybeRef<T>` in my codebases, as the argument may be a `Ref`, or not 🙃 | 2020-06-21T12:16:03 | 2020-06-21T15:02:02 | {
"+1": 14
} | MEMBER |
vuejs | core | 647,282,422 | 1,417 | Justineo | Named `v-slot` directive can only be used on `<template>`s:
```vue
<MyComponent>
<template v-slot:item>
<Hello></Hello>
</template>
</MyComponent>
```
Read more [here](https://github.com/vuejs/rfcs/blob/master/active-rfcs/0001-new-slot-syntax.md). | 2020-06-22T05:14:26 | 2020-06-22T05:14:26 | {} | MEMBER |
vuejs | core | 647,991,880 | 1,426 | underfin | If use the `patchFlags ` of previous node, the extra prop of you add ` { class: 'added-stuff' }` will not patched to dom.
Current behavior is expected.Because you add extar props with `cloneVNode ` and you want to this work on dom, the changed `patchFlags` is necessary.
If you want remove ` { class: 'added-stuff... | 2020-06-23T08:26:35 | 2020-06-23T08:26:35 | {} | MEMBER |
vuejs | core | 648,385,089 | 1,130 | basvanmeurs | > What is the reason to avoid tracking here? Is it solely for performance?
Not performance. In my use case I want to sync a scrollbar. I needed to get the current scroll value without tracking it to avoid recursive feedback while scrolling.
Possibly it's an edge case. | 2020-06-23T19:56:33 | 2020-06-23T19:56:33 | {} | CONTRIBUTOR |
vuejs | core | 649,604,404 | 1,406 | yyx990803 | This is temporarily disabled on purpose. Only declaring the type in the arg position doesn't actually match runtime behavior because `props` will be an empty object without runtime props declarations. | 2020-06-25T15:01:12 | 2020-06-25T15:01:12 | {} | MEMBER |
vuejs | core | 649,606,729 | 1,405 | yyx990803 | Seems unnecessary. It's in the same file. The getter and setter is only exposed for external files. | 2020-06-25T15:05:15 | 2020-06-25T15:05:15 | {} | MEMBER |
vuejs | core | 647,316,361 | 1,414 | underfin | You can add this into webpack config.It should work (I'm not test it).
```
{
test: /\.vue$/,
loader: 'vue-loader',
options: {
compilerOptions: {
isCustomElement: tag => {
return /^x-/.test(tag)
}
}
}
``` | 2020-06-22T06:36:07 | 2020-06-22T06:36:07 | {
"+1": 3
} | MEMBER |
vuejs | core | 648,148,991 | 1,426 | jods4 | No worry.
Wouldn't it be ok if you specifically look at the `FULL_PROPS` bit from both? | 2020-06-23T13:30:57 | 2020-06-23T13:30:57 | {} | CONTRIBUTOR |
vuejs | core | 648,575,982 | 1,426 | underfin | Thanks for your explain :)
Are you mean add the code `patchFlag = n1.patchFlag | n2.patchFlag` with this code place?
https://github.com/vuejs/vue-next/blob/8c72b1febdd36e227ff27fa0f7ceaa434c47e1a8/packages/runtime-core/src/renderer.ts#L782
If this is your idea, I think it is useful under this situation. | 2020-06-24T04:25:22 | 2020-06-24T04:25:22 | {} | MEMBER |
vuejs | core | 648,980,481 | 1,209 | yyx990803 | I'd say the problem here is that it doesn't make sense to want `watch` to run even if a watched value didn't change. You should just move the callback into a named function and call it in `onclickNow`. | 2020-06-24T18:08:33 | 2020-06-24T18:08:48 | {} | MEMBER |
vuejs | core | 648,998,826 | 1,414 | sonicoder86 | I've found the fix.
The Vue CLI config is:
```javascript
module.exports = {
chainWebpack: config => {
config.module
.rule('vue')
.use('vue-loader')
.loader('vue-loader')
.tap(options => {
options.compilerOptions = {
...(options.compilerOptions || {}),
... | 2020-06-24T18:44:07 | 2020-06-24T18:44:07 | {
"+1": 6,
"heart": 4,
"hooray": 2
} | NONE |
vuejs | core | 649,646,349 | 1,439 | yyx990803 | 1. The string conversion perf is negligible in the compiler. There's no point in using a dedicated util functions for this.
2. It's marginally a hotspot in runtime vnode normalization, where the occurrence of strings will be much more frequent than numbers.
3. The behavior of `'' + x` is consistent. Just don't use `x... | 2020-06-25T15:58:55 | 2020-06-25T15:58:55 | {
"+1": 3
} | MEMBER |
vuejs | core | 648,654,001 | 1,426 | jods4 | Yes, something like that.
As you said, mixing other flags might be confusing, so maybe just the FULL_PROPS:
```js
let { patchFlag, dynamicChildren, dirs } = n2;
// Consider both previous and new node because either one might have been replaced with cloneVNode or similar.
patchFlag |= (n1.patchFlag & PatchFlags.FUL... | 2020-06-24T07:43:45 | 2020-06-24T07:43:45 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 648,981,370 | 1,209 | RobbinBaauw | That would indeed be a better solution (although it doesn't solve it in the codebase as the watcher is still needed for other cases), thanks for clearing things up about `triggerRef`! | 2020-06-24T18:10:20 | 2020-06-24T18:14:40 | {} | CONTRIBUTOR |
vuejs | core | 649,788,997 | 1,175 | yyx990803 | This helped me understand some of the fixme cases in the tests - however the way appear hooks are being handled should've been done inside `BaseTransition`.
See acd3156d & 7ae70ea4 | 2020-06-25T20:03:27 | 2020-06-25T20:03:27 | {} | MEMBER |
vuejs | core | 650,231,595 | 1,197 | yyx990803 | Great job! | 2020-06-26T15:09:54 | 2020-06-26T15:09:54 | {
"heart": 1
} | MEMBER |
vuejs | core | 647,343,192 | 1,414 | LinusBorg | Oh so we really only check during compile time? My mistake then. | 2020-06-22T07:38:20 | 2020-06-22T07:38:20 | {} | MEMBER |
vuejs | core | 647,452,332 | 1,425 | seanfreemannutrien | It was documented. here: https://vuejs.org/v2/guide/state-management.html
it was an expected feature and lots of apps use it for a minimal state management. and it's actually so much better than vuex actually. | 2020-06-22T11:16:21 | 2020-06-22T11:16:21 | {} | NONE |
vuejs | core | 647,456,394 | 1,425 | CyberAP | There is a difference of data as an object and data as a function. The former is not supported in Vue 3 and the example you've shown wouldn't work. Object becoming reactive as a result of assigning it to a data function return is a side effect of Vue 2 reactivity and it's not documented in the page you've provided. The... | 2020-06-22T11:25:16 | 2020-06-22T11:26:06 | {} | CONTRIBUTOR |
vuejs | core | 647,710,972 | 1,414 | sonicoder86 | @LinusBorg
What can I do if the `tap` function doesn't exist?
The `webpack-chain` packages documentation seems to call `use` before calling `tap`.
I get this message:
`(node:10740) UnhandledPromiseRejectionWarning: TypeError: config.module.rule(...).tap is not a function` | 2020-06-22T18:54:43 | 2020-06-22T18:54:43 | {} | NONE |
vuejs | core | 647,981,571 | 1,433 | posva | Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the [forum](http://forum.vuejs.org/), the [Discord server](https://vue-land.js.org/) or [StackOverflow](http://stackoverflow.com/tags/vue.js).
---
`vue add` is the CLI command to add a CLI plug... | 2020-06-23T08:06:14 | 2020-06-23T08:06:14 | {} | MEMBER |
vuejs | core | 648,974,328 | 1,439 | Awen-hub | > Here is a test of all methods in isolation, template literal seems to be the fastest in Chrome 83 on Windows if you leave the constructor check, without the check concat is the fastest on average. But it probably should be `'' + x` to avoid getting unexpected results.
> https://jsperf.com/tostring-multiple-methods/1... | 2020-06-24T17:56:41 | 2020-06-24T17:56:41 | {} | NONE |
vuejs | core | 649,227,013 | 1,439 | Awen-hub | > I'd just change all occurrences to `'' + x` (inline, may need type casting) without a util function.
Emmm, I don't think it is the best choice. In fact, I tried as you say at first. But I find when it is a string, '' + x is faster than `${x}` (about 60% slower) and when it is a number `${x}` is faster than '' ... | 2020-06-25T05:25:50 | 2020-06-25T05:25:50 | {} | NONE |
vuejs | core | 649,349,030 | 1,366 | LinusBorg | > Is there even a usecase when I would want to pass T | Ref<T> and have possibility of updating the value of ref?
I'd say there surely are usecases even though they might not be that many. But since `Ref` also matches for computed refs, it just is more convenient: People can pass a ref or computed ref, whichever the... | 2020-06-25T08:10:15 | 2020-06-25T08:10:48 | {} | MEMBER |
vuejs | core | 649,677,768 | 1,439 | Awen-hub | > 1. The string conversion perf is negligible in the compiler. There's no point in using a dedicated util functions for this.
> 2. It's marginally a hotspot in runtime vnode normalization, where the occurrence of strings will be much more frequent than numbers.
> 3. The behavior of `'' + x` is consistent. Just don't ... | 2020-06-25T16:34:13 | 2020-06-25T16:34:13 | {} | NONE |
vuejs | core | 650,180,161 | 1,424 | yyx990803 | We should keep it consistent with v2. See e765d814 | 2020-06-26T13:30:43 | 2020-06-26T13:30:43 | {} | MEMBER |
vuejs | core | 645,368,833 | 1,392 | yyx990803 | This adds the cost of the `hasOwn` checks to every get access, which is likely even more expensive. | 2020-06-17T13:19:49 | 2020-06-17T13:19:49 | {} | MEMBER |
vuejs | core | 647,295,790 | 1,415 | shubhamzanwar | Thanks for clarifying, Evan. :)
Will look for a workaround | 2020-06-22T05:49:41 | 2020-06-22T05:49:41 | {} | NONE |
vuejs | core | 647,961,325 | 1,432 | posva | you need to return `root` in setup so it can be used by the `ref="root"` | 2020-06-23T07:25:09 | 2020-06-23T07:25:09 | {} | MEMBER |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.