owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 658,305,640 | 1,576 | zhangzhonghe | @yyx990803 Should affect CSS property selector. | 2020-07-14T17:18:29 | 2020-07-14T17:18:29 | {} | MEMBER |
vuejs | core | 658,763,524 | 1,590 | yyx990803 | Thanks but this doesn't actually matter since it's an object, not an argument list. | 2020-07-15T13:21:02 | 2020-07-15T13:21:02 | {} | MEMBER |
vuejs | core | 658,768,327 | 410 | yyx990803 | Closing as stale. Thanks for the PR still! | 2020-07-15T13:29:33 | 2020-07-15T13:29:33 | {
"+1": 1
} | MEMBER |
vuejs | core | 655,412,363 | 1,462 | jacekkarczmarczyk | > Before this PR, if you execute r.obj.k = 'x', actually it will not take effect.
Ah I see, that makes perfectly sense | 2020-07-08T09:43:54 | 2020-07-08T09:43:54 | {} | CONTRIBUTOR |
vuejs | core | 656,236,483 | 1,502 | Awen-hub | > This adds quite a bit of extra logic - it'd be nice to see a benchmark of how this affects the cases it's optimizing for, and whether it affects other common cases.
1. Year, it's a little difficult for me to check whther patched>= toBepatched and whether the move shoule be true. I use a lot of logic to do it and ... | 2020-07-09T16:48:51 | 2020-07-09T16:48:51 | {} | NONE |
vuejs | core | 656,969,325 | 1,227 | yyx990803 | Update: still WIP but the idea is working (screenshot of actual working code running in Vite):
<img width="792" alt="Screen Shot 2020-07-10 at 10 19 02 PM" src="https://user-images.githubusercontent.com/499550/87214525-64af2080-c2fb-11ea-9d52-d82175799df7.png">
| 2020-07-11T02:20:11 | 2020-07-11T02:20:11 | {
"rocket": 6
} | MEMBER |
vuejs | core | 657,103,259 | 1,227 | RobbinBaauw | Great! I was just thinking of something else: why is the `setupState` even reactive? I understand that props need to be reactive (although they are only `shallowReactive`), but I don't see the case where you should be able to reactively add new properties to this `setupState` object.
Couldn't you make it a normal ob... | 2020-07-11T17:54:27 | 2020-07-11T17:54:27 | {} | CONTRIBUTOR |
vuejs | core | 659,114,318 | 1,587 | tangjinzhou | This is a very conventional way of use. If using `v-if` `v-if` is not common, but `v-if` `v-else` is a common way of using it.
Like：
https://jsbin.com/lotusikiru/edit?html,output
```html
<span v-if="value%2 === 0" key="1">world</span>
<span v-else key="1">hello</span>
```
If let users understand patchFlag, this... | 2020-07-16T02:11:41 | 2020-07-16T02:13:00 | {} | CONTRIBUTOR |
vuejs | core | 659,119,029 | 1,587 | underfin | Look like we need do some static analysis for same keys element and add corresponding patchFlag to it. | 2020-07-16T02:28:20 | 2020-07-16T02:28:20 | {} | MEMBER |
vuejs | core | 655,567,393 | 1,539 | bundlejs | > Vue 3 SFC currently doesn't support scoped styles for manually render functions, for now you have to either use templates or CSS modules.
在vite build 之后的项目中,这个render方法并没有执行,也就没有相应的dom产生 | 2020-07-08T14:49:11 | 2020-07-08T14:49:11 | {} | NONE |
vuejs | core | 657,126,791 | 1,227 | jods4 | @RobbinBaauw If you dig through issues, you'll find one I opened during early betas to suggest not using any proxy at all on the returned state from `setup`.
This was done and then reversed. As I recall, the main argument was that Vue wants to unref proxies automatically in templates, and deeply so. | 2020-07-11T20:44:28 | 2020-07-11T20:44:28 | {} | CONTRIBUTOR |
vuejs | core | 657,151,492 | 1,553 | ChrisShank | I think an API for this was already discussed in this [RFC](https://github.com/vuejs/rfcs/pull/16) and already works in the Vue 3 Beta! | 2020-07-12T00:10:14 | 2020-07-12T00:30:19 | {} | NONE |
vuejs | core | 657,557,790 | 1,574 | Jupakabra | Don't think it's a bug, probably just intended, maybe can be supported?
```VUE
<template>
<button @click="test">Text to click {{ control }}</button>
</template>
<script lang="ts">
import { reactive, toRefs } from "vue";
export class Test {
public control = 1;
public test() {
console.... | 2020-07-13T13:23:01 | 2020-07-13T13:23:24 | {} | NONE |
vuejs | core | 657,583,199 | 1,574 | posva | By converting to refs with `toRefs` you will loose the context inside function calls anyway. Also, see https://github.com/vuejs/vue-next/issues/1499#issuecomment-653592825
This works:
```js
const { ref, createApp, reactive } = Vue;
class X {
constructor () {
this.y = 3
}
getY(viaTemplate) {
... | 2020-07-13T14:08:36 | 2020-07-13T14:56:24 | {} | MEMBER |
vuejs | core | 657,940,354 | 1,575 | Justineo | Thanks but we intentionally value performance over readability here (with less variables created). | 2020-07-14T03:09:46 | 2020-07-14T03:09:46 | {
"+1": 1
} | MEMBER |
vuejs | core | 658,262,574 | 1,576 | yyx990803 | Does this affect the behavior in anyway? As far as I know this doesn't make any difference except for when inspecting the DOM elements in devtools. | 2020-07-14T15:57:05 | 2020-07-14T15:57:05 | {} | MEMBER |
vuejs | core | 658,649,194 | 1,587 | tangjinzhou | https://vue-next-template-explorer.netlify.app/#%7B%22src%22%3A%22%3Ch1%20v-if%3D%5C%22x%5C%22%3Etest1%3C%2Fh1%3E%5Cn%3Ch1%20v-if%3D%5C%22y%5C%22%3Etest2%3C%2Fh1%3E%5Cn%22%2C%22ssr%22%3Afalse%2C%22options%22%3A%7B%22mode%22%3A%22module%22%2C%22prefixIdentifiers%22%3Afalse%2C%22optimizeImports%22%3Afalse%2C%22hoistStati... | 2020-07-15T09:12:31 | 2020-07-15T09:12:31 | {} | CONTRIBUTOR |
vuejs | core | 655,994,259 | 1,448 | tangjinzhou | I use version beta.20. still have this problem. @posva | 2020-07-09T08:40:52 | 2020-07-09T08:41:30 | {} | CONTRIBUTOR |
vuejs | core | 656,500,380 | 1,558 | underfin | You forgot register`TransitionWrapper ` inside `App`=.= | 2020-07-10T06:03:18 | 2020-07-10T06:03:18 | {} | MEMBER |
vuejs | core | 657,174,483 | 1,565 | pepsighan | I fixed the issue in vue 3 by merging the keydown event handlers into one:
**Before**
https://github.com/pepsighan/sudoku/blob/730d942967e94bc1bc40160beecfea7dfefe1f3a/src/views/Home.vue#L18-L22
**After**
https://github.com/pepsighan/sudoku/blob/951fbeb6a21486e12c3462d62c01c82ff5c6602e/src/views/Home.vue#L18-L20
... | 2020-07-12T04:39:17 | 2020-07-12T04:41:15 | {} | NONE |
vuejs | core | 657,407,533 | 1,572 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [ci/circleci: test](https://circleci.com/gh/vuejs/vue-next/6881?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
Dependabot will still automatically merge this pull request if you amend it and your test... | 2020-07-13T08:32:06 | 2020-07-13T08:32:06 | {} | CONTRIBUTOR |
vuejs | core | 657,592,186 | 1,564 | yyx990803 | We know this and have already been working on it. Vetur already does this to some extent (https://vuejs.github.io/vetur/interpolation.html) and the project mentioned above is another direction we are exploring. | 2020-07-13T14:25:01 | 2020-07-13T14:27:22 | {
"eyes": 1
} | MEMBER |
vuejs | core | 658,395,178 | 1,582 | yyx990803 | 1. According to [this RFC](https://github.com/vuejs/rfcs/blob/master/active-rfcs/0024-attribute-coercion-behavior.md) in 3.0 `v-bind:foo="false"` will render as `foo="false"` instead of removing the attribute
2. This code path may have to deal with DOM properties that do not have corresponding attributes, so only re... | 2020-07-14T20:25:43 | 2020-07-14T20:25:43 | {
"heart": 1
} | MEMBER |
vuejs | core | 656,062,261 | 1,552 | zhangenming | trick:
```js
computed(()=>{
array// this will not trigger in V3
array.map(noop) // this will trigger
function noop(){}
})
``` | 2020-07-09T11:04:02 | 2020-07-09T11:04:02 | {} | CONTRIBUTOR |
vuejs | core | 658,260,332 | 1,580 | yyx990803 | @dependabot rebase | 2020-07-14T15:53:15 | 2020-07-14T15:53:15 | {
"+1": 1
} | MEMBER |
vuejs | core | 659,130,642 | 1,595 | yyx990803 | The queue ordering has some internal assumptions: a new main queue job is only queued during the flush as a parent -> child forced update, for which the child is guaranteed to have a bigger ID than the parent (the sorting is there exactly to ensure child is updated after the parent).
The only edge case for this is w... | 2020-07-16T03:09:35 | 2020-07-16T03:10:13 | {} | MEMBER |
vuejs | core | 655,377,060 | 1,462 | Picknight | > this looks like a breaking change?
This is not a new feature, it just improves type checking. | 2020-07-08T08:37:21 | 2020-07-08T08:37:21 | {} | CONTRIBUTOR |
vuejs | core | 655,408,731 | 1,462 | Picknight | 1. Before this PR, if you execute `r.obj.k = 'x'`, actually it will not take effect. Now we have completed the type checking to avoid unnecessary troubles for developers.
2. For `shallow readonly variable`, you can use `shallowReadonly`. @jacekkarczmarczyk | 2020-07-08T09:36:45 | 2020-07-08T09:36:45 | {} | CONTRIBUTOR |
vuejs | core | 655,627,921 | 1,539 | yyx990803 | What's the point of using render functions inside single file components? Just for `<style>`? Also, if it's a Vite issue, please open separate issue in Vite's repo. | 2020-07-08T16:36:04 | 2020-07-08T16:36:56 | {} | MEMBER |
vuejs | core | 656,502,819 | 1,558 | pearofducks | Nice catch, sorry for the false report and thanks for taking a look @underfin ! | 2020-07-10T06:11:46 | 2020-07-10T06:11:46 | {} | NONE |
vuejs | core | 657,184,069 | 1,567 | janispritzkau | I'm guessing the problem is that Vue can't take object event listener definitions as an array. | 2020-07-12T07:03:50 | 2020-07-12T07:11:17 | {} | NONE |
vuejs | core | 657,465,880 | 1,564 | pikax | There're projects exploring this subject: https://github.com/znck/vue-developer-experience
| 2020-07-13T10:09:18 | 2020-07-13T10:09:18 | {} | MEMBER |
vuejs | core | 657,606,423 | 1,574 | yyx990803 | I looked into this a bit deeper because this actually wasn't caused by changes in vue-next.
Given a native class:
```js
class Test {
control = 1;
test() {
console.log(this.control);
}
}
const t = new Test()
for (const key in t) {
console.log(key)
}
```
Even though `test` exists on the ... | 2020-07-13T14:50:47 | 2020-07-13T14:51:02 | {} | MEMBER |
vuejs | core | 658,687,971 | 1,583 | michaeltintiuc | In fact currently it will call the enter hooks on page load as well, switching routes would call all of the hooks twice | 2020-07-15T10:27:42 | 2020-07-15T10:27:42 | {} | NONE |
vuejs | core | 655,627,442 | 1,547 | yyx990803 | This is expected behavior. `binding.instance` points to the instance whose template the directive is used in.
e.g.
```
<template>
<comp v-foo/>
<div v-foo/>
</template>
```
`binding.instance` should point to the same instance in both cases (i.e. `App`) | 2020-07-08T16:35:04 | 2020-07-08T16:35:04 | {} | MEMBER |
vuejs | core | 656,938,205 | 1,461 | HunderlineK | @CyberAP The solution I use for these cases is to wrap the primitive with an array, so I can create a new reference to the array even if the primitive stays the same i.e. using [primitive] as the value
https://codesandbox.io/s/eloquent-newton-goleu?file=/src/App.vue
Not sure if there are any performance differences... | 2020-07-10T23:33:25 | 2020-07-10T23:33:25 | {} | NONE |
vuejs | core | 658,035,674 | 1,577 | thecrypticace | See https://github.com/vuejs/vue-next/pull/1458
The type should likely be updated instead. | 2020-07-14T08:05:47 | 2020-07-14T08:05:47 | {} | CONTRIBUTOR |
vuejs | core | 658,813,723 | 1,591 | yyx990803 | This is actually caused by stale build cache that used wrong enum flag values when building for release. Should be fixed in the next release. (81e82e7d) | 2020-07-15T14:48:20 | 2020-07-15T14:48:20 | {} | MEMBER |
vuejs | core | 659,227,562 | 1,525 | johnsoncodehk | I think not trigger is the correct way. This is also the way of vue2.
This is an example, in response to the url parameter call api to get the page data, the code in the case of not trigger is:
```javascript
// not trigger
setup() {
const data = ref();
watch(
() => $route.query.dataId,
async (... | 2020-07-16T07:53:51 | 2020-07-16T07:53:51 | {} | MEMBER |
vuejs | core | 650,778,675 | 1,460 | yyx990803 | Ah, this is due to a breaking change in transition class names: https://github.com/vuejs/rfcs/blob/master/active-rfcs/0018-transition-class-change.md
`.fade-enter` should now be `.fade-enter-from`, which makes it more symmetric and explicit. | 2020-06-28T15:18:09 | 2020-06-28T15:18:09 | {} | MEMBER |
vuejs | core | 651,865,685 | 1,461 | yyx990803 | FYI: after b3536d87 you should be able to get the computed setter version work by adding `this.$forceUpdate()` (it's necessary because after the first set the state technically doesn't change anymore) | 2020-06-30T15:25:04 | 2020-06-30T15:25:04 | {} | MEMBER |
vuejs | core | 652,330,713 | 1,477 | posva | Duplicate of https://github.com/vuejs/vue-router-next/issues/341
Check the example I sent you. You can also clone it locally to see it in action | 2020-07-01T10:16:27 | 2020-07-01T10:16:27 | {} | MEMBER |
vuejs | core | 653,226,300 | 1,490 | aztalbot | A solution with little to no performance impact for this specific case would be a public function to add constructors to the collectionTypes Set (ex. `addCollectionType`). @tarnishablec Do you think that would work for your use case? The current solution here slows reactive object creation for all use cases. Extending... | 2020-07-02T21:22:19 | 2020-07-02T21:22:19 | {} | CONTRIBUTOR |
vuejs | core | 653,933,011 | 1,509 | zippaaa | I found an example: https://github.com/blacksonic/vue-3-playground/blob/master/src-javascript/components/Item.vue | 2020-07-05T20:06:41 | 2020-07-05T20:07:44 | {} | NONE |
vuejs | core | 654,008,753 | 1,513 | danyadev | I understand that this is a bad use case for key. Nevertheless, it was used in my code, although I did not even know about it, and everything worked perfectly. | 2020-07-06T04:30:23 | 2020-07-06T04:30:23 | {} | CONTRIBUTOR |
vuejs | core | 654,772,877 | 1,534 | odex21 | This should be because the vue-next plugin for vue-cli does not yet support the creation of ts templates.
[vue-cli-plugin-vue-next](https://github.com/vuejs/vue-cli-plugin-vue-next) | 2020-07-07T10:56:25 | 2020-07-07T10:59:19 | {} | NONE |
vuejs | core | 654,832,841 | 972 | AndrewBro | I added next release vesion
```
"vue-router": "4.1.0"
```
since I don't see this error | 2020-07-07T12:47:41 | 2020-07-07T12:47:41 | {} | NONE |
vuejs | core | 650,818,518 | 1,460 | sdras | Got it, updating the docs now, thanks | 2020-06-28T20:38:21 | 2020-06-28T20:38:21 | {} | MEMBER |
vuejs | core | 652,498,790 | 1,482 | Amour1688 | ```js
const { createApp, createVNode, withCtx } = Vue;
const A = (props, {
slots
}) => slots.default();
const App = {
data() {
return {
val: 0
};
},
methods: {
inc() {
this.val += 1;
}
},
render() {
const xx = {
innerHTML: this.val
};
... | 2020-07-01T15:47:53 | 2020-07-01T15:47:53 | {} | MEMBER |
vuejs | core | 653,439,249 | 1,246 | guaijie | > Accidentally closed by wrong issue tag in commit message -.-
？？？ | 2020-07-03T09:05:05 | 2020-07-03T09:05:05 | {} | CONTRIBUTOR |
vuejs | core | 653,869,844 | 1,507 | HcySunYang | Related issue: https://github.com/vuejs/vue-next/issues/1505 | 2020-07-05T10:20:28 | 2020-07-05T10:20:28 | {} | MEMBER |
vuejs | core | 653,870,113 | 1,506 | underfin | https://github.com/vuejs/vue-next/pull/1504 | 2020-07-05T10:23:07 | 2020-07-05T10:23:07 | {} | MEMBER |
vuejs | core | 654,091,406 | 1,520 | posva | I doubt this is a problem coming from Vue. I don’t even think there is a JS api to change the position of the pop up used for composed characters | 2020-07-06T08:25:00 | 2020-07-06T08:25:00 | {} | MEMBER |
vuejs | core | 654,848,347 | 1,532 | yyx990803 | So in this case, when do you expect it to be stopped? It seems you will need to manually implement a reference count in order to prevent the watcher from running indefinitely (and potentially lead to memory leaks) | 2020-07-07T13:13:41 | 2020-07-07T13:13:41 | {} | MEMBER |
vuejs | core | 654,864,999 | 1,532 | vmihailenco | >So in this case, when do you expect it to be stopped?
Not stopped at all by Vue. The data is essentially global and lives forever. I could run `useFoo` from the root component `App.vue` to achieve the same but:
- no lazy loading which is nice if the function loads some data using HTTP
- inconvenient if there are ... | 2020-07-07T13:36:05 | 2020-07-07T13:36:05 | {} | NONE |
vuejs | core | 654,991,447 | 1,035 | gjfei | 具体咋用呀！比如我要制作一个toast，以前可以直接vue.extend，现在要怎么制作 | 2020-07-07T16:51:32 | 2020-07-07T16:51:32 | {} | NONE |
vuejs | core | 651,087,993 | 1,461 | posva | > This won't work either. The value should be the first character.
That's why I asked, the code becomes `value[0]` instead of `value.slice(-1)`
@unbyte that's the proposed API, not a reproduction | 2020-06-29T12:32:55 | 2020-06-29T12:32:55 | {
"laugh": 1
} | MEMBER |
vuejs | core | 651,100,180 | 1,461 | CyberAP | The implementation of a setter should not matter, it should work both when you do not set a new value and set an altered value. | 2020-06-29T12:53:42 | 2020-06-29T12:53:42 | {} | CONTRIBUTOR |
vuejs | core | 652,619,352 | 1,475 | yyx990803 | Please use the RFC repo for proposals like this. | 2020-07-01T20:02:25 | 2020-07-01T20:02:25 | {} | MEMBER |
vuejs | core | 652,732,151 | 1,474 | underfin | https://github.com/vuejs/vue-next/blob/7f83856f34c17d3f0632a33cc09f7380b4767b69/packages/runtime-core/src/componentProxy.ts#L288
The warn will not trigger because that not inside `currentRendering` (`currentRenderingInstance`). | 2020-07-02T01:50:50 | 2020-07-02T01:50:50 | {} | MEMBER |
vuejs | core | 654,062,643 | 1,521 | tangjinzhou |
There is no problem for most scenes, but when using input, you will not be able to input Chinese like https://jsbin.com/neyuqekusi/edit?html,console,output . | 2020-07-06T07:23:29 | 2020-07-06T07:23:29 | {} | CONTRIBUTOR |
vuejs | core | 654,433,687 | 1,462 | yyx990803 | Thanks for the PR! Could you please add a test case in `test-dts`? (For test format, consult other files in that directory) | 2020-07-06T19:52:41 | 2020-07-06T19:52:41 | {} | MEMBER |
vuejs | core | 650,610,860 | 1,454 | dsonet | @HcySunYang was right. When you assign undefined to property maxLength, it will be treat as 0 and set attribute maxlength to 0(you can see that in DOM), thus you can type nothing.
But when you set attribute maxlength to undefined, it would just be ignored, won't affect maxLength. | 2020-06-27T19:40:54 | 2020-06-27T19:40:54 | {} | CONTRIBUTOR |
vuejs | core | 652,266,548 | 1,458 | Picknight | I simulated a special case of `normal effects depend on computed effects`, not sure if it is correct.
```js
const reactVal = reactive({})
let computedVal = computed(() => reactVal.foo)
let effectVal
effect(() => {
effectVal = reactVal.foo + computedVal.value
console.log('normal effects trigger!')
})
cons... | 2020-07-01T08:13:46 | 2020-07-01T08:14:35 | {} | CONTRIBUTOR |
vuejs | core | 652,287,602 | 1,475 | posva | I think adding more shorthand syntaxes for features that already follow an existing syntax (v-slot) is only going to make it harder to understand for anybody learning and overall hurt the experience despite trying to improve it.
At the end you don’t write that many Suspense components in a regular application.
If you ... | 2020-07-01T08:54:01 | 2020-07-01T08:54:01 | {} | MEMBER |
vuejs | core | 653,295,394 | 1,493 | Justineo | See https://github.com/vuejs/rfcs/issues/183. | 2020-07-03T02:07:31 | 2020-07-03T02:07:31 | {} | MEMBER |
vuejs | core | 654,320,182 | 1,520 | liulinboyi | I think they are maybe the reason.
https://cn.vuejs.org/v2/guide/forms.html#%E5%9F%BA%E7%A1%80%E7%94%A8%E6%B3%95
![image](https://user-images.githubusercontent.com/41336612/86612842-4daebc80-bfe3-11ea-847d-... | 2020-07-06T15:51:55 | 2020-07-06T15:51:55 | {} | MEMBER |
vuejs | core | 654,493,288 | 1,529 | yyx990803 | We should use clone to avoid mutation. The root cause is that `keep-alive` should be caching the normalized vnode instead of the vnode that is returned. See d86b01ba | 2020-07-06T22:19:23 | 2020-07-06T22:19:23 | {} | MEMBER |
vuejs | core | 654,497,678 | 1,513 | yyx990803 | This is a wontfix - `key` by definition must be identity unique and `NaN` is not a valid key. I added a warning for it in da40ff49. | 2020-07-06T22:34:03 | 2020-07-06T22:34:03 | {} | MEMBER |
vuejs | core | 654,507,433 | 1,527 | yyx990803 | When you use a string ref, it's a string key used to lookup refs on the render context. It's not an expression.
You can do something like `:ref="el => control.div = el"` though. | 2020-07-06T23:08:11 | 2020-07-06T23:08:11 | {} | MEMBER |
vuejs | core | 651,248,922 | 1,458 | yyx990803 | That would mean the normal effect has to run twice - which is exactly what we are trying to avoid. | 2020-06-29T17:10:26 | 2020-06-29T17:10:26 | {} | MEMBER |
vuejs | core | 652,624,476 | 1,474 | yyx990803 | Can you add a more specific test case? I don't think this actually "fixes" #1473 which is using an incompatible library. | 2020-07-01T20:15:07 | 2020-07-01T20:15:07 | {} | MEMBER |
vuejs | core | 654,457,358 | 1,520 | posva | That's something different. I tried with Pinyin keyboard and couldn't reproduce in multiple browsers, including latest Chrome. Make sure you don't have an extension that is somehow changing that but this is very unlikely to be related to Vue | 2020-07-06T20:48:01 | 2020-07-06T20:48:01 | {} | MEMBER |
vuejs | core | 654,573,994 | 1,503 | anandkumarram | @HcySunYang @yyx990803 it's working now.. thanks for the suggestion.. | 2020-07-07T03:16:29 | 2020-07-07T03:16:29 | {} | NONE |
vuejs | core | 650,280,841 | 1,425 | seanfreemannutrien | Update: thanks for your suggestion on using "reactive". i've learnt to work with it and i'm satisfied. thanks. | 2020-06-26T16:46:02 | 2020-06-26T16:46:02 | {} | NONE |
vuejs | core | 651,073,437 | 1,461 | unbyte | @posva
There is another example that a regexp is used to determine whether the input in the `<input/>` is legal or not, and if not, prevent the change in the `<input/>`. And it doesn't work if use code below just like what @CyberAP wrote for repro.
```vue
<template>
<div>
<input v-model="model" />... | 2020-06-29T12:05:42 | 2020-06-29T12:05:42 | {} | CONTRIBUTOR |
vuejs | core | 653,592,825 | 1,499 | yyx990803 | This is expected behavior. When you access `x` on the render context, you are getting a proxied version of it. Calling a method on the proxied object will call it with the proxied version as the receiver (i.e `this` context). If `this` is the non-proxied version of the object, it will not register reactivity.
In you... | 2020-07-03T15:17:21 | 2020-07-03T15:17:33 | {} | MEMBER |
vuejs | core | 653,586,677 | 1,227 | RobbinBaauw | ### Other advantages of direct field access
@yyx990803 I would also like to provide some alternative arguments than performance. Note that these are my personal opinions :)
First and foremost (arguably even more important than performance), readability. When working in teams, many pieces of code will not be written... | 2020-07-03T15:01:20 | 2020-07-03T15:21:10 | {} | CONTRIBUTOR |
vuejs | core | 653,744,618 | 1,502 | Awen-hub | 1. We can use a reversePatch to patch the reverse sequence. It can use less Map to set a key and check whther has the key. And I find it in an extreme example ( [a, b, c, d], [d, c, b, a] ) , the reversePatch can make patch process work about twice as fast.
2. When there is an unkeyed child in c2, store it's index i... | 2020-07-04T09:35:24 | 2020-07-04T09:35:24 | {} | NONE |
vuejs | core | 653,849,674 | 1,503 | HcySunYang | This is not a Vue's bug, the cause of the problem is that `vue3lib` installed vue itself and resolve the path to it, and `vue3App` also installed another `vue` and resolve the path to it. The `currentInstance` in these two `Vue` is not shared,
Just add the `alias` configuration in your `vue3App/vue.config.js`:
```... | 2020-07-05T06:47:52 | 2020-07-05T06:47:52 | {
"+1": 6
} | MEMBER |
vuejs | core | 654,480,793 | 1,525 | Jack97 | I've had a quick look at this one and the culprit seems to be in the following lines of code:
https://github.com/vuejs/vue-next/blob/6dd59ee301d8d93e7ca14447243d07a653e69159/packages/runtime-core/src/renderer.ts#L1994-L2003
I commented out the stop effect loop, and the watcher was triggered with the correct new v... | 2020-07-06T21:43:24 | 2020-07-06T21:43:24 | {} | CONTRIBUTOR |
vuejs | core | 654,645,053 | 1,533 | vue-bot | Hello, thank you for taking time filling this issue!
However, we kindly ask you to use our [Issue Helper](https://new-issue.vuejs.org/?repo=vuejs/vue-next) when creating new issues, in order to ensure every issue provides the necessary information for us to investigate. This explains why your issue has been automatic... | 2020-07-07T07:07:13 | 2020-07-07T07:07:13 | {} | CONTRIBUTOR |
vuejs | core | 650,970,380 | 1,461 | posva | What would be the value though? Last character, first one?
Can't you already achieve what you want:
```js
set(value) {
if (value.length > 1) this.value = this.value.slice(-1)
else this.value = value;
}
``` | 2020-06-29T06:57:37 | 2020-06-29T06:57:37 | {} | MEMBER |
vuejs | core | 652,609,558 | 1,458 | yyx990803 | Yeah you are right.
This was necessary in the case of using an async scheduler (exposed as `watchEffect`), before we added effect id-based sorting in the scheduler itself. But now the scheduler has id-based sorting so the effects are always flushed based on the order of creation, making this no longer necessary. | 2020-07-01T19:39:01 | 2020-07-01T19:39:01 | {} | MEMBER |
vuejs | core | 653,207,075 | 1,490 | dsonet | It would introduce unnecessary impact of the runtime performance just for very rare user cases., even though it's technically correct.
Just like concept vs the real world.
IMO the best way to deal with it is to put this into limitations section. | 2020-07-02T20:29:45 | 2020-07-02T20:30:17 | {} | CONTRIBUTOR |
vuejs | core | 653,243,091 | 1,483 | rhengles | Here's a more real world example: https://github.com/arijs/vue-next-example
Despite I know this will not be merged, I still would like some feedback 😊 | 2020-07-02T22:20:13 | 2020-07-02T22:20:13 | {} | NONE |
vuejs | core | 655,072,484 | 1,532 | jods4 | Watch, watchEffect and computed from vue are wrappers around the lower-level primitives `computed` and `effect` exported by the reactivity package.
You can import those to create watches that stop whenever you want. | 2020-07-07T19:22:49 | 2020-07-07T19:22:49 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 650,826,921 | 1,461 | CyberAP | For reference:
- React enables fully controlled mode if an input has a value binding (event a static one)
- Svelte enables controlled mode only if you specifically declare `bind:value`, just `value={value}` leaves input uncontrolled, updates value and does not prevent input
- Angular does not have a fully controll... | 2020-06-28T21:53:58 | 2020-06-28T21:53:58 | {} | CONTRIBUTOR |
vuejs | core | 651,270,513 | 1,461 | yyx990803 | We definitely don't want to introduce such a breaking change at this stage. But this can be introduced via a modifier, like `v-model.controlled`. I'd suggest opening an RFC for it anyway. | 2020-06-29T17:54:35 | 2020-06-29T17:54:59 | {
"+1": 1
} | MEMBER |
vuejs | core | 651,790,027 | 1,472 | yyx990803 | Good catch. Although it's too expensive to call `Object.defineProperty` like this. We can simply make the initial slot marker non-enumberable. See 062835d4 | 2020-06-30T13:27:20 | 2020-06-30T13:27:20 | {} | MEMBER |
vuejs | core | 652,138,414 | 1,472 | underfin | Thanks a lot for your explain. | 2020-07-01T01:47:12 | 2020-07-01T01:47:12 | {} | MEMBER |
vuejs | core | 652,742,058 | 1,458 | Picknight | Thanks for your explanation let me understand the historical reason here. | 2020-07-02T02:25:43 | 2020-07-02T02:25:43 | {} | CONTRIBUTOR |
vuejs | core | 653,008,970 | 1,491 | lockinmarv | Yes true, sounds reasonable to me. | 2020-07-02T13:34:34 | 2020-07-02T13:34:34 | {} | CONTRIBUTOR |
vuejs | core | 653,957,273 | 1,510 | CyberAP | You should add emits option to opt out of attribute fallthrough for event listeners.
```js
export default {
emits: ['update:modelValue'],
...
}
``` | 2020-07-06T00:06:17 | 2020-07-06T00:06:17 | {
"eyes": 2
} | CONTRIBUTOR |
vuejs | core | 654,452,726 | 1,512 | dsonet | It's may not a good idea to expose this logic in generated `ssrRender` function. I think the better way is to handle this in library layer. | 2020-07-06T20:36:58 | 2020-07-06T20:36:58 | {} | CONTRIBUTOR |
vuejs | core | 650,561,903 | 1,454 | HcySunYang | I don't think this is Vue's bug, the `maxLength` is a DOM property, and the `maxlength` is an attribute.
Native DOM behavior:
```js
el.maxLength = 10 // 10
el.maxLength = undefined // 0, cause can't input
```
If you want to reset `maxlength` you need to always use the `setAttribute/removeAttribute`：
```js
el.... | 2020-06-27T13:33:24 | 2020-06-27T13:33:24 | {} | MEMBER |
vuejs | core | 650,564,204 | 1,454 | tangjinzhou | maxlength is a DOM property. not maxLength.
In fact maxLength and maxlength should be the same behavior in vue. There is no such problem in vue2.
| 2020-06-27T13:55:10 | 2020-06-27T13:55:10 | {} | CONTRIBUTOR |
vuejs | core | 650,671,590 | 1,459 | Justineo | Please **DO NOT** abuse pull requests. Do experiments in your own repo. Thanks. | 2020-06-28T02:08:17 | 2020-06-28T02:08:17 | {} | MEMBER |
vuejs | core | 652,304,223 | 1,475 | ByScripts | @posva Yeah, you're probably right. I indeed seen a lot of Suspense because I seen a lot of news/articles/videos about Vue 3...
Will Suspense be "cascading" ? I mean, if i have a CompA using a CompB using a CompC and only CompC has an async setup loading data, does the Suspense in CompA will display the fallback ?
... | 2020-07-01T09:25:18 | 2020-07-01T09:25:18 | {} | NONE |
vuejs | core | 653,891,617 | 1,511 | danyadev | However, this is not the only problem with Keep-Alive. This is the second unplanned problem when trying to reproduce another bug:
(This is most likely due to the fact that there is no check for the lack of a deactivated hook)
![image](https://user-images.githubusercontent.com/35631027/86534173-eb6c9380-bede-11ea-... | 2020-07-05T13:52:27 | 2020-07-05T15:08:48 | {
"+1": 1
} | CONTRIBUTOR |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.