prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: LP unwrap / wrap is fully broken if master chef contract has insufficient reward token and block decollateralize wlp and wlp liquidation
### Description
LP unwrap / wrap is fully broken if master chef contract has insufficient reward token.
### Proof of Concept
We need to take a look at the external maste... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: drop optimization in opChallenge
### Description
The overridden `drop` function is called in `opChallenge`, which executes the generic `_after-AuthedAction` hook to reset some storage fields. However, within `opChallenge`, it is already known that the `opPoke` is not finalized yet, allowing for some optimizati... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Griefing of `CSModule.compensateELRewardsStealingPenalty()`
### Description
`CSModule.compensateELRewardsStealingPenalty()` [function is permissionless](https://github.com/lidofinance/community-staking-module/blob/a898d045b63303294752d1a60ad9dfe8d8ba69ca/src/CSModule.sol#L1096-L1108). At the same time [it's... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: AmAmm manager can manipulate TWAP prices without risk
### Description
The AmAmm manager of a pool can manipulate the TWAP price of the pool by swapping a large amount of assets and then setting the swap fee to a very high value in order to prevent others from arbitraging the pool.
The AmAmm manager of a po... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: Keep precision in _updateBatchFee()
### Description
The function `_updateBatchFee()` uses a trick to prevent losing precision in the calculation of `accDivisor`. The value `accDivisor` includes an extra multiplication with `batchFee`, which is undone when performing the operation:
```solidity
batchFee = (batc... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Wrong reward calculation leads to rewards being unclaimable/claimable once
### Description
Hello,
upon running the tests supplied by you and changing them a bit I came across an issue that I couldn't find in the audit but that leads to most likely a high impact. The main reward calculation of `RevenueHandler... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: Lack of maturity check for non-founder users allowing immediate withdrawals
### Description
### Finding description and impact
In the `AgentVeToken::withdraw()` function, the contract contains a check for the maturity of stakes, but this check only applies to the founding staker (`founder`). The condition ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Re-adding a removed reward token causes inconsistent userRewardPerTokenPaid accounting
### Description
When a reward token is removed from the staking contract, users who deposit afterwards never have their `userRewardPerTokenPaid` value updated for that token, so it remains `0`. If the same token is later ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Constant can be used
### Description
**Description**
Token.sol, Line 29. Token amount calculation can be moved to the public constant in order to
save gas during the deployment.
**Recommendation**:
Consider using the public constant. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Key State Changes Missing Events
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `e3957d84c8dfcb7b9ea5303a0c272bc874fe7c5b`. The client provided the following explanation:
> Added Events for key events
**File(s) affected:**`wstTAO.sol`
**Description:** Key state changes in the cont... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | front-running | false | false | ## Low: block.timestamp Can Be Manipulated By Miners
### Description
## Severity: Low Risk
## Context
- Periphery.sol
- GClaimManager.sol
- Space.sol#L160
- Space.sol#L401
- Space.sol#L435
- Divider.sol#L30
- Divider.sol#L33
- Divider.sol#L142
- Divider.sol#L368
- Divider.sol#L522
- Divider.sol#L564
- Divider.sol#L56... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | true | false | ## Low: External calls in loops may result in denial of service
### Description
The use of external calls in nested loops and subsequent loops, which iterate over lists that could have been provided by callers, may result in an out-of-gas failure during execution. To determine the total value of the collateral in the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Undefined behavior in base32
### Description
The `base32_encode` function is vulnerable due to how it processes certain inputs. Specifically, an `int` variable in each function can be left-shifted too many places, or left-shifted when its value is negative. Both instances lead to undefined behavior:
- The r... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Inefficient fee handling during InfraredBERADepositor execute may lead to delayed deposits
### Description
The current implementation applies the full fee from a slip during its first use, regardless of whether the entire slip amount is consumed. This may lead to issues for keepers or users who process partial... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Lack of Slippage Protection in `deposit()` and `mint()` Functions
### Description
The `MultipliVault` contract implements the ERC4626 standard but lacks essential slippage protection mechanisms for direct EOA interactions in the `deposit()` and `mint()` functions. According to `EIP-4626`, implementors shoul... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: `ConvexStakingWrapper`, `StakingRewards` Wrong implementation will send `concur` rewards to the wrong receiver
### Description
_Submitted by WatchPug, also found by bobi, CertoraInc, csanuragjain, danb, hickuphh3, and leastwood_
[ConvexStakingWrapper.sol#L246](https://github.com/code-423n4/2022-02-concur/blo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Governance can arbitrarily burn VeToken from any address
### Description
_Submitted by shenwilly_
Governance can burn any amount of `VeToken` from any address.
Unlike `VE3Token` which is minted when users deposit veAsset and burned when users withdraw, the `burn` function in the governance token `VeToken.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | false | false | ## High: MerkleVesting withdrawal does not verify that tokens were transferred successfully
### Description
_Submitted by kenzo, also found by IllIllI_
Across the codebase, the protocol is usually checking that ERC20 transfers have succeeded by checking their return value.
This check is missing in MerkleVesting's `wi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: Small division truncation
### Description
The contract uses a precalculated price for each tier based on the target amount of tokens to be sold per tier.
However, depending on the amounts sent by the users, the total amount of tokens sold may not match the target amount due to the accumulation of division tr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: Initial NOTE token funds could be lost
### Description
The [initialization of the `NoteERC20` contract](https://github.com/notional-finance/contracts-v2/blob/c37c89c9729b830637558a09b6f22fc6a735da64/contracts/external/governance/NoteERC20.sol#L83-L100) requires the `initialAccounts` array of addresses and `... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: `require()` or `revert()` statements that check input arguments should be at the top of the function
### Description
Checks that involve constants should come before checks that involve state variables
*There are 13 instances of this issue.* | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: RocketDAONodeTrustedAction - ambiguous event emitted in actionChallengeDecide ✓ Fixed
### Description
`actionChallengeDecide` succeeds and emits `challengeSuccess=False` in case the challenged node defeats the challenge. It also emits the same event if another node calls `actionChallengeDecided` before the ref... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: `setbidtobuy` allows token purchase even when sale is no longer listed
### Description
The `setbidtobuy` function is responsible for allowing buyers to submit bids to purchase a token listed for sale. A seller can invoke `setlistforsell` to list a token, specifying the price, payment token (denom), and whethe... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Inconsistent validation of money markets’ rewards address Difficulty: Medium
### Description
The validation of the `_rewards` address in the `HarvestMarket`, `AaveMarket`, `BProtocolMarket`, and `CompoundERC20Market` contracts is inconsistent. For example, in `HarvestMarket`, the initialization function checks w... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Contracts of the codebase will not strictly compliant with the ERC-1504.
### Description
Contracts of the codebase isn't strictly compliant with the ERC-1504. This breaks the readme.
### Impact
Break the readme.
### Recommendation
Make the contracts strictly compliant with ERC-1504. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: [18] Critical changes should use two-step procedure
### Description
Lack of two-step procedure for critical operations leaves them error-prone. Consider adding two-step procedure on the critical functions.
Consider adding a two-steps pattern on critical changes to avoid mistakenly transferring ownership of ro... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | false | false | ## High: Deadlock in vaults with underlying token with less then 18 decimals
### Description
If underlying token for the vault would have less then 18 decimals, then after liquidation there would be no way to process epoch, because `claim` function in `WithdrawProxy.sol` would revert, this would lock all user out of t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | true | ## High: "Votes" balance can be increased indefinitely in multiple contracts
### Description
The "voting power" can be easily manipulated in the following contracts:
- `ContinuousVestingMerkle`
- `PriceTierVestingMerkle`
- `PriceTierVestingSale_2_0`
- `TrancheVestingMerkle`
- `CrosschainMerkleDistributor`
- `Crosschai... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | false | false | ## Low: Updating Too Many Validator in a Single Update May Cause Out-of-Gas Error
### Description
The [`LookupValidatorsChanges` function](https://github.com/Fantom-foundation/Bridge/blob/558465d3aba2ffae1a4436a2fc14c723b82926df/internal/validators/validators.go#L18) is responsible for returning a list of validators w... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Widespread Undefined Behavior
### Description
## Solana Core Audit 05 | Vulnerabilities
## start_verify_transactions
The `start_verify_transactions` function triggers UB as soon as `set_len` is called on the uninitialized `Vec`.
**File Location:** `solana-labs:solana:entry/src/entry.rs` RUST
The most effi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | false | false | ## High: Lack of Refunds
### Description
The protocol allows users to bridge their ERC-20, ERC-721, ERC-1155, USDC, WETH, and ETH assets to the L2 rollup and back. If the target address is a contract, a callback is executed during the bridging transaction. For example, when calling the `deposit{ERC20|ETH}AndCall` func... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | true | false | ## Low: `StabilityPool::claimCollateralGains` should accrue depositor collateral gains before claiming
### Description
**Description:** `StabilityPool::claimCollateralGains` [reads](https://github.com/Bima-Labs/bima-v1-core/blob/09461f0d22556e810295b12a6d7bc5c0efec4627/contracts/core/StabilityPool.sol#L706-L713) `coll... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Reentry causing events misordering
### Description
At lines:
- https://github.com/nucypher/nucypher/blob/main/nucypher/blockchain/eth/sol/source/contracts/staking_contracts/PoolingStakingContractV2.sol#L105
- https://github.com/nucypher/nucypher/blob/main/nucypher/blockchain/eth/sol/source/contracts/staking... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Misplaced totalAssets function implementation
### Description
As part of the [`STETHVault`](https://github.com/pods-finance/yield-contracts/blob/c4b401ce674c24798de5f9d02c82e466ee0a2600/contracts/vaults/STETHVault.sol) contract implementation, the [`totalAssets`](https://github.com/pods-finance/yield-contracts... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | token | true | false | ## Severity: Medium Risk
## Context
- `PoolManager.sol#L185`
- `PoolManager.sol#L249`
- `PoolManager.sol#L269`
- `Periphery.sol#L375`
- `Periphery.sol#L465`
- `Periphery.sol#L472`
## Situation
The `bytes` variable is set by a string literal. The variable’s data in this case will be equivalent to the ASCII encoded dat... | Spearbit | 4 | Sense |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: `TARGET_HEALTH` calculation does not consider the adjust factors of the picked seize and repay markets
### Description
The `TARGET_HEALTH` calculation is correct, but returns the debt to pay considering that this debt corresponds to the average `adjustFactor`, which is false for more than 1 market, leading ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Proxy Manager Can Renounce onlyOwner Role
### Description
The `onlyOwner` role is granted to the deployer account of `AccessControlManagerProxy` by default. `AccessControlRegistry` implements a `renounceRole()` function which allows accounts to renounce granted roles belonging to them. The root role is strictl... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | false | false | ## High: Market coordinator can liquidate all users in the market
### Description
Source: https://github.com/sherlock-audit/2024-08-perennial-v2-update-3-judging/issues/29
## Found by
panprog
**Summary**
The README states the following:
> Q: Please list any known issues and explicitly state the acceptable risks for... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: BlockSpecimenProofChain::submitBlockSpecimenProof Block specimen producer can greatly reduce session duration by submitting fake block specimen in the future
### Description
Block specimen producers submit specimens for a given block number during a limited time called a session. Any block producer can star... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: Permanent Locking of User Funds in the Stability Pool
### Description
If the collateral is sunsetted and 180 days have passed, the sunsetted collateral will be replaced by newly added collateral. At this point, the `epochToScaleToSums` for the relevant index is reset to zero. This value may increase again if ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | overflow | true | false | ## Medium: Attacker can DoS lockers from unstaking from Kodiak
### Description
When staking in the `HoneyLocker` contract, the fields `totalLPStaked` and `vaultLPStaked` are increased by the amount of tokens being staked. When unstaking, these fields are decreased by the amount of tokens being unstaked. However, an at... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | true | false | ## Low: Bundle arrays in executePayroll()
### Description
The function `executePayroll()` has several array parameters. This requires several length checks to sanitize the input. The arrays could be bundled in a struct of arrays, which improves the readability of the rest of the code.
```solidity
function executePayr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | true | false | ## Gas: Use assembly to perform efficient back-to-back calls
### Description
If a similar external call is performed back-to-back, we can use assembly to reuse any function signatures and function parameters that stay the same. In addition, we can also reuse the same memory space for each function call (`scratch space... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | true | false | ## Low: Outdated reference to urBEAN3CRV Convert | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Possible manipulation with rewards period length.
### Description
**Description**
StWSX.sol, oracle Report Rewards()
Rewards reporting logic emits events with reward period length. However, there are no control methods to validate if oracles behave honestly - as for now periodLength can be arbitrary. For exam... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Cut-Off Price Retrieval May Return a Zero Price for Missing Token Entries
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `33628c64cfdfb3831bbf0bc0e2c03a62a632ad62`. The client provided the following explanation:
> Fixed
**File(s) affected:**`src/oracle/OracleRegistry.sol`
**Descri... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: When tokenX is an ERC777 token, users can bypass maxLiquidity
### Description
When tokenX is an ERC777 token, users can use callbacks to provide liquidity exceeding maxLiquidity
### Impact
users can provide liquidity exceeding maxLiquidity.
### Recommendation
Change to
```diff
function _provide(
uint2... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Type casting | true | true |
<https://github.com/jbx-protocol/juice-nft-rewards/blob/f9893b1497098241dd3a664956d8016ff0d0efd0/contracts/JBTiered721Delegate.sol#L240><br>
<https://github.com/jbx-protocol/juice-nft-rewards/blob/f9893b1497098241dd3a664956d8016ff0d0efd0/contracts/JBTiered721DelegateStore.sol#L628><br>
<https://github.com/jbx-protocol... | Code4rena | 3 | Juicebox |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | storage | false | false | ## High: minLiquidityRate formula
### Description
## Severity: High Risk
## Context
- MiniPoolDefaultReserveInterestRate.sol#L227-L254
- MiniPoolPiReserveInterestRateStrategy.sol#L197-L224
## Description/Recommendation
When the Mproxy does not have enough liquidity during a mini pool borrow, the following happens:
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | false | false | ## High: Malicious strategist could deny borrowers from repaying loan and force liquidation by setting a extremely high vault fee
### Description
**Issue:** A malicious strategist can deny the repayment of loans by setting a extremely high vault fee during creation of a public vault. The high vault fee will cause a re... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: ATA Validation for Custom Programs
### Description
## Instructions Overview
In the `deposit_staking_pool`, `redeem_vault`, and `withdraw_staking_pool` instructions, the `get_associated_token_address` constraint on `payer_associated_staked_token_account`, `pool_associated_staked_token_account`, `vault_associat... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Rewards can be claimed multiple times
### Description
_Submitted by johnnycash, also found by certora, cmichel, gpersoon, gzeon, harleythedog, kemmio, kenzo, sirhashalot, and 0x421f_
#### Impact
An attacker can claim its reward 256 \* `epochDuration` seconds after the timestamp at which the promotion starte... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: For loop over dynamic array
### Description
**Severity**: Medium
**Status**: Acknowledged
**Description**
The functions _updateRewards(), recoverClaim() and claim() function have a for loop over a dynamic array. This can lead to out of gas issues if the array becomes too large.
**Recommendation**:
It ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Using cached price to create a proposal reduce the efficacity of redemptions for asset peg
### Description
One of the conditions for updating oracle prices in Ditto is [when an action related to shorts is executed](https://dittoeth.com/technical/oracles#conditions-for-updating-oracle).
This is important bec... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: StopLoss/TakeProfit should be validated again for the new price in `Trading.executeLimitOrder()`
### Description
The open price of a stop order might be changed during execution but it doesn't validate StopLoss/TakeProfit for the changed price.
As a result, the executed market order might be closed immedia... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Inconsistent Lockup Period Calculation Allows Users to Game the System
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `b4c59bc4e68926746413e842fdaed3e6cd386934` and `cf36a2fac54e84904c51f8d419c04e215c7b35da`.
**File(s) affected:**`SapienVault.sol`
**Description:** The `SapienVau... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Rebase and deflationary tokens used as incentive can get stuck on the Bootstrap contract
### Description
The Bootstrap contract for incentives stores the amount of tokens "to be transferred", but not the amount which can be sent later.
- https://github.com/yearn/yETH-bootstrap/blob/2dd219d3af49952275934638e8c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: ZeroLend token is not behaving properly while contract is paused
### Description
Report type: Smart Contract
Target: https://github.com/zerolend/governance
Impacts:
- ZeroLendToken not properly behaving in prelaunch phase
## Description
## Brief/Intro
`ZeroLendToken` should allow to operate with Whitelist... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | flash-loan | true | true |
<https://github.com/code-423n4/2023-04-caviar/blob/main/src/PrivatePool.sol#L461>
<https://github.com/code-423n4/2023-04-caviar/blob/main/src/PrivatePool.sol#L623-L654>
`PrivatePool.sol` ERC721 and ERC20 tokens can be stolen by the previous owner via `execute` and `flashLoan` functions (or by malicious approval by t... | Code4rena | 5 | Caviar |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: `IBeforeInitializeHook` should be added to the `AngstromL2` inheritance chain
### Description
**Description:** `AngstromL2.sol` imports the `IBeforeInitializeHook` interface; however, it is not currently used. Given that `AngstromL2` is expected to implement this hook, it should be added to the inheritance cha... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | storage | false | false | ## Medium: `SmartAccount.sol` is intended to be upgradable but inherits from contracts that contain storage and no gaps
### Description
[contracts/smart-contract-wallet/base/ModuleManager.sol#L18](https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | flash-loan | false | false | ## Low: Calling `Router.onFlashLoan()` when `msgSender` is `address(this)`
### Description
`onFlashLoan()` can be called directly, which allows executing commands with the `msgSender` variable set to `address(this)`.
While this doesn't seem to be exploitable in a malicious way, it is recommended to ensure the `msgSen... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Bad UX on claiming
### Description
After claiming a user will lose all approvals on their tokens which can be inconvenient.
https://github.com/FantiumAG/smart-contracts/blob/a2d126453c1105028f12277b8f342d2cdbf01a77/contracts/FantiumNFTV3.sol#L803
### Recommendation
We recommend adding information for users th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Wrong Math | true | true | ## Lines of code
https://github.com/with-backed/papr/blob/9528f2711ff0c1522076b9f93fba13f88d5bd5e6/src/PaprController.sol#L264-L294
## Vulnerability details
## Impact
Function `purchaseLiquidationAuctionNFT()` purchases a liquidation auction with the controller's papr token. the liquidator pays the papr amount whic... | Code4rena | 5 | Backed Protocol |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | true | false | ## Low: Change `v3-rewards/package.json` to require minimum OpenZeppelin v4.9.2 as prior versions had a security vulnerability in Merkle Multi Proof
### Description
`v3-rewards/package.json` currently [specifies](https://github.com/SolidlyV3/v3-rewards/blob/6dfb435392ffa64652c8f88c98698756ca80cf28/package.json#L7) a m... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: Investors will not be able to withdraw tokens after the end of the vesting duration for Ecosystem in UnmarshalTokenVesting
### Description
**Description**
Array ecosystemVesting length is equal to 50. If more than 50 months have passed since the
initial time function _calculateAvailablePercentage will lead t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Uppercase immutable variables
### Description
In [VRFNFTRandomDraw.sol#L22-L26](https://github.com/code-423n4/2022-12-forgeries/blob/main/src/VRFNFTRandomDraw.sol#L22-L26):
In [VRFNFTRandomDraw.sol#L37](https://github.com/code-423n4/2022-12-forgeries/blob/main/src/VRFNFTRandomDraw.sol#L37):
In [Version.sol... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Remove comments which no longer apply
### Description
**Description:** Comments which no longer apply should be removed as they are now misleading.
File: `L1MessageServiceV1.sol`
File: `L1MessageService.sol`
**Linea:** Fixed in [PR256](https://github.com/Consensys/linea-monorepo/pull/256) commits [ac51e9e... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Marked active despite not having enough collateral
### Description
**Severity**: Medium
**Status**: Resolved
**Description**
GatewayManagerFacet.sol - In `register()` function, collateral is not being validated to be greater than `s.minStake`. Consequently we end up having a subnet status marked as Statu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: ESynth.mint can emit 0- Transfer events for non-allowed minters
### Description
The `mint` function can currently be called by anyone, even if they're not an authorized minter. Authorized minters are the ones for whom the admin has set capacity.
To avoid this, the function should revert if `amount == 0`, whi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: [02] `PriceFeed#getSqrtPrice()` could over/undervalue the quote price leading to wrong liquidation decisions
### Description
https://github.com/code-423n4/2024-05-predy/blob/a9246db5f874a91fb71c296aac6a66902289306a/src/PriceFeed.sol#L45-L58
This function returns the square root of the `baseToken` price quote... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Incorrect behaviour of private tokens claiming
### Description
**Description**
It is expected that the function claimPrivateTokens (lines 464-473) of Unbonded smart contract
should have an ability to claim tokens by the owner of the contract but it is not implemented.
**Recommendation**:
Change function acc... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Issues Identified with Fuzzing
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `4b7ab849a543e2e40cfb139710fcf4502713cc97` The client provided the following explanation: Removed `_addressToBytes32()`, `_bytes32ToString()`, unused imports.
Further the client acknowledged: We add docum... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Centralization risk
### Description
If the `guardian` address in the `CHNGovernance` contract is compromised, all the critical functionalities of the `CHNTimelock` contract will be compromised. The `guardian` address can directly change the `admin` address in the `CHNTimelock` contract via the `__queueSetTimel... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Boolean equality
### Description
In the `vesting` module, both the `claim` and `cancel` functions include assertions that compare a boolean expression to `false`, leading to unnecessary gas consumption.
Code Location
-------------
The `claim` function includes an assertion that compares a boolean expression ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: MISSING ZERO ADDRESS CHECK
### Description
The functions `addEligibleHolder`, `removeEligibleHolder` and `isEligibleHolder` do not perform verification to ensure that no addresses provided as parameters are the zero addresses. Consequently, there is a risk of accidentally setting an eligible holder address to ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: ChainlinkAtlasWrapper allows retransmitting old reports
### Description
When `transmit()` is called on the `ChainlinkAtlasWrapper`, there is nothing checking that the report and corresponding signatures haven't been used before. While the transmitters are whitelisted and trusted to an extent, this behavior ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | false | false | ## High: Misuse of SHA512 Leads to Password Vulnerable to Exposure
### Description
**Update**
The fix entails use of the `@metamask/browser-passworder` library. Users are automatically upgraded from the old scheme to the new one.
Marked as "Fixed" by the client. Addressed in: `8b90784`. The client provided the follow... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Timestamp usage
### Description
There’s a problem with using timestamps and **now** (alias for **block.timestamp**) for contract logic, based on the fact that miners can perform some manipulation. In general, [it’s better not to rely on timestamps for contract logic](https://github.com/ConsenSys/smart-contr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Ownership Can Be Renounced
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `b166e5b`. The client provided the following explanation: _`renounceOwnership()` is overwritten and deactivated in `BatchTrade` and `ExchangeAdapterRegistry`_
**File(s) affected:**`BatchTrade.sol`, `ExchangeAd... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Replace `==` balance comparison with `>=`
### Description
Even if the initial distribution is supposed to have an exact number of tokens, it is safer to check that the [function to distribute them](https://github.com/code-423n4/2024-01-salty/blob/53516c2cdfdfacb662cdea6417c52f23c94d5b5b/src/launch/InitialDistr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | true | false | ## Low: Unfavorable placement of require check
### Description
In the `repay` method the `MarginAccount` contract, the `amount` is checked before it is potentially modified again a few lines below. In the case of initially `amount == 0`, the transaction could revert due to an arithmetic underflow error instead of fail... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: `TOFTMarketReceiverModule::marketBorrowReceiver` flow is broken
### Description
The `TOFTMarketReceiverModule::marketBorrowReceiver` flow is broken and will revert when the Magnetar contract tries to transfer the ERC1155 tokens to the Market contract.
### Impact
The `TOFTMarketReceiverModule::marketBorrowR... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | false | false | ## Medium: The default value of epsilon differs from what is stated in the whitepaper
### Description
The default value of epsilon differs from what is stated in the whitepaper
### Impact
Precision will be tight
### Recommendation
```diff
-Epsilon: alloraMath.MustNewDecFromString("0.0001")
+Epsilon: alloraMath.Mus... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Missing sanity checks when setting the `tokenConfig`
### Description
The `addSupportedAsset()` function allows the admin to add new tokens with built-in sanity checks to ensure token validity:
However, during deployment, new tokens are added using the internal `_setTokenConfig()` function, which lacks these ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Unauthenticated calls can be made to the VM from the wallet implementation contract
### Description
Severity: Medium Risk
Context: WeirollWallet.sol#L4-L5
Description: The combination of using both ClonesWithImmutableArgs and Weiroll VM is made interest-
ing because delegatecall is a supported calltype. Clo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | dos | true | false | ## High: Malicious WASM program can cause denial of service attack against SEDA validators through unbounded stdout/stderr
### Description
The absence of size limits on WASM stdout/stderr outputs will cause a denial of service vulnerability for SEDA validators as attackers can exhaust node memory by creating data requ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Positions can be locked by malicious re-initialization in the event of multiple `ValkyrieSubscriber` contracts being deployed
### Description
**Description:** `IncentiveManager::notifyInitialize` does not currently check whether there is already an assigned hook corresponding to a give pool identifier:
There... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Bypass token-account address whitelisting with `SetAuthority`
### Description
The check_transfer_account() function validates transfers by comparing the source token-account’s
address (source_token.key()) against the whitelisted_wallets array.
That means the hook trusts the account itself, not the wallet that ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | true | false | ## Medium: Usage of **revert** in case of low gas in `L1CrossDomainMessenger` can result in loss of fund
### Description
I am reporting this issue separate from my other report `Causing users lose fund if bridging long message from L2 to L1 due to uncontrolled out-of-gas error`, as I think they provide different attac... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Removing a `UniswapV3Gauge` via `UniswapV3GaugeFactory` does not actually remove it from the `UniswapV3Staker`. The gauge still gains rewards and can be staked too (even though deprecated). Plus old stakers can game the rewards of new stakers
### Description
Gauge factories have a [`BaseV2GaugeFactory::remo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Slow Mode Transactions With Sender Value Allowed As Endpoint
### Description
## Endpoint Contract Overview
In the Endpoint contract, `processSlowModeTransaction` allows the transaction in a special case other than `msg.sender == txn.sender`. As it uses the `validateSender` function, it allows `txnSender ==... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Transaction executed successfully in _execute parameter edge case.
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
In contract SwapFacet, function _execute logic choose the type of operation that will be performed based on the opType variable, the value for opType can be 0,1... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | initialization | true | false | ## Context
(No context files were provided by the reviewer)
## Description
The `ParticlePositionManager` contract has a line in the constructor (which is currently commented out to deploy on mainnet, but will be uncommented when it is deployed on Blast) intended to configure the yield and gas modes of the contract as ... | Cantina | 4 | Particle |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: There are hard-coded values in the code
### Description
There are hard-coded values in several Marmo contracts. For example, [65536](https://github.com/ripio/marmo-contracts/blob/d3fb5922a4f01e47d585343d08cccfad659b3584/contracts/MarmoStork.sol#L65) and [0xff](https://github.com/ripio/marmo-contracts/blob/d3fb... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: [25] Import declarations should import specific identifiers, rather than the whole file
### Description
### Proof of Concept
Multiple instances in scope; for example, see [here](https://github.com/code-423n4/2024-06-badger/blob/9173558ee1ac8a78a7ae0a39b97b50ff0dd9e0f8/ebtc-protocol/packages/contracts/contract... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Session with Duplicate Tokens Can Not Be Settled
### Description
When creating sessions, users can put the same token twice, where there is no check in either `CredibleAccountModule::enableSession()` or `InvoiceManager::createInvoice()` that prevents this behaviour.
The problem is that when claiming, both ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | false | false | ## Medium: Arbitrary unitOfAccount Asset Could Cause Liquidations or Erroneous Value Conversions
### Description
The `Liquidation` contract implements the functionality to calculate and liquidate debt positions a user might have. To do so, each vault proxy defines at deployment the [`unitOfAccount` asset](https://gith... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Loss of Private Keys Leads to Rewards and Fees Allocation Lock
### Description
**Update**
Fees and rewards are being allocated at purchase time via `_allocateFeesAndRewards()`.
**Update**
Marked as "Fixed" by the client. Addressed in: `9cce282fd2f97c3974fe88d4b54e93d600ec558c`.
**File(s) affected:**`Subs... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | true | false | ## Low: Reentrancy risks
### Description
There is a reentrancy risk in `claimRewards()`:
- Assume the treasury wants to be proactive and immediately `deposit()` the fee back into the SonicStaking protocol.
- The treasury gains control at `treasury.call{...}("")` of `claimRewards()` and can initiate further actions.
- ... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.