prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Repository does not contain Ethereum development environmentconfiguration.
### Description
**Recommendation**:
use Truffle or Hardhat toolkits for automating of running tests, deployments and migrations. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | true | false | ## Medium: `OracleManage::generatePerformance` reverts if deactivating validator with ongoing rebalance request
### Description
`OracleManager::generatePerformance` is intended to update the stats of every validator and the `totalBalance` in `ValidatorManager`. This function is called once an hour (or at whatever inte... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | initialization | true | false | ## Gas: State variables only set in the constructor should be declared `immutable`
### Description
Avoids a Gsset (**20000 gas**) in the constructor, and replaces each Gwarmacces (**100 gas**) with a `PUSH32` (**3 gas**).
*There is 1 instance of this issue:* | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Multiple Purchases of the Same Marketplace Item by Different Users.
### Description
**Severity**: Informational
**Status**: Acknowledged
**description**
bpnmMain.sol: purchaseMarketplaceItem().
The function allows multiple users to purchase the same item from the marketplace. This
could be either intentiona... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | false | false | ## Low: Traders can't limit slippage and expiration time when creating market orders
### Description
Traders can't limit slippage and expiration time when creating market orders.
### Impact
Traders' orders may be filled later and at a less favorable price than they were expecting.
### Recommendation
Allow traders to... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | false | false | ## High: Attacker will prevent any raffles by calling `WinnablesTicketManager::cancelRaffle` before admin starts raffle
### Description
The [`WinnablesTicketManager::cancelRaffle`](https://github.com/sherlock-audit/2024-08-winnables-raffles/blob/main/public-contracts/contracts/WinnablesTicketManager.sol#L278) function... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: `executeTokenSwap` can be called with empty `externalTrades`
### Description
It is possible that during the rebalancing process, `externalTrades` is empty, and the external swap should not be performed. However, `executeTokenSwap` can still be called with empty `externalTrades`. While this has no serious impac... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | false | false | ## High: MISCALCULATION OF MAX LOAN TO VALUE WHEN QUERYING AVAILABLE COLLATERAL
### Description
In the `query_collateral_available` function in the **krp-cdp-contracts/central\_control** contract, the value of `max_loans_value` is miscalculated, and its value is overwritten in each step of the `for` loop. As a consequ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | false | false | ## High: Vault: The attacker can sandwich attack himself on swaps in open_position, close_position and reduce_position to make a bad debt
### Description
The attacker could call MarginDex to open/close postions in Vault. The swap slippage is controlled by the attacker. He can set the slippage to infinite to steal from... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | access-control | true | false | ## Gas: Functions guaranteed to revert when called by normal users can be marked `payable`
### Description
If a function modifier such as `onlyOwner` is used, the function will revert if a normal user tries to pay the function. Marking the function as `payable` will lower the gas cost for legitimate callers because th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | overflow | true | false | ## Gas: Don't use `SafeMath` once the solidity version is 0.8.0 or greater
### Description
Version 0.8.0 introduces internal overflow checks, so using `SafeMath` is redundant and adds overhead
*There are 2 instances of this issue:* | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | false | false | ## Medium: `XChainController::sendFundsToVault` can be griefed and leave `XChainController` in a bad state
### Description
A user can grief the send funds to vault state transition during by calling `sendFundsToVault` multiple times with the same vault.
### Impact
XChainController ends up out of sync with the vault(s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unused constant BIPS
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
VaultMath.sol - unused constant BIPS declared in the library.
**Recommendation**
Better be removed if not needed. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Inconsistent use of afterInitialized modifier in contracts
### Description
Several contracts in Augur’s code base are intended to be deployed behind the [EIP 1167](https://eips.ethereum.org/EIPS/eip-1167) minimal proxy contract. Therefore, to be able to replace the `constructor` function, they all inherit func... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: [3] There is no fee cap on the `Factory.setProtocolFeeRate` function. A value greater then 10000 can break the fee calculations in private pool. Consider validating that the input is less than 10000. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: `SwingTraderManager.deployedCapital()`: should use memory instead of storage variable
### Description
See @audit tag | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: The amount of debt removed during `liquidation` may be worth more than the account's collateral
### Description
The contract decreases user's debts but may not take the full worth in collateral from the user, leading to the contract losing potential funds from the missing collateral.
### Proof of concept
Du... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | liquidation | false | false | ## Gas: `storage` variable can be replaced with `calldata` variable
### Description
In the `Swapper._buildPermitTransferPayload` the `Collateral` struct is passed into the function as a `storage` variable named `collatInfo`. But it is only read from and not written to within the scope of the function implementation. H... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Incorrect handling of metadata traits in the attributes of `MetadataFacet::uri`
### Description
**Description:** For fully on-chain metadata, external clients expect the URI of a token to contain a base64 encoded JSON object that contains the metadata and base64 encoded SVG image. As raised previously, if thes... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | false | false | ## Low: `MIN_STAKING_AMOUNT` too low
### Description
During a `Staking::stake()` call, a `Staked` event is emitted to inform SXT nodes. The staking contract defines a `MIN_STAKING_AMOUNT` to prevent users from making extremely small stakes to spam the SXT chain. However, SXT token has 18 decimals, but the current `MIN... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: Incorrect condition would cause DoS on subscription and redemption
### Description
User's effective USD value applicable for fees is determined via `_getEffectiveUSDValueAndUpdateUserFeeConfig` function. This function will currently fail under certain circumstances for `UserFeeMode.NO_FEE_AFTER_LIMIT` mode.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | Front-Running | false | false | ## Handle
cmichel
## Vulnerability details
The `VaderPoolV2` `mintFungible` and `mintSynth` functions perform an unsafe `nativeAsset.safeTransferFrom(from, address(this), nativeDeposit)` with a parameter-specified `from` address.
Note that these functions are not called by the Router, they are directly called on t... | Code4rena | 4 | Vader Protocol |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Missed `safeApprove`
### Description
`Booster` uses `approve` method (https://github.com/convex-eth/platform/blob/754d9e700693246275b613e895b4044b63ce9ed5/contracts/contracts/Booster.sol#L288):
```solidity
IERC20(token).approve(rewardContract, _amount);
```
It's better to use `safeApprove`.
### Recommendat... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: Bridge gas limit parameter lacks lower bound validation leading to potential failed deliveries
### Description
**Description:** The `updateGasLimit` function in the `USDCBridge` contract allows an admin to set the `gasLimit` parameter to any arbitrary value. This parameter is used when quoting and sending cros... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | storage | false | false | ## High: Function `processEpoch()` in PublicVault would revert when most of the users withdraw their funds because of the underflow for new yIntercept calculation
### Description
When users withdraw their vault tokens PublicVault mint WithdrawProxy's shares token for them and at the end of the epoch PublicVault would ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Comparisons: != is more efficient than > in require (6 gas less)
### Description
!= 0 costs less gas compared to > 0 for unsigned integers in require statements with the optimizer enabled (6 gas)
For uints the minimum value would be 0 and never a negative value. Since it cannot be a negative value, then the c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Hackers can deploy token with respective name as the stable one to impersonate the stable token
### Description
Hackers can deploy tokens with respective names as the stable ones to impersonate the stable token. Then hackers can get profit from the malicious price oracle.
### Proof of Concept
string mem... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: PublicAllocator.reallocateTo does not revert when an unauthorized market is provided, creating a potential re-entrancy attack vector
### Description
To solve the liquidity fragmentation on MetaMorpho, the `publicAllocator` allows anyone to move the funds within the pre-configured limit. These limits are checke... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | initialization | false | false | ## Gas: Variables in non-upgradeable contracts which are only set once in `constructor` should be declared `immutable`
### Description
**Description:** Variables in non-upgradeable contracts which are only set once in `constructor` should be declared `immutable`:
* `PledgeManager::holderWallet`, `propertyToken`, `stab... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: `findNewOwner` edgecase
### Description
_Submitted by gpersoon_
In the function `findNewOwner` of `RCOrderbook`, as loop is done which included the check `_loopCounter 1.
**[Splidge (Reality Cards) confirmed and disagreed with severity](https://github.com/code-423n4/2021-08-realitycards-findings/issues/27... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Code relies on vulnerable NPM packages
### Description
Running `npm audit` over the codebase produces the following warning:
- **Found:** 1805 vulnerabilities (1000 low, 5 moderate, 800 high) in 1634 scanned packages.
The 1,805 vulnerabilities involve the 12 advisories in Table 1.1. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | false | false | ## Medium: Cannot liquidate Morpho users if no liquidity on the pool
### Description
Morpho implements liquidations by repaying the borrowed asset and then withdrawing the collateral asset from the underlying protocol (Aave / Compound). If there is no liquidity in the collateral asset pool, the liquidation will fail. ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | access-control | true | true | ## Medium: All swaps will revert if the dynamic protocol fee is enabled since `hook-config.sol` does not encode the `afterSwapReturnDelta` permission
### Description
If `AngstromL2::setPoolHookSwapFee` is called by the owner to configure the dynamic hook protocol fee to a non-zero value then the Uniswap V4 delta accou... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | dos | true | true | ## Medium: DoS of strategy execution due to array indices out of bounds
### Description
`StrategyBuilderPlugin._validateStep()` intends to enforce that the condition results reference a new index that does not exceed the maximum step index:
```solidity
function _validateStep(StrategyStep memory step, uint256 maxStepI... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Vault Can Become Permanently Paused if Admin Roles Are Set to Zero
### Description
In the `Auth2Step` contract, which extends Solmate’s Auth, there is currently no safeguard preventing both the owner and the auth address from being set to the zero address simultaneously. This is a highly unlikely configuration... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | token | true | true | ## Medium: Seizing payouts for frozen users can lead to double spending if the holder is unfrozen in subsequent distributions
### Description
The `ChildToken::seizeFrozenFunds` function is designed to perform the following operations:
- Permit the legitimate holder to claim all dividend distributions accrued prior to ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | access-control | true | true | ## Medium: `AdminImpl::ownerWithdrawExcessTokens` does not check the solvency of given market before attempting to withdraw excess tokens
### Description
[`AdminImpl::ownerWithdrawExcessTokens`](https://github.com/feat/dolomite-margin/blob/e10f14320ece20d7492e8e68400333c5c7dec656/contracts/protocol/impl/AdminImpl.sol#... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | Reentrancy | true | true | ## Security Report
## Severity
**High Risk**
## Context
- `GenericBridgeFacet.sol#L69-L120`
- `LibSwap.sol#L30-L68`
## Description
With the contract `GenericBridgeFacet`, the functions `swapAndStartBridgeTokensGeneric()` (via `LibSwap.swap()`) and `_startBridge()` allow arbitrary function calls, which enable anyone ... | Spearbit | 5 | LI.FI |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Whitelisted Or Super Whitelisted Users Cannot Be Removed
### Description
The owner can add a validator to the `whiteList` to reduce the ETH deposit required to make a new validator from **16 ETH** to **1 ETH**. Similarly, users can be added to the `superWhiteList` and then can create a new validator for no cos... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: [04] MIPS: The wrong variable name `v1` is used to denote register 7 instead of `a3`
### Description
In `handleSyscall` the variable `v1` is used to refer to register 7 which is where the error code of the syscall is stored. However, the correct variable name of register 7 is `a3`. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Unchecked return value for transferFrom calls
### Description
There are two `transferFrom` calls that do not check the return value (some tokens signal failure by returning false):
**code/contracts/pool/Pool.sol:L121**
```
stakedToken.transferFrom(from, address(this), amount);
```
**code/contracts/gene... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Explicit visibility of `workerFraction`
### Description
Explicit statements make code more readable.
https://github.com/nucypher/nucypher/blob/main/nucypher/blockchain/eth/sol/source/contracts/staking_contracts/PoolingStakingContractV2.sol#L46
### Recommendation
Add `public` visibility modifier | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: Lack of input validation for new values in MarinateV2.sol setters.
### Description
**Description**
MarinateV2.sol - addApproved Multiplier Token, setScale & setDepositLevel: new values are not validated before setting. For instance, there's no upper nor lower limit for mulptiplierthat is set in addApproved... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: Misleading Return Value in Guardian Value Retrieval
### Description
The `getGuardedValue` method returns `(0, 0)` when the minimum guardian threshold is not reached, which can be critically misinterpreted by other protocols:
- Returns a seemingly valid zero value instead of explicitly indicating a failure
-... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: [L-01]
### Description
It's possible to call the method [addAsset](https://github.com/code-423n4/2022-03-rolla/blob/efe4a3c1af8d77c5dfb5ba110c3507e67a061bdd/quant-protocol/contracts/options/AssetsRegistry.sol#L60) multiple times with the same `_underlying`, if you call `addAsset` with empty `symbol` it will by... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | true | false | ## Low: [09] Pausing `deposit(uint256 assets, address to, uint256 minSharesOut)` function causes stakers to lose slippage protection when depositing into vault
### Description
It is possible that the following `pauseVault` function of the `Core` contract is called to pause the `Vault` contract's `deposit(uint256 asset... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: There are two rewards claiming systems that are not compatible
### Description
There are two reward distributing systems for the game winners in the current code which are not compatible with each other. One issue is that there isn't enough functionality to withdraw pot and use PayoutManager to distribute the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | Business Logic | false | false | ## Severity: High Risk
## Context
balancer-v2-monorepo
## Description
The ManagedPool smart pool implementation of WeightedPool is still in active development by the Balancer team and could have unknown bugs. Additionally, the current version in Balancer’s GitHub is different from the version used in Mannon Vault.
... | Spearbit | 5 | Gauntlet |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Unused Constant
### Description
The `SignatureValidator` contract declares the following constant, but it is never used.
```
// bytes4(keccak256("isValidSignature(bytes32,bytes)")
bytes4 internal constant EIP1271_MAGICVALUE = 0x1626ba7e;
```
### Recommendation
Unused variables should be cleaned up from the c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Contract Vault doesn't override the `maxMint()` function
### Description
In the contract Vault, there is `assetLimit` to make sure that Vault won't receive more than that amount of assets. Function `deposit()` checks this limit but function `mint()` has no such check so it would be possible to bypass that limi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | false | false | ## Low: Checks-Effects-Interactions Pattern Violation
### Description
**Update**
The CEI pattern was applied to all listed functions in commit `a788632`.
**File(s) affected:**`Vepoch.sol`
**Description:** The [Checks-Effects-Interactions](https://solidity.readthedocs.io/en/latest/security-considerations.html#use-the... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: Inflation attack to steal first deposits
### Description
The `updateTotalAssets()` function, callable by the owner or rebalancer, can be exploited to perform an inflation attack against initial depositors. This vulnerability exists because the function updates the contract's total assets and stores it in the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: Tickets can be entered after prizes for current round have partially been distributed
### Description
The `ThrusterTreasure` contract is designed to facilitate a lottery game where users can enter tickets to win prizes based on entropy. The contract includes mechanisms for entering tickets into rounds (`ent... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: Exact duplicate FiatToken and MintForwarder contract can be deployed
### Description
The `TokenFactory.deployToken` and `MintForwarderFactory.deployMintForwarder` functions use `msg.data` to generate the create2 salt for `FiatTokenProxy` and `MintForwarder` deployments. The intention of this approach is to hav... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Potential Security Implication of Indefinite Validity for EOA Owner-Signed User Operations
### Description
**Update**
The client acknowledged the issue with the following comment: "A similar (but perhaps less severe as there are less intermediaries) issue exists with regular signed transactions, and as noted i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `_isValidToken()` check should not allow SDT
### Description
When a new vault and reward distributor are created using the PoolFactory, we add the reward tokens to the new StakeDAO reard distributor as follows:
1) We manually add CRV and SDT as reward tokens.
2) We iterate through all extra reward tokens from ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | token | false | false | ## Gas: Using bools for storage incurs overhead (5 instances)
### Description
Deployment Gas Saved: **60 668**
Avg. Method Call Gas Saved: **1 191**
`forge snapshot --diff`: **9 748** Gas Saved
// Booleans are more expensive than uint256 or any type that takes up a full
// word because each write operation emits ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Incorrect length of input data
### Description
`paths.length` can be < `creditFilter.allowedTokensCount()`:
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/contracts/credit/CreditManager.sol#L816
### Recommendation
We recommend adding a check that arrays ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: COLLATERAL LIQUIDATION IS NOT WORKING AS EXPECTED
### Description
The `liquidate_collateral` function in the **krp-cdp-contracts/central\_control** contract is querying its own balance instead of the balance of **krp-cdp-contracts/stable\_pool** contract. As a consequence, some unexpected situations can happe... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Missing unique signer check in `signers_setter` function
### Description
It was observed that while initializing the DVM program, a check ensures only unique signers are added to the program, preventing operational issues caused by non-unique signers. However, a similar check is missing in the `signers_setter`... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Index not checked
### Description
Index `i` must be less than `N_COINS`:
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/contracts/adapters/CurveV1.sol#L40
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Implement some type of version counter that will be incremented automatically for contract upgrades
### Description
As part of the upgradeability of Proxies , the contract can be upgraded multiple times, where it is a systematic approach to record the version of each upgrade.
```js
function upgradeTo(addres... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | rounding | true | false | ## High: Reward tokens can become inaccessible due to revert when `rewardPerTokenStored` is downcast and overflows
### Description
**Description:** The return value of `_newRewardPerToken()` that is assigned to the `rewardPerTokenStored` state variable present in all incentive logic contracts is not safe to be type ca... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Epoch Mismatch in Storage Reclamation
### Description
## Storage Resource Modification
`storage_resource::split_by_epoch` modifies an existing storage object by splitting it into two separate objects. The original storage is modified to have `start_epoch → split_epoch`, while a new storage object is create... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: Users can use the protocol freely without paying any fees by calling the `DecentEthRouter::bridgeWithPayload()` function directly.
### Description
### The execution flow of `bridgeAndExecute` function
To understand the vulnerability, we need to understand the execution flow of the [`bridgeAndExecute()`](ht... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | overflow | false | false | ## Medium: unexpected overflow for `FullMath.add512()` which can result in irregular behavior
### Description
The vulnerability originates from insufficient checking in add512 function, where the AddOverflow revert gets bypassed, essentially the function assumes that an overflow only happens if (addendA1 > sum1), wher... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | false | false | ## Medium: Potential Precision Loss Due to Division Before Multiplication
### Description
**Severity**: Medium
**Status**: Resolved
**Description**
The calculateEmissionPerSecond function in SingleLiquidityProvider.sol performs division before multiplication in the line ((apy / 100) * investmentAmount) / timePeriod... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Users might immediately be liquidated after position opening leading to a loss of CVA and Liquidation fee
### Description
The insolvency check (`isSolventAfterOpenPosition`) within the `openPosition` function does not consider the locked balance adjustment, causing the user account to become insolvent immed... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Routes can be more strictly checked
### Description
The only check performed when setting a new route is that it must be `>= MIN_UNIV3_ROUTE_LENGTH`. However, there aren't checks to ensure that it's properly encoded.
There are 2 possible checks to validate the route:
1. ensure `(_route.length - 20) % 23) == ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Unnecessary low level call
### Description
The implementation of `approveAndCall` is using a low level `call` to invoke a function on another contract. A comment explains this is *“so one doesn’t have to include a contract in here just for this”*. We would actually strongly recommend including the extra contra... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: Missing Slippage Checks
### Description
## Summary of Vulnerability in `get_lp_by_cake`
The function `get_lp_by_cake` does not properly perform slippage checks against an oracle price when swapping assets around. This mainly occurs in the functions `swap_exact_x_to_y_direct_external` and `add_liquidity_from_... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | false | false | ## Medium: An error in the `minOrderSize` check
### Description
```javascript
function _validateBondingCurveBuy(uint256 minOrderSize)
internal
returns (uint256 totalCost, uint256 trueOrderSize, uint256 fee, uint256 refund, bool shouldGraduate)
{
// Set the total cost to the amount of ETH sent
totalCost = msg... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | true | false | ## Low: Comparison in `_calcPayout()` should include equality
### Description
In the case where `elapsed == duration`, `proportionNow` evaluates to `1e18`, which is the same result when `elapsed > duration`. Proof below.
```solidity
proportionNow =
uint256(initialProportion) +
uint256(1e18 - initialProportion).wm... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Storage pointer for structs
### Description
Using a `storage` pointer is cheaper than reading a struct field several times.
### Proof of Concept
Instances:
##### src/modules/Buyout.sol
### Recommended Mitigation Steps
Use a `storage` pointer:
* original gas costs
╭──────────────────────┬─────────────... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Controller.inCaseStrategyGetStuck does not update balance
### Description
## Handle
cmichel
## Vulnerability details
The `Controller.inCaseStrategyGetStuck` withdraws from a strategy but does not call `updateBalance(_vault, _strategy)` afterwards.
## Impact
The `_vaultDetails[_vault].balances[_strategy... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: Missing `Unstaked` event for immediate unstake in `UnstakeCooldown::transfer`
### Description
**Description:** When `UnstakeCooldown::transfer` triggers an immediate unstake (i.e. the handler’s call to `proxy.request()` returns `unlockAt <= block.timestamp`), the function returns early after returning the prox... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Unobvious durations of time in `_checkCLBalanceDecrease()`
### Description
Two-time durations (`18 days` and `54 days`) are used directly in `_checkCLBalanceDecrease()` which is not obvious and explained only in the documentation. This might reduce code readability.
https://github.com/lidofinance/core/blob/ef... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Unbounded Royalty Collectors per Token
### Description
**Update**
Marked as "Acknowledged" by the client. The client provided the following explanation: "We control royalty setting, this is not a concern for us. It is clear from our business model and terms of service that we limit royalties set on the tokens.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Unnecessary Non-Owner Check When Removing an Address From the Blacklist
### Description
The `notOwner` modifier prevents the owner address from being removed from the blacklist. However, since the owner address can't be blacklisted, it should never be on the blacklist in the first place, and even if it were, i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Incorrect Parent Initializer in BridgedToken
### Description
The `BridgedToken` contract inherits from `ERC20PermitUpgradeable`, however, it [calls `__EIP712_init`](https://github.com/Consensys/linea-contracts/blob/f08c1906855198e2dc0413a47dcb38291b7087e5/contracts/tokenBridge/BridgedToken.sol#L31) instead of ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Invalid Zero Rate Not Rejected During Deposit
### Description
**Description:** When despoiting assets, and convert the shares to be minted to the despositer we are not checking the validity of rate value (weather it is greater zero or not)
> bc-solana-vault-sc/programs/sc-vault/src/utils/conversions.rs#conver... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Missing Pause Modifier On the InsuranceFunds contract
### Description
In case a hack occurs or an exploit is discovered, the team should be able to pause functionality until the necessary changes are made to the system. The deposits should be paused with Pause modifier.
### Proof of Concept
Navigate to the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Update `lastWithdrawRefresh` only if it has changed
### Description
Gas saved: ~100
At [`leakyRefresh()`](https://github.com/reserve-protocol/protocol/blob/c4ec2473bbcb4831d62af55d275368e73e16b984/contracts/p1/StRSR.sol#L674) `lastWithdrawRefresh` gets updated even if didn't change, that costs an additional 1... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: | Default Value Assignment
### Description
**Description**
Throughout the contracts `uint` variables are initialized to the default value (0):
- MarketUtils.sol::619
- Oracle.sol::100,136,226,252,285
- OracleUtils.sol::45
- SwapUtils.sol::44
- Timelock.sol::38,44
- Array.sol::33,41,51
**Recommendation**
Rem... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Unbonding of validators does not give priority to inactive validators
### Description
**Severity:** Medium
**Path:** x/liquidstake/keeper/liquidstake.go:LiquidUnstake#L344-L459
**Description:**
When a user wants to withdraw their `stkXPRT` for `xprt`, they will call `LiquidUnstake`. In the function, the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Flash minting can be used to redeem fyDAI
### Description
The flash-minting feature from the fyDAI token can be used to redeem an arbitrary amount of funds from a mature token. The fyDAI token has a special function that allows users to mint and burn an arbitrary amount of tokens in a single transaction:
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: THE TRANSFEROWNERSHIP PATTERN IS NOT FOLLOWED
### Description
The current ownership transfer process for the `GToken` contract inheriting from `Ownable` involves the current owner/timelock contract, calling the `transferOwnership` function.
If the nominated account is not a valid account, it is entirely possi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | flash-loan | false | false | ## Low: Intentionally Unbalancing Liquidity in StablePool2
### Description
In `StablePool2.sol`, the calculation of liquidity tokens minted takes place on line [113]:
```
liquidity = StablePoolMath.min((amount0 * _totalSupply) / _reserve0, (amount1 * _totalSupply) / _reserve1);
```
Because the calculation simply tak... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Lack of contract address check in setEscalationManager
### Description
The [`setEscalationManager`](https://github.com/UMAprotocol/protocol/blob/3687d9b3a80ca9b3694211d50a2ccad5415c77e1/packages/core/contracts/gnosis-zodiac/implementation/OptimisticGovernor.sol#L210) administrative function in `OptimisticGover... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: Potentially Dangerous Self Call Pattern
### Description
## Switchboard EVM Audit 05 | General Findings
## Remediation
Handle EIP2771 in the self-call to `oracleHeartbeat`.
### SOLIDITY
## Patch
Fixed in `d9ab8a0`.
### Recommendation
Handle EIP2771 in the self-call to `oracleHeartbeat`. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | false | false | ## Medium: Malicious user can front-run trades and deposit USDC tokens on behalf of other user
### Description
**Severity**: Medium
**Status**: Resolved
**Description**
The `buyOption` and `sellOption` functions allow a user to deposit USDC along with the trade execution. However, the deposit_amount parameter is no... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Privileged Roles and Ownership
### Description
**Update**
Marked as "Acknowledged" by the client. The client provided the following explanation:
> Noted
**File(s) affected:**`SophonFarming.sol`
**Description:** Smart contracts will often have `owner` variables to designate the person with special privileges... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | liquidation | true | false | ## Gas: Constants should be be used for hardcoded values
### Description
Constants should be be used for hardcoded values, especially if the [constants already exist](https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/main/src/DSCEngine.sol#L71), as it is in this case in `DSCEngine`.
```Solidity
uint256... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: ERC777 tokens may not implement ERC20 functions
### Description
[EIP 777](https://eips.ethereum.org/EIPS/eip-777) states that ERC777 tokens [“MAY implement both ERC20 and ERC777 in parallel”](https://eips.ethereum.org/EIPS/eip-777#backward-compatibility), but not that they must do so. Thus, some ERC777 toke... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | false | false | ## Low: Redundant Code
### Description
## Code Optimization Review
## 1. Price Check Improvement
In the market, the price check in `get_price_internal` can be rewritten as:
This is valid because the value is of type `u64`, which will always be positive. Similarly, the reserves check:
in `buy_collateral` is unnece... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Missing flags validation in new `pluginConfig`
### Description
There is no validation of flags in new `pluginConfig` set with `AlgebraPool.setPluginConfig()`. This can lead to the invocation of hooks that will constantly revert. E.g. `BEFORE_FLASH_FLAG`, `AFTER_FLASH_FLAG`, `AFTER_SWAP_FLAG` (without curre... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | front-running | true | false | ## Low: Obol fees will be applied retroactively to all non-distributed funds in the Splitter
### Description
When Obol decides to turn on fees, a call will be made to `ImmutableSplitController::updateSplit()`, which will take the predefined split parameters (the original user specified split with Obol's fees added in)... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Incomplete NatSpecs
### Description
Most `external` methods in the codebase have a NatSpec documentation but they almost always lack `@param` and `@return` explanation. Short example is `HoneyBoxx::addBundle` - neither the parameters or the return variable are listed in the NatSpec. Go through all methods and ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | false | false | ## Low: Risk of revert in rate calculation
### Description
- https://github.com/Instadapp/fluid-contracts/blob/b466ffd4b69761be50851094ff624edaf1fa6c07/contracts/libraries/liquidityCalcs.sol#L566-L568
In `liquidityCalcs.calcRateV1()`, it is required that the slope is non-negative:
```
if (slope_ < 0) {
revert Fluid... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Unnecessary boolean comparisons in `GMTokenManager`
### Description
**Description:** Both in [`GMTokenManager::_verifyQuote#L329`](https://github.com/ondoprotocol/rwa-internal/blob/a74d03f4a71bd9cac09e8223377b47f7d64ca8d4/contracts/globalMarkets/tokenManager/GMTokenManager.sol#L329) and [`GMTokenManager::admin... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.