prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Missing checks of _exists() return value
### Description
The ERC-721 `_exists()` function returns a Boolean value that indicates whether a token with the specified `tokenId` exists. In two instances in Arcade’s codebase, the function is called but its return value is not checked, bypassing the intended result ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Visibility not set
### Description
Visibility is not set:
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/contracts/core/ContractsRegister.sol#L16
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/contracts/co... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | true | false | ## Medium: Selling will be bricked if all other tokens are withdrawn to ERC20 token
### Description
`FeeSplitter.addFees()` reverts if the `totalSupply` of the token is `0`. The total supply is calculated via the formula below:
Consider the following scenario:
1. Alice buys 1 Curve token to initiate herself as a to... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: Function call may run out of gas
### Description
**Description**
The mass update pool allows the contract to update all pools data in one call. It can be the
cause of run out of gas if poolInfo.length will be a big number.
**Recommendation**:
There are few possible solutions:
Make a comment to explain th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Invalid Nodes can be registered due to an incorrect check
### Description
**Severity**
**Impact:** Medium
**Likelihood:** Medium
**Description**
DivReducer node is supposed to have 2 parent nodes. During registration node is checked to be valid, however it does nothing if parents are invalid:
**Recomm... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | true | ## Medium: LBRouter.removeLiquidity returning wrong values
### Description
## Lines of code
https://github.com/code-423n4/2022-10-traderjoe/blob/e81b78ddb7cc17f0ece921fbaef2c2521727094b/src/LBRouter.sol#L291
## Vulnerability details
## Impact
`LBRouter.removeLiquidity` reorders tokens when the user did not pass th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: In the `revertBatch` function, `inChallenge` is set to `false` incorrectly, causing challenges to continue after the protocol is paused.
### Description
An unchecked batch reversion will cause challenge invalidation for any committed batch, leading to batch rollback issues for challengers, as the isChalleng... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | initialization | true | false | ## Gas: State variables only set in the constructor should be declared `immutable`
### Description
Avoids a Gsset (20000 gas) in the constructor, and replaces each Gwarmacces (100 gas) with a `PUSH32` (3 gas) | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: currentTokenSupply() may not represent actual circulating available supply for voting
### Description
`currentTokenSupply()` varies largely in different contexts, for example:
- If tokens are minted but are in a vesting or staking contract, they can't be used but are counted.
- Similarly, if tokens are already... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Lack of Error Reporting During Program Initialization
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `8b12c969b157c77eb3beceebafca2843d025bb07`.
**File(s) affected:**`initialize.rs`
**Description:** The `instructions::initialize::initialize()` function does not display an error if ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | signature | true | false | ## Low: Functions not used internally could be marked external
### Description
Using proper visibility modifiers is a good practice to prevent unintended access to functions.
Furthermore, marking functions as `external` instead of `public` can save gas.
```solidity
File: DepositVault.sol
37: function deposit(uin... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: FeeDistributor.getPeriodReward updates lastClaimByToken potentially causing lock of tokens
### Description
`FeeDistributor` is a contract that incentivizes voters of the `Voter` contract with fees collected from pairs. The contract implements functionality to allow depositors to claim their rewards in two ways... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: | Lack of Access Control For Events
### Description
**Description**
Anyone can call `notifyFeeReceived` as there is a lack of access control, which leads to a depreciation of the authenticity of the event.
**Recommendation**
Implement access control concerning who may call `notifyFeeReceived`.
**Resolu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Missing Transaction Reverts for Zero Address Checks.
### Description
**Description**
ChainportSideBridge: _setTokenProxyAdmin, _setTokenLogic.
The functions_setTokenProxyAdmin() and_setTokenLogic() contain checks to prevent setting their respective addresses to the zero address. However, these checks are curr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Signing valid operation hashes via UI dialog
### Description
The message text box in the Sign tab in the Sign & Verify dialog box accepts arbitrary data, including binary, non-ascii bytes. Users can be tricked to sign data that is a valid hash of some operation. The input is encoded to utf8 prior to signing... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Use of GPG for release signing and verification
### Description
The EthStaker deposit CLI tool currently uses GPG for signing releases. While this was an improvement over the previous unsigned releases, GPG is not considered a good tool for verifying software releases in new projects. GPG has a history of crypt... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | token | true | false | ## Low: Dirty bits in `NonFungible` mid-field can break comparisons
### Description
[`NonFungible`](https://github.com/Licredity/licredity-v1-core/blob/e8ae10a7d9f27529e39ca277bf56cef01a807817/src/types/NonFungible.sol#L8-L16) is packed as `bytes32` with the layout `160 bits address | 32 bits empty | 64 bits tokenId`.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | front-running | false | false | ## Low: Wallet creation transactions can be made to fail — Method 2
### Description
Even if the calls to [`build(address _owner)`](https://github.com/InstaDApp/contract-v2/blob/4863c0c4156af7ded9cdb38b66e5f5e527c4a6d0/contracts/InstaRegistry.sol#L126) are restricted (as mentioned in the issues “Transfer of wallet owne... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: Max magnitude lock check will lead to a DoS and possible monopolization of `gov/Option` on `twTAP`/`TapiocaOptionBroker`
### Description
### Vulnerability details
There is a max magnitude lock check in the `twTAP.participate` function, it can't be greater than 4x the cumulative:
if (magnitude >= pool.cu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Lack of Inline Code Documentation Acknowledged
### Description
The codebase lacks inline documentation. This reduces the maintainability of the codebase as it can make it challenging for new developers and auditors to understand the code as it grows. Proper inline documentation is essential for maintaining co... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: `head` can't be taken out
### Description
`prev` account for head doesn't exist:
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/contracts/core/AccountFactory.sol#L257
### Recommendation
We recommend adding a special check for situation when `creditAccoun... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | front-running | true | false | ## High: Malicious registrant can front-run `RFPSimpleStrategy._allocate()` in order to change the `proposalBid` and get a bigger payout in the distribution
### Description
Source: https://github.com/sherlock-audit/2023-09-Gitcoin-judging/issues/497
## Found by
0xbepresent, 0xdeadbeef, WATCHPUG, detectiveking, hone... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unlocked Pragma
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `f2aa15d0bffaccd9c1a73a3d26a7b85d36802572`. The client provided the following explanation:
> Set to 0.8.20 version
**Description:** Every Solidity file specifies in the header a version number of the format `pragma soli... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Lack of access control on potentially sensitive functions
### Description
In the `BaseEscalationManager` contract, the following `public` functions may benefit from access control:
* [`requestPrice`](https://github.com/UMAprotocol/protocol/blob/fed1c5677b5e764eb0b3e59817941c129e6c26f7/packages/core/contracts... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | DOS | false | false | Source: https://github.com/sherlock-audit/2022-11-isomorph-judging/issues/70
## Found by
clems4ever, 0x52
## Summary
The oracles used have a built in safeguard to revert the transaction if the queried asset is outside of a defined price range. The issue with this is that every vault interaction requires the underl... | Sherlock | 4 | Isomorph |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Heavy Epoch Lookup for Uninitialized Ticks
### Description
In `LimitOrderManager._fillEpoch()`, the contract computes `Epoch epoch = getEpoch(pool, lower, upper, zeroForOne);` for every crossed tick. When no orders exist at a tick (the common case), this still incurs a `keccak256` hash and `SLOAD` before confi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Use `VETO_VALUE` for clarity
### Description
https://github.com/code-423n4/2023-05-party/blob/main/contracts/party/PartyGovernance.sol#L1024-L1027
Replace `type(uint96).max` in the above code with `VETO_VALUE` for clarity and easier refactoring in the future.
**[0xble (Party) acknowledged](https://github.com... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | rounding | true | false | ## High: Precision loss in `_withdrawFromL1Vault()` can cause asset transfer reverts
### Description
In the `VaultEscrow::_withdrawFromL1Vault()` function, the withdrawal amount from the L1 vault can be **less than** the amount sent back to the EVM spot (when both are transformed to floating-point numbers). This discr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | integer-overflow | true | false | ## Low: Use explicit unsigned integer sizing instead of `uint`
### Description
In Solidity `uint` automatically maps to `uint256` but it is considered good practice to specify the exact size when declaring variables:
```
Accounting.sol
200: ) public view returns (uint jrtNavT1, uint srtNavT1, uint reserveNavT1) {
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: In `PerpMarket::checkOpenInterestLimits` only calculate `isReducingSkew` if `shouldCheckMaxSkew == true`
### Description
**Description:** There is no point in calculating `isReducingSkew` every time since it is only used when `shouldCheckMaxSkew == true`. Hence refactor to only calculate in this case:
**Zaro... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: Overlapping of Multiple Issuances Simultaneously
### Description
## Issue with Multiple Active Issuances
The `InitializeIssuance` and `StartIssuance` instructions do not check if there is an active issuance already running under the bond before initiating a new one. This oversight allows multiple issuances t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: The vault contract is not compliant with the ERC4626
### Description
**Severity**: Medium
**Status**: Resolved
**Description**
Contract GlmVault is inheriting from the ERC4626 implementation and overriding several methods.
GlmVault has overridden the method `deposit()` and `mint()` method but `maxDepos... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Missing error messages in require statements
### Description
Within [`VotingV2.sol`](https://github.com/UMAprotocol/protocol/tree/28beb7e0e339aafe4bf19435e5fa70a342e34375/packages/core/contracts/oracle/implementation/VotingV2.sol) there are `require` statements that lack error messages. For instance:
* The `... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Initial Deposit | false | true | Source: https://github.com/sherlock-audit/2022-10-merit-circle-judging/issues/103
## Found by
WATCHPUG, bin2chen
## Summary
`pointsPerShare` can be manipulated by the first user and cause `_correctPoints()` to revert later.
## Vulnerability Detail
`POINTS_MULTIPLIER` is an unusually large number as a precision f... | Sherlock | 4 | Merit Circle |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: NFTs Persist After Use
### Description
Both contracts FuroStream and FuroVesting create NFTs for their recipients. When a stream or vest is finished or cancelled, the NFTs are left under the control of those users. There might be scope for these NFTs to be sold under false pretences or otherwise used in a scam... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Different order of parameters in events Cancel...Claim
### Description
The following events start with `receiver` and then `controller`. However, most events start with `controller`, followed by `receiver`.
```solidity
emit CancelDepositClaim(receiver, controller, REQUEST_ID, msg.sender, assets);
emit CancelR... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Clone-and-Own
### Description
**Update**
From the team:
**File(s) affected:**`packages/protocol/contracts/access/OwnableUpgradeable.sol`
**Description:** The clone-and-own approach involves copying and adjusting open source code at one's own discretion. From the development perspective, it is initially bene... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Copy-pasted comments in `WaterfallFactory`
### Description
Almost all methods reference a `split` instead of a `waterfall` in the contract, I expect they were copy-pasted from `SplitFactory`. Replace `split` with `waterfall` in all of the comments in `WaterfallFactory`. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: An authorized user can unauthorize other authorized users of the same sender
### Description
A user can grant authorization to another address to make calls on their behalf via the `Caller.callAs` function. The `Caller.unauthorize` function allows the user to revoke the authorization of another address.
An au... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Use of `transfer`/`transferFrom`
### Description
Not all ERC20 implementations are well behaved and revert on failure. Some simply return false and some might not return anything at all (USDT on mainnet).
Consider using OpenZeppelin `SafeERC20`s `safeTransfer` and `safeTransferFrom` to be as safe as possible ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Inconsistent between balanceOfNFT ,balanceOfNFTAt and_balanceOfNFT functions
### Description
The `balanceOfNFT` function implements a flash-loan protection that returns zero voting balance if `ownershipChange[_tokenId] == block.number`. However, this was not consistently applied to the `balanceOfNFTAt` and ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Limited Voting Options Allow Ballot Creation Spam
### Description
The message functions for certain types of voting allow only successful observation votes. This creates a problem if a compromised or faulty observer creates spam ballots with false observations. In this situation, honest observers have to sp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | cross-chain | false | false | ## High: `FunnelVaultUpgradeable` cannot send transactions to HyperCore
### Description
`sendNativeTokenToLayer1()` bridges `HYPE` from HyperEVM to HyperCore. These funds are credited to the vault contract address in HyperCore, so it is required that the contract implements the logic to send transactions from the Hype... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | reentrancy | true | false | ## Gas: Using `bool`s for storage incurs overhead
### Description
https://github.com/OpenZeppelin/openzeppelin-contracts/blob/58f635312aa21f947cae5f8578638a85aa2519f5/contracts/security/ReentrancyGuard.sol#L23-L27
Use `uint256(1)` and `uint256(2)` for true/false to avoid a Gwarmaccess (**[100 gas](https://gist.github.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Incorrect Version of Solidity
### Description
**Update**
Fixed in commit `959f9ef799d81a68f6a1fe246dd06fc0b293230f` by changing the solidity version to `0.8.18`.
**Description:** An [important bug](https://blog.soliditylang.org/2022/09/08/storage-write-removal-before-conditional-termination/) was identified i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | storage | true | true | ## High: Current storage pattern fails to ensure type safety
### Description
As mentioned in TOB-ROCKET-001, the RocketStorage contract uses the eternal storage pattern. This pattern uses assembly to read and write to raw storage slots. Most of the system’s data is stored in this manner, which is shown in figures 2.1 ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: NodeRegistry - In3Node memory n is never used ✓ Fixed
### Description
NodeRegistry `In3Node memory n` is never used inside the modifier `onlyActiveState`.
**code/in3-contracts/contracts/NodeRegistry.sol:L125-L133**
```
modifier onlyActiveState(address \_signer) {
SignerInformation memory si = signerInde... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Events missing
### Description
The function should emit an event for better UX in possible integrations:
- https://github.com/prisma-fi/prisma-contracts/blob/c0122d27677cd4e1aaee7f1e21f807ccadf46ac8/contracts/dao/Treasury.sol#L173.
### Recommendation
We recommend emitting events. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | false | false | ## Medium: AMM - Amount of collateral spent or shares received may be unpredictable for liquidity provider Acknowledged
### Description
When providing liquidity with `addLiquidity()`, the amount of collateral required is based on the current price and the amount of shares received depends on the total amount of share... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Registered Contracts Through `Registry` Cannot Be Removed
### Description
**Update**
Marked as "Acknowledged" by the client. The client provided the following explanation:
> We don't need to remove the registered ledger contracts Because the ledger contract has only one external method that will modify the st... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: ERC20 return values not checked
### Description
_Submitted by cmichel, also found by defsec, JMukesh, p4st13r4, and WatchPug_
The `ERC20.transfer()` and `ERC20.transferFrom()` functions return a boolean value indicating success. This parameter needs to be checked for success.
Some tokens do **not** revert ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Fragile check for contract order type
### Description
The `OrderType` enum defines five order types. Only one of these represents contract orders:
[`ConsiderationEnums.sol`](https://github.com/horsefacts/seaport/blob/5de7302bc773d9821ba4759e47fc981680911ea0/contracts/lib/ConsiderationEnums.sol#L5-L20):
[`Or... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: Missing slippage protection in `AerodromeDexter.sol` `swapExactTokensForTokens()`
### Description
### Finding description and impact
Even though there is no frontrunning on L2s, which could mitigate some of the MEV attacks, without defined slippage and in case of congestions the swap could be executed at u... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: calculateTokenAmount is not checking whether amounts provided has the same length as balances
### Description
There is no check to make sure `amounts.length == balances.length` in `calculateTokenAmount`:
```solidity
function calculateTokenAmount(
Swap storage self,
uint256[] calldata amounts,
bool depos... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: 9] Investor withdrawals may not function with a nonzero withdrawalLockupPeriod
### Description
**Severity:** High
**Path:** contracts/main/contracts/pool/UFarmPool.sol#L517
**Description:** `UFarmPool::withdraw` allows for a permissionless two-step withdrawal process for non-member investors if a nonzero `w... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | true | false | ## Low: Avoid return statements with named return variables
### Description
When declaring named return variables such as in `GaugeRegistrar::registerGauge`, it is not necessary to explicitly execute the return statement and this can be removed to save gas.
### Recommendation
```diff
function registerGauge(
addre... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Inconsistent linkage update for reserved type(uint128).max node
### Description
There is inconsistent behaviour when updating the `prev` link between `instantiate()` and `garbageCollect()`. The former only updates when the next node isn’t `type(uint128).max`, but `garbageCollect()` updates regardless.
```soli... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unused params
### Description
**Severity**: Informational
**Status**: Acknowledged
**Description**
In Contract GlmRouter.sol, the method `requestWithdraw(...)` has a parameter `address _ token` which is not used. It’s been if it’s USDC token or not but that is irrelevant to the method.
**Recommendation**: ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Tokens can't be rescued from HIP3StakingManager contract
### Description
The `StakingManager` includes a `rescueToken()` function that sends accidentally stuck tokens to the treasury:
```solidity
function rescueToken(address token, uint256 amount)
external
onlyRole(TREASURY_ROLE)
whenNotPaused
{
requi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Previous `feeRecipient` could lose the deserved fee
### Description
When `updateFeeRecipient` is called and `feeRecipient` is changed, it doesn't trigger `_accrueFee`.
Not triggering `_accrueFee` before updating `feeRecipient` could result in a loss of deserved fee shares from interest accrual for the previo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Floating pragma
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
Audited contracts use the following floating pragma:
It allows to compile contracts with various versions of the compiler and introduces the risk of using a different version when deploying than during testing... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: Chainlink's `latestRoundData` might return stale or incorrect results
### Description
_Submitted by cccz, also found by 0xDjango, 0xkatana, berndartmueller, defsec, Dravee, fatima_naz, IllIllI, jah, kebabsec, kenta, pedroais, peritoflores, rayn, reassor, tabish, and WatchPug_
On ChainlinkPriceOracle.sol, w... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: External functions can 't return memory pointers
### Description
This public function returns a memory pointer but does not work for external calls since memory does not persist to the calling context.
### Recommendation
The return values should be modified to:
- **Current Return**:
```solidity
returns (... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Common code should be refactored
### Description
[BaseAbstract](https://github.com/code-423n4/2022-12-gogopool/blob/aec9928d8bdce8a5a4efe45f54c39d4fc7313731/contracts/contract/BaseAbstract.sol#L71-L74) performs similar operations, so the common code should be refactored to a function
*There is 1 instance of t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: Invariant violation (funds could remain in the vault and a depositor could benefit from it)
### Description
There is a violation to one of the main invariants defined by the sponsor - `After every action (deposit/withdraw/rebalance/compound), the vault should be cleared of any token balances. Violation of t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Rewards of underlying protocols are stuck in pools
### Description
Some yield sources like Aave-V3 can pay out rewards for anyone supplying (and borrowing) tokens. The Hyperdrive pool would be eligible for these rewards with a potentially large share as all the LPs' funds are invested in them. However, there's... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: veALCX holders are able to withdraw rewards and vote even when their token is under cooldown
### Description
Report type: Smart Contract
Target: https://github.com/alchemix-finance/alchemix-v2-dao/blob/main/src/RewardsDistributor.sol
Impacts:
- Theft of unclaimed yield
## Description
## Brief/Intro
veALCX... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Discord Security Controls
### Description
During our assessment, we identified the following implemented controls:
- **CAPTCHA based user verification.**
- **2 external moderators + core team with 'core' role.**
- **Using several bots including MEE6, AFK Bot, and Wick.**
- **Large member base (33,823 members).... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Admin can break `_numberOfValidTokens`
### Description
_Submitted by cmichel, also found by gzeon and 0x1f8b_
The `ProtocolGovernance._numberOfValidTokens` can be decreased by the admin in the `ProtocolGovernance.removeFromTokenWhitelist` function:
This function can be called repeatedly until the `_numbe... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | false | false | ## Low: Cooldown Withdrawals Do Not Support ERC4626 Allowance-Based Owner Flow
### Description
`ERC-4626` specifies that withdraw and redeem [MUST support](https://eips.ethereum.org/EIPS/eip-4626) a flow where shares are burned from an owner address when `msg.sender` has sufficient ERC-20 allowance over the owner’s sh... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Naming Convention Not Followed
### Description
During the code review, several instances of non-compliant naming conventions were identified in the Solidity codebase. Specifically:
* Some contract names were not in CapWords:
+ `childUSDz` and `sUSDz`
* Some constants were not in uppercase:
+ `uint256 co... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `boostThreshold` check is missing in `setValidator`
### Description
In Staker, there is one `boostThreshold` variable. When there are more unboosted BGT in our contract than `boostThreshold`, we will queue and boost. The problem is that in `setValidator` function, we don't check the `boostThreshold` limitation... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Using > 0 costs more gas than != 0 when used on a uint in a require() statement
### Description
When dealing with unsigned integer types, comparisons with != 0 are cheaper then with > 0. This change saves 6 gas per instance | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Non-Idempotent Pre-Execution Hook in `SessionKeyPermissionsPlugin`
### Description
**Update**
Fixed by executing the pre-execution hook once, even if there are multiple post-execution hooks (our first recommendation). This way, pre-execution hooks do not have to be idempotent, and therefore, there is no nee... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Commented Out Expiration Field in LiquidityOrder Struct
### Description
In the **LiquidityOrder** struct, the `expiresAt` field is commented out:
```
struct LiquidityOrder {
// ... other fields ...
// uint256 expiresAt;
// uint256 executionFee;
}
```
The absence of an expiration time for liquid... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | true | false | ## Low: [1] Validator signing address of zero not rejected, allowing anyone to sign
### Description
`ecrecover()` returns `0` when the signature does not match. If the validators approve a valset including an address of `0`, then anyone will be able to sign messages for that signer, since invalid sigatures will return... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Round Up Fee Value
### Description
## VTVLVesting::calculateFee
In `VTVLVesting::calculateFee`, the fee value is automatically rounded down due to the default Solidity behavior for division.
## VTVLVesting.sol
## Remediation
Round up the division, as it ensures that the fee is always slightly overestimate... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | true | false | ## Medium: Front-running `Staking.unstakeRequestWithPermit()` can invalidate user transaction
### Description
An attacker can read the `v`, `r`, `s` from the mempool and call `mETH.permit()` first, consuming the user's signature and updating the nonce. The subsequent user transaction `Staking.unstakeRequestWithPermit(... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Validate MigrationAgent setting
### Description
The [`setMigrationAgent`](https://github.com/qiibee/qb-contracts/blob/d40368c9a7a536572a5bb03cb031d658ccb34f24/contracts/QiibeeToken.sol#L100) function from [`QiibeeToken`](https://github.com/qiibee/qb-contracts/blob/d40368c9a7a536572a5bb03cb031d658ccb34f24/contr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | false | false | ## High: Leverage user can avoid paying fees to bond holders by withdrawing before auction ends
### Description
Bond holders are paid fees by leverage holders in discrete quarterly payments. Due to the long length of this period, leverage holders can easily exploit and avoid this fee by withdrawing before funds are ta... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: Potential Misallocation of Validators in `_getDepositsAllocation` Function
### Description
The issue is identified within the [\_getDepositsAllocation](https://github.com/lidofinance/core/blob/fafa232a7b3522fdee5600c345b5186b4bcb7ada/contracts/0.8.9/StakingRouter.sol#L1406-L1434) function of the contract `S... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: `withdraw_tokens` fails to adjust `claimed_supply` locking tokens permanently
### Description
The `withdraw_tokens` function allows users to reclaim their payment tokens if the `min_threshold` is not met. However, the function does not update `claimed_supply` or transfer `tokens_purchased` back to the authori... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Consider Using Named Mappings
### Description
The project is using Solidity version greater than `0.8.18`, which supports named mappings. Using named mappings can improve the readability and maintainability of the code by making the purpose of each mapping clearer. This practice helps developers and auditors u... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | access-control | true | false | Source: https://github.com/sherlock-audit/2024-03-zap-protocol-judging/issues/54
## Found by
0x4non, AMOW, GatewayGuardians, HonorLt, NickV, ZdravkoHr., bughuntoor, cats, enfrasico, klaus, merlin, s1ce, thank\_you, ydlee
## Summary
Vesting contract cannot work with native token, although it's supposed to.
## Vulne... | Sherlock | 5 | Zap Protocol |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | false | false | ## Low: futureCashGroups parameters may not match FutureCash parameters
### Description
Within [`FutureCash.sol`](https://github.com/swapnet-protocol/swapnet-lite/blob/66ce8f3e529410a5272b7a57c8391fcb80a375fd/packages/contracts/contracts/FutureCash.sol), the [`setParameters`](https://github.com/swapnet-protocol/swapne... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: LP May Withdraw Excessive Liquidity
### Description
**Update**
The Blex team will only deploy one vault for this version. Later versions will have their code modified to support multiple vaults if desired. Thus, the issue will be of no consequence for the current version.
We do recommend updating documentati... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: TimeLock cannot schedule the same calls multiple times
### Description
## Handle
cmichel
## Vulnerability details
The `TimeLock.schedule` function reverts if the same `targets` and `data` fields are used as the `txHash` will be the same.
This means one cannot schedule the same transactions multiple time... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: MISSING ZERO-ADDRESS CHECK
### Description
Several instances found where the address validation is missing. A zero address validation failure was found when assigning user-supplied address values to state variables directly.
* In contract `GovernanceRegistry.sol`:
+ `changeGovernance` lacks a zero address ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Single-step process for critical ownership transfer is risky
### Description
Single-step process for critical ownership transfer is risky due to possible human error which could result in locking all the functions that use the onlyOwner modifier.
### Impact
Critical functions using the onlyOwner modifier w... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Inconsistencies in the AMM Fee Logic
### Description
## Issue with `amm::get_limit_order_size_in_base_and_quote`
The function `amm::get_limit_order_size_in_base_and_quote` incorrectly applies the fee to the base asset amount rather than the quote asset. The fee is applied after converting the quote asset to ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Checking `msg.sender` to not be zero address is redundant
### Description
There is an instance where `msg.sender` is checked not to be zero address. This check is redundant as no private key is known for this address, hence there can be no transactions coming from the zero address. The following diff removes t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | true | false | ## High: Flawed Precision and Scaling Logic in `price()`
### Description
The `price()` function in `ChainlinkCompositeOracleProvider` begins with a 36-decimal fixed-point accumulator (`highPrecisionPrice = PRECISION`). Each feed is then folded into that value, but two subtle arithmetic mistakes distort the final price... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | storage | true | false | ## Medium: Corrupted storage after upgrade in the `MarketFactory` contract.
### Description
The old `MarketFactory` is meant to be upgraded to a new implementation. The problem is that a new `extensions` mapping was added between currently occupied storage slots. After the upgrade, the newly upgraded smart contract wo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | Business Logic | false | true | _Submitted by panprog, also found by 0x52, 0xsanson, hansfriese, shenwilly, and zzzitron_
<https://github.com/code-423n4/2022-07-fractional/blob/8f2697ae727c60c93ea47276f8fa128369abfe51/src/modules/Migration.sol#L210>
<https://github.com/code-423n4/2022-07-fractional/blob/8f2697ae727c60c93ea47276f8fa128369abfe51/src/... | Code4rena | 5 | Fractional |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | false | false | ## Medium: `requestWithdraw` without obligation to withdraw allow underwriter to avoid payout
### Description
_Submitted by gzeon_
To prevent withdrawal front-running, a lockup period is set between withdrawal request and withdrawal. However, there are no obligation to withdraw after the lockup period and the capital... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: DoSed liquidations as `PrizeVault::liquidatableBalanceOf()` does not take into account the `mintLimit` when the token out is the asset
### Description
`PrizeVault::liquidatableBalanceOf()` is called in `TpdaLiquidationPair::_availableBalance()` to get the maximum amount to liquidate, which will be incorrect... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | cross-chain | true | false | ## High: An attacker can redeposit gas after `forceRevert()` to freeze all deposited gas budget of `Root Bridge Agent`
### Description
The call `forceRevert()` withdraws all of the deposited gas budget of `Root Bridge Agent` to ensure that the failed ``AnyCall`` execution will not be charged. However, if `forceRevert... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Validation | true | true |
<https://github.com/jbx-protocol/juice-nft-rewards/blob/f9893b1497098241dd3a664956d8016ff0d0efd0/contracts/JBTiered721DelegateStore.sol#L1224-L1259><br>
<https://github.com/jbx-protocol/juice-nft-rewards/blob/f9893b1497098241dd3a664956d8016ff0d0efd0/contracts/JBTiered721DelegateStore.sol#L566><br>
<https://github.com/... | Code4rena | 4 | Juicebox |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: Plant's empire can change by front-running in purchase transactions
### Description
In functions `createShip()`, `placeAcid()` and `chargeShield()` user defines `planetId` and the code performs the action for that planet and its empire but the code doesn't verify the empire of the plant:
```solidity
func... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | false | false | ## High: Report from a malicious oracle will be accounted for in the quorum
### Description
There is a chance that some of the oracle addresses will be compromised. After key leakage, the oracle address should be removed from the quorum, but if the malicious user sends a report before being excluded from the quorum, t... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.