prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | false | false | ## Medium: [Fixed] Use of transfer might render ETH impossible to withdraw
### Description
When withdrawing ETH deposits, the [`PayableProxyController` contract](https://github.com/opynfinance/GammaProtocol/blob/d151621b33134789b29dc78eb89dad2b557b25b9/contracts/external/proxies/PayableProxyController.sol#L19) uses So... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: Providing unbalanced liquidity to a buffer can mint more shares due to rounding
### Description
Providing only the underlying token to the `addLiquidityToBuffer` function of the `VaultAdmin` contract will result in slightly more shares being minted. During liquidity provision, the invariant is calculated in te... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Pledges that contain delisted tokens can be extended to continue using delisted reward tokens
### Description
Delisted reward tokens can continue to be used by extending current pledges that already use it.
### Proof of Concept
if(pledgeId >= pledgesIndex()) revert Errors.InvalidPledgeID();
address cr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | access-control | true | true |
Source: https://github.com/sherlock-audit/2025-10-centrifuge-protocol-v3-1-audit-judging/issues/641
## Found by
0x52, 0xRstStn, 6PottedL, Audittens, LeFy, NovaTheMachine, PowPowPow, Waydou, anonymousjoe, asui, gh0xt, skybluescar
## Summary
The request manager system allows attackers to steal all pending user depo... | Sherlock | 5 | Centrifuge Protocol V3 Audit |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: `ConfigTimeLockController` will put `QuantConfig` in a stalemate (rendering it unusable)
### Description
_Submitted by 0xmint_
The QuantConfig contract has these important setters, setProtocolAddress(), setProtocolUint256, setProtocolBoolean() and setProtocolRole(). This contract is subjected to a timelock... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Different Solidity versions.
### Description
**Description**
Different pragma directives are used. Throughout the project (including interfaces). Version
used: '=0.5.16', '>=0.5.0'
Issue is classified as Medium, because it is included to the list of standard smart contracts’
vulnerabilities.
**Recommendat... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: Broken block time assumptions affect am-AMM epoch duration and can DoS rebalancing on Arbitrum
### Description
**Description:** `AmAmm` defines the following virtual function which specifies the auction delay parameter in blocks:
Here, `7200` assumes a 12s Ethereum mainnet block time. This corresponds to ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | front-running | true | true | ## High: Non-atomic updatePool() enables sandwich attacks and extraction
### Description
The `YuzuILP.updatePool()` lacks atomicity when updating the pool state, allowing manipulation of `poolSize` in a way that can be exploited through sandwich attacks.
The function directly sets `poolSize` from the externally provi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Runtime contains a mock orderbook
### Description
The Picasso runtime contains a mock orderbook. Mock code should be included only in tests; if it is left in a production build, it may enable unexpected behavior when the code changes in the future.
```rust
pub struct MockOrderbook;
impl Orderbook for MockOrd... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Impossible liquidity removing
### Description
In case all funds were borrowed (big part of funds), users can't return their assets (`amountSent > balanceOf(address(this))`:
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/contracts/pool/PoolService.sol#L182
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | storage | true | false | ## Medium: Improper Approval Mechanism of Clearing House
### Description
The `ClearingHouse` implementation performs a `@solmate`-based `safeApprove` instruction (\[1]) with the remaining `balanceOf(address(this))` but contains code handling any remainder of funds that may remain in the contract \[2]. Investigation of... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | true | ## Low: Import of Debugging Tool Hardhat
### Description
The file `DefaultInterestRateStrategy.sol` imports a debugging tool on line [11]:
```solidity
import 'hardhat/console.sol';
```
This import statement unnecessarily increases the attack surface and should not be used in production.
### Recommendation
`hardhat`... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Boost calculator does not incorporate time weighted averages in its calculation
### Description
Boost calculation is done with the intent of using time weighted functions, however they are not used in the function definition.
This will lead to unexpected behavior when expecting time related details to affect ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Misleading comment at CoiinToken.sol
### Description
**Description**
The variables names are maxMintMonthly and minMintMonthly but in notice, we see the daily
minting allowed:
/// @notice The daily allowed COIIN to be minted
uint256 public maxMintMonthly;
uint256 public minMintMonthly;
**Recommendation**:
C... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: POOR AUTHENTICATION MECHANISM
### Description
Poor or missing authentication schemes allow an adversary to anonymously execute functionality within the web app or backend server used by the web app.
In this particular case, the web application lacks any password protection mechanism. The sole authentication me... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | initialization | true | false | ## Gas: Using `calldata` instead of `memory` for read-only arguments in `external` functions saves gas
### Description
When a function with a `memory` array is called externally, the `abi.decode()` step has to use a for-loop to copy each index of the `calldata` to the `memory` index. **Each iteration of this for-loop ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | cross-chain | false | false | ## Medium: An attacker can stuff a Solana Outbound transaction with multiple instructions to block it from finalizing
### Description
A Solana Outbound transaction is [expected](https://github.com/sherlock-audit/2025-04-zetachain-cross-chain/blob/main/node/zetaclient/chains/solana/observer/outbound.go#L296-L302) to ha... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: setVic should ensure that the newVic does not revert or report an incompatible interest rate per
### Description
## Second
## Severity: Low Risk
**Context:** VaultV2.sol#L200
**Description:** The current implementation of `setVic` does not perform any sanity checks on the `newVic` address. We have already s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: Funds are locked because borrowFee is not correctly implemented in BigBang
### Description
There's borrowOpeningFee for markets. In Singularity, this fee is accumulated over assets as a reward to asset depositors. In BigBang, assets is USD0 which would be minted and burned on borrow, and repay respectively. B... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | dos | true | true | ## Medium: `ComplianceServiceRegulated` applies double locking to investor transferable tokens leading to DoS of transfers
### Description
`ComplianceServiceRegulated::getComplianceTransferableTokens()` enforces a double locking on the investors' transferable tokens, causing more tokens to be considered locked up than... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Cache array length outside of loop
### Description
If not cached, the solidity compiler will always read the length of the array during each iteration. That is, if it is a storage array, this is an extra sload operation (100 additional extra gas for each iteration except for the first) and if it is a memory ar... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Ensuring Secure Token Transfers in Smart Contracts with OpenZeppelin's SafeTransfer
### Description
**Severity**: Low
**Status**: Unresolved
**Location**: Presale.sol, line 322, 324
**Description**:
The use of `.transfer()` for token transactions, while common, can pose significant security risks, particu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Token name and symbol can be changed
### Description
**Severity**: High
**Status**: Acknowledged
**Description**
The setInfo() function can be used to change the name and symbol of the token even after the token has been deployed. This is not advisable because the gov can change the name and symbol of the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: MISSING ZERO VALUE CHECK
### Description
There are functions within the project that should have a zero value check.
Code Location
-------------
**appchain-registry/src/registry\_settings\_actions.rs**
* change\_minimum\_register\_deposit
+ `value` should be greater than 0
* change\_counting\_interval\_in... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: `RedemptionOperations` Redemptions should be disabled during Recovery Mode
### Description
**Impact**
`RedemptionOperations` checks the `TCR < MCR`, but should most likely check for `TCR < CCR`
https://github.com/blkswnStudio/ap/blob/8fab2b32b4f55efd92819bd1d0da9bed4b339e87/packages/contracts/contracts/Re... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: Claim indexes can appear multiple times in the Merkle tree possibly leading to stuck funds
### Description
`MerkleLockup` uses a Merkle tree to distribute airstream funds. The leaves contain the combination of the recipient address, the amount, and an index. The index is used to keep track of which leaf of ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: _checkMinShares() does not account for shares in the silo
### Description
In `StakedlvlUSD`, the function `_checkMinShares()` ensures that the total supply of `slvlUSD` is either `0`, or not less than `MIN_SHARES`:
```solidity
function _checkMinShares() internal view {
uint256 _totalSupply = totalSupply(... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Missing Bounds Check
### Description
The `unlockLiquidity` function does not validate whether the provided `id` is within the bounds of the `lockedLiquidity` array for the caller. If an invalid or out-of-bounds `id` is passed, the function will revert with a low-level error, which lacks context and can lead to... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: _THUSD argument of _redeemCloseTrove could be removed
### Description
The function `_redeemCloseTrove()` accepts an argument `_THUSD`, which is always passed as the `THUSD_GAS_COMPENSATION` constant. This argument could be eliminated, and the constant used directly in the body of the function. Removing this ar... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | token | false | false | ## Low: `MysteryBox::claimMysteryBoxes()` should return custom error when reverting due to `amountToClaim == 0`
### Description
`MysteryBox::claimMysteryBoxes()` should [return custom error](https://github.com/Earnft/smart-contracts/blob/43d3a8305dd6c7325339ed35d188fe82070ee5c9/contracts/MysteryBox.sol#L305) when reve... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | token | true | false | ## Gas: Check price != 0 before interacting with IERC20
### Description
When deploying a new Escrow via the factory, we can check if the set price is not 0 before interacting with the IERC20 via external calls. This ultimately saves the user some gas.
### Impact
Additional gas costs occur even if the price is set to ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: Mismatches between UMIP and implementation
### Description
In [UMIP-152](https://github.com/UMAprotocol/UMIPs/blob/master/UMIPs/umip-152.md), the documentation of several data structures is significantly different from their implementation in [`OptmisticGovenor.sol`](https://github.com/UMAprotocol/protocol/... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: `ConcentratedLiquidityPool.burn()` Wrong implementation
### Description
_Submitted by WatchPug_
The reserves should be updated once LP tokens are burned to match the actual total bento shares hold by the pool.
However, the current implementation only updated reserves with the fees subtracted.
Makes the `re... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Incorrect conditional logic in fillIPOrder for LPToken Payment
### Description
The orderbook allows LPToken payment in `fillIPOrder` using two methods: withdrawing from the `fundingVault` or pulling directly from the user's wallet.
1. If a user wants to pay by withdrawing funds from a `fundingVault`, they wo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Incorrect implementation of Lender can result in lost tokens
### Description
_Submitted by cccz_
MapleLoanInternals.\_sendFee should check returnData.length == 32 before decoding, otherwise if it returns bytes data, the abi.decode will return 0x20, result in lost tokens.
### Proof of Concept
[MapleLoanIn... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | overflow | false | false | ## High: Uniswap v3 pool token balance proportion does not necessarily correspond to the price, and it is easy to manipulate.
### Description
`getSupplyProportion()` retrieves Uniswap v3 pool balances, but the proportion of pool tokens doesn't always correspond to the price. If `ownval` is less than `1e6 - threshold`,... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | EIP-4626 | true | true |
The `maxWithdraw` & `maxRedeem` functions should return the `0` when the withdrawal is paused. But here, it's returning `balanceOf[user]`.
### Proof of Concept
`vMaia Withdrawal` is only allowed once per month during the 1st Tuesday (UTC+0) of the month.
It's checked by the below function:
```
102 func... | Code4rena | 5 | Maia DAO Ecosystem |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | upgrade | false | false | ## Low: Potential L1->L2 `ERC20` decimal inconsistency can result in loss of user bridged tokens
### Description
The first time a new ERC20 token is bridged, `TokenBridge::bridgeToken` uses the `IERC20MetadataUpgradeable` interface to fetch the token's name, symbol and decimals in order to create a bridged version of ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Accrued interest may be calculated on an overstated payment
### Description
## Severity: Low Risk
**Context:** `migration-helpers::AccountingChecker.sol#L50-L51`
**Description:**
The `checkTotalAssets()` function is a useful helper that may be used to make business decisions in the protocol. However, if th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: Missing staleness check in PythOracle can lead to forced liquidations and theft of funds from borrowers.
### Description
The Pyth integration contract uses the `getPriceUnsafe()` function to retrieve the latest reported price from a specified price feed.
However, Pyth does not have sponsored price feeds o... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Correct state is not enforced in `CrowdSale::claim`
### Description
The `claim` method in `CrowdSale` will revert if a sale is still in `RUNNING` state and will go through the `claimFailed` route if it is in `FAILED` state. The problem is that it doesn't enforce a revert if the state after the first checks is ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | false | false | ## Low: Logs are incomplete and overwritten with each script invocation
### Description
Many bash scripts in the [`scripts/bash`](https://github.com/celo-org/celo-monorepo/tree/0e876e5cad0e93f5dd1fff853f4be3c9a0e5c2a7/packages/protocol/scripts/bash) folder use a specific logging implementation that overwrites each scr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: `public` functions not called by the contract should be declared `external` instead
### Description
Contracts [are allowed](https://docs.soliditylang.org/en/latest/contracts.html#function-overriding) to override their parents' functions and change the visibility from `external` to `public`.
*There are 12 inst... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: StakingContract - Misleading Comment
### Description
The comment notes that the expected caller is `admin` while the modifier checks that `msg.sender` is an active operator.
**src/contracts/StakingContract.sol:L109-L114**
```
/// @notice Ensures that the caller is the admin
modifier onlyActiveOperator(uint... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: 6] _getIsUnwindThresholdMet should include subsidyAmount for threshold calculation
### Description
**Severity:** Low
**Description:** To unwind liquidity before the deadline, the current reserves must exceed the EARLY_UNWIND_THRESHOLD. This threshold should also include the subsidyAmount, since the initialWET... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | cross-chain | true | false | ## Medium: Not handling the failure of cross chain messaging
### Description
If the `xReceive` function fails to handle reverts properly, it could result in funds getting stuck. This can happen for example when:
- Depositing into L2 when protocol on L1 is paused: because pausing is not defined on L2.
- Depositing lar... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `depositAmounts` marks an incorrect amount of funds after closing a game which may lead to wrong implications in future updates or external parts relying on this information.
### Description
**Severity**: Low
**Status**: Resolved
**Description**
If it is decided for a game to get closed by executing `closeG... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Named return variable never returned
### Description
`valid` is declared as the named return variable, but is never returned and is instead an intermediate variable to compute the return value. This may hurt readability a bit.
### Recommendation
Consider using an unnamed return from the function. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | true | false | ## Low: [1] The `Factory.create` function is susceptible to re-entrancy as it performs a `_safeMint` before initializing the pool. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Incorrect Pruning Of Vesting Schedules
### Description
## Prune Expired Vesting Schedules in Vesting
_pruneExpiredVestingSchedules_ in Vesting is crucial for maintaining the cleanliness and efficiency of the vesting contract. It identifies and removes vesting schedules past their specified end times, ensur... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: No use of two-phase ownership transfers
### Description
Consider adding a two-phase transfer, where the current owner nominates the next owner, and the next owner has to call `accept*()` to become the new owner. This prevents passing the ownership to an account that is unable to use it.
*There is 1 instance o... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Functions cancelMinipool() doesn’t reset the value of the RewardsStartTime for user when user’s minipoolcount is zero
### Description
## Lines of code
https://github.com/code-423n4/2022-12-gogopool/blob/aec9928d8bdce8a5a4efe45f54c39d4fc7313731/contracts/contract/MinipoolManager.sol#L271-L283
https://github... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Vesting logic implemented directly in the token contract
### Description
The vesting logic is currently implemented in the `QiibeeToken` in the form of a base `VestedToken` contract. These features are going to be used by a limited number of buyers and for a restricted amount of time only. Having complex logic... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | true | false | ## Low: Potential out of gas risk in reward distribution checkpoint traversal
### Description
The Gauge contract generates a checkpoint for each user operation, which can lead to excessive gas consumption during reward distribution. If a user has not claimed rewards for an extended period, traversing through numerous ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | true | true | ## Low: `abi.encodePacked()` should not be used with dynamic types when passing the result to a hash function such as `keccak256()`
### Description
`abi.encodePacked()` should not be used with dynamic types when passing the result to a hash function such as `keccak256()`.
Use `abi.encode()` instead which will pad ite... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Referrals cannot be changed
### Description
When a user deposits a token, he sets the referrer as well. The referrer allows the user to get a discount, and the referrer can only be set once.
However, the referrer can get blacklisted from USDC, or revert any low-level call if it's a contract, resulting in a f... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Transfer of ownership can be lost if transferred to an address owned by no one
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `290d6f8cfb4aa017cd751cd4a67a357df9a0e7b5`.
The client provided the answer "Since the system admin sets the owner, as long as there's a system admin, a new o... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Inconsistent argument order between Deposited and Withdrawn events
### Description
The order of the `amount` and `shares` arguments between the `Deposited` and `Withdrawn` events are different, potentially leading to confusion and mix-ups when reading them on the front-end.
### Recommendation
Swap the order i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | critical | input-validation | true | false | ## Critical: Missing source validation in CCIP message handling
### Description
YieldFi integrates with Chainlink CCIP to facilitate cross-chain transfers of its yield tokens (`YToken`). This functionality is handled by the `BridgeCCIP` contract, which manages token accounting for these transfers.
However, in the [`B... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | true | ## Medium: Valid redemption proposals can be disputed when bad debt occurs by applying it to a SR outside of the proposal
### Description
### Impact
When bad debt occurs in the system it is socialized among all short records by increasing the `ercDebtRate`. At the next interaction with this short the `updateErcDebt` ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | true | false | ## Low: Use Class Method Instead Of Native Comparers
### Description
In the `verifyBridgeDeposit` function of the `web3NodeManager` class, there's a comparison between the `eventLog.Address` and the `nm.config.LBTCAddress` using a native comparison operator (`!=`). This approach is not optimal because Ethereum address... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | initialization | true | false | ## Gas: Using `calldata` instead of `memory` for read-only arguments in `external` functions saves gas
### Description
When a function with a `memory` array is called externally, the `abi.decode()` step has to use a for-loop to copy each index of the `calldata` to the `memory` index. **Each iteration of this for-loop ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: [07] PREIMAGE: `read` syscalls that read EOF might not be able to be executed via `step()` if `op-program` is compiled to MIPS in a certain way
### Description
A common way to detect an EOF is to perform a `read` syscall until the return value (the count of the number of bytes to read) is 0. When this happens,... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | cross-chain | false | false | ## Medium: Repaying AAVE Loan in `_local` rather than `adopted` asset
### Description
_Submitted by cloudjunky_
When repaying the AAVE Portal in [`repayAavePortal()`](https://github.com/code-423n4/2022-06-connext/blob/main/contracts/contracts/core/connext/facets/PortalFacet.sol#L80) the `_local` asset is used to repa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: getNextValidatorDetails() may return validators with zero addresses
### Description
If the requested number of validators `_numNewValidators` when calling `getNextValidatorDetails()` is bigger than the actual number of validators, this function will return validators with zero addresses. It will return availab... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Possibility to Skip Proposals By Changing Timelock
### Description
**Update**
Marked as "Acknowledged" by the client. The client provided the following explanation:
The addTimelock() function is overseen by the owner, referred to as OmnichainExecutorOwner, with its ownership managed by the Access Control Ma... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | rounding | true | false | ## High: Natural logarithm function silently accepts invalid non-positive inputs
### Description
The natural logarithm function (`ln()`) in the Ln.sol contract accepts negative numbers and zero as inputs without any validation, despite these inputs being mathematically invalid for logarithmic operations. In mathematic... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Admin-gated functionality
### Description
## Security Considerations for Juiced Backend Initialization
Although the `initialize` instruction is intended for the Juiced backend, it does not compare the provided backend signer against a fixed public key. If the backend does not initialize all strategies immedia... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: [07] Some lower decimal tokens cannot be transferred in Nibiru
### Description
[`x/evm/keeper/erc20.go`](https://github.com/code-423n4/2024-11-nibiru/blob/main/x/evm/keeper/erc20.go):
[`x/evm/types/params.go`](https://github.com/code-423n4/2024-11-nibiru/blob/main/x/evm/types/params.go):
The protocol enfor... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | cross-chain | true | true | Source: https://github.com/sherlock-audit/2023-01-optimism-judging/issues/138
## Found by
GalloDaSballo
## Summary
In contrast to `CrossDomainMessenger` which has a 5k gas buffer, the Optimism Portal doesn't, meaning all its relayed calls will have 5k+ less gas than intended.
This forces integrations (e.g. Bridge... | Sherlock | 5 | Optimism |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | input-validation | true | false | ## Medium: Wrong validation in `Goldigovernor.cancel()`
### Description
In `Goldigovernor.cancel()`, the proposer should have fewer votes than `proposalThreshold` to cancel his proposal.
```solidity
function cancel(uint256 proposalId) external {
if(_getProposalState(proposalId) == ProposalState.Executed) revert... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Defining Custom Cryptographic Operations Introduces Unnecessary Risks
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `f6517e6f906e3c8ebda26b308c8bad8524a9748c`. The client provided the following explanation:
> use OZ ECDSA module
**File(s) affected:**`EthenaMinting.sol`
**Descript... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Delayed Recovery Validation May Compromise Account Security
### Description
In the `OidcRecoveryValidator` contract, the account recovery process flow is divided into two separate function calls, with the `startRecovery` and `validateTransaction` functions, due to the high gas consumption associated with verif... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | true | false | ## Low: tokenId and amount fully controlled by the order strategy when matching two orders
### Description
When two orders are matched, the strategy defined by the `MakerOrder` is called to check whether the order can be executed.
```solidity
function matchAskWithTakerBidUsingETHAndWETH (
OrderTypes.TakerOrder call... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Transfer of busd to same recipient is unnecessarily repeated in loops
### Description
**Severity**: Medium
**Status**: Resolved
**Description**
dpnm_sc.sol - busd.safeTransfer(feeCollector, ...) is repeated in loop in both methods: _TreePayment and depositFordPNMBuy, safeTransfer is a costly operation, a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Refund mechanism doesn’t take into account that key price can change
### Description
## Handle
kenzo
## Vulnerability details
Lock manager can change key pricing.
The refund mechanism calculates refund according to current key price, not price actually paid.
## Impact
A user refunding can get less (or ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | upgrade | true | false | ## Low: `burn` should delete `tokenURI` related data and emit `TokenUriUnpinned` event
### Description
The `burn` function should delete `tokenURI` related data and emit `TokenUriUnpinned` event:
```diff
function burn(uint256 tokenId) public override whenNotPaused {
// require sender is owner or approved h... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | false | false | ## Low: Cache storage slots to prevent identical storage reads
### Description
Cache storage slots to prevent identical storage reads if the values don't change during execution.
For example, `Bet::accept,cancel,resolve` should cache `_aavePool` if it is likely to be non-zero since this saves 1 storage read in `accep... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: In case that `unstakingDelay` is decreased, users who have previously unstaked would have to wait more than `unstakingDelay` for new unstakes
### Description
Users who wish to unstake their RSR from StRSR have to first unstake and then wait `unstakingDelay` till they can actually withdraw their stake.
The ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Revert strings length
### Description
Revert strings cost more gas to deploy if the string is larger than 32 bytes. It costs an extra `9,500` gas per string exceeding that 32-byte size upon deployment.
### Proof of Concept
Revert strings exceeding 32 bytes include instances:
##### src/utils/MerkleBase.sol
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Account implementation can be initialized
### Description
When a user creates a new `ERC4337Account`, they are actually deploying a minimal `ERC1967` proxy to a shared `ERC4337Account` implementation. As part of this flow, the `ERC4337Account` has an `initialize()` function that's expected to run in the proxy'... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Documentation and Typographical Issues
### Description
**Update**
The client fixed the issue in commit `bf2731499bbf3f072bf5934b2f96ae32ed52d18e` and provided the following explanation:
> All recommendations have been implemented.
All points have been addressed except for #1.
**Description:**
1. To improv... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | logic | true | false | ## Low: The logger is not related to the business logic. If possible, remove it as it increases the cost of the function itself.
### Description
**Recommendation**:
If it has no relation to the business logic, it’s better to remove it in order to improve gas
efficiency. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: The current implementation of the VotingEscrow contract doesn’t support fee on transfer tokens
### Description
## Lines of code
https://github.com/code-423n4/2022-08-fiatdao/blob/fece3bdb79ccacb501099c24b60312cd0b2e4bb2/contracts/VotingEscrow.sol#L418
## Vulnerability details
## Impact
Some ERC20 tokens... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: `Minter.sol#startInflation()` can be bypassed.
### Description
_Submitted by WatchPug, also found by 0x52_
As `lastEvent` and `lastInflationDecay` are not initialized in the `constructor()`, they will remain to the default value of `0`.
However, the permissionless `executeInflationRateUpdate()` method does... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Oracle can send reports for any block
### Description
An oracle can send a report for any block range, including old blocks and new blocks https://github.com/TwoFiftySixLabs/mntEth/blob/bd15a96aee7df0fc0566d662df0cf50ff2619d31/src/OracleQuorumManager.sol#L182.
### Recommendation
We recommend adding an alert i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: Race condition in the ERC20 approve function may lead to token the�t
### Description
The ERC20 standard contains a known race condition on the `approve` function, making possible the theft of tokens. The ERC20 standard describes how to create generic token contracts. Among others, an ERC20 contract has to def... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: A missing reward update in UsualSP::removeOriginalAllocation will cause reduced reward accumulation for users
### Description
The missing reward update in `removeOriginalAllocation` will cause a reduction in reward accumulation for users as the contract directly resets the `originalAllocation` variable withou... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Misleading Comment
### Description
Incorporating documentation and comments into the codebase is essential for elucidating key aspects and facilitating comprehension of the developer's intentions by others. However, the codebase contains a misleading comment in the `verify_pending_sign_request_amount` function... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | token | true | false | ## Low: Wrong event data field in `ERC20PeriodTransferEnforcer`
### Description
In the `ERC20PeriodTransferEnforcer` it emits the following event when this caveat is used:
```solidity
/**
* @notice Emitted when a transfer is made, updating the transferred amount in the active period.
* @param sender The ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | reentrancy | false | false | ## High: forceUnsponsor() may open a window for attackers to manipulate the _totalShares and freeze users’ funds at a certain deposit amount
### Description
## Handle
WatchPug
## Vulnerability details
https://github.com/code-423n4/2022-01-sandclock/blob/a90ad3824955327597be00bb0bd183a9c228a4fb/sandclock/contracts/... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: cronJob checkTokens Return Value Is Not Necessary ✓ Fixed
### Description
The cronJob `checkTokens` return value is not necessary as it will never be accessed, and should be omitted.
### Recommendation
Addressed by [tezoroproject/metamask-snap#46](https://github.com/tezoroproject/metamask-snap/pull/46) | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Use low-level `call()` to prevent gas griefing attacks when returned data not required
### Description
**Description:** Using `call()` when the returned data is not required unnecessarily exposes to gas griefing attacks from huge returned data payload. For [example](https://github.com/dexe-network/DeXe-Protoco... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Avoid Reading and writing to state if amount is zero
### Description
### 4 Instances
1. ### Refactor `PaymentEscrow._decreaseDeposit()` to avoid state read/write if `amount` is zero
- https://github.com/re-nft/smart-contracts/blob/3ddd32455a849c3c6dc3c3aad7a33a6c9b44c291/src/modules/PaymentEscrow.sol#L294
In... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: An infinite loop in `MultiFeeDistribution.sol` withdraw
### Description
An infinite loop will block the withdraw process.
### Proof of Concept
In the MultiFeeDistribution.sol the `withdraw` function will start going through user's locked amounts if they do not have enough unlocked to cover their withdraw re... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `Timelock` checks for `1` instead of `DONE_TIMESTAMP`
### Description
This should be `DONE_TIMESTAMP`
https://github.com/solidity-labs-io/kleidi/blob/1a06ac16bc99d0b4081281329d03064c3737f5e4/src/Timelock.sol#L430-L431 | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | cross-chain | true | false | ## Medium: MISSING CHAIN ID AND RECEIVER ADDRESS VERIFICATION IN EXECUTEPROPOSAL() FUNCTION
### Description
The `executeProposal()` function in the current smart contract is responsible for parsing and verifying VAAs (Validators Aggregated Attestations) and then executing transactions based on these VAAs. The function... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | true | false | ## Low: DoS risk with zero-amount transfers
### Description
_Resolved_
The `Marketplace` contract currently performs transfers using the `transferFrom` method for both the `sellerAmount` and the `feeAmount` without checking if these amounts are greater than zero.
This can lead to Denial of Service (DoS) vulnerabili... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Favorable swap outcomes not returned to user in Underlying-to-YT zap
### Description
_Acknowledged_
The *YT_SWAP_UNDERLYING_FOR_YT* command in `Dispatcher.sol` facilitates a complex "zap" transaction where a user swaps an underlying token for a Yield Token (YT). This operation involves an internal swap where ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Calculation Mistake on `_fulfill()` And `_fulfillBatch()` Functions
### Description
On line 510 should consider using `gETH.denominator()` when increasing the claimableETH on `_fulfill()`.
On line 486 should consider using `gETH.denominator()` increasing the claimableETH on `_fulfillBatch()`.
This finding h... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.