prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Airstreams have to be renounced individually
### Description
When airstreams are claimed, the cancelability is set based on the immutable `CANCELABLE` specified during the creation of the MerkleLockup contract. If the sender wants to renounce cancelability, they are required to do so on each stream individuall... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: USER_TYPE_HASH and SOLVER_TYPE_HASH define data as bytes32
### Description
The `USER_TYPE_HASH` and `SOLVER_TYPE_HASH` define data as `bytes32`, while in reality it is `bytes`. The functions `_getProofHash()` and `_getSolverHash()` do already hash the data.
```solidity
bytes32 constant USER_TYPE_HASH = keccak... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Using a single tokenRecipient inVeryFastRouter could result in locked NFTs
### Description
## Severity: Medium Risk
**Context:**
- VeryFastRouter.sol#L45
- VeryFastRouter.sol#L134-L139
- VeryFastRouter.sol#L158-L210
- LSSVMRouter.sol#L42-L43
**Description:**
VeryFastRouter uses a single `tokenRecipi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: ExManager.confirmWithdrawal() can be front ran causing a revert for the original caller
### Description
The `confirmWithdrawal()` function is permissionless and can be called by anyone for any recipient. This design introduces a griefing vector: a frontrunner can pre-emptively confirm another user's withdrawal... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Don't compare boolean expressions to boolean literals (2 instances)
### Description
Deployment Gas Saved: **1 607**
* src/policies/Governance.sol:[223](https://github.com/code-423n4/2022-08-olympus/blob/b5e139d732eb4c07102f149fb9426d356af617aa/src/policies/Governance.sol#L223), [306](https://github.com/code-... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | true | false | ## Low: Unused Import
### Description
During the security assessment of the smart contracts, an instance of unused import was found. Unused imports can clutter the codebase, reducing readability and potentially leading to confusion during development or auditing. Additionally, unnecessary imports can slightly increase... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: Donated tokens are never deposited into vaults
### Description
The `HyperEvmVault` contract has to use the asset balances of the `VaultEscrow`s in the share's price calculation to handle tokens being received from the system contract. In normal the balances should not exceed the `$.requestSum.assets` value. T... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Documentation issues
### Description
Although many functions in the codebase are well documented, there are numerous other functions that are lacking sufficient inline documentation. For example:
* Missing NatSpec for all functions of [`VaultLifecycle`](https://github.com/ribbon-finance/ribbon-v2/blob/3fa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Ternary operator in `Sun::rewardToHarvestable` can be simplified
### Description
In [`Sun::rewardToHarvestable`](https://github.com/BeanstalkFarms/Beanstalk/blob/c7a20e56a0a6659c09314a877b440198eff0cd81/protocol/contracts/beanstalk/sun/SeasonFacet/Sun.sol#L162-L172), the `newHarvestable` variable is [reassigne... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | false | false | ## Medium: If an auction has no bidder, the NFT ownership should go back to the loan lenders
### Description
The lenders in principal have the claim for the loan collateral, but current rule will let the liquidation caller get the collateral for free. Effectively take advantage from the vault LP, which is not fair.
#... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: withdrawal request override
### Description
It is possible that a withdrawal request is overridden during the initial phase.
### Impact
While not very likely to happen, the impact would be huge, because the users who invoke this function several times before the first rebalance, would burn their shares and... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Inefficiency from fixed `BPS_BUFFER` value in position scaling
### Description
The `BPS_BUFFER` constant is currently set to `500`, representing a 5% buffer when scaling down positions in the `ArbitrumStrategyManager` contract.
This fixed value can lead to **inefficiencies in liquidity management**, particul... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | overflow | true | false | ## Medium: Incorrect boundaries check in GeVault's `getActiveTickIndex` can temporarily freeze assets due to Index out of bounds error
### Description
`GeVault` stores the `TokenisableRange` instances it operates on in an ordered array:
Whenever a rebalancing happens, the `GeVault` contract withdraws all its liquidi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: No check for amount > 0
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
In contract cloudX_staker.sol and contract cloudX_rewardLocker.sol, the method emergencyWithdraw(..) does not check if the parameter _amount is zero.
In contract cloudX_rewardLocker.sol, the method dis... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Liquidity withdrawal can be blocked
### Description
The main problem in that issue is that the liquidity provider may face many potential issues when withdrawing the liquidity. Under some circumstances, a normal user will never be able to withdraw the liquidity. This issue consists of multiple factors that ar... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Improvements
### Description
**Update**
Marked as "Acknowledged" by the client. The client provided the following explanation:
> Fix applied for point 1. No fix issued for point 2
**File(s) affected:**`Vepoch.sol`
**Description:** We identified some code sections where gas usage could be improved:
1. `Vep... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | true | false | ## Low: Fee subtraction before yield update can cause arithmetic underflow
### Description
The `withdraw()` and `redeem()` functions in the UsualX contract subtract the withdrawal fee from `totalDeposits` before updating the yield. This can lead to an arithmetic underflow when a user's deposit is smaller than the yield... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Business Logic | false | true |
Fees are taken on funds deposited as collateral.
### Proof of Concept
uint256 feeValue = calculateWithdrawalFeeValue(entitledShares, id);
In L226 of Vault.sol#withdraw the fee is taken on the entire collateral deposited by the risk users. This is problematic for two reasons. The first is that the collateral pro... | Code4rena | 4 | Y2k Finance |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | false | false | ## Low: share to asset ratio is 1:1 for convertToShares and convertToAssets when currentPPS == 0 but not
### Description
## for totalAssets
**Severity:** Low Risk
**Context:** SuperVault.sol#L318
**Description:**
There's a difference in handling of share-to-asset ratio in the `convertToShares`/`convertToAssets... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Version Mismatch in Floatcontroller Contract
### Description
**Update**
Acknowledged by the client. The pragma remains unlocked at `^0.8.13` in the contract. However, the version was set to 0.8.28 in the `foundry.toml` file. Addressed in: `cffe6a268c96445a9bce1a5ec79e62a974a1178d`. The client provided the foll... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | front-running | false | false | ## High: Tokens Can Be Stolen By Frontrunning VestedRewardPool.vest() and VestedRewardPool.lock()
### Description
## Handle
leastwood
## Vulnerability details
## Impact
The `VestedRewardPool.sol` contract is a public facing contract aimed at vesting tokens for a minimum of 90 days before allowing the recipient to... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: transferFrom o�ten does not follow spec
### Description
If the message sender is the source of a `transferFrom` call, the sender’s allowance will not be considered, and the transfer will initiate immediately. This breaks invariants expected of `transferFrom`. Traditionally, the `transferFrom` method moves toke... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | false | false | ## High: Canceling an auction will result in a loss of borrower funds towards initiator fees
### Description
The initiator fee on the current bid has already been accounted during that bid but is expected to be paid again on cancellation by the borrower.
### Impact
Canceling an auction will require paying (a lot) mor... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: ANDROID - BACKGROUND SCREEN CACHING
### Description
Background screen caching refers to the process where an application’s screen is captured and displayed as a preview in the recent apps/task manager view. While this feature provides a seamless user experience, it poses a potential security risk when sensitiv... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: Wrong `_prevRatios` index could be used
### Description
**Severity**
**Impact:** Medium
**Likelihood:** High
**Description**
When `addLiquidity` is called and initial liquidity has already been provided, the caller can skip providing one of the listed tokens by setting the corresponding value in `amounts_... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Events missing
### Description
Several functions should emit an event for better UX in possible integrations:
https://github.com/cryptoalgebra/Algebra/blob/7290fad656bfa89db3743c52af631154f6a8a2d5/src/tokenomics/contracts/farmings/AlgebraEternalFarming.sol#L186-L195
https://github.com/cryptoalgebra/Algebra/blo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: [33] Remove the trailing comma after queries to `isNotEnoughGasForPubdata` in the bootloader to enforce no error in the Yul Syntax
### Description
### Proof of Concept
Take a look at https://github.com/code-423n4/2024-03-zksync/blob/4f0ba34f34a864c354c7e8c47643ed8f4a250e13/code/system-contracts/bootloader/boo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: `maxAllowedTokenRateDeviationPerDay_` is not checked
### Description
`maxAllowedTokenRateDeviationPerDay_` cannot exceed the value of `BASIS_POINT_SCALE` https://github.com/lidofinance/lido-l2-with-steth/blob/792071cdeaf61de927cc144e8c1c02d5f5996a01/contracts/optimism/TokenRateOracle.sol#L74.
### Recommendati... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: The redundant call to `pool.oddsBPS.indexOf(ratio)`
### Description
The `GachaTickets::getPayout` function selects the `oddsBPS ratio` randomly by calling the `pool.oddsBPS.pick` function. The implementation is as follows:
Once the `oddsBPS ratio` is selected the `getPayout` function calls the `pool.oddsBPS.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Updating the policy for the existing method will lead to adding unnecessary `byteOffset` to the `paramOffsets` array
### Description
There is an issue at lines https://github.com/MetaLex-Tech/borg-core/blob/9074503d37cfa1d777ef16f6c88b84c98b4f54eb/src/borgCore.sol#L262 and https://github.com/MetaLex-Tech/bo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | false | false | ## Low: Check backwards-compatibility throws for versions 10 and above
### Description
The [`fromGetVersionNumberReturnValue` function of the `ContractVersion` `class`](https://github.com/celo-org/celo-monorepo/blob/0e876e5cad0e93f5dd1fff853f4be3c9a0e5c2a7/packages/protocol/lib/compatibility/version.ts#L36) converts e... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Greedy Contracts
### Description
**Update**
Mints will fail if the payment token is not ETH and the `msg.value` is non-zero.
Addressed in: `f015d8aa81bbcc9e0ae21ef924c115390e174c8c`.
**File(s) affected:**`ERC1155Sale.sol`, `ERC721Sale.sol`
**Description:** Sale contracts can be configured to accept payments... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | true | false | ## Medium: Incorrect encoding of bytes for EIP712 digest in `TitleGraph` causes signatures generated by common EIP712 tools to be unusable
### Description
The signature in `TitleGraph.acknowledgeEdge()` and `TitleGraph.unacknowledgeEdge()` is generated based on a digest computed from `edgeId` and `data`. However, ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | storage | false | false | ## Medium: Unnecessary inheritance from `Proxy`
### Description
All functions for `yVault` called from proxy wouldn't work because the storage is not the same:
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/contracts/integrations/yearn/YearnPriceFeed.sol#L17
### Re... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Overshadowing Of token in `Staking.withDrawFunds` May Cause Accidental Change to Staking Token
### Description
**Severity**: Medium
**Status**: Resolved
**Description**
The `withDrawFunds` function in the Staking contract is used for administrators to clean out unusable tokens or to rescue funds in case ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | true | ## High: Proposal transactions can be executed separately and block Proposal.execute call
### Description
Missing access controls in the `Timelock.executeTransaction` function allow Proposal transactions to be executed separately, circumventing the `Governor.execute` function. This means that even though the `Proposal... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Panoptic pool can be non-profitable by specific Uniswap governance
### Description
Swap commission is paid on the intrinsic value based on `s_ITMSpreadFee` in `CollateralTracker` contract.
If `s_ITMSpreadFee` is zero, then swap commission can not be paid.
### Proof of Concept
As you can see above code sn... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | true | false | ## Low: offboard() doesn't delete everything
### Description
The function `offboard()` doesn't remove `orgs[msg.sender].approvers[SENTINEL_ADDRESS];`. It doesn't pose a security risk though, as in `onboard()`, this slot will be overwritten anyway with the current implementation.
```solidity
function offboard() extern... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Adding/replacing a new reward token is not supported
### Description
The Convex pool allows the owner to add new reward tokens at any time and also replace one reward token with another. If such an event occurs, the new token will not be added to the Gearbox protocol and will remain in the balance of the cr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | signature | false | false | ## High: Invalid aggregate signature [samples]
### Description
The `BLSSignatureAggregator` exposes a mechanism to let the bundler [validate individual signatures](https://github.com/eth-infinitism/account-abstraction/blob/6dea6d8752f64914dd95d932f673ba0f9ff8e144/contracts/bls/BLSSignatureAggregator.sol#L123) before c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Too flexible logic
### Description
`updatePolicy` can be used to update existing policies or add new ones. The chosen architecture is too flexible, making it harder to control the correctness of parameter updates for the owner. The same issue also applies to the `updateMethodCooldown` function:
- https://gi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | overflow | true | false | ## High: Rounding errors after slashing ✓ Addressed
### Description
When slashing happens `_delegatedToValidator` and `_effectiveDelegatedToValidator` values are reduced.
**new\_code/contracts/delegation/DelegationController.sol:L349-L355**
```
function confiscate(uint validatorId, uint amount) external {
uint c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | true | false | ## Low: onMessageInvocation checks in _invokeMessageCall() can be bypassed to call arbitrary function from Bridge contract
### Description
[Link](https://github.com/code-423n4/2024-03-taiko/blob/f58384f44dbf4c6535264a472322322705133b11/packages/protocol/contracts/bridge/Bridge.sol#L490)
The if block requires the data... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Escrow Balance Mismanagement
### Description
## WithdrawLp Instruction in Exponent Core
In the `WithdrawLp` instruction in `exponent_core`, `do_transfer_lp_out` transfers LP tokens from the market’s escrow account to the user’s destination account (`token_lp_dst`). However, the `market.lp_escrow_amount`, whi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: New NAV per share calculation when setting streaming fee could be stale
### Description
**Severity:** Low
**Path:** AutopoolFees.sol:setStreamingFeeBps
**Description:**
When setting a new streaming fee, the `navPerShareLastFeeMark` is reset to the current share rate so that the new streaming fee is not appl... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Ownership Can Be Renounced
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `f6311e7`.
Review comment: fixed as recommendation.
**Description:** The function `renounceOwnership` in the `Ownable` contract is not overridden to prevent the contract from being left with no owner. If the... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | input-validation | true | true | ## Medium: Transfer Amount enforcer for ERC20 and Native transfers increase spend limit without checking actual transfers
### Description
Failed token/native transfers can potentially deplete a delegation's spending allowance when used with the `EXECTYPE_TRY` execution mode.
The issue occurs because the enforcer trac... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: PnL is incorrectly counted as collateral when determining whether to close positions automatically
### Description
GMX uses `MIN_COLLATERAL_USD` to ensure that there is always enough collateral remaining in a position, so that if there are sudden large gaps in prices, there is enough collateral to cover pot... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: SPDX license identifier not provided in DVGToken.sol
### Description
**Description**
Trust in smart contracts can be better established if their source code is available. Since
making source code available always touches on legal problems with regards to copyright, the
Solidity compiler encourages the use of ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: Liquidation fees are permanently frozen on Penrose YB account
### Description
There is no treatment of liquidation fees in SGL, they are frozen on Penrose YB account.
### Impact
Protocol-wide loss of funds, which othwerwise would be channelled to stakers.
### Recommendation
Consider placing liquidation fees... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: For functions, follow Solidity standard naming conventions
### Description
[AutoPxGlp.sol#L487](https://github.com/code-423n4/2022-11-redactedcartel/blob/main/src/vaults/AutoPxGlp.sol#L487)
[AutoPxGlp.sol#L501](https://github.com/code-423n4/2022-11-redactedcartel/blob/main/src/vaults/AutoPxGlp.sol#L501)
[Aut... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: Attacker Can Decide The Initialization Ratio Of The AMM Pair
### Description
When the RA/CT is deposited in the AMM pool it must follow a pre defined ratio , but the attacker can see the pair has been deployed on uniV2 and make the first deposit (adding liquidity) and distrupt the intended ratio of the CT/R... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: QUEUE NOT ENFORCED TO BE EMPTY RIGHT AFTER POPPING ALL ELEMENTS
### Description
The `MERKLEIZER` circuit (`merkleize_l1_messages`) does not enforce the initial queue to be empty right after popping all elements. Even though it does it at the end of the circuit, as this circuit is resource-consuming while compu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | other | false | false |
<https://github.com/code-423n4/2022-07-golom/blob/e5efa8f9d6dda92a90b8b2c4902320acf0c26816/contracts/vote-escrow/VoteEscrowDelegation.sol#L242><br>
<https://github.com/code-423n4/2022-07-golom/blob/e5efa8f9d6dda92a90b8b2c4902320acf0c26816/contracts/vote-escrow/VoteEscrowDelegation.sol#L211><br>
The `VoteEscrowDelega... | Code4rena | 5 | Golom |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Change visibility from public to external
### Description
The functions `pause()`, `unpause()`, `registerOperator()`, `registerOperatorWithFeeDestination()`, and `unregisterOperator()` are not used internally in the contract. Therefore, they can be changed from `public` to `external`.
### Recommendation
The r... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Potentially dangerous use of a cached exchange rate from Compound
### Description
`GPortfolioReserveManager.adjustReserve` performs reserve adjustment calculations based on Compound’s cached exchange rate values (using `CompoundLendingMarketAbstraction.getExchangeRate()`) then triggers operations on managed... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Constant redefined elsewhere
### Description
Consider defining in only one contract so that values cannot become out of sync when only one location is updated. A [cheap way](https://medium.com/coinmonks/gas-cost-of-solidity-library-functions-dbe0cedd4678) to store constants in a single location is to create an... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | true | false | ## Low: The `nonReentrant` `modifier` should occur before all other modifiers
### Description
This is a best-practice to protect against reentrancy in other modifiers
1. File: contracts/PaladinRewardReserve.sol (line [52](https://github.com/code-423n4/2022-03-paladin/blob/9c26ec8556298fb1dc3cf71f471aadad3a5c74a0/con... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: The deposit /redeem are too permissioned
### Description
The deposit and redeem functions are permissioned and can only be called by the `onlyOwner`. These functions can only process requests created by users and cannot freely mint or pull shares/assets. Having these functions restricted to `onlyOwner` can com... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Liquidators Must Supply Collateral Asset Before Redeeming Seized Rewards
### Description
Liquidators can initiate liquidations even if they haven’t previously supplied the asset being liquidated. However, during this process, although their `totalInvestment` is updated based on the difference between `seize... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: Improper Oracle Update
### Description
## Update Pool State Documentation
`pool::update_pool_state` is responsible for updating the state of the liquidity pool after a swap operation occurs. In the current code, `oracle::update` is called after the pool’s `current_tick_index` and `current_sqrt_price` have bee... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Need Fuzzing test
### Description
In total 1 contracts, 2 unchecked are used, the functions used are critical. For this reason, there must be fuzzing tests in the tests of the project. Not seen in tests.
### Recommendation
Use Fuzzing test like Echidna.
As Alberto Cuesta Canada said:
_Fuzzing is not easy, t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: transferFrom uses allowance even if spender == from
### Description
Pool#transferFrom attempts to use allowance even when spender = from. This breaks compatibility with a large number of protocol who opt to use the transferFrom method all the time (pull only) instead of using both transfer and transferFrom ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | false | false | ## Gas: State variables can be packed into fewer storage slots
### Description
If variables occupying the same slot are both written the same function or by the constructor, avoids a separate Gsset (20000 gas). Reads of the variables are also cheaper.
Consider making this state var near one of the address types (does... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: `yVault.withdraw()`: L178 should be unchecked due to L177
### Description
See `@audit` tag: | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Redundant Inheritance
### Description
The `BsxToken` contract includes redundant inheritance, which unnecessarily increases the complexity of the contract. Specifically, it inherits from `ERC20`, which is already inherited by `ERC20Permit` and `ERC20Votes`:
```
contract BsxToken is ERC20, ERC20Permit, ERC20Vo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Price Feed May Unnecessarily Resort to Stale Data
### Description
**Update**
Marked as "Acknowledged" by the client. The client provided the following explanation:
> We use the oracle that liquity used.
**File(s) affected:**`PriceFeed.sol`
**Description:** At `PriceFeed.sol#265`, it is required that both Ch... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: priceLiquidity() may not work if PriceFeed.aggregator() is updated
### Description
priceLiquidity() may not work if PriceFeed.aggregator() is updated
### Recommendation
Consider getting latest priceFeed.aggregator().minAnswer()/maxAnswer() in priceLiquidity() | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | Business Logic | false | false | Source: https://github.com/sherlock-audit/2022-10-rage-trade-judging/issues/62
## Found by
0x52, clems4ever
## Summary
DnGmxJuniorVaultManager#_rebalanceBorrow fails to rebalance correctly if only one of the two assets needs a rebalance. In the case where one assets increases rapidly in price while the other stays... | Sherlock | 5 | Rage Trade |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: The lack of slippage protection leads to capital loss
### Description
In the `Controller.earningPulls()` function, if `bountyPullerTo_` is not equal to `account_`, the protocol calculates `amountForPuller`, converts this amount of wstETH to WETH, and then transfers it to the user as ETH:
```solidity
if (bo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Specific Hyperdrive factories should ensure that local storage vars used match the ones of the deployer
### Description
Some storage variables like `pool` are duplicated in the yield-source specific factories (like `ERC4626HyperdriveFactory`) and their deployer contracts (like `ERC4626HyperdriveDeployer`). The... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: User funds lock in MyStaking due to stakerCount manipulation.
### Description
**Description**
MyStaking.sol: function_withdraw(). When the user stakes, there is the increase of the counter 'stakerCount on line 227. After that, when the user redeems their funds, there is the subtraction of the counter in the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Constructor visibility
### Description
Visibility (public / external) is not needed for constructors anymore since Solidity 0.7.0, see [here](https://docs.soliditylang.org/en/v0.7.0/070-breaking-changes.html#functions-and-events)
### PROOF OF CONCEPT
Instances include:
#### lending-market/AccountantDelegato... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | true | ## Low: Lack of documentation concerning Rescuable base contract could result in exploitable modifications
### Description
The protocol uses a **Rescuable** base contract that allows privileged rescuer addresses to recover funds that were accidentally sent to the contracts. This rescue functionality is a controlled bac... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: EOA owner can change LZ settings in the `HoneyJar.sol`
### Description
Since the `HoneyJar.sol` inherits the `multisigOwnable.sol`, it has two owners: `realOwner` is the multisig that controls the token's admin functions and `owner` an EOA that is used for OpenSea collections management.
In the snippets below... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: `VaderReserve.reimburseImpermanentLoss` improperly converts USDV to VADER
### Description
_Submitted by TomFrenchBlockchain_
IL isn't properly converted from being in terms of USDV to VADER, resulting in reserve paying out incorrect amount.
#### Proof of Concept
`VaderReserve.reimburseImpermanentLoss` re... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | false | false | ## High: Duplicate validation gas accounting [core]
### Description
The [`handleOp` function](https://github.com/eth-infinitism/account-abstraction/blob/8832d6e04b9f4f706f612261c6e46b3f1745d61a/contracts/EntryPoint.sol#L52) of the `EntryPoint` contract tracks and records both the [pre-operation gas](https://github.com... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Direct contract referencing instead of interfaces in SEuroCalculator.
### Description
**Description**
SEuroCalculator.
SEuroCalculator.sol - Reference of BondingCurve, TokenManager
Generally referencing the contracts as is rather than implementing interfaces.
**Recommendation**
Use interfaces for interactin... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Change function visibility from public to external
### Description
Various functions across contracts are never called from within contracts yet are declared public. Their visibility can be made external to save gas.
As described in https://mudit.blog/solidity-gas-optimization-tips/:
> “For all the public fun... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Potential Storage Fee Insufficiency in the `locker_bill` Contract
### Description
**Update**
The team has acknowledged and decided to keep the minor issue as it is.
**File(s) affected:**`locker_bill.fc`
**Description:** The `locker_bill` contract is created on the `op::deposit_to_bill` message, with 0.5 TON ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | true | false | ## Medium: Rewards from `RebaseReward` unclaimable after `veKITTEN` changes
### Description
Voting for pools generates rewards in `VotingReward` and `RebaseReward` for the next period. This means that when a vote is reset, there might be rewards pending from the current and previous periods.
If `withdraw()`, `merge()... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: PortalRegistry contract has payable function without any withdraw mechanism
### Description
## Low Risk Security Issue Report
**Severity:** Low Risk
**Context:** `PortalRegistry.sol#L93`
**Description:**
`PortalRegistry.sol#L93` contains the function `bulkRegister` that is payable. However, the contrac... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | false | false | ## Low: Events in BatchBet can be spoofed using custom pool/market
### Description
**Details**
[BatchBet.sol#L89-L111](https://github.com/SportsFI-UBet/ubet-contracts-v1/blob/7b61ff6631091056be51bf0bd88377560f6986f7/contracts/markets/BatchBet.sol#L89-L111)
for (uint256 i = 0; i address market = buys[i].market;
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Malicious users can double their voting power.
### Description
**Description:** When calculating The `voteWeight` of a delegatee, its own `ownVoteWeight` is added. This makes it possible for some users to double their voting power by constructing a cycle. For example, Alice delegates Bob, Bob delegates Alice.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: Deployer does not transfer ownership of `CapAutomator` to admin
### Description
The function `DeployCapAutomator.run` deploys an instance of `CapAutomator`, assigning `msg.sender` (the `deployer`) as the initial owner. But it does not transfer the ownership to the designated `admin`.
```solidity
function r... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Autocompounding is independent from StWSX functionality.
### Description
**Description**
StWSX.sol, oracleClaim Rewards()
Autocompounding flow is fully implemented on 3rd party contracts and components, has no effect on contract storage, and does not use any contract data. It is also crucial, as the autocompo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: Floating Pragma
### Description
Pragma directives should be fixed to clearly identify the Solidity version with which the contracts will be compiled.
Throughout the codebase, there are multiple floating pragma directives:
* `Clones.sol` has the [`solidity ^0.8.20`](https://github.com/1inch/cross-chain-swap... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: OUTDATED RUST EDITION
### Description
It was observed that the project is using outdated rust edition(2018). Recently, 2021 rust edition came out, which includes a lot of stability improvements and new features that might make the code more readable.
Code Location
-------------
### Recommendation
**ACKNOWLED... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: Reward tokens can be withdrawn without fee
### Description
InterPol takes a cut of the rewards accrued from staking of the tokens locked in the protocol when withdrawing the reward tokens. The rewards can be withdrawn with the `withdrawERC20` function, which also sends the fee to the protocol. However, users ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: | Invalid Assumption
### Description
**Description**
In the `acceptTransfer` function it is assumed that `A maximum of ~7% amount of GMX (as esGMX) would be added`, however that assumption does not hold in several cases.
A user could have removed their sGMX and only been left with esGMX and bnGMX or a user... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | false | false | ## Medium: Ownership transfer cancellation can be front-run
### Description
The `RecoverableWallet` contract implements an ownership transfer system whereby the owner may offer ownership of the `Ownable` contract to an address referred to as the `pending_owner`. This is achieved by calling the `start_ownership_transfe... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Frontrunning PublicLock.initialize() can prevent upgrades due to insufficient access control
### Description
## Handle
elprofesor
## Vulnerability details
## Impact
The unlock protocols base contract `Unlock.sol` uses `setLocktemplate()` to initialize the implementation contract for the `PublicLock` pro... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: `ApprovalAll` event is missing parameters
### Description
[HolographERC721.sol#L392](https://github.com/code-423n4/2022-10-holograph/blob/f8c2eae866280a1acfdc8a8352401ed031be1373/src/enforcer/HolographERC721.sol#L392)
`beforeApprovalAll()` / `afterApprovalAll()` can only pass "to" and "approved", missing "... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Calling `Curve::withdraw` will likely result in users losing ETH
### Description
**Severity**
**Impact:**
High, as users can lose ETH value
**Likelihood:**
High, as all >75 Curve pools that have ETH are problematic
**Description**
The `Curve::withdraw` method removes liquidity from a pool to burn LP token... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: Functions that round by adding 1 result in unexpected behavior
### Description
Unit conversion functions in the Assembly contract add 1 to the results of their division operations to round them up, which results in unexpected rounding effects.
The `scaleFromWadUp()` function is used to convert the input for sw... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Usage of “magic” numbers
### Description
**Description**
buyCover(), line 205, line 237
Avoid usage of “magic” numbers for the accuracy of calculations. Consider usage of the
constant.
**Recommendation**:
Consider usage of the constant. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: Possible DOS attack using dust in `ReraiseETHCrowdfund._contribute()`
### Description
Normal contributors wouldn't contribute to the crowdfund properly by a malicious frontrunner.
### Proof of Concept
When users contribute to the `ReraiseETHCrowdfund`, it mints the crowdfund NFT in `_contribute()`.
As w... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Missing Long Descriptions In Cli Affects Usability And User Experience
### Description
The Command Line Interface (CLI) for the module is currently lacking long descriptions, which are available in the Cosmos SDK. Long descriptions provide users with detailed information about the purpose and usage of CLI comm... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: YieldMath.sol / Log2: >= or > ?
### Description
The V1 version of `YieldMath.sol` contains ">=" (larger or equal), while the V2 version of `YieldMath.sol` contains ">" (larger) in the log_2 function.
This change doesn't seem logical and might lead to miss calculations.
The difference is present in several adj... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Hook check may be bypassed
### Description
In Nexus, there is one hook mechanism. We use this hook mechanism to do pre-checks and post-checks of transactions to ensure conditions and state consistency.
In some key functions, such as `execute`, `executeFromExecutor`, we will add this `withHook` modifier. In `w... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.