prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | token | true | false | ## Low: `BorrowingFeePaid` event should include token that was repaid
### Description
`BorrowingFeePaid` event should include collateral token that was repaid:
```diff
- event BorrowingFeePaid(address indexed borrower, uint256 amount);
+ event BorrowingFeePaid(address indexed borrower, IERC20 collateralToken, uint256 ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | initialization | true | true | ## Medium: `IncentivizedERC20` should not be hardcoded to 18 decimals
### Description
Whenever a new `IncentivizedERC20` is created to represent the liquidity of a given pool, its decimals are hardcoded to 18:
```solidity
contract IncentivizedERC20 is ERC20, Owned {
...
constructor(string memory name, string ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Unsafe ERC20 transfers
### Description
**Description:** `Hype_Module::hyper_depositSpot` uses `IERC20(token).transfer(...)` directly and ignores the return value. Many ERC-20s are non-standard (e.g., USDT) and either don’t return `bool` or revert on failure in non-obvious ways, making bare `transfer`/`transfer... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Bulls that are unable to receive NFTs will not be able to claim them later
### Description
A lot of care has been taken to ensure that, if a bull has a contract address that doesn't accept ERC721s, the NFT is saved to `withdrawableCollectionTokenId` for later withdrawal. However, because there is no way to ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: `LibSilo::_removeDepositsFromAccount` events may be emitted with additional `amounts` elements when called from `EnrootFacet::enrootDeposits` with `amounts.length > stems.length`
### Description
For the purpose of gas efficiency, `EnrootFacet::enrootDeposits` does not validate that its `stems` and `amounts` ar... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: UNNEEDED INITIALIZATION OF UINT256 VARIABLES TO 0
### Description
Since `i` is an `uint256`, it is already initialized to 0. `uint256 i = 0` reassigns the 0 to `i` which wastes gas.
Code Location
-------------
`TokenSaleDistributor.sol`
* Line 157: `for (uint i = 0; i < recipients.length; i += 1) {`
### Re... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: for WASM program activation not charged early enough
### Description
The gas for activating WASM programs is not charged early enough in the activation code to prevent denial-of-service attacks. WASM activation is a computationally expensive operation that involves decompressing bytecode (Figure 1.1).
```g... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | false | false | ## Low: Iteration through array can consume great amount of gas.
### Description
**Description**
ReferralRegistry.sol: migrateReferral().
FNDZController.sol: getIndex().
Iteration through array can consume a lot of gas. In case array has too many elements,
iteration can consume more gas,
than can fit in a single bloc... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: Key fork parameters are set outside of proposal flow, while aren't being controlled in the code
### Description
These configuration parameters are crucial for fork workflow and new DAO logic, but aren't checked when being set in `ForkDAODeployer`'s constructor:
```solidity
contract ForkDAODeployer is IFork... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | reentrancy | true | false | ## High: Re-entrancy causes draining of funds through withdraw & SwapTo Function of EntangleTestBridge Contract
### Description
Finding description placeholder
### Recommendation
Restructure the `withdraw` function to update the contract's internal state (`tokenStorage[address(token)] -= amount`) before performing th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Insu�cient event generation
### Description
Multiple user operations do not emit events. As a result, it will be difficult to review the contracts’ behavior for correctness once they have been deployed. Events generated during contract execution aid in monitoring, baselining of behavior, and detection of suspi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: [05] Use Custom Errors
### Description
### Proof of concept
*There are 14 instances of this issue. (For in-depth details on this and all further gas optimizations with multiple instances, please see the warden's [full report](https://github.com/code-423n4/2023-05-base-findings/issues/11)).*
### Mitigation
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Misleading method GoDoc `GetPoolBalances`
### Description
GoDoc method comment for `pool:GetPoolBalances` does not describe the method correctly (it may be a copy, paste & edit error from the proceeding method in the file).
### Recommended Mitigation | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | false | false | ## Low: Use `calldata` instead of `memory` for inputs to `external` functions
### Description
Use `calldata` instead of `memory` for inputs to `external` functions. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Don't cache if used only once
### Description
Caching here will simply increase gas cost, since it doesn't affect readability, we should not cache since we only reference the cached variables only once.
https://github.com/open-dollar/od-contracts/blob/f4f0246bb26277249c1d5afe6201d4d9096e52e6/src/contracts/pro... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: The derivative in calculateMaxBuyBondsOutDerivativeSafe is not calculated correctly
### Description
The derivative in `calculateMaxBuyBondsOutDerivativeSafe` is not calculated correctly. Let:
\[ F(z) = dy_{max}(z) = y \frac{K}{c \sigma + 1} \frac{1}{1 - ts} y_{net} \]
where \( K \) is:
\[ K = c \sigma \left... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Use of deprecated function
### Description
**Severity**: Informational
**Status**: Resolved
**Function**: cosmwasm_std::to_binary
**Lines**: 6
**Description**:
Function `cosmwasm_std::to_binary` is deprecated
**Recommendation**: Use `to_json_binary` function instead | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | true | false | ## Gas: Using `bool`s for storage incurs overhead
### Description
Utilizing booleans for storage is less gas-efficient compared to using types that consume a full word like uint256. Every write operation on a boolean necessitates an extra SLOAD operation to read the slot's current value, modify the boolean bits, and t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | token | true | false | ## Low: `MembershipFactory::joinDAO` will not function correctly with fee-on-transfer tokens
### Description
While it is understood that the protocol does not intend to support fee-on-transfer tokens, it is prescient to note that `MembershipFactory::joinDAO` will [not function correctly](https://github.com/OneWpOrg/au... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `yUSDeVault` inherits from `PreDepositVault` but doesn't call `onAfterDepositChecks` or `onAfterWithdrawalChecks`
### Description
**Description:** `pUSDeVault` and `yUSDeVault` both inherit from `PreDepositVault`.
`pUSDeVault` uses `PreDepositVault::onAfterDepositChecks` and `onAfterWithdrawalChecks` inside i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Use a more recent pragma version
### Description
Old version of solidity is used, consider using the new one `0.8.17`.
You can see what new versions offer regarding bug fixed [here](https://github.com/ethereum/solidity/blob/develop/Changelog.md)
Instances - All of the contracts. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Liquidating positions of different accounts for the same market on the same block.timestamp uses the same fundingFeePerUnit regardless of the computed MarkPrice based on the size of the position been liqudiated.
### Description
When liquidating multiple accounts in the same tx, the fundingFeePerUnit that wi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | false | false | ## Medium: A liquidator can gain not only collateral, but also can reduce his own debt!
### Description
A liquidator can gain not only collateral, but also can reduce his own debt.
This is achieved by taking advantage of the following vulnerability of the ``liquidate()``:
it has a rounding down precision error and wh... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Suboptimal gas usage due to post-increment in loops
### Description
In multiple functions across the codebase, the `for` loops use `i++` (post-increment) for incrementing the loop counter. In Solidity, post-increment (`i++`) is slightly less efficient than pre-increment (`++i`) because `i++` requires storing t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Potential loss of funds on tokens with big supplies
### Description
`swap()` and `mint()` both reverts if either `2^112` or `2^128` tokens are sent to the pair. This would result in the funds being stuck and nobody being able to mint or swap. Submitting as low because the cost of attack is extremely high, but ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Users Might Not Be Able To Purchase Or Redeem SetToken
### Description
_Submitted by xiaoming90, also found by berndartmueller_
### Proof of Concept
Whenever a setToken is issued or redeemed, the `moduleIssueHook` and `moduleRedeemHook` will be triggered. These two hooks will in turn call the `_redeemMat... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Missing init functions on the upgradeable contracts
### Description
The contracts, which are designed to be upgradeable using the UUPS pattern, seem to be missing proper initialization functions. The initial setup for a UUPS upgradeable contract is crucial to ensure that the contract can be safely upgraded in ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | false | false | ## High: No Access Control on ReserveFeed Contract
### Description
The [`ReserveFeed` contract](https://github.com/Ion-Protocol/ion-protocol/blob/98e282514ac5827196b49f688938e1e44709505a/src/oracles/reserve/ReserveFeed.sol#L4) tracks exchange rates for each collateral type. The [`setExchangeRate` function](https://git... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Unnecessary validation in `finaliseDeposit`.
### Description
**Description**
Perpetual Tokens Farm.sol: function finalise Deposit(), line 1156.
TokensFarm.sol: function finaliseDeposit(), line 1058.
PerpetualTokensFarmSDK.sol: function finalise Deposit(), line 1076.
In PerpetualTokensFarm.sol and TokensFarm.s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | false | false | ## Low: [ACKNOWLEDGED] High decimals tokens support in `ZunamiStratBase`
### Description
In the `ZunamiStratBase` contract, the `tokenDecimalsMultipliers` variable is used to support tokens with fewer than 18 decimals. However, there is no provision to support tokens with more than 18 decimals.
### Recommendation
We ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `StardustToken` creation could always fail if pool is already created
### Description
When the `StardustToken` is first created, it will attempt to create a V2 pool with WETH and the `StardustToken`.
However, it is possible that an attacker that can predict the address of `StardustToken`, front runs the crea... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | timing | true | false | ## Medium: Zero‑Duration vesting edge case
### Description
When `duration == 0`, calling `vestedAmount(start)` falls through the `else if (_timestamp > start + duration)` check (because `start > start` is false) into the linear‑vest branch, executing
```solidity
(totalAllocation * (start - start)) / duration
```
Thi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: parameters for Stargate swap are hardcoded leading to stuck messages
### Description
The `dstGasForCall` for transferring erc20s through Stargate is hardcoded to 0 in the `Balancer` contract leading to `sgReceive` not being called during Stargate swap.
As a consequence, the `sgReceive` has to be manually ca... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: 14. PERMUTATION CONSTRAINT DISCREPANCY BETWEEN VERIFYPIL TOOLING AND STARK GENERATION
### Description
**Severity:** Informational
**Path:** pilcom/src/pil_verifier.js
**Description:**
In PIL language there is a selector polynomial for choosing specific lines to meet the constraints.
But there is differenc... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: [07] UNLIKE `DAO.deposit`, `DAO` CONTRACT HAS NO FUNCTIONS FOR DEPOSITING ERC721 AND ERC1155 TO DAO
### Description
Calling the following `DAO.deposit` function with the `_token` input being not `address(0)` can conveniently deposit an amount of the corresponding ERC20 token to the DAO. Yet, the `DAO` contract... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | true | false | ## Low: Modify comment to soft limit check for clarity
### Description
The limit check is done before the summation to the total collateral allowable for liquidation. One may consider this to be a bug, but the README explains why this is the case:
`
Note that the first auction to reach the limit is allowed to pass it... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | oracle | true | false | ## Gas: Cache the results of an external function instead of calling it again (5 instances)
### Description
- Deployment. Gas Saved: **102 794**
- Minumal Method Call. Gas Saved: **-53**
- Average Method Call. Gas Saved: **7 512**
- Maximum Method Call. Gas Saved: **7 514**
#### - src/Controller.sol:[199-200](http... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: Vault creator can't change quitPeriod
### Description
The vault's `quitPeriod` can be updated through the `setQuitPeriod()` function. Only the owner of the contract (AdminProxy through VaultController) can call it. But, the VaultController contract doesn't implement a function to call `setQuitPeriod()`. Thu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Consider documenting explicitly that virtual accounting is a requirement for "normal" re- serves
### Description
The documentation regarding Aave's new features currently states that the implementation of the virtual accounting feature includes an optional `virtualUnderlyingBalance` field for assets listed on ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | true | true | ## High: PythOracle:if price.expo is less than 0, wrong prices will be recorded
### Description
Source: https://github.com/sherlock-audit/2023-07-perennial-judging/issues/56
## Found by
Emmanuel, minhtrng, panprog
In PythOracle#\_recordPrice function, prices with negative exponents are not handled correctly, leadin... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Bad actor can list fake tokens
### Description
**Severity:** Informational
**Path:** BabylonCore.sol:startListing (L54-87)
**Description:** Any malicious actor can create a customized ERC721/ERC1155 collection and create a listing for it. There are no checks against a whitelist of tokens to protect users fro... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: _enablePolicies() does not install ERC7739Content
### Description
In the `validateUserOp()` function, the `_enablePolicies()` logic allows an account to atomically install policies during validation. Part of the data provided to the installation logic is `enableData.sessionToEnable.erc7739Policies.allowedER... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Middleware may send `bytes32(0)` as validator key
### Description
The Middleware contract periodically sends validator data to the gateway:
Validator keys are gathered through `getValidatorSet()`, which relies on `getOperatorKeyAt()` to return the validator's key:
However, `getOperatorKeyAt()` can return `by... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Timestamp comparison has a logical error
### Description
In `WERC721::transferFromWithAuthorization` we see the following code:
There is a logical error there, as even though the variable is named `validAfter`, the value of the variable would still work as a valid timestamp for transfer. Example is if the co... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Use of .format to create SQL queries
### Description
The back end builds SQL queries with the `.format` function. An attacker that controls one of the variables that the function is formatting will be able to inject SQL code to steal information or damage the database.
*[REDACTED]*
**Figure 12.1:** `chainp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: NatSpec comments should be increased in contracts
### Description
It is recommended that Solidity contracts are fully annotated using NatSpec for all public interfaces (everything in the ABI). It is clearly stated in the Solidity official documentation.
In complex projects such as Defi, the interpretation of ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: [01]
### Description
The critical parameters in `initialize(...)` are not set safely:
* `s.governor` should be set to `msg.sender`, because a wrong governor address will result in loss of access to all other parts, and later changing the governor to the correct address.
* `_l2BootloaderBytecodeHash` should ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: `constant`s should be defined rather than using magic numbers
### Description
*There are 43 instances of this issue:*
[See original submission](https://github.com/code-423n4/2022-05-rubicon-findings/issues/203) for details. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | true | false | ## Medium: Insufficient Input Data Validation For `Gateway.query()` Function
### Description
The `QueryRequest` struct and `message` inputs, which are the parameters of the `Gateway.query()` function are not sufficiently validated.
The missing checks are the following:
1. `QueryRequest.dstChainId` - This is the chain... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Application Monitoring Can Be Improved by Emitting More Events
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `a0dc7e18534736f27c75791cba8cca3fe4b52dd9`.
Items 5 and 6 were fixed in the commit `c5c1a62ad7968f19c2190569c9cba0a4f8a5706a`.
**File(s) affected:**`LibAdmin.sol`, `LibObj... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Missing debt validation in group burn function
### Description
The `_burnGroupBalances` function fails to validate that the burn operation completes successfully when expired tokens are present, potentially creating inconsistencies between ERC1155 balance tracking and group array tracking. The function skips ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: OUSD total supply can be arbitrary, even smaller than user balances
### Description
The OUSD token contract allows users to opt out of rebasing effects. At that point, their exchange rate is “fixed”, and further rebases will not have an impact on token balances (until the user opts in). The `rebaseOptOut` is ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Ambiguous Access Control Boundaries
### Description
## Update Asset Prices by Cega Function
The `updateAssetPricesByCega` function exhibits an ambiguous access control boundary which allows TRADER_ADMIN roles. The `updateAssetPricesByCega` function is used by admins to manually set the price information store... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: Use of Constant Value to Absorb Rounding Errors
### Description
Utilizing the constant WAD (10^18) to absorb rounding errors is inappropriate for tokens like USDC, which operate with 6 decimal places (10^6). Applying WAD to USDC can lead to significant inaccuracies and out-of-range errors, as the precision mis... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Possible nil pointer dereference in GetBatchHeader
### Description
In `GetBatchHeader`, when `in.BatchHeader.ReferenceBlockNumber` is accessed, `BatchHeader` could be nil.
### Recommendation
Use protobuf getter functions, like `in.GetBatchHeader().GetReferenceBlockNumber()`. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | true | true | ## Low: `TimelockController` won't revert when executing on non-existent contracts
### Description
`TimelockController::_execute` does this:
```solidity
function _execute(address target, uint256 value, bytes calldata data) internal virtual {
(bool success, bytes memory returndata) = target.call{value: value}(data)... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | high | input-validation | true | false | ## High: Wrong validation in `DefaultUndelegationPolicy.onUndelegate()`
### Description
In `onUndelegate()`, it checks if the operator owner still holds at least `minimumSelfDelegationFraction` of total supply.
```solidity
function onUndelegate(address delegator, uint amount) external {
// limitation only a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: The `Vault._to_usd_oracle_price()` function uses the same `ORACLE_FRESHNESS_THRESHOLD` for all token prices feeds which is incorrect
### Description
The same `ORACLE_FRESHNESS_THRESHOLD` is used for all the token prices feeds which can be dangerous because different pairs of tokens have different freshness ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: Potential for Lost Funds in Jetton Deposit
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `f219cb4c248a6ff7ad29046acbc674169c2fb42d`. The client provided the following explanation:
> The provided fix checks now that the forward_payload length is 160 bit and that the token has been w... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Insufficient Natspec for the input vars of slope1_ and slope2_ can lead to mis-config of the contract
### Description
From the interface `IIRM::computeInterestRate()` and `IIRM::computeInterestRateView()`, we can see that the return value of `ir` is expected to be scaled by `1e27`.
In addition, in Lines 61, 63,... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Remove obsolete `return` statements when already using named return variables
### Description
**Description:** Remove obsolete `return` statements when already using named return variables:
* `Bet::bet`
**WannaBet:** Fixed in commit [c116182](https://github.com/gskril/wannabet-v2/commit/c11618221162a1010109ec... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Blocking of the VUSD withdrawals is possible if the reserve token doesn't support zero value transfers
### Description
_Submitted by hyh_
VUSD withdraw queue will be blocked and user funds frozen simply by requesting a zero value withdraw, if the reserve token doesn't support zero value transfers.
Putting... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Some tokens may cause `GMXEmergency:emergencyWithdraw` to revert if the withdrawn amount is 0
### Description
Tokens that don't allow 0 amount transfers could cause `GMXEmergency:emergencyWithdraw` to misbehave.
### Impact
Users may be unable to withdraw or need to send tokens to the vault and lose a portion ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Missed NatSpec parameters descriptions for public methods
### Description
https://github.com/lidofinance/aragon-apps/blob/7e5cd1961697a1bc514bfebdeab08a296e51d700/apps/voting/contracts/Voting.sol#L234
https://github.com/lidofinance/aragon-apps/blob/7e5cd1961697a1bc514bfebdeab08a296e51d700/apps/voting/contracts... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | true | true | ## Low: Lack of validation when updating system configurations
### Description
The market contract’s Boolean configurations do not validate that the configuration has changed when they are updated. While setting the same value is benign, it may obscure a logical error in a peripheral program that would be readily ident... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | true | false | ## Low: _remove() doesn't clear last slot
### Description
In the `AssociatedArrayLib`, the `_remove()` function has the following implementation:
```solidity
function _remove(Array storage s, address account, uint256 index) private {
uint256 __length = _length(s, account);
if (index >= __length) revert Associated... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Inefficient loop accross current_ map during pop_accept after a call
### Description
```cpp
void pop_accept()
{
MONAD_ASSERT(version_);
for (auto it = current_.begin(); it != current_.end(); ++it) {
it->second.pop_accept(version_);
}
logs_.pop_accept(version_);
--version_;
}
```
The `current_` m... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Unnecessary role check
### Description
Role is checked both on the modifier and the function body. Consider removing one:
[RdpxDecayingBonds.sol#L114-L120](https://github.com/code-423n4/2023-08-dopex/blob/main/contracts/decaying-bonds/RdpxDecayingBonds.sol#L114-L120) | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | false | false | ## Low: Emit event in `MessageServiceBase::_setRemoteSender` when updating `remoteSender` storage
### Description
Emit event in `MessageServiceBase::_setRemoteSender` when updating `remoteSender` storage. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Missing address(0) check
### Description
All update functions having an address as an argument check them against `address(0)`. This is missing in `updateTokenGatedDrop`. This is also not protected in `ERC721SeaDrop.sol#updateTokenGatedDrop()`, so `address(0)` could pass as a valid value.
### Recommendation
C... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | signature | false | false | ## Gas: State variables should be cached
### Description
### Saves `300 GAS`, `3 SLOD`
Caching of a state variable replaces each Gwarmaccess (100 gas) with a cheaper stack read. Other less obvious fixes/optimizations include having local memory caches of state variable structs, or having local caches of state variabl... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: `pointsSum.slope` Not Updated After Nominee Removal and Votes Revocation
### Description
### Vulnerability details
The `removeNominee` and `revokeRemovedNomineeVotingPower` functions are part of the governance mechanism in the `VoteWeighting.sol` smart contract.
- The `removeNominee` function removes a nomi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: `create_account` can be dosed with pre-funding
### Description
**Description:** Instructions like `new_holder_account` create PDAs using `system_instruction::create_account` with `invoke_signed`. Per Solana system program rules, `create_account` fails if the target already **exists with non-zero lamports or... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Protocol fees can be withdrawn by liquidity providers
### Description
Liquidity providers can withdraw the protocol fees accumulated when providing unbalanced liquidity since they are never removed from the pool reserves. When a user provides liquidity, a message is sent from the `lp_account` contract to th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | false | false | ## Low: Incomplete length validation in hexadecimal parsing
### Description
The `hexToAddress` function in the **HexUtils** library checks that the substring defined by `idx` and `lastIdx` is at least 40 characters long but does not validate whether it is exactly 40 characters. On Berachain, addresses also require a p... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Missing week validation while claiming rewards
### Description
- https://github.com/code-423n4/2023-10-canto/blob/main/canto_ambient/contracts/mixins/LiquidityMining.sol#L156
- https://github.com/code-423n4/2023-10-canto/blob/main/canto_ambient/contracts/mixins/LiquidityMining.sol#L256
In `claimConcentratedRe... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Rewrite `withdraw()` for saving gas
### Description
In `withdraw()` function each call of the `withdraw(_tokens[i])` would trigger call of the `update` modificator:
https://github.com/keep3r-network/StakingRewardsV3/blob/13ecc6966ae1a413f62224382bfd4d64b1a22351/contracts/StakingRewardsV3-1.sol#L287
### Recomm... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | false | false | ## Medium: | Centralization Risk
### Description
**Description**
The `owner` for `ethernote2` and `ethernotePresale` has authority over many functions that may be used to negatively disrupt the project.
Some possible attack vectors include:
- Ceasing the available notes to prevent minting
- Updating an edition’s val... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: `initialize`functions not protected
### Description
**Description:**
ERC20Token is an upgradeable contract that does not protect its initialize functions from inherited contracts.
**Recommendations:**
Add constructor to ERC20 contract as mentioned in the OpenZeppelin docs here:
https://docs.openzeppelin.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Rearrange code to fail early
### Description
In the instance below, two gas-intensive internal functions are invoked before the `if` statement. If the check causes a revert, the gas consumed in the first two internal functions will not be refunded. Move the `if` statement to the top of the function to save gas... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: LSP8 and LSP9's `ERC-165` interface ID differs from their specification
### Description
According to [LSP7's specification](https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-7-DigitalAsset.md#specification), the [ERC-165](https://eips.ethereum.org/EIPS/eip-165) interface ID for LSP7 token contracts s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Honest users could be permanently DOS'd from withdrawing their vested tokens/rewards
### Description
### Proof of Concept
[`ChefIncentivesController#Claim()`](https://github.com/code-423n4/2024-07-loopfi/blob/57871f64bdea450c1f04c9a53dc1a78223719164/src/reward/ChefIncentivesController.sol#L518) is a public... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Redundant Zero-Balance Check in `withdraw`
### Description
Within the `withdraw` function of `DeoracleizedFeeDistributor`, there is a check for `address(this).balance == 0` before verifying `(client + service + referrer) > address(this).balance`. The latter conditions already cover the case of zero balance, ma... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: DOS of CreateBondingCurve
### Description
The `CreateBondingCurve` instruction requires passing `bonding_curve_token_account`:
```rust
#[account(
init,
payer = creator,
associated_token::mint = mint,
associated_token::authority = bonding_curve,
)]
bonding_curve_token_account: Box>,
```
`bond... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | dos | false | false | ## High: bn254.DeserializeG1() will panic on signatures smaller than 64 bytes allowing multiple service
### Description
## DOS
**Severity:** Critical Risk
**Context:** core/bn254/attestation.go#L111-L113
**Description:**
`bn254.DeserializeG1()` will panic if it receives a byte slice smaller than 64 bytes. This... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Missing zero address checks
### Description
**Severity**: Low
**Status**: Resolved
**Description**
The _penPie parameter in __vlPenPie_init_() of the vlPenpie contract, has a missing zero address check. Due to this a zero address can be passed accidentally to the parameter to set _penpie as a zero address.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | true | false | ## Gas: Multiple `address` mappings can be combined into a single `mapping` of an `address` to a `struct`, where appropriate
### Description
Saves a storage slot for the mapping. Depending on the circumstances and sizes of types, can avoid a Gsset (**20000 gas**) per mapping combined. Reads and subsequent writes can a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Native HYPE transfers to HyperCore will not work
### Description
**Description:** `Hype_Module::hyper_depositSpot` always calls `IERC20(token).transfer(assetAddress(uint64(asset)), _wei)`, including when `asset == 150` (native HYPE). Per HyperCore [docs](https://hyperliquid.gitbook.io/hyperliquid-docs/for-deve... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Admin privileges are dangerous
### Description
**Likelihood:**
Low, because it requires a malicious/compromised admin
**Impact:**
High, because a rug pull can be executed
**Description**
A malicious or a compromised admin can execute a 100% rug pull in the following way:
1. The `LP` admin calls the `Fac... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: The function
### Description
[L-07] The function mintReceipt shouldn’t mint receipts to users, if the quest is paused
For now the function mintReceipt doesn’t issue hashes before the quest has started or after the quest has ended.
This is done off-chain with the help of claimSignerAddress, but the off-chain s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Usage of Proper Error Codes
### Description
## Error Code Constraints in Functions
While most of the assert constraints generate the proper error codes, there are still some constraints that do not. For example, in the `profile::new` function, if the profile doesn’t exist, the error code used in the assert is... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | front-running | false | false | ## High: UniV3Vault.sol#collectEarnings() can be front run
### Description
## Handle
WatchPug
## Vulnerability details
For `UniV3Vault`, it seems that lp fees are collected through `collectEarnings()` callable by the `strategy` and reinvested (rebalanced).
However, in the current implementation, unharvested yield... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Incomplete IRedeem and IOption interfaces
### Description
Although the [`Redeem`](https://github.com/primitivefinance/primitive-protocol/blob/78a8e64b7618e9199203ab84042876c580ae1e90/packages/primitive-contracts/contracts/option/primitives/Redeem.sol#L20) and [`Option`](https://github.com/primitivefinance/prim... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | token | false | false | ## Low: Misleading events are emitted when transferring a dust amount of rOUSG shares
### Description
Calling `ROUSG.transferShares` emits two events:
`TransferShares`: How much rOUSG shares were transferred
`Transfer`: How much rOUSG tokens were transferred
Calling this function with a dust amount will emit an even... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: [FIXED] Typo in error message in `FixedSpreadLiquidationStrategy`
### Description
In the function `execute` of the contract `FixedSpreadLiquidationStrategy`, the error message contains a typo - `liquidationEngingRole`.
### Recommendation
We recommend replacing the error message with `LIQUIDATION_ENGINE_ROLE`. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: _seperators values not checked
### Description
Within the [`RSITrendingStrategy` contract](https://github.com/mcdexio/mai-fund-protocol/blob/98af0d1d7e9872ba2b5e734e2a43c161ef635608/contracts/oracle/RSITrendingStrategy.sol), the [array `_seperators`](https://github.com/mcdexio/mai-fund-protocol/blob/98af0d1d7e... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Caching a variable that is used once just wastes Gas
### Description
### No need to cache `ds.forkEscrow` as it's being used once
https://github.com/nounsDAO/nouns-monorepo/blob/718211e063d511eeda1084710f6a682955e80dcb/packages/nouns-contracts/contracts/governance/fork/NounsDAOV3Fork.sol#L141-L160
### NounsT... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Error handling
### Description
**Occurs**:
Basilisk-node/pallets/duster/src/lib.rs:221
When dusting an account error from dec_providers() isn`t handled. This can lead to a
situation when account has at least one consumer and one provider. In this situation provider
counter cannot be decreased and as a result ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: The voting rules are exploitable for one to do self-challenge at a very low cost hence pre- venting real challenges from others
### Description
Suppose Alice is a pool owner and she wants to protect her funds from being challenged by other players. To do this, she can use one of her other addresses to creat... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: CALLING THE BATCHLIQUIDATIONS FUNCTION WITH TOKENID 0 ALWAYS REVERTS
### Description
The `_batchLiquidations` function implemented in the `LiquidationStrategy` contract is designed to perform more than one liquidation in a go. The `tokenId > 0` check on the `payLoanAndRefundLiquidator` function assures that... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.