prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | token | true | false | ## Medium: SpokeVault transfers will frequently revert due to Wormhole gas fee fluctuations
### Description
The `SpokeVault.transferExcessM()` function forwards ETH to pay for Wormhole gas fees, but any excess ETH sent will cause the transaction to revert since `SpokeVault` lacks capability to receive ETH refunds. Cur... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Base calculation in `Leverager::isLiquidateable()` is incorrect as the max leverage may be smaller
### Description
Base calculation in `Leverager::isLiquidateable()` is:
`uint256 base = owedAmount * 1e18 / (vp.maxTimesLeverage - 1e18);`.
However, the max leverage may not actually be `vp.maxTimesLeverage`, but... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: `ConvexStakingWrapper#deposit()` depositors may lose their funds when the `_amount` is huge
### Description
_Submitted by WatchPug, also found by danb, gzeon, Heartless, and pauliax_
When the value of `_amount` is larger than `type(uint192).max`, due to unsafe type casting, the recorded deposited amount ca... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: ZeroLocker:merge can make a voting lock last longer than MAXTIME and inflate voting power
### Description
I have previously reported an issue called "ZeroLocker:merge can make a voting lock last longer than 4 years" as a primary medium-severity issue at Cantina's contest as there wasn't a voting power calc... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | flash-loan | false | false | ## High: Error while calculating the value
### Description
The `getPricePerFullShare()` function for a yDAI token contract returns the value multiplied by a factor of 1e18.
But it doesn't divided by 1e18:
- https://github.com/CoverProtocol/cover-flashloan/tree/bea8cd444aa1791a97b2a81078dc887a835f7949/contracts/CoverFl... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: Precision Loss due to truncated decimals
### Description
**Severity** : Low
**Status** : Resolved
**Description** :
This line will cause precision loss, however it mainly depends on the constructor arguments. This bug is due to the lack of support for floating-point arithmetic, which means Solidity can only... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: RateLimit.removeCaller does not reset the allowance state of caller
### Description
The `removeCaller` function only resets the callers mapping value for the removed caller. It does not change the `maxAllowances`, `allowances`, `allowancesLastSet`, and `intervals` states of the caller. This leads to some unint... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: Enabling the whitelist can grant a malicious operator a temporary whitelisted status
### Description
N/A
### Impact
Malicious actor can frontrun the whitelist mode enabled and in this way force the owners to whitelist him (in order to unwhitelist him) for at least one block. So the malicious actor can gain... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Gas Price | false | true |
[HolographOperator.sol#L255](https://github.com/code-423n4/2022-10-holograph/blob/f8c2eae866280a1acfdc8a8352401ed031be1373/src/HolographOperator.sol#L255)<br>
If the following conditions have been met:
* The selected operator doesn't complete the job, either intentionally (they're sacrificing their bonded amount t... | Code4rena | 4 | Holograph |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: An edge-case mints 2 times more FLUX than it should
### Description
Report type: Smart Contract
Target: https://github.com/alchemix-finance/alchemix-v2-dao/blob/main/src/Voter.sol
Impacts:
- Protocol insolvency
- Direct theft of any user funds, whether at-rest or in-motion, other than unclaimed yield
## D... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | oracle | true | false | ## Gas: Cache the mapping values rather than fetch it every time
### Description
https://github.com/code-423n4/2023-01-ondo/blob/f3426e5b6b4561e09460b2e6471eb694efdd6c70/contracts/lending/OndoPriceOracle.sol#L61-L72
### OndoPriceOracle.sol.getUnderlyingPrice(): fTokenToUnderlyingPrice[fToken] should be cached
https... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Remove or replace unused variables
### Description
Remove or replace unused variables to save deployment gas.
*Instances include:*
https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/vote-escrow/VoteEscrowCore.sol#L4 | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Risk of adding team wallet more than once for an aFiBase contract
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
In Contract AFiStorage.sol, method `addTeamWallet(...)` is used to add a team wallet to any aFiBase contract. Since there is no check if the wallet already exist... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: Unobvious exchange on Uniswap
### Description
At the lines:
- https://github.com/orbxball/curve-voter-proxy/blob/78c92e4ffc0f76651914565744a3607d0248d254/contracts/Strategy.sol#L263
- https://github.com/orbxball/curve-voter-proxy/blob/78c92e4ffc0f76651914565744a3607d0248d254/contracts/Strategy.sol#L278
are not... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Allowed IRM cannot be disallowed
### Description
An IRM contract cannot be removed from the allowlist. Disallowing an allowed IRM ensures that future deployed markets cannot use that IRM anymore.
### Recommendation
Add a method to disallow IRMs so that new markets cannot be created using those IRMs. Markets w... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | true | true | ## Low: getNextSqrtPriceFromInput|Output can return a value outside of MIN_SQRT_RATIO , MAX_SQRT_RATIO
### Description
`getNextSqrtPriceFromInput|Output` takes a square price and returns the next square ratio price. A square ratio price should be between `[MIN_SQRT_RATIO, MAX_SQRT_RATIO]`; however, `getNextSqrtPriceFr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Redundant Type-Bound Checks for `moduleId` and `nodeOpId`
### Description
In the `validateExitRequests` function, there are two checks:
```solidity=
require(_input.moduleId <= type(uint24).max, ERROR_MODULE_ID_OVERFLOW);
require(_input.nodeOpId <= type(uint40).max, ERROR_NODE_OP_ID_OVERFLOW);
```
These check... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | reentrancy | false | false | ## High: Not following the Checks-Effects-Interactions pattern
### Description
**Update:** *Fixed in [pull request #63](https://github.com/endaoment/endaoment-contracts/pull/63).*
The [`finalizeGrant`](https://github.com/endaoment/endaoment-contracts/blob/f60aa253d3d869ad6460877f23e6092acb313add/contracts/Fund.sol#L... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | true | false | ## Low: Reuse of CHAINID from contract deployment ✓ Fixed
### Description
The internal function `_validateWithdrawSignature()` is used to check whether a sponsored token withdrawal is approved by the owner of the stealth address that received the tokens. Among other data, the [chain ID](https://eips.ethereum.org/EIPS/... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | false | false | ## Medium: English auction bidder can win with low bidAmount on network congestion
### Description
English-like auctions differs from fixed-discount ones because the amount that has to be sold
is auctioned among bidders competing to offer more system coins ([in a first phase](https://github.com/reflexer-labs/geb/bl... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: buffer fails to rebalance for token deficits
### Description
Severity: Low Risk
Context: Vault.sol#L1185-L1206
Description: The current ERC4626 buffer logic is only able to rebalance itself when there is a surplus in the
underlying tokens when a user wraps tokens using the buffer. It fails to rebalance itself ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Single-step Ownership Transfer Pattern Can Be Dangerous
### Description
Inheriting from OpenZeppelin's `Ownable` contract means you are using a single-step ownership transfer pattern. If an admin provides an incorrect address for the new owner, this will result in none of the `onlyOwner` marked methods being c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | true | false | ## Low: Lack of over�low checks
### Description
The `catapult-server` provides wrappers for various value types and simplifies their usage with arithmetic operator overloads. However, many of those operations are not checked against integer overflows and may lead to unexpected behavior if an overflow does occur. While... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: `onERC721Received()` callback is never called when new tokens are minted in Erc721Facet.sol
### Description
The ERC721Facet contract does not properly call the corresponding callback when new tokens are minted.
The ERC721 standard states that the onERC721Received callback must be called when a mint or transfer... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Duplicate NFT generation via repeated forging with the same parent
### Description
### Impact
It is possible to get the same NFT (same generation, same entropy) when the forging is done with the same `parentId` multiple times. Although the number of times this action will be feasible is limited with the fo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: Malicious users can `createOrder` with `0 amount` and make `DOS` for all
### Description
Malicious users can `createOrder` with 0 amount and can cause `DOS / block users` to `fillOrder`, `cancleOrder`
### Impact
Malicious users will create huge numbers of orders with `0 amountIn`.
Now if anyone wants to `... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Overprivileged admin can grant unlimited WETH
### Description
_Submitted by hake_
Admin can `_grantComp()` to any address using any amount and drain the contract.
### Proof of Concept
If admin key gets compromised there is no timelock, no amount boundaries and no address limitations to prevent the asset... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: ChainlinkRelayerWithL2Validity.getResultWithValidity should not revert when the sequencer is down
### Description
ChainlinkRelayerWithL2Validity.getResultWithValidity function is designed to not revert, when the result is not valid, it should just return `false` as validity. But in case the sequencer is down, ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | reentrancy | true | false | ## High: REENTRANCY IN RAFFLEMINTV1.WITHDRAWNONRAFFLEPROCEEDS
### Description
In the contract `RaffleMintV1`, the function `withdrawNonRaffleProceeds()` is vulnerable to reentrancy as it updates the `nonRaffleWithdrawableProceeds` after the `payable(_msgSender()).call{value: proceeds}("");`:
### Recommendation
**SOLV... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: est bid in first auction can get irretrievably stuck in the protocol
### Description
_Submitted by PwnPatrol, also found by davidbrai, MiloTruck, and pauliax_
[Auction.sol#L248-L254](https://github.com/code-423n4/2022-09-nouns-builder/blob/7e9fddbbacdd7d7812e912a369cfd862ee67dc03/src/auction/Auction.sol#L2... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Check isComponent() is done on internal and external functions
### Description
The check for `isComponent()` is sometimes done on internal functions and sometimes on external functions. This is not consistent and makes it more difficult to review and maintain.
### Recommendation
Move the check from `_liquidat... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | true | false | ## Low: Transfers are noop when `lamports_diff` is zero
### Description
**Description:** The codebase contains multiple instances where lamports transfers are performed for rellocating space and size without checking if the transfer amount `lamports_diff` is greater than zero. To evaluate `lamports_diff` we are using... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: `internal` functions only called once can be inlined to save gas
### Description
Not inlining costs 20 to 40 gas because of two extra `JUMP` instructions and additional stack operations needed for function calls. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Function PythNodeprocess doesnt handle correctly PRECISION pythDataexpo
### Description
Report type: Smart Contract
Target: https://testnet.snowtrace.io/address/0xA758c321DF6Cd949A8E074B22362a4366DB1b725
Impacts:
* Temporary freezing of funds of at least 24h
## Description
## Vulnerability Details
Funct... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: Proposals IDs Could Be Reused
### Description
**Update**
The client fixed the issue in commit `c5ca8df079cb209009571b3be5d7c1be72f181d3` by adding a nonce to the proposal hash.
**File(s) affected:**`Web3MusicNativeTokenDAO.sol`
**Description:**`Web3MusicNativeTokenDAO.propose()` can be called by any address ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: The swap functions allows zero amountIn to be provided
### Description
The swap function of the Vault contract allows users to provide a zero amountGivenScaled18. If any of the calculations contains an error that could allow a user to swap a zero amountGivenScaled18 for a non-zero amount of tokens out, this co... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: bitcoin-spv - unnecessary intermediate cast ✓ Addressed
### Description
`CheckBitcoinSigs.accountFromPubkey()` casts the `bytes32` keccack256 hash of the `pubkey` to `uint256`, then `uint160` and then finally to `address` while the intermediate cast is not required.
### Recommendation
Issue addressed in [summ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: Accumulation of dust amounts due to rounding in `_tokenDistribution()`
### Description
**Description:** `_tokenDistribution()` computes each share independently with integer division:
If `beneficiaryPercentage + creatorPercentage + vaultPercentage == 10000` but any division truncates, `beneficiaryAmount + cr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Redundant code and assumptions in tests can introduce bugs in the future
### Description
**Severity**: Informational
**Status**: Acknowledged
**Description**
The following lines are redundant in the unit tests and fuzz tests and can be removed:
A) Test Contract Name: BaseControlledAsyncRedeemTest
1) Funct... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | ecrecover | true | true | _Submitted by gpersoon, also found by 0xRajeev, cmichel, and nikitastupin_.
#### Impact
The solidity function `ecrecover` is used, however the error result of 0 is not checked for.
See documentation:
<https://docs.soliditylang.org/en/v0.8.9/units-and-global-variables.html?highlight=ecrecover#mathematical-and-cryptogr... | Code4rena | 4 | Swivel |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Transferring tokens without tainting
### Description
- https://github.com/ConicFinance/protocol/blob/7a66d26ef84f93059a811a189655e17c11d95f5c/contracts/LpToken.sol#L74
- https://github.com/ConicFinance/protocol/blob/7a66d26ef84f93059a811a189655e17c11d95f5c/contracts/LpToken.sol#L81
If `_minimumTaintedTrans... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: An economic attack allowing protocols to bribe voters more effectively
### Description
All voters receive the incentive from the winner protocol despite the direction of their votes. Voters can vote for random protocols and still receive rewards from winners. Some economic attacks are allowed:
1) Protocol A b... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Inaccurate accounting of unrealizedLosses during default warning revert
### Description
During the process of executing the `removeDefaultWarning` function, an accounting discrepancy fails to decrement `netLateInterest` from `unrealizedLosses`, resulting in an over-inflated value. The `triggerDefaultWarning`... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | access-control | false | false | ## Low: Consider Two-step Ownership Transfer
### Description
In both `xbelo` and `clmm_lp_farming` programs, ownership is transferred within one function call, namely `transfer_admin`.
This pattern comes with it risks, any mistake can lead to losing ability to update vesting parameters for `xbelo` program, and losing ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: Loss of precision
### Description
Division by large numbers may result in the result being zero, due to solidity not supporting fractions. Consider requiring a minimum amount for the numerator to ensure that it is always larger than the denominator
*There are 2 instances of this issue:*
https://github.com/c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | access-control | true | false | ## Gas: NetFeeSplitter._transfer should revert early in case of insufficient allocation
### Description
The `NetFeeSplitter._transfer` function performs `_updateFees` before checking sufficient allocation of `oldRecipient`. This check should be done early to revert early and save gas in case of insufficient allocation. ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Incorrect Amount Logged in `PerpWithdrawReport`
### Description
**Description:** The `perp_withdraw` function logs the requested amount (`data.amount`) instead of the actual withdrawn amount (`amount`) in the `PerpWithdrawReport` event. This creates a discrepancy between the logged amount and the actual funds ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: `internal` functions only called once can be inlined to save gas
### Description
Not inlining costs 20 to 40 gas because of two extra `JUMP` instructions and additional stack operations needed for function calls.
*There are 6 instances of this issue:* | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | front-running | false | false | ## High: The `borrow` and `refinance` functions can be front-run by the pool lender leading to collateral being seized in the next block
### Description
The pool's `auctionLength` is assigned to the loan without the borrower having the possibility to define a minimum value. This allows the pool lender to front-run the... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Multiple Unlocked Solidity Versions in Use
### Description
The contracts in scope use multiple pragma versions with unlocked versions. Contracts should be deployed with the same compiler version and flags with which they were thoroughly tested. Locking the pragma helps to ensure that contracts are not accident... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: The neg method of the MathLib leads to unexpected results for half of the input value range
### Description
The `neg` method of the `MathLib` intends to negate unsigned input numbers, i.e. `z = -x`, where `x >= 0`.
```solidity
function neg(uint256 x) internal pure returns (int256 z) {
assembly {
z := sub(... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: Risk of Function Signature Clash With ifAdmin
### Description
The `ifAdmin` modifier is [deprecated](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/bd325d56b4c62c9c5c1aff048c37c6bb18ac0290/contracts/proxy/transparent/TransparentUpgradeableProxy.sol#L70) due to the risk of function signature clash ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Unnecessarily complex `ProxyAdmin` ownership setup
### Description
**Description:** The `ProxyAdmin` contract is created in the `MembershipFactory` constructor:
`ProxyAdmin` inherits `Ownable` and sets the contract owner to `msg.sender`, meaning that this will be the `MembershipFactory` contract.
This owner... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | true | false | ## Low: [07] `OffChainSignatureValidator.isValidSignature` misses a check for `ecrecover` returning `address(0)`
### Description
https://github.com/code-423n4/2023-10-party/blob/b23c65d62a20921c709582b0b76b387f2bb9ebb5/contracts/signature-validators/OffChainSignatureValidator.sol#L58
When `OffChainSignatureValidator`... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Deprecated Fee Calculator
### Description
## Deprecated Feature Notice
**Fees::fee_calculator** is deprecated by Solana. It will not be available in the future and may give inaccurate information when completely unsupported.
## Remediation
Replace `Fees::fee_calculator` with `solana_program::FeeRateGoverne... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: [10] PREIMAGE: Wrong comparison operator in `relativeOffset` may cause unintentional reverts
### Description
In the below snippet, the case `relativeOffset + 32 == _input.length` is fine because only calldata up to `relativeOffset + 31` will be loaded. This can cause unnecessary reverts when adding leaves in c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | true | false | ## Medium: Locked ether
### Description
In the `Listing` contract, users can send ether to the `buyFixedSale` `payable` function, in order to purchase a NFT listed for a fixed price (in ether). The protocol commission, when considered, is applied on top of the listing (selling) value, and needs to be added-up to the `... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Potential handling errors due to duplicate token entries in liquidity functions
### Description
In the `addLiquidity` and `removeLiquidity` functions of the **Router** contract, user-passed arrays (`meta_amounts`, `base_amounts`, etc.) are used to perform token transfers and allowances. If these arrays contain... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: Validators with dust collateral can join the network
### Description
**Severity**: High
**Status**: Acknowledged
SubnetActorManagerFacet.sol - In join function , validators are allowed to join the network to be added to `genesisValidators` in exchange for dust values as low as 1 native coin. This in turn ca... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Elytra share price may be inflatten to block the system
### Description
In Elytra, total asset tvl is calculated based on the formula: `totalAssetDepositsTracked + unstakingVault + strategyBalance - reserveBalance`.
Users can choose withdrawAssets or requestWithdrawal to withdraw their assets. When we with... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Function claim() in HappyTokenPool, does not update pool’s pool.swapped_map[msg.sender].
### Description
**Severity**: Low
**Status**: Acknowledged
**Description**:
The function does not update the pool.swapped_map[msg.sender] value after getting it value at “uint256 claimed_amount = pool.swapped_map[msg... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: Referrer discount token amount can be manipulated
### Description
_Submitted by cmichel_
The `Unlock.recordKeyPurchase` function is called on each key purchase (`MixinPurchase.purchase`) and mints UDT tokens to the referrer.
The amount to mint is based on the transaction's gas price which is controlled by ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Code documentation does not reference the paper
### Description
The AlephBFT Rust code implements the consensus protocol outlined in the Aleph Zero paper; however, it does not reference specific sections of the paper, which makes it more difficult to audit the code. For example, specific references to the “Pra... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Centralization Risk for trusted owners
### Description
The contracts in-scope are safe-guarded by an access control mechanism, which is a good practice in smart contract development and prevents non-authorized parties and bad actors to perform unauthorized activities within the contracts and ecosystem.
Owners... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: The `VestingEscrowSimple` instance can be initialized without supplying a sufficient amount of vesting tokens
### Description
The `VestingEscrowSimple` contract assumes that the contract holds a sufficient amount of vesting tokens. However, the vesting contract can be initialized without supplying the requi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | token | true | false | ## Gas: Use a more recent version of solidity
### Description
Use a solidity version of at least 0.8.2 to get compiler automatic inlining
Use a solidity version of at least 0.8.3 to get better struct packing and cheaper multiple storage reads
Use a solidity version of at least 0.8.4 to get custom errors, which are che... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | false | false | ## Low: Risk Of Leftover Funds
### Description
I n `iterateAndUpdateFundsDistribution` within keeper, percentages are calculated utilizing integer values that are truncated to whole numbers (`recipientCoins`). This truncation ignores any fractional part of the calculated distribution. When funds are distributed utiliz... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | reentrancy | false | false | ## High: Potential re-entrancy problem
### Description
At the line https://github.com/bondappetit/bondappetit-protocol/blob/355180f0aca0b29d60d808f761052956b7a3a159/contracts/profit/ProfitSplitter.sol#L227 contract transfers incoming tokens to `recipient`, however that place can be re-entered in case of callbacks from... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Fund Token Manipulation
### Description
## Symmetry Audit 05 | Vulnerabilities
In the `buy_state_rebalance` instruction, the program does not validate the instruction id/data being passed over to the prism aggregator CPI. The accounts are passed directly through `remaining_accounts` and are not validated eit... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: `ReentrancyGuard` Not Using Diamond Storage
### Description
**Update**
The team added a new `libs/ReentrancyGuard.sol` file that mimics the `ReentrancyGuard` logic from the OpenZeppelin implementation while abiding by the diamond storage model with `storage/LibDiamondStorageReentrancyGuard.sol`. Note that the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Missing chainlink price feed
### Description
Chainlink does not provide a price feed for SOL token on Avalanche.
### Impact
This issue affects some core protocol functions, which would make the core operations of a Strategy Vault using SOL on Avalanche impossible:
```GMXReader.sol::convertToUsdValue()```
``... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Unable to redeem from Notional
### Description
_Submitted by dipp, also found by cccz, cryptphi, datapunk, hyh, kenzo, Lambda, and WatchPug_
The `maxRedeem` function is a view function which only returns the balance of the `Redeemer.sol` contract. After this value is obtained, the PT is not redeemed from Not... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Complete Drainage of Vested Tokens from `claim()` in `DaoVesting`
### Description
The `DaosVesting::claim()` function has a critical vulnerability that allows an attacker to drain tokens from legitimate DAOs. The issue stems from insufficient validation of the DAO contract address and its state.
Vulnerable c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | dos | false | false | ## High: Malicious borrower can repeatedly fill then kill orders to permanently lock funds of lenders and other borrowers
### Description
**Details**
[Orderbook.sol#L118-L133](https://github.com/Blueberryfi/bloom-v2/blob/87a60380331cc914be41ad57691f08b532a4d6fb/src/Orderbook.sol#L118-L133)
function killBorrowerMat... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: ProposalDeleted events can be emitted with non-existent assertionId
### Description
The `OptimisticGovernor` contract's [`assertionDisputedCallback`](https://github.com/UMAprotocol/protocol/blob/3687d9b3a80ca9b3694211d50a2ccad5415c77e1/packages/core/contracts/gnosis-zodiac/implementation/OptimisticGovernor.sol... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: `>=` costs less gas than `>`
### Description
The compiler uses opcodes `GT` and `ISZERO` for solidity code that uses `>`, but only requires `LT` for `>=`, [which saves **3 gas**](https://gist.github.com/IllIllI000/3dc79d25acccfa16dee4e83ffdc6ffde).
*There are 3 instances of this issue.* | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: When L2Comptroller is low on funds, large claims will fail while small claims will succeed
### Description
When a user claims tokens on L2 (whether through `buyBackFromL1()`, `buyBack()`, `claim()` or `claimAll()`), the tokens are transferred with the following logic:
It is expected that, at times, the contr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Potential user restrictions in liquidity contributions
### Description
The `addLiquidity` function in the **Router** contract has a potential issue where `meta_amounts[i]` is overwritten by `base_lp_received` when `coin` matches `base_lp`. This leads to two scenarios:
1. If the initial `meta_amounts[i]` i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Pausing the contract does not pause voting delegations
### Description
The `CornOFT` contract overrides the `_update()` function to include a `whenNotPaused` modifier. As a result, a privileged role can pause the contract to prevent ERC-20 token transfers between accounts on the current chain or cross-chain. T... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | rounding | false | false | ## Gas: 3S-LENFT-N07 protocol/Lending/TokenOracle.sol: getTokenETHPrice() should also return price precision
### Description
In the current implementation of the [TokenOracle](https://github.com/leNFT/contracts/blob/master/contracts/protocol/Lending/TokenOracle.sol) contract, 2 external calls are necessary to get the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Vault.sol Tokens with fee on transfer are not supported
### Description
## Handle
WatchPug
## Vulnerability details
There are ERC20 tokens that charge fee for every `transfer()` / `transferFrom()`.
`Vault.sol#addValue()` assumes that the received amount is the same as the transfer amount, and uses it t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Inconsistencies in Storage Logic
### Description
## Soroban Storage Management
1. In Soroban, persistent storage entries have a TTL (Time-To-Live), and once it expires, the entry is archived. If a user interacts with a contract and the required data is archived, unarchiving the data may impact the user exper... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: User won't be able to buy token if he has less ETH in his wallet after paying for Token
### Description
**Severity:** Medium
**Context:** hyacinth_test.sol#L199
**Description:**
In the `buy()` function, there is a check to ensure that the sender's ETH balance is not less than the ETH amount sent:
This ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Code Maturity
### Description
## Refactor sellVaultToken to Utilize safeUpdateAtomicRequest
Refactor `sellVaultToken` to utilize `safeUpdateAtomicRequest` instead of `updateAtomicRequest` to ensure improved safety during the process of submitting an atomic request.
> _smart-wallets/src/token/YieldToken.sol s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | dos | false | false | ## High: EVM.Restore() gas not consumed on invalid signature
### Description
The `(evm *EVM) Restore()` function does not consume all gas on `RestoreData` signatures. An attacker can generate incredibly large `restorationTX` transactions that will consume the node's resources validating the restoration server's signat... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Missing Emergency Exit for Rewards Distribution
### Description
**Severity**: Low
**Status**: Unresolved
**Description**:
The TokenEmissionsStrategy contract allows the owner to perform an emergencyWithdrawal(), but there is no way to stop or pause rewards emissions in case of an emergency.
**Scenario**:
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | false | false | ## High: No Mechanism To Flag Sequencer Fraud
### Description
Note, while Mantle are aware of this and have intentionally structured the code as such, it was deemed important to comment on a feature that will eventually need to be enabled in Mantle L2.
There are currently no means of challenging a bad input from a se... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Redundant role assignment
### Description
In the `createDaoErc20` function within the `Emitter` contract, there is a line that grants the `EMITTER` role to `msg.sender`:
Given that the function is restricted by the `onlyRole(FACTORY)` modifier, `msg.sender` will always be the `FACTORY` contract. Since the `F... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Affiliate fees are not accumulated in multiple trading operations
### Description
In Augur v2, market creators can set an [`affiliateFeeDivisor`](https://github.com/AugurProject/augur/blob/9a33c3269e812d0cb66d49b61a72db58e32e4749/packages/augur-core/source/contracts/reporting/Market.sol#L45) value which corre... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Fee share calculation is incorrect
### Description
Fees are given to the feeRecipient by minting them shares. The current share calculation is incorrect and always mints too many shares the fee recipient, giving them more fees than they should get.
### Impact
Fee recipient is given more fees than intended,... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | true | false | ## Low: `bridgeTo` function vulnerable to reentrancy attacks
### Description
The function bridgeTo involves multiple state changes and external calls without a reentrancy guard:
This exposes the function to potential reentrancy attacks, especially since it interacts with multiple external contracts (the ERC20 token, ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | true | false | ## Low: Optimizing Update Function
### Description
## Performance Improvement in User Loan and Collateral Updates
In `update_user_loans` and `update_user_collaterals` of `storage.move`, the use of `vector::contains(&storage.users, &user)` for inserting items without duplicates can be computationally expensive. As `ve... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Reduce gas usage by moving to Solidity 0.8.19 or later
### Description
Please visit the following link for substantiated details:
https://soliditylang.org/blog/2023/02/22/solidity-0.8.19-release-announcement/#preventing-dead-code-in-runtime-bytecode
And, here are some of the instances entailed:
https://gith... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | true | false | ## Low: Refactor identical code in `NodeOperatorRegistry::getNextValidatorDetails`
### Description
The bodies of these two `else if` [branches](https://github.com/SwellNetwork/v3-contracts-lst/blob/a95ea7942ba895ae84845ab7fec1163d667bee38/contracts/implementations/NodeOperatorRegistry.sol#L151-L162) are identical:
``... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Verification Functions for Custom Hashing in Merkle Trees Assume Commutative Hashing
### Description
The functions [verify\_with\_builder](https://github.com/OpenZeppelin/rust-contracts-stylus/blob/a67ab7068ac94a5a1ad48ae632050c8d28f9ab25/lib/crypto/src/merkle.rs#L178) and [verify\_multi\_proof\_with\_builder]... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Variable _maxSupply Is Used For Two Different Purposes
### Description
The variable `_maxSupply` is used as the return value of the function `maxMint()`, which, according to the NatSpec comment of this function, is specified as “the maximum amount of the Vault shares that can be minted for the receiver, through... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: L01] README empty or missing important information
### Description
###### Low
Components: all
The `README.md` on the root of the GitHub repositories are the first documents that most developers will read, so they should be complete, clear, concise, and accurate.
The `README.md` files of [`deployment-nick... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: Use SafeERC20
### Description
**Severity**: Medium
**Status**: Resolved
**Description**
It is recommended to utilize SafeERC20 in order to do the transfers of tokens (i.e. as safeTransfer). Devs preferred to utilize transfer wrapped in a require statement which appears safe, but it is not the proper way ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | true | false | ## Low: Add NatSpec comments to the variables defined in Storage
### Description
I recommend adding NatSpec comments explaining the variables defined in Storage, their slots, their contents and definitions.
This improves code readability and control quality
Current Code;
Recommendation Code;
*** | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | true | false | ## High: `OUSGInstantManager` will allow excessive `OUSG` token minting during `USDC` depeg event
### Description
Any user can use `mint` function in `ousgInstantManager` contract to mint `OUSG` tokens by providing `USDC` token. It calls internal function `_mint` where the main logic resides.
### Two important point... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.