diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/globalize/active_record/translation.rb b/lib/globalize/active_record/translation.rb index abc1234..def5678 100644 --- a/lib/globalize/active_record/translation.rb +++ b/lib/globalize/active_record/translation.rb @@ -2,6 +2,12 @@ module ActiveRecord class Translation < ::ActiveRecord::Base ...
Fix cases in rbx + mysql where .table_exists? is called on the virtual model before it even has a table name.
diff --git a/lib/kvg_character_recognition/datastore.rb b/lib/kvg_character_recognition/datastore.rb index abc1234..def5678 100644 --- a/lib/kvg_character_recognition/datastore.rb +++ b/lib/kvg_character_recognition/datastore.rb @@ -9,7 +9,7 @@ def load_file filename begin - JSON.parse(File.read(fil...
Store keys as symbol in characters.json
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -4,7 +4,7 @@ Redcarpet::Markdown.new(renderer, { auto_link: true, tables: true }).render(text).html_safe end def s...
Fix shortening to work on multiline strings
diff --git a/lib/spree_i18n/controller_locale_helper.rb b/lib/spree_i18n/controller_locale_helper.rb index abc1234..def5678 100644 --- a/lib/spree_i18n/controller_locale_helper.rb +++ b/lib/spree_i18n/controller_locale_helper.rb @@ -15,6 +15,8 @@ def set_user_language I18n.locale = if session.key?(:l...
Support config_locale settings in set_user_language override Fixes spree/spree#3915
diff --git a/app/models/dojo.rb b/app/models/dojo.rb index abc1234..def5678 100644 --- a/app/models/dojo.rb +++ b/app/models/dojo.rb @@ -10,6 +10,8 @@ serialize :tags before_save { self.email = self.email.downcase } + + scope :default_order, -> { order(prefecture_id: :asc) } validates :name, presenc...
Add scope for default order
diff --git a/app/models/icon.rb b/app/models/icon.rb index abc1234..def5678 100644 --- a/app/models/icon.rb +++ b/app/models/icon.rb @@ -26,7 +26,8 @@ private def url_is_url - return true if url.to_s.starts_with?('http') + return true if url.to_s.starts_with?('http://') || url.to_s.starts_with?('https://')...
Reset URL if invalid; check validity via http(s)://
diff --git a/app/models/line.rb b/app/models/line.rb index abc1234..def5678 100644 --- a/app/models/line.rb +++ b/app/models/line.rb @@ -28,7 +28,7 @@ PATTERNS.each do |pattern| regex, action = pattern if raw_line =~ regex - self.person = Person.find_or_create_by_name($1) + self.person =...
Remove use of deprecated dynamic finder
diff --git a/app/models/live.rb b/app/models/live.rb index abc1234..def5678 100644 --- a/app/models/live.rb +++ b/app/models/live.rb @@ -2,7 +2,7 @@ has_many :songs, dependent: :restrict_with_exception scope :order_by_date, -> { order(date: :desc) } - scope :future, -> { where('date > ?', Date.today) } + scope...
Change the start of `future` scope
diff --git a/app/models/image.rb b/app/models/image.rb index abc1234..def5678 100644 --- a/app/models/image.rb +++ b/app/models/image.rb @@ -29,7 +29,7 @@ if source_id.present? sources << Source.find(source_id) else - sources << Source.find_or_initialize_by_name(source_attrs) + sourc...
Fix issue when setting certain sources.
diff --git a/activeresource.gemspec b/activeresource.gemspec index abc1234..def5678 100644 --- a/activeresource.gemspec +++ b/activeresource.gemspec @@ -13,7 +13,7 @@ s.email = 'david@loudthinking.com' s.homepage = 'http://www.rubyonrails.org' - s.files = Dir['README.rdoc', 'lib/**/*'] + s.files = Dir...
Include lincense file in the package
diff --git a/app/models/round.rb b/app/models/round.rb index abc1234..def5678 100644 --- a/app/models/round.rb +++ b/app/models/round.rb @@ -1,5 +1,8 @@ class Round < ActiveRecord::Base attr_accessible :charity, :closed, :expire_time, :failed, :max_amount, :secret_token, :url, :winning_address1, :winning_address2 + ...
Add has_many comments to Round model
diff --git a/lib/pacto/response.rb b/lib/pacto/response.rb index abc1234..def5678 100644 --- a/lib/pacto/response.rb +++ b/lib/pacto/response.rb @@ -10,7 +10,7 @@ end def instantiate - Faraday::Response.new(default_env) + self end def body
Use Pacto::Response instead of Faraday::Response for instantiate
diff --git a/household_expenses.rb b/household_expenses.rb index abc1234..def5678 100644 --- a/household_expenses.rb +++ b/household_expenses.rb @@ -1,5 +1,5 @@ class HouseholdExpenses def call(env) - [200, {}, ['Hello World']] + [200, {}, ['Hello World with CI and auto deploy']] end end
Use CI and auto deploy to demo environment
diff --git a/Library/Formula/noweb.rb b/Library/Formula/noweb.rb index abc1234..def5678 100644 --- a/Library/Formula/noweb.rb +++ b/Library/Formula/noweb.rb @@ -5,38 +5,43 @@ homepage 'http://www.cs.tufts.edu/~nr/noweb/' url 'ftp://www.eecs.harvard.edu/pub/nr/noweb.tgz' version '2.11b' - sha1 '3b391c42f46dcb8a...
Clean up TeX support installation, add caveat. Closes #42110. Signed-off-by: Alex Dunn <46952c1342d5ce1a4f5689855eda3c9064bca8f6@gmail.com>
diff --git a/lib/resgen/filters.rb b/lib/resgen/filters.rb index abc1234..def5678 100644 --- a/lib/resgen/filters.rb +++ b/lib/resgen/filters.rb @@ -18,7 +18,7 @@ path = File.expand_path(path) Proc.new do |artifact_type, artifact| catalog = catalog_for(artifact_type, artifact) - catalog.nil...
Make sure base catalog also matches
diff --git a/lib/valanga/client.rb b/lib/valanga/client.rb index abc1234..def5678 100644 --- a/lib/valanga/client.rb +++ b/lib/valanga/client.rb @@ -24,7 +24,10 @@ @session.click_on "規約に同意してログイン" - raise LoginError unless logged_in? + unless logged_in? + page = Nokogiri::HTML.parse(session.ht...
Set exception message when user failed to login
diff --git a/etc/examples/magician/compus_beats.rb b/etc/examples/magician/compus_beats.rb index abc1234..def5678 100644 --- a/etc/examples/magician/compus_beats.rb +++ b/etc/examples/magician/compus_beats.rb @@ -8,7 +8,7 @@ define :bass do sample :bass_voxy_c, amp: rrand(0.1, 0.2), rate: [0.5, 0.5, 1, 1,2,4].choose...
Fix compus beats phase rate
diff --git a/rails/config/initializers/session_store.rb b/rails/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/rails/config/initializers/session_store.rb +++ b/rails/config/initializers/session_store.rb @@ -6,4 +6,6 @@ # which shouldn't be used to store highly confidential information # (crea...
Fix test failures caused by secure cookie changes #178193849 https://www.pivotaltracker.com/story/show/178193849
diff --git a/spec/rspec/mocks/double_spec.rb b/spec/rspec/mocks/double_spec.rb index abc1234..def5678 100644 --- a/spec/rspec/mocks/double_spec.rb +++ b/spec/rspec/mocks/double_spec.rb @@ -33,4 +33,12 @@ dbl = double('foo' => 1) expect(dbl.foo).to eq(1) end + + it 'allows setter methods to be stubbed' do +...
Document behaviour of doubling setter methods.
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -1,3 +1,3 @@ # Be sure to restart your server when you modify this file. -CartoDB::Application.config.session_...
Use root domain as session cookie domain
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -4,7 +4,7 @@ Rails.application.config.session_store( :cookie_store, key: Settings.site.session_key, ...
Fix cookie store in locahost domain cannot login
diff --git a/cookbooks/chef/attributes/default.rb b/cookbooks/chef/attributes/default.rb index abc1234..def5678 100644 --- a/cookbooks/chef/attributes/default.rb +++ b/cookbooks/chef/attributes/default.rb @@ -2,7 +2,7 @@ default[:apt][:sources] = node[:apt][:sources] | [ "opscode" ] # Set the default client version ...
Update chef client to 11.10.0
diff --git a/cookbooks/devices/recipes/default.rb b/cookbooks/devices/recipes/default.rb index abc1234..def5678 100644 --- a/cookbooks/devices/recipes/default.rb +++ b/cookbooks/devices/recipes/default.rb @@ -25,7 +25,7 @@ execute "udevadm-trigger" do action :nothing - command "/sbin/udevadm trigger --action=add"...
Update udevadm path for Ubuntu 20.04 compatibility
diff --git a/lib/flatrack/template.rb b/lib/flatrack/template.rb index abc1234..def5678 100644 --- a/lib/flatrack/template.rb +++ b/lib/flatrack/template.rb @@ -17,7 +17,7 @@ private def find_by_type(type, file) - if File.exists?(file) + if File.exist?(file) file else Dir[F...
Move away from deprecated exists?
diff --git a/lib/minitest/ext/spec.rb b/lib/minitest/ext/spec.rb index abc1234..def5678 100644 --- a/lib/minitest/ext/spec.rb +++ b/lib/minitest/ext/spec.rb @@ -24,7 +24,7 @@ class_eval &context end else - raise ArgumentError, "No context with #{name} found." + raise ArgumentErro...
Improve the ArgumentError exception message in inherit_context.
diff --git a/lib/plugin/python/use.rb b/lib/plugin/python/use.rb index abc1234..def5678 100644 --- a/lib/plugin/python/use.rb +++ b/lib/plugin/python/use.rb @@ -7,6 +7,8 @@ __case(args[1]) do |ca| ca.when("jython*") do __export("JYTHON_HOME", raw("#{var}/libexec")) + #...
Add the jython libexec/Lib to PYTHONPATH
diff --git a/lib/poloxy/item_merge.rb b/lib/poloxy/item_merge.rb index abc1234..def5678 100644 --- a/lib/poloxy/item_merge.rb +++ b/lib/poloxy/item_merge.rb @@ -1,5 +1,7 @@ # Factorial Delegator for Item Merger Class class Poloxy::ItemMerge + attr :merger + def initialize config: nil @config = config || Polo...
Add :merger attr for testing
diff --git a/spec/controllers/api/translations_controller_spec.rb b/spec/controllers/api/translations_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/api/translations_controller_spec.rb +++ b/spec/controllers/api/translations_controller_spec.rb @@ -0,0 +1,55 @@+require 'rails_helper' + +describe...
Add specs for translation controller
diff --git a/spec/integration/release/create_bosh_release_spec.rb b/spec/integration/release/create_bosh_release_spec.rb index abc1234..def5678 100644 --- a/spec/integration/release/create_bosh_release_spec.rb +++ b/spec/integration/release/create_bosh_release_spec.rb @@ -0,0 +1,19 @@+require 'spec_helper' + +describe ...
Add integration test for creating a bosh dev release So that we can catch missing / extra files in job spec files within the bosh release. [Finish #101552268](https://www.pivotaltracker.com/story/show/101552268) Signed-off-by: Tushar Dadlani <30e3adf538ecf64bd912d5b2c65f5b8659805406@pivotal.io>
diff --git a/foodcritic.gemspec b/foodcritic.gemspec index abc1234..def5678 100644 --- a/foodcritic.gemspec +++ b/foodcritic.gemspec @@ -21,6 +21,7 @@ s.files = Dir['chef_dsl_metadata/*.json'] + Dir['lib/**/*.rb'] + Dir['misc/**/*'] + s.files += Dir['Rakefile'] + Dir['Gemfile'] + Dir["*.gemspec"] s.file...
Include gemspec and Gemfiles in distributed gem for ease of working with / running tests
diff --git a/spec/controllers/scites_controller_spec.rb b/spec/controllers/scites_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/scites_controller_spec.rb +++ b/spec/controllers/scites_controller_spec.rb @@ -1,3 +1,5 @@+require 'spec_helper' + describe ScitesController do let(:user) { Fa...
Fix a test bug when not run in guard
diff --git a/spec/rubocop/cop/lint/empty_ensure_spec.rb b/spec/rubocop/cop/lint/empty_ensure_spec.rb index abc1234..def5678 100644 --- a/spec/rubocop/cop/lint/empty_ensure_spec.rb +++ b/spec/rubocop/cop/lint/empty_ensure_spec.rb @@ -7,15 +7,17 @@ expect_offense(<<~RUBY) begin something - ensure...
Improve spec for Lint/EmptyEnsure with comments
diff --git a/test/adapters/redis_cache_test.rb b/test/adapters/redis_cache_test.rb index abc1234..def5678 100644 --- a/test/adapters/redis_cache_test.rb +++ b/test/adapters/redis_cache_test.rb @@ -1,7 +1,7 @@ require 'test_helper' require 'flipper/adapters/redis_cache' -class DalliTest < MiniTest::Test +class RedisC...
Rename dalli test to correct redis cache test
diff --git a/lib/discordrb/data.rb b/lib/discordrb/data.rb index abc1234..def5678 100644 --- a/lib/discordrb/data.rb +++ b/lib/discordrb/data.rb @@ -15,6 +15,18 @@ # Utility function to mention users in messages def mention "<@#{@id}>" + end + end + + class Channel + attr_reader :name, :server_i...
Add class to represent Discord channels
diff --git a/lib/formalist/form.rb b/lib/formalist/form.rb index abc1234..def5678 100644 --- a/lib/formalist/form.rb +++ b/lib/formalist/form.rb @@ -34,7 +34,7 @@ # @api public def build(input = {}) elements = self.class.elements.map { |el| el.resolve(self) } - Result.new(input, elements, schema.ru...
Access the schema’s rules via `.rule_ast`
diff --git a/lib/gas/git_config.rb b/lib/gas/git_config.rb index abc1234..def5678 100644 --- a/lib/gas/git_config.rb +++ b/lib/gas/git_config.rb @@ -1,6 +1,6 @@ module Gas - # Class that class that interacts with the git config + # Module that class that interacts with the git config module GitConfig # Pa...
Trim down some more code
diff --git a/browserify-rails.gemspec b/browserify-rails.gemspec index abc1234..def5678 100644 --- a/browserify-rails.gemspec +++ b/browserify-rails.gemspec @@ -22,6 +22,5 @@ spec.add_development_dependency "bundler", "~> 1.3" spec.add_development_dependency "rake" - spec.add_development_dependency "pry" spe...
Remove pry for debugging the tests
diff --git a/test/unit/release/scm/git_test.rb b/test/unit/release/scm/git_test.rb index abc1234..def5678 100644 --- a/test/unit/release/scm/git_test.rb +++ b/test/unit/release/scm/git_test.rb @@ -0,0 +1,58 @@+require "test_helper" +require "mocha/test_unit" +require "test_construct" + +module Roger + # Test for Roger...
Add test for GIT SCM
diff --git a/lib/jiggle/vector2.rb b/lib/jiggle/vector2.rb index abc1234..def5678 100644 --- a/lib/jiggle/vector2.rb +++ b/lib/jiggle/vector2.rb @@ -10,6 +10,11 @@ end alias :<=> :distance_to + + def to_a + [x, y] + end + alias :to_ary :to_a end def jgv(x, y)
Add converting to array stuff to Vector2 so it's nicer with Rubygame
diff --git a/lib/kuroko2/engine.rb b/lib/kuroko2/engine.rb index abc1234..def5678 100644 --- a/lib/kuroko2/engine.rb +++ b/lib/kuroko2/engine.rb @@ -9,15 +9,13 @@ config.autoload_paths << root.join('lib') - config.before_initialize do + initializer "kuroko2.configuration" do |app| URI.parse(Kuroko2...
Move configuration loading to initializer
diff --git a/lib/opal/processor.rb b/lib/opal/processor.rb index abc1234..def5678 100644 --- a/lib/opal/processor.rb +++ b/lib/opal/processor.rb @@ -9,15 +9,13 @@ true end - def self.method_missing_enabled - @method_missing_enabled - end - - def self.method_missing_enabled=(enabled) - @m...
Allow optimized_operators parser option to be configured
diff --git a/lib/rails_launcher.rb b/lib/rails_launcher.rb index abc1234..def5678 100644 --- a/lib/rails_launcher.rb +++ b/lib/rails_launcher.rb @@ -1,4 +1,4 @@-require 'active_support/core_ext/string' +require 'active_support/all' require "rails_launcher/version" require "rails_launcher/dsl"
Use 'activesupport/all' to avoid problem used as a gem
diff --git a/circuit_breaker-ruby.gemspec b/circuit_breaker-ruby.gemspec index abc1234..def5678 100644 --- a/circuit_breaker-ruby.gemspec +++ b/circuit_breaker-ruby.gemspec @@ -3,7 +3,7 @@ Gem::Specification.new do |gem| gem.name = 'circuit_breaker-ruby' gem.version = CircuitBreaker::VERSION - gem.d...
Fix date in gemspec file
diff --git a/lib/devise/uncommon_password/model.rb b/lib/devise/uncommon_password/model.rb index abc1234..def5678 100644 --- a/lib/devise/uncommon_password/model.rb +++ b/lib/devise/uncommon_password/model.rb @@ -25,7 +25,7 @@ private def not_common_password - return unless password.present? + ...
Switch to using password_required? to check if password is changing This is more idiomatic - it's what devise uses internally.
diff --git a/lib/travis/support.rb b/lib/travis/support.rb index abc1234..def5678 100644 --- a/lib/travis/support.rb +++ b/lib/travis/support.rb @@ -22,6 +22,10 @@ ENV['ENV'] || ENV['RAILS_ENV'] || ENV['RACK_ENV'] || 'development' end + def env?(name) + name.to_s == env + end + def logger ...
Add env check convenience method
diff --git a/templates/spec_helper.rb b/templates/spec_helper.rb index abc1234..def5678 100644 --- a/templates/spec_helper.rb +++ b/templates/spec_helper.rb @@ -26,12 +26,12 @@ config.order = 'random' config.use_transactional_fixtures = false - config.before(:each) do - Capybara.current_driver = select_drive...
Update code to latest RSpec configs
diff --git a/lib/revertible_paper_trail/version.rb b/lib/revertible_paper_trail/version.rb index abc1234..def5678 100644 --- a/lib/revertible_paper_trail/version.rb +++ b/lib/revertible_paper_trail/version.rb @@ -11,7 +11,7 @@ when "create" item.destroy when "update" - previ...
Fix revert action for update event.
diff --git a/lib/store_schema/converter/boolean.rb b/lib/store_schema/converter/boolean.rb index abc1234..def5678 100644 --- a/lib/store_schema/converter/boolean.rb +++ b/lib/store_schema/converter/boolean.rb @@ -30,7 +30,7 @@ # def to_db if TRUE_VALUES.include?(value) - "t" + DB_TRUE_VALUE els...
Return `DB_TRUE_VALUE` instead of "t" to avoid multiple memory allocations and to ensure consistency.
diff --git a/lib/tasks/cleanup_duplicate_urls.rake b/lib/tasks/cleanup_duplicate_urls.rake index abc1234..def5678 100644 --- a/lib/tasks/cleanup_duplicate_urls.rake +++ b/lib/tasks/cleanup_duplicate_urls.rake @@ -0,0 +1,14 @@+task :cleanup_dupes => :environment do + vals = [] + + validations = Validation.where(:url.n...
Add Rake task to cleanup dupes
diff --git a/lib/tasks/reprocess_tweet_images.rake b/lib/tasks/reprocess_tweet_images.rake index abc1234..def5678 100644 --- a/lib/tasks/reprocess_tweet_images.rake +++ b/lib/tasks/reprocess_tweet_images.rake @@ -1,5 +1,5 @@ task :reprocess_tweet_images => :environment do - RUBYFRIENDS_APP.tweets.each do |tweet| + Tw...
Fix reference to old constant
diff --git a/config/initializers/spree.rb b/config/initializers/spree.rb index abc1234..def5678 100644 --- a/config/initializers/spree.rb +++ b/config/initializers/spree.rb @@ -1,12 +1,15 @@ # Configure Spree Preferences -# +# # Note: Initializing preferences available within the Admin will overwrite any changes that...
Change checkout zone so that Austrlia is the default country selected in checkout.
diff --git a/omnibus-software.gemspec b/omnibus-software.gemspec index abc1234..def5678 100644 --- a/omnibus-software.gemspec +++ b/omnibus-software.gemspec @@ -14,7 +14,7 @@ # Software definitions in this bundle require at least this version of # omnibus because of the dsl methods they are using. s.add_depende...
Switch back to chef-sugar from chef-sugar-ng No need to use the ng here Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/msfl_visitors.gemspec b/msfl_visitors.gemspec index abc1234..def5678 100644 --- a/msfl_visitors.gemspec +++ b/msfl_visitors.gemspec @@ -10,7 +10,7 @@ s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n") s.homepage = 'https://github.com/Referly/msfl_visitors' - s.add_runtim...
Address warning from gem build about being overly pessimistic.
diff --git a/scripts/update-apidoc.rb b/scripts/update-apidoc.rb index abc1234..def5678 100644 --- a/scripts/update-apidoc.rb +++ b/scripts/update-apidoc.rb @@ -28,11 +28,9 @@ system("cd %s && apidoc update" % File.join(dir, "..")) latest = extract_version(path) -puts "current: %s" % current -puts "latest: %s" % lat...
Improve output from script to update API
diff --git a/spec/tic_tac_toe_spec.rb b/spec/tic_tac_toe_spec.rb index abc1234..def5678 100644 --- a/spec/tic_tac_toe_spec.rb +++ b/spec/tic_tac_toe_spec.rb @@ -55,7 +55,7 @@ it 'knows when someone has won' do ["X", "O"].each do |mark| - [[0, 1, 2]].each do |places| + [[0, 1, 2], [3,4,5]].eac...
Test won at different place sets
diff --git a/lib/musicality/composition/note_generation.rb b/lib/musicality/composition/note_generation.rb index abc1234..def5678 100644 --- a/lib/musicality/composition/note_generation.rb +++ b/lib/musicality/composition/note_generation.rb @@ -28,4 +28,19 @@ end module_function :make_notes +def e(pitch_groups) + p...
Add convenience methods for generating eighth, quarter, and dotted-quarter notes
diff --git a/ruby-ole.gemspec b/ruby-ole.gemspec index abc1234..def5678 100644 --- a/ruby-ole.gemspec +++ b/ruby-ole.gemspec @@ -1,4 +1,4 @@-$:.unshift (File.dirname(__FILE__) + '/lib') +$:.unshift File.dirname(__FILE__) + '/lib' require 'ole/storage/version' PKG_NAME = 'ruby-ole'
Fix to avoid warning about space before parentheses.
diff --git a/spec/controllers/campaigns_controller_spec.rb b/spec/controllers/campaigns_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/campaigns_controller_spec.rb +++ b/spec/controllers/campaigns_controller_spec.rb @@ -22,7 +22,7 @@ end context 'if there are a custom template' do - ...
Fix routing error for the campaign
diff --git a/spec/integration/package_vote_feature_spec.rb b/spec/integration/package_vote_feature_spec.rb index abc1234..def5678 100644 --- a/spec/integration/package_vote_feature_spec.rb +++ b/spec/integration/package_vote_feature_spec.rb @@ -22,8 +22,8 @@ end it "should be possible to vote for a package" do -...
Update wording to "uses" in vote spec
diff --git a/spec/cmd_spec.rb b/spec/cmd_spec.rb index abc1234..def5678 100644 --- a/spec/cmd_spec.rb +++ b/spec/cmd_spec.rb @@ -33,4 +33,10 @@ output = @winrm.run_cmd('') expect(output[:exitcode]).to eq(0) end + + it 'should run a CMD command that has bad arg and return non-zero exit code' do + output ...
Add zero exit code test case
diff --git a/spec/sse_spec.rb b/spec/sse_spec.rb index abc1234..def5678 100644 --- a/spec/sse_spec.rb +++ b/spec/sse_spec.rb @@ -3,7 +3,7 @@ require 'sparql/spec' describe SPARQL::Grammar::Parser do - describe "w3c dawg SPARQL evaluation tests" do + describe "w3c dawg SPARQL tests to SSE" do SPARQL::Spec.load...
Test both lexical and object translation to SSE. Lexical tests that fail are made pending.
diff --git a/Casks/p4v.rb b/Casks/p4v.rb index abc1234..def5678 100644 --- a/Casks/p4v.rb +++ b/Casks/p4v.rb @@ -1,6 +1,6 @@ cask :v1 => 'p4v' do - version '2014.3-1007540' - sha256 '07eac08f6bfb32e4a79bf47582116de8532fe0b18d91a014e1cd80861d6f0909' + version '2015.2-1312139' + sha256 '6f64cca4e84d344c5f420e58a72bd0...
Update P4V to latest version (2015.2-1312139).
diff --git a/spec/controllers/ideas_controller_spec.rb b/spec/controllers/ideas_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/ideas_controller_spec.rb +++ b/spec/controllers/ideas_controller_spec.rb @@ -33,5 +33,11 @@ end end - pending "needs expanded GET, POST, PATCH, PUT, DESTROY t...
Update IdeaController spec pending test messages Add messages for each individual test that can be added.
diff --git a/spec/controllers/votes_controller_spec.rb b/spec/controllers/votes_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/votes_controller_spec.rb +++ b/spec/controllers/votes_controller_spec.rb @@ -0,0 +1,12 @@+require 'rails_helper' + +describe VotesController do + describe '#create' do...
Define initial spec tests for upvoting.
diff --git a/spec/features/create_contribution_spec.rb b/spec/features/create_contribution_spec.rb index abc1234..def5678 100644 --- a/spec/features/create_contribution_spec.rb +++ b/spec/features/create_contribution_spec.rb @@ -0,0 +1,35 @@+require 'spec_helper' + +feature 'Create contribution' do + background do + ...
Test to make sure we don't get contributions smaller than $10
diff --git a/spec/features/issues/note_polling_spec.rb b/spec/features/issues/note_polling_spec.rb index abc1234..def5678 100644 --- a/spec/features/issues/note_polling_spec.rb +++ b/spec/features/issues/note_polling_spec.rb @@ -9,10 +9,8 @@ end scenario 'Another user adds a comment to an issue', js: true do - ...
Add minor fixes in note polling specs
diff --git a/spec/integration/rack/test/test_helper.rb b/spec/integration/rack/test/test_helper.rb index abc1234..def5678 100644 --- a/spec/integration/rack/test/test_helper.rb +++ b/spec/integration/rack/test/test_helper.rb @@ -15,6 +15,9 @@ include Webrat::Matchers def app - RackApp.new + Rack::Builder.n...
Use Rack::Lint to test the rack session
diff --git a/ontrac-web-services.gemspec b/ontrac-web-services.gemspec index abc1234..def5678 100644 --- a/ontrac-web-services.gemspec +++ b/ontrac-web-services.gemspec @@ -17,6 +17,5 @@ gem.version = Ontrac::VERSION gem.required_ruby_version = '>= 1.9.0' - gem.add_dependency("activesupport") gem.add_d...
Remove the dependency on activesupport.
diff --git a/spec/lib/appsignal/hooks/celluloid_spec.rb b/spec/lib/appsignal/hooks/celluloid_spec.rb index abc1234..def5678 100644 --- a/spec/lib/appsignal/hooks/celluloid_spec.rb +++ b/spec/lib/appsignal/hooks/celluloid_spec.rb @@ -3,6 +3,11 @@ before :context do module Celluloid def self.shutdown ...
Replace shutdown should-receive from Celluloid test Instead, use the mock (verb) to set an instance variable we can later read to see if the method was at least called.
diff --git a/templates/api_application_controller.rb b/templates/api_application_controller.rb index abc1234..def5678 100644 --- a/templates/api_application_controller.rb +++ b/templates/api_application_controller.rb @@ -2,5 +2,5 @@ include ApiDefaults # Prevent CSRF attacks by raising an exception. # For APIs,...
Modify API application controller to skip csrf protection when requesting JSON
diff --git a/db/schema.rb b/db/schema.rb index abc1234..def5678 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -0,0 +1,16 @@+# encoding: UTF-8 +# This file is auto-generated from the current state of the database. Instead +# of editing this file, please use the migrations feature of Active Record to +# incrementally m...
Fix init for heroku deployement
diff --git a/test/aws-lambda/features/support/env.rb b/test/aws-lambda/features/support/env.rb index abc1234..def5678 100644 --- a/test/aws-lambda/features/support/env.rb +++ b/test/aws-lambda/features/support/env.rb @@ -1,3 +1,19 @@+`command -v sam` + +if $? != 0 + puts <<~ERROR + The AWS SAM CLI must be installed b...
Check SAM is installed before running
diff --git a/lib/cenit_cmd/templates/collection/collection.gemspec b/lib/cenit_cmd/templates/collection/collection.gemspec index abc1234..def5678 100644 --- a/lib/cenit_cmd/templates/collection/collection.gemspec +++ b/lib/cenit_cmd/templates/collection/collection.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |s| ...
Add version.rb to template Cenit Collection Gem
diff --git a/core/app/workers/remove_fact_relation_credibility_job.rb b/core/app/workers/remove_fact_relation_credibility_job.rb index abc1234..def5678 100644 --- a/core/app/workers/remove_fact_relation_credibility_job.rb +++ b/core/app/workers/remove_fact_relation_credibility_job.rb @@ -1,4 +1,7 @@-class RemoveFactRel...
Put job on a queue
diff --git a/db/migrate/20151016130937_add_uuid_to_shared_entities.rb b/db/migrate/20151016130937_add_uuid_to_shared_entities.rb index abc1234..def5678 100644 --- a/db/migrate/20151016130937_add_uuid_to_shared_entities.rb +++ b/db/migrate/20151016130937_add_uuid_to_shared_entities.rb @@ -0,0 +1,25 @@+Sequel.migration d...
Add back ID to shared_entitites join table
diff --git a/db/migrate/20190212152221_change_dataset_id_to_bigint.rb b/db/migrate/20190212152221_change_dataset_id_to_bigint.rb index abc1234..def5678 100644 --- a/db/migrate/20190212152221_change_dataset_id_to_bigint.rb +++ b/db/migrate/20190212152221_change_dataset_id_to_bigint.rb @@ -0,0 +1,39 @@+class ChangeDatase...
Update dataset_id primary and foreign keys to bigint
diff --git a/app/controllers/admin/publishers_controller.rb b/app/controllers/admin/publishers_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/publishers_controller.rb +++ b/app/controllers/admin/publishers_controller.rb @@ -20,25 +20,25 @@ INNER JOIN site_channel_de...
Enable case insensitive admin search
diff --git a/week-4/simple-string.rb b/week-4/simple-string.rb index abc1234..def5678 100644 --- a/week-4/simple-string.rb +++ b/week-4/simple-string.rb @@ -0,0 +1,30 @@+# Solution Below + +old_string = "Ruby is cool" + +new_string = old_string.reverse.upcase + + + +# RSpec Tests. They are included in this file because...
Add simple string ruby file
diff --git a/app/controllers/community_controller.rb b/app/controllers/community_controller.rb index abc1234..def5678 100644 --- a/app/controllers/community_controller.rb +++ b/app/controllers/community_controller.rb @@ -11,7 +11,7 @@ def organization_leaderboards data = Rails.cache.fetch('community_organizati...
Use OrganizationIndexPresenter instead of OrganizationDetailPresenter
diff --git a/app/controllers/countries_controller.rb b/app/controllers/countries_controller.rb index abc1234..def5678 100644 --- a/app/controllers/countries_controller.rb +++ b/app/controllers/countries_controller.rb @@ -1,5 +1,5 @@ class CountriesController < ApplicationController - before_filter :admin_required + b...
Allow managers to manage countries
diff --git a/app/controllers/questions_controller.rb b/app/controllers/questions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/questions_controller.rb +++ b/app/controllers/questions_controller.rb @@ -16,8 +16,9 @@ @question = Question.new(question_params) @question.user = current_user ...
Change new question controller to redirect to show instead of rendering
diff --git a/su-template/coverage/fulldoc/text/setup.rb b/su-template/coverage/fulldoc/text/setup.rb index abc1234..def5678 100644 --- a/su-template/coverage/fulldoc/text/setup.rb +++ b/su-template/coverage/fulldoc/text/setup.rb @@ -19,11 +19,11 @@ puts "Generating #{MANIFEST_FILENAME}..." methods = Set.new nam...
Fix coverage template to filter the methods.
diff --git a/lib/pakyow/migrations/1441304573_console_create_users.rb b/lib/pakyow/migrations/1441304573_console_create_users.rb index abc1234..def5678 100644 --- a/lib/pakyow/migrations/1441304573_console_create_users.rb +++ b/lib/pakyow/migrations/1441304573_console_create_users.rb @@ -9,9 +9,9 @@ TrueClass ...
Remove defaults from user creds
diff --git a/test/test_wepay_rails_authorize.rb b/test/test_wepay_rails_authorize.rb index abc1234..def5678 100644 --- a/test/test_wepay_rails_authorize.rb +++ b/test/test_wepay_rails_authorize.rb @@ -0,0 +1,28 @@+require File.expand_path(File.dirname(__FILE__) + '/helper') + +class TestWepayRailsAuthorize < ActiveSupp...
Add tests for WePay authorization methods.
diff --git a/lib/authentication.rb b/lib/authentication.rb index abc1234..def5678 100644 --- a/lib/authentication.rb +++ b/lib/authentication.rb @@ -1,7 +1,7 @@ module FlickrCli module Authentication def self.establish_session - auth_file = File.expand_path("~/.flick_airliftrc") + auth_f...
Store credentials in a different file than flickr_airlift does - Use Ruby 1.9's Dir.home function for cross-platformitude
diff --git a/lib/bootstrap-sass.rb b/lib/bootstrap-sass.rb index abc1234..def5678 100644 --- a/lib/bootstrap-sass.rb +++ b/lib/bootstrap-sass.rb @@ -18,7 +18,7 @@ raise Bootstrap::FrameworkNotFound, "bootstrap-sass requires either Rails > 3.1 or Compass, neither of which are loaded" end stylesheets = Fi...
Fix namespace Sass module due to conflict with bootstra-sass-rails No one should really use the two together, but in case they do, or in case any other library defines a Bootstrap::Sass module, we should be clear that we mean the global core Sass module here. Fixes thomas-mcdonald/bootstrap-sass#293
diff --git a/test/lib/caruby/util/partial_order_test.rb b/test/lib/caruby/util/partial_order_test.rb index abc1234..def5678 100644 --- a/test/lib/caruby/util/partial_order_test.rb +++ b/test/lib/caruby/util/partial_order_test.rb @@ -6,36 +6,37 @@ class Queued include PartialOrder - attr_reader :value, :queue + a...
Make i.v. temp variable instead.
diff --git a/lib/proteus/kit.rb b/lib/proteus/kit.rb index abc1234..def5678 100644 --- a/lib/proteus/kit.rb +++ b/lib/proteus/kit.rb @@ -16,7 +16,9 @@ if system "git ls-remote #{url(kit_name)} #{repo_name} > /dev/null 2>&1" puts "Starting a new proteus-#{kit_name} project in #{repo_name}" - syst...
Destroy the existing .git folder and make a new one (so the user has a clean history)
diff --git a/lib/rusty_blank.rb b/lib/rusty_blank.rb index abc1234..def5678 100644 --- a/lib/rusty_blank.rb +++ b/lib/rusty_blank.rb @@ -1,7 +1,8 @@ require 'fiddle' require 'rbconfig' -library = Fiddle.dlopen("librusty_blank.#{RbConfig::CONFIG['DLEXT']}") +basename = "librusty_blank.#{RbConfig::CONFIG['DLEXT']}" +l...
Fix loading of the compiled library
diff --git a/lib/middleman-blog-drafts/draft_article.rb b/lib/middleman-blog-drafts/draft_article.rb index abc1234..def5678 100644 --- a/lib/middleman-blog-drafts/draft_article.rb +++ b/lib/middleman-blog-drafts/draft_article.rb @@ -16,7 +16,8 @@ # @param [String] The part of the path, e.g. "title" # @...
Fix failure on handling the path containing non-uri chars In `DraftArticle#path_part`, `Addressable::Template#extract` returns `nil` when `path` has characters not allowed for URI (RFC3986) so that `DraftArticle#slug` fails for undefined `[]`. Normalizing (percent-encoding) `path` string before `extract` prevents its ...
diff --git a/lib/paperclip/geometry_detector_factory.rb b/lib/paperclip/geometry_detector_factory.rb index abc1234..def5678 100644 --- a/lib/paperclip/geometry_detector_factory.rb +++ b/lib/paperclip/geometry_detector_factory.rb @@ -14,9 +14,14 @@ def geometry_string begin - silence_stream(STDERR) d...
Use :swallow_stderr instead of not thread safe silence_stream(STDERR)
diff --git a/lib/commands/raker.rb b/lib/commands/raker.rb index abc1234..def5678 100644 --- a/lib/commands/raker.rb +++ b/lib/commands/raker.rb @@ -8,8 +8,8 @@ load_rake_tasks end - def rake(task = nil, *args) - task.nil? ? print_rake_tasks : invoke_rake_task(task, *args) + def rake(task = nil)...
Allow you to set Rake ENV options as part of the call (still missing a way to set rake options like --trace)
diff --git a/db/migrate/20150617152323_create_votes.rb b/db/migrate/20150617152323_create_votes.rb index abc1234..def5678 100644 --- a/db/migrate/20150617152323_create_votes.rb +++ b/db/migrate/20150617152323_create_votes.rb @@ -0,0 +1,12 @@+class CreateVotes < ActiveRecord::Migration + def change + create_table :v...
Add votes schema for migration
diff --git a/01-sendPositionToChat.rb b/01-sendPositionToChat.rb index abc1234..def5678 100644 --- a/01-sendPositionToChat.rb +++ b/01-sendPositionToChat.rb @@ -13,8 +13,7 @@ # Get the block that the player is currently in playerPosition = mc.player.getTilePos() -# Get the exact position of the player -playerPosFLoa...
Remove unused exact position method call Remove unused call and place in another separate example
diff --git a/lib/jiraMule/query.rb b/lib/jiraMule/query.rb index abc1234..def5678 100644 --- a/lib/jiraMule/query.rb +++ b/lib/jiraMule/query.rb @@ -6,7 +6,7 @@ c.example 'Get Open issues and dump everything', %{jm query status=Open --fields "" --json} c.option '--[no-]raw', 'Do not prefix query with project and ass...
Add description to fields option.
diff --git a/Casks/ghc.rb b/Casks/ghc.rb index abc1234..def5678 100644 --- a/Casks/ghc.rb +++ b/Casks/ghc.rb @@ -0,0 +1,8 @@+class Ghc < Cask + url 'https://github.com/ghcformacosx/ghc-dot-app/releases/download/v7.8.2-r2/ghc-7.8.2-r2.zip' + homepage 'http://ghcformacosx.github.io/' + version '7.8.2-r2' + sha256 '7e...
Add GHC for Mac OS X
diff --git a/config/initializers/carrierwave.rb b/config/initializers/carrierwave.rb index abc1234..def5678 100644 --- a/config/initializers/carrierwave.rb +++ b/config/initializers/carrierwave.rb @@ -15,7 +15,7 @@ config.fog_directory = AWS_CONFIG['bucket'] # required config.fog_public ...
Reduce Fog expiration period to 17 years
diff --git a/config/initializers/session_ext.rb b/config/initializers/session_ext.rb index abc1234..def5678 100644 --- a/config/initializers/session_ext.rb +++ b/config/initializers/session_ext.rb @@ -0,0 +1,26 @@+module ActionDispatch + class Request + class Session + alias_method :original_accessor, :[] + ...
Store flash messages in a different session variable Avoids conflict with how Rails 3/public_website deals with flash messages
diff --git a/lib/mactag/builder.rb b/lib/mactag/builder.rb index abc1234..def5678 100644 --- a/lib/mactag/builder.rb +++ b/lib/mactag/builder.rb @@ -45,7 +45,7 @@ if builder.has_gems? Mactag::Ctags.new(@builder.files, Mactag::Config.tags_file).create - puts 'Successfully generated TAGS fil...
Print name of file instead of assuming TAGS.
diff --git a/lib/minuteman/user.rb b/lib/minuteman/user.rb index abc1234..def5678 100644 --- a/lib/minuteman/user.rb +++ b/lib/minuteman/user.rb @@ -9,8 +9,11 @@ unique :uid unique :identifier + index :identifier + def save self.uid ||= SecureRandom.uuid + self.identifier ||= "" su...
Add an identifier index for anonymous lookups