diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/pronto-jshint.gemspec b/pronto-jshint.gemspec index abc1234..def5678 100644 --- a/pronto-jshint.gemspec +++ b/pronto-jshint.gemspec @@ -1,7 +1,8 @@ # -*- encoding: utf-8 -*- +# $LOAD_PATH.push File.expand_path('../lib', __FILE__) - require 'pronto/jshint/version' +require 'English' Gem::Specification....
Reduce size of the gem by only including the necessary files via gemspec
diff --git a/core/app/controllers/tour_controller.rb b/core/app/controllers/tour_controller.rb index abc1234..def5678 100644 --- a/core/app/controllers/tour_controller.rb +++ b/core/app/controllers/tour_controller.rb @@ -5,7 +5,7 @@ # search for @step_in_signup_process = :account def create_your_first_factlink -...
Use tour layout for create_your_first_factlink.
diff --git a/lib/vagrant-notify.rb b/lib/vagrant-notify.rb index abc1234..def5678 100644 --- a/lib/vagrant-notify.rb +++ b/lib/vagrant-notify.rb @@ -2,6 +2,10 @@ require 'socket' require 'erb' require 'ostruct' + +if File.exists?(File.join(File.expand_path('../../', __FILE__), '.git')) + $:.unshift(File.expand_path(...
Allow running the gem from source
diff --git a/lib/wombat/crawler.rb b/lib/wombat/crawler.rb index abc1234..def5678 100644 --- a/lib/wombat/crawler.rb +++ b/lib/wombat/crawler.rb @@ -30,6 +30,7 @@ parsed = parse(@metadata_dup, url) instance_eval do alias :method_missing :old_method_missing + undef :old_method_missin...
Remove unnecessary `old_method_missing` method after crawled
diff --git a/make.rb b/make.rb index abc1234..def5678 100644 --- a/make.rb +++ b/make.rb @@ -2,16 +2,24 @@ include Config require "fileutils" include FileUtils::Verbose +require "generate-initial-keys.rb" loop do puts "Do you want to install the binary (b) or pure-ruby (r) core? (b/r)?" answer=STDIN.gets i...
Clean up better when switching cores
diff --git a/StateView.podspec b/StateView.podspec index abc1234..def5678 100644 --- a/StateView.podspec +++ b/StateView.podspec @@ -14,6 +14,5 @@ s.requires_arc = true s.source_files = 'StateView/*.swift' - s.dependency 'Dwifft' s.dependency 'SnapKit' end
Remove Dwifft from podspec dependencies
diff --git a/bldr.gemspec b/bldr.gemspec index abc1234..def5678 100644 --- a/bldr.gemspec +++ b/bldr.gemspec @@ -24,6 +24,6 @@ s.add_development_dependency 'json_pure' s.add_development_dependency 'sinatra', '~>1.2.6' s.add_development_dependency 'tilt', '~>1.3.2' - s.add_development_dependency 'yajl-ru...
Update yajl gemspec to >= 1.0
diff --git a/app/models/locality.rb b/app/models/locality.rb index abc1234..def5678 100644 --- a/app/models/locality.rb +++ b/app/models/locality.rb @@ -13,7 +13,7 @@ if contact_id.nil? '--' else - User.find(contact_id).name + contact.name end end
Update to follow Rails convention Call send name message to contact instead of searching by contact-id
diff --git a/lib/watir-get-image-content/image.rb b/lib/watir-get-image-content/image.rb index abc1234..def5678 100644 --- a/lib/watir-get-image-content/image.rb +++ b/lib/watir-get-image-content/image.rb @@ -7,13 +7,13 @@ def to_x_base64(target) assert_exists js = %Q{var canvas = document.createEleme...
Use natural width and natural height Use natural width and natural height to make sure we get the whole image for those that are scaled
diff --git a/demo/consumer_unit_test.rb b/demo/consumer_unit_test.rb index abc1234..def5678 100644 --- a/demo/consumer_unit_test.rb +++ b/demo/consumer_unit_test.rb @@ -0,0 +1,98 @@+#!/usr/bin/env ruby + +require 'rubygems' +require 'bundler/setup' + +require 'aviator' + +class AviatorConsumer + + def do_one_thing + ...
Add sample unit testing of a hypothetical Aviator consumer
diff --git a/test/controllers/users_controller_test.rb b/test/controllers/users_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/users_controller_test.rb +++ b/test/controllers/users_controller_test.rb @@ -1,8 +1,10 @@ require 'test_helper' class UsersControllerTest < ActionController::TestCas...
Add test for hitting author profile page successfully
diff --git a/Casks/macid.rb b/Casks/macid.rb index abc1234..def5678 100644 --- a/Casks/macid.rb +++ b/Casks/macid.rb @@ -1,11 +1,15 @@ cask :v1 => 'macid' do - version '1.2b' - sha256 '71dd713f6090b0c6038c274fa32bdb59bb8cfe7f39ec06c252f71dcae932e6a6' + version '1.2.2' + sha256 '6dd7ad1992355be510df33ee6c0209690c6d3...
Upgrade MacID.app to 1.2.2, add MacOS dependency and zap
diff --git a/Formula/dwm.rb b/Formula/dwm.rb index abc1234..def5678 100644 --- a/Formula/dwm.rb +++ b/Formula/dwm.rb @@ -17,12 +17,12 @@ end def caveats - <<EOF - In order to use the Mac OS X command key '⌘' for dwm commands + <<-EOS + In order to use the Mac OS X command key for dwm commands, c...
Remove command-key character for compatibility.
diff --git a/Fusuma.podspec b/Fusuma.podspec index abc1234..def5678 100644 --- a/Fusuma.podspec +++ b/Fusuma.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "Fusuma" - s.version = "0.2.5" + s.version = "0.5" s.summary = "Instagram-like photo browser with a few line o...
Upgrade to 0.5 in podspec
diff --git a/test/react-native/features/support/env.rb b/test/react-native/features/support/env.rb index abc1234..def5678 100644 --- a/test/react-native/features/support/env.rb +++ b/test/react-native/features/support/env.rb @@ -1,5 +1,6 @@ BeforeAll do - Maze.config.receive_no_requests_wait = 15 if Maze.config.respon...
Allow 60s for report deliveries
diff --git a/test/minitest_shared_examples/shared_examples_test.rb b/test/minitest_shared_examples/shared_examples_test.rb index abc1234..def5678 100644 --- a/test/minitest_shared_examples/shared_examples_test.rb +++ b/test/minitest_shared_examples/shared_examples_test.rb @@ -1,5 +1,5 @@ require 'test_helper' -descri...
Fix problem with not running the shared examples. We should use minitest syntax to define class instead of describe
diff --git a/app/controllers/misc_controller.rb b/app/controllers/misc_controller.rb index abc1234..def5678 100644 --- a/app/controllers/misc_controller.rb +++ b/app/controllers/misc_controller.rb @@ -1,3 +1,5 @@+require "fluent/version" + class MiscController < ApplicationController def show redirect_to misc_...
Fix system information page didn't load fluent/version
diff --git a/config/schedule.rb b/config/schedule.rb index abc1234..def5678 100644 --- a/config/schedule.rb +++ b/config/schedule.rb @@ -2,7 +2,7 @@ rake 'cron:minutely' end -every 30.minutes do +every 1.hour do rake 'cron:send_undeployed_commits_reminders' end
Change walrus to run every hour instead of every 30 minutes
diff --git a/attributes/defaults.rb b/attributes/defaults.rb index abc1234..def5678 100644 --- a/attributes/defaults.rb +++ b/attributes/defaults.rb @@ -8,7 +8,7 @@ default["sabnzbd"]["directories"]["install"] = '/opt/sabnzbd' default["sabnzbd"]["directories"]["logs"] = '/var/log/sabnzbd' -default["sabnzbd"]["direct...
Make default config folder be /vagrant/etc/config
diff --git a/app/helpers/spree/payment_methods_helper.rb b/app/helpers/spree/payment_methods_helper.rb index abc1234..def5678 100644 --- a/app/helpers/spree/payment_methods_helper.rb +++ b/app/helpers/spree/payment_methods_helper.rb @@ -1,9 +1,13 @@ module Spree module PaymentMethodsHelper - def payment_method_na...
Add method payment_method to get the payment method from a payment - Method `payment_method_name` now use `payment_method`
diff --git a/features/step_definitions/salt_steps.rb b/features/step_definitions/salt_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/salt_steps.rb +++ b/features/step_definitions/salt_steps.rb @@ -0,0 +1,9 @@+# Copyright 2015 SUSE LLC + +When(/^I get a content of a file "(.*?)"$/) do |filename| ...
Add Salt Master and Salt API step definitions
diff --git a/lib/active_interaction/filters/model_filter.rb b/lib/active_interaction/filters/model_filter.rb index abc1234..def5678 100644 --- a/lib/active_interaction/filters/model_filter.rb +++ b/lib/active_interaction/filters/model_filter.rb @@ -21,8 +21,7 @@ def cast(value, reconstantize = true) @klass |...
Move class matching logic into helper function
diff --git a/lib/smart_answer/predicate/variable_matches.rb b/lib/smart_answer/predicate/variable_matches.rb index abc1234..def5678 100644 --- a/lib/smart_answer/predicate/variable_matches.rb +++ b/lib/smart_answer/predicate/variable_matches.rb @@ -3,18 +3,15 @@ class VariableMatches < Base attr_reader :vari...
Allow overriding of entire label for VariableMatches predicate
diff --git a/lib/analysis/analyze_assessments_table.rb b/lib/analysis/analyze_assessments_table.rb index abc1234..def5678 100644 --- a/lib/analysis/analyze_assessments_table.rb +++ b/lib/analysis/analyze_assessments_table.rb @@ -29,7 +29,7 @@ end def assessment_subject_summary - assessment_subject.each_with_o...
Add method to print crosstabs
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -6,14 +6,13 @@ def create user = User.new(user_params) - if @user.save + if user.save session[:user_id] ...
Implement update user route, remove password and add profile attrs to strong params
diff --git a/lib/embulk/input/presto/explain_parser.rb b/lib/embulk/input/presto/explain_parser.rb index abc1234..def5678 100644 --- a/lib/embulk/input/presto/explain_parser.rb +++ b/lib/embulk/input/presto/explain_parser.rb @@ -6,7 +6,7 @@ explain_text = explain_result.flatten.last.lines.first col...
FIX an incorrect regular expression.
diff --git a/lib/fix_db_schema_conflicts/tasks/db.rake b/lib/fix_db_schema_conflicts/tasks/db.rake index abc1234..def5678 100644 --- a/lib/fix_db_schema_conflicts/tasks/db.rake +++ b/lib/fix_db_schema_conflicts/tasks/db.rake @@ -8,7 +8,7 @@ "#{Rails.root}/db/schema.rb" end rubocop_yml = File.expan...
Use bundled version of rubocop
diff --git a/config/initializers/mime_types.rb b/config/initializers/mime_types.rb index abc1234..def5678 100644 --- a/config/initializers/mime_types.rb +++ b/config/initializers/mime_types.rb @@ -1,8 +1,16 @@+# Video +Mime::Type.register 'video/mp4', :mp4 +Mime::Type.register 'video/mp4', :m4v +Mime::Type.register 'vi...
Add support for srt mimetype
diff --git a/lib/paper_trail_scrapbook/life_history.rb b/lib/paper_trail_scrapbook/life_history.rb index abc1234..def5678 100644 --- a/lib/paper_trail_scrapbook/life_history.rb +++ b/lib/paper_trail_scrapbook/life_history.rb @@ -6,6 +6,14 @@ class LifeHistory def initialize(object) @versions = object.vers...
Add ability to incorporate history of related content
diff --git a/lib/waves/utilities/eligibility_status.rb b/lib/waves/utilities/eligibility_status.rb index abc1234..def5678 100644 --- a/lib/waves/utilities/eligibility_status.rb +++ b/lib/waves/utilities/eligibility_status.rb @@ -8,5 +8,18 @@ ["(d) A local authority in the United Kingdom.", :status_d], ] ...
Add eligibility status for part 4 non-fishing
diff --git a/lib/commands/test_command.rb b/lib/commands/test_command.rb index abc1234..def5678 100644 --- a/lib/commands/test_command.rb +++ b/lib/commands/test_command.rb @@ -7,7 +7,7 @@ class TestCommand < Command def apply(mod) reset_counts(mod) - file_action "Testing", :other, mod, "some files" ...
Fix message displayed when running "yk test" Before this commit, the message was: * Testing some files... After this commit, it is: * Running testsuite... Much better.
diff --git a/rakefiles/wait_for.rb b/rakefiles/wait_for.rb index abc1234..def5678 100644 --- a/rakefiles/wait_for.rb +++ b/rakefiles/wait_for.rb @@ -1,5 +1,4 @@-def wait_for(cmd) - sleep_secs = 20 +def wait_for(cmd, sleep_secs=20) ready = false until ready sh cmd do |ok, res|
Make sleep_secs an arg (with default).
diff --git a/recipes/diff_merge.rb b/recipes/diff_merge.rb index abc1234..def5678 100644 --- a/recipes/diff_merge.rb +++ b/recipes/diff_merge.rb @@ -12,9 +12,9 @@ to "/Applications/DiffMerge.app/Contents/Resources/diffmerge.sh" end -# Configure git if requested +# Configure git unless otherwise requested node["di...
Enable diffmerge git configuration by default (turn off with attribute)
diff --git a/recommendable.gemspec b/recommendable.gemspec index abc1234..def5678 100644 --- a/recommendable.gemspec +++ b/recommendable.gemspec @@ -10,6 +10,7 @@ EOF s.files = Dir['lib/**/*'] + s.test_files = Dir['test/**/*'] s.has_rdoc = 'yard'
Update gemspec to include test_files Signed-off-by: David Celis <b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@davidcel.is>
diff --git a/lib/pacer/neo4j.rb b/lib/pacer/neo4j.rb index abc1234..def5678 100644 --- a/lib/pacer/neo4j.rb +++ b/lib/pacer/neo4j.rb @@ -3,16 +3,29 @@ import com.tinkerpop.blueprints.pgm.impls.neo4j.Neo4jVertex import com.tinkerpop.blueprints.pgm.impls.neo4j.Neo4jEdge - def self.neo4j(path) - graph = Neo4jGr...
Fix problem of lost references to open neo graphs.
diff --git a/lib/kaminari/mongo_mapper.rb b/lib/kaminari/mongo_mapper.rb index abc1234..def5678 100644 --- a/lib/kaminari/mongo_mapper.rb +++ b/lib/kaminari/mongo_mapper.rb @@ -1,7 +1,7 @@ require "kaminari/mongo_mapper/version" -module Kaminari - module MongoMapper - # Your code goes here... - end +ActiveSuppor...
Copy MongoMapper initialization from kaminari/hooks.rb
diff --git a/tasks/configuration.rake b/tasks/configuration.rake index abc1234..def5678 100644 --- a/tasks/configuration.rake +++ b/tasks/configuration.rake @@ -2,6 +2,7 @@ require 'yaml' namespace :configuration do + desc 'Updates the default configuration file when smell defaults change' task :update_default_c...
Add missing description to Rake task.
diff --git a/lib/peddler/parsers/model.rb b/lib/peddler/parsers/model.rb index abc1234..def5678 100644 --- a/lib/peddler/parsers/model.rb +++ b/lib/peddler/parsers/model.rb @@ -37,6 +37,10 @@ str = text_at_xpath(path) Time.parse(CGI.unescape(str)) if str end + + def attribute(name) + ...
Add an attribute parser helper to Model
diff --git a/lib/tic_tac_toe.rb b/lib/tic_tac_toe.rb index abc1234..def5678 100644 --- a/lib/tic_tac_toe.rb +++ b/lib/tic_tac_toe.rb @@ -12,4 +12,8 @@ puts " #{@board[6]} " + " #{@board[7]} " + " #{@board[8]} " end + def move(idx_pos, symbol) + @board[idx_pos - 1] = symbol + end + end
Create method to take in the index_position and symbol and place it on the TTT board
diff --git a/lib/rails/generators/run_template/run_template_generator.rb b/lib/rails/generators/run_template/run_template_generator.rb index abc1234..def5678 100644 --- a/lib/rails/generators/run_template/run_template_generator.rb +++ b/lib/rails/generators/run_template/run_template_generator.rb @@ -1,4 +1,6 @@ class R...
Include a redundant templates folder in generator
diff --git a/rakelib/package.rb b/rakelib/package.rb index abc1234..def5678 100644 --- a/rakelib/package.rb +++ b/rakelib/package.rb @@ -32,7 +32,7 @@ BUILDPACK_VERSION = JavaBuildpack::BuildpackVersion.new(false).freeze - PLATFORMS = %w(centos6 lucid mountainlion precise).freeze + PLATFORMS = %w(centos6 lucid ...
Add trust to list of platforms This change adds ubuntu Trust (14.04) to the list of packaged platform artifacts.
diff --git a/spec/support/setup.rb b/spec/support/setup.rb index abc1234..def5678 100644 --- a/spec/support/setup.rb +++ b/spec/support/setup.rb @@ -1,5 +1,6 @@ RSpec.configure do |config| config.before :suite do `docker build --tag nibtest:latest .` + `cd spec/dummy && docker-compose build` end end
Build dummy docker images before spec run
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -11,10 +11,10 @@ puma_config application do directory deploy[:deploy_to] environment deploy[:rails_env] - logrotate node[:puma][:logrotate] - thread_min node[:puma][:...
Fix issue with puma attributes, they should be defined per application not globally
diff --git a/spec/features/private_courses_spec.rb b/spec/features/private_courses_spec.rb index abc1234..def5678 100644 --- a/spec/features/private_courses_spec.rb +++ b/spec/features/private_courses_spec.rb @@ -0,0 +1,28 @@+# frozen_string_literal: true + +require 'rails_helper' + +describe 'Private courses' do + le...
Add basic feature spec for private courses
diff --git a/spec/support/authentication_helper.rb b/spec/support/authentication_helper.rb index abc1234..def5678 100644 --- a/spec/support/authentication_helper.rb +++ b/spec/support/authentication_helper.rb @@ -8,6 +8,6 @@ end def stub_login user - ApplicationController.any_instance.stub(:current_user) { user ...
Modify stub_login to use mocha mocks
diff --git a/spec/support/contexts/api_requests.rb b/spec/support/contexts/api_requests.rb index abc1234..def5678 100644 --- a/spec/support/contexts/api_requests.rb +++ b/spec/support/contexts/api_requests.rb @@ -10,7 +10,7 @@ name = described_class.name.split(/::/).last.downcase vcr_options = { - recor...
Fix VCR record mode overriding.
diff --git a/schema.gemspec b/schema.gemspec index abc1234..def5678 100644 --- a/schema.gemspec +++ b/schema.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |s| s.name = 'schema' s.summary = "Primitives for schema and structure" - s.version = '0.4.5.1' + s.version = '0.4.5.2' s.description = ' ' s.aut...
Package version increased from 0.4.5.1 to 0.4.5.2
diff --git a/app/decorators/meals/signup_decorator.rb b/app/decorators/meals/signup_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/meals/signup_decorator.rb +++ b/app/decorators/meals/signup_decorator.rb @@ -26,7 +26,7 @@ else form.select(:household_id, household&.decorate&.selected_opti...
821: Fix select2 label attr for signup households
diff --git a/app/helpers/budget_investments_helper.rb b/app/helpers/budget_investments_helper.rb index abc1234..def5678 100644 --- a/app/helpers/budget_investments_helper.rb +++ b/app/helpers/budget_investments_helper.rb @@ -16,8 +16,15 @@ end def set_sorting_icon(direction, sort_by) - icon = direction == "de...
Use `if` blocks instead of two ternary operators Using a simple ternary operator is usually fine; however, code combining two ternary operator is a bit hard to follow.
diff --git a/app/helpers/orchid/application_helper.rb b/app/helpers/orchid/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/orchid/application_helper.rb +++ b/app/helpers/orchid/application_helper.rb @@ -1,7 +1,10 @@ module Orchid::ApplicationHelper def copy_params + # Remove Rails internal...
Drop "action" and "controller" params from URLs Always accessible via `params["action"]` and `params["controller"]`
diff --git a/spec/requests_spec.rb b/spec/requests_spec.rb index abc1234..def5678 100644 --- a/spec/requests_spec.rb +++ b/spec/requests_spec.rb @@ -55,8 +55,8 @@ context 'Printing body' do let(:body) { 'Request Body' } - it 'prints body on post request' do - expect { post '/', body }.to output(/Reques...
Use a get request rather than post request in spec.
diff --git a/TinyConstraints.podspec b/TinyConstraints.podspec index abc1234..def5678 100644 --- a/TinyConstraints.podspec +++ b/TinyConstraints.podspec @@ -3,6 +3,7 @@ s.version = '3.1.0' s.ios.deployment_target = '9.0' s.tvos.deployment_target = '9.0' + s.osx.deployment_target = '10.11' s.summary ...
Add osx deployment target to podspec.
diff --git a/test/test_gem_install.rb b/test/test_gem_install.rb index abc1234..def5678 100644 --- a/test/test_gem_install.rb +++ b/test/test_gem_install.rb @@ -17,12 +17,4 @@ end assert_match(/GNU ed/, out) end - - def test_gem_install_nokogiri - msys = RubyInstaller::Runtime.msys2_installation - ms...
Remove test for "gem install nokogiri" The remaining gem install test already tests everything, so that nokogiri is not very valuable here.
diff --git a/config/initializers/inflections.rb b/config/initializers/inflections.rb index abc1234..def5678 100644 --- a/config/initializers/inflections.rb +++ b/config/initializers/inflections.rb @@ -11,6 +11,6 @@ # end # These inflection rules are supported but not enabled by default: -# ActiveSupport::Inflector.i...
Add JSON as an inflection Rails camel cases the filename to work out the expected class name. In this case, `symbolize_json.rb` was expected to be `SymbolizeJson`. Adding an acronym as an inflection will resolve this.
diff --git a/lib/order.rb b/lib/order.rb index abc1234..def5678 100644 --- a/lib/order.rb +++ b/lib/order.rb @@ -3,8 +3,13 @@ @order_hash = order_hash end + def address + address_type = @config['twilio.address_type'] || "billing" + @order_hash["#{address_type}_address"] + end + def customer_phone - ...
Bring back address picking via param Originally checked in 753c650e1e471f21215e480d198384c61856eb61 and lost later on in 7c5e414b083b41253fbb19fcb08dcc6e8345e1c9
diff --git a/acceptance/henson_install_spec.rb b/acceptance/henson_install_spec.rb index abc1234..def5678 100644 --- a/acceptance/henson_install_spec.rb +++ b/acceptance/henson_install_spec.rb @@ -28,7 +28,7 @@ end it "should have ssh module" do - expect(Pathname.new("#{project}/shared/ssh")).to be_directory ...
Update henson install spec to check if path sourced modules use symlinks
diff --git a/actionpack-action_caching.gemspec b/actionpack-action_caching.gemspec index abc1234..def5678 100644 --- a/actionpack-action_caching.gemspec +++ b/actionpack-action_caching.gemspec @@ -13,6 +13,7 @@ gem.executables = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) } gem.test_files = gem.files....
Add license information to gemspec.
diff --git a/core/spec/acceptance/add_channel_spec.rb b/core/spec/acceptance/add_channel_spec.rb index abc1234..def5678 100644 --- a/core/spec/acceptance/add_channel_spec.rb +++ b/core/spec/acceptance/add_channel_spec.rb @@ -8,6 +8,5 @@ visit channel_path(user, channel) page.should have_content(channel.title...
Revert "break acceptance spec, this should make a screenshot" This reverts commit c40f2556e42fc8f84dae00983051aec74bc81ae6.
diff --git a/core/spec/models/comable/address_spec.rb b/core/spec/models/comable/address_spec.rb index abc1234..def5678 100644 --- a/core/spec/models/comable/address_spec.rb +++ b/core/spec/models/comable/address_spec.rb @@ -13,4 +13,15 @@ it { is_expected.to validate_length_of(:city).is_at_most(255) } it { is_exp...
Add test code for `ransacker :full_name`
diff --git a/db/fixtures/development/07_milestones.rb b/db/fixtures/development/07_milestones.rb index abc1234..def5678 100644 --- a/db/fixtures/development/07_milestones.rb +++ b/db/fixtures/development/07_milestones.rb @@ -1,5 +1,3 @@-ActiveRecord::Base.observers.disable(:milestone_observer) - Milestone.seed(:id, [ ...
Remove milestone observer from db fixture.
diff --git a/core/file/socket_spec.rb b/core/file/socket_spec.rb index abc1234..def5678 100644 --- a/core/file/socket_spec.rb +++ b/core/file/socket_spec.rb @@ -19,15 +19,20 @@ rm_r filename end +end + +describe "File.socket?" do + before :each do + @name = tmp("i_am_a_socket") + @server = UNIXServer.ne...
Add proper before/after blocks for a File.socket? spec
diff --git a/spec/features/nodes_spec.rb b/spec/features/nodes_spec.rb index abc1234..def5678 100644 --- a/spec/features/nodes_spec.rb +++ b/spec/features/nodes_spec.rb @@ -0,0 +1,56 @@+require 'rails_helper' + +describe "Nodes Feature" do + + describe 'Find, update and create nodes via API' do + + before do + ...
Convert cucumber nodes-feature to rspec-feature
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -32,11 +32,11 @@ icon = "" case vote when 'yes' - icon = "thumbs-o-up" + icon = "check" when 'n...
Change to new icons again accidentally regressed in merge
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -1,10 +1,10 @@ module ApplicationHelper def set_title(title) - content_for :title, title + content_for :title, stri...
Handle html tags in page_heading helper.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -6,7 +6,8 @@ end def width_override(width) - width.nil? ? nil : "width: #{width}px !important;" + width = 695 i...
Fix table.content width rendering bug in application helper
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -1,5 +1,5 @@ module ApplicationHelper def is_ramsar_instance? - Rails.root.to_s.include?('API') + Rails.root.to_s.i...
Make sure methods checks for ramsar instance
diff --git a/spec/models/ability_spec.rb b/spec/models/ability_spec.rb index abc1234..def5678 100644 --- a/spec/models/ability_spec.rb +++ b/spec/models/ability_spec.rb @@ -7,4 +7,4 @@ roles.should == ['admin', 'accountant'] roles_collection.should == [['Administrator', 'admin'], ['Buchhalter', 'accountant']] ...
Add EOL to ability spec.
diff --git a/spec/rabbitmq/basic_spec.rb b/spec/rabbitmq/basic_spec.rb index abc1234..def5678 100644 --- a/spec/rabbitmq/basic_spec.rb +++ b/spec/rabbitmq/basic_spec.rb @@ -0,0 +1,31 @@+# +# Copyright (C) 2015 Red Hat, Inc. +# +# Author: Martin Magr <mmagr@redhat.com> +# +# Licensed under the Apache License, Version 2....
Add a basic test for RabbitMQ Basic test to see if RabbitMQ is up and running.
diff --git a/rb/spec/integration/selenium/webdriver/opera/driver_spec.rb b/rb/spec/integration/selenium/webdriver/opera/driver_spec.rb index abc1234..def5678 100644 --- a/rb/spec/integration/selenium/webdriver/opera/driver_spec.rb +++ b/rb/spec/integration/selenium/webdriver/opera/driver_spec.rb @@ -3,6 +3,9 @@ mod...
AndreasTolfTolfsen: Make sure remote server is shut down before running specs on Selenium::WebDriver::Opera git-svn-id: aa1aa1384423cb28c2b1e29129bb3a91de1d9196@13920 07704840-8298-11de-bf8c-fd130f914ac9
diff --git a/encrypted_params.gemspec b/encrypted_params.gemspec index abc1234..def5678 100644 --- a/encrypted_params.gemspec +++ b/encrypted_params.gemspec @@ -10,7 +10,7 @@ spec.email = ["support@cloversites.com"] spec.summary = "Provides a simple method to send and receive encrypted data." spec...
Add homepage and fix dependecy call
diff --git a/db/migrate/20160713130940_remove_type_template_and_vms_filters_from_miq_search.rb b/db/migrate/20160713130940_remove_type_template_and_vms_filters_from_miq_search.rb index abc1234..def5678 100644 --- a/db/migrate/20160713130940_remove_type_template_and_vms_filters_from_miq_search.rb +++ b/db/migrate/201607...
Create migration for removing Type / Template/VMs filters https://bugzilla.redhat.com/show_bug.cgi?id=1351210 Migration for removing Type / Template/VMs filters from MiqSearch to fix the bug because the filters were useless in VMS filters.
diff --git a/kernel/common/loadedfeatures.rb b/kernel/common/loadedfeatures.rb index abc1234..def5678 100644 --- a/kernel/common/loadedfeatures.rb +++ b/kernel/common/loadedfeatures.rb @@ -67,6 +67,14 @@ self end + def pop(*v) + Rubinius.synchronize(self) do + ret = super + identity_m...
Handle pop for loaded_features properly
diff --git a/frontend/test/controllers/artist_controller_test.rb b/frontend/test/controllers/artist_controller_test.rb index abc1234..def5678 100644 --- a/frontend/test/controllers/artist_controller_test.rb +++ b/frontend/test/controllers/artist_controller_test.rb @@ -4,8 +4,8 @@ test "list of artists" do get "i...
Use less frequently updated artist
diff --git a/features/steps/eventbrite_steps.rb b/features/steps/eventbrite_steps.rb index abc1234..def5678 100644 --- a/features/steps/eventbrite_steps.rb +++ b/features/steps/eventbrite_steps.rb @@ -11,4 +11,12 @@ # Poll eventbrite API for details # Find the relevant user and check the order type field pendin...
Add missing steps as pending 0:05
diff --git a/init.rb b/init.rb index abc1234..def5678 100644 --- a/init.rb +++ b/init.rb @@ -1,7 +1,7 @@ require_relative './lib/scraper.rb' require_relative './lib/parser.rb' -# years = (2002..2014) +years = (2005..2014) # years.each_with_index do |yr, i| # rush = Scraper.new('rushing', yr) # pass = Scraper....
Add code to run the Parser
diff --git a/lib/collect_user_photos.rb b/lib/collect_user_photos.rb index abc1234..def5678 100644 --- a/lib/collect_user_photos.rb +++ b/lib/collect_user_photos.rb @@ -17,12 +17,12 @@ current_photo_location = "#{Rails.root}/public/uploads/images/#{photo.image_filename}" new_photo_location = "#{album_d...
Use FileUtils for all file operations. Also uses Kernel.system to execute shell commands in a secure fashion.
diff --git a/config/initializers/ar_speed_up_migration_checking.rb b/config/initializers/ar_speed_up_migration_checking.rb index abc1234..def5678 100644 --- a/config/initializers/ar_speed_up_migration_checking.rb +++ b/config/initializers/ar_speed_up_migration_checking.rb @@ -10,7 +10,7 @@ # it reads + parses `...
Make `ActiveRecord::Migrator` idempotent again in test env
diff --git a/lib/diversity_dashboard.rb b/lib/diversity_dashboard.rb index abc1234..def5678 100644 --- a/lib/diversity_dashboard.rb +++ b/lib/diversity_dashboard.rb @@ -5,7 +5,7 @@ (load_metric 'diversity-gender')['value']['total'].each_pair do |gender, value| data << {label: gender, value: value} end -...
Sort legend on diversity pies alphabetically
diff --git a/lib/spinoza/calvin/node.rb b/lib/spinoza/calvin/node.rb index abc1234..def5678 100644 --- a/lib/spinoza/calvin/node.rb +++ b/lib/spinoza/calvin/node.rb @@ -14,6 +14,13 @@ @meta_log = meta_log @sequencer = sequencer || Calvin::Sequencer.new(node: self) @scheduler = scheduler || Calvin::Schedul...
Allow client-specified handling of results.
diff --git a/loadable_component.gemspec b/loadable_component.gemspec index abc1234..def5678 100644 --- a/loadable_component.gemspec +++ b/loadable_component.gemspec @@ -19,6 +19,6 @@ s.require_paths = ["lib"] # specify any dependencies here; for example: - # s.add_development_dependency "rspec" + s.add_develop...
Add rake as dev dependency.
diff --git a/app/models/georgia/concerns/contentable.rb b/app/models/georgia/concerns/contentable.rb index abc1234..def5678 100644 --- a/app/models/georgia/concerns/contentable.rb +++ b/app/models/georgia/concerns/contentable.rb @@ -14,11 +14,9 @@ @content ||= contents.select{|c| c.locale == I18n.locale.to_s}...
Add locale to the delegated method list
diff --git a/nanoc-core/spec/meta_spec.rb b/nanoc-core/spec/meta_spec.rb index abc1234..def5678 100644 --- a/nanoc-core/spec/meta_spec.rb +++ b/nanoc-core/spec/meta_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true describe 'meta', chdir: false do - example do + it 'is covered by specs' do regular_files =...
Add test to ensure Core does not log
diff --git a/script/imported_filesize_reporter.rb b/script/imported_filesize_reporter.rb index abc1234..def5678 100644 --- a/script/imported_filesize_reporter.rb +++ b/script/imported_filesize_reporter.rb @@ -3,8 +3,14 @@ include ActionView::Helpers::NumberHelper -total_attachment_size = AttachmentData.sum(:file_si...
Speed up counting by using a JOIN Note this will double count disk usage as it doesn't take into account the fact that attachments are re-attached to each subsequent edition.
diff --git a/app/views/products/who_bought.atom.builder b/app/views/products/who_bought.atom.builder index abc1234..def5678 100644 --- a/app/views/products/who_bought.atom.builder +++ b/app/views/products/who_bought.atom.builder @@ -0,0 +1,43 @@+atom_feed do |feed| + feed.title "Who bought #{@product.title}" + + fee...
Define an Atom view (using the Atom builder)
diff --git a/lib/discordrb/events/generic.rb b/lib/discordrb/events/generic.rb index abc1234..def5678 100644 --- a/lib/discordrb/events/generic.rb +++ b/lib/discordrb/events/generic.rb @@ -1,6 +1,15 @@ require 'discordrb/events/utility' +def not(object) + Negated.new(object) +end + module Discordrb::Events + class...
Add a class to represent negated objects for events
diff --git a/lib/gutentag/tag_validations.rb b/lib/gutentag/tag_validations.rb index abc1234..def5678 100644 --- a/lib/gutentag/tag_validations.rb +++ b/lib/gutentag/tag_validations.rb @@ -37,6 +37,11 @@ def add_length_validation? klass.table_exists? && limit.present? rescue *DATABASE_ERROR_CLASSES + warn ...
Add warning for missing validation if database isn't present.
diff --git a/lib/halfday/nginx/capistrano.rb b/lib/halfday/nginx/capistrano.rb index abc1234..def5678 100644 --- a/lib/halfday/nginx/capistrano.rb +++ b/lib/halfday/nginx/capistrano.rb @@ -10,7 +10,6 @@ conf = File.open(File.expand_path('../templates/app.conf', __FILE__)).read run "echo \"#{conf}\" >...
Remove old command to run for nginx
diff --git a/lib/mailsocio_rails/delivery.rb b/lib/mailsocio_rails/delivery.rb index abc1234..def5678 100644 --- a/lib/mailsocio_rails/delivery.rb +++ b/lib/mailsocio_rails/delivery.rb @@ -8,6 +8,8 @@ def deliver!(mail) addrs = addresses mail mail.to = settings[:mailsocio_recipient] + mail.cc = n...
Remove cc and bcc. Use bcc.
diff --git a/spec/lib/regexp_preview/multi_line_spec.rb b/spec/lib/regexp_preview/multi_line_spec.rb index abc1234..def5678 100644 --- a/spec/lib/regexp_preview/multi_line_spec.rb +++ b/spec/lib/regexp_preview/multi_line_spec.rb @@ -5,16 +5,16 @@ subject { RegexpPreview::MultiLine.new(File.expand_path("./spec/suppo...
Use more meaningful variable name tmp -> params
diff --git a/lib/multi_json/adapters/gson.rb b/lib/multi_json/adapters/gson.rb index abc1234..def5678 100644 --- a/lib/multi_json/adapters/gson.rb +++ b/lib/multi_json/adapters/gson.rb @@ -8,6 +8,7 @@ ParseError = ::Gson::DecodeError def load(string, options={}) + string = string.read if StringIO ...
Make Gson adapter explicitly read StringIO object
diff --git a/lib/rspec-rayo/tropo1/driver.rb b/lib/rspec-rayo/tropo1/driver.rb index abc1234..def5678 100644 --- a/lib/rspec-rayo/tropo1/driver.rb +++ b/lib/rspec-rayo/tropo1/driver.rb @@ -1,5 +1,6 @@ module RSpecRayo class Tropo1Driver + require 'drb' require 'net/http' require 'uri' require 'coun...
Allow a third party to stop and start Tropo1's DRb service
diff --git a/rack-dev-mark.gemspec b/rack-dev-mark.gemspec index abc1234..def5678 100644 --- a/rack-dev-mark.gemspec +++ b/rack-dev-mark.gemspec @@ -16,7 +16,7 @@ gem.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } gem.require_paths = ['lib'] - gem.required_ruby_version = ['>= 2.2'...
Remove upper limit for ruby It's not very useful but a hassle to update yearly.
diff --git a/lib/waves/utilities/customer.rb b/lib/waves/utilities/customer.rb index abc1234..def5678 100644 --- a/lib/waves/utilities/customer.rb +++ b/lib/waves/utilities/customer.rb @@ -21,7 +21,9 @@ :registration_number, :managing_owner, :correspondent, - :shares_held + :shares_held, +...
Add attributes to the Customer class
diff --git a/features/step_definitions/login_steps.rb b/features/step_definitions/login_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/login_steps.rb +++ b/features/step_definitions/login_steps.rb @@ -1,9 +1,10 @@ Given(/^I am logged in$/) do - ENV['PDS_HANDLE'] = 'PDS_HANDLE' + OmniAuth.confi...
Update the login step definitions for out new way to fake a login
diff --git a/Library/Formula/gist.rb b/Library/Formula/gist.rb index abc1234..def5678 100644 --- a/Library/Formula/gist.rb +++ b/Library/Formula/gist.rb @@ -3,7 +3,7 @@ class Gist < Formula url 'https://github.com/defunkt/gist/tarball/v2.0.3' homepage 'https://github.com/defunkt/gist' - md5 '5b9bfa8255e5f488b78a...
Fix MD5 sum for Gist Signed-off-by: Adam Vandenberg <34c2b6407fd5a10249a15d699d40f9ed1782e98c@gmail.com>
diff --git a/db/migrate/20111216163449_add_deleted_tweets_table.rb b/db/migrate/20111216163449_add_deleted_tweets_table.rb index abc1234..def5678 100644 --- a/db/migrate/20111216163449_add_deleted_tweets_table.rb +++ b/db/migrate/20111216163449_add_deleted_tweets_table.rb @@ -0,0 +1,10 @@+class AddDeletedTweetsTable < ...
Add migration for deleted tweets table.
diff --git a/db/migrate/20120307143553_create_ontology_versions.rb b/db/migrate/20120307143553_create_ontology_versions.rb index abc1234..def5678 100644 --- a/db/migrate/20120307143553_create_ontology_versions.rb +++ b/db/migrate/20120307143553_create_ontology_versions.rb @@ -4,6 +4,7 @@ t.references :user, :null...
Add reference to logic to ontology version
diff --git a/db/migrate/20181106135939_add_index_to_deployments.rb b/db/migrate/20181106135939_add_index_to_deployments.rb index abc1234..def5678 100644 --- a/db/migrate/20181106135939_add_index_to_deployments.rb +++ b/db/migrate/20181106135939_add_index_to_deployments.rb @@ -8,8 +8,6 @@ disable_ddl_transaction! ...
Revert add action follow up 2
diff --git a/app/controllers/spree/admin/product_imports_controller.rb b/app/controllers/spree/admin/product_imports_controller.rb index abc1234..def5678 100644 --- a/app/controllers/spree/admin/product_imports_controller.rb +++ b/app/controllers/spree/admin/product_imports_controller.rb @@ -1,10 +1,6 @@ module Spree ...
Remove extra comments, and use current_user instead of @current_user
diff --git a/base/lib/flow/actions/if_match.rb b/base/lib/flow/actions/if_match.rb index abc1234..def5678 100644 --- a/base/lib/flow/actions/if_match.rb +++ b/base/lib/flow/actions/if_match.rb @@ -1,4 +1,6 @@ class Flow::Action::IfMatch < Flow::Action + attr_reader :block_children + def setup_with_flow!(field, valu...
Add access to block_children of if/unless_match