diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/inputs/color_input.rb b/app/inputs/color_input.rb index abc1234..def5678 100644 --- a/app/inputs/color_input.rb +++ b/app/inputs/color_input.rb @@ -2,7 +2,7 @@ def input(wrapper_options) hex_code = object.try(attribute_name).presence || options.delete(:hex_code).presence || default_hex_code ...
Fix setting default hex color input
diff --git a/spec/plugin/models/rdb_board_spec.rb b/spec/plugin/models/rdb_board_spec.rb index abc1234..def5678 100644 --- a/spec/plugin/models/rdb_board_spec.rb +++ b/spec/plugin/models/rdb_board_spec.rb @@ -5,7 +5,6 @@ let(:board) do RdbBoard.create \ - context: Project.find(1), engine: Rdb::Task...
Fix spec due to removed context
diff --git a/lib/skroutz_api/paginated_collection.rb b/lib/skroutz_api/paginated_collection.rb index abc1234..def5678 100644 --- a/lib/skroutz_api/paginated_collection.rb +++ b/lib/skroutz_api/paginated_collection.rb @@ -26,7 +26,7 @@ end define_method "#{meth}_page" do |options = {}| - return [] if !se...
Return nil on methods trying to perform invalid pagination
diff --git a/lib/generators/angular/scaffold/scaffold_generator.rb b/lib/generators/angular/scaffold/scaffold_generator.rb index abc1234..def5678 100644 --- a/lib/generators/angular/scaffold/scaffold_generator.rb +++ b/lib/generators/angular/scaffold/scaffold_generator.rb @@ -14,9 +14,12 @@ controllers_path =...
Index and Form dialog box controllers are added to the scaffold generator.
diff --git a/lib/puppet-lint/plugins/duplicate_class_parameters.rb b/lib/puppet-lint/plugins/duplicate_class_parameters.rb index abc1234..def5678 100644 --- a/lib/puppet-lint/plugins/duplicate_class_parameters.rb +++ b/lib/puppet-lint/plugins/duplicate_class_parameters.rb @@ -6,7 +6,7 @@ level = 0 # if t...
Remove explicit return and replace with a next. Fixes `Non-local exit from iterator, without return value.`
diff --git a/app/controllers/expensesheets_controller.rb b/app/controllers/expensesheets_controller.rb index abc1234..def5678 100644 --- a/app/controllers/expensesheets_controller.rb +++ b/app/controllers/expensesheets_controller.rb @@ -30,10 +30,4 @@ end redirect_to user_path(session[:user_id]) end - - pr...
Remove unnecessary find user method
diff --git a/omniauth-vkontakte.gemspec b/omniauth-vkontakte.gemspec index abc1234..def5678 100644 --- a/omniauth-vkontakte.gemspec +++ b/omniauth-vkontakte.gemspec @@ -16,5 +16,5 @@ gem.require_paths = ['lib'] gem.version = OmniAuth::Vkontakte::VERSION - gem.add_runtime_dependency 'omniauth-oauth2', ['>=...
Update omniauth-oauth2 to version 1.7.0
diff --git a/features/support/silent_system.rb b/features/support/silent_system.rb index abc1234..def5678 100644 --- a/features/support/silent_system.rb +++ b/features/support/silent_system.rb @@ -1,4 +1,4 @@ def silent_system(cmd) - silent_cmd = cmd + " 2>&1 > /dev/null" + silent_cmd = cmd + " > /dev/null 2>&1" s...
Reorder shell direction so 2 is actually appended to 1
diff --git a/debian/ruby-tests.rake b/debian/ruby-tests.rake index abc1234..def5678 100644 --- a/debian/ruby-tests.rake +++ b/debian/ruby-tests.rake @@ -1,3 +1,4 @@+ENV['HOME'] = '/tmp' require 'gem2deb/rake/spectask' Gem2Deb::Rake::RSpecTask.new do |spec| spec.pattern = './spec/**/*_spec.rb'
Fix executing tests.rake: set /home/uwabami as /tmp during test Signed-off-by: Youhei SASAKI <71d846e864222823256d2e7aa2ef5b2fc53b38e3@gfd-dennou.org>
diff --git a/test/rails_app/app/models/business.rb b/test/rails_app/app/models/business.rb index abc1234..def5678 100644 --- a/test/rails_app/app/models/business.rb +++ b/test/rails_app/app/models/business.rb @@ -16,7 +16,7 @@ operating_days 0..6 date_established :datetime next_sale (Time.now + 1...
Make all hashes 1.8 compatible
diff --git a/hanami-bootstrap.gemspec b/hanami-bootstrap.gemspec index abc1234..def5678 100644 --- a/hanami-bootstrap.gemspec +++ b/hanami-bootstrap.gemspec @@ -19,7 +19,7 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ["lib"] - spec.add_dependency "hanami-asset...
Update hanami dep to 1.0.0.beta1
diff --git a/app/uploader/jenkins.rb b/app/uploader/jenkins.rb index abc1234..def5678 100644 --- a/app/uploader/jenkins.rb +++ b/app/uploader/jenkins.rb @@ -4,8 +4,11 @@ def upload dsym_path url = URI.parse(URI.encode(@job_build_url.strip)) - url.query = "" if url.query.nil? - url.query << "delay...
Fix query params with token
diff --git a/examples/any_gradient.rb b/examples/any_gradient.rb index abc1234..def5678 100644 --- a/examples/any_gradient.rb +++ b/examples/any_gradient.rb @@ -0,0 +1,60 @@+require 'roda' +require 'calyx' + +class AnyGradient < Calyx::Grammar + html '<body style="margin:0; padding:0">{svg}</body>' + xml '<?xml versi...
Add example SVG generator with different output options
diff --git a/lib/autocompleteable.rb b/lib/autocompleteable.rb index abc1234..def5678 100644 --- a/lib/autocompleteable.rb +++ b/lib/autocompleteable.rb @@ -4,8 +4,8 @@ class UnconfiguredException < Exception; end included do - after_create :add_to_autocomplete_cache after_destroy :remove_from_autocompl...
Update autocomplete cache on record change.
diff --git a/xtap.gemspec b/xtap.gemspec index abc1234..def5678 100644 --- a/xtap.gemspec +++ b/xtap.gemspec @@ -18,5 +18,6 @@ spec.require_paths = ['lib'] spec.add_development_dependency 'bundler', '~> 1.7' - spec.add_development_dependency 'rake', '~> 10.0' + spec.add_development_dependency 'rake', '~> 10...
Add rspec gem to dependencies and reformat file.
diff --git a/db/migrate/20200728210143_adjust_grade_change_tables_for_override_grades.partitions.rb b/db/migrate/20200728210143_adjust_grade_change_tables_for_override_grades.partitions.rb index abc1234..def5678 100644 --- a/db/migrate/20200728210143_adjust_grade_change_tables_for_override_grades.partitions.rb +++ b/db...
Update grade change tables for override grades flag=none closes EVAL-1065 Test plan: - "up" migration: - Ensure migrations run properly - After the migration finishes, check that the assignment_id, submission_id and submission_version_number columns in the auditor_grade_change_records_* tables do *not* ha...
diff --git a/ibge.gemspec b/ibge.gemspec index abc1234..def5678 100644 --- a/ibge.gemspec +++ b/ibge.gemspec @@ -20,6 +20,6 @@ spec.add_dependency "spreadsheet", "~> 1.0" - spec.add_development_dependency "rake", "~> 10.0" + spec.add_development_dependency "rake", "~> 12.3" spec.add_development_dependency "r...
Update rake requirement from ~> 10.0 to ~> 12.3 Updates the requirements on [rake](https://github.com/ruby/rake) to permit the latest version. - [Release notes](https://github.com/ruby/rake/releases) - [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc) - [Commits](https://github.com/ruby/rake/commits/v...
diff --git a/ConfigKit.podspec b/ConfigKit.podspec index abc1234..def5678 100644 --- a/ConfigKit.podspec +++ b/ConfigKit.podspec @@ -3,7 +3,7 @@ Pod::Spec.new do |s| s.name = 'ConfigKit' - s.version = '1.2.5' + s.version = '1.2.6' s.summary = 'Configuration toolkit.' s.description = <<-DESC
Modify : pod spec version
diff --git a/lib/doorkeeper/orm/neo4j/access_grant.rb b/lib/doorkeeper/orm/neo4j/access_grant.rb index abc1234..def5678 100644 --- a/lib/doorkeeper/orm/neo4j/access_grant.rb +++ b/lib/doorkeeper/orm/neo4j/access_grant.rb @@ -1,5 +1,5 @@-require 'doorkeeper/orm/mongoid5/concerns/scopes' -require 'doorkeeper-mongodb/comp...
Remove left over mongoid reference.
diff --git a/lib/girffi/ibaseinfo.rb b/lib/girffi/ibaseinfo.rb index abc1234..def5678 100644 --- a/lib/girffi/ibaseinfo.rb +++ b/lib/girffi/ibaseinfo.rb @@ -1,7 +1,11 @@+require 'girffi/class_base' + module GirFFI # Wraps GIBaseInfo struct, the base \type for all info types. # Decendant types will be implemented...
Use ClassBase to provide initialize and to_ptr.
diff --git a/spec/unit/generators/install_generator_spec.rb b/spec/unit/generators/install_generator_spec.rb index abc1234..def5678 100644 --- a/spec/unit/generators/install_generator_spec.rb +++ b/spec/unit/generators/install_generator_spec.rb @@ -1,6 +1,6 @@ # encoding: utf-8 -require 'spec_helper' +require 'fileut...
Change to clean up files
diff --git a/config.rb b/config.rb index abc1234..def5678 100644 --- a/config.rb +++ b/config.rb @@ -1,5 +1,13 @@+activate :deploy do |deploy| + deploy.method = :git + deploy.build_before = true +end + # Automatic image dimensions on image_tag helper activate :automatic_image_sizes + +# pretty URLs +activate :d...
Add a deploy method and pretty URLs
diff --git a/Funtestic.gemspec b/Funtestic.gemspec index abc1234..def5678 100644 --- a/Funtestic.gemspec +++ b/Funtestic.gemspec @@ -18,6 +18,19 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_development_dependency "bundler", "~> 1.3" - spec.add_deve...
Add runtime dependencies missing for the gem
diff --git a/cookbooks/nagios/recipes/client_package.rb b/cookbooks/nagios/recipes/client_package.rb index abc1234..def5678 100644 --- a/cookbooks/nagios/recipes/client_package.rb +++ b/cookbooks/nagios/recipes/client_package.rb @@ -18,11 +18,21 @@ # limitations under the License. # -%w{ - nagios-nrpe-server - nag...
Add support for install NRPE via package on CentOS and similar systems Former-commit-id: 2f1bb3bc6475fa16b61a921e0898e18ec515ac40 [formerly 46a219961f40fe59231d731019375814a9c4b867] [formerly 1cedf1c9e07e1703ebb42f7a53e59f990ace7533 [formerly 4101cb57c11083d9a5b5f4f85223d7febb608b2c [formerly 0ce0555029846c77b64dba61...
diff --git a/glow.gemspec b/glow.gemspec index abc1234..def5678 100644 --- a/glow.gemspec +++ b/glow.gemspec @@ -16,7 +16,7 @@ Handles Flash messages in Javascript for Rails xhr-responses. Fires a dom event when flash messages are present. DESC - s.files = Dir["{app,config,db,lib}/**/*"] + ["MIT-LICENSE", "Ra...
Add vendor dir to gemspec files list
diff --git a/grim.gemspec b/grim.gemspec index abc1234..def5678 100644 --- a/grim.gemspec +++ b/grim.gemspec @@ -7,7 +7,7 @@ s.version = Grim::VERSION s.authors = ["Jonathan Hoyt"] s.email = ["jonmagic@gmail.com"] - s.homepage = "" + s.homepage = "http://github.com/jonmagic/grim" s.summ...
Set homepage to github page.
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -13,5 +13,5 @@ require File.expand_path('lib/mem_model') Dir[File.expand_path('../support/*.rb', __FILE__)].each { |file| require file } -gem 'minitest', '5.2.0' +require 'minitest' require 'minit...
Use require (not gem) for minitest
diff --git a/JSONModel.podspec b/JSONModel.podspec index abc1234..def5678 100644 --- a/JSONModel.podspec +++ b/JSONModel.podspec @@ -11,6 +11,7 @@ s.ios.deployment_target = '5.0' s.osx.deployment_target = '10.7' + s.watchos.deployment_target = '2.0' s.source_files = 'JSONModel/**/*.{m,h}' s.public_heade...
Add deployment target to support watchOS 2
diff --git a/test/models/user_test.rb b/test/models/user_test.rb index abc1234..def5678 100644 --- a/test/models/user_test.rb +++ b/test/models/user_test.rb @@ -18,4 +18,9 @@ @user.email = ' ' assert_not @user.valid? end + + test 'name should not be too long' do + @user.name = "a" * 51 + assert_not @...
Add test case for user name length
diff --git a/lib/mocha/integration/test_unit/gem_version_230_to_231.rb b/lib/mocha/integration/test_unit/gem_version_230_to_231.rb index abc1234..def5678 100644 --- a/lib/mocha/integration/test_unit/gem_version_230_to_231.rb +++ b/lib/mocha/integration/test_unit/gem_version_230_to_231.rb @@ -10,7 +10,7 @@ modul...
Debug message had the wrong test-unit version numbers.
diff --git a/app/controllers/choose_a_country_controller.rb b/app/controllers/choose_a_country_controller.rb index abc1234..def5678 100644 --- a/app/controllers/choose_a_country_controller.rb +++ b/app/controllers/choose_a_country_controller.rb @@ -8,7 +8,6 @@ def choose_a_country restart_journey if identity_pro...
Revert "EID-1774 Implement eIDAS escape route (exploration)"
diff --git a/app/controllers/gend_image_pages_controller.rb b/app/controllers/gend_image_pages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/gend_image_pages_controller.rb +++ b/app/controllers/gend_image_pages_controller.rb @@ -5,7 +5,7 @@ include GendImagesHelper def show - @gend_image =...
Use active scope instead of dynamic finder.
diff --git a/release/package/linux/rpm.rb b/release/package/linux/rpm.rb index abc1234..def5678 100644 --- a/release/package/linux/rpm.rb +++ b/release/package/linux/rpm.rb @@ -26,6 +26,7 @@ --after-install "release/debian-after-install.sh" \ -d "p7zip" \ -d "desktop-file-utils" \ + -d "libXScr...
:penguin: Add missing fedora dependency libXScrnSaver
diff --git a/lib/resource_kit/action_invoker.rb b/lib/resource_kit/action_invoker.rb index abc1234..def5678 100644 --- a/lib/resource_kit/action_invoker.rb +++ b/lib/resource_kit/action_invoker.rb @@ -46,7 +46,7 @@ def append_hooks(hook_type, request) (action.hooks[hook_type] || []).each do |hook| - ...
Use instance exec instead of call on hook procs.
diff --git a/capi/recipes/vim_luan.rb b/capi/recipes/vim_luan.rb index abc1234..def5678 100644 --- a/capi/recipes/vim_luan.rb +++ b/capi/recipes/vim_luan.rb @@ -17,7 +17,7 @@ owner node['sprout']['user'] end -execute './install --non-interactive' do +execute './update --non-interactive' do cwd dotvim user no...
Update vim plugins when installing luan's vim * luan claims this won't break initial installations, so we will trust him Signed-off-by: Dan Wendorf <aacfaec681ee5d2ca2a22f1deac31c830d964d35@pivotal.io>
diff --git a/icloud.rb b/icloud.rb index abc1234..def5678 100644 --- a/icloud.rb +++ b/icloud.rb @@ -1,9 +1,11 @@ require './lib/ruby-icloud' +require 'io/console' require 'pry' def get_password prompt="Password: [typing will be hidden]" - `read -s -p "#{prompt}" password; echo $password`.chomp + puts prompt +...
Replace system call for password with ruby
diff --git a/features/step_definitions/fetching_steps.rb b/features/step_definitions/fetching_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/fetching_steps.rb +++ b/features/step_definitions/fetching_steps.rb @@ -1,5 +1,5 @@ Before do - %w(Repo User).each do |attr| + %w(Repo User Organization)...
Clean up all models in cucumber tests.
diff --git a/features/step_definitions/my_first_steps.rb b/features/step_definitions/my_first_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/my_first_steps.rb +++ b/features/step_definitions/my_first_steps.rb @@ -1,7 +1,7 @@ Given /^I am on the Welcome Screen$/ do wait_for(:timeout => 5) { e...
Check first movie under Top Box
diff --git a/spec/support/fluent_logger_helper.rb b/spec/support/fluent_logger_helper.rb index abc1234..def5678 100644 --- a/spec/support/fluent_logger_helper.rb +++ b/spec/support/fluent_logger_helper.rb @@ -1,6 +1,6 @@ module FluentLoggerHelper def logger - Fluent::Logger.class_variable_get(:@@default_logger) +...
Access the default logger simply
diff --git a/lib/bindi.rb b/lib/bindi.rb index abc1234..def5678 100644 --- a/lib/bindi.rb +++ b/lib/bindi.rb @@ -2,7 +2,7 @@ require 'bindi/version' class Bindi - def initialize serializer + def initialize serializer = Marhsal @serializer = serializer end @@ -55,4 +55,4 @@ def keys Ohm.redis.key...
Set default serializer to Marshal.
diff --git a/lib/bindi.rb b/lib/bindi.rb index abc1234..def5678 100644 --- a/lib/bindi.rb +++ b/lib/bindi.rb @@ -45,6 +45,6 @@ alias has_key key? def keys - @redis.keys.map &:to_sym + @redis.keys end end
Stop mapping keys to Symbols.
diff --git a/refinerycms-tweets.gemspec b/refinerycms-tweets.gemspec index abc1234..def5678 100644 --- a/refinerycms-tweets.gemspec +++ b/refinerycms-tweets.gemspec @@ -18,6 +18,6 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_dependency 'refinerycms-...
Update gemspec to refinerycms 3.0
diff --git a/rubyzome/load_local_app.rb b/rubyzome/load_local_app.rb index abc1234..def5678 100644 --- a/rubyzome/load_local_app.rb +++ b/rubyzome/load_local_app.rb @@ -14,8 +14,8 @@ $views['/'+typename+'/'+viewname]=Kernel.const_get(viewname) end + DataMapper.setup(:default,$db_url) # Includ...
Update to be Datamapper 1.0 compatible
diff --git a/lib/jazzy.rb b/lib/jazzy.rb index abc1234..def5678 100644 --- a/lib/jazzy.rb +++ b/lib/jazzy.rb @@ -1,2 +1,4 @@ require 'jazzy/config' require 'jazzy/doc_builder' + +Encoding.default_external = 'UTF-8'
Set the default encoding to UTF-8. After making myself a little shell script to run on build of a scheme in Xcode, it would always fail on me, even though running it from the terminal worked fine. Setting the default encoding to UTF-8 seems to fix this issue. Reference: https://github.com/berkshelf/berkshelf-api/issu...
diff --git a/lib/uspec.rb b/lib/uspec.rb index abc1234..def5678 100644 --- a/lib/uspec.rb +++ b/lib/uspec.rb @@ -16,7 +16,7 @@ at_exit do failures = Uspec::Stats.exit_code status = $!.respond_to?(:status) ? $!.status : 0 - errors = ($! && $!.cause == nil) ? 0 : 1 + errors = $!.respond_to?(:cause) && $!.cause ? ...
Exit with 0 if there are no errors.
diff --git a/templates/spec/support/database_cleaner.rb b/templates/spec/support/database_cleaner.rb index abc1234..def5678 100644 --- a/templates/spec/support/database_cleaner.rb +++ b/templates/spec/support/database_cleaner.rb @@ -1,2 +1,14 @@-require 'capybara/rails' -require 'capybara/rspec' +RSpec.configure do |co...
Fix database cleaner support for RSpec
diff --git a/installers/unix/Dockerfile.builder b/installers/unix/Dockerfile.builder index abc1234..def5678 100644 --- a/installers/unix/Dockerfile.builder +++ b/installers/unix/Dockerfile.builder @@ -7,8 +7,8 @@ yum -y groupinstall 'Development Tools' && \ yum -y install centos-release-scl epel-release && \ ...
Install rh-python27 in Docker but do not set envs
diff --git a/test/test_slugizer.rb b/test/test_slugizer.rb index abc1234..def5678 100644 --- a/test/test_slugizer.rb +++ b/test/test_slugizer.rb @@ -10,6 +10,11 @@ should "generate the slug" do @blogpost.slug.should =~ /\w+-blog-post-title/ + end + + should "not generate the slug if the slug key is b...
Test to ensure that slugs aren't generated when slug_key values are blank
diff --git a/lib/googlemaps/services/global_constants.rb b/lib/googlemaps/services/global_constants.rb index abc1234..def5678 100644 --- a/lib/googlemaps/services/global_constants.rb +++ b/lib/googlemaps/services/global_constants.rb @@ -0,0 +1,34 @@+# coding: utf-8 +require 'googlemaps/services/version' + +# Global con...
:sparkles: Add global constants used across the library
diff --git a/lib/mountable_processing_server/endpoint.rb b/lib/mountable_processing_server/endpoint.rb index abc1234..def5678 100644 --- a/lib/mountable_processing_server/endpoint.rb +++ b/lib/mountable_processing_server/endpoint.rb @@ -17,7 +17,8 @@ image = MiniMagick::Image.open @source_directory + original ...
Disable coalesce of GIFs for the time being
diff --git a/lib/torque/postgresql/attributes/builder.rb b/lib/torque/postgresql/attributes/builder.rb index abc1234..def5678 100644 --- a/lib/torque/postgresql/attributes/builder.rb +++ b/lib/torque/postgresql/attributes/builder.rb @@ -9,8 +9,7 @@ module Builder def self.include_on(klass, method_name, b...
Use table_exists? directly instead of going through connection
diff --git a/tools/load_testing.rb b/tools/load_testing.rb index abc1234..def5678 100644 --- a/tools/load_testing.rb +++ b/tools/load_testing.rb @@ -0,0 +1,52 @@+require 'json' +require 'httparty' +require 'thread/pool' +require 'awesome_print' + +target = 'http://146.185.153.218' + +i = 0 +hit_count = 0 +error_count =...
Add dirty load testing script
diff --git a/app/models/asset_type.rb b/app/models/asset_type.rb index abc1234..def5678 100644 --- a/app/models/asset_type.rb +++ b/app/models/asset_type.rb @@ -1,7 +1,12 @@ class AssetType < ActiveRecord::Base # associations + + # every asset type has 0 or more sub types has_many :asset_subtypes + +...
Add manufacturer list to asset types
diff --git a/app/models/collection.rb b/app/models/collection.rb index abc1234..def5678 100644 --- a/app/models/collection.rb +++ b/app/models/collection.rb @@ -8,4 +8,8 @@ # override the default Hydra properties so we don't get a prefix deprecation warning. has_metadata "properties", type: Worthwhile::PropertiesD...
Decrease the solr_page_size to 150 from the default 200
diff --git a/poke.rb b/poke.rb index abc1234..def5678 100644 --- a/poke.rb +++ b/poke.rb @@ -1,6 +1,5 @@ require 'gosu' -require './lib/player.rb' -require './lib/window.rb' +Dir['./lib/*.rb'].each { |file| require file } window = GameWindow.new window.show
Use iteration to require each file in lib/
diff --git a/lib/jeeyo.rb b/lib/jeeyo.rb index abc1234..def5678 100644 --- a/lib/jeeyo.rb +++ b/lib/jeeyo.rb @@ -5,5 +5,6 @@ autoload :Location, "jeeyo/location" EARTH_KILOMETERS_PER_RADIAN = Unit.new("6367.5 km/rad") + EARTH_RADIANS_PER_KILOMETER = EARTH_KILOMETERS_PER_RADIAN.inverse end
Add inverse constant: rad/km for the earth
diff --git a/lib/sower.rb b/lib/sower.rb index abc1234..def5678 100644 --- a/lib/sower.rb +++ b/lib/sower.rb @@ -1,20 +1,34 @@-#%w{activerecord activesupport activemodel arel builder i18n tzinfo}.each do |lib| -# path = File.expand_path("../vendor/#{lib}/lib",__FILE__) -# $:.unshift(path) -#end -#require 'rubygems' -...
Use vendor libraries and add core extensions
diff --git a/lib/anvil.rb b/lib/anvil.rb index abc1234..def5678 100644 --- a/lib/anvil.rb +++ b/lib/anvil.rb @@ -1,6 +1,7 @@ # encoding: UTF-8 require 'anvil/version' +require 'active_support' require 'active_support/core_ext' # Main anvil module
Load active_support before any other active_support file. This loads activesupport/dependencies/autoload.rb.
diff --git a/test/integration/charge_flow_test.rb b/test/integration/charge_flow_test.rb index abc1234..def5678 100644 --- a/test/integration/charge_flow_test.rb +++ b/test/integration/charge_flow_test.rb @@ -20,5 +20,8 @@ get '/round_status/' + @round.url @response_json = JSON.parse(@response.body) asser...
Test payment form not displayed on round status GET
diff --git a/lib/code_climate_check/get_gpa.rb b/lib/code_climate_check/get_gpa.rb index abc1234..def5678 100644 --- a/lib/code_climate_check/get_gpa.rb +++ b/lib/code_climate_check/get_gpa.rb @@ -32,6 +32,7 @@ else puts 'HTTP request have been failed' null_response + exit(0) end ...
Add exiting when HTTP request is not success
diff --git a/loaf.gemspec b/loaf.gemspec index abc1234..def5678 100644 --- a/loaf.gemspec +++ b/loaf.gemspec @@ -13,8 +13,6 @@ spec.description = %q{Loaf manages and displays breadcrumb trails in your Rails app. It aims to handle breadcrumb data through easy dsl and expose it through view helpers without any assumpti...
Change to stop loading test and executable files
diff --git a/lib/erector/rails/form_builder.rb b/lib/erector/rails/form_builder.rb index abc1234..def5678 100644 --- a/lib/erector/rails/form_builder.rb +++ b/lib/erector/rails/form_builder.rb @@ -13,9 +13,9 @@ attr_reader :parent, :template - def initialize(object_name, object, template, options, proc) ...
Fix FormBuilder for Rails 4.1+ Block parameter for FormBuilder was removed in https://github.com/rails/rails/commit/38aafc037705aab2f09ec924bf634d105002e016
diff --git a/lib/http_client/jruby/response.rb b/lib/http_client/jruby/response.rb index abc1234..def5678 100644 --- a/lib/http_client/jruby/response.rb +++ b/lib/http_client/jruby/response.rb @@ -42,7 +42,7 @@ end def each - @native_response.get_all_headers.each do |h| + @native_response.heade...
Switch to the iterator object to be more Java-ninny.
diff --git a/lib/juici/helpers/form_helpers.rb b/lib/juici/helpers/form_helpers.rb index abc1234..def5678 100644 --- a/lib/juici/helpers/form_helpers.rb +++ b/lib/juici/helpers/form_helpers.rb @@ -1,6 +1,6 @@ def form_at(route, fields, opts={}) form = "" - form << %Q{<form class="well" action="#{route}" method="pos...
Remove well class from forms
diff --git a/spec/classes/bitlbee_spec.rb b/spec/classes/bitlbee_spec.rb index abc1234..def5678 100644 --- a/spec/classes/bitlbee_spec.rb +++ b/spec/classes/bitlbee_spec.rb @@ -11,7 +11,7 @@ it { should include_class('bitlbee::config') } it { should contain_package('bitlbee').with_provider('homebrew') } it { sh...
Add helpful message for port spec.
diff --git a/spec/classes/openssl_spec.rb b/spec/classes/openssl_spec.rb index abc1234..def5678 100644 --- a/spec/classes/openssl_spec.rb +++ b/spec/classes/openssl_spec.rb @@ -1,37 +1,35 @@ require 'spec_helper' describe 'openssl' do - on_puppet_supported_platforms.each do |version, platforms| - platforms.each ...
Use rspec-puppet-facts instead of puppet_facts for unit tests
diff --git a/spec/debian/hostname_spec.rb b/spec/debian/hostname_spec.rb index abc1234..def5678 100644 --- a/spec/debian/hostname_spec.rb +++ b/spec/debian/hostname_spec.rb @@ -4,3 +4,9 @@ describe command('hostname') do it { should_not return_stdout 'debian-7-blank' } end + +# Hostname should retunr the UUID +uuid...
Test to ensure the hostname is set to the uuid of the VM
diff --git a/spec/rdayone/journal_spec.rb b/spec/rdayone/journal_spec.rb index abc1234..def5678 100644 --- a/spec/rdayone/journal_spec.rb +++ b/spec/rdayone/journal_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' describe Rdayone::Journal do - describe "loading" do + context "loading" do let(:finder) do ...
Tidy up spec a bit
diff --git a/json_presentable.gemspec b/json_presentable.gemspec index abc1234..def5678 100644 --- a/json_presentable.gemspec +++ b/json_presentable.gemspec @@ -11,7 +11,8 @@ s.email = ["johnonrails@gmail.com"] s.homepage = "http://github.com/johnnylaw/json_presentable" s.summary = "For presenting ...
Add description and license to gemspec
diff --git a/lib/godot.rb b/lib/godot.rb index abc1234..def5678 100644 --- a/lib/godot.rb +++ b/lib/godot.rb @@ -42,7 +42,7 @@ Timeout.timeout(interval) do socket = TCPSocket.open(host, port) end - rescue Errno::ECONNREFUSED, Errno::ETIMEDOUT, Timeout::Error, Errno::EHOSTUNREACH...
Add EHOSTDOWN to rescuable errors
diff --git a/lib/moltin/resource_collection.rb b/lib/moltin/resource_collection.rb index abc1234..def5678 100644 --- a/lib/moltin/resource_collection.rb +++ b/lib/moltin/resource_collection.rb @@ -3,6 +3,7 @@ @resources = [] def initialize(resource_class, data) + data ||= {} @resources = data.map...
Allow .first on resource collection
diff --git a/lib/omniauth/strategies/radius.rb b/lib/omniauth/strategies/radius.rb index abc1234..def5678 100644 --- a/lib/omniauth/strategies/radius.rb +++ b/lib/omniauth/strategies/radius.rb @@ -23,7 +23,7 @@ uid { raw_info['id'] } info do - raw_info["attributes"].slice *%w{ + raw_info["i...
Use the 'info' key from the `auth_hash` Migrating from the `attributes` key to `info` since this is the conical key we want to use going forward.
diff --git a/default_options.gemspec b/default_options.gemspec index abc1234..def5678 100644 --- a/default_options.gemspec +++ b/default_options.gemspec @@ -8,8 +8,8 @@ spec.version = DefaultOptions::VERSION spec.authors = ["John Mertens"] spec.email = ["john@versahq.com"] - spec.summary ...
Add a description to the gemspec.
diff --git a/lib/tasks/search-term-report.rake b/lib/tasks/search-term-report.rake index abc1234..def5678 100644 --- a/lib/tasks/search-term-report.rake +++ b/lib/tasks/search-term-report.rake @@ -0,0 +1,11 @@+namespace :report do + desc "Run a publication delay report of the last week" + task publication_delay_repor...
Clone report.rake for generic searches Use report.rake as a basis to create a task to run new generic term finder
diff --git a/iis/recipes/install.rb b/iis/recipes/install.rb index abc1234..def5678 100644 --- a/iis/recipes/install.rb +++ b/iis/recipes/install.rb @@ -1,5 +1,38 @@ powershell_script 'Install IIS' do - code 'Add-WindowsFeature Web-Server' + code <<- EOH + Add-WindowsFeature Web-Server, + Web-WebServer, + Web-Co...
Add additional IIS-related Windows features
diff --git a/lib/ephemeral/app/api.rb b/lib/ephemeral/app/api.rb index abc1234..def5678 100644 --- a/lib/ephemeral/app/api.rb +++ b/lib/ephemeral/app/api.rb @@ -4,6 +4,9 @@ require_relative '../models/build.rb' require_relative '../entities/build.rb' require_relative './resources/build.rb' +require_relative '../model...
Add require statements for file
diff --git a/lib/janky/notifier/chat_service.rb b/lib/janky/notifier/chat_service.rb index abc1234..def5678 100644 --- a/lib/janky/notifier/chat_service.rb +++ b/lib/janky/notifier/chat_service.rb @@ -2,14 +2,14 @@ module Notifier class ChatService def self.completed(build) - status = build.green? ...
Make chat service notifier send better success and failure messages.
diff --git a/lib/attr_secure.rb b/lib/attr_secure.rb index abc1234..def5678 100644 --- a/lib/attr_secure.rb +++ b/lib/attr_secure.rb @@ -15,8 +15,8 @@ # The order in this list matters, as only the first valid adapter will be used # ADAPTERS = [ + AttrSecure::Adapters::ActiveRecord, AttrSecure::Adapters:...
Revert "Prioritise Sequel over AR" This reverts commit af9777e1f29f7adaba94cd836aecf9679bd421e1.
diff --git a/wateringServer/spec/controllers/plants_controller_spec.rb b/wateringServer/spec/controllers/plants_controller_spec.rb index abc1234..def5678 100644 --- a/wateringServer/spec/controllers/plants_controller_spec.rb +++ b/wateringServer/spec/controllers/plants_controller_spec.rb @@ -38,4 +38,16 @@ expe...
Add test to show route for plants
diff --git a/lib/commit_hook.rb b/lib/commit_hook.rb index abc1234..def5678 100644 --- a/lib/commit_hook.rb +++ b/lib/commit_hook.rb @@ -18,11 +18,12 @@ diff2html = DiffToHtml.new diff2html.diff_between_revisions rev1, rev2, prefix, ref_name + branch_name = (ref_name =~ /master$/i) ? "" : "[#{ref_name.spl...
Include the branch name in the subject
diff --git a/test/test_verbs.rb b/test/test_verbs.rb index abc1234..def5678 100644 --- a/test/test_verbs.rb +++ b/test/test_verbs.rb @@ -3,6 +3,10 @@ class TestVerbs < Test::Unit::TestCase def test_copular_conjugation assert_equal :am, Verbs::Conjugator.conjugate(:be, :tense => :present, :person => :first, :plu...
Test present forms of the copular verb
diff --git a/lib/core/player.rb b/lib/core/player.rb index abc1234..def5678 100644 --- a/lib/core/player.rb +++ b/lib/core/player.rb @@ -11,9 +11,11 @@ # Increments the score of the player relative to the number of lines he just cleared and his current combo def increment_score(lines) - @combo += 1 - ...
Add check to prevent incrementing score with no line
diff --git a/git-scripts.gemspec b/git-scripts.gemspec index abc1234..def5678 100644 --- a/git-scripts.gemspec +++ b/git-scripts.gemspec @@ -10,7 +10,7 @@ s.email = ['daniel@ifixit.com', 'james@ifixit.com', 'tim@ifixit.com', 'robin@ifixit.com'] s.add_dependency 'bundler' - s.add_dependency 'octokit', '~> 3.0...
Update the octokit version to 4.0.0
diff --git a/test/wduck_test.rb b/test/wduck_test.rb index abc1234..def5678 100644 --- a/test/wduck_test.rb +++ b/test/wduck_test.rb @@ -0,0 +1,20 @@+require_relative 'test_helper' + +describe WDuck::Duck do + + subject { WDuck::Duck.new("linux") } + describe "function result that gets called for duck" do + it "sh...
Write sample test cases replace unit with minitest
diff --git a/lib/mnemosyne/version.rb b/lib/mnemosyne/version.rb index abc1234..def5678 100644 --- a/lib/mnemosyne/version.rb +++ b/lib/mnemosyne/version.rb @@ -7,7 +7,7 @@ PATCH = 0 STAGE = nil - STRING = [MAJOR, MINOR, PATCH, STAGE].reject(&:nil?).join('.') + STRING = [MAJOR, MINOR, PATCH, STAGE].com...
chore: Use compact instead of reject(&:nil?) Available in all supported rubys. Deteced by latest rubocop.
diff --git a/lib/macro.rb b/lib/macro.rb index abc1234..def5678 100644 --- a/lib/macro.rb +++ b/lib/macro.rb @@ -36,8 +36,8 @@ caption ||= "" template = %Q{ +%h5=caption %table.table.table-striped.table-bordered - %caption=caption %tr - headers.each do |header| %th=header.to_s
Use a h5 for table captions
diff --git a/test/functional/admin/get_involved_controller_test.rb b/test/functional/admin/get_involved_controller_test.rb index abc1234..def5678 100644 --- a/test/functional/admin/get_involved_controller_test.rb +++ b/test/functional/admin/get_involved_controller_test.rb @@ -0,0 +1,16 @@+require "test_helper" + +class...
Add test for Get Involved admin page There is currently no test that loads the admin page for Get Involved. This meant that an error in loading the page (e.g. by breaking a route helper) would not be noticed by running the test suite. I'm not exactly sure what this page is meant to do, other than provide some links ...
diff --git a/lib/micro_q/dsl.rb b/lib/micro_q/dsl.rb index abc1234..def5678 100644 --- a/lib/micro_q/dsl.rb +++ b/lib/micro_q/dsl.rb @@ -1,4 +1,20 @@ module MicroQ + ## + # Convenience methods for calling methods asynchronously + # Adds async_perform by default + # + # Usage + # class MyWorker + # worker :upda...
Add Docs for the new DSL.
diff --git a/spec/flipper/redis_spec.rb b/spec/flipper/redis_spec.rb index abc1234..def5678 100644 --- a/spec/flipper/redis_spec.rb +++ b/spec/flipper/redis_spec.rb @@ -5,7 +5,7 @@ describe Flipper::Adapters::Redis do let(:client) { Redis.new } - subject { Flipper::Adapters::Redis.new(client) } + subject { descr...
Use the described class for subject.
diff --git a/octo.gemspec b/octo.gemspec index abc1234..def5678 100644 --- a/octo.gemspec +++ b/octo.gemspec @@ -2,7 +2,7 @@ s.name = 'octo' s.summary = 'Run commands in parallel on multiple hosts' s.description = 'A lightweight script that allows you to run commands in parallel on multiple hosts'...
Remove code from sample gli app
diff --git a/ojwt.podspec b/ojwt.podspec index abc1234..def5678 100644 --- a/ojwt.podspec +++ b/ojwt.podspec @@ -21,7 +21,7 @@ s.requires_arc = true - s.source_files = "OJWT/OJ*{.m,.h}" + s.source_files = "OJWT/*OJ*{.m,.h}" s.public_header_files = "OJWT/*.h" end
Update pod spec to reflect categories
diff --git a/lib/tasks/add_admin.rake b/lib/tasks/add_admin.rake index abc1234..def5678 100644 --- a/lib/tasks/add_admin.rake +++ b/lib/tasks/add_admin.rake @@ -1,14 +1,12 @@-# encoding: utf-8 -namespace :add do - desc "通过邮箱地址给一个用户赋予管理员权限" - task :admin => :environment do +namespace :admin do + desc 'Grunt a user ...
Refactor admin rake task. :v:
diff --git a/lib/tasks/emergency.rake b/lib/tasks/emergency.rake index abc1234..def5678 100644 --- a/lib/tasks/emergency.rake +++ b/lib/tasks/emergency.rake @@ -29,5 +29,14 @@ end end end + + # TODO: Run this and then remove it + desc "Create default watches for all users with no current watch...
Add a rake task to set up watches for users that don't have them
diff --git a/lib/podding-cli.rb b/lib/podding-cli.rb index abc1234..def5678 100644 --- a/lib/podding-cli.rb +++ b/lib/podding-cli.rb @@ -3,8 +3,9 @@ require 'thor' require 'settingslogic' +require_relative 'settings/settings_helpers' +require_relative 'settings/setup' require_relative 'settings/load_settings' -requ...
Load order, and add setup
diff --git a/lib/rapid_rack/default_receiver.rb b/lib/rapid_rack/default_receiver.rb index abc1234..def5678 100644 --- a/lib/rapid_rack/default_receiver.rb +++ b/lib/rapid_rack/default_receiver.rb @@ -23,7 +23,7 @@ end def logout(env) - env['rack.session'].clear + env['rack.session'].destroy ...
Support destroying a user's session in Rails 5.2 `ActionDispatch::Request::Session.clear` stopped working on Rails 5.2. Calling destroy has the intended behaviour.
diff --git a/lib/redis/rails/instrumentation.rb b/lib/redis/rails/instrumentation.rb index abc1234..def5678 100644 --- a/lib/redis/rails/instrumentation.rb +++ b/lib/redis/rails/instrumentation.rb @@ -17,6 +17,7 @@ output = cmds.map do |name, *args| if !args.empty? + args = args.map { |ar...
Replace binary data with placeholder text when logging.
diff --git a/lib/veritas/aggregate.rb b/lib/veritas/aggregate.rb index abc1234..def5678 100644 --- a/lib/veritas/aggregate.rb +++ b/lib/veritas/aggregate.rb @@ -6,7 +6,10 @@ # Evaluate the aggregate using the operands # - # @return [undefined] + # @example + # Aggregate.call # => raises NotImplem...
Document the return value for Aggregate.call
diff --git a/lib/sandthorn_sequel_projection.rb b/lib/sandthorn_sequel_projection.rb index abc1234..def5678 100644 --- a/lib/sandthorn_sequel_projection.rb +++ b/lib/sandthorn_sequel_projection.rb @@ -23,12 +23,17 @@ ProcessedEventsTracker.migrate!(configuration.projections_driver) end + def event_store...
Make event store configurable, this makes it possible to not depend upon Sandthorn core lib. Decoupling galore!
diff --git a/lib/scss_lint/linter/hex_format.rb b/lib/scss_lint/linter/hex_format.rb index abc1234..def5678 100644 --- a/lib/scss_lint/linter/hex_format.rb +++ b/lib/scss_lint/linter/hex_format.rb @@ -1,24 +1,20 @@ module SCSSLint class Linter::HexFormat < Linter include LinterRegistry - - def visit_prop(nod...
Simplify HexFormat linter string searching The `HexFormat` linter was using `visit_prop` with a manual check to see if the value of the property was a `Sass::Script::String`, rather than just using `visit_script_string`. Switching to `visit_script_string` simplifies the code. Change-Id: I84a64b97071b74d9d37ff40360f4...
diff --git a/pakyow-mailer/lib/mailer/mailer.rb b/pakyow-mailer/lib/mailer/mailer.rb index abc1234..def5678 100644 --- a/pakyow-mailer/lib/mailer/mailer.rb +++ b/pakyow-mailer/lib/mailer/mailer.rb @@ -12,7 +12,12 @@ end def deliver_to(recipient, subject = nil) - @message.body = self.view.to_html ...
Set HTML part of message instead of body