id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
2,484,938,033
godot
C# exported StringName property set to null is assigned a non-null empty StringName with a null native value.
### Tested versions - Reproducible in 4.2 stable and 4.3 stable ### System information Windows 10 - Godot 4.3 ### Issue description When a node or resource has an exported StringName property and that property is set to null in the tscn or tres file, upon running the game an empty StringName object will be assigned to that property. ### Steps to reproduce It is specifically these functions from the [C# Glue StringName.cs](https://github.com/godotengine/godot/blob/e3550cb20f5d6a61befaafb7d9cbdb57b24870e4/modules/mono/glue/GodotSharp/GodotSharp/Core/StringName.cs#L55) and [C# Glue VariantUtils.cs](https://github.com/godotengine/godot/blob/e3550cb20f5d6a61befaafb7d9cbdb57b24870e4/modules/mono/glue/GodotSharp/GodotSharp/Core/NativeInterop/VariantUtils.cs#L520) files that cause this behavior: ```csharp // StringName.cs private StringName(godot_string_name nativeValueToOwn) { NativeValue = (godot_string_name.movable)nativeValueToOwn; _weakReferenceToSelf = DisposablesTracker.RegisterDisposable(this); } // Explicit name to make it very clear internal static StringName CreateTakingOwnershipOfDisposableValue(godot_string_name nativeValueToOwn) => new StringName(nativeValueToOwn); ``` ```csharp // VariantUtils.cs public static StringName ConvertToStringName(in godot_variant p_var) => StringName.CreateTakingOwnershipOfDisposableValue(ConvertToNativeStringName(p_var)); ``` This behavior can be observed when Godot is setting the properties defined within a tscn or tres file that has a StringName property with a value of null. When attempting to convert a Variant whose type is null, the `godot_string_name` that `ConvertToNativeStringName` returns does not have its `IsAllocated` property checked before creating a new StringName in `CreateTakingOwnershipOfDisposableValue`. This results in an empty StringName being created with an internal NativeValue wrapping a null IntPtr. This _feels_ like unintended behavior. When other exported reference types are set to null through the editor, they are assigned null at runtime. If this is in fact unintended, I've already written a [small fix](https://github.com/operation404/godot/commit/7e52ce776351a23f3c3d547290707bdda8404862) and can open a pull request with it. I just added a ternary check to see if the native value was allocated before creating a new managed StringName. If this is _intended_, then I think it should be documented somewhere explicitly. I have many StringName properties set to null by default, and if they aren't specified within a tscn or tres file, they stay null at runtime. If those properties are declared as null within those files, they instead have an empty StringName assigned. Even if a property isn't modified from its default and doesn't need to be specified in the resource file, Godot will sometimes add it anyways, which results in different behavior than if it were excluded. ### Minimal reproduction project (MRP) -
bug,topic:dotnet
low
Minor
2,484,947,318
rust
[rustdoc search] allow setting crates to search in before showing results
specifically, this would mean moving the `#crate-search` dropdown so it is available outside of the results screen. on desktops, it could be moved into the `<rustdoc-search>` search form, and displayed in a single line. on mobile, it could be displayed directly underneath the search bar line. this would significantly speed up searching through the `nightly-rustc` docs when you already know what crate you want to search, although it would require some small refactorings of rustdoc's `search.js`.
T-rustdoc,A-rustdoc-search
low
Minor
2,484,980,857
godot
Texture Progress with offset fill doesn't properly draw with nine patch stretch
### Tested versions Tested in v4.3.stable.official [77dcf97d8] ### System information Windows 10, Forward+ Renderer ### Issue description Texture progress is supposed to use a fill texture that only fills in the drawn progress inside of an Over or Under dressing texture. When using it in this way for a texture that needs to be able to be shrunk (necessitating clicking Nine Patch Stretch) - the fill does not draw in the correct UV space, nor properly handling the appropriate texture offset. ![image](https://github.com/user-attachments/assets/ecbd37b6-ca49-401c-beff-61240152328b) Seen here: clicking on NinePatchStretch has made this smaller texture - that's supposed to be the size of the empty space inside the Over texture - the entire size of the TextureProgress. It is also still using the original texture offset, not adjusting relatively to the drawn space of the node. ### Steps to reproduce In a new project - create a TextureProgress node Use either the supplied textures or any texture that requires an offset Progress texture that is a different size than the original <img src="https://github.com/user-attachments/assets/c67d8de2-e0f1-4053-a4f0-be336f7238ea" height="80"> <img src="https://github.com/user-attachments/assets/70dabca1-9bdb-48f1-8e7f-994b8c9c1b86" height="100"> Apply the larger texture to the Over (the right image) Apply the smaller texture to the Progress (the left image) set the value of the TextureProgress node to 100 to see the progress draw Enable NinePatchStretch -> observe the smaller Progress texture become the size of the entire rect. ### Minimal reproduction project (MRP) [textureprogressbug.zip](https://github.com/user-attachments/files/16738516/textureprogressbug.zip)
bug,topic:gui
low
Critical
2,484,982,187
godot
Unable to use subclassed instances of MovieWriter
### Tested versions Reproducible in 4.3 stable ### System information MacOs aarch64, Godot v4.3 stable ### Issue description I was subclassing `MovieWriter` when I realized that calls to `MovieWriter::add_writer` were not adding the writer to the list of available writers when done at scene initialization. This is problematic because, to my understanding, you cannot create new MovieWriter instances prior to this step in a gdextension. ### Steps to reproduce - subclass MovieWriter in a gdextension that adverstises mp4 support (MRP attached) - set the movie writer file to test.mp4 in the project settings - try to attach it at scene load time, to my understanding, the earliest that this can be done. - the error : `setup2: Can't find movie writer for file type, aborting: test.mp4` should be emitted in the debugger. ### Minimal reproduction project (MRP) The following rust plugin demonstrates the lifecycle issue https://github.com/mobile-bungalow/WriterExample. see that[ adding the writer](https://github.com/mobile-bungalow/WriterExample/blob/9762d581020fb4f1981786d3891e27897002f465/src/lib.rs#L21) must occur prior to [loading the writer](https://github.com/godotengine/godot/blob/e3550cb20f5d6a61befaafb7d9cbdb57b24870e4/main/main.cpp#L2962).
bug,topic:gdextension
low
Critical
2,484,995,648
flutter
[macOS] Remove FlutterViewController.mouseDown/Up workaround
In https://github.com/flutter/engine/pull/40241, I added a workaround for an AppKit bug wherein mouseDown/Up events were ignored when the *Reduced Transparency* accessibility setting was enabled, and the view was hosted in an `NSPopover`. I filed a Radar and Apple reported the bug fixed in macOS 13.3.1. When we drop support for macOS 12 in Flutter, we should remove the workaround in FlutterViewController, here: https://github.com/flutter/engine/blob/3ce6c4bf17534fddb07ea98df035d33243d9fd7a/shell/platform/darwin/macos/framework/Source/FlutterViewController.mm#L289-L316 So long as nothing else has been added to these methods at that time, the method overrides themselves should be removed, so that we fall back to the default behaviour. See: https://github.com/flutter/flutter/issues/115015 See: http://www.openradar.me/FB12050037 See: https://developer.apple.com/documentation/appkit/nsresponder/1535349-mouseup
engine,platform-mac,c: proposal,a: mouse,P3,team-macos,triaged-macos
low
Critical
2,485,000,627
go
x/tools/gopls: Extend hover ability to get the type of selected expression
### gopls version golang.org/x/tools/gopls v0.0.0-20240816163142-66adacf20fc4 golang.org/x/tools/gopls@v0.0.0-20240816163142-66adacf20fc4 h1:iSreTB1mHFYjQkoNmGjFjKRGkrhedt4wmfg 47nKSo28= github.com/BurntSushi/toml@v1.2.1 h1:9F2/+DoOYIOksmaJFPw1tGFy1eDnIJXg+UHjuD8lTak= github.com/google/go-cmp@v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI= golang.org/x/exp/typeparams@v0.0.0-20221212164502-fae10dda9338 h1:2O2DON6y3XMJiQRAS1UWU+54aec2uopH 3x7MAiqGW6Y= golang.org/x/mod@v0.20.0 h1:utOm6MM3R3dnawAiJgn0y+xvuYRsm1RKM/4giyfDgV0= golang.org/x/sync@v0.8.0 h1:3NFvSEYkUoMifnESzZl15y791HH1qU2xm6eCJU5ZPXQ= golang.org/x/telemetry@v0.0.0-20240712210958-268b4a8ec2d7 h1:nU8/tAV/21mkPrCjACUeSibjhynTovgRMXc32 +Y1Aec= golang.org/x/text@v0.17.0 h1:XtiM5bkSOt+ewxlOE/aE/AKEHibwj/6gvWMl9Rsh0Qc= golang.org/x/tools@v0.24.1-0.20240816163142-66adacf20fc4 h1:PoPnfVMls3TamN2+Zq6FsI1uSjUOqW1mt6AXfY w3kdw= golang.org/x/vuln@v1.0.4 h1:SP0mPeg2PmGCu03V+61EcQiOjmpri2XijexKdzv8Z1I= honnef.co/go/tools@v0.4.7 h1:9MDAWxMoSnB6QoSqiVr7P5mtkT9pOc1kSxchzPCnqJs= mvdan.cc/gofumpt@v0.6.0 h1:G3QvahNDmpD+Aek/bNOLrFR2XC6ZAdo62dZu65gmwGo= mvdan.cc/xurls/v2@v2.5.0 h1:lyBNOm8Wo71UknhUs4QTFUNNMyxy2JEIaKKo0RWOh+8= go: go1.22.4 ### go env ```shell GO111MODULE='auto' GOARCH='arm64' GOBIN='' GOCACHE='/Users/xzb/Library/Caches/go-build' GOENV='/Users/xzb/Library/Application Support/go/env' GOEXE='' GOEXPERIMENT='' GOFLAGS='' GOHOSTARCH='arm64' GOHOSTOS='darwin' GOINSECURE='' GOMODCACHE='/Users/xzb/go/pkg/mod' GONOPROXY='' GONOSUMDB='' GOOS='darwin' GOPATH='/Users/xzb/go' GOPRIVATE='' GOPROXY='https://proxy.golang.org,direct' GOROOT='/usr/local/go' GOSUMDB='sum.golang.org' GOTMPDIR='' GOTOOLCHAIN='auto' GOTOOLDIR='/usr/local/go/pkg/tool/darwin_arm64' GOVCS='' GOVERSION='go1.22.4' GCCGO='gccgo' AR='ar' CC='clang' CXX='clang++' CGO_ENABLED='1' GOMOD='/Users/xzb/Project/go/tools/go.mod' GOWORK='' CGO_CFLAGS='-O2 -g' CGO_CPPFLAGS='' CGO_CXXFLAGS='-O2 -g' CGO_FFLAGS='-O2 -g' CGO_LDFLAGS='-O2 -g' PKG_CONFIG='pkg-config' GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/gv/r110hgbx1gbgzp95kf_q71x40000gn/T/go-build4205968761=/tmp/go-build -gno-record-gcc-switches -fno-common' ``` ### What did you do? As the title says, get the type info of seleted range. in Goland https://github.com/user-attachments/assets/7eea395f-490f-420f-8c8e-d1897f679f0e in rust-analyzer [documentation](https://github.com/rust-lang/rust-analyzer/blob/master/docs/dev/lsp-extensions.md#hover-range) https://github.com/user-attachments/assets/1d12247d-eccb-44a6-819e-03ce71b40ed2 ### What did you see happen? We can't hover in selection state to get type information ### What did you expect to see? Get the type info of seleted range. related:https://github.com/rust-lang/rust-analyzer/pull/9693 ### Editor and settings _No response_ ### Logs _No response_
FeatureRequest,gopls,Tools
low
Major
2,485,005,473
tauri
[feat] It is not explicitly stated that hyphens cannot be used in the Android Package ID
### Describe the problem It is not explicitly stated that hyphens cannot be used in the Android Package ID. If the plugin name is Kebab case, the suggestion will be hyphenated. example: com.plugin.my-plugin ### Describe the solution you'd like 1. Explicitly state that hyphens are not allowed in the CLI. 2. Automatically convert suggestions. snake_case, or CamelCase. ### Alternatives considered _No response_ ### Additional context _No response_
type: feature request
low
Minor
2,485,015,563
tauri
[bug] Dragging window causes focus toggling, plus eats mouse event(s)
### Describe the bug On Windows, clicking any draggable region within a Tauri window causes a toggling of window focus and the loss of certain mouse events as observed by the webview. This occurs both with parts of the window which are within the native frame (e.g. titlebar, resize borders), and designated drag regions within the webview. When clicking in a webview drag region, the loss of the mouse up event very rarely seems to cause the window to get stuck in a dragging state, such that it will follow the mouse until the user clicks again. While draggable regions are associated with this behaviour, actually dragging them is unnecessary. Only clicking is required, though in certain cases you may need to hold the click for a moment before releasing. A [prior issue](https://github.com/tauri-apps/tauri/issues/5864) describes what I believe to be the same problem. I've opened a new issue to provide additional information and up-to-date reproductions steps, since this actually bit me when developing my current project. When clicking on a drag region within the webview, the following events are observed by the webview in this order: - When clicking without prior focus: - Focus gained - Mouse down - Focus lost - Focus gained - When clicking with prior focus: - Mouse down - Focus lost - Focus gained Notice the absence of a mouse up event: this will seemingly never be observed by event listeners in the webview. (If you double-click instead of single clicking, then the second mouse up event _will_ be visible: but this is only because it triggers the window maximize handler instead of the drag start handler.) When clicking in the native window frame area, outside the webview, the observed events are similar, with the addition of a delay: - When clicking without prior focus: - Focus gained - (delay) - Focus lost - Focus gained - When clicking with prior focus: - (delay) - Focus lost - Focus gained (No mouse events are seen by the webview in this case, but this is expected, since they occur in the frame area beyond the webview's bounds.) About the delay: - The delay is not present when clicking on a webview drag region. It only appears when clicking on the native window frame. - When clicking on the native window frame, the focus toggle seems to occur after a small delay of around half a second, at least on my system. - If the window has prior focus and the click is released faster than that, the focus toggle may not be observed at all, though it will always appear if the click is held for a time before releasing. - For whatever reason, without prior focus, this effect seems _not_ to be sensitive to how long the mouse is held down. Clicking, even quickly, will cause focus/unfocus/focus. - When I accidentally introduced a great deal of lag by using the webview dev tools and Window Detective to observe window messages at the same time, this bug disappeared, both when interacting with the native window frame and within drag regions within the webview. Extra focus/unfocus events were not observed, nor were mouse up events eaten. I suspect that enough lag was introduced in just the right places that the misbehaving code's ordering was changed, causing it to no longer manifest the bug. I'm not certain the delay will replicate on every system, but the gap is suspiciously close to 500ms. Here's a recording of a trace of the window messages, captured using Window Detective. Starting without focus on the window, I mouse over the native titlebar, pause, click down, hold for a moment, and then release. While the mouse button is held down, the mouse is not moved at all. ![Tauri focus issue - window messages](https://github.com/user-attachments/assets/a5ddde44-3a2f-4e8a-9356-a7fa68fe8d2b) Here also is a static screenshot of those window messages after the fact, with coloured bars drawn along the left-hand side so that you can easily associate them with the cause: ![screenshot 2024-08-24 20-32-27 (annotated)](https://github.com/user-attachments/assets/e1d7926d-16c2-4caf-a976-7ee9782194c5) - Green indicates messages that were sent after clicking down with the left mouse button. - Orange indicates messages also sent while the left mouse button is held down, but which only triggered after a ~500ms delay (note the timestamps), and which appear to correlate with the focus toggle issue I describe above. - Blue indicates messages that were sent after releasing the left mouse button. I poked through the Tauri internals a bit to see if I could figure out exactly where this was happening, but I'm still getting familiar with the project and with Rust, so I'm not very effective yet. I hope the above information can help someone else with a better grasp of the project pinpoint where it's happening. Do let me know if there's anything further information I could provide that would be useful. ### Reproduction 1. Create a minimal Tauri program using `create-tauri-app`: ``` cargo create-tauri-app --rc ``` 2. Add `core:window:allow-start-dragging` to the program permissions. 3. Insert the following code at the end of `main.js`: ```js // Misc. setup. Can be ignored. let dragRegion = document.createElement('div'); dragRegion.style.height = '100%'; dragRegion.style.width = '100%'; dragRegion.style.position = 'fixed'; dragRegion.style.top = '0'; dragRegion.style.left = '0'; dragRegion.style.display = 'flex'; dragRegion.style.justifyContent = 'center'; dragRegion.style.alignItems = 'center'; dragRegion.style.backgroundColor = 'grey'; document.body.append(dragRegion); let label = document.createElement('div'); label.textContent = 'Drag anywhere in the grey region to move the window.'; label.style.pointerEvents = 'none'; dragRegion.append(label); // Make document draggable via its interior // Requires core:window:allow-start-dragging dragRegion.setAttribute('data-tauri-drag-region', ''); // Make change of focus observable window.addEventListener('focus', () => console.log('Focus gained')); window.addEventListener('blur', () => console.log('Focus lost')); // Make mouse events observable // // We use capturing listeners so that we see the event before Tauri calls both // preventDefault() and stopPropagation() on it (see: drag.js). document.addEventListener('mousedown', () => console.log('> Mouse down'), { capture: true }); document.addEventListener('mouseup', () => console.log('> Mouse up'), { capture: true }); ``` 4. Run the program in dev mode: ``` cargo tauri dev ``` 5. Open the dev tools and watch the messages logged in the console as the window is clicked. ### Expected behavior The window should not lose focus when it is clicked while already focused. Mouse up events within the webview should not be silently ignored, even when clicking on a drag region. ### Full `tauri info` output ```text [✔] Environment - OS: Windows 10.0.19045 X64 ✔ WebView2: 127.0.2651.105 ✔ MSVC: Visual Studio Community 2022 ✔ rustc: 1.80.0 (051478957 2024-07-21) ✔ cargo: 1.80.0 (376290515 2024-07-16) ✔ rustup: 1.27.1 (54dd3d00f 2024-04-24) ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (environment override by RUSTUP_TOOLCHAIN) - node: 18.12.1 - npm: 8.19.2 [-] Packages - tauri [RUST]: 2.0.0-rc.6 - tauri-build [RUST]: 2.0.0-rc.6 - wry [RUST]: 0.42.0 - tao [RUST]: 0.29.1 - tauri-cli [RUST]: 2.0.0-rc.3 - @tauri-apps/api : not installed! - @tauri-apps/cli [NPM]: 2.0.0-rc.3 [-] App - build-type: bundle - CSP: unset - frontendDist: ../src ``` ### Stack trace _No response_ ### Additional context _No response_
type: bug,platform: Windows,status: needs triage
low
Critical
2,485,061,391
next.js
Cannot read properties of null (reading 'get')
### Link to the code that reproduces this issue https://github.com/yehonatanyosefi/parallel-routes-example ### To Reproduce Happens randomly in production with App Router ### Current vs. Expected behavior Happens here: `../src/client/components/router-reducer/fill-lazy-items-till-leaf-with-head.ts in fillLazyItemsTillLeafWithHead` at line `153:60`: ``` const existingParallelRoutes = newCache.parallelRoutes.get(key) ``` Error: `Cannot read properties of null (reading 'get')` ![image](https://github.com/user-attachments/assets/b3eeea05-a107-4ad0-8ebb-01d6fd2879a6) ### Provide environment information ```bash const nextConfig = { output: "standalone", reactStrictMode: true, poweredByHeader: false, skipTrailingSlashRedirect: true, ... } ``` ``` "next": "^15.0.0-rc.0", ``` ``` ### Which area(s) are affected? (Select all that apply) Parallel & Intercepting Routes ### Which stage(s) are affected? (Select all that apply) Other (Deployed) ### Additional context _No response_
bug,Parallel & Intercepting Routes
low
Critical
2,485,063,025
ollama
Add option to /api/embed to not normalize embeddings
The old /api/embeddings endpoint does not seem to normalize embeddings. However, the new /api/embed endpoint does: https://github.com/ollama/ollama/blob/0f92b19bec97198b035a7801eda14e3d48149033/server/routes.go#L388 This is probably the right behavior as normalized embeddings are what most people want. However, it would be nice if there were an optional argument to /api/embed where one could specify `'normalization':false`.
feature request,api
low
Minor
2,485,081,977
node
vm: TypeError thrown instead of ReferenceError when a Proxy is the vm context
### Version v22.7.0 ### Platform ```text Microsoft Windows NT 10.0.22631.0 x64 ``` ### Subsystem vm ### What steps will reproduce the bug? ```js "use strict"; const vm = require("vm"); const context = vm.createContext({ __proto__: new Proxy({}, { get(target, property, receiver) { return Reflect.get(target, property, receiver); } }) }); vm.runInContext("thisFunctionDoesNotExist()", context); ``` Output: ### How often does it reproduce? Is there a required condition? Always. ### What is the expected behavior? Why is that the expected behavior? If I instead do ```js const context = vm.createContext({ __proto__: new Proxy({}, {}) }); vm.runInContext("thisFunctionDoesNotExist()", context); ``` or simply ```js const context = vm.createContext({}); vm.runInContext("thisFunctionDoesNotExist()", context); ``` then I get the expected output: ``` $ node test.js evalmachine.<anonymous>:1 thisFunctionDoesNotExist() ^ ReferenceError: thisFunctionDoesNotExist is not defined at evalmachine.<anonymous>:1:1 at Script.runInContext (node:vm:148:12) at Object.runInContext (node:vm:300:6) ``` ### What do you see instead? ```$ node test.js evalmachine.<anonymous>:1 thisFunctionDoesNotExist() ^ TypeError: thisFunctionDoesNotExist is not a function at evalmachine.<anonymous>:1:1 at Script.runInContext (node:vm:148:12) at Object.runInContext (node:vm:300:6) at Object.<anonymous> (C:\Users\d\OneDrive - domenic.me\Code\GitHub\jsdom\jsdom\test.js:31:4) at Module._compile (node:internal/modules/cjs/loader:1546:14) at Module._extensions..js (node:internal/modules/cjs/loader:1691:10) at Module.load (node:internal/modules/cjs/loader:1317:32) at Module._load (node:internal/modules/cjs/loader:1127:12) at TracingChannel.traceSync (node:diagnostics_channel:315:14) at wrapModuleLoad (node:internal/modules/cjs/loader:217:24) Node.js v22.7.0 ``` ### Additional information I am not 100% sure this is a vm bug. It may be a fundamental limitation of `Proxy` and the complicated ECMAScript spec rules governing `ReferenceError` vs. `TypeError`. But I am pretty sure this is a vm limitation instead: - Browsers manage to give a ReferenceError here - Browsers have something very similar to proxies (the WindowProperties object) as part of their global object - I can't see anything in [the spec for WindowProperties](https://webidl.spec.whatwg.org/#named-properties-object) that cannot be emulated by a Proxy. This is blocking jsdom from passing the web platform test [window-runtime-error.html](https://github.com/web-platform-tests/wpt/blob/master/html/webappapis/scripting/events/event-handler-processing-algorithm-error/window-runtime-error.html) once I implement the WindowProperties object (https://github.com/jsdom/jsdom/pull/3765).
vm,v8 engine
low
Critical
2,485,082,167
go
os/exec: possible race handling stdout&stderr pipes
### Go version go version go1.22.6 linux/amd64 ### Output of `go env` in your module/workspace: ```shell GO111MODULE='' GOARCH='amd64' GOBIN='' GOCACHE='/home/rgooch/.cache/go-build' GOENV='/home/rgooch/.config/go/env' GOEXE='' GOEXPERIMENT='' GOFLAGS='' GOHOSTARCH='amd64' GOHOSTOS='linux' GOINSECURE='' GOMODCACHE='/home/rgooch/go/pkg/mod' GONOPROXY='' GONOSUMDB='' GOOS='linux' GOPATH='/home/rgooch/go' GOPRIVATE='' GOPROXY='https://proxy.golang.org,direct' GOROOT='/usr/local/go1.22.6-amd64' GOSUMDB='sum.golang.org' GOTMPDIR='' GOTOOLCHAIN='auto' GOTOOLDIR='/usr/local/go1.22.6-amd64/pkg/tool/linux_amd64' GOVCS='' GOVERSION='go1.22.6' GCCGO='gccgo' GOAMD64='v1' AR='ar' CC='gcc' CXX='g++' CGO_ENABLED='1' GOMOD='/home/rgooch/git/Dominator/go.mod' GOWORK='' CGO_CFLAGS='-O2 -g' CGO_CPPFLAGS='' CGO_CXXFLAGS='-O2 -g' CGO_FFLAGS='-O2 -g' CGO_LDFLAGS='-O2 -g' PKG_CONFIG='pkg-config' GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build438858212=/tmp/go-build -gno-record-gcc-switches' ``` ### What did you do? ``` stderr := &strings.Builder{} stdout := &strings.Builder{} cmd := exec.Command(path, args...) cmd.Env = make([]string, 0) cmd.Stderr = stderr cmd.Stdout = stdout if err := cmd.Start(); err != nil { return err } if err := cmd.Wait(); err != nil { return err } ``` This captures the essence of what I'm doing when starting a process. Note that there are other goroutines, in particular a goroutine that is accepting HTTP CONNECT requests concurrently. I have not yet been able to reproduce the problem with a minimal programme. I've taken a look at the `os/exec` implementation and haven't yet seen a potential bug, but given the core of what I'm doing is so simple, I have to wonder if there is a bug lurking somewhere in the standard library. It may be a subtle interaction with other file descriptors being created concurrently. ### What did you see happen? The `Start()` succeeds, but sometimes the `Wait()` never returns, despite the process (and all its children) exiting. When `Wait()` never returns, I was able to capture the file descriptors in the child process before it exited: ``` lr-x------ 1 0 0 64 0 -> /dev/null l-wx------ 1 0 0 64 1 -> pipe:[61465] l-wx------ 1 0 0 64 2 -> pipe:[61466] lr-x------ 1 0 0 64 10 -> /tmp/test.sh ``` As you can see, stdout and stderr each have the write-side of their own pipe, as expected. The child process (and any dependents) definitely exit shortly afterwards; they do not appear in the process table. Inside the parent process (the one using `os/exec`), these are the file descriptors: ``` lrwx------ 1 0 0 64 Aug 25 03:41 0 -> /dev/console lrwx------ 1 0 0 64 Aug 25 03:41 1 -> /dev/console lrwx------ 1 0 0 64 Aug 25 03:42 10 -> /dev/pts/0 lrwx------ 1 0 0 64 Aug 25 03:42 11 -> socket:[23564]= lrwx------ 1 0 0 64 Aug 25 03:41 2 -> /dev/console lrwx------ 1 0 0 64 Aug 25 03:41 3 -> socket:[15381]= lrwx------ 1 0 0 64 Aug 25 03:41 4 -> anon_inode:[eventpoll] lr-x------ 1 0 0 64 Aug 25 03:41 5 -> pipe:[61446]| l-wx------ 1 0 0 64 Aug 25 03:41 6 -> pipe:[61446]| l-wx------ 1 0 0 64 Aug 25 03:42 7 -> /tmp/log lrwx------ 1 0 0 64 Aug 25 03:42 8 -> socket:[61457]= lrwx------ 1 0 0 64 Aug 25 03:41 9 -> /dev/ptmx ``` Both the read *and* write side of the stderr pipe are open, and the stdout pipe is nowhere to be found. ### What did you expect to see? The `Wait()` should return as soon as the process exists. Also, the read-side of the stdout and stderr pipes should be open in the parent process, but not the write-side.
NeedsInvestigation
low
Critical
2,485,107,789
flutter
DraggableScrollableSheet fails to resize programatically
### Steps to reproduce 1. Create a `Scaffold` widget with a persistent bottom sheet (`bottomSheet`) wrapped in a `DraggableScrollableSheet`. 2. Assign a `DraggableScrollableController` to `DraggableScrollableSheet` to allow programmatic resizing of the sheet. 3. Note that the default `initialChildSize` of `DraggableScrollableSheet` is `0.5`. Or assign a custom `initialChildSize`. 4. Define a button/widget that when pressed, resizes the sheet programatically to any size lesser than `initialChildSize`. Either of the `jumpTo` or `animateTo` method of `DraggableSrollableController` can be used. 5. For instance: ```dart FilledButton(onPressed: () => _controller.jumpTo(0.2), child: Text('Minimize')); ``` 6. Run the app. 7. Resize the sheet (either by dragging manually or programmatically with another button) to any size greater than the `initialChildSize`. 8. Resize the sheet **programmatically** using the button defined above when the sheet is still at a size greater than `initialChildSize`. (See the code sample below for a minimal, reproducible and fully-working example.) ### Expected results When the button is pressed, the `DraggableScrollableSheet` should resize to the correct size. ### Actual results When the button is pressed, the sheet resizes to `initialChildSize` instead of the specified size. This only happens when the sheet is resized using the controller to a size lesser than the `initialChildSize` and when the sheet's current size is greater than `initialChildSize`. ### Cause After some debugging, it appears that the issue is arising because a `NotificationListener` in `Scaffold._maybeBuildPersistentBottomSheet` is calling `DraggableScrollableActuator.reset(context)`, causing the sheet to resize to its initial size. The notification listener is a local function in `_maybeBuildPersistentBottomSheet` called `persistentBottomSheetExtentChanged`. This listener calls `_persistentSheetHistoryEntry.remove()` which triggers the `LocalHistoryEntry`'s `onRemove` listener (defined in the same function) which in turn calls `DraggableScrollableActuator.reset(context)`. ### Code sample <details open><summary>Code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( title: 'Flutter Demo', debugShowCheckedModeBanner: false, theme: ThemeData( colorSchemeSeed: Colors.blue, ), home: const MyHomePage(title: 'DraggableScrollableSheet Resize Issue'), ); } } class MyHomePage extends StatefulWidget { final String title; const MyHomePage({ super.key, required this.title, }); @override State<MyHomePage> createState() => _MyHomePageState(); } const _maxSheetSize = 0.9; const _initialSheetSize = 0.4; const _minSheetSize = 0.2; class _MyHomePageState extends State<MyHomePage> { final _controller = DraggableScrollableController(); bool _isResizing = false; Future<void> _resizeSheet(double size) async { setState(() => _isResizing = true); await _controller.animateTo( size, duration: Durations.medium1, curve: Curves.linear, ); setState(() => _isResizing = false); } @override Widget build(BuildContext context) { final ThemeData( :colorScheme, :textTheme, ) = Theme.of(context); return Scaffold( appBar: AppBar( title: Text(widget.title), ), body: Container( constraints: BoxConstraints.expand(), color: colorScheme.inversePrimary, child: Center( child: Text( 'Resize the sheet to a size greater ' 'than ${_initialSheetSize} and hit "Min".', style: textTheme.titleLarge, ), ), ), bottomSheet: DraggableScrollableSheet( expand: false, initialChildSize: _initialSheetSize, maxChildSize: _maxSheetSize, minChildSize: _minSheetSize, controller: _controller, builder: (context, scrollController) => ListView( padding: EdgeInsets.all(32.0), controller: scrollController, children: [ ListenableBuilder( listenable: _controller, builder: (context, _) => Text( 'Current Size: ${_controller.size}', style: textTheme.displaySmall, ), ), Text('Is Resizing: ${_isResizing}'), const SizedBox(height: 16.0), Wrap( alignment: WrapAlignment.spaceBetween, children: [ FilledButton( child: Text('Max'), onPressed: () => _resizeSheet(_maxSheetSize), ), FilledButton( child: Text('Initial'), onPressed: () => _resizeSheet(_initialSheetSize), ), FilledButton( child: Text('Min'), onPressed: () { String message = _controller.size > _initialSheetSize ? 'Sheet should resize to ${_minSheetSize} but watch it resize to ${_initialSheetSize}.' : 'Sheet size is initial size or smaller, so sheet will be correctly resized to ${_minSheetSize}. ' 'Resize the sheet to a size greater than ${_initialSheetSize} to trigger the issue.'; ScaffoldMessenger.of(context).showSnackBar( SnackBar( content: Text( message, ), behavior: SnackBarBehavior.floating, ), ); _resizeSheet(_minSheetSize); }) ], ), ], ), ), ); } } ``` </details> ### Screenshots or Video <details open> <summary>Screenshots / Video demonstration</summary> </details> ### Logs <details open><summary>Logs</summary> </details> ### Flutter Doctor output <details open><summary>Doctor output</summary> The example is reproducible on DartPad with Dart 3.5.0 and Flutter 3.24.0. </details>
framework,f: scrolling,has reproducible steps,P2,team-framework,triaged-framework,found in release: 3.24,found in release: 3.25
low
Critical
2,485,116,664
ollama
Custom model generating response not based on the prompt given
### What is the issue? ollama run mapler/gpt2:latest >>> Hello "What do you mean?" I asked. "Well, what about the first two or three hundred people who came in a week after your show and didn't speak up for themselves? Or how did they react to that announcement of yours as well—that was just an excuse," he said, pointing at my face with his finger on mine. "What's going through our heads now?" I asked, looking down over the audience in dismay. The only one who seemed visibly shaken up and angry right back then had been me (or maybe a friend) while we were making this interview—and he hadn't bothered to tell us about it yet at all since… well, that was too much for him, anyway.  He wasn'a good guy," I said flatly, "but so why are you saying something like 'you did nothing wrong?' If they thought the right thing would happen with those numbers and then told me we were going to get it done by now… well... that was just what happened in Boston for them. They didn't care—the media treated us very badly." /randy_goddard ### OS Linux ### GPU Nvidia ### CPU Intel ### Ollama version 0.3.6
bug
low
Minor
2,485,134,524
flutter
Keyboard events, Windows, `AltGr` generates `Control Left` + `Alt Right`
### Steps to reproduce 1. Run the sample code on Windows or web on Windows 2. Switch input method to French 3. Press `AltGr` / `Alt Right` ### Expected results `AltGr` generates one event. `PhysicalKeyboardKey` should be `PhysicalKeyboardKey.altRight`. `LogicalKeyboardKey` should be `LogicalKeyboardKey.altGraph`. ### Actual results `AltGr` generates two events, `Control Left` and `Alt Right`. Because I'm listening the keyboard events. "`Control Left` + `Alt Right` + ?" is sometimes used as shortcut. And it is confused, because we don't know if `Control Left` + `Alt Right` is pressed with en-US, or `AltGr` is pressed with fr-FR. ### Code sample <details open><summary>Code sample</summary> ```dart import 'package:flutter/material.dart'; void main() { runApp(MyApp()); } class MyApp extends StatelessWidget { @override Widget build(BuildContext context) { return MaterialApp( title: 'Keyboard Event Demo', theme: ThemeData( primarySwatch: Colors.blue, ), home: const KeyboardEventPage(), ); } } class KeyboardEventPage extends StatefulWidget { const KeyboardEventPage({super.key}); @override _KeyboardEventPageState createState() => _KeyboardEventPageState(); } class _KeyboardEventPageState extends State<KeyboardEventPage> { final List<String> _lastKeyEvents = []; final FocusNode _focusNode = FocusNode(); @override Widget build(BuildContext context) { final child = Scaffold( appBar: AppBar( title: const Text('Keyboard Event Demo'), ), body: Center( child: Column( mainAxisAlignment: MainAxisAlignment.center, children: <Widget>[ const Text( 'Press any key:', style: TextStyle(fontSize: 20), ), const SizedBox(height: 20), for (final keyEvent in _lastKeyEvents) Text( keyEvent, style: const TextStyle(fontSize: 16), ), ], ), ), ); return FocusScope( autofocus: true, child: Focus( autofocus: true, canRequestFocus: true, focusNode: _focusNode, onKeyEvent: (node, event) { setState(() { _lastKeyEvents.add(event.toString()); if (_lastKeyEvents.length > 10) { _lastKeyEvents.removeAt(0); } }); return KeyEventResult.handled; }, child: child, ), ); } } ``` </details> ### Screenshots or Video <details open> <summary>Screenshots / Video demonstration</summary> ![image](https://github.com/user-attachments/assets/cef9cfbc-bddc-4dee-8bdc-f56c07cd4375) </details> ### Logs <details open><summary>Logs</summary> ```console [Paste your logs here] ``` </details> ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console [√] Flutter (Channel stable, 3.24.1, on Microsoft Windows [Version 10.0.22631.4037], locale en-US) • Flutter version 3.24.1 on channel stable at D:\DevEnv\flutter\flutter • Upstream repository https://github.com/flutter/flutter.git • Framework revision 5874a72aa4 (4 days ago), 2024-08-20 16:46:00 -0500 • Engine revision c9b9d5780d • Dart version 3.5.1 • DevTools version 2.37.2 [√] Windows Version (Installed version of Windows is version 10 or higher) [!] Android toolchain - develop for Android devices (Android SDK version 35.0.0) • Android SDK at C:\Users\Administrator\AppData\Local\Android\sdk X cmdline-tools component is missing Run `path/to/sdkmanager --install "cmdline-tools;latest"` See https://developer.android.com/studio/command-line for more details. X Android license status unknown. Run `flutter doctor --android-licenses` to accept the SDK licenses. See https://flutter.dev/to/windows-android-setup for more details. [√] Chrome - develop for the web • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe [√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.10.3) • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community • Visual Studio Community 2022 version 17.10.35013.160 • Windows 10 SDK version 10.0.26100.0 [√] Android Studio (version 2024.1) • Android Studio at C:\Program Files\Android\Android Studio • Flutter plugin can be installed from: https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: https://plugins.jetbrains.com/plugin/6351-dart • Java version OpenJDK Runtime Environment (build 17.0.10+0--11609105) [√] VS Code (version 1.92.2) • VS Code at C:\Users\Administrator\AppData\Local\Programs\Microsoft VS Code • Flutter extension version 3.94.0 [√] Connected device (3 available) • Windows (desktop) • windows • windows-x64 • Microsoft Windows [Version 10.0.22631.4037] • Chrome (web) • chrome • web-javascript • Google Chrome 127.0.6533.120 • Edge (web) • edge • web-javascript • Microsoft Edge 128.0.2739.42 [!] Network resources X A network error occurred while checking "https://maven.google.com/": The semaphore timeout period has expired. ! Doctor found issues in 2 categories. ``` </details>
framework,a: internationalization,platform-windows,has reproducible steps,P2,fyi-text-input,team-windows,triaged-windows,found in release: 3.24,found in release: 3.25
low
Critical
2,485,135,080
godot
Identical `spatial`/`canvas_item` fragment shaders differ in output, when not using Compatibility/GLES2 renderer
### Tested versions v4.3.stable.official [77dcf97d8], v4.0.stable.official [92bee43ad], v3.5.2.stable.official [170ba337a] ### System information Godot v4.2.2.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1660 SUPER (NVIDIA; 32.0.15.5612) - AMD Ryzen 5 5600G with Radeon Graphics (12 Threads) ### Issue description I was trying to translate `canvas_item` shaders to `spatial` and vice versa, in curiosity for how their performance would differ. Some were fine, but others just seemed to have different coloration and I was confused. Then I tested a basic linear gradient, and it seems that `spatial` isn't linear for some reason? --- This is the case in both Forward+ and Mobile renderers, but in Compatibility it looks fine! ![Godot_v4 2 2-stable_win64_R2vvGmQI6z](https://github.com/user-attachments/assets/0f891a5f-3df5-441a-bac1-e0991c694a00) > Forward+ ![Godot_v4 2 2-stable_win64_DuekR53VzL](https://github.com/user-attachments/assets/4b0470d3-2b84-4bb9-9948-3c4d68b23bd3) > Compatibility Here are the identical fragment shaders for both `spatial` and `canvas_item`: <details> <summary>Spatial Code</summary> ```GLSL shader_type spatial; render_mode blend_mix, unshaded; void vertex() { POSITION = vec4(VERTEX, 1.0); } void fragment() { ALBEDO = vec3(1.0 - SCREEN_UV.x, 0.0, 0.0); //ALBEDO = vec3(1.0 - UV.x, 0.0, 0.0); // The same as above. } ``` *`spatial` shader uses `vertex()` to act as fullscreen, but the bug happens regardless. </details> <details> <summary>CanvasItem Code</summary> ```GLSL shader_type canvas_item; render_mode blend_mix, unshaded; void fragment() { COLOR.rgb = vec3(1.0 - SCREEN_UV.x, 0.0, 0.0); //COLOR.rgb = vec3(1.0 - UV.x, 0.0, 0.0); // The same as above. } ``` </details> --- Interestingly enough, in Godot 3.5 it's the same thing; GLES3 has the same issue and GLES2 doesn't, even though Godot 4 uses GLES3 for Compatibility(afaik). I have tried many combos of `render_mode`s, but it doesn't seem to fix the problem. This seems like a bug to me, but I wouldn't be surprised if this is intended and I just don't get it. ### Steps to reproduce Open the repro and run `main.tscn`, bug is only apparent when not using Compatibility/GLES2 renderer. ### Minimal reproduction project (MRP) [ShaderBugRepro.zip](https://github.com/user-attachments/files/16739382/ShaderBugRepro.zip), 4.x [ShaderBugRepro3.zip](https://github.com/user-attachments/files/16739383/ShaderBugRepro3.zip), 3.x
discussion,topic:rendering,documentation,needs testing,topic:3d
low
Critical
2,485,135,378
storybook
[Bug]: Internal server error: Install @vitejs/plugin-vue to handle .vue files. when `npx storybook@latest init`
### Describe the bug When I tried `npx storybook@latest init` in my new nuxt3 project and `npm run storybook` an error appears: `Failed to parse source for import analysis because the content contains invalid JS syntax. Install @vitejs/plugin-vue to handle .vue files.` It would be great if I able to use storybook without this error. ### Reproduction link https://github.com/qkreltms/nuxt-storybook-playground You can reproduce an error by doing these steps: 1. npm i 2. npm run storybook ### Reproduction steps 1. npx nuxi@latest init 3. npx storybook init --type vue3 --builder vite 4. npm run storybook ### System ```bash System: OS: macOS 14.2.1 CPU: (8) arm64 Apple M2 Shell: 5.9 - /bin/zsh Binaries: Node: 19.9.0 - ~/.nvm/versions/node/v19.9.0/bin/node Yarn: 1.22.19 - /opt/homebrew/bin/yarn npm: 9.6.3 - ~/.nvm/versions/node/v19.9.0/bin/npm <----- active Browsers: Chrome: 127.0.6533.120 Safari: 17.2.1 npmPackages: @storybook/addon-essentials: ^8.2.9 => 8.2.9 @storybook/addon-interactions: ^8.2.9 => 8.2.9 @storybook/addon-links: ^8.2.9 => 8.2.9 @storybook/addon-onboarding: ^8.2.9 => 8.2.9 @storybook/blocks: ^8.2.9 => 8.2.9 @storybook/test: ^8.2.9 => 8.2.9 @storybook/vue3: ^8.2.9 => 8.2.9 @storybook/vue3-vite: ^8.2.9 => 8.2.9 storybook: ^8.2.9 => 8.2.9 ``` ### Additional context I was able to fix error by adding `@vitejs/plugin-vue` in my .storybook/main.js ```diff +import { mergeConfig } from 'vite' +import vue from '@vitejs/plugin-vue' /** @type { import('@storybook/vue3-vite').StorybookConfig } */ const config = { stories: ['../stories/**/*.mdx', '../stories/**/*.stories.@(js|jsx|mjs|ts|tsx)'], addons: ['@storybook/addon-links', '@storybook/addon-essentials', '@chromatic-com/storybook', '@storybook/addon-interactions'], framework: { name: '@storybook/vue3-vite', options: {}, }, docs: { autodocs: 'tag', }, + viteFinal: async( config) => { + return mergeConfig(config, { + plugins: [vue()] + }) + } }; export default config; ```
bug,needs triage
low
Critical
2,485,139,705
godot
Particles emit in the wrong direction when using double-precision, Vulkan, and local coordinates
### Tested versions Latest master as of writing e3550cb20f5d6a61befaafb7d9cbdb57b24870e4 ### System information macOS 14.6.1 ### Issue description The particle direction is incorrect when using this exact configuration: * Double-precision build of Godot `scons precision=double` * Vulkan renderer (Forward+ or Mobile) * Local coordinates enabled on the particles If you use a single-precision build, or switch to Compatibility, or disable local coordinates, the particles behave correctly. ### Steps to reproduce Open the minimal reproduction project with a double-precision build of Godot. It will look like this: <img width="700" alt="Screenshot 2024-08-25 at 2 06 40 AM" src="https://github.com/user-attachments/assets/315e5c4b-93e8-44a3-9965-71c7a64faa66"> However, this is not correct. The particles node is rotated, so it should look like this, as it does in a single-precision build, when using OpenGL, and/or when local coordinates is unchecked: <img width="700" alt="Screenshot 2024-08-25 at 2 07 04 AM" src="https://github.com/user-attachments/assets/70525873-e147-49ca-a893-daaac9c76bf2"> ### Minimal reproduction project (MRP) [particle-direction-double-vulkan-bug.zip](https://github.com/user-attachments/files/16739582/particle-direction-double-vulkan-bug.zip)
bug,topic:rendering,topic:3d,topic:particles
low
Critical
2,485,144,919
react-native
Bug: TextInput with multiline and lineHeight has height issue when controlled
### Description I'm experiencing a bug with the TextInput component when using it as a controlled component with both multiline and lineHeight properties. This issue occurs only on iOS; it does not occur on Android. ### Expected Behavior: The TextInput should adjust its height according to the content without any unexpected changes. ### Actual Behavior: On iOS, when the TextInput is controlled, the height of the TextInput increases unexpectedly as the number of lines increases. This issue does not occur when the TextInput is uncontrolled. ### Steps to reproduce 1. Create a TextInput component with the following properties: - multiline={true} - lineHeight set to a specific value (e.g., 60) - Controlled by a state variable (value and onChangeText props). 2. Type text into the TextInput to increase the number of lines. ### React Native Version 0.75.2 I have confirmed that this issue does not occur in version 0.73.2. ### Affected Platforms Runtime - iOS ### Output of `npx react-native info` ```text System: OS: macOS 14.4 CPU: (8) arm64 Apple M1 Pro Memory: 236.09 MB / 16.00 GB Shell: version: "5.9" path: /bin/zsh Binaries: Node: version: 20.12.2 path: ~/.nvm/versions/node/v20.12.2/bin/node Yarn: version: 1.22.22 path: ~/.nvm/versions/node/v20.12.2/bin/yarn npm: version: 10.5.0 path: ~/.nvm/versions/node/v20.12.2/bin/npm Watchman: version: 2024.07.15.00 path: /opt/homebrew/bin/watchman Managers: CocoaPods: version: 1.15.2 path: /opt/homebrew/bin/pod SDKs: iOS SDK: Platforms: - DriverKit 23.4 - iOS 17.4 - macOS 14.4 - tvOS 17.4 - visionOS 1.1 - watchOS 10.4 Android SDK: Not Found IDEs: Android Studio: 2024.1 AI-241.18034.62.2411.12071903 Xcode: version: 15.3/15E204a path: /usr/bin/xcodebuild Languages: Java: version: 17.0.12 path: /usr/bin/javac Ruby: version: 2.6.10 path: /usr/bin/ruby npmPackages: "@react-native-community/cli": Not Found react: Not Found react-native: Not Found react-native-macos: Not Found npmGlobalPackages: "*react-native*": Not Found Android: hermesEnabled: Not found newArchEnabled: Not found iOS: hermesEnabled: Not found newArchEnabled: Not found ``` ### Stacktrace or Logs ```text - ``` ### Reproducer https://snack.expo.dev/@holyunwoo/eager-indigo-cereal?platform=ios ### Screenshots and Videos #### Uncontrolled https://github.com/user-attachments/assets/7c359007-c157-4e68-814d-45a60c97239d #### Controlled https://github.com/user-attachments/assets/1cf5a2e8-0cc7-4a81-bb6d-4b9ae0741e1b <img width="300" alt="SCR-20240825-qgyj" src="https://github.com/user-attachments/assets/ed8acf6f-9351-4004-aeec-75c87421ae40">
Issue: Author Provided Repro,Component: TextInput,Newer Patch Available
low
Critical
2,485,163,245
godot
Empty doc tab appears, when Ctrl+clicking on undocumented identifier in GDscript editor
### Tested versions Reproducible on 4.3.stable ### System information Linux ### Issue description It seems that this happens only for identifiers that are missing the documentation. I'm not sure whether such classes should be even available through GDscript, but they're being hinted while writing the code. When I try to use such class I get this error: ``` Native class GDScriptNativeClass used in script doesn't exist or isn't exposed. ``` Details in the attached video: https://github.com/user-attachments/assets/ee2ef302-1186-4c4d-aa98-46ae63c5881a ### Steps to reproduce 1. Open any *.gd file 2. Start writing a code that uses an undocumented class (e.g. `MovieWriterMJPEG`) 3. Hold Ctrl key and click on it 4. Observe, that a new tab appeared, but it's content didn't open 5. Try to click on it to observe that an empty Docs window opens. ### Minimal reproduction project (MRP) N/A
bug,topic:editor
low
Critical
2,485,165,032
godot
`load()` returns `GDScript` even with `Parse error`, but `new()` method can't be called and error is undetectable
### Tested versions v4.2.1.stable.official [b09f793f5] v4.3.stable.official [77dcf97d8] ### System information Godot v4.2.1.stable ### Issue description When loading a `.gd` script using the `load()` function in Godot, the function returns a `GDScript` object even if there are parsing errors in the script. This is unexpected because: - A valid `GDScript` object should always have a `new()` method. - Despite `loaded.has_method("new")` returning `true`, calling `loaded.new()` results in the error: ``` Invalid call. Nonexistent function 'new' in base 'GDScript'. ``` This issue is problematic because there's no clear way to detect or handle this scenario programmatically. Even with parse errors, the script loads and appears valid according to the checks. The only way to detect that the script has issues is by using `loaded.reload()`, which returns a non-zero value if errors are present. However, relying on this method for error detection is not intuitive or well-documented. ### Expected behavior: - If there are parsing errors, load() should return null or provide a clear and intuitive way to detect errors. - A valid GDScript should always have a new() method that can be called without errors. ### Steps to reproduce Here’s an example of the code and its output in both normal and error scenarios: ### Code: ```gdscript # res://main.gd var loaded = load("res://error.gd") print("loaded: ", loaded) print("loaded == null: ", loaded == null) print("loaded is GDScript: ", loaded is GDScript) print("loaded.has_method('new'): ", loaded.has_method("new")) print("loaded.new: ", loaded.new) print("loaded.has_source_code(): ", loaded.has_source_code()) print("loaded.reload(): ", loaded.reload()) loaded.new() ``` ```gdscript # res://error.gd error ``` ### Output with a valid script: ``` loaded: <GDScript#-9223371840326459786> loaded == null: false loaded is GDScript: true loaded.has_method('new'): true loaded.new: GDScript::new loaded.has_source_code(): true loaded.reload(): 0 ``` ### Output with a script containing parse errors: ``` loaded: <GDScript#-9223371833011593533> loaded == null: false loaded is GDScript: true loaded.has_method('new'): true loaded.new: GDScript::new loaded.has_source_code(): true loaded.reload(): 43 ``` ### Error encountered: ``` Invalid call. Nonexistent function 'new' in base 'GDScript'. ``` ### Steps to reproduce: 1. Use the code provided above to load a script and check its validity. 2. Create a .gd script with syntax errors and attempt to load it. 3. Observe that loaded.has_method("new") returns true, but calling loaded.new() raises an error. 4. Note that loaded.reload() returns a non-zero value, indicating an error that isn't detectable by other checks. ### Minimal reproduction project (MRP) [gdscript load issue project.zip](https://github.com/user-attachments/files/16739816/gdscript.load.issue.project.zip)
discussion,topic:gdscript
low
Critical
2,485,190,985
tauri
[feat] ".tauri" folder for mobile plugin prepare initialize
### Describe the problem ".tauri" folder is not created until the mobile app is launched. So in plugin development, Open plugin directory that from Xcode or Android Studio has error until the mobile app is launched. - plugin-directory/.tauri // iOS tauri directory - plugin-directory/android/.tauri // Android tauri directory ### Describe the solution you'd like ".tauri" folder change to Swift Package Manager and mavenCentral. If that is not possible by design, you will probably need a command to copy. Example: package.json: `“preinstall”: “tauri plugin ios install”` ### Alternatives considered _No response_ ### Additional context _No response_
type: feature request
low
Critical
2,485,222,636
flutter
TextField Using emoji applications on the desktop crashes, and the performance of Windows and macOS is the same
### Steps to reproduce 1. TextField: Input content normally and then press the add button to add emojis to the text 2. TextField uses _focusNode. requestFocus(); Get the focus, then TextCelection. collaged() changes the cursor position, 3. The application crashes when typing again 1.TextField 正常输入内容然后按添加按钮在文本中加入emoji 2,TextField 使用_focusNode.requestFocus();获取焦点,然后 TextSelection.collapsed()改变光标位置 3, 再次输入时应用程序崩溃 ### Expected results TextField cursor position changes, application runs normally TextField光标位置改变, 应用程序正常运行 ### Actual results The application crashed 应用程序闪退了 ### Code sample <details open><summary>Code sample</summary> ```dart Scaffold( appBar: AppBar( backgroundColor: Theme.of(context).colorScheme.inversePrimary, title: Text(widget.title), ), body: Center( child: Column( mainAxisAlignment: MainAxisAlignment.center, children: <Widget>[ TextField( focusNode: _focusNode, controller: _contaoller, ) ], ), ), floatingActionButton: FloatingActionButton( onPressed: () { final text = _contaoller.text; final selection = _contaoller.selection; final characters = text.characters.toList(); final safeStart = selection.start.clamp(0, characters.length); final safeEnd = selection.end.clamp(0, characters.length); const characterToInsert = '😩'; // final characterToInsert1 = characterToInsert.characters; characters.replaceRange(safeStart, safeEnd, characterToInsert1); final newText = characters.join(); _contaoller.text = newText; _focusNode.requestFocus(); _contaoller.selection = TextSelection.collapsed( offset: safeStart + characterToInsert.length); }, tooltip: 'Increment', child: const Icon(Icons.add), ), // This trailing comma makes auto-formatting nicer for build methods. ); ``` </details> ### Screenshots or Video <details open> <summary>Screenshots / Video demonstration</summary> [flutter-issue.webm](https://github.com/user-attachments/assets/1d63b117-95db-433d-94aa-8055fe83bd08) </details> ### Logs <details open><summary>Logs</summary> ```console CLIENT ERROR: TUINSRemoteViewController does not override -viewServiceDidTerminateWithError: and thus cannot react to catastrophic errors beyond logging them ``` </details> ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console ✓] Flutter (Channel stable, 3.24.0, on macOS 14.6.1 23G93 darwin-arm64, locale zh-Hans-CN) • Flutter version 3.24.0 on channel stable at /Users/zhaofeixiang/development/flutter • Upstream repository https://github.com/flutter/flutter.git • Framework revision 80c2e84975 (4 weeks ago), 2024-07-30 23:06:49 +0700 • Engine revision b8800d88be • Dart version 3.5.0 • DevTools version 2.37.2 [✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0) • Android SDK at /Users/zhaofeixiang/Library/Android/sdk • Platform android-34, build-tools 34.0.0 • ANDROID_HOME = /Users/zhaofeixiang/Library • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314) • All Android licenses accepted. [✓] Xcode - develop for iOS and macOS (Xcode 15.3) • Xcode at /Applications/Xcode.app/Contents/Developer • Build 15E204a • CocoaPods version 1.15.2 [✓] Chrome - develop for the web • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [✓] Android Studio (version 2024.1) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314) [✓] VS Code (version 1.92.2) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 3.94.0 [✓] Connected device (3 available) • macOS (desktop) • macos • darwin-arm64 • macOS 14.6.1 23G93 darwin-arm64 • Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin • macOS 14.6.1 23G93 darwin-arm64 • Chrome (web) • chrome • web-javascript • Google Chrome 127.0.6533.120 ``` </details>
a: text input,c: crash,platform-mac,platform-windows,platform-linux,a: desktop,has reproducible steps,P2,c: fatal crash,team-text-input,triaged-text-input,found in release: 3.24,found in release: 3.25
low
Critical
2,485,238,132
ollama
llama_get_logits_ith: invalid logits id 11, reason: no logits
### What is the issue? llama_get_logits_ith: invalid logits id 11, reason: no logits ### OS Linux ### GPU Nvidia ### CPU Intel ### Ollama version _No response_
bug
low
Minor
2,485,270,153
godot
Custom script icons render too small on Retina display
### Tested versions v4.3.stable.official [77dcf97d8] ### System information Godot v4.3.stable - macOS 14.6.1 - GLES3 (Compatibility) - Intel(R) UHD Graphics 617 - Intel(R) Core(TM) i5-8210Y CPU @ 1.60GHz (4 Threads) ### Issue description When setting a custom `@icon` on a script, the icon renders smaller than expected in the Scene Tree. The icon preview in the FileSystem renders at the correct size. <img width="272" alt="icon-issue" src="https://github.com/user-attachments/assets/93381422-d34d-47d7-b908-29ee2f83f9b9"> I'm using a MacBook Air with a high DPI / Retina display: Screen Width: 1440 pixels Screen Height: 900 pixels DPR (Device Pixel Ratio): 2 ### Steps to reproduce - Create a new script - Add a custom `@icon` pointed at an asset in the FileSystem (.png and .svg both tested) ``` @icon ("res://assets/icons/icon_save.svg") extends Node2D class_name SaveDataResource ``` - Observe icon in FileSystem pane at incorrect size ### Minimal reproduction project (MRP) [customiconsizeissue.zip](https://github.com/user-attachments/files/16740466/customiconsizeissue.zip)
bug,topic:editor,usability
low
Minor
2,485,272,768
rust
ICE when implementing a generic trait + generic supertrait (and default values)
### Summary The ICE occurs if - generic trait has a generic supertrait - trait and supertrait share the same generic - trait's and supertrait's generic defines a default value for the generic (can differ between trait and supertrait) - generic's default value is only defined in the trait definition, not in the implementation - "generic_const_expr" gate is enabled (even though it's functionality not used) The ICE occurs as the trait is implemented for a type. The targeted type doesn't have to be the same as the generic one. ```rust #![feature(adt_const_params)] #![feature(generic_const_exprs)] use core::marker::ConstParamTy; // #[derive(ConstParamTy, PartialEq, Eq)] // struct StructOrEnum; #[derive(ConstParamTy, PartialEq, Eq)] enum StructOrEnum { A, } trait TraitParent<const SMTH: StructOrEnum = { StructOrEnum::A }> {} trait TraitChild<const SMTH: StructOrEnum = { StructOrEnum::A }>: TraitParent<SMTH> {} impl TraitParent for StructOrEnum {} // ICE occurs impl TraitChild for StructOrEnum {} // ICE does not occur // impl TraitChild<{ StructOrEnum::A }> for StructOrEnum {} ``` ### Version ```text rustc 1.82.0-nightly (f167efad2 2024-08-24) binary: rustc commit-hash: f167efad2f51088d86180ee89177b3d7c9e7c2f5 commit-date: 2024-08-24 host: x86_64-unknown-linux-gnu release: 1.82.0-nightly LLVM version: 19.1.0 ``` ### Error output <details><summary>Backtrace</summary> <p> ``` stack backtrace: 0: rust_begin_unwind 1: core::panicking::panic_fmt 2: <rustc_type_ir::binder::ArgFolder<rustc_middle::ty::context::TyCtxt>>::const_param_out_of_range 3: <rustc_type_ir::binder::ArgFolder<rustc_middle::ty::context::TyCtxt> as rustc_type_ir::fold::TypeFolder<rustc_middle::ty::context::TyCtxt>>::fold_const.llvm.11519418143500691559.cold 4: <rustc_middle::ty::generics::GenericPredicates>::instantiate_into 5: <rustc_trait_selection::traits::wf::WfPredicates>::nominal_obligations 6: <rustc_trait_selection::traits::wf::WfPredicates as rustc_type_ir::visit::TypeVisitor<rustc_middle::ty::context::TyCtxt>>::visit_const 7: <rustc_trait_selection::traits::fulfill::FulfillProcessor as rustc_data_structures::obligation_forest::ObligationProcessor>::process_obligation 8: <rustc_data_structures::obligation_forest::ObligationForest<rustc_trait_selection::traits::fulfill::PendingPredicateObligation>>::process_obligations::<rustc_trait_selection::traits::fulfill::FulfillProcessor> 9: <rustc_trait_selection::traits::engine::ObligationCtxt<rustc_trait_selection::traits::FulfillmentError>>::assumed_wf_types_and_report_errors 10: rustc_hir_analysis::check::wfcheck::check_well_formed [... omitted 1 frame ...] 11: rustc_hir_analysis::check::wfcheck::check_mod_type_wf [... omitted 1 frame ...] 12: rustc_hir_analysis::check_crate 13: rustc_interface::passes::run_required_analyses 14: rustc_interface::passes::analysis [... omitted 1 frame ...] 15: rustc_interface::interface::run_compiler::<core::result::Result<(), rustc_span::ErrorGuaranteed>, rustc_driver_impl::run_compiler::{closure#0}>::{closure#1} ``` </p> </details> <details><summary>ICE</summary> <p> ``` thread 'rustc' panicked at /rustc/f167efad2f51088d86180ee89177b3d7c9e7c2f5/compiler/rustc_type_ir/src/binder.rs:739:9: const parameter `SMTH/#1` (SMTH/#1/1) out of range when instantiating args=[StructOrEnum] stack backtrace: 0: 0x7044d54c4ea5 - std::backtrace::Backtrace::create::h60f0872d50b7947d 1: 0x7044d39d1ec5 - std::backtrace::Backtrace::force_capture::h5f5782d9f084b444 2: 0x7044d2b602ae - std[6e15924ca43b8509]::panicking::update_hook::<alloc[74339d1d9b201e21]::boxed::Box<rustc_driver_impl[d6b1c5b97f2d776c]::install_ice_hook::{closure#0}>>::{closure#0} 3: 0x7044d39e9d37 - std::panicking::rust_panic_with_hook::h48ec1454fab3e9d6 4: 0x7044d39e99f7 - std::panicking::begin_panic_handler::{{closure}}::hdfdc79a140009172 5: 0x7044d39e71f9 - std::sys::backtrace::__rust_end_short_backtrace::h5e9ef3624d34a08c 6: 0x7044d39e96c4 - rust_begin_unwind 7: 0x7044d0b9f263 - core::panicking::panic_fmt::h5c7dda2686e962d9 8: 0x7044d30f2bb9 - <rustc_type_ir[a178b1c04a843a22]::binder::ArgFolder<rustc_middle[715031de33b6a9f]::ty::context::TyCtxt>>::const_param_out_of_range 9: 0x7044d55da828 - <rustc_type_ir[a178b1c04a843a22]::binder::ArgFolder<rustc_middle[715031de33b6a9f]::ty::context::TyCtxt> as rustc_type_ir[a178b1c04a843a22]::fold::TypeFolder<rustc_middle[715031de33b6a9f]::ty::context::TyCtxt>>::fold_const.llvm.11519418143500691559.cold 10: 0x7044d423268c - <rustc_middle[715031de33b6a9f]::ty::generics::GenericPredicates>::instantiate_into 11: 0x7044d422f5a3 - <rustc_trait_selection[76948cd8c7a47ffa]::traits::wf::WfPredicates>::nominal_obligations 12: 0x7044d4c88362 - <rustc_trait_selection[76948cd8c7a47ffa]::traits::wf::WfPredicates as rustc_type_ir[a178b1c04a843a22]::visit::TypeVisitor<rustc_middle[715031de33b6a9f]::ty::context::TyCtxt>>::visit_const 13: 0x7044d08b4bdf - <rustc_trait_selection[76948cd8c7a47ffa]::traits::fulfill::FulfillProcessor as rustc_data_structures[34dac5edc44e011b]::obligation_forest::ObligationProcessor>::process_obligation 14: 0x7044d44178c1 - <rustc_data_structures[34dac5edc44e011b]::obligation_forest::ObligationForest<rustc_trait_selection[76948cd8c7a47ffa]::traits::fulfill::PendingPredicateObligation>>::process_obligations::<rustc_trait_selection[76948cd8c7a47ffa]::traits::fulfill::FulfillProcessor> 15: 0x7044d440a8c3 - <rustc_trait_selection[76948cd8c7a47ffa]::traits::engine::ObligationCtxt<rustc_trait_selection[76948cd8c7a47ffa]::traits::FulfillmentError>>::assumed_wf_types_and_report_errors 16: 0x7044d17183ca - rustc_hir_analysis[2f099064b091af30]::check::wfcheck::check_well_formed 17: 0x7044d45a6d27 - rustc_query_impl[7a841671113bb270]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[7a841671113bb270]::query_impl::check_well_formed::dynamic_query::{closure#2}::{closure#0}, rustc_middle[715031de33b6a9f]::query::erase::Erased<[u8; 1usize]>> 18: 0x7044d45aa4ea - rustc_query_system[77a41dfa2d87d677]::query::plumbing::try_execute_query::<rustc_query_impl[7a841671113bb270]::DynamicConfig<rustc_query_system[77a41dfa2d87d677]::query::caches::VecCache<rustc_hir[9a201f138b4d1b5]::hir_id::OwnerId, rustc_middle[715031de33b6a9f]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[7a841671113bb270]::plumbing::QueryCtxt, true> 19: 0x7044d45a9ef8 - rustc_query_impl[7a841671113bb270]::query_impl::check_well_formed::get_query_incr::__rust_end_short_backtrace 20: 0x7044d45a7acb - rustc_hir_analysis[2f099064b091af30]::check::wfcheck::check_mod_type_wf 21: 0x7044d45a7909 - rustc_query_impl[7a841671113bb270]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[7a841671113bb270]::query_impl::check_mod_type_wf::dynamic_query::{closure#2}::{closure#0}, rustc_middle[715031de33b6a9f]::query::erase::Erased<[u8; 1usize]>> 22: 0x7044d508fbcc - rustc_query_system[77a41dfa2d87d677]::query::plumbing::try_execute_query::<rustc_query_impl[7a841671113bb270]::DynamicConfig<rustc_query_system[77a41dfa2d87d677]::query::caches::DefaultCache<rustc_span[641b1e127128c80]::def_id::LocalModDefId, rustc_middle[715031de33b6a9f]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[7a841671113bb270]::plumbing::QueryCtxt, true> 23: 0x7044d509089b - rustc_query_impl[7a841671113bb270]::query_impl::check_mod_type_wf::get_query_incr::__rust_end_short_backtrace 24: 0x7044d473c34d - rustc_hir_analysis[2f099064b091af30]::check_crate 25: 0x7044d4739abf - rustc_interface[eb6eb7ed9ab023cb]::passes::run_required_analyses 26: 0x7044d4d59c9e - rustc_interface[eb6eb7ed9ab023cb]::passes::analysis 27: 0x7044d4d59c71 - rustc_query_impl[7a841671113bb270]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[7a841671113bb270]::query_impl::analysis::dynamic_query::{closure#2}::{closure#0}, rustc_middle[715031de33b6a9f]::query::erase::Erased<[u8; 1usize]>> 28: 0x7044d520d90d - rustc_query_system[77a41dfa2d87d677]::query::plumbing::try_execute_query::<rustc_query_impl[7a841671113bb270]::DynamicConfig<rustc_query_system[77a41dfa2d87d677]::query::caches::SingleCache<rustc_middle[715031de33b6a9f]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[7a841671113bb270]::plumbing::QueryCtxt, true> 29: 0x7044d520d5ba - rustc_query_impl[7a841671113bb270]::query_impl::analysis::get_query_incr::__rust_end_short_backtrace 30: 0x7044d4ff43aa - rustc_interface[eb6eb7ed9ab023cb]::interface::run_compiler::<core[f2f627d3c87d2691]::result::Result<(), rustc_span[641b1e127128c80]::ErrorGuaranteed>, rustc_driver_impl[d6b1c5b97f2d776c]::run_compiler::{closure#0}>::{closure#1} 31: 0x7044d506f390 - std[6e15924ca43b8509]::sys::backtrace::__rust_begin_short_backtrace::<rustc_interface[eb6eb7ed9ab023cb]::util::run_in_thread_with_globals<rustc_interface[eb6eb7ed9ab023cb]::util::run_in_thread_pool_with_globals<rustc_interface[eb6eb7ed9ab023cb]::interface::run_compiler<core[f2f627d3c87d2691]::result::Result<(), rustc_span[641b1e127128c80]::ErrorGuaranteed>, rustc_driver_impl[d6b1c5b97f2d776c]::run_compiler::{closure#0}>::{closure#1}, core[f2f627d3c87d2691]::result::Result<(), rustc_span[641b1e127128c80]::ErrorGuaranteed>>::{closure#0}, core[f2f627d3c87d2691]::result::Result<(), rustc_span[641b1e127128c80]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[f2f627d3c87d2691]::result::Result<(), rustc_span[641b1e127128c80]::ErrorGuaranteed>> 32: 0x7044d506f9fa - <<std[6e15924ca43b8509]::thread::Builder>::spawn_unchecked_<rustc_interface[eb6eb7ed9ab023cb]::util::run_in_thread_with_globals<rustc_interface[eb6eb7ed9ab023cb]::util::run_in_thread_pool_with_globals<rustc_interface[eb6eb7ed9ab023cb]::interface::run_compiler<core[f2f627d3c87d2691]::result::Result<(), rustc_span[641b1e127128c80]::ErrorGuaranteed>, rustc_driver_impl[d6b1c5b97f2d776c]::run_compiler::{closure#0}>::{closure#1}, core[f2f627d3c87d2691]::result::Result<(), rustc_span[641b1e127128c80]::ErrorGuaranteed>>::{closure#0}, core[f2f627d3c87d2691]::result::Result<(), rustc_span[641b1e127128c80]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[f2f627d3c87d2691]::result::Result<(), rustc_span[641b1e127128c80]::ErrorGuaranteed>>::{closure#1} as core[f2f627d3c87d2691]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0} 33: 0x7044d506fd6b - std::sys::pal::unix::thread::Thread::new::thread_start::h5ac727470998e7f2 34: 0x7044d680d39d - <unknown> 35: 0x7044d689249c - <unknown> 36: 0x0 - <unknown> rustc version: 1.82.0-nightly (f167efad2 2024-08-24) platform: x86_64-unknown-linux-gnu query stack during panic: #0 [check_well_formed] checking that `<impl at src/lib.rs:21:1: 21:33>` is well-formed rust-lang/rust-clippy#1 [check_mod_type_wf] checking that types are well-formed in top-level module rust-lang/rust-clippy#2 [analysis] running analysis passes on this crate end of query stack ``` </p> </details>
I-ICE,T-compiler,C-bug,requires-nightly,F-generic_const_exprs,F-adt_const_params,S-bug-has-test
low
Critical
2,485,273,274
rust
Compiler does not recognize the reserve-r9 target feature
This issue is similar to [this](https://github.com/rust-lang/rust/issues/121970) issue. On the armv7a-none-eabi target, specifying the reserve-r9 target feature using the flag -Ctarget-feature=+reserve-r9 results in the following warning: ``` warning: unknown and unstable feature specified for `-Ctarget-feature`: `reserve-r9` | = note: it is still passed through to the codegen backend, but use of this feature might be unsound and the behavior of this feature can change in the future = help: consider filing a feature request ``` The feature is currently working and is used by me and [others](https://internals.rust-lang.org/t/fixed-r9-in-arm/20842) too.
A-LLVM,O-Arm,T-compiler,A-target-feature
low
Minor
2,485,323,688
godot
Node Instantiation Fails with NativeAOT Enabled in Export Release Mode
### Tested versions - Reproducible in Godot v4.3.stable.mono - Reproducible in Godot v4.2.x.stable.mono (although the error text is different) ### System information iOS 17.6.1 (Not in debug mode) Windows 11 (NativeAOT enabled & release mode) ### Issue description ~~This is a bug that appears to only affect iOS based devices when distributing one's `.ipa` through Apple's App Store (so App Store Connect). This does not occur on iOS when distributing through a debug build on Xcode. When I first load my scene, many of the `Nodes` load properly, but when I get to the top level `Node3D` that contains most of my game level, it fails to instantiate. The error logs show this:~~ ``` USER ERROR: Index nprops[j].value = 61545 is out of bounds (prop_count = 58). at: instantiate (scene/resources/packed_scene.cpp:314) ``` ~~This leads me to believe that it could be related to Apple's restrictions on dynamic code via reflection which is still present in some of Godot's codebase for C#. I tested this with a release build on Android through Google Play and this error does not occur there either.~~ **UPDATE** It took a long time for me to figure out the exact configuration that was causing the primary world `Node3D` from instancing since my project has over a hundred `Node3D` instances that are a part of that `PackedScene`. However, I believe I've narrowed it down to a single `MeshInstance3D` that appears to be responsible. This `MeshInstance3D` has a script attached that utilizes an `[Export]` variable of type `StandardMaterial3D` and applies that to the `MeshInstance3D` on `_Ready()`. I apply a default value in the editor. And in the actual root world where I drag and drop multiple instances I replace this `[Export]` value with various different `StandardMaterial3D` assets. When I remove the `[Export]` variable and just supply the `StandardMaterial3D` with `ResourceLoader.Load()` instead, the error no longer occurs. Sooo, the workaround is to **NOT** use `[Export]` for `Object`s that inherit from `[Resource]`. As a side note, I also back all of my `Resource`s that I instance from `ResourceLoader` into a static `Dictionary` that prevents premature disposal of `Resource`s. This may or may not be a separate issue altogether which I note below, but seems related. This is a **difficult** bug to reproduce as I've not found a way yet to create a minimal reproduction sample. My guess is that this bug only has a small chance of happening but since my project has so many eligible `Nodes` for this bug to occur, it was happening to me almost all the time. Nonetheless, here's how one may encounter it... ### Steps to reproduce - Create a project with a basic world that has `Node3D` as the root. - Create another `Node3D` with a `MeshInstance3D` and attach a script. - That script should contain an `[Export]` variable that is some kind of material like `StandardMaterial3D`. - Give that material a default value in the editor. (not in the script) - Apply that material to the `MeshInstance3D` on `_Ready()` - Now put multiple instances of these `MeshInstance3D` nodes in the world. - Give each of those instances a different value for the [Export] variable in the root world. - Export with NativeAOT enabled and debug mode off. (Can also be iOS uploaded to App Store Connect since those are the defaults) ### Minimal reproduction project (MRP) N/A
platform:ios,needs testing,topic:dotnet,topic:export
low
Critical
2,485,332,143
godot
When running in Wayland, taskbar and window icons do not use Godot icon because Godot does not use a consistent `app_id` throughout its execution
### Tested versions Reproducible in v4.3.stable.official [77dcf97d8], v4.3.rc1.official [e343dbbcc] ### System information Gentoo Linux, KDE Plasma 5.27.11, Wayland graphics platform ### Issue description Wayland maps a window to an application by matching the application's `app_id` to a matching `.desktop` file in `/usr/share/applications` or `~/.local/share/applications/`. The `.desktop` file included in the Godot source is `misc/dist/linux/org.godotengine.Godot.desktop`, meaning that once that file is properly copied to the appropriate directories Wayland will only be able to match the window to the application when the app_id is exactly `org.godotengine.Godot`. The `.desktop` files appropriately placed in the application directories is also what allows application menus to automatically populate all the applications installed in the system. In `platform/linuxbsd/wayland/display_server_wayland.cpp`, function `DisplayServerWayland::_get_app_id_from_context`, Godot sets a different app_id based on the context it is running in: `org.godotengine.Editor`, `org.godotengine.ProjectManager`, `org.godotengine.Godot`, or the value set in `application/config/name`. Consequently the taskbar and window frame show the default Wayland app icon instead of the Godot icon. The value set in `application/config/name` would of course be the user's responsibility to have a `.desktop` file appropriate for their own game, so that is not an issue for this bug, although may require some documentation changes to note the connection between the `application/config/name` and the user’s own generated and distributed `.desktop` file. ### Steps to reproduce Enable the Prefer Wayland option in the editor settings. Copy the file `misc/dist/linux/org.godotengine.Godot.desktop` to either `/usr/share/applications` or `~/.local/share/applications/` Run Godot, opens in ProjectManager context with the app_id org.godotengine.ProjectManager. Open a project, Godot reloads with the app_id org.godotengine.Editor In both of these contexts, the taskbar and window decoration icons use the default Wayland icon. ### Minimal reproduction project (MRP) N/A
bug,platform:linuxbsd,topic:porting
low
Critical
2,485,342,783
godot
Grabbing native Popup window resize edge closes window instead of resizing
### Tested versions - 4.3.stable ### System information macOS 14.6.1 ### Issue description On resizable native Windows (and Popups) you can grab the edge to resize them. At least on macOS the system makes it easier for you to resize by allowing you to grab the window edge a couple of pixels inside and a couple of pixels outside the window edge, as indicated by where the cursor changes to a resize cursor. On resizable native Window object in Godot this works as expected as you can see. However for Popup windows, if you start doing the resize outside the window the popup closes instead. https://github.com/user-attachments/assets/f09327db-f626-4903-a94e-b7a99fb24b13 Since popups can be dismissed by clicking outside them I'm guessing this is simply what is happening, and it's not accounting for the fact that this click outside the window should actually start a resize drag instead of dismissing the Popup. ### Steps to reproduce Show a native resizable Popup window using popup() Try grabbing the edge to resize it where the cursor changes to the resize cursor just outside the window edge. Observe the popup close. ### Minimal reproduction project (MRP) [popupresize.zip](https://github.com/user-attachments/files/16740994/popupresize.zip)
bug,topic:gui
low
Minor
2,485,346,160
ui
[bug]: Input field has default bg-white and text-white
### Describe the bug When importing a Input field it has default text-white and bg-white for the input field. This gets bad after the focus is on the input field and have to manually make changes in the input ui component of the projects. ![Screenshot from 2024-08-25 21-04-59](https://github.com/user-attachments/assets/05d2b53c-1458-4a4a-859b-d1617e9f1523) This image show that there is text in the input filed because we can see the auto-correct's red underline. ![Screenshot from 2024-08-25 21-06-41](https://github.com/user-attachments/assets/15dd79b5-b9ed-4523-b17b-56c966a0faa7) Here i have attached a snapshot of the code that I have made change to to resolve this issue. ### Affected component/components Input ### How to reproduce 1. Import **Input** component from [ui.shadcn.com](https://ui.shadcn.com/docs/components/input) to you project folder. 2. Use the input component in you code with proper import statements. 3. Start the development server and open the localhost:3000. 4. Start typing in the input field. ### Codesandbox/StackBlitz link _No response_ ### Logs No response in log ### System Info ```bash browser- brave 128(latest updated version) system - Linux os- Ubuntu version-22.04 system-binaries up-to date and other system files. ``` ### Before submitting - [X] I've made research efforts and searched the documentation - [x] I've searched for existing issues
bug
low
Critical
2,485,374,362
vscode
Terminal Suggest: Add support for other shells (eg. zsh, bash)
<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Describe the feature you'd like. --> ### Feature Request https://github.com/microsoft/vscode/labels/terminal-suggest support for zsh and bash shells, similar to the [existing support for Powershell](https://code.visualstudio.com/docs/terminal/shell-integration#_experimental-intellisense-for-powershell): ![image](https://github.com/user-attachments/assets/ee16e15d-766f-4b65-bd0f-eb2d2cb06880) Ideally, VS Code would pick up the completions that a user already configured for their terminal. As a zsh user (at work) and bash user (at home), I wouldn't mind if enabling this feature required some minimal `.zshrc`/`.bashrc` changes (we're used to that kind of thing). It also wouldn't be a deal-breaker if I needed to hit TAB to generate the list of completions, but it'd be nice to have the completions updated after each input change. ### Motivation Terminal completion pop-ups are a feature available in several newer terminals/IDE's like Warp, Fig/AmazonQ, and JetBrains/IntelliJ. I'm quite excited to see that VS Code is adding support for this! However, switching to pwsh isn't in the cards for me. Plus, my teammates all use either zsh or bash, and it's harder for me to sell the idea of using VS Code without this feature. Beyond the obvious aesthetic improvement, having a pop-up, scrollable list of options can be quite helpful for long lists of completion options, such as `git <TAB>`: ``` zsh: do you wish to see all 141 possibilities (141 lines)? ``` ### Prior Work PR https://github.com/microsoft/vscode/pull/211962 disabled the https://github.com/microsoft/vscode/labels/terminal-suggest feature for all shells except powershell. Therefore it seems not possible to use this feature for any other shells, even with an extension.
feature-request,on-testplan,api-proposal,terminal-suggest
low
Major
2,485,380,962
rust
`slice::Iter` + `max` on array: Regression since Rust 1.65 (LLVM 15)
<!-- Thank you for filing a regression report! 🐛 A regression is something that changed between versions of Rust but was not supposed to. Please provide a short summary of the regression, along with any information you feel is relevant to replicate it. --> ### Code I tried this code: ```rust pub fn fna(x: [u8; 1024]) -> u8 { x.into_iter().max().unwrap() } pub fn fnb(x: [u8; 1024]) -> u8 { *x.iter().max().unwrap() } ``` [Godbolt](https://rust.godbolt.org/z/f36snahTn) I expected to see this happen: 1. Both functions should optimize away the unwrap 2. (Bonus) Both functions should inline the respective iterator functions and auto-vectorize Instead, this happened: 1. `fna` has no unwrap in the assembly output, but `fnb` has. 2. (Bonus) Both inline their respective iterators (according to the MIR output on the playground). `fna` auto-vectorizes, but `fnb` doesn't. `fnb` generates a byte-wise max implementation. Interestingly, it keeps _some_ information about the array length around, influencing the codegen. A byte-wise `max` implementation for `[u8; 1024]` will need to do 1023 comparisons (since the first value of the array will be the initial `max` result value), and 1023 is divisible by 3, so the compiler emits a loop that emits a loop that runs 341 times, doing 3 `max` computations each. If I change the length of the array to 1025, it will do 4 `max` computations each. Even though the generated code relies on the number of array entries, it still doesn't elide the `Option::unwrap` check for the `max` result. In Rust 1.45-1.64 `fnb` also generates the 3-byte-at-a-time loop, but _does_ remove the `Option::unwrap`. ### Version it worked on It most recently worked on: Rust 1.64. (For context: Rust 1.65 added LLVM 15.) It (initially?) started working in 1.45 (that version added LLVM 10). ### Version with regression Any version since Rust 1.65. ----- Since I thought this behavior was unexpected, I polled it on mastodon before looking further into it. ATM about half of the respondents thought just like me that both should be optimized (at least the unwrap part): ![image](https://github.com/user-attachments/assets/809ff640-b7b2-42dd-98af-a28aaa1706f2)
A-LLVM,I-slow,P-low,T-compiler,C-bug,regression-untriaged,llvm-fixed-upstream
low
Major
2,485,384,707
ollama
ONNX backend runtime support to simplify HW support?
A repetitive issue I see coming up over and over again is people not being able to run models on their hardware for any number of reasons, one of the biggest being that llama.cpp has not incorporated the proper level of support for their chosen hardware manufacture or hardware SDK. If I understand the goal of Ollama correctly to be a nice easy way of running LLMs with an API layer over lower level LLM libraries, would it make sense to heavily consider moving to a single solution runtime that can provide support of most all hardware configurations (aka ONNX)? These are some of the most commented PRs currently and there will probably be more to come from increasingly smaller/niche HW vendors (examples: Ascend NPU or Google Coral TPU): - https://github.com/ollama/ollama/pull/5593 - https://github.com/ollama/ollama/pull/5059 - https://github.com/ollama/ollama/pull/2458 - https://github.com/ollama/ollama/pull/5426 - https://github.com/ollama/ollama/pull/5872 Would it maybe make more sense to offload this hard work to the ONNX runtime folks and keep Ollama focused on what it is good at, being a great API for LLM inference? I realize this would require a massive amount of work to implement yet another backend, but I am making this ticket more as a callout for a trend I see in some of the Ollama tickets. https://onnxruntime.ai/docs/execution-providers/
feature request
low
Major
2,485,391,158
rust
asm: Since nightly-2024-08-01 (LLVM 19), in and out is sometime allocated to the same register
<!-- Thank you for filing a bug report! 🐛 Please provide a short summary of the bug, along with any information you feel relevant to replicating the bug. --> Repro: ```sh # Prerequisite: Environment that can compile or cross-compile aach64-linux-gnu git clone https://github.com/taiki-e/atomic-maybe-uninit.git cd atomic-maybe-uninit git checkout v0.3.2 RUSTFLAGS='-C target-feature=+lse' \ ./tools/test.sh --tests --target aarch64-unknown-linux-gnu --release --no-run ``` I expected to see this happen: compile pass Instead, this happened: ``` error: unpredictable STXP instruction, status is also a source --> src/arch/aarch64.rs:571:37 | 571 | ... concat!("st", $release, "xp {tmp:w}, {val_lo}, {val_hi}, [{dst}]"), | ^ | note: instantiated into assembly here --> <inline asm>:3:6 | 3 | stxp w8, x8, x23, [x9] | ^ error: unpredictable STXP instruction, status is also a source --> src/arch/aarch64.rs:571:37 | 571 | ... concat!("st", $release, "xp {tmp:w}, {val_lo}, {val_hi}, [{dst}]"), | ^ | note: instantiated into assembly here --> <inline asm>:3:7 | 3 | stlxp w8, x8, x23, [x9] | ^ ``` [This](https://github.com/taiki-e/atomic-maybe-uninit/blob/v0.3.2/src/arch/aarch64.rs#L565-L580) is the inline assembly that received the error, and `tmp` and `val_lo` which the compiler assigned the same registers are `out` and `in`, respectively. ```rs val_lo = in(reg) val.pair.lo, val_hi = in(reg) val.pair.hi, tmp = out(reg) _, ``` Those two must not be allocated the same register, but for some reason the compiler seems to be treating `out` as if it were [`lateout`](https://doc.rust-lang.org/nightly/reference/inline-assembly.html#asm.operand-type.supported-operands.lateout). > lateout(\<reg\>) \<expr\> > Identical to `out` except that the register allocator can reuse a register allocated to an `in`. I have confirmed that at least the following three targets are affected: - aarch64-unknown-linux-gnu ([ci log](https://github.com/taiki-e/atomic-maybe-uninit/actions/runs/10190828070/job/28191393249#step:19:2610)) - aarch64_be-unknown-linux-gnu ([ci log](https://github.com/taiki-e/atomic-maybe-uninit/actions/runs/10190828070/job/28191393573#step:19:4375)) - riscv64gc-unknown-linux-gnu ([ci log](https://github.com/taiki-e/atomic-maybe-uninit/actions/runs/10190828070/job/28191401156#step:15:3091)) As for riscv64gc-unknown-linux-gnu, I consistently get the [unexpected result](https://github.com/taiki-e/atomic-maybe-uninit/actions/runs/10190828070/job/28191401156#step:15:3091) at runtime (not compile error) in exactly the same version range. In the aarch64 case, the problem appeared in a form that the assembler could detect as an error, resulting in a compilation error, but in some situations, as in the riscv64 case, the code may be silently miscompiled. ### Meta <!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. --> `rustc --version --verbose`: ``` rustc 1.82.0-nightly (f167efad2 2024-08-24) binary: rustc commit-hash: f167efad2f51088d86180ee89177b3d7c9e7c2f5 commit-date: 2024-08-24 host: aarch64-unknown-linux-gnu release: 1.82.0-nightly LLVM version: 19.1.0 ``` It can be reproduced with nightly-2024-08-01 or later. ``` rustc 1.82.0-nightly (28a58f2fa 2024-07-31) binary: rustc commit-hash: 28a58f2fa7f0c46b8fab8237c02471a915924fe5 commit-date: 2024-07-31 host: aarch64-unknown-linux-gnu release: 1.82.0-nightly LLVM version: 19.1.0 ``` The last version *not* affected by the problem is nightly-2024-07-31, which uses LLVM 18, so it seems likely that the update to LLVM 19 (https://github.com/rust-lang/rust/pull/127513) caused this regression. cc @nikic ``` rustc 1.82.0-nightly (f8060d282 2024-07-30) binary: rustc commit-hash: f8060d282d42770fadd73905e3eefb85660d3278 commit-date: 2024-07-30 host: aarch64-unknown-linux-gnu release: 1.82.0-nightly LLVM version: 18.1.7 ``` --- @rustbot label +I-unsound, +A-LLVM, +A-inline-assembly
A-LLVM,A-inline-assembly,P-high,T-compiler,I-unsound,C-bug,WG-llvm,regression-untriaged,llvm-fixed-upstream,I-miscompile
low
Critical
2,485,396,574
pytorch
[torch.export] Extraneous warnings from torch/fx/experimental/recording.py (related to overloads)
### 🐛 Describe the bug I am starting to see extraneous warnings from `torch/fx/experimental/recording.py:298` when using torch.export. Here's a simple example that reproduces this issue: ```python import torch import torch.ao.quantization.fx class Qdq(torch.nn.Module): def __init__(self): super().__init__() def forward(self, x, x_scale, x_zp ): x_q = torch.ops.quantized_decomposed.quantize_per_tensor( # type: ignore x, x_scale, x_zp, -127, 127, torch.int8) x_dq = torch.ops.quantized_decomposed.dequantize_per_tensor( # type: ignore x_q, x_scale, x_zp, -127, 127, torch.int8) return x_dq p_qdq = torch.export.export( # type: ignore Qdq().eval(), ( torch.randn([4,4]), torch.tensor(1/127, dtype=torch.float), torch.tensor(0, dtype=torch.float) ) ) ``` The following warnings get generated when I run this code: ``` W0825 10:43:38.969793 16100 torch/fx/experimental/symbolic_shapes.py:5131] failed during evaluate_expr(zuf0, hint=None, expect_rational=False, size_oblivious=False, forcing_spec=False E0825 10:43:38.970002 16100 torch/fx/experimental/recording.py:298] failed while running evaluate_expr(*(zuf0, None), **{'fx_node': False, 'expect_rational': False}) W0825 10:43:39.010174 16100 torch/fx/experimental/symbolic_shapes.py:5131] failed during evaluate_expr(zuf0, hint=None, expect_rational=False, size_oblivious=False, forcing_spec=False E0825 10:43:39.010313 16100 torch/fx/experimental/recording.py:298] failed while running evaluate_expr(*(zuf0, None), **{'fx_node': False, 'expect_rational': False}) ... snipped ... ``` The warnings seem to go away if I specify the precise overload (i.e., change `torch.ops.quantized_decomposed.quantize_per_tensor` to `torch.ops.quantized_decomposed.quantize_per_tensor.tensor`), but this defeats the point of defining and using overloads (unless I am missing something). Does the warning in `recordings.py` need to take into account the actual overload (in this case `.tensor`) that is invoked? Please let me know if I can provide more information. PyTorch Version: `2.5.0.dev20240821+cpu` Thanks! ### Versions Collecting environment information... PyTorch version: 2.5.0.dev20240821+cpu Is debug build: False CUDA used to build PyTorch: None ROCM used to build PyTorch: N/A OS: Debian GNU/Linux 11 (bullseye) (x86_64) GCC version: (Debian 10.2.1-6) 10.2.1 20210110 Clang version: 11.0.1-2 CMake version: version 3.30.2 Libc version: glibc-2.31 Python version: 3.10.0 | packaged by conda-forge | (default, Nov 20 2021, 02:24:10) [GCC 9.4.0] (64-bit runtime) Python platform: Linux-4.12.14-122.183-default-x86_64-with-glibc2.31 Is CUDA available: False CUDA runtime version: No CUDA CUDA_MODULE_LOADING set to: N/A GPU models and configuration: No CUDA Nvidia driver version: No CUDA cuDNN version: No CUDA HIP runtime version: N/A MIOpen runtime version: N/A Is XNNPACK available: True Versions of relevant libraries: [pip3] executorch==0.4.0a0+26e921e [pip3] numpy==1.26.4 [pip3] onnx==1.16.2 [pip3] torch==2.5.0.dev20240821+cpu [pip3] torchaudio==2.4.0.dev20240821+cpu [pip3] torchsr==1.0.4 [pip3] torchvision==0.20.0.dev20240821+cpu [conda] executorch 0.4.0a0+26e921e pypi_0 pypi [conda] numpy 1.26.4 pypi_0 pypi [conda] torch 2.5.0.dev20240821+cpu pypi_0 pypi [conda] torchaudio 2.4.0.dev20240821+cpu pypi_0 pypi [conda] torchsr 1.0.4 pypi_0 pypi [conda] torchvision 0.20.0.dev20240821+cpu pypi_0 pypi cc @ezyang @chauhang @penguinwu @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @angelayi @suo @ydwu4
triaged,oncall: pt2,module: dynamic shapes,oncall: export
low
Critical
2,485,408,495
PowerToys
Unicode Codepoint Picker
### Description of the new feature / enhancement A keybound popout for that is similar in use to the existing ["emoji keyboard"](https://support.microsoft.com/en-us/windows/windows-keyboard-tips-and-tricks-588e0b72-0fff-6d3f-aeee-6e5116097942#:~:text=During%20text%20entry%2C%20type%20Windows%20logo%20key%C2%A0%C2%A0%2B%20.%20(period).%20The%20emoji%20keyboard%20will%20appear.) (emoji picker) that's bound to <kbd>⊞ + .</kbd> / <kbd>Super + .</kbd> The difference being that it searches uncode codepoints rather than emojis. Could have a lot of info like [unicode-explorer.com](https://unicode-explorer.com/c/200C) does, or could be a simple search by designated name like "ZERO WIDTH NON-JOINER" ### Scenario when this would be used? I'm very often using google to search for unicode codepoints so I can copy them, would be nice to have something like this easily accessible. ### Supporting information I don't understand what this section is for but I probably don't need it
Needs-Triage
low
Minor
2,485,435,031
angular
devtools injector preview (inside components tab) displays invalid NgModule injector
### Which @angular/* package(s) are the source of the bug? devtools ### Is this a regression? Yes ### Description **TL;DR; Displaying NgModule-related injectors is invalid.** setup, cases: - EmployeeListingComponent has `EmployeeService` injected - 2 cases compared: - case 1: svc is `providedIn: root` - case 2: svc is **additionally** provided in `@NgModule` `EmployeesModule` #### case 1 (correct) As expected, the path of injectors from component's local injector up to the root is displayed. There's only 1 provided (root), everything is fine. <img width="2402" alt="image" src="https://github.com/user-attachments/assets/98b58bf3-c104-47cc-b47b-dcaa73f00e9b"> ---- #### case 2 (incorrect), svc is **additionally** provided in `@NgModule` `EmployeesModule` what's wrong: - image is misleading: injector traversal goes bottom->up. And there are 2 instance providers (1 in root, 1 in NgModule). So assuming the image is correct, the root one should be found first... but the image is probably not right: - I think NgModule injector should **NOT** be above the root injector (it's a child module, the root shouldn't be a child of a child module, etc.); shouldn't EmployeeModule injector's providers be "flattened" with root injector? <img width="2361" alt="image" src="https://github.com/user-attachments/assets/d7f2f143-8190-4a4f-af22-bfddd0b81a67"> there's code (`employee.module.ts`) which makes sure that the instance is grabbed from the proper injector ```ts // 👇 HERE providers: [{ provide: EmployeesService, useFactory: () => { const http = inject(HttpClient) const svc = new EmployeesService(http) svc.origin = 'employees.module' return svc } }], ``` <img width="989" alt="image" src="https://github.com/user-attachments/assets/892e20ec-bf95-494c-8e10-86f220f64787"> ---- **moreover** I'm unable to find the EmployeeModule in the `injector tree tab` :( (note that EmployeeModule and Employee_**Routing**_Module are **different**). <img width="2045" alt="image" src="https://github.com/user-attachments/assets/4e8a26f7-bded-4111-b398-02b413848460"> ## important: toggling between case1 and case2 [`employee.module.ts` - remove the only provider](https://github.com/ducin/angular-bug-repros/commit/65e9bc6b3db5766a38c89f94760bbb13cb90f604#diff-7826b7a18690077bfbd65e8eb33348a8e594dda5c77e2bf1e21c8b314fd75f51) ### Please provide a link to a minimal reproduction of the bug https://github.com/ducin/angular-bug-repros/tree/devtools_components_tab_previewing_injector_lookup ### Please provide the exception or error you saw _No response_ ### Please provide the environment you discovered this bug in (run `ng version`) ```true angular v18.1.3, devtools: 1.0.17 node: v20.13.1 npm: 10.5.2 os: macos sonoma v14.5 ``` ### Anything else? _No response_
area: devtools
low
Critical
2,485,455,600
tauri
[bug] Exclude app_icon (Vec<u8>) from tracing instrumentation (`wry::ipc::handle`)
### Describe the bug I am trying to debug an application that I have written with Tauri. I enabled the tracing feature. When the app tries to handle a `tauri::command` my application freezes because it is trying to log the entire app icon as a `Vec<u8>`. The log looks like the following: ``` 2024-08-25T20:22:57.189423Z DEBUG wry::ipc::handle:window::on_message{self=Window { window: DetachedWindow { label: "main", dispatcher: WryDispatcher { window_id: 7354931179636518423, context: Context { main_thread_id: ThreadId(1), proxy: EventLoopProxy { <other stuff here> }, TauriConfig{ <other stuff here...>, app_icon: Some([105, 99, 110, 115, 0, 7, 53, 156, 105, 99, 49, 50, 0, 0, 18, 110, 137, 80, 78, 71, 13, 10, 26, 10, 0, 0, 0, 13, 73, 72, 68, 82, 0, 0, 0, 64, 0, 0, 0, 64, 8, 6, 0, 0, 0, 170, 105, 113, 222, 0, 0, 18, 45, 73, 68, 65, 84, 120, 156, 229, 91, 105, 116, 28, 213, 149, 190, 146, 122, 239, 214, 210, 146, 90, 82, 183, 118, 75, 224, 93, 216... ``` ### Reproduction Create a `tauri` application, add an app icon, then, enable tracing in your `Cargo.toml`, In `Cargo.toml`: ```toml [features] tauri-tracing = ["tauri/tracing"] ``` Set up tracing in your application ```rust fn setup_tracing() { let filter: Directive = LevelFilter::DEBUG.into(); let env_filter = EnvFilter::builder() .with_default_directive(filter) .from_env_lossy() .add_directive("h2=warn".parse().unwrap()) .add_directive("rustls=warn".parse().unwrap()) .add_directive("yup_oauth2::authenticator=warn".parse().unwrap()) .add_directive("hyper=warn".parse().unwrap()); let subscriber = tracing_subscriber::registry() .with(tracing_subscriber::fmt::layer().with_filter(env_filter)); #[cfg(all(debug_assertions, not(windows)))] // set up tokio-console if we're running in debug mode let subscriber = subscriber.with(console_subscriber::spawn()); subscriber.init(); } fn main() { let _sentry_guard = setup_tracing(); let state = InfraState::new(); tauri::Builder::default() .manage(state) .on_page_load(page_load_handler) .invoke_handler(tauri::generate_handler![ a_command ]) .run(tauri::generate_context!()) .expect("error while running tauri application"); } ``` Then run the application: ```shell RUST_DEBUG=1 NODE_TLS_REJECT_UNAUTHORIZED=0 RUST_BACKTRACE=full NO_COLOR=true yarn tauri dev -v --features tauri-tracing > app.log 2>&1 ``` ### Expected behavior The `app_icon` isn't necessary (in my opinion), and just clogs the logs. I'm hoping you can exclude it? ### Full `tauri info` output ```text ❯ yarn tauri info yarn run v1.22.19 $ tauri info [✔] Environment - OS: Mac OS 14.6.1 X64 ✔ Xcode Command Line Tools: installed ✔ rustc: 1.82.0-nightly (2c93fabd9 2024-08-15) ✔ cargo: 1.82.0-nightly (2f738d617 2024-08-13) ✔ rustup: 1.27.1 (54dd3d00f 2024-04-24) ✔ Rust toolchain: nightly-aarch64-apple-darwin (overridden by '/Users/msamdars/Code/omicspipelines-infrastructure/rust-toolchain.toml') - node: 20.11.0 - pnpm: 9.7.1 - yarn: 1.22.19 - npm: 10.2.4 - bun: 1.1.25 [-] Packages - tauri [RUST]: 1.7.2 - tauri-build [RUST]: 1.5.4 - wry [RUST]: 0.24.10 - tao [RUST]: 0.16.9 - @tauri-apps/api [NPM]: 1.6.0 - @tauri-apps/cli [NPM]: 1.6.1 [-] App - build-type: bundle - CSP: unset - distDir: ../build - devPath: http://localhost:9090/ - framework: React - bundler: Rollup ✨ Done in 2.69s. ```
type: bug,status: needs triage
low
Critical
2,485,460,176
vscode
Since latest update on 8/15 jupyter notebooks in Vs code very slow
Type: <b>Performance Issue</b> I have a large machine with plenty of ram. I have been using notebooks in vs code for a long time. It seems that lately, cell execution has gotten very slow. I have disabled extensions and restarted several times and swapped out virtual environments. VS Code version: Code 1.92.2 (fee1edb8d6d72a0ddff41e5f71a671c23ed924b9, 2024-08-14T17:29:30.058Z) OS version: Windows_NT x64 10.0.22631 Modes: <details> <summary>System Info</summary> |Item|Value| |---|---| |CPUs|AMD Ryzen 7 7735HS with Radeon Graphics (16 x 3194)| |GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: enabled_on<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: enabled<br>video_encode: enabled<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled<br>webgpu: enabled<br>webnn: disabled_off| |Load (avg)|undefined| |Memory (System)|63.19GB (41.90GB free)| |Process Argv|--folder-uri file:///c%3A/dev/projects/eda --crash-reporter-id 8a92ac4e-fcf5-40b5-944a-4562e27ae96f| |Screen Reader|no| |VM|0%| </details><details> <summary>Process Info</summary> ``` CPU % Mem MB PID Process 0 115 6444 code main 0 96 3580 ptyHost 0 8 1880 conpty-agent 0 5 5004 C:\Windows\System32\cmd.exe 0 5 7416 C:\Windows\System32\cmd.exe 0 8 26076 conpty-agent 0 628 8956 extensionHost [1] 0 17 4968 c:\Users\vinoo\.conda\envs\dataengineering\python.exe c:\Users\vinoo\.vscode\extensions\ms-toolsai.jupyter-2024.7.0-win32-x64\pythonFiles\vscode_datascience_helpers\kernel_interrupt_daemon.py --ppid 8956 0 10 25132 C:\Windows\system32\conhost.exe 0x4 0 8 7452 c:\Users\vinoo\.vscode\extensions\ms-python.python-2024.12.3-win32-x64\python-env-tools\bin\pet.exe server 0 10 26512 C:\Windows\system32\conhost.exe 0x4 0 202 9972 electron-nodejs (tvrV.js ) 0 10 6080 C:\Windows\system32\conhost.exe 0x4 0 42 13260 "C:\Program Files\nodejs\node.exe" c:\Users\vinoo\.vscode\extensions\mtxr.sqltools-0.28.3\dist\languageserver.js --node-ipc --clientProcessId=8956 0 10 2268 C:\Windows\system32\conhost.exe 0x4 0 15 15264 c:\Users\vinoo\.vscode\extensions\continue.continue-0.8.46-win32-x64\out\node_modules\@esbuild\win32-x64\esbuild.exe --service=0.17.19 --ping 0 13 13128 C:\Windows\system32\conhost.exe 0x4 0 52 23340 C:\Users\vinoo\.conda\envs\dataengineering\python.exe c:\Users\vinoo\.vscode\extensions\ms-python.python-2024.12.3-win32-x64\python_files\run-jedi-language-server.py 0 10 15972 C:\Windows\system32\conhost.exe 0x4 0 97 9200 window 0 92 9292 fileWatcher [1] 0 40 10540 utility-network-service 0 239 11216 window [1] (● b2b_purchases.ipynb - eda - Visual Studio Code) 0 117 15504 shared-process 0 101 15548 gpu-process 0 103 15636 window [2] (Issue Reporter) 0 28 25856 crashpad-handler 0 92 26428 window ``` </details> <details> <summary>Workspace Info</summary> ``` | Window (● b2b_purchases.ipynb - eda - Visual Studio Code) | Folder (eda): 7 files | File types: csv(4) ipynb(2) pdf(1) | Conf files:; ``` </details> <details><summary>Extensions (28)</summary> Extension|Author (truncated)|Version ---|---|--- amazon-q-vscode|ama|1.22.0 aws-toolkit-vscode|ama|3.21.0 continue|Con|0.8.46 vscode-eslint|dba|3.0.10 vsc-python-indent|Kev|1.18.0 sqltools-driver-redshift|kj|0.0.4 rainbow-csv|mec|3.12.0 vscode-docker|ms-|1.29.2 debugpy|ms-|2024.10.0 python|ms-|2024.12.3 jupyter|ms-|2024.7.0 jupyter-keymap|ms-|1.1.2 remote-containers|ms-|0.380.0 remote-wsl|ms-|0.88.2 sqltools|mtx|0.28.3 sqltools-driver-sqlite|mtx|0.5.1 autodocstring|njp|0.6.1 r-debugger|RDe|0.5.4 r|REd|2.8.4 LiveServer|rit|5.7.9 salesforce-vscode-slds|sal|1.4.10 salesforcedx-vscode|sal|61.10.0 salesforcedx-vscode-core|sal|61.10.0 salesforcedx-vscode-lwc|sal|61.10.0 salesforcedx-vscode-soql|sal|61.10.0 salesforcedx-vscode-visualforce|sal|61.10.0 pdf|tom|1.2.2 vscode-todo-highlight|way|1.0.5 </details><details> <summary>A/B Experiments</summary> ``` vsliv368:30146709 vspor879:30202332 vspor708:30202333 vspor363:30204092 vscod805cf:30301675 binariesv615:30325510 vsaa593:30376534 py29gd2263:31024239 c4g48928:30535728 azure-dev_surveyone:30548225 a9j8j154:30646983 962ge761:30959799 pythongtdpath:30769146 welcomedialog:30910333 pythonnoceb:30805159 asynctok:30898717 pythonregdiag2:30936856 pythonmypyd1:30879173 2e7ec940:31000449 pythontbext0:30879054 accentitlementst:30995554 dsvsc016:30899300 dsvsc017:30899301 dsvsc018:30899302 cppperfnew:31000557 dsvsc020:30976470 pythonait:31006305 dsvsc021:30996838 724cj586:31013169 pythoncenvpt:31062603 a69g1124:31058053 dvdeprecation:31068756 dwnewjupyter:31046869 newcmakeconfigv2:31071590 impr_priority:31102340 nativerepl1:31104043 refactort:31108082 pythonrstrctxt:31112756 wkspc-onlycs-t:31111718 wkspc-ranged-c:31123312 ei213698:31121563 ``` </details> <!-- generated by issue reporter -->
under-discussion,notebook-output
low
Critical
2,485,460,204
material-ui
[Grid2] Rollout plan
### Summary We recently made Grid v2 stable, #43054 so now it's time to look at the rollout plan, effectively to get completely get rid of the old one. A possible action plan: - [ ] 0. Fix the migration experience - [ ] 0.a. There is no clear warning when doing `<Grid2 item>`. It says: <img width="584" alt="SCR-20241127-papu" src="https://github.com/user-attachments/assets/efc78fda-4ef4-43e8-91ce-1f308f37f694"> I think we need a custom prop type instead, that clearly explain that this is a Grid v1 prop, that you can now remove the prop. - [ ] 0.b. There is no clear prop-type warning when doing `<Grid2 xs={12}>`. The attribute gets silently applied to the DOM: <img width="186" alt="SCR-20241127-pcfd" src="https://github.com/user-attachments/assets/087d9097-95f8-4a6e-8531-4aa15ae22ca4"> - [ ] 0.c. I got the impression that the migration guide was started but not finished: https://mui.com/material-ui/migration/migration-grid-v2/. I couldn't rely a lot on it. The problems I saw: - It doesn't talk about what to do with the `xs`, `sm`, etc. props. - It references older version of Material UI before newer ones, isn't the order inverted? - It doesn't have a full set of step to go from Grid to Grid2 when using Material UI v6 - In https://mui.com/material-ui/migration/migration-grid-v2/#why-you-should-migrate we could list the value of not using negative margins: e.g. https://github.com/mui/mui-private/pull/685 - [ ] 1. Update the h1 in https://next.mui.com/material-ui/react-grid/ to mention deprecated, so Google and Algolia search results are clear - [ ] 2. ~Reexport Grid v2 from `@mui/system/Grid2` getting one step closer to move everyone imports from @mui/material to mui/system #40594~ - [ ] 3. Migrate all the MUI codebase to the Grid v2 - [ ] 4. Introduce a deprecation warning when using Grid v1 #42259 - [ ] 5. In the next major swap the implementation for the Grid namespace, put the deprecated Grid v1 into the exported GridLegacy namespace and deprecate Grid2 imports - [ ] 6. In the major after that next major, remove Grid2 and GridLegacy. ### Motivation Simplicity
umbrella,component: Grid,v6.x migration
low
Minor
2,485,462,262
ollama
glm4 model function call support
The glm4 model supports function calls, but the templates in the model repository do not.
feature request,model request
low
Major
2,485,485,810
godot
Export size of windows desktop executable increased in 4.3 compared to 4.2.2
### Tested versions v4.3.stable.official [77dcf97d8] v4.2.2.stable.official [15073afe3] ### System information Godot v4.3.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 Laptop GPU (NVIDIA; 32.0.15.6081) - AMD Ryzen 5 5600H with Radeon Graphics (12 Threads) ### Issue description I have a newly created project with one scene of Node2D in Godot v4.2.2. Exported executable with default export template and embedded PCK has size of 67,984 KB. The same project in v4.3 when exported with the same settings and "Compressed binary tokens" weights 82,151 KB. Hasn't 4.3 version aimed towards executable's size reduction? Or is this a feature for Web export only? ### Steps to reproduce 1. Create new project. 2. Add Node2D and save scene. 3. Export project with Windows Desktop option and embedded PCK. ### Minimal reproduction project (MRP) [MRP.zip](https://github.com/user-attachments/files/16742098/MRP.zip)
platform:windows,discussion,topic:buildsystem
low
Major
2,485,516,484
godot
get_gravity() doesn't update after move_and_collide()
### Tested versions v4.3.stable.mono.official [77dcf97d8] ### System information Godot v4.3.stable.mono - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 6GB (NVIDIA; 31.0.15.5244) - AMD Ryzen 5 2600X Six-Core Processor (12 Threads) ### Issue description `PhysicsBody2D.get_gravity()` is not updating its value after I call `move_and_collide()` I'm doing multiple iterations of move_and_collide() in one frame to draw a `Line2D` path in the direction the object will be going and stop at any collision point. The problem is that `get_gravity()`'s value doesn't change at all over the course of the iterations, it stays constant the entire time. I'm using `Area2D` nodes as gravity points, so the gravity value should never be constant for a moving object, and without `get_gravity()` updating I can never actually predict the path my object will take in the future. If this is intended behavior, there's no indication in the documentation. [It just says](https://docs.godotengine.org/en/stable/classes/class_physicsbody2d.html#class-physicsbody2d-method-get-gravity) `Returns the gravity vector computed from all sources that can affect the body` which is not the behavior I'm observing. ### Steps to reproduce Use multiple `move_and_collide()` iterations in one frame whilst the object is inside an `Area2D` with `gravity_point` enabled and observe that the value returned from `get_gravity()` is the same for every iteration. ### Minimal reproduction project (MRP) [get_gravity_bug_godot_4.3.zip](https://github.com/user-attachments/files/16742277/get_gravity_bug_godot_4.3.zip)
discussion,documentation,topic:physics,needs testing,topic:2d
low
Critical
2,485,517,917
godot
Internal Script Error (Opcode = 0)
### Tested versions Reproducible in Godot 4.3 Stable ### System information Godot v4.3.stable - macOS 14.6.1 - GLES3 (Compatibility) - Intel(R) Iris(TM) Plus Graphics OpenGL Engine (1x6x8 (fused) LP - Intel(R) Core(TM) i3-1000NG4 CPU @ 1.10GHz (4 Threads) ### Issue description When running my project, triggering a breakpoint, commenting out said breakpoint, saving, and continuing, Godot throws this error: ``` E 0:00:09:0562 Grid.gd:125 @ (): Condition ' (ip + 7 + _pointer_size) > _code_size ' is true. Breaking..: <C++ Source> modules/gdscript/gdscript_vm.cpp:693 @ call() <Stack Trace> Grid.gd:125 @ () ``` Continuing from there closes/crashed the running game menu. ### Steps to reproduce 1) Run the project. 2) When the breakpoint shows up, click continue. (might not be required) 3) When the next breakpoint shows up, comment out the breakpoint in the createError() function, save, and click continue. 4) Error should have appeared. Might be a little inconsistent, maybe a 90% chance. https://github.com/user-attachments/assets/79e8fa8d-326f-4849-9f92-98749fdcfa96 ### Minimal reproduction project (MRP) [opcode-=-0-rmp.zip](https://github.com/user-attachments/files/16742298/opcode-.-0-rmp.zip)
bug,topic:gdscript,topic:editor
low
Critical
2,485,521,474
PowerToys
Can't remap Win+Shift+S
### Provide a description of requested docs changes ![image](https://github.com/user-attachments/assets/99605efe-3fc8-4f53-b07c-4186a27bbf64) I'm trying to have Win+Shift+S launch Greenshot instead of the built in snipping tool (as the builtin tool freezes the computer sometimes), but PowerTools doesn't seem to be able to overwrite it. Even if I just try having it launch calc, it still launches the snipping tool when I hit Win+Shift+S
Issue-Docs,Needs-Triage
low
Minor
2,485,521,940
pytorch
[MPS] `F.interpolate` with `mode="nearest-exact"` differs from expected output
### 🐛 Describe the bug This was discovered while annotating failures in https://github.com/pytorch/pytorch/pull/134184. Original test case is in [`test/test_nn.py`](https://github.com/pytorch/pytorch/blob/7af38eb98bdceb8fc6f8635ed7dd664ef44e4b10/test/test_nn.py#L9323). There's a diff between the results from MPS and CPU. The algorithm for correctly computing the expected output in 1d can be seen in https://github.com/pytorch/pytorch/blob/7af38eb98bdceb8fc6f8635ed7dd664ef44e4b10/test/test_nn.py#L9330-L9336 and 2d in https://github.com/pytorch/pytorch/blob/7af38eb98bdceb8fc6f8635ed7dd664ef44e4b10/test/test_nn.py#L9438-L9447 See also https://github.com/pytorch/pytorch/issues/34808. minimal repro: ```python import torch import torch.nn.functional as F isize, osize = (20, 11) in_cpu = torch.arange(isize, dtype=torch.float, device='cpu').unsqueeze(0).unsqueeze(0) in_mps = torch.arange(isize, dtype=torch.float, device='mps').unsqueeze(0).unsqueeze(0) out_cpu = F.interpolate(in_cpu, size=(osize, ), recompute_scale_factor=False, mode="nearest-exact") out_mps = F.interpolate(in_mps, size=(osize, ), recompute_scale_factor=False, mode="nearest-exact") out_cpu - out_mps.cpu() # tensor([[[0., 0., 0., 0., 0., 1., 0., 0., 0., 0., 0.]]]) ``` ### Versions PyTorch version: 2.5.0a0+gitc19005d Is debug build: False CUDA used to build PyTorch: None ROCM used to build PyTorch: N/A OS: macOS 14.6.1 (arm64) GCC version: Could not collect Clang version: 15.0.0 (clang-1500.3.9.4) CMake version: version 3.30.1 Libc version: N/A Python version: 3.12.4 | packaged by conda-forge | (main, Jun 17 2024, 10:13:44) [Clang 16.0.6 ] (64-bit runtime) Python platform: macOS-14.6.1-arm64-arm-64bit Is CUDA available: False CUDA runtime version: No CUDA CUDA_MODULE_LOADING set to: N/A GPU models and configuration: No CUDA Nvidia driver version: No CUDA cuDNN version: No CUDA HIP runtime version: N/A MIOpen runtime version: N/A Is XNNPACK available: True CPU: Apple M3 Max Versions of relevant libraries: [pip3] flake8==6.1.0 [pip3] flake8-bugbear==23.3.23 [pip3] flake8-comprehensions==3.15.0 [pip3] flake8-executable==2.1.3 [pip3] flake8-logging-format==0.9.0 [pip3] flake8-pyi==23.3.1 [pip3] flake8-simplify==0.19.3 [pip3] mypy==1.10.0 [pip3] mypy-extensions==1.0.0 [pip3] numpy==2.0.1 [pip3] optree==0.12.1 [pip3] torch==2.5.0a0+gitc19005d [pip3] torch-tb-profiler==0.4.3 [pip3] torchvision==0.20.0a0+0d80848 [pip3] triton==3.0.0 [conda] numpy 2.0.1 pypi_0 pypi [conda] optree 0.12.1 pypi_0 pypi [conda] torch 2.5.0a0+gitc19005d dev_0 <develop> [conda] torch-tb-profiler 0.4.3 pypi_0 pypi [conda] torchfix 0.4.0 pypi_0 pypi [conda] torchvision 0.20.0a0+0d80848 dev_0 <develop> [conda] triton 3.0.0 pypi_0 pypi cc @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen
triaged,module: correctness (silent),module: mps
low
Critical
2,485,562,420
PowerToys
fails to restart after closing
### Microsoft PowerToys version 0.83.0 ### Installation method PowerToys auto-update ### Running as admin Yes ### Area(s) with issue? General ### Steps to reproduce when closing powertoys via the task manager, it fails to restart manually. all of the options are checked, etc. but the actual powertoys requires a PC restart ### ✔️ Expected Behavior when restarting manually, powertoys should actually restart ### ❌ Actual Behavior the app launched, and all settings are correct, however none of the tools actually function until PC restart ### Other Software _No response_
Issue-Bug,Needs-Triage,Needs-Team-Response
low
Minor
2,485,608,016
pytorch
DISABLED test_pattern_matcher_multi_user_dynamic_shapes_cpu (__main__.DynamicShapesCpuTests)
Platforms: linux This test was disabled because it is failing in CI. See [recent examples](https://hud.pytorch.org/flakytest?name=test_pattern_matcher_multi_user_dynamic_shapes_cpu&suite=DynamicShapesCpuTests&limit=100) and the most recent trunk [workflow logs](https://github.com/pytorch/pytorch/runs/29225740208). Over the past 3 hours, it has been determined flaky in 12 workflow(s) with 12 failures and 12 successes. **Debugging instructions (after clicking on the recent samples link):** DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs. To find relevant log snippets: 1. Click on the workflow logs linked above 2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work. 3. Grep for `test_pattern_matcher_multi_user_dynamic_shapes_cpu` 4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs. <details><summary>Sample error message</summary> ``` Traceback (most recent call last): File "/var/lib/jenkins/workspace/test/inductor/test_torchinductor.py", line 11314, in test_pattern_matcher_multi_user self.common(forward, (a, b)) File "/var/lib/jenkins/workspace/test/inductor/test_torchinductor.py", line 430, in check_model actual = run(*example_inputs, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/py_3.12/lib/python3.12/site-packages/torch/_dynamo/eval_frame.py", line 465, in _fn return fn(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^ File "/var/lib/jenkins/workspace/test/inductor/test_torchinductor.py", line 424, in run def run(*ex, **kwargs): File "/opt/conda/envs/py_3.12/lib/python3.12/site-packages/torch/_dynamo/eval_frame.py", line 632, in _fn return fn(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/py_3.12/lib/python3.12/site-packages/torch/_functorch/aot_autograd.py", line 1100, in forward return compiled_fn(full_args) ^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/py_3.12/lib/python3.12/site-packages/torch/_functorch/_aot_autograd/runtime_wrappers.py", line 308, in runtime_wrapper all_outs = call_func_at_runtime_with_args( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/py_3.12/lib/python3.12/site-packages/torch/_functorch/_aot_autograd/utils.py", line 124, in call_func_at_runtime_with_args out = normalize_as_list(f(args)) ^^^^^^^ File "/opt/conda/envs/py_3.12/lib/python3.12/site-packages/torch/_functorch/_aot_autograd/utils.py", line 98, in g return f(*args) ^^^^^^^^ File "/opt/conda/envs/py_3.12/lib/python3.12/site-packages/torch/autograd/function.py", line 575, in apply return super().apply(*args, **kwargs) # type: ignore[misc] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ RuntimeError: std::bad_alloc To execute this test, run the following from the base repo dir: python test/inductor/test_torchinductor_dynamic_shapes.py DynamicShapesCpuTests.test_pattern_matcher_multi_user_dynamic_shapes_cpu This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0 ``` </details> Test file path: `inductor/test_torchinductor_dynamic_shapes.py` cc @clee2000 @ezyang @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire
triaged,module: flaky-tests,skipped,oncall: pt2,module: inductor
medium
Critical
2,485,706,634
pytorch
configure ignores USE_QNNPACK=0 and still looks for third_party/QNNPACK
### 🐛 Describe the bug The USE_QNNPACK=0 environment variable is ignored and the build fails with this message: ``` -- Building version 2.4.0a0+gitUnknown Could not find any of CMakeLists.txt, Makefile, setup.py, LICENSE, LICENSE.md, LICENSE.txt in /usr/ports/misc/py-pytorch/work-py311/pytorch-v2.4.0/third_party/QNNPACK Did you run 'git submodule update --init --recursive'? ``` distutils is used for build. ### Versions pytorch-2.4.0 Build in the FreeBSD ports framework. cc @malfet @seemethere
module: build,triaged
low
Critical
2,485,713,522
neovim
conceal can use a cchar from the wrong buffer
### Problem Sometimes concealed text in one buffer is replaced by a :syn-cchar defined in a different buffer's syntax rules. ### Steps to reproduce This isn't easy to reproduce; I suspect it's caused by a race condition in the syntax highlighting between different buffers. The simplest reproducer I've found so far is: ``` nvim --clean -c 'checkhealth|vert help reference_toc' ``` Sometimes, but not always, help tags in the `:help` window will render with a ─ (U+2500 BOX DRAWINGS LIGHT HORIZONTAL) on either side of them, like this: ![image](https://github.com/user-attachments/assets/4f5ef6f1-bceb-48f4-bf16-1dde330aee6c) Pressing Ctrl-L may fix that: ![image](https://github.com/user-attachments/assets/322cfcbf-f960-4c12-8d4b-a2f61d0157b9) Though pressing Ctrl-L again may make it recur, toggling between the two states. That box drawing character is configured in `runtime/syntax/checkhealth.vim`: ```vim syn match healthHeadingChar "=" conceal cchar=─ contained containedin=helpSectionDelim ``` But that is not expected to affect the behavior of an ft=help buffer. This seems to happen more often with certain terminal sizes (I've been reproducing it in a 100 column by 40 line terminal fairly regularly). ### Expected behavior The `|` surrounding help tags should be hidden at `conceallevel=2`, rather than replaced with `─`. I see that there's a static variable called `static int current_sub_char = 0;` that stores the "current" `cchar`, but it's not clear to me how that's meant to work across different buffers. It seems as though one buffer is seeing a cchar that only exists in the syntax rules for a different buffer. ### Neovim version (nvim -v) NVIM v0.11.0-dev-660+gcf44121f7 ### Vim (not Nvim) behaves the same? I can't reproduce reliably enough to be sure (given no :checkhealth in vim) ### Operating system/version Ubuntu 24.04 ### Terminal name/version Tested with Windows Terminal and wsltty ### $TERM environment variable xterm-256color ### Installation Nightly release from GitHub
bug,syntax,display,conceal
low
Minor
2,485,725,750
pytorch
Cuda memory error when testing GroupedGemm on a multi-Gpu environment
``` ### 🐛 Describe the bug import unittest import itertools from absl.testing import parameterized import sys from grouped_gemm import ops import numpy as np import torch def allclose(x, y, pct=2.0): mask = torch.isclose(x, y, rtol=1e-5) pct_diff = (mask.numel() - mask.sum()) / mask.numel() * 100 if pct_diff > pct: print(x[torch.logical_not(mask)], y[torch.logical_not(mask)]) print("{:.2f}% of values not close.".format(pct_diff)) return False return True def add_transpose_flags(x): out = [] for y in x: for f in [(False,), (True,)]: out.append(y + f) return out _TEST_PROBLEMS = add_transpose_flags(( (1, 128, 128, 128), (8, 128, 128, 128), (16, 128, 128, 128), (1, 128, 256, 512), (8, 128, 256, 512), (16, 128, 256, 512), )) def randn(bs, x, y, device_id): out = (torch.rand(bs, x, y) - 0.5 * 2) / (y * x) device = torch.device("cuda:%d"%device_id if torch.cuda.is_available() else "cpu") return out.to(device).to(torch.bfloat16) # return out.cuda().to(torch.bfloat16) def gmm(a, b, batch_sizes, trans_b=False): batch_sizes = batch_sizes.numpy() out = [] start = 0 for i, size in enumerate(batch_sizes): rhs = b[i, :, :].t() if trans_b else b[i, :, :] out.append(a[start:start + size, :] @ rhs) start += size return torch.cat(out) @parameterized.parameters(*_TEST_PROBLEMS) class OpsTest(parameterized.TestCase): def testGroupedGemm_FixedSizes(self, z, m, k, n, trans_b): torch.manual_seed(0) device_id = 3 a = randn(z, m, k, device_id).view(-1, k) b = randn(z, n, k, device_id) if trans_b else randn(z, k, n, device_id) batch_sizes = torch.tensor([m] * z) a.requires_grad_(True) b.requires_grad_(True) print("a.device: ",a.device) a_ref = a.detach().clone().requires_grad_(True) b_ref = b.detach().clone().requires_grad_(True) out = ops.gmm(a, b, batch_sizes, trans_b) expected_out = gmm(a_ref, b_ref, batch_sizes, trans_b) self.assertTrue(allclose(out, expected_out)) # Check gradients. out.sum().backward() expected_out.sum().backward() self.assertTrue(allclose(a.grad, a_ref.grad)) self.assertTrue(allclose(b.grad, b_ref.grad)) def testGroupedGemm_VariableSizes(self, z, m, k, n, trans_b): torch.manual_seed(0) device_id = 3 a = randn(z, m, k, device_id).view(-1, k) b = randn(z, n, k, device_id) if trans_b else randn(z, k, n, device_id) dist = torch.rand(z, ) dist /= dist.sum() batch_sizes = (dist * m).to(torch.long) error = m * z - batch_sizes.sum() batch_sizes[-1] += error assert batch_sizes.sum() == (m * z) a.requires_grad_(True) b.requires_grad_(True) a_ref = a.detach().clone().requires_grad_(True) b_ref = b.detach().clone().requires_grad_(True) out = ops.gmm(a, b, batch_sizes, trans_b) expected_out = gmm(a_ref, b_ref, batch_sizes, trans_b) self.assertTrue(allclose(out, expected_out)) # Check gradients. out.sum().backward() expected_out.sum().backward() self.assertTrue(allclose(a.grad, a_ref.grad)) self.assertTrue(allclose(b.grad, b_ref.grad)) if __name__ == '__main__': def check_device(device_id): try: device = torch.device(f"cuda:{device_id}") tensor = torch.randn(3, 3, device=device) print(f"Tensor created successfully on GPU {device_id}") except RuntimeError as e: print(f"Error on GPU {device_id}: {e}") for i in range(torch.cuda.device_count()): check_device(i) if torch.cuda.is_available(): print("GPU 3 memory summary:") print(torch.cuda.memory_summary(device='cuda:3')) unittest.main() ``` ### Versions I build several tensor groups to test the grouped_gemm. the program went well on single gpu, but when I change the environment to multiple gpus and load the tensors to different device at different time, the program would error and have different errors each time: the 1st case: ``` def randn(bs, x, y, device_id): out = (torch.rand(bs, x, y) - 0.5 * 2) / (y * x) device = torch.device(“cuda:%d”%device_id if torch.cuda.is_available() else “cpu”) return out.to(device).to(torch.bfloat16) a = randn(bs, x, y, device_id) b = randn(bs, x, y, device_id) ``` yes, I load the tensor to the specific device when I build it, and the error would be: > group_1: RuntimeError: Failed to run CUTLASS Grouped GEMM > group_2…n: > RuntimeError: CUDA error: an illegal memory access was encountered > Compile with TORCH_USE_CUDA_DSA to enable device-side assertions. I've put the three code snippets in this repository: https://github.com/NiuMa-1234/Test_of_GroupedGemm_on_multiGpus.git Thank you for your attention and any reply would be appreciated! cc @ptrblck @msaroufim
module: cuda,triaged
low
Critical
2,485,792,645
storybook
[Bug]: `EISDIR: [postcss] Is a directory` after updating from `8.1.11` to `8.2.0` with Bun
### Describe the bug With Storybook 8.2.0 or higher, and **using [Bun](https://bun.sh) as the JavaScript runtime instead of Node.js**, the Storybook server starts correctly but upon trying to load any preview it throws an error: ``` PS C:\Users\LoganDark\bunvite> bun storybook $ bunx --bun storybook dev -p 6006 --no-open storybook v8.2.0 info => Starting manager.. info => Starting preview.. info Using tsconfig paths for react-docgen Re-optimizing dependencies because lockfile has changed ╭──────────────────────────────────────────────────────────────────────────────────────────╮ │ │ │ Storybook 8.2.0 for react-vite started │ │ 156 ms for manager and 911 ms for preview │ │ │ │ Local: http://localhost:6006/ │ │ On your network: http://169.254.27.237:6006/ │ │ │ │ A new version (8.2.8) is available! │ │ │ │ Upgrade now: npx storybook@latest upgrade │ │ │ │ Read full changelog: https://github.com/storybookjs/storybook/blob/main/CHANGELOG.md │ │ │ ╰──────────────────────────────────────────────────────────────────────────────────────────╯ 16585 | path$n.dirname(nearestPackage.dir), 16586 | packageCache 16587 | )); 16588 | } 16589 | function loadPackageData(pkgPath) { 16590 | const data = JSON.parse(fs__default.readFileSync(pkgPath, "utf-8")); ^ EISDIR: [postcss] Is a directory errno: -21 code: " @font-face { font-family: 'Nunito Sans'; font-style: normal; font-weight: 400; font-display: swap; src: url('./sb-common-assets/nunito-sans-regular.woff2') format('woff2'); } @font-face { font-family: 'Nunito Sans'; font-style: italic; font-weight: 400; font-display: swap; src: url('./sb-common-assets/nunito-sans-italic.woff2') format('woff2'); } @font-face { font-family: 'Nunito Sans'; font-style: normal; font-weight: 700; font-display: swap; src: url('./sb-common-assets/nunito-sans-bold.woff2') format('woff2'); } @font-face { font-family: 'Nunito Sans'; font-style: italic; font-weight: 700; font-display: swap; src: url('./sb-common-assets/nunito-sans-bold-italic.woff2') format('woff2'); } " syscall: "read" fd: 3 at readFileSync (native:1:1) at loadPackageData (C:\Users\LoganDark\bunvite\node_modules\vite\dist\node\chunks\dep-BzOvws4Y.js:16590:39) at tryCleanFsResolve (C:\Users\LoganDark\bunvite\node_modules\vite\dist\node\chunks\dep-BzOvws4Y.js:46292:23) at tryFsResolve (C:\Users\LoganDark\bunvite\node_modules\vite\dist\node\chunks\dep-BzOvws4Y.js:46226:15) at C:\Users\LoganDark\bunvite\node_modules\vite\dist\node\chunks\dep-BzOvws4Y.js:46048:19 at resolveId (C:\Users\LoganDark\bunvite\node_modules\vite\dist\node\chunks\dep-BzOvws4Y.js:45973:25) at C:\Users\LoganDark\bunvite\node_modules\vite\dist\node\chunks\dep-BzOvws4Y.js:48919:17 at processTicksAndRejections (unknown:12:39) Sourcemap for "/virtual:/@storybook/builder-vite/setup-addons.js" points to missing source files Sourcemap for "/virtual:/@storybook/builder-vite/vite-app.js" points to missing source files Bun v1.1.26 (Windows x64) error: script "storybook" exited with code 1 ``` If I downgrade to Storybook 8.1.11, it works properly and the preview can be loaded/used (timestamps censored): ``` PS C:\Users\LoganDark\bunvite> bun storybook $ bunx --bun storybook dev -p 6006 --no-open @storybook/cli v8.1.11 info => Starting manager.. info => Starting preview.. info Using tsconfig paths for react-docgen ╭──────────────────────────────────────────────────────────────────────────────────────────╮ │ │ │ Storybook 8.1.11 for react-vite started │ │ 160 ms for manager and 821 ms for preview │ │ │ │ Local: http://localhost:6006/ │ │ On your network: http://169.254.27.237:6006/ │ │ │ │ A new version (8.2.8) is available! │ │ │ │ Upgrade now: npx storybook@latest upgrade │ │ │ │ Read full changelog: https://github.com/storybookjs/storybook/blob/main/CHANGELOG.md │ │ │ ╰──────────────────────────────────────────────────────────────────────────────────────────╯ X:XX:XX XM [vite] ✨ new dependencies optimized: @storybook/addon-themes X:XX:XX XM [vite] ✨ optimized dependencies changed. reloading ``` ### Reproduction link https://github.com/LoganDark/bunstorybookrepro ### Reproduction steps from [readme of above repository](https://github.com/LoganDark/bunstorybookrepro/blob/master/README.md) ## How to reproduce 1. Install latest Bun 2. Run `bun install` 3. Run `bun storybook` 4. Load <http://localhost:6006> in browser 5. Storybook server immediately crashes: ``` 16585 | path$n.dirname(nearestPackage.dir), 16586 | packageCache 16587 | )); 16588 | } 16589 | function loadPackageData(pkgPath) { 16590 | const data = JSON.parse(fs__default.readFileSync(pkgPath, "utf-8")); ^ EISDIR: [postcss] Is a directory errno: -21 code: " @font-face { font-family: 'Nunito Sans'; font-style: normal; font-weight: 400; font-display: swap; src: url('./sb-common-assets/nunito-sans-regular.woff2') format('woff2'); } @font-face { font-family: 'Nunito Sans'; font-style: italic; font-weight: 400; font-display: swap; src: url('./sb-common-assets/nunito-sans-italic.woff2') format('woff2'); } @font-face { font-family: 'Nunito Sans'; font-style: normal; font-weight: 700; font-display: swap; src: url('./sb-common-assets/nunito-sans-bold.woff2') format('woff2'); } @font-face { font-family: 'Nunito Sans'; font-style: italic; font-weight: 700; font-display: swap; src: url('./sb-common-assets/nunito-sans-bold-italic.woff2') format('woff2'); } " syscall: "read" fd: 3 at readFileSync (native:1:1) at loadPackageData (C:\Users\LoganDark\bunstorybookrepro\node_modules\vite\dist\node\chunks\dep-BzOvws4Y.js:16590:39) at tryCleanFsResolve (C:\Users\LoganDark\bunstorybookrepro\node_modules\vite\dist\node\chunks\dep-BzOvws4Y.js:46292:23) at tryFsResolve (C:\Users\LoganDark\bunstorybookrepro\node_modules\vite\dist\node\chunks\dep-BzOvws4Y.js:46226:15) at C:\Users\LoganDark\bunstorybookrepro\node_modules\vite\dist\node\chunks\dep-BzOvws4Y.js:46048:19 at resolveId (C:\Users\LoganDark\bunstorybookrepro\node_modules\vite\dist\node\chunks\dep-BzOvws4Y.js:45973:25) at C:\Users\LoganDark\bunstorybookrepro\node_modules\vite\dist\node\chunks\dep-BzOvws4Y.js:48919:17 at processTicksAndRejections (unknown:12:39) Sourcemap for "/virtual:/@storybook/builder-vite/setup-addons.js" points to missing source files Sourcemap for "/virtual:/@storybook/builder-vite/vite-app.js" points to missing source files Bun v1.1.26 (Windows x64) error: script "storybook" exited with code 1 ``` ## How to fix 1. Open `package.json` 2. Change storybook version to `8.1.11` 3. Run `bun install` 4. Run `bun storybook` 5. Open <http://localhost:6006> in browser 6. Storybook server does not crash ### System It doesn't work properly because it runs `npm` commands. ``` Storybook Environment Info: (node:5476) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead. (Use `node --trace-deprecation ...` to show where the warning was created) System: OS: Windows 11 10.0.25931 CPU: (12) x64 12th Gen Intel(R) Core(TM) i5-12400F Binaries: Node: 22.1.0 - ~\AppData\Local\pnpm\node.EXE Yarn: 1.22.22 - ~\AppData\Roaming\npm\yarn.CMD npm: 10.7.0 - ~\AppData\Local\pnpm\npm.CMD <----- active pnpm: 8.11.0 - ~\AppData\Local\pnpm\pnpm.EXE Browsers: Edge: Spartan (Visual Studio 2022 Command Prompt variables set.), Chromium (127.0.2610.3), ChromiumDev (Visual Studio 2022 Command Prompt variables set.) npmPackages: @storybook/react: 8.2.0 => 8.1.11 @storybook/react-vite: 8.2.0 => 8.1.11 storybook: 8.2.0 => 8.1.11 ``` Bun version is `1.1.26`, but this happens on any version of Bun
bug,needs triage
low
Critical
2,485,815,972
pytorch
[Torch.Export] [Regression] Index Put Outputs Fake Tensor in 2.4 (Was Good in 2.3)
### 🐛 Describe the bug Run this example ``` import torch class Model(torch.nn.Module): def forward(self, x): x = x.clone() x.index_put_( indices=(torch.LongTensor([0, -1]), torch.LongTensor([-2, 1])), values=torch.Tensor([1.0, 5.0]), ) return x if __name__ == "__main__": SHAPE = (3, 4) model = Model() model.eval() x = torch.rand(SHAPE) exported_program = torch.export.export(model, (x,)) graph_module = exported_program.module() x = torch.rand(SHAPE) y = graph_module(x) print(y) ``` With torch 2.4, we get fake tensor ``` FakeTensor(..., size=(3, 4)) ``` In previous torch 2.3, we can get normal result ``` tensor([[0.8517, 0.5608, 1.0000, 0.3297], [0.1325, 0.2706, 0.1296, 0.6235], [0.2908, 5.0000, 0.3512, 0.2101]]) ``` ### Versions torch 2.4.0 cc @ezyang @chauhang @penguinwu @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @angelayi @suo @ydwu4
triaged,module: regression,oncall: pt2,oncall: export
low
Critical
2,485,947,003
rust
The compiler unexpectedly panicked
<!-- Thank you for finding an Internal Compiler Error! 🧊 If possible, try to provide a minimal verifiable example. You can read "Rust Bug Minimization Patterns" for how to create smaller examples. http://blog.pnkfx.org/blog/2019/11/18/rust-bug-minimization-patterns/ --> ### Code ```Rust <code> ``` ### Meta <!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. --> `rustc --version --verbose`: ``` <version> rustc 1.80.1 (3f5fd8dd4 2024-08-06) binary: rustc commit-hash: 3f5fd8dd41153bc5fdca9427e9e05be2c767ba23 commit-date: 2024-08-06 host: aarch64-apple-darwin release: 1.80.1 LLVM version: 18.1.7 ``` ### Error output ``` <output> error: the compiler unexpectedly panicked. this is a bug. note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md note: rustc 1.80.1 (3f5fd8dd4 2024-08-06) running on aarch64-apple-darwin note: compiler flags: --crate-type bin -C embed-bitcode=no -C debuginfo=2 -C split-debuginfo=unpacked -C incremental=[REDACTED] note: some of the compiler flags provided by cargo are hidden query stack during panic: #0 [evaluate_obligation] evaluating trait selection obligation `diesel::query_builder::select_statement::SelectStatement<diesel::query_builder::from_clause::FromClause<db::schema::customer::ps_customer::table>>: diesel::associations::HasTable` | = note: this failure-note originates in the macro `diesel::table` (in Nightly builds, run with -Z macro-backtrace for more info) #1 [check_well_formed] checking that `db::schema::customer::ps_customer::<impl at src/db/schema/customer.rs:1:1: 78:2>` is well-formed #2 [analysis] running analysis passes on this crate end of query stack there was a panic while trying to force a dep node try_mark_green dep node stack: #0 representability(f1a03a494daa9112-4bf98043bc8a9b12) #1 adt_sized_constraint(thread 'rustc' panicked at compiler/rustc_hir/src/definitions.rs:389:13: ("Failed to extract DefId", adt_sized_constraint, PackedFingerprint(Fingerprint(10236940663812725753, 15889046077414162429))) ``` <!-- Include a backtrace in the code block by setting `RUST_BACKTRACE=1` in your environment. E.g. `RUST_BACKTRACE=1 cargo build`. --> <details><summary><strong>Backtrace</strong></summary> <p> ``` <backtrace> stack backtrace: 0: 0x1030ccc1c - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h41035ce174e31160 1: 0x10311187c - core::fmt::write::h7e946826fce7616b 2: 0x1030c3088 - std::io::Write::write_fmt::he3645adfefb23e4a 3: 0x1030cca74 - std::sys_common::backtrace::print::h2efe9ae66fda73dc 4: 0x1030cf080 - std::panicking::default_hook::{{closure}}::hd27200b4fbd3bf40 5: 0x1030ced4c - std::panicking::default_hook::hb8656334461229c8 6: 0x10c753380 - <alloc[9bfd1da98798fc47]::boxed::Box<rustc_driver_impl[1ef2360f78401c14]::install_ice_hook::{closure#0}> as core[cec0bd9d2fc86fa9]::ops::function::Fn<(&dyn for<'a, 'b> core[cec0bd9d2fc86fa9]::ops::function::Fn<(&'a core[cec0bd9d2fc86fa9]::panic::panic_info::PanicInfo<'b>,), Output = ()> + core[cec0bd9d2fc86fa9]::marker::Sync + core[cec0bd9d2fc86fa9]::marker::Send, &core[cec0bd9d2fc86fa9]::panic::panic_info::PanicInfo)>>::call 7: 0x1030cfa6c - std::panicking::rust_panic_with_hook::h10171cf76e1aed15 8: 0x1030cf480 - std::panicking::begin_panic_handler::{{closure}}::h9344de43a47cae21 9: 0x1030cd0a0 - std::sys_common::backtrace::__rust_end_short_backtrace::h55013ada3ab9c4e8 10: 0x1030cf1f0 - _rust_begin_unwind 11: 0x10312d128 - core::panicking::panic_fmt::h0b16bb09366e1f01 12: 0x1108586b0 - <rustc_hir[370215242720f464]::definitions::Definitions>::local_def_path_hash_to_def_id::err 13: 0x10d190008 - <rustc_middle[2867706b5eb6f7f9]::ty::context::TyCtxt>::def_path_hash_to_def_id 14: 0x10ceee0ac - rustc_interface[6917c625c882dc9d]::callbacks::dep_node_debug 15: 0x10dbbe228 - <rustc_query_system[a56a14b00b0e8ff6]::dep_graph::dep_node::DepNode as core[cec0bd9d2fc86fa9]::fmt::Debug>::fmt 16: 0x10311187c - core::fmt::write::h7e946826fce7616b 17: 0x1030c12d4 - <&std::io::stdio::Stderr as std::io::Write>::write_fmt::h106b890cac40debb 18: 0x1030c1cd4 - std::io::stdio::_eprint::hf58134ec6abaf37d 19: 0x11097b8ac - rustc_query_system[a56a14b00b0e8ff6]::dep_graph::graph::print_markframe_trace::<rustc_middle[2867706b5eb6f7f9]::dep_graph::DepsType> 20: 0x10daeab7c - <rustc_query_system[a56a14b00b0e8ff6]::dep_graph::graph::DepGraphData<rustc_middle[2867706b5eb6f7f9]::dep_graph::DepsType>>::try_mark_previous_green::<rustc_query_impl[9b9172b7a4c3de5d]::plumbing::QueryCtxt> 21: 0x10daeab0c - <rustc_query_system[a56a14b00b0e8ff6]::dep_graph::graph::DepGraphData<rustc_middle[2867706b5eb6f7f9]::dep_graph::DepsType>>::try_mark_previous_green::<rustc_query_impl[9b9172b7a4c3de5d]::plumbing::QueryCtxt> 22: 0x10daeab0c - <rustc_query_system[a56a14b00b0e8ff6]::dep_graph::graph::DepGraphData<rustc_middle[2867706b5eb6f7f9]::dep_graph::DepsType>>::try_mark_previous_green::<rustc_query_impl[9b9172b7a4c3de5d]::plumbing::QueryCtxt> 23: 0x10daeab0c - <rustc_query_system[a56a14b00b0e8ff6]::dep_graph::graph::DepGraphData<rustc_middle[2867706b5eb6f7f9]::dep_graph::DepsType>>::try_mark_previous_green::<rustc_query_impl[9b9172b7a4c3de5d]::plumbing::QueryCtxt> 24: 0x10daeab0c - <rustc_query_system[a56a14b00b0e8ff6]::dep_graph::graph::DepGraphData<rustc_middle[2867706b5eb6f7f9]::dep_graph::DepsType>>::try_mark_previous_green::<rustc_query_impl[9b9172b7a4c3de5d]::plumbing::QueryCtxt> 25: 0x10daeab0c - <rustc_query_system[a56a14b00b0e8ff6]::dep_graph::graph::DepGraphData<rustc_middle[2867706b5eb6f7f9]::dep_graph::DepsType>>::try_mark_previous_green::<rustc_query_impl[9b9172b7a4c3de5d]::plumbing::QueryCtxt> 26: 0x10daeab0c - <rustc_query_system[a56a14b00b0e8ff6]::dep_graph::graph::DepGraphData<rustc_middle[2867706b5eb6f7f9]::dep_graph::DepsType>>::try_mark_previous_green::<rustc_query_impl[9b9172b7a4c3de5d]::plumbing::QueryCtxt> 27: 0x10daeab0c - <rustc_query_system[a56a14b00b0e8ff6]::dep_graph::graph::DepGraphData<rustc_middle[2867706b5eb6f7f9]::dep_graph::DepsType>>::try_mark_previous_green::<rustc_query_impl[9b9172b7a4c3de5d]::plumbing::QueryCtxt> 28: 0x10daea88c - <rustc_query_system[a56a14b00b0e8ff6]::dep_graph::graph::DepGraphData<rustc_middle[2867706b5eb6f7f9]::dep_graph::DepsType>>::try_mark_green::<rustc_query_impl[9b9172b7a4c3de5d]::plumbing::QueryCtxt> 29: 0x10d960774 - rustc_query_system[a56a14b00b0e8ff6]::query::plumbing::try_execute_query::<rustc_query_impl[9b9172b7a4c3de5d]::DynamicConfig<rustc_query_system[a56a14b00b0e8ff6]::query::caches::DefaultCache<rustc_type_ir[24e377033abc0aab]::canonical::Canonical<rustc_middle[2867706b5eb6f7f9]::ty::context::TyCtxt, rustc_middle[2867706b5eb6f7f9]::ty::ParamEnvAnd<rustc_middle[2867706b5eb6f7f9]::ty::predicate::Predicate>>, rustc_middle[2867706b5eb6f7f9]::query::erase::Erased<[u8; 2usize]>>, false, false, false>, rustc_query_impl[9b9172b7a4c3de5d]::plumbing::QueryCtxt, true> 30: 0x10db7c124 - rustc_query_impl[9b9172b7a4c3de5d]::query_impl::evaluate_obligation::get_query_incr::__rust_end_short_backtrace 31: 0x10dff8030 - <rustc_infer[12dda32e7c8ea680]::infer::InferCtxt as rustc_trait_selection[7e0d0f6886399ce9]::traits::query::evaluate_obligation::InferCtxtExt>::evaluate_obligation 32: 0x10dff8520 - <rustc_infer[12dda32e7c8ea680]::infer::InferCtxt as rustc_trait_selection[7e0d0f6886399ce9]::traits::query::evaluate_obligation::InferCtxtExt>::evaluate_obligation_no_overflow 33: 0x10df7366c - <rustc_trait_selection[7e0d0f6886399ce9]::traits::fulfill::FulfillProcessor>::process_trait_obligation 34: 0x10df72c30 - <rustc_trait_selection[7e0d0f6886399ce9]::traits::fulfill::FulfillProcessor as rustc_data_structures[961a954d878499e9]::obligation_forest::ObligationProcessor>::process_obligation 35: 0x10df5cc48 - <rustc_data_structures[961a954d878499e9]::obligation_forest::ObligationForest<rustc_trait_selection[7e0d0f6886399ce9]::traits::fulfill::PendingPredicateObligation>>::process_obligations::<rustc_trait_selection[7e0d0f6886399ce9]::traits::fulfill::FulfillProcessor> 36: 0x10df68e90 - <rustc_trait_selection[7e0d0f6886399ce9]::traits::fulfill::FulfillmentContext<rustc_trait_selection[7e0d0f6886399ce9]::traits::FulfillmentError> as rustc_infer[12dda32e7c8ea680]::traits::engine::TraitEngine<rustc_trait_selection[7e0d0f6886399ce9]::traits::FulfillmentError>>::select_where_possible 37: 0x10c979a34 - rustc_hir_analysis[eb0b0898efcdc604]::check::compare_impl_item::compare_impl_method 38: 0x10caa6c6c - rustc_hir_analysis[eb0b0898efcdc604]::check::check::check_impl_items_against_trait 39: 0x10caa27a0 - rustc_hir_analysis[eb0b0898efcdc604]::check::check::check_item_type 40: 0x10caf6710 - rustc_hir_analysis[eb0b0898efcdc604]::check::wfcheck::check_well_formed 41: 0x10d9e9ad4 - rustc_query_impl[9b9172b7a4c3de5d]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[9b9172b7a4c3de5d]::query_impl::check_well_formed::dynamic_query::{closure#2}::{closure#0}, rustc_middle[2867706b5eb6f7f9]::query::erase::Erased<[u8; 1usize]>> 42: 0x10da320b4 - <rustc_query_impl[9b9172b7a4c3de5d]::query_impl::check_well_formed::dynamic_query::{closure#2} as core[cec0bd9d2fc86fa9]::ops::function::FnOnce<(rustc_middle[2867706b5eb6f7f9]::ty::context::TyCtxt, rustc_hir[370215242720f464]::hir_id::OwnerId)>>::call_once 43: 0x10d9a06d8 - rustc_query_system[a56a14b00b0e8ff6]::query::plumbing::try_execute_query::<rustc_query_impl[9b9172b7a4c3de5d]::DynamicConfig<rustc_query_system[a56a14b00b0e8ff6]::query::caches::VecCache<rustc_hir[370215242720f464]::hir_id::OwnerId, rustc_middle[2867706b5eb6f7f9]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[9b9172b7a4c3de5d]::plumbing::QueryCtxt, true> 44: 0x10d93f68c - rustc_query_system[a56a14b00b0e8ff6]::query::plumbing::force_query::<rustc_query_impl[9b9172b7a4c3de5d]::DynamicConfig<rustc_query_system[a56a14b00b0e8ff6]::query::caches::VecCache<rustc_hir[370215242720f464]::hir_id::OwnerId, rustc_middle[2867706b5eb6f7f9]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[9b9172b7a4c3de5d]::plumbing::QueryCtxt> 45: 0x10d9b1218 - <rustc_query_impl[9b9172b7a4c3de5d]::plumbing::query_callback<rustc_query_impl[9b9172b7a4c3de5d]::query_impl::check_well_formed::QueryType>::{closure#0} as core[cec0bd9d2fc86fa9]::ops::function::FnOnce<(rustc_middle[2867706b5eb6f7f9]::ty::context::TyCtxt, rustc_query_system[a56a14b00b0e8ff6]::dep_graph::dep_node::DepNode)>>::call_once 46: 0x10daeaac8 - <rustc_query_system[a56a14b00b0e8ff6]::dep_graph::graph::DepGraphData<rustc_middle[2867706b5eb6f7f9]::dep_graph::DepsType>>::try_mark_previous_green::<rustc_query_impl[9b9172b7a4c3de5d]::plumbing::QueryCtxt> 47: 0x10daea88c - <rustc_query_system[a56a14b00b0e8ff6]::dep_graph::graph::DepGraphData<rustc_middle[2867706b5eb6f7f9]::dep_graph::DepsType>>::try_mark_green::<rustc_query_impl[9b9172b7a4c3de5d]::plumbing::QueryCtxt> 48: 0x10d941204 - rustc_query_system[a56a14b00b0e8ff6]::query::plumbing::ensure_must_run::<rustc_query_impl[9b9172b7a4c3de5d]::DynamicConfig<rustc_query_system[a56a14b00b0e8ff6]::query::caches::DefaultCache<rustc_span[22cad54eabbc67cf]::def_id::LocalModDefId, rustc_middle[2867706b5eb6f7f9]::query::erase::Erased<[u8; 0usize]>>, false, false, false>, rustc_query_impl[9b9172b7a4c3de5d]::plumbing::QueryCtxt> 49: 0x10db622dc - rustc_query_impl[9b9172b7a4c3de5d]::query_impl::check_mod_type_wf::get_query_incr::__rust_end_short_backtrace 50: 0x10c9463bc - std[4ec0ba9e3c6d748b]::panicking::try::<(), core[cec0bd9d2fc86fa9]::panic::unwind_safe::AssertUnwindSafe<rustc_data_structures[961a954d878499e9]::sync::parallel::disabled::par_for_each_in<&[rustc_hir[370215242720f464]::hir_id::OwnerId], <rustc_middle[2867706b5eb6f7f9]::hir::map::Map>::par_for_each_module<rustc_hir_analysis[eb0b0898efcdc604]::check_crate::{closure#1}::{closure#0}>::{closure#0}>::{closure#0}::{closure#0}::{closure#0}>> 51: 0x10ca30184 - rustc_data_structures[961a954d878499e9]::sync::parallel::disabled::par_for_each_in::<&[rustc_hir[370215242720f464]::hir_id::OwnerId], <rustc_middle[2867706b5eb6f7f9]::hir::map::Map>::par_for_each_module<rustc_hir_analysis[eb0b0898efcdc604]::check_crate::{closure#1}::{closure#0}>::{closure#0}> 52: 0x10ca8a284 - <rustc_session[6e72d4e14abb7feb]::session::Session>::time::<(), rustc_hir_analysis[eb0b0898efcdc604]::check_crate::{closure#1}> 53: 0x10c963884 - rustc_hir_analysis[eb0b0898efcdc604]::check_crate 54: 0x10cebb26c - rustc_interface[6917c625c882dc9d]::passes::analysis 55: 0x10d9ecc10 - rustc_query_impl[9b9172b7a4c3de5d]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[9b9172b7a4c3de5d]::query_impl::analysis::dynamic_query::{closure#2}::{closure#0}, rustc_middle[2867706b5eb6f7f9]::query::erase::Erased<[u8; 1usize]>> 56: 0x10db0eb84 - <rustc_query_impl[9b9172b7a4c3de5d]::query_impl::analysis::dynamic_query::{closure#2} as core[cec0bd9d2fc86fa9]::ops::function::FnOnce<(rustc_middle[2867706b5eb6f7f9]::ty::context::TyCtxt, ())>>::call_once 57: 0x10d953690 - rustc_query_system[a56a14b00b0e8ff6]::query::plumbing::try_execute_query::<rustc_query_impl[9b9172b7a4c3de5d]::DynamicConfig<rustc_query_system[a56a14b00b0e8ff6]::query::caches::SingleCache<rustc_middle[2867706b5eb6f7f9]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[9b9172b7a4c3de5d]::plumbing::QueryCtxt, true> 58: 0x10db54730 - rustc_query_impl[9b9172b7a4c3de5d]::query_impl::analysis::get_query_incr::__rust_end_short_backtrace 59: 0x10c7704d8 - <rustc_middle[2867706b5eb6f7f9]::ty::context::GlobalCtxt>::enter::<rustc_driver_impl[1ef2360f78401c14]::run_compiler::{closure#0}::{closure#1}::{closure#3}, core[cec0bd9d2fc86fa9]::result::Result<(), rustc_span[22cad54eabbc67cf]::ErrorGuaranteed>> 60: 0x10c75b5a4 - <rustc_interface[6917c625c882dc9d]::interface::Compiler>::enter::<rustc_driver_impl[1ef2360f78401c14]::run_compiler::{closure#0}::{closure#1}, core[cec0bd9d2fc86fa9]::result::Result<core[cec0bd9d2fc86fa9]::option::Option<rustc_interface[6917c625c882dc9d]::queries::Linker>, rustc_span[22cad54eabbc67cf]::ErrorGuaranteed>> 61: 0x10c71d6b8 - <scoped_tls[1950327f1bf28942]::ScopedKey<rustc_span[22cad54eabbc67cf]::SessionGlobals>>::set::<rustc_interface[6917c625c882dc9d]::util::run_in_thread_with_globals<rustc_interface[6917c625c882dc9d]::interface::run_compiler<core[cec0bd9d2fc86fa9]::result::Result<(), rustc_span[22cad54eabbc67cf]::ErrorGuaranteed>, rustc_driver_impl[1ef2360f78401c14]::run_compiler::{closure#0}>::{closure#1}, core[cec0bd9d2fc86fa9]::result::Result<(), rustc_span[22cad54eabbc67cf]::ErrorGuaranteed>>::{closure#0}::{closure#0}::{closure#0}, core[cec0bd9d2fc86fa9]::result::Result<(), rustc_span[22cad54eabbc67cf]::ErrorGuaranteed>> 62: 0x10c75af18 - rustc_span[22cad54eabbc67cf]::create_session_globals_then::<core[cec0bd9d2fc86fa9]::result::Result<(), rustc_span[22cad54eabbc67cf]::ErrorGuaranteed>, rustc_interface[6917c625c882dc9d]::util::run_in_thread_with_globals<rustc_interface[6917c625c882dc9d]::interface::run_compiler<core[cec0bd9d2fc86fa9]::result::Result<(), rustc_span[22cad54eabbc67cf]::ErrorGuaranteed>, rustc_driver_impl[1ef2360f78401c14]::run_compiler::{closure#0}>::{closure#1}, core[cec0bd9d2fc86fa9]::result::Result<(), rustc_span[22cad54eabbc67cf]::ErrorGuaranteed>>::{closure#0}::{closure#0}::{closure#0}> 63: 0x10c751d58 - std[4ec0ba9e3c6d748b]::sys_common::backtrace::__rust_begin_short_backtrace::<rustc_interface[6917c625c882dc9d]::util::run_in_thread_with_globals<rustc_interface[6917c625c882dc9d]::interface::run_compiler<core[cec0bd9d2fc86fa9]::result::Result<(), rustc_span[22cad54eabbc67cf]::ErrorGuaranteed>, rustc_driver_impl[1ef2360f78401c14]::run_compiler::{closure#0}>::{closure#1}, core[cec0bd9d2fc86fa9]::result::Result<(), rustc_span[22cad54eabbc67cf]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[cec0bd9d2fc86fa9]::result::Result<(), rustc_span[22cad54eabbc67cf]::ErrorGuaranteed>> 64: 0x10c72859c - <<std[4ec0ba9e3c6d748b]::thread::Builder>::spawn_unchecked_<rustc_interface[6917c625c882dc9d]::util::run_in_thread_with_globals<rustc_interface[6917c625c882dc9d]::interface::run_compiler<core[cec0bd9d2fc86fa9]::result::Result<(), rustc_span[22cad54eabbc67cf]::ErrorGuaranteed>, rustc_driver_impl[1ef2360f78401c14]::run_compiler::{closure#0}>::{closure#1}, core[cec0bd9d2fc86fa9]::result::Result<(), rustc_span[22cad54eabbc67cf]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[cec0bd9d2fc86fa9]::result::Result<(), rustc_span[22cad54eabbc67cf]::ErrorGuaranteed>>::{closure#2} as core[cec0bd9d2fc86fa9]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0} 65: 0x1030d8588 - std::sys::pal::unix::thread::Thread::new::thread_start::hb184f2abd415aef7 66: 0x1886a6f94 - __pthread_joiner_wake ``` </p> </details>
I-ICE,T-compiler,A-incr-comp,C-bug
low
Critical
2,486,059,650
pytorch
DISABLED test_vdd_clamp_dynamic_shapes_cpu (__main__.DynamicShapesCpuTests)
Platforms: linux This test was disabled because it is failing in CI. See [recent examples](https://hud.pytorch.org/flakytest?name=test_vdd_clamp_dynamic_shapes_cpu&suite=DynamicShapesCpuTests&limit=100) and the most recent trunk [workflow logs](https://github.com/pytorch/pytorch/runs/29231152014). Over the past 3 hours, it has been determined flaky in 6 workflow(s) with 6 failures and 6 successes. **Debugging instructions (after clicking on the recent samples link):** DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs. To find relevant log snippets: 1. Click on the workflow logs linked above 2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work. 3. Grep for `test_vdd_clamp_dynamic_shapes_cpu` 4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs. <details><summary>Sample error message</summary> ``` Traceback (most recent call last): File "/var/lib/jenkins/workspace/test/inductor/test_torchinductor.py", line 8825, in test_vdd_clamp self.common( File "/var/lib/jenkins/workspace/test/inductor/test_torchinductor.py", line 430, in check_model actual = run(*example_inputs, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/py_3.11/lib/python3.11/site-packages/torch/_dynamo/eval_frame.py", line 465, in _fn return fn(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^ File "/var/lib/jenkins/workspace/test/inductor/test_torchinductor.py", line 424, in run def run(*ex, **kwargs): File "/opt/conda/envs/py_3.11/lib/python3.11/site-packages/torch/_dynamo/eval_frame.py", line 632, in _fn return fn(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/py_3.11/lib/python3.11/site-packages/torch/_functorch/aot_autograd.py", line 1100, in forward return compiled_fn(full_args) ^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/py_3.11/lib/python3.11/site-packages/torch/_functorch/_aot_autograd/runtime_wrappers.py", line 308, in runtime_wrapper all_outs = call_func_at_runtime_with_args( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/py_3.11/lib/python3.11/site-packages/torch/_functorch/_aot_autograd/utils.py", line 124, in call_func_at_runtime_with_args out = normalize_as_list(f(args)) ^^^^^^^ File "/opt/conda/envs/py_3.11/lib/python3.11/site-packages/torch/_functorch/_aot_autograd/utils.py", line 98, in g return f(*args) ^^^^^^^^ File "/opt/conda/envs/py_3.11/lib/python3.11/site-packages/torch/autograd/function.py", line 575, in apply return super().apply(*args, **kwargs) # type: ignore[misc] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ RuntimeError: std::bad_alloc To execute this test, run the following from the base repo dir: python test/inductor/test_torchinductor_dynamic_shapes.py DynamicShapesCpuTests.test_vdd_clamp_dynamic_shapes_cpu This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0 ``` </details> Test file path: `inductor/test_torchinductor_dynamic_shapes.py` cc @clee2000 @ezyang @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire
triaged,module: flaky-tests,skipped,oncall: pt2,module: inductor
medium
Critical
2,486,093,999
ant-design
Dropdown menu blinks when position is `bottom` and the trigger is close to left/right screen edge
### Reproduction link [![Edit on StackBlitz](https://developer.stackblitz.com/img/open_in_stackblitz.svg)](https://stackblitz.com/edit/antd-reproduce-5x-az6c7n?file=demo.tsx) ### Steps to reproduce 1) add a dropdown to the page https://ant.design/components/dropdown#dropdown 2) place the button that triggers the dropdown menu as close as possible to the right border of the window 3) make sure that dropdown menu has bigger width than the trigger element (so it will be partially hidden behind the screen border) 4) click on the trigger ### What is expected? The dropdown menu gets opened and doesn't blink ### What is actually happening? The dropdown menu gets opened but it blinks. | Environment | Info | | --- | --- | | antd | 5.19.1 | | React | 18.0.0 | | System | macos sonoma 14.6 beta | | Browser | Chrome 127.0.6533.120 | <!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
🐛 Bug,Inactive,unconfirmed
low
Major
2,486,156,252
flutter
FlutterEngineGroupCache on iOS
### Use case I want to use use FlutterEngineGroupCache on iOS. Android version of the class: https://api.flutter.dev/javadoc/io/flutter/embedding/engine/FlutterEngineGroupCache.html My use case: I want to be able to use same FlutterEngineGroup on every isolate, even one that was spawned from a foreground service or another plugin (flutter_isolate which handles plugins). And while I can quite easily share code between one plugin and main client, I can't easily share code between two plugins and one client, thus having the need for a "store" for FlutterEngineGroup objects. Why I want to do this: share complex objects via ports: https://github.com/flutter/flutter/issues/152484 I want quick pushing of objects without the need of serialization/deserialization. ### Proposal Expose a simple singleton which gets and sets FlutterEngineGroup objects on iOS, the same way it does on Android.
platform-ios,engine,c: proposal,P3,team-ios,triaged-ios
low
Major
2,486,194,309
TypeScript
Inconsistent boolean literal types in objects
### 🔎 Search Terms boolean invariant type parameter literal widen union ### 🕗 Version & Regression Information - This is the behavior in every version I tried ### ⏯ Playground Link https://www.typescriptlang.org/play/?ts=5.7.0-dev.20240824&ssl=14&ssc=130&pln=1&pc=1#code/PTAECEHsA8B4BUB8oAuBPADgU1ASwM54B2AbgIYBOuZRKxo8AsAFAvrYQwLIC8oA3i1CgA5lhQAuUAAoAlKB7J4AbiGh84qdPIAbAK5Yp8eYtAlIuACarmAXxstLWAMY7KOAGZ6izlLkhEoABGXEjaZPqGDLJSUHBIDszOAfh0QUQAjArBMNL8oBgUkBhSAAygtrLKoCCccPmFxVJEegC2QVgUFYgsyUSpwUQATLFcDUUloC3tnd3ZIdB5BRNlFVU1YADyANYsvSlpQVl8C0uNkx4RGmvVtXGw4005kDpYNN37-YcjdQ-LTyEXm9ArZeDlFo8LlccJVbmAAKIUIoUAA04L+5yklx011BU0gdDI+HwuBERDIQVeqEgv0hUkBr3eoJYQA ### 💻 Code ```ts // Box<T> type is invariant in T type Box<T> = { get: () => T; set: (value: T) => void; }; declare function box<T>(value: T): Box<T>; const bn1 = box({ prop: 0 }); // Box<{ prop: number }> const bn2: Box<{ prop: number }> = box({ prop: 0 }); // Ok const bb1 = box({ prop: false }); // Box<{ prop: boolean }> const bb2: Box<{ prop: boolean }> = box({ prop: false }); // Error, box<{ prop: false }> not assignable to Box<{ prop: boolean }> ``` ### 🙁 Actual behavior Error on `bb2` is surprising and inconsistent with lack of error on `bn2`. ### 🙂 Expected behavior Expected the `box(false)` expression to have type `Box<boolean>` for both `bb1` and `bb2`. ### Additional information about the issue This issue is a small variation of https://github.com/microsoft/TypeScript/issues/48363 that was fixed by @ahejlsberg in https://github.com/microsoft/TypeScript/pull/48380
Bug,Help Wanted
low
Critical
2,486,291,012
vscode
Notebook Find width cutting off "of x results" portion of widget -- Chinese Simplified
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --> <!-- 🔎 Search existing issues to avoid creating duplicates. --> <!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ --> <!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --> <!-- 🔧 Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: No <!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --> <!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. --> - VS Code Version: 1.92.2 (user setup) - OS Version: Windows_NT x64 10.0.22631 Steps to Reproduce: 1. Create a .ipynb file and a .py file, then type any thing in them. 2. Search in the py file, we can see the full information about the search result. ![image](https://github.com/user-attachments/assets/7f50fee4-c972-4435-bf28-73bdf738881f) 3. Search in the ipynb file, it can not show the total num of matches. ![image](https://github.com/user-attachments/assets/6267f00d-6df8-413a-be76-c43cbc8c77d2)
polish,notebook-find
low
Critical
2,486,296,589
ui
[feat]: only some colors are available in the CLI choice - why not blue, green, violet?
### Feature description On the [theme-choosing site](https://ui.shadcn.com/themes), we can choose different base colors. However, when running: `npx shadcn-svelte@latest init` (the fact that it's Svelte is irrelevant, it works exactly the same in standard shadcn), we are only provided with some of them: https://github.com/shadcn-ui/ui/blob/259a9ff56acc44551eca2a36023b4101d42e42df/packages/cli/src/utils/registry/index.ts#L39-L62 ### Affected component/components All ### Additional Context I could take care of that issue, but I would need a little guidance about what is needed apart from extending the `getBaseColors` method. ### Before submitting - [X] I've made research efforts and searched the documentation - [X] I've searched for existing issues and PRs
area: request
low
Minor
2,486,301,879
ollama
Performing GET request to registry.ollama.ai/v2/ returns 404 page not found
### What is the issue? Background: Kubernetes 1.31 introduced a new feature: [Read-Only Volumes Based on OCI Artifacts](https://kubernetes.io/blog/2024/08/16/kubernetes-1-31-image-volume-source/). I believe this feature could be very useful for deploying a dedicated model alongside Ollama in Kubernetes. The currently supported container runtime is [CRI-O](https://github.com/cri-o/cri-o), which relies on [containers/image](https://github.com/containers/image) for all image-related operations. It uses a `GET` request to the following URL to [determine](https://github.com/containers/image/blob/main/docker/docker_client.go#L903) the appropriate schema: e.g. https://registry.ollama.ai/v2/. I hardcoded the schema to `HTTPS` and used the Ollama image `registry.ollama.ai/library/tinyllama:latest` as the OCI image volume. After making some modifications to the modules consumed by CRI-O, I was able to get the pod and container running without any issues. Please see the following logs: ```bash ❯ sudo crictl --timeout=200s --runtime-endpoint unix:///run/crio/crio.sock run ./container.json ./sandbox_config.json INFO[0005] Pulling container image: registry.docker.com/ollama/ollama:latest INFO[0005] Pulling image registry.ollama.ai/library/tinyllama:latest to be mounted to container path: /volume 7e437894449f6429799cc5ef236c4a4570a69e3769bf324bbf700045e383cae8 ❯ sudo crictl --timeout=200s --runtime-endpoint unix:///run/crio/crio.sock ps CONTAINER IMAGE CREATED STATE NAME ATTEMPT POD ID POD 7e437894449f6 registry.docker.com/ollama/ollama:latest 8 seconds ago Running podsandbox-sleep 0 4d1766fdf286b unknown ❯ sudo crictl --timeout=200s --runtime-endpoint unix:///run/crio/crio.sock exec -it 7e437894449f6 bash root@crictl_host:/# cd volume/ root@crictl_host:/volume# ls -l total 622772 -rw-r--r-- 1 root root 637699456 Aug 26 08:32 model -rw-r--r-- 1 root root 98 Aug 26 08:32 params -rw-r--r-- 1 root root 31 Aug 26 08:32 system -rw-r--r-- 1 root root 70 Aug 26 08:32 template root@crictl_host:/volume# ``` I'm wondering if the Ollama model registry could be slightly updated to handle requests to `registry.ollama.ai/v2/`. This would allow certain container runtimes to seamlessly integrate Ollama's OCI models without any issues. ### OS Linux ### GPU Nvidia ### CPU Intel ### Ollama version 0.3.6
bug
low
Minor
2,486,332,769
ollama
Embedding model text2vec-large-chinese
www.modelscope.cn/Jerry0/text2vec-large-chinese
model request
low
Minor
2,486,389,583
material-ui
[code-infra] Clean up bundle size names
From https://www.notion.so/mui-org/code-infra-Cleanup-bundle-size-tracker-names-af489e26331c4faa9e44a81ee4e1f06f Assuming https://github.com/mui/material-ui/blob/92ff1fc67c1c999a9c92bdeb0f3ce6bbc173ee58/scripts/sizeSnapshot/webpack.config.js#L72-L73 is not useful for us anymore. - Rename the bundle ids: - `@material-ui/core` => `@mui/material` - etc... - Remove https://github.com/mui/material-ui/blob/92ff1fc67c1c999a9c92bdeb0f3ce6bbc173ee58/scripts/sizeSnapshot/webpack.config.js#L13-L20 **Search keywords**:
scope: code-infra
low
Minor
2,486,421,006
godot
[4.3 Crash] While browsing remote tab
### Tested versions v4.3.stable.official [77dcf97d8] ### System information Debian 11 - v4.3.stable.official [77dcf97d8] - Godot Engine v4.3.stable.official.77dcf97d8 - https://godotengine.org OpenGL API OpenGL ES 3.0 Mesa 20.3.5 - Compatibility - Using Device: Intel Open Source Technology Center - Mesa DRI Intel(R) HD Graphics 4000 (IVB GT2) ### Issue description As stated in title I have crash with several errors while browsing the remote tab. It happen now in 4.3. I think its a regression because I don't have these errors in 4.2.x ### Steps to reproduce My project is quite complex. So I just browse my remote tree while running my project. These are errors in Output tab before crash: ``` core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/io/marshalls.cpp:117 - Condition "len < 4" is true. Returning: ERR_INVALID_DATA core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/io/marshalls.cpp:117 - Condition "len < 4" is true. Returning: ERR_INVALID_DATA core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:134 - Condition "read != 4 || err != OK || size > (uint32_t)in_buf.size()" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:134 - Condition "read != 4 || err != OK || size > (uint32_t)in_buf.size()" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/io/marshalls.cpp:117 - Condition "len < 4" is true. Returning: ERR_INVALID_DATA core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:134 - Condition "read != 4 || err != OK || size > (uint32_t)in_buf.size()" is true. Continuing. core/debugger/remote_debugger_peer.cpp:134 - Condition "read != 4 || err != OK || size > (uint32_t)in_buf.size()" is true. Continuing. core/debugger/remote_debugger_peer.cpp:134 - Condition "read != 4 || err != OK || size > (uint32_t)in_buf.size()" is true. Continuing. core/debugger/remote_debugger_peer.cpp:134 - Condition "read != 4 || err != OK || size > (uint32_t)in_buf.size()" is true. Continuing. core/debugger/remote_debugger_peer.cpp:134 - Condition "read != 4 || err != OK || size > (uint32_t)in_buf.size()" is true. Continuing. core/debugger/remote_debugger_peer.cpp:134 - Condition "read != 4 || err != OK || size > (uint32_t)in_buf.size()" is true. Continuing. core/debugger/remote_debugger_peer.cpp:134 - Condition "read != 4 || err != OK || size > (uint32_t)in_buf.size()" is true. Continuing. core/debugger/remote_debugger_peer.cpp:134 - Condition "read != 4 || err != OK || size > (uint32_t)in_buf.size()" is true. Continuing. core/debugger/remote_debugger_peer.cpp:134 - Condition "read != 4 || err != OK || size > (uint32_t)in_buf.size()" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:134 - Condition "read != 4 || err != OK || size > (uint32_t)in_buf.size()" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. Malformed packet received, not an Array. core/io/marshalls.cpp:117 - Condition "len < 4" is true. Returning: ERR_INVALID_DATA core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:134 - Condition "read != 4 || err != OK || size > (uint32_t)in_buf.size()" is true. Continuing. core/debugger/remote_debugger_peer.cpp:134 - Condition "read != 4 || err != OK || size > (uint32_t)in_buf.size()" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/io/marshalls.cpp:121 - Condition "(header & 0xFF) >= Variant::VARIANT_MAX" is true. Returning: ERR_INVALID_DATA core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/io/marshalls.cpp:117 - Condition "len < 4" is true. Returning: ERR_INVALID_DATA core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/io/marshalls.cpp:117 - Condition "len < 4" is true. Returning: ERR_INVALID_DATA core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/io/marshalls.cpp:117 - Condition "len < 4" is true. Returning: ERR_INVALID_DATA core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. core/debugger/remote_debugger_peer.cpp:145 - Condition "read != in_pos || err != OK" is true. Continuing. ``` ### Minimal reproduction project (MRP) I don't have it right now because my project is quite complex. Also I'm not sure if I can extract the right section to make a MRP. Let me know if you have some guideline that allow me to focus in a specified section of my code. Thanks
bug,topic:editor,needs testing,crash
low
Critical
2,486,462,190
flutter
Swiping on a listview under perspective can cause erratic behaviour
### Steps to reproduce Have a ListView under a Transform with a perspective that imitates a "road". If you swipe your finger outside of the visible bounds of the list, the list jumps to an unpredictable location, in a direction opposite to that of a swipe. ### Expected results The list should behave "normally". ### Actual results The list jumps to an unpredictable location. ### Code sample <details open><summary>Code sample</summary> ```dart import 'package:flutter/material.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( title: 'Flutter Demo', theme: ThemeData( colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple), useMaterial3: true, ), home: const MyHomePage(title: 'Flutter Demo Home Page'), ); } } class MyHomePage extends StatefulWidget { const MyHomePage({super.key, required this.title}); final String title; @override State<MyHomePage> createState() => _MyHomePageState(); } class _MyHomePageState extends State<MyHomePage> { final _scrollController = ScrollController(); @override Widget build(BuildContext context) { return Scaffold( appBar: AppBar( backgroundColor: Theme.of(context).colorScheme.inversePrimary, title: Text(widget.title), ), body: Transform( transform: Matrix4.identity()..setEntry(3, 1, -0.003), alignment: Alignment.bottomCenter, child: ListView.builder( controller: _scrollController, physics: const ClampingScrollPhysics(), reverse: true, itemBuilder: (context, index) => Container( color: index.isEven ? Colors.white : Colors.black12, alignment: Alignment.center, child: Text('Item $index'), ), ), ), floatingActionButton: FloatingActionButton( tooltip: 'Reset To Start of the List', onPressed: () => _scrollController.animateTo( 0, duration: const Duration(seconds: 1), curve: Curves.easeInOut, ), child: const Icon(Icons.backspace_sharp), ), // This trailing comma makes auto-formatting nicer for build methods. ); } } ``` </details> ### Screenshots or Video <details open> <summary>Screenshots / Video demonstration</summary> https://github.com/user-attachments/assets/ee2db010-33fb-4e71-bbca-5a5be825d067 </details> ### Logs <details open><summary>Logs</summary> ```console Nothing in the logs when this happens ``` </details> ### Flutter Doctor output (Flutter version should not matter, we've had this for a long time.) <details open><summary>Doctor output</summary> ```console Doctor summary (to see all details, run flutter doctor -v): [✓] Flutter (Channel stable, 3.22.3, on macOS 14.5 23F79 darwin-arm64, locale en-PL) [✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1) [✓] Xcode - develop for iOS and macOS (Xcode 15.4) [✓] Chrome - develop for the web [✓] Android Studio (version 2022.3) [✓] IntelliJ IDEA Community Edition (version 2023.2.1) [✓] VS Code (version 1.92.1) [✓] Connected device (4 available) [✓] Network resources • No issues found! ``` </details>
framework,f: scrolling,has reproducible steps,P3,team-framework,triaged-framework,found in release: 3.24,found in release: 3.25
low
Major
2,486,488,252
PowerToys
Keyboard chatter blocker
### Description of the new feature / enhancement Include keyboard chatter blocker, similar to the https://github.com/mcmonkeyprojects/KeyboardChatterBlocker ### Scenario when this would be used? Any mechanical keyboard can produce chatter ### Supporting information _No response_
Needs-Triage,Needs-Team-Response
low
Minor
2,486,501,766
material-ui
[system] Remove createUseThemeProps, RtlProvider, DefaultPropsProvider, useDefaultProps API
### Summary From https://github.com/mui/material-ui/pull/40648#issuecomment-1961591574 > This PR aims to remove the usage of React context to make some components RSC compatible while having backward compatible with emotion. What's the use case to have RSC compatible components? We use the Badge in the PR, but I guess it's not the objective (I don't see why a developer would want this with his component, there would be no state change animations, the onClick listener wouldn't works, etc.), but I guess the Badge is meant as a supplement for layout components. For instance, it makes a lot of sense to me with a `<Container>` with a different default layout mode propagated with the context or for a static content: https://github.com/mui/mui-x/issues/12180). Now, I don't think this change is needed, we can have context (maybe with nesting support but not sure) https://github.com/emotion-js/emotion/issues/2978#issuecomment-1935131675. > Trade-off But them, how can we support theme nesting? I don't see this mentioned, but I think it matters. For example, how is the documentation of Material UI supposed to be able to show components in their default form while the docs has a MUI branded theme? At first sight, I would recommend: - We revert this PR. - We introduce a server side theme, to live in the server bundle, alongside the a client bundle theme. We need this anyway to get RSC support with Emotion. - We update the theme provider and theme customer to support both theme locations. This way, we get: - No theme propagation feature regression on the client bundle, theme nesting continues to work. On the server bundle, the theme nesting mighty not work, it depends on how React calls the cache API, but I wouldn't expect it to be achievable. Maybe one-day if React introduce a true context RSC API. - The foundations for Emotion with RSC. Opportunity moved to https://github.com/mui/material-ui/issues/43443 **Search keywords**: **Search keywords**:
priority: important,package: system
low
Major
2,486,520,013
rust
`#[repr()]` is allowed where it shouldn't
<!-- Thank you for filing a bug report! 🐛 Please provide a short summary of the bug, along with any information you feel relevant to replicating the bug. --> I tried this code: ```rust #[repr()] const CONST: u32 = 8; #[repr()] struct Struct; #[repr()] trait Trait {} #[repr()] impl Trait for Struct {} #[repr()] fn func() { #[repr()] let a = 4; } ``` I expected to see this happen: #[repr] doesn't make sense on other than struct/enum/union, so it shouldn't be permitted. Every case except the `struct` should be an error. Not sure if that one ought to be legal either, but I guess the current warning is enough there. Instead, this happened: Plenty of unused attribute warnings, but it compiles. ### Meta Tested on [playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=bef7acb458748796dba32d5be738999f), both `1.80.1` and `1.82.0-nightly (2024-08-24 f167efad2f51088d8618)`.
A-attributes,T-lang,T-compiler,C-bug,A-repr
low
Critical
2,486,551,373
godot
after update to Godot 4.3 frequent in-game freezes
### Tested versions Reproducible in: 4.3.0 Not reproducible in: 4.2.x ### System information Linux, X11 Godot 4.3.0 using Forward+ ### Issue description After update to Godot 4.3, my game project is starting to randomly freeze in-game (never the editor, even if it has a lot of `@tool`) it just stops drawing and hitting pause to open the debugger (or opening remote explorer) in the editor has no effect, while the stop button works. the only visible thing that might give some information, is that when it freezes it starts to output on log (when starting godot from the terminal) the message: Object was deleted while awaiting a callback. this message is repeated thousands upon thousands of times, which seems to happen in message_queue.cpp, line 406 ### Steps to reproduce just start playing the game for a while, and the total freeze happens after one-two minutes ### Minimal reproduction project (MRP) Unfortunately it seems to happen only in my project, which is rather big, so i wouldn't know exactly how to do a minimal project that shows the problem (doesn't seem to happen on the official example projects) I can rebuild Godot itself and add more debug or breakpoints in godot itself, if it might help.
bug,needs testing
low
Critical
2,486,590,427
deno
DX: Permissions prompts don't have "deny all" setting
When you first run something with Deno, you'll likely encounter a permission prompt. In this case I've been running the `npm:create-next-app` package and the first thing it asks is for permission to access environment variables. ```sh $ deno run npm:create-next-app@latest my-next-app ┏ ⚠️ Deno requests env access to "NO_COLOR". ┠─ Learn more at: https://docs.deno.com/go/--allow-env ┠─ Run again with --allow-env to bypass this prompt. ┗ Allow? [y/n/A] (y = yes, allow; n = no, deny; A = allow all env permissions) > ``` The prompt gives me three options: 1. Allow 2. Deny 3. Allow all But there is not `Deny All` option. I can deny it for this particular env variable, but since it's asking for 20 more it's a bit tedious. The only way a user can address this is by clicking on the link, (hopefully) learning about `--deny-env` and passing that to the command prompt. This makes me wonder if it would be easier if we had a `deny all` option in the prompt.
permissions
low
Major
2,486,667,513
flutter
New Material 3 `Slider` specs breaks overlay
### Use case New Material 3 `Slider` specs doesn't provide overlay color anymore and it is also missing the tokens database. <img width="955" alt="image" src="https://github.com/user-attachments/assets/932c9347-14e1-4ccc-b75b-555dc64c4030"> I can confirm Android components Slider also missing overlay in light mode and but not in dark mode on Android. However, when running the same demo on Android 15, overlay is also missing in dark mode. In Flutter, without Slider overlay there is no way to indicate the user if a Slider is hovered, focused, highlighted. I decided to NOT remove overlay in https://github.com/flutter/flutter/pull/152237 to avoid breaking such visual indicators and accessibility support. ### Proposal Update `Slider` overlay when there is more information on the Slider overlay design and it's implications in Flutter.
framework,f: material design,c: proposal,P2,team-design,triaged-design,dependency: material
low
Major
2,486,675,856
terminal
Getting a large dump of "^[[D" to the terminal on click in WSL Ubuntu Dev
### Windows Terminal version 1.22.2371.0 ### Windows build number 10.0.22635.4076 ### Other Software _No response_ ### Steps to reproduce Running WSL2 C:\Windows\system32\wsl.exe -d Ubuntu. Having "Automatically mark prompts on pressing Enter" enabled. Have long running job. "find ." or "docker-compose up" Clicking the terminal. ### Expected Behavior Nothing to be added. ### Actual Behavior Clicking the terminal causes a large dump to terminal. If I turn "Automatically mark prompts on pressing Enter" off it goes away. ![image](https://github.com/user-attachments/assets/1ad2cc4d-a80e-415c-98af-4fa20636b3de)
Issue-Bug,Area-TerminalControl,Product-Terminal
low
Minor
2,486,678,927
next.js
Next 14 App router AsyncLocalStorage From middleware to server component
### Link to the code that reproduces this issue https://github.com/KevinEonix/next-asyncLocalStorage ### To Reproduce 1. start npm run dev 2. access the default page 3. message rendered is `Context is undefined :(` ### Current vs. Expected behavior The phrase should be `test value in store is test value` ### Provide environment information ```bash Operating System: Platform: win32 Arch: x64 Version: Windows 11 Pro Available memory (MB): 32370 Available CPU cores: 12 Binaries: Node: 20.9.0 npm: 10.1.0 Yarn: N/A pnpm: N/A Relevant Packages: next: 14.2.6 // Latest available version is detected (14.2.6). eslint-config-next: 14.2.6 react: 18.3.1 react-dom: 18.3.1 typescript: 5.5.4 Next.js Config: output: N/A ``` ### Which area(s) are affected? (Select all that apply) Developer Experience, Middleware ### Which stage(s) are affected? (Select all that apply) next dev (local) ### Additional context I tested that on an other project and have the same problem (same machine sane versions)
bug,Middleware
low
Minor
2,486,697,855
pytorch
linalg.lu_factor: LU without pivoting is not implemented on the CPU
### 🐛 Describe the bug ```python import torch print(torch.__version__) A = torch.tensor([ [1,1,1], [1,2,2], [1,2,3] ], dtype=torch.float32) l, u = torch.linalg.lu(A, pivot = False) ``` returns ```bash 2.4.0+cpu Traceback (most recent call last): File C:\Python\Python39\lib\site-packages\spyder_kernels\py3compat.py:356 in compat_exec exec(code, globals, locals) File untitled0.py:18 l, u = torch.linalg.lu(A, pivot = False) RuntimeError: linalg.lu_factor: LU without pivoting is not implemented on the CPU ``` Would there be a difference between GPU and CPU implementation? ### Versions 2.4.0+cpu cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jianyuh @nikitaved @pearu @mruberry @walterddr @xwang233 @Lezcano
module: cpu,triaged,module: linear algebra,actionable
low
Critical
2,486,720,279
ui
[feat]: tree view component with drag & drop
### Feature description A tree view component with drag & drop functionality (to move around files and folders), something like [minop1205/react-dnd-treeview](https://minop1205.github.io/react-dnd-treeview/?path=/docs/basic-examples-custom-drag-preview--custom-drag-preview-story) I see that it's been requested before in the past as well https://github.com/shadcn-ui/ui/issues/1875 and https://github.com/shadcn-ui/ui/issues/355 ### Affected component/components _No response_ ### Additional Context [@atlassian/pragmatic-drag-and-drop](https://github.com/atlassian/pragmatic-drag-and-drop) seems like a good contender to implement this kind of functionality. Checkout their [tree view](https://atlassian.design/components/pragmatic-drag-and-drop/examples/#tree) example. ### Before submitting - [X] I've made research efforts and searched the documentation - [X] I've searched for existing issues and PRs
area: request
low
Major
2,486,748,482
opencv
How to build static library for iOS?
### Describe the doc issue Hi there. The [Doc](https://docs.opencv.org/4.x/d5/da3/tutorial_ios_install.html) only shows how to build a framework. Is there any way to build static library? ### Fix suggestion _No response_
category: documentation
low
Minor
2,486,761,614
kubernetes
Deletion of csi-node-plugin Pod causes driver entry to be removed from CSINode object; kube-scheduler schedules more than driver's allocatable
### What happened? With @plkokanov we hit in our environments the following issue multiple times: ``` % k -n shoot--foo--bar describe po etcd-main-0 Events: Type Reason Age From Message ---- ------ ---- ---- ------- Warning FailedAttachVolume 35s (x47 over 80m) attachdetach-controller AttachVolume.Attach failed for volume "pv-shoot--shik--shak-1234" : rpc error: code = Internal desc = Attach volume /subscriptions/<omitted>/resourceGroups/shoot--shik--shak/providers/Microsoft.Compute/disks/pv-shoot--shik--shak-1234 to instance shoot--shik--shak-cpu-worker-etcd-z1-6c956-mhcw5 failed with Retriable: false, RetryAfter: 0s, HTTPStatusCode: 409, RawError: {\r "error": {\r "code": "OperationNotAllowed",\r "message": "The maximum number of data disks allowed to be attached to a VM of this size is 16.",\r "target": "dataDisks"\r }\r } ``` When we checked, the CSINode object for the corresponding Node was reporting the correct volume attachment limit: ``` % k get csinode shoot--shik--shak-cpu-worker-etcd-z1-6c956-mhcw5 -o yaml spec: drivers: # ... - allocatable: count: 16 name: disk.csi.azure.com nodeID: shoot--shik--shak-cpu-worker-etcd-z1-6c956-mhcw5 topologyKeys: - topology.disk.csi.azure.com/zone - topology.kubernetes.io/zone ``` According to the Node status and according to the VM state in Azure, it had already 16 disks attached. ``` % k get no shoot--shik--shak-cpu-worker-etcd-z1-6c956-mhcw5 -o json | jq '.status.volumesAttached | length' 16 % az vm show -g shoot--shik--shak --name shoot--shik--shak-cpu-worker-etcd-z1-6c956-mhcw5 | jq '.storageProfile.dataDisks | length' 16 ``` kube-scheduler wrongly sheduled a Pod with a volume to the `shoot--shik--shak-cpu-worker-etcd-z1-6c956-mhcw5` Node as the Node already had its volume attachments limit reached. We found that this happens due to csi-node-plugin Pod deletion. On deletion of this Pod, we see that the driver section from the CSINode object is removed and it is added only when the new csi-node-plugin Pod starts. The corresponding handling in kube-scheduler's NodeVolumeLimits plugin is: https://github.com/kubernetes/kubernetes/blob/a7242fcff768658019f878cb691583dcbcfefb2d/pkg/scheduler/framework/plugins/nodevolumelimits/csi.go#L197-L201 If we fail to fetch the limit from the CSINode object, kube-scheduler let's the Pod to be scheduled. ### What did you expect to happen? kube-scheduler to do not schedule Pods with volumes to Nodes that already have their volume attachment limit reached. ### How can we reproduce it (as minimally and precisely as possible)? To reproduce the removal of the driver section after csi-node-plugin Pod deletion: 1. Start watching the CSINode object: ``` k get csinode "$NODENAME" -w -o yaml > "~/csinode-$NODENAME.yaml" ``` 2. In a new terminal window delete the csi-node-plugin Pod 3. Make sure that the CSINode object watch is as follows: ```yaml apiVersion: storage.k8s.io/v1 kind: CSINode metadata: name: node-1 spec: drivers: - allocatable: count: 8 name: disk.csi.azure.com nodeID: node-1 topologyKeys: - topology.disk.csi.azure.com/zone - topology.kubernetes.io/zone --- apiVersion: storage.k8s.io/v1 kind: CSINode metadata: name: node-1 spec: drivers: null --- apiVersion: storage.k8s.io/v1 kind: CSINode metadata: name: node-1 spec: drivers: - allocatable: count: 8 name: disk.csi.azure.com nodeID: node-1 topologyKeys: - topology.disk.csi.azure.com/zone - topology.kubernetes.io/zone ``` Note: The non-relevant fields are removed from the example output above. You can see that until the new csi-node-plugin is scheduled and started, the CSINode object does not contain any information about the driver. We see that during that time kube-scheduler schedules new Pods with volumes to that Node. The kube-scheduler plugin for respecting the Node volume limit is: https://github.com/kubernetes/kubernetes/blob/a7242fcff768658019f878cb691583dcbcfefb2d/pkg/scheduler/framework/plugins/nodevolumelimits/csi.go ### Anything else we need to know? We use VPA to scale the csi-node-plugin Pod. That's why it can be evicted and restarted. ### Kubernetes version <details> ```console $ kubectl version Server Version: v1.29.4 ``` </details> ### Cloud provider <details> Azure and AWS </details> ### OS version <details> ```console # On Linux: $ cat /etc/os-release # paste output here $ uname -a # paste output here # On Windows: C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture # paste output here ``` </details> ### Install tools <details> Gardener </details> ### Container runtime (CRI) and version (if applicable) <details> </details> ### Related plugins (CNI, CSI, ...) and versions (if applicable) <details> [azuredisk-csi-driver](https://github.com/kubernetes-sigs/azuredisk-csi-driver): v1.30.0 </details>
kind/bug,sig/storage,triage/accepted
low
Critical
2,486,785,781
PowerToys
Something went wrong.
### Microsoft PowerToys version 0.83.0.0 ### Installation method WinGet ### Running as admin No ### Area(s) with issue? General ### Steps to reproduce Apparently something went wrong while I was not using the system. I signed on and saw this message. ![image](https://github.com/user-attachments/assets/574a5722-fd81-4195-baeb-01cca6beea77) [2024-08-22.txt](https://github.com/user-attachments/files/16748725/2024-08-22.txt) ### ✔️ Expected Behavior Not to see an error message when I logged onto my PC. ### ❌ Actual Behavior No additional information available. ### Other Software _No response_
Issue-Bug,Needs-Triage
low
Critical
2,486,898,960
pytorch
Cannot create and distribute array in torch.func.grad
While experimenting with PyTorch's DTensor functionality in my single node "cpu" environment, I've encountered an unexpected limitation. Specifically, in the provided code example, I'm attempting to use torch.func.grad to compute gradients of a forward function that involves distributed tensors (DTensors) created with distribute_tensor. It raises : "RuntimeError: You are attempting to call Tensor.requires_grad_() (or perhaps using torch.autograd.functional.* APIs) inside of a function being transformed by a functorch transform. This is unsupported, please attempt to use the functorch transforms (e.g. grad, vjp, jacrev, jacfwd, hessian) or call requires_grad_() outside of a function being transformed instead." Repro: ```python from functools import partial import os import torch import torch.distributed as dist from torch.func import grad from torch.distributed._tensor import DeviceMesh, init_device_mesh, distribute_tensor, Shard, Replicate def forward(weight, input, device_mesh: DeviceMesh): res = input @ weight rand = distribute_tensor(torch.rand(res.shape), device_mesh, [Replicate()]) res += rand return res.mean() def run(): rank = int(os.environ['RANK']) world_size = int(os.environ['WORLD_SIZE']) # Initialize the process group dist.init_process_group("gloo", rank=rank, world_size=world_size) device_mesh = init_device_mesh("cpu", (world_size,)) input = torch.ones(256, 128) weight = torch.ones(128, 256) input_d = distribute_tensor(input, device_mesh, [Shard(0)]) weight_d = distribute_tensor(weight, device_mesh, [Replicate()]) _forward = partial(forward, input=input_d, device_mesh=device_mesh) grads = grad(_forward)(weight_d) if rank == 0: print(grads) # Clean up the process group dist.destroy_process_group() if __name__ == "__main__": run() ``` Terminal script: `torchrun --nproc_per_node=4 test.py` ### Versions PyTorch version: 2.4.0 Is debug build: False CUDA used to build PyTorch: None ROCM used to build PyTorch: N/A OS: macOS 14.6.1 (arm64) GCC version: Could not collect Clang version: 15.0.0 (clang-1500.1.0.2.5) CMake version: version 3.28.1 Libc version: N/A Python version: 3.11.0 (main, Mar 1 2023, 12:33:14) [Clang 14.0.6 ] (64-bit runtime) Python platform: macOS-14.6.1-arm64-arm-64bit Is CUDA available: False CUDA runtime version: No CUDA CUDA_MODULE_LOADING set to: N/A GPU models and configuration: No CUDA Nvidia driver version: No CUDA cuDNN version: No CUDA HIP runtime version: N/A MIOpen runtime version: N/A Is XNNPACK available: True CPU: Apple M2 Pro Versions of relevant libraries: [pip3] numpy==1.26.0 [pip3] torch==2.4.0 [conda] numpy 1.26.0 pypi_0 pypi [conda] torch 2.4.0 pypi_0 pypi cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @zou3519 @Chillee @samdow @kshitij12345 @tianyu-l @janeyx99
oncall: distributed,triaged,module: functorch,module: dtensor
low
Critical
2,486,947,586
material-ui
[material-ui] [Stepper] Connecting line issues when label is a long string
### Steps to reproduce Link to live example: https://stackblitz.com/edit/react-cemc8z?file=Demo.tsx Resize the preview to a small mobile size ### Current behavior ![image](https://github.com/user-attachments/assets/6c9bc1cd-dd09-484f-b289-860cbaeedccc) ### Expected behavior - The first connecting line does not clip into the first step button - The connecting line after step 2 has some more spacing - The connecting line after step 3 starts sooner Basically that it looks like if it was on desktop, just with shorter lines/more compressed. ### Context I'm trying to use the stepper with horizontal scrolling, which works fine, just causes these visual artifacts ### Your environment <details> <summary><code>npx @mui/envinfo</code></summary> ``` System: OS: macOS 14.6.1 Binaries: Node: 22.7.0 - /opt/homebrew/bin/node npm: 10.8.2 - /opt/homebrew/bin/npm pnpm: Not Found Browsers: Chrome: Not Found Chromium: 130.0.6677.0 <-- used Edge: Not Found Safari: 17.6 <-- used Firefox: 129.0.2 <-- used ``` </details> **Search keywords**: stepper, alternativeLabel, lines
support: question,waiting for 👍,component: stepper,customization: css
low
Minor
2,486,962,852
rust
encountered incremental compilation error with `evaluate_obligation`
Hi! Sorry I don't really have the time to make a minimal example, but here are some steps that allow me to repro this bug with 100% rate, even after a `cargo clean` (@lqd told me it's worth filing a bug for this). ### Code - Clone https://github.com/bnjbvr/matrix-rust-sdk/tree/bnjbvr/send-q-reactions - Checkout 6611815d4ebfe5d32dc230ae0aeb13ca0f9e9dfe (the commit named "WIP") - from the main directory, run `cargo nextest run --workspace --retries 0 --exclude matrix-sdk-integration-testing`. (All tests should pass, but I suspect it's not required to even run them.) - then checkout the head "WIP squared" aka 222dcc9620d33c81333dd91bdcfaabf0e5a84a33 - retry to run the above command ### Meta `rustc --version --verbose`: ``` rustc 1.80.1 (3f5fd8dd4 2024-08-06) binary: rustc commit-hash: 3f5fd8dd41153bc5fdca9427e9e05be2c767ba23 commit-date: 2024-08-06 host: x86_64-unknown-linux-gnu release: 1.80.1 LLVM version: 18.1.7 ``` ### Error output <details><summary><strong>Backtrace</strong></summary> <p> ``` error: internal compiler error: encountered incremental compilation error with evaluate_obligation(6bb4efc4e83b8d71-9f343aba19e9c9eb) | = help: This is a known issue with the compiler. Run `cargo clean -p matrix_sdk_ffi` or `cargo clean` to allow your project to compile = note: Please follow the instructions below to create a bug report with the provided information = note: See <https://github.com/rust-lang/rust/issues/84970> for more information thread 'rustc' panicked at /rustc/3f5fd8dd41153bc5fdca9427e9e05be2c767ba23/compiler/rustc_query_system/src/query/plumbing.rs:726:9: Found unstable fingerprints for evaluate_obligation(6bb4efc4e83b8d71-9f343aba19e9c9eb): Err(Canonical) stack backtrace: 0: rust_begin_unwind at /rustc/3f5fd8dd41153bc5fdca9427e9e05be2c767ba23/library/std/src/panicking.rs:652:5 1: core::panicking::panic_fmt at /rustc/3f5fd8dd41153bc5fdca9427e9e05be2c767ba23/library/core/src/panicking.rs:72:14 2: rustc_query_system::query::plumbing::incremental_verify_ich_failed::<rustc_middle::ty::context::TyCtxt> 3: rustc_query_system::query::plumbing::try_execute_query::<rustc_query_impl::DynamicConfig<rustc_query_system::query::caches::DefaultCache<rustc_type_ir::canonical::Canonical<rustc_middle::ty::context::TyCtxt, rustc_middle::ty::ParamEnvAnd<rustc_middle::ty::predicate::Predicate>>, rustc_middle::query::erase::Erased<[u8; 2]>>, false, false, false>, rustc_query_impl::plumbing::QueryCtxt, true> 4: <rustc_trait_selection::traits::fulfill::FulfillProcessor as rustc_data_structures::obligation_forest::ObligationProcessor>::process_obligation 5: <rustc_data_structures::obligation_forest::ObligationForest<rustc_trait_selection::traits::fulfill::PendingPredicateObligation>>::process_obligations::<rustc_trait_selection::traits::fulfill::FulfillProcessor> 6: <rustc_trait_selection::traits::engine::ObligationCtxt<rustc_trait_selection::traits::FulfillmentError>>::assumed_wf_types_and_report_errors 7: rustc_hir_analysis::check::wfcheck::check_well_formed [... omitted 1 frame ...] 8: rustc_hir_analysis::check::wfcheck::check_mod_type_wf [... omitted 1 frame ...] 9: rustc_hir_analysis::check_crate 10: rustc_interface::passes::analysis [... omitted 1 frame ...] 11: rustc_interface::interface::run_compiler::<core::result::Result<(), rustc_span::ErrorGuaranteed>, rustc_driver_impl::run_compiler::{closure#0}>::{closure#1} note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace. error: the compiler unexpectedly panicked. this is a bug. note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md note: rustc 1.80.1 (3f5fd8dd4 2024-08-06) running on x86_64-unknown-linux-gnu note: compiler flags: -C embed-bitcode=no -C linker=clang -C incremental=[REDACTED] -C strip=debuginfo -C link-arg=-fuse-ld=/usr/bin/mold note: some of the compiler flags provided by cargo are hidden query stack during panic: #0 [evaluate_obligation] evaluating trait selection obligation `timeline::Timeline: core::marker::Sync` #1 [check_well_formed] checking that `timeline::<impl at bindings/matrix-sdk-ffi/src/timeline/mod.rs:80:10: 80:24>` is well-formed #2 [check_mod_type_wf] checking that types are well-formed in module `timeline` #3 [analysis] running analysis passes on this crate end of query stack ``` </p> </details>
I-ICE,T-compiler,A-incr-comp,C-bug,S-has-mcve
low
Critical
2,487,014,275
react-native
Creating a module with New Architecture and including a .swift file introduces compiler errors
### Description I'm upgrading one of our open-source libraries, which uses Swift for the logic. However, when I include `swift` in the podspec `source_files`, I get compiler errors. ### Steps to reproduce I'm running into compiler errors after updating the podspec for the module to include `.swift` files in the `ios/` directory. ```ruby s.source_files = "ios/**/*.{h,m,mm,cpp,swift}" <--- adding Swift ``` After building the development pod, I get this error: <img width="1005" alt="Screenshot 2024-08-26 at 10 11 15 AM" src="https://github.com/user-attachments/assets/8c5a6b00-d708-4738-bef8-0bca0512cd43"> I found a workaround by omitting the following: 1. ```ruby s.source_files = "ios/**/*.{h,m,mm,cpp}" <--- remove swift ``` 2. `run bundle exec pod install` 3. Add the `.swift` file manually <img width="411" alt="Screenshot 2024-08-26 at 10 18 12 AM" src="https://github.com/user-attachments/assets/ae120f81-bd51-4a72-aad9-63f44bb497d4"> After building the project, there is no compiler error. This is fine for testing, but I need to update the podspec to include the file in the `Compile Sources`, otherwise, other errors will occur. ### React Native Version 0.74.0 ### Affected Platforms Runtime - iOS ### Areas TurboModule - The New Native Module System ### Output of `npx react-native info` ```text System: OS: macOS 14.4.1 CPU: (8) arm64 Apple M1 Memory: 175.06 MB / 16.00 GB Shell: version: "5.9" path: /bin/zsh Binaries: Node: version: 18.18.0 path: ~/.nvm/versions/node/v18.18.0/bin/node Yarn: version: 3.6.4 path: /opt/homebrew/bin/yarn npm: version: 9.8.1 path: ~/.nvm/versions/node/v18.18.0/bin/npm Watchman: version: 2024.04.15.00 path: /opt/homebrew/bin/watchman Managers: CocoaPods: version: 1.15.2 path: /Users/gary/.rvm/gems/ruby-2.7.5/bin/pod SDKs: iOS SDK: Platforms: - DriverKit 23.5 - iOS 17.5 - macOS 14.5 - tvOS 17.5 - visionOS 1.2 - watchOS 10.5 Android SDK: API Levels: - "29" - "30" - "31" - "32" - "33" - "34" Build Tools: - 28.0.3 - 30.0.2 - 30.0.3 - 31.0.0 - 32.0.0 - 32.1.0 - 33.0.0 - 33.0.1 - 34.0.0 System Images: - android-32 | Google APIs ARM 64 v8a - android-32 | Google Play ARM 64 v8a - android-33 | Google APIs ARM 64 v8a - android-33 | Google Play ARM 64 v8a - android-Tiramisu | Google APIs ARM 64 v8a Android NDK: 22.1.7171670 IDEs: Android Studio: 2023.2 AI-232.10300.40.2321.11668458 Xcode: version: 15.4/15F31d path: /usr/bin/xcodebuild Languages: Java: version: 17.0.12 path: /usr/bin/javac Ruby: version: 2.7.5 path: /Users/gary/.rvm/rubies/ruby-2.7.5/bin/ruby npmPackages: "@react-native-community/cli": Not Found react: installed: 18.3.1 wanted: 18.3.1 react-native: installed: 0.75.2 wanted: 0.75.2 react-native-macos: Not Found npmGlobalPackages: "*react-native*": Not Found Android: hermesEnabled: true newArchEnabled: true iOS: hermesEnabled: true newArchEnabled: true ``` ### Stacktrace or Logs ```text n/a ``` ### Reproducer https://github.com/candlefinance/oss/tree/feat-convert-send-na ### Screenshots and Videos _No response_
Needs: Repro,Newer Patch Available,Type: New Architecture
low
Critical
2,487,018,214
next.js
[15.0.0-canary.111+] Infinite loading page when fetch has "force-cache" in generateMetadata layout.tsx
### Link to the code that reproduces this issue https://github.com/aXenDeveloper/next-app-canary ### To Reproduce 1. Clone repo, 2. `pnpm i`, 3. Start app with `pnpm dev` or 1. `pnpm create next-app@canary` 4. In `src/app/layout.tsx` replace `metadata` to: ```tsx export const generateMetadata = async (): Promise<Metadata> => { await fetch("http://localhost:8080/graphql", { cache: "force-cache" }); return { title: "Create Next App", description: "Generated by create next app" }; }; ``` ### Current vs. Expected behavior Loaded home page. ### Provide environment information ```bash Operating System: Platform: darwin Arch: arm64 Version: Darwin Kernel Version 24.0.0: Tue Sep 24 23:37:36 PDT 2024; root:xnu-11215.1.12~1/RELEASE_ARM64_T6020 Available memory (MB): 16384 Available CPU cores: 12 Binaries: Node: 20.11.0 npm: 10.2.4 Yarn: N/A pnpm: 9.10.0 Relevant Packages: next: 15.0.1-canary.2 // Latest available version is detected (15.0.1-canary.2). eslint-config-next: N/A react: 19.0.0-rc-45804af1-20241021 react-dom: 19.0.0-rc-45804af1-20241021 typescript: 5.6.3 Next.js Config: output: N/A ``` ### Which area(s) are affected? (Select all that apply) Metadata ### Which stage(s) are affected? (Select all that apply) next dev (local), next start (local) ### Additional context When fetch has "force-cache" inside `generateMetadata()` and API has fetch error then page will have infinite loading. ```tsx export const generateMetadata = async (): Promise<Metadata> => { await fetch("http://localhost:8080/graphql", { cache: "force-cache" }); return { title: "Create Next App", description: "Generated by create next app" }; }; ``` It happens from `15.0.0-canary.111`+. `15.0.0-canary.110` works fine.
bug,Metadata
low
Critical
2,487,027,867
tensorflow
Error while loading Tensorflow plugins - cuFFT, cuDNN, cuBLAS
### Issue type Bug ### Have you reproduced the bug with TensorFlow Nightly? Yes ### Source binary ### TensorFlow version tf 2.17 ### Custom code No ### OS platform and distribution Linux Ubuntu 22.04 ### Mobile device _No response_ ### Python version 3.10 ### Bazel version _No response_ ### GCC/compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current behavior? ```Tensorflow==2.16.1``` does not produce the following log output errors. I tried to read the source for ```tensorflow==2.17.0 and 2.16.1``` to at least try find out what might be the issue. The following is what I found out: The executed piece of code for registering the plugin ```cuFFT``` is located at the file: ```tensorflow-2.16.1/third_party/xla/xla/stream_executor/cuda/cuda_fft.c``` (you can change the tensorflow version # appropriately) and reproduced below: ```c++ void initialize_cufft() { absl::Status status = PluginRegistry::Instance()->RegisterFactory<PluginRegistry::FftFactory>( cuda::kCudaPlatformId, "cuFFT", [](internal::StreamExecutorInterface *parent) -> fft::FftSupport * { gpu::GpuExecutor *cuda_executor = dynamic_cast<gpu::GpuExecutor *>(parent); if (cuda_executor == nullptr) { LOG(ERROR) << "Attempting to initialize an instance of the cuFFT " << "support library with a non-CUDA StreamExecutor"; return nullptr; } return new gpu::CUDAFft(cuda_executor); }); if (!status.ok()) { LOG(ERROR) << "Unable to register cuFFT factory: " << status.message(); } } ``` This function should be responsible for creating the ```PluginRegistry``` object defined in the file: ```tensorflow-2.16.1/third_party/xla/xla/stream_executor/plugin_registry.h```. This object has a very important comment, reproduced below: ``` //The PluginRegistry is a singleton that maintains the set of registered // "support library" plugins. Currently, there are four kinds of plugins: // BLAS, DNN, and FFT. Each interface is defined in the corresponding // gpu_{kind}.h header. // Registers the specified factory with the specified platform. // Returns a non-successful status if the factory has already been registered // with that platform (but execution should be otherwise unaffected). ``` The class should be a ```Singleton```, and even if it has been registered once an attempt to register it again will fail but tensorflow should work as expected. And below is the function responsible for the registration, from the file: ```tensorflow-2.16.1/third_party/xla/xla/stream_executor/plugin_registry.cc```: ```c++ template <typename FACTORY_TYPE> absl::Status PluginRegistry::RegisterFactoryInternal( const std::string& plugin_name, FACTORY_TYPE factory, std::optional<FACTORY_TYPE>* factories) { absl::MutexLock lock{&GetPluginRegistryMutex()}; if (factories->has_value()) { return absl::AlreadyExistsError( absl::StrFormat("Attempting to register factory for plugin %s when " "one has already been registered", plugin_name)); } (*factories) = factory; return absl::OkStatus(); } ``` I am not entirely sure as to when and where the very first object of ```cuFFT PluginRegistery``` is created for tensorflow to display this error. I believe there has to be a point from running ```import tensorflow``` and calling the above function ```initialize_cufft``` where the ```PluginRegistry``` object is created and since it must be a ```Singleton```, hence the error. I hope someone can elaborate further on this, or provide better clarity. ### Standalone code to reproduce the issue ```shell python -c "import tensorflow as tf; print(tf.config.list_physical_devices('GPU'))" ``` ### Relevant log output ```shell 2024-08-26 16:31:19.008920: E external/local_xla/xla/stream_executor/cuda/cuda_fft.cc:485] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered 2024-08-26 16:31:19.027228: E external/local_xla/xla/stream_executor/cuda/cuda_dnn.cc:8454] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered 2024-08-26 16:31:19.032798: E external/local_xla/xla/stream_executor/cuda/cuda_blas.cc:1452] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered 2024-08-26 16:31:19.047347: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations. To enable the following instructions: AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags. 2024-08-26 16:31:20.104940: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT WARNING: All log messages before absl::InitializeLog() is called are written to STDERR I0000 00:00:1724682680.723847 4894 cuda_executor.cc:1015] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355 I0000 00:00:1724682680.805189 4894 cuda_executor.cc:1015] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355 I0000 00:00:1724682680.805836 4894 cuda_executor.cc:1015] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355 2024-08-26 16:31:20.806043: W tensorflow/core/common_runtime/gpu/gpu_device.cc:2432] TensorFlow was not built with CUDA kernel binaries compatible with compute capability 5.0. CUDA kernels will be jit-compiled from PTX, which could take 30 minutes or longer. [PhysicalDevice(name='/physical_device:GPU:0', device_type='GPU')] ```
stat:awaiting tensorflower,type:build/install,subtype: ubuntu/linux,2.17
low
Critical
2,487,034,370
terminal
We should recurse upwards when looking for local snippets
#17388 only supported the exact current directory for looking for snippets. We should instead support looking for snippets recursively from the CWD, and layering top-down (so snippets in subdirs overwrite ones in higher dirs). (as spec'd in #17329)
Product-Terminal,Issue-Task,Needs-Tag-Fix,Area-Suggestions
low
Minor
2,487,086,078
go
x/tools/gopls: detect tools.go files, and suppress warning
I've been looking for a way to fix this for quite a bit of time and nothing I've tried has worked. I'm using `oapi-codegen` to generate boilerplate for my webserver. The authors of this library recommend the [tools.go](https://www.jvt.me/posts/2022/06/15/go-tools-dependency-management/) pattern for managing the dependency, so that `go.mod` can act as the single source of truth for versioning. For transparency, their readme recommends this [here](https://github.com/oapi-codegen/oapi-codegen/tree/main?tab=readme-ov-file#install). Doing this actually works -- I can run `go generate` just fine and my code builds. However, VSCode insists on showing an error and warning in this tools.go file, marking the file and the module folder red: ![image](https://github.com/user-attachments/assets/6f7b16e5-11eb-46d7-bffe-f0e9836bd1bb) This is driving me crazy. I'd like to at least suppress these, but I can't find any way to do so. I've tried using the `lintFlags` to exclude it, but it appears to be `gopls` and not `staticcheck`, so this doesn't do anything. I can't find a `gopls` configuration setting that will allow me to ignore this file or any issues with it, either. For what it's worth, someone else noticed the same thing with a different library in [this](https://github.com/grpc-ecosystem/grpc-gateway/issues/3515) issue. ### What version of Go, VS Code & VS Code Go extension are you using? <details><summary>Version Information</summary><br> * Run `go version` to get version of Go from _the VS Code integrated terminal_. - go version go1.22.5 darwin/arm64 * Run `gopls -v version` to get version of Gopls from _the VS Code integrated terminal_. - golang.org/x/tools/gopls v0.16.1 * Run `code -v` or `code-insiders -v` to get version of VS Code or VS Code Insiders. - Version: 1.92.1 * Check your installed extensions to get the version of the VS Code Go extension - v0.42.0 * Run Ctrl+Shift+P (Cmd+Shift+P on Mac OS) > `Go: Locate Configured Go Tools` command. ``` # Tools Configuration ## Environment GOBIN: undefined toolsGopath: gopath: /Users/[username]/go GOROOT: /opt/homebrew/Cellar/go/1.22.5/libexec PATH: /opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Users/[username]/Library/Application Support/JetBrains/Toolbox/scripts:/Users/[username]/go/bin ## Tools go: /opt/homebrew/bin/go: go version go1.22.5 darwin/arm64 gopls: /Users/[username]/go/bin/gopls (version: v0.16.1 built with go: go1.22.5) gotests: not installed gomodifytags: not installed impl: not installed goplay: not installed dlv: /Users/[username]/go/bin/dlv (version: v1.23.0 built with go: go1.22.5) staticcheck: /Users/[username]/go/bin/staticcheck (version: v0.4.7 built with go: go1.22.5) ## Go env Workspace Folder (point-system): /Users/[username]/Documents/Repositories/point-system GO111MODULE='' GOARCH='arm64' GOBIN='' GOCACHE='/Users/[username]/Library/Caches/go-build' GOENV='/Users/[username]/Library/Application Support/go/env' GOEXE='' GOEXPERIMENT='' GOFLAGS='' GOHOSTARCH='arm64' GOHOSTOS='darwin' GOINSECURE='' GOMODCACHE='/Users/[username]/go/pkg/mod' GONOPROXY='' GONOSUMDB='' GOOS='darwin' GOPATH='/Users/[username]/go' GOPRIVATE='' GOPROXY='https://proxy.golang.org,direct' GOROOT='/opt/homebrew/Cellar/go/1.22.5/libexec' GOSUMDB='sum.golang.org' GOTMPDIR='' GOTOOLCHAIN='auto' GOTOOLDIR='/opt/homebrew/Cellar/go/1.22.5/libexec/pkg/tool/darwin_arm64' GOVCS='' GOVERSION='go1.22.5' GCCGO='gccgo' AR='ar' CC='cc' CXX='c++' CGO_ENABLED='1' GOMOD='/dev/null' GOWORK='' CGO_CFLAGS='-O2 -g' CGO_CPPFLAGS='' CGO_CXXFLAGS='-O2 -g' CGO_FFLAGS='-O2 -g' CGO_LDFLAGS='-O2 -g' PKG_CONFIG='pkg-config' GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/by/cxzl4qc57c3c8dd9p9snhn680000gn/T/go-build3419525479=/tmp/go-build -gno-record-gcc-switches -fno-common' ``` </details> ### Share the Go related settings you have added/edited ```json { "go.lintTool": "staticcheck", "go.lintFlags": [ "-exclude=gateway/tools/tools.go" ] } ```
help wanted,gopls,Tools,gopls/analysis
low
Critical
2,487,186,434
material-ui
[code-infra] Migrate `aws-sdk` to v3
### Steps to reproduce Check CI output: https://app.circleci.com/pipelines/github/mui/material-ui/137230/workflows/fcd89719-5dcd-4394-aac0-9bc600d5519b/jobs/739730/parallel-runs/0/steps/0-105?invite=true#step-105-2740_89 ``` .../node_modules/aws-sdk postinstall: ╔═════════════════════════════════════════════════╗ .../node_modules/aws-sdk postinstall: ║ The AWS SDK for JavaScript (v2) will reach ║ .../node_modules/aws-sdk postinstall: ║ -> maintenance mode on September 8, 2024. ║ .../node_modules/aws-sdk postinstall: ║ -> end-of-support on September 8, 2025. ║ .../node_modules/aws-sdk postinstall: ║ ║ .../node_modules/aws-sdk postinstall: ║ To continue receiving updates to AWS services, ║ .../node_modules/aws-sdk postinstall: ║ bug fixes, and security updates please upgrade ║ .../node_modules/aws-sdk postinstall: ║ to AWS SDK for JavaScript (v3). ║ .../node_modules/aws-sdk postinstall: ║ ║ .../node_modules/aws-sdk postinstall: ║ More info: https://a.co/cUPnyil ║ .../node_modules/aws-sdk postinstall: ╚═════════════════════════════════════════════════╝ ``` ### Current behavior _No response_ ### Expected behavior _No response_ ### Context _No response_ ### Your environment <details> <summary><code>npx @mui/envinfo</code></summary> ``` Don't forget to mention which browser you used. Output from `npx @mui/envinfo` goes here. ``` </details> **Search keywords**: aws-sdk
priority: low,scope: code-infra
low
Critical
2,487,206,996
tailwindcss
Duplicate ellipsis in Safari when using `<sup>` or `<sub>` tags
<!-- Please provide all of the information requested below. We're a small team and without all of this information it's not possible for us to help and your bug report will be closed. --> **What version of Tailwind CSS are you using?** v3.4.10 **What build tool (or framework if it abstracts the build tool) are you using?** N/A **What version of Node.js are you using?** N/A **What browser are you using?** Safari **What operating system are you using?** macOS **Reproduction URL** https://play.tailwindcss.com/cUuJcAdOkx **Describe your issue** When loading the above reproduction in Safari, the text is truncated with multiple sets of ellipsis. It appears to be happening due to the `position: relative` styling of the `<sup>` and `<sub>` tags. Screenshot: ![image](https://github.com/user-attachments/assets/6075dbe7-f8f7-48d2-ba08-9ad890345661)
browser bug
low
Critical
2,487,228,037
ui
Docs: Add categories to components
### Feature description Currently it is hard to browse components from the list: ![component_list](https://github.com/user-attachments/assets/63b8f291-81ee-4e1b-9037-3d020d940fb8) We can divide the components into categories for easy navigation. Can take inspirations from [Material UI](https://mui.com/material-ui/) ![mui_components](https://github.com/user-attachments/assets/362f1c87-e52d-4a9f-ac10-9f4aaaea41ab) ### Affected component/components N/A ### Additional Context _No response_ ### Before submitting - [X] I've made research efforts and searched the documentation - [X] I've searched for existing issues and PRs
area: request
low
Minor
2,487,242,003
godot
2D NavigationPolygon baked in editor produces Navigation map synchronization error in 4.3
### Tested versions - Reproducible in v4.3.stable.official [77dcf97d8] - **NOT** reproducible in v4.2.1.stable.official [b09f793f5] ### System information Godot v4.3.stable - Linux Mint 21.3 (Virginia) - X11 - Vulkan (Forward+) - dedicated AMD Radeon RX 6700 XT (RADV NAVI22) - 12th Gen Intel(R) Core(TM) i5-12400 (12 Threads) ### Issue description On a simple project (see MRP), I have a NavigationRegion2D (with a simple rectangular outline) and 2 Polygons. ![navregion](https://github.com/user-attachments/assets/8736c8e7-a533-4267-8a63-a2744b88149b) When I launch my scene, I get an error : ``` E 0:00:00:0231 sync: Navigation map synchronization error. Attempted to merge a navigation mesh polygon edge with another already-merged edge. This is usually caused by crossing edges, overlapping polygons, or a mismatch of the NavigationMesh / NavigationPolygon baked 'cell_size' and navigation map 'cell_size'. If you're certain none of above is the case, change 'navigation/3d/merge_rasterizer_cell_scale' to 0.001. <Source C++> modules/navigation/nav_map.cpp:990 @ sync() ``` `cell_size` values are equal and changing `navigation/3d/merge_rasterizer_cell_scale` to 0.001 has no effect. Taking a closer look at the produced polygon, I can see this (I guess) problematic triangle : ![edgeerror](https://github.com/user-attachments/assets/94c9ec68-f64b-41ad-8db3-83204015033c) The thing is, when I open the same project in 4.2.1 and I rebake the navigation map, the produced polygon does not have this problematic triangle, and then I don't have the error. **Is it a regression ?** ### Steps to reproduce * Open MRP * Launch scene and look at output for the error ### Minimal reproduction project (MRP) MRP : [mrp_navmapsynchroerror.zip](https://github.com/user-attachments/files/16751112/mrp_navmapsynchroerror.zip)
topic:navigation
low
Critical
2,487,251,349
TypeScript
Wildcard/star export from type expression
### 🔍 Search Terms - `"export ="` - `"export type ="` - `flatten type export` - `export top-level type` - `wildcard export type` - `star export type` - `"export *"` - `"export type *"` ### ✅ Viability Checklist - [X] This wouldn't be a breaking change in existing TypeScript/JavaScript code - [X] This wouldn't change the runtime behavior of existing JavaScript code - [X] This could be implemented without emitting different JS based on the types of the expressions - [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.) - [X] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types - [X] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals ### ⭐ Suggestion Introduce syntax for exporting a "spread" type: ```ts // 1. This is based on ES export lists and spread tuple types. It would only be // valid for types, since modules have to be statically analyzable: export { ...ComplexType }; export type { ...ComplexType }; // 2. Not currently valid in normal type expressions, so might be // unexpected, even if it mirrors valid ES syntax. However, it might be // something to consider allowing independently, since it's not quite the // same as an intersection type, and would be useful for "overwriting" // properties: type Spread = { ...ComplexType }; // ^ Member 'Complex' implicitly has an 'any' type. (7008) // 3. These are probably too "generic" and easy to confuse with other export // syntax, and doesn't make the required "object" shape obvious: export ComplexType; // spread export type ComplexType; // spread export type Other = boolean; // NOT spread // 4. Barrel export syntax would be a bit more explicit, and mirrors their // respective import syntax nicely: import type * as ComplexType from "./a.ts"; export type * from ComplexType; // inverse of the import export type { Foo } from ComplexType; // also potentially nice to have // 5. An alternative based on CommonJS top-level export syntax, but probably // undesirable to use for ES modules: export = { Foo: "a", Bar: 1 }; // top-level value export type = ComplexType; // top-level ("spread") type ``` I'd personally prefer (4), but if extending spreading to object types is feasible, (1) would also be a natural choice. ### 📃 Motivating Example Not having "spreadable" type exports requires a lot of repetition in cases like this one, which this feature would alleviate significantly: ```tsx export type ComplexType = { Foo: string, Bar: number, }; // A. This is how it works right now. Every type name has to be repeated three // times each: export type Foo = ComplexType["Foo"]; export type Bar = ComplexType["Bar"]; export { Foo, Bar }; // B. This is what you could do instead: export type * from ComplexType; // (4) export type { ...ComplexType }; // (1) // C. You could even trivially allow mapped/filtered exports export type * from { [K in keyof ComplexType]: K extends 'Bar' ? never : ComplexType[K]; }; // (4) export type { [K in keyof ComplexType]: K extends 'Bar' ? never : ComplexType[K]; }; // (1) ``` ### 💻 Use Cases See [Motivating Example](#motivating-example)
Suggestion,Awaiting More Feedback
low
Minor
2,487,254,512
deno
DX: `deno test --coverage` doesn't show coverage
Running the `deno test --coverage` command generates coverage, but users still need to run a second command to show it. I feel like we should print the coverage result directly after the test summary like all other test runners.
feat
low
Minor
2,487,290,984
flutter
Tool with `--machine` emits `Downloading ...` before emitting JSON
`et` attempts to parse the output of the flutter tool, but when the tool logs that it is downloading dependencies, this parsing breaks. I suspect it would be trivial to add an error message in response to parsing failure suggesting that the user simply re-run `et`, as it succeeds on the second run once the flutter tool is finished building. ### Steps to reproduce 1. Delete `<flutter>/bin/cache/flutter_tools.stamp` 2. `cd` into the directory of any Flutter project 3. Run `et run` ### Expected results The engine builds and the Flutter project runs ### Actual results `et run` fails because it cannot parse the output logging from the Flutter tools updating. Re-running `et` after the failure completes, as the Flutter tools is now already built and up to date. ### Logs <details open><summary>Logs</summary> ```console [2024-08-26 12:35:50.925284] ERROR: Failed to parse flutter devices output: FormatException: Unexpected character (at character 1) Downloading package sky_engine... 388ms ^ Downloading package sky_engine... 388ms Downloading package flutter_gpu... 33ms Downloading flutter_patched_sdk tools... 126ms Downloading flutter_patched_sdk_product tools... 117ms Downloading darwin-arm64 tools... 762ms Downloading darwin-arm64/font-subset tools... 94ms [ { "name": "sdk gphone16k arm64", "id": "emulator-5554", "isSupported": true, "targetPlatform": "android-arm64", "emulator": true, "sdk": "Android 15 (API 35)", "capabilities": { "hotReload": true, "hotRestart": true, "screenshot": true, "fastStart": true, "flutterExit": true, "hardwareRendering": true, "startPaused": true } }, { "name": "macOS", "id": "macos", "isSupported": true, "targetPlatform": "darwin", "emulator": false, "sdk": "macOS 14.6.1 23G93 darwin-arm64", "capabilities": { "hotReload": true, "hotRestart": true, "screenshot": false, "fastStart": false, "flutterExit": true, "hardwareRendering": false, "startPaused": true } }, { "name": "Mac Designed for iPad", "id": "mac-designed-for-ipad", "isSupported": true, "targetPlatform": "darwin", "emulator": false, "sdk": "macOS 14.6.1 23G93 darwin-arm64", "capabilities": { "hotReload": true, "hotRestart": true, "screenshot": false, "fastStart": false, "flutterExit": true, "hardwareRendering": false, "startPaused": true } }, { "name": "Chrome", "id": "chrome", "isSupported": true, "targetPlatform": "web-javascript", "emulator": false, "sdk": "Google Chrome 127.0.6533.122", "capabilities": { "hotReload": true, "hotRestart": true, "screenshot": false, "fastStart": false, "flutterExit": false, "hardwareRendering": false, "startPaused": true } } ] ``` </details> ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console [!] Flutter (Channel master, 3.25.0-1.0.pre.133, on macOS 14.6.1 23G93 darwin-arm64, locale en) • Flutter version 3.25.0-1.0.pre.133 on channel master at /Users/schectman/src/flutter/flutter ! Upstream repository git@github.com:yaakovschectman/flutter.git is not a standard remote. Set environment variable "FLUTTER_GIT_URL" to git@github.com:yaakovschectman/flutter.git to dismiss this error. • Framework revision 6608936e6d (50 minutes ago), 2024-08-26 15:49:25 +0000 • Engine revision 365b0c70fa • Dart version 3.6.0 (build 3.6.0-175.0.dev) • DevTools version 2.39.0-dev.15 • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades. [✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0-rc4) • Android SDK at /Users/schectman/Library/Android/sdk • Platform android-35, build-tools 35.0.0-rc4 • ANDROID_HOME = /Users/schectman/Library/Android/sdk • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160) • All Android licenses accepted. [!] Xcode - develop for iOS and macOS (Xcode 15.3) • Xcode at /Applications/Xcode.app/Contents/Developer • Build 15E204a ! CocoaPods 1.12.1 out of date (1.13.0 is recommended). CocoaPods is a package manager for iOS or macOS platform code. Without CocoaPods, plugins will not work on iOS or macOS. For more info, see https://flutter.dev/to/platform-plugins To update CocoaPods, see https://guides.cocoapods.org/using/getting-started.html#updating-cocoapods [✓] Chrome - develop for the web • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [✓] Android Studio (version 2023.3) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160) [✓] VS Code (version 1.92.1) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension can be installed from: 🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter [✓] Connected device (4 available) • sdk gphone16k arm64 (mobile) • emulator-5554 • android-arm64 • Android 15 (API 35) (emulator) • macOS (desktop) • macos • darwin-arm64 • macOS 14.6.1 23G93 darwin-arm64 • Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin • macOS 14.6.1 23G93 darwin-arm64 • Chrome (web) • chrome • web-javascript • Google Chrome 127.0.6533.122 [✓] Network resources • All expected network resources are available. ! Doctor found issues in 2 categories. ``` </details>
tool,P3,team-tool,triaged-tool
low
Critical
2,487,305,674
transformers
Is it possible to add L1/L2 regularization using the trainer class ?
### Feature request I want to add L1/L2 regularization to the transformer training. ### Motivation Adding L1/L2 reg can promote sparser models that can accelerate inference and reduce storage. ### Your contribution Not sure.
Feature request
low
Minor
2,487,345,140
godot
Heavy stuttering whilst using Godot editor on a G Sync enabled monitor
### Tested versions 4.3 stable 4.3 dev ### System information Windows 11, Godot 4.3 stable, Vulkan Forward+ ### Issue description The editor stutters frequently whilst using the editor. It's most easily reproducible whilst highlighting text in the text editor disabling G Sync on the monitor resolves the issue. Monitor used is ROG SWIFT PG278QR - I have not been able to test on any other G Sync monitors, but I tested on another non G sync monitor and there was no issue ### Steps to reproduce Enable G Sync on monitor. Open Editor Highlight text in the text editor The PC will now stutter for a second or two. ### Minimal reproduction project (MRP) I have been able to reproduce this in any Godot project, including the small samples and empty projects
topic:rendering,topic:thirdparty,needs testing,performance
low
Major
2,487,346,505
godot
.godot/ is added to .gitignore, which can completely break various different resources and scenes, when reimporting project, due to the uid_cache.bin not being present in the git
### Tested versions -reproducable in all versions. ### System information Godot v4.4.dev1 - Windows 10.0.22631 - GLES3 (Compatibility) - NVIDIA GeForce RTX 3070 Ti (NVIDIA; 31.0.15.4592) - AMD Ryzen 7 5800X 8-Core Processor (16 Threads) ### Issue description basically, the .gitignore file that is autogenerated by both godot and github, automatically ignores the .godot folder, this makes sense, as there are lots of files which dont need ot be synchronise. HOWEVER, one of the files which gets ignored, is the uid_cache.bin file. Which I THINK is integral to various different importing processes. For example, if i reinport a project onto a new device, various resources, such as sprite frames missing textures for frames, or the entirety of tilesets just losing their textures. Whether this is due to the lack of uid_cache.bin file on the initial import is unknown to me, as sometimes it works fine, and sometimes not, its completely random. better documentation or transparency on how to migrate a project between different devices or how uid's affect resources would be heaviliy appriciated, as im working with a small team, who needs git to collaborate on various different files and resources. ### Steps to reproduce make a new .gitignore either through github and the Godot preset, or through the version control metadata on initial project and notice how .godot/ is added to the ignore, however uid_cache is present in .godot which to me is a incredibly important file. ### Minimal reproduction project (MRP) n/a
discussion,topic:editor,documentation,needs testing
low
Major
2,487,401,808
next.js
Cannot use local Next.js build as Next.js Dev Server (v14.2.6)
### Link to the code that reproduces this issue https://github.com/Ethan-Arrowood/next-dev-server-issue ### To Reproduce ## Reproduction > I'm running this on a Mac M3 Sonoma 14.6.1 1. Clone `vercel/next.js` 2. Check out tag `v14.2.6` with `git checkout tags/v14.2.6` 3. (Install deps and build Next.js locally) Run `pnpm i`, then `cd packages/next-swc`, `pnpm build-native`, and then `cd ../..` and `pnpm build` 4. Link it locally, `npm link` 1. Clone [this repo](https://github.com/Ethan-Arrowood/next-dev-server-issue) 2. Within `next-app`, run `npm i` - no need to link Next.js locally here 3. Within `next-server`, run `npm i` and `npm link next` 4. Run the server with `node server.js` (use Node v20) Visit `localhost:3000`, you'll see `Invariant: Expect to replace at least one import` in the console: ```sh testing/next-dev-server-issue/next-server via  v20.16.0 took 3s ❯ node server.js > Ready on http://localhost:3000 ○ Compiling / ... ⨯ app/page.js Invariant: Expected to replace at least one import ⨯ ../../../next.js/packages/next/dist/client/components/not-found-error.js Invariant: Expected to replace at least one import ⨯ ../../../next.js/packages/next/dist/build/webpack/loaders/next-route-loader/index.js?kind=PAGES&page=%2F_error&preferredRegion=&absolutePagePath=..%2F..%2F..%2Fnext.js%2Fpackages%2Fnext%2Fdist%2Fpages%2F_error.js&absoluteAppPath=next%2Fdist%2Fpages%2F_app&absoluteDocumentPath=next%2Fdist%2Fpages%2F_document&middlewareConfigBase64=e30%3D! Error: Invariant: Expected to replace at least one import GET / 500 in 2497ms ^C ``` Now if you just use the npm installed `next@14.2.6` dependency, everything works fine. But not being able to do this with a locally built version of Next.js is preventing me from debugging other things. This error is coming from here: https://github.com/vercel/next.js/blob/v14.2.6/packages/next/src/build/load-entrypoint.ts#L83 I used a debugger on the local Next.js build, and discovered that when `load-entrypoint.ts` is executing, the template file it receives contains `'` characters instead of the `"` the regex is expecting. This makes me think its something with how I'm building Next.js locally? See the following screenshot for more info: <img width="1399" alt="debug-screenshot" src="https://github.com/user-attachments/assets/40b8fca6-30dc-4ec6-86de-810ac3c2c691"> ### Current vs. Expected behavior I expect this to work locally just like when I use the Next.js dependency from `npm install`. ### Provide environment information ```bash Operating System: Platform: darwin Arch: arm64 Version: Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:30 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6030 Available memory (MB): 18432 Available CPU cores: 12 Binaries: Node: 20.16.0 npm: 10.8.1 Yarn: 1.22.22 pnpm: 9.7.0 Relevant Packages: next: 14.2.6 // Latest available version is detected (14.2.6). eslint-config-next: 14.2.6 react: 18.2.0 react-dom: 18.2.0 typescript: 5.2.2 Next.js Config: output: N/A ``` ### Which area(s) are affected? (Select all that apply) Developer Experience ### Which stage(s) are affected? (Select all that apply) next dev (local) ### Additional context 👋 Hi friends, hope all is well on the team. I had a feeling I'd be collaborating with y'all again 💙
bug
low
Critical
2,487,409,029
flutter
[camera] Camera example app doesn't explicitly dispose focusModeControlRowAnimationController in dispose
### What package does this bug report belong to? camera ### What target platforms are you seeing this bug on? Android ### Have you already upgraded your packages? Yes ### Dependency versions <details><summary>pubspec.lock</summary> ```lock # Generated by pub # See https://dart.dev/tools/pub/glossary#lockfile packages: _fe_analyzer_shared: dependency: transitive description: name: _fe_analyzer_shared sha256: f256b0c0ba6c7577c15e2e4e114755640a875e885099367bf6e012b19314c834 url: "https://pub.dev" source: hosted version: "72.0.0" _macros: dependency: transitive description: dart source: sdk version: "0.3.2" analyzer: dependency: transitive description: name: analyzer sha256: b652861553cd3990d8ed361f7979dc6d7053a9ac8843fa73820ab68ce5410139 url: "https://pub.dev" source: hosted version: "6.7.0" args: dependency: transitive description: name: args sha256: "7cf60b9f0cc88203c5a190b4cd62a99feea42759a7fa695010eb5de1c0b2252a" url: "https://pub.dev" source: hosted version: "2.5.0" async: dependency: transitive description: name: async sha256: "947bfcf187f74dbc5e146c9eb9c0f10c9f8b30743e341481c1e2ed3ecc18c20c" url: "https://pub.dev" source: hosted version: "2.11.0" boolean_selector: dependency: transitive description: name: boolean_selector sha256: "6cfb5af12253eaf2b368f07bacc5a80d1301a071c73360d746b7f2e32d762c66" url: "https://pub.dev" source: hosted version: "2.1.1" build: dependency: transitive description: name: build sha256: "80184af8b6cb3e5c1c4ec6d8544d27711700bc3e6d2efad04238c7b5290889f0" url: "https://pub.dev" source: hosted version: "2.4.1" build_config: dependency: transitive description: name: build_config sha256: bf80fcfb46a29945b423bd9aad884590fb1dc69b330a4d4700cac476af1708d1 url: "https://pub.dev" source: hosted version: "1.1.1" build_daemon: dependency: transitive description: name: build_daemon sha256: "79b2aef6ac2ed00046867ed354c88778c9c0f029df8a20fe10b5436826721ef9" url: "https://pub.dev" source: hosted version: "4.0.2" build_resolvers: dependency: transitive description: name: build_resolvers sha256: "339086358431fa15d7eca8b6a36e5d783728cf025e559b834f4609a1fcfb7b0a" url: "https://pub.dev" source: hosted version: "2.4.2" build_runner: dependency: "direct dev" description: name: build_runner sha256: dd09dd4e2b078992f42aac7f1a622f01882a8492fef08486b27ddde929c19f04 url: "https://pub.dev" source: hosted version: "2.4.12" build_runner_core: dependency: transitive description: name: build_runner_core sha256: f8126682b87a7282a339b871298cc12009cb67109cfa1614d6436fb0289193e0 url: "https://pub.dev" source: hosted version: "7.3.2" built_collection: dependency: transitive description: name: built_collection sha256: "376e3dd27b51ea877c28d525560790aee2e6fbb5f20e2f85d5081027d94e2100" url: "https://pub.dev" source: hosted version: "5.1.1" built_value: dependency: transitive description: name: built_value sha256: c7913a9737ee4007efedaffc968c049fd0f3d0e49109e778edc10de9426005cb url: "https://pub.dev" source: hosted version: "8.9.2" camera: dependency: "direct main" description: name: camera sha256: "26ff41045772153f222ffffecba711a206f670f5834d40ebf5eed3811692f167" url: "https://pub.dev" source: hosted version: "0.11.0+2" camera_android_camerax: dependency: transitive description: name: camera_android_camerax sha256: "7cd93578ad201dcc6bb5810451fb00d76a86bab9b68dceb68b8cbd7038ac5846" url: "https://pub.dev" source: hosted version: "0.6.8+3" camera_avfoundation: dependency: transitive description: name: camera_avfoundation sha256: "7c28969a975a7eb2349bc2cb2dfe3ad218a33dba9968ecfb181ce08c87486655" url: "https://pub.dev" source: hosted version: "0.9.17+3" camera_platform_interface: dependency: transitive description: name: camera_platform_interface sha256: b3ede1f171532e0d83111fe0980b46d17f1aa9788a07a2fbed07366bbdbb9061 url: "https://pub.dev" source: hosted version: "2.8.0" camera_web: dependency: "direct overridden" description: name: camera_web sha256: "595f28c89d1fb62d77c73c633193755b781c6d2e0ebcd8dc25b763b514e6ba8f" url: "https://pub.dev" source: hosted version: "0.3.5" characters: dependency: transitive description: name: characters sha256: "04a925763edad70e8443c99234dc3328f442e811f1d8fd1a72f1c8ad0f69a605" url: "https://pub.dev" source: hosted version: "1.3.0" checked_yaml: dependency: transitive description: name: checked_yaml sha256: feb6bed21949061731a7a75fc5d2aa727cf160b91af9a3e464c5e3a32e28b5ff url: "https://pub.dev" source: hosted version: "2.0.3" clock: dependency: transitive description: name: clock sha256: cb6d7f03e1de671e34607e909a7213e31d7752be4fb66a86d29fe1eb14bfb5cf url: "https://pub.dev" source: hosted version: "1.1.1" code_builder: dependency: transitive description: name: code_builder sha256: f692079e25e7869c14132d39f223f8eec9830eb76131925143b2129c4bb01b37 url: "https://pub.dev" source: hosted version: "4.10.0" collection: dependency: transitive description: name: collection sha256: ee67cb0715911d28db6bf4af1026078bd6f0128b07a5f66fb2ed94ec6783c09a url: "https://pub.dev" source: hosted version: "1.18.0" convert: dependency: transitive description: name: convert sha256: "0f08b14755d163f6e2134cb58222dd25ea2a2ee8a195e53983d57c075324d592" url: "https://pub.dev" source: hosted version: "3.1.1" cross_file: dependency: transitive description: name: cross_file sha256: "7caf6a750a0c04effbb52a676dce9a4a592e10ad35c34d6d2d0e4811160d5670" url: "https://pub.dev" source: hosted version: "0.3.4+2" crypto: dependency: transitive description: name: crypto sha256: ec30d999af904f33454ba22ed9a86162b35e52b44ac4807d1d93c288041d7d27 url: "https://pub.dev" source: hosted version: "3.0.5" csslib: dependency: transitive description: name: csslib sha256: "706b5707578e0c1b4b7550f64078f0a0f19dec3f50a178ffae7006b0a9ca58fb" url: "https://pub.dev" source: hosted version: "1.0.0" dart_style: dependency: transitive description: name: dart_style sha256: "99e066ce75c89d6b29903d788a7bb9369cf754f7b24bf70bf4b6d6d6b26853b9" url: "https://pub.dev" source: hosted version: "2.3.6" fake_async: dependency: transitive description: name: fake_async sha256: "511392330127add0b769b75a987850d136345d9227c6b94c96a04cf4a391bf78" url: "https://pub.dev" source: hosted version: "1.3.1" ffi: dependency: transitive description: name: ffi sha256: "16ed7b077ef01ad6170a3d0c57caa4a112a38d7a2ed5602e0aca9ca6f3d98da6" url: "https://pub.dev" source: hosted version: "2.1.3" file: dependency: transitive description: name: file sha256: "5fc22d7c25582e38ad9a8515372cd9a93834027aacf1801cf01164dac0ffa08c" url: "https://pub.dev" source: hosted version: "7.0.0" fixnum: dependency: transitive description: name: fixnum sha256: "25517a4deb0c03aa0f32fd12db525856438902d9c16536311e76cdc57b31d7d1" url: "https://pub.dev" source: hosted version: "1.1.0" flutter: dependency: "direct main" description: flutter source: sdk version: "0.0.0" flutter_driver: dependency: "direct dev" description: flutter source: sdk version: "0.0.0" flutter_plugin_android_lifecycle: dependency: transitive description: name: flutter_plugin_android_lifecycle sha256: "9ee02950848f61c4129af3d6ec84a1cfc0e47931abc746b03e7a3bc3e8ff6eda" url: "https://pub.dev" source: hosted version: "2.0.22" flutter_test: dependency: "direct dev" description: flutter source: sdk version: "0.0.0" flutter_web_plugins: dependency: transitive description: flutter source: sdk version: "0.0.0" frontend_server_client: dependency: transitive description: name: frontend_server_client sha256: f64a0333a82f30b0cca061bc3d143813a486dc086b574bfb233b7c1372427694 url: "https://pub.dev" source: hosted version: "4.0.0" fuchsia_remote_debug_protocol: dependency: transitive description: flutter source: sdk version: "0.0.0" glob: dependency: transitive description: name: glob sha256: "0e7014b3b7d4dac1ca4d6114f82bf1782ee86745b9b42a92c9289c23d8a0ab63" url: "https://pub.dev" source: hosted version: "2.1.2" graphs: dependency: transitive description: name: graphs sha256: "741bbf84165310a68ff28fe9e727332eef1407342fca52759cb21ad8177bb8d0" url: "https://pub.dev" source: hosted version: "2.3.2" html: dependency: transitive description: name: html sha256: "3a7812d5bcd2894edf53dfaf8cd640876cf6cef50a8f238745c8b8120ea74d3a" url: "https://pub.dev" source: hosted version: "0.15.4" http_multi_server: dependency: transitive description: name: http_multi_server sha256: "97486f20f9c2f7be8f514851703d0119c3596d14ea63227af6f7a481ef2b2f8b" url: "https://pub.dev" source: hosted version: "3.2.1" http_parser: dependency: transitive description: name: http_parser sha256: "2aa08ce0341cc9b354a498388e30986515406668dbcc4f7c950c3e715496693b" url: "https://pub.dev" source: hosted version: "4.0.2" integration_test: dependency: "direct dev" description: flutter source: sdk version: "0.0.0" io: dependency: transitive description: name: io sha256: "2ec25704aba361659e10e3e5f5d672068d332fc8ac516421d483a11e5cbd061e" url: "https://pub.dev" source: hosted version: "1.0.4" js: dependency: transitive description: name: js sha256: c1b2e9b5ea78c45e1a0788d29606ba27dc5f71f019f32ca5140f61ef071838cf url: "https://pub.dev" source: hosted version: "0.7.1" json_annotation: dependency: transitive description: name: json_annotation sha256: "1ce844379ca14835a50d2f019a3099f419082cfdd231cd86a142af94dd5c6bb1" url: "https://pub.dev" source: hosted version: "4.9.0" leak_tracker: dependency: transitive description: name: leak_tracker sha256: "3f87a60e8c63aecc975dda1ceedbc8f24de75f09e4856ea27daf8958f2f0ce05" url: "https://pub.dev" source: hosted version: "10.0.5" leak_tracker_flutter_testing: dependency: transitive description: name: leak_tracker_flutter_testing sha256: "932549fb305594d82d7183ecd9fa93463e9914e1b67cacc34bc40906594a1806" url: "https://pub.dev" source: hosted version: "3.0.5" leak_tracker_testing: dependency: transitive description: name: leak_tracker_testing sha256: "6ba465d5d76e67ddf503e1161d1f4a6bc42306f9d66ca1e8f079a47290fb06d3" url: "https://pub.dev" source: hosted version: "3.0.1" logging: dependency: transitive description: name: logging sha256: "623a88c9594aa774443aa3eb2d41807a48486b5613e67599fb4c41c0ad47c340" url: "https://pub.dev" source: hosted version: "1.2.0" macros: dependency: transitive description: name: macros sha256: "0acaed5d6b7eab89f63350bccd82119e6c602df0f391260d0e32b5e23db79536" url: "https://pub.dev" source: hosted version: "0.1.2-main.4" matcher: dependency: transitive description: name: matcher sha256: d2323aa2060500f906aa31a895b4030b6da3ebdcc5619d14ce1aada65cd161cb url: "https://pub.dev" source: hosted version: "0.12.16+1" material_color_utilities: dependency: transitive description: name: material_color_utilities sha256: f7142bb1154231d7ea5f96bc7bde4bda2a0945d2806bb11670e30b850d56bdec url: "https://pub.dev" source: hosted version: "0.11.1" meta: dependency: transitive description: name: meta sha256: bdb68674043280c3428e9ec998512fb681678676b3c54e773629ffe74419f8c7 url: "https://pub.dev" source: hosted version: "1.15.0" mime: dependency: transitive description: name: mime sha256: "801fd0b26f14a4a58ccb09d5892c3fbdeff209594300a542492cf13fba9d247a" url: "https://pub.dev" source: hosted version: "1.0.6" package_config: dependency: transitive description: name: package_config sha256: "1c5b77ccc91e4823a5af61ee74e6b972db1ef98c2ff5a18d3161c982a55448bd" url: "https://pub.dev" source: hosted version: "2.1.0" path: dependency: transitive description: name: path sha256: "087ce49c3f0dc39180befefc60fdb4acd8f8620e5682fe2476afd0b3688bb4af" url: "https://pub.dev" source: hosted version: "1.9.0" path_provider: dependency: "direct main" description: name: path_provider sha256: fec0d61223fba3154d87759e3cc27fe2c8dc498f6386c6d6fc80d1afdd1bf378 url: "https://pub.dev" source: hosted version: "2.1.4" path_provider_android: dependency: transitive description: name: path_provider_android sha256: "6f01f8e37ec30b07bc424b4deabac37cacb1bc7e2e515ad74486039918a37eb7" url: "https://pub.dev" source: hosted version: "2.2.10" path_provider_foundation: dependency: transitive description: name: path_provider_foundation sha256: f234384a3fdd67f989b4d54a5d73ca2a6c422fa55ae694381ae0f4375cd1ea16 url: "https://pub.dev" source: hosted version: "2.4.0" path_provider_linux: dependency: transitive description: name: path_provider_linux sha256: f7a1fe3a634fe7734c8d3f2766ad746ae2a2884abe22e241a8b301bf5cac3279 url: "https://pub.dev" source: hosted version: "2.2.1" path_provider_platform_interface: dependency: transitive description: name: path_provider_platform_interface sha256: "88f5779f72ba699763fa3a3b06aa4bf6de76c8e5de842cf6f29e2e06476c2334" url: "https://pub.dev" source: hosted version: "2.1.2" path_provider_windows: dependency: transitive description: name: path_provider_windows sha256: bd6f00dbd873bfb70d0761682da2b3a2c2fccc2b9e84c495821639601d81afe7 url: "https://pub.dev" source: hosted version: "2.3.0" platform: dependency: transitive description: name: platform sha256: "9b71283fc13df574056616011fb138fd3b793ea47cc509c189a6c3fa5f8a1a65" url: "https://pub.dev" source: hosted version: "3.1.5" plugin_platform_interface: dependency: transitive description: name: plugin_platform_interface sha256: "4820fbfdb9478b1ebae27888254d445073732dae3d6ea81f0b7e06d5dedc3f02" url: "https://pub.dev" source: hosted version: "2.1.8" pool: dependency: transitive description: name: pool sha256: "20fe868b6314b322ea036ba325e6fc0711a22948856475e2c2b6306e8ab39c2a" url: "https://pub.dev" source: hosted version: "1.5.1" process: dependency: transitive description: name: process sha256: "21e54fd2faf1b5bdd5102afd25012184a6793927648ea81eea80552ac9405b32" url: "https://pub.dev" source: hosted version: "5.0.2" pub_semver: dependency: transitive description: name: pub_semver sha256: "40d3ab1bbd474c4c2328c91e3a7df8c6dd629b79ece4c4bd04bee496a224fb0c" url: "https://pub.dev" source: hosted version: "2.1.4" pubspec_parse: dependency: transitive description: name: pubspec_parse sha256: c799b721d79eb6ee6fa56f00c04b472dcd44a30d258fac2174a6ec57302678f8 url: "https://pub.dev" source: hosted version: "1.3.0" shelf: dependency: transitive description: name: shelf sha256: ad29c505aee705f41a4d8963641f91ac4cee3c8fad5947e033390a7bd8180fa4 url: "https://pub.dev" source: hosted version: "1.4.1" shelf_web_socket: dependency: transitive description: name: shelf_web_socket sha256: "073c147238594ecd0d193f3456a5fe91c4b0abbcc68bf5cd95b36c4e194ac611" url: "https://pub.dev" source: hosted version: "2.0.0" sky_engine: dependency: transitive description: flutter source: sdk version: "0.0.99" source_span: dependency: transitive description: name: source_span sha256: "53e943d4206a5e30df338fd4c6e7a077e02254531b138a15aec3bd143c1a8b3c" url: "https://pub.dev" source: hosted version: "1.10.0" stack_trace: dependency: transitive description: name: stack_trace sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" url: "https://pub.dev" source: hosted version: "1.11.1" stream_channel: dependency: transitive description: name: stream_channel sha256: ba2aa5d8cc609d96bbb2899c28934f9e1af5cddbd60a827822ea467161eb54e7 url: "https://pub.dev" source: hosted version: "2.1.2" stream_transform: dependency: transitive description: name: stream_transform sha256: "14a00e794c7c11aa145a170587321aedce29769c08d7f58b1d141da75e3b1c6f" url: "https://pub.dev" source: hosted version: "2.1.0" string_scanner: dependency: transitive description: name: string_scanner sha256: "556692adab6cfa87322a115640c11f13cb77b3f076ddcc5d6ae3c20242bedcde" url: "https://pub.dev" source: hosted version: "1.2.0" sync_http: dependency: transitive description: name: sync_http sha256: "7f0cd72eca000d2e026bcd6f990b81d0ca06022ef4e32fb257b30d3d1014a961" url: "https://pub.dev" source: hosted version: "0.3.1" term_glyph: dependency: transitive description: name: term_glyph sha256: a29248a84fbb7c79282b40b8c72a1209db169a2e0542bce341da992fe1bc7e84 url: "https://pub.dev" source: hosted version: "1.2.1" test_api: dependency: transitive description: name: test_api sha256: "5b8a98dafc4d5c4c9c72d8b31ab2b23fc13422348d2997120294d3bac86b4ddb" url: "https://pub.dev" source: hosted version: "0.7.2" timing: dependency: transitive description: name: timing sha256: "70a3b636575d4163c477e6de42f247a23b315ae20e86442bebe32d3cabf61c32" url: "https://pub.dev" source: hosted version: "1.0.1" typed_data: dependency: transitive description: name: typed_data sha256: facc8d6582f16042dd49f2463ff1bd6e2c9ef9f3d5da3d9b087e244a7b564b3c url: "https://pub.dev" source: hosted version: "1.3.2" vector_math: dependency: transitive description: name: vector_math sha256: "80b3257d1492ce4d091729e3a67a60407d227c27241d6927be0130c98e741803" url: "https://pub.dev" source: hosted version: "2.1.4" video_player: dependency: "direct main" description: name: video_player sha256: e30df0d226c4ef82e2c150ebf6834b3522cf3f654d8e2f9419d376cdc071425d url: "https://pub.dev" source: hosted version: "2.9.1" video_player_android: dependency: transitive description: name: video_player_android sha256: "101028b643a3b43ced72107aacdbc4d30d55365487751de001a36cf0d86038d1" url: "https://pub.dev" source: hosted version: "2.7.2" video_player_avfoundation: dependency: transitive description: name: video_player_avfoundation sha256: d1e9a824f2b324000dc8fb2dcb2a3285b6c1c7c487521c63306cc5b394f68a7c url: "https://pub.dev" source: hosted version: "2.6.1" video_player_platform_interface: dependency: transitive description: name: video_player_platform_interface sha256: "236454725fafcacf98f0f39af0d7c7ab2ce84762e3b63f2cbb3ef9a7e0550bc6" url: "https://pub.dev" source: hosted version: "6.2.2" video_player_web: dependency: transitive description: name: video_player_web sha256: "6dcdd298136523eaf7dfc31abaf0dfba9aa8a8dbc96670e87e9d42b6f2caf774" url: "https://pub.dev" source: hosted version: "2.3.2" vm_service: dependency: transitive description: name: vm_service sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" url: "https://pub.dev" source: hosted version: "14.2.5" watcher: dependency: transitive description: name: watcher sha256: "3d2ad6751b3c16cf07c7fca317a1413b3f26530319181b37e3b9039b84fc01d8" url: "https://pub.dev" source: hosted version: "1.1.0" web: dependency: transitive description: name: web sha256: d43c1d6b787bf0afad444700ae7f4db8827f701bc61c255ac8d328c6f4d52062 url: "https://pub.dev" source: hosted version: "1.0.0" web_socket: dependency: transitive description: name: web_socket sha256: "3c12d96c0c9a4eec095246debcea7b86c0324f22df69893d538fcc6f1b8cce83" url: "https://pub.dev" source: hosted version: "0.1.6" web_socket_channel: dependency: transitive description: name: web_socket_channel sha256: "9f187088ed104edd8662ca07af4b124465893caf063ba29758f97af57e61da8f" url: "https://pub.dev" source: hosted version: "3.0.1" webdriver: dependency: transitive description: name: webdriver sha256: "003d7da9519e1e5f329422b36c4dcdf18d7d2978d1ba099ea4e45ba490ed845e" url: "https://pub.dev" source: hosted version: "3.0.3" xdg_directories: dependency: transitive description: name: xdg_directories sha256: faea9dee56b520b55a566385b84f2e8de55e7496104adada9962e0bd11bcff1d url: "https://pub.dev" source: hosted version: "1.0.4" yaml: dependency: transitive description: name: yaml sha256: "75769501ea3489fca56601ff33454fe45507ea3bfb014161abc3b43ae25989d5" url: "https://pub.dev" source: hosted version: "3.1.2" sdks: dart: ">=3.5.0 <4.0.0" flutter: ">=3.24.0" ``` </details> ### Steps to reproduce 1. Look up the Camera Example app's `initState` method https://github.com/flutter/packages/blob/b9715b7eac7d97428c4acde94a75dad5a7525668/packages/camera/camera/example/lib/main.dart#L72 and notice how all three row animation controllers (`flashMode`, `exposureMode`, `focusMode`) are initialized. 2. Look up the Camera Example app's `dispose` method https://github.com/flutter/packages/blob/b9715b7eac7d97428c4acde94a75dad5a7525668/packages/camera/camera/example/lib/main.dart#L103 and notice that the `focusMode` row animation controller is not disposed. ### Expected results To keep the initialization / disposal symmetry the `focusMode` row animation controller would be disposed just like the other two row animation controllers. ### Actual results The `focusMode` row animation controller is not getting disposed at dispose like the other two row animation controllers. ### Code sample <details open><summary>Code sample</summary> ```dart @override void initState() { super.initState(); WidgetsBinding.instance.addObserver(this); _flashModeControlRowAnimationController = AnimationController( duration: const Duration(milliseconds: 300), vsync: this, ); _flashModeControlRowAnimation = CurvedAnimation( parent: _flashModeControlRowAnimationController, curve: Curves.easeInCubic, ); _exposureModeControlRowAnimationController = AnimationController( duration: const Duration(milliseconds: 300), vsync: this, ); _exposureModeControlRowAnimation = CurvedAnimation( parent: _exposureModeControlRowAnimationController, curve: Curves.easeInCubic, ); _focusModeControlRowAnimationController = AnimationController( duration: const Duration(milliseconds: 300), vsync: this, ); _focusModeControlRowAnimation = CurvedAnimation( parent: _focusModeControlRowAnimationController, curve: Curves.easeInCubic, ); } @override void dispose() { WidgetsBinding.instance.removeObserver(this); _flashModeControlRowAnimationController.dispose(); _exposureModeControlRowAnimationController.dispose(); super.dispose(); } ``` </details> ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console [✓] Flutter (Channel stable, 3.24.1, on Devuan GNU/Linux 6 (excalibur/ceres) 6.10.4-amd64, locale en_US.UTF-8) [✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0) [✓] Android Studio (version 2024.1) [✓] VS Code (version 1.92.2) [✓] Connected device (1 available) [✓] Network resources • No issues found! ``` </details>
d: examples,p: camera,package,team-ecosystem,P3,triaged-ecosystem
low
Critical
2,487,412,972
pytorch
DISABLED test_dynamic_toggle (__main__.TestProfiler)
Platforms: windows, rocm This test was disabled because it is failing on main branch ([recent examples](https://torch-ci.com/failure?failureCaptures=%5B%22profiler%5C%5Ctest_profiler.py%3A%3ATestProfiler%3A%3Atest_dynamic_toggle%22%5D)). cc @robieta @chaekit @aaronenyeshi @guotuofeng @guyang3532 @dzhulgakov @davidberard98 @briancoutinho @sraikund16 @sanrise @ezyang @chauhang @penguinwu
triaged,skipped,oncall: profiler
low
Critical