id int64 393k 2.82B | repo stringclasses 68
values | title stringlengths 1 936 | body stringlengths 0 256k ⌀ | labels stringlengths 2 508 | priority stringclasses 3
values | severity stringclasses 3
values |
|---|---|---|---|---|---|---|
2,487,517,725 | terminal | Add an option to split font ligatures based on color change | <!--
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
# Description of the new feature/enhancement
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
I would like a feature to split font ligatures whenever there is a color change between the characters that make up a ligature. WezTerm does this as shown below.
Windows
<img width="176" alt="image" src="https://github.com/user-attachments/assets/91b9a4d1-b42c-4d2d-98b3-9a7d2ba37279">
Wezterm
<img width="173" alt="image" src="https://github.com/user-attachments/assets/dbb751eb-b8de-4a81-b139-a187776a4f21">
Both are using JetBrains Mono Nerd Font.
Not sure if there is a feature request already for this.
# Proposed technical implementation details (optional)
<!--
A clear and concise description of what you want to happen.
-->
Ideally it would be on by default but a toggle option may be preferred. | Area-Rendering,Product-Terminal,Issue-Task | low | Critical |
2,487,528,099 | angular | Canonical: consequences of macrotask scheduling | Angular uses a macrotask-based scheduler for its synchronization process, including change detection, render hooks, etc. This means that perturbations of component state which occur in one task (e.g. `click` event handler) will not fully resolve until the scheduled macrotask (usually `setTimeout(0)` but sometimes `requestAnimationFrame`). This has a number of positive consequences, such as batching updates from multiple sequenced events (bubbled events, `mousedown` / `mouseup` pairs, etc).
However, it is not without downsides / consequences, which this issue aims to capture:
## APIs which require user interaction
[Certain browser APIs](https://developer.mozilla.org/en-US/docs/Web/Security/User_activation) must be called from a user interaction context. Usually this means either as the direct result of a user interaction (synchronously in the event handler) or in a microtask which resolves in the event handler.
Deferring synchronization to a new macrotask breaks the connection to the original interaction event, meaning that these APIs cannot be used from contexts like component lifecycle hooks, input setters, effects, etc.
## Task separation impacts scrolling behavior
Certain rendering operations highlight an interesting edge case. For example, if a view is removed from a view container and replaced with another during the initial event (e.g. `click`), the view will not be fully rendered until the synchronization task (especially the creation of child embedded views from `@if`, `@for`, etc).
Although the user will not see the intermediate state (Angular's scheduler guarantees the page will fully render before painting), it turns out that when elements are removed and the page layout changes, browsers recalculate the scrolling position immediately following that task. This means that browsers will update the scrolling position between the initial task and the synchronization task, based on the half-rendered layout of the page. This can lead to unexpected or sub-optimal scrolling behavior.
* #57460 | area: core,core: change detection,canonical | low | Minor |
2,487,533,912 | godot | Editor Icon Saturation not applied to Custom Editor Icons | ### Tested versions
-Reproducible in Godot 4.3
### System information
Windows 11, Godot 4.3-stable
### Issue description
The editor theme icon saturation (`"interface/theme/icon_saturation"`) is only applied to built-in icons, not custom icons set using `@icon("res://...")`.
You can see it on the `ButtonContainer` icons here, notice they're not as saturated as the other Container icons.
I based these icons off of the built-in ones and they have the exact same color values.
My Editor saturation is set to 1.8 (because it's pretty ✨) and the difference is pretty apparent.
### Steps to reproduce
Open the MRP, set your Editor Icon Saturation to 2.
The icons should look like this:
CustomAnimationPlayer uses the same icon as AnimationPlayer, taken from the godot repo.
It's not saturated correctly, as it's a custom icon.
### Minimal reproduction project (MRP)
[icon-saturation-mrp.zip](https://github.com/user-attachments/files/16752513/icon-saturation-mrp.zip)
| bug,topic:editor | low | Minor |
2,487,542,682 | flutter | [camera] Camera Example app's setExposureOffset is not robust | ### What package does this bug report belong to?
camera
### What target platforms are you seeing this bug on?
Android
### Have you already upgraded your packages?
Yes
### Dependency versions
<details><summary>pubspec.lock</summary>
```lock
# Generated by pub
# See https://dart.dev/tools/pub/glossary#lockfile
packages:
_fe_analyzer_shared:
dependency: transitive
description:
name: _fe_analyzer_shared
sha256: f256b0c0ba6c7577c15e2e4e114755640a875e885099367bf6e012b19314c834
url: "https://pub.dev"
source: hosted
version: "72.0.0"
_macros:
dependency: transitive
description: dart
source: sdk
version: "0.3.2"
analyzer:
dependency: transitive
description:
name: analyzer
sha256: b652861553cd3990d8ed361f7979dc6d7053a9ac8843fa73820ab68ce5410139
url: "https://pub.dev"
source: hosted
version: "6.7.0"
args:
dependency: transitive
description:
name: args
sha256: "7cf60b9f0cc88203c5a190b4cd62a99feea42759a7fa695010eb5de1c0b2252a"
url: "https://pub.dev"
source: hosted
version: "2.5.0"
async:
dependency: transitive
description:
name: async
sha256: "947bfcf187f74dbc5e146c9eb9c0f10c9f8b30743e341481c1e2ed3ecc18c20c"
url: "https://pub.dev"
source: hosted
version: "2.11.0"
boolean_selector:
dependency: transitive
description:
name: boolean_selector
sha256: "6cfb5af12253eaf2b368f07bacc5a80d1301a071c73360d746b7f2e32d762c66"
url: "https://pub.dev"
source: hosted
version: "2.1.1"
build:
dependency: transitive
description:
name: build
sha256: "80184af8b6cb3e5c1c4ec6d8544d27711700bc3e6d2efad04238c7b5290889f0"
url: "https://pub.dev"
source: hosted
version: "2.4.1"
build_config:
dependency: transitive
description:
name: build_config
sha256: bf80fcfb46a29945b423bd9aad884590fb1dc69b330a4d4700cac476af1708d1
url: "https://pub.dev"
source: hosted
version: "1.1.1"
build_daemon:
dependency: transitive
description:
name: build_daemon
sha256: "79b2aef6ac2ed00046867ed354c88778c9c0f029df8a20fe10b5436826721ef9"
url: "https://pub.dev"
source: hosted
version: "4.0.2"
build_resolvers:
dependency: transitive
description:
name: build_resolvers
sha256: "339086358431fa15d7eca8b6a36e5d783728cf025e559b834f4609a1fcfb7b0a"
url: "https://pub.dev"
source: hosted
version: "2.4.2"
build_runner:
dependency: "direct dev"
description:
name: build_runner
sha256: dd09dd4e2b078992f42aac7f1a622f01882a8492fef08486b27ddde929c19f04
url: "https://pub.dev"
source: hosted
version: "2.4.12"
build_runner_core:
dependency: transitive
description:
name: build_runner_core
sha256: f8126682b87a7282a339b871298cc12009cb67109cfa1614d6436fb0289193e0
url: "https://pub.dev"
source: hosted
version: "7.3.2"
built_collection:
dependency: transitive
description:
name: built_collection
sha256: "376e3dd27b51ea877c28d525560790aee2e6fbb5f20e2f85d5081027d94e2100"
url: "https://pub.dev"
source: hosted
version: "5.1.1"
built_value:
dependency: transitive
description:
name: built_value
sha256: c7913a9737ee4007efedaffc968c049fd0f3d0e49109e778edc10de9426005cb
url: "https://pub.dev"
source: hosted
version: "8.9.2"
camera:
dependency: "direct main"
description:
name: camera
sha256: "26ff41045772153f222ffffecba711a206f670f5834d40ebf5eed3811692f167"
url: "https://pub.dev"
source: hosted
version: "0.11.0+2"
camera_android_camerax:
dependency: transitive
description:
name: camera_android_camerax
sha256: "7cd93578ad201dcc6bb5810451fb00d76a86bab9b68dceb68b8cbd7038ac5846"
url: "https://pub.dev"
source: hosted
version: "0.6.8+3"
camera_avfoundation:
dependency: transitive
description:
name: camera_avfoundation
sha256: "7c28969a975a7eb2349bc2cb2dfe3ad218a33dba9968ecfb181ce08c87486655"
url: "https://pub.dev"
source: hosted
version: "0.9.17+3"
camera_platform_interface:
dependency: transitive
description:
name: camera_platform_interface
sha256: b3ede1f171532e0d83111fe0980b46d17f1aa9788a07a2fbed07366bbdbb9061
url: "https://pub.dev"
source: hosted
version: "2.8.0"
camera_web:
dependency: "direct overridden"
description:
name: camera_web
sha256: "595f28c89d1fb62d77c73c633193755b781c6d2e0ebcd8dc25b763b514e6ba8f"
url: "https://pub.dev"
source: hosted
version: "0.3.5"
characters:
dependency: transitive
description:
name: characters
sha256: "04a925763edad70e8443c99234dc3328f442e811f1d8fd1a72f1c8ad0f69a605"
url: "https://pub.dev"
source: hosted
version: "1.3.0"
checked_yaml:
dependency: transitive
description:
name: checked_yaml
sha256: feb6bed21949061731a7a75fc5d2aa727cf160b91af9a3e464c5e3a32e28b5ff
url: "https://pub.dev"
source: hosted
version: "2.0.3"
clock:
dependency: transitive
description:
name: clock
sha256: cb6d7f03e1de671e34607e909a7213e31d7752be4fb66a86d29fe1eb14bfb5cf
url: "https://pub.dev"
source: hosted
version: "1.1.1"
code_builder:
dependency: transitive
description:
name: code_builder
sha256: f692079e25e7869c14132d39f223f8eec9830eb76131925143b2129c4bb01b37
url: "https://pub.dev"
source: hosted
version: "4.10.0"
collection:
dependency: transitive
description:
name: collection
sha256: ee67cb0715911d28db6bf4af1026078bd6f0128b07a5f66fb2ed94ec6783c09a
url: "https://pub.dev"
source: hosted
version: "1.18.0"
convert:
dependency: transitive
description:
name: convert
sha256: "0f08b14755d163f6e2134cb58222dd25ea2a2ee8a195e53983d57c075324d592"
url: "https://pub.dev"
source: hosted
version: "3.1.1"
cross_file:
dependency: transitive
description:
name: cross_file
sha256: "7caf6a750a0c04effbb52a676dce9a4a592e10ad35c34d6d2d0e4811160d5670"
url: "https://pub.dev"
source: hosted
version: "0.3.4+2"
crypto:
dependency: transitive
description:
name: crypto
sha256: ec30d999af904f33454ba22ed9a86162b35e52b44ac4807d1d93c288041d7d27
url: "https://pub.dev"
source: hosted
version: "3.0.5"
csslib:
dependency: transitive
description:
name: csslib
sha256: "706b5707578e0c1b4b7550f64078f0a0f19dec3f50a178ffae7006b0a9ca58fb"
url: "https://pub.dev"
source: hosted
version: "1.0.0"
dart_style:
dependency: transitive
description:
name: dart_style
sha256: "99e066ce75c89d6b29903d788a7bb9369cf754f7b24bf70bf4b6d6d6b26853b9"
url: "https://pub.dev"
source: hosted
version: "2.3.6"
fake_async:
dependency: transitive
description:
name: fake_async
sha256: "511392330127add0b769b75a987850d136345d9227c6b94c96a04cf4a391bf78"
url: "https://pub.dev"
source: hosted
version: "1.3.1"
ffi:
dependency: transitive
description:
name: ffi
sha256: "16ed7b077ef01ad6170a3d0c57caa4a112a38d7a2ed5602e0aca9ca6f3d98da6"
url: "https://pub.dev"
source: hosted
version: "2.1.3"
file:
dependency: transitive
description:
name: file
sha256: "5fc22d7c25582e38ad9a8515372cd9a93834027aacf1801cf01164dac0ffa08c"
url: "https://pub.dev"
source: hosted
version: "7.0.0"
fixnum:
dependency: transitive
description:
name: fixnum
sha256: "25517a4deb0c03aa0f32fd12db525856438902d9c16536311e76cdc57b31d7d1"
url: "https://pub.dev"
source: hosted
version: "1.1.0"
flutter:
dependency: "direct main"
description: flutter
source: sdk
version: "0.0.0"
flutter_driver:
dependency: "direct dev"
description: flutter
source: sdk
version: "0.0.0"
flutter_plugin_android_lifecycle:
dependency: transitive
description:
name: flutter_plugin_android_lifecycle
sha256: "9ee02950848f61c4129af3d6ec84a1cfc0e47931abc746b03e7a3bc3e8ff6eda"
url: "https://pub.dev"
source: hosted
version: "2.0.22"
flutter_test:
dependency: "direct dev"
description: flutter
source: sdk
version: "0.0.0"
flutter_web_plugins:
dependency: transitive
description: flutter
source: sdk
version: "0.0.0"
frontend_server_client:
dependency: transitive
description:
name: frontend_server_client
sha256: f64a0333a82f30b0cca061bc3d143813a486dc086b574bfb233b7c1372427694
url: "https://pub.dev"
source: hosted
version: "4.0.0"
fuchsia_remote_debug_protocol:
dependency: transitive
description: flutter
source: sdk
version: "0.0.0"
glob:
dependency: transitive
description:
name: glob
sha256: "0e7014b3b7d4dac1ca4d6114f82bf1782ee86745b9b42a92c9289c23d8a0ab63"
url: "https://pub.dev"
source: hosted
version: "2.1.2"
graphs:
dependency: transitive
description:
name: graphs
sha256: "741bbf84165310a68ff28fe9e727332eef1407342fca52759cb21ad8177bb8d0"
url: "https://pub.dev"
source: hosted
version: "2.3.2"
html:
dependency: transitive
description:
name: html
sha256: "3a7812d5bcd2894edf53dfaf8cd640876cf6cef50a8f238745c8b8120ea74d3a"
url: "https://pub.dev"
source: hosted
version: "0.15.4"
http_multi_server:
dependency: transitive
description:
name: http_multi_server
sha256: "97486f20f9c2f7be8f514851703d0119c3596d14ea63227af6f7a481ef2b2f8b"
url: "https://pub.dev"
source: hosted
version: "3.2.1"
http_parser:
dependency: transitive
description:
name: http_parser
sha256: "2aa08ce0341cc9b354a498388e30986515406668dbcc4f7c950c3e715496693b"
url: "https://pub.dev"
source: hosted
version: "4.0.2"
integration_test:
dependency: "direct dev"
description: flutter
source: sdk
version: "0.0.0"
io:
dependency: transitive
description:
name: io
sha256: "2ec25704aba361659e10e3e5f5d672068d332fc8ac516421d483a11e5cbd061e"
url: "https://pub.dev"
source: hosted
version: "1.0.4"
js:
dependency: transitive
description:
name: js
sha256: c1b2e9b5ea78c45e1a0788d29606ba27dc5f71f019f32ca5140f61ef071838cf
url: "https://pub.dev"
source: hosted
version: "0.7.1"
json_annotation:
dependency: transitive
description:
name: json_annotation
sha256: "1ce844379ca14835a50d2f019a3099f419082cfdd231cd86a142af94dd5c6bb1"
url: "https://pub.dev"
source: hosted
version: "4.9.0"
leak_tracker:
dependency: transitive
description:
name: leak_tracker
sha256: "3f87a60e8c63aecc975dda1ceedbc8f24de75f09e4856ea27daf8958f2f0ce05"
url: "https://pub.dev"
source: hosted
version: "10.0.5"
leak_tracker_flutter_testing:
dependency: transitive
description:
name: leak_tracker_flutter_testing
sha256: "932549fb305594d82d7183ecd9fa93463e9914e1b67cacc34bc40906594a1806"
url: "https://pub.dev"
source: hosted
version: "3.0.5"
leak_tracker_testing:
dependency: transitive
description:
name: leak_tracker_testing
sha256: "6ba465d5d76e67ddf503e1161d1f4a6bc42306f9d66ca1e8f079a47290fb06d3"
url: "https://pub.dev"
source: hosted
version: "3.0.1"
logging:
dependency: transitive
description:
name: logging
sha256: "623a88c9594aa774443aa3eb2d41807a48486b5613e67599fb4c41c0ad47c340"
url: "https://pub.dev"
source: hosted
version: "1.2.0"
macros:
dependency: transitive
description:
name: macros
sha256: "0acaed5d6b7eab89f63350bccd82119e6c602df0f391260d0e32b5e23db79536"
url: "https://pub.dev"
source: hosted
version: "0.1.2-main.4"
matcher:
dependency: transitive
description:
name: matcher
sha256: d2323aa2060500f906aa31a895b4030b6da3ebdcc5619d14ce1aada65cd161cb
url: "https://pub.dev"
source: hosted
version: "0.12.16+1"
material_color_utilities:
dependency: transitive
description:
name: material_color_utilities
sha256: f7142bb1154231d7ea5f96bc7bde4bda2a0945d2806bb11670e30b850d56bdec
url: "https://pub.dev"
source: hosted
version: "0.11.1"
meta:
dependency: transitive
description:
name: meta
sha256: bdb68674043280c3428e9ec998512fb681678676b3c54e773629ffe74419f8c7
url: "https://pub.dev"
source: hosted
version: "1.15.0"
mime:
dependency: transitive
description:
name: mime
sha256: "801fd0b26f14a4a58ccb09d5892c3fbdeff209594300a542492cf13fba9d247a"
url: "https://pub.dev"
source: hosted
version: "1.0.6"
package_config:
dependency: transitive
description:
name: package_config
sha256: "1c5b77ccc91e4823a5af61ee74e6b972db1ef98c2ff5a18d3161c982a55448bd"
url: "https://pub.dev"
source: hosted
version: "2.1.0"
path:
dependency: transitive
description:
name: path
sha256: "087ce49c3f0dc39180befefc60fdb4acd8f8620e5682fe2476afd0b3688bb4af"
url: "https://pub.dev"
source: hosted
version: "1.9.0"
path_provider:
dependency: "direct main"
description:
name: path_provider
sha256: fec0d61223fba3154d87759e3cc27fe2c8dc498f6386c6d6fc80d1afdd1bf378
url: "https://pub.dev"
source: hosted
version: "2.1.4"
path_provider_android:
dependency: transitive
description:
name: path_provider_android
sha256: "6f01f8e37ec30b07bc424b4deabac37cacb1bc7e2e515ad74486039918a37eb7"
url: "https://pub.dev"
source: hosted
version: "2.2.10"
path_provider_foundation:
dependency: transitive
description:
name: path_provider_foundation
sha256: f234384a3fdd67f989b4d54a5d73ca2a6c422fa55ae694381ae0f4375cd1ea16
url: "https://pub.dev"
source: hosted
version: "2.4.0"
path_provider_linux:
dependency: transitive
description:
name: path_provider_linux
sha256: f7a1fe3a634fe7734c8d3f2766ad746ae2a2884abe22e241a8b301bf5cac3279
url: "https://pub.dev"
source: hosted
version: "2.2.1"
path_provider_platform_interface:
dependency: transitive
description:
name: path_provider_platform_interface
sha256: "88f5779f72ba699763fa3a3b06aa4bf6de76c8e5de842cf6f29e2e06476c2334"
url: "https://pub.dev"
source: hosted
version: "2.1.2"
path_provider_windows:
dependency: transitive
description:
name: path_provider_windows
sha256: bd6f00dbd873bfb70d0761682da2b3a2c2fccc2b9e84c495821639601d81afe7
url: "https://pub.dev"
source: hosted
version: "2.3.0"
platform:
dependency: transitive
description:
name: platform
sha256: "9b71283fc13df574056616011fb138fd3b793ea47cc509c189a6c3fa5f8a1a65"
url: "https://pub.dev"
source: hosted
version: "3.1.5"
plugin_platform_interface:
dependency: transitive
description:
name: plugin_platform_interface
sha256: "4820fbfdb9478b1ebae27888254d445073732dae3d6ea81f0b7e06d5dedc3f02"
url: "https://pub.dev"
source: hosted
version: "2.1.8"
pool:
dependency: transitive
description:
name: pool
sha256: "20fe868b6314b322ea036ba325e6fc0711a22948856475e2c2b6306e8ab39c2a"
url: "https://pub.dev"
source: hosted
version: "1.5.1"
process:
dependency: transitive
description:
name: process
sha256: "21e54fd2faf1b5bdd5102afd25012184a6793927648ea81eea80552ac9405b32"
url: "https://pub.dev"
source: hosted
version: "5.0.2"
pub_semver:
dependency: transitive
description:
name: pub_semver
sha256: "40d3ab1bbd474c4c2328c91e3a7df8c6dd629b79ece4c4bd04bee496a224fb0c"
url: "https://pub.dev"
source: hosted
version: "2.1.4"
pubspec_parse:
dependency: transitive
description:
name: pubspec_parse
sha256: c799b721d79eb6ee6fa56f00c04b472dcd44a30d258fac2174a6ec57302678f8
url: "https://pub.dev"
source: hosted
version: "1.3.0"
shelf:
dependency: transitive
description:
name: shelf
sha256: ad29c505aee705f41a4d8963641f91ac4cee3c8fad5947e033390a7bd8180fa4
url: "https://pub.dev"
source: hosted
version: "1.4.1"
shelf_web_socket:
dependency: transitive
description:
name: shelf_web_socket
sha256: "073c147238594ecd0d193f3456a5fe91c4b0abbcc68bf5cd95b36c4e194ac611"
url: "https://pub.dev"
source: hosted
version: "2.0.0"
sky_engine:
dependency: transitive
description: flutter
source: sdk
version: "0.0.99"
source_span:
dependency: transitive
description:
name: source_span
sha256: "53e943d4206a5e30df338fd4c6e7a077e02254531b138a15aec3bd143c1a8b3c"
url: "https://pub.dev"
source: hosted
version: "1.10.0"
stack_trace:
dependency: transitive
description:
name: stack_trace
sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b"
url: "https://pub.dev"
source: hosted
version: "1.11.1"
stream_channel:
dependency: transitive
description:
name: stream_channel
sha256: ba2aa5d8cc609d96bbb2899c28934f9e1af5cddbd60a827822ea467161eb54e7
url: "https://pub.dev"
source: hosted
version: "2.1.2"
stream_transform:
dependency: transitive
description:
name: stream_transform
sha256: "14a00e794c7c11aa145a170587321aedce29769c08d7f58b1d141da75e3b1c6f"
url: "https://pub.dev"
source: hosted
version: "2.1.0"
string_scanner:
dependency: transitive
description:
name: string_scanner
sha256: "556692adab6cfa87322a115640c11f13cb77b3f076ddcc5d6ae3c20242bedcde"
url: "https://pub.dev"
source: hosted
version: "1.2.0"
sync_http:
dependency: transitive
description:
name: sync_http
sha256: "7f0cd72eca000d2e026bcd6f990b81d0ca06022ef4e32fb257b30d3d1014a961"
url: "https://pub.dev"
source: hosted
version: "0.3.1"
term_glyph:
dependency: transitive
description:
name: term_glyph
sha256: a29248a84fbb7c79282b40b8c72a1209db169a2e0542bce341da992fe1bc7e84
url: "https://pub.dev"
source: hosted
version: "1.2.1"
test_api:
dependency: transitive
description:
name: test_api
sha256: "5b8a98dafc4d5c4c9c72d8b31ab2b23fc13422348d2997120294d3bac86b4ddb"
url: "https://pub.dev"
source: hosted
version: "0.7.2"
timing:
dependency: transitive
description:
name: timing
sha256: "70a3b636575d4163c477e6de42f247a23b315ae20e86442bebe32d3cabf61c32"
url: "https://pub.dev"
source: hosted
version: "1.0.1"
typed_data:
dependency: transitive
description:
name: typed_data
sha256: facc8d6582f16042dd49f2463ff1bd6e2c9ef9f3d5da3d9b087e244a7b564b3c
url: "https://pub.dev"
source: hosted
version: "1.3.2"
vector_math:
dependency: transitive
description:
name: vector_math
sha256: "80b3257d1492ce4d091729e3a67a60407d227c27241d6927be0130c98e741803"
url: "https://pub.dev"
source: hosted
version: "2.1.4"
video_player:
dependency: "direct main"
description:
name: video_player
sha256: e30df0d226c4ef82e2c150ebf6834b3522cf3f654d8e2f9419d376cdc071425d
url: "https://pub.dev"
source: hosted
version: "2.9.1"
video_player_android:
dependency: transitive
description:
name: video_player_android
sha256: "101028b643a3b43ced72107aacdbc4d30d55365487751de001a36cf0d86038d1"
url: "https://pub.dev"
source: hosted
version: "2.7.2"
video_player_avfoundation:
dependency: transitive
description:
name: video_player_avfoundation
sha256: d1e9a824f2b324000dc8fb2dcb2a3285b6c1c7c487521c63306cc5b394f68a7c
url: "https://pub.dev"
source: hosted
version: "2.6.1"
video_player_platform_interface:
dependency: transitive
description:
name: video_player_platform_interface
sha256: "236454725fafcacf98f0f39af0d7c7ab2ce84762e3b63f2cbb3ef9a7e0550bc6"
url: "https://pub.dev"
source: hosted
version: "6.2.2"
video_player_web:
dependency: transitive
description:
name: video_player_web
sha256: "6dcdd298136523eaf7dfc31abaf0dfba9aa8a8dbc96670e87e9d42b6f2caf774"
url: "https://pub.dev"
source: hosted
version: "2.3.2"
vm_service:
dependency: transitive
description:
name: vm_service
sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d"
url: "https://pub.dev"
source: hosted
version: "14.2.5"
watcher:
dependency: transitive
description:
name: watcher
sha256: "3d2ad6751b3c16cf07c7fca317a1413b3f26530319181b37e3b9039b84fc01d8"
url: "https://pub.dev"
source: hosted
version: "1.1.0"
web:
dependency: transitive
description:
name: web
sha256: d43c1d6b787bf0afad444700ae7f4db8827f701bc61c255ac8d328c6f4d52062
url: "https://pub.dev"
source: hosted
version: "1.0.0"
web_socket:
dependency: transitive
description:
name: web_socket
sha256: "3c12d96c0c9a4eec095246debcea7b86c0324f22df69893d538fcc6f1b8cce83"
url: "https://pub.dev"
source: hosted
version: "0.1.6"
web_socket_channel:
dependency: transitive
description:
name: web_socket_channel
sha256: "9f187088ed104edd8662ca07af4b124465893caf063ba29758f97af57e61da8f"
url: "https://pub.dev"
source: hosted
version: "3.0.1"
webdriver:
dependency: transitive
description:
name: webdriver
sha256: "003d7da9519e1e5f329422b36c4dcdf18d7d2978d1ba099ea4e45ba490ed845e"
url: "https://pub.dev"
source: hosted
version: "3.0.3"
xdg_directories:
dependency: transitive
description:
name: xdg_directories
sha256: faea9dee56b520b55a566385b84f2e8de55e7496104adada9962e0bd11bcff1d
url: "https://pub.dev"
source: hosted
version: "1.0.4"
yaml:
dependency: transitive
description:
name: yaml
sha256: "75769501ea3489fca56601ff33454fe45507ea3bfb014161abc3b43ae25989d5"
url: "https://pub.dev"
source: hosted
version: "3.1.2"
sdks:
dart: ">=3.5.0 <4.0.0"
flutter: ">=3.24.0"
```
</details>
### Steps to reproduce
1. Look at https://github.com/flutter/packages/blob/b9715b7eac7d97428c4acde94a75dad5a7525668/packages/camera/camera/example/lib/main.dart#L947 `setExposureOffset`
2. Notice 1: it optimistically assigns `_currentExposureOffset = offset;` within a `setState` however the effective setting could fail at which point the `_currentExposureOffset` will not reflect the actual state.
3. Notice 2: Unlike `setFlashMode` or `setExposureMode` (and alike) - which don't have a return value - the `setExposureOffset` has a return value. The return value would be the effective offset and the result of the operation and that should be the new value of `_currentExposureOffset`. Assigning it to the input argument doesn't make sense and fails the VGV code analysis.
4. Notice 3: Even if the `setExposureOffset` doesn't throw an exception it may round the offset, so we better take that as the new value.
### Expected results
Handle if the `setExposureOffset` would throw a CameraException exception and also treat if the `setExposureOffset` would round the offset, try to store the proper new offset value.
### Actual results
Right now if any rounding or exception would happen the internal state may diverge compared to the actual offset.
### Code sample
<details open><summary>Code sample</summary>
```dart
Future<void> setExposureOffset(double offset) async {
if (controller == null) {
return;
}
setState(() {
_currentExposureOffset = offset; // Sets the variable, but it can fail later
});
try {
// VGV code analysis fail: assignment to the input argument
offset = await controller!.setExposureOffset(offset);
} on CameraException catch (e) {
_showCameraException(e);
rethrow;
}
}
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.24.1, on Devuan GNU/Linux 6 (excalibur/ceres) 6.10.4-amd64, locale en_US.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Android Studio (version 2024.1)
[✓] VS Code (version 1.92.2)
[✓] Connected device (1 available)
[✓] Network resources
• No issues found!
```
</details>
| d: examples,p: camera,package,team-ecosystem,P3,has partial patch,triaged-ecosystem | low | Critical |
2,487,655,430 | node | subset of small-order Ed25519 vectors is failing in WPTs | I've been working on upgrading the Web Platform Tests in PR #54468, but I'm running into an issue with the WebCryptoAPI tests failing. After investigating, I found that I could reproduce the problem in Node.js. The error seems to be related to the `crypto.subtle` API, which isn't producing the expected results when verifying data in Ed25519.
FWIW Node.js isn't the only runtime per <https://wpt.fyi/results/WebCryptoAPI/sign_verify/eddsa.https.any.html?label=experimental&label=master&aligned>
The original error from running the Web Platform Tests is:
```
[UNEXPECTED_FAILURE][FAIL] Ed25519 Verification checks with small-order key of order - Test 0
assert_equals: Signature verification result. expected false but got true
at Test.<anonymous> (/test/fixtures/wpt/WebCryptoAPI/sign_verify/eddsa.js:235:15)
Command: /out/Release/node /test/wpt/test-webcrypto.js 'sign_verify/eddsa.https.any.js'
[UNEXPECTED_FAILURE][FAIL] Ed25519 Verification checks with small-order key of order - Test 1
assert_equals: Signature verification result. expected false but got true
at Test.<anonymous> (/test/fixtures/wpt/WebCryptoAPI/sign_verify/eddsa.js:235:15)
Command: /out/Release/node /test/wpt/test-webcrypto.js 'sign_verify/eddsa.https.any.js'
[UNEXPECTED_FAILURE][FAIL] Ed25519 Verification checks with small-order key of order - Test 2
assert_equals: Signature verification result. expected false but got true
at Test.<anonymous> (/test/fixtures/wpt/WebCryptoAPI/sign_verify/eddsa.js:235:15)
Command: /out/Release/node /test/wpt/test-webcrypto.js 'sign_verify/eddsa.https.any.js'
```
My minimal reproduction is:
```js
var pubKeys = [
[0xc7, 0x17, 0x6a, 0x70, 0x3d, 0x4d, 0xd8, 0x4f, 0xba, 0x3c, 0x0b, 0x76, 0x0d, 0x10, 0x67, 0x0f, 0x2a, 0x20, 0x53, 0xfa, 0x2c, 0x39, 0xcc, 0xc6, 0x4e, 0xc7, 0xfd, 0x77, 0x92, 0xac, 0x03, 0xfa], // kSmallOrderPoints #5
[0xf7, 0xba, 0xde, 0xc5, 0xb8, 0xab, 0xea, 0xf6, 0x99, 0x58, 0x39, 0x92, 0x21, 0x9b, 0x7b, 0x22, 0x3f, 0x1d, 0xf3, 0xfb, 0xbe, 0xa9, 0x19, 0x84, 0x4e, 0x3f, 0x7c, 0x55, 0x4a, 0x43, 0xdd, 0x43], // highest 32 bytes of case "1" signature
[0xec, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff], // kSmallOrderPoints #9
[0xEC, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0x7F], // kSmallOrderPoints #1
]
const tests = [{
id: "0", // S = 0 | A's order = small | R's order = small | (1) = pass | (2) = pass
message: Uint8Array.from([0x8c, 0x93, 0x25, 0x5d, 0x71, 0xdc, 0xab, 0x10, 0xe8, 0xf3, 0x79, 0xc2, 0x62, 0x00, 0xf3, 0xc7, 0xbd, 0x5f, 0x09, 0xd9, 0xbc, 0x30, 0x68, 0xd3, 0xef, 0x4e, 0xde, 0xb4, 0x85, 0x30, 0x22, 0xb6]),
keyData: Uint8Array.from(pubKeys[0]),
signature: Uint8Array.from([0xc7, 0x17, 0x6a, 0x70, 0x3d, 0x4d, 0xd8, 0x4f, 0xba, 0x3c, 0x0b, 0x76, 0x0d, 0x10, 0x67, 0x0f, 0x2a, 0x20, 0x53, 0xfa, 0x2c, 0x39, 0xcc, 0xc6, 0x4e, 0xc7, 0xfd, 0x77, 0x92, 0xac, 0x03, 0x7a, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00]),
verified: false, // small-order signature's R fail in the verification.
},
{
id: "1", // 0 < S < L | A's order = small | R's order = mixed | (1) = pass | (2) = pass
message: Uint8Array.from([0x9b, 0xd9, 0xf4, 0x4f, 0x4d, 0xcc, 0x75, 0xbd, 0x53, 0x1b, 0x56, 0xb2, 0xcd, 0x28, 0x0b, 0x0b, 0xb3, 0x8f, 0xc1, 0xcd, 0x6d, 0x12, 0x30, 0xe1, 0x48, 0x61, 0xd8, 0x61, 0xde, 0x09, 0x2e, 0x79]),
keyData: Uint8Array.from(pubKeys[0]),
signature: Uint8Array.from([0xf7, 0xba, 0xde, 0xc5, 0xb8, 0xab, 0xea, 0xf6, 0x99, 0x58, 0x39, 0x92, 0x21, 0x9b, 0x7b, 0x22, 0x3f, 0x1d, 0xf3, 0xfb, 0xbe, 0xa9, 0x19, 0x84, 0x4e, 0x3f, 0x7c, 0x55, 0x4a, 0x43, 0xdd, 0x43, 0xa5, 0xbb, 0x70, 0x47, 0x86, 0xbe, 0x79, 0xfc, 0x47, 0x6f, 0x91, 0xd3, 0xf3, 0xf8, 0x9b, 0x03, 0x98, 0x4d, 0x80, 0x68, 0xdc, 0xf1, 0xbb, 0x7d, 0xfc, 0x66, 0x37, 0xb4, 0x54, 0x50, 0xac, 0x04]),
verified: false, // small-order key's data fail in the verification.
},
{
id: "2", // 0 < S < L | A's order = mixed | R's order = small | (1) = pass | (2) = pass
message: Uint8Array.from([0xae, 0xbf, 0x3f, 0x26, 0x01, 0xa0, 0xc8, 0xc5, 0xd3, 0x9c, 0xc7, 0xd8, 0x91, 0x16, 0x42, 0xf7, 0x40, 0xb7, 0x81, 0x68, 0x21, 0x8d, 0xa8, 0x47, 0x17, 0x72, 0xb3, 0x5f, 0x9d, 0x35, 0xb9, 0xab]),
keyData: Uint8Array.from(pubKeys[1]),
signature: Uint8Array.from([0xc7, 0x17, 0x6a, 0x70, 0x3d, 0x4d, 0xd8, 0x4f, 0xba, 0x3c, 0x0b, 0x76, 0x0d, 0x10, 0x67, 0x0f, 0x2a, 0x20, 0x53, 0xfa, 0x2c, 0x39, 0xcc, 0xc6, 0x4e, 0xc7, 0xfd, 0x77, 0x92, 0xac, 0x03, 0xfa, 0x8c, 0x4b, 0xd4, 0x5a, 0xec, 0xac, 0xa5, 0xb2, 0x4f, 0xb9, 0x7b, 0xc1, 0x0a, 0xc2, 0x7a, 0xc8, 0x75, 0x1a, 0x7d, 0xfe, 0x1b, 0xaf, 0xf8, 0xb9, 0x53, 0xec, 0x9f, 0x58, 0x33, 0xca, 0x26, 0x0e]),
verified: false, // small-order signature's R fail in the verification.
},
{
id: "11", // 0 < S < L | A's order = small (non-canonical) | R's order = mixed | (1) = ? | (2) = ? Implementations that reduce A before hashing will accept #10 and accept #11, and viceversa
message: Uint8Array.from([0x39, 0xa5, 0x91, 0xf5, 0x32, 0x1b, 0xbe, 0x07, 0xfd, 0x5a, 0x23, 0xdc, 0x2f, 0x39, 0xd0, 0x25, 0xd7, 0x45, 0x26, 0x61, 0x57, 0x46, 0x72, 0x7c, 0xee, 0xfd, 0x6e, 0x82, 0xae, 0x65, 0xc0, 0x6f]),
keyData: Uint8Array.from(pubKeys[2]),
signature: Uint8Array.from([0xa9, 0xd5, 0x52, 0x60, 0xf7, 0x65, 0x26, 0x1e, 0xb9, 0xb8, 0x4e, 0x10, 0x6f, 0x66, 0x5e, 0x00, 0xb8, 0x67, 0x28, 0x7a, 0x76, 0x19, 0x90, 0xd7, 0x13, 0x59, 0x63, 0xee, 0x0a, 0x7d, 0x59, 0xdc, 0xa5, 0xbb, 0x70, 0x47, 0x86, 0xbe, 0x79, 0xfc, 0x47, 0x6f, 0x91, 0xd3, 0xf3, 0xf8, 0x9b, 0x03, 0x98, 0x4d, 0x80, 0x68, 0xdc, 0xf1, 0xbb, 0x7d, 0xfc, 0x66, 0x37, 0xb4, 0x54, 0x50, 0xac, 0x04]),
verified: false, // non-canonical point should fail in the verificaton (RFC8032)
},
// https://eprint.iacr.org/2020/1244.pdf#section.A.2
// cases breaking non-repudiation
{
id: "12", // 0 < S < L | A's order = small | R's order = mixed | (1) = ? | (2) = ?
message: Uint8Array.from([0x53, 0x65, 0x6e, 0x64, 0x20, 0x31, 0x30, 0x30, 0x20, 0x55, 0x53, 0x44, 0x20, 0x74, 0x6f, 0x20, 0x41, 0x6c, 0x69, 0x63, 0x65]),
keyData: Uint8Array.from(pubKeys[3]),
signature: Uint8Array.from([0xa9, 0xd5, 0x52, 0x60, 0xf7, 0x65, 0x26, 0x1e, 0xb9, 0xb8, 0x4e, 0x10, 0x6f, 0x66, 0x5e, 0x00, 0xb8, 0x67, 0x28, 0x7a, 0x76, 0x19, 0x90, 0xd7, 0x13, 0x59, 0x63, 0xee, 0x0a, 0x7d, 0x59, 0xdc, 0xa5, 0xbb, 0x70, 0x47, 0x86, 0xbe, 0x79, 0xfc, 0x47, 0x6f, 0x91, 0xd3, 0xf3, 0xf8, 0x9b, 0x03, 0x98, 0x4d, 0x80, 0x68, 0xdc, 0xf1, 0xbb, 0x7d, 0xfc, 0x66, 0x37, 0xb4, 0x54, 0x50, 0xac, 0x04]),
verified: false,
},
{
id: "13", // 0 < S < L | A's order = small | R's order = mixed | (1) = ? | (2) = ?
message: Uint8Array.from([0x53, 0x65, 0x6e, 0x64, 0x20, 0x31, 0x30, 0x30, 0x30, 0x30, 0x30, 0x20, 0x55, 0x53, 0x44, 0x20, 0x74, 0x6f, 0x20, 0x41, 0x6c, 0x69, 0x63, 0x65]),
keyData: Uint8Array.from(pubKeys[3]),
signature: Uint8Array.from([0xa9, 0xd5, 0x52, 0x60, 0xf7, 0x65, 0x26, 0x1e, 0xb9, 0xb8, 0x4e, 0x10, 0x6f, 0x66, 0x5e, 0x00, 0xb8, 0x67, 0x28, 0x7a, 0x76, 0x19, 0x90, 0xd7, 0x13, 0x59, 0x63, 0xee, 0x0a, 0x7d, 0x59, 0xdc, 0xa5, 0xbb, 0x70, 0x47, 0x86, 0xbe, 0x79, 0xfc, 0x47, 0x6f, 0x91, 0xd3, 0xf3, 0xf8, 0x9b, 0x03, 0x98, 0x4d, 0x80, 0x68, 0xdc, 0xf1, 0xbb, 0x7d, 0xfc, 0x66, 0x37, 0xb4, 0x54, 0x50, 0xac, 0x04]),
verified: false,
}
]
const algorithm = { name: "Ed25519" };
for (let i = 0; i < tests.length; i++) {
const test = tests[i];
const publicKey = await crypto.subtle.importKey("raw", test.keyData, algorithm, false, ["verify"]);
const isVerified = await crypto.subtle.verify(algorithm, publicKey, test.signature, test.message);
console.log(test.id, isVerified === test.verified);
}
```
> Modified from <https://github.com/web-platform-tests/wpt/blob/master/WebCryptoAPI/sign_verify/eddsa.js>. I've excluded the passing tests.
Results:
```
(node:73243) ExperimentalWarning: The Ed25519 Web Crypto API algorithm is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
0 false
1 false
2 false
11 false
12 false
13 false
```
<details>
<summary>Expand for a version with all tests, including passing ones</summary>
```js
var pubKeys = [
[0xc7, 0x17, 0x6a, 0x70, 0x3d, 0x4d, 0xd8, 0x4f, 0xba, 0x3c, 0x0b, 0x76, 0x0d, 0x10, 0x67, 0x0f, 0x2a, 0x20, 0x53, 0xfa, 0x2c, 0x39, 0xcc, 0xc6, 0x4e, 0xc7, 0xfd, 0x77, 0x92, 0xac, 0x03, 0xfa], // kSmallOrderPoints #5
[0xf7, 0xba, 0xde, 0xc5, 0xb8, 0xab, 0xea, 0xf6, 0x99, 0x58, 0x39, 0x92, 0x21, 0x9b, 0x7b, 0x22, 0x3f, 0x1d, 0xf3, 0xfb, 0xbe, 0xa9, 0x19, 0x84, 0x4e, 0x3f, 0x7c, 0x55, 0x4a, 0x43, 0xdd, 0x43], // highest 32 bytes of case "1" signature
[0xcd, 0xb2, 0x67, 0xce, 0x40, 0xc5, 0xcd, 0x45, 0x30, 0x6f, 0xa5, 0xd2, 0xf2, 0x97, 0x31, 0x45, 0x93, 0x87, 0xdb, 0xf9, 0xeb, 0x93, 0x3b, 0x7b, 0xd5, 0xae, 0xd9, 0xa7, 0x65, 0xb8, 0x8d, 0x4d],
[0x44, 0x2a, 0xad, 0x9f, 0x08, 0x9a, 0xd9, 0xe1, 0x46, 0x47, 0xb1, 0xef, 0x90, 0x99, 0xa1, 0xff, 0x47, 0x98, 0xd7, 0x85, 0x89, 0xe6, 0x6f, 0x28, 0xec, 0xa6, 0x9c, 0x11, 0xf5, 0x82, 0xa6, 0x23],
[0xec, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff], // kSmallOrderPoints #9
[0xEC, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0x7F], // kSmallOrderPoints #1
]
const tests = [{
id: "0", // S = 0 | A's order = small | R's order = small | (1) = pass | (2) = pass
message: Uint8Array.from([0x8c, 0x93, 0x25, 0x5d, 0x71, 0xdc, 0xab, 0x10, 0xe8, 0xf3, 0x79, 0xc2, 0x62, 0x00, 0xf3, 0xc7, 0xbd, 0x5f, 0x09, 0xd9, 0xbc, 0x30, 0x68, 0xd3, 0xef, 0x4e, 0xde, 0xb4, 0x85, 0x30, 0x22, 0xb6]),
keyData: Uint8Array.from(pubKeys[0]),
signature: Uint8Array.from([0xc7, 0x17, 0x6a, 0x70, 0x3d, 0x4d, 0xd8, 0x4f, 0xba, 0x3c, 0x0b, 0x76, 0x0d, 0x10, 0x67, 0x0f, 0x2a, 0x20, 0x53, 0xfa, 0x2c, 0x39, 0xcc, 0xc6, 0x4e, 0xc7, 0xfd, 0x77, 0x92, 0xac, 0x03, 0x7a, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00]),
verified: false, // small-order signature's R fail in the verification.
},
{
id: "1", // 0 < S < L | A's order = small | R's order = mixed | (1) = pass | (2) = pass
message: Uint8Array.from([0x9b, 0xd9, 0xf4, 0x4f, 0x4d, 0xcc, 0x75, 0xbd, 0x53, 0x1b, 0x56, 0xb2, 0xcd, 0x28, 0x0b, 0x0b, 0xb3, 0x8f, 0xc1, 0xcd, 0x6d, 0x12, 0x30, 0xe1, 0x48, 0x61, 0xd8, 0x61, 0xde, 0x09, 0x2e, 0x79]),
keyData: Uint8Array.from(pubKeys[0]),
signature: Uint8Array.from([0xf7, 0xba, 0xde, 0xc5, 0xb8, 0xab, 0xea, 0xf6, 0x99, 0x58, 0x39, 0x92, 0x21, 0x9b, 0x7b, 0x22, 0x3f, 0x1d, 0xf3, 0xfb, 0xbe, 0xa9, 0x19, 0x84, 0x4e, 0x3f, 0x7c, 0x55, 0x4a, 0x43, 0xdd, 0x43, 0xa5, 0xbb, 0x70, 0x47, 0x86, 0xbe, 0x79, 0xfc, 0x47, 0x6f, 0x91, 0xd3, 0xf3, 0xf8, 0x9b, 0x03, 0x98, 0x4d, 0x80, 0x68, 0xdc, 0xf1, 0xbb, 0x7d, 0xfc, 0x66, 0x37, 0xb4, 0x54, 0x50, 0xac, 0x04]),
verified: false, // small-order key's data fail in the verification.
},
{
id: "2", // 0 < S < L | A's order = mixed | R's order = small | (1) = pass | (2) = pass
message: Uint8Array.from([0xae, 0xbf, 0x3f, 0x26, 0x01, 0xa0, 0xc8, 0xc5, 0xd3, 0x9c, 0xc7, 0xd8, 0x91, 0x16, 0x42, 0xf7, 0x40, 0xb7, 0x81, 0x68, 0x21, 0x8d, 0xa8, 0x47, 0x17, 0x72, 0xb3, 0x5f, 0x9d, 0x35, 0xb9, 0xab]),
keyData: Uint8Array.from(pubKeys[1]),
signature: Uint8Array.from([0xc7, 0x17, 0x6a, 0x70, 0x3d, 0x4d, 0xd8, 0x4f, 0xba, 0x3c, 0x0b, 0x76, 0x0d, 0x10, 0x67, 0x0f, 0x2a, 0x20, 0x53, 0xfa, 0x2c, 0x39, 0xcc, 0xc6, 0x4e, 0xc7, 0xfd, 0x77, 0x92, 0xac, 0x03, 0xfa, 0x8c, 0x4b, 0xd4, 0x5a, 0xec, 0xac, 0xa5, 0xb2, 0x4f, 0xb9, 0x7b, 0xc1, 0x0a, 0xc2, 0x7a, 0xc8, 0x75, 0x1a, 0x7d, 0xfe, 0x1b, 0xaf, 0xf8, 0xb9, 0x53, 0xec, 0x9f, 0x58, 0x33, 0xca, 0x26, 0x0e]),
verified: false, // small-order signature's R fail in the verification.
},
{
id: "3", // 0 < S < L | A's order = mixed | R's order = mixed | (1) = pass | (2) = pass
message: Uint8Array.from([0x9b, 0xd9, 0xf4, 0x4f, 0x4d, 0xcc, 0x75, 0xbd, 0x53, 0x1b, 0x56, 0xb2, 0xcd, 0x28, 0x0b, 0x0b, 0xb3, 0x8f, 0xc1, 0xcd, 0x6d, 0x12, 0x30, 0xe1, 0x48, 0x61, 0xd8, 0x61, 0xde, 0x09, 0x2e, 0x79]),
keyData: Uint8Array.from(pubKeys[2]),
signature: Uint8Array.from([0x90, 0x46, 0xa6, 0x47, 0x50, 0x44, 0x49, 0x38, 0xde, 0x19, 0xf2, 0x27, 0xbb, 0x80, 0x48, 0x5e, 0x92, 0xb8, 0x3f, 0xdb, 0x4b, 0x65, 0x06, 0xc1, 0x60, 0x48, 0x4c, 0x01, 0x6c, 0xc1, 0x85, 0x2f, 0x87, 0x90, 0x9e, 0x14, 0x42, 0x8a, 0x7a, 0x1d, 0x62, 0xe9, 0xf2, 0x2f, 0x3d, 0x3a, 0xd7, 0x80, 0x2d, 0xb0, 0x2e, 0xb2, 0xe6, 0x88, 0xb6, 0xc5, 0x2f, 0xcd, 0x66, 0x48, 0xa9, 0x8b, 0xd0, 0x09]),
verified: true, // mixed-order points are not checked.
},
{
id: "4", // 0 < S < L | A's order = mixed | R's order = mixed | (1) = pass | (2) = fail
message: Uint8Array.from([0xe4, 0x7d, 0x62, 0xc6, 0x3f, 0x83, 0x0d, 0xc7, 0xa6, 0x85, 0x1a, 0x0b, 0x1f, 0x33, 0xae, 0x4b, 0xb2, 0xf5, 0x07, 0xfb, 0x6c, 0xff, 0xec, 0x40, 0x11, 0xea, 0xcc, 0xd5, 0x5b, 0x53, 0xf5, 0x6c]),
keyData: Uint8Array.from(pubKeys[2]),
signature: Uint8Array.from([0x16, 0x0a, 0x1c, 0xb0, 0xdc, 0x9c, 0x02, 0x58, 0xcd, 0x0a, 0x7d, 0x23, 0xe9, 0x4d, 0x8f, 0xa8, 0x78, 0xbc, 0xb1, 0x92, 0x5f, 0x2c, 0x64, 0x24, 0x6b, 0x2d, 0xee, 0x17, 0x96, 0xbe, 0xd5, 0x12, 0x5e, 0xc6, 0xbc, 0x98, 0x2a, 0x26, 0x9b, 0x72, 0x3e, 0x06, 0x68, 0xe5, 0x40, 0x91, 0x1a, 0x9a, 0x6a, 0x58, 0x92, 0x1d, 0x69, 0x25, 0xe4, 0x34, 0xab, 0x10, 0xaa, 0x79, 0x40, 0x55, 0x1a, 0x09]),
verified: false, // expect a cofactorless verification algorithm.
},
{
id: "5", // 0 < S < L | A's order = mixed | R's order = L | (1) = pass | (2) = fail
message: Uint8Array.from([0xe4, 0x7d, 0x62, 0xc6, 0x3f, 0x83, 0x0d, 0xc7, 0xa6, 0x85, 0x1a, 0x0b, 0x1f, 0x33, 0xae, 0x4b, 0xb2, 0xf5, 0x07, 0xfb, 0x6c, 0xff, 0xec, 0x40, 0x11, 0xea, 0xcc, 0xd5, 0x5b, 0x53, 0xf5, 0x6c]),
keyData: Uint8Array.from(pubKeys[2]),
signature: Uint8Array.from([0x21, 0x12, 0x2a, 0x84, 0xe0, 0xb5, 0xfc, 0xa4, 0x05, 0x2f, 0x5b, 0x12, 0x35, 0xc8, 0x0a, 0x53, 0x78, 0x78, 0xb3, 0x8f, 0x31, 0x42, 0x35, 0x6b, 0x2c, 0x23, 0x84, 0xeb, 0xad, 0x46, 0x68, 0xb7, 0xe4, 0x0b, 0xc8, 0x36, 0xda, 0xc0, 0xf7, 0x10, 0x76, 0xf9, 0xab, 0xe3, 0xa5, 0x3f, 0x9c, 0x03, 0xc1, 0xce, 0xee, 0xdd, 0xb6, 0x58, 0xd0, 0x03, 0x04, 0x94, 0xac, 0xe5, 0x86, 0x68, 0x74, 0x05]),
verified: false, // expect a cofactorless verification algorithm.
},
{
id: "6", // S > L | A's order = L | R's order = L | (1) = pass | (2) = pass
message: Uint8Array.from([0x85, 0xe2, 0x41, 0xa0, 0x7d, 0x14, 0x8b, 0x41, 0xe4, 0x7d, 0x62, 0xc6, 0x3f, 0x83, 0x0d, 0xc7, 0xa6, 0x85, 0x1a, 0x0b, 0x1f, 0x33, 0xae, 0x4b, 0xb2, 0xf5, 0x07, 0xfb, 0x6c, 0xff, 0xec, 0x40]),
keyData: Uint8Array.from(pubKeys[3]),
signature: Uint8Array.from([0xe9, 0x6f, 0x66, 0xbe, 0x97, 0x6d, 0x82, 0xe6, 0x01, 0x50, 0xba, 0xec, 0xff, 0x99, 0x06, 0x68, 0x4a, 0xeb, 0xb1, 0xef, 0x18, 0x1f, 0x67, 0xa7, 0x18, 0x9a, 0xc7, 0x8e, 0xa2, 0x3b, 0x6c, 0x0e, 0x54, 0x7f, 0x76, 0x90, 0xa0, 0xe2, 0xdd, 0xcd, 0x04, 0xd8, 0x7d, 0xbc, 0x34, 0x90, 0xdc, 0x19, 0xb3, 0xb3, 0x05, 0x2f, 0x7f, 0xf0, 0x53, 0x8c, 0xb6, 0x8a, 0xfb, 0x36, 0x9b, 0xa3, 0xa5, 0x14]),
verified: false, // S out of bounds
},
{
id: "7", // S >> L | A's order = L | R's order = L | (1) = pass | (2) = pass
message: Uint8Array.from([0x85, 0xe2, 0x41, 0xa0, 0x7d, 0x14, 0x8b, 0x41, 0xe4, 0x7d, 0x62, 0xc6, 0x3f, 0x83, 0x0d, 0xc7, 0xa6, 0x85, 0x1a, 0x0b, 0x1f, 0x33, 0xae, 0x4b, 0xb2, 0xf5, 0x07, 0xfb, 0x6c, 0xff, 0xec, 0x40]),
keyData: Uint8Array.from(pubKeys[3]),
signature: Uint8Array.from([0x8c, 0xe5, 0xb9, 0x6c, 0x8f, 0x26, 0xd0, 0xab, 0x6c, 0x47, 0x95, 0x8c, 0x9e, 0x68, 0xb9, 0x37, 0x10, 0x4c, 0xd3, 0x6e, 0x13, 0xc3, 0x35, 0x66, 0xac, 0xd2, 0xfe, 0x8d, 0x38, 0xaa, 0x19, 0x42, 0x7e, 0x71, 0xf9, 0x8a, 0x47, 0x34, 0xe7, 0x4f, 0x2f, 0x13, 0xf0, 0x6f, 0x97, 0xc2, 0x0d, 0x58, 0xcc, 0x3f, 0x54, 0xb8, 0xbd, 0x0d, 0x27, 0x2f, 0x42, 0xb6, 0x95, 0xdd, 0x7e, 0x89, 0xa8, 0xc2, 0x02]),
verified: false, // S out of bounds
},
{
id: "8", // 0 < S < L | A's order = mixed | R's order = small (non-canonical) | (1) = ? | (2) = ? Implementations that reduce A before hashing will accept #8 and accept #9, and viceversa
message: Uint8Array.from([0x9b, 0xed, 0xc2, 0x67, 0x42, 0x37, 0x25, 0xd4, 0x73, 0x88, 0x86, 0x31, 0xeb, 0xf4, 0x59, 0x88, 0xba, 0xd3, 0xdb, 0x83, 0x85, 0x1e, 0xe8, 0x5c, 0x85, 0xe2, 0x41, 0xa0, 0x7d, 0x14, 0x8b, 0x41]),
keyData: Uint8Array.from(pubKeys[1]),
signature: Uint8Array.from([0xec, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x03, 0xbe, 0x96, 0x78, 0xac, 0x10, 0x2e, 0xdc, 0xd9, 0x2b, 0x02, 0x10, 0xbb, 0x34, 0xd7, 0x42, 0x8d, 0x12, 0xff, 0xc5, 0xdf, 0x5f, 0x37, 0xe3, 0x59, 0x94, 0x12, 0x66, 0xa4, 0xe3, 0x5f, 0x0f]),
verified: false, // non-canonical point should fail in the verificaton (RFC8032)
},
{
id: "9", // 0 < S < L | A's order = mixed | R's order = small (non-canonical) | (1) = ? | (2) = ?
message: Uint8Array.from([0x9b, 0xed, 0xc2, 0x67, 0x42, 0x37, 0x25, 0xd4, 0x73, 0x88, 0x86, 0x31, 0xeb, 0xf4, 0x59, 0x88, 0xba, 0xd3, 0xdb, 0x83, 0x85, 0x1e, 0xe8, 0x5c, 0x85, 0xe2, 0x41, 0xa0, 0x7d, 0x14, 0x8b, 0x41]),
keyData: Uint8Array.from(pubKeys[1]),
signature: Uint8Array.from([0xec, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xca, 0x8c, 0x5b, 0x64, 0xcd, 0x20, 0x89, 0x82, 0xaa, 0x38, 0xd4, 0x93, 0x66, 0x21, 0xa4, 0x77, 0x5a, 0xa2, 0x33, 0xaa, 0x05, 0x05, 0x71, 0x1d, 0x8f, 0xdc, 0xfd, 0xaa, 0x94, 0x3d, 0x49, 0x08]),
verified: false, // non-canonical point should fail in the verificaton (RFC8032)
},
{
id: "10", // 0 < S < L | A's order = small (non-canonical) | R's order = mixed | (1) = ? | (2) = ? Implementations that reduce A before hashing will accept #10 and accept #11, and viceversa
message: Uint8Array.from([0xe9, 0x6b, 0x70, 0x21, 0xeb, 0x39, 0xc1, 0xa1, 0x63, 0xb6, 0xda, 0x4e, 0x30, 0x93, 0xdc, 0xd3, 0xf2, 0x13, 0x87, 0xda, 0x4c, 0xc4, 0x57, 0x2b, 0xe5, 0x88, 0xfa, 0xfa, 0xe2, 0x3c, 0x15, 0x5b]),
keyData: Uint8Array.from(pubKeys[4]),
signature: Uint8Array.from([0xa9, 0xd5, 0x52, 0x60, 0xf7, 0x65, 0x26, 0x1e, 0xb9, 0xb8, 0x4e, 0x10, 0x6f, 0x66, 0x5e, 0x00, 0xb8, 0x67, 0x28, 0x7a, 0x76, 0x19, 0x90, 0xd7, 0x13, 0x59, 0x63, 0xee, 0x0a, 0x7d, 0x59, 0xdc, 0xa5, 0xbb, 0x70, 0x47, 0x86, 0xbe, 0x79, 0xfc, 0x47, 0x6f, 0x91, 0xd3, 0xf3, 0xf8, 0x9b, 0x03, 0x98, 0x4d, 0x80, 0x68, 0xdc, 0xf1, 0xbb, 0x7d, 0xfc, 0x66, 0x37, 0xb4, 0x54, 0x50, 0xac, 0x04]),
verified: false, // non-canonical point should fail in the verificaton (RFC8032)
},
{
id: "11", // 0 < S < L | A's order = small (non-canonical) | R's order = mixed | (1) = ? | (2) = ? Implementations that reduce A before hashing will accept #10 and accept #11, and viceversa
message: Uint8Array.from([0x39, 0xa5, 0x91, 0xf5, 0x32, 0x1b, 0xbe, 0x07, 0xfd, 0x5a, 0x23, 0xdc, 0x2f, 0x39, 0xd0, 0x25, 0xd7, 0x45, 0x26, 0x61, 0x57, 0x46, 0x72, 0x7c, 0xee, 0xfd, 0x6e, 0x82, 0xae, 0x65, 0xc0, 0x6f]),
keyData: Uint8Array.from(pubKeys[4]),
signature: Uint8Array.from([0xa9, 0xd5, 0x52, 0x60, 0xf7, 0x65, 0x26, 0x1e, 0xb9, 0xb8, 0x4e, 0x10, 0x6f, 0x66, 0x5e, 0x00, 0xb8, 0x67, 0x28, 0x7a, 0x76, 0x19, 0x90, 0xd7, 0x13, 0x59, 0x63, 0xee, 0x0a, 0x7d, 0x59, 0xdc, 0xa5, 0xbb, 0x70, 0x47, 0x86, 0xbe, 0x79, 0xfc, 0x47, 0x6f, 0x91, 0xd3, 0xf3, 0xf8, 0x9b, 0x03, 0x98, 0x4d, 0x80, 0x68, 0xdc, 0xf1, 0xbb, 0x7d, 0xfc, 0x66, 0x37, 0xb4, 0x54, 0x50, 0xac, 0x04]),
verified: false, // non-canonical point should fail in the verificaton (RFC8032)
},
// https://eprint.iacr.org/2020/1244.pdf#section.A.2
// cases breaking non-repudiation
{
id: "12", // 0 < S < L | A's order = small | R's order = mixed | (1) = ? | (2) = ?
message: Uint8Array.from([0x53, 0x65, 0x6e, 0x64, 0x20, 0x31, 0x30, 0x30, 0x20, 0x55, 0x53, 0x44, 0x20, 0x74, 0x6f, 0x20, 0x41, 0x6c, 0x69, 0x63, 0x65]),
keyData: Uint8Array.from(pubKeys[5]),
signature: Uint8Array.from([0xa9, 0xd5, 0x52, 0x60, 0xf7, 0x65, 0x26, 0x1e, 0xb9, 0xb8, 0x4e, 0x10, 0x6f, 0x66, 0x5e, 0x00, 0xb8, 0x67, 0x28, 0x7a, 0x76, 0x19, 0x90, 0xd7, 0x13, 0x59, 0x63, 0xee, 0x0a, 0x7d, 0x59, 0xdc, 0xa5, 0xbb, 0x70, 0x47, 0x86, 0xbe, 0x79, 0xfc, 0x47, 0x6f, 0x91, 0xd3, 0xf3, 0xf8, 0x9b, 0x03, 0x98, 0x4d, 0x80, 0x68, 0xdc, 0xf1, 0xbb, 0x7d, 0xfc, 0x66, 0x37, 0xb4, 0x54, 0x50, 0xac, 0x04]),
verified: false,
},
{
id: "13", // 0 < S < L | A's order = small | R's order = mixed | (1) = ? | (2) = ?
message: Uint8Array.from([0x53, 0x65, 0x6e, 0x64, 0x20, 0x31, 0x30, 0x30, 0x30, 0x30, 0x30, 0x20, 0x55, 0x53, 0x44, 0x20, 0x74, 0x6f, 0x20, 0x41, 0x6c, 0x69, 0x63, 0x65]),
keyData: Uint8Array.from(pubKeys[5]),
signature: Uint8Array.from([0xa9, 0xd5, 0x52, 0x60, 0xf7, 0x65, 0x26, 0x1e, 0xb9, 0xb8, 0x4e, 0x10, 0x6f, 0x66, 0x5e, 0x00, 0xb8, 0x67, 0x28, 0x7a, 0x76, 0x19, 0x90, 0xd7, 0x13, 0x59, 0x63, 0xee, 0x0a, 0x7d, 0x59, 0xdc, 0xa5, 0xbb, 0x70, 0x47, 0x86, 0xbe, 0x79, 0xfc, 0x47, 0x6f, 0x91, 0xd3, 0xf3, 0xf8, 0x9b, 0x03, 0x98, 0x4d, 0x80, 0x68, 0xdc, 0xf1, 0xbb, 0x7d, 0xfc, 0x66, 0x37, 0xb4, 0x54, 0x50, 0xac, 0x04]),
verified: false,
}
]
const algorithm = { name: "Ed25519" };
for (let i = 0; i < tests.length; i++) {
const test = tests[i];
const publicKey = await crypto.subtle.importKey("raw", test.keyData, algorithm, false, ["verify"]);
const isVerified = await crypto.subtle.verify(algorithm, publicKey, test.signature, test.message);
console.log(test.id, isVerified === test.verified);
}
```
```
(node:77667) ExperimentalWarning: The Ed25519 Web Crypto API algorithm is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
0 false
1 false
2 false
3 true
4 true
5 true
6 true
7 true
8 true
9 true
10 true
11 false
12 false
13 false
```
</details>
---
CC @nodejs/crypto | crypto,experimental,webcrypto,web-standards | low | Critical |
2,487,660,333 | create-react-app | Broken and soon to be discontiued short links (goo.gl) | ### Describe the bug
There are short links using googles url shortener goo.gl in the documentation as well as in build output that point to pages that have been moved. Users following the short link must manually click to go to the new page and copy the anchor from the page before to get to the right section.
Google will be discontinuing the goo.gl service anyways (https://www.cnet.com/tech/services-and-software/google-link-shortener-service-ends-firebase-dynamic-links-googl/) so those links should be replaced anyways which is easier while they can still be followed. So even the ones still working should be replaced.
### Which terms did you search for in User Guide?
Searching the repository for all occruences of "goo.gl"
### Expected behavior
Clicking link (eg. https://goo.gl/LeUzfb) leads to desired ressource
### Actual behavior
- Currently: Clicking link leads to Markdown file pointing to the file where the originally linked file has been moved to
- Soon: Clicking link leads nowhere or to a google error page
### Proposed fix
I suggest to replace them with direct links and could supply a PR to do so.
But in the past there were also discussions about other shortening solutions, eg in #5910 netlify-shortener was suggested, but it doesn't seem a decision was ever made.
If no other solution is preferred, I''ll supply a PR with the replaced links. | needs triage,issue: bug report | low | Critical |
2,487,662,239 | material-ui | [material-ui][Autocomplete] Issues with clearOnEscape when using screen reader on Windows | ### Steps to reproduce
Link to live example: https://codesandbox.io/p/sandbox/hungry-northcutt-d3nr68?file=%2Fsrc%2FDemo.tsx
Steps:
1. The issue can be seen from even the default demo on the component's page.
2. While using a screen reader like NVDA or JAWS, interact with the autocomplete and then try to use the escape key.
3. Observe
### Current behavior
While the escape key does clear the input field, the focus on the input seems to be lost.
Videos:
https://drive.google.com/file/d/15xjifFiumDYm7X7Eztf5f33-aB5qPozs/view?usp=sharing
https://drive.google.com/file/d/1cFjOo6-xZA-Su9qYCWAmHo4Ka_O6M8Mx/view?usp=sharing
### Expected behavior
When using the escape key, the input will stay focused and the user will continue to be able to interact with the element.
### Context
Ensure that users have the ability to interact with the autocomplete component when using screen readers on Windows.
### Your environment
<details>
<summary><code>npx @mui/envinfo</code></summary>
```
System:
OS: Windows 10
Binaries:
Node: 20.12.0 - ~/.nvm/versions/node/v20.12.0/bin/node
npm: 10.5.0 - ~/.nvm/versions/node/v20.12.0/bin/npm
pnpm: Not Found
Browsers:
Chrome: 127.0.6533.122
Edge: Not Found
Safari: 17.4.1
npmPackages:
@emotion/react: 11.13.3 => 11.13.3
@emotion/styled: 11.13.0 => 11.13.0
@mui/core-downloads-tracker: 5.16.7
@mui/material: 5.16.7 => 5.16.7
@mui/private-theming: 5.16.6
@mui/styled-engine: 5.16.6
@mui/system: 5.16.6
@mui/types: 7.2.15
@mui/utils: 5.16.6
@mui/x-data-grid: 7.12.1 => 7.12.1
@mui/x-date-pickers: 7.12.1 => 7.12.1
@mui/x-internals: 7.12.0
@types/react: 18.3.3 => 18.3.3
react: 18.3.1 => 18.3.1
react-dom: 18.3.1 => 18.3.1
typescript: 5.5.4 => 5.5.4
```
</details>
**Search keywords**: clearOnEscape | bug 🐛,accessibility,component: autocomplete | low | Minor |
2,487,769,991 | flutter | Add benchmarks to compare performance metrics between Flutter and native equivalent apps | Add benchmarks for key performance metrics to compare a Flutter app with an equivalent native app.
- [ ] #162025
- [ ] #162026
- [ ] Move the app and scripts to flutter/flutter benchmarks
- Add new benchmarks
- [ ] #162028
- [ ] #162029
- [ ] #162030
- [ ] #162031
- [ ] Hook up the metrics to Skiaperf benchmarks
- [ ] Make sure all benchmarks are added to Skiaperf benchmarks alerts (the regex just changed so it may need to be added explicitly).
Design Doc/Inspo: [flutter.dev/go/ui-imitation-games](url)
| team: benchmark,P2,team-ios,triaged-ios | low | Major |
2,487,786,682 | node | V8 build error with 22.7.0 | Like https://github.com/nodejs/node/issues/53633 which was for gcc 12 and fixed in commit f4a7ac5e1842c0f4629a0bebfda38f2502a2ee41 but with clang 15.0.7 on x86_64 linux I get the exact same build error:
```
../deps/v8/src/base/small-vector.h:25:3: error: static assertion failed due to requirement '::v8::base::is_trivially_copyable<std::pair<const v8::internal::com
piler::turboshaft::PhiOp *, const v8::internal::compiler::turboshaft::OpIndex>>::value': T should be trivially copyable
ASSERT_TRIVIALLY_COPYABLE(T);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/v8/src/base/macros.h:211:3: note: expanded from macro 'ASSERT_TRIVIALLY_COPYABLE'
static_assert(::v8::base::is_trivially_copyable<T>::value, \
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/v8/src/compiler/turboshaft/loop-unrolling-reducer.h:431:65: note: in instantiation of template class 'v8::base::SmallVector<std::pair<const v8::interna
l::compiler::turboshaft::PhiOp *, const v8::internal::compiler::turboshaft::OpIndex>, 16>' requested here
base::SmallVector<std::pair<const PhiOp*, const OpIndex>, 16> phis;
```
Maybe just remove that ASSERT_TRIVIALLY_COPYABLE? Upstream already tests for correctness and to us it's just a recurring source of build breakage. | confirmed-bug,build,v8 engine | low | Critical |
2,487,793,802 | go | runtime: gccheckmark does nothing? | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.23.0 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/Users/mm/Library/Caches/go-build'
GOENV='/Users/mm/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/mm/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='darwin'
GOPATH='/Users/mm/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/darwin_amd64'
GOVCS=''
GOVERSION='go1.23.0'
GODEBUG=''
GOTELEMETRY='local'
GOTELEMETRYDIR='/Users/mm/Library/Application Support/go/telemetry'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='/usr/bin/clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD='/Users/mm/go/src/github.com/MikeMitchellWebDev/gc_knobs/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/5y/wtzzmjlj5v52pg7wr8ptbg_m0000gp/T/go-build534087183=/tmp/go-build -gno-record-gcc-switches -fno-common'
uname -v: Darwin Kernel Version 20.6.0: Thu Jul 6 22:12:47 PDT 2023; root:xnu-7195.141.49.702.12~1/RELEASE_X86_64
ProductName: macOS
ProductVersion: 11.7.10
BuildVersion: 20G1427
lldb --version: lldb-1300.0.42.3
Swift version 5.5.2-dev
</pre></details>
### What did you do?
2 things: First I ran a program with` GODEBUG=gccheckmark=1.` When `setCheckmark `wasn't called, I tried to build the go source code after manually setting `var useCheckmark = true`
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
### What did you expect to see?
It depends on whether I had simply run a program with `GODEBUG=gccheckmark=1` or altered the source code as described above.
1. setCheckmark to be called at some point
2. The source code to build after I set `useCheckmark = true`
### What did you see instead?
1. With the source code "as is", setCheckmark is never called. There is a very narrow window in which useCheckmark is set to true inside `gcMarkTermination`, so this line of code in mgcmark.go never runs
```
if useCheckmark {
if setCheckmark(obj, base, off, mbits) {
```
2. When I manually set useCheckmark = true, the source code wouldn't build. There's always a fatal error "fatal error: checkmark found unmarked object" | NeedsInvestigation,compiler/runtime | low | Critical |
2,487,866,266 | Web-Dev-For-Beginners | Fix code scanning alert - Weak hashes | <!-- Warning: The suggested title contains the alert rule name. This can expose security information. -->
Tracking issue for:
- [ ] https://github.com/microsoft/Web-Dev-For-Beginners/security/code-scanning/1
| no-issue-activity | low | Minor |
2,487,882,611 | rust | `unreachable_pattern` could get more specific if the preempting pattern resembles a `const` | `match`allways picks the first arm if matching value is not defined/unknown.
I was using `const`to define the values for the arms.
But the `const` were places inside the `main()` and the match expression was in a separate function.
I tried this code:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=4b8fce2e782604f738c4fb9229b2a29b
Uncommenting the first 2 `const` gives the wanted results.
I expected to see this happen:
That the compiler finds the const values or stop compiling because the matching values are unknown.
Instead, this happened:
It just compiles.
But it gives some warnings like `warning: unreachable pattern`.
It just runs but with the wrong values.
See play link. See the behavior on all the versions "Stable", "Beta" and "Nightly". | A-lints,A-diagnostics,T-compiler,C-bug,A-patterns,L-unreachable_patterns | low | Critical |
2,487,888,043 | transformers | Extend Fx supported models with KV cache | ### Feature request
I noticed only llama and opt models are supported for FX tracing with KV Cache right now, can I check what is the plan to extend it to more models? Thanks!
### Motivation
I would like run fx traced graphmodules for generate(), which uses KV Cache. Right now it works for OPT and LLama, but I would like try on more models.
### Your contribution
If someone could point me to the general design pattern to make a model FX supported with KV cache or the lines of changes in modeling_opt.py or modeling_llama.py that made them work, I would be happy to submit PRs to make more models work. | Feature request | low | Minor |
2,487,912,069 | flutter | [Impeller] Support instanced rendering in the Impeller HAL. | Impeller doesn't support instanced rendering with base vertex specification today. It is not portable across all platforms and client rendering APIs Impeller supports today.
OpenGL ES 2.0 doesn't support instanced rendering at all (without extensions). Metal does support instanced rendering but not on MTLGPUFamilyMac1 and MTLGPUFamilyApple2 and earlier families per the [Metal Feature Set Tables](https://developer.apple.com/metal/Metal-Feature-Set-Tables.pdf). Vulkan does seem to support instanced rendering everywhere and MoltenVK has an emulation for the older GPU families.
It should be trivial to support instanced rendering via emulation as a start and add fast paths for newer devices. These should cover the vast majority of devices. | P3,e: impeller,team-engine,triaged-engine,flutter-gpu | low | Major |
2,487,925,116 | ui | [bug]: SelectTrigger placeholder does not mute | ### Describe the bug
When using the `<SelectTrigger />` component, the `placeholder:text-muted-foreground` does not work properly.
I'm assuming this is because the select component does not have a placeholder attribute. The placeholder value is just used as the standard button text if the select value does not have any state selected.
### Affected component/components
SelectTrigger
### How to reproduce
View Select component on docs site:
https://ui.shadcn.com/docs/components/select
Note the image below. The place holder value is the standard black font. It is not being muted via the `placeholder:text-muted-foreground` style that is being applied to the `<SelectTrigger>` component.
<img width="808" alt="image" src="https://github.com/user-attachments/assets/0efcf953-bf08-446e-92d7-d3fcf10851be">
```
<SelectTrigger>
<SelectValue
ref={field.ref}
placeholder="My placeholder..."
/>
```
### Codesandbox/StackBlitz link
_No response_
### Logs
_No response_
### System Info
```bash
Mac M1 Pro Max, Latest Chrome. TypeScript, Tailwind
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,487,928,187 | godot | Very small default min window size in hyprland. | ### Tested versions
v4.3.stable.arch_linux using hyprland wm
### System information
Godot v4.3.stable unknown - Arch Linux #1 SMP PREEMPT_DYNAMIC Wed, 14 Aug 2024 15:21:14 +0000 - Wayland - Vulkan (Forward+) - integrated AMD Radeon Vega 3 Graphics (RADV RAVEN) - AMD Ryzen 3 2200U with Radeon Vega Mobile Gfx (4 Threads)
### Issue description
In Godot editor, windows like "Create New Node", "Instantiate Child Scene", "About Godot", and any other besides de main editor window, starts with a very little size, then you need to manually resize it.
### Steps to reproduce
In Hyprland wm, launch Godot, open any project, then try to open any window, for example try to add a new node to the scene tree, or open Help ->"about godot".
### Minimal reproduction project (MRP)
May be any project, no one in particular. | bug,platform:linuxbsd,needs testing,topic:gui | low | Major |
2,487,965,041 | flutter | Deprecate 'canRequestFocus' in Favor of 'focusable' for FocusNode and FocusScopeNode | I created this issue to cover the API improvement described in #24722:
| framework,c: proposal,f: focus,P3,team-framework,triaged-framework | low | Minor |
2,487,972,644 | rust | Indicate the user when lifetime requirements from a method diverge from trait | ### Code
```Rust
trait Trait {
fn foo(&'static self) {}
}
impl Trait for bool {
fn foo(&self) {}
}
fn bar() {
let b = false;
b.foo();
}
```
### Current output
```Shell
error[E0597]: `b` does not live long enough
--> src/lib.rs:10:5
|
9 | let b = false;
| - binding `b` declared here
10 | b.foo();
| ^------
| |
| borrowed value does not live long enough
| argument requires that `b` is borrowed for `'static`
11 | }
| - `b` dropped here while still borrowed
```
### Desired output
```Shell
error[E0597]: `b` does not live long enough
--> src/lib.rs:10:5
|
9 | let b = false;
| - binding `b` declared here
10 | b.foo();
| ^------
| |
| borrowed value does not live long enough
| argument requires that `b` is borrowed for `'static`
11 | }
| - `b` dropped here while still borrowed
note: lifetime requirements from the method diverge from the trait declaration
```
### Rationale and extra context
Today I had a compile error that I couldn't understand for a long time, and it'd be nice if the compiler could help a bit.
I had a function that called another function, passing a parameter as-is. And it tricked "lifetime does not live long enough" error. I checked the callee, and the lifetime was correct. I stared at this for a long time, trying to fiddle with changes but none helped.
Only after a long time I realized that this was a trait method, and when I changed the method lifetimes, I changed the impl and not the trait. rustc accepted this just fine, but the constraints were actually the stricter from the trait.
Deciding whether to allow refinements like this to actually work is a T-lang decision, but we can at least tell the users that the lifetimes they see are not the real ones.
### Other cases
_No response_
### Rust Version
```Shell
Checked with both stable and nightly.
```
### Anything else?
_No response_ | A-diagnostics,T-compiler | low | Critical |
2,487,972,887 | godot | Issue: Path3D/PathFollow3D logic | ### Tested versions
- Reproducible in: 4.3 stable Not reproducible in: 4.2.1 stable
### System information
Godot v4.2.1.stable - Windows 10.0.22621 - GLES3 (Compatibility) - AMD Radeon(TM) 610M (Advanced Micro Devices, Inc.; 31.0.21024.2004) - AMD Ryzen 3 7320U with Radeon Graphics (8 Threads)
### Issue description
I have a movement system which involves Path3D and PathFollow3D, it creates a new curve every time a player click to a "movement tile", goes into its position, cleans up curves with every new issued movement. It worked flawlessly in Godot 4.2.1 stable and dragged the player along the path without problem.
However when i upgraded to 4.3 i noticed a minor progression glitch from the players perspective (0.1 millisecond long or so) where the pathing logic got messed up with the project being in the same exact state. It seemed like it throwed a little bit back the player in the curve for no reason because the starting point should be the same where to player is when the order happens.
### Steps to reproduce
- Spam-clicking on the movement object in Godot 4.3 stable should call out the visual bug.
### Minimal reproduction project (MRP)
MRP included with proper instructions in-game. (4.3 stable project)
[movementsystembug.zip](https://github.com/user-attachments/files/16754679/movementsystembug.zip)
| bug,needs testing,regression,topic:3d | low | Critical |
2,487,990,883 | TypeScript | Isolated declarations quick fix results in redundant type arguments when the RHS is a new expression with explicit type arguments | ### Acknowledgement
- [X] I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion.
### Comment
```
// @declaration: true
// @isolatedDeclarations: true
export const s = new Set<string>();
```
After generating and applying a quick-fix, the current resulting code is:
```
export const s: Set<string> = new Set<string>();
```
An ideal fix would remove the redundant type arguments in the RHS expression when adding the same type arguments to the suggested type annotation, resulting in something like:
```
export const s: Set<string> = new Set();
``` | Help Wanted,Possible Improvement | low | Major |
2,488,007,125 | rust | `unused_crate_dependencies` false positive for dev-dependencies on main crate | Steps to reproduce:
```
cargo new mycrate
cd mycrate
cargo add --dev termtree
printf '[lints.rust]\nunused_crate_dependencies = "deny"\n' >> Cargo.toml
cargo build --all-targets
```
Result:
```
error: external crate `termtree` unused in `mycrate`: remove the dependency or add `use termtree as _;`
|
= note: requested on the command line with `-D unused-crate-dependencies`
error: could not compile `mycrate` (bin "mycrate" test) due to 1 previous error
```
dev-dependencies have a variety of uses, and should not be considered as potentially unused. I'd love to see unused dev-dependencies detected as well, but right now they produce false positives.
The reverse is *also* true: rustc will warn about unused non-dev dependencies when compiling tests.
Short-term, perhaps we could provide a way to easily disable this warning entirely for dev-dependencies, and for non-dev dependencies in targets such as tests.
Longer-term, perhaps rustc could feed information about *potentially* unused dependencies back to Cargo in its output, and Cargo could then aggregate the intersection of those dependencies that are *completely* unused.
Meanwhile, however, these false positives make it difficult to use `unused_crate_dependencies` in any project that has dev-dependencies or tests. | A-lints,A-diagnostics,T-compiler,T-cargo,L-unused_crate_dependencies | low | Critical |
2,488,022,852 | pytorch | torch._assert does not work with torch.export | ### 🐛 Describe the bug
`torch._assert` does not seem to work with torch.export. For example the following script:
```
import torch
from torch.export import export
class M(torch.nn.Module):
def __init__(self):
super().__init__()
def forward(self, x):
torch._assert(x.min() >= 0, "x must be positive")
return x
exported_program: torch.export.ExportedProgram = export(
M(),
args=tuple(torch.ones(1, 32, 64)),
)
out = exported_program.module()(tuple(torch.ones(1, 32, 64)))
```
Leads to this error (`Tried to use data-dependent value in the subsequent computation`):
```
File "/opt/venv/lib/python3.11/site-packages/torch/_dynamo/convert_frame.py", line 400, in _convert_frame_assert
return _compile(
^^^^^^^^^
File "/usr/lib/python3.11/contextlib.py", line 81, in inner
return func(*args, **kwds)
^^^^^^^^^^^^^^^^^^^
File "/opt/venv/lib/python3.11/site-packages/torch/_dynamo/convert_frame.py", line 676, in _compile
guarded_code = compile_inner(code, one_graph, hooks, transform)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/venv/lib/python3.11/site-packages/torch/_dynamo/utils.py", line 262, in time_wrapper
r = func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/venv/lib/python3.11/site-packages/torch/_dynamo/convert_frame.py", line 535, in compile_inner
out_code = transform_code_object(code, transform)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/venv/lib/python3.11/site-packages/torch/_dynamo/bytecode_transformation.py", line 1036, in transform_code_object
transformations(instructions, code_options)
File "/opt/venv/lib/python3.11/site-packages/torch/_dynamo/convert_frame.py", line 165, in _fn
return fn(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^
File "/opt/venv/lib/python3.11/site-packages/torch/_dynamo/convert_frame.py", line 500, in transform
tracer.run()
File "/opt/venv/lib/python3.11/site-packages/torch/_dynamo/symbolic_convert.py", line 2149, in run
super().run()
File "/opt/venv/lib/python3.11/site-packages/torch/_dynamo/symbolic_convert.py", line 810, in run
and self.step()
^^^^^^^^^^^
File "/opt/venv/lib/python3.11/site-packages/torch/_dynamo/symbolic_convert.py", line 773, in step
getattr(self, inst.opname)(inst)
File "/opt/venv/lib/python3.11/site-packages/torch/_dynamo/symbolic_convert.py", line 489, in wrapper
return inner_fn(self, inst)
^^^^^^^^^^^^^^^^^^^^
File "/opt/venv/lib/python3.11/site-packages/torch/_dynamo/symbolic_convert.py", line 1802, in CALL
self.call_function(fn, args, kwargs)
File "/opt/venv/lib/python3.11/site-packages/torch/_dynamo/symbolic_convert.py", line 674, in call_function
self.push(fn.call_function(self, args, kwargs))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/venv/lib/python3.11/site-packages/torch/_dynamo/variables/torch.py", line 679, in call_function
tensor_variable = wrap_fx_proxy(
^^^^^^^^^^^^^^
File "/opt/venv/lib/python3.11/site-packages/torch/_dynamo/variables/builder.py", line 1330, in wrap_fx_proxy
return wrap_fx_proxy_cls(target_cls=TensorVariable, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/venv/lib/python3.11/site-packages/torch/_dynamo/variables/builder.py", line 1415, in wrap_fx_proxy_cls
example_value = get_fake_value(proxy.node, tx, allow_non_graph_fake=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/venv/lib/python3.11/site-packages/torch/_dynamo/utils.py", line 1704, in get_fake_value
raise UserError( # noqa: TRY200
torch._dynamo.exc.UserError: Tried to use data-dependent value in the subsequent computation. This can happen when we encounter unbounded dynamic value that is unknown during tracing time. You will need to explicitly give hint to the compiler. Please take a look at constrain_as_value OR constrain_as_size APIs. Could not guard on data-dependent expression Eq(u0, 1) (unhinted: Eq(u0, 1)). (Size-like symbols: none)
Potential framework code culprit (scroll up for full backtrace):
File "/opt/venv/lib/python3.11/site-packages/torch/_dynamo/utils.py", line 1764, in run_node
return node.target(*args, **kwargs)
For more information, run with TORCH_LOGS="dynamic"
For extended logs when we create symbols, also add TORCHDYNAMO_EXTENDED_DEBUG_CREATE_SYMBOL="u0"
If you suspect the guard was triggered from C++, add TORCHDYNAMO_EXTENDED_DEBUG_CPP=1
For more debugging help, see https://docs.google.com/document/d/1HSuTTVvYH1pTew89Rtpeu84Ht3nQEFTYhAX3Ypa_xJs/edit?usp=sharing
User Stack (most recent call last):
(snipped, see stack below for prefix)
File "/workspaces/models/src/scripts/export/test_assert.py", line 10, in forward
torch._assert(x.min() >= 0, "x must be positive")
For more information about this error, see: https://pytorch.org/docs/main/generated/exportdb/index.html#constrain-as-size-example
from user code:
File "/workspaces/models/src/scripts/export/test_assert.py", line 10, in forward
torch._assert(x.min() >= 0, "x must be positive")
Set TORCH_LOGS="+dynamo" and TORCHDYNAMO_VERBOSE=1 for more information
```
### Versions
Collecting environment information...
PyTorch version: 2.3.1+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A
OS: Ubuntu 22.04.4 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: Could not collect
CMake version: Could not collect
Libc version: glibc-2.35
Python version: 3.11.9 (main, Apr 6 2024, 17:59:24) [GCC 11.4.0] (64-bit runtime)
Python platform: Linux-6.5.0-1025-oracle-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: Could not collect
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: GPU 0: NVIDIA A100-SXM4-80GB
Nvidia driver version: 535.183.01
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 48 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 256
On-line CPU(s) list: 0-254
Off-line CPU(s) list: 255
Vendor ID: AuthenticAMD
Model name: AMD EPYC 7J13 64-Core Processor
CPU family: 25
Model: 1
Thread(s) per core: 2
Core(s) per socket: 64
Socket(s): 2
Stepping: 1
Frequency boost: enabled
CPU max MHz: 3673.0950
CPU min MHz: 0.0000
BogoMIPS: 4900.16
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb cat_l3 cdp_l3 invpcid_single hw_pstate ssbd mba ibrs ibpb stibp vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local clzero irperf xsaveerptr rdpru wbnoinvd amd_ppin brs arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif v_spec_ctrl umip pku ospke vaes vpclmulqdq rdpid overflow_recov succor smca fsrm
Virtualization: AMD-V
L1d cache: 4 MiB (128 instances)
L1i cache: 4 MiB (128 instances)
L2 cache: 64 MiB (128 instances)
L3 cache: 512 MiB (16 instances)
NUMA node(s): 8
NUMA node0 CPU(s): 0-15,128-143
NUMA node1 CPU(s): 16-31,144-159
NUMA node2 CPU(s): 32-47,160-175
NUMA node3 CPU(s): 48-63,176-191
NUMA node4 CPU(s): 64-79,192-207
NUMA node5 CPU(s): 80-95,208-223
NUMA node6 CPU(s): 96-111,224-239
NUMA node7 CPU(s): 112-127,240-254
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Vulnerable
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Vulnerable: __user pointer sanitization and usercopy barriers only; no swapgs barriers
Vulnerability Spectre v2: Vulnerable; IBPB: disabled; STIBP: disabled; PBRSB-eIBRS: Not affected; BHI: Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected
Versions of relevant libraries:
[pip3] mypy==1.9.0
[pip3] mypy-extensions==1.0.0
[pip3] numpy==1.26.4
[pip3] pytorch-lightning==2.2.1
[pip3] torch==2.3.1
[pip3] torchmetrics==1.3.2
[pip3] triton==2.3.1
[conda] Could not collect
cc @ezyang @chauhang @penguinwu @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @angelayi @suo @ydwu4 | triaged,oncall: pt2,oncall: export | low | Critical |
2,488,023,457 | pytorch | MiniCPM-V 2.6 transformer model returns nonsense tokens when running on MPS backend vs CPU backend. | ### 🐛 Describe the bug
When I run MiniCPM-v2.6 model on my MacBook, the outputs look fine when using CPU backend, but they tend to contain nonsense English tokens or foreign language tokens when running on MPS backend. Here's the code to reproduce the issue:
```python
import requests
import torch
from PIL import Image
from transformers import AutoModel, AutoTokenizer
model = AutoModel.from_pretrained('openbmb/MiniCPM-V-2_6', trust_remote_code=True,
attn_implementation='sdpa', torch_dtype=torch.bfloat16)
model = model.eval().to("mps")
tokenizer = AutoTokenizer.from_pretrained('openbmb/MiniCPM-V-2_6', trust_remote_code=True)
url = "https://huggingface.co/datasets/huggingface/documentation-images/resolve/main/transformers/tasks/car.jpg?download=true"
image = Image.open(requests.get(url, stream=True).raw).convert('RGB')
question = 'What is in the image?'
msgs = [{'role': 'user', 'content': [image, question]}]
res = model.chat(
image=None,
msgs=msgs,
tokenizer=tokenizer
)
print(res)
```
Here are some example generations with MPS backend:
```
SRúite, aá.
우리 이미지에는 자동차와 건물이 있습니다.
可能です。
ῶς ἐγὼ τὴν εἰκώνα προσεβλέψω.
OTOS
```
Here are example generations with CPU backend for the exact same input.
```
The image features a vintage car, specifically a turquoise-colored Volkswagen Beetle, parked in front of a yellow building with wooden doors.
The image features a vintage turquoise-colored car parked on the side of a street. The car has classic design elements, such as round headlights and chrome accents. Behind the car, there's a yellow wall with two wooden doors.
The image features a vintage turquoise-colored car parked on a paved street in front of an old building with yellow walls and wooden doors.
```
### Versions
```
Collecting environment information...
PyTorch version: 2.5.0.dev20240826
Is debug build: False
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A
OS: macOS 14.5 (arm64)
GCC version: Could not collect
Clang version: 15.0.0 (clang-1500.3.9.4)
CMake version: Could not collect
Libc version: N/A
Python version: 3.12.4 | packaged by Anaconda, Inc. | (main, Jun 18 2024, 10:07:17) [Clang 14.0.6 ] (64-bit runtime)
Python platform: macOS-14.5-arm64-arm-64bit
Is CUDA available: False
CUDA runtime version: No CUDA
CUDA_MODULE_LOADING set to: N/A
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Apple M3 Max
Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] torch==2.4.0
[pip3] torchaudio==2.4.0.dev20240826
[pip3] torchvision==0.20.0.dev20240826
[conda] numpy 1.26.4 py312h7f4fdc5_0
[conda] numpy-base 1.26.4 py312he047099_0
[conda] pytorch 2.5.0.dev20240826 py3.12_0 pytorch-nightly
[conda] torch 2.4.0 pypi_0 pypi
[conda] torchaudio 2.4.0.dev20240826 py312_cpu pytorch-nightly
[conda] torchvision 0.20.0.dev20240826 py312_cpu pytorch-nightly
```
cc @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen | triaged,module: correctness (silent),module: mps | low | Critical |
2,488,028,530 | pytorch | Triton/Inductor Gather Prologue Fusion Issues | ### 🐛 Describe the bug
I have a mostly ready PR implementing prologue fusion at https://github.com/pytorch/pytorch/pull/134532/ (although not yet ready for review).
One of the use cases @Chillee pointed out was fusing a gather into a MM. For
```Python
torch.set_default_device("cuda)
x = torch.rand([2048, 2048], dtype=torch.float16)
y = torch.rand([2048, 2048], dtype=torch.float16)
index = torch.randperm(2048, device="cuda")
def foo(x, y, index):
return x[index] @ y
```
On an a100, When this is run on fp32, everything works succesfully. However, when run on fp16, I get the following error:
> python: /home/eellison/triton/third_party/nvidia/lib/TritonNVIDIAGPUToLLVM/LoadStoreOpToLLVM.cpp:852: virtual mlir::LogicalResult {anonymous}::AsyncCopyGlobalToLocalOpConversion::matchAndRewrite(mlir::triton::gpu::AsyncCopyGlobalToLocalOp, mlir::ConvertOpToLLVMPattern<mlir::triton::gpu::AsyncCopyGlobalToLocalOp>::OpAdaptor, mlir::ConversionPatternRewriter&) const: Assertion `byteWidth == 16 || byteWidth == 8 || byteWidth == 4' failed.
For this [generated kernel](https://gist.github.com/eellison/ca959f32ff25bb9afab276b2b49d36a4).
The main loop of the mm kernel is:
```Python
for k_idx in range(0, tl.cdiv(K, BLOCK_K)):
a_k_idx_vals = offs_k[None, :] + (k_idx * BLOCK_K)
idx_m = offs_a_m[:, None]
idx_n = a_k_idx_vals
xindex = idx_n + (2048*idx_m)
tmp0 = tl.load(in_ptr1 + (tl.broadcast_to(idx_m, xindex.shape)), None, eviction_policy='evict_last')
tmp1 = tl.full(xindex.shape, 2048, tl.int32)
tmp2 = tmp0 + tmp1
tmp3 = tmp0 < 0
tmp4 = tl.where(tmp3, tmp2, tmp0)
tl.device_assert((0 <= tl.broadcast_to(tmp4, xindex.shape)) & (tl.broadcast_to(tmp4, xindex.shape) < 2048), "index out of bounds: 0 <= tl.broadcast_to(tmp4, xindex.shape) < 2048")
tmp6 = tl.load(in_ptr2 + (tl.broadcast_to(idx_n + (2048*tmp4), xindex.shape)), None, eviction_policy='evict_last')
a = tmp6.to(tl.float16)
B_ptr = B + ((offs_k[:, None] + (k_idx * BLOCK_K)) * stride_bk + offs_b_n[None, :] * stride_bn)
b = tl.load(B_ptr)
acc += tl.dot(a, b, allow_tf32=ALLOW_TF32)
```
In this case, the `tmp0` load is loop invariant. When you [update the kernel](https://gist.github.com/eellison/885fede92f970060ef694d1eb0da5757) to hoist the load, it runs successfully. It also gives a 14% speedup over the max-autotune-no-cudagraphs without prologue fusion and 25% over eager.
So there are two issues here:
1) the codegen failure
2) Can triton improve its loop invariant code motion to hoist this load ? Note, we benchmark this prologue fusion, so in the worst case where we can't prove a hoist we would just not fuse instead of generating a terrible mm.
While it is doable for inductor to generate the code hoisted, this is code generated through triton templates. Ideally I would be to keep the single per buffer current prologue fusion api of `{{load_input("A", "a", ("idx_m", "idx_n")}}` instead of something more tedious that involved using apis for the initialization of indices.
Not sure I file here or triton.. doing here for now.
cc @ezyang @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @bertmaher @int3 @davidberard98 @nmacchioni @embg @peterbell10 @aakhundov @htyu
### Versions
master | triaged,oncall: pt2,module: inductor,upstream triton | low | Critical |
2,488,124,404 | PowerToys | The service feature of Borderless Mouse and the shared pasteboard do not work at the same time. | ### Microsoft PowerToys version
0.83.0
### Installation method
GitHub, PowerToys auto-update
### Running as admin
Yes
### Area(s) with issue?
Mouse Without Borders
### Steps to reproduce
When the service feature is enabled, the shared clipboard feature is invalidated.
### ✔️ Expected Behavior
_No response_
### ❌ Actual Behavior
_No response_
### Other Software
_No response_ | Issue-Bug,Needs-Triage | low | Minor |
2,488,132,335 | vscode | Line numbers for notebook diff view | Diff views are often used for peers to review their code. Since our current diff view does not include an execution count or line numbers, if two coworkers are discussing changes in a notebook it can be difficult to index what piece of code/output they'd like to review.
Originally filed here https://github.com/microsoft/vscode/issues/136141 | feature-request,notebook-diff | low | Minor |
2,488,133,114 | vscode | Bug on Editor Sticky Scroll | I have a really text file with really big sections of text. When I have editor sticky scroll on it jumps and causes the text to disappear as I scroll. I have a screen recording which would be helpful but has potentially confidential info, if you DM me I can send it to you. Thanks! | bug,info-needed,editor-sticky-scroll | low | Critical |
2,488,210,081 | godot | RichTextLabel mouse_exited() event fires by Context Menu when control is Right Clicked | ### Tested versions
v4.3.stable.official [77dcf97d8]
### System information
Linux Kubuntu 24.04 KDE Plasma Version: 5.27.11 KDE Frameworks Version: 5.115.0 Qt Version: 5.15.13 Kernel Version: 6.8.0-39-generic (64-bit) Graphics Platform: X11 Processors: 16 × 12th Gen Intel® Core™ i7-1260P Memory: 15.3 GiB of RAM
### Issue description
When enabled, the Context Menu of **RichTextLabel** fires a mouse_exited event when you right click on the label. In addition, mousing over the Context Menu keeps firing mouse_exited/mouse_entered events. This interferes with the ability to use mouse_exited() with Context Menu at the same time.
However no such event is fired when Context Menu is disabled. Also mouse Left Click has no effect.
Here is the code of the single scene above:
```gdscript
extends Control
func _ready():
# Checked context Menu
$RichTextLabel.mouse_exited.connect(func():
$RichTextLabel.add_theme_color_override("default_color",Color.WHITE)
print(5)
)
$RichTextLabel.mouse_entered.connect(func():
$RichTextLabel.add_theme_color_override("default_color",Color.RED)
print(6)
)
# Unchecked Context Menu
$RichTextLabel2.mouse_exited.connect(func():
$RichTextLabel2.add_theme_color_override("default_color",Color.WHITE)
print(7)
)
$RichTextLabel2.mouse_entered.connect(func():
$RichTextLabel2.add_theme_color_override("default_color",Color.RED)
print(8)
)
```
### Steps to reproduce
Add a **RichtextLabel** control to a scene with some text.
Enable the Context Menu.
Add mouse_exited event as above.
Right click and event fires even though you did not exit the label.
Mouse over Context Menu and the events keep firing.
### Minimal reproduction project (MRP)
Attached is the above scene to demo the issue. Please add to an empty project if you wish to try it.
[node_2d.zip](https://github.com/user-attachments/files/16756247/node_2d.zip)
| discussion,topic:gui | low | Minor |
2,488,254,711 | TypeScript | Remapped property names has wrong completion, error messages and code actions (snippets) | ### 🔎 Search Terms
"remapped property", "mapped types"
### 🕗 Version & Regression Information
- This changed between versions 4.9.5 and 5.0.4
### ⏯ Playground Link
https://www.typescriptlang.org/play/?ts=5.7.0-dev.20240826#code/C4TwDgpgBAMglgZ2BAdhATgFQgWzAGwENkAeTAGigGUoIAPZFAEwSiXThQHNKBJWhqhZtgHblAC8UAEQASAN4BGAL7SAfJKjyAUFD0BtANJROUANYQQAewBmUTFEKtj9RsPacuuvT6gB+agE3VgADBU4bDCgAMWUFXjj5CKiAJWUQ-ygw+ViFQ0S0jIAuKGMSwwBdb18oEoAKfERGDHqwQhB8K0ImEswjCoBKSQ0ANys4JiGJUfGmAG5tZQXQSFgm1ABBAGNgOCsUQgAjfAgSAFENKXgkVAxsPCJSM8ppbqYAKmvm9GkoAB8ZOhcFYRhBPus0D8Xu91MtwNAAMKNLZmM6glDAKgAVzAYCs6GAmi+mx2ewOx1O8igSLgKJKAHIEFYcBAALRbZFmVkQdHAVltDpdJj0qDKNQLbRbfZIKCEqR1AYlGkotGoTE4vEE4ZaapQIHALHoFA6mo+AD0ZqgvGNmBoAAUiCAuOgrFjmLKABYYaCIKAoKxsFBwXEQYCsOr4q1QJj7emEsz+gDuUA9VmTwADqCOJ09uAGut8FqghyxhNMIwQUqY0GAXqBJlYhEDwcghJCb2VZmJkIaEIwAwydRWEErHDAwAAdAgsVwuCPJxynAgALK4Q4YKhBkNhidZik9WXoLEQfOmvRFxMe2kekwoBAYMNZTu9m6QoZU2QABlFGU4N26UC2FkHact2GAvt875QF+P66soixAA
### 💻 Code
```ts
type ListenerTemplate<T, S extends string, I extends string = "${1}"> = {
[K in keyof T as K extends string
? S extends `${infer F}${I}${infer R}` ? `${F}${K}${R}` : K : K]
: (listener: (payload: T[K]) => void) => void;
};
type ListenActionable<E> = ListenerTemplate<E, "add*Listener" | "remove*Listener", "*">;
type ClickEventSupport = ListenActionable<{ Click: 'some-click-event-payload' }>;
const t = (): ClickEventSupport => {
return {
// In TS Playground there is no snippets (or I don't know how to enable them)
// but in vscode there is a snippet `addClickListener(listener)` (typescript.suggest.classMemberSnippets.enabled: true)
// which inserts `Click(listener) { $0 }` instead of `addClickListener(listener) { $0 }`
}
}
```
### 🙁 Actual behavior
Completion with snippets is generating methods which are not in the interface:
```ts
type ListenerTemplate<T, S extends string, I extends string = "${1}"> = {
[K in keyof T as K extends string
? S extends `${infer F}${I}${infer R}` ? `${F}${K}${R}` : K : K]
: (listener: (payload: T[K]) => void) => void;
};
type ListenActionable<E> = ListenerTemplate<E, "add*Listener" | "remove*Listener", "*">;
type ClickEventSupport = ListenActionable<{ Click: 'some-click-event-payload' }>;
const t = (): ClickEventSupport => {
return {
Click(listener) {
},
}
}
```
### 🙂 Expected behavior
I expect completion to provide working snippets.
```ts
type ListenerTemplate<T, S extends string, I extends string = "${1}"> = {
[K in keyof T as K extends string
? S extends `${infer F}${I}${infer R}` ? `${F}${K}${R}` : K : K]
: (listener: (payload: T[K]) => void) => void;
};
type ListenActionable<E> = ListenerTemplate<E, "add*Listener" | "remove*Listener", "*">;
type ClickEventSupport = ListenActionable<{ Click: 'some-click-event-payload' }>;
const t = (): ClickEventSupport => {
return {
addClickListener(listener) {
},
}
}
```
### Additional information about the issue
I already reported a related [bug](https://github.com/microsoft/TypeScript/issues/54694), it was fixed partially: only code action for implement interface was fixed.
I plan to fix this bug by myself, MR is in progress. | Bug,Help Wanted,Domain: Completion Lists | low | Critical |
2,488,366,999 | ui | [feat]: Add new variant to toast component | ### Feature description
The toast component has 2 variants: "default" and "destructive".
I would like to a new variant: "success", as it would be the most common variant to use with toast.
### Affected component/components
Toast
### Additional Context
_No response_
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues and PRs | area: request | low | Minor |
2,488,374,547 | ui | Docs: Missing installation script | ### Feature description
the installation section for [`Form`](https://ui.shadcn.com/docs/components/form) component has script for installing `form`.
But in the example, `<Input>` is being used, so it would require to add install script for `input` below.
### Affected component/components
Form
### Additional Context
Additional details here...
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues and PRs | area: request | low | Minor |
2,488,388,698 | godot | Using -rigid import hint on a blender model with an unapplied scale changes scale of rigidbody nodes directly, causing issues. | ### Tested versions
- Found in 4.3.stable
### System information
Godot v4.3.stable - EndeavourOS #1 SMP PREEMPT_DYNAMIC Mon, 19 Aug 2024 17:02:39 +0000 - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 7700S (RADV NAVI33) - AMD Ryzen 9 7940HS w/ Radeon 780M Graphics (16 Threads)
### Issue description
When importing a .blend file that has objects in it with unapplied scales, it looks like those scales get copied to the rigidbody objects created by the `-rigid` import hint. Godot actually shows a warning that this will cause issues if you open the model in the scene editor:
Although the model looks correct in the editor, when the game is run the model will have it's scale reset. In the demo project attached you can see this causes the bottle to become massive.
In editor:
In game:
I think this may also happen to other file formats, but I don't have as clean as an example to share.
I don't know what the proper fix for this should be. I think applying transformations in the importer would break animations, based on the warning in blender's FBX exporter. Maybe Godot should apply the scaling to the mesh and collision shape instead of the Rigidbody?
### Steps to reproduce
1. Scale an object in Blender while in Object Mode, then make sure the name of the object ends with `-rigid`
2. Create a Godot Scene with that object in it
3. Observe the scale change between the editor and runtime, or open the model's scene and see the warning.
### Minimal reproduction project (MRP)
[blendscale MRP.zip](https://github.com/user-attachments/files/16757444/blendscale.MRP.zip)
| bug,topic:import | low | Minor |
2,488,407,053 | ant-design | TreeSelect 组件使用labelInValue后，希望把选中的属性全部暴露出去，不然只能获取到label、value的值 | ### What problem does this feature solve?
能满足复杂的选择判断场景
### What does the proposed API look like?
增加返回字段
<!-- generated by ant-design-issue-helper. DO NOT REMOVE --> | 💡 Feature Request,Inactive | low | Minor |
2,488,416,292 | flutter | Keyboard, Linux and MacOS, dead keys, characters are wrong | ### Steps to reproduce
1. Run the sample code on Linux or MacOS
2. Switch to French input method
3. Press `[`, then press `e`
### Expected results
The second event character should be `ê`, but it's not.
### Actual results
See the screenshot.
Results from https://github.com/flutter/flutter/issues/154055#issuecomment-2309898881
<details open><summary>Output logs on Linux</summary>
```console
flutter: [KeyDownEvent#45f66(physicalKey: PhysicalKeyboardKey#5b142(usbHidUsage: "0x00070053", debugName: "Num Lock"), logicalKey: LogicalKeyboardKey#f3b7b(keyId: "0x10000010a", keyLabel: "Num Lock", debugName: "Num Lock"), character: null, timeStamp: 0:17:03.718000, synthesized)]
flutter: [KeyDownEvent#45f66(physicalKey: PhysicalKeyboardKey#5b142(usbHidUsage: "0x00070053", debugName: "Num Lock"), logicalKey: LogicalKeyboardKey#f3b7b(keyId: "0x10000010a", keyLabel: "Num Lock", debugName: "Num Lock"), character: null, timeStamp: 0:17:03.718000, synthesized), KeyDownEvent#f9675(physicalKey: PhysicalKeyboardKey#f51de(usbHidUsage: "0x0007002f", debugName: "Bracket Left"), logicalKey: LogicalKeyboardKey#01bcb(keyId: "0x0000005b", keyLabel: "[", debugName: "Bracket Left"), character: null, timeStamp: 0:17:03.718000)]
flutter: [KeyDownEvent#45f66(physicalKey: PhysicalKeyboardKey#5b142(usbHidUsage: "0x00070053", debugName: "Num Lock"), logicalKey: LogicalKeyboardKey#f3b7b(keyId: "0x10000010a", keyLabel: "Num Lock", debugName: "Num Lock"), character: null, timeStamp: 0:17:03.718000, synthesized), KeyDownEvent#f9675(physicalKey: PhysicalKeyboardKey#f51de(usbHidUsage: "0x0007002f", debugName: "Bracket Left"), logicalKey: LogicalKeyboardKey#01bcb(keyId: "0x0000005b", keyLabel: "[", debugName: "Bracket Left"), character: null, timeStamp: 0:17:03.718000), KeyUpEvent#33f66(physicalKey: PhysicalKeyboardKey#f51de(usbHidUsage: "0x0007002f", debugName: "Bracket Left"), logicalKey: LogicalKeyboardKey#01bcb(keyId: "0x0000005b", keyLabel: "[", debugName: "Bracket Left"), character: null, timeStamp: 0:17:03.862000)]
flutter: [KeyDownEvent#45f66(physicalKey: PhysicalKeyboardKey#5b142(usbHidUsage: "0x00070053", debugName: "Num Lock"), logicalKey: LogicalKeyboardKey#f3b7b(keyId: "0x10000010a", keyLabel: "Num Lock", debugName: "Num Lock"), character: null, timeStamp: 0:17:03.718000, synthesized), KeyDownEvent#f9675(physicalKey: PhysicalKeyboardKey#f51de(usbHidUsage: "0x0007002f", debugName: "Bracket Left"), logicalKey: LogicalKeyboardKey#01bcb(keyId: "0x0000005b", keyLabel: "[", debugName: "Bracket Left"), character: null, timeStamp: 0:17:03.718000), KeyUpEvent#33f66(physicalKey: PhysicalKeyboardKey#f51de(usbHidUsage: "0x0007002f", debugName: "Bracket Left"), logicalKey: LogicalKeyboardKey#01bcb(keyId: "0x0000005b", keyLabel: "[", debugName: "Bracket Left"), character: null, timeStamp: 0:17:03.862000), KeyDownEvent#49e1f(physicalKey: PhysicalKeyboardKey#86a89(usbHidUsage: "0x00070008", debugName: "Key E"), logicalKey: LogicalKeyboardKey#1e0f5(keyId: "0x00000065", keyLabel: "E", debugName: "Key E"), character: "e", timeStamp: 0:17:03.981000)]
flutter: [KeyDownEvent#45f66(physicalKey: PhysicalKeyboardKey#5b142(usbHidUsage: "0x00070053", debugName: "Num Lock"), logicalKey: LogicalKeyboardKey#f3b7b(keyId: "0x10000010a", keyLabel: "Num Lock", debugName: "Num Lock"), character: null, timeStamp: 0:17:03.718000, synthesized), KeyDownEvent#f9675(physicalKey: PhysicalKeyboardKey#f51de(usbHidUsage: "0x0007002f", debugName: "Bracket Left"), logicalKey: LogicalKeyboardKey#01bcb(keyId: "0x0000005b", keyLabel: "[", debugName: "Bracket Left"), character: null, timeStamp: 0:17:03.718000), KeyUpEvent#33f66(physicalKey: PhysicalKeyboardKey#f51de(usbHidUsage: "0x0007002f", debugName: "Bracket Left"), logicalKey: LogicalKeyboardKey#01bcb(keyId: "0x0000005b", keyLabel: "[", debugName: "Bracket Left"), character: null, timeStamp: 0:17:03.862000), KeyDownEvent#49e1f(physicalKey: PhysicalKeyboardKey#86a89(usbHidUsage: "0x00070008", debugName: "Key E"), logicalKey: LogicalKeyboardKey#1e0f5(keyId: "0x00000065", keyLabel: "E", debugName: "Key E"), character: "e", timeStamp: 0:17:03.981000), KeyUpEvent#12aca(physicalKey: PhysicalKeyboardKey#86a89(usbHidUsage: "0x00070008", debugName: "Key E"), logicalKey: LogicalKeyboardKey#1e0f5(keyId: "0x00000065", keyLabel: "E", debugName: "Key E"), character: null, timeStamp: 0:17:04.154000)]
```
<details open><summary>Output logs on MacOS</summary>
```console
flutter: [KeyDownEvent#c91d2(physicalKey: PhysicalKeyboardKey#f51de(usbHidUsage: "0x0007002f", debugName: "Bracket Left"), logicalKey: LogicalKeyboardKey#01bcb(keyId: "0x0000005b", keyLabel: "[", debugName: "Bracket Left"), character: null, timeStamp: 27:28:17.865322)]
flutter: [KeyDownEvent#c91d2(physicalKey: PhysicalKeyboardKey#f51de(usbHidUsage: "0x0007002f", debugName: "Bracket Left"), logicalKey: LogicalKeyboardKey#01bcb(keyId: "0x0000005b", keyLabel: "[", debugName: "Bracket Left"), character: null, timeStamp: 27:28:17.865322), KeyUpEvent#478a8(physicalKey: PhysicalKeyboardKey#f51de(usbHidUsage: "0x0007002f", debugName: "Bracket Left"), logicalKey: LogicalKeyboardKey#01bcb(keyId: "0x0000005b", keyLabel: "[", debugName: "Bracket Left"), character: null, timeStamp: 27:28:17.966194)]
flutter: [KeyDownEvent#c91d2(physicalKey: PhysicalKeyboardKey#f51de(usbHidUsage: "0x0007002f", debugName: "Bracket Left"), logicalKey: LogicalKeyboardKey#01bcb(keyId: "0x0000005b", keyLabel: "[", debugName: "Bracket Left"), character: null, timeStamp: 27:28:17.865322), KeyUpEvent#478a8(physicalKey: PhysicalKeyboardKey#f51de(usbHidUsage: "0x0007002f", debugName: "Bracket Left"), logicalKey: LogicalKeyboardKey#01bcb(keyId: "0x0000005b", keyLabel: "[", debugName: "Bracket Left"), character: null, timeStamp: 27:28:17.966194), KeyDownEvent#4f56f(physicalKey: PhysicalKeyboardKey#86a89(usbHidUsage: "0x00070008", debugName: "Key E"), logicalKey: LogicalKeyboardKey#1e0f5(keyId: "0x00000065", keyLabel: "E", debugName: "Key E"), character: "e", timeStamp: 27:28:18.044895)]
flutter: [KeyDownEvent#c91d2(physicalKey: PhysicalKeyboardKey#f51de(usbHidUsage: "0x0007002f", debugName: "Bracket Left"), logicalKey: LogicalKeyboardKey#01bcb(keyId: "0x0000005b", keyLabel: "[", debugName: "Bracket Left"), character: null, timeStamp: 27:28:17.865322), KeyUpEvent#478a8(physicalKey: PhysicalKeyboardKey#f51de(usbHidUsage: "0x0007002f", debugName: "Bracket Left"), logicalKey: LogicalKeyboardKey#01bcb(keyId: "0x0000005b", keyLabel: "[", debugName: "Bracket Left"), character: null, timeStamp: 27:28:17.966194), KeyDownEvent#4f56f(physicalKey: PhysicalKeyboardKey#86a89(usbHidUsage: "0x00070008", debugName: "Key E"), logicalKey: LogicalKeyboardKey#1e0f5(keyId: "0x00000065", keyLabel: "E", debugName: "Key E"), character: "e", timeStamp: 27:28:18.044895), KeyUpEvent#7582e(physicalKey: PhysicalKeyboardKey#86a89(usbHidUsage: "0x00070008", debugName: "Key E"), logicalKey: LogicalKeyboardKey#1e0f5(keyId: "0x00000065", keyLabel: "E", debugName: "Key E"), character: null, timeStamp: 27:28:18.202908)]
```
### Code sample
<details open><summary>Code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(MyApp());
}
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Keyboard Event Demo',
theme: ThemeData(
primarySwatch: Colors.blue,
),
home: const KeyboardEventPage(),
);
}
}
class KeyboardEventPage extends StatefulWidget {
const KeyboardEventPage({super.key});
@override
_KeyboardEventPageState createState() => _KeyboardEventPageState();
}
class _KeyboardEventPageState extends State<KeyboardEventPage> {
final List<String> _lastKeyEvents = [];
final FocusNode _focusNode = FocusNode();
@override
Widget build(BuildContext context) {
final child = Scaffold(
appBar: AppBar(
title: const Text('Keyboard Event Demo'),
),
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
const Text(
'Press any key:',
style: TextStyle(fontSize: 20),
),
const SizedBox(height: 20),
for (final keyEvent in _lastKeyEvents)
Text(
keyEvent,
style: const TextStyle(fontSize: 16),
),
],
),
),
);
return FocusScope(
autofocus: true,
child: Focus(
autofocus: true,
canRequestFocus: true,
focusNode: _focusNode,
onKeyEvent: (node, event) {
setState(() {
_lastKeyEvents.add(event.toString());
if (_lastKeyEvents.length > 10) {
_lastKeyEvents.removeAt(0);
}
});
return KeyEventResult.handled;
},
child: child,
),
);
}
}
```
</details>
### Screenshots or Video
<details open>
<summary>Screenshots / Video demonstration</summary>
</details>
### Logs
<details open><summary>Logs</summary>
```console
[Paste your logs here]
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[✓] Flutter (Channel stable, 3.24.1, on Ubuntu 22.04.4 LTS 6.8.0-40-generic,
locale en_US.UTF-8)
• Flutter version 3.24.1 on channel stable at
/home/username/workspace/flutter/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 5874a72aa4 (6 days ago), 2024-08-20 16:46:00 -0500
• Engine revision c9b9d5780d
• Dart version 3.5.1
• DevTools version 2.37.2
[✗] Android toolchain - develop for Android devices
✗ Unable to locate Android SDK.
Install Android Studio from:
https://developer.android.com/studio/index.html
On first launch it will assist you in installing the Android SDK
components.
(or visit https://flutter.dev/to/linux-android-setup for detailed
instructions).
If the Android SDK has been installed to a custom location, please use
`flutter config --android-sdk` to update to that location.
[✓] Chrome - develop for the web
• Chrome at google-chrome
[✓] Linux toolchain - develop for Linux desktop
• Ubuntu clang version 14.0.0-1ubuntu1.1
• cmake version 3.22.1
• ninja version 1.10.1
• pkg-config version 0.29.2
[!] Android Studio (not installed)
• Android Studio not found; download from
https://developer.android.com/studio/index.html
(or visit https://flutter.dev/to/linux-android-setup for detailed
instructions).
[✓] Connected device (2 available)
• Linux (desktop) • linux • linux-x64 • Ubuntu 22.04.4 LTS
6.8.0-40-generic
• Chrome (web) • chrome • web-javascript • Google Chrome 128.0.6613.84
[!] Network resources
✗ A network error occurred while checking "https://maven.google.com/":
Connection timed out
! Doctor found issues in 3 categories.
```
</details>
| a: text input,framework,platform-mac,a: internationalization,platform-linux,has reproducible steps,P2,team-framework,triaged-framework,fyi-text-input,found in release: 3.24,found in release: 3.25 | low | Critical |
2,488,436,434 | vscode | SCM - show repositories view by default with multiple repositories | Opening a multi root workspace with 3 repositories, here is my default UI in SCM:
I find this quite a complex UI esp. since buttons repeat N times.
I would suggest to show the repositories view as soon as I deal with multiple and only select the first by default for a much calmer experience:
//cc @daviddossett @joaomoreno | ux,scm,under-discussion | low | Minor |
2,488,482,082 | vscode | Not fully clear why `export type TextSearchResultNew = TextSearchMatchNew | TextSearchContextNew;` | Testing #226671
A search result can be either of the 2 types, but I find that a bit strange to operate with. Why wouldn't the context not be referenced from the match? What is the order? Would I first get a context for the line above, then a match and then the line below? | search,under-discussion | low | Minor |
2,488,498,962 | vscode | The find widget should be more like the find widget in the terminal | Testing #226676
- offer match count (e.g. 7 of 13)
- offer up down buttons to move to the next / previous match
I should behave more like the find in the terminal since for me a debug console is a special kind of terminal not a special kind of list /tree where we use that widget as well. | feature-request,debug-console | low | Critical |
2,488,523,952 | pytorch | [JIT][foreach_add] Arguments for call are not valid | ### 🐛 Describe the bug
Observe an error when try to use torch.jit.script on _foreach_add in following script:
```
import torch
def func_cpu():
input = [torch.ones(2,2)]
scalars = [0.5]
return torch._foreach_add(input, scalars)[0]
print(func_cpu()) # Works as use aten::_foreach_add.ScalarList
print(torch.jit.script(func_cpu)) # Fails to create a jit function.
```
the error is following:
```
tensor([[1.5000, 1.5000],
[1.5000, 1.5000]])
Traceback (most recent call last):
File "/home/pswider/foreach_add_repro.py", line 12, in <module>
print(torch.jit.script(func_cpu))
File "/home/pswider/.local/lib/python3.10/site-packages/torch/jit/_script.py", line 1432, in script
return _script_impl(
File "/home/pswider/.local/lib/python3.10/site-packages/torch/jit/_script.py", line 1204, in _script_impl
fn = torch._C._jit_script_compile(
RuntimeError:
Arguments for call are not valid.
The following variants are available:
aten::_foreach_add.Scalar(Tensor[] self, Scalar scalar) -> Tensor[]:
Expected a value of type 'number' for argument 'scalar' but instead found type 'List[float]'.
aten::_foreach_add.Scalar_out(Tensor[] self, Scalar scalar, *, Tensor(a!)[] out) -> ():
Expected a value of type 'number' for argument 'scalar' but instead found type 'List[float]'.
aten::_foreach_add.List(Tensor[] self, Tensor[] other, *, Scalar alpha=1) -> Tensor[]:
Expected a value of type 'List[Tensor]' for argument 'other' but instead found type 'List[float]'.
aten::_foreach_add.List_out(Tensor[] self, Tensor[] other, *, Scalar alpha=1, Tensor(a!)[] out) -> ():
Expected a value of type 'List[Tensor]' for argument 'other' but instead found type 'List[float]'.
aten::_foreach_add.ScalarList(Tensor[] self, Scalar[] scalars) -> Tensor[]:
Expected a value of type 'List[number]' for argument 'scalars' but instead found type 'List[float]'.
aten::_foreach_add.ScalarList_out(Tensor[] self, Scalar[] scalars, *, Tensor(a!)[] out) -> ():
Expected a value of type 'List[number]' for argument 'scalars' but instead found type 'List[float]'.
aten::_foreach_add.Tensor(Tensor[] self, Tensor other, *, Scalar alpha=1) -> Tensor[]:
Expected a value of type 'Tensor' for argument 'other' but instead found type 'List[float]'.
aten::_foreach_add.Tensor_out(Tensor[] self, Tensor other, *, Scalar alpha=1, Tensor(a!)[] out) -> ():
Expected a value of type 'Tensor' for argument 'other' but instead found type 'List[float]'.
The original call is:
File "/home/pswider/foreach_add_repro.py", line 7
input = [torch.ones(2,2)]
scalars = [0.5]
return torch._foreach_add(input, scalars)[0]
~~~~~~~~~~~~~~~~~~ <--- HERE
```
TorchScript seems to treat List[float] as it isn't List[number] which cause RuntimeError
### Versions
Collecting environment information...
PyTorch version: 2.4.0+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A
OS: Ubuntu 22.04 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: 14.0.0-1ubuntu1.1
CMake version: version 3.27.9
Libc version: glibc-2.35
Python version: 3.10.12 (main, Jul 29 2024, 16:56:48) [GCC 11.4.0] (64-bit runtime)
Python platform: Linux-5.15.0-117-generic-x86_64-with-glibc2.35
Is CUDA available: False
CUDA runtime version: No CUDA
CUDA_MODULE_LOADING set to: N/A
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 43 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 12
On-line CPU(s) list: 0-11
Vendor ID: GenuineIntel
Model name: Intel(R) Xeon(R) Gold 6132 CPU @ 2.60GHz
CPU family: 6
Model: 85
Thread(s) per core: 1
Core(s) per socket: 6
Socket(s): 2
Stepping: 0
BogoMIPS: 5187.81
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon nopl xtopology tsc_reliable nonstop_tsc cpuid tsc_known_freq pni pclmulqdq vmx ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti ssbd ibrs ibpb stibp tpr_shadow vnmi ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 invpcid avx512f avx512dq rdseed adx smap clflushopt clwb avx512cd avx512bw avx512vl xsaveopt xsavec xsaves arat pku ospke md_clear flush_l1d arch_capabilities
Virtualization: VT-x
Hypervisor vendor: VMware
Virtualization type: full
L1d cache: 384 KiB (12 instances)
L1i cache: 384 KiB (12 instances)
L2 cache: 12 MiB (12 instances)
L3 cache: 38.5 MiB (2 instances)
NUMA node(s): 1
NUMA node0 CPU(s): 0-11
Vulnerability Gather data sampling: Unknown: Dependent on hypervisor status
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX flush not necessary, SMT disabled
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP disabled; RSB filling; PBRSB-eIBRS Not affected; BHI SW loop, KVM SW loop
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected
Versions of relevant libraries:
[pip3] flake8==6.1.0
[pip3] numpy==1.23.5
[pip3] torch==2.4.0
[pip3] triton==3.0.0
[conda] Could not collect
cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel | oncall: jit | low | Critical |
2,488,550,257 | excalidraw | bug: minor sticky-note formatting issue on paste | Would be nice if the text did not flow outside the rectangle during paste. If the rectangle is big enough everything is fine, but if it needs to increase in size then positioning of the text is off.
https://github.com/user-attachments/assets/a746367e-505c-4bb2-8a34-67faf16c00d7
| bug,Text containers | low | Critical |
2,488,567,497 | godot | Concatenating constant arrays always gives the same array reference | ### Tested versions
- Reproducible in:
- v4.3.stable.official [77dcf97d8]
- v4.4.dev.gh [db76de5de]
- v4.1.3.stable.official [f06b6836a]
- v4.0.alpha1.official [31a7ddbf8]
- Not reproducible in: v3.5.3.stable.official [6c814135b]
### System information
Godot v4.3.stable - Windows 10.0.22631 - GLES3 (Compatibility) - NVIDIA GeForce RTX 4050 Laptop GPU (NVIDIA; 32.0.15.5612) - 13th Gen Intel(R) Core(TM) i7-13620H (16 Threads)
### Issue description
When concatenating constant arrays, the result is always a reference to the same array, probably due to [constant folding](https://godotengine.org/article/gdscript-progress-report-type-checking-back/#better-constant-folding).
As a result of this, creating a new array by concatenating two constant arrays, modifying the seemingly newly created array, and using the same concatenation elsewhere (or later in another call of the same function) gives the modified concatenation.
Example:
```gdscript
const A = ["a"]
const B = ["b"]
(A + B).append("X")
print(
"\nA: ", A,
"\nB: ", B,
"\nA + B: ", A + B
)
```
Result:
```
A: ["a"]
B: ["b"]
A + B: ["a", "b", "X"]
```
Expected:
```
A: ["a"]
B: ["b"]
A + B: ["a", "b"]
```
Workaround:
Concatenating a non-constant empty array truly creates a new array. (tested only in v4.3.stable.official [77dcf97d8])
```gdscript
(A + B + []).append("X")
print(
"\nA: ", A,
"\nB: ", B,
"\nA + B: ", A + B + []
)
```
### Steps to reproduce
The MRP contains:
- An EditorScript (`test_in_editor.gd`) that executes the previous code sample on execution (`ctrl+shift+X` by default)
- NB: The concatenation result seems to be reset at each execution, so each execution gives the same result.
- A scene with a Button that runs the previous code sample. (It's the default one, so you can press `F5` to start it)
- NB: The concatenation result is not reset at each execution, so each button press adds another "X".
### Minimal reproduction project (MRP)
[const_array_concatenation.zip](https://github.com/user-attachments/files/16758149/const_array_concatenation.zip)
| bug,discussion,topic:gdscript | low | Minor |
2,488,579,756 | flutter | Flutter Web: Google Chrome desktop mode shows blank page in portrait | ### Steps to reproduce
Open any Flutter web app (like https://flutterweb-wasm.web.app/) on Android (real device or emulator) with Google Chrome, desktop mode and portrait. When I load the app in landscape, it loads. When I switch from landscape to portrait, the app loads but is distorted. This issue does not exist when I build the app as HTML.
### Expected results
Web app is displayed as desktop version.
### Actual results
Blank page is displayed.
### Code sample
<details open><summary>Code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
useMaterial3: true,
),
home: const MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatefulWidget {
const MyHomePage({super.key, required this.title});
final String title;
@override
State<MyHomePage> createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
int _counter = 0;
void _incrementCounter() {
setState(() {
_counter++;
});
}
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
backgroundColor: Theme.of(context).colorScheme.inversePrimary,
title: Text(widget.title),
),
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
const Text(
'You have pushed the button this many times:',
),
Text(
'$_counter',
style: Theme.of(context).textTheme.headlineMedium,
),
],
),
),
floatingActionButton: FloatingActionButton(
onPressed: _incrementCounter,
tooltip: 'Increment',
child: const Icon(Icons.add),
),
);
}
}
```
</details>
### Screenshots or Video
<details open>
<summary>Screenshots / Video demonstration</summary>
[Upload media here]
</details>
### Logs
<details open><summary>Logs</summary>
```console
(index):38 Injecting <script> tag. Using callback.
Fetch finished loading: GET "<URL>".
Fetch finished loading: GET "<URL>".
Fetch finished loading: GET "<URL>".
Fetch finished loading: GET "<URL>".
Fetch finished loading: GET "<URL>".
Fetch finished loading: GET "<URL>".
Fetch finished loading: GET "<URL>".
Fetch finished loading: GET "<URL>".
browser_client.dart:101 XHR finished loading: GET "http://192.168.178.40:5050/version.json?cachebuster=1724745095244".
send @ browser_client.dart:101
(anonymous) @ async_patch.dart:45
runUnary @ zone.dart:1661
handleValue @ future_impl.dart:163
handleValueCallback @ future_impl.dart:847
_propagateToListeners @ future_impl.dart:876
[_completeWithValue] @ future_impl.dart:652
(anonymous) @ future_impl.dart:722
_microtaskLoop @ schedule_microtask.dart:40
_startMicrotaskLoop @ schedule_microtask.dart:49
(anonymous) @ async_patch.dart:181
Promise.then
_scheduleImmediateWithPromise @ async_patch.dart:179
_scheduleImmediate @ async_patch.dart:151
_scheduleAsyncCallback @ schedule_microtask.dart:69
_rootScheduleMicrotask @ zone.dart:1466
scheduleMicrotask @ zone.dart:1681
[_asyncCompleteWithValue] @ future_impl.dart:721
[_asyncComplete] @ future_impl.dart:681
_Future.immediate @ future_impl.dart:291
value @ future.dart:348
_engine.EngineFlutterWindow.__ @ window.dart:582
implicit @ window.dart:65
ensureImplicitViewInitialized @ window.dart:709
initializeEngineUi @ initialization.dart:228
runBody @ async_patch.dart:84
_async @ async_patch.dart:127
initializeEngineUi @ initialization.dart:208
(anonymous) @ initialization.dart:39
runBody @ async_patch.dart:84
_async @ async_patch.dart:127
(anonymous) @ initialization.dart:35
_checkAndCall @ operations.dart:426
callMethod @ operations.dart:494
dsend @ operations.dart:498
(anonymous) @ app_bootstrap.dart:57
runBody @ async_patch.dart:84
_async @ async_patch.dart:127
(anonymous) @ app_bootstrap.dart:56
(anonymous) @ js_loader.dart:74
_checkAndCall @ operations.dart:426
dcall @ operations.dart:431
ret @ js_allow_interop_patch.dart:17
(anonymous) @ (index):38
Promise.then
i @ (index):38
didCreateEngineInitializer @ (index):38
bootstrapEngine @ initialization.dart:52
runBody @ async_patch.dart:84
_async @ async_patch.dart:127
bootstrapEngine @ initialization.dart:27
main @ web_entrypoint.dart:19
runBody @ async_patch.dart:84
_async @ async_patch.dart:127
main$ @ web_entrypoint.dart:18
(anonymous) @ main_module.bootstrap.js:18
execCb @ require.js:1696
check @ require.js:883
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
enable @ require.js:1176
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
(anonymous) @ require.js:1460
setTimeout
req.nextTick @ require.js:1815
localRequire @ require.js:1449
configure @ require.js:1387
requirejs @ require.js:1794
(anonymous) @ require.js:2144
(anonymous) @ require.js:2145
developer_patch.dart:88 registerExtension() from dart:developer is only supported in build/run/test environments where the developer event method hooks have been set by package:dwds v11.1.0 or higher.
_registerExtension @ developer_patch.dart:88
registerExtension$ @ extension.dart:126
initializeEngineServices @ initialization.dart:136
runBody @ async_patch.dart:84
_async @ async_patch.dart:127
initializeEngineServices @ initialization.dart:110
(anonymous) @ initialization.dart:34
runBody @ async_patch.dart:84
_async @ async_patch.dart:127
(anonymous) @ initialization.dart:33
(anonymous) @ app_bootstrap.dart:48
runBody @ async_patch.dart:84
_async @ async_patch.dart:127
(anonymous) @ app_bootstrap.dart:47
(anonymous) @ js_loader.dart:56
_checkAndCall @ operations.dart:426
dcall @ operations.dart:431
ret @ js_allow_interop_patch.dart:17
i @ (index):38
didCreateEngineInitializer @ (index):38
bootstrapEngine @ initialization.dart:52
runBody @ async_patch.dart:84
_async @ async_patch.dart:127
bootstrapEngine @ initialization.dart:27
main @ web_entrypoint.dart:19
runBody @ async_patch.dart:84
_async @ async_patch.dart:127
main$ @ web_entrypoint.dart:18
(anonymous) @ main_module.bootstrap.js:18
execCb @ require.js:1696
check @ require.js:883
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
(anonymous) @ require.js:1139
(anonymous) @ require.js:134
(anonymous) @ require.js:1189
each @ require.js:59
emit @ require.js:1188
check @ require.js:938
enable @ require.js:1176
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
callGetModule @ require.js:1203
completeLoad @ require.js:1590
onScriptLoad @ require.js:1717
load
req.load @ require.js:1942
load @ require.js:1685
load @ require.js:834
fetch @ require.js:824
check @ require.js:856
enable @ require.js:1176
enable @ require.js:1557
(anonymous) @ require.js:1161
(anonymous) @ require.js:134
each @ require.js:59
enable @ require.js:1113
init @ require.js:788
(anonymous) @ require.js:1460
setTimeout
req.nextTick @ require.js:1815
localRequire @ require.js:1449
configure @ require.js:1387
requirejs @ require.js:1794
(anonymous) @ require.js:2144
(anonymous) @ require.js:2145
isolate_helper.dart:43 [Violation] 'setTimeout' handler took 215ms
isolate_helper.dart:43 [Violation] 'setTimeout' handler took 123ms
js_allow_interop_patch.dart:17 [Violation] 'requestAnimationFrame' handler took 224ms
js_allow_interop_patch.dart:17 [Violation] 'requestAnimationFrame' handler took 82ms
js_allow_interop_patch.dart:17 [Violation] 'requestAnimationFrame' handler took 102ms
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[✓] Flutter (Channel stable, 3.22.3, on macOS 14.5 23F79 darwin-arm64, locale de-DE)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.3)
[✓] VS Code (version 1.92.2)
[✓] Connected device (4 available)
[✓] Network resources
• No issues found!
```
</details>
| engine,platform-web,c: rendering,e: web_canvaskit,has reproducible steps,P2,browser: chrome-android,e: web_skwasm,team-web,triaged-web,found in release: 3.24,found in release: 3.25 | low | Minor |
2,488,581,856 | flutter | [tool] New project gitignore still defines rules for Android and iOS folder, instead of placing them in the Android/iOS gitignore file | ### Use case
Users creating a new Flutter project that want to benefit from the starting gitignore.
### Proposal
Currently when creating a new Flutter project, most of the Android & iOS specific things are split off into their own gitignores in the Android & iOS directories.
However, this isn't the case for all the rules.
For iOS, we still define `**/ios/Flutter/.last_build_id` in the root gitignore at https://github.com/flutter/flutter/blob/master/packages/flutter_tools/templates/app_shared/.gitignore.tmpl#L28
For Android, we still define
```
/android/app/debug
/android/app/profile
/android/app/release
```
at the bottom of the same template.
We should probably move these gitignore lines into their Android / iOS specific counterparts.
Steps to reproduce:
1. `flutter create sample`
2. `cd sample && cat .gitignore`
3. The `ios` and `android` folders are still present in rules in that file
Question: I'm not sure if the `**/` glob pattern is for add-to-app use cases?
<details>
<summary>Flutter Doctor</summary>
```console
[✓] Flutter (Channel stable, 3.24.1, on macOS 14.6.1 23G93 darwin-x64, locale en-BE)
• Flutter version 3.24.1 on channel stable at /Users/navaronbracke/Documents/flutter
• Upstream repository git@github.com:navaronbracke/flutter.git
• FLUTTER_GIT_URL = git@github.com:navaronbracke/flutter.git
• Framework revision 5874a72aa4 (6 days ago), 2024-08-20 16:46:00 -0500
• Engine revision c9b9d5780d
• Dart version 3.5.1
• DevTools version 2.37.2
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /Users/navaronbracke/Library/Android/sdk
• Platform android-34, build-tools 34.0.0
• ANDROID_HOME = /Users/navaronbracke/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15F31d
• CocoaPods version 1.15.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2023.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
[✓] VS Code (version 1.92.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.94.0
[✓] Connected device (2 available)
• macOS (desktop) • macos • darwin-x64 • macOS 14.6.1 23G93 darwin-x64
• Chrome (web) • chrome • web-javascript • Google Chrome 128.0.6613.85
[✓] Network resources
• All expected network resources are available.
• No issues found!
```
</details> | tool,c: proposal,P3,team-tool,triaged-tool | low | Critical |
2,488,586,261 | neovim | Piping to tee breaks neovim | ### Problem
Piping the ouput of the nvim command to `tee` renders neovim unusable (the window is not resized to the size of terminal window and the display gliches out).
nvim | tee test
In contrast, Vim shows a warning (`Output is not to a terminal`) and loads normally.
This may not seem like an actual use case, but I've encountered this in the real world, where I need to use a wrapper script to run arbitrary shell commands. If I use it with nvim I run into this issue, so I'm stuck with old vim for now.
### Steps to reproduce
nvim --clean | tee test
Neovim doesn't load normally, the display glitches out.
### Expected behavior
Vim shows the following warning, but loads normally:
Vim: Warning: Output is not to a terminal
### Neovim version (nvim -v)
0.10.1
### Vim (not Nvim) behaves the same?
no
### Operating system/version
Ubuntu
### Terminal name/version
Windows Terminal
### $TERM environment variable
xterm-256color
### Installation
snap | bug,tui | low | Minor |
2,488,591,398 | pytorch | ScriptModel Save ERROR, when I convert part of the model to TRT | ### 🐛 Describe the bug
```
import torch.nn
import torch_tensorrt
class MySubmodule(torch.nn.Module):
def __init__(self):
super(MySubmodule, self).__init__()
self.layer = torch.nn.Linear(10, 10)
def forward(self, x):
return self.layer(x)
class MyMod(torch.nn.Module):
def __init__(self):
super(MyMod, self).__init__()
self.submod = MySubmodule()
self.submod = torch_tensorrt.compile(self.submod, ir="ts",inputs=[
torch_tensorrt.Input(shape=(1, 10)),
])
print(self.submod.__qualname__)
def forward(self, x):
return self.submod(x)
if __name__ == "__main__":
model = MyMod()
scripted = torch.jit.script(model)
scripted(torch.zeros(1, 10).cuda())
scripted.save("test.pt")
```
But it raises exception: RuntimeError: method.qualname() == QualifiedName(selfClass->name()->qualifiedName(), methodName)INTERNAL ASSERT FAILED at "../torch/csrc/jit/serialization/python_print.cpp":1105, please report a bug to PyTorch.
### Versions
```
CPU(s): 104
On-line CPU(s) list: 0-103
Vendor ID: GenuineIntel
Model name: Intel(R) Xeon(R) Platinum 8269CY CPU @ 2.50GHz
CPU family: 6
Model: 85
Thread(s) per core: 2
Core(s) per socket: 26
Socket(s): 2
Stepping: 7
CPU max MHz: 3800.0000
CPU min MHz: 1200.0000
BogoMIPS: 5000.00
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single intel_ppin ssbd mba ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts pku ospke avx512_vnni md_clear flush_l1d arch_capabilities
Virtualization: VT-x
L1d cache: 1.6 MiB (52 instances)
L1i cache: 1.6 MiB (52 instances)
L2 cache: 52 MiB (52 instances)
L3 cache: 71.5 MiB (2 instances)
NUMA node(s): 1
NUMA node0 CPU(s): 0-103
Vulnerability Itlb multihit: KVM: Mitigation: Split huge pages
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Enhanced IBRS, IBPB conditional, RSB filling
Vulnerability Tsx async abort: Mitigation; TSX disabled
Versions of relevant libraries:
[pip3] mypy-extensions==1.0.0
[pip3] numpy==1.26.4
[pip3] optree==0.12.1
[pip3] torch==2.4.0
[pip3] torch_tensorrt==2.4.0
[pip3] torchaudio==2.4.0
[pip3] torchelastic==0.2.2
[pip3] torchmetrics==1.0.3
[pip3] torchrec==0.8.0+cu121
[pip3] torchvision==0.19.0
[pip3] triton==3.0.0
[conda] blas 1.0 mkl
[conda] ffmpeg 4.3 hf484d3e_0 pytorch
[conda] libjpeg-turbo 2.0.0 h9bf148f_0 pytorch
[conda] mkl 2023.1.0 h213fc3f_46344
[conda] mkl-service 2.4.0 py311h5eee18b_1
[conda] mkl_fft 1.3.8 py311h5eee18b_0
[conda] mkl_random 1.2.4 py311hdb19cb5_0
[conda] numpy 1.26.4 py311h08b1b3b_0
[conda] numpy-base 1.26.4 py311hf175353_0
[conda] optree 0.12.1 pypi_0 pypi
[conda] pytorch 2.4.0 py3.11_cuda12.1_cudnn9.1.0_0 pytorch
[conda] pytorch-cuda 12.1 ha16c6d3_5 pytorch
[conda] pytorch-mutex 1.0 cuda pytorch
[conda] torch-tensorrt 2.4.0 pypi_0 pypi
[conda] torchaudio 2.4.0 py311_cu121 pytorch
[conda] torchelastic 0.2.2 pypi_0 pypi
[conda] torchmetrics 1.0.3 pypi_0 pypi
[conda] torchrec 0.8.0+cu121 pypi_0 pypi
[conda] torchtriton 3.0.0 py311 pytorch
[conda] torchvision 0.19.0 py311_cu121 pytorch
```
cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel | oncall: jit | low | Critical |
2,488,614,017 | vscode | `FileSearchProviderOptions` isn't a good name for its purpose | Testing #226668
The `FileSearchProviderOptions` options aren't options for the provider but for a single invocation of a provider, I believe the more correct name would be just `FileSearchOptions` | search,polish,search-api | low | Minor |
2,488,649,597 | langchain | OpenLLM cant connect to local server with error: "module 'openllm' has no attribute 'client'" | ### Checked other resources
- [X] I added a very descriptive title to this issue.
- [X] I searched the LangChain documentation with the integrated search.
- [X] I used the GitHub search to find a similar question and didn't find it.
- [X] I am sure that this is a bug in LangChain rather than my code.
- [X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).
### Example Code
Code can be found here: https://github.com/SmolPandaDev/openllm-issue
### Error Message and Stack Trace (if applicable)
```
Traceback (most recent call last):
File "/Users/work/learning/openllm-issue/main.py", line 3, in <module>
llm = OpenLLM(server_url='http://localhost:3000')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/langchain_community/llms/openllm.py", line 149, in __init__
openllm.client.HTTPClient
^^^^^^^^^^^^^^
AttributeError: module 'openllm' has no attribute 'client'
```
### Description
I'm trying to get langchain to use a local LLM model so I can ask it questions and receive answers
### System Info
Output of `pip3 freeze | grep langchain`:
```
langchain==0.2.13
langchain-community==0.2.12
langchain-core==0.2.30
langchain-openai==0.1.21
langchain-text-splitters==0.2.2
langchainhub==0.1.21
```
Platform: MacOS (14.5 (23F79))
Output of: python3 --version
Python 3.11.6 | 🤖:bug,stale | low | Critical |
2,488,662,409 | vscode | `FileSearchProviderOptions#session` should not be `undefined` | Testing #226668
My sample search provider uses a weak map to cache FS walks by `FileSearchProviderOptions#session`. However, my provider now errors with "stack trace: Error: Invalid value used as weak map key" and that's because the session is sometimes passed as undefined. That should not happen and we should make a guarantee that it always has some value | bug,search,confirmed,search-api | low | Critical |
2,488,671,125 | transformers | When the model outputs Chinese, the dimension of the attention map output by output_attentions is wrong | ### Feature request
When outputting English, the last layer of attention map is (960, 960), and when outputting Chinese, the last layer of attention map is (1910,). How can this problem be solved?
### Motivation
When I use llama to output Chinese
### Your contribution
no | Feature request | low | Minor |
2,488,693,915 | vscode | Bad Diff: Incorrectly matched original and modified | ## Description
Expected the following original and modified lines to be matched with each other:
- Original: `protected abstract createModel(user: string, view: ISpliceable<ITreeNode<T, TFilterData>>, options: IAbstractTreeOptions<T, TFilterData>): ITreeModel<T, TFilterData, TRef>;`
- Modified: `protected abstract createModel(user: string, options: IAbstractTreeOptions<T, TFilterData>): ITreeModel<T, TFilterData, TRef>;`
## Playground Example
[Monaco Editor Playground Repro](https://microsoft.github.io/monaco-editor/playground.html?source=v0.51.0-rc3#XQAAAAIqEQAAAAAAAABBqQkHQ5NjdMeMm-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWdz-byd4PWyZAX4gTjZnHx_R_ugxZ6xrWgz8k0rlYVGZfwQ3QjH2GDw7bI_8paqOoYtw1AXFwYvJQ2FfcOWSRahkBHGIpwJqOpYf4BvMSh4Q_Lboro8yxmkrVhNAJ-0yoebVSHry0vSFJcaRrdRkTfIVBANfegyZKh3isi9jSLTmWBXMfeV5_Yi_FrV9L6TqGCnJ8THMn9gPA29gjKE-DCK6AhocHkpHeQBptRMQg7uXZaZALJuNSzAZvMiYmZ4treBles7PEPoN2D_gsC9m83S8N5R-ayFS__AkwwKlS__6AhhPcZYmTdgFO_YMAojxwe9jvFIJ74FiUJ0sNv2U7T_9WYVO-qLKShoZuO2MbfIB-lCiRf6z3lF3IZgzZPRcBkOq-FWvXy44L6Y2Uu2VXvIet2ishGioogDjz1ObYyOMsS_Y5EjAiCqV0qzkOV1u55lwmoUhl9E23ZIcjBjE8-ftMjpw_AR630eaMzJDXlgMxFHZD0Ag8-TOJMZNxOb68mW-YD08LOuZZTj2fMZ5IxLjF0bSr71filHG6Z9QsHRoyv3z2fo_AWYj45QtJqIZr6hFzLUchcAfBi2OGBXAz_-H2-xGNo4Gad_z74LGk6CC3zU_54LK5II44rjzA2mb9EoDXbHOyot0JqUqdh4E31WjVtqcgygPgKP7qo_E6BX-Hc1pCeHmtT7_PFl2sbYd4EigDF5f0bu5OytbmOoKcW5f6yFl5j87RJrU15C6r7dOK17mnaRq3P3t3Y4vVANwBta6OHJwcfNULGYcgozrKXbqbtYUTjUSZ-VjVYhIU5PM-yBNN9M4d2qbrzErReZby9dQOYTNbQ-ARG03OEOwSoqcvfitDQI4ymjvrLZfGcPH1pXPVQjb-9q7vJ9BZYAdWoezg2vHDaz4SdkY5xbTFY2GSJsYrFJKMl7mETK22CUgrJwaHFyE8i7VHeNLnUT4gHQDBlXPrwEwPOW53yZoyQA9pi00Y52MgXjgYgBPe3C4gE3Q9XjwLS4b0T7EaMgSfzC_l4Ev9cgotf-DiL92bQlF9a20r4LG6xZv9a35MyON85LynEr42YgyIes9UHpR_oUPMFB4XJhhbu8Ee9oYDxCl3peypljWgcU_IAO77GOJUsORxzsiCh6q7Xzm1RESm_WBspxFjKGzhTDxxvizQR4L-4dhq0xbUVlR3cCTKKHECWLLIgEdSq6aoeSMyedTgbYKCpcsE9_QBxlRWNjbGnrBC64DbA5f3xnw7R4qZFhM6_8HyyXF_J4ZWWsc0w26BC2it7Mo1xy45QBmTRh43lUF8iCMxI0qmnFzwA88aCQa-5B7p0cndOScRZ791I9AzPnD4E9fX9s_X0LAgOeS0zn54l9tXQwu7Bnc-ChSyrCa_fmfkXH69lPhUmHCQBF3cKw_6vfGFTFipIkmth9sRJmIFnWkoSDj14dwQdNvFzN_SGtH1cQ_ATLWjlwORJ9behE_cVWje8BlwZxh-vM2nugN8qStowtOVVm-a3r3ZgclV4j6H4f-iBW3VBxn5Fmy-mfoc5o46AOIxK39nI9uDHAmYpTIzj4KOx8HEFlNfIZq1LgQbqLi4s2RIc8_v9T0h9d5oBMXkz5pBq1tyLcGakyxsP--Isd0T0ZAXEEU6xOita8i0AhVB8c4HuQSfNAHenL8DO6l0JfOpCOL_EarVtotCN2AV6H1DVifNJ2zJduvk5A_5iZ0cvBV9K3ZD_ccprWTD22uEo7rmnx704rYZDu4iRyOS8QC_fxwrq4sMXCTqWCj-eBpiEeiFU411IiJwe-o6xmYcS4Qic8EtcSboG9oS7W_IL6fecrWkEcZyjeTSiztgXao7Klt0IRhmHXItAoC4Gc8WUkUaXvl1y3SmqkO2_B-kE5R0awkpRjcK4BGznGAijKd10_p_mO_TBTGzVjk5Mgd31juMunSPxXV3qpS1Zbn9OYzvoyIyymdmqw6iGN3LzW3jEofCW5ef0rbRbGKefXVK97VJ5uEH8Dy4R2kzh-A8rXncGJy5gxX-ISIhKJjjM4YPnRjAvm8LZZnFJ__8Xiqh) (click on "use latest dev" to verify a future bug-fix)
| feature-request,diff-editor | low | Critical |
2,488,706,249 | PowerToys | Fancy zones: Window gets snapped to different zone when clicked. Better discrimination between click and drag needed. | ### Microsoft PowerToys version
0.82.1
### Installation method
GitHub, PowerToys auto-update
### Running as admin
None
### Area(s) with issue?
FancyZones
### Steps to reproduce
I have a wide screen with 3 zones defined: left half of the screen (LH), right half of the screen (RH) and an area in the center of the screen (C) that overlaps the previous two. The center zone is slightly larger than the ones on the sides and I have configured: When multiple zones overlap - Activate the largest zone by area and also I have unchecked Hold Shift key to activate zones while dragging a window - this way whenever I click and drag the top (menu) bar of a window it snaps automatically to one zone.
The problem arises when I try to focus a window that's snapped to LH or RH zone and I click on the top bar in the area that overlaps with the C zone
### ✔️ Expected Behavior
I expect that the window on which I click to get focused and remain in the zone that's snapped to.
### ❌ Actual Behavior
What happens is that the window gets focused but also it moves/snaps to the Center zone because if I move the mouse even a pixel while I'm clicking the window, Fancy zones interprets this as the window being dragged/snapped to the C zone instead of a simple click and with the high resolutions of today's monitors, it's almost impossible to press the mouse button and release it without moving the mouse at all.
To avoid "accidentally" snapping the window to a different zone when clicking it, the code that's executed on "mouse button up" event needs to check if the mouse was moved a significant (>3 pixels?) distance from the position at "mouse button down" and only then interpret it as a "window dragged/moved", otherwise it should be handled as a simple click.
### Other Software
_No response_ | Issue-Bug,Needs-Triage | low | Minor |
2,488,719,729 | pytorch | histogramdd 'Cuda' backend | ### 🚀 The feature, motivation and pitch
I want to use the histogramdd function within the training loop, but since it hasn't been implemented to run on GPU, it slows down the training time. It would be great to have a Cuda implementation for that.
Running the code below on Torch 2.4 and Cuda version 12.4:
`torch.histogramdd(torch.tensor([[0., 1.], [1., 0.], [2., 0.], [2., 2.]])
.to('cuda'), bins=[3,3])
I received this error:
`NotImplementedError: Could not run 'aten::_histogramdd_bin_edges' with arguments from the 'CUDA' backend. This could be because the operator doesn't exist for this backend, or was omitted during the selective/custom build process (if using custom build). If you are a Facebook employee using PyTorch on mobile, p
lease visit https://fburl.com/ptmfixes for possible resolutions. 'aten::_histogramdd_bin_edges' is only available for these backends: [CPU, Meta, BackendSelect, Python, FuncTorchDynamicLayerBackMode, Functionalize, Named, Conjugate, Negative, ZeroTensor, ADInplaceOrView, AutogradOther, AutogradCPU, AutogradCUDA
, AutogradHIP, AutogradXLA, AutogradMPS, AutogradIPU, AutogradXPU, AutogradHPU, AutogradVE, AutogradLazy, AutogradMTIA, AutogradPrivateUse1, AutogradPrivateUse2, AutogradPrivateUse3, AutogradMeta, AutogradNestedTensor, Tracer, AutocastCPU, AutocastXPU, AutocastCUDA, FuncTorchBatched, BatchedNestedTensor, FuncTorchVmapMode, Batched, VmapMode, FuncTorchGradWrapper, PythonTLSSnapshot, FuncTorchDynamicLayerFrontMode, PreDispatch, PythonDispatcher].
CPU: registered at C:\cb\pytorch_1000000000000\work\build\aten\src\ATen\RegisterCPU.cpp:30455 [kernel]
Meta: registered at C:\cb\pytorch_1000000000000\work\aten\src\ATen\core\MetaFallbackKernel.cpp:23 [backend fallback]
BackendSelect: fallthrough registered at C:\cb\pytorch_1000000000000\work\aten\src\ATen\core\BackendSelectFallbackKernel.cpp:3 [backend fallback]
Python: registered at C:\cb\pytorch_1000000000000\work\aten\src\ATen\core\PythonFallbackKernel.cpp:153 [backend fallback]
FuncTorchDynamicLayerBackMode: registered at C:\cb\pytorch_1000000000000\work\aten\src\ATen\functorch\DynamicLayer.cpp:497 [backend fallback]
Functionalize: registered at C:\cb\pytorch_1000000000000\work\aten\src\ATen\FunctionalizeFallbackKernel.cpp:349 [backend fallback]
Named: registered at C:\cb\pytorch_1000000000000\work\aten\src\ATen\core\NamedRegistrations.cpp:7 [backend fallback]
Conjugate: registered at C:\cb\pytorch_1000000000000\work\aten\src\ATen\ConjugateFallback.cpp:17 [backend fallback]`
### Alternatives
_No response_
### Additional context
_No response_
cc @ptrblck @msaroufim | module: cuda,triaged | low | Critical |
2,488,756,538 | angular | [devtools] duplicate entries in Components > Injected Services | ### Is this a bug report or a feature request?
- [X] Bug Report
- [ ] Feature Request
### Please provide the steps to reproduce the issue [Bug Report only]
1. Create an example application:
```typescript
import { Component, output } from '@angular/core';
import { bootstrapApplication } from '@angular/platform-browser';
@Component({
selector: 'app-root',
standalone: true,
template: `Test`,
})
export class AppComponent {
foo = output();
bar = output();
baz = output();
}
bootstrapApplication(AppComponent, {providers: []})
.catch((err) => console.error(err));
```
2. run `ng serve`, open the application in the browser
3. open the Angular DevTools, select `app-root` in the Components tab
### Please provide the expected behavior vs the actual behavior you encountered [Bug Report only]
If the same token was injected more than once, the Injected Services section shows duplicate entries, one for each injection.
This results in a lot of repetition, especially when using the new framework features such as `output`, `toSignal`, `effect`, etc. which inject multiple dependencies internally.
The info shown for multiple injections is exactly the same and doesn't provide additional information, apart from maybe the `Optional` flag being different for some of them
### Please provide a screenshot if possible [Bug Report only]
### Please provide the exception or error you saw [Bug Report only]
_No response_
### Is this a browser-specific issue? If so, please specify the device, browser, and version. [Bug Report only]
_No response_
### Description [Feature Request only]
_No response_
### Proposed solution [Feature Request only]
_No response_
### Alternatives considered [Feature Request only]
_No response_ | area: devtools | low | Critical |
2,488,772,165 | godot | Custom enumeration is not colored | ### Tested versions
v4.4.dev1.official [28a72fa43]
### System information
w10 64
### Issue description
### Steps to reproduce
...
### Minimal reproduction project (MRP)
... | enhancement,discussion,topic:gdscript,topic:editor | low | Minor |
2,488,831,122 | PowerToys | a PowerRename bug with input method | ### Microsoft PowerToys version
0.83.0
### Installation method
GitHub
### Running as admin
Yes
### Area(s) with issue?
PowerRename
### Steps to reproduce
## 1. failed - chinese input method
## 2. failed - unresponsive(also chinese input method)
## 3. success - switching input method
### ✔️ Expected Behavior
_No response_
### ❌ Actual Behavior
_No response_
### Other Software
OS: win10 22H2
chinese input method: 讯飞输入法 | Issue-Bug,Needs-Triage | low | Critical |
2,488,836,119 | godot | Unused class variable warning does not have one for public class variable | ### Tested versions
Reproducible in Godot 4.3.stable
### System information
macOS 13.6.7 (Intel) - Godot v4.3.stable - Vulkan (Mobile)
### Issue description
In 3.5, the Unused Class Variable warning would trigger for unused public and private class member variables. Now in 4.x, this has been renamed to Unused Private Class Variable and only warns for private class variable.
### Steps to reproduce
Turn on warning for Unused Private Class Variable and Unused Variable in Project Settings > Debug > GDScript. Then type in a new script:
```
var some_public_var # This will not have a warning
var _some_private_var # This will have an UNUSED PRIVATE CLASS VARIABLE warning
func _ready():
var some_local_var # This will have an UNUSED VARIABLE warning
```
I apologize if this change was made because unused public class variables are ok to have, but the previous warning was very useful to find class variables I forgot to remove. I am not familiar with other languages to know if this is the convention elsewhere.
### Minimal reproduction project (MRP)
N/A | discussion,topic:gdscript,documentation | low | Critical |
2,488,868,081 | ui | [feat]: AI Assist to build with Shadcn | ### Feature description
Hi there,
shadcn-ui is a popular repository for beautifully designed, accessible, and customizable components that you can copy and paste into your apps. However, most copilots aren't able to help with the latest syntax. So, we created a custom AI Assist trained on this repo's code and issues.
Please try it [here](https://app.commanddash.io/agent/github_shadcn-ui_ui)
It is also mentionable as a badge in the README and can help developers landing on the repo build apps for their use cases.
<a href="https://app.commanddash.io/agent/github_shadcn-ui_ui"><img src="https://img.shields.io/badge/AI-Code%20Agent-EB9FDA"></a>
```
<a href="https://app.commanddash.io/agent/github_shadcn-ui_ui"><img src="https://img.shields.io/badge/AI-Code%20Agent-EB9FDA"></a>
```
hope this helps!
### Affected component/components
_No response_
### Additional Context
_No response_
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues and PRs | area: request | low | Minor |
2,488,880,823 | godot | Autocomplete does not work properly in certain circumstances. | ### Tested versions
v4.4.dev1.official [28a72fa43]
### System information
w10 64
### Issue description
Watch the video, autocomplete works fine in the first case.
Then I comment out the line where autocomplete works correctly and uncomment the line where autocomplete does not work.
This can be seen when I type the "." in the enumeration.
It seems that the part that causes the problem is the ternary condition.
https://github.com/user-attachments/assets/d340f795-f7dc-49e2-87eb-83d1f5d2af50
works without ternary condition
### Steps to reproduce
...
### Minimal reproduction project (MRP)
Type "." at the end of line 9
[testautocompletadoenum.zip](https://github.com/user-attachments/files/16760805/testautocompletadoenum.zip)
| bug,topic:gdscript,topic:editor,needs testing | low | Minor |
2,488,891,457 | flutter | Expose a way to download and list Android dependencies | We want a command like `flutter build --config-only` (or similar) to download Gradle dependencies and list the jar files. Preferably this should work even if the Flutter project is a plugin and not an application with a `main` function.
This is useful for jnigen where we want to generate Dart bindings for an application's gradle dependencies.
Similarly, downloading source jars and Javadocs are useful, here is a task that downloads the source artifacts. (Replacing `SourcesArtifact` with `JavadocArtifact` will do the same for Javadocs)
```kotlin
tasks.register("getSources") {
doLast {
val componentIds =
configurations["releaseCompileClasspath"].incoming.resolutionResult.allDependencies.map { it.from.id }
val result = dependencies.createArtifactResolutionQuery().forComponents(componentIds)
.withArtifacts(JvmLibrary::class.java, SourcesArtifact::class.java).execute()
val sourceArtifacts = mutableListOf<File>()
result.resolvedComponents.forEach { component ->
val sources = component.getArtifacts(SourcesArtifact::class.java)
sources.forEach { artifact ->
if (artifact is ResolvedArtifactResult) {
sourceArtifacts.add(artifact.file)
}
}
}
sourceArtifacts.forEach { println(it) }
}
}
```
Context: https://github.com/dart-lang/native/issues/628
@gmackall @reidbaker
| tool,p: tooling,t: gradle,a: build,team-android | low | Minor |
2,488,900,645 | opencv | (.note.gnu.property+0x0): data is too short error during IPP linkage with NDK 27 for Android x86 | ### System Information
Branch: 4.x
NDK: 27.0.12077973
Reproduced with CI in https://github.com/opencv/opencv/pull/26057
### Detailed description
-
### Steps to reproduce
```
$ export ANDROID_HOME=/home/alexander/Android2/
$ cmake -GNinja -DCMAKE_TOOLCHAIN_FILE=/home/alexander/Android2/ndk/27.0.12077973/build/cmake/android.toolchain.cmake -DANDROID_SDK=/home/alexander/Android2/ -DANDROID_ABI=x86 ../opencv-master
### Issue submission checklist
- [X] I report the issue, it's not a question
- [X] I checked the problem with documentation, FAQ, open issues, forum.opencv.org, Stack Overflow, etc and have not found any solution
- [X] I updated to the latest OpenCV version and the issue is still there
- [X] There is reproducer code and related data files (videos, images, onnx, etc) | bug,category: build/install,platform: android | medium | Critical |
2,488,902,145 | ant-design | Incorrect date-picker small Token | ### Reproduction link
[https://github.com/ant-design/ant-design/blob/master/components/date-picker/style/index.ts#L170-L172](https://github.com/ant-design/ant-design/blob/master/components/date-picker/style/index.ts#L170-L172)
### Steps to reproduce
components/date-picker/style/index.ts
```code
// Size
'&-large': {
...genPickerPadding(token, controlHeightLG, fontHeightLG, paddingInline),
[`${componentCls}-input > input`]: {
fontSize: fontSizeLG,
lineHeight: lineHeightLG,
},
},
'&-small': {
...genPickerPadding(token, controlHeightSM, fontHeight, paddingInlineSM),
},
```
'&-small' genPickerPadding 没对应用用fontHeightSM Token , 覆写 >input 也没用 fontSizeSM和lineHeightSM Token
### What is expected?
...genPickerPadding(token, controlHeightSM, fontHeightSM, paddingInlineSM),
### What is actually happening?
...genPickerPadding(token, controlHeightSM,fontHeight, paddingInlineSM),
| Environment | Info |
| --- | --- |
| antd | undefined |
| React | 18 |
| System | macos |
| Browser | chrome |
<!-- generated by ant-design-issue-helper. DO NOT REMOVE --> | help wanted,Inactive,unconfirmed | low | Minor |
2,488,902,726 | transformers | [i18n-ur] Translating docs to Urdu (اردو) | <!--
Note: Please search to see if an issue already exists for the language you are trying to translate.
-->
Hi!
Let's bring the documentation to all the Urdu-speaking community 🌐 (currently 0 out of 267 complete)
Who would want to translate? Please follow the 🤗 [TRANSLATING guide](https://github.com/huggingface/transformers/blob/main/docs/TRANSLATING.md). Here is a list of the files ready for translation. Let us know in this issue if you'd like to translate any, and we'll add your name to the list.
Some notes:
* Please translate using an informal tone (imagine you are talking with a friend about transformers 🤗).
* Please translate in a gender-neutral way.
* Add your translations to the folder called `<languageCode>` inside the [source folder](https://github.com/huggingface/transformers/tree/main/docs/source).
* Register your translation in `<languageCode>/_toctree.yml`; please follow the order of the [English version](https://github.com/huggingface/transformers/blob/main/docs/source/en/_toctree.yml).
* Once you're finished, open a pull request and tag this issue by including #issue-number in the description, where issue-number is the number of this issue. Please ping @stevhliu and @MKhalusova for review.
* 🙋 If you'd like others to help you with the translation, you can also post in the 🤗 [forums](https://discuss.huggingface.co/).
@akkefa
## Get Started section
- [ ] index.md ( Work in progress )
- [ ] [quicktour.md](https://github.com/huggingface/transformers/blob/main/docs/source/en/quicktour.md) (waiting for initial PR to go through)
- [ ] [installation.md](https://github.com/huggingface/transformers/blob/main/docs/source/en/installation.md).
## Tutorial section
- [ ] [pipeline_tutorial.md](https://github.com/huggingface/transformers/blob/main/docs/source/en/pipeline_tutorial.md)
- [ ] [autoclass_tutorial.md](https://github.com/huggingface/transformers/blob/main/docs/source/en/autoclass_tutorial.md)
- [ ] [preprocessing.md](https://github.com/huggingface/transformers/blob/main/docs/source/en/preprocessing.md)
- [ ] [training.md](https://github.com/huggingface/transformers/blob/main/docs/source/en/training.md)
- [ ] [accelerate.md](https://github.com/huggingface/transformers/blob/main/docs/source/en/accelerate.md)
- [ ] [model_sharing.md](https://github.com/huggingface/transformers/blob/main/docs/source/en/model_sharing.md)
- [ ] [multilingual.md](https://github.com/huggingface/transformers/blob/main/docs/source/en/multilingual.md)
<!--
Keep on adding more as you go 🔥
-->
| WIP | low | Minor |
2,488,909,204 | flutter | [camera] recording video of 200MS duration is not possible on android | ### Steps to reproduce
Test 1:
1. Start recording video using ```await controller?.startVideoRecording()```
2. Wait till 200 MS
3. Call ```controller?.stopVideoRecording()```
Test 2:
1. Start recording video using ```await controller?.startVideoRecording()```
2. Wait till 2 seconds
3. Call ```controller?.stopVideoRecording()```
### Expected results
Test 1:
- Video with 200MS runtime should be generated
Test 2:
- Video with 2 seconds runtime should be generated
### Actual results
Test 1:
- .temp file is returned with 0 byte size
Test 2:
- .temp file is returned (if you extension change to .mp4 it will be video with 1.7 seconds)
### Code sample
<details open><summary>Code sample</summary>
Test 1:
```dart
await controller?.startVideoRecording();
await Future.delayed(const Duration(milliseconds: 200), () {});
final video = await controller!.stopVideoRecording();
video.path.logI;
(await video.length()).logI;
```
Test 2:
```dart
await controller?.startVideoRecording();
await Future.delayed(const Duration(milliseconds: 2000), () {});
final video = await controller!.stopVideoRecording();
video.path.logI;
(await video.length()).logI;
```
</details>
### Additional Info
- Test 1 fails with error if we are not using camerax implementation.
- Look into [.temp file issue](https://github.com/flutter/flutter/issues/148335) for additional context.
### Logs
<details open><summary>Logs</summary>
Test 1:
```console
I/flutter (25587): │ 💡 /data/user/0/com.zizle.dev/cache/REC7265390614749397427.temp
I/flutter (25587): │ 💡 0
```
Test 2:
```console
I/flutter (25587): │ 💡 /data/user/0/com.zizle.dev/cache/REC1589270164385580655.temp
I/flutter (25587): │ 💡 4187259
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[✓] Flutter (Channel stable, 3.22.3, on macOS 14.4.1 23E224 darwin-x64, locale
en-US)
• Flutter version 3.22.3 on channel stable at /Users/tagline/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision b0850beeb2 (6 weeks ago), 2024-07-16 21:43:41 -0700
• Engine revision 235db911ba
• Dart version 3.4.4
• DevTools version 2.34.3
[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
• Android SDK at /Users/tagline/Library/Android/sdk
• Platform android-35, build-tools 35.0.0
• Java binary at: /Applications/Android
Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build
17.0.10+0-17.0.10b1087.21-11609105)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15F31d
• CocoaPods version 1.15.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2024.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build
17.0.10+0-17.0.10b1087.21-11609105)
[✓] VS Code (version 1.92.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.94.0
[✓] Connected device (4 available)
• IV2201 (mobile) • PRHYZHS8WC6LUOTO • android-arm64 •
Android 13 (API 33)
• iPhone 12 Mini (mobile) • 00008101-001039AC0AF1003A • ios • iOS
15.4.1 19E258
• macOS (desktop) • macos • darwin-x64 •
macOS 14.4.1 23E224 darwin-x64
• Chrome (web) • chrome • web-javascript •
Google Chrome 128.0.6613.84
[✓] Network resources
• All expected network resources are available.
• No issues found!
```
</details>
| platform-android,p: camera,package,has reproducible steps,P3,team-android,triaged-android,found in release: 3.24 | low | Critical |
2,488,953,827 | excalidraw | BUG: Elbow Arrow ALT+drag duplication results in fuzzy/confusing UX | Alt+dragging a single elbow connector that is bound to at least one element results in a duplicated element right on top of the previous element. Dragging the arrow - to move it - has no effect.
When duplicating the new arrow should not carry its bindings.
https://github.com/user-attachments/assets/cda2761a-b97a-4977-b013-d7e7f5cd098c
| good first issue | low | Critical |
2,488,954,951 | vscode | `SettingsEditor2` shows progress when opening raw settings file | Steps to Reproduce:
1. switch between a file and settings.json
2. notice how a progress bar shows up each time
Stack points to:
```
withProgress (progressService.ts:51)
M (dirtydiffDecorator.ts:1334)
(anonymous) (dirtydiffDecorator.ts:1307)
queue (async.ts:231)
(anonymous) (async.ts:423)
(anonymous) (async.ts:364)
Promise.then (async)
trigger (async.ts:358)
trigger (async.ts:423)
J (dirtydiffDecorator.ts:1307)
I (dirtydiffDecorator.ts:1298)
Ee (dirtydiffDecorator.ts:1253)
o (instantiationService.ts:162)
createInstance (instantiationService.ts:128)
F (dirtydiffDecorator.ts:1646)
(anonymous) (dirtydiffDecorator.ts:1612)
(anonymous) (event.ts:187)
B (event.ts:1242)
C (event.ts:1253)
fire (event.ts:1277)
(anonymous) (editorService.ts:173)
B (event.ts:1242)
C (event.ts:1253)
fire (event.ts:1277)
(anonymous) (editorGroupView.ts:1286)
await in (anonymous) (async)
Kb (editorGroupView.ts:1301)
Jb (editorGroupView.ts:1259)
openEditor (editorGroupView.ts:1163)
openEditor (editorService.ts:573)
await in openEditor (async)
ub (anythingQuickAccess.ts:1083)
accept (anythingQuickAccess.ts:1040)
(anonymous) (pickerQuickAccess.ts:343)
B (event.ts:1242)
C (event.ts:1253)
fire (event.ts:1277)
Ub (quickInput.ts:943)
(anonymous) (quickInput.ts:991)
```
| bug,settings-editor,papercut :drop_of_blood: | low | Major |
2,488,966,052 | PowerToys | [Color Picker] Preferred monitor position? | ### Description of the new feature / enhancement
As I know there's no "Preferred monitor position" feature in Color Picker. It just launches in first-launched after boot and last opened monitor only. I think Color Picker should always launch from monitor that picked color because that monitor we're trying to pick a color on is we're looking at.
### Scenario when this would be used?
Pick a color in multiple display environment
### Supporting information
_No response_ | Needs-Triage | low | Minor |
2,488,969,816 | vscode | The docs for `provideFileSearchResults` should provide guidance how to interpret `pattern` | Testing #226668
Today, the docs just say _"The search pattern to match against file paths."_ This leaves a lot of room for speculation and it's not clear if matching is substring, startWith, case-sensitive, fuzzy etc.
For the `WorkspaceSymbolProvider` api we have very similar challenge and with it we are very explicit how the search string should be interpreted:
https://github.com/microsoft/vscode/blob/7473068e0d7b62bfd4ef4c8f6b86832448ff1d36/src/vscode-dts/vscode.d.ts#L3599-L3602 | search,polish,search-api | low | Minor |
2,488,994,825 | vscode | Consider to support streaming for file search results | Testing #226668
Today's proposal for file search doesn't support streaming (where the proposal for text search does). I understand the history behind this and I know our UI doesn't benefit from streaming but I think we should reconsider this. We do have requests for streaming for similar "large data" apis like reference and symbol search and the same request might come for this API | feature-request,search,search-api | low | Minor |
2,488,997,572 | PowerToys | The update requires a D drive ? | ### Microsoft PowerToys version
0.83.0
### Installation method
GitHub, PowerToys auto-update
### Running as admin
Yes
### Area(s) with issue?
Installer
### Steps to reproduce
Since I merged the C and D drives,I received an error message during the upgrade saying it could not be installed.After I repartitioned to create a D drive,the installation proceeded normally.But the D drive is not being used.The error number is ×80070643
### ✔️ Expected Behavior
_No response_
### ❌ Actual Behavior
_No response_
### Other Software
_No response_ | Issue-Bug,Needs-Triage | low | Critical |
2,489,002,866 | vscode | Docs for `FileSearchProviderOptions.folderOptions.useIgnoreFiles` are wrong | Testing #226668
The docs say "If set, {@link FileSearchProviderOptions.useIgnoreFiles.local} should also be `true`" which can be understood as "vscode gives you data but doesn't know the actual values". Given we control the data, we should enforce strictness and swap ~should~ with *is*. | bug,search,search-api | low | Minor |
2,489,007,997 | vscode | Properties of `FileSearchProviderOptions` should be marked `readonly` | Testing #226668
When VS Code gives data to extensions to interpret (like options) we mark all the things as `readonly` and `readonly foo[]`. This ensures extension authors don't believe they can tweak or change these options | bug,search,search-api | low | Minor |
2,489,028,139 | flutter | Inject proguard rules after Dart AOT compilation to gradle | Once the Dart code is compiled in AOT mode, we can understand which methods and classes are used from the jnigen generated bindings and can use that to generate proguard rules. The tree-shaking information is accessible through `hook/link.dart`.
I'm not sure how the release build pipeline looks like, for example if the process starts with gradle can we then inject the generated proguard rules mid build?
Context: https://github.com/dart-lang/native/issues/681
@gmackall @reidbaker @dcharkes @mkustermann | c: new feature,tool,p: tooling,t: gradle,a: build,team-android | low | Major |
2,489,083,216 | vscode | Inline completions floating meu does not show the number of total completions when intellisense is open at the same time | - In a file write some code that triggers the inline completions and intellisense at the same time.
- While intellisense is visible, hover over the greyed out text
- Notice that the floating menu does not show the number of completions (generally would say 1/1)
- Make intellisense disappear, but keep the inline completions.
- Hover on the inline completions, it shows the total number of completions.
https://github.com/user-attachments/assets/33ef4b56-de75-42e7-9939-2f13bd698de4
| bug,inline-completions | low | Minor |
2,489,097,187 | godot | Godot 4.3 export to Android release and debug issue aab files | ### Tested versions
Reproduce on Godot 4.3stable version.
### System information
windows 10 - Godot 4.3
### Issue description
When exporting to Android aab file I have got the issue. The release file is bigger than debug one. When I extracted the release file I found dir "BUNDLE-METADATA" containing com.android.tools.build.debugsymbols and big *.so files
### Steps to reproduce
1 Create new project
2 Install Android build template
3 Project-Export add android export
4 Check: Use gradle build
5 Choose: Export AAB
6 Export project
7 Export with Debug create 2 variants using .aab extension
8 * to release export use keystore
### Minimal reproduction project (MRP)
[issue_test.zip](https://github.com/user-attachments/files/16761586/issue_test.zip)
readme.txt file contains the keystore user and password
I cannot download my .aab files because they are 45 MB for debug and 84 MB for release | bug,platform:android,topic:export | low | Critical |
2,489,097,987 | rust | std::process::Command is broken on VMWare ESXi | std::process::Command is broken on VMWare ESXi, probably VMKernel does't support a `SOCK_SEQPACKET`
I tried this code:
```rust
// main.rs
use std::process::{Command, Stdio};
fn main() {
let res = Command::new("ls")
.arg("-l")
.output()
.unwrap();
println!("status = {:?}", res.status);
println!("stderr = {:?}", String::from_utf8_lossy(&res.stderr));
println!("stdout = {:?}", String::from_utf8_lossy(&res.stdout));
}
```
```toml
# Cross.toml
[target.x86_64-unknown-linux-gnu]
image = "ghcr.io/cross-rs/x86_64-unknown-linux-gnu:0.2.2-centos"
```
Build with cross:
```cross +nightly build -Zbuild-std=std --target x86_64-unknown-linux-gnu --release```
I expected to see this happen: exit status code, stdout, stderr of ```ls``` process
Instead, this happened: panic with message: ```thread 'main' panicked at /home/root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys_common/process.rs:153:17:
called `Result::unwrap()` on an `Err` value: Os { code: 25, kind: Uncategorized, message: "Inappropriate ioctl for device" }```
But if I change the code a little:
```rust
// main.rs
use std::process::{Command, Stdio};
fn main() {
let res = Command::new("ls")
.arg("-l")
.stderr(Stdio::null()) // <--
.output()
.unwrap();
println!("status = {:?}", res.status);
println!("stderr = {:?}", String::from_utf8_lossy(&res.stderr));
println!("stdout = {:?}", String::from_utf8_lossy(&res.stdout));
}
```
Panic message is changed: ```thread 'main' panicked at src/main.rs:10:10:
called `Result::unwrap()` on an `Err` value: Os { code: 22, kind: InvalidInput, message: "Invalid argument" }```
### Meta
`rustc --version --verbose` of current toolchain:
```
rustc 1.82.0-nightly (60d146580 2024-08-06)
binary: rustc
commit-hash: 60d146580c10036ce89e019422c6bc2fd9729b65
commit-date: 2024-08-06
host: x86_64-unknown-linux-gnu
release: 1.82.0-nightly
LLVM version: 19.1.0
```
`rustc --version --verbose` of working toolchain:
```
rustc 1.73.0-nightly (f88a8b71c 2023-08-08)
binary: rustc
commit-hash: f88a8b71cebb730cbd5058c45ebcae1d4d9be377
commit-date: 2023-08-08
host: x86_64-unknown-linux-gnu
release: 1.73.0-nightly
LLVM version: 17.0.0
```
`rustc --version --verbose` of first broken toolchain:
```
rustc 1.73.0-nightly (08d00b40a 2023-08-09)
binary: rustc
commit-hash: 08d00b40aef2017fe6dba3ff7d6476efa0c10888
commit-date: 2023-08-09
host: x86_64-unknown-linux-gnu
release: 1.73.0-nightly
LLVM version: 17.0.0
```
`vmware -v`:
```
VMware ESXi 8.0.1 build-21813344
```
`Affected commit`: #113939
| O-linux,C-bug,T-libs,A-process | low | Critical |
2,489,136,097 | deno | deno resource leak test false positive when using filter | Version: Deno 1.46.0
# bug
deno resource leak test false positive when using filter
## reproduce
```sh
$ deno test -A ./x.ts
running 2 tests from ./x.ts
a ... ok (11ms)
b ... FAILED (6ms)
ERRORS
b => ./x.ts:12:6
error: Leaks detected:
- A child process was started during the test, but not closed during the test. Close the child process by calling `proc.kill()` or `proc.close()`.
- An async operation to wait for a subprocess to exit was started in this test, but never completed. This is often caused by not awaiting the result of a `Deno.Process#status` call.
To get more details where leaks occurred, run again with the --trace-leaks flag.
FAILURES
b => ./x.ts:12:6
FAILED | 1 passed | 1 failed (19ms)
error: Test failed
```
## actual
deno resource leak test false positive when using filter
```sh
$ deno test -A --filter b ./x.ts
running 1 test from ./x.ts
b ... ok (14ms)
ok | 1 passed | 0 failed | 1 filtered out (15ms)
```
## expected
```sh
$ deno test -A --filter b ./x.ts
(complain resource leak when using test filter)
```
## additional
Found this bug when https://github.com/evanw/esbuild/issues/3896
| bug,testing | low | Critical |
2,489,257,451 | kubernetes | Extended resources could not be zeroed while node has been recreated | ### What happened?
https://github.com/kubernetes/kubernetes/blob/7436ca32bc766ff202109a7541d2e7bb41ee7d13/pkg/kubelet/kubelet_node_status.go#L181
the `reconcileExtendedResource` check with devicemanager to see if there is no checkpoints to decide whether to zero out ER, but while kubelet start, the checkpoint dir could not be empty as the kubelet.sock will be created first
https://github.com/kubernetes/kubernetes/blob/7436ca32bc766ff202109a7541d2e7bb41ee7d13/pkg/kubelet/checkpointmanager/checkpoint_manager.go#L105
the `ListCheckpoints ` list all file except ones which has prefix ".", but not filter the sock files, so `kl.containerManager.ShouldResetExtendedResourceCapacity` will always return false
### What did you expect to happen?
the `ListCheckpoints ` should only list the real checkpoint file, the kubelet_internal_checkpoint
### How can we reproduce it (as minimally and precisely as possible)?
1. register a node with GPU
2. recreate the node with a new vm
3. see the node status GPU resource, not zerod out
### Anything else we need to know?
_No response_
### Kubernetes version
<details>
```console
$ kubectl version
# paste output here
```
1.28.x
</details>
### Cloud provider
<details>
</details>
### OS version
<details>
```console
# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here
# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here
```
</details>
### Install tools
<details>
</details>
### Container runtime (CRI) and version (if applicable)
<details>
</details>
### Related plugins (CNI, CSI, ...) and versions (if applicable)
<details>
</details>
| kind/bug,priority/backlog,sig/node,triage/accepted | low | Minor |
2,489,305,792 | pytorch | Would it be possible to have a CMAKE option USE_SYSTEM_FMT | ### 🚀 The feature, motivation and pitch
Currently we are building libtorch with CMake with our own system dependencies making use of the different available `USE_SYSTEM_XXX` options.
However in the case of FMT there is no `USE_SYSTEM_FMT` option available. Instead the `cmake/Dependencies.cmake` enforce the compilation of thirdparty fmt source (https://github.com/pytorch/pytorch/blob/main/cmake/Dependencies.cmake#L1526)
Would it be possible to have a `USE_SYSTEM_FMT` option? Maybe a simple `find_package(fmt)` in that option would be enough.
### Alternatives
_No response_
### Additional context
_No response_
cc @malfet @seemethere | module: build,triaged | low | Minor |
2,489,343,318 | vscode | vscode.dev workbench doesn't allow not saving a file with simple file dialog |
Type: <b>Bug</b>
repro:
0. you should have simple-dialog enabled
1. open insiders.vscode.dev ([link](https://insiders.vscode.dev/github/jrieken/vscode-tree-sitter-query/pull/16?vscode-version=d903f161caa4a4aa9cc965d95d24cf6704940020&vscode-esm=true))
2. open a jupyter notebook (I was using tree-sitter notebook from jrieken.vscode-tree-sitter-query)
3. make the notebook dirty by making a change to a cell
4. try changing your current profile -- the dirty notebook pops up with simple dialog which if you `escape` from just ends up closing the dialog for "save"/"not save" action
VS Code version: Code - Insiders 1.93.0-insider (d903f161caa4a4aa9cc965d95d24cf6704940020, 2024-08-27T04:53:27.167Z)
OS version:
Modes:
System Info: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/128.0.0.0 Safari/537.36<details><summary>Extensions (46)</summary>
Extension|Author (truncated)|Version
---|---|---
anycode-rust|ms-|0.0.6
anycode-python|ms-|0.0.5
anycode|ms-|0.0.73
anycode-php|ms-|0.0.6
anycode-java|ms-|0.0.5
anycode-kotlin|ms-|0.0.5
anycode-typescript|ms-|0.0.5
anycode-cpp|ms-|0.0.5
anycode-go|ms-|0.0.5
anycode-c-sharp|ms-|0.0.5
remote-server|ms-|1.6.2024081909
azure-repos|ms-|0.39.2024082601
codespaces|Git|1.17.2
remotehub|Git|0.63.2024082601
remote-repositories|ms-|0.41.2024082601
remote-explorer|ms-|0.5.2024081309
tsl-problem-matcher|amo|0.6.2
esbuild-problem-matchers|con|0.0.3
kusto|don|0.4.4
gitlens|eam|2024.8.2705
prettier-vscode|esb|11.0.0
vscode-pull-request-github|Git|0.95.2024082704
vscode-tree-sitter-query|jri|0.0.6
rainbow-csv|mec|3.12.0
template-string-converter|meg|0.6.1
fluent-icons|mig|0.0.18
python|ms-|2024.13.2024082701
vscode-pylance|ms-|2024.8.2
jupyter|ms-|2024.8.2024081201
jupyter-keymap|ms-|1.1.2
jupyter-renderers|ms-|1.0.19
vscode-jupyter-cell-tags|ms-|0.1.9
vscode-jupyter-slideshow|ms-|0.1.6
remote-wsl|ms-|0.88.2
hexeditor|ms-|1.10.0
vscode-diagnostic-tools|ms-|1.2.0
vscode-github-issue-notebooks|ms-|0.0.130
vscode-typescript-next|ms-|5.7.20240826
vsliveshare|ms-|1.0.5936
bun-vscode|ove|0.0.12
vscode-yaml|red|1.15.0
cody-ai|sou|1.33.1724685353
graphviz-interactive-preview|tin|0.3.5
tldraw-vscode|tld|2.9.0
vim|vsc|1.28.0
pretty-ts-errors|Yoa|0.6.0
</details>
<!-- generated by issue reporter -->
https://github.com/user-attachments/assets/aa0a7fbb-bb22-4da5-9854-9dcfea571397
| bug,web,notebook | low | Critical |
2,489,440,083 | vscode | Hover on the autocompletion dropdown list item auto pop up | <!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Describe the feature you'd like. -->
I find that `completionItem.documentation` need to be highlighted and user need to click on one of the documentations to show up.
**Can we add a feature to show the documentation when hovering over a completion item?**
For example, is there any services like `hoverProvider` that works on **completion Item**?
| feature-request,ux,suggest | medium | Major |
2,489,447,268 | vscode | SCM Graph - On refresh, do not lose the current selection | Testing #226648
When clicking refresh, it would be great if the currently selected commit could be selected (and revealed) again.
If that works, that will allow to automatically refresh when a fetch detects new commit. | scm,under-discussion | low | Minor |
2,489,449,643 | vscode | How should bad/stale providers be handled? | Testing #226668
Have a provider that just does this `return new Promise(() => { /* NEVER resolve */ });`, e.g it never returns and today it can stall the whole find widget. This is how we usually do it (e.g for suggest or references) but I wonder if search should do something more nuanced, like showing results from providers as they come? | feature-request,search,search-api | low | Minor |
2,489,539,740 | stable-diffusion-webui | [Bug]: "Sampler Scheduler autocorrection" when using the API | ### Checklist
- [X] The issue exists after disabling all extensions
- [X] The issue exists on a clean installation of webui
- [ ] The issue is caused by an extension, but I believe it is caused by a bug in the webui
- [X] The issue exists in the current version of the webui
- [X] The issue has not been reported before recently
- [ ] The issue has been reported before but has not been fixed yet
### What happened?
When using the API, there is a warning on the console:
> Sampler Scheduler autocorrection: "Euler a" -> "Euler a", "automatic" -> "Automatic"
It is no major issue as it works correctly, but it looks like the API default is lowercase and the webui expects the name to start with a capital letter.
When explicitly setting the `scheduler` parameter in the API call to `Automatic`, it works without warning.
### Steps to reproduce the problem
1. Render an image using the `/sdapi/v1/txt2img` API endpoint without giving a sampler or scheduler selection
### What should have happened?
The API default should match a valid scheduler. In this case it looks like it should be `Automatic` with capital A.
### Console logs
```Shell
WARNING:root:Sampler Scheduler autocorrection: "Euler a" -> "Euler a", "automatic" -> "Automatic"███████████████████████████████████████████████████████████████████████████████████████████████████████████████| 20/20 [00:03<00:00, 6.87it/s]
100%|
``` | not-an-issue | low | Critical |
2,489,552,565 | vscode | Clicking the link in the description of `window.experimentalControlOverlay` doesn't go to the linked issue | Testing #226397
| bug,settings-editor,confirmed | low | Minor |
2,489,567,560 | pytorch | [MPS] BatchNorm2D produces incorrect results for column first tensors | ### 🐛 Describe the bug
Discovered while fixing BatchNorm2D for empty tensors (marked as reason for skip in https://github.com/pytorch/pytorch/issues/100914 ) and attempting to remove https://github.com/pytorch/pytorch/blob/3418708abfc21d190a4658c477bfb2f42ac107f6/torch/testing/_internal/common_modules.py#L3462-L3464
```
% python test_modules.py -v -k test_memory_format_nn_BatchNorm2d_
FAIL: test_memory_format_nn_BatchNorm2d_eval_mode_mps_float32 (__main__.TestModuleMPS)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/malfet/git/pytorch/pytorch/torch/testing/_internal/common_utils.py", line 2962, in wrapper
method(*args, **kwargs)
File "/Users/malfet/git/pytorch/pytorch/torch/testing/_internal/common_device_type.py", line 448, in instantiated_test
result = test(self, **param_kwargs)
File "/Users/malfet/git/pytorch/pytorch/torch/testing/_internal/common_utils.py", line 1522, in wrapper
fn(*args, **kwargs)
File "/Users/malfet/git/pytorch/pytorch/torch/testing/_internal/common_modules.py", line 129, in test_wrapper
return test(*args, **kwargs)
File "/Users/malfet/git/pytorch/pytorch/torch/testing/_internal/common_cuda.py", line 225, in wrapped
return f(*args, **kwargs)
File "/Users/malfet/git/pytorch/pytorch/test/test_modules.py", line 745, in test_memory_format
self.assertEqual(outputs, desired_outputs, rtol=rtol, atol=atol)
File "/Users/malfet/git/pytorch/pytorch/torch/testing/_internal/common_utils.py", line 3868, in assertEqual
raise error_metas.pop()[0].to_error(
AssertionError: Tensor-likes are not close!
Mismatched elements: 212 / 216 (98.1%)
Greatest absolute difference: 16.83740234375 at index (0, 0, 5, 0) (up to 1e-05 allowed)
Greatest relative difference: 178.90695190429688 at index (0, 1, 4, 3) (up to 1e-05 allowed)
To execute this test, run the following from the base repo dir:
python test/test_modules.py TestModuleMPS.test_memory_format_nn_BatchNorm2d_eval_mode_mps_float32
This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
```
I suspect it's caused by https://github.com/pytorch/pytorch/pull/133610 though unsure whether or not it worked before
### Versions
nightly
cc @ezyang @gchanan @zou3519 @kadeng @msaroufim @kulinseth @albanD @DenisVieriu97 @jhavukainen | high priority,triaged,module: correctness (silent),module: mps | medium | Critical |
2,489,576,013 | vscode | Sorting comments uses filter icon, not a sort icon | Testing #226657
While filtering is certainly related to sorting, they're different things. I was not expecting sort actions to be there:
I see we have this icon:
But I was expecting one like this:
or
| bug,comments | low | Minor |
2,489,590,320 | pytorch | Give a better error message on Python custom ops x AOTI | Right now AOTI just complains that it can't find the custom op.
cc @ezyang @chauhang @penguinwu @bdhirsh @desertfire @chenyang78 | triaged,module: custom-operators,oncall: pt2,module: pt2-dispatcher,module: aotinductor | low | Critical |
2,489,623,029 | PowerToys | PowerRename ignores greek letter "ς" (final sigma) in formatting, when changing beween lower and upper case | ### Microsoft PowerToys version
0.83.0
### Installation method
Microsoft Store
### Running as admin
Yes
### Area(s) with issue?
PowerRename
### Steps to reproduce
Create a simple .txt file (or use any kind of file you like) and rename it to "Δοκιμαστικός" (without the quotes).
Use PowerRename to change the file name to UPPERCASE.
[PowerToysReport_2024-08-27-17-37-57.zip](https://github.com/user-attachments/files/16763829/PowerToysReport_2024-08-27-17-37-57.zip)
### ✔️ Expected Behavior
After changing to uppercase, the file name should be: ΔΟΚΙΜΑΣΤΙΚΟΣ.txt
The letter "ς" (final sigma) is the same as "σ", but it is used only when it is the last letter of a word. So, it should be changed to "Σ".
Also, when changing to lowercase, if "Σ" is the last letter of a word (ONLY then), it should be changed to "ς", not "σ".
### ❌ Actual Behavior
Instead it changes to: ΔΟΚΙΜΑΣΤΙΚΌς.txt
"σ" is correctly changed to "Σ", but unfortunatelly "ς" remains the same.
Also, when "Σ" is the last letter of a word, after changing to lowercase it becomes "σ", which is wrong.
Since it is the last letter, it should become "ς" (final sigma).
### Other Software
_No response_ | Issue-Bug,Area-Localization,Product-PowerRename,Needs-Triage | low | Minor |
2,489,628,162 | vscode | Only clicking on the icon expands collapsed cells, not the entire sash. | Testing #226663
I expect to be able to click on the entire sash, not just the icon.
| feature-request,notebook-diff | low | Major |
2,489,673,700 | svelte | [AST] Incorrect parsing of comments inside the callback scope | ### Describe the bug
Sorry in advance, but I might be bringing a PITA with comments, again.
I noticed while working on updating `svelte-ast-print`, I've had inline snapshots mismatch _(thanks Vitest!)_.
There was a bug which I've overlooked before and noticed that something was off. I was able to narrow that there's a parsing difference between version `svelte@5.0.0-next.190` and `svelte@5.0.0-next.191`. Regardless, both versions parse it wrongly, including the latest one.
Possibly related PR: https://github.com/sveltejs/svelte/pull/12471
Piece of input inside the `<script>` tag that gets parsed wrong:
```js
beforeUpdate(() => {
// determine whether we should auto-scroll
// once the DOM is updated...
});
afterUpdate(() => {
// ...the DOM is now in sync with the data
});
```
<table>
<thead>
<tr>
<th>
`svelte@5.0.0-next.190`
</th>
<th>
`svelte@5.0.0-next.191`
</th>
</tr>
</thead>
<tbody>
<tr>
<td>
```diff
- beforeUpdate(() => {
- // determine whether we should auto-scroll
+ beforeUpdate(() => {}); // determine whether we should auto-scroll
- // once the DOM is updated...
+ // once the DOM is updated...
- });
-
- afterUpdate(() => {
- // ...the DOM is now in sync with the data
- });
+ afterUpdate(() => {}); // ...the DOM is now in sync with the data
```
</td>
<td>
```diff
- beforeUpdate(() => {
+ beforeUpdate(() => {});
- // determine whether we should auto-scroll
+ // determine whether we should auto-scroll
- // once the DOM is updated...
+ // once the DOM is updated...
- });
-
- afterUpdate(() => {
+ afterUpdate(() => {});
+
- // ...the DOM is now in sync with the data
+ // ...the DOM is now in sync with the data
- });
-
```
</td>
</tr>
</tbody>
<table>
Below I will provide a simple reproduction where you can see that the comment inside the callback scope of `beforeUpdate()` gets wrongly parsed as `trailingComments`.
### Reproduction
https://svelte-5-preview.vercel.app/#H4sIAAAAAAAAE02OywrCMBBFf2WYTS0Uum-14D_oyriIyZQG8yIzFaT03yUI4vIezoG74ew8MQ63DaMOhAOec8YO5Z3r4Bd5IeyQ01pMJUc2xWWZVFTiQk5FYIMHzanQNVstBDvMJQVovm0zqljdf-VwaOE0wVa5kr6Hy-IYTAqBogAvafUWWPQbXGRnCYz2_qHNE9ikTDXb21HFY_87gx2GZN3syOIgZaX9vn8AcUwca90AAAA=
### Logs
_No response_
### System Info
```shell
next
```
### Severity
annoyance | feature request | low | Critical |
2,489,691,285 | ui | [feat]: Conform support for forms | ### Feature description
It would be nice if there's a [Conform](https://conform.guide) version of `<Form />` alongside with the current react-hook-form one.
### Affected component/components
Form
### Additional Context
Additional details here...
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues and PRs | area: request | low | Major |
2,489,702,822 | ollama | stella_en_400M_v5 model request | Need help supporting
https://hf.rst.im/dunzhang/stella_en_400M_v5
since we have also https://ollama.com/Losspost/stella_en_1.5b_v5 | model request | low | Minor |
2,489,740,316 | vscode | Show raw json sync file doesn't open the file | While trying to investigate why a sync happened:
| bug,settings-sync | low | Minor |
2,489,749,514 | vscode | Imported file has a sha in the path | Testing #226653
* open https://insiders.vscode.dev/github/microsoft/vscode-anycode/blob/main/anycode/client/src/node/main.ts#L7
* cmd+click on CommonLanguageClient from the imports
* observe complex URL
| bug,typescript,javascript,web | low | Minor |
2,489,800,077 | deno | deno cache returns 133 error | Version: Deno 1.46.1
The `deno cache` command returns an error code of 133 when run with Deno 1.46.1 on my Macbook Pro (M2).
For instance, running this...
`deno cache --node-modules-dir=false --unstable-worker-options --unstable-ffi --unstable-temporal --config=./tsconfig.json --import-map=./import-map.json ./src/main.ts`
Causes this output...
`zsh: trace trap deno cache --node-modules-dir=false --unstable-worker-options --unstable-ffi`
Further analysis shows the error code being returned is 133 (Trace/BPT trap: 5).
| needs info | low | Critical |
2,489,840,390 | PowerToys | Power Toys Color Picker | ### Microsoft PowerToys version
0.83.0
### Installation method
PowerToys auto-update
### Running as admin
Yes
### Area(s) with issue?
ColorPicker
### Steps to reproduce
Application Popup: PowerToys.ColorPickerUI.exe - Entry point not found: OpenGmm procedure entry point not found in the dynamic link library C:\WINDOWS\System32\DriverStore\FileRepository\iigd_dch.inf_amd64_08c6076a1ac36ac6\igd9dxva64.dll.
### ✔️ Expected Behavior
_No response_
### ❌ Actual Behavior
_No response_
### Other Software
update Intel Graphics Driver 31.0.101.2128 | Issue-Bug,Needs-Triage | low | Minor |
2,489,844,515 | PowerToys | FancyZone layout editor not covering full screen | ### Microsoft PowerToys version
0.83.0
### Installation method
PowerToys auto-update
### Running as admin
Yes
### Area(s) with issue?
FancyZones Editor
### Steps to reproduce
Use a monitor with a resolution of 5120x1440, launch fancy zone editor.
### ✔️ Expected Behavior
The editor displays an overlay over the entire screen to allocate where to snap zones.
### ❌ Actual Behavior
A portion of the overlay is not covering the right half of the screen.
### Other Software
_No response_ | Issue-Bug,FancyZones-Editor,Product-FancyZones,Needs-Triage | low | Minor |
2,489,876,467 | godot | Broken icons in the gizmo visibility popup menu | ### Tested versions
Broken in v4.4.dev.custom_build [142d33211]
Broken in 4.3 stable
### System information
Godot v4.4.dev (142d33211) - macOS 14.5.0 - Metal (Forward+) - integrated Apple M1 Max (Apple7) - Apple M1 Max (10 Threads)
### Issue description
Default theme, fresh editor start:
<img width="1036" alt="s" src="https://github.com/user-attachments/assets/850096bb-6588-4d84-81c4-de18f2526556"><br>
They get fixed if you change the editor theme to something else until the next editor restart
### Steps to reproduce
Just creating a new project with the current master build should be enough
### Minimal reproduction project (MRP)
N/A | bug,topic:editor | low | Critical |
2,489,901,478 | vscode | Unclear why I'd want to `Copy changed line` in notebook diff | Testing #226665
Testing on latest VS Code Insiders on Windows 11 Insiders
```
Version: 1.93.0-insider (user setup)
Commit: ff7a154d5e5e9034914f0466420f0f1407f0c95e
Date: 2024-08-27T05:04:20.235Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.25987
```
I notice a lightbulb will appear in every cell of the notebook diff view to `Copy changed line`:
I'm unclear what this does or why I'd want to do this in every entry of the diff view. I tried clicking on it, but it doesn't seem to then later paste anything? | bug,multi-diff-editor | low | Minor |
2,489,909,420 | vscode | Probably needs some padding at the botton where the scroll shows up | Testing #226665
| bug,multi-diff-editor | low | Minor |
2,489,912,020 | vscode | SCM Graph - Improve name/description of theme keys | Testing #226648
It's not immediately clear what a group is here:
https://github.com/microsoft/vscode/blob/78f4b54aca1c0e9b0b86f2e650e22ceb7217ccba/src/vs/workbench/contrib/scm/browser/scmHistory.ts#L25-L27
I think it would be more clean if these were named:
- `scm.graph.localItemForeground`
- Since the feature is called "source control graph", the history seems unneeded?
- Foreground/background/border is normally a suffix of theme keys
- `scm.graph.remoteItemForeground`
- `scm.graph.mergeBaseItemForeground`
- I think base means merge base here? | scm,under-discussion | low | Minor |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.