showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
yeah silly multi cursor editor	[ 0 ]
unrelated but we should probably kill this code fork and just have one way always be used	[ 0 ]
you culd remove the nd part of this comment only st part is relevant the content does not matter	[ 0 ]
The server has BIG gay, pls fix	[ 1 ]
agree that this line should prabably be removed	[ 0 ]
this backslash is unnecessary and should go away	[ 0 ]
should be a konstant	[ 0 ]
I'm hit by this as well. Currently, I'm using buildah with some custom scripts. There's no way to describe to tilt that it needs to build my base image before the children images, so it just never does. To work around this, I'm rebuilding the base image every time which kinda sucks.	[ 1 ]
i think the above rule are useless	[ 0 ]
if openstack release openstack release ubuntu	[ 0 ]
It's something we can lock down with a shrinkwrap file, the same way we lock deps down with a composer lock file. Our current shrinkwrap implementation doesn't lock down dev-dependencies because the native Node shrinkwrap is a bit rubbish at handing dev-dependencies. We have a workaround in in the above branch which uses https://github.com/uber/npm-shrinkwrap via the `npm run lock` script.	[ 1 ]
You have a ridiculous amount of mods, this is not a vanilla bug.	[ 1 ]
based as fucking hell	[ 1 ]
i had commented on that before seems a little silly	[ 0 ]
damn, I'll just find something in the files	[ 1 ]
Well, 4, on the 1-10 scale, is reasonably competent...8 is pretty damn good. (I suggested it as peak learnable from books, IIRC.) To judge the book by its cover (title), I might think 3-7 or 3-6, but 4-8 is acceptable.	[ 1 ]
No translation file found for domain cddagl' .. and some line numbers I couldn't catch as it closed, something in gettext.py? The path is fairly long so command line sucks :(	[ 1 ]
this would allow instance flavor to be none possibly and it should be nullable false do we care	[ 0 ]
hmm actually this is not a stdlib it should be inserted at line please check other six imports too	[ 0 ]
i wonder how much of the code that is being created to be asyncio compatible is actually handling this error since as far as i understand it every usage of yield from needs to be wrapped in a cancellederror and the code needs to handle this occurring though to what eventlet does that is similar being bad since the code it monkey patches has no idea that a exception like cancellederror maybe raised at least code created for asyncio should be somewhat aware that cancellederror s may happen	[ 0 ]
Merge it faggot. It's better	[ 1 ]
no need to chain filter by this way can put them all into one filter by vlan id vlan id switch ip switch ip port id port id	[ 0 ]
I do not care about the snowflake code's original function. It was bad and it needs to be sent to the hellscape.	[ 1 ]
> Can't get the python script to work if your byond is installed anywhere but the C: Drive Fucking PATH	[ 1 ]
This looks strange, we've created two images but dispose one. Easier is to add dispose listener to the control on which you supply images at the moment you create them.	[ 1 ]
After the first letter, always indent with spaces, otherwise it will look ugly with different tab sizes. (Same for your Lua scripts)	[ 1 ]
Nope, it runtimes, and `.:len` doesn't even compile So we're left with the current check, which doesn't even do what we need. Shit.	[ 1 ]
What is with the disgusting newline here?	[ 1 ]
honestly since this takes a separate var flag anyway i would bundle it into cmdsetdep since they are semantically very similar a ridiculous bonus would be for this to work vars foo revision asdf deps foo var foo revision gclient setdep r foo qwer updates the value of foo revision that would be truly magical that can come later if at all	[ 0 ]
useless spaces	[ 0 ]
Damn, you're right, (and welcome back!)	[ 1 ]
you need to put this one on a sync db conditional	[ 0 ]
This is kind of a weird pattern, the roach always goes to your east or to your west, it'd make more sense if it went in front of you or just always in your tile. But hey this is just a bugfix.	[ 1 ]
for once not my irish spelling iff abreviates if and only if	[ 0 ]
Jesus this is a clusterfuck Just swap the order of this check and the Putin check and make this one `else if()`	[ 1 ]
i can see how it seemed like a good idea at the time but the first time i actually tried to debug anything classpath related not seeing the actual path was a huge pain in the ass	[ 0 ]
bad client should be initialized like fake client	[ 0 ]
if openstack release openstack release ubuntu	[ 0 ]
this should be called devtest overcloud images sh	[ 0 ]
Damn it, thanks for catching that!	[ 1 ]
this is pretty useless see diagassert if you really want to assert but we usually do not bother with null pointers	[ 0 ]
Pretty OP; Goonchem specifically avoids per cycle multiheals because they're mindless--this is effectively better than even Doctor's Delight considering these are the two most common damage types.	[ 1 ]
the backslash is unnecessary	[ 0 ]
i think this red mark means extra space that should be removed	[ 0 ]
it s a pity you could not use embeddedtestserverrule would it be worth creating something like a embeddedhttpstestserverrule	[ 0 ]
eternal languish and fury of the damned salty souls	[ 1 ]
you can actually pass null as the second argument for some reason we have a lot of callers using dummy variables like this we should probably clean them up one day	[ 0 ]
nit kill everything after the comma in this sentence	[ 0 ]
fk	[ 0 ]
probably something stupid it is restored	[ 0 ]
what the hell is this o_O	[ 1 ]
retry count should be lowercase because it is not a constant	[ 0 ]
s of useless is useless	[ 0 ]
this signal is shit. it's a proc disguised as a signal.	[ 1 ]
i would like to see some white space to make the bullets stand out	[ 0 ]
Swishy is gay, Unban me from .gg/london you neek! :rage:	[ 1 ]
this was uncomfortably difficult for me to parse while we are here can we just make this winner deltas loser deltas	[ 0 ]
Oh wait it scrolled off the screen, silly me. But yeah, that many tabs is silly	[ 1 ]
fake fakedeploy imo should be here for fake driver	[ 0 ]
I think I know whats happened with tests 2 and 5 of group 2. In test 2 you need to update the first row in the table to have A=0.2 and phi=1.5 otherwise it gives rubbish In test 5, you have the tiled by option set to Run instead of group/pair (its above the plot)	[ 1 ]
are dwo files generated for arm with debug fission apparently they are not generated for x	[ 0 ]
ah that is one part of the console protocol that i should have documented better in case of success the answer should always be ok r n and nothing more the only exception is for the kill command which kills the emulator i would prefer if you keep it that way if you need to send information back dump it with lines ending with r n then dump ok r n	[ 0 ]
zopfli is used by update assets sh to compress the assets when they change	[ 0 ]
it seems you are still using self nested templ with server rather it should be files the yaml self nested templ	[ 0 ]
HOLY SHIT IT'S BACK BABY IT'S FUCKING BACK HOLY SHIT	[ 1 ]
@drequivalent Do you mean "why hasn't this clearly excellent feature been made yet" or "why hasn't this obviously rubbish feature request been closed yet?" Anyway, there are lots of issues on this list that have been open for years.	[ 1 ]
Either of these approaches still have the same ECS problem of access modifiers being shit because any system can modify this when they really shouldn't but I'll change it.	[ 1 ]
like this rk platform termination	[ 0 ]
Damn, so it is also wrong in the calicoctl code as I copy-pasted it here :-/	[ 1 ]
this way of patching is a bit dirty because if we want to change how the client works then we have to patch your writer too	[ 0 ]
code style issue fixed on merge --- NB: That code style rule is rubbish	[ 1 ]
why are you putting you want this under builddir	[ 0 ]
please leave init py empty	[ 0 ]
just use as the rule dummy dummy is not valid rule i think	[ 0 ]
eliminate backslash	[ 0 ]
This is kinda scary... Along with the one in `IncompatibilityDisplayingModButton`. Because the mod is used to display the tooltip.	[ 1 ]
i suppose that l should be executed after this one please move l after if else fi statement	[ 0 ]
1. Why is a campfire checking for cell charge what is this lazy copy paste shit. 2. There should be feedback to the player that it didn't work and why.	[ 1 ]
yeah you are right my bad testing return is kinda dumb like that l	[ 0 ]
All of this out into a separate function? `ValidateRenderPassPipelineBarriers` is getting ridiculously large.	[ 1 ]
Ehh let me figure this cyclic import nonsense out.	[ 1 ]
might be a stupid question but why is this different from the addcleanup tool	[ 0 ]
hmm seems i made a stupid rebase	[ 0 ]
The absolute worst part .. I intended to do what @LordAro mentions .. but somewhere my brain said: fuck this, and went his own way ;)	[ 1 ]
uuid strategy utils generate uuid	[ 0 ]
I spent a hour debugging this shit, and then suddenly understood that someone could forgot ..() in New(), and that's why a machine isn't in machines list.	[ 1 ]
hmm does the end person want to know what state it was trying to be set to when it failed nostate seems somewhat useless	[ 0 ]
i really got to learn git ryan plz go ahead and change the owner as it is your patch in the meantime i will figure out what stupidity i am doing	[ 0 ]
suggest uuid uuid in place of random randint	[ 0 ]
do you know the difference between dump and dumps	[ 0 ]
It inherits it from 1953: all badass costumes are nuke and clown ops only.	[ 1 ]
i would replace the ndashes here and on line with either an unspaced mdash or a colon preferred alternatively you could make this a varlist	[ 0 ]
should be a volumedriverexception rather than cinderexception	[ 0 ]
taskhelper update verify networks	[ 0 ]
Also for some fucking reason the animated states for the cult bedsheet work but the cosmos bedsheet doesn't. I swear to god I couldn't figger it out so I just left it. I'll fix it later gtfo of my face femboy.	[ 1 ]
this attach interface not found case is almost the same as the one of v api test so how about defining not found case exception exc httpnotfound in interfaceattachtestsv class and defining not found case exception exc httpbadrequest in interfaceattachtestsv class and replacing self assertraises exc httpbadrequest self assertraises self not found case exception in attach interface not found case of interfaceattachtestsv	[ 0 ]
we were told to remove these from our cinder drivers as cinder team is not ready to adopt this yet just use x as before	[ 0 ]
please remove all trailing whitespaces	[ 0 ]
ohhh brother. That's a lot to put on one line. Maybe just like, suck it up and make it an if check?	[ 1 ]
nullptr	[ 0 ]

yeah silly multi cursor editor

[ 0 ]

unrelated but we should probably kill this code fork and just have one way always be used

[ 0 ]

you culd remove the nd part of this comment only st part is relevant the content does not matter

[ 0 ]

The server has BIG gay, pls fix

[ 1 ]

agree that this line should prabably be removed

[ 0 ]

this backslash is unnecessary and should go away

[ 0 ]

should be a konstant

[ 0 ]

I'm hit by this as well. Currently, I'm using buildah with some custom scripts. There's no way to describe to tilt that it needs to build my base image before the children images, so it just never does. To work around this, I'm rebuilding the base image every time which kinda sucks.

[ 1 ]

i think the above rule are useless

[ 0 ]

if openstack release openstack release ubuntu

[ 0 ]

It's something we can lock down with a shrinkwrap file, the same way we lock deps down with a composer lock file. Our current shrinkwrap implementation doesn't lock down dev-dependencies because the native Node shrinkwrap is a bit rubbish at handing dev-dependencies. We have a workaround in in the above branch which uses https://github.com/uber/npm-shrinkwrap via the `npm run lock` script.

[ 1 ]

You have a ridiculous amount of mods, this is not a vanilla bug.

[ 1 ]

based as fucking hell

[ 1 ]

i had commented on that before seems a little silly

[ 0 ]

damn, I'll just find something in the files

[ 1 ]

Well, 4, on the 1-10 scale, is reasonably competent...8 is pretty damn good. (I suggested it as peak learnable from books, IIRC.) To judge the book by its cover (title), I might think 3-7 or 3-6, but 4-8 is acceptable.

[ 1 ]

No translation file found for domain cddagl' .. and some line numbers I couldn't catch as it closed, something in gettext.py? The path is fairly long so command line sucks :(

[ 1 ]

this would allow instance flavor to be none possibly and it should be nullable false do we care

[ 0 ]

hmm actually this is not a stdlib it should be inserted at line please check other six imports too

[ 0 ]

i wonder how much of the code that is being created to be asyncio compatible is actually handling this error since as far as i understand it every usage of yield from needs to be wrapped in a cancellederror and the code needs to handle this occurring though to what eventlet does that is similar being bad since the code it monkey patches has no idea that a exception like cancellederror maybe raised at least code created for asyncio should be somewhat aware that cancellederror s may happen

[ 0 ]

Merge it faggot. It's better

[ 1 ]

no need to chain filter by this way can put them all into one filter by vlan id vlan id switch ip switch ip port id port id

[ 0 ]

I do not care about the snowflake code's original function. It was bad and it needs to be sent to the hellscape.

[ 1 ]

> Can't get the python script to work if your byond is installed anywhere but the C: Drive Fucking PATH

[ 1 ]

This looks strange, we've created two images but dispose one. Easier is to add dispose listener to the control on which you supply images at the moment you create them.

[ 1 ]

After the first letter, always indent with spaces, otherwise it will look ugly with different tab sizes. (Same for your Lua scripts)

[ 1 ]

Nope, it runtimes, and `.:len` doesn't even compile So we're left with the current check, which doesn't even do what we need. Shit.

[ 1 ]

What is with the disgusting newline here?

[ 1 ]

honestly since this takes a separate var flag anyway i would bundle it into cmdsetdep since they are semantically very similar a ridiculous bonus would be for this to work vars foo revision asdf deps foo var foo revision gclient setdep r foo qwer updates the value of foo revision that would be truly magical that can come later if at all

[ 0 ]

useless spaces

[ 0 ]

Damn, you're right, (and welcome back!)

[ 1 ]

you need to put this one on a sync db conditional

[ 0 ]

This is kind of a weird pattern, the roach always goes to your east or to your west, it'd make more sense if it went in front of you or just always in your tile. But hey this is just a bugfix.

[ 1 ]

for once not my irish spelling iff abreviates if and only if

[ 0 ]

Jesus this is a clusterfuck Just swap the order of this check and the Putin check and make this one `else if()`

[ 1 ]

i can see how it seemed like a good idea at the time but the first time i actually tried to debug anything classpath related not seeing the actual path was a huge pain in the ass

[ 0 ]

bad client should be initialized like fake client

[ 0 ]

if openstack release openstack release ubuntu

[ 0 ]

this should be called devtest overcloud images sh

[ 0 ]

Damn it, thanks for catching that!

[ 1 ]

this is pretty useless see diagassert if you really want to assert but we usually do not bother with null pointers

[ 0 ]

Pretty OP; Goonchem specifically avoids per cycle multiheals because they're mindless--this is effectively better than even Doctor's Delight considering these are the two most common damage types.

[ 1 ]

the backslash is unnecessary

[ 0 ]

i think this red mark means extra space that should be removed

[ 0 ]

it s a pity you could not use embeddedtestserverrule would it be worth creating something like a embeddedhttpstestserverrule

[ 0 ]

eternal languish and fury of the damned salty souls

[ 1 ]

you can actually pass null as the second argument for some reason we have a lot of callers using dummy variables like this we should probably clean them up one day

[ 0 ]

nit kill everything after the comma in this sentence

[ 0 ]

fk

[ 0 ]

probably something stupid it is restored

[ 0 ]

what the hell is this o_O

[ 1 ]

retry count should be lowercase because it is not a constant

[ 0 ]

s of useless is useless

[ 0 ]

this signal is shit. it's a proc disguised as a signal.

[ 1 ]

i would like to see some white space to make the bullets stand out

[ 0 ]

Swishy is gay, Unban me from .gg/london you neek! :rage:

[ 1 ]

this was uncomfortably difficult for me to parse while we are here can we just make this winner deltas loser deltas

[ 0 ]

Oh wait it scrolled off the screen, silly me. But yeah, that many tabs is silly

[ 1 ]

fake fakedeploy imo should be here for fake driver

[ 0 ]

I think I know whats happened with tests 2 and 5 of group 2. In test 2 you need to update the first row in the table to have A=0.2 and phi=1.5 otherwise it gives rubbish In test 5, you have the tiled by option set to Run instead of group/pair (its above the plot)

[ 1 ]

are dwo files generated for arm with debug fission apparently they are not generated for x

[ 0 ]

ah that is one part of the console protocol that i should have documented better in case of success the answer should always be ok r n and nothing more the only exception is for the kill command which kills the emulator i would prefer if you keep it that way if you need to send information back dump it with lines ending with r n then dump ok r n

[ 0 ]

zopfli is used by update assets sh to compress the assets when they change

[ 0 ]

it seems you are still using self nested templ with server rather it should be files the yaml self nested templ

[ 0 ]

HOLY SHIT IT'S BACK BABY IT'S FUCKING BACK HOLY SHIT

[ 1 ]

@drequivalent Do you mean "why hasn't this clearly excellent feature been made yet" or "why hasn't this obviously rubbish feature request been closed yet?" Anyway, there are lots of issues on this list that have been open for years.

[ 1 ]

Either of these approaches still have the same ECS problem of access modifiers being shit because any system can modify this when they really shouldn't but I'll change it.

[ 1 ]

like this rk platform termination

[ 0 ]

Damn, so it is also wrong in the calicoctl code as I copy-pasted it here :-/

[ 1 ]

this way of patching is a bit dirty because if we want to change how the client works then we have to patch your writer too

[ 0 ]

code style issue fixed on merge --- NB: That code style rule is rubbish

[ 1 ]

why are you putting you want this under builddir

[ 0 ]

please leave init py empty

[ 0 ]

just use as the rule dummy dummy is not valid rule i think

[ 0 ]

eliminate backslash

[ 0 ]

This is kinda scary... Along with the one in `IncompatibilityDisplayingModButton`. Because the mod is used to display the tooltip.

[ 1 ]

i suppose that l should be executed after this one please move l after if else fi statement

[ 0 ]

1. Why is a campfire checking for cell charge what is this lazy copy paste shit. 2. There should be feedback to the player that it didn't work and why.

[ 1 ]

yeah you are right my bad testing return is kinda dumb like that l

[ 0 ]

All of this out into a separate function? `ValidateRenderPassPipelineBarriers` is getting ridiculously large.

[ 1 ]

Ehh let me figure this cyclic import nonsense out.

[ 1 ]

might be a stupid question but why is this different from the addcleanup tool

[ 0 ]

hmm seems i made a stupid rebase

[ 0 ]

The absolute worst part .. I intended to do what @LordAro mentions .. but somewhere my brain said: fuck this, and went his own way ;)

[ 1 ]

uuid strategy utils generate uuid

[ 0 ]

I spent a hour debugging this shit, and then suddenly understood that someone could forgot ..() in New(), and that's why a machine isn't in machines list.

[ 1 ]

hmm does the end person want to know what state it was trying to be set to when it failed nostate seems somewhat useless

[ 0 ]

i really got to learn git ryan plz go ahead and change the owner as it is your patch in the meantime i will figure out what stupidity i am doing

[ 0 ]

suggest uuid uuid in place of random randint

[ 0 ]

do you know the difference between dump and dumps

[ 0 ]

It inherits it from 1953: all badass costumes are nuke and clown ops only.

[ 1 ]

i would replace the ndashes here and on line with either an unspaced mdash or a colon preferred alternatively you could make this a varlist

[ 0 ]

should be a volumedriverexception rather than cinderexception

[ 0 ]

taskhelper update verify networks

[ 0 ]

Also for some fucking reason the animated states for the cult bedsheet work but the cosmos bedsheet doesn't. I swear to god I couldn't figger it out so I just left it. I'll fix it later gtfo of my face femboy.

[ 1 ]

this attach interface not found case is almost the same as the one of v api test so how about defining not found case exception exc httpnotfound in interfaceattachtestsv class and defining not found case exception exc httpbadrequest in interfaceattachtestsv class and replacing self assertraises exc httpbadrequest self assertraises self not found case exception in attach interface not found case of interfaceattachtestsv

[ 0 ]

we were told to remove these from our cinder drivers as cinder team is not ready to adopt this yet just use x as before

[ 0 ]

please remove all trailing whitespaces

[ 0 ]

ohhh brother. That's a lot to put on one line. Maybe just like, suck it up and make it an if check?

[ 1 ]

nullptr

[ 0 ]