text
stringlengths
1
5.2k
labels
listlengths
1
1
this exec ipmitool method will attempt times l if the command fail so for our validate method that is no need to have try with times so how do you think if we add new parameter for exec ipmitool method default is as below def exec ipmitool driver info command attempts so we just call it with attempts here for validation action exec ipmitool driver info mc info attempts
[ 0 ]
nice did not know about that i hate the code thing javadoc should be a wiki like syntax not simplified html
[ 0 ]
nit this is decryption middleware
[ 0 ]
if you will have nested directories in your path that endswith rules then os path exists dir will return true but os remove will fail because it cannot remove directories use os path isfile instead moreover that fact than os path exists return to you that fact than file exists does not means that this file will exist when os remove call will be executed why do not use try os remove filename except oserror some piece of s t
[ 0 ]
the fuck is this shit
[ 1 ]
useless untested perf nit opinion basically we could actually do if if nova object name in db obj since it is a string which might be slightly better than doing full json loads twice
[ 0 ]
Thank fuck for that. For reference: ![Pasted Image 1.png](https://shipusercontent.com/9d9437c9d0b4fda229706423c085204d/Pasted%20Image%201.png)
[ 1 ]
HOLY FUCKING BLECH BATMAN
[ 1 ]
It should be changed. It is kind of ridiculous now.
[ 1 ]
should we still log a meaningful message if the cluster was not found instead of having an attributeerror
[ 0 ]
what is the purpose of waiting in case if need to wait until program exits i recommend next solution local kill if pid then return fi kill pid dev null for i in seq nailgun start max wait time do if kill pid dev null then kill sleep else kill break fi done if kill ne then kill pid dev null fi return
[ 0 ]
Damn, is it really? That's a shame cuz it makes this harder. Maybe we use this fix for now and spend some hammock time thinking about a good abstraction for this.
[ 1 ]
that repeats the ugly instantiation twice it encapsulates the typedef better though i do not think that is really that important in tests with respect to the name the assembler class is assemblerx thus the name
[ 0 ]
why not unite the above lines to one from neutron openstack common gettestutils import lw le
[ 0 ]
perhaps it might worth removing floating ip from self free floating ips
[ 0 ]
whitespaces should be removed
[ 0 ]
midonet client midonet neutron client api midonetapiclient midonet use zoom false
[ 0 ]
if client auth auth type none
[ 0 ]
Damn this is ridiculous, sorry about this purgatory you are stuck in. Have you recently angered an ancient god? I'm going to restart the tests and see if they pass. They have been very flaky lately and it seems like you're getting the worst of it.
[ 1 ]
why the hell is its throwforce so high?
[ 1 ]
Why the hell is this var gost
[ 1 ]
@Iamgoofball not sure how I'd darken just the vis contents instead of everything on the tile. I ended up doing a filter thing as everything else looked like crap.
[ 1 ]
this is a subset of code bin header v flcn perhaps you can reuse the header
[ 0 ]
90.*CLHEP::deg; this is simply ridiculous… please use angles in radiant
[ 1 ]
my fault but please remove the semi colon while you are at it
[ 0 ]
several e checks are wrong and contradict pep we should ignore them
[ 0 ]
maybe rather than wrapping the body of the function in if we could wrap the call to this function on line detail skip pingtest cleanup can be written more conventionally like skip pingtest cleanup
[ 0 ]
just let this declare that it throws interruptedexception otherwise you have a bug if daemon stop is called while waiting it might claim finalization took seconds when it really didn t
[ 0 ]
ceph osd unset noout
[ 0 ]
what if you add always unused to the junk decl from linux compiler h does the warning go away then
[ 0 ]
@sdegueldre Damn, I've been caught! I removed it ^^
[ 1 ]
ok i suggest you actually write refers to the config element here then otherwise dumb people like me will wonder where the pool table is in the snooker room presumably
[ 0 ]
Use `generic_string` to get a `nicely/separated/path/` instead of `stupid\\\\microsoft\\\\bullshit`.
[ 1 ]
rpc api version should be bumped to
[ 0 ]
Bump. @tldahlgren @tgamblin is this being looked at? It's extremely important to many of us who use Spack in our app distribution models that the installation is not sucking up configurations from the user's home directory.
[ 1 ]
It is honestly a pleasure @aateeqi , I am very happy to review things and help if needed. If you'd like any further reviews, just ping me and I shall check it within the day (timezone nonsense and all that). Happy and safe holidays to you.
[ 1 ]
This will almost always be a lie. It won't be recent at all.
[ 1 ]
this fucking line, I love this fucking line
[ 1 ]
Pushed with the gem version updates. The only blog page(s) I see that are a bit wacky are the ones generated through the calendar template, e.g. http://localhost:4567/blog/2017/04/ when running the site locally.
[ 1 ]
it will be nice to put here self aborted false so in benchmark engine we will be able to understand was this benchmark aborted or not take a look at my comment here c rally benchmark runners constant py
[ 0 ]
this is useless just put return value foo keypair at line
[ 0 ]
dumb unicode question can you just encode utf instead
[ 0 ]
useless
[ 0 ]
nice this is fantastic
[ 0 ]
A suggestion: create a local function `getDefaultCount` and return the count for each situation. Ternary operations are ugly in Lua.
[ 1 ]
Holy crap this released already I so can't wait to test this. may I request an option in the debug menu to view the heat from the fire? filling the room. So select display heat radiation and they it overlays heat icon coming from and around fire plus any where else the heat is actually going to. PR this nowwwww I want lol. Thanks
[ 1 ]
no one s looking at this instr state since you manufactured this struct yourself just kill everything here having to do with struct erase info
[ 0 ]
The one causes rebase hell too with the change of indentation,.
[ 1 ]
please move these out so we are not hiding their return code i guess this fools bashate s local foo blah checking
[ 0 ]
damn you Ruby \U0001f923
[ 1 ]
Damn, the character creation UI is a pain to work with. How do we want it to look? A tab with point systems and a tab with descriptions? A tab with point systems and a second tab with point values? Difficulty presets?
[ 1 ]
@phamann I know prototype is a rubbish word but "alpha" isn't something everyone is going to understand. I'd rather err on the side of caution for this release (especially since it will go out before blended container fronts) but of course we can iterate as we go on.
[ 1 ]
crap, they're only addable.... GRRRRRRRRRRR
[ 1 ]
God damn, you're right. I was so sure.
[ 1 ]
nit boolean values are trivial and following the musician s comment these should be dropped
[ 0 ]
iterables concat is lazy there will be no unnecessary loops
[ 0 ]
pls docstring
[ 0 ]
Wacky...
[ 1 ]
we need to memoize the crap out of this
[ 1 ]
all those variables have horrible names it d be nice to switch to more meaningful ones
[ 0 ]
small nits this should be the s dhcp driver does not
[ 0 ]
this line should be removed
[ 0 ]
@gguij004 this is shit, fix this UI when i finish pls
[ 1 ]
remove all author tags
[ 0 ]
What the hells a thingstorm
[ 1 ]
i know kill is a very bad system call name in posix but can we add some information as a comment or at least in the docstring saying that this kill call with the argument will not try to kill the process just saying because it is confusing to call os kill to check the process and after that call kill using utils execute to actually kill the process or another way simpler to check it for the existence of the process would be to check the proc fs e g def check pid pid check for the existence of a pid return os path exists proc d pid
[ 0 ]
This is probably a symptom of #1901. I believe I have a partial fix for that in a branch somewhere, but the long and short of it is that FITS boolean columns are ridiculous.
[ 1 ]
it should be volumemetadataresponseparameters instead of volumemeatadataresponseparameters
[ 0 ]
remove final newline
[ 0 ]
Take the *REM out of this. It'll fuck up the toxin loss stack.
[ 1 ]
this might seem pedantic and stupid but do we really want to take a vast amount i know of memory just so a line does not break
[ 0 ]
nit get instead of compute we re not computing anything
[ 0 ]
should use a manilaexception such as invalidinput
[ 0 ]
adbcommandfailederror is a subclass of commandfailederror so i think that is ok
[ 0 ]
this seems not so useful useless remove it
[ 0 ]
this is what is in the base test l there are ips meant to be assigned to the port the first from the subnet and the second a specific one test is kind of idiot ic
[ 0 ]
will do though the instructions are quite ugly and would make alex cry we need to convert the process to involve an init script
[ 0 ]
i am a coward and i do not want to enable it by default for icehouse i am confident the feature is well designed and implemented even better but as stated earlier i am a coward and i would vote for enabling notifications by default as soon as juno gates open
[ 0 ]
This isn't a verb what the hell are you doingggggggg
[ 1 ]
i suspect we are about to die anyway when we are that low on memory but done
[ 0 ]
pls use cfg conf set override
[ 0 ]
i'm dumb as shit and have no idea how i'd try to slot in an `Adjacent` check
[ 1 ]
quick stupid question but why
[ 0 ]
These should probably have a timer of someone thing like `time = 10` because otherwise, you know people are going to be spamming these just to be annoying.
[ 1 ]
done block length does not include null terminator
[ 0 ]
why are you adding a public virt driver api method for this nothing outside the libvirt driver is using this so making it a public api is pointless and just pollutes the namespace
[ 0 ]
killing the dbus ones seems to work on brillo at least i can confirm experimentally that libutils is needed though
[ 0 ]
kindly remove the white space char
[ 0 ]
if nw info instance info cache network info return
[ 0 ]
useless trailing see the implementation of the rand name function
[ 0 ]
"Kiddo" is a pretty demeaning thing to call an adult. Are we supposed to think the Behemoth captain is a condescending jerk?
[ 1 ]
last year you changed the defaults from naked array to a std vector c
[ 0 ]
I got similar issues and seems it is related to some kind of rubbish code between outlet and back button validation that Ionic do inside, I'm not sure what the problem is, but from my side, to save my time, I just removed this useless component and did re-write my own back button. You can look at my answer in the forum here: https://forum.ionicframework.com/t/ionic-4-back-button-angular/137866/25
[ 1 ]
better to display them in the order they should be executed in the lifecycle of the node
[ 0 ]
i do not know why it was named coffee pot probably due to the name of the project but if you tell me i would be glad to add it name of device should not be unique
[ 0 ]
very well then, I miss the link though, Drag&Drop is clumsy :/ thanks you for answers @sindresorhus @paulmolluzzo
[ 1 ]
does pbr not leave a egg info directory when packaging maybe devstack does that or maybe that was only when using setup py develop
[ 0 ]
i personally do not like sourcing sh files can you actually execute setup java sh on it is own
[ 0 ]
could you try to use what the fuck forward h to avoid include what the fuck string h in header file
[ 0 ]
TODO reminder. I know logic ops suck, but there are games that DO use them. Probably on some checklist. -[Unknown]
[ 1 ]