showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
just abort with a message most android stuff including tests themselves just is not going to work well without android data	[ 0 ]
I know this is tiny, but "DofC" looks kinda weird, just DC would be better. Also it seems that the airport is just outside DC so maybe Virginia (VA) is more appropriate.	[ 1 ]
should probably be utils py then	[ 0 ]
This sentence is a bit weird.	[ 1 ]
This will need to check whether the `brushItem()->tileRegion()` contains the mouse position.	[ 1 ]
you ve injected your new method and grabbed the delete group decorators your method needs to be above	[ 0 ]
static const struct mali dvfs info mali dvfs infotbl	[ 0 ]
its vegetable soup bro wtf	[ 1 ]
it's not a typo, comdom is the original term and likely a bastardized portmanteau of "command" and "dominant"	[ 1 ]
may want to do this self cert required cert required lower true in case someone fat fingered the true	[ 0 ]
create a new src configure and move the econf call to that drop the die too	[ 0 ]
should this maybe be called rootwrap xenapi or rootwrap xen dom i am wondering if dom is not distinct enough to non xen for them to know to ignore this file	[ 0 ]
please get rid of trailing whitespace	[ 0 ]
There's no really good way to handle input in tgui, as far as I know; dropdown menus are a fucking myth for liars that don't exist.	[ 1 ]
Lint. Including a complaint about a welcome.html in the docker folder not having valid links. Linters are a condign punishment for life long pedantic bastards like me.	[ 1 ]
shit. uhhh hold on i'll see if i can find the other ones. wew.	[ 1 ]
please use here self resource def	[ 0 ]
I guess I can change it but I wasn't aware we were taking everything in the shuttle category as canon. It's a joke on ONLY NINETIES KIDS REMEMBER.	[ 1 ]
this function is useless since you would have to first convert your input to a dict first	[ 0 ]
i think there is a case where you dumb example want to lock between nova api and nova scheduler though even if not cross project it can be cross services	[ 0 ]
need to remove trailing white spaces	[ 0 ]
this is wrong you want to essentially copy the implementation from stack task destroy task scheduler dependencytaskgroup self dependencies resource resource destroy reverse true	[ 0 ]
I am once again reminded this godawful script exists	[ 1 ]
right i talked to anusha ramineni in the comments already and am going to remove that bit from the spec	[ 0 ]
Just pass this information into generate functions and modify it, this stacking is pretty ugly.	[ 1 ]
container should be empty already so need to remove	[ 0 ]
Seems like spacing screwed up here. I guess one is tabs, the other is spaces? Best to make it all tabs.	[ 1 ]
replace with `user.mind.add_addiction_points(/datum/addiction/maintenance_drugs, 1000) ///Max that shit out`	[ 1 ]
This project uses C++-style (//) comments.	[ 1 ]
The ridiculous part here is that our selector is already more specific than theirs, so I\u2019m not sure of how it could happen in the first place.	[ 1 ]
thanks for you comment it is really stupid misstake part of old code sorry about it	[ 0 ]
you re going to get a pep violation on this please see	[ 0 ]
this is dumb we have to wait a second or before calling the confirm resize of the instance because we will get an error from the call saying the resize failed even though it had not problem this is likely because the task description or id is set after the verify resize state shows up this needs a little more research on why	[ 0 ]
are useless	[ 0 ]
It's so ridiculous.	[ 1 ]
they will die in next cl but okay	[ 0 ]
wtf i made that var who set its value to that smh	[ 1 ]
These indentations are getting all screwed up by my vim.	[ 1 ]
what the fuck. why tis there an action for that	[ 1 ]
OMG JUST FUCKING FIX YOUR ABOMINATION	[ 1 ]
shitanshu@ check this class.	[ 1 ]
me neither stupid mistake thanks for kindly reviewing will rebase to last master	[ 0 ]
movz out in hi in lo movn out in lo in lo	[ 0 ]
Goddamn it, it's autoremoved.	[ 1 ]
kill spawned	[ 0 ]
this is to only upload dumps without having to create a crashhandler	[ 0 ]
The uttermost shame is that I am long since subscribed to the internals list, but I couldn't get myself to wade through the nonsense of the attached .eml forest that is a PITA to view :/ Perhaps it is just time to switch to the regular format from the digest stuff.	[ 1 ]
Not buggy, but sucks and is full of debug. Need to add an astar subcontroller, but that'll have to be in another PR	[ 1 ]
fuuuck, copypasta is my enemy...	[ 1 ]
The line endings got fucked up on this file, which editor are you using?	[ 1 ]
this is not testing anything a mocked object mock client init can be called in arbitrary ways and will pass it is not actually running the object s code what you want to do is params param list here with mock patch object client client init as mock client init mock client init return value none neutron neutronapi get client my context mock client init assertcalledoncewith params	[ 0 ]
more pedantry i do not think here you mean floating ip with fip but fixed ip can you rename fip to fixed ip in this case just to avoid confusing dumb readers like me	[ 0 ]
no macros please constexpr size t koptionstringmaxlength	[ 0 ]
can move object false	[ 0 ]
Righto, I'll unfuck that tomorrow	[ 1 ]
you really do not need a function and even less a closure here c mon	[ 0 ]
i propose kill s pid it looks fine d proc pid is also good and decreases numbers of forks	[ 0 ]
No fuck off with this shit There are like 3 other ways you could do this at least	[ 1 ]
just copied it my checkpatch actually picked this up i will change it now	[ 0 ]
ngl this field is just a weird way of caching the damagetypeprototype. change it if you want, i wont rip your head off if you dont tho	[ 1 ]
you left the host cpu info field in the returned stats dictionary but you have removed the unit test for it here either remove the host cpu info field from the stats dictionary or keep this unit test in note that on line in nova virt xenapi fake py you changed the return value for the host cpu info field so this unit test will need to be modified accordingly	[ 0 ]
No more children. As god intended for this shitcode	[ 1 ]
this will not cover the wifsignaled case i think you can trigger those with a command like this kill sig	[ 0 ]
just to be clear by a new fix coming up did you mean the monkey patching to eliminate true concurrency c ceilometer cli py	[ 0 ]
this is fantastic	[ 0 ]
damn why did I even try to do this lol	[ 1 ]
i saw that in the log when i ran generate gni sh but it did not change rtcd h files	[ 0 ]
missing param image source	[ 0 ]
`` If a doctor in game wants to be a paramedic, it is completely plausible for them to just go get the uniform and ask the HoP for exterior access. By making it a separate role, you're just limiting players' willingness to go do that.`` your argument sucks, more job slots are good, the HoP exists if people want to change what their job is, it's equally stupid to argue against paramedics for that exact reason	[ 1 ]
This isn't crazy/funny, it's just nonsense, try shopping it around to one of the sci-fi mods.	[ 1 ]
why did you remove here map	[ 0 ]
pid tid does not matter here	[ 0 ]
FUCK NANO FUCK NANO FUCK NANO FUCK NANO FUCK NANO FUCK NANO FUCK NANO FUCK NANO FUCK NANO FUCK NANO FUCK NANO	[ 1 ]
you are filtering by two fields that are not making a primary key so beside noresultfound one can throw multipleresultfound potentially can you explain how edge id pool vseid is unique and if it is then why not add it as a constrain to the model definition and migration	[ 0 ]
@JackBoosY seems right. (the SDL story was nonsense.)	[ 1 ]
oops this is old it showed up in my diff with upstream libselinux feel free to ignore	[ 0 ]
ah hell you're right, I'll update it	[ 1 ]
I assume there is no way to get the camera position? If a player has a different size he is screwed. He can't place slabs or stairs	[ 1 ]
i think port status notifier should still be a member of mech driver be self port status notifier otherwise it may be garbage collected and stop working	[ 0 ]
testl ecx ecx is smaller	[ 0 ]
should be start execute disksetup	[ 0 ]
openstack common middleware request id py from openstack common middleware import base oslo update sh copies in dependencies	[ 0 ]
you utter coward. not even ONE emoji?	[ 1 ]
but in general, arts sucks.	[ 1 ]
right that was a fuckup while removing origin techs i'll remove it when i'm done and get around to it.	[ 1 ]
hey jordy i think you were looking an old version of the mocks this button should never be disabled if it is disabled users will not have the ability to retry contacting the server	[ 0 ]
@phil235 why the fuck would I buy an item that could be disabled that easily new meta is gonna be shift click all doors before opening them anyways	[ 1 ]
Everything appears to render correctly without the offset. In fact, adding it back in screws things up. Not sure why though.	[ 1 ]
silly nit but knavigate	[ 0 ]
Shit thought i was clever with that early continue.	[ 1 ]
dragent bgpdragent replace all such occurrences	[ 0 ]
sure i would prefer something a little more descriptive than just make sh any preferences make gpu tools sh make autobuild sh	[ 0 ]
Submitter: Heaven The fucking nigger hotpocket eating faggots implemented this piece of shit captcha that somehow is worse than Google's shit and it's not working with 4Chan ecks. Fix it.	[ 1 ]
for regex patterns always do r in your case r s s data vendor id data product id meanwhile is equivalent to match any char the is useless here because overrides it what s the real pattern you want to match here in sys bus hid devices there are directories with names like cb i am just trying to look up the one which contains the vid and pid which genericinput found you may have noticed i do not write a lot of python what i have seems to work but i am sure it is not the best way to do it	[ 0 ]
bool session adopted false	[ 0 ]
@benoitf this is rubbish :worried: I've deleted it. Thanks for this	[ 1 ]
useless unused	[ 0 ]
var/break_that_sucker = fall_on_cross == DESTROY_ON_CROSS	[ 1 ]
An annoying thing is that the title for the new forms cannot start empty.. very weird limitation	[ 1 ]
you re not dumb i forgot to fix up this file too i have also renamed it to clarify what it does better	[ 0 ]

just abort with a message most android stuff including tests themselves just is not going to work well without android data

[ 0 ]

I know this is tiny, but "DofC" looks kinda weird, just DC would be better. Also it seems that the airport is just outside DC so maybe Virginia (VA) is more appropriate.

[ 1 ]

should probably be utils py then

[ 0 ]

This sentence is a bit weird.

[ 1 ]

This will need to check whether the `brushItem()->tileRegion()` contains the mouse position.

[ 1 ]

you ve injected your new method and grabbed the delete group decorators your method needs to be above

[ 0 ]

static const struct mali dvfs info mali dvfs infotbl

[ 0 ]

its vegetable soup bro wtf

[ 1 ]

it's not a typo, comdom is the original term and likely a bastardized portmanteau of "command" and "dominant"

[ 1 ]

may want to do this self cert required cert required lower true in case someone fat fingered the true

[ 0 ]

create a new src configure and move the econf call to that drop the die too

[ 0 ]

should this maybe be called rootwrap xenapi or rootwrap xen dom i am wondering if dom is not distinct enough to non xen for them to know to ignore this file

[ 0 ]

please get rid of trailing whitespace

[ 0 ]

There's no really good way to handle input in tgui, as far as I know; dropdown menus are a fucking myth for liars that don't exist.

[ 1 ]

Lint. Including a complaint about a welcome.html in the docker folder not having valid links. Linters are a condign punishment for life long pedantic bastards like me.

[ 1 ]

shit. uhhh hold on i'll see if i can find the other ones. wew.

[ 1 ]

please use here self resource def

[ 0 ]

I guess I can change it but I wasn't aware we were taking everything in the shuttle category as canon. It's a joke on ONLY NINETIES KIDS REMEMBER.

[ 1 ]

this function is useless since you would have to first convert your input to a dict first

[ 0 ]

i think there is a case where you dumb example want to lock between nova api and nova scheduler though even if not cross project it can be cross services

[ 0 ]

need to remove trailing white spaces

[ 0 ]

this is wrong you want to essentially copy the implementation from stack task destroy task scheduler dependencytaskgroup self dependencies resource resource destroy reverse true

[ 0 ]

I am once again reminded this godawful script exists

[ 1 ]

right i talked to anusha ramineni in the comments already and am going to remove that bit from the spec

[ 0 ]

Just pass this information into generate functions and modify it, this stacking is pretty ugly.

[ 1 ]

container should be empty already so need to remove

[ 0 ]

Seems like spacing screwed up here. I guess one is tabs, the other is spaces? Best to make it all tabs.

[ 1 ]

replace with `user.mind.add_addiction_points(/datum/addiction/maintenance_drugs, 1000) ///Max that shit out`

[ 1 ]

This project uses C++-style (//) comments.

[ 1 ]

The ridiculous part here is that our selector is already more specific than theirs, so I\u2019m not sure of how it could happen in the first place.

[ 1 ]

thanks for you comment it is really stupid misstake part of old code sorry about it

[ 0 ]

you re going to get a pep violation on this please see

[ 0 ]

this is dumb we have to wait a second or before calling the confirm resize of the instance because we will get an error from the call saying the resize failed even though it had not problem this is likely because the task description or id is set after the verify resize state shows up this needs a little more research on why

[ 0 ]

are useless

[ 0 ]

It's so ridiculous.

[ 1 ]

they will die in next cl but okay

[ 0 ]

wtf i made that var who set its value to that smh

[ 1 ]

These indentations are getting all screwed up by my vim.

[ 1 ]

what the fuck. why tis there an action for that

[ 1 ]

OMG JUST FUCKING FIX YOUR ABOMINATION

[ 1 ]

shitanshu@ check this class.

[ 1 ]

me neither stupid mistake thanks for kindly reviewing will rebase to last master

[ 0 ]

movz out in hi in lo movn out in lo in lo

[ 0 ]

Goddamn it, it's autoremoved.

[ 1 ]

kill spawned

[ 0 ]

this is to only upload dumps without having to create a crashhandler

[ 0 ]

The uttermost shame is that I am long since subscribed to the internals list, but I couldn't get myself to wade through the nonsense of the attached .eml forest that is a PITA to view :/ Perhaps it is just time to switch to the regular format from the digest stuff.

[ 1 ]

Not buggy, but sucks and is full of debug. Need to add an astar subcontroller, but that'll have to be in another PR

[ 1 ]

fuuuck, copypasta is my enemy...

[ 1 ]

The line endings got fucked up on this file, which editor are you using?

[ 1 ]

this is not testing anything a mocked object mock client init can be called in arbitrary ways and will pass it is not actually running the object s code what you want to do is params param list here with mock patch object client client init as mock client init mock client init return value none neutron neutronapi get client my context mock client init assertcalledoncewith params

[ 0 ]

more pedantry i do not think here you mean floating ip with fip but fixed ip can you rename fip to fixed ip in this case just to avoid confusing dumb readers like me

[ 0 ]

no macros please constexpr size t koptionstringmaxlength

[ 0 ]

can move object false

[ 0 ]

Righto, I'll unfuck that tomorrow

[ 1 ]

you really do not need a function and even less a closure here c mon

[ 0 ]

i propose kill s pid it looks fine d proc pid is also good and decreases numbers of forks

[ 0 ]

No fuck off with this shit There are like 3 other ways you could do this at least

[ 1 ]

just copied it my checkpatch actually picked this up i will change it now

[ 0 ]

ngl this field is just a weird way of caching the damagetypeprototype. change it if you want, i wont rip your head off if you dont tho

[ 1 ]

you left the host cpu info field in the returned stats dictionary but you have removed the unit test for it here either remove the host cpu info field from the stats dictionary or keep this unit test in note that on line in nova virt xenapi fake py you changed the return value for the host cpu info field so this unit test will need to be modified accordingly

[ 0 ]

No more children. As god intended for this shitcode

[ 1 ]

this will not cover the wifsignaled case i think you can trigger those with a command like this kill sig

[ 0 ]

just to be clear by a new fix coming up did you mean the monkey patching to eliminate true concurrency c ceilometer cli py

[ 0 ]

this is fantastic

[ 0 ]

damn why did I even try to do this lol

[ 1 ]

i saw that in the log when i ran generate gni sh but it did not change rtcd h files

[ 0 ]

missing param image source

[ 0 ]

`` If a doctor in game wants to be a paramedic, it is completely plausible for them to just go get the uniform and ask the HoP for exterior access. By making it a separate role, you're just limiting players' willingness to go do that.`` your argument sucks, more job slots are good, the HoP exists if people want to change what their job is, it's equally stupid to argue against paramedics for that exact reason

[ 1 ]

This isn't crazy/funny, it's just nonsense, try shopping it around to one of the sci-fi mods.

[ 1 ]

why did you remove here map

[ 0 ]

pid tid does not matter here

[ 0 ]

FUCK NANO FUCK NANO FUCK NANO FUCK NANO FUCK NANO FUCK NANO FUCK NANO FUCK NANO FUCK NANO FUCK NANO FUCK NANO

[ 1 ]

you are filtering by two fields that are not making a primary key so beside noresultfound one can throw multipleresultfound potentially can you explain how edge id pool vseid is unique and if it is then why not add it as a constrain to the model definition and migration

[ 0 ]

@JackBoosY seems right. (the SDL story was nonsense.)

[ 1 ]

oops this is old it showed up in my diff with upstream libselinux feel free to ignore

[ 0 ]

ah hell you're right, I'll update it

[ 1 ]

I assume there is no way to get the camera position? If a player has a different size he is screwed. He can't place slabs or stairs

[ 1 ]

i think port status notifier should still be a member of mech driver be self port status notifier otherwise it may be garbage collected and stop working

[ 0 ]

testl ecx ecx is smaller

[ 0 ]

should be start execute disksetup

[ 0 ]

openstack common middleware request id py from openstack common middleware import base oslo update sh copies in dependencies

[ 0 ]

you utter coward. not even ONE emoji?

[ 1 ]

but in general, arts sucks.

[ 1 ]

right that was a fuckup while removing origin techs i'll remove it when i'm done and get around to it.

[ 1 ]

hey jordy i think you were looking an old version of the mocks this button should never be disabled if it is disabled users will not have the ability to retry contacting the server

[ 0 ]

@phil235 why the fuck would I buy an item that could be disabled that easily new meta is gonna be shift click all doors before opening them anyways

[ 1 ]

Everything appears to render correctly without the offset. In fact, adding it back in screws things up. Not sure why though.

[ 1 ]

silly nit but knavigate

[ 0 ]

Shit thought i was clever with that early continue.

[ 1 ]

dragent bgpdragent replace all such occurrences

[ 0 ]

sure i would prefer something a little more descriptive than just make sh any preferences make gpu tools sh make autobuild sh

[ 0 ]

Submitter: Heaven The fucking nigger hotpocket eating faggots implemented this piece of shit captcha that somehow is worse than Google's shit and it's not working with 4Chan ecks. Fix it.

[ 1 ]

for regex patterns always do r in your case r s s data vendor id data product id meanwhile is equivalent to match any char the is useless here because overrides it what s the real pattern you want to match here in sys bus hid devices there are directories with names like cb i am just trying to look up the one which contains the vid and pid which genericinput found you may have noticed i do not write a lot of python what i have seems to work but i am sure it is not the best way to do it

[ 0 ]

bool session adopted false

[ 0 ]

@benoitf this is rubbish :worried: I've deleted it. Thanks for this

[ 1 ]

useless unused

[ 0 ]

var/break_that_sucker = fall_on_cross == DESTROY_ON_CROSS

[ 1 ]

An annoying thing is that the title for the new forms cannot start empty.. very weird limitation

[ 1 ]

you re not dumb i forgot to fix up this file too i have also renamed it to clarify what it does better

[ 0 ]