text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
these two assertions mocks delete snapshot and delete volume should be placed at l because they are actually related to l then these two mocks should be reset and here at l they should be checked that they are not called because we have do delete false at l
|
[
0
] |
finally, damn daniel shoes support
|
[
1
] |
i expect that we should deprecate this for one cycle so the removal should happen in ocata
|
[
0
] |
what our politics about downgrades openstack was decided to disabling them
|
[
0
] |
this reference to config keystone service name should be removed
|
[
0
] |
use sdkconstants class activity
|
[
0
] |
remove all ds store in your next commit
|
[
0
] |
stupid python question but what happens when a class is empty is still valid syntax
|
[
0
] |
suggestion same concurrency times as cinder scenario
|
[
0
] |
if the background is just going to be white we should suet set self view backgroundcolor instead of adding another view
|
[
0
] |
so this is a dumb question i am not sure who what calls spawn but it is not this driver and this is in nova should we be raising ironic exceptions here or converting them to nova exceptions
|
[
0
] |
s called either aodh called aodh
|
[
0
] |
the line break should be here and line should be removed
|
[
0
] |
Crap, this comment is out of date, updating
|
[
1
] |
@wchristian I hate Steam, specially its UI. I think it is rubbish. I see no need for this request, nor a way to implement it on a distributed, federated environment.
|
[
1
] |
my git fuck is weak i will put these back
|
[
0
] |
potentially stupid question here should this be hidden true
|
[
0
] |
not necessary self columns is a tuple
|
[
0
] |
i agree it is a fair compromise for now but i would like us to dedicate some time thinking how valuable it is to verify for consistency something that is being returned by the service this library was built for clients must be a bridge between the service and the user they need to as stupid as possible
|
[
0
] |
all of that is useless
|
[
0
] |
kill this comment
|
[
0
] |
destroy chroot environment implies killing of all processes which are running inside this chroot unmounting of all necessary mountpoints and then finally removing the chroot directory
|
[
0
] |
cool i like the autogenerated uuid
|
[
0
] |
seems like you do not need here to inherit from both classes utils requestscenario is a subclass of base scenario anyway
|
[
0
] |
rebase and this line should be gone
|
[
0
] |
if ra mode and address mode and ra mode address mode
|
[
0
] |
did you mean to nuke this docstring
|
[
0
] |
Matter of fact, what is this hardcoded shit? Go home, and write a proper genetics jobban for this. Don't half-ass this.
|
[
1
] |
can the audit template be generated automatically by calling the nova clis for example or does it have to be populated by hand i guess one can massage the output of nova clis to put it into the right format is there a watcher reset that needs to happen when the operator wants to execute a new audit template
|
[
0
] |
we should call linux net ensure ovs bridge here with datapath system
|
[
0
] |
remove the user kwarg same reason as above
|
[
0
] |
first of all this breaks indentation second this fuction is a little useless see below
|
[
0
] |
This file has a shitload of spacing changes because it was half indented with tabs and half indented with spaces. Now it's indented with only spaces.
|
[
1
] |
this should be like the others below new entity user entity format role data user
|
[
0
] |
why run mysql start o oozie cannot be call from here
|
[
0
] |
remove excess white space
|
[
0
] |
these have the same problem as the parent review asserttrue asserts that the expression token is true and will only use the matcher as an error message if the assertion is false
|
[
0
] |
Also wtf is redefining usr in a proc like this allowed? This should be user not usr imo
|
[
1
] |
Wait, it's not even trailing, it's a while loop exit. Disgusting.
|
[
1
] |
does kill hup reload dnsmasq eith the same pid otherwise we might want to re fetch and update it is value
|
[
0
] |
why is this reimplementing stdlib h s div round up
|
[
0
] |
we only need gpuclient per child process not per identity how can we wire the child id pretty please it s important to associate gpu memory with the right process again it is not about the pid as was done in previous patches but the child id browserchildprocesshostimpl getdata id
|
[
0
] |
That was terrible english
|
[
1
] |
use int ret snprintf better size t prop len snprintf
|
[
0
] |
if you want to check that it works for invalid yaml you should mock yaml load and make yamlerror a side effect there
|
[
0
] |
> I doubt that _not_ adding it is a _significant_ barrier to bots. It's a fixed name root file, how hard can it be? No, `robots.txt` is a fixed name root file. Naming the sitemap `sitemap.xml` is just a convention. > We\u2019ve always felt linking to your XML sitemap from your robots.txt is a bit nonsense. I couldn't disagree more. It is essential for the reasons I've given above.
|
[
1
] |
wtf does 'new header' even mean \u0ca0_\u0ca0
|
[
1
] |
Re added spawning of dickgirls and cuntboys in new system. Started playing around with class functions, I like it.
|
[
1
] |
shouldn t this be step no big deal anyway
|
[
0
] |
Also that get_config_data sucks performance that hard might be worth looking into at some point later as well.
|
[
1
] |
it was my understanding that mocking the call to get bridges in the setup function will result in it being mocked in all tests in this class as the setup function is invoke before each test is run any mocked functions object would cascade into be mocked in each of the test sorry if my first comment was unclear this would normally be true however as the mocks are defined in a with contextlib nested block you are correct it will not cascade as the scope of the mock is limited to the contextlib block i will resubmit the updated patch shortly with this change
|
[
0
] |
I see scanner's still shitcode from 3 years ago (\u256f\xb0\u25a1\xb0\uff09\u256f\ufe35 \u253b\u2501\u253b
|
[
1
] |
i suspect negligible would be more accurate than no since there are extra if checks being executed but that is kind of splitting hairs
|
[
0
] |
We're still in the shitstorm about excessive realism fucking up gameplay. Even if it wasn't the case, causing limb loss tier damage without any reliable warning and grading is horrible design. Realism is nowhere near good enough of an excuse for this degree of damage for as long as repairing a 0 hp limb requires a splint and 2+ weeks of rest.
|
[
1
] |
can you add a space after afe here to fix the alignment this has been bothering me for a while but a one character commit seemed silly
|
[
0
] |
Damn i always forget when there's a pending request, will fix asap
|
[
1
] |
this is an openstack project but the cla is not required
|
[
0
] |
No, the more I look at gas mixture code, the more I realise that I have no fucking clue about any of it.
|
[
1
] |
Not a big fan of this sort of comic book stuff. Seeing a trickshooter do it or 'I know a guy who tried it once' doesn't change the fact that it's ridiculous.
|
[
1
] |
i am not sure that address pairs attr not specified should trigger a delete of the address pairs
|
[
0
] |
Oops, wonder how that got in there. Weird.
|
[
1
] |
yeah if you move pid pid to this line and use pid instead of pid in your ptrace call above you can get rid of attached entirely
|
[
0
] |
Hah, I suck at reading diffs.
|
[
1
] |
this is garbage code left from rebase update
|
[
0
] |
i am stupid and will forget to update year
|
[
0
] |
sobj self apic infranodep get switch id
|
[
0
] |
aha as an poor non native english speaker i really should not make comments on spelling
|
[
0
] |
There seems to be a little bit of an issue. its far too gay for me, could you tone it down mr justoos?
|
[
1
] |
Casting the space character is kind of wacky, but this shuld be initialized to something.
|
[
1
] |
> putting not yet coded shit in the compile options who the fuck
|
[
1
] |
this looks (and always looked) like ass. Make it some nice paragraph please.
|
[
1
] |
useless too
|
[
0
] |
alright I'm stumped here, I need some examples of shit that do this to rip apart and cannibalize into this
|
[
1
] |
nit dump this all into a separate function self do stuff to summary options from diagnostic statiscs names
|
[
0
] |
This is ridiculous, this needs to be fixed. Allowing your website access to a system folder is unacceptable
|
[
1
] |
same question here with your change cros run vm update will use flags ssh private key as the value for private key for image to live sh
|
[
0
] |
Well heck, I pulled it right from welding code same as the iffy spawn
|
[
1
] |
Not that this error actually ever happens, but isn't the error message kind of weird?
|
[
1
] |
kill empty this empty space
|
[
0
] |
i have stupid question does this test run agent py l
|
[
0
] |
First you tell me to wait 6 months, now this gets auto-closed for inactivity. It's a bit ridiculous. We went with https://docs.openra.net/ now, but https://openra.readthedocs.io/ is still in hands of a stranger.
|
[
1
] |
you can separate that mocks with comma with mock x mock y as mock spawn
|
[
0
] |
how could I screw up a oneliner, I will go hide in shame.
|
[
1
] |
What the hell are you basing your judgements on? I mean, there is a possibility that you have a point, but it's so god damn intransparent. I don't think you have a compelling argument here. Which leads me to think your judgment is based on ignorance or arrogance. This understandable perception is the most annoying bit about when you comment on issues.
|
[
1
] |
hmm should be using nova dir i suppose
|
[
0
] |
It looks too gay, Also your index looks bad :)
|
[
1
] |
these ident vars need to be declared local
|
[
0
] |
these if s then s do not match the style above and before also please stay away from using bashism s like in this case it is not needed
|
[
0
] |
because if top activity r havestate false is in the died process it should still to resume next
|
[
0
] |
another rebase issue the following line should be removed i think
|
[
0
] |
dumb question how did you test this in particular how do you reach this line the draft page feature was suppose to be a performance optimzation from a long time ago but last i checked it was broken so i turned it off
|
[
0
] |
Hold on, I fucked up hard Maybe it's not quite so fast Stay tuned for more
|
[
1
] |
Rebase the change onto the latest codebase so there are no conflicts, and I'll add the PR myself. The fact that this has taken so long to get approval is ridiculous.
|
[
1
] |
....Cheridan. I don't see how this is adding poo? Hell, goons don't even have poo anymore.
|
[
1
] |
here for libvirt destroy
|
[
0
] |
i think this is a really good point you already made die a macro for that reason this should really be one as well
|
[
0
] |
useless
|
[
0
] |
horizon ssl cipher suite should be used here
|
[
0
] |
i think we should talk a bit about this one it could make for some really nasty output on devstack also my devstack logs are already murdering my system
|
[
0
] |
Shouldn't be a problem now. I forgot legion existed wtf
|
[
1
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.