showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
get rid of this code and have callers of this call new with disabled auth failure as second param	[ 0 ]
I don't think anything needs to be done here. Allowing both integer and strings is wacky enough, let's not complicate it anymore. In 4.x we should consider having two separate methods for int and string params.	[ 1 ]
use uma histogram boolean instead of uma histogram enumeration	[ 0 ]
i would like to have that here too since input may have junk data after a valid cbor	[ 0 ]
i meant the interface here no i meant a list of dictionary representations of the steps this is much more flexible than directly calling the methods in the agent driver s case it is proxying the info to the agent and running the steps on the agent blah i guess i did not look hard enough at base py i wrongly assumed all the interfaces shared a common base class i meant this method and execute clean step would be on the interfaces not the driver	[ 0 ]
`leaving a pair of lipstick lips` - this could use rewriting, sounds weird `leaving a lipstick impression` or something	[ 1 ]
self apic apic client restclient cfg conf ml cisco apic apic host cfg conf ml cisco apic apic port cfg conf ml cisco apic apic username cfg conf ml cisco apic apic password	[ 0 ]
FUCKING SCREAMING LIKE A FUCKING LUNATIC	[ 1 ]
could you name this something that indicates it concatenates the supplied keymanagers with the defaults maybe something lame like createwithadditionalkeymanagers	[ 0 ]
It looks like Visual Studio auto styled this for me. I have no idea how it came up with this crap nor do I remember adding it to the commit. Will fix	[ 1 ]
Balance change. why the hell not?	[ 1 ]
literal af literal	[ 0 ]
can be killed	[ 0 ]
Any reason to not use `let`? Since `var` kinda sucks with `for` and `if` blocks.	[ 1 ]
conversions from and to size_t are a pain in the ass. I think I implemented the most sensible solution for all of these occasions.	[ 1 ]
Damn this library really is like, batteries included	[ 1 ]
What the hell @deitylink	[ 1 ]
declare this as welcomebubbleview and remove the static cast in getclosebuttonfortest	[ 0 ]
let s only declare the variable and leave it uninitialized here and move this assignment into the catch block the compiler will complain about variables left uninitialized	[ 0 ]
put here atomic action false	[ 0 ]
This won't work but go at it you absolute clowns.	[ 1 ]
Damn, you are completely right, i got so confused with the day's length, i somehow thought that the time between dawn and noon was different to the time from non to dusk, same for night time.	[ 1 ]
paste garbage will add warning	[ 0 ]
it works in trunk and diablo stable is there a reason you are testing against the rcb build i am not aware of that being a publicly available build or that we need to be testing against it	[ 0 ]
damn.. pushed by accident again	[ 1 ]
Damn, I'm tired, was supposed to be `$d`.	[ 1 ]
Done! And, there's a setting to make them say a bunch of other obnoxious stuff too.	[ 1 ]
you are a liar!	[ 1 ]
@aeschli Please see #6916 where we crash with OOM because the JavaScript grammar produces ridiculous amount of scopes. Disabling the `type-parameters` rule seems to help it considerably, considering that every `<` entered this state.	[ 1 ]
Wow... these are awful. You can barely tell its a sword inhand it looks like a cane for someone who is blind	[ 1 ]
you mean this enabled opt cfg boolopt enabled default false and so on	[ 0 ]
nit picky but i would probably have lined up conf with kwargs above seems odd where it is	[ 0 ]
I just fucked with flags until I found d something somewhere else in the code that worked, I'll change it.	[ 1 ]
getlogginghandeerrorfixture should be getlogginghandlererrorfixture	[ 0 ]
shouldn t you add word addr when checking for out of bounds	[ 0 ]
so i would suggest to probably shoot for try size body iter df verify bunch of args if size and not zbf for chunk in body iter rate limit business except dfnotexist return except dfquarantined as err self logger stuff i might even think it possible to do the close and raise quarantine stuff in a finally block in the iterator	[ 0 ]
> WTF are finger blades anyway?... something between claws and razor blades that come out of your fingertips? Gawd that's nonsense. I take it you've never read Neuromancer. They're short little blades that pop out from under your fingernails, sort of like having box-knives for fingers. Molly Millions had them.	[ 1 ]
saying "nah fuck off" to someone just because you can isn't really an "interaction"	[ 1 ]
So now they serve no purpose whatsoever? I can dig that they shouldn't really be providing extra storage space, but this makes belts and helmet netting as useless as those ridiculous cat ears. Would it be better to just remove them from the game entirely?	[ 1 ]
Wtf this list contains the datum AND turfs?! KEVINZZ!!!!!	[ 1 ]
Why are we changing this shit again? I just got done testing it in all possible environments. -.-	[ 1 ]
actually the client is intended to be as dumb as possible we might want for example to test passing extra data	[ 0 ]
intersect is a little vague wwpns on vios	[ 0 ]
this leads to a useless error message use this instead self assertthat links self matchers endswith revoked list url	[ 0 ]
date should should just be y mm dd	[ 0 ]
that s fine i kinda prefer it as jsonproperty since that is clearer what it is and i doubt the dumps loads time is meaningful but do not care that deeply	[ 0 ]
wouldn t you be missing python if you can ssh run python c import cpickle and that passes then you do not need servo	[ 0 ]
I remember hearing that MoMMIs use some weird bastardized inventory slots that don't behave quite like regular mob inventory slots.	[ 1 ]
please remove unnecessary white spaces	[ 0 ]
put die at the end of this	[ 0 ]
Ahh crap I think that was my fault from way back when, providing faulty info. Also yes I do plan to bring playback support into EE, as well as recording of cl2 in the short-term.	[ 1 ]
That's fair, but note that unless we use some slightly ridiculous tricks (e.g. metamodule) we cannot raise a deprecation warning on access to `matplotlib.testing.compare.verifiers` (a public dictionary)...	[ 1 ]
use `cpp/util/misc.h:mod() functions` to avoid negative number fuckups.	[ 1 ]
i was utterly moronic. and now i've got it. thanks for the guidance. """dang it was such a easy fix. and it went right over me...""" well its working now. and as intended	[ 1 ]
should be elif or else followed by assert object type port	[ 0 ]
we can nuke the delegate tos since we already set login host	[ 0 ]
Nevermind, I'm saying shit:) I should not talk when I'm tired	[ 1 ]
useless parantheses	[ 0 ]
should be used jsonutils from lib oslo serialization	[ 0 ]
the rebuilt it, they rushed it and cut one to many corners and now it has come to this. i'm done with mage2, apart from the framework-level absurdities the frontend is a mess and the pivot to spa wont save it. complexity on mage2 has gone through the roof and I don't see the payoff for my clients.	[ 1 ]
we do not have the u of crud here	[ 0 ]
USE PLATFORMIO Arduino IDE is rubbish for larger projects. Things to try 1) move marlin to root of a Drive and rename it M 2) delete all unneeded HAL directories 3) remove unused lcd/extui directory 4) if using a 1284p based board use melzi not atmega1284p (shorter) 5) write to Microsoft and complain bitterly at their pathetic path length limitations.	[ 1 ]
i dislike usage of word nova here clients osclients clients self context admin endpoint for service in clients nova services list will be much cleaner as well i really do not understand why not using standard approach l l so only thing that you need here is something like def neutron available admin client osclients clients self context admin endpoint return consts service neutron in admin client services actually as far as we land support of usage existing users we will try to drop admin requirements everywhere where it is possible so usage of admin is such cases is something that should be avoided e g def neutron available if users in self context client else client return consts service neutron in admin client services	[ 0 ]
Similar problems with BMP280 It reads correctly for a couple of seconds when first connecting to the http interface then goes wacky and stays that way. Could it be i2c related?	[ 1 ]
kevin i think it would be better if you tried mocking timeutils utcnow yourself using your method the return value of mock patch object is a patcher class instance not a magicmock instance	[ 0 ]
contextlib should be moved up as it is std lib	[ 0 ]
volumes page self volumes page	[ 0 ]
I am thoroughly shocked that this actually worked... I've tried it before like 5 times and it didn't solve the issue... This is ridiculous, whatever lol Thank you...	[ 1 ]
fuckin...I rebased to make sure I didn't revert these, not sure how this ended up like this :(	[ 1 ]
nit get rid of battery percentage and just return the values directly below	[ 0 ]
if quacks like wsgi	[ 0 ]
damnit, it could've been, that was some "fix" for deleting light sources bay made later, guess I fucked up the copy paste :/	[ 1 ]
drop the crossbow and give it a cr-20(or hell, make a custom machine gun), and like i said at borg rechargers(where regular borgs recharge metal, tasers, glass, etc.)	[ 1 ]
Indentation here is messed up	[ 1 ]
let s use frozenset for affected node ids	[ 0 ]
This is so ridiculous, How long can it take to make the lowest fee be 1.1 sat/byte? This problem happened to me about 15 times already. Sending single UTXO to charities is a very common use-case.	[ 1 ]
no action required talk about a useless test name	[ 0 ]
have i mentioned that putting the tenant project in the uri is retard ed sigh	[ 0 ]
if you respin how about this to make sure it is not being silly self assertequal root bdm block device get root bdm reversed bdms	[ 0 ]
i do not think readers are going to know if it is domain specific drivers in general that is new and experimental or just storing domain specific configs in sql	[ 0 ]
live migration tunnelled	[ 0 ]
i would prefer we used the stupid atomic uint least t here so we can use explicitly sized types in the rest of the code allowing s nonsense like unsigned int to leak back into the code seems like a mistake even if the ill considered standard tries to move us in that direction	[ 0 ]
sh files are not binaries seems weird to put scripts into system bin	[ 0 ]
sh*t, you're right... I must have been drunk when I wrote it	[ 1 ]
I'm not sure how well this is going to work or if this is even using the list properly, to be honest. Wound code is horrible and should be purged in hellfire.	[ 1 ]
nit make this an even dumb er struct by removing the ctor and changing line so that it zero initializes the instance via availablelanguagealiases available aliases	[ 0 ]
Oh the tab+space. Damn relic.	[ 1 ]
aahhhh fucking get_all_slots nevermind	[ 1 ]
Everybody of the BAC complaining all the god damn time that the checkout button disappears because the tablet decides to increase the viewport by 300 ish pixels when you open the keyboard. Why? Because standards are for bitches, and everyone just wings it. (Because edge is chromium! Why does it work on edge and not on chrome?!!!!)	[ 1 ]
should be garbage collected	[ 0 ]
Log example: SAY clownman3/(John Testerson) "You son of a bitch! I'm in." FORCED by You son of a bitch, he's in.	[ 1 ]
Honestly, that seems to be a ridiculous overengineering. Also, what if `self` is not hashable?	[ 1 ]
can we call this pcidevicepool	[ 0 ]
The point of this feature is quality, not performance. Sure you can get a bit more performance but quality sucks. I think this should be left as-is, and optimization and performance will be assessed in due time.	[ 1 ]
invalid intendation	[ 0 ]
I'm wondering if it would be useful to add some comments here about our current thinking. The API here (wtf is `other`) is not very clear, and we might find some issues with this code later where understanding how we thought things should work originally might come in handy.	[ 1 ]
Damn this is jank. No races here?	[ 1 ]
yeah i have tests but they are supposed to go in oslo common when this gets moved there as well i was not sure how to go about that i have definitely tested this bugger though i am using the test code from this change iteration c tests unit test gettext py	[ 0 ]
utter rebase fail	[ 0 ]
to run stand alone need to mock utils hash path suffix and use fake rings	[ 0 ]

get rid of this code and have callers of this call new with disabled auth failure as second param

[ 0 ]

I don't think anything needs to be done here. Allowing both integer and strings is wacky enough, let's not complicate it anymore. In 4.x we should consider having two separate methods for int and string params.

[ 1 ]

use uma histogram boolean instead of uma histogram enumeration

[ 0 ]

i would like to have that here too since input may have junk data after a valid cbor

[ 0 ]

i meant the interface here no i meant a list of dictionary representations of the steps this is much more flexible than directly calling the methods in the agent driver s case it is proxying the info to the agent and running the steps on the agent blah i guess i did not look hard enough at base py i wrongly assumed all the interfaces shared a common base class i meant this method and execute clean step would be on the interfaces not the driver

[ 0 ]

`leaving a pair of lipstick lips` - this could use rewriting, sounds weird `leaving a lipstick impression` or something

[ 1 ]

self apic apic client restclient cfg conf ml cisco apic apic host cfg conf ml cisco apic apic port cfg conf ml cisco apic apic username cfg conf ml cisco apic apic password

[ 0 ]

FUCKING SCREAMING LIKE A FUCKING LUNATIC

[ 1 ]

could you name this something that indicates it concatenates the supplied keymanagers with the defaults maybe something lame like createwithadditionalkeymanagers

[ 0 ]

It looks like Visual Studio auto styled this for me. I have no idea how it came up with this crap nor do I remember adding it to the commit. Will fix

[ 1 ]

Balance change. why the hell not?

[ 1 ]

literal af literal

[ 0 ]

can be killed

[ 0 ]

Any reason to not use `let`? Since `var` kinda sucks with `for` and `if` blocks.

[ 1 ]

conversions from and to size_t are a pain in the ass. I think I implemented the most sensible solution for all of these occasions.

[ 1 ]

Damn this library really is like, batteries included

[ 1 ]

What the hell @deitylink

[ 1 ]

declare this as welcomebubbleview and remove the static cast in getclosebuttonfortest

[ 0 ]

let s only declare the variable and leave it uninitialized here and move this assignment into the catch block the compiler will complain about variables left uninitialized

[ 0 ]

put here atomic action false

[ 0 ]

This won't work but go at it you absolute clowns.

[ 1 ]

Damn, you are completely right, i got so confused with the day's length, i somehow thought that the time between dawn and noon was different to the time from non to dusk, same for night time.

[ 1 ]

paste garbage will add warning

[ 0 ]

it works in trunk and diablo stable is there a reason you are testing against the rcb build i am not aware of that being a publicly available build or that we need to be testing against it

[ 0 ]

damn.. pushed by accident again

[ 1 ]

Damn, I'm tired, was supposed to be `$d`.

[ 1 ]

Done! And, there's a setting to make them say a bunch of other obnoxious stuff too.

[ 1 ]

you are a liar!

[ 1 ]

@aeschli Please see #6916 where we crash with OOM because the JavaScript grammar produces ridiculous amount of scopes. Disabling the `type-parameters` rule seems to help it considerably, considering that every `<` entered this state.

[ 1 ]

Wow... these are awful. You can barely tell its a sword inhand it looks like a cane for someone who is blind

[ 1 ]

you mean this enabled opt cfg boolopt enabled default false and so on

[ 0 ]

nit picky but i would probably have lined up conf with kwargs above seems odd where it is

[ 0 ]

I just fucked with flags until I found d something somewhere else in the code that worked, I'll change it.

[ 1 ]

getlogginghandeerrorfixture should be getlogginghandlererrorfixture

[ 0 ]

shouldn t you add word addr when checking for out of bounds

[ 0 ]

so i would suggest to probably shoot for try size body iter df verify bunch of args if size and not zbf for chunk in body iter rate limit business except dfnotexist return except dfquarantined as err self logger stuff i might even think it possible to do the close and raise quarantine stuff in a finally block in the iterator

[ 0 ]

> WTF are finger blades anyway?... something between claws and razor blades that come out of your fingertips? Gawd that's nonsense. I take it you've never read Neuromancer. They're short little blades that pop out from under your fingernails, sort of like having box-knives for fingers. Molly Millions had them.

[ 1 ]

saying "nah fuck off" to someone just because you can isn't really an "interaction"

[ 1 ]

So now they serve no purpose whatsoever? I can dig that they shouldn't really be providing extra storage space, but this makes belts and helmet netting as useless as those ridiculous cat ears. Would it be better to just remove them from the game entirely?

[ 1 ]

Wtf this list contains the datum AND turfs?! KEVINZZ!!!!!

[ 1 ]

Why are we changing this shit again? I just got done testing it in all possible environments. -.-

[ 1 ]

actually the client is intended to be as dumb as possible we might want for example to test passing extra data

[ 0 ]

intersect is a little vague wwpns on vios

[ 0 ]

this leads to a useless error message use this instead self assertthat links self matchers endswith revoked list url

[ 0 ]

date should should just be y mm dd

[ 0 ]

that s fine i kinda prefer it as jsonproperty since that is clearer what it is and i doubt the dumps loads time is meaningful but do not care that deeply

[ 0 ]

wouldn t you be missing python if you can ssh run python c import cpickle and that passes then you do not need servo

[ 0 ]

I remember hearing that MoMMIs use some weird bastardized inventory slots that don't behave quite like regular mob inventory slots.

[ 1 ]

please remove unnecessary white spaces

[ 0 ]

put die at the end of this

[ 0 ]

Ahh crap I think that was my fault from way back when, providing faulty info. Also yes I do plan to bring playback support into EE, as well as recording of cl2 in the short-term.

[ 1 ]

That's fair, but note that unless we use some slightly ridiculous tricks (e.g. metamodule) we cannot raise a deprecation warning on access to `matplotlib.testing.compare.verifiers` (a public dictionary)...

[ 1 ]

use `cpp/util/misc.h:mod() functions` to avoid negative number fuckups.

[ 1 ]

i was utterly moronic. and now i've got it. thanks for the guidance. """dang it was such a easy fix. and it went right over me...""" well its working now. and as intended

[ 1 ]

should be elif or else followed by assert object type port

[ 0 ]

we can nuke the delegate tos since we already set login host

[ 0 ]

Nevermind, I'm saying shit:) I should not talk when I'm tired

[ 1 ]

useless parantheses

[ 0 ]

should be used jsonutils from lib oslo serialization

[ 0 ]

the rebuilt it, they rushed it and cut one to many corners and now it has come to this. i'm done with mage2, apart from the framework-level absurdities the frontend is a mess and the pivot to spa wont save it. complexity on mage2 has gone through the roof and I don't see the payoff for my clients.

[ 1 ]

we do not have the u of crud here

[ 0 ]

USE PLATFORMIO Arduino IDE is rubbish for larger projects. Things to try 1) move marlin to root of a Drive and rename it M 2) delete all unneeded HAL directories 3) remove unused lcd/extui directory 4) if using a 1284p based board use melzi not atmega1284p (shorter) 5) write to Microsoft and complain bitterly at their pathetic path length limitations.

[ 1 ]

i dislike usage of word nova here clients osclients clients self context admin endpoint for service in clients nova services list will be much cleaner as well i really do not understand why not using standard approach l l so only thing that you need here is something like def neutron available admin client osclients clients self context admin endpoint return consts service neutron in admin client services actually as far as we land support of usage existing users we will try to drop admin requirements everywhere where it is possible so usage of admin is such cases is something that should be avoided e g def neutron available if users in self context client else client return consts service neutron in admin client services

[ 0 ]

Similar problems with BMP280 It reads correctly for a couple of seconds when first connecting to the http interface then goes wacky and stays that way. Could it be i2c related?

[ 1 ]

kevin i think it would be better if you tried mocking timeutils utcnow yourself using your method the return value of mock patch object is a patcher class instance not a magicmock instance

[ 0 ]

contextlib should be moved up as it is std lib

[ 0 ]

volumes page self volumes page

[ 0 ]

I am thoroughly shocked that this actually worked... I've tried it before like 5 times and it didn't solve the issue... This is ridiculous, whatever lol Thank you...

[ 1 ]

fuckin...I rebased to make sure I didn't revert these, not sure how this ended up like this :(

[ 1 ]

nit get rid of battery percentage and just return the values directly below

[ 0 ]

if quacks like wsgi

[ 0 ]

damnit, it could've been, that was some "fix" for deleting light sources bay made later, guess I fucked up the copy paste :/

[ 1 ]

drop the crossbow and give it a cr-20(or hell, make a custom machine gun), and like i said at borg rechargers(where regular borgs recharge metal, tasers, glass, etc.)

[ 1 ]

Indentation here is messed up

[ 1 ]

let s use frozenset for affected node ids

[ 0 ]

This is so ridiculous, How long can it take to make the lowest fee be 1.1 sat/byte? This problem happened to me about 15 times already. Sending single UTXO to charities is a very common use-case.

[ 1 ]

no action required talk about a useless test name

[ 0 ]

have i mentioned that putting the tenant project in the uri is retard ed sigh

[ 0 ]

if you respin how about this to make sure it is not being silly self assertequal root bdm block device get root bdm reversed bdms

[ 0 ]

i do not think readers are going to know if it is domain specific drivers in general that is new and experimental or just storing domain specific configs in sql

[ 0 ]

live migration tunnelled

[ 0 ]

i would prefer we used the stupid atomic uint least t here so we can use explicitly sized types in the rest of the code allowing s nonsense like unsigned int to leak back into the code seems like a mistake even if the ill considered standard tries to move us in that direction

[ 0 ]

sh files are not binaries seems weird to put scripts into system bin

[ 0 ]

sh*t, you're right... I must have been drunk when I wrote it

[ 1 ]

I'm not sure how well this is going to work or if this is even using the list properly, to be honest. Wound code is horrible and should be purged in hellfire.

[ 1 ]

nit make this an even dumb er struct by removing the ctor and changing line so that it zero initializes the instance via availablelanguagealiases available aliases

[ 0 ]

Oh the tab+space. Damn relic.

[ 1 ]

aahhhh fucking get_all_slots nevermind

[ 1 ]

Everybody of the BAC complaining all the god damn time that the checkout button disappears because the tablet decides to increase the viewport by 300 ish pixels when you open the keyboard. Why? Because standards are for bitches, and everyone just wings it. (Because edge is chromium! Why does it work on edge and not on chrome?!!!!)

[ 1 ]

should be garbage collected

[ 0 ]

Log example: SAY clownman3/(John Testerson) "You son of a bitch! I'm in." FORCED by You son of a bitch, he's in.

[ 1 ]

Honestly, that seems to be a ridiculous overengineering. Also, what if `self` is not hashable?

[ 1 ]

can we call this pcidevicepool

[ 0 ]

The point of this feature is quality, not performance. Sure you can get a bit more performance but quality sucks. I think this should be left as-is, and optimization and performance will be assessed in due time.

[ 1 ]

invalid intendation

[ 0 ]

I'm wondering if it would be useful to add some comments here about our current thinking. The API here (wtf is `other`) is not very clear, and we might find some issues with this code later where understanding how we thought things should work originally might come in handy.

[ 1 ]

Damn this is jank. No races here?

[ 1 ]

yeah i have tests but they are supposed to go in oslo common when this gets moved there as well i was not sure how to go about that i have definitely tested this bugger though i am using the test code from this change iteration c tests unit test gettext py

[ 0 ]

utter rebase fail

[ 0 ]

to run stand alone need to mock utils hash path suffix and use fake rings

[ 0 ]