text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
indention should be blah blah stuff stuff stuff
|
[
0
] |
should you pop stdout and stderr before calling this
|
[
0
] |
maru you mean that fake route and operations on it are useless and fake route would be enough do not you
|
[
0
] |
To anyone who is still searching for the solution on Google page > 1: It seems obvious but you should check if you're not accidentally using the USB 2.0 port for the NCS 2. That could (also) cause this error. I've been an inattentive moron so you don't have to, have a nice day :)
|
[
1
] |
there are some places with exc notfound and another ones with abort why do not use an abort here
|
[
0
] |
isn t that redundant count should be catched by if not count above already
|
[
0
] |
quick stupid question but why
|
[
0
] |
if iworktypes h is included then iworktypes fwd h is unnecessary
|
[
0
] |
better pass by value bool bistextcat or just bool istextcat to avoid the ugly misunderstood hungarian prefix
|
[
0
] |
a little confusing how about collapsing this block from like to if kwargs pop management true and self management url is not none url to use self management url else url to use self auth url
|
[
0
] |
amxx is not implemented in xash3d. All weapons are hardcoded with C++.
|
[
1
] |
this sleep make test running seconds delay you should also mock in in the test case virt libvirt test driver py test unrescue
|
[
0
] |
we should be using our official git mirror git openstgack org
|
[
0
] |
oy use fucking defines you oaf.
|
[
1
] |
let s remove my silly note it is now logged in gerrit for the future
|
[
0
] |
Wtf admins are responsible!!!??
|
[
1
] |
why not simply use grub and set it is params as you did it for mock object this mock really do not gives you anything
|
[
0
] |
this is pretty hacky cannot you use pyelftools to load the elf and check the exported symbol table directly
|
[
0
] |
i think it would be better to make this an arg to the function
|
[
0
] |
On a side note, adding a PR to a milestone which is not yet ready for review and causes a lot of debate is also pretty crap. History showed us that forcing things in last minute was never a good idea.
|
[
1
] |
gotta keep those comments up to date on the new shit.
|
[
1
] |
am i being dumb here but does not this raise the gnocchi notimplementederror class as opposed to an instance of that class would it be more correct to instantiate raise gnocchi notimplementederror
|
[
0
] |
remove the backslash
|
[
0
] |
please line wrap this to chars
|
[
0
] |
What the hell did you do to get linker errors from that?
|
[
1
] |
fat fingers i guess
|
[
0
] |
node uid and task id should be nullable false should not them
|
[
0
] |
maybe add dshi to verify this he s mucked with chromeos version sh lately
|
[
0
] |
we do not usually split a line up like this better might be self mock get driver return value plugin driver agentbasedplugindriver self plugin instance dummy
|
[
0
] |
please put here definition for all params
|
[
0
] |
Should probably add values to Centcomm armor here and shit like Thunderdome armor.
|
[
1
] |
doesn't seem that bad, lots of 'that sucks' in detections
|
[
1
] |
what if there is bit rot and like a bit gets flipped we need comment backups haha
|
[
0
] |
nit in general you want to use instead of here this takes care of the case where there is a space in one of the parameters e g print params for p in do printf s n p done print params for p in do printf s n p done print params a fool prints a then fool on lines print params a fool prints a fool on line
|
[
0
] |
Dang! I wonder what is the rationale for that ridiculous melee damage?
|
[
1
] |
this render process id dcheck seems a bit overkill would just remove
|
[
0
] |
it mean message storage default storage
|
[
0
] |
> Also, a 30 damage weapon is absurd. Counterbalanced it by giving it 0.5 attack speed, so you attack half as fast with it. Averages out to 15 DPS if you can consistently land the hits.
|
[
1
] |
yeah this is really fucky, honestly, it's a lot more lines for nothing good
|
[
1
] |
yeah this would introduce a bug the only caller is vfprintf
|
[
0
] |
i am a bit confused here isn t this equivalent to line did mock execute get called did node maintenance get set the other thing i notice i think is that this test and the test above l are very similar except for the values returned by the mocks have you considered creating a helper function that these two can call after setting up the mocks
|
[
0
] |
remove this blank line your pep failure
|
[
0
] |
Ive been asking for weeks whether or not this will work with the damn holidays module, but I am pretty sure this loads before it.
|
[
1
] |
Finally someone closed my ridiculous request. :P This has been waiting here for a while.
|
[
1
] |
ok for the first version but pls add a comment here that we should really enqueue before we have preparsed the func then the interaction w aborting will also be simple you will just need to tell the preparsing to not abort
|
[
0
] |
No it's not a real error, just test any game with it and you would it spamming like hell.
|
[
1
] |
i think a patch is needed for utils drop unique constraint instead of migration patch if migrate engine name mysql get fk from table test fk columns in uc drop fk drop uc create fk
|
[
0
] |
so these ischecked are inverted that is a bug i will push this test and then fix it
|
[
0
] |
I'm pretty sure I filtered out all of these before pushing, but apparently not. Damn.
|
[
1
] |
adapter host uuid instance and connection info should be removed
|
[
0
] |
might be a stupid question but why is this different from the addcleanup tool
|
[
0
] |
why are you overriding even any of these they are inherited from parent and youre fuckin em up
|
[
1
] |
hi marios so far this patch is just a test to check whether this can mitigate lock wait timeouts the aim of this patch is to validate the hypothesis regarding these lock wait timeout failures honestly i have never been a fan of this approach and i would push for this patch to be merged only if we are unable to do anything better
|
[
0
] |
use tdf to refer to the bug report remove the link below and add a more descriptive message than fix bug
|
[
0
] |
yes dstdir and dstdir contain all unpacked for final packing
|
[
0
] |
let me try this one last time our tempest client compute json services client py on line is self put os services disable post body note this is os services disable this is not disable log reason at nova api side os services disable maps to openstack compute services py l disable self disable note this will call self disable this will not call self disable log reason self disable will call self enable disable with disabled reason none so the value of body disabled reason is completely ignored and never returned this is because our tempest client calls os services disable if it had called os services disable log reason you would be right now try this curl g i x put h user agent python novaclient h content type application json h accept application json h x auth token xx d binary nova compute host node disabled reason foobar notice we call os services disable and look at what is returned by this curl command
|
[
0
] |
gettext or ngettext
|
[
0
] |
the line above should be removed
|
[
0
] |
As in A1V1, the wait for bounties on Hard in A1V2 is ridiculously long and annoying (feels even longer in this one). Also the seconday wormspawner here is even worse, because there is no safe area to harvest in this map.
|
[
1
] |
updatedistribution should not be necessary here anymore
|
[
0
] |
suggest uuid uuid in place of random randint
|
[
0
] |
for speed i would change the strlen check to string null
|
[
0
] |
those blasted patch requests are the worst this and the path info in resp environ check above are a bit overly defensive for my tastes it s just distracting why is this code here how does this happen is swob broken should i re read pep wait should i me wastes an mins nope must be present phew
|
[
0
] |
oh crap, i totally forgot about this
|
[
1
] |
I fucked up and accidentally deleted the "one handed" part to write the twohanded thing. Sorry. Does it really matter that I fix it? It's just a comment, and I kinda don't want to.
|
[
1
] |
annotate with notnull
|
[
0
] |
Holy crap this is fragile, this seriously needs an overhaul. If nothing else monster_list should be a list, and then the other two can have pointers to the monsters.
|
[
1
] |
please get rid of backslash use brackets
|
[
0
] |
Jesus fucking christ dude, I just got super cancer looking at this. Use initial. var/obj/item/projectile/whateverdude = P.type fire_sound = initial(whateverdude.variablewhatever)
|
[
1
] |
fuck vim
|
[
0
] |
This is already documented on the linked methods. I'd rather avoid repeating the documentation. Although, since rust-analyzer doesn't support these links it does kinda suck. hmmmm
|
[
1
] |
this is the wrong folder it should be tools base build but then the code below is wrong you d have to put project parent builddir project name
|
[
0
] |
If you find out what GLFW does I'd like to know - I didn't see anything out of the ordinary in their implementation (but they also haven't gotten to the wacky stuff like surface suspension yet, so who knows).
|
[
1
] |
bitch you added it in the first place
|
[
1
] |
i think this separator should be removed the cryptix part is for twofish right
|
[
0
] |
damn, ya that's bad, fixing it now
|
[
1
] |
hmm this should have been failing since the call to api heat did not got mocked can you you it here too better yet we could refactor the code since we are using the same sets of mock and data for the three test methods
|
[
0
] |
kill it
|
[
0
] |
you can use the angle gl program and add a glshader type in gl raii h to not need this
|
[
0
] |
if (1 !=0 ) will work (as that's always true) and if you're seeing updates in the library view that's good. As for this change we need to always send a notify, as something might have changed. The other refresh is a killer, as it refreshes everything on every update. How is the memory footprint? PS thanks for trying this out testing this out (I'm a bit rubbish at thanking ppl sometimes!)
|
[
1
] |
darn... I always forget this.
|
[
1
] |
author not needed taken care of by git
|
[
0
] |
i will create a barbican subdirectory under etc security
|
[
0
] |
> That means you propose a PR you even did not test !!! Very dangerous. The strict minimum would be to mention it. Fair point, I will remember it. I have 20 years of programming experience and had my Java pro friend code-review it to make sure it's not absolute rubbish :)
|
[
1
] |
looks like your git has the wrong name configured in it
|
[
0
] |
agreed i will ping back when the tests are added but will assume your lgtm still stands should this happen while you are o next week i should cover these three cases multiple throttles all doing restart synchronously multiple throttles all doing restart while deferred multiple throttles doing a mix of synchronous and deferred restarts
|
[
0
] |
Do I really have to unfuck old pieces of code too now u_u
|
[
1
] |
you should be using mock patch in the appropriate place instead of manually patching the library
|
[
0
] |
i am ignorant can you share what is that about
|
[
0
] |
small dumb nit do not need the global statement here i think you already changed this but it got lost in a rebase merge
|
[
0
] |
ahh bummer! thats ridiculously expensive!
|
[
1
] |
the active looks for a pid file i did not see this generated maybe it is my bad
|
[
0
] |
pre version does not tell us much better would be test upload to image pre
|
[
0
] |
m open iter return value iter lines
|
[
0
] |
i was going to say this is badly in need of a comment there is a comment on the original in rbd utils could you please move it over too
|
[
0
] |
same here we will use tcp socket mojom h instead of tcp connected socket h
|
[
0
] |
should be adopt failed failed i guess
|
[
0
] |
i really should learn how to sort in vi for when i am doing stuff over ssh clearly i am too stupid to do it manually
|
[
0
] |
this one is good we spit out a warning a die in a fire if this is below
|
[
0
] |
should this take an expect body key arg defaulted to false so we can do all our checking in one place it should remove the need for some of the error handling in basedecryptercontext get unwrapped key i think to the point that it would make sense to let callers just call self crypto unwrap key themselves
|
[
0
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.