showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
these printks are missing the kern prefix probably want kern info for the first and kern warn for the second	[ 0 ]
Same old unused result shit.	[ 1 ]
why should we ignore what the parent does if it does have that flag? seems like it could be fucky	[ 1 ]
@pdrosos that works, thanks. yeah definitely needs to be fixed otherwise I need to do the same thing every time I reinstall the node_modules which is ridiculous.	[ 1 ]
check functiondecl getcanonicaldecl getlocation functiondecl getlocation to avoid useless notes	[ 0 ]
the vulkan joke doesn't work and is really fucking forced and shoehorned	[ 1 ]
I was confused about why the sanity check was removed. On closer inspection it was shitcode	[ 1 ]
No, the person who mentioned that was a troll. they keep coming in with random usernames and pretending to know their shit.	[ 1 ]
# is that A FUCKING LINE BREAK	[ 1 ]
why did this block have to get changed was this some rubocop violation	[ 0 ]
seems that populate quantum extension values is redundant with the refresh quantum extensions cache method of the bellow has port binding extension	[ 0 ]
wait this is an aux module, not an exploit. I'm not seeing the 0day mainly because the description is nonsense and the print_\\* messages don't really describe much. I'm closing this. Sorry it didn't work out.	[ 1 ]
jeebus with this many mocks is this test actually doing anything	[ 0 ]
yeah there's a shitton of reactions that can be un-nerfed/uncommented now that smoke is not shit	[ 1 ]
I didn't do this, I was copy/pasting shit from the other slots just to be certain on things I was unsure about.	[ 1 ]
question do we want to end up having an empty almost empty fake policy file i am asking because what this fake policy file is doing is making some of the apis looser in terms of authorization for testing purposes if we will remove all these rules we would have to have an admin context for almost all tests	[ 0 ]
this newline should be removed	[ 0 ]
It's super annoying making changes to anything in the peep or vehicle headers they get included everywhere. Anything that reduces that would be great	[ 1 ]
yup as designed because an iscsi initiator of is completely useless	[ 0 ]
Looks like this formatting was done by .clang-format... was it wrong in the first place or is my formatter screwed up?	[ 1 ]
i think added fields self policy attrs self orig fields	[ 0 ]
dumb question what does force true does for us	[ 0 ]
Damn, you're right! Will do.	[ 1 ]
killing seems bad why kill just stop it using an event object for example def heartbeat self while self coordinator is not none and not self dead is set do stuff def stop self stuff if self coordinator is not none self coordinator stop self dead set if self ev is not none self ev wait self ev none self coordinator none self started false	[ 0 ]
they are useless but heat config heat api cert file will not be in the catalog if that does not matter i can remove it	[ 0 ]
you are just retrying a part of a transaction on bulk network create it does not seams to work	[ 0 ]
Oh! you are right. Damn this is confusing.	[ 1 ]
^ Holy shit there's an extremely long description on this class.	[ 1 ]
how about using cros factory test session console info to show the log in the goofy bottom panel	[ 0 ]
What the fuck? Why change the name?	[ 1 ]
it's really gonna suck to accidentally write over this program	[ 1 ]
i will remove them	[ 0 ]
for uniformity reasons please use is wide false here	[ 0 ]
Close /Reopen because one of the appveyor builds crashed for nonsense reasons.	[ 1 ]
uid uid	[ 0 ]
if vnic type portbindings vnic direct physical	[ 0 ]
MSG_NOSIGNAL doesn't help of course - we never got a signal, just an error code from send. Still, a bit mysterious. maybe some firewall nonsense	[ 1 ]
WTF? Why three times?	[ 1 ]
Piece of crap global iterators. Space pods are the only reason you exist. WHY CAN'T YOU BE UP TO DATE LIKE YOUR SUPERIOR SENIOR AND PREDECESSOR.	[ 1 ]
zomg locals it be a hangin offense	[ 0 ]
what is this loop for in case the handler sets another alert pending is there a better way to track check this	[ 0 ]
config fixture does not exist in havana you need to do the following conf ldap url fake memory conf ldap chase referrals false	[ 0 ]
updated (see second commit). Also reduced some of the ridiculous repetitions of rest/spread/rest/spread :)	[ 1 ]
i think you can garbage collect this comment	[ 0 ]
Oh god oh fuck. Reverted, thanks!	[ 1 ]
missing period at the end of this sentence also host does not need to be capitalized	[ 0 ]
probably worth pointing out that sample type is a bitmask	[ 0 ]
This is still an issue. Is there no way to centre the inline placeholder? What if the `textAlignment` of my text field is centred? It looks ridiculous if the placeholder is left aligned in this case	[ 1 ]
shouldn t you set ramdisk element dracut ramdisk here if you want it to test the puppet jobs	[ 0 ]
ctrbegin libc init cpp	[ 0 ]
Ridiculous to still not have updated the official install for MacOS... Intel should be embarrassed with themselves. Why not just use the instructions @GitwellAnyohub posted at the least, that worked for me.	[ 1 ]
I actually haven't seen a successful run at all inside this Centos6 docker image. So this is a pretty good/wacky repro.	[ 1 ]
thanks actually i should remove them because locked is not returned through api	[ 0 ]
lol dumb error it will not forbid to enable it because it is registered by the catalog instance but it will not appear in the generated conf file lemme fix this	[ 0 ]
Oh it also holds like ammo boxes my b. Actually wait why does it do that? yucky storage creep. Just inherit tbh	[ 1 ]
should this go outside of the try i imagine the attributeerror would be thrown from l	[ 0 ]
move this down to the iptablesfirewalltestcase the ipset mocks it	[ 0 ]
canretry should be false instead of none i know that it previously used none but seems that if it is a boolean it should be explicitly false just my euros	[ 0 ]
Gonna look into this one today, it's being ridiculous	[ 1 ]
the line break should be here and line should be removed	[ 0 ]
Damn it i completely forgot, time to revert that for now, since i have zero clue on how to make the ai voice	[ 1 ]
gross	[ 0 ]
Oh shit, you're right. I've corrected it now.	[ 1 ]
yes those cls should go in by tues	[ 0 ]
since you use stevedore to load custom constraints this line is useless and should be removed	[ 0 ]
should scrub key data after creation of aeskey	[ 0 ]
do you want to abort when these invariants are violated for user based tools i usually prefer a warning unless the error is fatal but it might be better to make this fatal so we can catch any errors handling one of these sections	[ 0 ]
Well, this is optional. If you're fine with it, then feel free to leave it. But as somebody that does spend a LOT of time in QMK.... I find that underscores do make it a bit more readable. And I don't know about you, but I've come back to my own code and wondered WTF I was doing. :D So making sure it's readable is a good thing. But it's more important that it's readable TO YOU.	[ 1 ]
make sure to go through and make all the other event systems that use this shit but copypasted use this proc instead	[ 1 ]
dumb question don t we have these meters from the rate of change transformers in case of libvirt too	[ 0 ]
those sneaky whitespaces	[ 0 ]
this is different than other fk should be fk host history revision resource history revision	[ 0 ]
i think we should probably use a different heapchunkcallback for native dump casting random non heap native memory to object and then examining it seems not correct this would also remove the need for the heap bitmap lock here	[ 0 ]
I kinda hate this. But I guess there's no avoiding it since pulling the thing while it walks would break glide settings, right? Yet another reason why `walk` sucks btw.	[ 1 ]
the runtime configuration by calling cros factory utils config utils saveruntimeconfig light sensor calibration new config	[ 0 ]
Have you ever poured salt on a wound? That shit burns.	[ 1 ]
Bump. I believe we discussed squashing commits and that we shouldn't do this in case people are cherry picking or merging branches - unless it's a ridiculous number of commits.	[ 1 ]
looks great thanks does this apply to c also or just crap this file is reused in both	[ 0 ]
The lack of support for programmatically making pulumi deployments is the reason I'm going to be forced to choose Terraform. It's a damn shame, because I would put up with a lot of nonsense to be able to maintain and modify the unusual architecture I have from my existing codebase.	[ 1 ]
maybe we should get rid of this as well	[ 0 ]
this backslash is not required and should go away	[ 0 ]
whoot whoot whot	[ 0 ]
ah i thought you were referring to null instanceof classa i will add sensitivity to nullchecks in a follow up	[ 0 ]
why not time time self session start self session timeout	[ 0 ]
there are white spaces remove one	[ 0 ]
Hi Marco, I hope to review it before the end of the week. I done dependencies because I thought that providers works like that. I thought that deleting without inserting and updating is a nonsense. But it's right that updating and inserting are not dependant. What do you preconise ?	[ 1 ]
your fake server has duplicate logic of the class under test due to the same inheritance you should choose a different style of mocking httmock is being use elsewhere in neutron	[ 0 ]
service host should not be needed	[ 0 ]
2nd iteration by using LOVE threads. It still using C++'s high resolution timer though.	[ 1 ]
"Attention," is really weird grammatically	[ 1 ]
you missed this occurrence of type	[ 0 ]
Damn. I'm attaching the file.<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/8573">issues.joomla.org/joomla-cms/8573</a>.</sub>	[ 1 ]
useless string	[ 0 ]
this subshell is not correct but could you write this simpler as d proc pid	[ 0 ]
i am totally fine with pushing this toward a real boolean	[ 0 ]
oh wait shit you\u2019re right, was mixing this up with the badfood toxin	[ 1 ]
secondary should be used to find the array you are failing over to	[ 0 ]
i think we should remove tmp dir at the end of script	[ 0 ]
i would put it here right before rspec runs if options update librarian puppet prepare library end	[ 0 ]
we raised an error testnaerror in autotest but i cannot find the equivalent in tast any suggestion is it ok to mark it as pass	[ 0 ]

these printks are missing the kern prefix probably want kern info for the first and kern warn for the second

[ 0 ]

Same old unused result shit.

[ 1 ]

why should we ignore what the parent does if it does have that flag? seems like it could be fucky

[ 1 ]

@pdrosos that works, thanks. yeah definitely needs to be fixed otherwise I need to do the same thing every time I reinstall the node_modules which is ridiculous.

[ 1 ]

check functiondecl getcanonicaldecl getlocation functiondecl getlocation to avoid useless notes

[ 0 ]

the vulkan joke doesn't work and is really fucking forced and shoehorned

[ 1 ]

I was confused about why the sanity check was removed. On closer inspection it was shitcode

[ 1 ]

No, the person who mentioned that was a troll. they keep coming in with random usernames and pretending to know their shit.

[ 1 ]

# **is that A FUCKING LINE BREAK**

[ 1 ]

why did this block have to get changed was this some rubocop violation

[ 0 ]

seems that populate quantum extension values is redundant with the refresh quantum extensions cache method of the bellow has port binding extension

[ 0 ]

wait this is an aux module, not an exploit. I'm not seeing the 0day mainly because the description is nonsense and the print_\\* messages don't really describe much. I'm closing this. Sorry it didn't work out.

[ 1 ]

jeebus with this many mocks is this test actually doing anything

[ 0 ]

yeah there's a shitton of reactions that can be un-nerfed/uncommented now that smoke is not shit

[ 1 ]

I didn't do this, I was copy/pasting shit from the other slots just to be certain on things I was unsure about.

[ 1 ]

question do we want to end up having an empty almost empty fake policy file i am asking because what this fake policy file is doing is making some of the apis looser in terms of authorization for testing purposes if we will remove all these rules we would have to have an admin context for almost all tests

[ 0 ]

this newline should be removed

[ 0 ]

It's super annoying making changes to anything in the peep or vehicle headers they get included everywhere. Anything that reduces that would be great

[ 1 ]

yup as designed because an iscsi initiator of is completely useless

[ 0 ]

Looks like this formatting was done by .clang-format... was it wrong in the first place or is my formatter screwed up?

[ 1 ]

i think added fields self policy attrs self orig fields

[ 0 ]

dumb question what does force true does for us

[ 0 ]

Damn, you're right! Will do.

[ 1 ]

killing seems bad why kill just stop it using an event object for example def heartbeat self while self coordinator is not none and not self dead is set do stuff def stop self stuff if self coordinator is not none self coordinator stop self dead set if self ev is not none self ev wait self ev none self coordinator none self started false

[ 0 ]

they are useless but heat config heat api cert file will not be in the catalog if that does not matter i can remove it

[ 0 ]

you are just retrying a part of a transaction on bulk network create it does not seams to work

[ 0 ]

Oh! you are right. Damn this is confusing.

[ 1 ]

^ Holy shit there's an extremely long description on this class.

[ 1 ]

how about using cros factory test session console info to show the log in the goofy bottom panel

[ 0 ]

What the fuck? Why change the name?

[ 1 ]

it's really gonna suck to accidentally write over this program

[ 1 ]

i will remove them

[ 0 ]

for uniformity reasons please use is wide false here

[ 0 ]

Close /Reopen because one of the appveyor builds crashed for nonsense reasons.

[ 1 ]

uid uid

[ 0 ]

if vnic type portbindings vnic direct physical

[ 0 ]

MSG_NOSIGNAL doesn't help of course - we never got a signal, just an error code from send. Still, a bit mysterious. maybe some firewall nonsense

[ 1 ]

WTF? Why three times?

[ 1 ]

Piece of crap global iterators. Space pods are the only reason you exist. WHY CAN'T YOU BE UP TO DATE LIKE YOUR SUPERIOR SENIOR AND PREDECESSOR.

[ 1 ]

zomg locals it be a hangin offense

[ 0 ]

what is this loop for in case the handler sets another alert pending is there a better way to track check this

[ 0 ]

config fixture does not exist in havana you need to do the following conf ldap url fake memory conf ldap chase referrals false

[ 0 ]

updated (see second commit). Also reduced some of the ridiculous repetitions of rest/spread/rest/spread :)

[ 1 ]

i think you can garbage collect this comment

[ 0 ]

Oh god oh fuck. Reverted, thanks!

[ 1 ]

missing period at the end of this sentence also host does not need to be capitalized

[ 0 ]

probably worth pointing out that sample type is a bitmask

[ 0 ]

This is still an issue. Is there no way to centre the inline placeholder? What if the `textAlignment` of my text field is centred? It looks ridiculous if the placeholder is left aligned in this case

[ 1 ]

shouldn t you set ramdisk element dracut ramdisk here if you want it to test the puppet jobs

[ 0 ]

ctrbegin libc init cpp

[ 0 ]

Ridiculous to still not have updated the official install for MacOS... Intel should be embarrassed with themselves. Why not just use the instructions @GitwellAnyohub posted at the least, that worked for me.

[ 1 ]

I actually haven't seen a successful run at all inside this Centos6 docker image. So this is a pretty good/wacky repro.

[ 1 ]

thanks actually i should remove them because locked is not returned through api

[ 0 ]

lol dumb error it will not forbid to enable it because it is registered by the catalog instance but it will not appear in the generated conf file lemme fix this

[ 0 ]

Oh it also holds like ammo boxes my b. Actually wait why does it do that? yucky storage creep. Just inherit tbh

[ 1 ]

should this go outside of the try i imagine the attributeerror would be thrown from l

[ 0 ]

move this down to the iptablesfirewalltestcase the ipset mocks it

[ 0 ]

canretry should be false instead of none i know that it previously used none but seems that if it is a boolean it should be explicitly false just my euros

[ 0 ]

Gonna look into this one today, it's being ridiculous

[ 1 ]

the line break should be here and line should be removed

[ 0 ]

Damn it i completely forgot, time to revert that for now, since i have zero clue on how to make the ai voice

[ 1 ]

gross

[ 0 ]

Oh shit, you're right. I've corrected it now.

[ 1 ]

yes those cls should go in by tues

[ 0 ]

since you use stevedore to load custom constraints this line is useless and should be removed

[ 0 ]

should scrub key data after creation of aeskey

[ 0 ]

do you want to abort when these invariants are violated for user based tools i usually prefer a warning unless the error is fatal but it might be better to make this fatal so we can catch any errors handling one of these sections

[ 0 ]

Well, this is optional. If you're fine with it, then feel free to leave it. But as somebody that does spend a LOT of time in QMK.... I find that underscores do make it a bit more readable. And I don't know about you, but I've come back to my own code and wondered WTF I was doing. :D So making sure it's readable is a good thing. But it's more important that it's readable TO YOU.

[ 1 ]

make sure to go through and make all the other event systems that use this shit but copypasted use this proc instead

[ 1 ]

dumb question don t we have these meters from the rate of change transformers in case of libvirt too

[ 0 ]

those sneaky whitespaces

[ 0 ]

this is different than other fk should be fk host history revision resource history revision

[ 0 ]

i think we should probably use a different heapchunkcallback for native dump casting random non heap native memory to object and then examining it seems not correct this would also remove the need for the heap bitmap lock here

[ 0 ]

I kinda hate this. But I guess there's no avoiding it since pulling the thing while it walks would break glide settings, right? Yet another reason why `walk` sucks btw.

[ 1 ]

the runtime configuration by calling cros factory utils config utils saveruntimeconfig light sensor calibration new config

[ 0 ]

Have you ever poured salt on a wound? That shit burns.

[ 1 ]

Bump. I believe we discussed squashing commits and that we shouldn't do this in case people are cherry picking or merging branches - unless it's a ridiculous number of commits.

[ 1 ]

looks great thanks does this apply to c also or just crap this file is reused in both

[ 0 ]

The lack of support for programmatically making pulumi deployments is the reason I'm going to be forced to choose Terraform. It's a damn shame, because I would put up with a lot of nonsense to be able to maintain and modify the unusual architecture I have from my existing codebase.

[ 1 ]

maybe we should get rid of this as well

[ 0 ]

this backslash is not required and should go away

[ 0 ]

whoot whoot whot

[ 0 ]

ah i thought you were referring to null instanceof classa i will add sensitivity to nullchecks in a follow up

[ 0 ]

why not time time self session start self session timeout

[ 0 ]

there are white spaces remove one

[ 0 ]

Hi Marco, I hope to review it before the end of the week. I done dependencies because I thought that providers works like that. I thought that deleting without inserting and updating is a nonsense. But it's right that updating and inserting are not dependant. What do you preconise ?

[ 1 ]

your fake server has duplicate logic of the class under test due to the same inheritance you should choose a different style of mocking httmock is being use elsewhere in neutron

[ 0 ]

service host should not be needed

[ 0 ]

2nd iteration by using LOVE threads. It still using C++'s high resolution timer though.

[ 1 ]

"Attention," is really weird grammatically

[ 1 ]

you missed this occurrence of type

[ 0 ]

Damn. I'm attaching the file.<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/8573">issues.joomla.org/joomla-cms/8573</a>.</sub>

[ 1 ]

useless string

[ 0 ]

this subshell is not correct but could you write this simpler as d proc pid

[ 0 ]

i am totally fine with pushing this toward a real boolean

[ 0 ]

oh wait shit you\u2019re right, was mixing this up with the badfood toxin

[ 1 ]

secondary should be used to find the array you are failing over to

[ 0 ]

i think we should remove tmp dir at the end of script

[ 0 ]

i would put it here right before rspec runs if options update librarian puppet prepare library end

[ 0 ]

we raised an error testnaerror in autotest but i cannot find the equivalent in tast any suggestion is it ok to mark it as pass

[ 0 ]