showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
I might just rework this, it sucks Edit: never mind, can't be as clever as I had hoped.	[ 1 ]
use vp nuq doff quant profiles coef bands	[ 0 ]
for people who are confused this is basically a meme pr I originally coded slapping when headpatting was originally added and then both were removed slapping as it is now is functionally identical except far less suffering to use do not fucking add this, disarm mouth slapping SUCKED	[ 1 ]
afaiu this should be removed as well here and in l settings additional components mongo value false	[ 0 ]
Fucking old coders and nu-coders	[ 1 ]
using the default aosp applications i am seeing the following logs i talked to nick and i am going to split the auditallows across the specific domains to make it very clear which app domains use which services untrusted app drmserver service mediaserver service nfc service surfaceflinger service system server service platform app mediaserver service radio service surfaceflinger service system server service system app nfc service surfaceflinger service system server service	[ 0 ]
on jaikumar ganesh wrote dbg should be false to avoid log spew done	[ 0 ]
Uh, okay, that's surprising. I'm gonna try later on the most modern PowerVR device I have, a wacky Spreadtrum x86-64 phone.	[ 1 ]
Reasons this is dumb: I'm sacrificing the unique species aspect I cant make them forced vegetarian I have to hardcode mutant part checks for shit with elves vs catbeest retards	[ 1 ]
it seems only create subnet will invoke create subnet db so the none and temp you added here seems useless	[ 0 ]
you fucked this one up	[ 1 ]
@mrIncompetent no not so far, just trap into this at every demo and it opens up some questions on the audience. Also if someone takes a picture or video it's not perfect. The cluster itself is created trough the UI.	[ 1 ]
policy id should be policy name	[ 0 ]
you're right but this is a webedit PR cause I did it while pissed so gimme a sec and do it properly	[ 1 ]
devops driver dummy can be added as well	[ 0 ]
Should be fine to delete this as it's in a controller and (technically) not accessible outside the controller scope. I say technically because it's still possible in AngularJS to do some disgusting scope manipulation and get access to controller internals, but in reality it's a whole lot easier just to duplicate the function in your own code. If this were a service/factory, deleting would not be safe.	[ 1 ]
this sucks, but it's not your fault.	[ 1 ]
omg you are right removing now	[ 0 ]
i am not sure why we need to mock utils execute twice utils execute is mocked at l already	[ 0 ]
yey, my commit stat will raise like hell!	[ 1 ]
that is the localframeclient must be an emptylocalframeclient	[ 0 ]
based on hacking the zmq import should come after this next section of stdlib imports	[ 0 ]
Also, if this is in the wrong area, feel free to call me a faggot and/or direct me to the proper place to make requests	[ 1 ]
YOU CRAZY? A FUCKING PULSE RIFLE?	[ 1 ]
Tweet from Pig Bussy at London, England	[ 1 ]
also you now have a conflict here since is non empty and non zero	[ 0 ]
just asprintf this or return a std string no sprintf in new code	[ 0 ]
huge nit want once space after the colon	[ 0 ]
this is still lvm iscsi also below please change	[ 0 ]
why to print and why just this why not just use a logger	[ 0 ]
based on the comment why this property named touchinprogress just want to be clear because your next comment refers to interaction	[ 0 ]
why does this take an argument....weird.	[ 1 ]
poor man s enums	[ 0 ]
yes if that one fails we have already a corrupt calc model and it would just crash later	[ 0 ]
to me it is more like karate kid where terry make daniel bust up his foot kicking x s	[ 0 ]
Well, the standards are all a bit rubbish, I mean, what can you do? Python has PEP440 where the version/tag is used + the number of commits since, but that would suffer the same issue we've been talking about. You could force a custom integer into `pkgver()` before the revision count and hash I guess?	[ 1 ]
god imagine if someone manages to trick an admin into using this specific smite on them while they know sleeping carp, that'd be badass as hell (keep it in)	[ 1 ]
double evaluation sucks...	[ 1 ]
can you be a little more descriptive this comment is tautological	[ 0 ]
fantastic	[ 0 ]
strictly speaking it does not belong to this patch i have uploaded a new one	[ 0 ]
nit you are inside the dwarf namespace so you do not need this	[ 0 ]
this is misleading if i do sh tools coding checks sh fp you will get an error i think you can keep option or do f flake p pylint	[ 0 ]
Damn! Out-grammared!	[ 1 ]
Oh you think I just spelled one thing wrong? Oh boy get reading then, I'm sure I fucked something else somewhere. (Thanks)	[ 1 ]
should be cleared that the native abi remains unchanged and the change is for internal abi	[ 0 ]
as i said before we will not support rule notifications kill it	[ 0 ]
And we're 100% sure 99 fucking degrees won't still husk you, right?	[ 1 ]
God of War, Combat and the Sky. Lost his hand in an amusing story involving a giant wolf, a few dwarves and a ukrainian transvestite. Rather ironically his familiar is the wolf.	[ 1 ]
Yeah i think for now it would be best to fallback to GLES2 if possible. It would suck to hurt install base of existing users unless we really have to.	[ 1 ]
this is redundant convert to int ensures we will have an int	[ 0 ]
i apologise if i am being blind stupid but what email thread	[ 0 ]
should not you put your dummy gettext and dgettext in here instead	[ 0 ]
so now we have device tree and generated c storing key value pairs can we use one or the other if device tree is not up to the task let us kill it now if it is use that here instead please	[ 0 ]
This is still pretty ass so the TODO should stay.	[ 1 ]
ceph osd unset noout	[ 0 ]
useless ifdef	[ 0 ]
missing a title for edge vpn	[ 0 ]
This is fucked up. It was already here, though, and ToRban doesn't work anymore anyway. Also, no, I don't know why it's capitalized like that.	[ 1 ]
i am going to poke don s shoulder next time i pass him	[ 0 ]
Oh man, this would be bad. Good catch.	[ 1 ]
vscode was bitching about somehting so I changed some stuff and fixed your write to return a string instead of printing to console	[ 1 ]
i think that an enum will be perhaps better than a string	[ 0 ]
dedent this block to put out it	[ 0 ]
invalid intendation	[ 0 ]
why not unite the above lines to one from neutron openstack common gettestutils import lw le	[ 0 ]
this is useless since you overwrite msg fields at l	[ 0 ]
tests should go under osprofiler tests otherwise they are not even executed	[ 0 ]
nit isnodejs	[ 0 ]
have you considered passing rules instead to stop the nonsense or doing security group rules security group rules everywhere or is it painful	[ 0 ]
change to run playbooks sh script and on line	[ 0 ]
Shit, I mindlessly copied that from my Cit implementation where (IIRC) I used it more than once. Yeah, I'll just make it in the actual proc.	[ 1 ]
Fix usage/convention such that indentation is not so horrific	[ 1 ]
whip blade maybe? "whip sword" sounds a little ridiculous	[ 1 ]
this particular one is a big change i think i will do that in a separate patch i will file a bug to remind myself	[ 0 ]
port id returned obj floatingip get port id or original obj get port id if port id is none return	[ 0 ]
you re killing me here	[ 0 ]
The reason is I'm a shitcoder. Fixing this now though, thank you for pointing it out.	[ 1 ]
you need both tunnel id ranges and network vlan ranges	[ 0 ]
~Wacky merge here, I'll fix up.~ And it's fixed. Nothing a force push won't solve \U0001f605	[ 1 ]
Can confirm, it's the coders shitposting paradise for JQuery, SQL, and bits	[ 1 ]
I have no problem at all using my SAV MkI using a native USB interface. It runs at 12Mbps peak transfers with a BER which is a joke. I use a 1.5m cable with a choke but also use it with a rubbish cable flawlessly. One thing that would help is to look at the console and see how many retransmissions happen.	[ 1 ]
backslashes should only be used as a last resort	[ 0 ]
Damn I just woke up, didn't get enough coffee I guess... ;)	[ 1 ]
AVG detects a ton of false positives generally in P2P networking programs (it flags bittorrent the same way). Not much we can do other than someone reporting to AVG that their detector is crappy. No antivirus from virus total detects is as malicious: https://www.virustotal.com/#/url/4d7669b0cb6f9b2b92474c35e02dfffe2bc476e84ee48526408498361d015275/detection	[ 1 ]
The fuck, why are you removing the event based processing from this?	[ 1 ]
this is likely ok since the bad admin role check is no different than other priv calls	[ 0 ]
Oh fuck, I didn't change the description, it shouldn't be enabled, it should be "disabled" XD	[ 1 ]
If you specified the list of mutations new one needs to recieve you sure as hell dont want any random mutation to pop up	[ 1 ]
nit instead of line continuation you should use parens	[ 0 ]
what is all this extra canpass crap? why are you adding more stuff to the floor path and not the pool path?	[ 1 ]
by "insane nonsense" I mean not the renaming itself but the way it was done.	[ 1 ]
someday we are going to regret having these hardcoded everywhere not that there is a better way to do it here	[ 0 ]
dear duncan thomas this is not a version comparision here rather a referential comparision only so doing string comparision will not be a problem actually version comparision is done earlier and here we are just comparing whether it is none or else let me explain actual https header version comparision is done at c cinder api v volumes py we pass string to differentiate the function call is for microversion if req api version request matches none self volume api check volume filters filters else self volume api check volume filters filters then here we compare this argument part as string comparision here to check if this call needs to be executed as per microversion or normal hope i could explain	[ 0 ]
nevermind sdague schooled me on the regex	[ 0 ]
Agree to improve the EOS RAM market, but "actual usage ratio (used/total) of RAM" is easy to fake by store some rubbish in my own contract.	[ 1 ]
this only deletes subdirectories of workspace	[ 0 ]
this traceback is quite useless worse since chromeos is set to crash on warnings it will result in a reboot while running out of memory is severe it seems extreme to because a system reboot because of it	[ 0 ]
i think handler kind is a list so probably handler kind would work	[ 0 ]
i would agree that a log warning should be thrown here	[ 0 ]

I might just rework this, it sucks Edit: never mind, can't be as clever as I had hoped.

[ 1 ]

use vp nuq doff quant profiles coef bands

[ 0 ]

for people who are confused this is basically a meme pr I originally coded slapping when headpatting was originally added and then both were removed slapping as it is now is functionally identical except far less suffering to use do not fucking add this, disarm mouth slapping SUCKED

[ 1 ]

afaiu this should be removed as well here and in l settings additional components mongo value false

[ 0 ]

Fucking old coders and nu-coders

[ 1 ]

using the default aosp applications i am seeing the following logs i talked to nick and i am going to split the auditallows across the specific domains to make it very clear which app domains use which services untrusted app drmserver service mediaserver service nfc service surfaceflinger service system server service platform app mediaserver service radio service surfaceflinger service system server service system app nfc service surfaceflinger service system server service

[ 0 ]

on jaikumar ganesh wrote dbg should be false to avoid log spew done

[ 0 ]

Uh, okay, that's surprising. I'm gonna try later on the most modern PowerVR device I have, a wacky Spreadtrum x86-64 phone.

[ 1 ]

Reasons this is dumb: I'm sacrificing the unique species aspect I cant make them forced vegetarian I have to hardcode mutant part checks for shit with elves vs catbeest retards

[ 1 ]

it seems only create subnet will invoke create subnet db so the none and temp you added here seems useless

[ 0 ]

you fucked this one up

[ 1 ]

@mrIncompetent no not so far, just trap into this at every demo and it opens up some questions on the audience. Also if someone takes a picture or video it's not perfect. The cluster itself is created trough the UI.

[ 1 ]

policy id should be policy name

[ 0 ]

you're right but this is a webedit PR cause I did it while pissed so gimme a sec and do it properly

[ 1 ]

devops driver dummy can be added as well

[ 0 ]

Should be fine to delete this as it's in a controller and (technically) not accessible outside the controller scope. I say technically because it's still possible in AngularJS to do some disgusting scope manipulation and get access to controller internals, but in reality it's a whole lot easier just to duplicate the function in your own code. If this were a service/factory, deleting would not be safe.

[ 1 ]

this sucks, but it's not your fault.

[ 1 ]

omg you are right removing now

[ 0 ]

i am not sure why we need to mock utils execute twice utils execute is mocked at l already

[ 0 ]

yey, my commit stat will raise like hell!

[ 1 ]

that is the localframeclient must be an emptylocalframeclient

[ 0 ]

based on hacking the zmq import should come after this next section of stdlib imports

[ 0 ]

Also, if this is in the wrong area, feel free to call me a faggot and/or direct me to the proper place to make requests

[ 1 ]

YOU CRAZY? A FUCKING PULSE RIFLE?

[ 1 ]

Tweet from Pig Bussy at London, England

[ 1 ]

also you now have a conflict here since is non empty and non zero

[ 0 ]

just asprintf this or return a std string no sprintf in new code

[ 0 ]

huge nit want once space after the colon

[ 0 ]

this is still lvm iscsi also below please change

[ 0 ]

why to print and why just this why not just use a logger

[ 0 ]

based on the comment why this property named touchinprogress just want to be clear because your next comment refers to interaction

[ 0 ]

why does this take an argument....weird.

[ 1 ]

poor man s enums

[ 0 ]

yes if that one fails we have already a corrupt calc model and it would just crash later

[ 0 ]

to me it is more like karate kid where terry make daniel bust up his foot kicking x s

[ 0 ]

Well, the standards are all a bit rubbish, I mean, what can you do? Python has PEP440 where the version/tag is used + the number of commits since, but that would suffer the same issue we've been talking about. You could force a custom integer into `pkgver()` before the revision count and hash I guess?

[ 1 ]

god imagine if someone manages to trick an admin into using this specific smite on them while they know sleeping carp, that'd be badass as hell (keep it in)

[ 1 ]

double evaluation sucks...

[ 1 ]

can you be a little more descriptive this comment is tautological

[ 0 ]

fantastic

[ 0 ]

strictly speaking it does not belong to this patch i have uploaded a new one

[ 0 ]

nit you are inside the dwarf namespace so you do not need this

[ 0 ]

this is misleading if i do sh tools coding checks sh fp you will get an error i think you can keep option or do f flake p pylint

[ 0 ]

Damn! Out-grammared!

[ 1 ]

Oh you think I just spelled one thing wrong? Oh boy get reading then, I'm sure I fucked something else somewhere. (Thanks)

[ 1 ]

should be cleared that the native abi remains unchanged and the change is for internal abi

[ 0 ]

as i said before we will not support rule notifications kill it

[ 0 ]

And we're 100% sure 99 fucking degrees won't still husk you, right?

[ 1 ]

God of War, Combat and the Sky. Lost his hand in an amusing story involving a giant wolf, a few dwarves and a ukrainian transvestite. Rather ironically his familiar is the wolf.

[ 1 ]

Yeah i think for now it would be best to fallback to GLES2 if possible. It would suck to hurt install base of existing users unless we really have to.

[ 1 ]

this is redundant convert to int ensures we will have an int

[ 0 ]

i apologise if i am being blind stupid but what email thread

[ 0 ]

should not you put your dummy gettext and dgettext in here instead

[ 0 ]

so now we have device tree and generated c storing key value pairs can we use one or the other if device tree is not up to the task let us kill it now if it is use that here instead please

[ 0 ]

This is still pretty ass so the TODO should stay.

[ 1 ]

ceph osd unset noout

[ 0 ]

useless ifdef

[ 0 ]

missing a title for edge vpn

[ 0 ]

This is fucked up. It was already here, though, and ToRban doesn't work anymore anyway. Also, no, I don't know why it's capitalized like that.

[ 1 ]

i am going to poke don s shoulder next time i pass him

[ 0 ]

Oh man, this would be bad. Good catch.

[ 1 ]

vscode was bitching about somehting so I changed some stuff and fixed your write to return a string instead of printing to console

[ 1 ]

i think that an enum will be perhaps better than a string

[ 0 ]

dedent this block to put out it

[ 0 ]

invalid intendation

[ 0 ]

why not unite the above lines to one from neutron openstack common gettestutils import lw le

[ 0 ]

this is useless since you overwrite msg fields at l

[ 0 ]

tests should go under osprofiler tests otherwise they are not even executed

[ 0 ]

nit isnodejs

[ 0 ]

have you considered passing rules instead to stop the nonsense or doing security group rules security group rules everywhere or is it painful

[ 0 ]

change to run playbooks sh script and on line

[ 0 ]

Shit, I mindlessly copied that from my Cit implementation where (IIRC) I used it more than once. Yeah, I'll just make it in the actual proc.

[ 1 ]

Fix usage/convention such that indentation is not so horrific

[ 1 ]

whip blade maybe? "whip sword" sounds a little ridiculous

[ 1 ]

this particular one is a big change i think i will do that in a separate patch i will file a bug to remind myself

[ 0 ]

port id returned obj floatingip get port id or original obj get port id if port id is none return

[ 0 ]

you re killing me here

[ 0 ]

The reason is I'm a shitcoder. Fixing this now though, thank you for pointing it out.

[ 1 ]

you need both tunnel id ranges and network vlan ranges

[ 0 ]

~Wacky merge here, I'll fix up.~ And it's fixed. Nothing a force push won't solve \U0001f605

[ 1 ]

Can confirm, it's the coders shitposting paradise for JQuery, SQL, and bits

[ 1 ]

I have no problem at all using my SAV MkI using a native USB interface. It runs at 12Mbps peak transfers with a BER which is a joke. I use a 1.5m cable with a choke but also use it with a rubbish cable flawlessly. One thing that would help is to look at the console and see how many retransmissions happen.

[ 1 ]

backslashes should only be used as a last resort

[ 0 ]

Damn I just woke up, didn't get enough coffee I guess... ;)

[ 1 ]

AVG detects a ton of false positives generally in P2P networking programs (it flags bittorrent the same way). Not much we can do other than someone reporting to AVG that their detector is crappy. No antivirus from virus total detects is as malicious: https://www.virustotal.com/#/url/4d7669b0cb6f9b2b92474c35e02dfffe2bc476e84ee48526408498361d015275/detection

[ 1 ]

The fuck, why are you removing the event based processing from this?

[ 1 ]

this is likely ok since the bad admin role check is no different than other priv calls

[ 0 ]

Oh fuck, I didn't change the description, it shouldn't be enabled, it should be "disabled" XD

[ 1 ]

If you specified the list of mutations new one needs to recieve you sure as hell dont want any random mutation to pop up

[ 1 ]

nit instead of line continuation you should use parens

[ 0 ]

what is all this extra canpass crap? why are you adding more stuff to the floor path and not the pool path?

[ 1 ]

by "insane nonsense" I mean not the renaming itself but the way it was done.

[ 1 ]

someday we are going to regret having these hardcoded everywhere not that there is a better way to do it here

[ 0 ]

dear duncan thomas this is not a version comparision here rather a referential comparision only so doing string comparision will not be a problem actually version comparision is done earlier and here we are just comparing whether it is none or else let me explain actual https header version comparision is done at c cinder api v volumes py we pass string to differentiate the function call is for microversion if req api version request matches none self volume api check volume filters filters else self volume api check volume filters filters then here we compare this argument part as string comparision here to check if this call needs to be executed as per microversion or normal hope i could explain

[ 0 ]

nevermind sdague schooled me on the regex

[ 0 ]

Agree to improve the EOS RAM market, but "actual usage ratio (used/total) of RAM" is easy to fake by store some rubbish in my own contract.

[ 1 ]

this only deletes subdirectories of workspace

[ 0 ]

this traceback is quite useless worse since chromeos is set to crash on warnings it will result in a reboot while running out of memory is severe it seems extreme to because a system reboot because of it

[ 0 ]

i think handler kind is a list so probably handler kind would work

[ 0 ]

i would agree that a log warning should be thrown here

[ 0 ]