id
stringlengths
22
25
commit_message
stringlengths
137
6.96k
diffs
listlengths
0
63
derby-DERBY-2991-d4333738
DERBY-2991: Index split deadlock Added more test cases for BTreeForwardScan.fetchRows(). git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@746273 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2991-ebf2f360
DERBY-2991: Added a JUnit performance test for index scans git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@729039 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2991-f487e071
DERBY-2991: Index split deadlock Added more test cases for BTreeForwardScan.fetchRows() where the current leaf page was split while the index scan was waiting for a row lock. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@746954 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2992-8f01b3ce
DERBY-2992: getBinaryStream returns incorrect result (truncated value) if underlying blob is deleted Made OverflowInputStream throw exception if the underlying value is deleted/modified. (i.e. if the next overflow page cannot be found/accessed). Added a new error message (D015). Incorporated repro (originally contributed by Kathey Marsden, kmarsdenderby at sbcglobal dot net). Patch file: derby-2992-1b-throw_exception_on_eof.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@908586 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/data/OverflowInputStream.java", "hunks": [ { "added": [ "import org.apache.derby.iapi.services.i18n.MessageService;" ], "header": "@@ -25,6 +25,7 @@ import org.apache.derby.iapi.error.StandardException;", ...
derby-DERBY-3-a8db6658
DERBY-4442: Default value and identity in an INSERT result set evaluated too early Always add a ProjectRestrictNode on top of the source result set for an insert if the source columns are not ordered the same way as the target columns, or if inserting into a subset of the columns, and the source is not a table constructor. Then the adding of default values to the source result column list happens on top of the original source result node, and not inside that node. This means that the source result is produced before the default values are added, and the generation of the defaults happens at the correct time. As a side-effect, these other issues are fixed: DERBY-3 Identity column not filled consecutively with "insert ... select distinct" DERBY-4433 Cannot insert from EXCEPT/INTERSECT when target table has more columns than the source Much of the added code is actually old code revived from the Subversion history. Before DERBY-1644, we used to put a ProjectRestrictNode on top of the source result if it was a SetOperatorNode. The code that inserted the ProjectRestrictNode was added back and changed to operate on ResultSetNode instead of SetOperatorNode. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@885421 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/InsertNode.java", "hunks": [ { "added": [ "\t\tresultSet = enhanceAndCheckForAutoincrement(resultSet, inOrder, colMap);" ], "header": "@@ -411,9 +411,7 @@ public final class InsertNode extends DMLModStatementNod...
derby-DERBY-3002-b5105f32
DERBY-3002: Add partial support for ROLLUP variant of GROUP BY clause This change adds an initial implementation of support for the ROLLUP style of GROUP BY. Specifying ROLLUP causes Derby to perform multiple nested levels of grouping in a single pass over the input data, returning the results in a single result set. Most of the changes were made to GroupedAggregateResultSet, which is enhanced to be able to perform multiple levels of grouping in a single pass over the (sorted) input data. There are also changes to the SQL grammar to allow the new syntax to be specified, and changes to GroupByNode to pass the rollup specification through to the execution engine. Several tests were added to the OLAPTest test suite. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@824966 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/sql/execute/ResultSetFactory.java", "hunks": [ { "added": [ "\t\t@param isRollup true if this is a GROUP BY ROLLUP()" ], "header": "@@ -487,6 +487,7 @@ public interface ResultSetFactory {", "removed": [] }, ...
derby-DERBY-3004-4f278dd3
DERBY-3004: Get rid of the finalizer in EmbedResultSet Moved code from EmbedResultSet.finalize() to EmbedStatement.finalize() to make allocation and garbage collection of EmbedResultSet objects cheaper (ResultSets are normally allocated more frequently than Statements). git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@566981 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java", "hunks": [ { "added": [ "\t the activation or the finalization of the parent EmbedStatement", "\t @see EmbedStatement#finalize()", "\t @see EmbedPreparedStatement#finalize()" ], ...
derby-DERBY-3008-1b41764b
DERBY-3008 Set forCreateTable state of CreateIndexConstantAction at compile time. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@566425 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/TableElementList.java", "hunks": [ { "added": [ "\t\t\t\tindexAction = genIndexAction(", " forCreateTable,", " constraintDN.requiresUniqueIndex()," ], ...
derby-DERBY-3008-68db840f
DERBY-3008 (partial) Create a boolean forCreateTable flag in the CrreateConstraintConstantAction (set at compile time). Activation still has such a field, will be removed in future changes. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@565930 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/AlterTableNode.java", "hunks": [ { "added": [ "\tprivate void\tprepConstantAction() throws StandardException" ], "header": "@@ -375,7 +375,7 @@ public class AlterTableNode extends DDLStatementNode", "rem...
derby-DERBY-3009-f5ec6ec7
DERBY-3009: Out of memory error when creating a very large table Clear the local state in AlterTableConstantAction after invocation so that the memory held in the table descriptors can be freed. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1086527 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/execute/AlterTableConstantAction.java", "hunks": [ { "added": [ " /**", " * Run this constant action.", " *", " * @param activation the activation in which to run the action", " ...
derby-DERBY-3012-09787898
DERBY-3012 Pass in TransactionController to DataDictionary.getTableDescriptor(String name). Mainly a signature change, more changes needed to use the pass in transaction git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@566318 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/diag/SpaceTable.java", "hunks": [ { "added": [ " SchemaDescriptor sd = dd.getSchemaDescriptor(schemaName, tc, true);", " TableDescriptor td = dd.getTableDescriptor(tableName,sd, tc);" ], "header": "@@ -13...
derby-DERBY-302-a4e85351
Fix for DERBY-302, committing on behalf of DERBY-302 - Insert on Clob of 500k of data using streams takes long time. It takes 3 mins on a sun jvm1.4.2 and 20 seconds with ibm jvm 1.4.2. The following fix improves the performance of insert into a 500k blob from 20 seconds to around 1 second. Note that by changing just the test program time was reduced from 3 minutes to avg around 20 seconds. Currently in derby, for an insert on a clob using setCharacterStream what will happen is , the entire stream will be materialized into a char array and sent to store for the insert. ( we should not have to stream here. I will file another jira issue for this and put in all information I learnt) Given this is how inserts for large clobs are happening, the performance issue analysis is as follows: -- profiler run shows that most time is spent in SQLChar.readExternal which is where the materialization into a char array for the user's input stream happens. The growth of this array happens gradually till the entire stream is materialized into the array. Below code snippet shows by how much the array is grown each time when it realizes it has to read more bytes from the stream. The dvd hierarchy for clob is - SQLClob ( dvd) extends SQLVarChar extends SQLChar. So in SQLChar.readExternal ........ int growby = in.available(); if(growby < 64) growby = 64 and then an allocation and an arraycopy to the new allocated array. -- In the code snippet, 'in' is the wrapper around the user's stream which is ReaderToUTF8Stream. ReaderToUTF8Stream extends InputStream and does not override available() method . As per the spec, InputStream.available() returns 0. -- Thus each time, the array growth is by 64 bytes which is obviously not performant. so for a 500k clob insert, this would mean allocation & arraycopy steps happen ~8000 times. -- The ReaderToUTF8Stream that has the user's stream reads from the stream and does the utf8 conversion and puts it in a 4k array. I think it is reasonable to have a 32k buffer to store this information for clobs. Although I think there seems to be more possible optimizations in this area, I prefer the incremental approach too :) so this patch is a first step towards fixing the insert clob performance in the current system. Fix includes: -- enhanced the way the array was grown to keep the original 64 bytes for char ( seems reasonable given the upper limit for char) but override it to have 4k for varchar and clobs. -- OVERRIDE AVAILABLE() IN READERTOUTF8STREAM TO RETURN A BETTER ESTIMATE OF HOW MANY BYTES CAN BE READ. git-svn-id: https://svn.apache.org/repos/asf/incubator/derby/code/trunk@190415 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/types/SQLChar.java", "hunks": [ { "added": [ " /**", " * threshold, that decides when we return space back to the VM", " * see getString() where it is used", " */", " protected fina...
derby-DERBY-3023-125f9182
DERBY-4679 Several left outer joins causes unstable query with incorrect results Patch derby-4679b, which solves the following problem: When transitive closure generates new criteria into the query, it is sometimes confused by situations where the same column name appears in a result column list multiple times due to flattening of sub-queries. Flattening requires remapping of (table, column) numbers in column references. In cases where the same column name appears in a result column list multiple times, this lead to remapping (reassigning) wrong (table, column) numbers to column references in join predicates transformed to where clauses as a result of the flattening. See also DERBY-2526 and DERBY-3023 whose fixes which were partial solutions to the problem of wrong column number remappings confusing the transitive closure of search predicates performed by the preprocessing step of the optimizer. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@952237 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/ColumnReference.java", "hunks": [ { "added": [ " /* For remembering original (tn,cn) of this CR during join flattening. */", " private int tableNumberBeforeFlattening = -1;", " private int columnNum...
derby-DERBY-3025-cb29d726
DERBY-3025: NPE when connecting to database with securityMechanism=8 Use an internal attribute name when passing security mechanism from the network server to the embedded driver. This prevents confusion if an embedded connection is established with securityMechanism specified (in which case the security mechanism should be ignored). git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@570663 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3032-78cb2da6
DERBY-3032 Derby java.lang.ClassCastException returning null from a case statement in subquery git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@572738 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/ConditionalNode.java", "hunks": [ { "added": [ "\t * @param fromList FromList to pass on to bindExpression if recast is performed", "\t * @param subqueryList SubqueryList to pass on to bindExpression if reca...
derby-DERBY-3033-9247f313
DERBY-3033: NullPointerExceptions with flattening of NOT EXISTS subqueries This patch modifies the behavior of queries which contain correlated subqueries using a NOT EXISTS predicate. For example: select ... from a, b where <join criteria> and not exists (select from c where c.col = b.col) Depending on various conditions, subqueries may be "flattened", which is a term used to describe an internal rewriting process in which the subquery is converted into a same-level join with the parent tables. For many types of queries, such flattening results in multiple tables equijoined together, and the optimizer may recognize, via transitive closure of the equijoin predicates, additional opportunities for join predicates. However, when a NOT EXISTS table is in the join's from list, join predicates that mention the NOT EXISTS table cannot be used for such transitive closure, because these are not equijoin predicates, they are equi-NON-join predicates: the join succeeds when there are NOT matching rows in that table. Prior to this change, Derby might incorrectly infer an equijoin predicate in such a situation, which could lead to wrong results, or to crashes during query execution when the join processing attempted to access the non-existing rows. This change modifies the PredicateList processing to note when a join predicate includes a NOT EXISTS table, and to omit that join predicate from transitive closure processing. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@581943 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/PredicateList.java", "hunks": [ { "added": [ "\t *", "\t * Note that an equijoin predicate between two tables CANNOT be", "\t * used for transitive closure, if either of the tables is in the", "\t ...
derby-DERBY-3035-c48e69a1
DERBY-3035 Cannot restore backups without BACKUP.HISTORY file git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@712693 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3037-0f450705
DERBY-3304 DERBY-3037 DERBY-1585 I am adding a test case to check for the resultset from the java procedure call when the java procedure has done a rollback inside it. This test shows that in trunk, after checkin 602991 for DERBY-1585, a procedure does not return a resultset if there was a rollbck inside the procedure with resultset creation before rollback. This behavior is different than what happens in 10.2 codeline. In 10.2, a procedure will return a *closed* resultset if there was a rollback inside the procedure. But a procedure should not return closed result sets, so it appears that trunk is behaving correctly and 10.2's behavior was incorrect. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@628130 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/JDBC.java", "hunks": [ { "added": [ " * Assert that the statement has no more results(getMoreResults) and it ", " * indeed does not return any resultsets(by checking getResultSet). ", " * Also, ensu...
derby-DERBY-3037-0f4ab910
DERBY-3037 EmbedStatement.executeStatement at line 1276 was calling finish rather than close on the Language Resultset. I fixed that to make a call to close. In addition, I also had to move the code for collecting the stats from finish to close method in NoRowsResultSetImpl. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@604976 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/execute/NoRowsResultSetImpl.java", "hunks": [ { "added": [ " * Dump the stat if not already done so. Close all of the open subqueries." ], "header": "@@ -324,32 +324,12 @@ abstract class NoRowsResultSetImpl implemen...
derby-DERBY-3037-a660147e
DERBY-3037 This commit makes sure that EmbeddedResultSet.close() calls Language Resultset.close rather than Language Resultset.finish. This change caused few tests to fail. The tests had runtime statistics on but the code to dump the runtime statistics was in Language Resutlset.finish and not in Language Resultset.close. To fix this, I have moved the code to dump runtime statistics from Language Resutlset.finish into Lanugage ResultSet.close This has fixed the test failures. As for the 2nd part of this jira entry which is to have activation.close() call Language Resultset.finish(). This already happens in impl.sql.execute.BaseActivation.close() and hence no work was needed for the 2nd part. Will merge this change into 10.3 codeline soon. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@601830 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/execute/BasicNoPutResultSetImpl.java", "hunks": [ { "added": [], "header": "@@ -28,11 +28,8 @@ import org.apache.derby.iapi.error.StandardException;", "removed": [ "import org.apache.derby.iapi.services.monitor.Monitor;...
derby-DERBY-3038-1c709640
DERBY-3038 SYSCS_IMPORT_TABLE FAILS with No current connection after shutdown/reconnect to encrypted database : 10.3.1.4 regression Patch DERBY-3038-2, will merge into 10.3 branch too. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@574733 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-304-c10c4049
DERBY-304 submitted on behalf of Suresh Thalamati Fix : 1) Do not allow backup path to be any derby database directory. A directory is assumed to be a derby database directory if it has service.properties file in it. 2) copy files needed from the database home into the backup one by one instead of recursive copy from the top directory. 3) while copying the directories under jar directory, copy each sub directory separately without copying any subdirectories under them (There should not be any unless if user has created explicitly or created backup at that location). 4) Log and Seg0 directory are NOT already copied recursively, this was changed as part of online backup work (DERBY-239). git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@379620 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/services/io/FileUtil.java", "hunks": [ { "added": [ " return copyDirectory( storageFactory, from, to, null, null, true);", "", " String[] filter, ", " ...
derby-DERBY-3041-c06280c2
DERBY-3041 (partial) Removed the classes utilMain14 and Main14. utilMain14.createStatement() was moved to utilMain. utilMain.setHoldability() and utilMain.getHoldability() were removed since they serve no purpose now that we don't support Java 1.3. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@572058 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/tools/org/apache/derby/impl/tools/ij/ijException.java", "hunks": [ { "added": [], "header": "@@ -59,7 +59,6 @@ public class ijException extends RuntimeException {", "removed": [ "\tprivate final static String HoldCursorsNotSupported = \"IJ_HoldCursAre4...
derby-DERBY-3041-ccf72fbf
DERBY-3041: Removed the createStatement() method in utilMain and factored out common error checks in operations on scrollable cursors. These changes also removed workarounds for problems in very old versions of WebLogic and JCC. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@572244 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/tools/org/apache/derby/impl/tools/ij/utilMain.java", "hunks": [ { "added": [], "header": "@@ -21,8 +21,6 @@", "removed": [ "import org.apache.derby.iapi.reference.JDBC20Translation;", "" ] }, { "added": [], ...
derby-DERBY-3042-65241d51
DERBY-3042: Remove Java 1.3 specific code in NetworkServerControlImpl.setUpSocket() Removed the workaround since the network server does not run under Java 1.3 any more. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@572001 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java", "hunks": [ { "added": [ "\t\t\t\t\t\t\t\t\t\t\t\tcreateSocket(hostAddress, portNumber);", "\t\t\t\t\t\t\t\t\t\t\t\tcreateSocket(hostAddress, portNumber);" ], "header": "@@ -2241,...
derby-DERBY-3043-a9d71730
DERBY-3043: Schema does not exist error when table uses check constraint In Derby, the CREATE SCHEMA statement is optional. When a table is created, if the schema which contains it does not yet exist, the schema is automatically created as well. If the CREATE TABLE statement contained a CHECK constraint, the statement was being rejected with the error Schema 'XXX' does not exist This error occurred during compilation and bind processing for the check constraint, when the criteria used in the constraint were bound to the table definition. At that point in query processing, the schema name for the table had not yet been filled in, so the bind processing was searching the DataDictionary for a schema which did not yet exist (the schema will exist after the statement is executed, but we're still compiling the statement at this point). This change modifies the bind processing for the CHECK constraint so that the FromBaseTable object used to bind the constraint has the schema name fully filled in, ensuring that the bind processing will be able to manipulate the table without encountering no-such-schema errors. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@705887 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3046-53d64978
DERBY-3046 This commit fixes the null pointer exception by making sure that we do not try to access the object's elements if the object is null. I have also added a test case for this fix. Additionally, while working on this, I found that we return different sql state for parameter being out of range for PreparedStatment.setObject and Preparedstatement.setXXX calls in Network Server. I have entered a Jira entry for that issue DERBY-3139. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@586596 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3049-24e3f7e9
DERBY-3049 Remove final traces of language ResultSet.getResultDescription(). Method was being removed as the result description was not specific to the ResultSet and thus was confusing. The ResultDescription is specific to the statement and is available through the activation or prepared plan. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@601395 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/execute/DMLVTIResultSet.java", "hunks": [ { "added": [], "header": "@@ -51,19 +51,9 @@ abstract class DMLVTIResultSet extends DMLWriteResultSet", "removed": [ " ResultDescription \t\tresultDescription;", "\...
derby-DERBY-3049-4ef86215
DERBY-3049 (partial) Change EmbedResultSet to get a ResultDescription from the activation. Cleanup some ResultSet implementations of getResultDescription() git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@572753 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java", "hunks": [ { "added": [ "\t\tresultDescription = theResults.getActivation().getResultDescription();" ], "header": "@@ -251,7 +251,7 @@ public abstract class EmbedResultSet extends ConnectionChild"...
derby-DERBY-3049-51572c87
DERBY-3049 (partial) Cleanup of some unused fields/variables in ResultSet implementations that leads to some ResultDescription related methods being no longer used and hence removed git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@600678 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/sql/dictionary/DataDescriptorGenerator.java", "hunks": [ { "added": [ "import java.sql.Timestamp;", "import org.apache.derby.catalog.types.ReferencedColumnsDescriptorImpl;", "import org.apache.derby.iapi.error.StandardE...
derby-DERBY-3049-88bb146d
DERBY-3049 (partial) More cleanup related to removing the confusing (language) ResultSet.getResultDescription() method. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@598739 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/execute/DeleteCascadeResultSet.java", "hunks": [ { "added": [ "class DeleteCascadeResultSet extends DeleteResultSet" ], "header": "@@ -53,7 +53,7 @@ import java.util.Enumeration;", "removed": [ "public...
derby-DERBY-3049-c69c8b01
DERBY-4610: Error attempting delete with cascade and triggers Backed out the fix for DERBY-3049 (four commits) using this command: svn merge -c -601395,-600678,-598739,-572753 . Additionally, two import statements that had been removed in later commits had to be reintroduced manually in BasicNoPutResultSetImpl.java and TemporaryRowHolderImpl.java. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@940462 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/sql/dictionary/DataDescriptorGenerator.java", "hunks": [ { "added": [ "import org.apache.derby.iapi.services.monitor.Monitor;", "import org.apache.derby.iapi.error.StandardException;", "", "import org.apache.d...
derby-DERBY-3056-6c3076f6
DERBY-3056; making test run with JSR169, although not exactly testing what test was designed to test. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@573418 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3057-af27f3c8
DERBY-3057 - enabling test TableFunctionTest.java to run with j2ME/CDC/JSR169. - adjusted method equals(Object) in junit.JDBC$GeneratedID to implement a similar check for JSR169 as is achieved with String.matches() (which is not available with JSR169) - implemented method BinaryDecimal.setValueFromResultSet() which gets executed by the test (also adjusted javadoc referring to non-existing CDCDecimal) - adjusted test TableFunctionTest to call an appropriate method instead of ResultSet.getBigDecimal() (which is not available with JSR169). git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@575364 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/types/BinaryDecimal.java", "hunks": [ { "added": [ " * BigIntegerDecimal implementation." ], "header": "@@ -36,7 +36,7 @@ import org.apache.derby.iapi.services.sanity.SanityManager;", "removed": [ " * CDCD...
derby-DERBY-3060-99422a7c
DERBY-3060: Network Server incorrectly assumes that all SQLExceptions with error code 08004 are caused by an authentication failure. Contributed by Jørgen Løland git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@574870 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java", "hunks": [ { "added": [ "\t\t// These tests are ok since DATABASE_NOT_FOUND,", "\t\t// NO_SUCH_DATABASE and AUTH_INVALID_USER_NAME are not", "\t\t// ambigious error codes (on the first five char...
derby-DERBY-3061-70f168c9
DERBY-3061: Fix wrong results regression caused by incorrect sorting of "probe predicates" prior to code generation. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@574635 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/Predicate.java", "hunks": [ { "added": [ "\t\t/* The call to \"isRelationalOpPredicate()\" will return false", "\t\t * for a \"probe predicate\" because a probe predicate is really", "\t\t * a disguised IN l...
derby-DERBY-3063-0e86ea34
DERBY-3063: Extend the system function mechanism to support functions with multiple arguments. Added support for system functions with several arguments. Added numberic function ATAN2 (used the one in StrictMath). Patch file: derby-3063-2a.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@694166 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java", "hunks": [ { "added": [ " * This simple table can handle an arbitrary number of arguments", " *[0] = FUNCTION name", " *[1] = RETURNS type", " *[2] = ...
derby-DERBY-3068-c0a8467f
DERBY-3068 testImportExportProcedureNegative(org.apache.derbyTesting.functionTests.tests.tools.ImportExportProcedureTest)junit.framework.ComparisonFailure: Unexpected SQL state. expected:<38000> but was:<XIE0S> Changed unexpectedException in import to close the stream first. Changed ImportExportProcedureTest to delete files immediately after the test instead of before the test that recreates the file. Changed deleteFile to fail if it cannot delete the file. Ran suites.All on IBM 1.5 3 times without errors, and on jdk16. There may however still be a problem with import as I did see the unchanged test fail on IBM 1.5. With the new test structure it should be easier to identify the source of the problem if it happens again. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@614893 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/load/ImportAbstract.java", "hunks": [ { "added": [ "import java.io.IOException;" ], "header": "@@ -21,6 +21,7 @@", "removed": [] }, { "added": [ "\t\tthrow importError(ex);" ], ...
derby-DERBY-3069-1653bccb
DERBY-3069: Add stringArrayTable, a VTI useful for testing VTIs. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1431623 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3069-5f587f79
DERBY-3069: Fix a bug in the upgrade tests introduced by revision 1417835. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1418022 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3069-615cb37c
DERBY-6047: Fix NPE in routine resolution introduced by work on DERBY-3069. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1435267 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/StaticMethodCallNode.java", "hunks": [ { "added": [ "\t\t\tRoutineAliasInfo rai = (RoutineAliasInfo) proc.getAliasInfo();", "\t\t\tint parameterCount = rai.getParameterCount();", " boolean hasVara...
derby-DERBY-3069-68573fc4
DERBY-3069: Backing out this feature. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@630351 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/services/loader/ClassInspector.java", "hunks": [ { "added": [], "header": "@@ -21,8 +21,6 @@", "removed": [ "import org.apache.derby.iapi.services.info.JVMInfo;", "" ] }, { "added": [ ...
derby-DERBY-3069-7b398e91
DERBY-3069: Support varargs in user code. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@579653 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/services/loader/ClassInspector.java", "hunks": [ { "added": [ "import org.apache.derby.iapi.services.info.JVMInfo;", "" ], "header": "@@ -21,6 +21,8 @@", "removed": [] }, { "added": [ ...
derby-DERBY-3069-ba70926b
DERBY-3069: Fix varargs bugs in handling of primitive args and out/inout args. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1421052 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/MethodCallNode.java", "hunks": [ { "added": [ " boolean hasVarargs = hasVarargs();", " int firstVarargIdx = getFirstVarargIdx();", " int paramCount = signature.length;", ...
derby-DERBY-3069-f9596d49
DERBY-3069: DDL for varargs routines. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1417835 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/catalog/types/RoutineAliasInfo.java", "hunks": [ { "added": [ "\t/** PARAMETER STYLE DERBY */", "\tpublic static final short PS_DERBY = PS_DERBY_JDBC_RESULT_SET + 1;", "", " private static final short SECURITY_D...
derby-DERBY-3074-507841dc
DERBY-3074 Database shutdown exception 08006 throws SQLTransientConnectionException instead of SQLNonTransientConnectionException DERBY-3075 Client error: 08001 Error connecting to server.. throws SQLTransientConnectionException instead of SQLNonTransientConnectionException git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@576546 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/SQLExceptionFactory40.java", "hunks": [ { "added": [ "import java.sql.SQLNonTransientConnectionException;", "" ], "header": "@@ -28,9 +28,10 @@ import java.sql.SQLException;", "removed": [ "...
derby-DERBY-3075-507841dc
DERBY-3074 Database shutdown exception 08006 throws SQLTransientConnectionException instead of SQLNonTransientConnectionException DERBY-3075 Client error: 08001 Error connecting to server.. throws SQLTransientConnectionException instead of SQLNonTransientConnectionException git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@576546 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/SQLExceptionFactory40.java", "hunks": [ { "added": [ "import java.sql.SQLNonTransientConnectionException;", "" ], "header": "@@ -28,9 +28,10 @@ import java.sql.SQLException;", "removed": [ "...
derby-DERBY-3077-137e3a1a
DERBY-3077 Trying to reconnect with derby client after bringing server down throws SQL Exception 58009 rather than 08XXX exception Per Knut's suggestion, it changes expected client side errors such as SocketExceptions and IOExceptions to throw 08006 exceptions instead of 58 class exceptions. DRDA_CONNECTION_TERMINATED SOCKET_EXCEPTION COMMUNICATION_ERROR CONNECTION_FAILED_ON_DEFERRED_RESET NET_INSUFFICIENT_DATA NET_LOB_DATA_TOO_LARGE_FOR_JVM This leaves only protocol exceptions in the 58 class. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@576936 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/shared/org/apache/derby/shared/common/reference/SQLState.java", "hunks": [ { "added": [ " String DRDA_CONNECTION_TERMINATED = \"08006.C\";", " ", " // Use this version of SOCKET_EXCEPTION any time *except* when try...
derby-DERBY-3083-7093bb67
DERBY-3083: To fix regression introduced by DERBY-2196, do not fail server startup if derbynet.jar cannot be found. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@597125 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/drda/NetworkServerControl.java", "hunks": [ { "added": [ " * <li>Classes live in the jar files which we expect..</li>" ], "header": "@@ -545,6 +545,7 @@ public class NetworkServerControl{", "removed": [] }, ...
derby-DERBY-3083-fb6b9e8d
DERBY-3083: Revert 597125. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@599086 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/drda/NetworkServerControl.java", "hunks": [ { "added": [], "header": "@@ -545,7 +545,6 @@ public class NetworkServerControl{", "removed": [ " * <li>Classes live in the jar files which we expect..</li>" ] }, ...
derby-DERBY-3085-788599fc
DERBY-3085 Fails to handle BLOB fields with a PreparedStatement with size >32750 bytes Store a reference to the stream for the streamed parameter in the DRDAStatement.paramState and then drain the stream after statement execution if needed. There is only one parameter ever streamed, so only one field needed to be added. I added a test for both BLOB's and CLOB's to Blob4ClobTest.java. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@581012 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java", "hunks": [ { "added": [ "\t\t\t\t\t\t// Only the last EXTDTA is streamed. This is because all of ", "\t\t\t\t\t\t// the parameters have to be set before execution and are ", "\t\t\t\t\t\t// con...
derby-DERBY-3086-63adae87
DERBY-3086: More permissions and privilege blocks so that the server tracing and sysinfo will continue to work when the server automatically installs a security manager. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@592758 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/tools/org/apache/derby/impl/tools/sysinfo/Main.java", "hunks": [ { "added": [ "\t String classpath = null;", "", " try {", " classpath = (String) AccessController.doPrivileged( new PrivilegedAction()", " ...
derby-DERBY-3088-044179c3
DERBY-3088 - improvements to ServerPropertiesTest and related changes - adds an assertExecJavaCmdAsExpected method to BaseTestCase.java git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@612684 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/NetworkServerTestSetup.java", "hunks": [ { "added": [ " System.out.println( \"XXX server startup command = \");", " " ], "header": "@@ -225,12 +225,12 @@ final public class NetworkServerTes...
derby-DERBY-3088-0c8f7b8c
DERBY-3088 - (partial) follow up patch to convert testProperties to junit test ServerPropertiesTest. This change reworks the first fixture (ttestSetPortPriority) to take advantage of NetworkServerTestSetup; to do so there are changes to NetworkServerTestSetup. Also modified method execJavaCmd in junit.Utilities to do something in addition to the assertExecJavaCmdAsExpected in BaseTestCase and made use if it. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@616982 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/NetworkServerTestSetup.java", "hunks": [ { "added": [ " private final boolean startServerAtSetup;" ], "header": "@@ -59,6 +59,7 @@ final public class NetworkServerTestSetup extends BaseTestSetup {", "rem...
derby-DERBY-3092-0fc17872
DERBY-3092 (partial) Use the Map interface to access TransactionTable.trans This change will make it easier to replace the Hashtable with a ConcurrentHashMap on platforms that support java.util.concurrent, since we don't use Hashtable-specific methods anymore. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@901100 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/xact/TransactionTable.java", "hunks": [ { "added": [], "header": "@@ -25,7 +25,6 @@ import org.apache.derby.iapi.services.context.ContextManager;", "removed": [ "import org.apache.derby.iapi.services.io.FormatIdUt...
derby-DERBY-3092-3c48dd92
DERBY-3092 (partial) Don't expose TransactionTable's Hashtable Added a visitEntries() method that could be used instead of getTableForXA() to inspect the contents of the transaction table. Now, the Hashtable is only visible to the TransactionTable class, which will make it easier to replace it with another Map implementation later. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@901597 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/xact/TransactionTable.java", "hunks": [ { "added": [ " /**", " * Interface for visiting entries in the transaction table.", " * @see #visitEntries(EntryVisitor)", " */", " ...
derby-DERBY-3092-6e66e704
DERBY-3092 (partial) Add back optimization that was mistakenly removed by the previous patch git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@901162 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/xact/TransactionTable.java", "hunks": [ { "added": [ "\t\t\t\tif (count > 0)", "\t\t\t\t\tfor (Iterator it = trans.values().iterator(); it.hasNext();)", "\t\t\t\t\t\tTransactionTableEntry ent =", "\t...
derby-DERBY-3092-e21c3de3
DERBY-3092 (partial) Use visitors instead of iterators to scan the transaction table in the methods that synchronize explicitly on the Hashtable trans. This limits the usage of explicit synchronization on trans to one single method, TransactionTable.visitEntries(). git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@903200 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/xact/TransactionTable.java", "hunks": [ { "added": [ "import java.util.ArrayList;" ], "header": "@@ -38,6 +38,7 @@ import org.apache.derby.iapi.store.raw.xact.TransactionId;", "removed": [] }, ...
derby-DERBY-3093-98d82d9e
DERBY-3093: Intermittent transaction failure caused by internal duplicate savepoint name for triggers Don't use hashCode() to generate unique savepoint name. Contributed by James F. Adams. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@586956 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/conn/GenericStatementContext.java", "hunks": [ { "added": [ " // Counter used to create unique savepoint names.", " private static long nextNameId = Long.MIN_VALUE;", "" ], "header": "@@ -96,6 ...
derby-DERBY-3094-31d80c00
DERBY-3094: Grouping by expressions causes NullPointerException This change modifies GroupByNode.addUnAggColumns to process the expressions in the GROUP BY list in descending order of complexity, as measured by the number of column references in the GROUP BY list element. This ensures that when we are matching up expressions in the SELECT list with expressions in the GROUP BY list, that we choose the best match, and don't erroneously match a sub-expression. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@632221 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/GroupByNode.java", "hunks": [ { "added": [ "import java.util.ArrayList;", "import java.util.Comparator;", "import java.util.Collections;" ], "header": "@@ -23,6 +23,9 @@ package\torg.apache.d...
derby-DERBY-3096-7ae0ee5a
DERBY-3096 SSL handshake throws bad_certificate when server tries to authenticate client. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@596983 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/net/NaiveTrustManager.java", "hunks": [ { "added": [ "import java.io.FileInputStream;", "import javax.net.ssl.KeyManagerFactory;", "import java.security.KeyStore;", "" ], "header": "@@ -21,13...
derby-DERBY-3097-d9dd1e59
DERBY-4798 NPE in nested outer join Patch derby-4798a. Reintroduces the bailout code in BaseActivation#getColumnFromRow which was removed in DERBY-3097 until we understand why it is needed. Adds the repro for this issue to OuterJoinTest git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@998170 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3098-f6973263
DERBY-3098: If allowed by transaction isolation level, release locks whenn [BC]lob.free() is called. This changes the following files: M java/engine/org/apache/derby/impl/jdbc/EmbedClob.java Only initialize storeStream once. M java/engine/org/apache/derby/impl/store/raw/data/OverflowInputStream.java Do not lock for entire duration anymore, but until corresponding BaseContainerHandle has been closed. Also, make sure that locking only happens once. M java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/BlobTest.java Add tests to test locking of Blob after free() for different isolation levels. Also, moved code from setUp that is only relevant to one test case to that specific test case. M java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/ClobTest.java Add tests to test locking of Blob after free() for different isolation levels. Also, moved code from setUp that is only relevant to one test case to that specific test case. M java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/BlobClob4BlobTest.java Test that locks on Blob/Clob are released when transaction commits. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@584777 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/jdbc/EmbedClob.java", "hunks": [ { "added": [ " this.clob = new StoreStreamClob(storeStream, this);" ], "header": "@@ -144,7 +144,7 @@ final class EmbedClob extends ConnectionChild implements Clob", "...
derby-DERBY-3099-1309add8
DERBY-3099: Pages not freed on rollback to savepoint Ensured that slotFieldSize and slotEntrySize are properly initialized before StoredPage.initSpace() is called. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@583691 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/data/StoredPage.java", "hunks": [ { "added": [ " * totalSpace - slotEntrySize - 16 - OVERFLOW_POINTER_SIZE;", " private int maxFieldSize;" ], "header": "@@ -369,10 +369,9 @@ public class Stor...
derby-DERBY-3100-16b9059c
DERBY-3100: java.lang.NumberFormatException in test lang.TableFunctionTest Use locale-sensitive number parsing with NumberFormat instead of Double.parseDouble(). git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@581704 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3107-da0b88f0
DERBY-3107: Client: Clob.free() needs to tell server to release locator. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@584717 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/Clob.java", "hunks": [ { "added": [ "", "", "", "" ], "header": "@@ -47,17 +47,17 @@ public class Clob extends Lob implements java.sql.Clob {", "removed": [ " ", ...
derby-DERBY-3110-5028317c
DERBY-3110 server hangs after trace on command fails If there is an error in turning on tracing for any of the sessions, we fail to turn global tracing on and return an error to the client. The change also wraps the tracing in a privilege block. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@592111 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/impl/drda/DssTrace.java", "hunks": [ { "added": [ "import java.io.IOException;", "import java.io.PrintWriter;", "import java.security.AccessController;", "import java.security.PrivilegedActionException;", "...
derby-DERBY-3113-7c490a62
DERBY-3113: Use Arrays.fill() in StoredPage.clearSection() git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@584093 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/data/StoredPage.java", "hunks": [ { "added": [ "import java.util.Arrays;" ], "header": "@@ -73,6 +73,7 @@ import org.apache.derby.iapi.services.io.LimitObjectInput;", "removed": [] }, { ...
derby-DERBY-3116-a390adb3
DERBY-3116: totalSpace not properly initialized in AllocPage - in AllocPage.createPage(), set borrowedSpace before super.createPage() is called so that getMaxFreeSpace() returns the correct value when totalSpace is initialized - in CachedPage.setPageArray(), call usePageBuffer() also when the old buffer is reused. This ensures that totalSpace is recalculated when a page object is reused. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@644698 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/data/AllocPage.java", "hunks": [ { "added": [ " // We need to set borrowedSpace before we call super.createPage() so", " // that totalSpace is initialized correctly (DERBY-3116).", " borro...
derby-DERBY-3117-beb1faaf
DERBY-3117: Improve portability of grandparent lookup in PropertySetter. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@596438 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/build/org/apache/derbyPreBuild/PropertySetter.java", "hunks": [ { "added": [ " File jdkParentDirectory = getJdkParentDirectory();", " { default_j14lib = getJreLib( jdkParentDirectory, seed14 ); }", " { default_j15lib = g...
derby-DERBY-3117-f9b0b054
DERBY-3117: Adjust master build script to require the Java 5 compiler to build Derby Added extra directory in which to search when building on Solaris. This increases the chance of finding JDK 1.4.2, since the default location for JDKs on Solaris changed with JDK 5.0. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@596478 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/build/org/apache/derbyPreBuild/PropertySetter.java", "hunks": [ { "added": [ "import java.util.ArrayList;", "import java.util.List;" ], "header": "@@ -25,8 +25,10 @@ import java.io.File;", "removed": [] }, { "added...
derby-DERBY-3119-057ae460
DERBY-3119: Commit James Adams patch for resolving functions which return the Java object versions of the primitive datatypes. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@589766 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/MethodCallNode.java", "hunks": [ { "added": [], "header": "@@ -792,14 +792,6 @@ abstract class MethodCallNode extends JavaValueNode", "removed": [ "", "", "\t\t\t\t// DB2 LUW does not support...
derby-DERBY-3122-4177c4f3
DERBY-3122: Remove dead code in Clob git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@583921 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/Clob.java", "hunks": [ { "added": [], "header": "@@ -46,8 +46,6 @@ public class Clob extends Lob implements java.sql.Clob {", "removed": [ " private PreparedStatement internalLengthStmt_ = null;", "" ...
derby-DERBY-3130-bf5fd3cf
DERBY-3130: Reduce memory footprint of StoredRecordHeader Factor out some of the fields in StoredRecordHeader to reduce the object size when there's no overflow on the record. This reduces the peaks in heap space usage seen when the page cache gets filled with index pages (for instance after a SELECT COUNT(*) query). git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@643875 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/data/StoredRecordHeader.java", "hunks": [ { "added": [], "header": "@@ -28,7 +28,6 @@ import org.apache.derby.iapi.store.raw.RecordHandle;", "removed": [ "import java.io.InputStream;" ] }, { ...
derby-DERBY-3131-73bd5d40
DERBY-3131: Background cleaner has no daemon service after database creation Give the page cache and the container cache a background cleaner also when no recovery was performed during database boot. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@600457 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/store/raw/data/DataFactory.java", "hunks": [ { "added": [ "import org.apache.derby.iapi.services.daemon.DaemonService;" ], "header": "@@ -23,6 +23,7 @@ package org.apache.derby.iapi.store.raw.data;", "removed": [] ...
derby-DERBY-3132-129b0765
DERBY-3132: Changed some calls to deprecated methods Properties.save(OutputStream, String) -> Properties.store(OutputStream, String) URLDecoder.decode(String) -> URLDecoder.decode(String, String) ResultSet.getBigDecimal(int, int) -> ResultSet.getBigDecimal(int) git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@586317 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/build/org/apache/derbyBuild/splitmessages.java", "hunks": [ { "added": [ "\t\t\tc[i].store(fos, (String) null);" ], "header": "@@ -173,7 +173,7 @@ public class splitmessages {", "removed": [ "\t\t\tc[i].save(fos, (String) null);" ...
derby-DERBY-3132-e24d8efb
DERBY-3132: Added @deprecated javadoc tag to implementations of deprecated methods git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@586313 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/ResultSet.java", "hunks": [ { "added": [ " /** @deprecated */" ], "header": "@@ -783,6 +783,7 @@ public abstract class ResultSet implements java.sql.ResultSet,", "removed": [] }, { "added...
derby-DERBY-3135-36659bbf
DERBY-3135 Committing patch derby-3135-01-jsr169numerics-aa.diff generated by Rick. This patch enforces the expectation that Derby will call getString() when reading DECIMAL/NUMERIC columns from a table function. Thanks for the patch, Rick. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@586265 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3136-d0edfdc8
DERBY-3136 Cut down on unnecessary String and CollationElementIterator objects creation in Like.java class by changing the way we compare the character in value string vs character in the pattern string. When working with database with UCS_BASIC collation, the 2 characters should be the same otherwise we will return FALSE. When working with territory based collation, if the 2 characters are the same, then we can simply return TRUE because their collation elements will have to be same. But if the 2 characters are not same, then use the RuleBasedCollator for the territory to see if those 2 different characters match (ie they have same collation element(s) corresponding to them). git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@588147 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/types/Like.java", "hunks": [ { "added": [ "\t * If the character in val matches the character in pat, then it does not", "\t * matter if the database is UCS_BASIC or territory based, we simply return ", "\t * TRUE from ...
derby-DERBY-3137-09069c54
DERBY-3137 SQL roles: add catalog support Patch DERBY-3137-moreTests-b which adds a missign test case. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@727709 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3137-0ea31cab
DERBY-3137 SQL roles: add catalog support Patch DERBY-3137-setRoleAsStringFix-b: When setting a role with a literal string argument, we should do the same checks as for dynamic parameter on the identifier validity. Added that, plus new test cases and some refactoring. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@730802 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/util/IdUtil.java", "hunks": [ { "added": [ "import org.apache.derby.iapi.reference.Limits;" ], "header": "@@ -30,6 +30,7 @@ import java.io.StringReader;", "removed": [] } ] } ]
derby-DERBY-3137-44ea4f0f
DERBY-3137 SQL roles: add catalog support Patch DERBY-3137-setRoleNoCNF-3, which changes the behavior of SET ROLE ? and CURRENT_ROLE to comply with the latest SQL standard: - changes the behavior of SET ROLE ? to interpret the dynamic argument as a delimited SQL identifier. Up till now, it was interpreted as an identifer in internal (case normal form), but this seems wrong according to SQL 2003, section 18.3, GR3. A Java null value is no longer accepted as an argument. An empty string or a null value will give identifer parse error ("XCXA0"). NONE no longer has a special meaning when used in a dynamic ("SET ROLE ?") statement, cf. the addendum ISO/IEC 9075-2:2003/Cor.2:2007 section 18.3. Also, section 18.3, GR2 calls for whitespace to be removed from the string before interpreting it as an identifier. This is now also performed. - similarly changes the builtin function CURRENT_ROLE to now return a delimited identifer if the role is set, making it "symmetrical" with SET ROLE, that is, the output of CURRENT_ROLE can be used as input to "SET ROLE ?". When the role is not set, CURRENT_ROLE returns NULL (which can not be used as input to "SET ROLE ?", however). git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@699374 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/SpecialFunctionNode.java", "hunks": [ { "added": [ "\t\t\tmethodName = \"getCurrentRoleIdDelimited\";" ], "header": "@@ -158,7 +158,7 @@ public class SpecialFunctionNode extends ValueNode", "removed": [ ...
derby-DERBY-3137-4e3ddd75
DERBY-3137 SQL roles: add catalog support Patch DERBY-3137-rename-b. Renaming plus misc cleanup. No behavioral change. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@661123 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/sql/dictionary/DataDescriptorGenerator.java", "hunks": [ { "added": [ " * Create a new role grant descriptor", "\t * @param uuid unique identifier for this role grant descriptor in", "\t * time and space" ...
derby-DERBY-3137-64f3218d
DERBY-3137 SQL roles: add catalog support Patch DERBY-3137-setRoleNoDynamicNone, which forbids use of "NONE" as an identifier to a dynamic SET ROLE statement, unless delimited. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@704754 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/execute/SetRoleConstantAction.java", "hunks": [ { "added": [ "import org.apache.derby.iapi.util.StringUtil;" ], "header": "@@ -35,6 +35,7 @@ import org.apache.derby.iapi.sql.Activation;", "removed": [] } ...
derby-DERBY-3137-a6c7bc73
DERBY-3137 SQL roles: add catalog support Patch DERBY-3137-modeTests which adds a missing test case: Creating a role that already exists. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@727417 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3137-d02fa84d
DERBY-3137 SQL roles: add catalog support Patch DERBY-3137-ijfix: - a fix to ij's "SHOW ROLES" command to give an error message if the driver is not Derby embedded or client. The command does not use database metadata, so the generated select from SYS.SYSROLES is inherently Derby specific. - a new simple test for the command, tools/ij_show_roles.sql (run via JUnit/ToolScripts.java). The test is run both the embedded and via the network client. - a fix to escape case normal form role names to protect the role id when performing DROP ROLE in CleanDatabaseTestSetup#removeRoles (the test above provoked this bug). git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@699366 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/tools/org/apache/derby/impl/tools/ij/Session.java", "hunks": [ { "added": [ "\tboolean isEmbeddedDerby = false; // Is this the Derby Embedded JDBC Driver", "" ], "header": "@@ -52,6 +52,8 @@ class Session {", "removed": [] }, ...
derby-DERBY-3137-f717f799
DERBY-3137 SQL roles: add catalog support Patch DERBY-3137-uuid adds a UUID column to SYS.SYSROLES. The new column is needed for implementing persistent dependencies on role definitions and grants. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@614273 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/sql/dictionary/DataDescriptorGenerator.java", "hunks": [ { "added": [ "\t * @param uuid unique identifier for this role descriptor in time and space" ], "header": "@@ -488,6 +488,7 @@ public class DataDescriptorGenerator", ...
derby-DERBY-3138-3bbcfabe
DERBY-3138: Fix for this bug is to use the correct overload of accept() during preprocessing. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@587230 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3139-53d64978
DERBY-3046 This commit fixes the null pointer exception by making sure that we do not try to access the object's elements if the object is null. I have also added a test case for this fix. Additionally, while working on this, I found that we return different sql state for parameter being out of range for PreparedStatment.setObject and Preparedstatement.setXXX calls in Network Server. I have entered a Jira entry for that issue DERBY-3139. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@586596 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3142-9a55084e
DERBY-3142: sysinfo ignores derby.ui.locale Fetch sysinfo's resource bundle from LocalizedResource, which recognizes derby.ui.locale, instead of directly from ResourceBundle.getBundle(), which only considers the JVM's default locale. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@597610 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/tools/org/apache/derby/impl/tools/sysinfo/Main.java", "hunks": [ { "added": [ " /**", " * Name of file which contains messages for sysinfo.", " */", " private final static String MESSAGE_FILE =", " \"org.apa...
derby-DERBY-3147-0fd9a50e
DERBY-3147 Add some comments to ParseId.java to clarify behaviour git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@589712 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/util/IdUtil.java", "hunks": [ { "added": [ "\tprivate static String parseId(StringReader r, boolean normalize, boolean normalizeToUpper)" ], "header": "@@ -197,7 +197,7 @@ public abstract class IdUtil", "removed": [...
derby-DERBY-3147-6870e87f
DERBY-3147 (partial) Remove unused code that allowed lower-casing for SQL identifiers in the system catalogs. Derby's identifiers are always upper cased. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@588385 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/sql/dictionary/CatalogRowFactory.java", "hunks": [ { "added": [], "header": "@@ -62,7 +62,6 @@ public abstract\tclass CatalogRowFactory", "removed": [ " private boolean convertIdToLower;" ] }, { ...
derby-DERBY-3147-7206fbcb
DERBY-3147 Add some tests for duplicates in the read only and full access lists as database properties. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@589796 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3147-90676624
DERBY-3147 Remove some unused lower identifier casing code, clarify some methods in IDUtil by renaming them. Add some tests for duplicates in the read only and full access lists as database properties. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@589749 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/catalog/SystemProcedures.java", "hunks": [ { "added": [ "\t\t\tString[] st = IdUtil.parseMultiPartSQLIdentifier(jar.trim());" ], "header": "@@ -985,7 +985,7 @@ public class SystemProcedures {", "removed": [ "\...
derby-DERBY-3147-9ac3a768
DERBY-3147 (partial) Clean of handling user identifiers and renaming some IdUtil methods with comments to make behaviour clearer. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@589804 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/util/IdUtil.java", "hunks": [ { "added": [ "c" ], "header": "@@ -129,11 +129,7 @@ public abstract class IdUtil", "removed": [ " Parse a multi-part (dot separated) SQL identifier form the", "...
derby-DERBY-3147-9fbf2cbb
DERBY-3147 (partial) Add two user names to AuthenticationTest that must be represented as delimited identifiers in SQL due to an @ sign or the user being 123. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@589829 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3147-aa438ff0
DERBY-3147 Remove last traces of lower-cased identifiers from IdUtil and StringUtil. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@590730 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/util/IdUtil.java", "hunks": [ { "added": [ "\t\t\t\treturn parseUnQId(r,normalize);" ], "header": "@@ -205,7 +205,7 @@ c", "removed": [ "\t\t\t\treturn parseUnQId(r,normalize, true);" ] }, ...
derby-DERBY-3147-c33061f5
DERBY-3147 Add more tests for various user names and the connection authorization git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@589902 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-3148-64e8bd34
DERBY-3148: Fix JUnit test code that searches for Xalan version to avoid "Malformed \uxxxx encoding" errors when the user's classpath has "\u.." in it. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@588698 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/XML.java", "hunks": [ { "added": [], "header": "@@ -34,7 +34,6 @@ import java.sql.PreparedStatement;", "removed": [ "import java.util.Properties;" ] }, { "added": [ " ...
derby-DERBY-3150-2bbaf40f
DERBY-3150 Add some testing of user identifier casing for JDBC connection requests including two commented out cases that fail. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@588304 13f79535-47bb-0310-9956-ffa450edef68
[]