id stringlengths 22 25 | commit_message stringlengths 137 6.96k | diffs listlengths 0 63 |
|---|---|---|
derby-DERBY-3270-392ac57f | DERBY-3270 Delayed (on-demand) creation of current user schema makes select from view belonging to other schema fail.
Fixed with patch derby-3270-dhw-3. This temporarily sets the default
current schema back to what it was at the time of definition of the
schema. This need also exsts in other places, so a general mechanism
to do this was factored in and used in all such places.
New testcase added.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@735084 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CompilerContextImpl.java",
"hunks": [
{
"added": [
""
],
"header": "@@ -1,3 +1,4 @@",
"removed": []
},
{
"added": [
"\t\tdefaultSchemaStack = null;"
],
"head... |
derby-DERBY-3279-20bd3c03 | DERBY-3279: Add logic for execution-time sorting of IN list values
into DESCENDING order when required. This is necessary when doing
IN-list "multi-probing" on some column C for which a DESC sort has
been eliminated (by the optimizer). In such a case the row values
will come back in the order in which they appear in the IN List,
which means the IN list values must themselves be sorted in the
correct (descending) order.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@616126 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/execute/ResultSetFactory.java",
"hunks": [
{
"added": [
"\t\t@param sortRequired Which type of sort we need for the values",
"\t\t\t(ascending, descending, or none)."
],
"header": "@@ -1002,8 +1002,8 @@ public... |
derby-DERBY-3279-50567fe2 | DERBY-3279: Add logic for execution-time sorting of IN list values
into DESCENDING order when required.
This is a follow-up patch to add an implementation of the
adjustForSortElimination(RequiredRowOrdering) to IndexToBaseRowNode,
which was missing from the previous commit (svn # 616126). This
commit also adds more test cases to InListMultiProbeTest.java.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@617548 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/IndexToBaseRowNode.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.compile.RequiredRowOrdering;"
],
"header": "@@ -26,6 +26,7 @@ import org.apache.derby.iapi.services.context.ContextManager;",
... |
derby-DERBY-3288-00679884 | DERBY-3288: Fix optimizer dependency tracking logic so that it
correctly enforces join order dependencies between Optimizables,
even when plan "short-circuiting" occurs. This patch also fixes
a bug in FromVTI's referenced table map (which affects dependencies)
and does a slight refactoring of the "pull Optimizable" code for
the sake of clarity. And finally, it adds an appropriate test
case to the existing lang/subqueryFlattening.sql test.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@618841 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/OptimizerImpl.java",
"hunks": [
{
"added": [
"\t\t\tint nextOptimizable = proposedJoinOrder[joinPosition] + 1;",
"\t\t\tif (proposedJoinOrder[joinPosition] >= 0)",
"\t\t\t{",
"\t\t\t\t/* We are eit... |
derby-DERBY-3296-161e9cca | DERBY-3296: Importing to table in default schema fails when another table with the same name exists in a different schema
If schema isn't specified, ColumnInfo should pass the name of the
session's current schema to DatabaseMetaData.getColumns().
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@779681 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/load/ColumnInfo.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.jdbc.EngineConnection;"
],
"header": "@@ -33,6 +33,7 @@ import java.sql.Connection;",
"removed": []
}
]
}
] |
derby-DERBY-3299-c437565f | DERBY-3299 (incremental): Updates ConglomerateDescriptor.java to include
logic for detecting a conglomerate "replacement" scenario, and adds logic
to drop the old (shared) conglomerate in those scenarios. Also changes
the various ConstantAction classes which rely on the "drop(...)" methods
of ConglomerateDescriptor and ConstraintDescriptor so that they use the
utility methods added as part of svn # 628181. This commit is the one
which "activates" the previous changes for this issue and ultimately
changes Derby's behavior to fix the problem. Test cases will be added
in a subsequent commit.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@629160 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/ConglomerateDescriptor.java",
"hunks": [
{
"added": [
"\t ConglomerateDescriptor [] congDescs =",
"\t dd.getConglomerateDescriptors(getConglomerateNumber());",
"",
"\t\tboolean dropCon... |
derby-DERBY-3299-c92685ee | DERBY-3299 (incremental): Add several utility methods to
DDLSingleTableConstantAction.java that can be called by the various
ConstantAction subclasses to drop a constraint and/or a conglomerate
descriptor. In addition to performing the drop as before, these
utility methods also check to see if dropping the constraint or
index necessitates the "update" of a shared physical conglomerate.
If so, the new methods will take the necessary steps to create
create a new ("replacement") physical conglomerate that correctly
satisfies all remaining conglomerate descriptors--i.e. all of the
ones that were sharing the dropped physical conglomerate.
Note that a) Derby does not currently have logic to recognize when
a shared physical conglomerate needs to be updated (that's coming
in a subsequent patch), and b) there are currently no calls to the
new utility methods. Thus this commit should not have any effect
on Derby yet (incremental development).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@628181 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/ConglomerateDescriptor.java",
"hunks": [
{
"added": [
" * @param lcc Connection context to use for dropping",
" * @param td TableDescriptor for the table to which this",
" * conglomerate belo... |
derby-DERBY-3299-cf870799 | DERBY-3299 (incremental: Changes/additions to CreateIndexConstantAction.java
so that it can support the creation of "replacement" conglomerates, which
will be necessary when the physical conglomerate for an index has been
dropped but the index descriptor still exists. This can happen if multiple
indexes share a physical conglomerate but then the conglomerate is dropped
as part of "drop index" processing for one of the indexes. (Note that
"indexes" here includes indexes which were created to back constraints).
In that case we'll need to create a new "replacement" physical conglomerate
to support the existing descriptor.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@627836 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/CreateIndexConstantAction.java",
"hunks": [
{
"added": [
"\t/** Conglomerate number for the conglomerate created by this",
"\t * constant action; -1L if this constant action has not been",
"\t * executed. I... |
derby-DERBY-3301-de519067 | DERBY-3301: Incorrect result from query with nested EXIST
Prevent the optimizer from flattening subqueries that
need to be evaluated to get correct results.
Patch contributed by Thomas Nielsen
Patch files: derby-3301-8.diff, derby-3301-test-master-2.diff,
derby-3301-test-3.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@618586 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/SelectNode.java",
"hunks": [
{
"added": [
"\tboolean originalWhereClauseHadSubqueries;",
"\t"
],
"header": "@@ -112,6 +112,8 @@ public class SelectNode extends ResultSetNode",
"removed": []
... |
derby-DERBY-3302-9460d4cc | DERBY-3302 The user was running into null pointer exception at the time of database recovery
because Derby was trying to get the Collator object through database context. But the
Collator object is already available in the territory sensitive character classes and we
do not have to go to database context to get it. I changed the code to use that collator
object rather than look into database context. The reason for null pointer exception was
that database context was not loaded yet during database recovery.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@610846 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/SQLChar.java",
"hunks": [
{
"added": [
"\t/**",
"\t * This method gets called for the collation sensitive char classes ie",
"\t * CollatorSQLChar, CollatorSQLVarchar, CollatorSQLLongvarchar,",
"\t * Coll... |
derby-DERBY-3303-d2a6cce8 | DERBY-3303: Fix OrderByColumn.java to account for "pulled" GROUP BY columns
when a) checking to see if the user has specified a valid ORDER BY column,
and b) trying to resolve "pulled" ORDER BY columns to their underlying values.
Also, add some relevant test cases to the existing lang/orderby.sql test.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@628823 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/OrderByColumn.java",
"hunks": [
{
"added": [
"",
"\t\t\t/* Column is out of range if either a) resultCol is null, OR",
"\t\t\t * b) resultCol points to a column that is not visible to the",
"\t\t\t... |
derby-DERBY-3304-002bf942 | DERBY-3304 and DERBY-3414
This serves as a test case for both the jira entries above.
Number of code changes for transaction ending time went in as part of DERBY-3304 and this
new test will check those code changes for specific case of rollback inside a java procedure
call.
The test case is currently disabled for network server because the rollback inside the
procedure is not closing all the resultsets and DERBY-3414 is to track this behavior of
network server. Once DERBY-3414 is fixed, we should enable the test for network server.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@627673 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3304-039b8cdf | Adding a junit test for the standalone test case provided by Dag for DERBY-3304. Here, we
are adding a Java procedure which does a commit and then returns a resultset back to the
caller. The resultset should not get closed as part of the commit.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@614292 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3304-0f450705 | DERBY-3304
DERBY-3037
DERBY-1585
I am adding a test case to check for the resultset from the java procedure call when the
java procedure has done a rollback inside it. This test shows that in trunk, after checkin
602991 for DERBY-1585, a procedure does not return a resultset if there was a rollbck
inside the procedure with resultset creation before rollback. This behavior is different
than what happens in 10.2 codeline. In 10.2, a procedure will return a *closed* resultset
if there was a rollback inside the procedure. But a procedure should not return closed
result sets, so it appears that trunk is behaving correctly and 10.2's behavior was
incorrect.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@628130 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/JDBC.java",
"hunks": [
{
"added": [
" * Assert that the statement has no more results(getMoreResults) and it ",
" * indeed does not return any resultsets(by checking getResultSet). ",
" * Also, ensu... |
derby-DERBY-3304-27711132 | DERBY-3304
Some code cleanup in GenericLanguageConnectionContext.endTransactionActivationHandling so the code is more readable.
No functionality change, just consolidated various if statements and used some local variables to replace repeated
method calls like a.getResultSet() and a.getResultSet().returnsRows()
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@619772 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/conn/GenericLanguageConnectionContext.java",
"hunks": [
{
"added": [
"\t\t\tif (forRollback) { ",
"\t\t\t\t// Only invalidate statements if we performed DDL.",
"\t\t\t\tif (dataDictionaryInWriteMode()) {",
... |
derby-DERBY-3304-782354ac | DERBY-3304
The main purpose of this patch is to fix the rollback handling for resultsets that do not
return rows. An example case for this is a java procedure which has a Connection.rollback
inside it. When the user calls the java procedure, and Connection.rollback is made inside
of it, Derby should not be closing the resultset assoicated with the java procedure call
(that resultset is a CallStatementResultSet). In other words, a user initiated rollback
through JDBC Connection object should leave the resultsets that do not return rows open. In
order to implement this, I had to make changes to ignore resultsets that do not return rows
in
GenericLanguageConnectionContext.endTransactionActivationHandling. As a result of this
change, for the eg case given above, the activation assoicated with the java procedure
will not be reset (which also means that, CallStatementResultSet.close will not be called)
inside GenericLanguageConnectionContext.endTransactionActivationHandling.
But the code inside CallStatementResultset.close() took care of the closed dynamic resultset
and it took out the closed dynamic resultset from the list of resultsets that would be
available to user through the Statement.getResultSet api. With my changes through this
patch, we are going to skip the CallStatementResultset.close during
GenericLanguageConnectionContext.endTransactionActivationHandling which means that we have
to deal with those closed dynamic resultsets on our own. I did that part of logic
changes in EmbedStatement.processDynamicResults
EmbedStatement.processDynamicResults used to check if the JDBC Resultset is closed by
directly checking the field isClosed in the EmbedResultSet. But it is not sufficient to
check only JDBC Resultset. We need to check the underlying language Resultset too to
determine if the dynamic resultset is closed. There is no direct api on EmbedResultset
which will return a boolean after checking the JDBC Resultset and language Resulset. Instead,
there is a method called EmbedResultSet.checkIfClosed. This method will throw an exception
if it finds the JDBC ResultSet or language ResultSet closed. So, my changes in
EmbedStatement.processDynamicResults make a call to EmbedResultSet.checkIfClosed and if
there is an exception thrown, then we know that the resultset is closed and hence we should
move to the next resultset.
In addition to these code changes, I have added a new test to LangProcedureTest. The new
java procedure is defined to return 2 dynamic resultsets. One of these resultsets is
created before Connection.rollback inside the java procedure. The other dynamic resultset
is created after Connection.rollback. As as result of Connection.rollback, the first
dynamic resultset will be closed but the second one will remain open. The test makes sure
that only one dynamic resultset is returned by the java procedure.
Also, made one minor change in LangProcedureTest for an existing test. The test at line 804
was getting a resultset from the Statement object without asserting that there are no more
resultsets. The resultset object would have been null anyways in this test because there
are no open resulsets from the Java procedure. Because of this, I took out the redundant
code of getting null resultset object from Statement using getResultset,
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@629926 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/conn/GenericLanguageConnectionContext.java",
"hunks": [
{
"added": [
"\t\tthe activations that have resultset returning rows associated with ",
"\t\tthem. DERBY-3304 Resultsets that do not return rows should be left ",
... |
derby-DERBY-3304-9f9a13ab | DERBY-3304
When a SQL exception is thrown, make sure that rollback caused by it closes all the resultsets
irrespective of whether they return rows or not. This cleanup was not happening for
CallableStatementResultSet. To fix this, in CallableStatementResultSet class, I have changed
the no-op cleanup() method to call close(). Without this, the locks held by the resultsets
created inside the Java procedure method were not getting released.
I have added a test case to make sure that this code change is tested. I have created a
Java procedure which creates a dynamic resultset, a local resultset and then does an
insert which will cause duplicate key exception. As part of rollback for exception, Derby
closes the dynamic resultset and local resultset along with the CallableStatementResultset.
And the test case is able to drop the tables which were used by the dynamic and local
resultset without running into locking issues.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@631108 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3304-a68377ce | Checking in code cleanup for DERBY-3304. This code cleanup is based on Knut's review of my
earlier commit 629926. No functionality has changed, but code will be now much easier to
read.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@631481 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/conn/GenericLanguageConnectionContext.java",
"hunks": [
{
"added": [
"\t\t\t//Determine if the activation has a resultset and if that resultset",
"\t\t\t//returns rows. For such an activation, we need to take special",
... |
derby-DERBY-3304-ac5abd96 | DERBY-6038: Intermittent failure in LangProcedureTest: cannot drop table because of open ResultSet
Explicitly close the non-dynamic result set in the regression test case
for DERBY-3304. Also update the comments to reflect that DERBY-3304 only
affected the internal CallStatementResultSet and its dynamic result sets.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1431945 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3304-cbc650d0 | DERBY-3304
This commit addresses two issues.
First of all, it cleanups up reset method in BaseActivation which was doing more than just bringing the Activation back
to pre-execution state. The method had to make itself aware of holdability and what
kind of resultset it was dealing with
before closing or clearing the row of the resultset. The reason for this behavior
is commit code path was relying on
Activation.reset to do more than just bringing the activation to pre-execution state.
I fixed this by moving this code
from BaseActivation.reset to GenericLanguageConnectionContext.resetActivations.
Additionally, in the new code in GenericLanguageConnectionContext.resetActivations, I added the code to not close the
language result sets associated with activations that do not return rows even if activation may have holdability set to
false. This will ensure that a commit inside a java procedure will not inadvertantly close the resultset associated with
the java procedure call.
Additionally, I copied some of the cleanup work(as shown below) from BaseActivation.reset into
new code in GenericLanguageConnectionContext.resetActivations
a.clearHeapConglomerateController();
if (!a.isSingleExecution())
a.clearWarnings();
This code above was always getting executed at the time of commit before my commit and because of that, I decided to copy
it in GenericLanguageConnectionContext.resetActivations. If anyone has any comments on this, please let me know.
(Andrew trying to change commit message for Mamta)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@618788 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/BaseActivation.java",
"hunks": [
{
"added": [
"\t\tif (resultSet != null) ",
"\t\t\tresultSet.close();",
"\t\t"
],
"header": "@@ -332,16 +332,9 @@ public abstract class BaseActivation impleme... |
derby-DERBY-3304-ff175071 | DERBY-3304
This is a followup commit for DERBY-3304 based on various comments. It does following
1)The existing method resetActivations in GenericLanguageConnectionContext has been renamed to better reflect it's
functionality. It will be now called endTransactionActivationHandling since it gets called for commit/rollback.
2)The javadoc comments for resetActivations(now called endTransactionActivationHandling) were not valid. Fixed that in
this commit.
3)Took out the redundant code about setting the holdability to false if we were in rollback. It was needed earlier
because the method that took care of activations at rollback time needed to check the holdability. That method
(BaseActivation.reset) does not check holdability anymore and hence we do not need to set the activations to false
holdability when we are dealing with rollback.
4)Lastly, JDBC api for Connection.commit does not ask for clearing of warnings and hence we should not have code to
clear the warnings at the time of commit. I removed the warning clearing code from resetActivations(now called
endTransactionActivationHandling) in GenericLanguageConnectionContext.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@619279 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/conn/GenericLanguageConnectionContext.java",
"hunks": [
{
"added": [
"\t\tendTransactionActivationHandling(false);"
],
"header": "@@ -1122,7 +1122,7 @@ public class GenericLanguageConnectionContext",
"removed": ... |
derby-DERBY-3305-f62cb688 | DERBY-3305 Ensure that a processing a ResultSet into a dynamic result marks the application statment result set as the correct one, based upon the statement the result set is transferred to. Add asserts to jdbcapi.ProcedureTest to check that ResultSet.getStatement returns the correct Statement object.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@610238 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3306-181c56ab | DERBY-3325: Add 'maxStatements' property to ClientConnectionPoolDataSource.
Enabled the test jdbcapi.ClientConnectionPoolDataSourceTest, removed two unused imports from _Suite and removed the workaround for DERBY-3306.
Patch file: derby-3325-2a-enable_test_and_remove_workaround.diff
(I added one missing space character to the diff)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@628102 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3306-7fe51c32 | DERBY-3306 (+DERBY-3412): jdbc4.StatementEventsTest cannot be run individually in a clean environment.
This commit backs out the previous patch committed for this issue (revision 620480). Manual work was required because J2EEDataSourceTest has been split off DataSourceTest in the mean time.
This patch also fixes StatementEventsTest by setting the createDatabase to create.
Patch file: derby-3306-2a-backout_and_alternative_fix.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@629894 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/JDBCDataSource.java",
"hunks": [
{
"added": [
" * configuration. The getConnection() method will return",
" * a connection identical to TestConfiguration.openDefaultConnection()."
],
"header": "@@... |
derby-DERBY-3306-9cf3fb5e | DERBY-3306: jdbc4.StatementEventsTest cannot be run individually in a clean environment. This is in fact a more general fix for tests using a DataSource obtained through the JUnit framework utility classes to create connections. The connections will now default to create the database if it does not exists. The accompanying test changes were required to get a clean suites.All run, and falls into three categories; test doesn't want to create db, asserting on zero warnings or uses connection attributes that conflict with db creation.
Patch file: derby-3306-1c-create_db_by_default_and_test_fixes.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@620480 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/JDBCDataSource.java",
"hunks": [
{
"added": [
" * configuration.",
" * <p>The getConnection() method will return a connection identical to",
" * {@link TestConfiguration#openDefaultConnection}."
... |
derby-DERBY-3307-2e2d2ee2 | DERBY-3307: NPE in PooledConnction event notification handling if a null listener is added
- Added null check in ClientPooledConnection.addConnectionEventListener().
- Added regression test in J2EEDataSourceTest
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@666040 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3308-e5b0435f | DERBY-3308: Broken synchronization for event handling in ClientPooledConnection40.
Patch file: derby-3308-1b-eventlisteners_synchronization.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@614536 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/ClientPooledConnection40.java",
"hunks": [
{
"added": [
"import java.util.ArrayList;"
],
"header": "@@ -23,7 +23,7 @@ package org.apache.derby.client;",
"removed": [
"import java.util.Vector;"
]
... |
derby-DERBY-3310-0dfa31cd | Cleanup related to DERBY-3310. Simplify ResultSetNode.genNormalizeResultSetNode to always work on itself by producing a NormalizeResultSetNode that wraps it. That is how the function worked and was imlemented.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@630643 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ResultSetNode.java",
"hunks": [
{
"added": [
" ResultColumnList prRCList = resultColumns;"
],
"header": "@@ -821,12 +821,10 @@ public abstract class ResultSetNode extends QueryTreeNode",
"removed"... |
derby-DERBY-3310-2e105f0d | Add some comments to ResultColumn related to investigations for DERBY-3310 explaining some more about how the column can have a different type to the expression it refers to.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@630645 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ResultColumn.java",
"hunks": [
{
"added": [
" * <P>",
" * its underlying column is not. In an INSERT or UPDATE the ResultColumn",
" * will represent the type of the column in the table, the type of",
... |
derby-DERBY-3310-c6564415 | DERBY-3597 Incorporate DERBY-3310 and DERBY-3494 write-ups into NormalizeResultSetNode code comments.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@645638 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/NormalizeResultSetNode.java",
"hunks": [
{
"added": [
" *",
" * child result set that needs one. See non-javadoc comments for ",
" * a walk-through of a couple sample code paths.",
" */",
... |
derby-DERBY-3311-d6209a80 | DERBY-3311: Client ResultSet.getHoldabilty will return incorrect value when the ResultSet is obtained from a procedure call
Patch contributed by Daniel John Debrunner
Patch file: derby_3311_diff.txt
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@613169 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.jdbc.EngineResultSet;"
],
"header": "@@ -61,6 +61,7 @@ import org.apache.derby.iapi.services.sanity.SanityManager;",
"removed": []
... |
derby-DERBY-3316-3abb5722 | DERBY-3316 Leak in client if ResultSet not closed
The leak was in SectionManager.positionedUpdateCursorNameToResultSet_ which kept a reference to the ResultSet so it wouldn't get garbage collected. The solution was to use a WeakReference to the ResultSets in positionedUpdateCursorNameToResultSet_ so that they can be garbage collected.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@612262 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/SectionManager.java",
"hunks": [
{
"added": [
"import java.lang.ref.WeakReference;",
""
],
"header": "@@ -21,6 +21,8 @@",
"removed": []
}
]
}
] |
derby-DERBY-3319-60d10e68 | DERBY-1191 (partial) Some SQLExceptions, for example those generated from BrokeredStatements, do not print to derby.log even when derby.stream.error.logSeverityLevel=0
Here is a patch that takes the approach of adding a public static void logAndThrowSQLException(SQLException se) method and then calling that instead of just throwing the exception.
The initial patch only uses the method for EmbedConnection.checkForTransactionInProgress() which is the most important exception to log after the fix for DERBY-3319.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@803948 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/Util.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.error.ErrorStringBuilder;",
"import org.apache.derby.iapi.services.property.PropertyUtil;",
"import org.apache.derby.iapi.services.stream.HeaderPrin... |
derby-DERBY-3319-902041a6 | DERBY-3319: Logical connections do not check if a transaction is active on close
Make sure that connections created by the different kinds of data
sources throw an exception on close if they are active. This is done
to get the same behaviour as with connections returned by
DriverManager.
Don't throw exception for connections with auto-commit on (since
they'll auto-commit the transaction as part of the close, and
therefore won't leave uncommitted operations around) or connections
that are part of an XA transaction (since those transactions can still
be committed/aborted via the associated XAResource after the closing
of the connection).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@675870 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/jdbc/EmbedPooledConnection.java",
"hunks": [
{
"added": [],
"header": "@@ -153,11 +153,6 @@ class EmbedPooledConnection implements javax.sql.PooledConnection, BrokeredConne",
"removed": [
"\t\t// need to do this in case the conn... |
derby-DERBY-3320-6b95f615 | DERBY-3320 This commit will ensure that if the Collator support does not exist during
a territory based database creation, then we will throw an exception saying Collator
support does not exist. In case of subsequent boot of a successfully created territory
based database, we will check for the Collator support from JVM at the time first collation
related operation is run on the database. This can happen if the database recovery needs
to be done at the boot time or it can happen after the database has booted and user has
issued a SQL which requires Collator support.
The details of the changes that went into different classes are as follows.
DataDictionaryImpl
With this patch, the collation attribute on JDBC url now gets verified in DVF.boot method
and hence we do not need to verify the value again in DataDictionaryImpl.boot. We can assume
that if the user has provided the collation attribute, then it will be set to UCS_BASIC or
TERRITORY_BASED. If user did not supply this attribute, then we will use the default
territory of UCS_BASIC
BasicDatabase
The boot method here would call DVF.setLocale in order to set the correct locale and
Collator object on DVF. With this patch, DVF.boot method does the setting of locale
and Collator object and hence BasicDatabase.boot does not need to make a special call
on DVF.setLocale. I have removed setLocale method from DVF because there are no other
callers of the setLocale method.
DVF and DVFImpl
The boot method here has been modified so that it will set the locale on itself rather than
rely on BasicDatabase.boot to do it. In addition, it will it will check if the user has
supplied collation attribute on JDBC url at database create time. If none specified, we will
user the default of UCS_BASIC. If user has provided a value for collation attribute, then
this method will verify that it is set to UCS_BASIC or TERRITORY_BASED. If not, it will
throw an exception. During database create time, boot method will make sure that the
Collator support is available for the requested locale for TERRITORY_BASED database. If not,
it will throw an exception. In case of subsequent database boot, the verification for the
Collator support will be done the first time a collation operation is executed on the DB.
This can happen at database recovery time if the database has to be recovered or it can
happen later when user issues a SQL which required a collation operation. This collation
support check is done in the new method called verifyCollatorSupport().
In addition to changes in the boot method, I had to change the signature of existing apis
like getNullChar, getNullVarchar etc to throw StandardException. These methods can throw
an exception if they are the first ones to require collation support and during the
collation support check, we can throw exception if the Collator support from JVM is not
found.
messages.xml and SQLState.java
Added a new SQL State XBM04 for the case when the requested locale for territory based
database does not have Collator support from the jvm.
CollationTest
Added a test case which tries to use a non-existent locale to create a territory based
database. The creation fails as expected and we throw exception that the Collator support
does not exist for the requested locale.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@643292 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/DataValueFactory.java",
"hunks": [
{
"added": [],
"header": "@@ -31,8 +31,6 @@ import java.sql.Timestamp;",
"removed": [
"import java.util.Locale;",
""
]
},
{
"added": [
... |
derby-DERBY-3320-ececdabc | Fix for the test that was added for DERBY-3320. The test was using DriverManager.getConnection
but DriverManager is not available in JSR 169 environment. This caused the test to fail
when run in JSR 169 environment. I have fixed the test to use testUtil.getConnection
which is smart enough to use DriverManager or DataSource depending on what VM the test
is getting run in.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@645665 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3321-16164d57 | DERBY-3321: NullPointerException for 'NOT EXISTS' with nested subquery
Checks fromList for a FromSubquery using a CollectNodesVistior.
The value of bindTargetListOnly is based on the contents of the visitor.
Patch contributed by Thomas Nielsen
Patch file: d3321.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@634316 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3327-99d7d8b3 | DERBY-3327 SQL roles: Implement authorization stack
Patch DERBY-3327-3 which implements the authorization stack for SQL roles.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@614071 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/conn/LanguageConnectionContext.java",
"hunks": [
{
"added": [],
"header": "@@ -423,22 +423,6 @@ public interface LanguageConnectionContext extends Context {",
"removed": [
"\t/**",
"\t *\tGet the current role ... |
derby-DERBY-3327-f04dc447 | DERBY-3327 SQL roles: Implement authorization stack
Some javadoc bugs fixed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@615109 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/Activation.java",
"hunks": [
{
"added": [
"\t * @param role The name of the current role"
],
"header": "@@ -591,7 +591,7 @@ public interface Activation",
"removed": [
"\t * @arg role The name of the cu... |
derby-DERBY-3330-0efe521c | DERBY-3330
submitted by Anurag Shekhar
This commit is of the derby-3330_followup_1_modified.diff.
CreateIndexConstantAction.java
I have changed the name of the variable and added comment to explain what its meant for.
I got confused while commenting last time. This property is required if
TransactionCoordinator has to select the non default Sorter.
BTreeController.java
I haven't optimized it yet. But instead of returning error code setting the ret value so the latch
is cleared before return.
IndexDescriptorImpl.java
Updated both the place (using new name in toString () and using the new attribute in equals methods).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@634540 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/types/IndexDescriptorImpl.java",
"hunks": [
{
"added": [
"\t\t\tsb.append (\"UNIQUE WITH DUPLICATE NULLS\");"
],
"header": "@@ -216,7 +216,7 @@ public class IndexDescriptorImpl implements IndexDescriptor, Formatable",
... |
derby-DERBY-3330-2f994958 | DERBY-3330
Adding an additional upgrade test case to verify that behavior of unique
constraint on non-null column is consistent in all cases.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@634849 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3330-435735bf | DERBY-3330
javadoc fixes, mostly related to DERBY-3330.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@636114 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/CreateIndexConstantAction.java",
"hunks": [
{
"added": [
" * @param uniqueWithDuplicateNulls True means index check and disallow"
],
"header": "@@ -115,7 +115,7 @@ class CreateIndexConstantAction extend... |
derby-DERBY-3330-62af56f3 | DERBY-3330
committing on behalf of Anurag Shekhar.
Adding upgrade tests that both confirm existing behavior of indexes and
new behavior of constraints on nullable columns.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@634383 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3330-d07f526b | DERBY-3330
contributed by Anurag Shekhar
committing a modified version of sortercomments.diff patch. This change just
updates the comments associated with the class and routine in this file - no
code changes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@634436 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/access/sort/UniqueWithDuplicateNullsMergeSort.java",
"hunks": [
{
"added": [
" * This class extends and customizes MergeSort to support unique indexes with",
" * duplicate nulls.",
" * Compares two keys. ",
... |
derby-DERBY-3333-9c3b91c3 | DERBY-3333 User name corresponding to authentication identifier PUBLIC must be rejected
Patch DERBY-3333-roles.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@655948 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/GrantRoleConstantAction.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.conn.Authorizer;"
],
"header": "@@ -28,6 +28,7 @@ import java.util.List;",
"removed": []
}
]
},
{
... |
derby-DERBY-3341-f432362d | DERBY-3341: For Table Functions, coerce data values coming out of Java ResultSets into the SQL data values declared in the signature of the Table Function.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@636004 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/execute/ResultSetFactory.java",
"hunks": [
{
"added": [
"import org.apache.derby.catalog.TypeDescriptor;",
""
],
"header": "@@ -21,6 +21,8 @@",
"removed": []
},
{
"added": [
... |
derby-DERBY-3342-7a361f26 | DERBY-2775 Remove last use of DataTypeDescriptor.setNullability() to make DTD's use immutable wrt nullability. Fixes DERBY-3346 and DERBY-3342 which were cases when a query was getting the incorrect nullability for some columns due to the mutability of DTD when shared across nodes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@616853 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3343-28ce2663 | DERBY-3343: Subsequent calls to PreparedStatement cause SQLIntegrityConstraintViolationException on column that is "Generated always"
Patch file: d3343.v3.diff
Modifies the logic in ResultColumn.getOrderableVariantType() so that it behaves
correctly even when a default column is explicitly mentioned in an insert statement.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@615203 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3346-7a361f26 | DERBY-2775 Remove last use of DataTypeDescriptor.setNullability() to make DTD's use immutable wrt nullability. Fixes DERBY-3346 and DERBY-3342 which were cases when a query was getting the incorrect nullability for some columns due to the mutability of DTD when shared across nodes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@616853 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3347-a7de0811 | DERBY-3347: ERROR XSDB3: Container information cannot change once written
On JVMs that support the NIO API, multiple threads may perform I/O
operations concurrently on the same data file. As long as these
operations go through the page cache, only a single thread performs
I/O on a single page at any given time. The data files can also be
accessed by the container cache, which accesses space that it borrows
on the first page in the file. Since these accesses don't go through
the page cache, a mechanism is needed to prevent concurrent access
that page.
This patch makes reading and writing of the first page in a file
synchronize on the container object. Since access to the borrowed
space on the first page also is synchronized on the container,
concurrent I/O on the first page is prevented. (On JVMs that don't
support the NIO API, all page accesses synchronize on the container.)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@647091 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/data/RAFContainer4.java",
"hunks": [
{
"added": [
" {",
" // If this is the first alloc page, there may be another thread",
" // accessing the container information in the borrowed space on th... |
derby-DERBY-3347-b44572f2 | DERBY-3347: ERROR XSDB3: Container information cannot change once written
On JVMs that support the NIO API, use NIO consistently when accessing
the data files. Mixing old style I/O and NIO has caused problems on
some platforms since thread-safety is only guaranteed if all access
happens through the FileChannel interface.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@647139 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/data/FileContainer.java",
"hunks": [
{
"added": [],
"header": "@@ -26,19 +26,11 @@ import org.apache.derby.iapi.reference.Property;",
"removed": [
"import org.apache.derby.impl.store.raw.data.BaseContainer;",
... |
derby-DERBY-3349-cd8df940 | DERBY-3349: Nested WHERE EXISTS queries need improved testing
Patch contributed by Thomas Nielsen
Patch file: d3349-3.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@628686 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3350-50a8c626 | DERBY-3350 Ensure that CAST inherits the nullability of its value expression since a cast of a non-null value is always not null. Changes the nullability of a number of JDBC DatabaseMetaData columns since many are derived from CAST expression in the SQL query that forms the result set.
Updated canons where the nullability changed, since if the column display size was less than four but nullable, ij would increase the display size to four to allow for NULL. Once such columns become not nullable their display size drops to less than four.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@616473 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3354-74bac8e0 | DERBY-3354: Select from large lob table with embedded gives OutOfMemoryError
Contributed by Anurag.
This patch introduces a new WeakHashMap in EmbedConnection. EmbedBlob and EmbedClob objects references are stored in this
map (objects as key and null as value). Adding entry to locater map is
differed till the first call of getLocater.
This ensures that there is entry of LOB objects in locater map if they are invoked in embedded mode.
As the keys of WeakHashMap doesn't prevents the objects from being
garbage collected, once the lob objects are unreferenced lob objects will
be garbage collected releasing the memory.
During commit/rollback or Connection.close, free is invoked on all the lob
objects from WeakHashMap and the map is cleared.
Modified files
java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java
Added a new attribute lobRefrences of type WeakHashMap.
Added a new method addLOBReference to make an entry in new
hash map.
Modified clearLOBMapping to use lobRefrences to fetch and invoke free on lob objects instead of lobHashMap.
java/engine/org/apache/derby/impl/jdbc/EmbedBlob.java
java/engine/org/apache/derby/impl/jdbc/EmbedClob.java
Modified constructs to call connection.lobRefrences instead of conn.addLOBMapping.
Modified getLocater method to check if the locater value is non zero
before returning and if its zero calling conn.addLOBMapping to make
entry of lob objects and getting locater value.
Calling removeLOBMapping in free method.
Cleanup of temporary file is already being taken care by the finalizer of
LOBStreamControl so I haven't added any new cleanup code for
finalizer.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@644755 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedBlob.java",
"hunks": [
{
"added": [
" private int locator;"
],
"header": "@@ -75,7 +75,7 @@ final class EmbedBlob extends ConnectionChild implements Blob, EngineLOB",
"removed": [
... |
derby-DERBY-3354-d96e3980 | DERBY-3354: Select from large lob table with embedded gives OutOfMemoryError
Contributed by Anurag.
This patch introduces a new WeakHashMap in EmbedConnection. EmbedBlob and EmbedClob objects references are stored in this
map (objects as key and null as value). Adding entry to locater map is
differed till the first call of getLocater.
This ensures that there is entry of LOB objects in locater map if they are invoked in embedded mode.
As the keys of WeakHashMap doesn't prevents the objects from being
garbage collected, once the lob objects are unreferenced lob objects will
be garbage collected releasing the memory.
During commit/rollback or Connection.close, free is invoked on all the lob
objects from WeakHashMap and the map is cleared.
Modified files
java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java
Added a new attribute lobRefrences of type WeakHashMap.
Added a new method addLOBReference to make an entry in new
hash map.
Modified clearLOBMapping to use lobRefrences to fetch and invoke free on lob objects instead of lobHashMap.
java/engine/org/apache/derby/impl/jdbc/EmbedBlob.java
java/engine/org/apache/derby/impl/jdbc/EmbedClob.java
Modified constructs to call connection.lobRefrences instead of conn.addLOBMapping.
Modified getLocater method to check if the locater value is non zero
before returning and if its zero calling conn.addLOBMapping to make
entry of lob objects and getting locater value.
Calling removeLOBMapping in free method.
Cleanup of temporary file is already being taken care by the finalizer of
LOBStreamControl so I haven't added any new cleanup code for
finalizer.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@644764 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedBlob.java",
"hunks": [
{
"added": [
" private int locator;"
],
"header": "@@ -75,7 +75,7 @@ final class EmbedBlob extends ConnectionChild implements Blob, EngineLOB",
"removed": [
... |
derby-DERBY-3356-334e9a30 | DERBY-3361: Make the startSlave connection wait until slave replication mode is confirmed started or until an error occurs.
In addition, this patch adds host and port information to a derby.log message and a few exceptions for easier debugging. DERBY-3356 is also fixed by this patch.
Contributed by Jorgen Loland
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@618944 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/db/SlaveDatabase.java",
"hunks": [
{
"added": [],
"header": "@@ -31,7 +31,6 @@ import org.apache.derby.iapi.services.context.ContextService;",
"removed": [
"import org.apache.derby.impl.services.monitor.UpdateServicePropert... |
derby-DERBY-3357-0c7de0fe | DERBY-3357 ; improving run time of test DataSourceTest by only creating
database objects once and by deciding in suite methods whether to run with
network server and/or client, rather than within the fixtures.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@619667 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3357-5b20343a | DERBY-3357: Reduce runtime of jdbcapi.DataSourceTest. Reduced lock timeouts.
Patch file: derby-3357-1a-lower_lock_timeout.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@617486 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3357-decb600e | DERBY-3357; fixing up a few minor mistakes in DataSourceTest - forgot to change
comments referring to renamed (to baseSuite) method getRunTwiceSuite, failed
to add testXAHoldability, and I had tested testAutoCommitOnXAResourceStart
against both client and server but forgot to remove it from the client suite.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@619722 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3358-46ed45c9 | DERBY-3358: Do not cache Throwable in printStackAndStopMaster
Contributed by V Narayanan.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@634694 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/replication/master/MasterController.java",
"hunks": [
{
"added": [
" * @param e the exception that needs to be handled.",
" private void printStackAndStopMaster(Exception e) {",
" repLogger.logErr... |
derby-DERBY-3358-fc4e76b6 | DERBY-3358: After an incorrect(unsuccesfull) startMaster comand, further correct startMaster attempts also fail.
Contributed by V Narayanan.
M java/engine/org/apache/derby/impl/services/replication/master/MasterController.java
* Added a variable boolean that indicates whether the master controller is currently running or has
been stopped. I thought I could manage with the earlier boolean variable stopMasterController but
decided against it because it seemed more tied with the stopMaster operation.
* moved start up parameter initialization from boot to startMaster method.
* changed the startMaster, stopMaster and the startFailover methods to take into account the boolean
active.
* replaced the earlier uses of stopMasterController with active.
M java/engine/org/apache/derby/impl/store/raw/RawStore.java
* The replication properties that are part of the bootServiceModule call no longer contain the
startup parameters. These have instead been moved to the startMaster method.
* The replicationProps are empty and not null because a null passed to a bootServiceModule call
results in a NullPointerException.
M java/engine/org/apache/derby/iapi/services/replication/master/MasterFactory.java
* Changed the startMaster declaration to now accept the startup parameters as the method arguments.
M java/engine/org/apache/derby/loc/messages.xml
M java/shared/org/apache/derby/shared/common/reference/SQLState.java
* Added a new messages for the case when the master has already been booted.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@634218 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/replication/master/MasterFactory.java",
"hunks": [
{
"added": [],
"header": "@@ -73,19 +73,7 @@ public interface MasterFactory {",
"removed": [
"",
" /** Property key used to specify which slave host t... |
derby-DERBY-336-75fb1cf8 | Submitting Dyre Tjeldvoll's patch for DERBY-336
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@230900 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/error/StandardException.java",
"hunks": [
{
"added": [
" SanityManager.ASSERT(messageID != null,",
" \"StandardException with no messageID\");"
],
"header... |
derby-DERBY-3360-0a6ce0bc | DERBY-3360 Invalid method java.lang.Integer >> void <init>(short) because java.lang.NoSuchMethodException: java.lang.Integer.<init>(short)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@679815 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3361-334e9a30 | DERBY-3361: Make the startSlave connection wait until slave replication mode is confirmed started or until an error occurs.
In addition, this patch adds host and port information to a derby.log message and a few exceptions for easier debugging. DERBY-3356 is also fixed by this patch.
Contributed by Jorgen Loland
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@618944 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/db/SlaveDatabase.java",
"hunks": [
{
"added": [],
"header": "@@ -31,7 +31,6 @@ import org.apache.derby.iapi.services.context.ContextService;",
"removed": [
"import org.apache.derby.impl.services.monitor.UpdateServicePropert... |
derby-DERBY-3362-dd2ce24a | DERBY-3362
Changed code to use right interface to get the control row and return null
if either page does not exist or if the background thread would have had to
wait for the page. In either case post commit just skips processing.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@634101 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/access/btree/BTreePostCommit.java",
"hunks": [
{
"added": [
" LeafControlRow leaf = null;",
" // The following can fail, returning null, either if it can't get",
" // the latch or some... |
derby-DERBY-3364-5d5aab5f | DERBY-3364: Replication failover implementation must be modified to fail at the master after slave has been stopped
Contributed by V Narayanan
Changes:
M java/engine/org/apache/derby/impl/services/replication/net/ReplicationMessageTransmit.java
* Set a timeout on the socket that is translated as a timeout on the
reads on the I/P streams
M java/engine/org/apache/derby/impl/services/replication/master/MasterController.java
* Stop log shipment and tear down network both with successful and
non-successful failover.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@631534 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/replication/master/MasterController.java",
"hunks": [
{
"added": [
" //The socket connection that is obtained needs to be torn down.",
" teardownNetwork();"
],
"header": "@@ -274,9 +... |
derby-DERBY-3365-456b8a1c | DERBY-3365 Network Server stores a duplicate entry in the lob hash map for every lob
Change network server to use existing lob hash map entry instead of creating a second entry.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@617186 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.jdbc.EngineBlob;",
"import org.apache.derby.iapi.jdbc.EngineClob;"
],
"header": "@@ -62,6 +62,8 @@ import org.apache.derby.iapi.servic... |
derby-DERBY-337-1fa1fd04 | DERBY-337: Enhance dblook to support SQL functions.
1 - Renames "impl/tools/dblook/DB_StoredProcedure.java" to "impl/tools/dblook/DB_Alias.java" because that file now handles stored procedures AND functions AND synonyms, all of which are based on the SYSALIASES system catalog.
2 - Adds logic to new DB_Alias.java file to generate DDL for functions.
3 - Modifies the "toString()" method of the catalog/types/RoutineAliasInfo file to generate a string that is SYNTACTICALLY VALID based on whether an instance of that class is for a PROCEDURE or for a FUNCTION. The reason this change is required is because the "ALIASINFO" column that is returned as part of the SYS.SYSALIASES result set is an instance of RoutineAliasInfo, and thus a call to ResultSet.getString() on the ALIASINFO column ultimately makes a call to RoutineAliasInfo.toString(). That said, the dblook utility makes a "getString()" call on the ALIASINFO column and uses the result to generate the corresponding DDL. Before this patch, the result of the toString() method always corresponded to the PROCEDURE syntax; but now, since dblook is generating DDL for FUNCTIONs, the RoutineAliasInfo.toString() method must recognize if an instance is a PROCEDURE or FUNCTION and return the appropriate syntax.
4 - Adds test cases for FUNCTIONS to the dblook tests and updates the master files accordingly.
Submitted by Army Brown (qozinx@sbcglobal.net)
git-svn-id: https://svn.apache.org/repos/asf/incubator/derby/code/trunk@189650 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/types/RoutineAliasInfo.java",
"hunks": [
{
"added": [
"\t// What type of alias is this: PROCEDURE or FUNCTION?",
"\tprivate char aliasType;",
""
],
"header": "@@ -88,6 +88,9 @@ public class RoutineAli... |
derby-DERBY-3371-3e92fd96 | DERBY-3371 (partial) Made T_AccessFactory.alterTable() run with both
temporary and non-temporary conglomerates to get better test coverage
in RAMTransaction
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@618299 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/unitTests/store/T_AccessFactory.java",
"hunks": [
{
"added": [
" && alterTable(tc, false)",
" && alterTable(tc, true)"
],
"header": "@@ -144,7 +144,8 @@ public class T_AccessFactor... |
derby-DERBY-3376-52a0f73d | DERBY-3376: Test case in GrantRevokeDDLTest commented out
This change adds some additional tests to GrantRevokeDDLTest.
The test cases were originally contributed by Yip Ng (yipng168 at gmail dot com)
The tests were originally written during buddy testing of Derby 10.2, and
were committed as part of DERBY-1736, but were commented out at the
time due to DERBY-1589. The test cases now pass, and so this change
enables the tests as part of GrantRevokeDDLTest.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@831762 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3379-5d59e9db | DERBY-3379: "No Current connection" on PooledConnection.getConnection() if pooled connection is reused during connectionClosed processing.
Patch file: derby-3379-3a-minimal_fix_and_test_enabling.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@642942 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/ClientPooledConnection.java",
"hunks": [
{
"added": [
" // Null out the reference to the logical connection that is currently",
" // being closed.",
" this.logicalConnection_ = null;",
"... |
derby-DERBY-3379-f1567ead | DERBY-3379 (partial): Updated some comments in buildDss, and converted comments for method finalizeDssLength into JavaDoc.
Patch file: derby-3379-2a-comment_and_JavaDoc.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@637805 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/net/Request.java",
"hunks": [
{
"added": [
" // RQSDSS header is 6 bytes long: (ll)(Cf)(rc)",
" // Save the position of the length bytes, so they can be updated with a",
" // different value at a ... |
derby-DERBY-3382-29fd25c8 | DERBY-3382: Slave must inform master if DBs are out of sync.
Adds a check of the log files to the replication initialization so that replication does not start if the log files are out of synch. The master will be notified whether or not the log files are synched.
Tidies up if starting of replication fails.
Contributed by Jorgen Loland
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@630207 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/replication/master/AsynchronousLogShipper.java",
"hunks": [
{
"added": [
" /** The highest log instant in failedChunk */",
" private long failedChunkHighestInstant = -1;",
" /** The highest log instan... |
derby-DERBY-3382-9e93a53d | DERBY-3382: Adds regression test for out of sync checking between master and slave.
Contributed by Jorgen Loland
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@641221 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3383-dd55fd82 | DERBY-3383: Replication: Make sure stopSlave does not boot the database if not already booted.
Contributed by Jorgen Loland
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@620444 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java",
"hunks": [
{
"added": [
" // DERBY-3383: stopSlave must be performed before",
" // bootDatabase so that we don't accidentally boot the db",
" // if stopSlave ... |
derby-DERBY-3388-1d0892eb | DERBY-3388: Improve message handling for replication messages to derby.log
Add timestamp to replication messages written to derby.log and
introduce the following configurable properties:
* derby.replication.verbose -> true/false - replication messages are
written to log
* derby.replication.logBufferSize -> the size of the replication log
buffers
* derby.replication.minLogShippingInterval -> the shortest interval
between two consecutive log shipments
* derby.replication.maxLogShippingInterval -> the longest interval
between two consecutive log shipments (a "soft" guarantee that the
slave will not deviate more than this amount of millis from the
master)
Contributed by Jørgen Løland <Jorgen.Loland@Sun.COM>.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@634586 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/replication/ReplicationLogger.java",
"hunks": [
{
"added": [
"import java.util.Date;",
"import org.apache.derby.iapi.reference.Property;",
"import org.apache.derby.iapi.services.property.PropertyUtil;",
... |
derby-DERBY-339-88c25bba | DERBY-339 Network client XA should only keep XA state for transaction branch association
Network client XA should only keep XA state for transaction branch association, to track whether to send commit in autocommit mode. All other state and state related decisions should be defered to the server.
The client tries to track XA state to make decisions based on current XA state. Most of this state handling was removed with DERBY246, but it still was not being handled properly. This is evidenced by multiple failures in xaSimplePostive that now that it gets past DERBY-246.
This fix will have the client track only branch association as outlined in the XA+ specification. Table 6-2, State Table for Transaction Branch Association. The client will track only
XA_TO_NOT_ASSOCIATED
XA_T1_ASSOCIATED
Association Suspended (T2) will map to XA_TO_NOT_ASSOCIATED for the client's pupurposes.
The client commit in autocommit mode only for
XA_TO_NOT_ASSOCIATED.
git-svn-id: https://svn.apache.org/repos/asf/incubator/derby/code/trunk@189710 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Connection.java",
"hunks": [
{
"added": [
" // The client needs to keep track of the connection's transaction branch association",
" // per table 2.6 in the XA+ specification in order to determine if commits should flo... |
derby-DERBY-3390-b75cf01c | DERBY-3390; preventing ClassCastException and disconnect on SQLException thrown from a user function
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@700948 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java",
"hunks": [
{
"added": [
"\t\t\tsqlerrmc = buildTokenizedSqlerrmc(se);"
],
"header": "@@ -6005,7 +6005,7 @@ class DRDAConnThread extends Thread {",
"removed": [
"\t\t\tsqlerrmc = bu... |
derby-DERBY-3391-58f22ba5 | DERBY-3391 Remove dead code that restored isolation level during a compile, since isolation cannot be changed by a compile
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@619981 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CompilerContextImpl.java",
"hunks": [
{
"added": [],
"header": "@@ -617,22 +617,6 @@ public class CompilerContextImpl extends ContextImpl",
"removed": [
"\t/**",
"\t * @see CompilerContext#setEntryIsol... |
derby-DERBY-3397-683c673d | DERBY-3397: Derby 10.3.1.4 and 10.3.2.1 break scrollable result sets? Hibernate Query.setFirstResult and/or setMaxResults.
Added two simple regression tests.
Patch file: derby-3397-2a-junit_reg_test.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@650786 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3398-841c8990 | DERBY-5546 ResultSet#updateBigDecimal on a REAL column does not do underflow checking
Patch derby-5546-2. For both Real and Double, check for underflow. For
Double underflow is currently detected but only because we didn't fix
DERBY-3398 yet, so we introduce the same check now as for Real. Once
DERBY-3398 it will no longer be redundant. The tests are still guarded
by a check for embedded until DERBY-5534 is fixed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1447996 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/SQLDouble.java",
"hunks": [
{
"added": [
"import java.math.BigDecimal;"
],
"header": "@@ -36,6 +36,7 @@ import java.io.ObjectOutput;",
"removed": []
}
]
},
{
"file": "java/engine/org/apache/d... |
derby-DERBY-3400-8935ca15 | DERBY-3400 testgetTypeInfo Fails with ibm16 while running the UpgradeTests
Workaround for IBM JVM issue. Make new arrays for ODBC nullability instead of doing arrayCopy.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@628151 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3401-2f817f3f | Add commented out code that exposes the bug described by DERBY-3401. Removing a listener from a pooled connection during logical connection close processing causes other listeners to be ignored.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@619991 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3401-431eec83 | DERBY-3401 (partial) Fixed ConcurrentModificationException if a
statement event listener adds or removes a listener on the same pooled
connection.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@660959 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/ClientPooledConnection40.java",
"hunks": [
{
"added": [
"import java.util.concurrent.CopyOnWriteArrayList;"
],
"header": "@@ -23,7 +23,7 @@ package org.apache.derby.client;",
"removed": [
"import java.ut... |
derby-DERBY-3401-af3cf0c5 | DERBY-3401: Removing a ConnectionEventListener from a PooledConnection during its connectionClosed() callback causes other ConnectionEventListener callbacks to be missed
Clone the list of listeners if it is modified while the listeners are executing.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@663641 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/ClientPooledConnection.java",
"hunks": [
{
"added": [
" /** List of {@code ConnectionEventListener}s. Never {@code null}. */",
" private ArrayList listeners_ = new ArrayList();",
"",
" /**",
... |
derby-DERBY-3404-5a17d020 | DERBY-3404: EmbedResultSet.getString() returns wrong value after auto-commit with CLOSE_CURSORS_AT_COMMIT
Made EmbedResultSet.checkIfClose() detect that the language ResultSet
had been closed because of the auto-commit, and throw an SQLException.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@629712 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java",
"hunks": [
{
"added": [],
"header": "@@ -2240,7 +2240,6 @@ public abstract class EmbedResultSet extends ConnectionChild",
"removed": [
"\t//4)Make sure underneath language resultset is not closed"... |
derby-DERBY-3406-d588984f | DERBY-3406: Fix unsynchronized calls to notify
Contributed by V Narayanan
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@628078 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/replication/master/AsynchronousLogShipper.java",
"hunks": [
{
"added": [
" if (fi >= FI_HIGH || ",
" (System.currentTimeMillis() - lastShippingTime) > MIN) {",
" synchronized (t... |
derby-DERBY-3412-7fe51c32 | DERBY-3306 (+DERBY-3412): jdbc4.StatementEventsTest cannot be run individually in a clean environment.
This commit backs out the previous patch committed for this issue (revision 620480). Manual work was required because J2EEDataSourceTest has been split off DataSourceTest in the mean time.
This patch also fixes StatementEventsTest by setting the createDatabase to create.
Patch file: derby-3306-2a-backout_and_alternative_fix.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@629894 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/JDBCDataSource.java",
"hunks": [
{
"added": [
" * configuration. The getConnection() method will return",
" * a connection identical to TestConfiguration.openDefaultConnection()."
],
"header": "@@... |
derby-DERBY-3414-002bf942 | DERBY-3304 and DERBY-3414
This serves as a test case for both the jira entries above.
Number of code changes for transaction ending time went in as part of DERBY-3304 and this
new test will check those code changes for specific case of rollback inside a java procedure
call.
The test case is currently disabled for network server because the rollback inside the
procedure is not closing all the resultsets and DERBY-3414 is to track this behavior of
network server. Once DERBY-3414 is fixed, we should enable the test for network server.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@627673 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3415-8f89c096 | DERBY-3415: 'DataSourceSerializationTestjunit.framework.AssertionFailedError' on Windows.
Added closing of the FileInputStream to the test. Without it, the test failed on Windows platforms during tear down, and it is of course good practice to always clean up :)
Patch file: derby-3415-1a.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@627734 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3417-84fa650c | DERBY-4175 Instability in some replication tests under load, since tests don't wait long enough for final state or anticipate intermediate states
Patch derby-4175-3 (+ resolved some conflicts arising from commit of DERBY-3417).
It makes three replication tests less sensitive to load by making
them accept intermediate states without failing or wait for longer
before giving up on seeing the final end state of a replication state
change.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@769602 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3417-8c9d41ec | DERBY-3417 slave side stop in a client server mode results in SQLState printed without proper error message
Patch derby-3417-2.
A set of replication errors have been made session level (they are),
also having the effect of preformatting the error message strings on
the server, solving this issue. Also removed usage of
org.apache.derby.shared.common.reference.SQLState's strings in the
replication tests to make them self contained.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@769596 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3420-1b0debd1 | DERBY-3420: Remove obsolete -ca option from ij.
The -ca command-line-option for the ij command is obsolete and no longer
needed, since the ij connection URL can now accept all the necessary
connection attribute information.
This change removes the implementation of the -ca option from the ij code,
and removes the option from the ij "usage" message, and from the test output.
There is a release note attached to DERBY-3420, noting that the option
has been removed, and that users of this option (hopefully there are none)
should instead pass connection attributes in the URL.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@737948 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/impl/tools/ij/Main.java",
"hunks": [
{
"added": [],
"header": "@@ -82,7 +82,6 @@ public class Main {",
"removed": [
"\t\tProperties connAttributeDefaults = null;"
]
},
{
"added": [],
"header": ... |
derby-DERBY-3421-7ad8ff6b | DERBY-3421: Remove unused code for caching of connect bytes.
Patch file: derby-3421-1b-removal.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@628679 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/net/NetConnection.java",
"hunks": [
{
"added": [],
"header": "@@ -57,10 +57,6 @@ public class NetConnection extends org.apache.derby.client.am.Connection {",
"removed": [
"",
" // byte[] to save the connect f... |
derby-DERBY-3422-cd903151 | DERBY-3422: Embedded returns wrong value for DatabaseMetaData.autoCommitFailureClosesAllResultSets()
Return the correct value (true) and update the test so that it is able
to detect differences between returned value and actual behaviour.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@629395 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3423-7e4dcd98 | DERBY-3423: Minor cleanup in DatabaseMetaData implementation classes
- removed providesQueryObjectGenerator()
- removed unused variables and imports
- fixed signatures for getSchemas(String,String) and
getClientInfoProperties() to match the signatures in the interface
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@629785 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/DatabaseMetaData.java",
"hunks": [
{
"added": [],
"header": "@@ -23,7 +23,6 @@ package org.apache.derby.client.am;",
"removed": [
"import org.apache.derby.jdbc.ClientDataSource;"
]
},
{
"add... |
derby-DERBY-3424-57655605 | DERBY-3424 (partial) Improve JMXManagementService to spearate registering of mbeans with Derby's management service from registering with the JMX service. This allows the ManagementMBEan to correctly implement the stop and start management service to unregister (from the platform mbean server) Derby's MBean when the stopManagement() is called and then re-register them when startManagement() is called.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@628585 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/jmx/JMXManagementService.java",
"hunks": [
{
"added": [
"import java.util.HashMap;",
"import java.util.Map;"
],
"header": "@@ -22,12 +22,11 @@ import java.security.AccessController;",
"removed": [... |
derby-DERBY-3424-b69d62b9 | DERBY-3424 Change getSystemModule() to return null if the monitor is not booted, rather than a NullPointerException
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@632398 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/monitor/Monitor.java",
"hunks": [
{
"added": [
" /**",
" * Return a system module. If it cannot be found or the monitor is",
" * not running then null is returned.",
" */",
" ... |
derby-DERBY-3424-e6a963f7 | DERBY-3424 DERBY-3385 Add test for the ManagementMBean when Derby is not running.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@633643 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/jmx/JMXManagementService.java",
"hunks": [
{
"added": [
" systemIdentifier = null;"
],
"header": "@@ -150,6 +150,7 @@ public final class JMXManagementService implements ManagementService, ModuleCont",
... |
derby-DERBY-3424-f8bc0199 | DERBY-3424 (partial) Add initial apis and bean implementations for a management
mbean to control Derby's JMX behaviour. Start and stop the management are
present as operations but currently do nothing. Also fix a bug in DERBY-1387
where shutting down Derby would fail with jmx when multiple mbeans were registered.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@628142 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/jmx/ManagementService.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.reference.Module;",
"import org.apache.derby.mbeans.ManagementMBean;"
],
"header": "@@ -18,6 +18,8 @@",
"removed"... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.