id stringlengths 22 25 | commit_message stringlengths 137 6.96k | diffs listlengths 0 63 |
|---|---|---|
derby-DERBY-3151-04353ef8 | DERBY-3151: Reduce dependency on NetworkServerControl in TestConfiguration.
Added a NetworkServerControl wrapper using reflection to use the class and invoke its methods.
The purpose of the change is to be able to run JUnit tests without having derbynet.jar (and derbyrun.jar) on the classpath.
Patch file: derby-3151-4b-wrapper_with_reflection.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@669808 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java",
"hunks": [
{
"added": [],
"header": "@@ -31,8 +31,6 @@ import java.util.Properties;",
"removed": [
"import org.apache.derby.drda.NetworkServerControl;",
""
]
},
... |
derby-DERBY-3155-03170a55 | DERBY-3155: Add a test for MERGE statements which sometimes put nulls into generated columns and sometimes don't; commit derby-3155-41-aa-nullGeneratedColumns.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1576710 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-0ae3b6de | DERBY-3155: Simplify processing of then rows for the DELETE actions of MERGE statements; commit derby-3155-50-aa-revampDeleteThenRows.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1579937 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/MatchingClauseNode.java",
"hunks": [
{
"added": [],
"header": "@@ -87,7 +87,6 @@ public class MatchingClauseNode extends QueryTreeNode",
"removed": [
" private int[] _deleteColumnOff... |
derby-DERBY-3155-1484b835 | DERBY-3155: Forbid subqueries in the WHEN [ NOT ] MATCHED clauses of MERGE statements; commit derby-3155-19-aa-forbidSubqueriesInMatchedClauses.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1561671 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/MatchingClauseNode.java",
"hunks": [
{
"added": [
" //",
" // Although the SQL Standard allows subqueries in the WHEN [ NOT ] MATCHED clauses,",
" // we don't support them yet. That is b... |
derby-DERBY-3155-1705596a | DERBY-3155: Propagate RowLocations out of index probes as necessary for the driving left join of a MERGE statement; commits derby-3155-26-aa-copyRowLocationForIndexScans.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1569396 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/execute/ResultSetFactory.java",
"hunks": [
{
"added": [
"\t\t@param baseColumnCount\t\tNumber of columns in the base table"
],
"header": "@@ -1086,6 +1086,7 @@ public interface ResultSetFactory {",
"removed": []... |
derby-DERBY-3155-18792e22 | DERBY-3155: Add privilege checks for the INSERT actions of MERGE statements; tests passed cleanly on derby-3155-33-ab-insertPrivs.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1574131 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/MatchingClauseNode.java",
"hunks": [
{
"added": [
"",
" bindExpressions( selectList, fullFromList );"
],
"header": "@@ -809,7 +809,8 @@ public class MatchingClauseNode extends QueryTreeNode",
... |
derby-DERBY-3155-1a3e2c0c | DERBY-3155: Run all MERGE tests with and without collations; commit derby-3155-47-aa-collations.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1579040 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-1a5b33ed | DERBY-3155: Add support for ? parameters to MERGE statements; commit derby-3155-24-aa-supportParameters.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1566673 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-1cd5dd1c | DERBY-3155: Improve support for correlation names for the source tables of MERGE statements; tests passed cleanly for me on derby-3155-10-aa-correlationNames.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1548298 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/MatchingClauseNode.java",
"hunks": [
{
"added": [
" FromList fromList = fullFromList;",
"",
" //",
" // For an INSERT action, the WHEN NOT MATCHED refinement can... |
derby-DERBY-3155-273d23fd | DERBY-3155: Add tests for largish lobs in MERGE statements; commit derby-3155-40-aa-bigLobs.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1576383 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-2945dbb8 | DERBY-3155: Allow system and temp tables in MERGE statements; commit derby-3155-13-aa-allowSystemAndTempTables.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1558912 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/MergeNode.java",
"hunks": [
{
"added": [
" switch( desc.getTableType() )",
" {",
" case TableDescriptor.BASE_TABLE_TYPE:",
" case TableDescriptor.GLOBAL_TEMPORARY_TABLE_... |
derby-DERBY-3155-2d835fe5 | DERBY-3155: Add test for MERGE statement which fires triggers involving generated columns; commit derby-3155-42-aa-triggersAndGeneratedColumns.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1576893 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-2f8e6fbd | DERBY-3155: Revamp how columns referenced by WHEN [ NOT ] MATCHED clauses are linked to the columns coming back from the driving left join of a MERGE statement; commit derby-3155-20-aa-reworkColumnMatching.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1564874 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ColumnReference.java",
"hunks": [
{
"added": [
" // For associating columns with the SOURCE and TARGET tables of MERGE statements.",
" public static final int MERGE_UNKNOWN = 0;",
" public stat... |
derby-DERBY-3155-30e18dba | DERBY-3155: Remove some obsolete code which was causing a cross-schema MERGE statement to raise a missing schema error: commit derby-3155-29-aa-missingSchema.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1570352 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-3511a12d | DERBY-3155: Improve handling of correlation names for the target tables in MERGE statements; commit derby-3155-09-aa-correlationNames.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1547585 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/MergeNode.java",
"hunks": [
{
"added": [
" // source table must be a vti or base table",
" if (",
" !(_sourceTable instanceof FromVTI) &&",
" !(_sourceTable inst... |
derby-DERBY-3155-3cc631bb | DERBY-3155: Forbid derived column lists in MERGE statements; commit derby-3155-23-aa-forbidDerivedColumnLists.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1566649 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/MergeNode.java",
"hunks": [
{
"added": [
" // don't allow derived column lists right now",
" forbidDerivedColumnLists();",
" "
],
"header": "@@ -214,6 +214,9 @@ public fi... |
derby-DERBY-3155-3e77b5ad | DERBY-3155: More improvements to column resolution in MERGE statements; tests passed cleanly for me on derby-3155-30-ab-moreCorrelationNames.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1571808 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ColumnReference.java",
"hunks": [
{
"added": [
" /**"
],
"header": "@@ -113,7 +113,7 @@ public class ColumnReference extends ValueNode",
"removed": [
"\t/**"
]
},
{
... |
derby-DERBY-3155-480456f6 | DERBY-3155: Allow for row location columns in the result column list of base tables; tests passed cleanly for me on derby-3155-16-aa-treatCurrentRowLocationNodeLikeBaseColumnNode.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1560134 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-4cf6633b | DERBY-3155: Improve comments for compilation of MERGE statements; commit derby-3155-51-aa-cleanup2.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1579950 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/MatchingClauseNode.java",
"hunks": [
{
"added": [
" //",
" // Filled in by the constructor.",
" //",
" // Filled in at bind() time.",
" // the INSERT/UPDATE/DELETE statemen... |
derby-DERBY-3155-5d1ab631 | DERBY-3155: Add support for ? parameters as INSERT values in MERGE statements; commit derby-3155-25-aa-parametersAsInsertValues.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1567368 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/MatchingClauseNode.java",
"hunks": [
{
"added": [
" ResultColumnList selectList = new ResultColumnList( getContextManager() );",
" for ( int i = 0; i < _insertValues.size(); i++ )",
" ... |
derby-DERBY-3155-661c2e6c | DERBY-3155: Add grammar and bind logic for MERGE statement; commit derby-3155-01-ac-grammar.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1516157 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/InsertNode.java",
"hunks": [
{
"added": [
" //",
" // For the MERGE statement, DEFAULT expressions in the SELECT node",
" // may have been replaced with generated expressions already.",
... |
derby-DERBY-3155-69ab4bd8 | DERBY-3155: Make the INSERT column list optional in the WHEN NOT MATCHED clause of a MERGE statement provided that the number of values in the VALUES subclause equals the number of columns in the target table; commit derby-3155-12-aa-canOmitInsertColumnList.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1558871 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/MatchingClauseNode.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.dictionary.ColumnDescriptorList;"
],
"header": "@@ -41,6 +41,7 @@ import org.apache.derby.iapi.sql.ResultDescription;",
... |
derby-DERBY-3155-6b8d71bb | DERBY-3155: Fix bug in MERGE statement fired by a trigger; commit derby-3155-53-aa-transitionSimpleColumn.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1587317 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-6ffb1125 | DERBY-3155: Add a test case for privilege checking on a MERGE statement with all 3 kinds of actions; commit derby-3155-35-aa-allPrivsTest.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1574956 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-77b6e859 | DERBY-3155: Eliminate redundant copies of columns in the select list of the driving left join for MERGE statements; commit derby-3155-43-aa-eliminateDuplicateColumnRefs.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1577566 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/MergeNode.java",
"hunks": [
{
"added": [
"import java.util.HashSet;"
],
"header": "@@ -24,6 +24,7 @@ package\torg.apache.derby.impl.sql.compile;",
"removed": []
},
{
"added": [
... |
derby-DERBY-3155-7f8154de | DERBY-3155: Make MERGE statement serialize SQLRefs rather than HeapRowLocations; commit derby-3155-17-aa-serializingRowLocations.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1560452 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/MergeResultSet.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.types.SQLRef;"
],
"header": "@@ -33,6 +33,7 @@ import org.apache.derby.iapi.sql.execute.ExecRow;",
"removed": []
}
]
... |
derby-DERBY-3155-856f8920 | DERBY-3155: Replace correlation names on the left side of the SET clauses in MERGE statements: commit derby-3155-14-aa-replaceCorrelationNamesOnLeftSideOfSETclauses.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1559183 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-898f3f5a | DERBY-3155: Make cleanup logic in MergeResultSet more closely resemble the cleanup logic in InsertResultSet; commit derby-3155-15-aa-replumbMergeResultSetCleanup.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1559218 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/MergeResultSet.java",
"hunks": [
{
"added": [
"\tprivate int\t\t\t\t\t\tnumOpens;",
" "
],
"header": "@@ -60,6 +60,8 @@ class MergeResultSet extends NoRowsResultSetImpl",
"removed": []
... |
derby-DERBY-3155-89f969c4 | DERBY-3155: Verify that columns needed for triggers are buffered up by MERGE statements, even when the MERGE statements do not mention those columns; commit derby-3155-46-aa-deferredDeletes.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1578945 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-8a90f7cd | DERBY-3155: Add tests for the (de)serialization of MERGE statements; commit derby-3155-45-aa-serialization.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1578920 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-9cfeeb1e | DERBY-3155: Forbid MERGE statements in soft-upgraded databases; commit derby-3155-52-aa-upgrade.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1580889 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-9d3ad325 | DERBY-3155: Add test for MERGE statement which reads the target table via an index; commit derby-3155-48-aa-indexScan.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1579685 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-a19ac61c | DERBY-3155: Add lock mode comment to master MERGE node; commit derby-3155-36-aa-lockModeComment.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1575026 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/MergeNode.java",
"hunks": [
{
"added": [
" //",
" // No need to set lockMode in the master MergeNode. The individual",
" // actions and the driving left-join will set their own lock mode... |
derby-DERBY-3155-a2b37c2a | DERBY-3155: Materialize LOBs before buffering them up for processing by WHEN [ NOT ] MATCHED clauses; commit derby-3155-44-aa-lobsInTriggers.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1578535 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/MergeResultSet.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.services.io.StreamStorable;"
],
"header": "@@ -24,6 +24,7 @@ package org.apache.derby.impl.sql.execute;",
"removed": []
}... |
derby-DERBY-3155-a4a5f1ac | DERBY-3155: Fix build problem introduced by derby-3155-38-aa-datatypes.diff; commit derby-3155-39-aa-fixBuild.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1576062 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-a7d99c10 | DERBY-3155: Add tests to verify that BEFORE triggers can't fire MERGE statements, just as they can't fire INSERT/UPDATE/DELETE statements; commit derby-3155-11-ab-beforeTriggersCantFireMerge.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1549948 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-b3f38f87 | DERBY-3155: Forbid synonyms in MERGE statement; tests passed cleanly for me on derby-3155-21-ac-cleanupAndForbidSynonyms.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1565830 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ColumnReference.java",
"hunks": [
{
"added": [
" if ( (_mergeTableID != MERGE_UNKNOWN) && (_mergeTableID != mergeTableID) )",
" \"MERGE statement can't re-associate column \" + getSQLColumn... |
derby-DERBY-3155-bba59bbb | DERBY-3155: Uncomment a test verifying that trigger transition tables cannot be used as the target tables of MERGE statements: derby-3155-05-aa-triggerTransitionTableAsTarget.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1535397 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-bbd6aff4 | DERBY-3155: Point matching refinement clauses into the row returned by the driving left join of the MERGE statement; commit derby-3155-27-aa-adjustMatchingRefinements.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1569521 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/MatchingClauseNode.java",
"hunks": [
{
"added": [],
"header": "@@ -234,12 +234,6 @@ public class MatchingClauseNode extends QueryTreeNode",
"removed": [
" /** Re-bind various clauses and lists once we have Re... |
derby-DERBY-3155-bff25717 | DERBY-3155: Fix some serialization bugs in the MERGE ConstantActions and add test cases for using trigger transition tables as the source tables of MERGE statements; check in derby-3155-06-aa-triggerTransitionTableAsSource.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1535447 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/MatchingClauseConstantAction.java",
"hunks": [
{
"added": [
" /** 0-arg constructor needed by Formatable machinery */",
" public MatchingClauseConstantAction() {}",
""
],
"header": "@@... |
derby-DERBY-3155-c2a0bdd9 | DERBY-3155: Basic support for views as the source tables of MERGE statements; commit derby-3155-18-aa-basicView.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1560507 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-daffaee4 | DERBY-3155: Enforce correct privileges for DELETE actions of MERGE statements; tests passed cleanly on derby-3155-31-aa-deletePrivs.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1572665 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/DeleteNode.java",
"hunks": [
{
"added": [
" getCompilerContext().removePrivilegeFilter( scopeFilter );"
],
"header": "@@ -297,11 +297,7 @@ class DeleteNode extends DMLModStatementNode",
"remov... |
derby-DERBY-3155-ddfefebc | DERBY-3155: Implement printSubNodes() for MergeNode and MatchingClauseNode; commit derby-3155-37-aa-printSubNodes.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1575032 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/MergeNode.java",
"hunks": [
{
"added": [
"\t/**",
"\t * Prints the sub-nodes of this object. See QueryTreeNode.java for",
"\t * how tree printing is supposed to work.",
"\t *",
"\t * @pa... |
derby-DERBY-3155-efa1efa9 | DERBY-3155: Prevent a MERGE statement from altering the same target row twice; commit derby-3155-28-aa-cardinalityViolations.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1570230 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/MergeResultSet.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.store.access.BackingStoreHashtable;",
"import org.apache.derby.shared.common.sanity.SanityManager;"
],
"header": "@@ -25,15 +... |
derby-DERBY-3155-f2cad07d | DERBY-3155: Add test to verify use of identifiers on the left side of SET clauses in MERGE statements; commit derby-3155-22-ad-testIdentifiersOnLeftSideOfSetClauses.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1566625 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3155-ffbe8135 | DERBY-3155: Add privilege checks for the UPDATE actions of MERGE statements; commit derby-3155-34-ab-updatePrivs.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1574566 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/MatchingClauseNode.java",
"hunks": [
{
"added": [
" //",
" // Don't add USAGE privilege on user-defined types.",
" //",
" boolean wasSkippingTypePrivileges = getCompiler... |
derby-DERBY-3158-ce018f39 | DERBY-3158 DERBY-3159 Ensure that SYSCS_SET_USER_ACCESS: 1) always sets the user name in the lists in its delimited form. 2) Allows repeated calls to set the permission for the same user by always clearing both lists of that user name before adding. 3) Allows user names with characters that require quoting in SQL by not validating the name as a SQL identifier since the passed in user name is a normalized user name.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@589894 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/util/IdUtil.java",
"hunks": [
{
"added": [
" * Produce a delimited form of a normal value.",
"\tpublic static String normalToDelimited(String id)",
" ",
"\t\tfor (int ix = 0; ix < id.length(); ix++)... |
derby-DERBY-3159-ce018f39 | DERBY-3158 DERBY-3159 Ensure that SYSCS_SET_USER_ACCESS: 1) always sets the user name in the lists in its delimited form. 2) Allows repeated calls to set the permission for the same user by always clearing both lists of that user name before adding. 3) Allows user names with characters that require quoting in SQL by not validating the name as a SQL identifier since the passed in user name is a normalized user name.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@589894 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/util/IdUtil.java",
"hunks": [
{
"added": [
" * Produce a delimited form of a normal value.",
"\tpublic static String normalToDelimited(String id)",
" ",
"\t\tfor (int ix = 0; ix < id.length(); ix++)... |
derby-DERBY-3160-bbba1c74 | DERBY-3160 Make SYSCS_GET_USER_ACCESS treat the passed in user name in its normal form, as for example would be passed by using the expression CURRENT_USER
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@590720 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3172-836fc7bd | This is a followup checkin to checkin(595047) was committed for DERBY-3172. The DataSourceTest had started failing
under JDK1.6 after 595047. The particular test case that was failing was for Connection.getTypeMap The reason for
failure was that this method was overridden in a subclass which kicks in only when JDBC4.0 is available. The
overriden method was not sending the correct connection error event as expected by the test and hence the failure.
While fixing this, I realized that there are several new JDBC4.0 apis that need to send the correct events to
ConnectionEventListeners. This checkin takes care of those apis. More info on what was changed in this commit is
as follows.
New JDBC4.0 api, setClientInfo, wraps SQLException inside SQLClientInfoException but we were not copying the
error code of SQLException into SQLClientInfoException. Without the correct error code, we would not send
connection error event because the severity has to be fatal for us to send connection error event. Because of this,
I had to change several places where SQLException is wrapped inside SQLClientInfoException to pass SQLException's
error code to SQLClientInfoException. The classes changed because of this are EmbedConnection40,
BrokeredConnection40, NetConnection40.
For methods that throw SQLClientInfoException, we were not notifying the connection error events. I made changes to
fix this.
Several of new JDBC4 apis on connection object were not sending error events so I changed those methods in
BrokeredConnection40 and LogicalConnection40.
BrokeredConnection40 implements new JDBC4 methods on Connection object but these new methods did not follow the
same logic as the other existing pre-JDBC4 methods to check for connection close and that caused the events to
be not sent correctly. The problematic apis were createBlob, createClob, isWrapperFor, unwrap and I fixed those.
Not all the new JDBC4 apis have been implemented (they throw not implemented exception) so the tests written for
those apis just catch the unimplemented exception. These methods include createArrayOf, createNClob, createSQLXML,
createStruct.
In JDBC4, Connection object has two methods isWrapperFor and unwrap which do not go to the server when Derby is
being accessed in client server mode and because of this, we never detect that the server is down and hence no
connection error event is thrown in client server mode for these 2 apis. But when the same apis are called in
embedded Derby after the engine is shutdown, we get connection error event. I have added the test for these 2 apis
to count for the different in behavior but I am not sure if this is the expected behavior difference between the
2 configurations of Derby. I will enter a Jira entry for this.
And lastly, the new JDBC4 api isValid on Connection object has different behavior in client server mode and
embedded mode. They both throw exception that the connection is down but the connection close and error events
are not dealt the same way in the 2 configurations. In embedded mode, after the engine is shutdown, an isValid
call on Connection object raises a connection closed event and no connection error event. In client server mode,
after the Network Server is shutdown, an isValid call on Connection object does not raise any event. In both the
configurations, we do get a SQLException stating that connection is down. Again, I am not sure if this is expected
bahavior difference between the 2 configurations of Derby. I will enter a Jira entry for this too. In addition, as
per Connection.isValid api Java specification, a SQLException is thrown under following condition which is not
being followed in embedded and client-server mode
Throws:
SQLException - if the value supplied for timeout is less then 0
Based on this, I am not sure if our behavior is correct to throw an SQLException if the server/engine is down. I
will include this information in the Jira entry that I will make.
The tests for all these new JDBC4 apis are in jdbc4/DataSourceTest.
I moved the AssertEventCatcher class implementation from jdbcapi/DataSourceTest into a class of it's own. This way,
it can be shared by jdbcapi/DataSourceTest and jdbc4/DataSourceTest.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@595803 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/LogicalConnection40.java",
"hunks": [
{
"added": [
" try",
" {",
" \t\tcheckForNullPhysicalConnection();",
" return physicalConnection_.createArrayOf( typeName, elements );",
... |
derby-DERBY-3172-cb47a36e | DERBY-3172
Change the Network Server code so that when the Network Server is shutdown, any api on Connection object will
raise a Connection error event (similar to what is done in embedded mode). This also required me changing the
disconnectError from -4999 to 40000(to match embedded). This change was made client.am.SqlCode. I have added tests
for all the apis on Connection object in DataSourceTest. Had to change couple tests which were testing for
-4999. Now they look for 40000. I will merge this change into 10.3 and run tests there before committing the changes
in 10.3 codeline.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@595047 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/ClientPooledConnection.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.error.ExceptionSeverity;"
],
"header": "@@ -23,8 +23,8 @@ package org.apache.derby.client;",
"removed": [
"import org.a... |
derby-DERBY-3173-320f6afa | DERBY-3173: Removed cached String objects from SQLTime and SQLTimestamp
Patch contributed by Eranda Sooriyabandara <070468D at gmail dot com>.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@989918 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/DateTimeParser.java",
"hunks": [
{
"added": [],
"header": "@@ -31,7 +31,6 @@ class DateTimeParser",
"removed": [
" private String trimmedString;"
]
}
]
},
{
"file": "java/engine/org/apache... |
derby-DERBY-3173-eac24d28 | DERBY-3173: Removed cached String objects from SQLDate
Patch contributed by Eranda Sooriyabandara <070468D@gmail.com>.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@988107 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/SQLDate.java",
"hunks": [
{
"added": [
" return BASE_MEMORY_USAGE;"
],
"header": "@@ -86,14 +86,11 @@ public final class SQLDate extends DataType",
"removed": [
"\t// The cached value.toString... |
derby-DERBY-3175-45c3f035 | DERBY-3175: NullPointerException on INSERT after ALTER TABLE DROP COLUMN
The implementation of ALTER TABLE DROP COLUMN needs to adjust the
SYSCOLUMNS information for some of the columns in the table. Specifically,
columns with a higher column position than the dropped column need to
have their column position adjusted (decremented by 1).
The algorithm which did this column position adjustment was flawed,
because it was losing the auto-increment information for generated columns.
The code adjusts the column position by:
- reading the old column information into a ColumnDescriptor
- deleting the old column information from SYSCOLUMNS
- modifying the ColumnDescriptor to set the new column position
- adding the new column information to SYSCOLUMNS
But the generated column information in the ColumnDescriptor was not being
preserved properly in this process.
The fix involved ensuring that the ColumnDescriptor information was
accurate for generated columns, and ensuring that SYSCOLUMNSRowFactory.makeRow
was correctly loading the generated column information into the new row.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@594727 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/ColumnDescriptor.java",
"hunks": [
{
"added": [
"\tprivate long\t\t\t\tautoincValue;"
],
"header": "@@ -69,6 +69,7 @@ public final class ColumnDescriptor extends TupleDescriptor",
"removed": []
... |
derby-DERBY-3176-05e9c291 | DERBY-3176: Re-enable support for running Derby on phoneME small device platforms.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@594184 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/info/JVMInfo.java",
"hunks": [
{
"added": [
"\tThis class is used to determine which Java specification Derby will run at.",
" For a useful discussion of how this class is used, please see DERBY-3176."
],
... |
derby-DERBY-3176-8a319fbe | DERBY-3224 - modifications to enable running with phoneME advanced platform;
changes are as follows:
- org/apache/derby/iapi/tools/i18n/LocalizedInput.java -
Performance of ij tests improved by using a BufferedReader on top of the
InputStreamReader when ij read from its scriptfiles.
The reason is the use of some buffers when doing character conversion.
Every time the buffer is full, an exception object would be created, thrown and caught; for instance, during LangScripts test, when ij read 1 char at a time from the InputStream, this would happen 1.5 million times. Using the BufferedReader reduced the number of exceptions to 92, and made the test run a lot faster on this platform.
- GrantRevokeTest - clean up code was added (on phoneME advanced tests run in opposite order. )
- CollationTest.java and CollationTest2.java - Added code to not run the tests for non-english locales if the locales are not supported
- ForBitDataTest.java - clean up code was added
- ScrollCursors1Test.java - clean up code was added
- ForUpdateTest.java - Moved code from a test to general setup as it was needed by more than one test and thus fixtures were not independent of order.
- UpdateCursorTest.java - clean up code was added
- upgradeTests/_Suite.java - added code to prevent upgrade from 10.3.1.4
because 10.3.1.4 doesn't boot on this platform (DERBY-3176).
- BaseJDBCTestCase - added method to compare Time objects
patch contributed by Vermund Ostgaard
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@618507 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/iapi/tools/i18n/LocalizedInput.java",
"hunks": [
{
"added": [
"import java.io.BufferedReader;",
"public class LocalizedInput extends BufferedReader{",
"\t\tsuper(new InputStreamReader(i));",
"\t\tsuper(new InputStre... |
derby-DERBY-3177-57465efa | DERBY-3177: Cleanup suspect coding practices in the types package.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1468143 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/types/DefaultInfoImpl.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.services.io.ArrayUtil;"
],
"header": "@@ -21,6 +21,7 @@",
"removed": []
}
]
},
{
"file": "java/engine/org/apach... |
derby-DERBY-3178-2216a400 | DERBY-3178
This commit modifies DataSourceTest.java to ensure that expected Connection events are fired to the
ConnectionEventListener.
The changes have been implemented by having AssertEventCatcher in DataSourceTest.java keep track of what events
it received. This state is kept in boolean gotConnectionClosed and boolean gotConnectionErrorOccured flags in
AssertEventCatcher. The test then checks the state of AssertEventCatcher after the test has done firing the events
to make sure AssertEventCatcher got the expected events.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@592544 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3181-38e6a8d2 | DERBY-3181: DatabaseMetaData.getBestRowIdentifier behavior with invalid scope
This patch was contributed by Danoja Dias (danojadias at gmail dot com)
The DatabaseMetaData.getBestRowIdentifier method takes a number of arguments,
including "scope", which is supposed to be one of the enumerated values:
bestRowTemporary, bestRowTransaction, and bestRowSession.
If an invalid scope argument was passed to this method, Derby was returning
a hard-coded "empty" row identifier, which was slightly different, in detail,
to the row identifier that is returned for a valid scope argument.
Since JDBC does not require that we return such a row identifier for an
invalid scope argument, it seems cleaner and more useful to throw an
exception with a message indicating that an invalid scope argument was
passed. The caller can then correct their application to make the call with
a valid scope argument, and will then receive a valid row identifier.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1745414 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3182-3d3a8fe7 | DERBY-3182 ; test comments re functioning of nullisok flag (5th parameter to
getBestRowIdentifier) were incorrect. Adjusting test.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@593931 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-319-fd58c3c2 | Derby-194: Modify Derby metadata for datetime values so that the correct "precision" and "scale" for those types will be returned in metadata calls.
Description from Army:
Since the definitions of "precision" and "scale" aren't clearly defined for datetime values in JDBC, I've set them based on the ODBC specification. It was agreed in discussion of this issue (and also of DERBY-319) that the "intent" of JDBC for these values is to mimic ODBC behavior. See the thread here for that discussion:
http://article.gmane.org/gmane.comp.apache.db.derby.devel/2786
http://article.gmane.org/gmane.comp.apache.db.derby.devel/2787
So that said, the attached patch sets precision/scale for datetime values according to the following ODBC pages:
[ Precision ]
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/odbc/htm/odbccolumn_size.asp
Pasted from the above link:
"The column (or parameter) size of numeric data types is defined as the maximum number of digits used by the data type of the column or parameter, or the precision of the data. For character types, this is the length in characters of the data; for binary data types, column size is defined as the length in bytes of the data. For the time, timestamp, and all interval data types, this is the number of characters in the character representation of this data."
[ Scale ]
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/odbc/htm/odbcdecimal_digits.asp
Pasted from the above link:
"The decimal digits of decimal and numeric data types is defined as the maximum number of digits to the right of the decimal point, or the scale of the data. For approximate floating-point number columns or parameters, the scale is undefined because the number of digits to the right of the decimal point is not fixed. For datetime or interval data that contains a seconds component, the decimal digits is defined as the number of digits to the right of the decimal point in the seconds component of the data."
I have run "derbyall" on Windows 2000 with Sun JDK 1.4.2 and have included all required master updates in the patch. The "svn stat" output is attached to this email, along with the patch itself.
Submitted by Army Brown(qozinx@sbcglobal.net)
git-svn-id: https://svn.apache.org/repos/asf/incubator/derby/code/trunk@179839 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/TypeId.java",
"hunks": [
{
"added": [
" // Max width for datetime values is the length of the",
" // string returned from a call to \"toString()\" on the",
" // java.sql.Date, java.sql.Time, a... |
derby-DERBY-3191-aaa14032 | DERBY-3191 SQL roles: add upgrade support
Patch DERBY-3191b; adds hard upgrade code for the new roles system table SYS.SYSROLES,
plus tests for this functionality to the upgrade tests.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@597409 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java",
"hunks": [
{
"added": [
" /**",
" * Similar to additionalDatabaseDecorator except the database will",
" * not be shutdown, only deleted. It is the responsibility of the",
... |
derby-DERBY-3192-585cf5c9 | DERBY-3192: Cache session data in the client driver
Remove special handling of SYNCCTL in sanity-check ASSERT. Since the final
version of the real patch piggy-backs changes caused by SYNCCTL there is no
longer any need to omit the sanity check after SYNCCTL.
Patch file: derby-3192-fup.v1.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@633011 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java",
"hunks": [
{
"added": [
" SanityManager.ASSERT(!pbsd.isModified(),",
" \"Unexpected PBSD modification: \" + pbsd +",
" ... |
derby-DERBY-3192-c6c4d4de | DERBY-3192: Cache session data in the client driver
Piggy-backs the current isolation level and the current schema onto
messages going back to the client. The client caches this information so that
it can be returned to a user (app) without an extra round-trip.
See also http://wiki.apache.org/db-derby/Derby3192Writeup
Patch file: derby-3192-mark2.v8.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@631593 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Connection.java",
"hunks": [
{
"added": [
"import org.apache.derby.shared.common.sanity.SanityManager;"
],
"header": "@@ -27,6 +27,7 @@ import org.apache.derby.shared.common.reference.JDBC30Translation;",
"remo... |
derby-DERBY-3192-d4a1ecd2 | DERBY-3192: followup to disable the test for JSR169 and use more harness helper methods.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@597630 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3195-10acff8d | DERBY-3195; Describe if default security manager & policy is installed or not on each of the mechanisms to start the network server.
updating the javadoc for NetworkServerControl to reflect information about the security manager.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1646373 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/drda/NetworkServerControl.java",
"hunks": [
{
"added": [
" connect to a running Network Server to shutdown, configure or retrieve "
],
"header": "@@ -37,7 +37,7 @@ import org.apache.derby.impl.drda.NetworkServerControlImpl;",
... |
derby-DERBY-3198-29c10e34 | DERBY-3198: Using setQueryTimeout will leak sections
Patch file: derby-3198.v6.diff
Introduce a separate varable to track the Section object used by
writeSetSpecialRegister. The Section is allocated on demand and freed
when the Statement is closed or reset.
Adds a new test case to StatementJDBC30Test to catch future regressions.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@602495 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Statement.java",
"hunks": [
{
"added": [
"import org.apache.derby.shared.common.sanity.SanityManager;"
],
"header": "@@ -24,6 +24,7 @@ import java.sql.SQLException;",
"removed": []
},
{
"add... |
derby-DERBY-3199-86bc9d55 | DERBY-3199: Minor cleanup of DRDAProtocolTest.
Patch file: derby-3199-1a-minor_cleanup.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@594118 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3202-57964be4 | DERBY-3202: 'AccessControlException: access denied
(java.io.FilePermission C:\....\file-2.log read)' in ErrorStreamTest.
Problem was that getCanonicalPath() needed a security permission on
Windows (but not on Solaris/Linux). In addition the Derby engine had
to be shut down before derby.log could be deleted on Windows.
Fix contributed by Vemund Østgaard.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@594894 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3202-cda55ef7 | DERBY-3202:
Workaround for failure in ErrorStreamTest on Windows Vista and Sun JDK 1.4.2.
Contributed by Vemund Østgaard.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@598626 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3208-4a868384 | DERBY-3208: Callers of DaemonService.serviceNow() assume behaviour not
guaranteed by the interface
Expanded the javadoc comment in the interface so that it guarantees
what the callers implicitly assume.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@596262 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/daemon/DaemonService.java",
"hunks": [
{
"added": [
" /**",
" * Service this subscription ASAP. When this method is called, the",
" * subscriber's <code>performWork()</code> method is guaranteed to b... |
derby-DERBY-3213-fb98ba49 | DERBY-3213: SQLChar.trim method is unused and could be removed
Patch contributed by Deepthi Devaki A R
Patch file: DERBY-3213.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@627791 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/StringDataValue.java",
"hunks": [
{
"added": [],
"header": "@@ -109,21 +109,6 @@ public interface StringDataValue extends ConcatableDataValue",
"removed": [
"\t/**",
"\t * The SQL trim(), ltrim() and rtrim()... |
derby-DERBY-3214-87fd7022 | DERBY-3214: Account for loss of precision that can occur when very
large cost estimates are added to, and then subtracted from, relatively
small cumulative estimates during Optimizable "pull" processing.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@603659 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/OptimizerImpl.java",
"hunks": [
{
"added": [
"\t\t\t\t\t** loss of precision--but that should ONLY happen if the",
"\t\t\t\t\t** optimizable we just pulled was at position 0. If we",
"\t\t\t\t\t** have a ne... |
derby-DERBY-3214-c741a20a | DERBY-3214: Follow-up patch to fix a bug in the first commit.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@604513 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/OptimizerImpl.java",
"hunks": [
{
"added": [
"\t\t\t\t\t\t\tnewCost = recoverCostFromProposedJoinOrder(false);"
],
"header": "@@ -875,7 +875,7 @@ public class OptimizerImpl implements Optimizer",
"remove... |
derby-DERBY-3215-90daaabd | DERBY-3215 Potential NullPointerException in CachedPage class
Patch DERBY-3215b; code cleanup follow-up, no semantic change.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@597123 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/data/CachedPage.java",
"hunks": [
{
"added": [],
"header": "@@ -23,22 +23,17 @@ package org.apache.derby.impl.store.raw.data;",
"removed": [
"import org.apache.derby.impl.store.raw.data.BasePage;",
"",
... |
derby-DERBY-3216-63bc195f | DERBY-3216
If btree post commit thread can not get table level lock for row cleanup and
possible tree merging, then instead attempt just row level row purging. Without
this change some stress tests were seeing post commit queue continuous grow
as there was always some thread with a lock on the index, and thus the items
could never get executed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@597865 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/access/btree/BTreePostCommit.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.store.access.RowUtil;",
""
],
"header": "@@ -30,7 +30,9 @@ import org.apache.derby.iapi.store.access.AccessFactory;",... |
derby-DERBY-3219-a840fa50 | DERBY-3219: GROUP BY query fails with ERROR XSDA7
The underlying cause of this problem is that the externalized data format
for a MaxMinAggregator instance includes the max (or min) value that the
aggregator is processing, and this data value happens to be embedded
*inside* of the overall externalized data format. However, the externalized
format for a SQLChar-based data value can use a "stream" format, in which
the explicit length of the value is not encoded, and rather the value is
read until an EOF is received, which means that such a value always has
to be the *last* value in the particular stream, and cannot be embedded
inside of a larger data structure.
In the case in question, the value was a string of length 0, which when
externalized looks like a streamed value, but can be distinguished
because the EOF exception occurs before any data has been read. But when
the value is included inside the larger MaxMinAggregator value, the EOF
exception does *not* occur immediately, but rather after the code in
SQLChar.readExternal has read beyond its own section, and has erroneously
consumed the other values from the MaxMinAggregator's external data.
The solution is to re-order the external format of the MaxMinAggregator,
such that the data value is the last item in the external data, by
calling super.writeExternal and super.readExternal *after* processing
the other MaxMinAggregator data. Since MaxMinAggregator instances are
never stored persistently in permanent data structures, but only in
temporary data structures such as overflow tables and sort buffers, this
should not cause any compatibility problems.
An alternative implementation, which involved changing SQLChar.writeExternal
to use an explicitly-delimited external format for a string of length
zero, rather than the streaming-until-EOF format, was rejected because it
would have increased the on-disk format of such values, and because it
could have caused compatibility problems by changing the on-disk format
of existing values.
The unit test for this bug fix involves the use of some SanityManager code
in the sorter, and hence is only effective when run in a sane debug build.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@661204 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/MaxMinAggregator.java",
"hunks": [
{
"added": [
"\t// Formatable implementations usually invoke the super()",
"\t// version of readExternal or writeExternal first, then",
"\t// do the additional actions here... |
derby-DERBY-3220-925ae992 | DERBY-3220 <transition table or variable list> (ReferencingClause) in CREATE TRIGGER statement not SQL compliant
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@597604 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3221-2a31ed91 | DERBY-3221: "java.sql.SQLException: The conglomerate (-5) requested does not exist." from Derby 10.3.1.4 embedded within Eclipse 3.3 and RAD 7.0
Patch file: derby-3221.v3.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@613116 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/TemporaryRowHolderImpl.java",
"hunks": [
{
"added": [
"\tprivate\tlong\t\t\t\t CID;"
],
"header": "@@ -67,7 +67,7 @@ class TemporaryRowHolderImpl implements TemporaryRowHolder",
"removed": [
... |
derby-DERBY-3222-a30f4ad8 | Merging change(599933) from 10.3 codeline into trunk for DERBY-3222 The commit comment for checkin into 10.3
codeline was as follows
The test will fail depending on the timing. It inserts CURRENT_DATE into a column and then compares that
column with whatever the CURRENT_DATE might be during the run of compare sql. If the insert happened right before
midnight and comparison happens right after midnight, the comparison of the dates will return FALSE. Since the main
purpose of the test is to make sure that Derby derives correct collation type for CURRENT_DATE and
UPPER(CURRENT_DATE), it really does not matter if the 2 current dates actually match or not. Because of this, I
have changed the test to look for <= while doing date comparison rather than =. This should resolve the timing
related fact of the test.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@599973 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3229-4aa78691 | DERBY-3229: Make SysinfoLocaleTest print more information on failure
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@598456 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-323-a4aa5a7e | DERBY-323: Locale problem in test of derby
Description of the patch:
1) Rewrite tools/derbyrunjartest.java to use jvm.getCommandLine() to
get the command line to start the test with.
2) Move the setting of user.language and user.country from RunTest
and NetServer to jvm.getCommandLine(). This way, all of the java
processes that are forked from the test harness or from a test
get the same locale.
3) Add Locale.setDefault(Locale.US) to RunTest.main(). This fixes
the issue with the nist tests.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@424072 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3230-fca5be58 | DERBY-3230 Selecting data from a Table raises Error XN008: Query processing has been terminated due to an error on the server
The solution was to move the retrieval of all of the data associated with the QRYDTA before the ResultSet is marked as closed on the server.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@612849 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/net/NetCursor.java",
"hunks": [
{
"added": [
" // If we don't have at least one byte in the buffer for the DA null indicator,",
" // then we need to send a CNTQRY request to fetch the next block of data.",
... |
derby-DERBY-3231-71b56308 | DERBY-3231: Sorting on COUNT with OR and GROUP BY delivers wrong results.
Patch contributed by: Manish Khettry.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@603954 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3233-59678316 | DERBY-3233 ComparisonFailure in derbyStress
Change test to close connection to ensure all result sets are closed before dropping the table.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@614277 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3238-75d1fb19 | DERBY-3238 minor cleanup in TriggerTest to remove getConnection() calls
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@601118 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3238-9696c22c | DERBY-3238 Add test cases when the lob columns are referenced and referenced multiple times.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@604042 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3238-d2d2e684 | DERBY-3238 When table contains large LOB values (> ~32K) trigger execution fails for that row with ERROR XCL30: An IOException was thrown when reading a 'BLOB'
When a trigger is present, unchanged columns with be part of the UpdateResultSet. These columns are present twice in the result set as a before and after value. There was code to "objectify" the before value but the after value was not getting updated. Changed objectifyStream to make sure after values point to data value and not the stream after objectifyStream occurs.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@601110 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/DMLWriteResultSet.java",
"hunks": [
{
"added": [
"import java.io.InputStream;",
""
],
"header": "@@ -21,6 +21,8 @@",
"removed": []
}
]
}
] |
derby-DERBY-3242-ad72a2b5 | DERBY-3242: ij doesn't understand bracketed comments
Fix contributed by James F. Adams.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@604871 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/impl/tools/ij/StatementFinder.java",
"hunks": [
{
"added": [
" Comments currently recognized include the SQL comment,",
" which begins with \"--\" and ends at the next EOL, and nested",
" bracketed comments."
... |
derby-DERBY-3243-212a1264 | DERBY-3243 (jdbc net client) exception during normal iteration through "ResultSet" of "select * from t"
Allow locators > 32K. Exclude extended length values 0x800x so that lob by value will work with older versions. Exclude negative and 0 locators.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@618431 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java",
"hunks": [
{
"added": [
"\t* Return the current locator value/",
" * 0x800x values are not valid values as they are used to indicate the BLOB ",
" * is being sent by value, so ... |
derby-DERBY-3243-66fe22b0 | DERBY-3243 (jdbc net client) exception during normal iteration through "ResultSet" of "select * from t"
Add test retrieving more than 32K lobs.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@630036 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3244-5faf131d | DERBY-3244
In the case of a wait for a latch while traveling left at leaf level, and
a subsequent wait for either a lock or another latch while looking for row
to lock then one path through the code would get a null pointer. The code
was trying to release a latch that had already been released and was tracked
by "current_leaf == null".
I could not get this to fail in my environment, but did force it by code
inspection and changing the path through the code by hand to mimic latch
waits. My assumption is that intermittently on some platforms this single
threaded test is competing for these latches with background deleted row
cleaner thread, probably on a fast multiple processor machine.
-
M java/engine/org/apache/derby/impl/store/access/btree/index/B2IRowLocking3.java
M java/engine/org/apache/derby/impl/store/access/btree/BTreeLockingPolicy.java
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@603375 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/access/btree/index/B2IRowLocking3.java",
"hunks": [
{
"added": [
" /**",
" * move left in btree and lock previous key.",
" * <p>",
" * Enter routine with \"current_leaf\" latched. This ro... |
derby-DERBY-3249-fafbff83 | Add JDBC.assertGeneratedKeyResultSet() to verify the type and concurrency of ResultSets returned by Statement.getGeneratedKeys. Add a commented out test case in AutoGenJDBC30Test.java that shows the bug DERBY-3249.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@601044 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/JDBC.java",
"hunks": [
{
"added": [
" /**",
" * Assert that a ResultSet representing generated keys is non-null",
" * and of the correct type. This method leaves the ResultSet",
" * ope... |
derby-DERBY-3250-e621aee2 | DERBY-3250 : making NetworkServerTestSetup using a Runtime.exec(String[]) rather than Runtime.exec(String) to prevent trouble with spaces in arguments.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@608140 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/NetworkServerTestSetup.java",
"hunks": [
{
"added": [
" ArrayList al = new ArrayList();",
" al.add( \"java\" );",
" al.add( \"-classpath\" );",
" al.add( classpath );... |
derby-DERBY-3253-32edb61b | DERBY-3253: Fix NPE for IN list operator when the probe predicate is
pushed into a subselect but then multi-probing does not occur.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@605616 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/BinaryRelationalOperatorNode.java",
"hunks": [
{
"added": [
"\t * back to the InListOperatorNode referenced here. NOTE: Once",
"\t * set, this variable should *only* ever be accessed via the",
"\t * isInLis... |
derby-DERBY-3257-2e556fe3 | DERBY-3257 SELECT with HAVING clause containing OR conditional incorrectly return 1 row - should return 2 rows - works correctly with 10.2 DB
Normalize the havingClause before calling preprocess. This made it necessary to explicitly exclude having subqueries from flattenning, before they were implicitly excluded because the clause was not normalized. Army Brown contributed the main part of the fix to normalize the having clause.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@614017 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/SelectNode.java",
"hunks": [
{
"added": [
"\t\twhereClause = normExpressions(whereClause);",
"\t\t// DERBY-3257. We need to normalize the having clause as well, because ",
"\t\t// preProcess expects CNF.",
... |
derby-DERBY-3258-dd32c163 | DERBY-3258: 'Unexpected row count: expected:<0> but was:<3>' in testReleaseCompileLocks
Wait for post-commit work to complete before checking the contents of
the lock table.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1041338 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-326-f3ab04f3 | - DERBY-326 Improve streaming of large objects for network server and client - Patch by Tomohito Nakayama (tomonaka@basil.ocn.ne.jp)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@405037 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DDMWriter.java",
"hunks": [
{
"added": [
"import java.io.InputStream;",
"import java.io.BufferedInputStream;",
"import java.io.BufferedOutputStream;",
"import org.apache.derby.iapi.reference.Property;",
... |
derby-DERBY-3260-387d1fb4 | DERBY-3260: NullPointerException caused by race condition in GenericActivationHolder
Hold the synchronization lock on the GenericPreparedStatement until
the activation class has been retrieved. This prevents other threads
from setting the activation class to null before we have retrieved it,
and thereby prevents the NPE.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@613815 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/GenericActivationHolder.java",
"hunks": [
{
"added": [
" GeneratedClass newGC;",
"",
" // DERBY-3260: If someone else reprepares the statement at the",
" // sam... |
derby-DERBY-3266-58d069af | DERBY-3266 Not possible for non-db-owner to create a temporary table
Patch derby-3266-2. With this patch, a non-dbo user can use temporary
tables. A new testcase was added to GrantRevokeDDLTest.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@704762 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CompilerContextImpl.java",
"hunks": [
{
"added": [
"",
"\t\tif (td.getTableType() ==",
"\t\t\t\tTableDescriptor.GLOBAL_TEMPORARY_TABLE_TYPE) {",
"\t\t\treturn; // no priv needed, it is per session ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.