repo_name stringlengths 8 38 | pr_number int64 3 47.1k | pr_title stringlengths 8 175 | pr_description stringlengths 2 19.8k ⌀ | author null | date_created stringlengths 25 25 | date_merged stringlengths 25 25 | filepath stringlengths 6 136 | before_content stringlengths 54 884k ⌀ | after_content stringlengths 56 884k | pr_author stringlengths 3 21 | previous_commit stringlengths 40 40 | pr_commit stringlengths 40 40 | comment stringlengths 2 25.4k | comment_author stringlengths 3 29 | __index_level_0__ int64 0 5.1k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
reactor/reactor-netty | 2,357 | Capture HTTP/2 server active stream metrics | Capture H2 active streams metrics for HttpServer.
Issue: https://github.com/reactor/reactor-netty/issues/2356 | null | 2022-07-05 21:47:54+00:00 | 2022-07-07 06:34:23+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerMeters.java | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | samueldlightfoot | f5522a71a6b203a729e8ea5b53c440406f6fe4df | 3a14fc6d638e4fa75d35a047897fa2a555ea8444 | I agree - I'd aligned with the client-side counterpart 'reactor.netty.connection.provider.active.streams', but think it makes sense to be consistent within the server metrics. | samueldlightfoot | 124 |
reactor/reactor-netty | 2,263 | Update faq for connection closed BEFORE error | After upgrading spring versions in our stack we started to see `Connection prematurely closed BEFORE response`.
During investigation I found an introduction of max-keep-alive-requests property from Netty. I wanted to mention this as a point to check in the faq.
## Netty introduces max-keep-alive-requests
chang... | null | 2022-06-01 21:44:43+00:00 | 2022-06-02 13:49:13+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | tylerhjones | aa987075e6f761ac2728f1a20b4e84866e7bf4c7 | 1c3953eeacbe504651b49bc60865d7410d1865c3 | `server.tomcat.max-keep-alive-requests` value by default is **100** and is not changed
```suggestion
``` | violetagg | 125 |
reactor/reactor-netty | 2,057 | Reduce memory overhead when creating Micrometer timers | The purpose of this PR is to reduce memory overhead when creating Micrometer timers instances. | null | 2022-02-24 11:39:49+00:00 | 2022-03-07 09:41:43+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 9aa4fc8a60c23a305bfd3b6099df752b848d3853 | a158ad5fb4ff746ecc5f473c0c0cdc80599469db | Discussed the change with @marcingrzejszczak, we should do the change below
```suggestion
REGISTRY.observationConfig()
.observationHandler(new ObservationHandler.FirstMatchingCompositeObservationHandler(
new ReactorNettyTimerObservationHandler(REGISTRY), new TimerObservationHandler(REGISTRY)));
``` | violetagg | 126 |
reactor/reactor-netty | 2,057 | Reduce memory overhead when creating Micrometer timers | The purpose of this PR is to reduce memory overhead when creating Micrometer timers instances. | null | 2022-02-24 11:39:49+00:00 | 2022-03-07 09:41:43+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 9aa4fc8a60c23a305bfd3b6099df752b848d3853 | a158ad5fb4ff746ecc5f473c0c0cdc80599469db | ```suggestion
import io.micrometer.core.instrument.observation.ObservationHandler;
import io.micrometer.core.instrument.observation.TimerObservationHandler;
import reactor.netty.observability.ReactorNettyTimerObservationHandler;
``` | violetagg | 127 |
reactor/reactor-netty | 2,057 | Reduce memory overhead when creating Micrometer timers | The purpose of this PR is to reduce memory overhead when creating Micrometer timers instances. | null | 2022-02-24 11:39:49+00:00 | 2022-03-07 09:41:43+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 9aa4fc8a60c23a305bfd3b6099df752b848d3853 | a158ad5fb4ff746ecc5f473c0c0cdc80599469db | What do you think to make this `final`? | violetagg | 128 |
reactor/reactor-netty | 2,057 | Reduce memory overhead when creating Micrometer timers | The purpose of this PR is to reduce memory overhead when creating Micrometer timers instances. | null | 2022-02-24 11:39:49+00:00 | 2022-03-07 09:41:43+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 9aa4fc8a60c23a305bfd3b6099df752b848d3853 | a158ad5fb4ff746ecc5f473c0c0cdc80599469db | What do you think to make this `final`? | violetagg | 129 |
reactor/reactor-netty | 2,057 | Reduce memory overhead when creating Micrometer timers | The purpose of this PR is to reduce memory overhead when creating Micrometer timers instances. | null | 2022-02-24 11:39:49+00:00 | 2022-03-07 09:41:43+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 9aa4fc8a60c23a305bfd3b6099df752b848d3853 | a158ad5fb4ff746ecc5f473c0c0cdc80599469db | What do you think to make this `final`? | violetagg | 130 |
reactor/reactor-netty | 2,057 | Reduce memory overhead when creating Micrometer timers | The purpose of this PR is to reduce memory overhead when creating Micrometer timers instances. | null | 2022-02-24 11:39:49+00:00 | 2022-03-07 09:41:43+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/MicrometerAddressResolverGroupMetrics.java | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | pderop | 9aa4fc8a60c23a305bfd3b6099df752b848d3853 | a158ad5fb4ff746ecc5f473c0c0cdc80599469db | Can we remove `protocol` as we provide the `recorder` now? | violetagg | 131 |
reactor/reactor-netty | 2,057 | Reduce memory overhead when creating Micrometer timers | The purpose of this PR is to reduce memory overhead when creating Micrometer timers instances. | null | 2022-02-24 11:39:49+00:00 | 2022-03-07 09:41:43+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/MicrometerAddressResolverGroupMetrics.java | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | pderop | 9aa4fc8a60c23a305bfd3b6099df752b848d3853 | a158ad5fb4ff746ecc5f473c0c0cdc80599469db | I applied your feedbacks, thanks. | pderop | 132 |
reactor/reactor-netty | 2,057 | Reduce memory overhead when creating Micrometer timers | The purpose of this PR is to reduce memory overhead when creating Micrometer timers instances. | null | 2022-02-24 11:39:49+00:00 | 2022-03-07 09:41:43+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/client/MicrometerHttpClientMetricsHandler.java | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | pderop | 9aa4fc8a60c23a305bfd3b6099df752b848d3853 | a158ad5fb4ff746ecc5f473c0c0cdc80599469db | Can we remove `recorder.protocol()` as we provide the `recorder` now? | violetagg | 133 |
reactor/reactor-netty | 2,057 | Reduce memory overhead when creating Micrometer timers | The purpose of this PR is to reduce memory overhead when creating Micrometer timers instances. | null | 2022-02-24 11:39:49+00:00 | 2022-03-07 09:41:43+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/client/MicrometerHttpClientMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 9aa4fc8a60c23a305bfd3b6099df752b848d3853 | a158ad5fb4ff746ecc5f473c0c0cdc80599469db | What do you think to make this `final`? | violetagg | 134 |
reactor/reactor-netty | 2,057 | Reduce memory overhead when creating Micrometer timers | The purpose of this PR is to reduce memory overhead when creating Micrometer timers instances. | null | 2022-02-24 11:39:49+00:00 | 2022-03-07 09:41:43+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsHandler.java | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | pderop | 9aa4fc8a60c23a305bfd3b6099df752b848d3853 | a158ad5fb4ff746ecc5f473c0c0cdc80599469db | Can we remove `recorder.protocol()` as we provide the `recorder` now? | violetagg | 135 |
reactor/reactor-netty | 2,057 | Reduce memory overhead when creating Micrometer timers | The purpose of this PR is to reduce memory overhead when creating Micrometer timers instances. | null | 2022-02-24 11:39:49+00:00 | 2022-03-07 09:41:43+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsHandler.java | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | pderop | 9aa4fc8a60c23a305bfd3b6099df752b848d3853 | a158ad5fb4ff746ecc5f473c0c0cdc80599469db | Can we remove `recorder.protocol()` as we provide the `recorder` now? | violetagg | 136 |
reactor/reactor-netty | 2,057 | Reduce memory overhead when creating Micrometer timers | The purpose of this PR is to reduce memory overhead when creating Micrometer timers instances. | null | 2022-02-24 11:39:49+00:00 | 2022-03-07 09:41:43+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 9aa4fc8a60c23a305bfd3b6099df752b848d3853 | a158ad5fb4ff746ecc5f473c0c0cdc80599469db | What do you think to make this `final`? | violetagg | 137 |
reactor/reactor-netty | 2,045 | Update reactor-netty-http timers to use the new Observation | HttpClient/HttpServer response times now are Observation
Related to #1952
Co-authored-by: Marcin Grzejszczak <mgrzejszczak@vmware.com> | null | 2022-02-21 11:53:34+00:00 | 2022-02-22 09:30:30+00:00 | reactor-netty-core/src/main/java/reactor/netty/tcp/SniProvider.java | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 47dd756398f1b2a2d9cb69b67e8991ba8c9ffcb6 | e6eceff8c65d650b39b9c8e00713521479b9beaf | Shall we add a javadoc for the new enableTracing parameter (maybe not because it's not a public API) ?
| pderop | 138 |
reactor/reactor-netty | 2,045 | Update reactor-netty-http timers to use the new Observation | HttpClient/HttpServer response times now are Observation
Related to #1952
Co-authored-by: Marcin Grzejszczak <mgrzejszczak@vmware.com> | null | 2022-02-21 11:53:34+00:00 | 2022-02-22 09:30:30+00:00 | reactor-netty-core/src/main/java/reactor/netty/tcp/SniProvider.java | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 47dd756398f1b2a2d9cb69b67e8991ba8c9ffcb6 | e6eceff8c65d650b39b9c8e00713521479b9beaf | I would say yes, for our future selves :) | simonbasle | 139 |
reactor/reactor-netty | 2,045 | Update reactor-netty-http timers to use the new Observation | HttpClient/HttpServer response times now are Observation
Related to #1952
Co-authored-by: Marcin Grzejszczak <mgrzejszczak@vmware.com> | null | 2022-02-21 11:53:34+00:00 | 2022-02-22 09:30:30+00:00 | reactor-netty-core/src/main/java/reactor/netty/tcp/SniProvider.java | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 47dd756398f1b2a2d9cb69b67e8991ba8c9ffcb6 | e6eceff8c65d650b39b9c8e00713521479b9beaf | fixed | violetagg | 140 |
reactor/reactor-netty | 2,043 | Update reactor-netty-core timers to use the new Observation | Connect, Hostname resolution and TLS handshake timers now are Observation
Related to #1952
Co-authored-by: Marcin Grzejszczak <mgrzejszczak@vmware.com>
Note: Context propagation and Timers caches will be tracked in separate PRs | null | 2022-02-18 12:56:22+00:00 | 2022-02-18 15:49:17+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/ChannelOperations.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 02db971e866c57c579b74a5c0f02d154d16f27e6 | d7163272601ba231807fbbd777dbe96968b9bc58 | consider expanding this to fuller if-else, nested ternary operators are not great for readability | simonbasle | 141 |
reactor/reactor-netty | 2,043 | Update reactor-netty-core timers to use the new Observation | Connect, Hostname resolution and TLS handshake timers now are Observation
Related to #1952
Co-authored-by: Marcin Grzejszczak <mgrzejszczak@vmware.com>
Note: Context propagation and Timers caches will be tracked in separate PRs | null | 2022-02-18 12:56:22+00:00 | 2022-02-18 15:49:17+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/ChannelOperations.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 02db971e866c57c579b74a5c0f02d154d16f27e6 | d7163272601ba231807fbbd777dbe96968b9bc58 | > one small nitpick, otherwise looks good.
> note that this is targetting `documented-meters` branch, I assume this is on purpose?
Yes I'll re-target before merging | violetagg | 142 |
reactor/reactor-netty | 2,043 | Update reactor-netty-core timers to use the new Observation | Connect, Hostname resolution and TLS handshake timers now are Observation
Related to #1952
Co-authored-by: Marcin Grzejszczak <mgrzejszczak@vmware.com>
Note: Context propagation and Timers caches will be tracked in separate PRs | null | 2022-02-18 12:56:22+00:00 | 2022-02-18 15:49:17+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/ChannelOperations.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 02db971e866c57c579b74a5c0f02d154d16f27e6 | d7163272601ba231807fbbd777dbe96968b9bc58 | > consider expanding this to fuller if-else, nested ternary operators are not great for readability
fixed | violetagg | 143 |
reactor/reactor-netty | 2,041 | Integrated with Micrometer Docs Generator | Use DocumentedMeter for describing Reactor Netty metrics
and add gradle task for generating documentation for these metrics.
Related to #1952
Co-authored-by: Marcin Grzejszczak <mgrzejszczak@vmware.com> | null | 2022-02-17 12:19:07+00:00 | 2022-02-18 14:42:28+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 41cf6dc7209447b75b16efd73c576de507b1c8ec | 02db971e866c57c579b74a5c0f02d154d16f27e6 | just to be sure: if my interpretation is correct from my other two comments, then this would have been equivalent (although concatenation of constants is more concise and prob more efficient):
```suggestion
key -> filter(DistributionSummary.builder(name + DATA_RECEIVED)
key -> filter(DistributionSummary.buil... | simonbasle | 144 |
reactor/reactor-netty | 2,041 | Integrated with Micrometer Docs Generator | Use DocumentedMeter for describing Reactor Netty metrics
and add gradle task for generating documentation for these metrics.
Related to #1952
Co-authored-by: Marcin Grzejszczak <mgrzejszczak@vmware.com> | null | 2022-02-17 12:19:07+00:00 | 2022-02-18 14:42:28+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 41cf6dc7209447b75b16efd73c576de507b1c8ec | 02db971e866c57c579b74a5c0f02d154d16f27e6 | yes exactly | violetagg | 145 |
reactor/reactor-netty | 2,041 | Integrated with Micrometer Docs Generator | Use DocumentedMeter for describing Reactor Netty metrics
and add gradle task for generating documentation for these metrics.
Related to #1952
Co-authored-by: Marcin Grzejszczak <mgrzejszczak@vmware.com> | null | 2022-02-17 12:19:07+00:00 | 2022-02-18 14:42:28+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/ByteBufAllocatorMetrics.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 41cf6dc7209447b75b16efd73c576de507b1c8ec | 02db971e866c57c579b74a5c0f02d154d16f27e6 | ah I see, it's the reverse: the builder uses the enum's `getName()` unless it needs something more dynamic (in which case the enum's `getName()` doesn't really matter?) | simonbasle | 146 |
reactor/reactor-netty | 2,041 | Integrated with Micrometer Docs Generator | Use DocumentedMeter for describing Reactor Netty metrics
and add gradle task for generating documentation for these metrics.
Related to #1952
Co-authored-by: Marcin Grzejszczak <mgrzejszczak@vmware.com> | null | 2022-02-17 12:19:07+00:00 | 2022-02-18 14:42:28+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/ByteBufAllocatorMetrics.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 41cf6dc7209447b75b16efd73c576de507b1c8ec | 02db971e866c57c579b74a5c0f02d154d16f27e6 | yes, when it is dynamic it doesn't matter | violetagg | 147 |
reactor/reactor-netty | 2,029 | Propagate the client thread in the ConnectionPool subscription context | This PR is an attempt to fix a concurrency issue where sometimes an event loop thread may handle almost all http client connections.
The issue may happen when a server is used as a proxy, where requests are forwarded to a remote server using web clients, and when many requests are received concurrently while the con... | null | 2022-02-09 14:02:40+00:00 | 2022-02-09 15:36:35+00:00 | reactor-netty-core/src/main/java/reactor/netty/resources/PooledConnectionProvider.java | /*
* Copyright (c) 2018-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2018-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 54d3a2f40b5f11c5bf67b43ec24fcb0d90aec6dd | bf1a4b33acecd4004be00379fb3bb5fb9bcc6aad | Do we need this space at the beginning of the string?
```suggestion
final static String CONTEXT_CALLER_EVENTLOOP = "callereventloop";
``` | violetagg | 148 |
reactor/reactor-netty | 2,029 | Propagate the client thread in the ConnectionPool subscription context | This PR is an attempt to fix a concurrency issue where sometimes an event loop thread may handle almost all http client connections.
The issue may happen when a server is used as a proxy, where requests are forwarded to a remote server using web clients, and when many requests are received concurrently while the con... | null | 2022-02-09 14:02:40+00:00 | 2022-02-09 15:36:35+00:00 | reactor-netty-core/src/main/java/reactor/netty/resources/PooledConnectionProvider.java | /*
* Copyright (c) 2018-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2018-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 54d3a2f40b5f11c5bf67b43ec24fcb0d90aec6dd | bf1a4b33acecd4004be00379fb3bb5fb9bcc6aad | good catch, thanks. | pderop | 149 |
reactor/reactor-netty | 2,017 | Ensure the stream is closed immediately when a server response is received but still sending the request body | null | null | 2022-02-02 13:51:15+00:00 | 2022-02-02 15:20:06+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientConfig.java | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 0af63514fc69973d00e767372b2f8993d4438c8d | 2ca910d5ef5322ce5c899030244eecf8d381237c | nit: typo on `INSTANSE` => `INSTANCE` | simonbasle | 150 |
reactor/reactor-netty | 2,017 | Ensure the stream is closed immediately when a server response is received but still sending the request body | null | null | 2022-02-02 13:51:15+00:00 | 2022-02-02 15:20:06+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientConfig.java | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 0af63514fc69973d00e767372b2f8993d4438c8d | 2ca910d5ef5322ce5c899030244eecf8d381237c | ouch ... fixed | violetagg | 151 |
reactor/reactor-netty | 2,009 | Http2 streams not closed if request data is not fully consumed | Http2 streams close events are missed in case a full response is sent before having fully read the request.
Fixes #1978 | null | 2022-01-28 15:38:06+00:00 | 2022-02-01 14:42:11+00:00 | reactor-netty-http/src/test/java/reactor/netty/http/server/HttpServerTests.java | /*
* Copyright (c) 2011-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | b28f479f0b0f8e2734b34dfcc48c96634bc0615c | 8e3980d36c3a3fa8924c1e53b476b612316e54b3 | ```suggestion
}
``` | violetagg | 152 |
reactor/reactor-netty | 2,009 | Http2 streams not closed if request data is not fully consumed | Http2 streams close events are missed in case a full response is sent before having fully read the request.
Fixes #1978 | null | 2022-01-28 15:38:06+00:00 | 2022-02-01 14:42:11+00:00 | reactor-netty-http/src/test/java/reactor/netty/http/server/HttpServerTests.java | /*
* Copyright (c) 2011-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | b28f479f0b0f8e2734b34dfcc48c96634bc0615c | 8e3980d36c3a3fa8924c1e53b476b612316e54b3 | thanks, fixed.
| pderop | 153 |
reactor/reactor-netty | 2,007 | [doc] Add info for TCP keep-alive conf on various loadbalancers that may cause connection closed | null | null | 2022-01-28 12:31:09+00:00 | 2022-01-31 07:19:15+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | violetagg | 681274d79c9ccabfb139386e240d38aa88e353d0 | f5761d42eb44c5b121da68a2bef8e0bbb6fe06f7 | as it is, this sentence is put on the same line as the previous bullet point (see rich diff). since it can technically apply to both bullet point, I'd suggest putting it on its own line by adding `**` | simonbasle | 154 |
reactor/reactor-netty | 2,007 | [doc] Add info for TCP keep-alive conf on various loadbalancers that may cause connection closed | null | null | 2022-01-28 12:31:09+00:00 | 2022-01-31 07:19:15+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | violetagg | 681274d79c9ccabfb139386e240d38aa88e353d0 | f5761d42eb44c5b121da68a2bef8e0bbb6fe06f7 | It doesn't apply for the first bullet for idle timeout configuration. `idle timeout configuration` and `TCP keep-alive` are two different configurations.
With the first the proxy and load balancer still send RST/FIN, while with the second they silently drop the connection from their tables without sending any signal.
... | violetagg | 155 |
reactor/reactor-netty | 2,002 | Ensure the correct Context is provided to ContextAwareHttpServerMetricsRecorder | Fixes #1854 | null | 2022-01-26 19:07:54+00:00 | 2022-01-27 19:38:17+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServer.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 821c79564bbd08514d2ec0f10c0563d986b08b56 | f4460ae31f5d58997a40c25551f5db937b467d96 | I would avoid extra couple operators (doOnNext, then) by setting the `ops.currentContext` and returning the `fromDirect` inside the `deferContextual` lambda. | simonbasle | 156 |
reactor/reactor-netty | 2,002 | Ensure the correct Context is provided to ContextAwareHttpServerMetricsRecorder | Fixes #1854 | null | 2022-01-26 19:07:54+00:00 | 2022-01-27 19:38:17+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServer.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 821c79564bbd08514d2ec0f10c0563d986b08b56 | f4460ae31f5d58997a40c25551f5db937b467d96 | as discussed, this suggestion doesn't really work because the `catch` clause below depends on `handler#apply` throwing at assembly time. applying the function outside of `deferContextual` should work though. | simonbasle | 157 |
reactor/reactor-netty | 2,002 | Ensure the correct Context is provided to ContextAwareHttpServerMetricsRecorder | Fixes #1854 | null | 2022-01-26 19:07:54+00:00 | 2022-01-27 19:38:17+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServer.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 821c79564bbd08514d2ec0f10c0563d986b08b56 | f4460ae31f5d58997a40c25551f5db937b467d96 | fixed | violetagg | 158 |
reactor/reactor-netty | 1,998 | HttpServerOperations#isFormUrlencoded handles header value with charset | Fixes #1988 | null | 2022-01-25 12:06:36+00:00 | 2022-01-26 11:36:59+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerOperations.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 952d030d42eb1d7d7f662c47034d9ec007097634 | 61f12a5842e21174837d707ef3e7a33575c751d9 | I would suggest avoiding `startsWith` and instead maybe introducing some sort of headers sanitization or comparison util which removes/ignores directives... as you said offband, the `;` can be separated by whitespace so it is not a simple matter of checking the n-th character, unfortunately :( | simonbasle | 159 |
reactor/reactor-netty | 1,998 | HttpServerOperations#isFormUrlencoded handles header value with charset | Fixes #1988 | null | 2022-01-25 12:06:36+00:00 | 2022-01-26 11:36:59+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerOperations.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 952d030d42eb1d7d7f662c47034d9ec007097634 | 61f12a5842e21174837d707ef3e7a33575c751d9 | good catch, let me fix that | violetagg | 160 |
reactor/reactor-netty | 1,998 | HttpServerOperations#isFormUrlencoded handles header value with charset | Fixes #1988 | null | 2022-01-25 12:06:36+00:00 | 2022-01-26 11:36:59+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerOperations.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 952d030d42eb1d7d7f662c47034d9ec007097634 | 61f12a5842e21174837d707ef3e7a33575c751d9 | please check now | violetagg | 161 |
reactor/reactor-netty | 1,998 | HttpServerOperations#isFormUrlencoded handles header value with charset | Fixes #1988 | null | 2022-01-25 12:06:36+00:00 | 2022-01-26 11:36:59+00:00 | reactor-netty-http/src/test/java/reactor/netty/http/server/HttpServerTests.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 952d030d42eb1d7d7f662c47034d9ec007097634 | 61f12a5842e21174837d707ef3e7a33575c751d9 | maybe add a test that `application/x-www-form-urlencoded-bad` is not `isFormUrlencoded`? | simonbasle | 162 |
reactor/reactor-netty | 1,996 | [build] Hardening of GitHub actions | This commit makes several modifications to our workflows to make them
more secure:
- explicitly have GITHUB_TOKEN read-only by default
- split tagging steps in their own jobs, limiting the scope of needed
write permission to these short-lived jobs | null | 2022-01-25 09:11:09+00:00 | 2022-01-27 14:11:26+00:00 | .github/workflows/check_netty_snapshots.yml | name: Check Netty SNAPSHOTS
on:
schedule:
- cron: "0 14 * * *"
jobs:
build:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-20.04, macos-10.15, windows-2019]
transport: [native, nio]
exclude:
# excludes native on Windows (there's ... | name: Check Netty SNAPSHOTS
on:
schedule:
- cron: "0 14 * * *"
permissions: read-all
jobs:
build:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-20.04, macos-10.15, windows-2019]
transport: [native, nio]
exclude:
# excludes native... | violetagg | a1eeebfae73a60687937a104d9476f7707997c5d | 821c79564bbd08514d2ec0f10c0563d986b08b56 | this could also be enabled on `codeql` workflow. that said, ultimately the org-wide setting will probably be used on top of explicit read-only `permissions` clauses | simonbasle | 163 |
reactor/reactor-netty | 1,996 | [build] Hardening of GitHub actions | This commit makes several modifications to our workflows to make them
more secure:
- explicitly have GITHUB_TOKEN read-only by default
- split tagging steps in their own jobs, limiting the scope of needed
write permission to these short-lived jobs | null | 2022-01-25 09:11:09+00:00 | 2022-01-27 14:11:26+00:00 | .github/workflows/check_netty_snapshots.yml | name: Check Netty SNAPSHOTS
on:
schedule:
- cron: "0 14 * * *"
jobs:
build:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-20.04, macos-10.15, windows-2019]
transport: [native, nio]
exclude:
# excludes native on Windows (there's ... | name: Check Netty SNAPSHOTS
on:
schedule:
- cron: "0 14 * * *"
permissions: read-all
jobs:
build:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-20.04, macos-10.15, windows-2019]
transport: [native, nio]
exclude:
# excludes native... | violetagg | a1eeebfae73a60687937a104d9476f7707997c5d | 821c79564bbd08514d2ec0f10c0563d986b08b56 | mmm for CodeQL we need `security-events: write`
see https://github.com/github/codeql-action#usage | violetagg | 164 |
reactor/reactor-netty | 1,996 | [build] Hardening of GitHub actions | This commit makes several modifications to our workflows to make them
more secure:
- explicitly have GITHUB_TOKEN read-only by default
- split tagging steps in their own jobs, limiting the scope of needed
write permission to these short-lived jobs | null | 2022-01-25 09:11:09+00:00 | 2022-01-27 14:11:26+00:00 | .github/workflows/check_netty_snapshots.yml | name: Check Netty SNAPSHOTS
on:
schedule:
- cron: "0 14 * * *"
jobs:
build:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-20.04, macos-10.15, windows-2019]
transport: [native, nio]
exclude:
# excludes native on Windows (there's ... | name: Check Netty SNAPSHOTS
on:
schedule:
- cron: "0 14 * * *"
permissions: read-all
jobs:
build:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-20.04, macos-10.15, windows-2019]
transport: [native, nio]
exclude:
# excludes native... | violetagg | a1eeebfae73a60687937a104d9476f7707997c5d | 821c79564bbd08514d2ec0f10c0563d986b08b56 | right. that doesn't seem too bad and probably better than the (current) default of write-all so I'd say go for it | simonbasle | 165 |
reactor/reactor-netty | 1,996 | [build] Hardening of GitHub actions | This commit makes several modifications to our workflows to make them
more secure:
- explicitly have GITHUB_TOKEN read-only by default
- split tagging steps in their own jobs, limiting the scope of needed
write permission to these short-lived jobs | null | 2022-01-25 09:11:09+00:00 | 2022-01-27 14:11:26+00:00 | .github/workflows/check_netty_snapshots.yml | name: Check Netty SNAPSHOTS
on:
schedule:
- cron: "0 14 * * *"
jobs:
build:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-20.04, macos-10.15, windows-2019]
transport: [native, nio]
exclude:
# excludes native on Windows (there's ... | name: Check Netty SNAPSHOTS
on:
schedule:
- cron: "0 14 * * *"
permissions: read-all
jobs:
build:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-20.04, macos-10.15, windows-2019]
transport: [native, nio]
exclude:
# excludes native... | violetagg | a1eeebfae73a60687937a104d9476f7707997c5d | 821c79564bbd08514d2ec0f10c0563d986b08b56 | ok we have now
```
GITHUB_TOKEN Permissions
Metadata: read
SecurityEvents: write
```
https://github.com/reactor/reactor-netty/runs/4940728231?check_suite_focus=true#step:1:13 | violetagg | 166 |
reactor/reactor-netty | 1,996 | [build] Hardening of GitHub actions | This commit makes several modifications to our workflows to make them
more secure:
- explicitly have GITHUB_TOKEN read-only by default
- split tagging steps in their own jobs, limiting the scope of needed
write permission to these short-lived jobs | null | 2022-01-25 09:11:09+00:00 | 2022-01-27 14:11:26+00:00 | .github/workflows/codeql-analysis.yml | # For most projects, this workflow file will not need changing; you simply need
# to commit it to your repository.
#
# You may wish to alter this file to override the set of languages analyzed,
# or to provide custom queries or build logic.
name: "CodeQL"
on:
push:
branches: [ main ]
pull_request:
# The br... | # For most projects, this workflow file will not need changing; you simply need
# to commit it to your repository.
#
# You may wish to alter this file to override the set of languages analyzed,
# or to provide custom queries or build logic.
name: "CodeQL"
on:
push:
branches: [ main ]
pull_request:
# The br... | violetagg | a1eeebfae73a60687937a104d9476f7707997c5d | 821c79564bbd08514d2ec0f10c0563d986b08b56 | I don't think that will work without a `permissions: read-all` at top level, will it ?
(if any specific permission is set, anything that is unset defaults to `none`).
I guess this doesn't come up in the PR's checks because CodeQL is only activated on main branch 🤔 | simonbasle | 167 |
reactor/reactor-netty | 1,996 | [build] Hardening of GitHub actions | This commit makes several modifications to our workflows to make them
more secure:
- explicitly have GITHUB_TOKEN read-only by default
- split tagging steps in their own jobs, limiting the scope of needed
write permission to these short-lived jobs | null | 2022-01-25 09:11:09+00:00 | 2022-01-27 14:11:26+00:00 | .github/workflows/codeql-analysis.yml | # For most projects, this workflow file will not need changing; you simply need
# to commit it to your repository.
#
# You may wish to alter this file to override the set of languages analyzed,
# or to provide custom queries or build logic.
name: "CodeQL"
on:
push:
branches: [ main ]
pull_request:
# The br... | # For most projects, this workflow file will not need changing; you simply need
# to commit it to your repository.
#
# You may wish to alter this file to override the set of languages analyzed,
# or to provide custom queries or build logic.
name: "CodeQL"
on:
push:
branches: [ main ]
pull_request:
# The br... | violetagg | a1eeebfae73a60687937a104d9476f7707997c5d | 821c79564bbd08514d2ec0f10c0563d986b08b56 | I added a top level permissions | violetagg | 168 |
reactor/reactor-netty | 1,989 | fixes #1940: adds support to basic auth (username and password) to pr… | …oxy providers created from system properties | null | 2022-01-18 09:16:14+00:00 | 2022-01-25 08:39:28+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/ProxyProvider.java | /*
* Copyright (c) 2017-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2017-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | sebphil | 389d1e76785058d833b7ae2dfd0d210fb4d0eb77 | 5139bfc880c42eec60c6a02bf79376174164c331 | I would check that the password is non-null IF AND ONLY IF the user property is set. If username non-null but password null, fail with an NPE with a message like `"Proxy username is set via " + userProperty + ", but no password is set". | simonbasle | 169 |
reactor/reactor-netty | 1,989 | fixes #1940: adds support to basic auth (username and password) to pr… | …oxy providers created from system properties | null | 2022-01-18 09:16:14+00:00 | 2022-01-25 08:39:28+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/ProxyProvider.java | /*
* Copyright (c) 2017-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2017-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | sebphil | 389d1e76785058d833b7ae2dfd0d210fb4d0eb77 | 5139bfc880c42eec60c6a02bf79376174164c331 | here I think we need to conditionally invoke `username` and `password` methods? (the same way it is done for the SOCKS proxy configuration below) | simonbasle | 170 |
reactor/reactor-netty | 1,989 | fixes #1940: adds support to basic auth (username and password) to pr… | …oxy providers created from system properties | null | 2022-01-18 09:16:14+00:00 | 2022-01-25 08:39:28+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/ProxyProvider.java | /*
* Copyright (c) 2017-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2017-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | sebphil | 389d1e76785058d833b7ae2dfd0d210fb4d0eb77 | 5139bfc880c42eec60c6a02bf79376174164c331 | I thought about doing that, but it appears that the username and password methods are just "setters", so passing null is just a no-op and doesn't break anything. If you think this behavior is subject to change, it might be worthwile to add a nullity check. Please let me know what you think is best.
Edit: the `newPro... | sebphil | 171 |
reactor/reactor-netty | 1,989 | fixes #1940: adds support to basic auth (username and password) to pr… | …oxy providers created from system properties | null | 2022-01-18 09:16:14+00:00 | 2022-01-25 08:39:28+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/ProxyProvider.java | /*
* Copyright (c) 2017-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2017-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | sebphil | 389d1e76785058d833b7ae2dfd0d210fb4d0eb77 | 5139bfc880c42eec60c6a02bf79376174164c331 | I refactored my code to be more in line with the SOCKS part | sebphil | 172 |
reactor/reactor-netty | 1,989 | fixes #1940: adds support to basic auth (username and password) to pr… | …oxy providers created from system properties | null | 2022-01-18 09:16:14+00:00 | 2022-01-25 08:39:28+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/ProxyProvider.java | /*
* Copyright (c) 2017-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2017-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | sebphil | 389d1e76785058d833b7ae2dfd0d210fb4d0eb77 | 5139bfc880c42eec60c6a02bf79376174164c331 | ```suggestion
}
else {
throw new NullPointerException("Proxy username is set via '" + userProperty + "', but '" + passwordProperty + "' is not set.");
}
``` | violetagg | 173 |
reactor/reactor-netty | 1,989 | fixes #1940: adds support to basic auth (username and password) to pr… | …oxy providers created from system properties | null | 2022-01-18 09:16:14+00:00 | 2022-01-25 08:39:28+00:00 | reactor-netty-core/src/test/java/reactor/netty/transport/ProxyProviderTest.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | sebphil | 389d1e76785058d833b7ae2dfd0d210fb4d0eb77 | 5139bfc880c42eec60c6a02bf79376174164c331 | add two tests to check the NPE reflects the property used (HTTP vs HTTPS) + at least one test to check what happens when `username(null)` is invoked? | simonbasle | 174 |
reactor/reactor-netty | 1,989 | fixes #1940: adds support to basic auth (username and password) to pr… | …oxy providers created from system properties | null | 2022-01-18 09:16:14+00:00 | 2022-01-25 08:39:28+00:00 | reactor-netty-core/src/test/java/reactor/netty/transport/ProxyProviderTest.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | sebphil | 389d1e76785058d833b7ae2dfd0d210fb4d0eb77 | 5139bfc880c42eec60c6a02bf79376174164c331 | I added tests for the NPE cases. I don't think it's useful to add specific tests for when username is null, as it's already the case in all other tests. | sebphil | 175 |
reactor/reactor-netty | 1,981 | Document that extended TCP keep-alive settings are only available on … | …Mac/Linux not Windows | null | 2022-01-12 19:41:54+00:00 | 2022-01-28 12:02:41+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/release/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
[[http-cl... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/release/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
[[http-cl... | ryanrupp | f4460ae31f5d58997a40c25551f5db937b467d96 | ba35218f4c396cb2ad48e4dcbf3c49b0d9918938 | ```suggestion
When you run with `Epoll`/`NIO` (https://bugs.openjdk.java.net/browse/JDK-8194298[since *Java 11* on *Mac or Linux*]) transport, you may also configure:
``` | violetagg | 176 |
reactor/reactor-netty | 1,981 | Document that extended TCP keep-alive settings are only available on … | …Mac/Linux not Windows | null | 2022-01-12 19:41:54+00:00 | 2022-01-28 12:02:41+00:00 | reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client/channeloptions/Application.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ryanrupp | f4460ae31f5d58997a40c25551f5db937b467d96 | ba35218f4c396cb2ad48e4dcbf3c49b0d9918938 | ```suggestion
// on Mac or Linux (Java does not currently support these extended options on Windows)
// https://bugs.openjdk.java.net/browse/JDK-8194298
``` | violetagg | 177 |
reactor/reactor-netty | 1,974 | Do not cache Meter builders | Meter builders are mutable and not thread safe. | null | 2022-01-10 11:06:19+00:00 | 2022-01-10 12:17:46+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsRecorder.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | fce4ec3b6e830c70ff1ba31e9ea890a6541b7709 | 3d5f96ecadae94f4335cc754f99cdcf09b542089 | suggestion: use either `tags(k1, v1, k2, v2)` or add line return | simonbasle | 178 |
reactor/reactor-netty | 1,974 | Do not cache Meter builders | Meter builders are mutable and not thread safe. | null | 2022-01-10 11:06:19+00:00 | 2022-01-10 12:17:46+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsRecorder.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | fce4ec3b6e830c70ff1ba31e9ea890a6541b7709 | 3d5f96ecadae94f4335cc754f99cdcf09b542089 | suggestion: use either `tags(k1, v1, k2, v2)` or add line return | simonbasle | 179 |
reactor/reactor-netty | 1,974 | Do not cache Meter builders | Meter builders are mutable and not thread safe. | null | 2022-01-10 11:06:19+00:00 | 2022-01-10 12:17:46+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsRecorder.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | fce4ec3b6e830c70ff1ba31e9ea890a6541b7709 | 3d5f96ecadae94f4335cc754f99cdcf09b542089 | suggestion: use either `tags(k1, v1, k2, v2)` or add line return | simonbasle | 180 |
reactor/reactor-netty | 1,974 | Do not cache Meter builders | Meter builders are mutable and not thread safe. | null | 2022-01-10 11:06:19+00:00 | 2022-01-10 12:17:46+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsRecorder.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | fce4ec3b6e830c70ff1ba31e9ea890a6541b7709 | 3d5f96ecadae94f4335cc754f99cdcf09b542089 | nice catch | violetagg | 181 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | Remove `2019` as `2022` is the year when the file is created.
```suggestion
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
``` | violetagg | 182 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | thanks Violeta, applied suggestion. | pderop | 183 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | mmh I saw 2022 only in the other PR (which will likely clash with that one btw) and looking at history of this file, despite being moved, it _was_ created in 2019, wasn't it ? | simonbasle | 184 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | ```suggestion
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
``` | simonbasle | 185 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | @simonbasle ooo, my bad. You are right. I was thinking that this is a new file. | violetagg | 186 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | these are now unused, right? | simonbasle | 187 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | same here, unused constant ? | simonbasle | 188 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | These are used by the `ConnectionProvider` and cannot be changed as this is a backwards incompatible change. | violetagg | 189 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | ah, that's why. ok, turning my review into an approved 👍 | simonbasle | 190 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | the java doc needs correction | violetagg | 191 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | the java doc needs correction | violetagg | 192 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/AbstractChannelMetricsHandler.java | /*
* Copyright (c) 2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | /*
* Copyright (c) 2021-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | ```suggestion
public void channelActive(ChannelHandlerContext ctx) {
``` | violetagg | 193 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/AbstractChannelMetricsHandler.java | /*
* Copyright (c) 2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | /*
* Copyright (c) 2021-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | ```suggestion
public void channelInactive(ChannelHandlerContext ctx) {
``` | violetagg | 194 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/ChannelMetricsRecorder.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | @simonbasle What do you think about the API? I'm still thinking that this is a bit ... yeah I don't know.
Increment
`recorder().incrementServerConnections(ctx.channel().localAddress(), 1);`
Decrement
`recorder().incrementServerConnections(ctx.channel().localAddress(), -1);`
| violetagg | 195 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/ChannelMetricsRecorder.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | I guess a single method called increment which accepts a negative number is a bit weird 🤔
in fact, how did I miss this: `Counter` in micrometer **doesn't support decrementing**:
> Counters report a single metric, a count. The Counter interface allows you to increment by a fixed amount, which must be positive.
| simonbasle | 196 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/ChannelMetricsRecorder.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | indeed, maybe 2 methods would make sense (especially given that amount is either -1 or 1). So I suggest:
```java
recordConnectionOpened(SocketAddress localAddress);
recordConnectionClosed(SocketAddress localAddress);
```
see also the Http recorder below
| simonbasle | 197 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | Micrometer `Counter`s don't support negative increment.
> Counters report a single metric, a count. The Counter interface allows you to increment by a fixed amount, which must be positive.
| simonbasle | 198 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | this should probably be a `Gauge` over an over `AtomicInteger` (unless we think integer max value is not enough in practice, in which case `AtomicLong`). The `AtomicInteger` wrapper would be stored and incremented/decremented by recorder interaction. When the backend polls the Gauge, it will report `AtomicLong##get`, w... | simonbasle | 199 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | nit: `increment` instead of `add(1)` | violetagg | 200 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | nit: `decrement` instead of `add(-1)` | violetagg | 201 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | There is no need on `MeterKey`, check reactor.netty.channel.MicrometerChannelMetricsRecorder#incrementErrorsCount | violetagg | 202 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-core/src/test/java/reactor/netty/tcp/TcpMetricsTests.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | For the future PR , if you want to reorganise the imports/format etc please do this in another commit | violetagg | 203 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | same as in tcp, split into 2 methods
```java
recordConnectionActive(String uri, String method);
recordConnectionInactive(String uri, String method);
```
~regarding `uri`, as stated in previous review, this seems to be more of a constant `http` closer to a protocol. I don't think we need/want to keep track of n... | simonbasle | 204 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | disregard that comment about `uri`. For active connections, it is indeed correctly passed (and the `tag mapper` can be used to reduce the cardinality) 👍 | simonbasle | 205 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | as discussed off-band, let's avoid tagging with uri/method, and align input parameters with `recordServiceConnectionOpened|Closed`: only provide `SocketAddress localAddress`. | simonbasle | 206 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | same as above: align input parameters with `recordServiceConnectionOpened|Closed`: only provide `SocketAddress localAddress`. | simonbasle | 207 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | same as in TCP, use a `Gauge` over `AtomicInteger` (unless we think integer max value is not enough in practice, in which case `AtomicLong`) | simonbasle | 208 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | should we replace `URI` with a new `PROTOCOL` tag? | simonbasle | 209 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | maybe rename to `PROTOCOL_VALUE_HTTP` ? consider also adding a `PROTOCOL` tag name constant. | simonbasle | 210 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | note that if this was actually an URI, there would again be a potential for a high number of variations. not as much as the remote address, but still in some case there can be a huge number of URIs served by the server.
but in any case, this doesn't seem to be used as uri, more as a protocol tag ✅ | simonbasle | 211 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | oh I see... the URI tag is set to the protocol via the constructor and meter builders, for cases where the actual URI is unknown / non-applicable. | simonbasle | 212 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | disregard these comments. the common API with tcp base doesn't allow passing of an URI and so the URI tag doesn't make sense here. our meters use `URI = protocol` as a convention when the uri is unknown hence this tag. | simonbasle | 213 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | these are redundant with the similar ones in super class and can be removed
```suggestion
``` | simonbasle | 214 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | this one is not needed. `super(HTTP_SERVER_PREFIX, HTTP)` creates a counter builder with http both in the name and as a `URI` tag. actually, I don't think you need to override `incrementServerConnections` thanks to that fact
```suggestion
``` | simonbasle | 215 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | this override is not needed. the super method already does the same thing, since `super(HTTP_SERVER_PREFIX, HTTP)` correctly configures the meter builder name and URI tag. as a result, `connectionsCache` and `connectionsBuilder` are also redundant
```suggestion
``` | simonbasle | 216 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | good catch !!
thanks for the review, I'll work on applying all this. | pderop | 217 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | the same as channel recorder | violetagg | 218 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | the same as channel recorder | violetagg | 219 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | transitively, this should also only have a single input parameter `SocketAddress localAddress`. | simonbasle | 220 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | the tags would become:
`.tags(URI, PROTOCOL_VALUE_HTTP, LOCAL_ADDRESS, localAddress)` | simonbasle | 221 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsRecorder.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | NB: amend the tests accordingly | simonbasle | 222 |
reactor/reactor-netty | 1,956 | Add more server connection metrics | This PR which adds the following metrics for the #1366 issue:
- reactor.netty.tcp.server.connections.total: this new meter (Gauge) reflects the number of currently opened and accepted tcp server connections. TAGS supported: uri (always "tcp"), local.address (corresponds to server listening address, in the format ip:... | null | 2021-12-23 11:48:28+00:00 | 2022-01-11 12:05:02+00:00 | reactor-netty-http/src/test/java/reactor/netty/http/HttpMetricsHandlerTests.java | /*
* Copyright (c) 2019-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | f2f1277e40f04f605f8e936981e6a1c769b57044 | 81f73f7afd7291137e59a7a8ce3f9575600e6b15 | that method is badly used, because it checks counter is >= expectedCount. so naturally, even though counter newer decrements, `checkCounter(0)` would always be `true`... | simonbasle | 223 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.