repo_name stringlengths 8 38 | pr_number int64 3 47.1k | pr_title stringlengths 8 175 | pr_description stringlengths 2 19.8k ⌀ | author null | date_created stringlengths 25 25 | date_merged stringlengths 25 25 | filepath stringlengths 6 136 | before_content stringlengths 54 884k ⌀ | after_content stringlengths 56 884k | pr_author stringlengths 3 21 | previous_commit stringlengths 40 40 | pr_commit stringlengths 40 40 | comment stringlengths 2 25.4k | comment_author stringlengths 3 29 | __index_level_0__ int64 0 5.1k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
reactor/reactor-netty | 1,923 | New HTTP/2 connection pool implementation | The connection is removed from the pool when:
- The connection is closed.
- The connection has reached its life time and there are no active streams.
- The connection has no active streams.
- When the client is in one of the two modes: 1) `H2` and `HTTP/1.1` or 2) `H2C` and `HTTP/1.1`,
and the negotiated protocol ... | null | 2021-12-06 12:38:24+00:00 | 2021-12-08 17:48:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/client/Http2ConnectionProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | bddeb859a6871573934aa74692478b8fc5ff6c60 | 81f4d7a518600de71b07b5017b1d5a94aa362aad | not sure I understand the purpose of this `map` in old code, but it does seem totally removable in new code, right?
edit: I'm guessing this is to force downcasting to `Mono<Connection>` rather than `Mono<? extends Connection>`? | simonbasle | 224 |
reactor/reactor-netty | 1,923 | New HTTP/2 connection pool implementation | The connection is removed from the pool when:
- The connection is closed.
- The connection has reached its life time and there are no active streams.
- The connection has no active streams.
- When the client is in one of the two modes: 1) `H2` and `HTTP/1.1` or 2) `H2C` and `HTTP/1.1`,
and the negotiated protocol ... | null | 2021-12-06 12:38:24+00:00 | 2021-12-08 17:48:02+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/client/Http2ConnectionProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | bddeb859a6871573934aa74692478b8fc5ff6c60 | 81f4d7a518600de71b07b5017b1d5a94aa362aad | > I'm guessing this is to force downcasting to Mono<Connection> rather than Mono<? extends Connection>?
yes | violetagg | 225 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | suggest to add `@since 1.0.14` after @return statement | ctlove0523 | 226 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | this.localAddress = Objects.requireNonNull(localAddress,"localAddress"); | ctlove0523 | 227 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | Let's rename the method and accept a `Supplier` as in the rest of the `Transport`s
`bindAddress(Supplier<? extends SocketAddress> bindAddressSupplier)` | violetagg | 228 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | ```suggestion
* Set a new local address that will be used to bind.
* By default, the host is configured for any local address, and the system picks up an ephemeral port.
``` | violetagg | 229 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | Check for `NULL` as the coding below in this method. | violetagg | 230 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | ```suggestion
NameResolverSpec bindAddress(Supplier<? extends SocketAddress> bindAddressSupplier);
```
| violetagg | 231 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | ```suggestion
* By default, the host is configured for any local address, and the system picks up an ephemeral port.
*
* @param bindAddressSupplier A supplier of the address to bind to.
``` | violetagg | 232 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | The idea of the `Supplier` is to create the `SocketAddress` lazy. Please do not obtain the `SocketAddress` here. The field `localAddress` will be `Supplier` and not `SocketAddress`.
Check only that the `Supplier` is not null. Later when we configure the name resolver we will handle the case when the `Supplier` returns... | violetagg | 233 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | done | ShijunDeng | 234 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | ```suggestion
* Returns the configured supplier of local address to bind to or null.
*
* @return the configured supplier of local address to bind to or null
``` | violetagg | 235 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | Add `@since 1.0.14` | violetagg | 236 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | done | ShijunDeng | 237 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | I think there is a word missing after the `that`, `provides` comes to mind | simonbasle | 238 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | @violetagg @shijundeng is there a potential need for supporting `null` as input in order to get back to the default strategy? | simonbasle | 239 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | @violetagg @shijundeng I know the other similarily Nullable fields are not marked as such, but maybe we should consider it? | simonbasle | 240 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | @violetagg @shijundeng same here for `@Nullable` marker | simonbasle | 241 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | That sounds marvelous! but there is no `@Nullable` on other filed too | ShijunDeng | 242 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | there is no @Nullable on other filed too | ShijunDeng | 243 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | there is no @Nullable on other filed too | ShijunDeng | 244 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | yes , it's `Set a new local address supplier that supply the address to bind to.` | ShijunDeng | 245 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | @simonbasle If we decide to do this let's do it in a separate PR for all fields. Wdyt? | violetagg | 246 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | You can always return a `Supplier` that provides null. I intentionally haven't requested a check for null here
```
if (bindAddressSupplier != null) {
builder.localAddress(bindAddressSupplier.get());
}
```
The Netty's API handles the case when you provide null.
But may be this requires some comments in the... | violetagg | 247 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | ```suggestion
// If the default behaviour for bindAddress is the desired behaviour, one can provide a Supplier that returns null
Objects.requireNonNull(bindAddressSupplier, "bindAddressSupplier");
``` | violetagg | 248 |
reactor/reactor-netty | 1,919 | config dns bind address in NameResolverSpec | Allow to config dns bind address in NameResolverSpec
FIx [1920](https://github.com/reactor/reactor-netty/issues/1920) | null | 2021-12-05 14:32:55+00:00 | 2021-12-07 13:54:32+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | ShijunDeng | e4354a359c47c679902727218ab8a01f08f13780 | 72f88aafd0647efac43b20ca37d1c899b11d488a | ```suggestion
// There is no check for bindAddressSupplier.get() == null
// This is deliberate, when null value is provided Netty will use the default behaviour
builder.localAddress(bindAddressSupplier.get());
``` | violetagg | 249 |
reactor/reactor-netty | 1,917 | Add new metrics for monitoring actual bytes consumed by in-use buffers | Added a note in the "How can I debug a memory leak" FAQ, on how to use Native Memory Tracking jvm tool. | null | 2021-12-03 12:00:31+00:00 | 2022-01-13 14:05:19+00:00 | docs/asciidoc/alloc-metrics.adoc | `ByteBufAllocator` metrics
[width="100%",options="header"]
|=======
| metric name | type | description
| reactor.netty.bytebuf.allocator.used.heap.memory | Gauge | The number of the bytes of the heap memory
| reactor.netty.bytebuf.allocator.used.direct.memory | Gauge | The number of the bytes of the direct memory
| re... | `ByteBufAllocator` metrics
[width="100%",options="header"]
|=======
| metric name | type | description
| reactor.netty.bytebuf.allocator.used.heap.memory | Gauge | The number of bytes reserved by heap buffer allocator
| reactor.netty.bytebuf.allocator.used.direct.memory | Gauge | The number of bytes reserved by direct... | pderop | 15b5a54c362c3ef64961bf3a2a126640cfd9673c | 72a7c922350741bdcfa471b45873f4c06018bcab | how about "reserved by" rather than "committed to"?
```suggestion
| reactor.netty.bytebuf.allocator.used.heap.memory | Gauge | The number of bytes reserved by heap buffer allocator
| reactor.netty.bytebuf.allocator.used.direct.memory | Gauge | The number of bytes reserved by direct buffer allocator
```
if acce... | simonbasle | 250 |
reactor/reactor-netty | 1,917 | Add new metrics for monitoring actual bytes consumed by in-use buffers | Added a note in the "How can I debug a memory leak" FAQ, on how to use Native Memory Tracking jvm tool. | null | 2021-12-03 12:00:31+00:00 | 2022-01-13 14:05:19+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | pderop | 15b5a54c362c3ef64961bf3a2a126640cfd9673c | 72a7c922350741bdcfa471b45873f4c06018bcab | May be it is better to extend our Memory metrics. Wdyt? | violetagg | 251 |
reactor/reactor-netty | 1,917 | Add new metrics for monitoring actual bytes consumed by in-use buffers | Added a note in the "How can I debug a memory leak" FAQ, on how to use Native Memory Tracking jvm tool. | null | 2021-12-03 12:00:31+00:00 | 2022-01-13 14:05:19+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | pderop | 15b5a54c362c3ef64961bf3a2a126640cfd9673c | 72a7c922350741bdcfa471b45873f4c06018bcab | This discussion is interesting https://github.com/netty/netty/pull/11642 and https://github.com/netty/netty/pull/11667 | violetagg | 252 |
reactor/reactor-netty | 1,917 | Add new metrics for monitoring actual bytes consumed by in-use buffers | Added a note in the "How can I debug a memory leak" FAQ, on how to use Native Memory Tracking jvm tool. | null | 2021-12-03 12:00:31+00:00 | 2022-01-13 14:05:19+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | pderop | 15b5a54c362c3ef64961bf3a2a126640cfd9673c | 72a7c922350741bdcfa471b45873f4c06018bcab | yes ! better is to add more meter(s).
ok, I'll work on this ...
| pderop | 253 |
reactor/reactor-netty | 1,917 | Add new metrics for monitoring actual bytes consumed by in-use buffers | Added a note in the "How can I debug a memory leak" FAQ, on how to use Native Memory Tracking jvm tool. | null | 2021-12-03 12:00:31+00:00 | 2022-01-13 14:05:19+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | pderop | 15b5a54c362c3ef64961bf3a2a126640cfd9673c | 72a7c922350741bdcfa471b45873f4c06018bcab | It is more visible if we use `something` instead of _something_
```suggestion
Another way to detect memory leaks is to monitor `reactor.netty.bytebuf.allocator.active.heap.memory` and `reactor.netty.bytebuf.allocator.active.direct.memory` meters:
- The `reactor.netty.bytebuf.allocator.active.heap.memory` provi... | violetagg | 254 |
reactor/reactor-netty | 1,917 | Add new metrics for monitoring actual bytes consumed by in-use buffers | Added a note in the "How can I debug a memory leak" FAQ, on how to use Native Memory Tracking jvm tool. | null | 2021-12-03 12:00:31+00:00 | 2022-01-13 14:05:19+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 15b5a54c362c3ef64961bf3a2a126640cfd9673c | 72a7c922350741bdcfa471b45873f4c06018bcab | ```suggestion
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
``` | simonbasle | 255 |
reactor/reactor-netty | 1,905 | [documentation] How to debug "Connection prematurely closed BEFORE response" | null | null | 2021-11-30 11:14:01+00:00 | 2021-12-02 16:08:45+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]
[[faq.logging-prefix]]
== ... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | violetagg | 01b9348724bd23ea69d0dd09bce2a164a5fe9272 | 667cbf84d70f735055ea849713496fab2bb559e9 | the `setup might not be like:` part of this sentence is unclear. not like what? there are two `:` in this sentence, which makes me think it was meant to be two separate sentences? | simonbasle | 256 |
reactor/reactor-netty | 1,905 | [documentation] How to debug "Connection prematurely closed BEFORE response" | null | null | 2021-11-30 11:14:01+00:00 | 2021-12-02 16:08:45+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]
[[faq.logging-prefix]]
== ... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | violetagg | 01b9348724bd23ea69d0dd09bce2a164a5fe9272 | 667cbf84d70f735055ea849713496fab2bb559e9 | ```suggestion
By default, Reactor Netty clients uses connection pooling. When a connection is acquired from the connection pool, it is checked to be open still.
``` | simonbasle | 257 |
reactor/reactor-netty | 1,905 | [documentation] How to debug "Connection prematurely closed BEFORE response" | null | null | 2021-11-30 11:14:01+00:00 | 2021-12-02 16:08:45+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]
[[faq.logging-prefix]]
== ... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | violetagg | 01b9348724bd23ea69d0dd09bce2a164a5fe9272 | 667cbf84d70f735055ea849713496fab2bb559e9 | Change to:
By default, Reactor Netty clients use connection pooling. When a connection is acquired from the connection pool, it is checked to see whether it is still open. | Buzzardo | 258 |
reactor/reactor-netty | 1,905 | [documentation] How to debug "Connection prematurely closed BEFORE response" | null | null | 2021-11-30 11:14:01+00:00 | 2021-12-02 16:08:45+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]
[[faq.logging-prefix]]
== ... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | violetagg | 01b9348724bd23ea69d0dd09bce2a164a5fe9272 | 667cbf84d70f735055ea849713496fab2bb559e9 | Change "cause connection" to "cause a connection". | Buzzardo | 259 |
reactor/reactor-netty | 1,905 | [documentation] How to debug "Connection prematurely closed BEFORE response" | null | null | 2021-11-30 11:14:01+00:00 | 2021-12-02 16:08:45+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]
[[faq.logging-prefix]]
== ... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | violetagg | 01b9348724bd23ea69d0dd09bce2a164a5fe9272 | 667cbf84d70f735055ea849713496fab2bb559e9 | There are two related ideas here. I would write it as two sentences:
In most cases, the client might not send directly to the server. Instead, there might be other network components (proxies, load balancers, and so on) between them. | Buzzardo | 260 |
reactor/reactor-netty | 1,905 | [documentation] How to debug "Connection prematurely closed BEFORE response" | null | null | 2021-11-30 11:14:01+00:00 | 2021-12-02 16:08:45+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]
[[faq.logging-prefix]]
== ... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | violetagg | 01b9348724bd23ea69d0dd09bce2a164a5fe9272 | 667cbf84d70f735055ea849713496fab2bb559e9 | Change to:
If, on the client side, you observe `Connection prematurely closed BEFORE response`, perform the following checks to identify the reason for the connection being closed: | Buzzardo | 261 |
reactor/reactor-netty | 1,905 | [documentation] How to debug "Connection prematurely closed BEFORE response" | null | null | 2021-11-30 11:14:01+00:00 | 2021-12-02 16:08:45+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]
[[faq.logging-prefix]]
== ... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | violetagg | 01b9348724bd23ea69d0dd09bce2a164a5fe9272 | 667cbf84d70f735055ea849713496fab2bb559e9 | Change to:
* Obtain a https://en.wikipedia.org/wiki/Tcpdump[TCP dump] and check which peer sends a `FIN`/`RST` signal. | Buzzardo | 262 |
reactor/reactor-netty | 1,905 | [documentation] How to debug "Connection prematurely closed BEFORE response" | null | null | 2021-11-30 11:14:01+00:00 | 2021-12-02 16:08:45+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]
[[faq.logging-prefix]]
== ... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | violetagg | 01b9348724bd23ea69d0dd09bce2a164a5fe9272 | 667cbf84d70f735055ea849713496fab2bb559e9 | Add a period at the end. (Because each of these is a complete sentence, they require periods. One of the items having multiple sentences also forces the others to be sentences and have periods.) | Buzzardo | 263 |
reactor/reactor-netty | 1,905 | [documentation] How to debug "Connection prematurely closed BEFORE response" | null | null | 2021-11-30 11:14:01+00:00 | 2021-12-02 16:08:45+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]
[[faq.logging-prefix]]
== ... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | violetagg | 01b9348724bd23ea69d0dd09bce2a164a5fe9272 | 667cbf84d70f735055ea849713496fab2bb559e9 | Change to:
* Check your Firewall and VPN. | Buzzardo | 264 |
reactor/reactor-netty | 1,905 | [documentation] How to debug "Connection prematurely closed BEFORE response" | null | null | 2021-11-30 11:14:01+00:00 | 2021-12-02 16:08:45+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]
[[faq.logging-prefix]]
== ... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | violetagg | 01b9348724bd23ea69d0dd09bce2a164a5fe9272 | 667cbf84d70f735055ea849713496fab2bb559e9 | Move the question mark to being last (after the parenthetical content). | Buzzardo | 265 |
reactor/reactor-netty | 1,905 | [documentation] How to debug "Connection prematurely closed BEFORE response" | null | null | 2021-11-30 11:14:01+00:00 | 2021-12-02 16:08:45+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]
[[faq.logging-prefix]]
== ... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | violetagg | 01b9348724bd23ea69d0dd09bce2a164a5fe9272 | 667cbf84d70f735055ea849713496fab2bb559e9 | Change to:
Check the target server. Are there configurations related to any of the following? | Buzzardo | 266 |
reactor/reactor-netty | 1,905 | [documentation] How to debug "Connection prematurely closed BEFORE response" | null | null | 2021-11-30 11:14:01+00:00 | 2021-12-02 16:08:45+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]
[[faq.logging-prefix]]
== ... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | violetagg | 01b9348724bd23ea69d0dd09bce2a164a5fe9272 | 667cbf84d70f735055ea849713496fab2bb559e9 | Add "that are" between "options" and "available". | Buzzardo | 267 |
reactor/reactor-netty | 1,904 | [documentation] How to debug memory leaks | null | null | 2021-11-30 09:27:51+00:00 | 2021-12-03 09:52:08+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | violetagg | 315cd27a86ddc4d4c9c47a2e2ad1fda0b06ebb79 | 79adb3a40a02d4102e6ff4e50b977dc420180f18 | Remove "a" from "a direct memory". | Buzzardo | 268 |
reactor/reactor-netty | 1,904 | [documentation] How to debug memory leaks | null | null | 2021-11-30 09:27:51+00:00 | 2021-12-03 09:52:08+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | violetagg | 315cd27a86ddc4d4c9c47a2e2ad1fda0b06ebb79 | 79adb3a40a02d4102e6ff4e50b977dc420180f18 | Add a comma after "(working with sockets)". | Buzzardo | 269 |
reactor/reactor-netty | 1,904 | [documentation] How to debug memory leaks | null | null | 2021-11-30 09:27:51+00:00 | 2021-12-03 09:52:08+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | violetagg | 315cd27a86ddc4d4c9c47a2e2ad1fda0b06ebb79 | 79adb3a40a02d4102e6ff4e50b977dc420180f18 | Change the commas around "used in Reactor Netty by default" to parentheses. While technically correct, with other commas nearby, it is hard to parse. Replacing those two commas with parentheses will clarify the sentence. | Buzzardo | 270 |
reactor/reactor-netty | 1,904 | [documentation] How to debug memory leaks | null | null | 2021-11-30 09:27:51+00:00 | 2021-12-03 09:52:08+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | violetagg | 315cd27a86ddc4d4c9c47a2e2ad1fda0b06ebb79 | 79adb3a40a02d4102e6ff4e50b977dc420180f18 | Add a comma after "information". | Buzzardo | 271 |
reactor/reactor-netty | 1,904 | [documentation] How to debug memory leaks | null | null | 2021-11-30 09:27:51+00:00 | 2021-12-03 09:52:08+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | violetagg | 315cd27a86ddc4d4c9c47a2e2ad1fda0b06ebb79 | 79adb3a40a02d4102e6ff4e50b977dc420180f18 | Remove "In order". This is a general rule. It is nearly always unnecessary. | Buzzardo | 272 |
reactor/reactor-netty | 1,904 | [documentation] How to debug memory leaks | null | null | 2021-11-30 09:27:51+00:00 | 2021-12-03 09:52:08+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | violetagg | 315cd27a86ddc4d4c9c47a2e2ad1fda0b06ebb79 | 79adb3a40a02d4102e6ff4e50b977dc420180f18 | Add "for" between "instructions" and the link. | Buzzardo | 273 |
reactor/reactor-netty | 1,904 | [documentation] How to debug memory leaks | null | null | 2021-11-30 09:27:51+00:00 | 2021-12-03 09:52:08+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | violetagg | 315cd27a86ddc4d4c9c47a2e2ad1fda0b06ebb79 | 79adb3a40a02d4102e6ff4e50b977dc420180f18 | Remove "in order". | Buzzardo | 274 |
reactor/reactor-netty | 1,904 | [documentation] How to debug memory leaks | null | null | 2021-11-30 09:27:51+00:00 | 2021-12-03 09:52:08+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | violetagg | 315cd27a86ddc4d4c9c47a2e2ad1fda0b06ebb79 | 79adb3a40a02d4102e6ff4e50b977dc420180f18 | Add parentheses around `_reactor.netty.channel.LeakDetection`. | Buzzardo | 275 |
reactor/reactor-netty | 1,904 | [documentation] How to debug memory leaks | null | null | 2021-11-30 09:27:51+00:00 | 2021-12-03 09:52:08+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | violetagg | 315cd27a86ddc4d4c9c47a2e2ad1fda0b06ebb79 | 79adb3a40a02d4102e6ff4e50b977dc420180f18 | Change to
By default, this logger is disabled. To enable it, increase the log level to `DEBUG`. | Buzzardo | 276 |
reactor/reactor-netty | 1,904 | [documentation] How to debug memory leaks | null | null | 2021-11-30 09:27:51+00:00 | 2021-12-03 09:52:08+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | violetagg | 315cd27a86ddc4d4c9c47a2e2ad1fda0b06ebb79 | 79adb3a40a02d4102e6ff4e50b977dc420180f18 | I would actually suggest to turn this sentence to:
```suggestion
As allocation and deallocation are expensive operations, Reactor Netty also uses pooled buffers by default.
``` | simonbasle | 277 |
reactor/reactor-netty | 1,904 | [documentation] How to debug memory leaks | null | null | 2021-11-30 09:27:51+00:00 | 2021-12-03 09:52:08+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | violetagg | 315cd27a86ddc4d4c9c47a2e2ad1fda0b06ebb79 | 79adb3a40a02d4102e6ff4e50b977dc420180f18 | In addition I think it worth to mention the reducing memory: the lesser memory application has the sooner memory leak will produce an exception.
Some time ago I used
```
-Djdk.nio.maxCachedBufferSize
-XX:MaxDirectMemorySize
-Xms32m
-Xmx32m
```
for it when debugged gateway.
Also there is an article https:/... | nkonev | 278 |
reactor/reactor-netty | 1,904 | [documentation] How to debug memory leaks | null | null | 2021-11-30 09:27:51+00:00 | 2021-12-03 09:52:08+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]... | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
* <<faq.memory-leaks>>
* <<faq.connection-closed>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[ta... | violetagg | 315cd27a86ddc4d4c9c47a2e2ad1fda0b06ebb79 | 79adb3a40a02d4102e6ff4e50b977dc420180f18 | @reactor/netty-team @nkonev I added a note for reducing the used memory. Please check. | violetagg | 279 |
reactor/reactor-netty | 1,903 | [documentation] Add information for the prefix that is added to every log record | null | null | 2021-11-29 13:10:07+00:00 | 2021-11-29 16:47:38+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]
| [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]
[[faq.logging-prefix]]
== ... | violetagg | f5519eee0b606aad3cab711612583970e0036ecd | 5952c15a94b2f67c21c71d96c61042efdb2a48cc | nitpick but I'd put that in the same order as it appears in the log line, ie. before REMOTE_ADDRESS line 33.
same for the other "format" sections (HTTP1, HTTP2...) below | simonbasle | 280 |
reactor/reactor-netty | 1,903 | [documentation] Add information for the prefix that is added to every log record | null | null | 2021-11-29 13:10:07+00:00 | 2021-11-29 16:47:38+00:00 | docs/asciidoc/faq.adoc | [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]
| [[faq]]
= Frequently Asked Questions
This section covers the following content:
* <<faq.proxy-connect-method>>
* <<faq.logging-prefix>>
* <<faq.logging-correlation>>
[[faq.proxy-connect-method]]
== Connection to the proxy cannot be established
include::proxy.adoc[tag=proxy-connect-method]
[[faq.logging-prefix]]
== ... | violetagg | f5519eee0b606aad3cab711612583970e0036ecd | 5952c15a94b2f67c21c71d96c61042efdb2a48cc | I fixed that, please check now | violetagg | 281 |
reactor/reactor-netty | 1,898 | [documentation] How to debug connection to proxy cannot be established | null | null | 2021-11-26 08:26:37+00:00 | 2021-11-26 15:06:12+00:00 | docs/asciidoc/index.asciidoc | = Reactor Netty Reference Guide
Stephane Maldini <https://twitter.com/smaldini[@smaldini]>; Violeta Georgieva <https://twitter.com/violeta_g_g[@violeta_g_g]>
ifndef::host-github[:ext-relative: {outfilesuffix}]
:doctype: book
:icons: font
:toc2:
:sectnums:
:sectanchors:
include::about-doc.adoc[leveloffset=1]
ifeval::["... | = Reactor Netty Reference Guide
Stephane Maldini <https://twitter.com/smaldini[@smaldini]>; Violeta Georgieva <https://twitter.com/violeta_g_g[@violeta_g_g]>
ifndef::host-github[:ext-relative: {outfilesuffix}]
:doctype: book
:icons: font
:toc2:
:sectnums:
:sectanchors:
include::about-doc.adoc[leveloffset=1]
ifeval::["... | violetagg | 568ab981309122ae8ee9348e9baf1e74fe664b93 | 0dbd2889adc209ad5128092b57fb934bdbc6781a | shouldn't the appendix/faq be linked first and foremost at the end of `index.adoc`?
a link or include of the `<<faq.proxy-connect-method>>` entry can then be included in both `udp-client.adoc` and `tcp-client.adoc` | simonbasle | 282 |
reactor/reactor-netty | 1,898 | [documentation] How to debug connection to proxy cannot be established | null | null | 2021-11-26 08:26:37+00:00 | 2021-11-26 15:06:12+00:00 | docs/asciidoc/index.asciidoc | = Reactor Netty Reference Guide
Stephane Maldini <https://twitter.com/smaldini[@smaldini]>; Violeta Georgieva <https://twitter.com/violeta_g_g[@violeta_g_g]>
ifndef::host-github[:ext-relative: {outfilesuffix}]
:doctype: book
:icons: font
:toc2:
:sectnums:
:sectanchors:
include::about-doc.adoc[leveloffset=1]
ifeval::["... | = Reactor Netty Reference Guide
Stephane Maldini <https://twitter.com/smaldini[@smaldini]>; Violeta Georgieva <https://twitter.com/violeta_g_g[@violeta_g_g]>
ifndef::host-github[:ext-relative: {outfilesuffix}]
:doctype: book
:icons: font
:toc2:
:sectnums:
:sectanchors:
include::about-doc.adoc[leveloffset=1]
ifeval::["... | violetagg | 568ab981309122ae8ee9348e9baf1e74fe664b93 | 0dbd2889adc209ad5128092b57fb934bdbc6781a | > shouldn't the appendix/faq be linked first and foremost at the end of index.adoc?
Reactor Netty has only `index.asciidoc`, it doesn't have `index.adoc`. I don't understand.
> a link or include of the <<faq.proxy-connect-method>> entry can then be included in both udp-client.adoc
There is no section for proxy... | violetagg | 283 |
reactor/reactor-netty | 1,898 | [documentation] How to debug connection to proxy cannot be established | null | null | 2021-11-26 08:26:37+00:00 | 2021-11-26 15:06:12+00:00 | docs/asciidoc/index.asciidoc | = Reactor Netty Reference Guide
Stephane Maldini <https://twitter.com/smaldini[@smaldini]>; Violeta Georgieva <https://twitter.com/violeta_g_g[@violeta_g_g]>
ifndef::host-github[:ext-relative: {outfilesuffix}]
:doctype: book
:icons: font
:toc2:
:sectnums:
:sectanchors:
include::about-doc.adoc[leveloffset=1]
ifeval::["... | = Reactor Netty Reference Guide
Stephane Maldini <https://twitter.com/smaldini[@smaldini]>; Violeta Georgieva <https://twitter.com/violeta_g_g[@violeta_g_g]>
ifndef::host-github[:ext-relative: {outfilesuffix}]
:doctype: book
:icons: font
:toc2:
:sectnums:
:sectanchors:
include::about-doc.adoc[leveloffset=1]
ifeval::["... | violetagg | 568ab981309122ae8ee9348e9baf1e74fe664b93 | 0dbd2889adc209ad5128092b57fb934bdbc6781a | ah my bad, I misread the diff and thought that the below was the edited file 🤦
```
@@ -55,3 +55,10 @@ https://github.com/reactor/reactor-netty/edit/main/docs/asciidoc/udp-client.adoc
``` | simonbasle | 284 |
reactor/reactor-netty | 1,898 | [documentation] How to debug connection to proxy cannot be established | null | null | 2021-11-26 08:26:37+00:00 | 2021-11-26 15:06:12+00:00 | docs/asciidoc/tcp-client.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/release/api
:nettyjavadoc: https://netty.io/4.1/api
[[tcp-client]]
= TCP Client
Reactor Netty provides the easy... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/release/api
:nettyjavadoc: https://netty.io/4.1/api
[[tcp-client]]
= TCP Client
Reactor Netty provides the easy... | violetagg | 568ab981309122ae8ee9348e9baf1e74fe664b93 | 0dbd2889adc209ad5128092b57fb934bdbc6781a | unless I missed something this is a copy-paste of the faq entry. consider linking to the faq entry or using a [tagged region](https://docs.asciidoctor.org/asciidoc/latest/directives/include-tagged-regions/) to directly import the relevant part(s) from the `faq.adoc` source | simonbasle | 285 |
reactor/reactor-netty | 1,898 | [documentation] How to debug connection to proxy cannot be established | null | null | 2021-11-26 08:26:37+00:00 | 2021-11-26 15:06:12+00:00 | docs/asciidoc/tcp-client.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/release/api
:nettyjavadoc: https://netty.io/4.1/api
[[tcp-client]]
= TCP Client
Reactor Netty provides the easy... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/release/api
:nettyjavadoc: https://netty.io/4.1/api
[[tcp-client]]
= TCP Client
Reactor Netty provides the easy... | violetagg | 568ab981309122ae8ee9348e9baf1e74fe664b93 | 0dbd2889adc209ad5128092b57fb934bdbc6781a | ok
| violetagg | 286 |
reactor/reactor-netty | 1,897 | #1872: Implement additional metrics from reactor-pool | Please review this PR, which adds two methods in the ConnectionPoolMetrics interface:
The added methods (maxAllocatedSize, and maxPendingAcquireSize) simply expose the delegated methods from the original InstrumentedPool.PoolMetrics. This will most likely resolve the #1872 issue.
| null | 2021-11-25 18:19:36+00:00 | 2021-11-30 09:50:39+00:00 | reactor-netty-core/src/main/java/reactor/netty/resources/ConnectionPoolMetrics.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 5952c15a94b2f67c21c71d96c61042efdb2a48cc | 8849b54d0e7ac45dac4417b829c35fb26e839a39 | nit:
```suggestion
* A Pool might be unbounded, in which case this method returns {@code Integer.MAX_VALUE}.
``` | violetagg | 287 |
reactor/reactor-netty | 1,897 | #1872: Implement additional metrics from reactor-pool | Please review this PR, which adds two methods in the ConnectionPoolMetrics interface:
The added methods (maxAllocatedSize, and maxPendingAcquireSize) simply expose the delegated methods from the original InstrumentedPool.PoolMetrics. This will most likely resolve the #1872 issue.
| null | 2021-11-25 18:19:36+00:00 | 2021-11-30 09:50:39+00:00 | reactor-netty-core/src/main/java/reactor/netty/resources/ConnectionPoolMetrics.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 5952c15a94b2f67c21c71d96c61042efdb2a48cc | 8849b54d0e7ac45dac4417b829c35fb26e839a39 | Add `@since 1.0.14`
When a functionality is added after GA, we explicitly indicate in which version this functionality is added. | violetagg | 288 |
reactor/reactor-netty | 1,897 | #1872: Implement additional metrics from reactor-pool | Please review this PR, which adds two methods in the ConnectionPoolMetrics interface:
The added methods (maxAllocatedSize, and maxPendingAcquireSize) simply expose the delegated methods from the original InstrumentedPool.PoolMetrics. This will most likely resolve the #1872 issue.
| null | 2021-11-25 18:19:36+00:00 | 2021-11-30 09:50:39+00:00 | reactor-netty-core/src/main/java/reactor/netty/resources/ConnectionPoolMetrics.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 5952c15a94b2f67c21c71d96c61042efdb2a48cc | 8849b54d0e7ac45dac4417b829c35fb26e839a39 | nit:
```suggestion
* Get the maximum number of {@code Pool.acquire()} this Pool can queue in a pending state
``` | violetagg | 289 |
reactor/reactor-netty | 1,897 | #1872: Implement additional metrics from reactor-pool | Please review this PR, which adds two methods in the ConnectionPoolMetrics interface:
The added methods (maxAllocatedSize, and maxPendingAcquireSize) simply expose the delegated methods from the original InstrumentedPool.PoolMetrics. This will most likely resolve the #1872 issue.
| null | 2021-11-25 18:19:36+00:00 | 2021-11-30 09:50:39+00:00 | reactor-netty-core/src/main/java/reactor/netty/resources/ConnectionPoolMetrics.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 5952c15a94b2f67c21c71d96c61042efdb2a48cc | 8849b54d0e7ac45dac4417b829c35fb26e839a39 | nit:
```suggestion
* {@code Integer.MAX_VALUE}.
``` | violetagg | 290 |
reactor/reactor-netty | 1,897 | #1872: Implement additional metrics from reactor-pool | Please review this PR, which adds two methods in the ConnectionPoolMetrics interface:
The added methods (maxAllocatedSize, and maxPendingAcquireSize) simply expose the delegated methods from the original InstrumentedPool.PoolMetrics. This will most likely resolve the #1872 issue.
| null | 2021-11-25 18:19:36+00:00 | 2021-11-30 09:50:39+00:00 | reactor-netty-core/src/main/java/reactor/netty/resources/ConnectionPoolMetrics.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 5952c15a94b2f67c21c71d96c61042efdb2a48cc | 8849b54d0e7ac45dac4417b829c35fb26e839a39 | Add `@since 1.0.14` | violetagg | 291 |
reactor/reactor-netty | 1,893 | Add support for Macos M1 architecture | As discussed this morning, please review this PR for adding support for macos M1 arch (osx-aarch_64).
thanks. | null | 2021-11-23 20:05:45+00:00 | 2021-11-25 13:37:17+00:00 | reactor-netty-core/build.gradle | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 16192800e177092d44cca342c256d45d9250fd10 | 568ab981309122ae8ee9348e9baf1e74fe664b93 | I wonder if that is still relevant if we cannot detect any `osx-*` from `osdetector` ?
ie should we default to pure `$nettyVersion` in that case ? | simonbasle | 292 |
reactor/reactor-netty | 1,893 | Add support for Macos M1 architecture | As discussed this morning, please review this PR for adding support for macos M1 arch (osx-aarch_64).
thanks. | null | 2021-11-23 20:05:45+00:00 | 2021-11-25 13:37:17+00:00 | reactor-netty-core/build.gradle | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 16192800e177092d44cca342c256d45d9250fd10 | 568ab981309122ae8ee9348e9baf1e74fe664b93 | @simonbasle Having the comment below, do we still need to address this? | violetagg | 293 |
reactor/reactor-netty | 1,893 | Add support for Macos M1 architecture | As discussed this morning, please review this PR for adding support for macos M1 arch (osx-aarch_64).
thanks. | null | 2021-11-23 20:05:45+00:00 | 2021-11-25 13:37:17+00:00 | reactor-netty-core/build.gradle | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 16192800e177092d44cca342c256d45d9250fd10 | 568ab981309122ae8ee9348e9baf1e74fe664b93 | no, sorry, I answered as a main comment instead of resolving this conversion. go for merge. | simonbasle | 294 |
reactor/reactor-netty | 1,893 | Add support for Macos M1 architecture | As discussed this morning, please review this PR for adding support for macos M1 arch (osx-aarch_64).
thanks. | null | 2021-11-23 20:05:45+00:00 | 2021-11-25 13:37:17+00:00 | reactor-netty-http/build.gradle | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | pderop | 16192800e177092d44cca342c256d45d9250fd10 | 568ab981309122ae8ee9348e9baf1e74fe664b93 | same question as above | simonbasle | 295 |
reactor/reactor-netty | 1,867 | Add API for specifying maximum number of keep-alive requests | Fixes #1865 | null | 2021-10-28 14:19:23+00:00 | 2021-10-29 09:18:39+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServer.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 345a8d3d5861f48f4015be525ee6c30e17d0413c | 45190a1c0697bc91d6ef928196ec42e032263727 | Can you double check the generated javadoc? I think it requires `>` kind of escaping | simonbasle | 296 |
reactor/reactor-netty | 1,867 | Add API for specifying maximum number of keep-alive requests | Fixes #1865 | null | 2021-10-28 14:19:23+00:00 | 2021-10-29 09:18:39+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServer.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 345a8d3d5861f48f4015be525ee6c30e17d0413c | 45190a1c0697bc91d6ef928196ec42e032263727 | fixed | violetagg | 297 |
reactor/reactor-netty | 1,867 | Add API for specifying maximum number of keep-alive requests | Fixes #1865 | null | 2021-10-28 14:19:23+00:00 | 2021-10-29 09:18:39+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerConfig.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 345a8d3d5861f48f4015be525ee6c30e17d0413c | 45190a1c0697bc91d6ef928196ec42e032263727 | Typo: configured | simonbasle | 298 |
reactor/reactor-netty | 1,867 | Add API for specifying maximum number of keep-alive requests | Fixes #1865 | null | 2021-10-28 14:19:23+00:00 | 2021-10-29 09:18:39+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerConfig.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 345a8d3d5861f48f4015be525ee6c30e17d0413c | 45190a1c0697bc91d6ef928196ec42e032263727 | fixed | violetagg | 299 |
reactor/reactor-netty | 1,867 | Add API for specifying maximum number of keep-alive requests | Fixes #1865 | null | 2021-10-28 14:19:23+00:00 | 2021-10-29 09:18:39+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerOperations.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 345a8d3d5861f48f4015be525ee6c30e17d0413c | 45190a1c0697bc91d6ef928196ec42e032263727 | Can you clarify this line?
It's not clear to me how the connection itself represents an AtomicLong that tracks the number of requests. Where is this incremented for each request? | philsttr | 300 |
reactor/reactor-netty | 1,867 | Add API for specifying maximum number of keep-alive requests | Fixes #1865 | null | 2021-10-28 14:19:23+00:00 | 2021-10-29 09:18:39+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerOperations.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 345a8d3d5861f48f4015be525ee6c30e17d0413c | 45190a1c0697bc91d6ef928196ec42e032263727 | We already track the number of the requests because we need to construct a unique request id. In addition to the unique request id, we add to the logs this information.
See these change #1530
On the server the `Connection` is https://github.com/reactor/reactor-netty/blob/345a8d3d5861f48f4015be525ee6c30e17d0413c/r... | violetagg | 301 |
reactor/reactor-netty | 1,867 | Add API for specifying maximum number of keep-alive requests | Fixes #1865 | null | 2021-10-28 14:19:23+00:00 | 2021-10-29 09:18:39+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerOperations.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 345a8d3d5861f48f4015be525ee6c30e17d0413c | 45190a1c0697bc91d6ef928196ec42e032263727 | 👍 Got it. Thanks for the clarification. | philsttr | 302 |
reactor/reactor-netty | 1,867 | Add API for specifying maximum number of keep-alive requests | Fixes #1865 | null | 2021-10-28 14:19:23+00:00 | 2021-10-29 09:18:39+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpTrafficHandler.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 345a8d3d5861f48f4015be525ee6c30e17d0413c | 45190a1c0697bc91d6ef928196ec42e032263727 | I'd suggest adding a check for `-1` here, since `requestsCounter` can potentially return -1. The connection should never be closed here if `maxKeepAliveRequests == -1`
```suggestion
boolean maxKeepAliveRequestsReached = maxKeepAliveRequests != -1 && HttpServerOperations.requestsCounter(ctx.channel()) == maxKeep... | philsttr | 303 |
reactor/reactor-netty | 1,860 | Polish test logging | This PR polishes test logging by:
- applying the `testLogging` config on ALL tasks of type `Test` rather than
just the base `test` task
- excluding log lines that simply reflect Netty's configuration when attempting
to highlight `ResourceLeakDetector` errors | null | 2021-10-19 09:10:47+00:00 | 2021-10-21 11:17:55+00:00 | build.gradle | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | simonbasle | 7ba5f68e22b25fc2c95b88ea2644103ce6b3bf67 | 2eac401bb8c5f83cdd1b49f761c27f8da2b4b462 | Why don't we apply this also for all `Tests` | violetagg | 304 |
reactor/reactor-netty | 1,860 | Polish test logging | This PR polishes test logging by:
- applying the `testLogging` config on ALL tasks of type `Test` rather than
just the base `test` task
- excluding log lines that simply reflect Netty's configuration when attempting
to highlight `ResourceLeakDetector` errors | null | 2021-10-19 09:10:47+00:00 | 2021-10-21 11:17:55+00:00 | build.gradle | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | simonbasle | 7ba5f68e22b25fc2c95b88ea2644103ce6b3bf67 | 2eac401bb8c5f83cdd1b49f761c27f8da2b4b462 | my bad, reverted that when I tried to split the commits | simonbasle | 305 |
reactor/reactor-netty | 1,850 | Add NoMicrometer testSet for HttpClient | Minimum coverage of channel init issue without micrometer
This commit attempts at covering the channel initialization issue when
metrics recorders are registered during configuration but Micrometer is
not on the classpath.
The NoClassDefFoundError itself is not accessible. It is swallowed by
Netty during channel init... | null | 2021-10-11 14:18:34+00:00 | 2021-10-21 11:16:54+00:00 | reactor-netty-http/build.gradle | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | simonbasle | 30cf3ada602d96130b7d301802cb88e15b4006d0 | 7ba5f68e22b25fc2c95b88ea2644103ce6b3bf67 | Do we need this? In the other submodules we have additional source sets and IntelliJ Idea recognises them without additional instructions. | violetagg | 306 |
reactor/reactor-netty | 1,850 | Add NoMicrometer testSet for HttpClient | Minimum coverage of channel init issue without micrometer
This commit attempts at covering the channel initialization issue when
metrics recorders are registered during configuration but Micrometer is
not on the classpath.
The NoClassDefFoundError itself is not accessible. It is swallowed by
Netty during channel init... | null | 2021-10-11 14:18:34+00:00 | 2021-10-21 11:16:54+00:00 | reactor-netty-http/build.gradle | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | simonbasle | 30cf3ada602d96130b7d301802cb88e15b4006d0 | 7ba5f68e22b25fc2c95b88ea2644103ce6b3bf67 | somehow IDEA kept adding the directory as a main source directory rather than a test source directory, and I wouldn't get access to base test dependencies (IIRC JUnit annotations didn't compile) due to that. | simonbasle | 307 |
reactor/reactor-netty | 1,850 | Add NoMicrometer testSet for HttpClient | Minimum coverage of channel init issue without micrometer
This commit attempts at covering the channel initialization issue when
metrics recorders are registered during configuration but Micrometer is
not on the classpath.
The NoClassDefFoundError itself is not accessible. It is swallowed by
Netty during channel init... | null | 2021-10-11 14:18:34+00:00 | 2021-10-21 11:16:54+00:00 | reactor-netty-http/build.gradle | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | simonbasle | 30cf3ada602d96130b7d301802cb88e15b4006d0 | 7ba5f68e22b25fc2c95b88ea2644103ce6b3bf67 | yeah we specify which dependencies we want for every source set - see here https://github.com/reactor/reactor-netty/blob/30cf3ada602d96130b7d301802cb88e15b4006d0/reactor-netty-core/build.gradle#L131-L133
We want to be very concrete about dependencies because we don't want to have some transitive dependencies that wi... | violetagg | 308 |
reactor/reactor-netty | 1,850 | Add NoMicrometer testSet for HttpClient | Minimum coverage of channel init issue without micrometer
This commit attempts at covering the channel initialization issue when
metrics recorders are registered during configuration but Micrometer is
not on the classpath.
The NoClassDefFoundError itself is not accessible. It is swallowed by
Netty during channel init... | null | 2021-10-11 14:18:34+00:00 | 2021-10-21 11:16:54+00:00 | reactor-netty-http/build.gradle | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | simonbasle | 30cf3ada602d96130b7d301802cb88e15b4006d0 | 7ba5f68e22b25fc2c95b88ea2644103ce6b3bf67 | ok, yeah I guess this is a different approach that doesn't need `testSet` plugin.
for the record, here is what I have in IntelliJ. For the build it doesn't really matter, but I guess it _could_ confuse some features of the IDE (like "search in production files" for instance 🤔)
 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | simonbasle | 30cf3ada602d96130b7d301802cb88e15b4006d0 | 7ba5f68e22b25fc2c95b88ea2644103ce6b3bf67 | Do we need this? It is needed only when we run with BlockHound. | violetagg | 310 |
reactor/reactor-netty | 1,850 | Add NoMicrometer testSet for HttpClient | Minimum coverage of channel init issue without micrometer
This commit attempts at covering the channel initialization issue when
metrics recorders are registered during configuration but Micrometer is
not on the classpath.
The NoClassDefFoundError itself is not accessible. It is swallowed by
Netty during channel init... | null | 2021-10-11 14:18:34+00:00 | 2021-10-21 11:16:54+00:00 | reactor-netty-http/build.gradle | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | simonbasle | 30cf3ada602d96130b7d301802cb88e15b4006d0 | 7ba5f68e22b25fc2c95b88ea2644103ce6b3bf67 | Why do we need this? | violetagg | 311 |
reactor/reactor-netty | 1,842 | Support graceful shutdown for the ConnectionProvider | null | null | 2021-10-06 12:59:42+00:00 | 2021-10-06 16:34:50+00:00 | reactor-netty-core/src/main/java/reactor/netty/resources/PooledConnectionProvider.java | /*
* Copyright (c) 2018-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2018-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 9cb4c847217cbbbd7f4f0132baf783db8ae95cf6 | 3f9279ecb3e186770f122f4e024b0af3b6576a6e | maybe we want to `onErrorResume` this, since unlike `pool.disposeLater()` the graceful shutdown can "fail" (it just notifies that the resources were not all `released()` within the provided `Duration`, but does so after having actually shut down the pool anyway). | simonbasle | 312 |
reactor/reactor-netty | 1,842 | Support graceful shutdown for the ConnectionProvider | null | null | 2021-10-06 12:59:42+00:00 | 2021-10-06 16:34:50+00:00 | reactor-netty-core/src/main/java/reactor/netty/resources/PooledConnectionProvider.java | /*
* Copyright (c) 2018-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2018-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 9cb4c847217cbbbd7f4f0132baf783db8ae95cf6 | 3f9279ecb3e186770f122f4e024b0af3b6576a6e | please check the new commit | violetagg | 313 |
reactor/reactor-netty | 1,842 | Support graceful shutdown for the ConnectionProvider | null | null | 2021-10-06 12:59:42+00:00 | 2021-10-06 16:34:50+00:00 | reactor-netty-core/src/main/java/reactor/netty/resources/PooledConnectionProvider.java | /*
* Copyright (c) 2018-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2018-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 9cb4c847217cbbbd7f4f0132baf783db8ae95cf6 | 3f9279ecb3e186770f122f4e024b0af3b6576a6e | you might want to just log the fact that the pool didn't shut down gracefully within the grace period, up to you.
note that acquire `Mono`s that are still _pending_ at this point will terminate with an `onError` anyway.
what doesn't get notified is already acquired `Mono` for which the pool awaits a `release()`. ... | simonbasle | 314 |
reactor/reactor-netty | 1,842 | Support graceful shutdown for the ConnectionProvider | null | null | 2021-10-06 12:59:42+00:00 | 2021-10-06 16:34:50+00:00 | reactor-netty-core/src/main/java/reactor/netty/resources/PooledConnectionProvider.java | /*
* Copyright (c) 2018-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2018-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 9cb4c847217cbbbd7f4f0132baf783db8ae95cf6 | 3f9279ecb3e186770f122f4e024b0af3b6576a6e | Please check the new commit, I added logging, but I needed one small change there in order to be able to do that. | violetagg | 315 |
reactor/reactor-netty | 1,841 | Support sending trailer headers on the server and receiving such on the client | Fixes #1837 | null | 2021-10-05 17:32:40+00:00 | 2021-10-06 16:37:58+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerOperations.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 3f9279ecb3e186770f122f4e024b0af3b6576a6e | 8ad9eedfd9f40f3bf7aef6cbdbd4ef03e7860dc7 | there are two cases where any `Consumer` defined by the user simply gets silently ignored: `isTransferEncodingChunked` is false or `declaredHeaderNames == null`.
should these cases be documented in the javadoc? or should they lead to an exception? (especially if a `Consumer<TrailerHeaders>` is provided in the setup ... | simonbasle | 316 |
reactor/reactor-netty | 1,841 | Support sending trailer headers on the server and receiving such on the client | Fixes #1837 | null | 2021-10-05 17:32:40+00:00 | 2021-10-06 16:37:58+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerOperations.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | 3f9279ecb3e186770f122f4e024b0af3b6576a6e | 8ad9eedfd9f40f3bf7aef6cbdbd4ef03e7860dc7 | Please check it now, I added additional comments and javadoc | violetagg | 317 |
reactor/reactor-netty | 1,830 | Add handling for QUIC channel id | QUIC channel id is prepended with trace id
`(0d764edf1d7fbf6651fdedc08ed44c69efbaeee1)[id: 5dc8071b] Created a new QUIC channel` | null | 2021-09-29 11:00:12+00:00 | 2021-10-04 13:49:33+00:00 | reactor-netty-core/src/main/java/reactor/netty/ReactorNetty.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | c640bb3e93886ca0c838cf65efdf526a5a1d67ad | 3279d7e531d1c1e8c6c12aaf0ed9085c936d10b3 | should that part be made fool-proof against the `channelStr` not containing the `ORIGINAL_CHANNEL_ID_PREFIX` at all?
in any case, the code can be simplified to:
```java
channelStr = channel.toString();
int ind = channelStr.indexOf(ORIGINAL_CHANNEL_ID_PREFIX);
if (ind > -1) {
result = new StringBuilder(1 + (c... | simonbasle | 318 |
reactor/reactor-netty | 1,830 | Add handling for QUIC channel id | QUIC channel id is prepended with trace id
`(0d764edf1d7fbf6651fdedc08ed44c69efbaeee1)[id: 5dc8071b] Created a new QUIC channel` | null | 2021-09-29 11:00:12+00:00 | 2021-10-04 13:49:33+00:00 | reactor-netty-core/src/main/java/reactor/netty/ReactorNetty.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | c640bb3e93886ca0c838cf65efdf526a5a1d67ad | 3279d7e531d1c1e8c6c12aaf0ed9085c936d10b3 | overall the logic is starting to get a little difficult to follow, and would benefit from some comments explaining in which conditions we get to each branch of the if(if/else)/else(if/else) | simonbasle | 319 |
reactor/reactor-netty | 1,830 | Add handling for QUIC channel id | QUIC channel id is prepended with trace id
`(0d764edf1d7fbf6651fdedc08ed44c69efbaeee1)[id: 5dc8071b] Created a new QUIC channel` | null | 2021-09-29 11:00:12+00:00 | 2021-10-04 13:49:33+00:00 | reactor-netty-core/src/main/java/reactor/netty/ReactorNetty.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | c640bb3e93886ca0c838cf65efdf526a5a1d67ad | 3279d7e531d1c1e8c6c12aaf0ed9085c936d10b3 | some additional test giving examples of all possible combinations would be useful, I think | simonbasle | 320 |
reactor/reactor-netty | 1,830 | Add handling for QUIC channel id | QUIC channel id is prepended with trace id
`(0d764edf1d7fbf6651fdedc08ed44c69efbaeee1)[id: 5dc8071b] Created a new QUIC channel` | null | 2021-09-29 11:00:12+00:00 | 2021-10-04 13:49:33+00:00 | reactor-netty-core/src/main/java/reactor/netty/ReactorNetty.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | c640bb3e93886ca0c838cf65efdf526a5a1d67ad | 3279d7e531d1c1e8c6c12aaf0ed9085c936d10b3 | well it is always non empty and starts with `(` or `[`, but if you want we can add additional checks | violetagg | 321 |
reactor/reactor-netty | 1,830 | Add handling for QUIC channel id | QUIC channel id is prepended with trace id
`(0d764edf1d7fbf6651fdedc08ed44c69efbaeee1)[id: 5dc8071b] Created a new QUIC channel` | null | 2021-09-29 11:00:12+00:00 | 2021-10-04 13:49:33+00:00 | reactor-netty-core/src/main/java/reactor/netty/ReactorNetty.java | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2011-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | c640bb3e93886ca0c838cf65efdf526a5a1d67ad | 3279d7e531d1c1e8c6c12aaf0ed9085c936d10b3 | > if the id prefix is at the beginning of the string, ind == 0 and channelStr.substring(0, 0) is the empty String.
How this can happen you are in the branch where the string starts with something different then `[`?
The case where we know it starts with `[id: ` it is deliberately made with immediate substring in ... | violetagg | 322 |
reactor/reactor-netty | 1,830 | Add handling for QUIC channel id | QUIC channel id is prepended with trace id
`(0d764edf1d7fbf6651fdedc08ed44c69efbaeee1)[id: 5dc8071b] Created a new QUIC channel` | null | 2021-09-29 11:00:12+00:00 | 2021-10-04 13:49:33+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/logging/ReactorNettyLoggingHandler.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | c640bb3e93886ca0c838cf65efdf526a5a1d67ad | 3279d7e531d1c1e8c6c12aaf0ed9085c936d10b3 | same comment as above for this section which can be simplified | simonbasle | 323 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.