repo_name stringlengths 8 38 | pr_number int64 3 47.1k | pr_title stringlengths 8 175 | pr_description stringlengths 2 19.8k ⌀ | author null | date_created stringlengths 25 25 | date_merged stringlengths 25 25 | filepath stringlengths 6 136 | before_content stringlengths 54 884k ⌀ | after_content stringlengths 56 884k | pr_author stringlengths 3 21 | previous_commit stringlengths 40 40 | pr_commit stringlengths 40 40 | comment stringlengths 2 25.4k | comment_author stringlengths 3 29 | __index_level_0__ int64 0 5.1k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
reactor/reactor-netty | 2,792 | `responseContent()` remove excess `ByteBufFlux` conversion | When I looked at the implementation of the class **HttpClientFinalizer** code, I found that the logic of the **responseContent** method was a bit strange. HttpClientFinalizer.contentReceiver represents **ChannelOperations::receive**, while ChannelOperations::receive internal implementation has already made a call to **... | null | 2023-05-03 03:50:45+00:00 | 2023-05-05 06:23:08+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientFinalizer.java | /*
* Copyright (c) 2017-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2017-2023 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | manzhizhen | d76a54ec2fcb18496fd74873769c747c6f7c2160 | 162c11e1d4fcb358ee4c1816e69c102365eb6afd | Then I'll make some adjustments, this does have the least impact. | manzhizhen | 24 |
reactor/reactor-netty | 2,792 | `responseContent()` remove excess `ByteBufFlux` conversion | When I looked at the implementation of the class **HttpClientFinalizer** code, I found that the logic of the **responseContent** method was a bit strange. HttpClientFinalizer.contentReceiver represents **ChannelOperations::receive**, while ChannelOperations::receive internal implementation has already made a call to **... | null | 2023-05-03 03:50:45+00:00 | 2023-05-05 06:23:08+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientFinalizer.java | /*
* Copyright (c) 2017-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2017-2023 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | manzhizhen | d76a54ec2fcb18496fd74873769c747c6f7c2160 | 162c11e1d4fcb358ee4c1816e69c102365eb6afd | @manzhizhen , could you also please revert the change from WebsocketFinalizer ? (because now, there is no more changes done in this file) ? thank you. | pderop | 25 |
reactor/reactor-netty | 2,792 | `responseContent()` remove excess `ByteBufFlux` conversion | When I looked at the implementation of the class **HttpClientFinalizer** code, I found that the logic of the **responseContent** method was a bit strange. HttpClientFinalizer.contentReceiver represents **ChannelOperations::receive**, while ChannelOperations::receive internal implementation has already made a call to **... | null | 2023-05-03 03:50:45+00:00 | 2023-05-05 06:23:08+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientFinalizer.java | /*
* Copyright (c) 2017-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2017-2023 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | manzhizhen | d76a54ec2fcb18496fd74873769c747c6f7c2160 | 162c11e1d4fcb358ee4c1816e69c102365eb6afd | Okay, I'll restore it | manzhizhen | 26 |
reactor/reactor-netty | 2,733 | Enhance usage of `FQDN` in `PoolKey` | The SocketAddres.toString method to generate the FQDN is relatively heavy and it appears to be unnecessary given the socket address is being hashed and equaled already. This should work for unix domain sockets as well.
This code:
````java
System.out.println(AddressUtils.createUnresolved("127.0.0.1", 80));
System.... | null | 2023-03-19 21:14:43+00:00 | 2023-03-27 08:48:26+00:00 | reactor-netty-core/src/main/java/reactor/netty/resources/PooledConnectionProvider.java | /*
* Copyright (c) 2018-2023 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2018-2023 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | yuzawa-san | 0cfc731667737a59c245d01ce6e633bd4c0556ae | cbf9f2d610f3a6ce819ec36be029a237356970de | ```suggestion
// Use FQDN as a tie-breaker over IP's
``` | violetagg | 27 |
reactor/reactor-netty | 2,659 | Allow `HTTP1.1`, `H2`, and `H2C` protocol for `HttpClient` | Currently a client that's configured for HTTP 1.1, H2, and H2C is unable to make requests to both HTTPS and HTTP urls due to checks in HttpClientConnect.java which can be safely ignored as long as a backup protocol is configured.
The following changes are in line with discussion in this PR [#1403](https://github.com... | null | 2023-01-19 06:00:14+00:00 | 2023-01-26 15:51:36+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientConnect.java | /*
* Copyright (c) 2017-2023 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2017-2023 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | alextychan | 168475e35db27e1444134bd9a19d695843e17895 | 9a7b4730bf5c8f528b1fcb6eab61badf90168173 | What do you think about checking once for `_config.checkProtocol(HttpClientConfig.h2c)`? | violetagg | 28 |
reactor/reactor-netty | 2,659 | Allow `HTTP1.1`, `H2`, and `H2C` protocol for `HttpClient` | Currently a client that's configured for HTTP 1.1, H2, and H2C is unable to make requests to both HTTPS and HTTP urls due to checks in HttpClientConnect.java which can be safely ignored as long as a backup protocol is configured.
The following changes are in line with discussion in this PR [#1403](https://github.com... | null | 2023-01-19 06:00:14+00:00 | 2023-01-26 15:51:36+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientConnect.java | /*
* Copyright (c) 2017-2023 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2017-2023 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | alextychan | 168475e35db27e1444134bd9a19d695843e17895 | 9a7b4730bf5c8f528b1fcb6eab61badf90168173 | What do you think about checking once for `_config.checkProtocol(HttpClientConfig.h2)`? | violetagg | 29 |
reactor/reactor-netty | 2,659 | Allow `HTTP1.1`, `H2`, and `H2C` protocol for `HttpClient` | Currently a client that's configured for HTTP 1.1, H2, and H2C is unable to make requests to both HTTPS and HTTP urls due to checks in HttpClientConnect.java which can be safely ignored as long as a backup protocol is configured.
The following changes are in line with discussion in this PR [#1403](https://github.com... | null | 2023-01-19 06:00:14+00:00 | 2023-01-26 15:51:36+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientConnect.java | /*
* Copyright (c) 2017-2023 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2017-2023 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | alextychan | 168475e35db27e1444134bd9a19d695843e17895 | 9a7b4730bf5c8f528b1fcb6eab61badf90168173 | Sounds good. | alextychan | 30 |
reactor/reactor-netty | 2,659 | Allow `HTTP1.1`, `H2`, and `H2C` protocol for `HttpClient` | Currently a client that's configured for HTTP 1.1, H2, and H2C is unable to make requests to both HTTPS and HTTP urls due to checks in HttpClientConnect.java which can be safely ignored as long as a backup protocol is configured.
The following changes are in line with discussion in this PR [#1403](https://github.com... | null | 2023-01-19 06:00:14+00:00 | 2023-01-26 15:51:36+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientConnect.java | /*
* Copyright (c) 2017-2023 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2017-2023 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | alextychan | 168475e35db27e1444134bd9a19d695843e17895 | 9a7b4730bf5c8f528b1fcb6eab61badf90168173 | Sounds good.
| alextychan | 31 |
reactor/reactor-netty | 2,622 | Support configurable DNS resolver cache | - Support user-provided DnsCache for NameResolverProvider | null | 2022-12-22 13:58:06+00:00 | 2023-01-03 07:38:28+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | samueldlightfoot | d0fa1ad9a0c5c45f83039551776fda48525669aa | 3fbb146f18d8860319fcfe0242ba001fbca59b2f | ```suggestion
* @return {@code this}
* @since 1.0.27
``` | violetagg | 32 |
reactor/reactor-netty | 2,622 | Support configurable DNS resolver cache | - Support user-provided DnsCache for NameResolverProvider | null | 2022-12-22 13:58:06+00:00 | 2023-01-03 07:38:28+00:00 | reactor-netty-core/src/main/java/reactor/netty/transport/NameResolverProvider.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | samueldlightfoot | d0fa1ad9a0c5c45f83039551776fda48525669aa | 3fbb146f18d8860319fcfe0242ba001fbca59b2f | ```suggestion
* @return the configured DNS resolver cache or null
* @since 1.0.27
```
| violetagg | 33 |
reactor/reactor-netty | 2,608 | Deregister connection pool metrics from `Micrometer` (or alternate registry) when disposing the connection pool | Deregister pool metrics from Micrometer (or alternate registry) in order to release resources when there is a large churn of connection pools and endpoints. | null | 2022-12-09 00:33:32+00:00 | 2022-12-12 08:11:46+00:00 | reactor-netty-core/src/main/java/reactor/netty/resources/ConnectionProvider.java | /*
* Copyright (c) 2018-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2018-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | manolama | dfb751d5890adcd10a3d653e6843a4fbf2fe4df2 | f53f4c6326098f1c57685644346ad5a9d4b2f245 | Let's make JAPICMP happy (I will remove the default implementation in Reactor Netty version 2.0.x where we can make this incompatible change)
```
Japicmp report was filtered and interpreted to find the following incompatibilities:
source incompatible change: **** MODIFIED INTERFACE: PUBLIC ABSTRACT STATIC reactor.... | violetagg | 34 |
reactor/reactor-netty | 2,608 | Deregister connection pool metrics from `Micrometer` (or alternate registry) when disposing the connection pool | Deregister pool metrics from Micrometer (or alternate registry) in order to release resources when there is a large churn of connection pools and endpoints. | null | 2022-12-09 00:33:32+00:00 | 2022-12-12 08:11:46+00:00 | reactor-netty-core/src/main/java/reactor/netty/resources/ConnectionProvider.java | /*
* Copyright (c) 2018-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2018-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | manolama | dfb751d5890adcd10a3d653e6843a4fbf2fe4df2 | f53f4c6326098f1c57685644346ad5a9d4b2f245 | Sounds good, thanks! | manolama | 35 |
reactor/reactor-netty | 2,608 | Deregister connection pool metrics from `Micrometer` (or alternate registry) when disposing the connection pool | Deregister pool metrics from Micrometer (or alternate registry) in order to release resources when there is a large churn of connection pools and endpoints. | null | 2022-12-09 00:33:32+00:00 | 2022-12-12 08:11:46+00:00 | reactor-netty-core/src/main/java/reactor/netty/resources/ConnectionProvider.java | /*
* Copyright (c) 2018-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2018-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | manolama | dfb751d5890adcd10a3d653e6843a4fbf2fe4df2 | f53f4c6326098f1c57685644346ad5a9d4b2f245 | I removed the default implementation in Reactor Netty 2 with PR #2613 | violetagg | 36 |
reactor/reactor-netty | 2,608 | Deregister connection pool metrics from `Micrometer` (or alternate registry) when disposing the connection pool | Deregister pool metrics from Micrometer (or alternate registry) in order to release resources when there is a large churn of connection pools and endpoints. | null | 2022-12-09 00:33:32+00:00 | 2022-12-12 08:11:46+00:00 | reactor-netty-core/src/test/java/reactor/netty/resources/PooledConnectionProviderCustomMetricsTest.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | manolama | dfb751d5890adcd10a3d653e6843a4fbf2fe4df2 | f53f4c6326098f1c57685644346ad5a9d4b2f245 | ```suggestion
triggerAcquisition(true, () -> new MeterRegistrarImpl(registered, deRegistered, null));
``` | violetagg | 37 |
reactor/reactor-netty | 2,608 | Deregister connection pool metrics from `Micrometer` (or alternate registry) when disposing the connection pool | Deregister pool metrics from Micrometer (or alternate registry) in order to release resources when there is a large churn of connection pools and endpoints. | null | 2022-12-09 00:33:32+00:00 | 2022-12-12 08:11:46+00:00 | reactor-netty-core/src/test/java/reactor/netty/resources/PooledConnectionProviderCustomMetricsTest.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | manolama | dfb751d5890adcd10a3d653e6843a4fbf2fe4df2 | f53f4c6326098f1c57685644346ad5a9d4b2f245 | Connection establishment is expected to fail always so we cannot return any Connection. The intention of this method is just to create the connection pool.
```
io.netty.channel.AbstractChannel$AnnotatedSocketException: Can't assign requested address: localhost/127.0.0.1:0
Caused by: java.net.BindException: Can't a... | violetagg | 38 |
reactor/reactor-netty | 2,608 | Deregister connection pool metrics from `Micrometer` (or alternate registry) when disposing the connection pool | Deregister pool metrics from Micrometer (or alternate registry) in order to release resources when there is a large churn of connection pools and endpoints. | null | 2022-12-09 00:33:32+00:00 | 2022-12-12 08:11:46+00:00 | reactor-netty-core/src/test/java/reactor/netty/resources/PooledConnectionProviderCustomMetricsTest.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | manolama | dfb751d5890adcd10a3d653e6843a4fbf2fe4df2 | f53f4c6326098f1c57685644346ad5a9d4b2f245 | ```suggestion
``` | violetagg | 39 |
reactor/reactor-netty | 2,608 | Deregister connection pool metrics from `Micrometer` (or alternate registry) when disposing the connection pool | Deregister pool metrics from Micrometer (or alternate registry) in order to release resources when there is a large churn of connection pools and endpoints. | null | 2022-12-09 00:33:32+00:00 | 2022-12-12 08:11:46+00:00 | reactor-netty-core/src/test/java/reactor/netty/resources/PooledConnectionProviderCustomMetricsTest.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | manolama | dfb751d5890adcd10a3d653e6843a4fbf2fe4df2 | f53f4c6326098f1c57685644346ad5a9d4b2f245 | ```suggestion
pool.acquire(config, ConnectionObserver.emptyListener(), remoteAddress, config.resolverInternal())
``` | violetagg | 40 |
reactor/reactor-netty | 2,608 | Deregister connection pool metrics from `Micrometer` (or alternate registry) when disposing the connection pool | Deregister pool metrics from Micrometer (or alternate registry) in order to release resources when there is a large churn of connection pools and endpoints. | null | 2022-12-09 00:33:32+00:00 | 2022-12-12 08:11:46+00:00 | reactor-netty-core/src/test/java/reactor/netty/resources/PooledConnectionProviderCustomMetricsTest.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | manolama | dfb751d5890adcd10a3d653e6843a4fbf2fe4df2 | f53f4c6326098f1c57685644346ad5a9d4b2f245 | ```suggestion
``` | violetagg | 41 |
reactor/reactor-netty | 2,608 | Deregister connection pool metrics from `Micrometer` (or alternate registry) when disposing the connection pool | Deregister pool metrics from Micrometer (or alternate registry) in order to release resources when there is a large churn of connection pools and endpoints. | null | 2022-12-09 00:33:32+00:00 | 2022-12-12 08:11:46+00:00 | reactor-netty-core/src/test/java/reactor/netty/resources/PooledConnectionProviderCustomMetricsTest.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | manolama | dfb751d5890adcd10a3d653e6843a4fbf2fe4df2 | f53f4c6326098f1c57685644346ad5a9d4b2f245 | Let's announce that `Nullable` is allowed.
```suggestion
MeterRegistrarImpl(
@Nullable AtomicBoolean registered,
@Nullable AtomicBoolean deRegistered,
@Nullable AtomicInteger customMetric) {
this.registered = registered;
this.deRegistered = deRegistered;
this.customMetric = customMetric... | violetagg | 42 |
reactor/reactor-netty | 2,608 | Deregister connection pool metrics from `Micrometer` (or alternate registry) when disposing the connection pool | Deregister pool metrics from Micrometer (or alternate registry) in order to release resources when there is a large churn of connection pools and endpoints. | null | 2022-12-09 00:33:32+00:00 | 2022-12-12 08:11:46+00:00 | reactor-netty-core/src/test/java/reactor/netty/resources/PooledConnectionProviderCustomMetricsTest.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | manolama | dfb751d5890adcd10a3d653e6843a4fbf2fe4df2 | f53f4c6326098f1c57685644346ad5a9d4b2f245 | ```suggestion
}
``` | violetagg | 43 |
reactor/reactor-netty | 2,608 | Deregister connection pool metrics from `Micrometer` (or alternate registry) when disposing the connection pool | Deregister pool metrics from Micrometer (or alternate registry) in order to release resources when there is a large churn of connection pools and endpoints. | null | 2022-12-09 00:33:32+00:00 | 2022-12-12 08:11:46+00:00 | reactor-netty-core/src/test/java/reactor/netty/resources/PooledConnectionProviderCustomMetricsTest.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | manolama | dfb751d5890adcd10a3d653e6843a4fbf2fe4df2 | f53f4c6326098f1c57685644346ad5a9d4b2f245 | ```suggestion
``` | violetagg | 44 |
reactor/reactor-netty | 2,608 | Deregister connection pool metrics from `Micrometer` (or alternate registry) when disposing the connection pool | Deregister pool metrics from Micrometer (or alternate registry) in order to release resources when there is a large churn of connection pools and endpoints. | null | 2022-12-09 00:33:32+00:00 | 2022-12-12 08:11:46+00:00 | reactor-netty-core/src/test/java/reactor/netty/resources/PooledConnectionProviderCustomMetricsTest.java | /*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | manolama | dfb751d5890adcd10a3d653e6843a4fbf2fe4df2 | f53f4c6326098f1c57685644346ad5a9d4b2f245 | Doh, thanks. I had meant to grab the `remoteAddress` from the connection but found it was externally accessible. | manolama | 45 |
reactor/reactor-netty | 2,608 | Deregister connection pool metrics from `Micrometer` (or alternate registry) when disposing the connection pool | Deregister pool metrics from Micrometer (or alternate registry) in order to release resources when there is a large churn of connection pools and endpoints. | null | 2022-12-09 00:33:32+00:00 | 2022-12-12 08:11:46+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/client/MicrometerHttp2ConnectionProviderMeterRegistrar.java | /*
* Copyright (c) 2021-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2021-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | manolama | dfb751d5890adcd10a3d653e6843a4fbf2fe4df2 | f53f4c6326098f1c57685644346ad5a9d4b2f245 | In `Http2ConnectionProvider` we need to override `reactor.netty.resources.PooledConnectionProvider#deRegisterDefaultMetrics`
```
@Override
protected void deRegisterDefaultMetrics(String id, SocketAddress remoteAddress) {
MicrometerHttp2ConnectionProviderMeterRegistrar.INSTANCE
.deRegisterMetrics(name(), ... | violetagg | 46 |
reactor/reactor-netty | 2,588 | Support context propagation for `ChannelHandler` | null | null | 2022-11-25 11:03:10+00:00 | 2022-11-28 15:29:59+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsHandler.java | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | violetagg | 5fb65cf7caece8b5f776618771c7b67aa83c957f | 106cbff810bcef4b810e0095bccdb77ef11d34eb | nit: tabulation from lines 155,156 are not aligned with the ones above (lines 152,152) | pderop | 47 |
reactor/reactor-netty | 2,588 | Support context propagation for `ChannelHandler` | null | null | 2022-11-25 11:03:10+00:00 | 2022-11-28 15:29:59+00:00 | reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsHandler.java | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | violetagg | 5fb65cf7caece8b5f776618771c7b67aa83c957f | 106cbff810bcef4b810e0095bccdb77ef11d34eb | fixed, thanks | violetagg | 48 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Change `request/response` to `request or response`. | Buzzardo | 49 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Add a period at the end. | Buzzardo | 50 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Add a period at the end. | Buzzardo | 51 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Add a period at the end. | Buzzardo | 52 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Add a period at the end. | Buzzardo | 53 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Remove `if needed`. (That's always implied with a See or See also link.) | Buzzardo | 54 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Change `initialises` to `initializes`. (Spring uses American spelling.)
Add a comma after `Zipkin`. (Spring uses serial commas - often called the Harvard comma or the Oxford comma.) | Buzzardo | 55 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Change `will be` to `are`. (Spring uses the indefinite present tense whenever possible.) | Buzzardo | 56 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Add a period at the end. | Buzzardo | 57 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Add `looks like` before the colon at the end. Spring avoids sentence fragments, so we need a verb (and the verb requires an object this time). | Buzzardo | 58 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
See <<observability-spans-http-client-response-span>>.
``` | violetagg | 59 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
See <<observability-spans-hostname-resolution-span>>.
``` | violetagg | 60 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
See <<observability-spans-connect-span>>.
``` | violetagg | 61 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
See <<observability-spans-tls-handshake-span>>.
``` | violetagg | 62 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
See the https://micrometer.io/docs/tracing#_micrometer_tracing_opentelemetry_setup[`Micrometer Tracing`] documentation for `OpenTelemetry` setup.
``` | violetagg | 63 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
<1> Initializes Brave, Zipkin, and the Observation registry.
``` | violetagg | 64 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
<2> Templated URIs are used as an URI tag value when possible.
``` | violetagg | 65 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
<3> Enables the built-in integration with Micrometer.
``` | violetagg | 66 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
The result in `Zipkin` looks like:
``` | violetagg | 67 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-client.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.client.HttpClient
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
| HTTP <HTTP METHOD> | Information and total time for the request.
``` | violetagg | 68 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-server.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Add a period at the end. | Buzzardo | 69 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-server.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Remove `if needed`. | Buzzardo | 70 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-server.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Change `initialises` to `initializes`. (Spring uses American spelling.)
Add a comma after `Zipkin`. (Spring uses serial commas - often called the Harvard comma or the Oxford comma.) | Buzzardo | 71 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-server.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Change `will be` to `are`. | Buzzardo | 72 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-server.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Add `looks like` before the colon at the end. Spring avoids sentence fragments, so we need a verb (and the verb requires an object this time). | Buzzardo | 73 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-server.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Add a period at the end. | Buzzardo | 74 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-server.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
See <<observability-spans-http-server-response-span>>.
``` | violetagg | 75 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-server.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
See the https://micrometer.io/docs/tracing#_micrometer_tracing_opentelemetry_setup[`Micrometer Tracing`] documentation for `OpenTelemetry` setup.
``` | violetagg | 76 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-server.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
<1> Initializes Brave, Zipkin, and the Observation registry.
``` | violetagg | 77 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-server.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
<2> Templated URIs are used as an URI tag value when possible.
``` | violetagg | 78 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-server.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
<3> Enables the built-in integration with Micrometer.
``` | violetagg | 79 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-server.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
The result in `Zipkin` looks like:
``` | violetagg | 80 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/http-server.adoc | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | :sourcedir: ./../../reactor-netty-http/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.http.server.HttpServer
... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
| <HTTP METHOD>_<URI> | Information and total time for the request.
``` | violetagg | 81 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-client.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Add a period at the end. | Buzzardo | 82 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-client.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Add a period at the end. | Buzzardo | 83 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-client.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Add a period at the end. | Buzzardo | 84 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-client.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Remove if needed. (That's always implied with a See or See also link.) | Buzzardo | 85 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-client.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Change `initialises` to `initializes`. (Spring uses American spelling.)
Add a comma after `Zipkin`. (Spring uses serial commas - often called the Harvard comma or the Oxford comma.) | Buzzardo | 86 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-client.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Add a period at the end. | Buzzardo | 87 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-client.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Add `looks like` before the colon at the end. Spring avoids sentence fragments, so we need a verb (and the verb requires an object this time). | Buzzardo | 88 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-client.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
See <<observability-spans-hostname-resolution-span>>.
``` | violetagg | 89 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-client.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
See <<observability-spans-connect-span>>.
``` | violetagg | 90 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-client.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
See <<observability-spans-tls-handshake-span>>.
``` | violetagg | 91 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-client.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
See the https://micrometer.io/docs/tracing#_micrometer_tracing_opentelemetry_setup[`Micrometer Tracing`] documentation for `OpenTelemetry` setup.
``` | violetagg | 92 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-client.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
<1> Initializes Brave, Zipkin, and the Observation registry.
``` | violetagg | 93 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-client.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
<2> Enables the built-in integration with Micrometer.
``` | violetagg | 94 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-client.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/client
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpClient
[[tcp-cli... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
The result in `Zipkin` looks like:
``` | violetagg | 95 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-server.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Add a period at the end. | Buzzardo | 96 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-server.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Remove if needed. (That's always implied with a See or See also link.) | Buzzardo | 97 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-server.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Add `looks like` before the colon at the end. Spring avoids sentence fragments, so we need a verb (and the verb requires an object this time). | Buzzardo | 98 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-server.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Change initialises to initializes. (Spring uses American spelling.)
Add a comma after Zipkin. (Spring uses serial commas - often called the Harvard comma or the Oxford comma.) | Buzzardo | 99 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-server.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Add a period at the end. | Buzzardo | 100 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-server.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
See <<observability-spans-tls-handshake-span>>.
``` | violetagg | 101 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-server.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
See the https://micrometer.io/docs/tracing#_micrometer_tracing_opentelemetry_setup[`Micrometer Tracing`] documentation for `OpenTelemetry` setup.
``` | violetagg | 102 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-server.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
<1> Initializes Brave, Zipkin, and the Observation registry.
``` | violetagg | 103 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-server.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
<2> Enables the built-in integration with Micrometer.
``` | violetagg | 104 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | docs/asciidoc/tcp-server.adoc | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | :sourcedir: ./../../reactor-netty-core/src/main/java
:examplesdir: ./../../reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/tcp/server
:javadoc: https://projectreactor.io/docs/netty/{project-version}/api
:nettyjavadoc: https://netty.io/4.1/api
:wirelogger: reactor.netty.tcp.TcpServer
[[tcp-ser... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
The result in `Zipkin` looks like:
``` | violetagg | 105 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | reactor-netty-http-brave/README.md | # Brave instrumentation for Reactor Netty HTTP
:exclamation: This module is **DEPRECATED** as of `Reactor Netty 1.1.0` and will be removed in `Reactor Netty 2.0.0`.
Prefer using the standard `HttpClient/HttpServer` metrics functionality which has integration with
[Micrometer Observation API](https://github.com/microme... | # Brave instrumentation for Reactor Netty HTTP
:exclamation: This module is **DEPRECATED** as of `Reactor Netty 1.1.0` and will be removed in `Reactor Netty 2.0.0`.
We prefer to use the standard `HttpClient/HttpServer` integration with [Micrometer Tracing](https://micrometer.io/docs/tracing).
This module contains tra... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | Change `Prefer using` to `We prefer to use`. | Buzzardo | 106 |
reactor/reactor-netty | 2,558 | Add documentation and examples for the integration with Micrometer Tracing | null | null | 2022-11-02 12:35:50+00:00 | 2022-11-03 08:47:53+00:00 | reactor-netty-http-brave/README.md | # Brave instrumentation for Reactor Netty HTTP
:exclamation: This module is **DEPRECATED** as of `Reactor Netty 1.1.0` and will be removed in `Reactor Netty 2.0.0`.
Prefer using the standard `HttpClient/HttpServer` metrics functionality which has integration with
[Micrometer Observation API](https://github.com/microme... | # Brave instrumentation for Reactor Netty HTTP
:exclamation: This module is **DEPRECATED** as of `Reactor Netty 1.1.0` and will be removed in `Reactor Netty 2.0.0`.
We prefer to use the standard `HttpClient/HttpServer` integration with [Micrometer Tracing](https://micrometer.io/docs/tracing).
This module contains tra... | violetagg | 58c021d9607a8a548fc4c14ffd3921bb0ae5db96 | 4ec59fee23d15f8ee8edbee8ade77e90a890bf18 | ```suggestion
We prefer to use the standard `HttpClient/HttpServer` integration with [Micrometer Tracing](https://micrometer.io/docs/tracing).
``` | violetagg | 107 |
reactor/reactor-netty | 2,394 | Remove the dependency to the context propagation library | @simonbasle @rstoyanchev @marcingrzejszczak PTAL | null | 2022-07-21 07:59:43+00:00 | 2022-07-21 18:02:13+00:00 | reactor-netty-core/build.gradle | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | a12264287763af2461717d8c18ec7c820954c2f5 | 6bf35e7290b08b215b45f61922681947017cb050 | Actually `micrometer-tracing` has a compile dependency on context-propagation | marcingrzejszczak | 108 |
reactor/reactor-netty | 2,394 | Remove the dependency to the context propagation library | @simonbasle @rstoyanchev @marcingrzejszczak PTAL | null | 2022-07-21 07:59:43+00:00 | 2022-07-21 18:02:13+00:00 | reactor-netty-core/build.gradle | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | a12264287763af2461717d8c18ec7c820954c2f5 | 6bf35e7290b08b215b45f61922681947017cb050 | Isn't it `implementation` and not `api`? | violetagg | 109 |
reactor/reactor-netty | 2,394 | Remove the dependency to the context propagation library | @simonbasle @rstoyanchev @marcingrzejszczak PTAL | null | 2022-07-21 07:59:43+00:00 | 2022-07-21 18:02:13+00:00 | reactor-netty-core/build.gradle | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2020-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | a12264287763af2461717d8c18ec7c820954c2f5 | 6bf35e7290b08b215b45f61922681947017cb050 | It's `implementation` | marcingrzejszczak | 110 |
reactor/reactor-netty | 2,394 | Remove the dependency to the context propagation library | @simonbasle @rstoyanchev @marcingrzejszczak PTAL | null | 2022-07-21 07:59:43+00:00 | 2022-07-21 18:02:13+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | a12264287763af2461717d8c18ec7c820954c2f5 | 6bf35e7290b08b215b45f61922681947017cb050 | So you're manually doing what the context propagation library already does, correct? | marcingrzejszczak | 111 |
reactor/reactor-netty | 2,394 | Remove the dependency to the context propagation library | @simonbasle @rstoyanchev @marcingrzejszczak PTAL | null | 2022-07-21 07:59:43+00:00 | 2022-07-21 18:02:13+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | a12264287763af2461717d8c18ec7c820954c2f5 | 6bf35e7290b08b215b45f61922681947017cb050 | Yeah I need only this from the context propagation library and there is no need to bring additional dependency. | violetagg | 112 |
reactor/reactor-netty | 2,394 | Remove the dependency to the context propagation library | @simonbasle @rstoyanchev @marcingrzejszczak PTAL | null | 2022-07-21 07:59:43+00:00 | 2022-07-21 18:02:13+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | a12264287763af2461717d8c18ec7c820954c2f5 | 6bf35e7290b08b215b45f61922681947017cb050 | could use the one from the TLAccessor:
```suggestion
public static final String OBSERVATION_KEY = ObservationThreadLocalAccessor.KEY;
```
reading a static constant field shouldn't lead to class initialization so it should work without `context-propagation` on the classpath | simonbasle | 113 |
reactor/reactor-netty | 2,394 | Remove the dependency to the context propagation library | @simonbasle @rstoyanchev @marcingrzejszczak PTAL | null | 2022-07-21 07:59:43+00:00 | 2022-07-21 18:02:13+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | a12264287763af2461717d8c18ec7c820954c2f5 | 6bf35e7290b08b215b45f61922681947017cb050 | @simonbasle The build fails with the below if I don't have dependency
```
> Task :reactor-netty-core:compileJava
error: cannot access ThreadLocalAccessor
class file for io.micrometer.context.ThreadLocalAccessor not found
Consult the following stack trace for details.
com.sun.tools.javac.code.Symbol$Comple... | violetagg | 114 |
reactor/reactor-netty | 2,394 | Remove the dependency to the context propagation library | @simonbasle @rstoyanchev @marcingrzejszczak PTAL | null | 2022-07-21 07:59:43+00:00 | 2022-07-21 18:02:13+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | a12264287763af2461717d8c18ec7c820954c2f5 | 6bf35e7290b08b215b45f61922681947017cb050 | (I would defer to @rstoyanchev's expertise here though, I might have been wrong about that) | simonbasle | 115 |
reactor/reactor-netty | 2,394 | Remove the dependency to the context propagation library | @simonbasle @rstoyanchev @marcingrzejszczak PTAL | null | 2022-07-21 07:59:43+00:00 | 2022-07-21 18:02:13+00:00 | reactor-netty-core/src/main/java/reactor/netty/Metrics.java | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | /*
* Copyright (c) 2019-2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | violetagg | a12264287763af2461717d8c18ec7c820954c2f5 | 6bf35e7290b08b215b45f61922681947017cb050 | interesting... nevermind then | simonbasle | 116 |
reactor/reactor-netty | 2,394 | Remove the dependency to the context propagation library | @simonbasle @rstoyanchev @marcingrzejszczak PTAL | null | 2022-07-21 07:59:43+00:00 | 2022-07-21 18:02:13+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/client/MicrometerHttpClientMetricsHandler.java | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | violetagg | a12264287763af2461717d8c18ec7c820954c2f5 | 6bf35e7290b08b215b45f61922681947017cb050 | I would suggest writing a test that actually uses context-propagation (which should in effect update the Reactor context with this specific key) and then you would reuse that entry that is stored by the key you've copy pasted yourself. That way if for some reason anything changes in the context propagation repo in a br... | marcingrzejszczak | 117 |
reactor/reactor-netty | 2,394 | Remove the dependency to the context propagation library | @simonbasle @rstoyanchev @marcingrzejszczak PTAL | null | 2022-07-21 07:59:43+00:00 | 2022-07-21 18:02:13+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/client/MicrometerHttpClientMetricsHandler.java | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | violetagg | a12264287763af2461717d8c18ec7c820954c2f5 | 6bf35e7290b08b215b45f61922681947017cb050 | Actually you don't even need that because the Key is there in `ObservationThreadLocalAccessor` which is in micrometer-core! | marcingrzejszczak | 118 |
reactor/reactor-netty | 2,394 | Remove the dependency to the context propagation library | @simonbasle @rstoyanchev @marcingrzejszczak PTAL | null | 2022-07-21 07:59:43+00:00 | 2022-07-21 18:02:13+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/client/MicrometerHttpClientMetricsHandler.java | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | violetagg | a12264287763af2461717d8c18ec7c820954c2f5 | 6bf35e7290b08b215b45f61922681947017cb050 | `micrometer-observation` has only optional dependency to the context propagation library. If I try to build my project without that dependency I'm receiving
```
> Task :reactor-netty-core:compileJava
error: cannot access ThreadLocalAccessor
class file for io.micrometer.context.ThreadLocalAccessor not found
C... | violetagg | 119 |
reactor/reactor-netty | 2,394 | Remove the dependency to the context propagation library | @simonbasle @rstoyanchev @marcingrzejszczak PTAL | null | 2022-07-21 07:59:43+00:00 | 2022-07-21 18:02:13+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/client/MicrometerHttpClientMetricsHandler.java | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | violetagg | a12264287763af2461717d8c18ec7c820954c2f5 | 6bf35e7290b08b215b45f61922681947017cb050 | let's go with the route of adding a test sanity checking the key is same as in `ObservationThreadLocalAccessor` 👍
I'll do the same in reactor-core-micrometer | simonbasle | 120 |
reactor/reactor-netty | 2,389 | Uses the new receiver and sender contexts | prerequisites
- [ ] https://github.com/micrometer-metrics/micrometer/pull/3293
- [ ] https://github.com/micrometer-metrics/tracing/pull/36 | null | 2022-07-15 14:09:12+00:00 | 2022-07-20 13:21:09+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsHandler.java | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | marcingrzejszczak | 7a9b894f73cebafef93abe0fae719324a400d703 | acdc2b304e6f45e9ef9a91cc87c32b38786b0f63 | ```suggestion
``` | violetagg | 121 |
reactor/reactor-netty | 2,389 | Uses the new receiver and sender contexts | prerequisites
- [ ] https://github.com/micrometer-metrics/micrometer/pull/3293
- [ ] https://github.com/micrometer-metrics/tracing/pull/36 | null | 2022-07-15 14:09:12+00:00 | 2022-07-20 13:21:09+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/MicrometerHttpServerMetricsHandler.java | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | marcingrzejszczak | 7a9b894f73cebafef93abe0fae719324a400d703 | acdc2b304e6f45e9ef9a91cc87c32b38786b0f63 | ```suggestion
``` | violetagg | 122 |
reactor/reactor-netty | 2,357 | Capture HTTP/2 server active stream metrics | Capture H2 active streams metrics for HttpServer.
Issue: https://github.com/reactor/reactor-netty/issues/2356 | null | 2022-07-05 21:47:54+00:00 | 2022-07-07 06:34:23+00:00 | reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerMeters.java | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | /*
* Copyright (c) 2022 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unl... | samueldlightfoot | f5522a71a6b203a729e8ea5b53c440406f6fe4df | 3a14fc6d638e4fa75d35a047897fa2a555ea8444 | for the existing http server metrics, we currently have for example:
- reactor.netty.http.server.connections.**active**
- reactor.netty.http.server.connections.**total**
etc ...
We use the same prefix, followed by the meaning of the meter (active, total, etc ...)
so, for consistency reasons, wouldn't it be b... | pderop | 123 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.